From nobody Mon Jun 8 09:50:05 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1780525924; cv=none; d=zohomail.com; s=zohoarc; b=HAGK9RPI7pWmEoGbcrh5qN77IH2Yq+8dwXvBIdKnatMjp8uk89wRpXG9pyKQL5xHL7G+HXI0BaIHusAKPAxCDTjzu2X6EE+AUt/Iycrwuff3VzV/IEavNh4GbF2jX0wAJ6cjcYDsZ/YtIZacz/00a6CZgYHaR1CsJhSK2aingJY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780525924; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=7Qeo7Y2gRYxrMiI/rFV1bSRa4NhH7u6R/B+Va6qNK70=; b=EmhGWlO/fv9CmPBn23JlGDRLQ5euYvT+A//4syoWjaSUiuiuUXh1ZSMZUK9+6AbmWXPzRTHt/LAFEBnJwNvbXtfZyH2nfme7leFQI79tObMnv9I1HxsrBtfjO9hXalFkAS/0UXcYtBUA/dUsC/3Je6L9jsSkzy9+Fz8pQaLUO9U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780525924774648.3572909444241; Wed, 3 Jun 2026 15:32:04 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wUu7D-0007XG-BY; Wed, 03 Jun 2026 18:31:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wUu7C-0007Wz-J4 for qemu-devel@nongnu.org; Wed, 03 Jun 2026 18:31:10 -0400 Received: from smtp-out1.suse.de ([195.135.223.130]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wUu7B-0005vi-0G for qemu-devel@nongnu.org; Wed, 03 Jun 2026 18:31:10 -0400 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9D6A86A80E; Wed, 3 Jun 2026 22:31:06 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DA347779A7; Wed, 3 Jun 2026 22:31:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 4JdjKimrIGpRQgAAD6G6ig (envelope-from ); Wed, 03 Jun 2026 22:31:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780525866; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=7Qeo7Y2gRYxrMiI/rFV1bSRa4NhH7u6R/B+Va6qNK70=; b=xArdlvHBzylEDo7Y0MLANmHXUrZ2OxDuOnJ6J18rBFrDVk3bxr34+KA9Ok+2uWoLTVE8za S+JuTllLc2e1GD+l0JFJBjg705esQ8JZ46om6Cpb18y3oy95eTdqG9qwvSCdysBe92AFsk Qwu0AetLutJqAJD2EIaNIfWwbJaVRIg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780525866; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=7Qeo7Y2gRYxrMiI/rFV1bSRa4NhH7u6R/B+Va6qNK70=; b=XX4q249UJU40JcHNJEFc3x70Q6UedDAbCb4EBYwDJ8F8pJD+BMnS7Feairiw+X+kMfJkNK TtJg+rL+dozjO5Dw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780525866; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=7Qeo7Y2gRYxrMiI/rFV1bSRa4NhH7u6R/B+Va6qNK70=; b=xArdlvHBzylEDo7Y0MLANmHXUrZ2OxDuOnJ6J18rBFrDVk3bxr34+KA9Ok+2uWoLTVE8za S+JuTllLc2e1GD+l0JFJBjg705esQ8JZ46om6Cpb18y3oy95eTdqG9qwvSCdysBe92AFsk Qwu0AetLutJqAJD2EIaNIfWwbJaVRIg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780525866; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=7Qeo7Y2gRYxrMiI/rFV1bSRa4NhH7u6R/B+Va6qNK70=; b=XX4q249UJU40JcHNJEFc3x70Q6UedDAbCb4EBYwDJ8F8pJD+BMnS7Feairiw+X+kMfJkNK TtJg+rL+dozjO5Dw== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Richard Henderson Subject: [PATCH] tcg: Silence ubsan error on tcg_splitwx_diff causing overflow Date: Wed, 3 Jun 2026 19:30:48 -0300 Message-ID: <20260603223048.2574846-1-farosas@suse.de> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.80 X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:email,suse.de:mid]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCPT_COUNT_TWO(0.00)[2]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[] Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=195.135.223.130; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1780525928491158500 Content-Type: text/plain; charset="utf-8" UBSAN complains: runtime error: addition of unsigned offset to 0x7bc06e1f5000 overflowed to 0x7bc02e1f5000 Cast the pointer to unsigned integer to perform the arithmetic and silence the error. Signed-off-by: Fabiano Rosas --- tcg/region.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tcg/region.c b/tcg/region.c index 5d4be1453b..b405fa2ecb 100644 --- a/tcg/region.c +++ b/tcg/region.c @@ -112,7 +112,7 @@ const void *tcg_splitwx_to_rx(void *rw) /* Pass NULL pointers unchanged. */ if (rw) { g_assert(in_code_gen_buffer(rw)); - rw +=3D tcg_splitwx_diff; + rw =3D (void *)((uintptr_t)rw + tcg_splitwx_diff); } return rw; } @@ -121,7 +121,7 @@ void *tcg_splitwx_to_rw(const void *rx) { /* Pass NULL pointers unchanged. */ if (rx) { - rx -=3D tcg_splitwx_diff; + rx =3D (void *)((uintptr_t)rx - tcg_splitwx_diff); /* Assert that we end with a pointer in the rw region. */ g_assert(in_code_gen_buffer(rx)); } @@ -200,7 +200,7 @@ static struct tcg_region_tree *tc_ptr_to_region_tree(co= nst void *p) * a signal handler over which the caller has no control. */ if (!in_code_gen_buffer(p)) { - p -=3D tcg_splitwx_diff; + p =3D (void *)((uintptr_t)p - tcg_splitwx_diff); if (!in_code_gen_buffer(p)) { return NULL; } @@ -763,8 +763,9 @@ void tcg_region_init(size_t tb_size, int splitwx, unsig= ned max_threads) /* Request large pages for the buffer and the splitwx. */ qemu_madvise(region.start_aligned, region.total_size, QEMU_MADV_HUGEPA= GE); if (tcg_splitwx_diff) { - qemu_madvise(region.start_aligned + tcg_splitwx_diff, - region.total_size, QEMU_MADV_HUGEPAGE); + uintptr_t buf_rx =3D (uintptr_t)region.start_aligned + tcg_splitwx= _diff; + + qemu_madvise((void *)buf_rx, region.total_size, QEMU_MADV_HUGEPAGE= ); } =20 /* --=20 2.53.0