From nobody Mon Jun 8 04:25:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780384208; cv=none; d=zohomail.com; s=zohoarc; b=ZTY6+1pyToggQsvjme3i4GBCXE3nfMC6aKKQNbSG11r3wGAELTCj6EeYCGgitmKR0CzGgJXJ38fxvVufn6zehJLvu6X++Ftq0PoWARXJCVQxFtqF/6WCVQ61wPRsfxx7qkV+V7VRUY1NzQipOkbw5Obpo7KcfYQY30Ey3PJV6H0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780384208; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=rG5FbdDWSl7zdC04QlO/yrV5wJ/+oGdBFMHaAU6dx+I=; b=LRqxzW2GuY6QL3mpK8cgViBaznS3xNKgTk+AFLwlzLg8SMpTqj8z+Xrjv5AWob4cqxxnJ3M1+AYP9Ieh+8Y8vg/U4b0biBG7yjLZkTv4isGY+49ducwnqxJsGA7JQwdBcdTevg3xyrptLG3a6Xdhn137ZXhyzUqaYxtrFzzJQNY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780384208608813.0304215572162; Tue, 2 Jun 2026 00:10:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wUJFe-0007de-1U; Tue, 02 Jun 2026 03:09:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wUJFb-0007dQ-Fh for qemu-devel@nongnu.org; Tue, 02 Jun 2026 03:09:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wUJFZ-0003pK-R1 for qemu-devel@nongnu.org; Tue, 02 Jun 2026 03:09:23 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-134-jXj0v3-nOqGyeOW3605nAQ-1; Tue, 02 Jun 2026 03:09:17 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 058F6195609D; Tue, 2 Jun 2026 07:09:16 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.44.48.177]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 154121956095; Tue, 2 Jun 2026 07:09:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780384160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rG5FbdDWSl7zdC04QlO/yrV5wJ/+oGdBFMHaAU6dx+I=; b=BJgkrj5UGxg2qLs3X7PE7DvKZsgVeFLXHxNSY4oa/IkU2hLqR7vpXJc+QHkDFlM0RWkFOR /wB4rQbMqWfid3BWH33AZvHcIR1gR2u7mGpMjIZxboytIpik3rnURgT4PB+Zal+FtjS7dv bhGZToCwvJO6aQlPvy3F3DsBzKf0yvE= X-MC-Unique: jXj0v3-nOqGyeOW3605nAQ-1 X-Mimecast-MFC-AGG-ID: jXj0v3-nOqGyeOW3605nAQ_1780384156 From: Mario Casquero To: qemu-devel@nongnu.org Cc: clg@redhat.com, alex@shazbot.org, Mario Casquero Subject: [PATCH v2] vfio/pci: Initialize rom_read_failed in vfio_pci_load_rom() Date: Tue, 2 Jun 2026 09:08:57 +0200 Message-ID: <20260602070857.356526-1-mcasquer@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=mcasquer@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780384209796158500 When vfio_device_get_region_info() fails in vfio_pci_load_rom(), the function returns without setting vdev->rom_read_failed to true, and without allocating vdev->rom. This leaves vdev->rom as NULL. Signed-off-by: Mario Casquero Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/vfio/pci.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 9c06b25e63..9df04fa2d7 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -1027,7 +1027,7 @@ static void vfio_update_msi(VFIOPCIDevice *vdev) } } =20 -static void vfio_pci_load_rom(VFIOPCIDevice *vdev) +static bool vfio_pci_load_rom(VFIOPCIDevice *vdev) { VFIODevice *vbasedev =3D &vdev->vbasedev; struct vfio_region_info *reg_info =3D NULL; @@ -1041,7 +1041,7 @@ static void vfio_pci_load_rom(VFIOPCIDevice *vdev) =20 if (ret !=3D 0) { error_report("vfio: Error getting ROM info: %s", strerror(-ret)); - return; + return false; } =20 trace_vfio_pci_load_rom(vbasedev->name, (unsigned long)reg_info->size, @@ -1052,12 +1052,11 @@ static void vfio_pci_load_rom(VFIOPCIDevice *vdev) vdev->rom_offset =3D reg_info->offset; =20 if (!vdev->rom_size) { - vdev->rom_read_failed =3D true; error_report("vfio-pci: Cannot read device rom at %s", vbasedev->n= ame); error_printf("Device option ROM contents are probably invalid " "(check dmesg).\nSkip option ROM probe with rombar=3D0= , " "or load from file with romfile=3D\n"); - return; + return false; } =20 vdev->rom =3D g_malloc(size); @@ -1113,6 +1112,8 @@ static void vfio_pci_load_rom(VFIOPCIDevice *vdev) data[6] =3D -csum; } } + + return true; } =20 /* "Raw" read of underlying config space. */ @@ -1146,7 +1147,7 @@ static uint64_t vfio_rom_read(void *opaque, hwaddr ad= dr, unsigned size) =20 /* Load the ROM lazily when the guest tries to read it */ if (unlikely(!vdev->rom && !vdev->rom_read_failed)) { - vfio_pci_load_rom(vdev); + vdev->rom_read_failed =3D !vfio_pci_load_rom(vdev); } =20 memcpy(&val, vdev->rom + addr, --=20 2.54.0