From nobody Mon Jun 8 04:25:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1780378291; cv=pass; d=zohomail.com; s=zohoarc; b=SjVLYC4CLxOvEe32rFLdE0iCR87gpPOylELixvl+oiiH0NGa3K644YPnlmboFIw36Bfg5sCNiMwYAEowOh1BdmeRuNZfQqm8H6i3IOIudGWTHwT5N3cA5doZCT6ATdAskYxmet7GMGoxQyfEDovox6UegIEN9TfedKPrvq56J7Y= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780378291; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=5dkBRuDh3Q0xUeKqDfKX/28puNKG0/vbDS3aJweapr4=; b=VWEgN/Uws6V1QKCldW2NyvGdjsdz5pRXNnesHbuVjPgX6PWDD+1IPa4M6cOFrgB7cksOo1Xhx1Cu/HHOb583ddctIVDjwrbUUw96h+4w5dxOqL4O5OPkRz2r4wBcL82VbrF1I3B9DaeRJDuvAB7pg/1IxwBWlypqspLw/K1zmYY= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780378291184687.5626732197092; Mon, 1 Jun 2026 22:31:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wUHgI-0003ww-4j; Tue, 02 Jun 2026 01:28:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wUHgG-0003w0-BJ; Tue, 02 Jun 2026 01:28:48 -0400 Received: from mail-japaneastazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c405::7] helo=TYDPR03CU002.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wUHgC-0002gD-Ua; Tue, 02 Jun 2026 01:28:47 -0400 Received: from TYZPR06MB4980.apcprd06.prod.outlook.com (2603:1096:400:1cc::10) by SI2PR06MB5411.apcprd06.prod.outlook.com (2603:1096:4:1ee::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Tue, 2 Jun 2026 05:28:30 +0000 Received: from TYZPR06MB4980.apcprd06.prod.outlook.com ([fe80::ea8a:7cb7:4822:2fb3]) by TYZPR06MB4980.apcprd06.prod.outlook.com ([fe80::ea8a:7cb7:4822:2fb3%5]) with mapi id 15.21.0071.015; Tue, 2 Jun 2026 05:28:29 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xdH8eRauh27mqIIskwNYQzyK3660lOdDb8pWTLn5PxvZEw2Wi7wE4dGjX57QrhN+DwDRsDUpVQ0zMDNuBhtQcGKw9BIw6nKzvaMo2xfUulZGo7CfIW1DxordM+QLTltAnWtkAKI13K63VHJMZMYcWRd2cyHHZru3ik+gE8WAHPfDcc6+neeyNPQX9/QD0u3FdaRlCGcOu2eH83ym6JBYYCItE51bIArtOtDtOM+OiQCZ3HSdVZOIPKu5wkwK9SeuYLekfP4SVhhOAUaZPLQ49OAfiZzPVXA2vjYnmPB93eib3e6uPKzdHCNdPM6LuVg3MT24/Ce5leLFdMLBBN/MYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5dkBRuDh3Q0xUeKqDfKX/28puNKG0/vbDS3aJweapr4=; b=H6+ky4G7AiJvivMvZ7/iQqvnExzrITGw86JAGDK292YpxUUMoslUXH2rVDPKevmRDZXge8LqOrrH6p6srdAN1XKJcooJVYGu2HqLc9tA8c1a96cpEon9FvZAymRI1YsP03KL+sswUznkQBSY1NZFsenqmzMAXnDwP5CNofGLNkrUKU3M2WQeHJxh2SGMZcgrY5kVIbFfev+t145Kl5n0ZdnhDFaT4hLAauc5UikhTO3bfBVERV/tN/s2TOJX+4akyF1PJ38gfYamt26mK/xz2DAKzAElYC2tN/CHaOM1qf553RPmYsd6YM2qX5jxX0av/FJ8m9g6Gmvyb2ocox9ezg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5dkBRuDh3Q0xUeKqDfKX/28puNKG0/vbDS3aJweapr4=; b=F9FY5qfms6nhmbJ5qz2yXVW3gJa3v35rS5pk9v8nwMSwi9qHCrCcTEphFmEDPubfce9XeIRUi6grc2So26dXqXeKSEyXHEWK2UNY9eGmEz7PuIMWk0GZrB0UCkwD+tf3gD53b1zvoGx20HlFS7xltrO5r+RlKp/wq8jxqpb1W0vgxSZtXfUnNWx3z1RJ0IjyUEE5U3m/MWX8LrGSFFT8PZDE4SpA+8gc611+dIOuawOiFgd3MOjgMzHt/va85dR8EG+RsaxQz0ToO+Edz8BP38i4fAeysRNyWFEqhLtSHSOJdcE7dSw+OvSeCbx33979wnx89DKHHXHsS5b6BYlQYQ== From: Jamin Lin To: =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee Subject: [PATCH v2 01/10] hw/i2c/aspeed_i2c: Introduce dma_addr_lo_mask to unify DMA address handling Thread-Topic: [PATCH v2 01/10] hw/i2c/aspeed_i2c: Introduce dma_addr_lo_mask to unify DMA address handling Thread-Index: AQHc8lClc/pwAK0NSE21bh5LfoHzoQ== Date: Tue, 2 Jun 2026 05:28:29 +0000 Message-ID: <20260602052827.1535299-2-jamin_lin@aspeedtech.com> References: <20260602052827.1535299-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260602052827.1535299-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYZPR06MB4980:EE_|SI2PR06MB5411:EE_ x-ms-office365-filtering-correlation-id: 525038bd-fc05-4e99-3d6c-08dec067c7c5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|56012099006|18002099003|22082099003|38070700021; x-microsoft-antispam-message-info: 1bono6VzOFNt/5Fhp54OV8Z6y0WxcKHFPP2inxOV3vVVdTJhgwdIrOOpt6VzKiv/Z4RwSfM1xIdNIv+9NlQdR79/xa8GKo0GY6quOTdAGeZZjq0mTFdCxBtwyRafqkyq/BjdffVmnoUhrUn7d1kAaWNeMVY6oQC438wia9FqncuC2rbHG9I2gI9IpkVOVnmhGlrEg3aIuPXs3cKcV8IlRSyph6jndHHL8NQs/yvcnNMcZJXyZMdKdticZJ+eB1j3697VPIxtt8WOwcx+Qex7cqh51GcZmVxo19wAIFvwsERRa+lhm4wK613V4JUZrmrqfTcJDgtcoOBpBstEPouh2dfcZgbOghREZeKRudr/3vCjAzfnjO+vtSfTJj10YoWoRO5avvIxUai/oxsIIoXAPsoGttYw+/mtl8bkfxVezv29q+guSp3JKjF0m55BGuziR2UAHX82KsD/MCyBVpkz8RCCNXAwWZvXHS2vIvecRprQLTVcqiVnZkPgsLytbsh+54qDMp2juHn4Upc4UgZxFuDthwDlCEHIpogXeaEhB6SFA2IS5SAJi2PREEMAutRWHSL6gpDDzJyI38nHUkfrjJuxpo5YmFb9E2xeh7lNEzqZua7yumlG20hES/JwCZTbykg8ngw8MmkMiYgkmsKWt2pTu7+f6WqxM8iG1+fPAFS9Ooq/iQlNJnTog0zkI4jKKKpLUFFMY8wPRGLKZSUVl2xbS10dFs1ft0uIwH/Dbxk/qfN9pMlBlE5V9FqWNakW x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYZPR06MB4980.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(56012099006)(18002099003)(22082099003)(38070700021); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?ZFcu2fJFnyQA2pV07lHw7UQVrfL7rcXAM2nx2kjGOI24QaVzTqpwTA8fFJ?= =?iso-8859-1?Q?sEb3gy6QzPY2MNcHSaegiOCxO8Pig5U1184eIJjCxIijPE3rgr4Zg5LkFb?= =?iso-8859-1?Q?xpynCMFTJs7L17+9gEQrRuOjBv8wsDm07DrgQhMsohEkSYXlUxnfExKj5M?= =?iso-8859-1?Q?PssAFWg26M5dFpWST+DYbSZ+zcVfWGDwdpJ+oUW4HN4Sh5wK0Bt0lHnfyI?= =?iso-8859-1?Q?TTzedbLEfrvmjZyMCTCtfLktN0COPHjnwnhj98Lk1qEddWSPcCaoO5b4+g?= =?iso-8859-1?Q?3CJBM0PlWOP93ByakvjKN/ibpBUA9UCbxCvMdi9RNa0ExxJqzGxagKwIH/?= =?iso-8859-1?Q?bvxvxWRJyFq9G0f2AlAx9V+V+wtzUmvWByyccKO1DZ8oIk6ZW2X+jwFa2/?= =?iso-8859-1?Q?0lLgpB8ThF2ra4B+noAYX0cJXZmgPZJvf8qyuKwzkJeJk3dD+/wx5epKVQ?= =?iso-8859-1?Q?BURNySJPIcIH4sfWdBKoYQgKwQBC2QU3Re8lPHzzzdZFESl0XJqVhfcB5z?= =?iso-8859-1?Q?qT7eOX3LIon0mnLbUSqc/FFkYlFS12V5yAZSJMHrHef8aFg86sEp3NxKwU?= =?iso-8859-1?Q?LYLaTNIjhOGygeaDqdgYiLPLy09CPE5HBaOId7cwaqPRotwzR1TVLnQptI?= =?iso-8859-1?Q?Rt8AEVCDiQjNM7zKN9Q9YcH1u+HpSyMKCxG8sE686GAOFAXj9dLXupOvax?= =?iso-8859-1?Q?MUpobdQTteyibU7Vn5oR0vL8ZARvyEuCCUQqgt7aNM9K9VHaneuVVb/zk0?= =?iso-8859-1?Q?L3GLcvm0sgDlhuFX3StdEVgeYi4KX8oeuZeAjk6D6ZH8tjK4E7+qtmGNok?= =?iso-8859-1?Q?Pb+Yq3L1F+0Do7yutEJDa/o1BHb2eBybzz38nLLyahBfaXg2MDUd66eeVJ?= =?iso-8859-1?Q?Y7xtxxkjksCDmKkc33Q7oLPxwHCpkn2ORqWZ7ioTN4CkqNDCqgWCr1swz7?= =?iso-8859-1?Q?8EhsGJnAP2BDd5RawtywaNZoNKfJReammULjtPW9sfbppBXjgZxSAzKkf9?= =?iso-8859-1?Q?GwHULZNl0FvexV2PvY3ot6NdKHzoZ21jjKMm/HqGKhT+8fItAXVaVYNbkQ?= =?iso-8859-1?Q?7DgSusc5LcmDf8lSi/RlJON79uXJT/dBH86LL6LGVh3cUGtvhf457I0QFa?= =?iso-8859-1?Q?efw7dF2QocCP7jyu9GHd1mpgI3EgVn44xhW5vSv2kA/+mWDsaeNw6w31Gc?= =?iso-8859-1?Q?M9nt18D4rP/9C3xjUldldkQDN8HzttbAwyrJOQ1bxLqYO0cVYbi1R/xkDb?= =?iso-8859-1?Q?bKz+K1DRMYDoAQzIrANLiDabxS79xmfIksESEtSAiNtu0JGbEshInIxVyj?= =?iso-8859-1?Q?DvzCcPP2s1HA2UQmJ9NTtCphsTJJR8gOEVf+WwqhUvV2aoL2uLB1EbHoNv?= =?iso-8859-1?Q?gvXFLjZ8itn0dQxiXdhOxbQrTAFcw2l1f3LyoxK9ZQ5nCtKYC8BGZNm6Z8?= =?iso-8859-1?Q?AqgTVhELqoMabZwPFEDTGpvvJPDHzL97Gr82WByPGtXdzp+mt15axEkk47?= =?iso-8859-1?Q?wDKLX2hBd5LJMu+7ScGEv8Wm8B6J+ZmlX1haHOG7AfeS1me8aLco1isxn2?= =?iso-8859-1?Q?r+hPtWB7RGqm3KxnVUzVyH0rMnTckapl/x0wvX2KTUx0a6gOC2GR+BlY4t?= =?iso-8859-1?Q?SjwWtYRJg7e4QlHoKTCNksPXuWAWhzVOculoM3Ctso5uk+iawy2wJFdeup?= =?iso-8859-1?Q?kIPRiPKMO+rJCzsYS4ujCZrBc4BS32KXwJ7Se4M7CCTlNw7/2et18cFLCm?= =?iso-8859-1?Q?816dl2L9a9Bxigj1/+ETZZQSoMhP0l5xlM5uxxQPbQcCg761CJLXTRQuxc?= =?iso-8859-1?Q?dI4qfkWbxA=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: UdpFaIaBA7xJI58keZdqMDRXLqnxpCs39Gbc0S0mg6F34edoOj4LqEEOIjDidnBaj6Zc+Vd5Ily9nkA7IJkC3PVxIyo8CJk1lLte3R+1XrQoH5RYfm5XBUZj52BBcJeLbjZHNgppAwYaCE7npI74m4W3JhUsqQ8Ie6T10R1RbMsLdMGAFLS90n5TjMeREKWBGrDIUAy9jz9QfZfmUR0rI2bRNvFiskNQXIimCSa1DqbZIh4sHZSJhrRz2vcS0gLlTu1Tvep4OlfUCE8qoUea/9PL9HidOEmddZvt/Nu2vxnpsRqa2QrRy0yS2Qirxjixy7F9f8zyvOacK8OubugKoA== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4980.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 525038bd-fc05-4e99-3d6c-08dec067c7c5 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2026 05:28:29.8389 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: euTbJA1bOCPnJztMC6YuWFQZRuwv+6/6jbO9syQSVxrL2QdVJHvfMYDaxQgM+k4aPSbP/jAUrbxjifBmwoyyUzBRSSlEMkBRkARqnv4IfzQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5411 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c405::7; envelope-from=jamin_lin@aspeedtech.com; helo=TYDPR03CU002.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1780378292497154100 Content-Type: text/plain; charset="utf-8" The Aspeed I2C controller has two register layouts. The AST2500 uses the old mode with a single DMA address register (I2CD_DMA_= ADDR) where the address is 4-byte aligned and masked to 0x3ffffffc. From AST2600 onwards, the new mode provides separate master TX/RX and slave= RX DMA address registers (I2CM_DMA_TX_ADDR, I2CM_DMA_RX_ADDR, I2CS_DMA_RX_ADDR) with different address widths per SoC: AST2600 (new mode): 0x7fffffff - bits[30:0] AST1030 (new mode): 0x7fffffff - bits[30:0] AST1060 (new mode): 0x7fffffff - bits[30:0] AST2700 (new mode): 0xffffffff - bits[31:0] Introduce dma_addr_lo_mask as a per-class attribute and apply it uniformly when storing DMA address register writes and when loading the address into dma_dram_offset for both master and slave paths. This replaces the previous FIELD_EX32 extractions (which incorrectly stripped bit 31 on AST2700) and the hardcoded 0x3ffffffc literal in the old-mode path. Fixes: 1809ab6a67359e0876981cd05d2a50b2843eabad ("hw/i2c/aspeed: Add AST270= 0 support") Signed-off-by: Jamin Lin --- include/hw/i2c/aspeed_i2c.h | 5 +---- hw/i2c/aspeed_i2c.c | 22 +++++++++++++--------- 2 files changed, 14 insertions(+), 13 deletions(-) diff --git a/include/hw/i2c/aspeed_i2c.h b/include/hw/i2c/aspeed_i2c.h index d42cb4865a..1fc229f699 100644 --- a/include/hw/i2c/aspeed_i2c.h +++ b/include/hw/i2c/aspeed_i2c.h @@ -209,13 +209,9 @@ REG32(I2CS_DMA_LEN, 0x2c) FIELD(I2CS_DMA_LEN, TX_BUF_LEN_W1T, 15, 1) FIELD(I2CS_DMA_LEN, TX_BUF_LEN, 0, 11) REG32(I2CM_DMA_TX_ADDR, 0x30) - FIELD(I2CM_DMA_TX_ADDR, ADDR, 0, 31) REG32(I2CM_DMA_RX_ADDR, 0x34) - FIELD(I2CM_DMA_RX_ADDR, ADDR, 0, 31) REG32(I2CS_DMA_TX_ADDR, 0x38) - FIELD(I2CS_DMA_TX_ADDR, ADDR, 0, 31) REG32(I2CS_DMA_RX_ADDR, 0x3c) - FIELD(I2CS_DMA_RX_ADDR, ADDR, 0, 31) REG32(I2CS_DEV_ADDR, 0x40) REG32(I2CM_DMA_LEN_STS, 0x48) FIELD(I2CM_DMA_LEN_STS, RX_LEN, 16, 13) @@ -303,6 +299,7 @@ struct AspeedI2CClass { bool has_share_pool; uint64_t mem_size; bool has_dma64; + uint32_t dma_addr_lo_mask; }; =20 static inline bool aspeed_i2c_is_new_mode(AspeedI2CState *s) diff --git a/hw/i2c/aspeed_i2c.c b/hw/i2c/aspeed_i2c.c index 4a6732a185..a6b44174f5 100644 --- a/hw/i2c/aspeed_i2c.c +++ b/hw/i2c/aspeed_i2c.c @@ -236,7 +236,7 @@ static void aspeed_i2c_set_tx_dma_dram_offset(AspeedI2C= Bus *bus) value =3D bus->regs[R_I2CM_DMA_TX_ADDR]; bus->dma_dram_offset =3D deposit64(bus->dma_dram_offset, 0, 32, - FIELD_EX32(value, I2CM_DMA_TX_ADDR, ADDR)); + value & aic->dma_addr_lo_mask); if (aic->has_dma64) { value =3D bus->regs[R_I2CM_DMA_TX_ADDR_HI]; bus->dma_dram_offset =3D @@ -246,7 +246,7 @@ static void aspeed_i2c_set_tx_dma_dram_offset(AspeedI2C= Bus *bus) } else { value =3D bus->regs[R_I2CD_DMA_ADDR]; bus->dma_dram_offset =3D deposit64(bus->dma_dram_offset, 0, 32, - value & 0x3ffffffc); + value & aic->dma_addr_lo_mask); } } =20 @@ -261,7 +261,7 @@ static void aspeed_i2c_set_rx_dma_dram_offset(AspeedI2C= Bus *bus) value =3D bus->regs[R_I2CM_DMA_RX_ADDR]; bus->dma_dram_offset =3D deposit64(bus->dma_dram_offset, 0, 32, - FIELD_EX32(value, I2CM_DMA_RX_ADDR, ADDR)); + value & aic->dma_addr_lo_mask); if (aic->has_dma64) { value =3D bus->regs[R_I2CM_DMA_RX_ADDR_HI]; bus->dma_dram_offset =3D @@ -271,7 +271,7 @@ static void aspeed_i2c_set_rx_dma_dram_offset(AspeedI2C= Bus *bus) } else { value =3D bus->regs[R_I2CD_DMA_ADDR]; bus->dma_dram_offset =3D deposit64(bus->dma_dram_offset, 0, 32, - value & 0x3ffffffc); + value & aic->dma_addr_lo_mask); } } =20 @@ -735,12 +735,10 @@ static void aspeed_i2c_bus_new_write(AspeedI2CBus *bu= s, hwaddr offset, aspeed_i2c_bus_raise_interrupt(bus); break; case A_I2CM_DMA_TX_ADDR: - bus->regs[R_I2CM_DMA_TX_ADDR] =3D FIELD_EX32(value, I2CM_DMA_TX_AD= DR, - ADDR); + bus->regs[R_I2CM_DMA_TX_ADDR] =3D value & aic->dma_addr_lo_mask; break; case A_I2CM_DMA_RX_ADDR: - bus->regs[R_I2CM_DMA_RX_ADDR] =3D FIELD_EX32(value, I2CM_DMA_RX_AD= DR, - ADDR); + bus->regs[R_I2CM_DMA_RX_ADDR] =3D value & aic->dma_addr_lo_mask; break; case A_I2CM_DMA_LEN: w1t =3D FIELD_EX32(value, I2CM_DMA_LEN, RX_BUF_LEN_W1T) || @@ -1375,6 +1373,8 @@ static void aspeed_i2c_class_init(ObjectClass *klass,= const void *data) static int aspeed_i2c_bus_new_slave_event(AspeedI2CBus *bus, enum i2c_event event) { + AspeedI2CClass *aic =3D ASPEED_I2C_GET_CLASS(bus->controller); + switch (event) { case I2C_START_SEND_ASYNC: if (!SHARED_ARRAY_FIELD_EX32(bus->regs, R_I2CS_CMD, RX_DMA_EN)) { @@ -1385,7 +1385,7 @@ static int aspeed_i2c_bus_new_slave_event(AspeedI2CBu= s *bus, ARRAY_FIELD_DP32(bus->regs, I2CS_DMA_LEN_STS, RX_LEN, 0); bus->dma_dram_offset =3D deposit64(bus->dma_dram_offset, 0, 32, - ARRAY_FIELD_EX32(bus->regs, I2CS_DMA_RX_ADDR, ADDR)); + bus->regs[R_I2CS_DMA_RX_ADDR] & aic->dma_addr_lo_mas= k); bus->regs[R_I2CC_DMA_LEN] =3D ARRAY_FIELD_EX32(bus->regs, I2CS_DMA_LEN, RX_BUF_LEN) + 1; i2c_ack(bus->bus); @@ -1608,6 +1608,7 @@ static void aspeed_2500_i2c_class_init(ObjectClass *k= lass, const void *data) aic->check_sram =3D true; aic->has_dma =3D true; aic->mem_size =3D 0x1000; + aic->dma_addr_lo_mask =3D 0x3ffffffc; } =20 static qemu_irq aspeed_2600_i2c_bus_get_irq(AspeedI2CBus *bus) @@ -1631,6 +1632,7 @@ static void aspeed_2600_i2c_class_init(ObjectClass *k= lass, const void *data) aic->bus_pool_base =3D aspeed_2500_i2c_bus_pool_base; aic->has_dma =3D true; aic->mem_size =3D 0x1000; + aic->dma_addr_lo_mask =3D 0x7fffffff; } =20 static void aspeed_1030_i2c_class_init(ObjectClass *klass, const void *dat= a) @@ -1649,6 +1651,7 @@ static void aspeed_1030_i2c_class_init(ObjectClass *k= lass, const void *data) aic->bus_pool_base =3D aspeed_2500_i2c_bus_pool_base; aic->has_dma =3D true; aic->mem_size =3D 0x10000; + aic->dma_addr_lo_mask =3D 0x7fffffff; } =20 static void aspeed_2700_i2c_class_init(ObjectClass *klass, const void *dat= a) @@ -1670,6 +1673,7 @@ static void aspeed_2700_i2c_class_init(ObjectClass *k= lass, const void *data) aic->has_dma =3D true; aic->mem_size =3D 0x2000; aic->has_dma64 =3D true; + aic->dma_addr_lo_mask =3D 0xffffffff; } =20 static const TypeInfo aspeed_i2c_types[] =3D { --=20 2.43.0 From nobody Mon Jun 8 04:25:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1780378206; cv=pass; d=zohomail.com; s=zohoarc; b=PYs0fN/RO1VGc8VJt4SkHjYHT6Ek/BOoLPvpX9iJSIUoeBy5xpNrstFKQaG99GFFJj5wRhkUfogF6b7WTEZbkqDjONXFoppLFmLIE0GhtJu4CyJnVRhKwlcbYB7C9o9crMkB7LXaoTYXcvi+M5tCEJbU8TshhvcdS/D50B5z31E= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780378206; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=fFTOTnALSubxRKNw4UWsXs+kG+DAqNtpQ+eNasnXxls=; b=MN1+wflHMY2kf7QRbQgsOS1zo6X2R4bkLljBqdbNw33dMHnh8Z57kU4st8HZblwkOO7G1Wc1l04Pl8M44w090E0KP+yFgtStKhC9SKZ8Uzi7DChVQjVWo+LttpkHLwGe4WoeaWX6wRjTHi7xjgcaiF0h1gArg48adZkbiJ+AkGI= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780378206727431.50179507530197; Mon, 1 Jun 2026 22:30:06 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wUHgH-0003wE-4A; Tue, 02 Jun 2026 01:28:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wUHgE-0003va-1W; Tue, 02 Jun 2026 01:28:47 -0400 Received: from mail-japaneastazlp170120005.outbound.protection.outlook.com ([2a01:111:f403:c405::5] helo=TYPPR03CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wUHg9-0002fW-ME; Tue, 02 Jun 2026 01:28:43 -0400 Received: from TYZPR06MB4980.apcprd06.prod.outlook.com (2603:1096:400:1cc::10) by SI2PR06MB5411.apcprd06.prod.outlook.com (2603:1096:4:1ee::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Tue, 2 Jun 2026 05:28:31 +0000 Received: from TYZPR06MB4980.apcprd06.prod.outlook.com ([fe80::ea8a:7cb7:4822:2fb3]) by TYZPR06MB4980.apcprd06.prod.outlook.com ([fe80::ea8a:7cb7:4822:2fb3%5]) with mapi id 15.21.0071.015; Tue, 2 Jun 2026 05:28:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oWOCCIAky6ljWoJs/ihc5CzU4uOE+Sbqv2aAsa8WFIm4xxViocCI8LH7n+IucqzoTcXqU4e0LmbjvFGcVLX+2YEZ7hKrDuXf0xSFCSZqAkKbrl2NxlorQqhF+usfj5enu0QxO1KNjuE/hgE6ZZaLvSt1Hu4+tNxNyMtAvvt6fnxkSSMHqLNpG7UGvu0sh+yi+jJPBoPZ0TdSFuugXu3z3qb0gQYknxd/hcdDpP3RGYJAwzhnHXjhwZ2jsI24/jsrP1ahmHJg1bRfJLdb6qazxvnAfB2W7EtSzpDWXvMSZoZnhpnRnv9Vgi+dvZ32No082fDLvEZvLtlnKFyNzOgaWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fFTOTnALSubxRKNw4UWsXs+kG+DAqNtpQ+eNasnXxls=; b=sVQHUkbALYUoxkDThcJIV0KuYrH7Uz9mp9My6WcUuGqJ+solGkUy+rSO8HAp3rCLEE0q2K5w8OAa5Qdayjk8I5C3tKONZEtUV/s/GgcvHaRcsOzPb2HqyNo4KkLUM1MPF0JQ0oED8/7AzFJgSREFNYI/2DAqoEt8XV8IU1tioaiaKJF251SB4ImDzq689a42NeiAxi41i6l5CKbRRj9uHAk8s2rDANUw/Q8JTA9wTESXjrz7Jpq5Xdcg441tS8KXZkqvPdFH4EuBD4mrTQcULWRLn1AKJq3u7n3Nrg45cxMq9pDhlEzZSV4iIy9u0hf2UC3c+E1oBj3yQGFlu3MC5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fFTOTnALSubxRKNw4UWsXs+kG+DAqNtpQ+eNasnXxls=; b=dZ7s66hDm8cRiosAP5IQnIp5y8M76SI9xmoLCJNkdjub5JfqT+OnZolmDpJH28CDBvoy2l0DdLzduoAjIp7+dp+bOUYCVMp+Hs4SyEGi1Tk9hZq0xfWuNoV7WMrqQh/tq8bHMVV3q5djZhEdhZG4nxxQzeOLgR5+Y8bYNkpYMsNOt/WIOCzNBT7JVv9hpb2Wjz0IiB76L7osnfVJPWS101LATZ8Sr+Zl8KNdXRryr1eOU8Tl5xVVez2thcvjqA1tERm1Ihx+Xw5+a8c8Ao9aIjbzYEl8zZ9XM/t2Ry7UYgf9IZkz3r5TaFFni6P5GBRA4MxmR2fT1Il2VvE57MmXhA== From: Jamin Lin To: =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee Subject: [PATCH v2 02/10] hw/i2c/aspeed_i2c: Increase AST2700 buffer mode size and adjust offset Thread-Topic: [PATCH v2 02/10] hw/i2c/aspeed_i2c: Increase AST2700 buffer mode size and adjust offset Thread-Index: AQHc8lClfE7j1h0c1Ei93ZJaqVx8dg== Date: Tue, 2 Jun 2026 05:28:30 +0000 Message-ID: <20260602052827.1535299-3-jamin_lin@aspeedtech.com> References: <20260602052827.1535299-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260602052827.1535299-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYZPR06MB4980:EE_|SI2PR06MB5411:EE_ x-ms-office365-filtering-correlation-id: c2ff7f91-ad53-42de-9080-08dec067c884 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|56012099006|18002099003|22082099003|6133799003|38070700021; x-microsoft-antispam-message-info: 5AkYurAw0zPLee+K2ZnNKHmb3ay+HGLa/gdYqU9XEt972DydVzFjqYVVwmAOmPX0KNQfLXZKCxcMFwfQ4aSjc455k/PdPPyQA/273/FLP0r2JnKrlZtaIvE4wmh3QMw4GSsHb2QLFTsTJv0wlolOV9d0qDYWKtohL5Gl25kf62r+0bqjy4coCNa8oxA6GpP5VGN+N0tWgYMZWVHDUSMoKDSbqqSvvuNYuBalftABOIuIQn7FcT4lxHq5mfceeqH/L3cyD4YdKhpIvYQuEgAfy0ThvBRigkXxgrJdAXSH8RKl5IgaWwbDv/DA/uwdfqOI/M9F3b0c68FNEz3JPqn9V+YBwGA6zrkGPPVmGZq9V7nVqiZmb9kWbv7wVHyIPCJGsORhDz61B3+LpawPkqcl3SdxxiKigKqASCRwczxiqmrtd0WlVJA3T/QCydg5nHAYG1yjywhUKV/V/7QotY1yVOAbbvPzTElRKst9BzTdnPnWmU91FvrWHrjN05IUGJ4cdLkD3zfi0Z5Lg8nPqFHGzKIQkN0k1+Kkd2gyXftlJmbETCfyCrIjxgEH3LS4uKfhjjE1JBJYLHn9fsdPP6Vv/kaQ0z/CUr9iHHj8jQlXTORRLBxg1OJWSdBRnQ+Ilxc0dEkkOYayoIoYase8iogwIZHkxHDnu5QMJVricnbJGPeRn2ZQB+pKyBP+YXsHaBGAtbeyGge1+2aJ33SBtY+aN9jr4Uf6Gx2xKuPNCOWuL/zW4rbCNdIyeX3n3+rn1Ed+ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYZPR06MB4980.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(56012099006)(18002099003)(22082099003)(6133799003)(38070700021); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?MSchi5mOF5H6c7otzXDVKeAplGrRnV2yRj6BDClArvMqALrHRa+7RcyjcU?= =?iso-8859-1?Q?jyhu9Cb+dTosvIWIxCrfGxPFIsp/zAfulxPYw8oB5K2bgYHsP8ZSOkfO/H?= =?iso-8859-1?Q?yYPRTw0ZJINJdlNTyeItQ09fXp22IZr1lBvY5YCKfAEgyvIPVvqnNf1Rs0?= =?iso-8859-1?Q?ihlkYIsthIX7p6MairqUcPBaTtvm40HG3pVKwSQLI9Xqy6VW8No8L+oCgG?= =?iso-8859-1?Q?glH4zC2A8sVeR1x+O13g5XTIAZlasSKkj6qBVIdyCkOvA48XMVObUJSwPY?= =?iso-8859-1?Q?DDcPbXaIU0vj3KjNVYf4KwNXyklApq+Zzn76t0/JDrDm87dx6Ua1F/K3J6?= =?iso-8859-1?Q?9OkNEfmUvGvBTaJ6+If04lpl1quAG5cfSOyph0Kkqr88R9/Hz4q6n6YMcL?= =?iso-8859-1?Q?RCUewBQXK74dPgjAni6CaJ5latbQbWb7X9kccvoxowWrHlK4CP/1Fa+uX4?= =?iso-8859-1?Q?huYi5SRvAweh4H9mpNKkOhnE4vaDnP9LNigzZepKXqJhPHurlTfwgRPRua?= =?iso-8859-1?Q?Z+HXJ4Z0dbpDRcclhsdpLc50pszE600TJ/CgpWTm6AApcCNcuS4aa8r0Lv?= =?iso-8859-1?Q?b4j9rgfrOiQ8UBOFkQtJu2PZU5LmCDMtdv+Oz/O7cCbuCBd6Ho6K/Kz65s?= =?iso-8859-1?Q?Qtg0uoFzH40Sby4iBSMo22FO1cXZ8lpfhW08MeJ9WoTehsiiNDsD8QkRAQ?= =?iso-8859-1?Q?TCmMMHnfeybgelR9KKpQ9yE5JUJukujTGgXX76wa5soHloE5pU/OjBBgJZ?= =?iso-8859-1?Q?Hvm48pelKGueKIMWlud2nYQoqnDLMQ5Cu6vVA8HaiedS/b2q+iPf9HXlrC?= =?iso-8859-1?Q?5y9rxzofR6gWoJwHBgu4GgAyQ+HHIi25hB8t0QDg7oIAJDv7zHa4t8HSfn?= =?iso-8859-1?Q?oEq1wlZkePd7O7SB8OOwzBypLcuzy4PKkRDW4BC9LBqNJE1SP05ee7ypVd?= =?iso-8859-1?Q?gFSvpBbgNHf1oFVasQFomAjeNljgiA/GutdRiy4E5qJR8ngHv0G9vuu4ym?= =?iso-8859-1?Q?jLgKpgDv6jXfaNHZ5DDNo1KmdmQCdRjGcrzs5AfnA0o4lhSPeu0w21kNpv?= =?iso-8859-1?Q?fA/yrG1yWrhpXvF4z23zcOMQuLtd3eDlbFueXBDLUtjDVTD/HvZlG/3ypx?= =?iso-8859-1?Q?419YgxqDdEmQW+UJjg7qG/DRvg9V39QVrvifq6xNeD7LXZWxS77treoTaK?= =?iso-8859-1?Q?/rSgCDqTW9AzwTPJGugum4SLrRhBp4wvSHhB5LPq+5y9+JpmGECUYAbsK8?= =?iso-8859-1?Q?Ec4YG2FYn2Y0WEqv5Y2ZfQindDZTLbpYzAtKQVg4MD5x7G7XjwiE5NEYER?= =?iso-8859-1?Q?dtYDlf2D+bSt9gqGU9gspLx9HMYhgW0Uvl/r62nMRLYYf18WWbt8+S1mZ0?= =?iso-8859-1?Q?p+4601AmeUS7RIGYxxkU20huEeP5RQjHO7VIsN4PqxSLK25jFkRZdfdsUB?= =?iso-8859-1?Q?W4TGaLa+jFdZHanKioBXn3kakTZeNvV4iXVhfHIi5eTN8yQnvm9J0TfkJN?= =?iso-8859-1?Q?+krpL33W/osgdUuZ3OyfAa2M1dOz0OzM6YlQIDeLNJLtPFmdfREJehBHGv?= =?iso-8859-1?Q?RPUeLEIeYLrE+Miwq5J25jRac3/2zsgJadsxLzilZzJ/VatyhiYkcjj6g2?= =?iso-8859-1?Q?HVadDXlcwdmzUiCEz3x9eo/f+/yZ2uKhaLsV0V41aDlaMvRp4IaSI0pu51?= =?iso-8859-1?Q?pR/6KWCyDk/na92mv/Oci1DdwgxahUbDBRqydGwXJPNDLr6VT7vKk4m/L4?= =?iso-8859-1?Q?f8aUu/l+32gefOHLxz1NwMG9BbnpXgLm25F44ZYbKQxifTghlNf2/iy3Gk?= =?iso-8859-1?Q?vd7KKAWfVQ=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: e4hrp+gcboRhu/Y/aisGd1t0RugrCU1Pv7SZnQW1w9+JLuadZ7FfO0dsBd5hq9ahXVAj+jg+i3NjuRYfKEOlPapQSgg3lAAen+4AkhNv6vQUhUM/gkr0u5bNl1VLpR3ixM2qvKH0MjBSNkDaYYHWwOynqCzoP4gcOs3JeMK3w2VaB6ABnB2D7WCSIognHReKQHEPPjgGpTp21BUSHF98q4rdCK2J4OuidFIFBe3CFzzHhykkL6en3veMwkZeBTjasfGOoTM23C243b7Mj+WnN/cJwkI9XB4FPo45w0a783cV3E9BvIqXBF5jSQafWD7RM2UwWmba7XdiAqwQ+fWtiQ== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4980.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c2ff7f91-ad53-42de-9080-08dec067c884 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2026 05:28:31.0165 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UPOB69vz/Cm+xpEr4xeczxTKM55/+RBN9SS2b/xGZjxmHqIHJ7aH1123PfhQMqjXqennPa+JjnY/+v42JUvo8u1dGV7lLeMbCS/hIe/khlo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5411 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c405::5; envelope-from=jamin_lin@aspeedtech.com; helo=TYPPR03CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1780378208979158500 Content-Type: text/plain; charset="utf-8" Update the AST2700 I2C buffer mode configuration to match the latest firmware definition: - Increase buffer mode pool size from 0x20 to 0x40 - Adjust buffer mode base offset to 0x1c0 Since the buffer mode region size changes, the migration state layout is also modified. Bump the VMState version numbers to prevent incompatible migration between old and new machine states. Fixes: 1809ab6a67359e0876981cd05d2a50b2843eabad ("hw/i2c/aspeed: Add AST270= 0 support") Signed-off-by: Jamin Lin --- include/hw/i2c/aspeed_i2c.h | 2 +- hw/i2c/aspeed_i2c.c | 46 ++++++++++++++++++------------------- 2 files changed, 24 insertions(+), 24 deletions(-) diff --git a/include/hw/i2c/aspeed_i2c.h b/include/hw/i2c/aspeed_i2c.h index 1fc229f699..b2e4d2fb9d 100644 --- a/include/hw/i2c/aspeed_i2c.h +++ b/include/hw/i2c/aspeed_i2c.h @@ -35,7 +35,7 @@ OBJECT_DECLARE_TYPE(AspeedI2CState, AspeedI2CClass, ASPEE= D_I2C) =20 #define ASPEED_I2C_NR_BUSSES 16 #define ASPEED_I2C_SHARE_POOL_SIZE 0x800 -#define ASPEED_I2C_BUS_POOL_SIZE 0x20 +#define ASPEED_I2C_BUS_POOL_SIZE 0x40 #define ASPEED_I2C_NEW_NUM_REG (0xa0 >> 2) =20 #define A_I2CD_M_STOP_CMD BIT(5) diff --git a/hw/i2c/aspeed_i2c.c b/hw/i2c/aspeed_i2c.c index a6b44174f5..595b5fcf5c 100644 --- a/hw/i2c/aspeed_i2c.c +++ b/hw/i2c/aspeed_i2c.c @@ -1132,8 +1132,8 @@ static const MemoryRegionOps aspeed_i2c_bus_pool_ops = =3D { =20 static const VMStateDescription aspeed_i2c_bus_vmstate =3D { .name =3D TYPE_ASPEED_I2C, - .version_id =3D 7, - .minimum_version_id =3D 6, + .version_id =3D 8, + .minimum_version_id =3D 7, .fields =3D (const VMStateField[]) { VMSTATE_UINT32_ARRAY(regs, AspeedI2CBus, ASPEED_I2C_NEW_NUM_REG), VMSTATE_UINT32_V(pending_intr_sts, AspeedI2CBus, 7), @@ -1145,8 +1145,8 @@ static const VMStateDescription aspeed_i2c_bus_vmstat= e =3D { =20 static const VMStateDescription aspeed_i2c_vmstate =3D { .name =3D TYPE_ASPEED_I2C, - .version_id =3D 3, - .minimum_version_id =3D 3, + .version_id =3D 4, + .minimum_version_id =3D 4, .fields =3D (const VMStateField[]) { VMSTATE_UINT32(intr_status, AspeedI2CState), VMSTATE_STRUCT_ARRAY(busses, AspeedI2CState, @@ -1250,37 +1250,37 @@ static void aspeed_i2c_instance_init(Object *obj) * Address Definitions (AST2700) * 0x000 ... 0x0FF: Global Register * 0x100 ... 0x19F: Device 0 - * 0x1A0 ... 0x1BF: Device 0 buffer + * 0x1C0 ... 0x1FF: Device 0 buffer * 0x200 ... 0x29F: Device 1 - * 0x2A0 ... 0x2BF: Device 1 buffer + * 0x2C0 ... 0x2FF: Device 1 buffer * 0x300 ... 0x39F: Device 2 - * 0x3A0 ... 0x3BF: Device 2 buffer + * 0x3C0 ... 0x3FF: Device 2 buffer * 0x400 ... 0x49F: Device 3 - * 0x4A0 ... 0x4BF: Device 3 buffer + * 0x4C0 ... 0x4FF: Device 3 buffer * 0x500 ... 0x59F: Device 4 - * 0x5A0 ... 0x5BF: Device 4 buffer + * 0x5C0 ... 0x5FF: Device 4 buffer * 0x600 ... 0x69F: Device 5 - * 0x6A0 ... 0x6BF: Device 5 buffer + * 0x6C0 ... 0x6FF: Device 5 buffer * 0x700 ... 0x79F: Device 6 - * 0x7A0 ... 0x7BF: Device 6 buffer + * 0x7C0 ... 0x7FF: Device 6 buffer * 0x800 ... 0x89F: Device 7 - * 0x8A0 ... 0x8BF: Device 7 buffer + * 0x8C0 ... 0x8FF: Device 7 buffer * 0x900 ... 0x99F: Device 8 - * 0x9A0 ... 0x9BF: Device 8 buffer + * 0x9C0 ... 0x9FF: Device 8 buffer * 0xA00 ... 0xA9F: Device 9 - * 0xAA0 ... 0xABF: Device 9 buffer + * 0xAC0 ... 0xAFF: Device 9 buffer * 0xB00 ... 0xB9F: Device 10 - * 0xBA0 ... 0xBBF: Device 10 buffer + * 0xBC0 ... 0xBFF: Device 10 buffer * 0xC00 ... 0xC9F: Device 11 - * 0xCA0 ... 0xCBF: Device 11 buffer + * 0xCC0 ... 0xCFF: Device 11 buffer * 0xD00 ... 0xD9F: Device 12 - * 0xDA0 ... 0xDBF: Device 12 buffer + * 0xDC0 ... 0xDFF: Device 12 buffer * 0xE00 ... 0xE9F: Device 13 - * 0xEA0 ... 0xEBF: Device 13 buffer + * 0xEC0 ... 0xEFF: Device 13 buffer * 0xF00 ... 0xF9F: Device 14 - * 0xFA0 ... 0xFBF: Device 14 buffer + * 0xFC0 ... 0xFFF: Device 14 buffer * 0x1000 ... 0x109F: Device 15 - * 0x10A0 ... 0x10BF: Device 15 buffer + * 0x10C0 ... 0x10BF: Device 15 buffer */ static void aspeed_i2c_realize(DeviceState *dev, Error **errp) { @@ -1666,9 +1666,9 @@ static void aspeed_2700_i2c_class_init(ObjectClass *k= lass, const void *data) aic->reg_gap_size =3D 0x60; aic->gap =3D -1; /* no gap */ aic->bus_get_irq =3D aspeed_2600_i2c_bus_get_irq; - aic->pool_size =3D 0x20; - aic->pool_gap_size =3D 0xe0; - aic->pool_base =3D 0x1a0; + aic->pool_size =3D 0x40; + aic->pool_gap_size =3D 0xc0; + aic->pool_base =3D 0x1c0; aic->bus_pool_base =3D aspeed_2500_i2c_bus_pool_base; aic->has_dma =3D true; aic->mem_size =3D 0x2000; --=20 2.43.0 From nobody Mon Jun 8 04:25:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1780378250; cv=pass; d=zohomail.com; s=zohoarc; b=MC68s0OpEQMHeLZrp05sYxTkMLDgPeW9++0k2+FA4zSHalYMsPJ1U4swcar1EumEYAoUg/70W0/FurHdW9mYTHw983bwRAitODn7Kd3Bbw4H1uaCbFGToWUtio3VEAaUkJ7OR+XKhCYr2nFfHtJD9WFeAEEckN1BtmtwmvyN288= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780378250; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=hrTG8zd2buClBhqaHE/pk14970IbTzF4v20Qqgtdp24=; b=XqWxvl8UT174Pl9AiFrHbWtj0r/pGOy6FSswKBPZmc6wl0OJavzsyEuHyi3C8mjVXRXK0YUMW+u3jgl0Ia8/k4ZYhxDWFn3lf/tlLm1rIV1TQmh6lzhDiWEwKBUo13HdvAUymiRwrg20KSSvoCOTgqB0WWPBD7TUTL3y8MP1fnI= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780378249999720.8664543337753; Mon, 1 Jun 2026 22:30:49 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wUHgL-0003yH-4T; Tue, 02 Jun 2026 01:28:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wUHgJ-0003xL-2u; Tue, 02 Jun 2026 01:28:51 -0400 Received: from mail-japaneastazlp170120005.outbound.protection.outlook.com ([2a01:111:f403:c405::5] helo=TYPPR03CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wUHgF-0002fW-Tz; Tue, 02 Jun 2026 01:28:49 -0400 Received: from TYZPR06MB4980.apcprd06.prod.outlook.com (2603:1096:400:1cc::10) by SI2PR06MB5411.apcprd06.prod.outlook.com (2603:1096:4:1ee::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Tue, 2 Jun 2026 05:28:32 +0000 Received: from TYZPR06MB4980.apcprd06.prod.outlook.com ([fe80::ea8a:7cb7:4822:2fb3]) by TYZPR06MB4980.apcprd06.prod.outlook.com ([fe80::ea8a:7cb7:4822:2fb3%5]) with mapi id 15.21.0071.015; Tue, 2 Jun 2026 05:28:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QkN3YOWtjsD4Y9HBvAXLDcuYMan3mu0AhtDTWsD3jqSDvjxtKgwNBOw8XsfyEgOIoVqMVxwg5FSvVvzpvTNLJ+L8yqpyrcDRJ9LNBL1Mt44+e98hDBYupvIbnaWNq9U783C0cuh+E7wBwAwYLKwMLzIBi4eSmDH9MKSroVg1JjzSrigb+E2cFN+tO3ble5z9H/vopwF8MkfdASP9vTKJYoGyxRzT6IA+0ocOW3sReenUPKpDcbmhoF4tGnvYERU5tJmI048m35LEdPE7TQrXDhiVf+mxDRohcrt53JP4YWycbQi9GBKoBHkA0bJi5YsnFLCHsp9DUlvKP2QiNR5EoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hrTG8zd2buClBhqaHE/pk14970IbTzF4v20Qqgtdp24=; b=MYDQUNbkbD2f427+vLHDSm4JehblvGcTUyZnWpwUDJS4HSwPR8gQelCcoG+ikQ3I5bvV/Zz0DVwFx2O+zXGFNTFS3eHMSfABA+EuN5zfUTQLpmae4i57MLAataJA8484fuQhJMpUGNdNt0TQ7Uc034S0jpUxvLq01C9M9m29XCKRr8AaeDLPTQJZipsdoa6u2sIQ4eBkMW3dqHuzs7j59H9TB984LOd/tqGq5CDfxYyb93DW35rqkgblS8xOIleJRSAEABQl2M38dcKdQH9QCqAkoypHnMTnyRPFWYefaZSQqmV6WSUiXqf8KnIw/+FjZqzsOT5YlWNU6rkpRe5YOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hrTG8zd2buClBhqaHE/pk14970IbTzF4v20Qqgtdp24=; b=UGWqJEkEhOTR7WbtQGUz1VWdJ6yIas6qcik0KgW74qqaa4LBdN0AAr4fnplyRr4FFfafugeZIzt7YHWaPnNWX6nBXHVP2E32qKQVMJ8OvAhhVs+kCfkRKUzCXeEpmV6mgl+nOGiw5Nf0KpvBpGW97yQ59gOTKxRLa4SQ0ykQ1/Yf5QH4BM9tZdqxgfzYhCQROCLpBtxoiAFpMDxa3CIKgQwK0rwqgI422RMM1TGZlc7+pcm6Gj5qP10muDhJws1EGXisVBBmrLaZLZbLnR5bJdpn+B/zroKVOjxhBwgybYZJKJuwhfsIJQK/KA4PaGHtgwvd8GkQrWtLbeUl7nLwqQ== From: Jamin Lin To: =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , =?iso-8859-1?Q?C=E9dric_Le_Goater?= Subject: [PATCH v2 03/10] hw/arm/aspeed_ast1040: Reuse AST2700 ADC model Thread-Topic: [PATCH v2 03/10] hw/arm/aspeed_ast1040: Reuse AST2700 ADC model Thread-Index: AQHc8lCmxu7DCQWv5kKOP6uKyFOM2g== Date: Tue, 2 Jun 2026 05:28:32 +0000 Message-ID: <20260602052827.1535299-4-jamin_lin@aspeedtech.com> References: <20260602052827.1535299-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260602052827.1535299-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYZPR06MB4980:EE_|SI2PR06MB5411:EE_ x-ms-office365-filtering-correlation-id: 51930674-8fa5-4a57-45cf-08dec067c941 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|56012099006|18002099003|22082099003|6133799003|38070700021; x-microsoft-antispam-message-info: XhTiIXFMf5vQwYowX9em1C2Ug5n/tn/56x1FMCHv8okJ6y0ujgCrg6DWlqt2mHwSGmRJuVR3N+VCDFdQ0IrALyxaDrkshTGuwRQHThu88RWyUm+32f6a30SZuoV60YGEADQ2SvRfcuedmxQ6K4uganYdm04HQQwmIbnB9YD6QfBfhivzos7kZJHX0ZZEJ/vURfyyXTo5vZAk/A6xrtAU7LkZbQbpMyr8UUWekYybAgch7Es0x97TI3s/zVkkfijB/S4G4DF5J9rzvwaOw2eoDmNpnojRETaNo15G6XxqTW0vqes/CvX48epmS7ZUvG1qXur5wJVw/ywBKVSQ5el4dK5cYEkwIdJSM//Zs/jKGMl39W3nbpWnAf4JWgsyymb0KNYI5+fUvYwMKJwQuDiHlwJD9zO+jot73/ORQjxzxWQzz9uRVEW5bRQxrEO+Gt/YOqgPPJOXXtFtwa5WszTSjbTH40pGHbPN0BXDmydREi9Fx9bWlPudN2LOT5Md4r5AIvfcJV7Z5lO+FeHA66atZO03ZEaqDmAL+z6x22cFQa0fZl39BfqK8anxbKA1xadGPnD7Bv/tgYaXYdJqh+2WEVu7Xw6fBHTeQFSmKWNNLWPimtMbBj5n9D8URTpcDKp8w2TRnJuKNaQoFY9BK7RNjHMFtaF+zPPP0QEimddRZPsKOBrKKjgWdJCW9B3rEj5xZXnPWsml/bYcqi1mnyY6Vc3iP/D5vQkTiL82K7CnilP/XDQL8+6T35DibJk8xlQs x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYZPR06MB4980.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(56012099006)(18002099003)(22082099003)(6133799003)(38070700021); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?BW23tkvL6jSdhbMyddEj1IY/E2PbRpYUKfS0qgV4akcU3YhvBQT9gWTqPs?= =?iso-8859-1?Q?Zjo4BLACrz2ebiQ9kDcKNZ86tCFOplFXx6PrJrL3z6zDf+o4YTkz7cDpOX?= =?iso-8859-1?Q?5XGd5WoQymRTVPahxoMJiMQy3xTn/eCqxKyKUYedeziVIYvm71GSOiQ1BL?= =?iso-8859-1?Q?ixKUxTdCY8wu+NKpvtaNF8tejse6u6Cmt3VelHRzMl64Ofd6EldXO0zgyU?= =?iso-8859-1?Q?ayG/lkYiNJVOVdAlpjjDgPuvWVtRsD1DjlX3MXq85GlhMYyb7Wf8itScxh?= =?iso-8859-1?Q?NOkXbz6BqXMx+dRzspVDmeFsWDQJddEcOO2iej9Q6xqphHs9xsX4S68me2?= =?iso-8859-1?Q?tjIDQANzp0C2toVSTjsVGO7gBrknIGS7gUVO52T+xHSRG9i4yWnfMwvk+M?= =?iso-8859-1?Q?FpofrKqisspZYxY6MiW4ra4UqS0Ox5zljqWwWSH5hZmP2wyFRl7XZUcJbL?= =?iso-8859-1?Q?Qo9cZMidjg7Oyp59T8p6jq4h39tyWPsPfN4fSKWeKdMuLVBdJsnxg1q6U7?= =?iso-8859-1?Q?389Pj8xcDB231SI2RpshXldJp5J7nm6r9bbvyuV37NoHor8RJQlZ8khCK/?= =?iso-8859-1?Q?y+4XR0pBHv9tGR7jaOvWkd+aOmh3PGMCbSzWplYPfHV2A6dQeLyy3aw/YE?= =?iso-8859-1?Q?Skkm0O29S5yvMSB3FMtlSL+GO8yFkrSLVKr/lmQBWwirlvdWuSmpfW0bHE?= =?iso-8859-1?Q?Tx/H3YFGeoVmmKL+8C0Z8e1cgdUHXREQKxCL064JSoK3vbwUv9ALyEqiHL?= =?iso-8859-1?Q?YdUlXz8wU7eSr0yRcJnaH19l2eiRW0z1fZDjDedvJ5Nl2JVuN498sw1psr?= =?iso-8859-1?Q?QM0WGz3O0XmkeRMHk+59OS/IdfPD7mkDQjmT4CVBtdK6YxA4VnCgobxWX2?= =?iso-8859-1?Q?++9uTa06y3FzgpmOtwUnX/6qcTCunpJPclhOawfq0f35yCrt0HeEh1PaMk?= =?iso-8859-1?Q?srrxowcQ6sc7BrSf0RpEnUgR2ul7cevH3LwkHVjmoD7DI879EuUa9bjLV+?= =?iso-8859-1?Q?weLYPXcNSadYe9BsuyamQYBKgqwUFDnqiSJfmhyRAT4rbU7nNVp0GyRb0Y?= =?iso-8859-1?Q?52HPyjRi6hLb+LzGkrToOOJbjD3QSwW7yLqj3Qk1FabnwJZog0dB+hkWwS?= =?iso-8859-1?Q?p9XxC/7/EUET/T4N4QnvOdmpNUPIZc+1PzrvC6DTLOtzGPqBmLma2n16KM?= =?iso-8859-1?Q?gcMm+LCF1aagQNv7fUFexOB47jleI4B03TLRfKHPm7xviTqognwMK8Cpln?= =?iso-8859-1?Q?xzBqHplVYB6hqjhgkJoszgCUWQrbYp7JiCsgrNJORCboeFU5imd2ICvDSd?= =?iso-8859-1?Q?KvUXik/ox2wS4vytGc2xTboHVl+ryuJoXrsruocvWC38hVzPszyi/XyliE?= =?iso-8859-1?Q?qZjJ7+Ma8PwU4e7g3FX57z97cGQlEhtV5P8wUN5SpnNAI8OnuAME/9/GIB?= =?iso-8859-1?Q?Jp2dK4GdEJEZSGWXiWrTDL1VFED/GiL2P5/zJSqNVZtrmIb7hhN63f3JBk?= =?iso-8859-1?Q?wGAoQggsGrqeNSPpsu3Q2qVPCw5olirfom6JjnBKnIFxDHP322bhgcCHXD?= =?iso-8859-1?Q?1x2MoYH89hrVJkVSwzjnTfwS9GRifkkx6+YaosTU9VSVZd9NpemSc5YbCx?= =?iso-8859-1?Q?4k+M+KK2i6xImVo3dQAgXyRyN4EXkyKqEd1deex74evRvFNGdZZkaLJK3E?= =?iso-8859-1?Q?TI+awsQqCxkAxPVsLFV295org3e/5NjWZ5jMOJHQlq+DDZYttb5iZHZ2iY?= =?iso-8859-1?Q?gxREzei4lZoqJPeHCTG8G5BVqMgkENkkq5dx5w9Wab5CEfukqs+6LbXSv7?= =?iso-8859-1?Q?/GyXfdhFdA=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: oL2bnUZz3SHE/DrIc5Ob2MdVa8QXt3cQDOVcdX/+oyiyhhr5jh/u4ZxV8Ng4tbHG8XEIKB0C3LKI7RUSOYrx0cFN08Q+MgCQEY1+hofDz3NdU2b8nOr2d1Z4315EeHt3HLKThgCYY0PJM1SSKxT2h/Q4PR3yXMhzH+pw8NyBRt6VrJg6ICUgVo9OorCHfd6xVJI2Pr8E0sUalPAYBj1A4yYUy28VUzivbgZFGdeUxd6j5YS8U6qGdeHNWnoEJkL5LmQUG7jlO6kdJDZPG2MzdKG5nm9BegWst9gHqPhGoZTOQkN8acBXWSafFAqixbZs4fgzC6SkB6whcCUQpJcxgg== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4980.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51930674-8fa5-4a57-45cf-08dec067c941 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2026 05:28:32.3473 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vasCPwFfQFGu11aqBPmRLTGg8aIsh1SrR4MBug2IrQPpGGgMwb7gGofhD+Bs+vF3KuSCT28yKtg/6gDodAYaXd9WTk1AWMG+T8ISiWKNddE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5411 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c405::5; envelope-from=jamin_lin@aspeedtech.com; helo=TYPPR03CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1780378251771154100 Content-Type: text/plain; charset="utf-8" Instead of introducing a dedicated TYPE_ASPEED_1040_ADC model, initialize the existing AST2700 ADC device directly for AST1040. This avoids unnecessary duplication and keeps the codebase simpler and easier to maintain. Add ADC device initialization and realization support to the AST1040 SoC model using TYPE_ASPEED_2700_ADC. Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater --- hw/arm/aspeed_ast1040.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/hw/arm/aspeed_ast1040.c b/hw/arm/aspeed_ast1040.c index 8efcdad8f6..b736e690e5 100644 --- a/hw/arm/aspeed_ast1040.c +++ b/hw/arm/aspeed_ast1040.c @@ -107,6 +107,8 @@ static void aspeed_soc_ast1040_init(Object *obj) object_initialize_child(obj, "uart[*]", &s->uart[i], TYPE_SERIAL_M= M); } =20 + object_initialize_child(obj, "adc", &s->adc, TYPE_ASPEED_2700_ADC); + object_initialize_child(obj, "pwm", &s->pwm, TYPE_UNIMPLEMENTED_DEVICE= ); object_initialize_child(obj, "espi", &s->espi, TYPE_UNIMPLEMENTED_DEVI= CE); object_initialize_child(obj, "udc", &s->udc, TYPE_UNIMPLEMENTED_DEVICE= ); @@ -188,6 +190,15 @@ static void aspeed_soc_ast1040_realize(DeviceState *de= v_soc, Error **errp) aspeed_soc_ast1040_get_irq(s, uart)); } =20 + /* ADC */ + if (!sysbus_realize(SYS_BUS_DEVICE(&s->adc), errp)) { + return; + } + aspeed_mmio_map(s->memory, SYS_BUS_DEVICE(&s->adc), 0, + sc->memmap[ASPEED_DEV_ADC]); + sysbus_connect_irq(SYS_BUS_DEVICE(&s->adc), 0, + aspeed_soc_ast1040_get_irq(s, ASPEED_DEV_ADC)); + /* Unimplemented peripherals */ aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->pwm), "aspeed.pwm", --=20 2.43.0 From nobody Mon Jun 8 04:25:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1780378214; cv=pass; d=zohomail.com; s=zohoarc; b=fBiWBfuPi+j5YlCPZmtoXtSL+sximKDeeNVhKbPMIgVCGY+QEn2peU9jVedYLvlghoklSWP6EBMTrUvAEOWKAWiVHYEmPhd4s98b4Z/SE0i0btNVPf525XJf8Tt02deRjvEtM03itXb/Jo6xQIAxybVLzHjpu8c92BnaguA9XsM= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780378214; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=AEVegwRiUCq+PRBAvXjoVyyq1Cndiszr9rLKaQIyY4E=; b=Cs0cDhmfWewQgJ9NJFj2fTLg/QTukFcIlRRwSAYn4e+RQYIRaCbsx9i46m+WS4uCL/3f6Rtqfbix3H5qqve1argqj1OszGgAOwixbKCpIFaweNzfkz7VmrtIB4hIpjOYghG2PScr9SFmOnACEIsxR0/jofrU3X1KkzuCpIBMoEY= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780378214069150.9358933121698; Mon, 1 Jun 2026 22:30:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wUHgP-0003z2-Uj; Tue, 02 Jun 2026 01:28:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wUHgK-0003yA-Ct; Tue, 02 Jun 2026 01:28:52 -0400 Received: from mail-japaneastazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c405::7] helo=TYDPR03CU002.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wUHgH-0002gD-IF; Tue, 02 Jun 2026 01:28:51 -0400 Received: from TYZPR06MB4980.apcprd06.prod.outlook.com (2603:1096:400:1cc::10) by SI2PR06MB5411.apcprd06.prod.outlook.com (2603:1096:4:1ee::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Tue, 2 Jun 2026 05:28:33 +0000 Received: from TYZPR06MB4980.apcprd06.prod.outlook.com ([fe80::ea8a:7cb7:4822:2fb3]) by TYZPR06MB4980.apcprd06.prod.outlook.com ([fe80::ea8a:7cb7:4822:2fb3%5]) with mapi id 15.21.0071.015; Tue, 2 Jun 2026 05:28:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jBDQ3fsbj/tTvcvfW1hEjJ5odNx+9nF/7kjPLae7klCqGxULBueGermHpYc5wd2hMisJNE/kGrLsj8BsGF8KoRywrq8qIlKCJ8p8hNbJp6B34iEneI4H15dLFhR2anYPsJntcpGxI/OoDIJTJMALOISjq749gwUHIcKQNcMJT9ExxxQ8bVK3J4VjG9gDM8gkEnl/YElp4Q6mL+IUgLd24mA1rNSjyOaMABTEIbZudL08gtZZ8psk4cctymBnBhFoNztJbZw5LXFsOJ1B/bgzoWcViehdgM90DZoAen0opXWjQHg76ZcIQz/KZKezQmUioBQxgkkmLYFMJAyO65fRvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AEVegwRiUCq+PRBAvXjoVyyq1Cndiszr9rLKaQIyY4E=; b=gHfLhSjhjYbLuy/4lplJ0IkiSPMnAb9iP7zPr8AfgP5Budf4QQGmQnnB4xDzScwL2E9nkQb51ABbCwelCDFLbAmuV0eRLsy6bGEZCJekf65OkMQOpfUNjdE7ircXLBrMDhMOAqkT12PJB4U0V1pMq/61Bf+k+PSvlFxoVYbw3GUS3hHhZaYyY3eJ8+0um768OTYyYVtx7h7FQ2aQS4ID+sjKFWPoFfsUkeRLw8LoMP4eVacibtWZaMPU2v7qO7Jl/S2MAQoOekwXSrls5O63YILDUGWCT3rYkEuN62yuyMy6PsFlvoilK2iPNGRCTl1iO4yNMabm54B9XqAuoqFtkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AEVegwRiUCq+PRBAvXjoVyyq1Cndiszr9rLKaQIyY4E=; b=dot+o/8Mu1b9zyh1UKh8pavft7I8OctWNsOV3nkLcLoBd8cu/jLldGv/GfQQfl2fHtTUaZW0dgdzchtIrewaogumEpuFZKz8q9Cuw2qoBMQAmXfEzQC3QR1wIk9kZOtgKIJGH/AJ/IxpZ6pLiCj7tZd5Dj9Fs9g59cqVw3AqZ6k1MEdUlfqZzfE13FlVxbJWwHLXj95dfvYJv5PlGZQGpnwCPdpBhGtJgjKqPoZjrECM5HIQlDw03o1UeWcFPJiWNQtfHuHpfhP88pyZapCwQsyK+7+viESapvIworNz5Xs8eEAdVaOL3MNf/4JGgXXdQ9X0Zifclj3B94LGwRQKBQ== From: Jamin Lin To: =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , =?iso-8859-1?Q?C=E9dric_Le_Goater?= Subject: [PATCH v2 04/10] hw/arm/aspeed_ast1040: Introduce PECI support Thread-Topic: [PATCH v2 04/10] hw/arm/aspeed_ast1040: Introduce PECI support Thread-Index: AQHc8lCnRzA644Fqm0Gm6Q6CmCqEzw== Date: Tue, 2 Jun 2026 05:28:33 +0000 Message-ID: <20260602052827.1535299-5-jamin_lin@aspeedtech.com> References: <20260602052827.1535299-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260602052827.1535299-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYZPR06MB4980:EE_|SI2PR06MB5411:EE_ x-ms-office365-filtering-correlation-id: 559feafe-e225-4b73-965d-08dec067c9ee x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|56012099006|18002099003|22082099003|6133799003|38070700021; x-microsoft-antispam-message-info: 16co9jIu2Scwxfqw7xFMxUlvyT3Un0+j3yROCnUw3tSmnBd44ROHs1GV6xs45M5oEIxr24Jp9VECyEiZDqq4wM6MDWeKTTGOXmS1clTsbh9b3ovRq8N0+qDlb+yOluTtBVwoi5gCXJAiiOoYIYVLAlYvMj+/YzHmSXi/fi1Xe6UgAQCyF5Xt8kXJtTC1YxQfMcr9FqZcm6YVuG+UieAizkaR5fFR/khGBA2ofFfL62PqLmVGb0fCHmEFoq+dB+r6H49FxjrP8tq9HJzJ4xhCweNLuMz5uXpPCA0AfbKXO/j6X9NQSDWVggz7Qn1cJyg2x32pwqLzjM1HpyuGyjY23aBDrvX9hhDIC5XGfTIAsF/Soci0tf3cjGvYCAsCMSlhAONhf1yy4R5eMdytckDpLYikVbwzI/ctHUpG2wFZ41/PL0ryfTgq78nZcBbpbWzmAgukuhnI0BwRo3rnet2pe3/ebooh+4NRk8u8/khye8iUtH7I1aijJonw4ElIuWVcmqRfkTApJsfje9J+zDi6N117CGGBaFxwjHMqE1kuo4fFCTOQwzUC7tl23xdfqFvaeUbgPqiN30l7XXz0KnKe8rZwUKeTF5JfV8j9ZntezjvJ+xAFkLsAcDUAwXSGbdhK9gMn9m5B1bQCE1+pW63IW7befM+/VMpGG1VQtSKIUzZe3BUYf4H8Lvo40jnP9V8l2PXgXQYrCht0snpcVyR1c7Mx+QqXONKpxNASvzx5+9jdSFYlFI63o65ZvkkH2O+a x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYZPR06MB4980.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(56012099006)(18002099003)(22082099003)(6133799003)(38070700021); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?KQvQxYxt6jk3Wi27G0OdxHfWBskP6g4KgxQaob9hRrHY7/kck5YLn5Zr2E?= =?iso-8859-1?Q?eOj9TRAiX2KNj+fCaWmZ7TeY32UnjiRh7lX70bIC7zYF/2BM6df0zell1h?= =?iso-8859-1?Q?g8fAV3QsWnVcH0N2MciAZ5y71lt00HP71e6obua6Ocb3Nd79KVX7Xf5YhL?= =?iso-8859-1?Q?nW6QNgzOX5OLZXcpf+btaMaEV7CL1aJwWHjmT4HE4PgeDLA6zZqCj/mhQW?= =?iso-8859-1?Q?fXRzHsOeE6Qrv2py0opcaVahbc8iwGqCUUp3rCvqHENr1YtEGQwcE4ZBYU?= =?iso-8859-1?Q?o5A8YxkyOXSrMpAcCZDJUnpTf2sFLMuWINH6Ra82HB7ZxTZaLOvmhrCjJ8?= =?iso-8859-1?Q?0VCPqxKrF0wMHOI7AaxjvWvTS6eZXIyoCBJAu9tBojkIJP/rgkTQAIOzos?= =?iso-8859-1?Q?wLgO6Jc9glGsr6PP+XO+fDP3QeGykukuPptiNKIXaJMhziYDeQhMGIVROD?= =?iso-8859-1?Q?Go+lsPqiNseRWUiDzV/2Ej1HpAQNF21GAEyiD546d7NaNW7XyjkgwoXP31?= =?iso-8859-1?Q?v61vsKeqIECHA1Im/dQfQgsD19EhU2AigYl73xFFJu34jqFSV8HAGXxjIf?= =?iso-8859-1?Q?vJEaRQsxcwoBPSn9bMY6CynEbRUKAVf9FEeSRNWo1+/FdUHXab1XtoTFLz?= =?iso-8859-1?Q?BSXiqm/UWS5m/+LP+riN8qlgNaYWoN8D/7eJgwQeI6hqAc9TmqBd1ONcRw?= =?iso-8859-1?Q?mn2R51dEMlGAO6ITJwR9JAqnRvru4aE0Yf5yJjk+sY1ylIACjAxbKy7lnb?= =?iso-8859-1?Q?E+mJ7zFPrIfOEJNyRRx7n74gwlSMmns5PTejQjhpawljSsMyz0znJm7UYk?= =?iso-8859-1?Q?9DBC7XK4a4HGHbXg7+Ng5Da5A2nFcScizTwQZ/9IZ9iaq8uOVewxt6qofj?= =?iso-8859-1?Q?Gks2x9Zi9XDrQdA988VeLqyS/sqV/D+1aigDZ0YgpV/uxP5aNJajQlDYcI?= =?iso-8859-1?Q?DDX6tP5nYYCjNQJY8BijDLxhMquXJ7aDSjluwr4a3oxsKDvs6X6EOMpXqQ?= =?iso-8859-1?Q?S7VSkUVJ3mHQNGtmBy+Wu+3AJGCG9eu/412rq6MZz6aQjGVWNPUDfBtrgB?= =?iso-8859-1?Q?X91Y/zwz1AOQD/wTTQRvxZAjXScIbfJbRNJJHmHz6ZUwws/Yebxd+kctN4?= =?iso-8859-1?Q?m5Jg71spLofVU1Vsr+o9zEwGzKeLqTAWYvlQUACTk0oDOZjGbJC6ecHsx3?= =?iso-8859-1?Q?IDNxJp5awOkax2IYQ6Z3CP9TwbDXiMgPSBZvGdoRRMdnFbh1xzDsFEeChk?= =?iso-8859-1?Q?sQ3iKcw8QwbRqhZo4Ysb7egm5OKBYLf4cPj2WEdv8BJsTkVQ2K0wz5pmnM?= =?iso-8859-1?Q?Dg4HZiBODwFEIES7x2C5E1HLWePcp2zN83tNFsaq3Ae0x6oJxK8ZhsVLRw?= =?iso-8859-1?Q?umj+vg1+ZMxmx3/iXmRY4qQSgaxD0A3U3unKCGUXqDlcEGgMHZYtrmG/pf?= =?iso-8859-1?Q?cR9rvg/j0c6wJvQ9Vv7UL3v/BVKiWzgAUmrytnc0AGMtsJ1kOIBvwQv83e?= =?iso-8859-1?Q?5NEDOImeEJcYa9EhnQNIrIH9+uOd3BMSGliWd8EgzBkilrR7luBt/jD+en?= =?iso-8859-1?Q?iWFykkAaxmB1rOYcLd19YFrJiIpdb0CVWwzsNwyIGXhzZYlNK3/Be6nr4I?= =?iso-8859-1?Q?mG6NruDjw1dSd87o9ufUI20RkdcUJTBd57FDn7G5v19N3nwqiYAk2+s2RD?= =?iso-8859-1?Q?8rMdHgmEkNpgKXbOsRIabR9bsG/+JrA2jUWaGkq/kt6MmrTBUOIFBiAod+?= =?iso-8859-1?Q?0RUEZBdvG0jx/2YAzMDBjSPlH+0vl7b1gtRrDLHWB5L1ynlXE/57hL/0LO?= =?iso-8859-1?Q?8VArvvf27A=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: kuzrh5Qxtd6u6b+LZPQOK9/Rj9UXhRa7wIC3x70eCn3+eNrPkvSSk0PtEgyMa9zuLYf1zvZfShCgA4CqsIO5/aehOCjpzajNyn5PDdBoXhlx0I6vClTLX1z87jwzdaRXX8qu7e5IGkSw2/FxBCg3NkQIJ2GJ0V2OWmQnymzBFDUCIKu+pmeneJfcupmLc44i0ywb34a2YtI9jeMzC/XB+1v2xjqCmuUhX9BDD2HKijKV82GfBxUUSfAIbm4U8M/agtwjqc9kHdzqM9dx0RUWgs4T/D9ihOSkFIPOC/RNJfCzWD2RiEgD3ZL7v+9OXtzVxNrlWRF8N1FeNDv20zaUCw== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4980.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 559feafe-e225-4b73-965d-08dec067c9ee X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2026 05:28:33.4679 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yAgr3VfP+QB6gxzbfaZ7Ru8C93dluWsrtcgmjJcm/JfGCYGOFu0jtufCEc26KpdkxUJDi6z4JTnQK4sqbEJL/Yq7980sugMUo6IaZ+Nypu8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5411 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c405::7; envelope-from=jamin_lin@aspeedtech.com; helo=TYDPR03CU002.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1780378216815158500 Content-Type: text/plain; charset="utf-8" Introduce PECI support for the AST1040 SoC model. This change adds the PECI MMIO region and IRQ mapping, initializes the PECI device instance, and realizes the controller during SoC initialization. The PECI controller is mapped at 0x74C1F000 and connected to IRQ 164. Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater --- hw/arm/aspeed_ast1040.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/hw/arm/aspeed_ast1040.c b/hw/arm/aspeed_ast1040.c index b736e690e5..9ae0a0e7a4 100644 --- a/hw/arm/aspeed_ast1040.c +++ b/hw/arm/aspeed_ast1040.c @@ -31,6 +31,7 @@ static const hwaddr aspeed_soc_ast1040_memmap[] =3D { [ASPEED_DEV_SGPIOM0] =3D 0x74C0C000, [ASPEED_DEV_SGPIOM1] =3D 0x74C0D000, [ASPEED_DEV_I2C] =3D 0x74C0F000, + [ASPEED_DEV_PECI] =3D 0x74C1F000, [ASPEED_DEV_I3C] =3D 0x74C20000, [ASPEED_DEV_UART0] =3D 0x74C33000, [ASPEED_DEV_UART1] =3D 0x74C33100, @@ -76,6 +77,7 @@ static const int aspeed_soc_ast1040_irqmap[] =3D { [ASPEED_DEV_UART11] =3D 146, [ASPEED_DEV_UART12] =3D 147, [ASPEED_DEV_JTAG0] =3D 162, + [ASPEED_DEV_PECI] =3D 164, }; =20 static qemu_irq aspeed_soc_ast1040_get_irq(AspeedSoCState *s, int dev) @@ -108,6 +110,7 @@ static void aspeed_soc_ast1040_init(Object *obj) } =20 object_initialize_child(obj, "adc", &s->adc, TYPE_ASPEED_2700_ADC); + object_initialize_child(obj, "peci", &s->peci, TYPE_ASPEED_PECI); =20 object_initialize_child(obj, "pwm", &s->pwm, TYPE_UNIMPLEMENTED_DEVICE= ); object_initialize_child(obj, "espi", &s->espi, TYPE_UNIMPLEMENTED_DEVI= CE); @@ -199,6 +202,15 @@ static void aspeed_soc_ast1040_realize(DeviceState *de= v_soc, Error **errp) sysbus_connect_irq(SYS_BUS_DEVICE(&s->adc), 0, aspeed_soc_ast1040_get_irq(s, ASPEED_DEV_ADC)); =20 + /* PECI */ + if (!sysbus_realize(SYS_BUS_DEVICE(&s->peci), errp)) { + return; + } + aspeed_mmio_map(s->memory, SYS_BUS_DEVICE(&s->peci), 0, + sc->memmap[ASPEED_DEV_PECI]); + sysbus_connect_irq(SYS_BUS_DEVICE(&s->peci), 0, + aspeed_soc_ast1040_get_irq(s, ASPEED_DEV_PECI)); + /* Unimplemented peripherals */ aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->pwm), "aspeed.pwm", --=20 2.43.0 From nobody Mon Jun 8 04:25:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1780378280; cv=pass; d=zohomail.com; s=zohoarc; b=MfkpM1FpNkaQiZWvIpjPr6/iwwAeW0YFD3aM06sNgIgJ59Xfo3W3gtHpqoN09KsfbFd5Dcigb0kplXJeXbQIxxbVNnr+wc9utgjhlnDXp50CuDW8vEG+1GNzrOjF5qbbOPdaXFb9jLDAbfait3DHXG387ThX2PIyvCbJpISi2D0= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780378280; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=DwqQTMcIbbeGHj4DzMKq3QP8GMmsA7i24EFJRkLzc1I=; b=GIvvejKqDZhOkknON9jwTYSe+iGWlAvMF69H2oC95YSc+8b+dh+j1CCJs/4aKthsByDtS1IxxdlsvoFu7ZOOnC2ht3/v2p0NGI5t5FKBb/ShJlsuqLRFvT1Ds3oD5rFs3iTBxiowJbS86usB1o+VzsicMR++2+zutptCLzxPUPc= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17803782803991.1127263958288722; Mon, 1 Jun 2026 22:31:20 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wUHgW-00041l-61; Tue, 02 Jun 2026 01:29:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wUHgM-0003yh-3I; Tue, 02 Jun 2026 01:28:54 -0400 Received: from mail-japaneastazlp170120005.outbound.protection.outlook.com ([2a01:111:f403:c405::5] helo=TYPPR03CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wUHgK-0002fW-6n; Tue, 02 Jun 2026 01:28:53 -0400 Received: from TYZPR06MB4980.apcprd06.prod.outlook.com (2603:1096:400:1cc::10) by SI2PR06MB5411.apcprd06.prod.outlook.com (2603:1096:4:1ee::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Tue, 2 Jun 2026 05:28:34 +0000 Received: from TYZPR06MB4980.apcprd06.prod.outlook.com ([fe80::ea8a:7cb7:4822:2fb3]) by TYZPR06MB4980.apcprd06.prod.outlook.com ([fe80::ea8a:7cb7:4822:2fb3%5]) with mapi id 15.21.0071.015; Tue, 2 Jun 2026 05:28:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=naQ+Id8j2HjwLiG6MusG8Jm0svm5EQ3G+yM3FQhR2LoV/e9jAPnz7PnroEJt0B8n7DAf9nWHgkjlsPVO7CBJ7/CbJw+kgLjhCiXL9KE8nriv60lRsxtnhvPJES00R2IpklFz/x4WHOC/2ZcEfygf3LK14xbs1JXQ5WiJ/zN7ua8apNnkm3g7l054c6iWWT8dmoWmZ3446tB55QEkrbn9qyt090/AaaEdm4yY5ITVLdboxgRRzIcoRi5P9FSFBEag4yQyLTl0+/NPkha20R2xOiq/ZtYaCbUXJNyraqqbmhyOEM8aWQQuqYYY4E/C7w9RUSPw5n+I5JyGSCTtc8G5FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DwqQTMcIbbeGHj4DzMKq3QP8GMmsA7i24EFJRkLzc1I=; b=ybBWiu8Me9tvEF8n1sSO6aGCZx+Kzi7PcjjXFLansQOpWcfoyuNH3DKu/bizTMfczTu46c3aZX+5BPeY8JuH/9vNns9rBF3YYrgN4ru6OX3RvT0NQD9eQcDID0EogEDjr9krk8hMkJ0wRLyEbva0PdLqprXA/mAQZe+MGNlVuG4Tp2/fOW3Ske9rHfRoMpidCwiQJEyKTbsX96gWmBQKANawwHb7LDDQBiyF+blzZswlQfNNxk28huKWcoonCc2JwpBuaRgIWkenec8e/e3jnyj+PmoxXNGvqpV6nCl8tLett7BkelFHoA8CcDtRRY4rsCRL8bhzyK7bC9WNvNN0Ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DwqQTMcIbbeGHj4DzMKq3QP8GMmsA7i24EFJRkLzc1I=; b=lRV3ZrHrZageANYVixzRp/hqvFDyfajpcvBnES3PyNbVUgiwRWOv5u0idFF1xA4IpWCRKupwgJXX/96RB5Ysyn2z5h+du1PdY317KTTB7IfiNC4Ywyz1gfRRIFzRx2MUOj0UOsReBI9SCVBNphLaibWkrdGLYqGb/B2dm58CfJvYlquBG4sWcUI0IwxPflbFODeHbhDR39Ekx4xxJixyo9hBCWuYT/bE4/4BD+zaUWMndjzvpegjnrPU1Gc/5Yw1Haub+kYDrw5kHoQZDbJQr3I+7fCKCAM8MF4eKUgLxGJohwevHgWnncpquGmvLV2UeAJ7euvAwOVYnA+n26LOMw== From: Jamin Lin To: =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , =?iso-8859-1?Q?C=E9dric_Le_Goater?= Subject: [PATCH v2 05/10] hw/arm/aspeed_ast1040: Reuse AST2700 GPIO controller model Thread-Topic: [PATCH v2 05/10] hw/arm/aspeed_ast1040: Reuse AST2700 GPIO controller model Thread-Index: AQHc8lComJ7O7DjJ1kCe4lV2qHyMGg== Date: Tue, 2 Jun 2026 05:28:34 +0000 Message-ID: <20260602052827.1535299-6-jamin_lin@aspeedtech.com> References: <20260602052827.1535299-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260602052827.1535299-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYZPR06MB4980:EE_|SI2PR06MB5411:EE_ x-ms-office365-filtering-correlation-id: 19c208ea-06cf-484e-0a3c-08dec067caa6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|56012099006|18002099003|22082099003|6133799003|38070700021; x-microsoft-antispam-message-info: ePCl+O9Y+72Nz82rqRE3aMONR+MCXcCvCDpG6MuH6eUIryfIdqtSYj5zDqs/gIuQ/zGkYe1jElfJdH7zbUCJ++9gOwDZ6JzyslTm3kouoA7yRdhPXdnQLz7iBysmVJ4CyTDrcjTOxkDaxlHeujZOckszrP1j7QDWtDlaI5rIb6GJnERr3qt6VtVgzoRC525EfGdGrdyprSZQ3EFe2XOcDaMSC1i90LglyKo2esu0jg0yJbkUsEK6LTixdL2kd3pUT21wSTCX9f8wqS7MZCtrqvBPhprqgN5c3e97GwjEhjq/MbNXO5T9NuExzWx7Lox/CTAKN23z+pRDBM99gSbHCqaVe8fAh/Q/6339470lqx5tRWoYYo0VbHlthY+0h+Mj57P3CWJQNhuy9KQ3dkXmtdo8P3voJUGZgpsmIr5ZD7eWeilu5IpLH3IGu1yGCVzmuq4tTLWUW81+rSpjTMnt16MIal/yrKavYzV7zkXOlIEA8HQ7UShakKjHGdQouqkVFeUv6YDzsAmxv99wtv9guDh8N57o8Lqj8VdeWGJxfNEm+dpxTOFFrVFQHcRt7kYdcFEUQuDsiZAFj+9KsIkWvxOi0x5p4r6hK2NxzW2iPuHN3ouGmK8mH2l35aINc/5UH/GECxXfgGHfndAS4fbySWn2Z6JpdLF3dZrqGQoPkHVjZ5h6MeeeTNEIulsPO0D40LY6dEym47WLim3OCtQL5sLINMgeJEeMZygMZSvMbMGcupf8h4Min/2ouUp0hdwo x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYZPR06MB4980.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(56012099006)(18002099003)(22082099003)(6133799003)(38070700021); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?/i+b3nrUxdcjAjnEhfUHAtT0xCfxpGy9LPFL56uDYBc3j8fBQsHG1orbXb?= =?iso-8859-1?Q?+/X+yCngTzCiYK7nDVt4a9+ZTxPEdBnxORNBKuYPwHZRngz2Z7bN23b7uI?= =?iso-8859-1?Q?d5+0TdGX4mv/wZueThK1wYKopZWfd/uS1TbF6itTMcPCr6SIrbxIUURYL2?= =?iso-8859-1?Q?0HeYQa1YO+awQsnuUjB8/sDPvdO5xdWMFDkFjdnsQ4I90DtfEmQX5DWsZO?= =?iso-8859-1?Q?k4NX2Q081sCDqlZzcJbfMgLW6E7kAkunJ+rbN4jgq+8AzI1sNCOXy5l74F?= =?iso-8859-1?Q?VYo8zYZzQOYAAY9Wtg2oVPsSC3NkIjlgu4/qI24lkpsgwCfV/GPfRF5b5o?= =?iso-8859-1?Q?w7VA4Nst8FL27Ss/HeJ5szsu3/qT8DZ5BiGV1qVu6EcCOU6fKhldS2YO3j?= =?iso-8859-1?Q?oSoDrUKwWl5JcwLab+xqLdZ89BM1XuRblVyA9FkixT+CSaAQoGR2UXxVF2?= =?iso-8859-1?Q?h+Ng3QmaJ6GWvpZA/ndCfiUBAQi3zvLWfHt4/L1jMNnCL/6DxWtpOUtCNL?= =?iso-8859-1?Q?2XJvLMZZKTzOV1YgmPC1PU7RCAVsdde9jLjU0f4z/nWnFbaDm93Hc79R6G?= =?iso-8859-1?Q?jYc0sHFIp3qdaqaby3joQNrwtOuoE/HT7d1efru6joWGFSbkc+zzyh5Yc1?= =?iso-8859-1?Q?3UztEi/KMqbDqjpfH7wjNjyZFNPmjUmqgq8d7yOxYQr0669lRLCEL3lm2x?= =?iso-8859-1?Q?hg/bUP9s1nMCNHUlEMyl6ZTM9Hmo1uMl0jVHMd14iRKOCwpCyWuJCPfTzt?= =?iso-8859-1?Q?WgolnfR+dKon7fciJRxcXy9lhTYDMMlhfXMP7eip2Ury+ap2gkJBIyWH5Y?= =?iso-8859-1?Q?Eyxe/a59QJuj8MugCk9Kn1bSJgZ6/DbEhVqqGjf0f8gvQleg+u3Y0oL4vK?= =?iso-8859-1?Q?7FTU2lpQx7HKoSXqlWUvpdfnXdNFvctCGt0DgeTQPazlBL0kxb2q7ZAbVG?= =?iso-8859-1?Q?0/EOVG/JhpCSPLOjr8/6SSiwtnxAzlERdXBolJd5mqC+yHx7jXLgWtibO8?= =?iso-8859-1?Q?VA60buLw0+ioyvhqGsd8MxN6I7rJ8y5viIsQZcLmO9wkibFdpFF/nFXkYN?= =?iso-8859-1?Q?wU5+e46XXgf3fksnQiV5NOp1I2aZo884XjnKKJLHk4RDdIdBUJQaZGpu3P?= =?iso-8859-1?Q?3ZNSqu14PUw+Wt1rp5N7+0LFBPDU8v2/LXd1rHQ1a5ZRrBNyuShD/Kc0ns?= =?iso-8859-1?Q?mkdar49A2X2A3Lg30z/sz5dd31MS342VhlfVQUEjbcjOYi4K8+T831DDRL?= =?iso-8859-1?Q?t0MGAbfA4crrGLbeopf3MblqebjSjxuHnIRFv9oQPgzq+WjDOwCKILtQQq?= =?iso-8859-1?Q?aR3EJf7j8F5Z32oAMhQFzCdsfx+JIppxhbhlgUEXPfBX4hk/MhsHfVXais?= =?iso-8859-1?Q?tQbAOSEVG75VIcKFRJGefPHzE88AYrq37uckCQkHv0WKbAoN620yOuFoUM?= =?iso-8859-1?Q?4u+LS2n8dPalexFB72OqSCTkvd3MCLBjt3ELW97CzStH9l9Htp4Yiyjtff?= =?iso-8859-1?Q?815QiBJ8vwsDLNDKAiYf9A+7esYHMkH5MuIbYZUJ1An8PkhLxKIc3PfErj?= =?iso-8859-1?Q?BUIKDSkuBvSBjbNIR1pSyFPI3nTHktwamRYLAYaQCylqcq3JBXLJwVtruU?= =?iso-8859-1?Q?LzCxi5QPk0nEuqQhbu9+s2GA3ZSiH9ZNeFJjQUqfznRp/MrLhgwPSJwTFv?= =?iso-8859-1?Q?cDOGXMwW98TavnvsRbGlIrZd/12MpgxMzbHubBqcwlKx+vVhzEfNFCbb8/?= =?iso-8859-1?Q?Wgbw6fLVHsJgNNMmYyU6w3Mdwno6wMW9JFhjMuW/9UQdL9HC+OhXKRWIZU?= =?iso-8859-1?Q?V94Oo87EBg=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: jaEpqWwV8ubVEU/EYCvKMaU5D6y8j4gHrqUSlQOZYm8538JW9+r/jkroqGf4zA+ffo0nTn7eLWAnzoU/gUZOFWsLmLasy2XJVNf+8ovCkuYXW1ddqyX/UZN20J7Rm1sRusz8wLP6JMsd1xwBdqkVGFgIB7lNTKerFXwA1XaO7spcwr9h2nI5sQC/xFlkdZ2XAEKoqv0SwBxvkFqdhWVsqJ4JX1vHu3aRL5Yf+KMcIEFrlPVE08PS8HPpSCmvIOFtV/9msChGhwXP+CAeWGj8GvbRf23EG2DDiLGdVwUQbcHMP1tGYhzYrGWrQ9BeceD0mXx1XP4aNLGtArSZesoLCg== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4980.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 19c208ea-06cf-484e-0a3c-08dec067caa6 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2026 05:28:34.7132 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FfdbpohZW/6x6uwSkwGK4j0IZVMjEpzaXVXjspxl6PlpWwrEeg7BlOQqJ5LjLQaJMCQGe0g7vFBtjCCkW/Lnz11VmWxrQO5FE7NPnzAqmC0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5411 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c405::5; envelope-from=jamin_lin@aspeedtech.com; helo=TYPPR03CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1780378282277154100 Content-Type: text/plain; charset="utf-8" The AST1040 GPIO controller is compatible with the AST2700 GPIO controller implementation. Reuse the existing "aspeed.gpio-ast2700" device model for AST1040 instead of introducing a separate implementation. Add the GPIO device initialization, MMIO mapping, and IRQ wiring for the AST1040 SoC model. Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater --- hw/arm/aspeed_ast1040.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/hw/arm/aspeed_ast1040.c b/hw/arm/aspeed_ast1040.c index 9ae0a0e7a4..c6b22186ce 100644 --- a/hw/arm/aspeed_ast1040.c +++ b/hw/arm/aspeed_ast1040.c @@ -111,6 +111,7 @@ static void aspeed_soc_ast1040_init(Object *obj) =20 object_initialize_child(obj, "adc", &s->adc, TYPE_ASPEED_2700_ADC); object_initialize_child(obj, "peci", &s->peci, TYPE_ASPEED_PECI); + object_initialize_child(obj, "gpio", &s->gpio, "aspeed.gpio-ast2700"); =20 object_initialize_child(obj, "pwm", &s->pwm, TYPE_UNIMPLEMENTED_DEVICE= ); object_initialize_child(obj, "espi", &s->espi, TYPE_UNIMPLEMENTED_DEVI= CE); @@ -211,6 +212,15 @@ static void aspeed_soc_ast1040_realize(DeviceState *de= v_soc, Error **errp) sysbus_connect_irq(SYS_BUS_DEVICE(&s->peci), 0, aspeed_soc_ast1040_get_irq(s, ASPEED_DEV_PECI)); =20 + /* GPIO */ + if (!sysbus_realize(SYS_BUS_DEVICE(&s->gpio), errp)) { + return; + } + aspeed_mmio_map(s->memory, SYS_BUS_DEVICE(&s->gpio), 0, + sc->memmap[ASPEED_DEV_GPIO]); + sysbus_connect_irq(SYS_BUS_DEVICE(&s->gpio), 0, + aspeed_soc_ast1040_get_irq(s, ASPEED_DEV_GPIO)); + /* Unimplemented peripherals */ aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->pwm), "aspeed.pwm", --=20 2.43.0 From nobody Mon Jun 8 04:25:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1780378173; cv=pass; d=zohomail.com; s=zohoarc; b=C80Rvq3uORz3HM7jH1o8oEQVtL02l/BkqWTpAbooKEGhKIMcigemLqxN2JLrkb2hsicS6pMnX2RQbnqe+43+hIUxUICPpilvAIFAKZ5qJsKhgRLKd5UgW8qtawustH8FeGX57FYKOjmk/FrdmZlAg5zNs2M5BWLqoqIUnaNoGlQ= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780378173; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=a3OsqHROOE6fTpnLl+1tLFFrsZTzXXgi1xiWiyPUlGg=; b=HlI9K6TFSvnJEhjltQoJI+pONL0lFnub5Z0k4qPEyF5N8nWyLtRrWhi4r6kroQ8HFsAlBWGhc4r4USVQZQKZU63gnBVJZ0Wv50IHznXdD20HKKYYx/EX96PH8zEuXHfhoJY56uzv0v0SFGQdiR07vVbQIxY2bJbiYVfchrsdBSw= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178037817308589.81151323420511; Mon, 1 Jun 2026 22:29:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wUHgW-00041z-VB; Tue, 02 Jun 2026 01:29:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wUHgO-0003z3-P4; Tue, 02 Jun 2026 01:28:57 -0400 Received: from mail-japaneastazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c405::7] helo=TYDPR03CU002.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wUHgL-0002gD-89; Tue, 02 Jun 2026 01:28:55 -0400 Received: from TYZPR06MB4980.apcprd06.prod.outlook.com (2603:1096:400:1cc::10) by SI2PR06MB5411.apcprd06.prod.outlook.com (2603:1096:4:1ee::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Tue, 2 Jun 2026 05:28:36 +0000 Received: from TYZPR06MB4980.apcprd06.prod.outlook.com ([fe80::ea8a:7cb7:4822:2fb3]) by TYZPR06MB4980.apcprd06.prod.outlook.com ([fe80::ea8a:7cb7:4822:2fb3%5]) with mapi id 15.21.0071.015; Tue, 2 Jun 2026 05:28:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Aag5AcLBhe1yZxwDMTjoWTJFrCBvgzqhgnQ614YzZgAPz3hIvoqbgsIaepn7t7WW3rgpJL+7oZ8ol3uEuiflKlE2NCSaBv5SVwGsTvInFRI06557bhRj3fb3P/uRyTaXdQUAnx4Jr7w8OBle36M9vFBfLUMabNPVTupn0GVqDcF+u4G3x8VdQ4oDPTWmg3tXppkBkLNr5auOEJRnRhcL19akvBsN7FioCZaVIuKO9kryEi3aiHLD96lFBWnd1Cqwl6/kUd8y6lNdTB8yTm2KSuLKXRooBjjzf4ejZvg9kmyM20eHNK1TDp8Jzr6zTIR3UCuzyhzNQxJfSNyjzxbpfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a3OsqHROOE6fTpnLl+1tLFFrsZTzXXgi1xiWiyPUlGg=; b=CytEcxTnV1TU0gy8p2+d7DFrin0JBoxMA0Mmmc31oh2SUIF5eyZdv7xMIj3mAciqFDox+Fb9i7VmCM0ebDpPkLtLx6DXO5JC8B99zoAG9tYtQ/NN/uaQ0/312JvYMwW0uF2St5fpvMdoDkfiTrZLbQfHRPiqBOIDfxvFFg23exVmWC+Npcu/eU+8aVrWKnMF/6U8xK60tT2JFmLXzjjsqP9j/q4yetwVruKNX7w/hVQvaTko3gkHxmfPZMjFF0OI892cDuYc+tnS0u2i2P6oOqtvx95U/22QNUHEq07HY9AYbTqekI2mRJ/WxxhZCDT8JF+gLVJ+Fixr5ohpr2eMWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a3OsqHROOE6fTpnLl+1tLFFrsZTzXXgi1xiWiyPUlGg=; b=NOjDXtOikq5qk8jjT1y2cPHGqP51R9Tkn7lFtDy2ZyheJTjcjyCwAhqicGAp3tfEBbzw4dbJAlogUrraOh204z8uOP5NSdPEK+mFqhiakaHJyjxDe8hU1BpPnpjsV9zaJtZQGBxAdIL6u6s+eu+bpSBn0VSVLKoZFfwItthLUlD6lPsqCozxXiPKEoWRe9/y7rd5+xT68eqc5oqGe+a5HUrOCP5jN4HkBpF4RuVJ7N5kKLeUX4bLC1TBuPuDlzHcb9UpeUK1QUR724UL40YozVGIss//s7yGy8iHM/NyBDnqo59F+GPm/SaUW30ZLYinTNMc2GWn1O7XsWDUh/UuaA== From: Jamin Lin To: =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , =?iso-8859-1?Q?C=E9dric_Le_Goater?= Subject: [PATCH v2 06/10] hw/arm/aspeed_ast1040: Add SGPIO controller support Thread-Topic: [PATCH v2 06/10] hw/arm/aspeed_ast1040: Add SGPIO controller support Thread-Index: AQHc8lCotRTeV5O6f0mL/H1WU02onw== Date: Tue, 2 Jun 2026 05:28:35 +0000 Message-ID: <20260602052827.1535299-7-jamin_lin@aspeedtech.com> References: <20260602052827.1535299-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260602052827.1535299-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYZPR06MB4980:EE_|SI2PR06MB5411:EE_ x-ms-office365-filtering-correlation-id: c217495d-0a6e-4754-8cda-08dec067cb68 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|56012099006|18002099003|22082099003|38070700021; x-microsoft-antispam-message-info: r+nbN/Tmmz0eTjiGkJ4UJBRnCluQgIPAKrCzoE22J1uQdCxLFd/aJ9Ps/Kad2r0p9ZJ8udHSp0rt/246TJ24cbKEoEria3qhkZDOFOvBSCfJJu5OnjA2NWIBTgB/0xj8HF/4NO1KY7dgCot4RQRnG+ObJycAptsjXzVNh70yjuJWroUAODGN+8Bf0yvSjJeszdcOPS5KcwYIxlrUfZPvrEblaqrj0gaRTuEBsGh+CPeyu4niItBVBo12PuDcU5cpOQty6Gat9h+pfJim311r5kwDKeNXp6z3bUopl3TuzK7AWEKzlUxPSuX3w84NDnMC8lqT7fIf8vftlGLUeq6oa/hpto5IPdfLf5yla49rnIlSuywmBt23RsGWnLkXdMh1hhf/QT4bBdSwapdnnyC2WUZ7Uuo0GL1k/ASE7N9TGBvKRC8pGv1XME8gN5xCZsd28tejYyPTZeurHGZEIDyqGSExMnK+M0XIbgoz/37rHTsOa5pVXKq8SAQxOAhtG8hf9fDYr59We2Ds4rryyvpTLEOg5W857sOrH3+Rc8eg5lKhUkMNqJN3aoYVQgakFFAKolW5JcM/vMyQQSFbazf2lMfSFc8PPnEKFhT+bi3T/EuqqxMlusNT2DYy77FKAisbW7x2JLErYZ5WgzcLsQY3rqo/L5myrAqA8VF8hZhKqvHsW/zyJZsEA/GfYv0DAs7OzA/Lm+ZM6gGmSWfqP62ZxXMvFcfMmnDtSMGmNm01oJ+O7JMTVKqOvi+wGAHzRsFR x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYZPR06MB4980.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(56012099006)(18002099003)(22082099003)(38070700021); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?PKuGIcjAsR4rsPg31aIXy4LPB4b9aHW2DYMcgwPCy8mEQVFVjciLXhA0s6?= =?iso-8859-1?Q?UknaLTE7lVpLNfSscJfrf2fPoYE8YGt1nRAtTk/KCjwHQR5nA/CKcLgXWT?= =?iso-8859-1?Q?CXl2FHjCdPSl58qzuTLqpVH8ObrEeLynkvrHuYE2xKS8GtGkq66CrZLV6p?= =?iso-8859-1?Q?Q70yVj8hYVfpGBTMsxc5kuN/zBz24Ze+bpcuke+UDPalOZi/P3Z0aTdHrp?= =?iso-8859-1?Q?0V0O+5M69nXkirXZtBtMGK+u9zfQ7tDMkbeJRX4t2hUCzMGeI3o2c5KkYn?= =?iso-8859-1?Q?D5CC2hywadsCMwOD8KU2k2ve5Ao5ivUBcC1rrn0gmiHIKgc4+JDAcOSQUH?= =?iso-8859-1?Q?ltFiTEIw638d0N78I9QIc+yMRRgZLWclk1D75wMsRElGPWWewnbk+jR7xK?= =?iso-8859-1?Q?Av7vMKK/r7CkgxBFxbgWIWZnmJqkbhR+gXyEv+nVQyRYxUVa6JqGw+4J3h?= =?iso-8859-1?Q?3AnKwdDDBOnBsuoWjpsEaeBaUTW5g9s1tTJP7obtgGpOaIYFheQFBf2D3W?= =?iso-8859-1?Q?4ZKQtcmZrex+H3b3bNAQkkSnSsWUy/kdsj1wk3KYcO4LOdsbA7jykCy0V/?= =?iso-8859-1?Q?xaFdpmKs/90Sd7ythF8JHChracGitcr2q2aSai+6Lqf8O1LLk0jyfJ+C44?= =?iso-8859-1?Q?8EmQR8FupGzONLJYamVYS0VDm9ubx3jQo7pKcjfH/Uze83UCFznOCMQhlW?= =?iso-8859-1?Q?nPdP9LY+MyEiYtj6XlIkL+BvGvdlmcE4YnXml7RyzRZpphJwtejj9WJkGY?= =?iso-8859-1?Q?vcIxxvkju55lWx/Mu4ab4yzsqoqmTNY8IQQARwFdIwu7EEo8AEqWgpC+hH?= =?iso-8859-1?Q?WQFyLJnEH4UfRF+KPsZeUzOsi6PHSU+k5zs1TX6LM/ser9F0F2RpKzCTwG?= =?iso-8859-1?Q?Da/fGu5oz36lb2QRyI3XZUWUK8LvVMCTLHmEym8pScUyfGgOBwpdtA1Aop?= =?iso-8859-1?Q?/lAnt5tvTR7Oj/Q83pjPBWSDLGPnKVsIGsO0jNmTFu6PYzLnz/yTfzpYoo?= =?iso-8859-1?Q?LIlp+7GR/VGs/lHUUKbqK6pPZxG439NaYKk8m+AqVJ0AE9vCQU9XP6FI8J?= =?iso-8859-1?Q?+jsRJscNcI/oVB708sFUfa7AL5SDKEE3Ju9Tyqom5J1yoox8zokb+CbH/f?= =?iso-8859-1?Q?QyN3q0J1w/BumuVu8ACIMdzvZb6YmlK+L2S7a4yb59euo7sdreEjmkLk8E?= =?iso-8859-1?Q?F++e8lJuNf7DUETuOsLcASNpis6AnL5uBeYcV+0WkJXErDXauQx3BYvesd?= =?iso-8859-1?Q?Bn8xP3HICUp0YMw8VkNqaoSnJiqZsGg3Yzwt1prhS6XcPTDx5FHSlh2aeN?= =?iso-8859-1?Q?uxVK96ZuMkD7yytiz0QjjGpT2/dyTMuawXlmMv2jyg84QzU/5tOKwYC4DX?= =?iso-8859-1?Q?7DptPd9DIOs8SEvQebZmYnW9r+12us5yudWXiHXGSyG6cQtyeYrzEQ8nwc?= =?iso-8859-1?Q?ndmzTvsiaj6n8DEwEf/Zl+9wHSERUKIshaNCxKHgt4ZzYlyfbQbauLlE0q?= =?iso-8859-1?Q?kngQntfFAfnt7Z8EqjeqbS/ArdojEU/PuI3ewncZbH6egXpmVzik1uW+rc?= =?iso-8859-1?Q?mZoGUZSYv+yzAgr3VJyLGeB09fCyFKlXrnLMbU6PHl5Si0cptwX94esdwR?= =?iso-8859-1?Q?3WcbrFYt8brNkfIx/Tbn8uyDQ8a5OvIXZdpA0RDQQI/nYc/zZzxAl6KkzI?= =?iso-8859-1?Q?BuQsfDS1S49kUqkpKeVX+/pILMq2yYdxF9TEA+mk7aq+inJMImJbBBtT0m?= =?iso-8859-1?Q?5Q8cGwVZ9rFV11nclpepo8W6rX/Kx0LZ9Dr48E0tF4E3+PPnPV/2wRvSNF?= =?iso-8859-1?Q?C/1getdRcQ=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: VyZhUTEEZc6bKBq4W+VNDOih8RB1UOniRvV54SQpKIoXIR0wdF/47ZRwCQifyFDyo/+akWujShWO1mXytEWgwykGgj9O3dCjD/00cYnmSknNWbx129DLQGV3O4mr1wuPkBKSUOfaE7TMmFSSx+8A42SFuQ+H0p+vPPw94pyfaPcXnzyMQET7Yp5h/lsd+ig7bS2T/xclOUFokIZqJZBsQs7JLTRbwoaYlVe+oD+rAfCEox0qTxyy4F/PXtUjhof/vYFTIKcRAnMX+DczVBqtZvN7yVK4QZPceNUTro9sbGBaDmjGk054XmAouf1upUFYp28j1Br+gh5uaNec/0Qh8w== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4980.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c217495d-0a6e-4754-8cda-08dec067cb68 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2026 05:28:35.9390 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lLgedMBAfVr8/DWukTPCT7EkL7z4CywL2xjD++1Pcwt4rrITVw7TwoEla4wZiuIIQmGBJHI2edqqSS6F9qwb0D986YpmoFk0v+CazESHMV4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5411 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c405::7; envelope-from=jamin_lin@aspeedtech.com; helo=TYDPR03CU002.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1780378176802154100 Content-Type: text/plain; charset="utf-8" The AST1040 SGPIO controller is compatible with the AST2700 SGPIO controller implementation. AST1040 contains two SGPIO controllers, so reuse the existing "aspeed.sgpio-ast2700" device model instead of keeping them as unimplemented devices. MMIO mapping: - SGPIOM0 : 0x74C0C000 - SGPIOM1 : 0x74C0D000 IRQ mapping: - SGPIOM0 : IRQ 85 - SGPIOM1 : IRQ 88 Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater --- hw/arm/aspeed_ast1040.c | 29 +++++++++++++++++------------ 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/hw/arm/aspeed_ast1040.c b/hw/arm/aspeed_ast1040.c index c6b22186ce..77211ce1f3 100644 --- a/hw/arm/aspeed_ast1040.c +++ b/hw/arm/aspeed_ast1040.c @@ -56,6 +56,7 @@ static const int aspeed_soc_ast1040_irqmap[] =3D { [ASPEED_DEV_ADC] =3D 80, [ASPEED_DEV_GPIO] =3D 82, [ASPEED_DEV_SGPIOM0] =3D 85, + [ASPEED_DEV_SGPIOM1] =3D 88, [ASPEED_DEV_TIMER1] =3D 92, [ASPEED_DEV_I3C] =3D 96, /* 96 ~ 103 */ [ASPEED_DEV_WDT] =3D 112, @@ -112,14 +113,14 @@ static void aspeed_soc_ast1040_init(Object *obj) object_initialize_child(obj, "adc", &s->adc, TYPE_ASPEED_2700_ADC); object_initialize_child(obj, "peci", &s->peci, TYPE_ASPEED_PECI); object_initialize_child(obj, "gpio", &s->gpio, "aspeed.gpio-ast2700"); + for (i =3D 0; i < sc->sgpio_num; i++) { + object_initialize_child(obj, "sgpio[*]", &s->sgpiom[i], + "aspeed.sgpio-ast2700"); + } =20 object_initialize_child(obj, "pwm", &s->pwm, TYPE_UNIMPLEMENTED_DEVICE= ); object_initialize_child(obj, "espi", &s->espi, TYPE_UNIMPLEMENTED_DEVI= CE); object_initialize_child(obj, "udc", &s->udc, TYPE_UNIMPLEMENTED_DEVICE= ); - object_initialize_child(obj, "sgpiom[0]", &s->sgpiom[0], - TYPE_UNIMPLEMENTED_DEVICE); - object_initialize_child(obj, "sgpiom[1]", &s->sgpiom[1], - TYPE_UNIMPLEMENTED_DEVICE); object_initialize_child(obj, "jtag[0]", &s->jtag[0], TYPE_UNIMPLEMENTED_DEVICE); object_initialize_child(obj, "jtag[1]", &s->jtag[1], @@ -221,6 +222,17 @@ static void aspeed_soc_ast1040_realize(DeviceState *de= v_soc, Error **errp) sysbus_connect_irq(SYS_BUS_DEVICE(&s->gpio), 0, aspeed_soc_ast1040_get_irq(s, ASPEED_DEV_GPIO)); =20 + /* SGPIO */ + for (i =3D 0; i < sc->sgpio_num; i++) { + if (!sysbus_realize(SYS_BUS_DEVICE(&s->sgpiom[i]), errp)) { + return; + } + aspeed_mmio_map(s->memory, SYS_BUS_DEVICE(&s->sgpiom[i]), 0, + sc->memmap[ASPEED_DEV_SGPIOM0 + i]); + sysbus_connect_irq(SYS_BUS_DEVICE(&s->sgpiom[i]), 0, + aspeed_soc_ast1040_get_irq(s, ASPEED_DEV_SGPIOM0 + = i)); + } + /* Unimplemented peripherals */ aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->pwm), "aspeed.pwm", @@ -234,14 +246,6 @@ static void aspeed_soc_ast1040_realize(DeviceState *de= v_soc, Error **errp) "aspeed.udc", sc->memmap[ASPEED_DEV_UDC], 0x4000); =20 - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->sgpiom[0]), - "aspeed.sgpiom0", - sc->memmap[ASPEED_DEV_SGPIOM0], 0x1000); - - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->sgpiom[1]), - "aspeed.sgpiom1", - sc->memmap[ASPEED_DEV_SGPIOM1], 0x1000); - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->jtag[0]), "aspeed.jtag0", sc->memmap[ASPEED_DEV_JTAG0], 0x100); @@ -269,6 +273,7 @@ static void aspeed_soc_ast1040_class_init(ObjectClass *= klass, const void *data) sc->sram_size[0] =3D 128 * KiB; sc->sram_size[1] =3D 16 * MiB; /* Hyper RAM */ sc->uarts_num =3D 13; + sc->sgpio_num =3D 2; sc->uarts_base =3D ASPEED_DEV_UART0; sc->irqmap =3D aspeed_soc_ast1040_irqmap; sc->memmap =3D aspeed_soc_ast1040_memmap; --=20 2.43.0 From nobody Mon Jun 8 04:25:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1780378246; cv=pass; d=zohomail.com; s=zohoarc; b=kTFIelkuuVg0o7celooKafXweVz7WEri/b2cqUm0powtSGd5GFNyKwejol361L1o4O8Y1Ea1VAMXAAxXqUxbNtkfzvQg8EeACBTs8bgAf/O/+wDSGDmTn7JPEiUMWRGT6k0Fy/rcLeNESeUXOOzGdQN0w1ZMaNNAHnARtVmaba4= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780378246; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=5Nfl4QAPNWGNdHhXByDOkhIZW8XVzz3hkMhnpx6zNpI=; b=neUwmAHYyzHglkYS0vQzX5mFeIZVQdWynkjYZUmmNKsNbWEK8hWw6MGkPr55OL3ssfLtF53ffPGmjlKAs6/kchdJWjWMeffmisO3HTwZ3I4Sz06wz2JPrcmdk2BnQAwXAPmFE8EeLyPOQT8lZ2MdqlpJyGgK50W2udEZbSzuznI= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17803782465671017.1579261018574; Mon, 1 Jun 2026 22:30:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wUHgb-000433-6k; Tue, 02 Jun 2026 01:29:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wUHgP-0003zN-M8; Tue, 02 Jun 2026 01:28:57 -0400 Received: from mail-japaneastazlp170120005.outbound.protection.outlook.com ([2a01:111:f403:c405::5] helo=TYPPR03CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wUHgN-0002fW-0A; Tue, 02 Jun 2026 01:28:56 -0400 Received: from TYZPR06MB4980.apcprd06.prod.outlook.com (2603:1096:400:1cc::10) by SI2PR06MB5411.apcprd06.prod.outlook.com (2603:1096:4:1ee::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Tue, 2 Jun 2026 05:28:37 +0000 Received: from TYZPR06MB4980.apcprd06.prod.outlook.com ([fe80::ea8a:7cb7:4822:2fb3]) by TYZPR06MB4980.apcprd06.prod.outlook.com ([fe80::ea8a:7cb7:4822:2fb3%5]) with mapi id 15.21.0071.015; Tue, 2 Jun 2026 05:28:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pViv1jvLGTj6oNQNH28PZjdiQs7ZJKpZxzaAuOOwiHV4m4eiwzBu6WcVIaAu8Fnk6TICrSO31qlIV9d/xuejSGVH3lPYtnIm4qDmbIxKOzTOUOoqHK8syggoT+PATlFlaRApQSeizhDYpMXP5ommOQEkJshImCigv7OuyBkYrE2Y8NBx8VRY35wdotLMhSQuBRK4/dy8dpHh2bVIMcJj5dP1wb1J/QyLgHhk94YR0h0ZC5flDJumNd5VfzV/kvlpgI/wx0l83KQd9nVGiwMvtku6QrVEgqzwsRRtcVGIjxz6GYGT/05Q2yDFEzaHvxpbf8JC3etjw6CMYo/Qh/Ipvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5Nfl4QAPNWGNdHhXByDOkhIZW8XVzz3hkMhnpx6zNpI=; b=andoNLbs8JRTGkxlGSOoNDR1siek6iIZKOJT1Ufjbt/XjUQgRJssrclyOcPA8AnAdwhlwoldI6+pCMTUgss3tk+jHtMCYzP3VZRhDRQv2yn7ye5aLuxkFVaZb5Te5KkQN1EdGAOs6+yXN0KjUxjtxVxQWrlevrGhwh6JGe74QWhVLVhfeBhlxAUSba9B3h5rUuX1hjepYTiiDsc85SkLdJtSfCKFlrQtIXwt0I0apIFyPTlTkCwq5NFET/L6f9vWcWYmFHEKXkm68Zp23TqztcgJiRy9kFIXgB/PdXHfxNO1wEnNbcJcObWBPVGYjMKkXPtXPa1f+FTbDtaN6St6XQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5Nfl4QAPNWGNdHhXByDOkhIZW8XVzz3hkMhnpx6zNpI=; b=TMP/1g9Dw+YrRFe34WW6QXTdGGdIpMyaB8DUH8vlbqNCy0EYswrFx8SagfUO0BVYpel3pSsgpNiA0M6/OJRFlbmTdqqqGYWc9mqSIKHdIpGaWdK7wCvuNspICVWQ94je2NvNN9K6ukIAfYdo1Okjxzp6FEq2Wk71Bbxf1PZpzdwZbss1InxPIy7JQb2ZV2K8V0b1xyWglR85muI5oMkh+UgJD+IBJ8kCzpDhXllpSgtvg72/Vb1WApIPbSx7056DMl0tmE4CRjHo1Guuig5/1CDgt8kpBtaUFSdCeWo8QUt7tJhB/URhr2s4HLuqJ47eTJWo9h+UCgZqE43/cRguBA== From: Jamin Lin To: =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , =?iso-8859-1?Q?C=E9dric_Le_Goater?= Subject: [PATCH v2 07/10] hw/i2c/aspeed_i2c: Introduce AST1040 I2C model Thread-Topic: [PATCH v2 07/10] hw/i2c/aspeed_i2c: Introduce AST1040 I2C model Thread-Index: AQHc8lCpVLHcmwklNkWfSlsdKf/XHg== Date: Tue, 2 Jun 2026 05:28:37 +0000 Message-ID: <20260602052827.1535299-8-jamin_lin@aspeedtech.com> References: <20260602052827.1535299-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260602052827.1535299-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYZPR06MB4980:EE_|SI2PR06MB5411:EE_ x-ms-office365-filtering-correlation-id: ae31ae4d-05cf-4283-1ca2-08dec067cc16 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|56012099006|18002099003|22082099003|38070700021; x-microsoft-antispam-message-info: a8U8xiZCqfqLpCdHT+6p8bJcC4w6P9mco98pJBX8XqXRmn17NdUHlwF/2pd04a1X58YgNggnot51Zkc9JSCTNbwycypOZWnJ88/CvpHy7xZfypMxsgrrbLASbiaNY7SzGP3LZ0HG6XZiqBnhoXiU7pfBqWem98hsb290G8FxUj8J4LO9OjxiiljHt890cTAIdZeTWlgGplbNmbgdlrq8ol7gHf/OLa5kawtaJ3esyUmAKxUQ//yrFWT3kqrJnnJVPJX5l9rH1VL24g89vp6PzXkt+hr/SZ14U4yXGwlcod7VJB5Evb8Sab9UpQtkXsq3dYcQV3ucZl4DoGESF4SdFc03chnbdtTdlOUGr/c9TClHMO5VQotF15ZGSjsNbkhZbeJuLABTMjvdQCB7L9mURK+XR7lWIs3Fv6oBAu0XQTEl/VetM+mRoyeJHDU+zTm+/1en8bB2fixhKEBroVry8VKOZevGQ7ThAnKmtl01yGO2od5vtttC2Nv0+suYhxVADrD0yNajxm8AYgF+K6LFtAzD6t9qFo8jz4HN7sOzmHLP6jiuY7svg/fyfs+Bw2b4Sc+ZfxPUJfr/FOel8xcpqLMPcf5sSIxf2UsmhFku2Ao/Lm21ZnkMXN879s4LMoh2JFQciequclZOeuL8rWQ6smCHh5ONrCJ9fG3MxfZoxwR4eNfkqa2somf/rLud/R8tMMf3j5SCP42U0AyDFstZxgUjEXo55TSdW6IRHwSXl9pXN6JrB8eusMj/isXYzB7G x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYZPR06MB4980.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(56012099006)(18002099003)(22082099003)(38070700021); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?eYybDWEq56z3EYHl1YtgeZpozsB/2Sjxa1ZjeaRxSGVrJ2qWlaUIPBW3rW?= =?iso-8859-1?Q?V3aF8RivDq6OnBUUZ+ULqqokJptuq4sUjUqKM2Kv7DU2HUJyyw9Yb1azxU?= =?iso-8859-1?Q?gjNkO2q6+eVOkC54vsSN8+4sGty7/aCxxeD1amuZfFLxlZCny2oUiB6+il?= =?iso-8859-1?Q?acYZb/HqyvPhVoEODxYT7elQSGpBL3N5zR1FGzW0waVKlnYGKNYONbK0pe?= =?iso-8859-1?Q?FA+kFbjMOtlZ2XCEohmUNhwFjuCSv3k7Pboly2qVYMTbcCISSnQXCiLzbS?= =?iso-8859-1?Q?+DchU5oeq4MB4XXweKu4HoXcH0zZSfY+lqkKIWjdCFHGX8CHZ3awYwP3+7?= =?iso-8859-1?Q?9GYNtntfKe4UtMJHwa4JPc1e2ciWniXexv1SDqwUXJgY1V0tztheTJh/og?= =?iso-8859-1?Q?znVRNdHup7qy7ie5ZVfnWb1eXrQCSd7vPuDKCalfQXYi9Co6wKSCnG47J5?= =?iso-8859-1?Q?u8he0taUPSR97/ka0ejJsdQ5Wiek5dKf0OzewQKfZ0yZI3bny83kweNY8I?= =?iso-8859-1?Q?QvY1abt5lXKRpkr4/KcxCdcL7vmRZ5M+hZMRiESDTbtxAHuGBfmJE4OlSZ?= =?iso-8859-1?Q?iN69TEMVCYW88Kfn9h+D5Ns1ioiRQ14w8lrAe6882XNe1voRWyst+jUM+w?= =?iso-8859-1?Q?Zo0i5P+XvwUdEAfoOZfRZeNwUF+k4uY24il1gDAvSi5xHVL26iu/tEBpgB?= =?iso-8859-1?Q?k9fGV4N1Mqmw2sox8tJFMrtmr1wTleMUB6Z6D++KMScWuQ23hdqvKQeVSm?= =?iso-8859-1?Q?2FhPayDd+kcjxa7e6293KLL+LcSWmopqEpAN+c/3HykcF4RZZR1V1lhVKM?= =?iso-8859-1?Q?NAN6bHfpG9UkSp87dlS0je1fT+xktGfgIOm5eKfXEsNCIREz29zUP717Rh?= =?iso-8859-1?Q?yv1wStYnxKO3ulSoYF1ZpPxDI++DLFgePBJ50O+PvhZhkAJYkN43zvn5Wa?= =?iso-8859-1?Q?KQQdBirCvhI+ChpYbJSl8YW/Gz9Ca23iN96kvzioE0QI+XIfxsvpy1+p1U?= =?iso-8859-1?Q?buObPfQlJdyCAII+xwoTiwvvyMsKFY1369q0pQ7Plv6ordec9FsuC7Zqdw?= =?iso-8859-1?Q?ait0PIflw7bd8vOzvw4WJU0mN5wRABsyD+fVOi8ibXkhuquZVwO6fAXCy9?= =?iso-8859-1?Q?peeQb64MVTjcSlHwaxVxEGZJPAApeINzq92NrH4xbwA/frApa7tpmb/dhx?= =?iso-8859-1?Q?v6kMVlLNMjQT0dSnhsfR4YzdUPwBIj1PGhazGSrQxo2kVSBbgICT7f8Hz5?= =?iso-8859-1?Q?14qpMcaXC8q9ZQEmyNNl7I1a3z5pcRqMb3ndtU4+kz7q6lQT9KxKOEBsyX?= =?iso-8859-1?Q?U2MIg12uEEey0zMZHE+XNOyTD0EHlxA5FdBkhFpBpzi1NhsMWQWuunrfJZ?= =?iso-8859-1?Q?lDebOujPqulVD0r/Kj3KEDoSeNWqcgFRCx1GB22P+Yf93WAXlgbaTrvQtg?= =?iso-8859-1?Q?smml+TMh/mqOXHKmuZ5pM/8aYZf6EBPoQ9kaJP/HCqu86b83NwzHUtAIOF?= =?iso-8859-1?Q?7kXtWpA2kOyZl3rhI1HNDHs8jdx632uplBG0YUG8bsdUGYtFamcLi6OTmA?= =?iso-8859-1?Q?oEaTB0v/KnBXO5HwdMuNF2tVedcVLmtkdAVemezcQBUMUZRRIE+kIXAwg4?= =?iso-8859-1?Q?B/Jj9I85WQW+vrHpO26LBqvuzam1TTmb3hP9dErTLnfq+nrWO8KZVOnSi2?= =?iso-8859-1?Q?yUKePq8TsW+HJBw5/TNyOT5PFq+Tr5gZfQEJMWvvVASB572lYCqaI8amMe?= =?iso-8859-1?Q?xBq4i6RtxLYEGoPZ/Wl4nqmtTahPjSE29vC9sjFXpVSeb4VogQmKqDyhfU?= =?iso-8859-1?Q?SlziDxAIYw=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: EVM8oL9Wd94CyGlrsOHGpX1gQeG8IvLPKIyvdqEDgHFfmkJfYY9ZZSxAb8do2g6oZPK9uxQy+pN9kG/QXFqLiA7dnGbJNZaTKu9RTX6MzAVpET6VgXngoPkHo5FJDdKFdnF51vfidgaBcMzaWN/bdT8S5HOyOtfSHJTF+2Jenih7qb8boEJ6EYT1PNV9pJqjoRN56k873J/Fd3jnRb1vUOdHr/k8kdvyQ6CszO3weSzqQZfI5Y8seQtGVeFZZIwzp2iOGWSQ/6P0O7b7f69K747n7xxjyd0MBi8I/U3QvU72yL091eXVbRCAgdoiLSv5lFYWdjOfnlF+J2ERA1Qnpg== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4980.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ae31ae4d-05cf-4283-1ca2-08dec067cc16 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2026 05:28:37.1137 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DlzGp2ExAuYO4myl6INgbuY+oxsq4l0KXp1d2bU2K/3ZCu02qxqURIB1+Q8j6tfmq2Z0C6Xy8cibz+3FnuKk5MLO3+0D2B5zHm9Ty/nvvb4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5411 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c405::5; envelope-from=jamin_lin@aspeedtech.com; helo=TYPPR03CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1780378249750154100 Content-Type: text/plain; charset="utf-8" Introduce the AST1040 I2C controller model. The AST1040 I2C controller is compatible with the AST2700 I2C controller, including DMA support and the 64-bit DMA address registers. Set has_dma64 so firmware can access the high address register and program it to zero, as the CM4 CPU only supports 32-bit addressing. Since AST1040 has 16MB HyperRAM, limit the DMA low address mask to 0x00ffffff. Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater --- include/hw/i2c/aspeed_i2c.h | 1 + hw/i2c/aspeed_i2c.c | 33 +++++++++++++++++++++++++++++++++ 2 files changed, 34 insertions(+) diff --git a/include/hw/i2c/aspeed_i2c.h b/include/hw/i2c/aspeed_i2c.h index b2e4d2fb9d..156998e7c1 100644 --- a/include/hw/i2c/aspeed_i2c.h +++ b/include/hw/i2c/aspeed_i2c.h @@ -30,6 +30,7 @@ #define TYPE_ASPEED_2500_I2C TYPE_ASPEED_I2C "-ast2500" #define TYPE_ASPEED_2600_I2C TYPE_ASPEED_I2C "-ast2600" #define TYPE_ASPEED_1030_I2C TYPE_ASPEED_I2C "-ast1030" +#define TYPE_ASPEED_1040_I2C TYPE_ASPEED_I2C "-ast1040" #define TYPE_ASPEED_2700_I2C TYPE_ASPEED_I2C "-ast2700" OBJECT_DECLARE_TYPE(AspeedI2CState, AspeedI2CClass, ASPEED_I2C) =20 diff --git a/hw/i2c/aspeed_i2c.c b/hw/i2c/aspeed_i2c.c index 595b5fcf5c..a810ef9ff1 100644 --- a/hw/i2c/aspeed_i2c.c +++ b/hw/i2c/aspeed_i2c.c @@ -1654,6 +1654,34 @@ static void aspeed_1030_i2c_class_init(ObjectClass *= klass, const void *data) aic->dma_addr_lo_mask =3D 0x7fffffff; } =20 +static void aspeed_1040_i2c_class_init(ObjectClass *klass, const void *dat= a) +{ + DeviceClass *dc =3D DEVICE_CLASS(klass); + AspeedI2CClass *aic =3D ASPEED_I2C_CLASS(klass); + + dc->desc =3D "ASPEED 1040 I2C Controller"; + + /* + * AST1040 reuses the AST2700 I2C controller implementation since + * the AST1040 is compatible with AST2700. The only difference + * is that AST1040 HyperRAM is limited to 16 MiB, so the DMA low + * address mask is restricted accordingly. + */ + aic->num_busses =3D 16; + aic->reg_size =3D 0xa0; + aic->reg_gap_size =3D 0x60; + aic->gap =3D -1; /* no gap */ + aic->bus_get_irq =3D aspeed_2600_i2c_bus_get_irq; + aic->pool_size =3D 0x40; + aic->pool_gap_size =3D 0xc0; + aic->pool_base =3D 0x1c0; + aic->bus_pool_base =3D aspeed_2500_i2c_bus_pool_base; + aic->has_dma =3D true; + aic->mem_size =3D 0x2000; + aic->has_dma64 =3D true; + aic->dma_addr_lo_mask =3D 0x00ffffff; +} + static void aspeed_2700_i2c_class_init(ObjectClass *klass, const void *dat= a) { DeviceClass *dc =3D DEVICE_CLASS(klass); @@ -1703,6 +1731,11 @@ static const TypeInfo aspeed_i2c_types[] =3D { .parent =3D TYPE_ASPEED_I2C, .class_init =3D aspeed_1030_i2c_class_init, }, + { + .name =3D TYPE_ASPEED_1040_I2C, + .parent =3D TYPE_ASPEED_I2C, + .class_init =3D aspeed_1040_i2c_class_init, + }, { .name =3D TYPE_ASPEED_2400_I2C, .parent =3D TYPE_ASPEED_I2C, --=20 2.43.0 From nobody Mon Jun 8 04:25:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1780378221; cv=pass; d=zohomail.com; s=zohoarc; b=f/YoTyJO+KwJsVvQkhnDAcsd73LQUI2LC5PfO2tfR+Or802FHvHrE+WzLRRwXPeh+UjESVQdOP+DLoMRMrghP/jazmO6sZdFy98J3/GVday3P0CdqrzwJN0jX855/nMcd/Z6l/kbALX6FYHZ8R334XzvjBrAbaDBhidaVDBMqHs= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780378221; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=73fYVtAkqFYcmsWlUq3FwusTwkE8fjgS/ikDnU8ezRE=; b=JLnwdjfIIsD96gTwJgckaF2Oyb+6spXwSSHhIluqSbn9wJfHpEbsHVTiFr3yGMNFX332DMDs5fBb2AQ8+dFkKeoHZrRUR4lV96wdr/0YusIoKWe8gJjwinqkm791PAlKND4xz35eQarK+cu6QKVggW+GaQ5bMPjnXSIPbMcU18k= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780378221296329.18874386376297; Mon, 1 Jun 2026 22:30:21 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wUHgb-00043u-NB; Tue, 02 Jun 2026 01:29:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wUHgR-00040D-Ms; Tue, 02 Jun 2026 01:29:00 -0400 Received: from mail-japaneastazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c405::7] helo=TYDPR03CU002.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wUHgP-0002gD-MV; Tue, 02 Jun 2026 01:28:59 -0400 Received: from TYZPR06MB4980.apcprd06.prod.outlook.com (2603:1096:400:1cc::10) by SI2PR06MB5411.apcprd06.prod.outlook.com (2603:1096:4:1ee::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Tue, 2 Jun 2026 05:28:38 +0000 Received: from TYZPR06MB4980.apcprd06.prod.outlook.com ([fe80::ea8a:7cb7:4822:2fb3]) by TYZPR06MB4980.apcprd06.prod.outlook.com ([fe80::ea8a:7cb7:4822:2fb3%5]) with mapi id 15.21.0071.015; Tue, 2 Jun 2026 05:28:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=p2wfneoWCZqBYhil5H+s8E8Uxc2phtvo/g2IPtBtJpwm0H6xY4OFBqd5V91x86/jfGyFnyQwS86vSnzKVYtCDcP49uscJfeo78ROF9Gjl2IRF/n+q+m4UwGBB8L+dgw3k2lalv9ZRzCgfs2DamS54hKz4U2bxPlcQDdCbw7KwcowMSjMfrSxT5BnAH9/aojMII3OweP8g9PInBVvbeQ/EQMMYYMLGtYCue67L8TT7YvHd2h0GK+DHzx4+zdIvNpZhH/DI2ykjo5BrwYfD/IdnaU+2TrDeglLQMHUQW/FoVrWM1vZC9I07hw8PyBxJfRDP9m49vmOvvciTGuF7nTV7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=73fYVtAkqFYcmsWlUq3FwusTwkE8fjgS/ikDnU8ezRE=; b=rpjLKRWcJOLpUwfJz3B7bL1lxXExRvFD3t8lf074jOgt0K8OJoettr+oJnGGIgCg4KwBwSQgg14eK30GRz61x2knuDJZ3/96NFLdufWNH+n/3B7rT3k6L0Mgx7x/X4HP2F/YWRTdR6mTq/ISfwMlmhX3UbYQDWJlD++OIiClNhAIhzCr8RSCNq8vrf4UCPdizZQ9tn5sbiqPPbx3/D9ZZX7BKJXSuC+P9e0Lta7NMLNch4/ITQ5KfCi0Ytu8k63ixy7Ryid9K61pTsVzFbmR2uz4JCqGpa1yAXZvLrc9jjb/vuWt7qUVX6Vyia7DWO04ywmnmLQe466DNQR37sPHvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=73fYVtAkqFYcmsWlUq3FwusTwkE8fjgS/ikDnU8ezRE=; b=WuSUwijK3JaSm54IQsSKz2lUqup2hbO03r0GJg/4cHKdcPZoH7g8/3cxy4xudrGk9fas7h+zSbTdq14OvNKIgKYvNpg/TwqfYaBalG74IuUtdL441JxlGFszAhlsqVtFkwYRUBoV2bvgOW4h//HjNs+j3jAcWPWEaleExnt4o1IlrgDuNqH0sFyCxa6pVus7uOo04V8hm04uQ8oYxtMXYCrmEw6nBEkGkE6ZqKojFGK2nf1h0c+mhF2LYb9KBZwTuwjT1/6w0zLNBJe0ECUXN1IvKZtbbUjTSz+ZZDfsdGjXkstEJS5QUEosBrl29EZ6BpkgDyLVMfEkzfj+u8kavQ== From: Jamin Lin To: =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee Subject: [PATCH v2 08/10] hw/arm/aspeed_ast1040: Introduce I2C support Thread-Topic: [PATCH v2 08/10] hw/arm/aspeed_ast1040: Introduce I2C support Thread-Index: AQHc8lCqXQYkF7vSPUq9WdALtqsNsw== Date: Tue, 2 Jun 2026 05:28:38 +0000 Message-ID: <20260602052827.1535299-9-jamin_lin@aspeedtech.com> References: <20260602052827.1535299-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260602052827.1535299-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYZPR06MB4980:EE_|SI2PR06MB5411:EE_ x-ms-office365-filtering-correlation-id: 7524a10f-fb8e-4f6d-0683-08dec067cccd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|56012099006|18002099003|22082099003|38070700021; x-microsoft-antispam-message-info: PmTTwcQiJBgD9KYBtD3lk0dY8rbXH8z6V99F4TsVo+QEJb0mdpYRFgQmGXlJs9gZYvZbxQMb/XgBi7vGjImTXtyp6uR7ltzgSUiPsWFxgVZ55EvzhUgED/abyU31X9P/dIxntaDJnFwWZiFOHeHbLT8XcYlk7i5jggUTsTjyWSRQMuHK3aquigfvXSwPVhzhbnJTJZxlCBME/d38qmx4Tlxbr/EW0Lh9k8l6AxxFFv3uKf4BwO0QgDmTzOLzNxlMmZq/1dWIBtGYodJGho4zYG5vOrtld/bQGDU1yIvWsPaY/vQnsY/P+bg+vykWsmtFeud1PqdgVDJfs+Uj9/Vclg83l1Hi8iYHbaL7qkz2vDsopo4yrLBGpwQtY2PUDfVUEb0qNBVM22F5CCOLpnYV4JsctkTl6GnbLCKuA2zY8u5jdouI4w/Djc+r2FmEdcsKVC4ask2UY21se2KhcjdJ+xUEcHUHC9Rjf89rQTYAYbHWfpyhe2Dju2KBcuBrq+jOl2vtv6BkVmCOR3RrEd+APwqNvlMFA/lIUqEPvZwa5A8pt5Ol7xHBJwWnmvfd1LLi8OFCBCvYjI9IacCQtCVjtzwQ1QV5R3qgHbhIQLOdLIZ7ozWJTMmhpMhhTyPM0/j1B35nmWSjdzOxERPhmzBlXTxUwhQdAXPtE21pkLJK+lOAfR67BNQN20YI18BCW1lJxsXiR8RRQpKw7GuEWwicifNAHERiVpKdOj5vkPWAMvuH4oxEiWobsARPv8/ZI2z7 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYZPR06MB4980.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(56012099006)(18002099003)(22082099003)(38070700021); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?T5hswvt40s+1ozvV5qLr63XQJzaTHCUNLbaBFnqp2Hc/hAyae2gaUmXQpu?= =?iso-8859-1?Q?VW1XBdaCFhza4JvorX5d1BD/JEtY5ilFPFv3V+fGqiHpsoUWiKoTzxnmq4?= =?iso-8859-1?Q?3KH1+PbXQvASwCc+t5T7yM9WIU675S1Dp+AfInpNFCp9IkkTOn6MAtHaU9?= =?iso-8859-1?Q?CcUr+NegkRkdnxqZ7Gk12oImaud3uZsPNHP6zxRQgm2+/4TInqIwxIV3WK?= =?iso-8859-1?Q?3Ciqda0ShSPUcja7RY8gDDTeCEoIy2vTtbsu7yRnD6CE64wfJSiAZOBNJC?= =?iso-8859-1?Q?aiydqCZKhoy+stm0FCED9eNfvkP9vWB3xcTkFlFSEEo9ZEsVDL7e9bY09x?= =?iso-8859-1?Q?umQlwMm0cAN9XYldqXeZkxKetAR2hTNBSA+JqNUwoEz2iMuSjlq0Esru7B?= =?iso-8859-1?Q?DZIBk21BH1ZgMZPfyiaUN5huz489+h5A4+H2Mm9PxgSn8jRg1vcb1hVl+K?= =?iso-8859-1?Q?FpC/zs/zX10TfBTc+kJ6tH3YRc7RKcxgvyc1tKwg1pyIIcsclfdUYmyQc8?= =?iso-8859-1?Q?DBTf+bYpEoinwr5WUpvMEna7buobU262hX/55OZ16HCKxxL5WuwdBmY5bn?= =?iso-8859-1?Q?ChqSTGGNyhboDsHdpuDiuMmlk/rq7ZIjx0zjoNLszvBjXVAOb1hGGCrq9R?= =?iso-8859-1?Q?1fbTV5/r1rqWlGxjbQnRzPbg1QalmntNf3YajcRMm8H+FzUJkoNns2Y/Su?= =?iso-8859-1?Q?NEu2NGWW2kQWJ1wTaWV5SHUFoGfdN32mcFOs6NqWUDJobfY2GkYJgAyuuo?= =?iso-8859-1?Q?p28z4phvO9RN2eDiydjncqJCTlh7i5ujxYwnMcTr03Z7Zw5dabYKpcL0BJ?= =?iso-8859-1?Q?c49cQBdP9PDDDhV0VpSc6ST7l29opwKf8gqowIT76XDUEOpsxsLuQ7UA+4?= =?iso-8859-1?Q?WxEdumCtwE8Rp3RXGaK3EpokHPHTtt6QjQUPFJ5r37gkfReNXKkF5dMUCD?= =?iso-8859-1?Q?mQ8X2t9pInf/9xbuSufRknbU02cHkOx8jOsXA3ryPRByy2w8nTQ60qRCm2?= =?iso-8859-1?Q?kDJd4FkVLeXlMLf3HCRJqwvcRePtk8/ZFJofXwlwMGUmP1TVfW0ShHbxdP?= =?iso-8859-1?Q?3RsPnIB83ZJ5pZPN5sfzc7GPsI8ZXPVYESZF7CUaZnp80HpiN8GcjcjAju?= =?iso-8859-1?Q?DKjFB+cSoxRG1AYLp/fJSIZrCMj4D5FMjuNi0DGu5H6a/4uvUrQMZbyvP3?= =?iso-8859-1?Q?Xxwqg2nVSxVjg28U2/D1C1DZmfZQHg+ZCVY9lB4SK0yG230DIEsDWbHsZY?= =?iso-8859-1?Q?SorO5smOs4eQQVHxxXLUscCHPi2EmybJ35TirDIV3CnZiEVBCDnE+YwKFV?= =?iso-8859-1?Q?5d9dL39QdCo9W8zjlar2KE0nkjSnK3SXzWNu63QkKC50NxjrU+TSA14LUA?= =?iso-8859-1?Q?ZB4iNaEaXx3DsmCEBv8/4LC/J3jD7k44JQ4hoWnZ4JempvZ34OCox+es09?= =?iso-8859-1?Q?KRf3jhk4si4sFj4IK6IAUpU7GGHig0Bgq4HF1MtDLlz2PLXOplPfoOS5AZ?= =?iso-8859-1?Q?4BNaKXCoaEZihSuV3KSQT2a60ePby9xsEu6ML78DUVgPsdJXRtC5I0DMiw?= =?iso-8859-1?Q?cumodLILCTSaBdubeeE4/QxgZKPYmpy5JO9kb7uZn4wBwh7IABHwkpHno/?= =?iso-8859-1?Q?L0mTcJNa2iaozc3zua7a6vmBiL+jpK+MQGTc4KC0IHjRCg0++AkeUEjAgk?= =?iso-8859-1?Q?iunnQJyB+0cJj2y31dDFVzrDQCyrEaAtJ+GtMuNcqgnMrCgoj3gLICN5dN?= =?iso-8859-1?Q?0iFAEzRoRU1PCICt1q2J8YUBTcdvFVE3GL0+2W1Il/9GHbYIxushCz5Wqc?= =?iso-8859-1?Q?WnoZJLX4AQ=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: Gb00nLSkf/34VuOsXCXsFdcZW7RxfDNL0xO5/bC/j4wc7KcNIoRf40B9lc7CQYd7e+KadI2ZSl2y1dbUjmcsNsNppkftvDzppJcBKIaiq82eBhGBNL8nbB48MyDaiV4Cd8QzRWROaABZrh64QwSLJO+oaSnctnDL17z9k/gt9XOYwhY7ht5/aFqmz3PDbMD+KAypla4ZAaeNViGJ8SGcNz6TXn3Bad+d0Q1eprtjsBkFkIKFSIf3tDIDpn76Pu+qSnqoAKfDjxlyIrKn8s04fOxeHZ9hkNu+9DqXR0i0aak08/DzDxaAQOQX/a/prnQtQakOcJuyh+1zbSC/MxFp5Q== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4980.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7524a10f-fb8e-4f6d-0683-08dec067cccd X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2026 05:28:38.3045 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rV33sU5qhoZKff6J3Oa4gwEaLyNtZBZfvdsqfeNoPeXbooszwT51OT/4f3+TTXmyzOVs40lQV/LGbCooYhuyMuQOCnE6IGOq/GwVYMVucwA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5411 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c405::7; envelope-from=jamin_lin@aspeedtech.com; helo=TYDPR03CU002.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1780378222922158500 Content-Type: text/plain; charset="utf-8" Introduce I2C controller support for the AST1040 SoC model. The I2C model type is selected from the SoC type name, allowing the AST1040 SoC to use the corresponding aspeed.i2c-ast1040 model. The I2C controller is mapped at 0x74C0F000 and uses IRQs 64 - 77, with one IRQ assigned per I2C bus. The controller DRAM link is connected to SRAM1 (HyperRAM) for DMA support. Signed-off-by: Jamin Lin --- hw/arm/aspeed_ast1040.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/hw/arm/aspeed_ast1040.c b/hw/arm/aspeed_ast1040.c index 77211ce1f3..6d1cb9b102 100644 --- a/hw/arm/aspeed_ast1040.c +++ b/hw/arm/aspeed_ast1040.c @@ -117,6 +117,7 @@ static void aspeed_soc_ast1040_init(Object *obj) object_initialize_child(obj, "sgpio[*]", &s->sgpiom[i], "aspeed.sgpio-ast2700"); } + object_initialize_child(obj, "i2c", &s->i2c, TYPE_ASPEED_1040_I2C); =20 object_initialize_child(obj, "pwm", &s->pwm, TYPE_UNIMPLEMENTED_DEVICE= ); object_initialize_child(obj, "espi", &s->espi, TYPE_UNIMPLEMENTED_DEVI= CE); @@ -233,6 +234,21 @@ static void aspeed_soc_ast1040_realize(DeviceState *de= v_soc, Error **errp) aspeed_soc_ast1040_get_irq(s, ASPEED_DEV_SGPIOM0 + = i)); } =20 + /* I2C */ + object_property_set_link(OBJECT(&s->i2c), "dram", OBJECT(&s->sram[1]), + &error_abort); + if (!sysbus_realize(SYS_BUS_DEVICE(&s->i2c), errp)) { + return; + } + aspeed_mmio_map(s->memory, SYS_BUS_DEVICE(&s->i2c), 0, + sc->memmap[ASPEED_DEV_I2C]); + for (i =3D 0; i < ASPEED_I2C_GET_CLASS(&s->i2c)->num_busses; i++) { + qemu_irq irq =3D qdev_get_gpio_in(DEVICE(&a->armv7m), + sc->irqmap[ASPEED_DEV_I2C] + i); + /* The AST1040 I2C controller has one IRQ per bus. */ + sysbus_connect_irq(SYS_BUS_DEVICE(&s->i2c.busses[i]), 0, irq); + } + /* Unimplemented peripherals */ aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->pwm), "aspeed.pwm", --=20 2.43.0 From nobody Mon Jun 8 04:25:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1780378237; cv=pass; d=zohomail.com; s=zohoarc; b=GjtvNAD/L6zLYuShfG0/7leNBmsBIVe8WRX7sJ/UAzj36tzqxYrdwdCk9Nb2BcZkY5/EOsBFqgE+JeUneeXtP45b5To/hfp7Mmyv4h7w29Ev9NL22FQfa3be3TEEnoRhFBiC0YTwcDc0ErM8PdISMMTVKfQW5QwbXQogEmf5yP0= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780378237; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=D/w37WYK09FTwxaQXZZH5wZ2TjnhflZvP1M6boyz9bs=; b=gZ2QgMNjMCPuD+w1bVsNMvbj1KrXDnUZ/m3ecw91EhR2AGBn8vplDupEWH4b4MfN3FqtRmXkzEhmjO6/JLSrfhOqPsSyuOlqafR9CrYRbSZJCNguv45RDp41B9imKFfRJPHyFrDlDArJS4nL9X8HxkH0TK9GbiHbHV5O10Mu/R8= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780378237664796.4624799233828; Mon, 1 Jun 2026 22:30:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wUHgb-00042N-34; Tue, 02 Jun 2026 01:29:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wUHgS-00040K-So; Tue, 02 Jun 2026 01:29:01 -0400 Received: from mail-japaneastazlp170120005.outbound.protection.outlook.com ([2a01:111:f403:c405::5] helo=TYPPR03CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wUHgQ-0002fW-Mg; Tue, 02 Jun 2026 01:29:00 -0400 Received: from TYZPR06MB4980.apcprd06.prod.outlook.com (2603:1096:400:1cc::10) by SI2PR06MB5411.apcprd06.prod.outlook.com (2603:1096:4:1ee::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Tue, 2 Jun 2026 05:28:39 +0000 Received: from TYZPR06MB4980.apcprd06.prod.outlook.com ([fe80::ea8a:7cb7:4822:2fb3]) by TYZPR06MB4980.apcprd06.prod.outlook.com ([fe80::ea8a:7cb7:4822:2fb3%5]) with mapi id 15.21.0071.015; Tue, 2 Jun 2026 05:28:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QuxKw/ZQLL/vV8AWWdgEylncxD/tm453W8TTpG4qMHAiYnkg5z7G0szzkeFRXLcljT6CjuqJhYsGDFu2lRBzEOglp+z/gJRta2822KWJf4CDTnEATXe2bqEYNMHtb++EWirm3Gm7XNlYJZeiSY8HqmhvhrkOD9YlkRXQH8eIEJt+GtwH67Aw/52NnFJJnCbePblENHwZwELF7gbd6eRWpGQpeIuugCcUahKmjtQ7aDTmS5/t58scu93O4FfCUPM/fNuUluzdW59Kex4sRgylOO9hreYfvorSRpdAlHXypoB5I1KX4xg2/phbvYDgAX+pD5qoG1L8hhBLOQX9wDsqhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D/w37WYK09FTwxaQXZZH5wZ2TjnhflZvP1M6boyz9bs=; b=fYMTo9yqkw4MarjyJ76EHeYj2K3sDqisF+RCInwtr8trWMYkS00T5UDcFXacovwU8ZoWmfp4sBPL8aLn340FbdQIMBlL6tom5d3ydEKAiuP60xwUXLhkwBG1BuQdh/k6kNoshKaevXq+vjoQ3y1m2/BGCkDQus22NlmmFpYQcAA/XYeZvjE9y3owsljcQFFlqhWDWHuofiAnqN6/XM6Yq0XdZutpaYNBUP16IpuOm+yrJNQJq58pMlS7MKsUUtxEGRHoREcYy2JgyxoUyj7cftj5pLw0RZQqRNb54NjymQ+9Y4Bz1oPjbdQ22C0usibxxqiLletNeZfhGHmhFqeHFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D/w37WYK09FTwxaQXZZH5wZ2TjnhflZvP1M6boyz9bs=; b=gdOw/1X5CabnFIoULNwQZZqbWtivOqc+8HQkV+bHwOB+qgY0LLYOvlkOVr/9pCtp2bSFdEZqlWsJB1AO8z/T9cztdpzh1YIKap5zrKYyKXxaDuaZdGg86ebGEOhe7szEYhxaVZGbZdYGNK5Nei8J5m6vFXH95nidrYDFS4AWyHKaJDupVSqe+KG8u0jzFvwXSyilsBsR8rcmk8Cq/aAHJZLCOWskH2gOpyQ+bWa6HTJpqkAe1UVRa8KtN1dU/cM/7utgm88K/J3HvP+pcYFqHR5c5uQOUhpis8s7PoHiUxzLZROHds8m6P4EjRyRNPtf4Nyj++CGvHjTUmPGEvm6Kw== From: Jamin Lin To: =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee Subject: [PATCH v2 09/10] hw/arm/aspeed_ast1040_evb: Introduce onboard I2C device Thread-Topic: [PATCH v2 09/10] hw/arm/aspeed_ast1040_evb: Introduce onboard I2C device Thread-Index: AQHc8lCqSxHismjzOkG6W4XZ3+fb1Q== Date: Tue, 2 Jun 2026 05:28:39 +0000 Message-ID: <20260602052827.1535299-10-jamin_lin@aspeedtech.com> References: <20260602052827.1535299-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260602052827.1535299-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYZPR06MB4980:EE_|SI2PR06MB5411:EE_ x-ms-office365-filtering-correlation-id: ef3258de-170e-4b14-20ce-08dec067cd78 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|56012099006|18002099003|22082099003|6133799003|38070700021; x-microsoft-antispam-message-info: PuK3NwxtL6ktUb74cWCr4y46zmM/H+PWCy1DJzDLHHE0XnVuL5DiEZsTgYJrdospojsoRJtHrVywgPD8ZWXvJSHNahOP+yV6vALoDpE77XE4tyBxVsP7X2Ykltt0PYG08xX4BKAYClaFW8zsAXVeoqifX643I5tnfuuGCxoJypcr7Xm/JgA3G2fRr6Mm2wivfCKSCczHaH0AufRnrUkMe9Wt/cD1XdnbhbDB75bY9n64SMtZ8V0GHTGs8JyemH9Qru3yEw8BeLfvi0vOST50CV1j/XYx3jZ3/oi3TdLBxQroi4j5jlRoSLtWI6N2/A+PHCZvurAEOrfzyH/rJ6PjMujdXICD3PuKqdwR5KdS9UaLswglokbBj/dK9y2bG///htJecXliSGYfYysOh0pAtS7fND8C+7r7imVcUHFRZFbo2JnfDTOHMyh4Fvkw40AR8qsyM3hA//XWk++7Iw1L8iESAwEpzbiLqJKOHA22gqB79IIB9UhTgsk4hYJMIN9FBy2YucQbQD5v2S+pElNYva/BxC81Fn1xKisGNtM3u3CrDQHjwobUQY2+Rte+7aaPhYrF3BCc8l7wfWXxQ590+Qcw7GNlG3LqYYiCrmI3/KTV9G82XgF5BknmjvVrSfb/u7r7ZcXkBjlAOqvHCka7ey1eZj72s7Sm6s4+VU1LbI16CSQY2QPZdgjSfFmqv/wqIIKj2zk5vM/KDOA/uBcPaL/UoaUwo8VHlbqSygWF+YQiUfuRwG+KnhQFkYgF2wUM x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYZPR06MB4980.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(56012099006)(18002099003)(22082099003)(6133799003)(38070700021); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?UCOoCswmUBwXFHz7pu6OkBFDq6Ms7wo3jLVdqj2jDN+x4NSTuHLtXAC9R9?= =?iso-8859-1?Q?jAeeZW/GfSGaB6vlN69T0SUj6b0ziFPAvH3uYfypc5jv0IAzGtwGbtpLVx?= =?iso-8859-1?Q?/n7KE4XrCCv/Ff+2qMFD6I8Do9ZMPTEksmLjKsRNwNem13zgmrr35bkgmm?= =?iso-8859-1?Q?QB7pwvxkLE7uTuq6IQZpzTfELiBpxpIBUwIEtJTfjjuKLf182YTybZse1m?= =?iso-8859-1?Q?FLfeLXYz3uPFD3tAACHHBZApl5iW5yH8mQdQAgFGUAqSH1iS/dKbSErXHz?= =?iso-8859-1?Q?Ja1z1/nucmIGd7DEGQm4llQD49XTdlOeSURwOzqj7IOodltqrZ+/D6UAxq?= =?iso-8859-1?Q?+V7b2jPhynB5pAgHPdl+4IDxoj2iKsbSkMEcMnPekqCLkox2mY4lFJz36N?= =?iso-8859-1?Q?waUBzGH4SgIIhQ7IUEqAUPV1vGMQX3q5YJh4yoZ+6fijM6TTwsrE5zFN3Q?= =?iso-8859-1?Q?3A8vjnFOyTm31iktNDCpC2WS5a9P3mCKqaPZw6wTQ0tPEupg3DXGVUNYwj?= =?iso-8859-1?Q?tWUq4ZzgCBagFLxl+ZQ9KKMJyTRD8mu6+PByqrKWJhmLK0I44uC7kS+Qfd?= =?iso-8859-1?Q?AQQfNc5D41mojwcwd6UIFV4OAmz0kVZVhxrRXnqLR+7mCQW7bS92V8Db8x?= =?iso-8859-1?Q?5v/RVkBd6AfIYny4699EyIsVnqPwrhqdPwn1B+BDt6CQq06j7SkDw8agXR?= =?iso-8859-1?Q?qYPyINafaqc5PiztDX+6hSWsZOqp/RJj3t26hXPKe0HfvEhbpiG4puoW8N?= =?iso-8859-1?Q?DcHiD06sNo6wgheiaqB3n4grOJQauBwPzgFsox0b2sWJap9sMJgqWEtzT6?= =?iso-8859-1?Q?zUewRuC+ka1vDXOUaev2Okd6+MsgvzV2L9q49cfvcOSzDVhneZcx7zftuy?= =?iso-8859-1?Q?HcFTRxiN0asjs3kE4T0+H+HNqmbMx5pCU9H+8geKS4Ok4nQ8k0PJMl2jvj?= =?iso-8859-1?Q?P4lwTR6hWMXWGpiMVGIoW8cSAcEEWtZnQ7Cug/xlGDrb9Km5+l1jcyq6nH?= =?iso-8859-1?Q?quGhRYtLLiq2B8yp6+ZjrQx09WtyG+UQSKMyjfG2YPNJvi3NW/rpPOLrqv?= =?iso-8859-1?Q?D+LgqVCIGF01cwXTEMXUqoPbEUgbP81opNLX9ejh5s2HACyxw20ctNuJwd?= =?iso-8859-1?Q?t7jjeQ/D/W3KJJquv0LuDIFM9POm5ASjNvivf5cf7PlRnIiBVI7TnI7h91?= =?iso-8859-1?Q?spFtru1Nb28BqCy34Smc5ffBfhvwAJvDjBcMYq3g4dSux7d75LafSnn3ab?= =?iso-8859-1?Q?39FXObvDblZ2z7HyBOc9F8Kc6Hf/+R9sTX3MNGtYbm2tqkxfVOHU5sgWme?= =?iso-8859-1?Q?o6begNIAeo3nUJQVyNxWxt14PVnsi/29oAQRPUswgLwSluz6wvi0d414BO?= =?iso-8859-1?Q?UKo4jQvuGkQ6MvQNaDBeFyB6lZdQ+45YNBbcjsmGV6yJgVTiDlUvm+xFnW?= =?iso-8859-1?Q?NMEV+ySWpW4g5XV4xZ3SBkiQLZBJruz2HL2kYGLgb9Je+pL5cF3dfXrzxF?= =?iso-8859-1?Q?uQuwp0g2UWO7FXApUPReSsEo1XGoBWPCV/rGVmNf6xi+2sa76/BMwGHTFe?= =?iso-8859-1?Q?rcJBxHtbHMpaMlrG8CZNBXJ7Xu3cz+rxwXZ5PKl3JCEMYlUKKKMkmMAo1a?= =?iso-8859-1?Q?eSJG28ONeMizbdCQITzPYTFYE51VZ9l/sGlhIeVu9AyJEZVuxp7i9YDIHK?= =?iso-8859-1?Q?5pvKpHaX7qIOkaUVP9rJR7EMq+ZSnv0IUlxkBw+4LI8wLHTFqsR1Hfa857?= =?iso-8859-1?Q?4tMIw2i2hF+WsOPqIrvAu4sXBjKbT6hpjNeEPh48UHR5FdgGmmiaVkKWY6?= =?iso-8859-1?Q?PUu2R0ULig=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: rl/1W2B0ANQMM2OQFtCi1LEb4ND//Gyc3PkaRjZLTNPHfwI/QT00def0EniHZ6zP4qU9slmKoaGamxuU3tow40HMVhePOxE+L4nmqGBmKmbW6dAx88NwecOIBDxa7sB787+NAhnh1qYgy1IXuDO2vwH1Z/b3v1el5bWbhchC3F5TDnaGye1G0Rx9VqxBax1A+VjwYgUvDK9m4w1Wc20Ae+GXNKF4uHbh4zE8jP2LAA+yQN2KsfL0oiog7h3VGBlyMQypLaUOCLrSZFOS4oL0eDCG/zr7t4yRGGnJbUZZqNVdQiC/eKQC13ZhAU/fhfYAu3hmisEpRwhCEvcz1Lwatw== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4980.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef3258de-170e-4b14-20ce-08dec067cd78 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2026 05:28:39.4497 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: H+UdXGZSNppRv/Q0nO5mEZcVPPMks2jC89gRKeZ9SoybATHPlfb4+eo5EJZX82iMq/AfFlxQZMdTecSDZNBLVlFxd7jMUoPfkddGxqUJOBg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5411 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c405::5; envelope-from=jamin_lin@aspeedtech.com; helo=TYPPR03CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1780378239681154100 Content-Type: text/plain; charset="utf-8" Introduce onboard I2C device initialization for the AST1040 EVB model. This change adds the initial onboard I2C device setup flow and instantiates a 24C08 SMBus EEPROM device connected to I2C bus 0, matching the current AST1040 EVB hardware design. Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater --- hw/arm/aspeed_ast1040_evb.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/hw/arm/aspeed_ast1040_evb.c b/hw/arm/aspeed_ast1040_evb.c index 1d9b55247f..66f08ccbe6 100644 --- a/hw/arm/aspeed_ast1040_evb.c +++ b/hw/arm/aspeed_ast1040_evb.c @@ -14,6 +14,7 @@ #include "hw/arm/aspeed_soc.h" #include "hw/core/qdev-clock.h" #include "system/system.h" +#include "hw/i2c/smbus_eeprom.h" =20 #define AST1040_INTERNAL_FLASH_SIZE (4 * MiB) /* Main SYSCLK frequency in Hz (400MHz) */ @@ -38,12 +39,28 @@ static void aspeed_bic_machine_init(MachineState *machi= ne) aspeed_connect_serial_hds_to_uarts(bmc); qdev_realize(DEVICE(bmc->soc), NULL, &error_abort); =20 + if (amc->i2c_init) { + amc->i2c_init(bmc); + } + armv7m_load_kernel(ARM_CPU(first_cpu), machine->kernel_filename, 0, AST1040_INTERNAL_FLASH_SIZE); } =20 +static void ast1040_evb_i2c_init(AspeedMachineState *bmc) +{ + AspeedSoCState *soc =3D bmc->soc; + + /* U10 24C08 connects to SDA/SCL Group 1 by default */ + uint8_t *eeprom_buf =3D g_malloc0(32 * KiB); + smbus_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 0), 0x50, eeprom_b= uf); + + /* U11 LM75 connects to SDA/SCL Group 2 by default */ + i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 1), "tmp105", 0x= 4d); +} + static void aspeed_machine_ast1040_evb_class_init(ObjectClass *oc, const void *data) { @@ -55,6 +72,7 @@ static void aspeed_machine_ast1040_evb_class_init(ObjectC= lass *oc, amc->hw_strap1 =3D 0; amc->hw_strap2 =3D 0; mc->init =3D aspeed_bic_machine_init; + amc->i2c_init =3D ast1040_evb_i2c_init; mc->default_ram_size =3D 0; amc->macs_mask =3D 0; amc->uart_default =3D ASPEED_DEV_UART12; --=20 2.43.0 From nobody Mon Jun 8 04:25:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1780378200; cv=pass; d=zohomail.com; s=zohoarc; b=Eu9eFpSHm6I+balEyoCRwvI77ZakXNtSrFn0nyCJPIO9COxinXZ4ySCH1XHEnf2Iip42sjaHjg+fer4FU3xsHv9eg926POoT4LLbZxSL8LDsEL5V3sPa9EuS1dg8PfXlU6jqMs8Z5sYFvlQu+I066phdiaI/dW6GuYP983BMmww= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780378200; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+sQFWHVUXY18uniuXWWtKF9n764bQm6UVtavQBNUvvw=; b=bYGQeKf+iDd2HHleoFl+9wjiQPizPoanGKSbDkkDI21GGNlKE4n8t5SAegT2pEAhq435mQw5GALnqMo5sRl7Eu9yeacVobGIWBGhZUHGRXcbrIHSDO4D4nQH2lJ9qDdbFyZkfh+t53CttU+cb1xN0Z3dC/oGKA5lYAaaM9OzgaY= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780378199504175.4536742264603; Mon, 1 Jun 2026 22:29:59 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wUHgJ-0003xu-Rt; Tue, 02 Jun 2026 01:28:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wUHgH-0003wF-BG; Tue, 02 Jun 2026 01:28:49 -0400 Received: from mail-koreacentralazlp170130006.outbound.protection.outlook.com ([2a01:111:f403:c40f::6] helo=SEYPR02CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wUHgE-0002gS-Dl; Tue, 02 Jun 2026 01:28:48 -0400 Received: from TYZPR06MB4980.apcprd06.prod.outlook.com (2603:1096:400:1cc::10) by OSNPR06MB9190.apcprd06.prod.outlook.com (2603:1096:604:493::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.71.16; Tue, 2 Jun 2026 05:28:40 +0000 Received: from TYZPR06MB4980.apcprd06.prod.outlook.com ([fe80::ea8a:7cb7:4822:2fb3]) by TYZPR06MB4980.apcprd06.prod.outlook.com ([fe80::ea8a:7cb7:4822:2fb3%5]) with mapi id 15.21.0071.015; Tue, 2 Jun 2026 05:28:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fkST8Iv+X40eNg8Y+VytOpNCf9NI6EoT2Aqe7Np9qby44f5Y1vy2dfBxtms47sVMEPEvqN1kLsvCJ7xZebeWuSUKTkHFB5BYFm/KR64gZ1vS7lPOmllecgn2/cvBPSt2xOol+mRYrRsxjRorkLIQ0xmS1NxP+LXPg6/AWAquw0awoORc44s/cCGVVNXuOnCyJhQWsSSyhXGXHzesbYEJixl0VkkfI1ajQcwuVzOyMwH0gUwkYL4R3SygVxhnl5fpsTyTrIHijQQi8uGq8UVPD0buYKbTmkgSJXFeUs+OKIAVyLVNswviDTnybXQ0CkzM+XyAHKO2hZ0/imBTNfExEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+sQFWHVUXY18uniuXWWtKF9n764bQm6UVtavQBNUvvw=; b=g2Jg/qcgEYvUv/DAOb32eOjCg317wn5WreUIjhpwgWVUrozajmBABq1G1wtkJBlb/n56vC+yZy4czgwc/cfZJjW9rnwK1yqHKwjnbKA16Byigf5ckta0rOFFwz0u2D/gPG/mpJerr9+fY3ESesBeX6SemCZy6UXA/4OqlObZOJj49Y9jg8HOnKY0/yuanh9pgAlW53zrnxpyFQ/5EZAueAhcxEo5w2TH502/8XfzkUNFr4nfAftdslqp1yELytk2A5H9m175M5JdE4tuuzoyifELrJHmUfAwy3t9bp7IyHyjlRTRN6DYtXX8edKdfTGpimZ97/gsTmuJbkSPWpXa/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+sQFWHVUXY18uniuXWWtKF9n764bQm6UVtavQBNUvvw=; b=iTFtialvXRk5kNJjDpn90GG0c0kv5aN/Pyt7Ed8qWA+N+gaUbaeTtPt54cK+OQn+LxjX4J/lUIjE/vPPJL7cad0auOQRmJ1QbSAwDiUK4fkDu0JUj7kjEJbMjABz4u4UpaIeGpqLcJ2fJdrevBokMS/OHEhVWuCdvuYm9djWFweOw5B0NEWTOu88Tcz7SkgUCqXg7h+Zqtz/1geGRO/c7kM+uuTO5/MwTtF6Oni5lBNVT3F1D+ri9chOLaPkloHlOsGa+SvZQ5b+GRv2McgZPFmKuEnDSFPba6TMiOp8VDfODgcoQKMg2ol8G/G7koC12MF/CbQGnSQqL7vONDmizw== From: Jamin Lin To: =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , =?iso-8859-1?Q?C=E9dric_Le_Goater?= Subject: [PATCH v2 10/10] hw/arm/aspeed_ast1040: Reuse AST2700 watchdog models Thread-Topic: [PATCH v2 10/10] hw/arm/aspeed_ast1040: Reuse AST2700 watchdog models Thread-Index: AQHc8lCrHYFiMY5pDkuQB66IJp8DvA== Date: Tue, 2 Jun 2026 05:28:40 +0000 Message-ID: <20260602052827.1535299-11-jamin_lin@aspeedtech.com> References: <20260602052827.1535299-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260602052827.1535299-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYZPR06MB4980:EE_|OSNPR06MB9190:EE_ x-ms-office365-filtering-correlation-id: 2bbd4275-c3eb-4522-5334-08dec067ce25 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|376014|1800799024|22082099003|18002099003|56012099006|38070700021; x-microsoft-antispam-message-info: KNPZIa5PrD1kcjpyThhjQh+hKtxD9kaR6NqsjwZf+l0Vd2Qe4yMVlxho6TbQbNR6wLNJMfmeqLzsiWbQf++U9jo32YnJ+uxZSYmGx6T72Z99czcBbNmlOAa0AgFA7TPPIo2z0xuTZeJ+YrXapW77PT15XYFUMrWqwYUKxm5yZfYfT35f5swyYHwZTLNkvNS0fM2IWkzxtR6yx5NVaCKGthh4+cEIiy9Nh+jDs1PaL7vENXlvgNbbudxKIcljqCTQy2ngHZsmEh+jDeqxq2W05ApeQwDUl7Ryy4zWTiqSA+gTDMlgkyflUxbXMzFvi41K5Nw7YcuyhMnYNgDspI+24ABUWOy6WuU/E7p9h8YPTOxYJGTcygWOQZU0zeCj3RmZZ7w1Xtk42kwEuwBdKtiP7sbJtkR2b/gJn4tvKsPkXF6bKG/9z0V2benGm0yQqgbVTmEyl/YxmM7EZV1gADRRJ3KISKkXl9MbHSOnQOQkQ4XoBzZyMDaGqXvF/XmeCh4Essav2JsoWjBVrTjv4+l+CcCBzjWBl8S2Rm5K8/NKynlSi4PIbi5YX1WRPxUkyYACcCVM/T34F24+ciKe5mI+O6bAuwO9ckBb9XtsZrjyuo4gjQoBvHtsbeoy4F90fWvKFJCgSiD7pfFc3yFutNKZgzgw7XYOthZJQP7DQPlCM6qKoh0zzn1pxr0IhhMHZOpAqVKxrtX+nqhJlMZHpinB6qsJLi1oO6BM3/wMYecpKqA5ReF4RwOEjI0y3NjFfJQ2 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYZPR06MB4980.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(22082099003)(18002099003)(56012099006)(38070700021); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?y7f0/sMA0nkqyFjTwyfWi1GL8sw5upa1mOFf7Qzeyu17ihM+X/R2+/q58f?= =?iso-8859-1?Q?XTz9MrIKbNtzJQR0ULNelQjbajUxpMnhnF3kPQbuLBp3jYnkkfBY/zFjsq?= =?iso-8859-1?Q?Ee1AeCR2DFOq89MHP6pB75TwvyGEVvzBNDvONaVkq/5Z8EU/L4I2vNmidD?= =?iso-8859-1?Q?bumpUxRKN1jP+kLf9EwUxJBB/Fix8oF1r2YRYtFZ51Cz4g+7AmckpRpYHK?= =?iso-8859-1?Q?L6ty46AvOn7NdjvlBrwXc6aYew54/xV/eTV/0mSwgRf0Og9PQA6o1HCfN3?= =?iso-8859-1?Q?eFXMQgcwvt/+In0tTMSgwehlBkfF4aHWUOZ43lLGdH8Flb87kVDQ9bWmU8?= =?iso-8859-1?Q?6/I+doMi/0GuRjXLVfMb7iHltQz3tYxzXQQlA6gyvtEqZlKiMzj5thhaJA?= =?iso-8859-1?Q?8AKK8tRPUDmE6VHa0vYFKc2JTT6sgiEo6kKQjndYAv4Reiqp/O98mi8HKI?= =?iso-8859-1?Q?6jKxAObm/zOHQSOrypvKPHojEU+QTfcL2XzK+So6Nckk4RJR11fytrQ7zx?= =?iso-8859-1?Q?BigL2hRZtxhLp58s1TYuWiuwbhYcnyGc5Fzms1VszHSHnNChnuhMrTJOA8?= =?iso-8859-1?Q?GXBlLEtfhWiHFri8MOFyKh8Z8XHtmd+U0+a+i7TUAtHXBJwNoBugJA9s1n?= =?iso-8859-1?Q?8dPsBXfOmt+zvQTIntPvbB/Kn/dzUXGwzsAYiwz8IoVX6TZoPISCIqQGJb?= =?iso-8859-1?Q?mnTR78VcYwSoNc51vb51I6BYQpT0uq/wdw3SIM7SP8lZgMeAP/tUDMrGEN?= =?iso-8859-1?Q?CCTqw65J1kuHWpBSgDUU8TmNOY5jSReXn3KvmPp7j9xQ1phqnoPjbmbnUZ?= =?iso-8859-1?Q?IvSCYZ877oyQ3Tb0EZbiPFOlbmM5DCAGcIrKsJlEQK2REO/7Xv9ttviUUD?= =?iso-8859-1?Q?K5ZgHv1CQ7tqdNKiQpHEgaoA7i0QRIj7pBOaIXJXQ+jom1FvV7nUsbIJFm?= =?iso-8859-1?Q?hhpuaukVaVpWIoxFGd3y6Q7dtyfZdx+69/6UfrANSe1weSUEl3AobQ3bg8?= =?iso-8859-1?Q?BCSPbjIvdHy2/Jg3FXRvvmINEPmxet4lezgppJBB5kLPOMkBWEBqUhq7JG?= =?iso-8859-1?Q?lt+hDX7wxKPGNpzSrzo6JOUj6eZ8g12J+ZIiLdMyQ+S2U9qHK/oUKH0bpc?= =?iso-8859-1?Q?C4ukv+2bnxufTLJ13B1+IAyxzYAIgXrNAARGW+fMJMS5qsQkvrQW9FfN2B?= =?iso-8859-1?Q?6hq3N2hgtWpyLqtviN9CVqmk0NsJjYo1qy6r53IBSISZA74SNtkqK17ko8?= =?iso-8859-1?Q?hMCTpifys0u2h2YybzHGShpekJW9xMScsq8S9VwgY0b8aC2Oxho06QwKC4?= =?iso-8859-1?Q?55CtqkHhJ1fe7MSwW1t2siWE1M5BeYG6R4tRfFR8AtVOwlU1dWADyQamgK?= =?iso-8859-1?Q?fKcjpjlj8tLo5fW0LP+X1Sq7SZk28DYm+H7/YeV1vQxnaLOYJ24gJwTfQa?= =?iso-8859-1?Q?W9qe0YNRniqO6XVnBnRPJqAdZmwaw2Y0k9p0QBpRTtwxt0Iz6OX5vyhp0O?= =?iso-8859-1?Q?IzKyalQEIx3xgcf658A/830dyGABfYEn2wRoS0V6NJMnzg9JpNJytAuQq1?= =?iso-8859-1?Q?Da/qI5Io6uWG8PJTHSBIsHE4EzD+PqX2JT070Bt5TnHrnDuvP2oq0NHJmk?= =?iso-8859-1?Q?QniTa94cKN7UXQliWHUpts4pSC+o9A+2C/mrACk4MYkrMR4nYru63isuDf?= =?iso-8859-1?Q?9bScxbzXfVnXL8q/Gik7EH7Gm9uVFXdZl5Sv0BXwZNNrDmSoIRV3ipbe0t?= =?iso-8859-1?Q?1cQuIEA17QagzUfi96bQOpENeOcM14zzYOIAZ1aw/d23CsWVz+9COydJpF?= =?iso-8859-1?Q?t/OW8R09Xw=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: YY3MJMFsFj2sgRzye4nB+zCFxVTpliiEzo4ZeVZrC/ofEHcCBfQIlEDlI3rp5MJX+U1pozy2zR1ETtStI74gR4ya4pbz2n/bACs4Tg/xCWezzVOxXJutm8DpD7dkgC7+1oHIaVp+rLpcyb8SOESHZTN3liewseXRisQ+m5Q3Uh7lPjHSQAO3TTBS9OHwcQv+3wzE0eDa6d6JtWNlmrGVAJ90GG7Wh5yHnvY639/5rQ71TXT1jJOMlUMXgHL1M19Ieo5cspPK5Iwd9KuEaNtILxA1sLC3KWzOcGyySfd+swqMQb3pgZGyZP5PlmXcDXxXVtahw/vkYSVCg+69IxmWMQ== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4980.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2bbd4275-c3eb-4522-5334-08dec067ce25 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2026 05:28:40.5696 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pODJ0x26VJ/4UaiA8QjxUhrKmyxpo0r/GZUxb1bGQNdOOo6/T6BeGQEjdYKqpCjkn7R8N4I4fVGLilGgwdvA1uJbAuJJMiUJali54vY3Y+I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSNPR06MB9190 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c40f::6; envelope-from=jamin_lin@aspeedtech.com; helo=SEYPR02CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1780378203505158500 Content-Type: text/plain; charset="utf-8" Instantiate and realize the watchdog models for the AST1040 SoC. The AST1040 watchdog controller is compatible with the AST2700 watchdog controller, so reuse the existing AST2700 watchdog model. Configure the AST1040 SoC with 8 watchdog instances and map them to their corresponding MMIO regions. The first watchdog controller (WDT0) is located at 0x74c37000, with subsequent watchdogs placed according to the controller register space size. Each watchdog is linked to the SCU device before realization to provide the required reset and system control interactions. Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater --- hw/arm/aspeed_ast1040.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/hw/arm/aspeed_ast1040.c b/hw/arm/aspeed_ast1040.c index 6d1cb9b102..57ffc0807a 100644 --- a/hw/arm/aspeed_ast1040.c +++ b/hw/arm/aspeed_ast1040.c @@ -119,6 +119,11 @@ static void aspeed_soc_ast1040_init(Object *obj) } object_initialize_child(obj, "i2c", &s->i2c, TYPE_ASPEED_1040_I2C); =20 + for (i =3D 0; i < sc->wdts_num; i++) { + object_initialize_child(obj, "wdt[*]", &s->wdt[i], + "aspeed.wdt-ast2700"); + } + object_initialize_child(obj, "pwm", &s->pwm, TYPE_UNIMPLEMENTED_DEVICE= ); object_initialize_child(obj, "espi", &s->espi, TYPE_UNIMPLEMENTED_DEVI= CE); object_initialize_child(obj, "udc", &s->udc, TYPE_UNIMPLEMENTED_DEVICE= ); @@ -249,6 +254,19 @@ static void aspeed_soc_ast1040_realize(DeviceState *de= v_soc, Error **errp) sysbus_connect_irq(SYS_BUS_DEVICE(&s->i2c.busses[i]), 0, irq); } =20 + /* Watch dog */ + for (i =3D 0; i < sc->wdts_num; i++) { + AspeedWDTClass *awc =3D ASPEED_WDT_GET_CLASS(&s->wdt[i]); + hwaddr wdt_offset =3D sc->memmap[ASPEED_DEV_WDT] + i * awc->iosize; + + object_property_set_link(OBJECT(&s->wdt[i]), "scu", OBJECT(&s->scu= ), + &error_abort); + if (!sysbus_realize(SYS_BUS_DEVICE(&s->wdt[i]), errp)) { + return; + } + aspeed_mmio_map(s->memory, SYS_BUS_DEVICE(&s->wdt[i]), 0, wdt_offs= et); + } + /* Unimplemented peripherals */ aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->pwm), "aspeed.pwm", @@ -290,6 +308,7 @@ static void aspeed_soc_ast1040_class_init(ObjectClass *= klass, const void *data) sc->sram_size[1] =3D 16 * MiB; /* Hyper RAM */ sc->uarts_num =3D 13; sc->sgpio_num =3D 2; + sc->wdts_num =3D 8; sc->uarts_base =3D ASPEED_DEV_UART0; sc->irqmap =3D aspeed_soc_ast1040_irqmap; sc->memmap =3D aspeed_soc_ast1040_memmap; --=20 2.43.0