From nobody Sat May 30 17:43:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=9elements.com ARC-Seal: i=1; a=rsa-sha256; t=1780058648; cv=none; d=zohomail.com; s=zohoarc; b=hsJcVjWCvkS9xz2RUhEZ8kYwFiFDo6OYn7R6Kj484R/qWzUWfs02fIrJXzm7pLFVarr+iNy8iDRXxwXO8OBDvDTjvQLOpocSiUpLA2C1CTse7sTE9oDj1dnne6QNmO6hLaM1rvOWeDUWsYuV43kyopKVa1dWoeJu6YS6DBohEf4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780058648; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=GiatuOl2+dyGsu3brL4iC0xQDkMxt6rEepwRrvFN+Xs=; b=lNykgtGxNvKjisF8p18XCp2meETaY8Ph6uSnQgWSbawJcuDuQh3hrlc5btN48iKvW6o0F6fKEidxpShY6BPWDB0kTgDRsVfe+01bJOgzkAyCNy51PJ3Dx+6SgsKmk0Jh7e/52kRS3PKgfhkaf+N99AOSE6MwXHjgKPFv7Wd28Q4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780058648665642.876734440604; Fri, 29 May 2026 05:44:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wSwZ4-0000y4-BM; Fri, 29 May 2026 08:43:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wSwYo-0000x6-Jm for qemu-devel@nongnu.org; Fri, 29 May 2026 08:43:35 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wSwYm-0004h9-2w for qemu-devel@nongnu.org; Fri, 29 May 2026 08:43:34 -0400 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-45eeba68948so1181050f8f.1 for ; Fri, 29 May 2026 05:43:31 -0700 (PDT) Received: from alexanderarchlinux ([188.111.3.154]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45ef35598e5sm3163354f8f.27.2026.05.29.05.43.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2026 05:43:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; t=1780058610; x=1780663410; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GiatuOl2+dyGsu3brL4iC0xQDkMxt6rEepwRrvFN+Xs=; b=ftSPtaxA9zRa2DwoQOhdRM4Kx7WHc6y7muF89T36nqNBCGzjOFm/qaTqO4y+Y6BWiF V2cZ8sa7dbXvCWlvkzUrbo1IFP+8u1MnUfObFHI61b76VO3HE9lfB3/JR7aYyXpa8lVh x+eGucDv+4u0/O0C32D6elrm8Vj3/+0BnIlhQ/NLRCsjJqZTqm4JGy7n/lYjGl3INfT1 yOqGPaA4Ls0e1+SpH29RCYJEkF8kw4uUvGU+pZ5Qs1dNR6kuBlfrb9fmW03cC/Mw92LC 3SQ1g0G45QAGnAncxRhgHxdKU3MU3fwr+D7as1Zhyl2doCo4q2sKG767s5F6o1t9jkgn IWDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780058610; x=1780663410; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GiatuOl2+dyGsu3brL4iC0xQDkMxt6rEepwRrvFN+Xs=; b=f9t9knUyHfPMgKlO/prgS3h+bwjYemJHNlTdAOGkPjNqel94HSUg77VQVOaB/mx7DJ sKHZPqXsPq711ZOQwConvMVXQTxaQiNDnjo+Dy7MwyYgepdm5t9+yieA7hg9ixzcVlFq eBdpXwg9c/audrqoiOaDONmu8MVgm87rleVuRUp4PqaeKSx/AebOSCKUuHFyd+v/e1RT yNy/P4dB9yW5GUC5hyHuGsGJZsVBQwRHbHMzFu3hfK1sDDza9PpjAurHxObgdQN3RFo8 H6uWFyrA915me+1YdQg7SVcu1d4lI0105DtmUEGzwTBq82+AFaZvOdICZkmUwyHGhnI8 IP6w== X-Gm-Message-State: AOJu0YzsHRI2+uefSoMLMhWcChBbiPV7Grx2y7m8z6Oc3yu2VnDCVrZ4 ly3GB5TApP1uCleWi73Bn9m3qKPPKWk6H+gf0q0rzWWFibWxODaQDBwA63Ma4PA+Up+KBtqGlwm yuURiCWQ= X-Gm-Gg: Acq92OF2qVtKP3fEhUAO4UIMS/9UaB2c/wKWa7/aclusevj5mQXznCOuLQiTahvz7xX Ss8ybuuHvmysl+cG5F+i5mpr6NC7cyA3hTrOpod0t5IwB7gKIK/1pm51kMuJV3PV3Hs7oFKyTTS xrGcQ/2nyQ40I39v7UIISD4kUSRoHA84T+fLpl1zQEjTVXLPeVdXBA5Dwt2tHWq77/rm2YZdgIR CfXaict7NRtSEH+laMlwvg3gF9cjSOXgzQ1s2pp0Bu6/SDMWcVXBokf2Bt5VeayR7jliixJf2Cv YX5HDZX0LopgdoUf6eWe8AmGSmD5J8Dpodpk2c7ZMiqiW1OeYzrH377stvIZcCjRhJJsDEV30Xj 7PxmSxanfcSL7fACEndInrW6dVdHC8jLPifdCAjVk2olFIWXOmE6dhSinn73o17WklMcpmnMTS6 LGiTUigIYF+8Vq7LBplDullt7ocg0QSsNH0bLrK7FogK7+j0UwogJqh2o= X-Received: by 2002:a05:6000:c04:b0:45e:651c:47bb with SMTP id ffacd0b85a97d-45ef144d494mr4053179f8f.28.1780058610428; Fri, 29 May 2026 05:43:30 -0700 (PDT) From: Alexander Hansen To: qemu-devel@nongnu.org Cc: Alexander Hansen , Titus Rwantare , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , Steven Lee , Troy Lee , Jamin Lin , Kane Chen , Andrew Jeffery , Joel Stanley , qemu-arm@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PATCH v5 1/5] ast2600: yosemite4 initial support Date: Fri, 29 May 2026 14:37:30 +0200 Message-ID: <20260529124237.94087-2-alexander.hansen@9elements.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260529124237.94087-1-alexander.hansen@9elements.com> References: <20260529124237.94087-1-alexander.hansen@9elements.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=alexander.hansen@9elements.com; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @9elements.com) X-ZM-MESSAGEID: 1780058651980154100 Initial patch based on [1] to support yosemite v4 bmc emulation. The goal of this machine support is to support OpenBMC development. Reference linux devicetree from openbmc linux is [2]. Status: - Enclosure FRU: showing up - Management Board FRU: showing up - Blade Board FRU: showing up - Blade Board sensors: not implemented - Blade Chassis FRU: showing up - Fan Board FRU: both showing up - Fan Board sensors: supported Overall the emulation is incomplete but already helpful in development and testing. The focus of this initial support is on the FRU eeproms and fanboard sensors. Tested: booted an OpenBMC image for yosemite4 target. References: [1] https://github.com/9elements/qemu/commit/32139f913c2bd0ebe4bd26c4676586= 1f6f9f2d49 [2] arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts [3] https://github.com/legoater/qemu-aspeed-boot/pull/5 Cc: Titus Rwantare Cc: "C=C3=A9dric Le Goater" (maintainer:ASPEED BMCs) Cc: Peter Maydell (maintainer:ASPEED BMCs) Cc: Steven Lee (reviewer:ASPEED BMCs) Cc: Troy Lee (reviewer:ASPEED BMCs) Cc: Jamin Lin (reviewer:ASPEED BMCs) Cc: Kane Chen (reviewer:ASPEED BMCs) Cc: Andrew Jeffery (reviewer:ASPEED BMCs) Cc: Joel Stanley (reviewer:ASPEED BMCs) Cc: qemu-arm@nongnu.org (open list:ASPEED BMCs) Cc: qemu-devel@nongnu.org (open list:All patches CC here) Reviewed-by: C=C3=A9dric Le Goater Signed-off-by: Alexander Hansen --- hw/arm/aspeed_ast2600_fby4.c | 267 +++++++++++++++++++++++++++++++++++ hw/arm/meson.build | 1 + 2 files changed, 268 insertions(+) create mode 100644 hw/arm/aspeed_ast2600_fby4.c diff --git a/hw/arm/aspeed_ast2600_fby4.c b/hw/arm/aspeed_ast2600_fby4.c new file mode 100644 index 0000000000..89fb0ac2fd --- /dev/null +++ b/hw/arm/aspeed_ast2600_fby4.c @@ -0,0 +1,267 @@ +/* + * Facebook Yosemite V4 + * + * Copyright 2026 9elements. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include "qemu/osdep.h" +#include "hw/arm/machines-qom.h" +#include "hw/arm/aspeed.h" +#include "hw/arm/aspeed_soc.h" +#include "hw/nvram/eeprom_at24c.h" +#include "hw/i2c/i2c_mux_pca954x.h" +#include "hw/gpio/pca9552.h" + +#define FBY4_BMC_RAM_SIZE ASPEED_RAM_SIZE(2 * GiB) + +/* START OF EEPROM CONTENTS */ + +/* + *./frugen -s board.mfg=3D"Wiwynn" \ + * --set board.pname=3D"Fan Board FSC-MAX ADC-TI LED-NXP EFUSE-MAX" \ + * --set text:board.pn=3D"BRD-PN-345" \ + * --board-date "10/1/2017 12:58:00" \ + * --set board.serial=3D"123456" \ + * --set product.pname=3D"Yosemite V4" \ + * --set product.mfg=3D"Wiwynn" \ + * --set product.ver=3D"v1.1" \ + * --set product.serial=3D"123456" \ + * --set product.atag=3D"PLACEHOLDER" \ + * --set product.custom=3D"Fanboard Custom1" \ + * --set product.custom.1=3D"Fanboard Custom2" \ + * --set text:product.pn=3D"PN-345" \ + * fru-yv4-fanboard.bin + */ +/* EM Config: yosemite4_fanboard_fsc_max_adc_ti_led_nxp_ons_efuse_max.json= */ +/* Yosemite4 fan board */ +static const uint8_t fru_yv4_fanboard_bin[] =3D { + 0x01, 0x00, 0x00, 0x01, 0x0b, 0x00, 0x00, 0xf3, 0x01, 0x0a, 0x19, 0xce, + 0xc2, 0xa8, 0xc6, 0x57, 0x69, 0x77, 0x79, 0x6e, 0x6e, 0xea, 0x46, 0x61, + 0x6e, 0x20, 0x42, 0x6f, 0x61, 0x72, 0x64, 0x20, 0x46, 0x53, 0x43, 0x2d, + 0x4d, 0x41, 0x58, 0x20, 0x41, 0x44, 0x43, 0x2d, 0x54, 0x49, 0x20, 0x4c, + 0x45, 0x44, 0x2d, 0x4e, 0x58, 0x50, 0x20, 0x45, 0x46, 0x55, 0x53, 0x45, + 0x2d, 0x4d, 0x41, 0x58, 0x85, 0x91, 0x34, 0x51, 0x95, 0x05, 0xca, 0x42, + 0x52, 0x44, 0x2d, 0x50, 0x4e, 0x2d, 0x33, 0x34, 0x35, 0xc0, 0xc1, 0x00, + 0x00, 0x00, 0x00, 0xdb, 0x01, 0x09, 0x19, 0xc6, 0x57, 0x69, 0x77, 0x79, + 0x6e, 0x6e, 0xcb, 0x59, 0x6f, 0x73, 0x65, 0x6d, 0x69, 0x74, 0x65, 0x20, + 0x56, 0x34, 0xc6, 0x50, 0x4e, 0x2d, 0x33, 0x34, 0x35, 0xc4, 0x76, 0x31, + 0x2e, 0x31, 0x85, 0x91, 0x34, 0x51, 0x95, 0x05, 0x89, 0x30, 0x1b, 0x8e, + 0x25, 0xfa, 0xb2, 0x64, 0x29, 0x03, 0xc0, 0xd0, 0x46, 0x61, 0x6e, 0x62, + 0x6f, 0x61, 0x72, 0x64, 0x20, 0x43, 0x75, 0x73, 0x74, 0x6f, 0x6d, 0x32, + 0xc1, 0x00, 0x00, 0x9d +}; +static const size_t fru_yv4_fanboard_bin_len =3D sizeof(fru_yv4_fanboard_b= in); + +/* + *./frugen -s board.mfg=3D"Wiwynn" \ + * --set board.pname=3D"Sentinel Dome without Retimer" \ + * --set text:board.pn=3D"BRD-PN-345" \ + * --board-date "10/1/2017 12:58:00" \ + * --set board.serial=3D"123456" \ + * --set product.pname=3D"Yosemite V4" \ + * --set product.mfg=3D"Wiwynn" \ + * --set product.ver=3D"v1.1" \ + * --set product.serial=3D"123456" \ + * --set product.atag=3D"PLACEHOLDER" \ + * --set product.custom=3D"Yosemite V4 T1" \ + * --set product.custom.1=3D"Yosemite V4 T1" \ + * --set text:product.pn=3D"PN-345" \ + * fru-yv4-sentineldome-board.bin + */ +/* product.cust maps to PRODUCT_INFO_AM2 */ +/* EM Config: yosemite4_sentineldome_t1.json */ +/* Yosemite4 Sentinel Dome without Retimer Boards */ +static const uint8_t fru_yv4_sentineldome_board_bin[] =3D { + 0x01, 0x00, 0x00, 0x01, 0x09, 0x00, 0x00, 0xf5, 0x01, 0x08, 0x19, 0xce, + 0xc2, 0xa8, 0xc6, 0x57, 0x69, 0x77, 0x79, 0x6e, 0x6e, 0xdd, 0x53, 0x65, + 0x6e, 0x74, 0x69, 0x6e, 0x65, 0x6c, 0x20, 0x44, 0x6f, 0x6d, 0x65, 0x20, + 0x77, 0x69, 0x74, 0x68, 0x6f, 0x75, 0x74, 0x20, 0x52, 0x65, 0x74, 0x69, + 0x6d, 0x65, 0x72, 0x85, 0x91, 0x34, 0x51, 0x95, 0x05, 0xca, 0x42, 0x52, + 0x44, 0x2d, 0x50, 0x4e, 0x2d, 0x33, 0x34, 0x35, 0xc0, 0xc1, 0x00, 0x78, + 0x01, 0x09, 0x19, 0xc6, 0x57, 0x69, 0x77, 0x79, 0x6e, 0x6e, 0xcb, 0x59, + 0x6f, 0x73, 0x65, 0x6d, 0x69, 0x74, 0x65, 0x20, 0x56, 0x34, 0xc6, 0x50, + 0x4e, 0x2d, 0x33, 0x34, 0x35, 0xc4, 0x76, 0x31, 0x2e, 0x31, 0x85, 0x91, + 0x34, 0x51, 0x95, 0x05, 0x89, 0x30, 0x1b, 0x8e, 0x25, 0xfa, 0xb2, 0x64, + 0x29, 0x03, 0xc0, 0xce, 0x59, 0x6f, 0x73, 0x65, 0x6d, 0x69, 0x74, 0x65, + 0x20, 0x56, 0x34, 0x20, 0x54, 0x31, 0xc1, 0x00, 0x00, 0x00, 0x00, 0xeb +}; +static const size_t fru_yv4_sentineldome_board_bin_len =3D + sizeof(fru_yv4_sentineldome_board_bin); + +/* + *./frugen -s board.mfg=3D"Wiwynn" \ + * --set board.pname=3D"Sentinel Dome" \ + * --set text:board.pn=3D"BRD-PN-345" \ + * --board-date "10/1/2017 12:58:00" \ + * --set board.serial=3D"123456" \ + * --set product.pname=3D"Yosemite V4" \ + * --set product.mfg=3D"Wiwynn" \ + * --set product.ver=3D"v1.1" \ + * --set product.serial=3D"123456" \ + * --set product.atag=3D"PLACEHOLDER" \ + * --set text:product.pn=3D"PN-345" \ + * fru-yv4-sentineldome-chassis.bin + */ +/* EM Config: yosemite4_sentineldome_chassis.json */ +/* Yosemite 4 Sentinel Dome Chassis FRU */ +static const uint8_t fru_yv4_sentineldome_chassis_bin[] =3D { + 0x01, 0x00, 0x00, 0x01, 0x07, 0x00, 0x00, 0xf7, 0x01, 0x06, 0x19, 0xce, + 0xc2, 0xa8, 0xc6, 0x57, 0x69, 0x77, 0x79, 0x6e, 0x6e, 0xcd, 0x53, 0x65, + 0x6e, 0x74, 0x69, 0x6e, 0x65, 0x6c, 0x20, 0x44, 0x6f, 0x6d, 0x65, 0x85, + 0x91, 0x34, 0x51, 0x95, 0x05, 0xca, 0x42, 0x52, 0x44, 0x2d, 0x50, 0x4e, + 0x2d, 0x33, 0x34, 0x35, 0xc0, 0xc1, 0x00, 0xb6, 0x01, 0x07, 0x19, 0xc6, + 0x57, 0x69, 0x77, 0x79, 0x6e, 0x6e, 0xcb, 0x59, 0x6f, 0x73, 0x65, 0x6d, + 0x69, 0x74, 0x65, 0x20, 0x56, 0x34, 0xc6, 0x50, 0x4e, 0x2d, 0x33, 0x34, + 0x35, 0xc4, 0x76, 0x31, 0x2e, 0x31, 0x85, 0x91, 0x34, 0x51, 0x95, 0x05, + 0x89, 0x30, 0x1b, 0x8e, 0x25, 0xfa, 0xb2, 0x64, 0x29, 0x03, 0xc0, 0xc1, + 0x00, 0x00, 0x00, 0x59 +}; +static const size_t fru_yv4_sentineldome_chassis_bin_len =3D + sizeof(fru_yv4_sentineldome_chassis_bin); + +/* + *./frugen -s board.mfg=3D"Wiwynn" \ + * --set board.pname=3D"Management Board wBMC" \ + * --set text:board.pn=3D"BRD-PN-345" \ + * --board-date "10/1/2017 12:58:00" \ + * --set board.serial=3D"123456" \ + * --set product.pname=3D"Yosemite V4" \ + * --set product.mfg=3D"Wiwynn" \ + * --set product.ver=3D"v1.1" \ + * --set product.serial=3D"123456" \ + * --set product.atag=3D"PLACEHOLDER" \ + * --set text:product.pn=3D"PN-345" \ + * fru-yv4-eclosure.bin + */ +/* EM Config: yosemite4_chassis.json, yosemite4.json */ +/* Yosemite 4 Sentinel Dome Enclosure FRU */ +static const uint8_t fru_yv4_eclosure_bin[] =3D { + 0x01, 0x00, 0x00, 0x01, 0x08, 0x00, 0x00, 0xf6, 0x01, 0x07, 0x19, 0xce, + 0xc2, 0xa8, 0xc6, 0x57, 0x69, 0x77, 0x79, 0x6e, 0x6e, 0xd5, 0x4d, 0x61, + 0x6e, 0x61, 0x67, 0x65, 0x6d, 0x65, 0x6e, 0x74, 0x20, 0x42, 0x6f, 0x61, + 0x72, 0x64, 0x20, 0x77, 0x42, 0x4d, 0x43, 0x85, 0x91, 0x34, 0x51, 0x95, + 0x05, 0xca, 0x42, 0x52, 0x44, 0x2d, 0x50, 0x4e, 0x2d, 0x33, 0x34, 0x35, + 0xc0, 0xc1, 0x00, 0x26, 0x01, 0x07, 0x19, 0xc6, 0x57, 0x69, 0x77, 0x79, + 0x6e, 0x6e, 0xcb, 0x59, 0x6f, 0x73, 0x65, 0x6d, 0x69, 0x74, 0x65, 0x20, + 0x56, 0x34, 0xc6, 0x50, 0x4e, 0x2d, 0x33, 0x34, 0x35, 0xc4, 0x76, 0x31, + 0x2e, 0x31, 0x85, 0x91, 0x34, 0x51, 0x95, 0x05, 0x89, 0x30, 0x1b, 0x8e, + 0x25, 0xfa, 0xb2, 0x64, 0x29, 0x03, 0xc0, 0xc1, 0x00, 0x00, 0x00, 0x59 +}; +static const size_t fru_yv4_eclosure_bin_len =3D sizeof(fru_yv4_eclosure_b= in); + +/* END OF EEPROM CONTENTS */ + +static void fby4_i2c_init_fanboard(I2CSlave *fan_mux, size_t eepromSize) +{ + /* 2 fan boards */ + for (int i =3D 0; i <=3D 1; i++) { + /* downstream bus */ + I2CBus *bus =3D pca954x_i2c_get_bus(fan_mux, i); + + /* ti,adc128d818 @ 0x1f (adc) */ + /* TODO */ + + /* maxim,max31790 @ 0x20 (pwm) */ + /* TODO */ + + /* + * ti,tca6424 @ 0x22 (gpio) + * linux handles tca6424 with PCA953X_TYPE, same as pca9535 + * { "pca9535", 16 | PCA953X_TYPE | PCA_INT, }, + * { "tca6424", 24 | PCA953X_TYPE | PCA_INT, }, + * so we _could_ be fine here unless more than 16 gpios are used + */ + i2c_slave_create_simple(bus, TYPE_PCA9535, 0x22); + + /* + * NOTE: above works and could use for gpio presence: + * $ gpioget gpiochip2 2 + * 1 + */ + + /* maxim,max31790 @ 0x2f (pwm) */ + /* TODO */ + + /* maxim,max11615 @ 0x33 (adc) */ + /* TODO */ + + at24c_eeprom_init_rom( + bus, 0x52, eepromSize, + fru_yv4_fanboard_bin, + fru_yv4_fanboard_bin_len); + + /* LED blink driver / gpio expander */ + /* nxp,pca9552 @ 0x61 (gpio) */ + i2c_slave_create_simple(bus, TYPE_PCA9552, 0x61); + } +} + +static void fby4_i2c_init_blade_chassis(I2CBus *bus, size_t eepromSize) +{ + /* Sentinel Dome Blade EEPROMS */ + + /* Board */ + at24c_eeprom_init_rom(bus, 0x54, eepromSize, + fru_yv4_sentineldome_board_bin, fru_yv4_sentineldome_board_bin_len= ); + + /* Chassis */ + at24c_eeprom_init_rom(bus, 0x55, eepromSize, + fru_yv4_sentineldome_chassis_bin, fru_yv4_sentineldome_chassis_bin_= len); +} + +static void fby4_i2c_init_multiple_blade_chassis(I2CBus **i2c, + size_t eepromSize) +{ + /* there is 8 blade chassis, but we only emulate 2 for performance rea= son */ + for (int bus =3D 1; bus <=3D (8 / 4); bus++) { + fby4_i2c_init_blade_chassis(i2c[bus], eepromSize); + } +} + +static void fby4_i2c_init(AspeedMachineState *bmc) +{ + AspeedSoCState *soc =3D bmc->soc; + I2CBus *i2c[16]; + + for (int i =3D 0; i < 16; i++) { + i2c[i] =3D aspeed_i2c_get_bus(&soc->i2c, i); + } + + /* Enclosure (EM Config: yosemite4_chassis.json, yosemite4.json) */ + at24c_eeprom_init_rom(i2c[1], 0x51, 128 * KiB, + fru_yv4_eclosure_bin, fru_yv4_eclosure_bin_len); + + fby4_i2c_init_multiple_blade_chassis(i2c, 128 * KiB); + + /* Yv4 fanboard connection */ + I2CSlave *fan_mux =3D i2c_slave_create_simple(i2c[14], TYPE_PCA9546, 0= x74); + + fby4_i2c_init_fanboard(fan_mux, 128 * KiB); +} + +static void aspeed_machine_fby4_class_init(ObjectClass *oc, const void *da= ta) +{ + MachineClass *mc =3D MACHINE_CLASS(oc); + AspeedMachineClass *amc =3D ASPEED_MACHINE_CLASS(oc); + + mc->desc =3D "Facebook fby4 BMC (Cortex-A7)"; + amc->fmc_model =3D "mx66l1g45g"; + amc->num_cs =3D 2; + amc->macs_mask =3D ASPEED_MAC3_ON; + amc->i2c_init =3D fby4_i2c_init; + mc->default_ram_size =3D FBY4_BMC_RAM_SIZE; + aspeed_machine_class_init_cpus_defaults(mc); +} + +static const TypeInfo aspeed_ast2600_fby4_types[] =3D { + { + .name =3D MACHINE_TYPE_NAME("fby4-bmc"), + .parent =3D MACHINE_TYPE_NAME("ast2600-evb"), + .class_init =3D aspeed_machine_fby4_class_init, + .interfaces =3D arm_machine_interfaces, + } +}; + +DEFINE_TYPES(aspeed_ast2600_fby4_types) diff --git a/hw/arm/meson.build b/hw/arm/meson.build index 68d204bb4e..30d92c3f33 100644 --- a/hw/arm/meson.build +++ b/hw/arm/meson.build @@ -59,6 +59,7 @@ arm_ss.add(when: 'CONFIG_ASPEED_SOC', if_true: files( 'aspeed_ast2600_catalina.c', 'aspeed_ast2600_evb.c', 'aspeed_ast2600_fby35.c', + 'aspeed_ast2600_fby4.c', 'aspeed_ast2600_fuji.c', 'aspeed_ast2600_gb200nvl.c', 'aspeed_ast2600_rainier.c', --=20 2.54.0 From nobody Sat May 30 17:43:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=9elements.com ARC-Seal: i=1; a=rsa-sha256; t=1780058665; cv=none; d=zohomail.com; s=zohoarc; b=arBh/JcN41EGr9IvIwUvJ+rABjmp3WU5nor1lVWuboFNdD4cXRbm6Wk0ES0CQ+O9hI21rSuZ+qpXibMGPd0pbk1f4TqYy9+eTlwAdhab4sU9igyN1KgTq+3pBo0RyBVW5I/jR9QBtFZg3jtrSTUcPCnGMxfTCI5KIjDoXGkMe9U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780058665; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ZhogzhFO7uDRTLBEbud3mZouqlv1sTkvv/Oi6WwVzrM=; b=BrsTcCbXQyGuJKWJJGMSq9cR73We4Cl8ox0ckHn1NxB5O7sSY3U+ZL4v8nYD0fwopwXbY0kYjjxCiAB36DfTOpsFoqyiZhyoayoYJsQ/73ZFqNhy7OMCxcZxqVuZeDxPHSb/e3nQKCZoDd9YP5qqpyVk9joBh7veuTEddGfcry0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780058665068429.0679403246884; Fri, 29 May 2026 05:44:25 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wSwZO-000112-NP; Fri, 29 May 2026 08:44:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wSwYw-0000xn-Bv for qemu-devel@nongnu.org; Fri, 29 May 2026 08:43:46 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wSwYs-0004j5-T1 for qemu-devel@nongnu.org; Fri, 29 May 2026 08:43:40 -0400 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-45eecb8bf67so1178468f8f.2 for ; Fri, 29 May 2026 05:43:36 -0700 (PDT) Received: from alexanderarchlinux ([188.111.3.154]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45ef35598e5sm3163354f8f.27.2026.05.29.05.43.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2026 05:43:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; t=1780058616; x=1780663416; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZhogzhFO7uDRTLBEbud3mZouqlv1sTkvv/Oi6WwVzrM=; b=KFsjwUgqo7HWCNY50FblVmdqvH3Nr+v+eivO2hqc8MMk1gFhBhVuSZMIY6jkCJYTQQ qnDVjIa3CCsXdF6jFvbco2njj80fqcVoubsITW78dG5witSDXvIk3xakzPPz2ld42SWu AiN4h0zaNq8+P1DRQ0f61c+CKJAe1UIt1tBQPieARCKuDQXCatDNJeYpbq880FYWsmMA +67tKvZTr/JKpVpuQyXdIerfhUd1wjWN2QGZ4NGoiwxCdxe/Yb0R++pA54hDK03XX7nD RR3iCc5N1eBVzE2xcg+PON4JRLrruTJ76wY+qlm8Sl0XkY72ranVdHzhkUR9I/8NnqGS Oriw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780058616; x=1780663416; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ZhogzhFO7uDRTLBEbud3mZouqlv1sTkvv/Oi6WwVzrM=; b=U6BFQgdn7sYNfhUJHO+oeqbZHnqgtHJbg7vN/cwJEdEWMxiDFchOwf2P/6dQb55p1v sxsls55BVRZ4Q+1CDdi0qemYs7M8mG/lCqzyocD55ikMUOiWS9siWpyqmEA6CjDHxwK2 2PsDN9vcmrHZbedkJaKIgnMpgrezXOHdIXAQEjz1uWpxvr4SVGtgssAK042PspMmzAnd xs+EboV4bw7Xfx+DEWKOwkN/ZcYN57gYFK6Zn8Lo4Iy0PL0NWfrouWUPMGUlYUQD9Nvc Io2zw8HMRHkDsmEQqMr5FWMRQkvRlZiH0MqSxG3BN0tXxS9AQPhRQvebT0Hi+A2lpB3+ fIzA== X-Gm-Message-State: AOJu0Yw/ZaiUlXu1SnY9V3DzaNkVf9F4OlO3bg4FkJtdcsKWViYCGR1j HhKZk3lKEQblwL+XY9F1OY0jXdS0izQ16Lz9Eb1izixsZseVFEZiTwfkEg88nNUkwgKiUlao1es 2vlvYf6c= X-Gm-Gg: Acq92OFqhRzuKtgWSxMxpClbonQcTTZMEzPRY6iq7+yq/sMtOxW4dXPKqWgnDVtAERY 4h8r9OXthzNlFtKejACCGT3MfsjTsFlSQUC4dQy0krRufE43Q9H7SXN7n3xWL+H2d+cSQR4Dbl7 t8erQHMHuBYd34LJTvOfFzZuV5l9N4ctLapfm89wB+4qXBNvQxBDENAHbs6n6C8mcri/RdkZqCZ 1w9lRB9DbBN3/Jq7ppwXuR33ZwEAxUtllLVHC2WNUEwOE/scNlSmSZj4ETSzRpNipKyuBJNCUtL K/CwTxuQZTV7JQTG84v3r0n+jkRMHRYdo1U1mLF3sbK04DaTfIzIknxQIxSx9Vk/UbpLO3PAMWI /mvoIMMV9nj6T3rPbnjJCIYRl/lL3A0U1nCxgZNKg+vqd2LT/3fGjMh+LVIWQ21aN8QwOHJqsR7 LLJO56wqCuUgRoeqttLwuew3XGUd4N6qMpkgtLoj3hw+RhC2VXFd1t5Mw= X-Received: by 2002:a05:6000:41ec:b0:45e:ce28:666a with SMTP id ffacd0b85a97d-45ef140196fmr5051697f8f.1.1780058615755; Fri, 29 May 2026 05:43:35 -0700 (PDT) From: Alexander Hansen To: qemu-devel@nongnu.org Cc: Alexander Hansen , Titus Rwantare , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , Steven Lee , Troy Lee , Jamin Lin , Kane Chen , Andrew Jeffery , Joel Stanley , qemu-arm@nongnu.org Subject: [PATCH v5 2/5] ast2600: yosemite4 functional test Date: Fri, 29 May 2026 14:37:31 +0200 Message-ID: <20260529124237.94087-3-alexander.hansen@9elements.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260529124237.94087-1-alexander.hansen@9elements.com> References: <20260529124237.94087-1-alexander.hansen@9elements.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=alexander.hansen@9elements.com; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @9elements.com) X-ZM-MESSAGEID: 1780058667474154100 Add a functional test for the Yosemite V4 (fby4-bmc) machine that validates: - U-Boot initialization and kernel boot sequence The test uses an OpenBMC image built for the yosemite4 board and validates console output through the boot process. Cc: Titus Rwantare Cc: "C=C3=A9dric Le Goater" (maintainer:ASPEED BMCs) Cc: Peter Maydell (maintainer:ASPEED BMCs) Cc: Steven Lee (reviewer:ASPEED BMCs) Cc: Troy Lee (reviewer:ASPEED BMCs) Cc: Jamin Lin (reviewer:ASPEED BMCs) Cc: Kane Chen (reviewer:ASPEED BMCs) Cc: Andrew Jeffery (reviewer:ASPEED BMCs) Cc: Joel Stanley (reviewer:ASPEED BMCs) Cc: qemu-arm@nongnu.org (open list:ASPEED BMCs) Cc: qemu-devel@nongnu.org (open list:All patches CC here) Signed-off-by: Alexander Hansen --- tests/functional/arm/meson.build | 2 ++ tests/functional/arm/test_aspeed_fby4.py | 45 ++++++++++++++++++++++++ 2 files changed, 47 insertions(+) create mode 100755 tests/functional/arm/test_aspeed_fby4.py diff --git a/tests/functional/arm/meson.build b/tests/functional/arm/meson.= build index 61b00932db..19331b3f16 100644 --- a/tests/functional/arm/meson.build +++ b/tests/functional/arm/meson.build @@ -15,6 +15,7 @@ test_arm_timeouts =3D { 'aspeed_anacapa' : 480, 'aspeed_bletchley' : 480, 'aspeed_catalina' : 480, + 'aspeed_fby4': 480, 'aspeed_gb200nvl_bmc' : 480, 'aspeed_rainier' : 480, 'bpim2u' : 500, @@ -50,6 +51,7 @@ tests_arm_system_thorough =3D [ 'aspeed_anacapa', 'aspeed_bletchley', 'aspeed_catalina', + 'aspeed_fby4', 'aspeed_gb200nvl_bmc', 'aspeed_rainier', 'bpim2u', diff --git a/tests/functional/arm/test_aspeed_fby4.py b/tests/functional/ar= m/test_aspeed_fby4.py new file mode 100755 index 0000000000..a521834f79 --- /dev/null +++ b/tests/functional/arm/test_aspeed_fby4.py @@ -0,0 +1,45 @@ +#!/usr/bin/env python3 +# +# Functional test that boots the ASPEED machines +# +# SPDX-License-Identifier: GPL-2.0-or-later + +from qemu_test import Asset +from qemu_test import wait_for_console_pattern +from aspeed import AspeedTest + + +class YosemiteV4Machine(AspeedTest): + + ASSET_YOSEMITE_V4_FLASH =3D Asset( + 'https://github.com/legoater/qemu-aspeed-boot/raw/refs/heads/maste= r/images/yosemite4-bmc/openbmc-20260505132843/obmc-phosphor-image-yosemite4= -20260505132843.static.mtd.xz', + 'dff6946363b41f952b15cfc3156482b89fcfc1b0ecfc3ec8b3ed496a5f001ef9') + + def do_test_arm_aspeed_openbmc_no_network(self, machine, image, uboot, + cpu_id, soc): + + self.set_machine(machine) + self.vm.set_console() + self.vm.add_args('-drive', f'file=3D{image},if=3Dmtd,format=3Draw', + '-snapshot') + self.vm.launch() + + self.wait_for_console_pattern(f'U-Boot {uboot}') + self.wait_for_console_pattern('## Loading kernel from FIT Image') + self.wait_for_console_pattern('Starting kernel ...') + self.wait_for_console_pattern(f'Booting Linux on physical CPU {cpu= _id}') + self.wait_for_console_pattern(f'ASPEED {soc}') + self.wait_for_console_pattern('/init as init process') + # yosemite v4 does not emit the hostname log which is + # different from the other machines. + self.wait_for_console_pattern('yosemite4 login:') + + def test_arm_ast2600_yosemitev4_openbmc(self): + image_path =3D self.uncompress(self.ASSET_YOSEMITE_V4_FLASH) + + self.do_test_arm_aspeed_openbmc_no_network('fby4-bmc', image=3Dima= ge_path, + uboot=3D'2019.04', cpu_id=3D'0xf00= ', + soc=3D'AST2600 rev A3') + +if __name__ =3D=3D '__main__': + AspeedTest.main() --=20 2.54.0 From nobody Sat May 30 17:43:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=9elements.com ARC-Seal: i=1; a=rsa-sha256; t=1780058679; cv=none; d=zohomail.com; s=zohoarc; b=ADwnDePT6PHXJ/m9fc8GQVaai3fqDdl32N33TKCXJqa4iGTqUXMNl0ThQEo5LPlZiGN/pVHjL+6mUBDMsH71wLqZhLlSEQ6ccXx5cdJYWJn8hJRzZXmm9Ogjez4SESP7LK1uXsxwSzlJRGWkVghFR9gEWLoRpLdXgO0ZjSp8pNg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780058679; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=kcBlTDpNI56yQQL/dKxDkjW3RIf5KPKY471849aFq/w=; b=ixXtpAxx658biFlRDVRkgwZqRmOpL/S+FiEIj2qZE3wnn+GF3N7whLbZrM0qTZUVeRvFKoWSxfVF3gwI84H3xwzYi2bVKZQ6lDAsCrZG0lMAPZ51FV68vp1y2iOhzzU4jrLD/u+R56zXXHsx9ZX7Sr4fbdld1bQbzjlg8NDAEKA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780058679428892.910958409922; Fri, 29 May 2026 05:44:39 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wSwZU-00016o-Qu; Fri, 29 May 2026 08:44:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wSwZ9-0000yh-Fx for qemu-devel@nongnu.org; Fri, 29 May 2026 08:43:55 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wSwYy-0004k2-D7 for qemu-devel@nongnu.org; Fri, 29 May 2026 08:43:49 -0400 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-4903d5c67bfso45350575e9.1 for ; Fri, 29 May 2026 05:43:43 -0700 (PDT) Received: from alexanderarchlinux ([188.111.3.154]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45ef35598e5sm3163354f8f.27.2026.05.29.05.43.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2026 05:43:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; t=1780058622; x=1780663422; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kcBlTDpNI56yQQL/dKxDkjW3RIf5KPKY471849aFq/w=; b=Rvupf/mo1gBjFTpdyR+66mTR2WCFxHrjBLbiQ20tvdhOIafrh3t877rcul5AcuY+Ha w1uxnm3yvqqOSctR4vxQDTy5eun8fFgPhv5xlSeyZrd9TbQBpu73z+/IpzK7OYTx4vUf wceB3OrRpv0jrtVJop5Lr2SRGmPbBbwH0yuDlt3Kim6tEhZonRlpYOr8SK8VWp19PIxW NY2Oi8AykAZl+zjjXEgJzYhnkE2093LbDm5ywQymC2S+jyxEbaqacJBv/D2QdNbojtK3 K+Z46qjHyNPCTXbMKUsb6pHeuS5WBLOoWkfo5uzquKkI3CUg9gX9cI/vEjaGmjTNqZu3 sLYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780058622; x=1780663422; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kcBlTDpNI56yQQL/dKxDkjW3RIf5KPKY471849aFq/w=; b=nelVsTL14+LqofPJN8xiCB18sX7T7YCM/BJ/FrgLxXK1rJVor9ZMH6QiNASCTysdMv 1SSgblKJUE7MQz3VW9o+Gli7kvYFqGnjabhlKGjZ5gvr6BBMYKKAyC1WPwK9SvRjyl3r u2Y8a+1L9bwR9ITXAAncxP1WQlmyapS1s/su/Mgcsn3Du/nuso2t4XBUMa6tflVAphZF CR5ixbvAxU0+95vDQWM5KvaEx4NfqcwtgldjJUTKq/L3lC/Uj/JtPFqg16q1sACajQ38 E9Dha1rUJiqgC7clr+GCFpwz7uA3nqA759Ad6NkbpteG9Kej0mGODwPdbd7btk5na/UV eWBQ== X-Gm-Message-State: AOJu0YzRA8w66viUTQdmUZBGQmDPVYtEvVmXe6wvpXmdPXSk0C8l3S2Q y+rH8jeZuM5PO9KxUhQ6hYPf+060inf8qKGnxESKgxXC+DiH38qMth6ra5WPEXUhYChHjSA2GRo sUbKvtdU= X-Gm-Gg: Acq92OExr4QSgMY3aO9DPCA7CvIHHTTQCn3KqAPs3acMDOPsDgivscEHiRzgDcsRw5y ONfrd7SAaWwPKC+oNIv3ABbxf10o2vaeQ/47+cy9Tu3AndojE/HLBhqnbg74y76BizIH/oF2huI A4hJbdUtppy/M+6g9AD95T9CwWLCQ10CMhxVjoggf0qD39nJSMCdzVpYvV8P6rY+cFodAG6nOPI tawjbg0X6Lji15cRWBjH2watuTWJ70DLkIxPqTG5CQdRtyEhntO+W+3LT33uH3pGiv5V1tsQvpN 4g19mBotUJ7XwXKeFozI9a071NFMwCJ572IBMm98Fj3z6sLq0ZKYoafKEzSk4tPIOs0ZvX6eFiX nz/y18xE2QnwLDCWj363tM2/ZmE138Ic6mtROHkal7rPi+5D2j2u6Kr2rUysB03o1DnXPUGrtiK sqVyhAEfBh3n+PcHB44gEDWggKW7tEHiSVPrKhYZadqnX0FDpkUZdQKmg= X-Received: by 2002:a05:600c:5247:b0:490:3d62:eb0 with SMTP id 5b1f17b1804b1-4909c0c6e4fmr48005985e9.24.1780058622120; Fri, 29 May 2026 05:43:42 -0700 (PDT) From: Alexander Hansen To: qemu-devel@nongnu.org Cc: Alexander Hansen , Titus Rwantare , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Jonathan Cameron , Paolo Bonzini , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, Steven Lee , Troy Lee , Jamin Lin , Kane Chen , Andrew Jeffery , Joel Stanley Subject: [PATCH v5 3/5] hw/sensor: MAX31790 support Date: Fri, 29 May 2026 14:37:32 +0200 Message-ID: <20260529124237.94087-4-alexander.hansen@9elements.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260529124237.94087-1-alexander.hansen@9elements.com> References: <20260529124237.94087-1-alexander.hansen@9elements.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=alexander.hansen@9elements.com; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @9elements.com) X-ZM-MESSAGEID: 1780058680950158500 Product: [1] Datasheet: [2] MAX31790 Support: - fan inputs are reading - tach reading propertional to pwm setting from linux driver - fans do not show any fault - 6 PWM registers influence 6 TACH registers There is intentional stub behavior in some places and various functions of the device are currently unsupported. MAX31790 currently unsupported: - slave address restriction - fan dynamics - spin-up configuration - fault state / failure possibility - rate-of-change control - tach mode - mixed layouts where number of fans !=3D number of tachs - see Figure 5.9 in [2] for example of mixed layout Anyone could expand it in the future for more accurate emulation. The reason for adding this device is to support Yosemite V4 emulation. Tested: on yosemite 4 qemu root@yosemite4:~# ls /sys/class/hwmon/hwmon2/ device fan2_fault fan3_target fan5_fault fan6_target pwm2 pw= m5 fan1_enable fan2_input fan4_enable fan5_input name pwm2_enable pwm5_= enable fan1_fault fan2_target fan4_fault fan5_target of_node pwm3 pwm6 fan1_input fan3_enable fan4_input fan6_enable power pwm3_enable pwm6= _enable fan1_target fan3_fault fan4_target fan6_fault pwm1 pwm4 subsystem fan2_enable fan3_input fan5_enable fan6_input pwm1_enable pwm4_enabl= e uevent root@yosemite4:~# cat /sys/class/hwmon/hwmon2/fan1_input 4551 root@yosemite4:~# cat /sys/class/hwmon/hwmon2/fan1_enable 1 root@yosemite4:~# cat /sys/class/hwmon/hwmon2/fan1_fault 0 root@yosemite4:~# cat /sys/class/hwmon/hwmon2/fan1_target 2048 root@yosemite4:~# cat /sys/class/hwmon/hwmon2/pwm1 178 root@yosemite4:~# cat /sys/class/hwmon/hwmon2/name max31790 Trace output: max31790_realize i2c_addr: 0x20 max31790_realize i2c_addr: 0x2f max31790_realize i2c_addr: 0x20 max31790_realize i2c_addr: 0x2f max31790_event i2c_addr: 0x20, event: 0x01 max31790_send i2c_addr: 0x20, data: 0x02 max31790_event i2c_addr: 0x20, event: 0x00 max31790_recv i2c_addr: 0x20, reg_addr: 0x02 max31790_recv_return i2c_addr: 0x20, returns: 0x08 ... References: [1] https://www.analog.com/en/products/MAX31790.html [2] https://www.analog.com/media/en/technical-documentation/data-sheets/MAX= 31790.pdf Cc: Titus Rwantare Cc: "C=C3=A9dric Le Goater" (maintainer:ASPEED BMCs) Cc: Jonathan Cameron Cc: Paolo Bonzini Cc: Peter Maydell Cc: "Philippe Mathieu-Daud=C3=A9" Cc: qemu-arm@nongnu.org Cc: qemu-devel@nongnu.org Signed-off-by: Alexander Hansen --- MAINTAINERS | 1 + hw/arm/aspeed_ast2600_fby4.c | 4 +- hw/sensor/max31790.c | 537 +++++++++++++++++++++++ hw/arm/Kconfig | 1 + hw/sensor/Kconfig | 4 + hw/sensor/meson.build | 1 + hw/sensor/trace-events | 11 + tests/functional/arm/test_aspeed_fby4.py | 26 ++ 8 files changed, 583 insertions(+), 2 deletions(-) create mode 100644 hw/sensor/max31790.c diff --git a/MAINTAINERS b/MAINTAINERS index cd5c4831e2..2a0dbd1cc4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3987,6 +3987,7 @@ S: Maintained F: hw/i2c/pmbus_device.c F: hw/sensor/adm1272.c F: hw/sensor/isl_pmbus_vr.c +F: hw/sensor/max31790.c F: hw/sensor/max34451.c F: include/hw/i2c/pmbus_device.h F: include/hw/sensor/isl_pmbus_vr.h diff --git a/hw/arm/aspeed_ast2600_fby4.c b/hw/arm/aspeed_ast2600_fby4.c index 89fb0ac2fd..1f391022a2 100644 --- a/hw/arm/aspeed_ast2600_fby4.c +++ b/hw/arm/aspeed_ast2600_fby4.c @@ -164,7 +164,7 @@ static void fby4_i2c_init_fanboard(I2CSlave *fan_mux, s= ize_t eepromSize) /* TODO */ =20 /* maxim,max31790 @ 0x20 (pwm) */ - /* TODO */ + i2c_slave_create_simple(bus, "max31790", 0x20); =20 /* * ti,tca6424 @ 0x22 (gpio) @@ -182,7 +182,7 @@ static void fby4_i2c_init_fanboard(I2CSlave *fan_mux, s= ize_t eepromSize) */ =20 /* maxim,max31790 @ 0x2f (pwm) */ - /* TODO */ + i2c_slave_create_simple(bus, "max31790", 0x2f); =20 /* maxim,max11615 @ 0x33 (adc) */ /* TODO */ diff --git a/hw/sensor/max31790.c b/hw/sensor/max31790.c new file mode 100644 index 0000000000..b0430ea094 --- /dev/null +++ b/hw/sensor/max31790.c @@ -0,0 +1,537 @@ +/* + * Maxim MAX31790 PMBus 6-Channel Fan Controller + * + * Datasheet: + * https://www.analog.com/media/en/technical-documentation/data-sheets/MAX= 31790.pdf + * + * Copyright 2026 9elements + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include "qemu/osdep.h" +#include "qemu/log.h" +#include "hw/i2c/i2c.h" +#include "qapi/error.h" +#include "qapi/visitor.h" +#include "migration/vmstate.h" +#include "qemu/module.h" +#include "qom/object.h" +#include "trace.h" + +#define TYPE_MAX31790 "max31790" + +#define MAX31790_NUM_FANS 6 +#define MAX31790_NUM_TACHS 12 + +#define MAX31790_REG_GLOBAL_CONFIG 0x00 +#define MAX31790_REG_PWM_FREQ 0x01 + +/* 0x02 to 0x07: N =3D 0 .. 5 */ +#define MAX31790_REG_FAN_CONFIG(N) (0x02 + N) + +/* 0x08 to 0x0d: N =3D 0 .. 5 */ +#define MAX31790_REG_FAN_DYNAMICS(N) (0x08 + N) + +#define MAX31790_REG_FAN_FAULT_STATUS_2 0x10 +#define MAX31790_REG_FAN_FAULT_STATUS_1 0x11 +#define MAX31790_REG_FAN_FAULT_MASK_2 0x12 +#define MAX31790_REG_FAN_FAULT_MASK_1 0x13 +#define MAX31790_REG_FAILED_FAN_OPT 0x14 + +/* 0x18 to 0x2f: N =3D 0 .. 11 */ +#define MAX31790_REG_TACH_COUNT_MSB(N) (0x18 + 2 * N) +#define MAX31790_REG_TACH_COUNT_LSB(N) (0x19 + 2 * N) + +/* 0x30 to 0x3b: N =3D 0 .. 5 */ +#define MAX31790_REG_PWM_DUTY_CYCLE_MSB(N) (0x30 + 2 * N) +#define MAX31790_REG_PWM_DUTY_CYCLE_LSB(N) (0x31 + 2 * N) + +/* .. reserved registers ... */ + +/* 0x40 to 0x4b: N =3D 0 .. 5 */ +#define MAX31790_REG_PWM_TARGET_DUTY_CYCLE_MSB(N) (0x40 + 2 * N) +#define MAX31790_REG_PWM_TARGET_DUTY_CYCLE_LSB(N) (0x41 + 2 * N) + +/* ... 'User Byte' registers ... */ + +/* 0x50 to 0x5b: N =3D 0 .. 5 */ +#define MAX31790_REG_TACH_TARGET_COUNT_MSB(N) (0x50 + 2 * N) +#define MAX31790_REG_TACH_TARGET_COUNT_LSB(N) (0x51 + 2 * N) + +struct MAX31790State { + I2CSlave i2c; + + uint8_t fan_config[MAX31790_NUM_FANS]; + uint8_t fan_dynamics[MAX31790_NUM_FANS]; + + uint16_t pwm[MAX31790_NUM_FANS]; + uint16_t tach_target[MAX31790_NUM_FANS]; + + /* + * Fan speed is measured by counting the number of internal 8192Hz + * (fTOSC/4) clock cycles that take place during a select- + * able number of tachometer periods. The number of clock + * cycles counted (11-bit value) is stored in the associated + * TACH Count registers and the desired number of cycles + * is stored in the TACH Target Count registers. + */ + uint16_t tach_count[MAX31790_NUM_TACHS]; + + /* command buffer */ + uint8_t len; + uint8_t buf[2]; + + /* output buffer */ + uint8_t outlen; + uint8_t outbuf[2]; + + /* selected register for read/write operation */ + uint8_t pointer; +}; + +struct MAX31790Class { + I2CSlaveClass parent_class; +}; + +OBJECT_DECLARE_TYPE(MAX31790State, MAX31790Class, MAX31790) + +static void max31790_read(MAX31790State *s) +{ + size_t index =3D 0; + uint8_t out0 =3D 0; + uint8_t out1 =3D 0; + + switch (s->pointer) { + case MAX31790_REG_FAN_CONFIG(0): + case MAX31790_REG_FAN_CONFIG(1): + case MAX31790_REG_FAN_CONFIG(2): + case MAX31790_REG_FAN_CONFIG(3): + case MAX31790_REG_FAN_CONFIG(4): + case MAX31790_REG_FAN_CONFIG(5): + out0 =3D s->fan_config[s->pointer - MAX31790_REG_FAN_CONFIG(0)]; + break; + case MAX31790_REG_FAN_DYNAMICS(0): + case MAX31790_REG_FAN_DYNAMICS(1): + case MAX31790_REG_FAN_DYNAMICS(2): + case MAX31790_REG_FAN_DYNAMICS(3): + case MAX31790_REG_FAN_DYNAMICS(4): + case MAX31790_REG_FAN_DYNAMICS(5): + out0 =3D s->fan_dynamics[s->pointer - MAX31790_REG_FAN_DYNAMICS(0)= ]; + break; + case MAX31790_REG_FAN_FAULT_STATUS_1: + case MAX31790_REG_FAN_FAULT_STATUS_2: + /* we do not have any fan fault */ + out0 =3D 0x00; + out1 =3D 0x00; + break; + case MAX31790_REG_TACH_COUNT_MSB(0): + case MAX31790_REG_TACH_COUNT_MSB(1): + case MAX31790_REG_TACH_COUNT_MSB(2): + case MAX31790_REG_TACH_COUNT_MSB(3): + case MAX31790_REG_TACH_COUNT_MSB(4): + case MAX31790_REG_TACH_COUNT_MSB(5): + case MAX31790_REG_TACH_COUNT_MSB(6): + case MAX31790_REG_TACH_COUNT_MSB(7): + case MAX31790_REG_TACH_COUNT_MSB(8): + case MAX31790_REG_TACH_COUNT_MSB(9): + case MAX31790_REG_TACH_COUNT_MSB(10): + case MAX31790_REG_TACH_COUNT_MSB(11): + index =3D (s->pointer - MAX31790_REG_TACH_COUNT_MSB(0)) / 2; + out0 =3D (s->tach_count[index] >> 8) & 0xff; + out1 =3D s->tach_count[index] & 0xff; + break; + + case MAX31790_REG_TACH_COUNT_LSB(0): + case MAX31790_REG_TACH_COUNT_LSB(1): + case MAX31790_REG_TACH_COUNT_LSB(2): + case MAX31790_REG_TACH_COUNT_LSB(3): + case MAX31790_REG_TACH_COUNT_LSB(4): + case MAX31790_REG_TACH_COUNT_LSB(5): + case MAX31790_REG_TACH_COUNT_LSB(6): + case MAX31790_REG_TACH_COUNT_LSB(7): + case MAX31790_REG_TACH_COUNT_LSB(8): + case MAX31790_REG_TACH_COUNT_LSB(9): + case MAX31790_REG_TACH_COUNT_LSB(10): + case MAX31790_REG_TACH_COUNT_LSB(11): + index =3D (s->pointer - MAX31790_REG_TACH_COUNT_LSB(0)) / 2; + out0 =3D s->tach_count[index] & 0xff; + break; + + case MAX31790_REG_PWM_DUTY_CYCLE_MSB(0): + case MAX31790_REG_PWM_DUTY_CYCLE_MSB(1): + case MAX31790_REG_PWM_DUTY_CYCLE_MSB(2): + case MAX31790_REG_PWM_DUTY_CYCLE_MSB(3): + case MAX31790_REG_PWM_DUTY_CYCLE_MSB(4): + case MAX31790_REG_PWM_DUTY_CYCLE_MSB(5): + index =3D (s->pointer - MAX31790_REG_PWM_DUTY_CYCLE_MSB(0)) / 2; + out0 =3D (s->pwm[index] >> 8) & 0xff; + out1 =3D s->pwm[index] & 0xff; + break; + case MAX31790_REG_PWM_DUTY_CYCLE_LSB(0): + case MAX31790_REG_PWM_DUTY_CYCLE_LSB(1): + case MAX31790_REG_PWM_DUTY_CYCLE_LSB(2): + case MAX31790_REG_PWM_DUTY_CYCLE_LSB(3): + case MAX31790_REG_PWM_DUTY_CYCLE_LSB(4): + case MAX31790_REG_PWM_DUTY_CYCLE_LSB(5): + index =3D (s->pointer - MAX31790_REG_PWM_DUTY_CYCLE_LSB(0)) / 2; + out0 =3D s->pwm[index] & 0xff; + break; + + case MAX31790_REG_PWM_TARGET_DUTY_CYCLE_MSB(0): + case MAX31790_REG_PWM_TARGET_DUTY_CYCLE_MSB(1): + case MAX31790_REG_PWM_TARGET_DUTY_CYCLE_MSB(2): + case MAX31790_REG_PWM_TARGET_DUTY_CYCLE_MSB(3): + case MAX31790_REG_PWM_TARGET_DUTY_CYCLE_MSB(4): + case MAX31790_REG_PWM_TARGET_DUTY_CYCLE_MSB(5): + index =3D (s->pointer - MAX31790_REG_PWM_TARGET_DUTY_CYCLE_MSB(0))= / 2; + out0 =3D (s->pwm[index] >> 8) & 0xff; + out1 =3D s->pwm[index] & 0xff; + break; + case MAX31790_REG_PWM_TARGET_DUTY_CYCLE_LSB(0): + case MAX31790_REG_PWM_TARGET_DUTY_CYCLE_LSB(1): + case MAX31790_REG_PWM_TARGET_DUTY_CYCLE_LSB(2): + case MAX31790_REG_PWM_TARGET_DUTY_CYCLE_LSB(3): + case MAX31790_REG_PWM_TARGET_DUTY_CYCLE_LSB(4): + case MAX31790_REG_PWM_TARGET_DUTY_CYCLE_LSB(5): + index =3D (s->pointer - MAX31790_REG_PWM_TARGET_DUTY_CYCLE_LSB(0))= / 2; + out0 =3D s->pwm[index] & 0xff; + break; + case MAX31790_REG_TACH_TARGET_COUNT_MSB(0): + case MAX31790_REG_TACH_TARGET_COUNT_MSB(1): + case MAX31790_REG_TACH_TARGET_COUNT_MSB(2): + case MAX31790_REG_TACH_TARGET_COUNT_MSB(3): + case MAX31790_REG_TACH_TARGET_COUNT_MSB(4): + case MAX31790_REG_TACH_TARGET_COUNT_MSB(5): + index =3D (s->pointer - MAX31790_REG_TACH_TARGET_COUNT_MSB(0)) / 2; + out0 =3D (s->tach_target[index] >> 8) & 0xff; + out1 =3D s->tach_target[index] & 0xff; + break; + case MAX31790_REG_TACH_TARGET_COUNT_LSB(0): + case MAX31790_REG_TACH_TARGET_COUNT_LSB(1): + case MAX31790_REG_TACH_TARGET_COUNT_LSB(2): + case MAX31790_REG_TACH_TARGET_COUNT_LSB(3): + case MAX31790_REG_TACH_TARGET_COUNT_LSB(4): + case MAX31790_REG_TACH_TARGET_COUNT_LSB(5): + index =3D (s->pointer - MAX31790_REG_TACH_TARGET_COUNT_LSB(0)) / 2; + out0 =3D s->tach_target[index] & 0xff; + break; + default: + qemu_log_mask(LOG_UNIMP, "%s: read of register %d\n", __func__, + s->pointer); + break; + } + + s->outbuf[0] =3D out0; + s->outbuf[1] =3D out1; +} + +static uint8_t max31790_get_speed_range(MAX31790State *s, size_t index) +{ + const uint16_t value =3D (s->fan_dynamics[index] >> 5); + return (value > 5) ? 32 : 1 << value; +} + +static void max31790_set_rpm(MAX31790State *s, size_t index, uint16_t rpm) +{ + trace_max31790_rpm_write(s->i2c.address, index, rpm); + + /* + * (see page 11) NP =3D number of tachometer pulses per revolution. + * Most general-purpose brushless DC fans produce two tachometer + * pulses per revolution. + */ + const uint64_t sr =3D max31790_get_speed_range(s, index); + + /* page 11: tach_count =3D 60 * SR * 8192 / (NP * RPM) */ + + /* prevent division by 0 */ + rpm =3D (rpm =3D=3D 0) ? 1 : rpm; + + /* simplified, assuming NP =3D 2 */ + uint64_t tach_count =3D (245760ULL * sr) / (uint64_t)rpm; + + /* datasheet: lowest 5 bits are 0 */ + s->tach_count[index] =3D tach_count << 5; + + trace_max31790_tach_count_reg(s->i2c.address, index, s->tach_count[ind= ex]); +} + +static void max31790_pwm_write(MAX31790State *s, size_t index, uint16_t va= lue) +{ + trace_max31790_pwm_write(s->i2c.address, index, value); + + s->pwm[index] =3D value; + + /* last 7 bits in register are 0 , 9 bits remaining */ + const uint16_t pwm_real =3D s->pwm[index] >> 7; + + /* maximum value will be 511 */ + + /* + * This formula has magic values which model the relationship + * of PWM input to a fan. Not derived from datasheet. + */ + max31790_set_rpm(s, index, 100 + pwm_real * 20); +} + +static void max31790_write_2_byte(MAX31790State *s) +{ + size_t index =3D 0; + const uint8_t value0 =3D s->buf[0]; + const uint8_t value1 =3D s->buf[1]; + + switch (s->pointer) { + case MAX31790_REG_FAN_CONFIG(0): + case MAX31790_REG_FAN_CONFIG(1): + case MAX31790_REG_FAN_CONFIG(2): + case MAX31790_REG_FAN_CONFIG(3): + case MAX31790_REG_FAN_CONFIG(4): + case MAX31790_REG_FAN_CONFIG(5): + break; /* handled by one byte write */ + case MAX31790_REG_FAN_DYNAMICS(0): + case MAX31790_REG_FAN_DYNAMICS(1): + case MAX31790_REG_FAN_DYNAMICS(2): + case MAX31790_REG_FAN_DYNAMICS(3): + case MAX31790_REG_FAN_DYNAMICS(4): + case MAX31790_REG_FAN_DYNAMICS(5): + break; /* handled by one byte write */ + case MAX31790_REG_PWM_TARGET_DUTY_CYCLE_MSB(0): + case MAX31790_REG_PWM_TARGET_DUTY_CYCLE_MSB(1): + case MAX31790_REG_PWM_TARGET_DUTY_CYCLE_MSB(2): + case MAX31790_REG_PWM_TARGET_DUTY_CYCLE_MSB(3): + case MAX31790_REG_PWM_TARGET_DUTY_CYCLE_MSB(4): + case MAX31790_REG_PWM_TARGET_DUTY_CYCLE_MSB(5): + index =3D (s->pointer - MAX31790_REG_PWM_TARGET_DUTY_CYCLE_MSB(0))= / 2; + max31790_pwm_write(s, index, value0 << 8 | value1); + break; + case MAX31790_REG_TACH_TARGET_COUNT_MSB(0): + case MAX31790_REG_TACH_TARGET_COUNT_MSB(1): + case MAX31790_REG_TACH_TARGET_COUNT_MSB(2): + case MAX31790_REG_TACH_TARGET_COUNT_MSB(3): + case MAX31790_REG_TACH_TARGET_COUNT_MSB(4): + case MAX31790_REG_TACH_TARGET_COUNT_MSB(5): + index =3D (s->pointer - MAX31790_REG_TACH_TARGET_COUNT_MSB(0)) / 2; + s->tach_target[index] =3D (value0 << 8) | value1; + break; + default: + qemu_log_mask(LOG_UNIMP, "%s: write to register %d\n", __func__, + s->pointer); + break; + } +} + +static void max31790_write_1_byte(MAX31790State *s) +{ + size_t index =3D 0; + uint16_t pwm =3D 0; + const uint8_t value =3D s->buf[0]; + + switch (s->pointer) { + case MAX31790_REG_FAN_CONFIG(0): + case MAX31790_REG_FAN_CONFIG(1): + case MAX31790_REG_FAN_CONFIG(2): + case MAX31790_REG_FAN_CONFIG(3): + case MAX31790_REG_FAN_CONFIG(4): + case MAX31790_REG_FAN_CONFIG(5): + s->fan_config[s->pointer - MAX31790_REG_FAN_CONFIG(0)] =3D value; + break; + case MAX31790_REG_FAN_DYNAMICS(0): + case MAX31790_REG_FAN_DYNAMICS(1): + case MAX31790_REG_FAN_DYNAMICS(2): + case MAX31790_REG_FAN_DYNAMICS(3): + case MAX31790_REG_FAN_DYNAMICS(4): + case MAX31790_REG_FAN_DYNAMICS(5): + s->fan_dynamics[s->pointer - MAX31790_REG_FAN_DYNAMICS(0)] =3D val= ue; + break; + case MAX31790_REG_PWM_TARGET_DUTY_CYCLE_MSB(0): + case MAX31790_REG_PWM_TARGET_DUTY_CYCLE_MSB(1): + case MAX31790_REG_PWM_TARGET_DUTY_CYCLE_MSB(2): + case MAX31790_REG_PWM_TARGET_DUTY_CYCLE_MSB(3): + case MAX31790_REG_PWM_TARGET_DUTY_CYCLE_MSB(4): + case MAX31790_REG_PWM_TARGET_DUTY_CYCLE_MSB(5): + index =3D (s->pointer - MAX31790_REG_PWM_TARGET_DUTY_CYCLE_MSB(0))= / 2; + pwm =3D (value << 8) | (s->pwm[index] & 0x00ff); + max31790_pwm_write(s, index, pwm); + break; + case MAX31790_REG_PWM_TARGET_DUTY_CYCLE_LSB(0): + case MAX31790_REG_PWM_TARGET_DUTY_CYCLE_LSB(1): + case MAX31790_REG_PWM_TARGET_DUTY_CYCLE_LSB(2): + case MAX31790_REG_PWM_TARGET_DUTY_CYCLE_LSB(3): + case MAX31790_REG_PWM_TARGET_DUTY_CYCLE_LSB(4): + case MAX31790_REG_PWM_TARGET_DUTY_CYCLE_LSB(5): + index =3D (s->pointer - MAX31790_REG_PWM_TARGET_DUTY_CYCLE_LSB(0))= / 2; + pwm =3D (s->pwm[index] & 0xff00) | (value & 0x00ff); + max31790_pwm_write(s, index, pwm); + break; + case MAX31790_REG_TACH_TARGET_COUNT_MSB(0): + case MAX31790_REG_TACH_TARGET_COUNT_MSB(1): + case MAX31790_REG_TACH_TARGET_COUNT_MSB(2): + case MAX31790_REG_TACH_TARGET_COUNT_MSB(3): + case MAX31790_REG_TACH_TARGET_COUNT_MSB(4): + case MAX31790_REG_TACH_TARGET_COUNT_MSB(5): + index =3D (s->pointer - MAX31790_REG_TACH_TARGET_COUNT_MSB(0)) / 2; + s->tach_target[index] =3D (s->tach_target[index] & 0x00ff) | (valu= e << 8); + break; + case MAX31790_REG_TACH_TARGET_COUNT_LSB(0): + case MAX31790_REG_TACH_TARGET_COUNT_LSB(1): + case MAX31790_REG_TACH_TARGET_COUNT_LSB(2): + case MAX31790_REG_TACH_TARGET_COUNT_LSB(3): + case MAX31790_REG_TACH_TARGET_COUNT_LSB(4): + case MAX31790_REG_TACH_TARGET_COUNT_LSB(5): + index =3D (s->pointer - MAX31790_REG_TACH_TARGET_COUNT_LSB(0)) / 2; + s->tach_target[index] =3D (s->tach_target[index] & 0xff00) | value; + break; + default: + qemu_log_mask(LOG_UNIMP, "%s: write to register %d\n", __func__, + s->pointer); + break; + } +} + +static int max31790_send(I2CSlave *i2c, uint8_t data) +{ + MAX31790State *s =3D MAX31790(i2c); + + trace_max31790_send(s->i2c.address, data); + + if (s->len =3D=3D 0) { + /* first byte is the register pointer for a read / write operation= */ + s->pointer =3D data; + s->len++; + return 0; + } + + if (s->len > 2) { + qemu_log_mask(LOG_GUEST_ERROR, "%s: write too many bytes\n", __fun= c__); + return 1; /* NAK */ + } + + /* second / third byte is the data to write */ + s->buf[s->len - 1] =3D data; + s->len++; + + if (s->len =3D=3D 2) { + max31790_write_1_byte(s); + } else if (s->len =3D=3D 3) { + max31790_write_2_byte(s); + } + + return 0; +} + +static uint8_t max31790_recv(I2CSlave *i2c) +{ + MAX31790State *s =3D MAX31790(i2c); + trace_max31790_recv(s->i2c.address, s->pointer); + + max31790_read(s); + s->len =3D 0; + + if (s->outlen >=3D 2) { + /* error */ + qemu_log_mask(LOG_GUEST_ERROR, "%s: guest over read\n", __func__); + s->outlen =3D 0; + } + + const uint8_t data =3D s->outbuf[s->outlen++]; + + trace_max31790_recv_return(s->i2c.address, data); + return data; +} + +static int max31790_event(I2CSlave *i2c, enum i2c_event event) +{ + MAX31790State *s =3D MAX31790(i2c); + + trace_max31790_event(s->i2c.address, event); + + switch (event) { + case I2C_START_RECV: + s->outlen =3D 0; + break; + case I2C_START_SEND: + s->len =3D 0; + break; + default: + break; + } + + return 0; +} + +static const VMStateDescription vmstate_max31790 =3D { + .name =3D TYPE_MAX31790, + .version_id =3D 0, + .minimum_version_id =3D 0, + .fields =3D + (const VMStateField[]){ + VMSTATE_UINT8(len, MAX31790State), + VMSTATE_UINT8_ARRAY(fan_config, MAX31790State, MAX31790_NUM_FA= NS), + VMSTATE_UINT8_ARRAY(fan_dynamics, MAX31790State, MAX31790_NUM_= FANS), + VMSTATE_UINT16_ARRAY(pwm, MAX31790State, MAX31790_NUM_FANS), + VMSTATE_UINT16_ARRAY(tach_target, MAX31790State, MAX31790_NUM_= FANS), + VMSTATE_UINT16_ARRAY(tach_count, MAX31790State, MAX31790_NUM_T= ACHS), + VMSTATE_UINT8_ARRAY(buf, MAX31790State, 2), + VMSTATE_UINT8(outlen, MAX31790State), + VMSTATE_UINT8_ARRAY(outbuf, MAX31790State, 2), + VMSTATE_UINT8(pointer, MAX31790State), + VMSTATE_I2C_SLAVE(i2c, MAX31790State), VMSTATE_END_OF_LIST() } +}; + +static void max31790_reset(DeviceState *dev) +{ + MAX31790State *s =3D MAX31790(dev); + + for (int i =3D 0; i < MAX31790_NUM_FANS; i++) { + /* POR-State 0b 0XX0 0000 */ + s->fan_config[i] =3D 0b00000000; + + /* same as POR-State */ + s->tach_target[i] =3D 0b0011110000000000; + + /* same as POR-State */ + s->fan_dynamics[i] =3D 0b01001100; + } + + /* this will set both pwm and tach count */ + for (int i =3D 0; i < MAX31790_NUM_TACHS; i++) { + max31790_pwm_write(s, i, 0x4444); + } +} + +static void max31790_realize(DeviceState *dev, Error **errp) +{ + MAX31790State *s =3D MAX31790(dev); + + trace_max31790_realize(s->i2c.address); +} + +static void max31790_class_init(ObjectClass *klass, const void *data) +{ + DeviceClass *dc =3D DEVICE_CLASS(klass); + I2CSlaveClass *k =3D I2C_SLAVE_CLASS(klass); + + dc->realize =3D max31790_realize; + dc->desc =3D "Maxim MAX31790 6-Channel Fan Controller"; + dc->vmsd =3D &vmstate_max31790; + dc->legacy_reset =3D max31790_reset; + k->event =3D max31790_event; + k->recv =3D max31790_recv; + k->send =3D max31790_send; +} + +static const TypeInfo max31790_info =3D { + .name =3D TYPE_MAX31790, + .parent =3D TYPE_I2C_SLAVE, + .instance_size =3D sizeof(MAX31790State), + .class_size =3D sizeof(MAX31790Class), + .class_init =3D max31790_class_init, +}; + +static void max31790_register_types(void) +{ + type_register_static(&max31790_info); +} + +type_init(max31790_register_types) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 5b198402d5..99864eb878 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -552,6 +552,7 @@ config ASPEED_SOC select LED select PMBUS select MAX31785 + select MAX31790 select FSI_APB2OPB_ASPEED select AT24C select PCI_EXPRESS diff --git a/hw/sensor/Kconfig b/hw/sensor/Kconfig index bc6331b4ab..767f198e92 100644 --- a/hw/sensor/Kconfig +++ b/hw/sensor/Kconfig @@ -43,3 +43,7 @@ config ISL_PMBUS_VR config MAX31785 bool depends on PMBUS + +config MAX31790 + bool + depends on I2C diff --git a/hw/sensor/meson.build b/hw/sensor/meson.build index 420fdc3359..4987c3b253 100644 --- a/hw/sensor/meson.build +++ b/hw/sensor/meson.build @@ -8,3 +8,4 @@ system_ss.add(when: 'CONFIG_MAX34451', if_true: files('max3= 4451.c')) system_ss.add(when: 'CONFIG_LSM303DLHC_MAG', if_true: files('lsm303dlhc_ma= g.c')) system_ss.add(when: 'CONFIG_ISL_PMBUS_VR', if_true: files('isl_pmbus_vr.c'= )) system_ss.add(when: 'CONFIG_MAX31785', if_true: files('max31785.c')) +system_ss.add(when: 'CONFIG_MAX31790', if_true: files('max31790.c')) diff --git a/hw/sensor/trace-events b/hw/sensor/trace-events index a3fe54fa6d..0bde02e676 100644 --- a/hw/sensor/trace-events +++ b/hw/sensor/trace-events @@ -4,3 +4,14 @@ tmp105_read(uint8_t dev, uint8_t addr) "device: 0x%02x, addr: 0x%02x" tmp105_write(uint8_t dev, uint8_t addr) "device: 0x%02x, addr 0x%02x" tmp105_write_shutdown(uint8_t dev) "device: 0x%02x" + +# max31790.c +max31790_send(uint8_t i2c_addr, uint8_t send) "i2c_addr: 0x%02x, data: 0x%= 02x" +max31790_recv(uint8_t i2c_addr, uint8_t reg_addr) "i2c_addr: 0x%02x, reg_a= ddr: 0x%02x" +max31790_recv_return(uint8_t i2c_addr, uint8_t data) "i2c_addr: 0x%02x, re= turns: 0x%02x" +max31790_event(uint8_t i2c_addr, uint8_t event) "i2c_addr: 0x%02x, event: = 0x%02x" +max31790_realize(uint8_t i2c_addr) "i2c_addr: 0x%02x" +max31790_pwm_write(uint8_t i2c_addr, size_t index, uint16_t value) "i2c_ad= dr: 0x%02x, index: %zu, value: 0x%04x" +max31790_rpm_write(uint8_t i2c_addr, size_t index, uint16_t value) "i2c_ad= dr: 0x%02x, index: %zu, value: 0x%04x" +max31790_tach_count_reg(uint8_t i2c_addr, size_t index, uint16_t value) "i= 2c_addr: 0x%02x, index: %zu, value: 0x%04x" + diff --git a/tests/functional/arm/test_aspeed_fby4.py b/tests/functional/ar= m/test_aspeed_fby4.py index a521834f79..dc2437a533 100755 --- a/tests/functional/arm/test_aspeed_fby4.py +++ b/tests/functional/arm/test_aspeed_fby4.py @@ -8,6 +8,8 @@ from qemu_test import wait_for_console_pattern from aspeed import AspeedTest =20 +from qemu_test import wait_for_console_pattern +from qemu_test import exec_command_and_wait_for_pattern =20 class YosemiteV4Machine(AspeedTest): =20 @@ -34,6 +36,30 @@ def do_test_arm_aspeed_openbmc_no_network(self, machine,= image, uboot, # different from the other machines. self.wait_for_console_pattern('yosemite4 login:') =20 + # perform login + exec_command_and_wait_for_pattern(self, + "root", "Password:"); + + exec_command_and_wait_for_pattern(self, "0penBmc", "#"); + + # MAX31790 test + exec_command_and_wait_for_pattern(self, + "cat /sys/class/hwmon/hwmon2/name", "max31790"); + exec_command_and_wait_for_pattern(self, + "cat /sys/class/hwmon/hwmon2/fan1_input", "7447"); + exec_command_and_wait_for_pattern(self, + "cat /sys/class/hwmon/hwmon2/fan1_enable", "1"); + exec_command_and_wait_for_pattern(self, + "cat /sys/class/hwmon/hwmon2/fan1_fault", "0"); + exec_command_and_wait_for_pattern(self, + "echo 1 > /sys/class/hwmon/hwmon2/pwm1", "root@yosemite4"); + exec_command_and_wait_for_pattern(self, + "cat /sys/class/hwmon/hwmon2/fan1_input", "140"); + exec_command_and_wait_for_pattern(self, + "echo 255 > /sys/class/hwmon/hwmon2/pwm1", "root@yosemite4"); + exec_command_and_wait_for_pattern(self, + "cat /sys/class/hwmon/hwmon2/fan1_input", "10685"); + def test_arm_ast2600_yosemitev4_openbmc(self): image_path =3D self.uncompress(self.ASSET_YOSEMITE_V4_FLASH) =20 --=20 2.54.0 From nobody Sat May 30 17:43:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=9elements.com ARC-Seal: i=1; a=rsa-sha256; t=1780058693; cv=none; d=zohomail.com; s=zohoarc; b=RD3/aI7AahfBlpX55tJMXwILkdoc+61YtGJfDha2+DNFVma1yW3FNnsKtj+mb8/ydEM2oSSMbJ4EHwhuEbvfglC/n5NxZbJdhavIPAxC2SgckLoj9mPMRYgyrEO47njTj9mt4S1fW77gmtp3Xqgg4xYY+woaJHKJAfJqAyJZJgA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780058693; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1PBygEponuULoC+Eq4LpbLAWoLdlDY8mXLzWm6nlfFo=; b=Aj57+9fpqyxLoUYUZ8L83wrd4j6+LHAjxYFM4ZNKyVdGZGrvvCQ259i8BshbyOFPMQh6CP2AUDc6vNSXi+22F944FgpOhDIJOOD2Dzb7hc4RILOUtPNI+O/eHP7rTtPIfiOjEfT2dc4exdAopIMG6H4UOGOT8Pa9OfWqk2FbD80= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780058693454953.4224621854238; Fri, 29 May 2026 05:44:53 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wSwZW-0001Eo-9l; Fri, 29 May 2026 08:44:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wSwZC-00010S-BD for qemu-devel@nongnu.org; Fri, 29 May 2026 08:44:04 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wSwZ5-0004kb-8B for qemu-devel@nongnu.org; Fri, 29 May 2026 08:43:57 -0400 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-441209fb77eso8576297f8f.1 for ; Fri, 29 May 2026 05:43:48 -0700 (PDT) Received: from alexanderarchlinux ([188.111.3.154]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45ef35598e5sm3163354f8f.27.2026.05.29.05.43.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2026 05:43:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; t=1780058627; x=1780663427; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1PBygEponuULoC+Eq4LpbLAWoLdlDY8mXLzWm6nlfFo=; b=WLEq0eYKMlg9QAlGw0HSwyiHGqGwkJFqnms+Wc+uqyXywQn5HD/rY4hbtfk+8Afnm3 bvBOE+t3+h3+jUP71esQFU2d4DjCvg1FhbFitbjaWUfqmybrp1qmBHSHXs/1UU0V5ntw UmbEa33TXgJsxl5gr7DZLaW/tY6ZmNe4s1ESsugrnXBqG3lRlRNmf3Or7rZuJvZvU+w4 ZR3V1TXXXa80qAFCjCOkfkADnc193VvJUyGOXqIJSoIw3810cscjIkzoGsVN5Fr7CrqK 8b9rd2hKw7EzWj6Dqi305XdOwsqNeui85gPvwGaWZ5CZEwY9ZtGXr6Ix21CcXdDOVPS4 BIpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780058627; x=1780663427; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1PBygEponuULoC+Eq4LpbLAWoLdlDY8mXLzWm6nlfFo=; b=QId1EAGy7ayE6FYpuCssntgnFUcHBU/tCCPkdYKH/fD5vIQ6iqAMvagr2WpbW5Qtpy kcCuZTVyDyUH6YFjKzkryGIHqmDpsHOs0x2QBuGwCZHSw6UEFLQ+p/Th4fM2nRkKmrFu /nog7XEHRVqpd30gxnDu8JJcPMD876WYgVsTXjWYsF6KpP+bbW2gG3qydyquCfEdDCIq f/2wrU0bGGFKRxLJ+0b46oXvhHdRNaMghbCQLcjsWSJ5Sn29wXnYJZ4aC2NLCVfIR7CC Oux2lh9ztDt6F0vW4vt1HBfO6ckGUH4bGOLqE02NTxPqwSuY3iyHLDZUzgsgq0B17Zl0 ISDA== X-Gm-Message-State: AOJu0Yxt1VnBel6B9zKEeRn/mqXhfa6q1GIFzTFnQQ4ysc1926V3SYUg choxrCcxF7zzlIAxliw+7QYG35W1dPLPPJXLhlcR0Aa3UUQKyDRF2realsJFsq25VG9z18JwQHq +3o8LD2U= X-Gm-Gg: Acq92OEAEWeH9X5Xhwe7qaF3WYEv3y0mItg3+oyqA9ApEJBe79e558zGKjeZv3R77w1 Mqwq1GGZ8WH1ouslGQ1Gg37afY5IyXPHKXGR/Qi/k6yWg+0NuwBghGVCUqGmt9xQzw/NvTAa6Va 1dMuh0wJA8BjlM5aMH/oP479RXZUbTbMQCmvLdK+gZiqZfw/thWvKjnuhC9I3xuD3wFT13vAynh zp19jYgsTEqPeQyJUjsTrbBiVaE8VUQZP+m1o6YUod3OaMQguQrFalkJcLQN0jUhHnmSiUvrL0+ 4GLYdy9S+pRPFQ7jsxvxV8ERnDTXcGNQqIVBh1oHc0LnOJ2D1nbPb5mh2WNTXt7JGbA+IAqPUYX SH1SyQaZ5oki+HlKVEjsyOwaSQxVvLTt/RyZCPXt5Ac4JfB+B/+ZE9fnMhBnw65bp+aqX+asNiM gjLUB9B2Sz4oMBk3GDb5JxvJCsa6kEZT/evybe/gf0sah7XwzeKsCV7so= X-Received: by 2002:a05:6000:25ee:b0:44f:69f4:39b5 with SMTP id ffacd0b85a97d-45ef139b5camr4114051f8f.29.1780058627205; Fri, 29 May 2026 05:43:47 -0700 (PDT) From: Alexander Hansen To: qemu-devel@nongnu.org Cc: Alexander Hansen , Titus Rwantare , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Jonathan Cameron , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , Peter Maydell , qemu-arm@nongnu.org, Steven Lee , Troy Lee , Jamin Lin , Kane Chen , Andrew Jeffery , Joel Stanley Subject: [PATCH v5 4/5] hw/sensor: support MAX11615 Date: Fri, 29 May 2026 14:37:33 +0200 Message-ID: <20260529124237.94087-5-alexander.hansen@9elements.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260529124237.94087-1-alexander.hansen@9elements.com> References: <20260529124237.94087-1-alexander.hansen@9elements.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=alexander.hansen@9elements.com; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @9elements.com) X-ZM-MESSAGEID: 1780058695802154100 Product: [1] Datasheet: [2] Sensor readings can be provided upon creation of the device. In case no readings are provided the ADC reads a pre-defined arbitrary value. root@yosemite4:~# cat /sys/bus/iio/devices/iio:device2/name max11615 root@yosemite4:~# cat /sys/bus/iio/devices/iio:device2/in_voltage0_raw 1922 root@yosemite4:~# cat /sys/bus/iio/devices/iio:device2/in_voltage_scale 0.500000000 trace: less /tmp/qemu-trace.log | grep -i max116 max11615_realize i2c_addr: 0x33 max11615_realize i2c_addr: 0x33 max11615_event i2c_addr: 0x33, event: 0x01 max11615_write_setup i2c_addr: 0x33, data: 0xd2 max11615_write_config i2c_addr: 0x33, data: 0x0f max11615_event i2c_addr: 0x33, event: 0x03 max11615_event i2c_addr: 0x33, event: 0x01 max11615_write_setup i2c_addr: 0x33, data: 0xd2 max11615_write_config i2c_addr: 0x33, data: 0x0f max11615_event i2c_addr: 0x33, event: 0x03 max11615_event i2c_addr: 0x33, event: 0x01 max11615_write_setup i2c_addr: 0x33, data: 0xd2 max11615_write_config i2c_addr: 0x33, data: 0x61 max11615_event i2c_addr: 0x33, event: 0x03 max11615_event i2c_addr: 0x33, event: 0x00 max11615_recv i2c_addr: 0x33, reg_addr: 0x00 max11615_recv_return i2c_addr: 0x33, returns: 0xfa max11615_recv i2c_addr: 0x33, reg_addr: 0x00 max11615_recv_return i2c_addr: 0x33, returns: 0xd2 max11615_event i2c_addr: 0x33, event: 0x04 max11615_event i2c_addr: 0x33, event: 0x03 References: [1] https://www.analog.com/en/products/MAX11615.html [2] https://www.analog.com/media/en/technical-documentation/data-sheets/MAX= 11612-MAX11617.pdf Cc: Titus Rwantare Cc: "C=C3=A9dric Le Goater" (maintainer:ASPEED BMCs) Cc: Jonathan Cameron Cc: "Philippe Mathieu-Daud=C3=A9" (odd fixer:Overall se= nsors) Cc: Paolo Bonzini (maintainer:Kconfig) Cc: Peter Maydell (supporter:ARM TCG CPUs) Cc: qemu-devel@nongnu.org (open list:All patches CC here) Cc: qemu-arm@nongnu.org (open list:ARM TCG CPUs) Signed-off-by: Alexander Hansen --- MAINTAINERS | 1 + include/hw/sensor/max11615.h | 20 ++ hw/arm/aspeed_ast2600_fby4.c | 8 +- hw/sensor/max11615.c | 312 +++++++++++++++++++++++ hw/arm/Kconfig | 1 + hw/sensor/Kconfig | 4 + hw/sensor/meson.build | 1 + hw/sensor/trace-events | 8 + tests/functional/arm/test_aspeed_fby4.py | 8 + 9 files changed, 362 insertions(+), 1 deletion(-) create mode 100644 include/hw/sensor/max11615.h create mode 100644 hw/sensor/max11615.c diff --git a/MAINTAINERS b/MAINTAINERS index 2a0dbd1cc4..195e3c7927 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3987,6 +3987,7 @@ S: Maintained F: hw/i2c/pmbus_device.c F: hw/sensor/adm1272.c F: hw/sensor/isl_pmbus_vr.c +F: hw/sensor/max11615.c F: hw/sensor/max31790.c F: hw/sensor/max34451.c F: include/hw/i2c/pmbus_device.h diff --git a/include/hw/sensor/max11615.h b/include/hw/sensor/max11615.h new file mode 100644 index 0000000000..0460ee5963 --- /dev/null +++ b/include/hw/sensor/max11615.h @@ -0,0 +1,20 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +#ifndef QEMU_MAX11615_H +#define QEMU_MAX11615_H + +#include "qemu/osdep.h" +#include "hw/i2c/i2c.h" + +#define TYPE_MAX11615 "max11615" + +/* + * Create and realize a MAX11615 ADC with constant caller-supplied readings + * @bus: I2C bus to put it on + * @address: I2C address + * @init_values: array of readings for each ADC channel + * @init_values_size: Size of @init_values, can be less than the number of= channels + */ +I2CSlave *max11615_init_with_values(I2CBus *bus, uint8_t address, + const uint16_t *init_values, uint32_t = init_values_size); + +#endif diff --git a/hw/arm/aspeed_ast2600_fby4.c b/hw/arm/aspeed_ast2600_fby4.c index 1f391022a2..c55f7ca895 100644 --- a/hw/arm/aspeed_ast2600_fby4.c +++ b/hw/arm/aspeed_ast2600_fby4.c @@ -11,6 +11,7 @@ #include "hw/arm/aspeed.h" #include "hw/arm/aspeed_soc.h" #include "hw/nvram/eeprom_at24c.h" +#include "hw/sensor/max11615.h" #include "hw/i2c/i2c_mux_pca954x.h" #include "hw/gpio/pca9552.h" =20 @@ -185,7 +186,12 @@ static void fby4_i2c_init_fanboard(I2CSlave *fan_mux, = size_t eepromSize) i2c_slave_create_simple(bus, "max31790", 0x2f); =20 /* maxim,max11615 @ 0x33 (adc) */ - /* TODO */ + static const uint16_t adc_values[8] =3D { + 1922, 1000, + 1922, 1000, + 1922, 1000, + 1922, 1000}; + max11615_init_with_values(bus, 0x33, adc_values, 8); =20 at24c_eeprom_init_rom( bus, 0x52, eepromSize, diff --git a/hw/sensor/max11615.c b/hw/sensor/max11615.c new file mode 100644 index 0000000000..594bc3d290 --- /dev/null +++ b/hw/sensor/max11615.c @@ -0,0 +1,312 @@ +/* + * Maxim MAX11615 Low-Power 12 bit ADC + * Models MAX11612,MAX11613,MAX11614,MAX11615,MAX11616,MAX11617 + * + * Datasheet: + * https://www.analog.com/media/en/technical-documentation/data-sheets/MAX= 11612-MAX11617.pdf + * + * Copyright 2026 9elements + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include "hw/sensor/max11615.h" +#include "hw/i2c/i2c.h" +#include "migration/vmstate.h" +#include "qapi/error.h" +#include "qapi/visitor.h" +#include "qemu/log.h" +#include "qemu/module.h" +#include "qemu/osdep.h" +#include "trace.h" + +#define MAX11615_NUM_CHANNELS 8 + +struct MAX11615State { + I2CSlave i2c; + + /* true: single-ended mode, false: differential mode */ + bool single_ended; + + /* + * Output data coding for the MAX11612=E2=80=93MAX11617 is + * binary in unipolar mode and two=E2=80=99s complement in bipolar mode + */ + bool bipolar; + + /* The MAX11613/MAX11615/MAX11617 feature a 2.048V internal reference = */ + uint16_t vref; + + uint16_t channels[MAX11615_NUM_CHANNELS]; + + /* output buffer */ + uint8_t outlen; + uint8_t outbuf[2]; + + /* selected channel for read/write operation */ + uint8_t pointer; +}; + +struct MAX11615Class { + I2CSlaveClass parent_class; +}; + +OBJECT_DECLARE_TYPE(MAX11615State, MAX11615Class, MAX11615) + +static void max11615_set_outbuf(MAX11615State *s, uint16_t value) +{ + uint8_t msb =3D value >> 8; + uint8_t lsb =3D value & 0xff; + s->outbuf[0] =3D 0b11110000 | (msb & 0b00001111); + s->outbuf[1] =3D lsb; +} + +static void max11615_read_single_ended(MAX11615State *s) +{ + /* Table 3. Channel Selection in Single-Ended Mode */ + /* read an ADC channel, first 4 bits must be high */ + uint16_t value =3D s->channels[s->pointer]; + /* + * In single-ended mode, the MAX11612=E2=80=93MAX11617 always + * operates in unipolar mode irrespective of BIP/UNI. + */ + if (value > s->vref) { + value =3D 0xfff; + } + max11615_set_outbuf(s, value); +} + +static int16_t max11615_differential_value(MAX11615State *s) +{ + /* Table 4. Channel Selection in Differential Mode */ + size_t i1 =3D s->pointer; + size_t i2 =3D (s->pointer % 2 =3D=3D 0) ? s->pointer + 1 : s->pointer = - 1; + + const int16_t ch1 =3D s->channels[i1]; + const int16_t ch2 =3D s->channels[i2]; + return ch1 - ch2; +} + +static void max11615_read_differential(MAX11615State *s) +{ + const int16_t value =3D max11615_differential_value(s); + uint16_t vu =3D value; + + /* full-scale transition: Figure 12, Figure 13 */ + if (s->bipolar) { + const uint16_t fs =3D s->vref / 2; + if (value < -fs) { + vu =3D 0b100000000000; + } + if (value > fs) { + vu =3D 0b011111111111; + } + } else { + /* + * A negative differential analog input in unipolar mode causes the + * digital output code to be zero + */ + if (value < 0) { + vu =3D 0; + } + } + + max11615_set_outbuf(s, vu); +} + +static void max11615_read(MAX11615State *s) +{ + if (s->single_ended) { + max11615_read_single_ended(s); + } else { + max11615_read_differential(s); + } +} + +static void max11615_write_config_byte(MAX11615State *s, uint8_t data) +{ + trace_max11615_write_config(s->i2c.address, data); + + uint8_t scan_select =3D (data >> 5) & 0b11; + + if (scan_select !=3D 0b11) { + qemu_log_mask(LOG_UNIMP, "%s: unimplemented scan select\n", __func= __); + } + + uint8_t channel_select =3D (data >> 1) & 0b1111; + + /* Table 3. Channel Selection */ + if (channel_select >=3D MAX11615_NUM_CHANNELS) { + qemu_log_mask(LOG_GUEST_ERROR, "%s: invalid channel select", __fun= c__); + channel_select =3D MAX11615_NUM_CHANNELS - 1; + } + s->pointer =3D channel_select; + s->single_ended =3D data & 0x1; +} + +static void max11615_write_setup_byte(MAX11615State *s, uint8_t data) +{ + trace_max11615_write_setup(s->i2c.address, data); + /* we ignore the setup byte, not implemented */ + + /* 1 =3D no action, 0 =3D resets the configuration register to default= */ + const bool rst =3D ((data >> 1) & 0b1) =3D=3D 0b0; + + if (rst) { + s->single_ended =3D true; + s->pointer =3D 0; + } + + s->bipolar =3D ((data >> 2) & 0b1) =3D=3D 0b1; + + /* Table 6. Reference Voltage */ + const uint8_t sel =3D (data >> 4) & 0b111; + + if (sel =3D=3D 0b10 || sel =3D=3D 0b11) { + qemu_log_mask(LOG_UNIMP, "%s: unsupported: external vref\n", __fun= c__); + } +} + +static int max11615_send(I2CSlave *i2c, uint8_t data) +{ + MAX11615State *s =3D MAX11615(i2c); + const uint8_t msb =3D (data >> 7) & 0b1; + + if (msb) { + max11615_write_setup_byte(s, data); + } else { + max11615_write_config_byte(s, data); + } + + s->outlen =3D 0; + return 0; +} + +static uint8_t max11615_recv(I2CSlave *i2c) +{ + MAX11615State *s =3D MAX11615(i2c); + trace_max11615_recv(s->i2c.address, s->pointer); + + if (s->outlen >=3D 2) { + /* MAX11615 supports multichannel scan with wraparound */ + /* see datasheet page 17 */ + + s->outlen =3D 0; + + s->pointer++; + if (s->pointer >=3D MAX11615_NUM_CHANNELS) { + s->pointer =3D 0; + } + } + + max11615_read(s); + + const uint8_t data =3D s->outbuf[s->outlen++]; + + trace_max11615_recv_return(s->i2c.address, data); + return data; +} + +static int max11615_event(I2CSlave *i2c, enum i2c_event event) +{ + MAX11615State *s =3D MAX11615(i2c); + + trace_max11615_event(s->i2c.address, event); + + switch (event) { + case I2C_START_RECV: + s->outlen =3D 0; + break; + default: + break; + } + + return 0; +} + +static const VMStateDescription vmstate_max11615 =3D { + .name =3D TYPE_MAX11615, + .version_id =3D 0, + .minimum_version_id =3D 0, + .fields =3D + (const VMStateField[]){ VMSTATE_BOOL(single_ended, MAX11615State), + VMSTATE_BOOL(bipolar, MAX11615State), + VMSTATE_UINT16(vref, MAX11615State), + VMSTATE_UINT16_ARRAY(channels, MAX11615Sta= te, + MAX11615_NUM_CHANNELS= ), + VMSTATE_UINT8(outlen, MAX11615State), + VMSTATE_UINT8_ARRAY(outbuf, MAX11615State,= 2), + VMSTATE_UINT8(pointer, MAX11615State), + VMSTATE_I2C_SLAVE(i2c, MAX11615State), + VMSTATE_END_OF_LIST() } +}; + +I2CSlave *max11615_init_with_values(I2CBus *bus, uint8_t address, + const uint16_t *init_values, + uint32_t init_values_size) +{ + MAX11615State *s; + + s =3D MAX11615(i2c_slave_new(TYPE_MAX11615, address)); + + for (int i =3D 0; i < MAX11615_NUM_CHANNELS; i++) { + /* arbitrary value if there is no data*/ + s->channels[i] =3D + i < init_values_size ? init_values[i] : 0b0000101011010010; + } + + i2c_slave_realize_and_unref(I2C_SLAVE(s), bus, &error_abort); + + return I2C_SLAVE(s); +} + +static void max11615_reset(DeviceState *dev) +{ + MAX11615State *s =3D MAX11615(dev); + + s->single_ended =3D true; + s->bipolar =3D false; + s->vref =3D 2048; + s->pointer =3D 0; + s->outlen =3D 0; + + for (int i =3D 0; i < MAX11615_NUM_CHANNELS; i++) { + s->channels[i] =3D 0b0000101011010010; + } +} + +static void max11615_realize(DeviceState *dev, Error **errp) +{ + MAX11615State *s =3D MAX11615(dev); + + trace_max11615_realize(s->i2c.address); +} + +static void max11615_class_init(ObjectClass *klass, const void *data) +{ + DeviceClass *dc =3D DEVICE_CLASS(klass); + I2CSlaveClass *k =3D I2C_SLAVE_CLASS(klass); + + dc->realize =3D max11615_realize; + dc->desc =3D "Maxim MAX11615 12-bit ADC"; + dc->vmsd =3D &vmstate_max11615; + dc->legacy_reset =3D max11615_reset; + k->event =3D max11615_event; + k->recv =3D max11615_recv; + k->send =3D max11615_send; +} + +static const TypeInfo max11615_info =3D { + .name =3D TYPE_MAX11615, + .parent =3D TYPE_I2C_SLAVE, + .instance_size =3D sizeof(MAX11615State), + .class_size =3D sizeof(MAX11615Class), + .class_init =3D max11615_class_init, +}; + +static void max11615_register_types(void) +{ + type_register_static(&max11615_info); +} + +type_init(max11615_register_types) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 99864eb878..76a7d327a9 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -553,6 +553,7 @@ config ASPEED_SOC select PMBUS select MAX31785 select MAX31790 + select MAX11615 select FSI_APB2OPB_ASPEED select AT24C select PCI_EXPRESS diff --git a/hw/sensor/Kconfig b/hw/sensor/Kconfig index 767f198e92..441bee7604 100644 --- a/hw/sensor/Kconfig +++ b/hw/sensor/Kconfig @@ -47,3 +47,7 @@ config MAX31785 config MAX31790 bool depends on I2C + +config MAX11615 + bool + depends on I2C diff --git a/hw/sensor/meson.build b/hw/sensor/meson.build index 4987c3b253..a1e26604fa 100644 --- a/hw/sensor/meson.build +++ b/hw/sensor/meson.build @@ -9,3 +9,4 @@ system_ss.add(when: 'CONFIG_LSM303DLHC_MAG', if_true: files= ('lsm303dlhc_mag.c')) system_ss.add(when: 'CONFIG_ISL_PMBUS_VR', if_true: files('isl_pmbus_vr.c'= )) system_ss.add(when: 'CONFIG_MAX31785', if_true: files('max31785.c')) system_ss.add(when: 'CONFIG_MAX31790', if_true: files('max31790.c')) +system_ss.add(when: 'CONFIG_MAX11615', if_true: files('max11615.c')) diff --git a/hw/sensor/trace-events b/hw/sensor/trace-events index 0bde02e676..23e34d8297 100644 --- a/hw/sensor/trace-events +++ b/hw/sensor/trace-events @@ -15,3 +15,11 @@ max31790_pwm_write(uint8_t i2c_addr, size_t index, uint1= 6_t value) "i2c_addr: 0x max31790_rpm_write(uint8_t i2c_addr, size_t index, uint16_t value) "i2c_ad= dr: 0x%02x, index: %zu, value: 0x%04x" max31790_tach_count_reg(uint8_t i2c_addr, size_t index, uint16_t value) "i= 2c_addr: 0x%02x, index: %zu, value: 0x%04x" =20 +# max11615.c +max11615_write_setup(uint8_t i2c_addr, uint8_t send) "i2c_addr: 0x%02x, da= ta: 0x%02x" +max11615_write_config(uint8_t i2c_addr, uint8_t send) "i2c_addr: 0x%02x, d= ata: 0x%02x" +max11615_recv(uint8_t i2c_addr, uint8_t reg_addr) "i2c_addr: 0x%02x, reg_a= ddr: 0x%02x" +max11615_recv_return(uint8_t i2c_addr, uint8_t data) "i2c_addr: 0x%02x, re= turns: 0x%02x" +max11615_event(uint8_t i2c_addr, uint8_t event) "i2c_addr: 0x%02x, event: = 0x%02x" +max11615_realize(uint8_t i2c_addr) "i2c_addr: 0x%02x" + diff --git a/tests/functional/arm/test_aspeed_fby4.py b/tests/functional/ar= m/test_aspeed_fby4.py index dc2437a533..4ace4985d2 100755 --- a/tests/functional/arm/test_aspeed_fby4.py +++ b/tests/functional/arm/test_aspeed_fby4.py @@ -60,6 +60,14 @@ def do_test_arm_aspeed_openbmc_no_network(self, machine,= image, uboot, exec_command_and_wait_for_pattern(self, "cat /sys/class/hwmon/hwmon2/fan1_input", "10685"); =20 + # MAX11615 test + exec_command_and_wait_for_pattern(self, + "cat /sys/bus/i2c/devices/30-0033/iio:device*/name", "max11615= "); + exec_command_and_wait_for_pattern(self, + "cat /sys/bus/i2c/devices/30-0033/iio:device*/in_voltage0_raw"= , "4095"); + exec_command_and_wait_for_pattern(self, + "cat /sys/bus/i2c/devices/30-0033/iio:device*/in_voltage_scale= ", "0.500000000"); + def test_arm_ast2600_yosemitev4_openbmc(self): image_path =3D self.uncompress(self.ASSET_YOSEMITE_V4_FLASH) =20 --=20 2.54.0 From nobody Sat May 30 17:43:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=9elements.com ARC-Seal: i=1; a=rsa-sha256; t=1780058687; cv=none; d=zohomail.com; s=zohoarc; b=Ldp12JN2YXI3Ak5b7aTOwgiXYyjZQyNw5KJvbyRl/HrtY3pvye7lvx7bb0GK5S2BaFe2Lqcmh/4nLgy4qhpluHGN9wsgdgMv36vzOy+DOBtbBdqhR6u3Z1umcnRu63seJ2RyKbnXZ2SzisEx9W3+3kKb69i/pZGsOAHNGBR3uNQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780058687; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=C5YfvPix9JRVMLq5pqy0F5KTeMae+z3jj4lvXkKKiEY=; b=n6p61u68/9dd8EY/OUtuT5y5A+zxpsc8T+30GGYjeikXOytlDJ4kCJQWK+g2G7lH10AqsKHkgEAVcu5uRuqYlNvBDlfZvQa/rfro7czazskSBzwBBMpi9pnKfj2AYHZtq1SON8jObkD5mR8dKrCOHqxdrAqS5Ibr1uRgMch/tVQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780058687258184.97730535913297; Fri, 29 May 2026 05:44:47 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wSwZV-0001CR-Et; Fri, 29 May 2026 08:44:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wSwZF-00010m-Ai for qemu-devel@nongnu.org; Fri, 29 May 2026 08:44:06 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wSwZ9-0004lM-8p for qemu-devel@nongnu.org; Fri, 29 May 2026 08:44:00 -0400 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-45ef56d9b67so195461f8f.2 for ; Fri, 29 May 2026 05:43:53 -0700 (PDT) Received: from alexanderarchlinux ([188.111.3.154]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45ef35598e5sm3163354f8f.27.2026.05.29.05.43.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2026 05:43:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; t=1780058632; x=1780663432; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=C5YfvPix9JRVMLq5pqy0F5KTeMae+z3jj4lvXkKKiEY=; b=YjqsjYwR2XzsfnoRevC4+rf/cNndHk/7f1EruLa8KLtaicG/yhGslA9+/ftrg1oM+D zdE84rXdbDd/e1zLWA3B3RAVO3igVtcQbZjZZ3TgG8MLRi35r3Y2fulmfU6nyWk1TRdK dIQgazleG/2uIrQ8Vwk84eQfQ9w2sFsyCOT+Ut7fkAibJXgqtraHuIi5Io4SkVHH6g42 fd/XbIn0n/c708svYvMlQmgvfkk0tORrA6io/ihFmaa8Z2LEZ1p4zv8BqJDfIBZ37dTI 4H1kNY6/UAvZb4WoGb1xVvpCyKT816n0F+cygxU4jJlhN6h517FEADA1j9wquD6ti1Jz kAdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780058632; x=1780663432; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=C5YfvPix9JRVMLq5pqy0F5KTeMae+z3jj4lvXkKKiEY=; b=CPAmIibkvr8ObEto+j38aPTVWyv5D3eoDKHtKYnqRQVwStfpSru5d0rl5coF7v85RV xH/a0J+uzj23fv9LFMlgQ0j3Ddkz5ZURm/MfcmbEZL2MmwTj64Mb4Kc5UviDNzOsYv5O HyYJgcjB2seTgUKDsReuGpJvsGa0pA9laYYSUFzZFCiaE0CSVpNiuSKqFU1bRrNoW6sv TEXD5z9nUlpLbt8+kUs+9YhCJKJT1lYMlrYealE+vHOU+9ylAMn3zhzjt8BeFfL2bPrR x7Dx2ru0kj5UxEZ8n+6psnRDZXL7P/REwQPLRICqOmCieO1DLvpmvkO9J7e7zrdEGO9w 8FJA== X-Gm-Message-State: AOJu0YxIJ4aXFg2dENC0LvT1PwbKoEIGunk7k5FfodsSAOhLMEoQ83T7 AZnvW5nHpxFCZeNP7UrBHagS5Nj5Bs5EAKY2Hn+VBdXgxE1YwLMHfc87kXc1LE94GjrERLYT72J mDn8DssE= X-Gm-Gg: Acq92OFOwP1QtnxERTA/YoSBEUMKNxazF1+hepBawW+OHf4LrBbwudI0GnJEhYmoxMp ZwJphB3aphR1oQn8WVJFI7K+uXrEKMPGyMm6nhmHxCNZoVjAMZeIruxclRrDzIP3r3t93Ltv3Zi efkUjJey8/VcyhDa5SaoHfOSVKhSwItLxReawzV8+kkYsXTkZn/9WT1r6+63O6eeMDx6mymqv3o pDf3LbsIaqdxkeGhHYxcVojPNRpfcwZ78IYz36xs7UeGQIAEHVsvvIfFb0XxiHr/ZKmQyyMIm/n ZqeeHvMcODcRPvC7xkstrmpOATecwSMegyLL7wBm22fcw2J3IiIAqgcm4fh+OP4Pc0SK2c956I3 UtqeqVVSlbwUKfOD0BGQGgdCwmL8YFRHd8+V+C4bERmqsRyDBqg4uFRuNgf8OfdolFZ+yEFvqGe NJgmEQTmZG4/+iXgqKueUTuf4cVldhbEGKcAE+Yz3anyiWF57+RsItUI9HhJbv94QyUw== X-Received: by 2002:a05:6000:481c:b0:43f:e934:50ac with SMTP id ffacd0b85a97d-45ef13fd680mr4852362f8f.7.1780058632019; Fri, 29 May 2026 05:43:52 -0700 (PDT) From: Alexander Hansen To: qemu-devel@nongnu.org Cc: Alexander Hansen , Titus Rwantare , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Jonathan Cameron , Paolo Bonzini , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, Steven Lee , Troy Lee , Jamin Lin , Kane Chen , Andrew Jeffery , Joel Stanley Subject: [PATCH v5 5/5] hw/sensor: support Texas Instruments ADC128D818 Date: Fri, 29 May 2026 14:37:34 +0200 Message-ID: <20260529124237.94087-6-alexander.hansen@9elements.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260529124237.94087-1-alexander.hansen@9elements.com> References: <20260529124237.94087-1-alexander.hansen@9elements.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=alexander.hansen@9elements.com; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @9elements.com) X-ZM-MESSAGEID: 1780058688944158500 Product: [1] Datasheet: [2] ADC128D818 Support: - channel readings from pre-set values - driver can read and write most configuration registers ADC128D818 currently unsupported: - slave address restriction - startup sequence and realistic busy register emulation - external VREF - conversion rate - interrupts - deep shutdown mode - individual channel shutdown - selection between Mode 0,1,2,3 - pseudo-differential input Anyone could expand it in the future for more accurate emulation. The reason for adding this device is to support Yosemite V4 emulation. Tested: on yosemite v4 qemu initialize the device: // ti,adc128d818 @ 0x1f (adc) // the driver will throw away the last 4 bits, set them 0 uint16_t adc_values1[8] =3D { 0b011110000000, 0b010100010000, 0b001000110000, 0b100000100000, 0b011110000000, 0b010100010000, 0b001000110000, 0b100000100000}; adc128d818_init_with_values(bus, 0x1f, adc_values1, 8); Trace outputs directly after initialization: adc128d818_realize i2c_addr: 0x1f adc128d818_realize i2c_addr: 0x1f adc128d818_event i2c_addr: 0x1f, event: 0x01 adc128d818_send i2c_addr: 0x1f, data: 0x00 adc128d818_send i2c_addr: 0x1f, data: 0x80 adc128d818_write i2c_addr: 0x1f, reg: 0x00 data: 0x80 adc128d818_event i2c_addr: 0x1f, event: 0x03 adc128d818_event i2c_addr: 0x1f, event: 0x01 ... read the values root@yosemite4:/sys/bus/i2c/devices/30-001f# cat hwmon/hwmon0/in0_min 0 root@yosemite4:/sys/bus/i2c/devices/30-001f# cat hwmon/hwmon0/in0_max 0 root@yosemite4:/sys/bus/i2c/devices/30-001f# cat hwmon/hwmon0/in0_input 75 root@yosemite4:/sys/bus/i2c/devices/30-001f# cat hwmon/hwmon0/name adc128d818 We initially configured 0b011110000000 for the first channel. The driver throws away the last 4 bits and does calculation similar to below: val =3D DIV_ROUND_CLOSEST(data->in[index][nr] * data->vref, 4095); We can check that the calculation is as expected given our configured value. ((0b011110000000 >> 4) * 2560) / 4095 75.01831501831502 References: [1] https://www.ti.com/product/ADC128D818 [2] https://www.ti.com/lit/gpn/adc128d818 Cc: Titus Rwantare Cc: "C=C3=A9dric Le Goater" (maintainer:ASPEED BMCs) Cc: Jonathan Cameron Cc: Paolo Bonzini (maintainer:Kconfig) Cc: Peter Maydell (supporter:ARM TCG CPUs) Cc: "Philippe Mathieu-Daud=C3=A9" (odd fixer:Overall se= nsors) Cc: qemu-arm@nongnu.org (open list:ARM TCG CPUs) Cc: qemu-devel@nongnu.org (open list:All patches CC here) Signed-off-by: Alexander Hansen --- MAINTAINERS | 1 + include/hw/sensor/adc128d818.h | 23 ++ hw/arm/aspeed_ast2600_fby4.c | 9 +- hw/sensor/adc128d818.c | 433 +++++++++++++++++++++++ hw/arm/Kconfig | 1 + hw/sensor/Kconfig | 4 + hw/sensor/meson.build | 1 + hw/sensor/trace-events | 7 + tests/functional/arm/test_aspeed_fby4.py | 10 + 9 files changed, 488 insertions(+), 1 deletion(-) create mode 100644 include/hw/sensor/adc128d818.h create mode 100644 hw/sensor/adc128d818.c diff --git a/MAINTAINERS b/MAINTAINERS index 195e3c7927..470e118f3c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3985,6 +3985,7 @@ PMBus M: Titus Rwantare S: Maintained F: hw/i2c/pmbus_device.c +F: hw/sensor/adc128d818.c F: hw/sensor/adm1272.c F: hw/sensor/isl_pmbus_vr.c F: hw/sensor/max11615.c diff --git a/include/hw/sensor/adc128d818.h b/include/hw/sensor/adc128d818.h new file mode 100644 index 0000000000..02d75ca3e1 --- /dev/null +++ b/include/hw/sensor/adc128d818.h @@ -0,0 +1,23 @@ +/* Copyright 2026 9elements */ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +#ifndef QEMU_ADC128D818_H +#define QEMU_ADC128D818_H + +#include "qemu/osdep.h" +#include "hw/i2c/i2c.h" + +#define TYPE_ADC128D818 "adc128d818" + +/* + * Create and realize a adc128d818 ADC with constant caller-supplied readi= ngs + * @bus: I2C bus to put it on + * @address: I2C address + * @init_values: array of readings for each ADC channel + * @init_values_size: Size of @init_values, can be less than the number of + * channels + */ +I2CSlave *adc128d818_init_with_values(I2CBus *bus, uint8_t address, + const uint16_t *init_values, + uint32_t init_values_size); + +#endif diff --git a/hw/arm/aspeed_ast2600_fby4.c b/hw/arm/aspeed_ast2600_fby4.c index c55f7ca895..cfcf689723 100644 --- a/hw/arm/aspeed_ast2600_fby4.c +++ b/hw/arm/aspeed_ast2600_fby4.c @@ -12,6 +12,7 @@ #include "hw/arm/aspeed_soc.h" #include "hw/nvram/eeprom_at24c.h" #include "hw/sensor/max11615.h" +#include "hw/sensor/adc128d818.h" #include "hw/i2c/i2c_mux_pca954x.h" #include "hw/gpio/pca9552.h" =20 @@ -162,7 +163,13 @@ static void fby4_i2c_init_fanboard(I2CSlave *fan_mux, = size_t eepromSize) I2CBus *bus =3D pca954x_i2c_get_bus(fan_mux, i); =20 /* ti,adc128d818 @ 0x1f (adc) */ - /* TODO */ + /* the driver will throw away the last 4 bits, set them 0 */ + static const uint16_t adc_values1[8] =3D { + 0b011110000000, 0b010100010000, + 0b001000110000, 0b100000100000, + 0b011110000000, 0b010100010000, + 0b001000110000, 0b100000100000}; + adc128d818_init_with_values(bus, 0x1f, adc_values1, 8); =20 /* maxim,max31790 @ 0x20 (pwm) */ i2c_slave_create_simple(bus, "max31790", 0x20); diff --git a/hw/sensor/adc128d818.c b/hw/sensor/adc128d818.c new file mode 100644 index 0000000000..7ad7c935fc --- /dev/null +++ b/hw/sensor/adc128d818.c @@ -0,0 +1,433 @@ +/* + * Texas Instruments ADC128D818 12 bit ADC with temperature sensor + * Models ADC128D818 + * + * Product: https://www.ti.com/product/ADC128D818 + * Datasheet: https://www.ti.com/lit/gpn/adc128d818 + * + * Copyright 2026 9elements + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include "hw/sensor/adc128d818.h" +#include "hw/i2c/i2c.h" +#include "migration/vmstate.h" +#include "qapi/error.h" +#include "qapi/visitor.h" +#include "qemu/log.h" +#include "qemu/module.h" +#include "qemu/osdep.h" +#include "trace.h" + +/* 8 bit, r/w */ +#define REG_CONFIG 0x00 + +/* 8 bit, readonly */ +#define REG_INTERRUPT_STATUS 0x01 + +/* 8 bit, r/w */ +#define REG_INTERRUPT_MASK 0x03 + +/* 8 bit, r/w */ +#define REG_CONVERSION_RATE 0x07 + +/* 8 bit, r/w */ +#define REG_CHANNEL_DISABLE 0x08 + +/* 8 bit, write-only */ +#define REG_ONE_SHOT 0x09 + +/* 8 bit, r/w */ +#define REG_DEEP_SHUTDOWN 0x0a + +/* 8 bit, r/w */ +#define REG_ADVANCED_CONFIG 0x0b + +/* 8 bit, readonly */ +#define REG_BUSY_STATUS 0x0c + +/* 16 bit registers, N =3D 0..7, readonly */ +#define REG_CHANNEL_READING(N) (0x20 + N) + +/* 8 bit registers N =3D 0..15, r/w */ +#define REG_LIMIT(N) (0x2a + N) + +/* 8 bit register, readonly */ +#define REG_MANUFACTURER_ID 0x3e + +/* 8 bit register, readonly */ +#define REG_REVISION_ID 0x3f + +#define ADC128D818_NUM_CHANNELS 8 + +struct ADC128D818State { + I2CSlave i2c; + + uint8_t config; + uint8_t interrupt_status; + uint8_t interrupt_mask; + uint8_t conversion_rate; + uint8_t channel_disable; + bool deep_shutdown; + uint8_t advanced_config; + + /* channel reading registers, 2 bytes each */ + uint16_t channels[ADC128D818_NUM_CHANNELS]; + + /* high and low limit registers 0x2a - 0x39, one byte each */ + uint8_t limit[ADC128D818_NUM_CHANNELS * 2]; + + /* input buffer */ + uint8_t len; + uint8_t buf[2]; + + /* output buffer */ + uint8_t outlen; + uint8_t outbuf[2]; + + /* selected channel for read/write operation */ + uint8_t pointer; +}; + +struct ADC128D818Class { + I2CSlaveClass parent_class; +}; + +OBJECT_DECLARE_TYPE(ADC128D818State, ADC128D818Class, ADC128D818) + +static void adc128d818_read(ADC128D818State *s) +{ + uint8_t ch_num =3D 0; + switch (s->pointer) { + case REG_CONFIG: + s->outbuf[0] =3D s->config; + break; + case REG_INTERRUPT_STATUS: + s->outbuf[0] =3D s->interrupt_status; + break; + case REG_INTERRUPT_MASK: + s->outbuf[0] =3D s->interrupt_mask; + break; + case REG_CONVERSION_RATE: + s->outbuf[0] =3D s->conversion_rate; + break; + case REG_CHANNEL_DISABLE: + s->outbuf[0] =3D s->channel_disable; + break; + case REG_ONE_SHOT: + /* not marked as readable */ + qemu_log_mask(LOG_GUEST_ERROR, "%s: read of register 0x%02x\n", + __func__, s->pointer); + s->outbuf[0] =3D 0x0; + break; + case REG_DEEP_SHUTDOWN: + s->outbuf[0] =3D s->deep_shutdown ? 0x1 : 0x0; + break; + case REG_ADVANCED_CONFIG: + s->outbuf[0] =3D s->advanced_config & 0b111; + break; + case REG_BUSY_STATUS: + /* not implemented */ + s->outbuf[0] =3D 0b00000010; /* POR State */ + break; + case REG_CHANNEL_READING(0): + case REG_CHANNEL_READING(1): + case REG_CHANNEL_READING(2): + case REG_CHANNEL_READING(3): + case REG_CHANNEL_READING(4): + case REG_CHANNEL_READING(5): + case REG_CHANNEL_READING(6): + case REG_CHANNEL_READING(7): + ch_num =3D s->pointer - REG_CHANNEL_READING(0); + /* high byte comes first, driver reads swapped */ + s->outbuf[0] =3D (s->channels[ch_num] >> 8) & 0xff; + s->outbuf[1] =3D s->channels[ch_num] & 0xff; + break; + case REG_LIMIT(0): + case REG_LIMIT(1): + case REG_LIMIT(2): + case REG_LIMIT(3): + case REG_LIMIT(4): + case REG_LIMIT(5): + case REG_LIMIT(6): + case REG_LIMIT(7): + case REG_LIMIT(8): + case REG_LIMIT(9): + case REG_LIMIT(10): + case REG_LIMIT(11): + case REG_LIMIT(12): + case REG_LIMIT(13): + case REG_LIMIT(14): + case REG_LIMIT(15): + s->outbuf[0] =3D s->limit[s->pointer - REG_LIMIT(0)]; + break; + case REG_MANUFACTURER_ID: + s->outbuf[0] =3D 0x1; /* readonly */ + break; + case REG_REVISION_ID: + s->outbuf[0] =3D 0b00001001; /* readonly */ + break; + default: + qemu_log_mask(LOG_GUEST_ERROR, "%s: read of register 0x%02x\n", + __func__, s->pointer); + break; + } +} + +static void adc128d818_write_advanced_config(ADC128D818State *s, uint8_t d= ata) +{ + /* + * Note: Whenever the Advanced Configuration Register is programmed, + * all of the values in the Channel Reading Registers and + * Interrupt Status Registers will return to their default values. + */ + + s->advanced_config =3D (data & 0b111); + + s->interrupt_status =3D 0x0; + + /* + * The channel reading registers do not have a default value. + * See 8.6.1 ADC128D818 Internal Registers + * To do something sane, just reset the channels to an arbitrary value + */ + + /* reset channels to a defined state */ + for (int i =3D 0; i < ADC128D818_NUM_CHANNELS; i++) { + + /* arbitrary value */ + s->channels[i] =3D 0b0000101011010010; + } +} + +static void adc128d818_write(ADC128D818State *s, uint8_t data) +{ + trace_adc128d818_write(s->i2c.address, s->pointer, data); + + /* which bits in config register are writable */ + const uint8_t config_w_mask =3D 0b10001011; + const uint8_t config_ro_mask =3D (uint8_t)~config_w_mask; + + switch (s->pointer) { + case REG_CONFIG: + s->config =3D (s->config & config_ro_mask) | (data & config_w_mask= ); + break; + case REG_INTERRUPT_MASK: + s->interrupt_mask =3D data; + break; + case REG_CONVERSION_RATE: + s->conversion_rate =3D data; + break; + case REG_CHANNEL_DISABLE: + s->channel_disable =3D data; + break; + case REG_ONE_SHOT: + /* + * Initiate a single conversion and comparison cycle when + * the device is in shutdown mode or deep shutdown mode, after + * which the device returns to the respective mode that it was in + * + */ + break; + case REG_DEEP_SHUTDOWN: + s->deep_shutdown =3D (data & 0x1) !=3D 0; + break; + case REG_ADVANCED_CONFIG: + adc128d818_write_advanced_config(s, data); + break; + case REG_LIMIT(0): + case REG_LIMIT(1): + case REG_LIMIT(2): + case REG_LIMIT(3): + case REG_LIMIT(4): + case REG_LIMIT(5): + case REG_LIMIT(6): + case REG_LIMIT(7): + case REG_LIMIT(8): + case REG_LIMIT(9): + case REG_LIMIT(10): + case REG_LIMIT(11): + case REG_LIMIT(12): + case REG_LIMIT(13): + case REG_LIMIT(14): + case REG_LIMIT(15): + s->limit[s->pointer - REG_LIMIT(0)] =3D data; + break; + default: + qemu_log_mask(LOG_GUEST_ERROR, "%s: write of register 0x%02x\n", + __func__, s->pointer); + break; + } +} + +static int adc128d818_send(I2CSlave *i2c, uint8_t data) +{ + ADC128D818State *s =3D ADC128D818(i2c); + trace_adc128d818_send(s->i2c.address, data); + + s->outlen =3D 0; + + if (s->len >=3D 2) { + qemu_log_mask(LOG_GUEST_ERROR, "%s: wrote too many bytes\n", __fun= c__); + return 1; + } + + s->buf[s->len] =3D data; + + if (s->len =3D=3D 0) { + s->pointer =3D data; + } else if (s->len =3D=3D 1) { + adc128d818_write(s, data); + } + + s->len++; + return 0; +} + +static uint8_t adc128d818_recv(I2CSlave *i2c) +{ + ADC128D818State *s =3D ADC128D818(i2c); + trace_adc128d818_recv(s->i2c.address, s->pointer); + + adc128d818_read(s); + + if (s->outlen >=3D 2) { + qemu_log_mask(LOG_GUEST_ERROR, "%s: too many bytes read\n", __func= __); + s->outlen =3D 0; + } + + const uint8_t data =3D s->outbuf[s->outlen++]; + + trace_adc128d818_recv_return(s->i2c.address, data); + return data; +} + +static int adc128d818_event(I2CSlave *i2c, enum i2c_event event) +{ + ADC128D818State *s =3D ADC128D818(i2c); + + trace_adc128d818_event(s->i2c.address, event); + + switch (event) { + case I2C_START_RECV: + s->outlen =3D 0; + break; + case I2C_START_SEND: + s->len =3D 0; + break; + default: + break; + } + + return 0; +} + +static const VMStateDescription vmstate_adc128d818 =3D { + .name =3D TYPE_ADC128D818, + .version_id =3D 0, + .minimum_version_id =3D 0, + .fields =3D + (const VMStateField[]){ + VMSTATE_UINT8(config, ADC128D818State), + VMSTATE_UINT8(interrupt_mask, ADC128D818State), + VMSTATE_UINT8(conversion_rate, ADC128D818State), + VMSTATE_UINT8(channel_disable, ADC128D818State), + VMSTATE_BOOL(deep_shutdown, ADC128D818State), + VMSTATE_UINT8(advanced_config, ADC128D818State), + VMSTATE_UINT16_ARRAY(channels, ADC128D818State, + ADC128D818_NUM_CHANNELS), + VMSTATE_UINT8_ARRAY(limit, ADC128D818State, + ADC128D818_NUM_CHANNELS * 2), + VMSTATE_UINT8(len, ADC128D818State), + VMSTATE_UINT8_ARRAY(buf, ADC128D818State, 2), + VMSTATE_UINT8(outlen, ADC128D818State), + VMSTATE_UINT8_ARRAY(outbuf, ADC128D818State, 2), + VMSTATE_UINT8(pointer, ADC128D818State), + VMSTATE_I2C_SLAVE(i2c, ADC128D818State), VMSTATE_END_OF_LIST()= } +}; + +I2CSlave *adc128d818_init_with_values(I2CBus *bus, uint8_t address, + const uint16_t *init_values, + uint32_t init_values_size) +{ + ADC128D818State *s; + + s =3D ADC128D818(i2c_slave_new(TYPE_ADC128D818, address)); + + for (int i =3D 0; i < ADC128D818_NUM_CHANNELS; i++) { + + /* arbitrary value */ + s->channels[i] =3D + i < init_values_size ? init_values[i] : 0b0000101011010010; + } + + i2c_slave_realize_and_unref(I2C_SLAVE(s), bus, &error_abort); + + return I2C_SLAVE(s); +} + +static void adc128d818_reset(DeviceState *dev) +{ + ADC128D818State *s =3D ADC128D818(dev); + + s->pointer =3D 0; + s->outlen =3D 0; + + /* POR-State */ + s->config =3D 0b00001000; + s->interrupt_status =3D 0x0; + s->interrupt_mask =3D 0; + s->conversion_rate =3D 0; + s->channel_disable =3D 0; + s->deep_shutdown =3D 0; + s->advanced_config =3D 0; + + /* No POR-State defined in datasheet */ + for (int i =3D 0; i < ADC128D818_NUM_CHANNELS * 2; i++) { + s->limit[i] =3D 0; + } + + /* reset channels to a defined state */ + for (int i =3D 0; i < ADC128D818_NUM_CHANNELS; i++) { + + /* arbitrary value */ + s->channels[i] =3D 0b0000101011010010; + } +} + +static void adc128d818_realize(DeviceState *dev, Error **errp) +{ + ADC128D818State *s =3D ADC128D818(dev); + + trace_adc128d818_realize(s->i2c.address); +} + +static void adc128d818_class_init(ObjectClass *klass, const void *data) +{ + DeviceClass *dc =3D DEVICE_CLASS(klass); + I2CSlaveClass *k =3D I2C_SLAVE_CLASS(klass); + + dc->realize =3D adc128d818_realize; + dc->desc =3D "Texas Instruments ADC128D818 12-bit ADC with temp sensor= "; + dc->vmsd =3D &vmstate_adc128d818; + dc->legacy_reset =3D adc128d818_reset; + k->event =3D adc128d818_event; + k->recv =3D adc128d818_recv; + k->send =3D adc128d818_send; +} + +static const TypeInfo adc128d818_info =3D { + .name =3D TYPE_ADC128D818, + .parent =3D TYPE_I2C_SLAVE, + .instance_size =3D sizeof(ADC128D818State), + .class_size =3D sizeof(ADC128D818Class), + .class_init =3D adc128d818_class_init, +}; + +static void adc128d818_register_types(void) +{ + type_register_static(&adc128d818_info); +} + +type_init(adc128d818_register_types) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 76a7d327a9..cc89c65e3f 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -554,6 +554,7 @@ config ASPEED_SOC select MAX31785 select MAX31790 select MAX11615 + select ADC128D818 select FSI_APB2OPB_ASPEED select AT24C select PCI_EXPRESS diff --git a/hw/sensor/Kconfig b/hw/sensor/Kconfig index 441bee7604..a640958257 100644 --- a/hw/sensor/Kconfig +++ b/hw/sensor/Kconfig @@ -51,3 +51,7 @@ config MAX31790 config MAX11615 bool depends on I2C + +config ADC128D818 + bool + depends on I2C diff --git a/hw/sensor/meson.build b/hw/sensor/meson.build index a1e26604fa..defd7647e7 100644 --- a/hw/sensor/meson.build +++ b/hw/sensor/meson.build @@ -10,3 +10,4 @@ system_ss.add(when: 'CONFIG_ISL_PMBUS_VR', if_true: files= ('isl_pmbus_vr.c')) system_ss.add(when: 'CONFIG_MAX31785', if_true: files('max31785.c')) system_ss.add(when: 'CONFIG_MAX31790', if_true: files('max31790.c')) system_ss.add(when: 'CONFIG_MAX11615', if_true: files('max11615.c')) +system_ss.add(when: 'CONFIG_ADC128D818', if_true: files('adc128d818.c')) diff --git a/hw/sensor/trace-events b/hw/sensor/trace-events index 23e34d8297..dc6cf26a0b 100644 --- a/hw/sensor/trace-events +++ b/hw/sensor/trace-events @@ -23,3 +23,10 @@ max11615_recv_return(uint8_t i2c_addr, uint8_t data) "i2= c_addr: 0x%02x, returns: max11615_event(uint8_t i2c_addr, uint8_t event) "i2c_addr: 0x%02x, event: = 0x%02x" max11615_realize(uint8_t i2c_addr) "i2c_addr: 0x%02x" =20 +# adc128d818.c +adc128d818_send(uint8_t i2c_addr, uint8_t data) "i2c_addr: 0x%02x, data: 0= x%02x" +adc128d818_write(uint8_t i2c_addr, uint8_t reg, uint8_t data) "i2c_addr: 0= x%02x, reg: 0x%02x data: 0x%02x" +adc128d818_recv(uint8_t i2c_addr, uint8_t reg) "i2c_addr: 0x%02x, reg: 0x%= 02x" +adc128d818_recv_return(uint8_t i2c_addr, uint8_t data) "i2c_addr: 0x%02x, = returns: 0x%02x" +adc128d818_event(uint8_t i2c_addr, uint8_t event) "i2c_addr: 0x%02x, event= : 0x%02x" +adc128d818_realize(uint8_t i2c_addr) "i2c_addr: 0x%02x" diff --git a/tests/functional/arm/test_aspeed_fby4.py b/tests/functional/ar= m/test_aspeed_fby4.py index 4ace4985d2..4957d3d89f 100755 --- a/tests/functional/arm/test_aspeed_fby4.py +++ b/tests/functional/arm/test_aspeed_fby4.py @@ -68,6 +68,16 @@ def do_test_arm_aspeed_openbmc_no_network(self, machine,= image, uboot, exec_command_and_wait_for_pattern(self, "cat /sys/bus/i2c/devices/30-0033/iio:device*/in_voltage_scale= ", "0.500000000"); =20 + # ADC128D818 test + exec_command_and_wait_for_pattern(self, + "cat /sys/bus/i2c/devices/30-001f/hwmon/hwmon0/name", "adc128d= 818"); + exec_command_and_wait_for_pattern(self, + "cat /sys/bus/i2c/devices/30-001f/hwmon/hwmon0/in0_input", "10= 8"); + exec_command_and_wait_for_pattern(self, + "cat /sys/bus/i2c/devices/30-001f/hwmon/hwmon0/in0_min", "0"); + exec_command_and_wait_for_pattern(self, + "cat /sys/bus/i2c/devices/30-001f/hwmon/hwmon0/in0_max", "0"); + def test_arm_ast2600_yosemitev4_openbmc(self): image_path =3D self.uncompress(self.ASSET_YOSEMITE_V4_FLASH) =20 --=20 2.54.0