From nobody Sat May 30 17:31:32 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1779980587; cv=none; d=zohomail.com; s=zohoarc; b=LW3SfBlgOhikMXr2GkUU34d00UdW/XC4Q5RrruGjKTdtLHZ4RSxaGa10iO/g7oaoAIkqQUWogSWAP2QsxejTdQIXnFWLU1xwjXqK1wamyqyW7EvqoV0VNXdIvg20BHAftoBdeJM/VfWyPKADayfsfTm+fdm1OaoG1w6C/lXGxwI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779980587; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=GRFZxMW1/uepakyjETGNiaM+FXY8gaKdWbloOt0XkX8=; b=d+uHZMN8cAhhOgwaxL0agMyc4/0LHaHBh86aDhN0TgDNjEEzCOk2tz+sKelp3zkn4oHpPVz99KKhJNrOa6FgwPKjY7J/vcNSvOnI/ixlG3+c4HGXc9i/EPOnLDR2qvvh8KG0hfVDvgc9dVwpBaaUbQi2cnetK5DOtNNwoZvQ1g8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from=<314abh@gmail.com> (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1779980587010901.4901909717015; Thu, 28 May 2026 08:03:07 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wScFy-0005NG-Ii; Thu, 28 May 2026 11:02:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <314abh@gmail.com>) id 1wSbyz-0001LO-MR for qemu-devel@nongnu.org; Thu, 28 May 2026 10:45:13 -0400 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <314abh@gmail.com>) id 1wSbyt-0007kc-Ig for qemu-devel@nongnu.org; Thu, 28 May 2026 10:45:09 -0400 Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-837b39eb078so8959684b3a.2 for ; Thu, 28 May 2026 07:45:06 -0700 (PDT) Received: from arch ([112.133.246.27]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-841e403bb3csm4024715b3a.32.2026.05.28.07.45.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2026 07:45:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779979506; x=1780584306; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=GRFZxMW1/uepakyjETGNiaM+FXY8gaKdWbloOt0XkX8=; b=cSpOAdt+gYuY3SuN3BP2wK/k91EjyrMsozFbnUfI6CbjwlCaecd20XWJa2+lEO+6Yi bYDyGvkSHuFSwLLPK4pQxblauHpMyjfUH9uaoNkffbUHYduj/ApIRBmFJsnPFeKk6KsF YZXxfmUGT92A0WxFXGJQSNOmmp5TcgskJwoRnSh3P8Blf5SoksSeui5UgG3Lpeevm7fF lMx5/Qve+nhJC9W1zkgS4eXa3QjXkyAiO9/VwW+YXYUeP81oat/QzGAOa/fNIT3Ldnck CMBdBxytSSk81vuS2foV4hph2Pj6Gw2ErmyNdUBXBjbV6KbL0UaHeOCcP9SvX54hY4ms dKZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779979506; x=1780584306; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GRFZxMW1/uepakyjETGNiaM+FXY8gaKdWbloOt0XkX8=; b=Ki09keaFBGmGS2BU/PNJzzM1XkkE+61AXYQ22ljwS8u2vZC1byH0NhzkUYoi/0EdNz znS9fpiS1+uxbysxQPpOReIOcvjNQeJq/4ydKK7vdJ8UJaFTPuHrpZG4G2rXExEOGS4J JlndXJZt9/2Ac+3x9Hff875YFLb1htGhLFg8bGn0J887XycluWEhiV/csmkp14RymK4I pI+aaug6kcCObzBvIE5S14SyRXAo5/42llUUw2+TIFIAVQltCuaaUe6aSoHZ2adIlg0T 9/NJlXFc65ogUGsEXbrDdT4KgsSAVvmQPK7rlmF0H+vI+ZVY652fugE6wr+5UczFIaNg R4DA== X-Gm-Message-State: AOJu0YwfukA5TSevljp8TymdNgifO4fzrGBYjMvFcXM3F4Zpxc5cCEB/ 0e3zqO+N+IDvvtLAOvmEsWH1stZC7zleYJ1Du1OxkInAJNQKUKmXspCshtSlww== X-Gm-Gg: Acq92OGWV7HnFxa2cOQevBWPwshnBLwVeQAgZkTtjD9qpzzsMMpLADqZtNrjo5TIatJ l655hvx1w6J/mlHJ6qd2DW0lvGCRPtg2OjHnfkOrnPotl3ir2MK1Wi1CDHf6DNJ4U49yyZpei0U Rq/IjhDYj4K9h8O1SYTEpwgk2uUg2O/NXNMunE+lCl0Fymnr7S1ZYkxOHTrdL05iZViREYuFQLt 06gMPV8bI4GspyJO4yJQvjWyGKkyxusnbuLbEP6LQ6wUiq31l52gC0qzyWEpntlIbvKR2lnVY/3 KeNR8o5B/wVf5xRhWVQV4H9pWQuk1/iu9d9aphgRh1KBfPnIJ/14j/+1oQL1+yk3mO4GNUpdIP5 JHGTLIoGRrcMmsnssWbz/kORsxxuJVBpXbcxrfzSkUKYZW4VVBcDlhenXRIiRP4Vu/x21AX+B5h Och8EJAlrL0ZCPj6wRz/Lh X-Received: by 2002:a05:6a00:1ac8:b0:82a:65fa:cecf with SMTP id d2e1a72fcca58-8415f3b0abfmr25911526b3a.4.1779979505838; Thu, 28 May 2026 07:45:05 -0700 (PDT) From: Abhigyan Kumar <314abh@gmail.com> To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Richard Henderson , Abhigyan Kumar <314abh@gmail.com> Subject: [PATCH] target/i386: Fix incorrect tcg generation for RCR & RCL instructions Date: Thu, 28 May 2026 20:14:57 +0530 Message-ID: <20260528144457.682901-1-314abh@gmail.com> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::431; envelope-from=314abh@gmail.com; helo=mail-pf1-x431.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FROM_STARTS_WITH_NUMS=0.738, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 28 May 2026 11:02:45 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1779980588972158500 Content-Type: text/plain; charset="utf-8" RCR and RCL instructions of a count of 9 is meaningless for 8-bit operands. In gen_RCR and gen_RCL functions, gen_rotc_mod converts a rotation of 9 to 0. But, the can_be_zero flag wasn't updated and hence we skip the immediate if branch. This causes 0 to underflow into -1 at tcg_gen_subi_tl(count, count, 1); Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3452 Signed-off-by: Abhigyan Kumar <314abh@gmail.com> --- target/i386/tcg/emit.c.inc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/i386/tcg/emit.c.inc b/target/i386/tcg/emit.c.inc index ce636b6c5..a71af846d 100644 --- a/target/i386/tcg/emit.c.inc +++ b/target/i386/tcg/emit.c.inc @@ -3452,6 +3452,7 @@ static void gen_RCL(DisasContext *s, X86DecodedInsn *= decode) low_count =3D tcg_temp_new(); =20 gen_rotc_mod(ot, count); + can_be_zero =3D (ot =3D=3D MO_8 || ot =3D=3D MO_16); have_1bit_cin =3D gen_eflags_adcox(s, decode, true, can_be_zero); if (can_be_zero) { zero_label =3D gen_new_label(); @@ -3504,6 +3505,7 @@ static void gen_RCR(DisasContext *s, X86DecodedInsn *= decode) high_count =3D tcg_temp_new(); =20 gen_rotc_mod(ot, count); + can_be_zero =3D (ot =3D=3D MO_8 || ot =3D=3D MO_16); have_1bit_cin =3D gen_eflags_adcox(s, decode, true, can_be_zero); if (can_be_zero) { zero_label =3D gen_new_label(); --=20 2.54.0