From nobody Sat May 30 17:31:32 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1779973826; cv=none; d=zohomail.com; s=zohoarc; b=cimz1T6w7Enq4XOAIBRl+DitqTLXnY/hhQX6pH2MWuP6o0+Mb//cSOvMogJs3tekx4eghOJDNSrCt221As2sRKr8lkCgTPBYFLDT6DDBUjjr2qPHoTSb+BNVj9SNhzmrfKJHdQON8hnZHFsgwHTCrhWC3fi57uMXQPI44ZmPBlQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779973826; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=s3OGZYfXnteRuvNA+6MIt19Oh5drbLD/0Yb8FeJHQwI=; b=S/qwuPZGGa9lVgwG90mDBHS3rhEEZDfpWbEsRGJO9yswGNMjEp0f9it1Qqv4tiFaduhrf8QU6mcc4Uo3+NH6Jwxn35ksvLuR+6JI8XEJD2qX7+7RgrEO4o5Izyv2qoUhl5sRPt37Wl/MzX7FNlEG+T/5SCbMtNhO9u3+252pWW4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from=<314abh@gmail.com> (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1779973826802716.5256652059471; Thu, 28 May 2026 06:10:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wSaTc-0001sR-Qx; Thu, 28 May 2026 09:08:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <314abh@gmail.com>) id 1wSUZG-0006s7-QU for qemu-devel@nongnu.org; Thu, 28 May 2026 02:50:10 -0400 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <314abh@gmail.com>) id 1wSUZF-0003V3-5y for qemu-devel@nongnu.org; Thu, 28 May 2026 02:50:10 -0400 Received: by mail-pj1-x1030.google.com with SMTP id 98e67ed59e1d1-367cbac9c37so7425407a91.2 for ; Wed, 27 May 2026 23:50:08 -0700 (PDT) Received: from arch ([112.133.246.6]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c852058557bsm14405961a12.30.2026.05.27.23.50.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2026 23:50:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779951006; x=1780555806; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=s3OGZYfXnteRuvNA+6MIt19Oh5drbLD/0Yb8FeJHQwI=; b=FYBMuSmF0842WXoh1o1G3zXiczca0JkXkx36VycN4hrTlfU9THhH6ivAMZCVHEBTYQ YWT9Zc7sb9lRSRXeO3xjKLsCmx3/YLlZ9CmV4ZjsPkehYps3R2reS+JOEQipCTGAJjXU rHdXPw00EZDNy5kBJOAYS74WKHoB9ekX6mGtJrR2a0DWbcKmZL8+U8/eKQQJQhye+WJS +91+VHhDGbjQ7H6Muy4J0iVgvKkJaK2amDrDHGor29rUUVo9pckRxcDMPOAT/40HePyh 9zEEQVcRiiLa/ZAO51ArzZB13AfhphQy36L9bialyCte8SxpEx2/BB9PHPkmpIUFZ4YB O4ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779951006; x=1780555806; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=s3OGZYfXnteRuvNA+6MIt19Oh5drbLD/0Yb8FeJHQwI=; b=Z+1cgUoM5tP5ZReky4BVlr8FrEDcHm3G8K+g5k50y9gqWS8oSvT5Ub3pwNpbFfwyqj 5IEkw+OQT0XeAlZhEYATl4yxCHN40Y4lHtLkmGbJNqn5rBvs2LZlOH/xOrnx4qqQxuXe 3d+A36Vj+suifAmisQ084RFCAMNwQF06tKnky0VjXdMj3+NmDpGvfgyzhLEKozeT5vUe cn0QKDvYcp96/JnsjOXo5lAempd6mEUhmFLXTrCu0oAn8CNZPZ/q1rhpNizq0Li7OT0/ 0H77fZhH1fsg0H88M6wpe8JjY/+tFBoDtPdIgdw3wldBdOI6f7VEO9cwRv68tHda2Ns0 yUjA== X-Gm-Message-State: AOJu0YwGff0jPbj26omO1dJ4FItj0h47l978qIaGF2rfl1s9hb+hd+MG 0fymipxlw0n/nwrHDSGG6qljKIfBId4JpJbrH8D+VHPxY7UQL920SSu+gFyxT7PN X-Gm-Gg: Acq92OEYpkPzs3MdO1lMERyMozOGr0ubeBykkvdPZF9jtBFSC8PfxljYyoY9Y1fB9KL O3wvXlVC3pMRdFuDFCqkuEpezmYBxg9ikjJYIohQp4U+sbpK7cK7ok52juYUEnSrMW5GtnmzRZL OhiPpIgepC6d3OGTRerMYwJhzFjIy47ORCKg6Qwd0Y8hzM+4N7ctX98zEy9lvarTyjBcPn77lJP Ap133gcmK10S4EBgxvy4ebjEVN0mIsftiDRjGkye9iNKkhflvkSrnLutCCqfCdMRZZQC3o20+BN 4AQR/he1ZN7+wfWPJmGWjq8hRR7zcpochGLtBzAc2WUaJcatvefvKVJr8U3Qri0war81qkM5s4T UUdXiMnVH8aSZmFsd1wZmDFJu0ljvYfl7ZntZk6ndefDgwsWIwF6Ck3oXxoTARDjj3FwFSAxuqu krdfG5GVs9zS5fvexA424= X-Received: by 2002:a17:90b:3bc6:b0:368:7327:6326 with SMTP id 98e67ed59e1d1-36a6741ecbamr27650249a91.1.1779951006381; Wed, 27 May 2026 23:50:06 -0700 (PDT) From: Abhigyan Kumar <314abh@gmail.com> To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Richard Henderson , Abhigyan Kumar <314abh@gmail.com> Subject: [PATCH] target/i386: Fix incorrect tcg generation for RCR & RCL instructions Date: Thu, 28 May 2026 12:19:41 +0530 Message-ID: <20260528064941.351917-1-314abh@gmail.com> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1030; envelope-from=314abh@gmail.com; helo=mail-pj1-x1030.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FROM_STARTS_WITH_NUMS=0.738, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 28 May 2026 09:08:44 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1779973827504158500 Content-Type: text/plain; charset="utf-8" RCR and RCL instructions of a count of 9 is meaningless for 8-bit operands. In gen_RCR and gen_RCL functions, gen_rotc_mod converts a rotation of 9 to 0. But, the can_be_zero flag wasn't updated and hence we skip the immediate if branch. This causes 0 to underflow into -1 at tcg_gen_subi_tl(count, count, 1); Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3452 --- target/i386/tcg/emit.c.inc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/i386/tcg/emit.c.inc b/target/i386/tcg/emit.c.inc index ce636b6c5..a71af846d 100644 --- a/target/i386/tcg/emit.c.inc +++ b/target/i386/tcg/emit.c.inc @@ -3452,6 +3452,7 @@ static void gen_RCL(DisasContext *s, X86DecodedInsn *= decode) low_count =3D tcg_temp_new(); =20 gen_rotc_mod(ot, count); + can_be_zero =3D (ot =3D=3D MO_8 || ot =3D=3D MO_16); have_1bit_cin =3D gen_eflags_adcox(s, decode, true, can_be_zero); if (can_be_zero) { zero_label =3D gen_new_label(); @@ -3504,6 +3505,7 @@ static void gen_RCR(DisasContext *s, X86DecodedInsn *= decode) high_count =3D tcg_temp_new(); =20 gen_rotc_mod(ot, count); + can_be_zero =3D (ot =3D=3D MO_8 || ot =3D=3D MO_16); have_1bit_cin =3D gen_eflags_adcox(s, decode, true, can_be_zero); if (can_be_zero) { zero_label =3D gen_new_label(); --=20 2.54.0