From nobody Wed Aug 26 21:48:33 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1779486868; cv=none; d=zohomail.com; s=zohoarc; b=INQy59rklk7lzbS3vThEdkV5EzHzqfhp4a0CrXGyN3PnfqwNhFCLCklPgMkoSEwUPuLm3QO7DCNDXhlMttWjKZy0eB5+UaDRGbHlmxPl0mpG6K8LA7VnpELdwzPWLyLfb4Vr5fLYxBlxnFhRBIGthrbjX9lN4mwAMJSH8O3zGJM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779486868; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=RALOQ1sONAPVBPsNYlKmR16ceV8GnLF36LNysNH/IP8=; b=W+daOGSC40zV418au9Q9CCH2DtvQrL1JUmK8FzkJ6roxLokcvKWc4gKMowEe2usFLIvHDZlJCT6T5kYv0kqIHIriILP5En5uuTcnkrFMeKm2ga9nswoDZju8VTrn5v7wMi50xM5fReSQuYAXnoD2xk+XJbl7Voklp/eld7T5JV8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1779486868725800.9907512798611; Fri, 22 May 2026 14:54:28 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wQXlX-0008Uf-2l; Fri, 22 May 2026 17:50:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wQXlR-0008FZ-2b; Fri, 22 May 2026 17:50:41 -0400 Received: from isrv.corpit.ru ([212.248.84.144]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wQXlN-0003Ln-LZ; Fri, 22 May 2026 17:50:40 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id 3006F1AFB6A; Sat, 23 May 2026 00:49:20 +0300 (MSK) Received: from think4mjt.tls.msk.ru (mjtthink.wg.tls.msk.ru [192.168.177.146]) by tsrv.corpit.ru (Postfix) with ESMTP id 4D0B93B71B9; Sat, 23 May 2026 00:49:24 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tls.msk.ru; s=202602; t=1779486560; bh=6yNTHyY4n+czwCDJOviiZkYDpnz4dMyJaeqmCz/8sP8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=f4ypp9qTDrbMBnGxRr2VEWfU4hKquHS7jVvVT1Ax2ochXFLkMGWi7nHNF6Oq8th5J 0KefefqWWxia1Gy00vhaUI6mtwtBTs1S//PZWMVRguspPSKfQrFi9H9xdByr9DsCdf Xc7GZVW0st8FJL578uI19o1+gLHokcG78hxvqMTBCwrCZa7KuginheoYBxfMwsChkM EQxY0e+tvOW+RQJ4QYDNMcgmrqFQeSJ93qhJUAzzxJaRu94cKtGvI4h5qhg2pAOC+I 56cvSYRsgTZUUvg5g4wPxW9Vkw272wlb5xsM4/fVIyyvehoCVs4803489hCBFJXb0E sEjiOn444JBvQ== From: Michael Tokarev To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, Gerd Hoffmann , Katherine Leaver , Michael Tokarev Subject: [Stable-10.2.3 116/149] hw/uefi: verify data size before accessing it in wrap_pkcs7 Date: Sat, 23 May 2026 00:48:48 +0300 Message-ID: <20260522214923.807017-17-mjt@tls.msk.ru> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=212.248.84.144; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @tls.msk.ru) X-ZM-MESSAGEID: 1779486869694154100 Content-Type: text/plain; charset="utf-8" From: Gerd Hoffmann Fixes: CVE-2026-41439 Fixes: 3e33af2cb306 ("hw/uefi: add var-service-pkcs7.c") Reported-by: Katherine Leaver Signed-off-by: Gerd Hoffmann Message-ID: <20260422092910.444997-6-kraxel@redhat.com> (cherry picked from commit 22b7b222d8f5428be8b5d4787f36efd0a0b75292) Signed-off-by: Michael Tokarev diff --git a/hw/uefi/var-service-pkcs7.c b/hw/uefi/var-service-pkcs7.c index 32accf4e44..f17ad6872f 100644 --- a/hw/uefi/var-service-pkcs7.c +++ b/hw/uefi/var-service-pkcs7.c @@ -73,7 +73,8 @@ static void wrap_pkcs7(gnutls_datum_t *pkcs7) }; gnutls_datum_t wrap; =20 - if (pkcs7->data[4] =3D=3D 0x06 && + if (pkcs7->size > 16 && + pkcs7->data[4] =3D=3D 0x06 && pkcs7->data[5] =3D=3D 0x09 && memcmp(pkcs7->data + 6, signed_data_oid, sizeof(signed_data_oid)) = =3D=3D 0 && pkcs7->data[15] =3D=3D 0x0a && --=20 2.47.3