From nobody Tue Aug 25 22:59:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1779486886; cv=none; d=zohomail.com; s=zohoarc; b=SqJv8y+SwmqwqpQrEe4okVjiY3lzBTaBfdL+JnPgmAZ1FbWbaglhh0L0+zgDiFJD/kGTzMKns2NKd8xHZxTHurEy+9hl57exwFxZZNQYqpDlsV6skOo31pHMgS1K0Pp3cATycbI5Sh4O2OvU2xC8bg+CMw6/BydIqBZyhnoe1BI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779486886; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=7wIGD3kd3G2LVxViTnPl/r5+y+R9W/Bwo/4oGZsvPTE=; b=QWJMyoWt0W1SlXhtF9NE2G9ZVIe/PYSClo3X9ocr+iKnHK5CFPPbeevuuMPEOsv4Z7TZn+D9YN2VAjVIbvj1ynyjyIKrBgvrmrTDOV6PbDGsQUkFauPNCYmeqc77v0vWg57HU9+V0QQ5UWGaipKCA4ecUei3ZQWzRrGOpT59jzI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177948688635749.45160757557812; Fri, 22 May 2026 14:54:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wQXlV-0008TZ-RL; Fri, 22 May 2026 17:50:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wQXl0-0007nQ-KN; Fri, 22 May 2026 17:50:14 -0400 Received: from isrv.corpit.ru ([212.248.84.144]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wQXky-0003I6-6c; Fri, 22 May 2026 17:50:14 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id E2B271AFB67; Sat, 23 May 2026 00:49:19 +0300 (MSK) Received: from think4mjt.tls.msk.ru (mjtthink.wg.tls.msk.ru [192.168.177.146]) by tsrv.corpit.ru (Postfix) with ESMTP id 0D0833B71B6; Sat, 23 May 2026 00:49:24 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tls.msk.ru; s=202602; t=1779486559; bh=usJebyXOwOn1hWsXzUOvUHyblNNQU6e+dFrR0SYBzcs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=RPtFZWkTo/OplmyjdLF/GbOd+3EwVLqkfmIy/VRzo72N33QDH+UoX2zzYlKhZaNOj B8BEaWwAuU+EZpYTOT+lA05/Nr76/bNPj8dtoDHaKUd4gEnwViGKMPWh5m9VijecmZ rvLBkC3ruO6kmAnf7oVNCWojGeiKbhi9xaYkz+l8l2/AEhEVdDlA+/V/2azaVKis/l GFIhFCCBPB7iUHeJ7LynTUklnnjY+HJsYi7UWrJb0qg8F52Li3oZCezD1MjVBzQT8U gLicqNrDejhxXndRdVVike42bVgUHHkBAG7KpvN0qMt7nxBRbUo9m0ycV6tnGbLiCv 5urz0IlfCJd+Q== From: Michael Tokarev To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, Gerd Hoffmann , Katherine Leaver , Michael Tokarev Subject: [Stable-10.2.3 113/149] hw/uefi: verify pio_xfer_offset before calculating buffer checksum Date: Sat, 23 May 2026 00:48:45 +0300 Message-ID: <20260522214923.807017-14-mjt@tls.msk.ru> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=212.248.84.144; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @tls.msk.ru) X-ZM-MESSAGEID: 1779486888342158500 Content-Type: text/plain; charset="utf-8" From: Gerd Hoffmann Without that it is possible to do trigger OOB reads by first advancing offset, then making the buffer smaller, finally asking for a checksum. Fixes: CVE-2026-41436 Fixes: 90ca4e03c27d ("hw/uefi: add var-service-core.c") Reported-by: Katherine Leaver Signed-off-by: Gerd Hoffmann Message-ID: <20260422092910.444997-3-kraxel@redhat.com> (cherry picked from commit 94d9a8b2c9e6962aa7f7673229d2db7b110cfac6) Signed-off-by: Michael Tokarev diff --git a/hw/uefi/var-service-core.c b/hw/uefi/var-service-core.c index 91548e2f39..660ca2f9f8 100644 --- a/hw/uefi/var-service-core.c +++ b/hw/uefi/var-service-core.c @@ -229,6 +229,10 @@ static uint64_t uefi_vars_read(void *opaque, hwaddr ad= dr, unsigned size) uv->pio_xfer_offset +=3D size; break; case UEFI_VARS_REG_PIO_BUFFER_CRC32C: + if (uv->pio_xfer_offset > uv->buf_size) { + retval =3D 0; + break; + } retval =3D crc32c(0xffffffff, uv->pio_xfer_buffer, uv->pio_xfer_of= fset); break; case UEFI_VARS_REG_FLAGS: --=20 2.47.3