From nobody Sat May 30 17:44:06 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1779438424; cv=none; d=zohomail.com; s=zohoarc; b=eSTTQHH7yI7x5zc6RdMVTm1lqONNbJGHT6JaZrEEpwdSBsw6VAEYJGrhsn+rwHaqzLw55Abj/19AFF+V47+DMhlNcs49ahw2D3E7ScPnIii+XVUcWWAwBNRTdMAgmqK+Z3FSjmA2ZSG/yZ9ZsOGrZDJrguVsp1aJn/YYI2kPY4I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779438424; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=gP4eIMrCm/sjEeUVWJ/H2/1+92DRkNvRRdjEsCA5uzE=; b=F1GOTQlIt7O3FuwmrmoyAjm5TrHbQLE9G7ea2IklhcI3Mbx4NfbvxtidSmbPtNeN9qbZ327kn0+mrn8tGqtOVSnnXFya6nxAktw6W6wwW0GMJYhub/m6GB3j/zxekV5H7qeeUM5mpn/Wo9cG5qxdt5Wwj19nrXhel8jV9TC2jRY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1779438424404687.5276277155302; Fri, 22 May 2026 01:27:04 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wQLD3-0000ab-6F; Fri, 22 May 2026 04:26:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wQLD1-0000aC-Gh; Fri, 22 May 2026 04:26:19 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wQLCz-0003ga-NL; Fri, 22 May 2026 04:26:19 -0400 Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64M0ghB1795743; Fri, 22 May 2026 08:26:08 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4e6h8n3171-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 May 2026 08:26:08 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 64M8OOgU015157; Fri, 22 May 2026 08:26:07 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4e73wkg3j8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 May 2026 08:26:07 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 64M8Q3YL50266560 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 22 May 2026 08:26:03 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 530A920043; Fri, 22 May 2026 08:26:03 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 568FC2004E; Fri, 22 May 2026 08:26:00 +0000 (GMT) Received: from localhost.localdomain (unknown [9.124.216.126]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP; Fri, 22 May 2026 08:26:00 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=pp1; bh=gP4eIMrCm/sjEeUVWJ/H2/1+92DRkNvRRdjEsCA5u zE=; b=EZUYK/RZQdmRgJKW/uG9orqaK4+GqwG0HSsnQBd9bau4FCHax3EaLKH2U bIzEjUx4cddexsR9oEdBjXLiZRdZwu0up9f5Coa1WJiddOVPGD6fCBLCIBq1o7xT T5F3xXhKgHpvKrwpkQeNIbCBstvdMrLc+39Fo77vzwW2vm94gQzIl2sSUOnathIP SrRvqjXKNtC5hXIaB/fnxHiGdQ36FSThwYK1awHTxThxoXp2W8y6A+d1zC8TYX38 oU8b7J3AYIUAMt0lZshm4I6oqeX4H3pmXa/+QNmtlt1ZB7ACOPZ5RYlvUoO2vuV/ ceG374d5Ir1VX4QJKyvmQig6wM0QQ== From: Amit Machhiwal To: qemu-ppc@nongnu.org, Fabiano Rosas , Laurent Vivier Cc: Amit Machhiwal , Vaibhav Jain , Harsh Prateek Bora , Chinmay Rath , Shivaprasad G Bhat , Gautam Menghani , Paolo Bonzini , Matthew Penney , Anushree Mathur , Aditya Gupta , qemu-devel@nongnu.org Subject: [PATCH v2] tests/qtest/libqtest: Use GLib functions for proper const correctness Date: Fri, 22 May 2026 13:55:55 +0530 Message-ID: <20260522082555.54918-1-amachhiw@linux.ibm.com> X-Mailer: git-send-email 2.50.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-GUID: jxzMo7E-6-I9o4TFBibHTJU6ZoJrlJZf X-Authority-Analysis: v=2.4 cv=GYMnWwXL c=1 sm=1 tr=0 ts=6a101320 cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=uAbxVGIbfxUO_5tXvNgY:22 a=VnNF1IyMAAAA:8 a=jvaL8Bd8GjUaJr6_dqQA:9 X-Proofpoint-ORIG-GUID: jxzMo7E-6-I9o4TFBibHTJU6ZoJrlJZf X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIyMDA4MCBTYWx0ZWRfX8uWH51xXqymb Qp03ypU+pwM9kkTTmj4ViLSWJ8oXRRCwrZy+kxPtmlJTl4qyOujes7UXYI7dfCxVda8/hxt/9gG Q/czK+sCNG5CYJ/KKuWbPaHObq6X2YB9K5/Nhc2oHPO3llqhh5WGh6cRNaF2trtbT7IH8A5pDa+ ljdw+lxoGd6WoTZoKAqpxHFt+hXrN5L+xGKVslAqvVC7oDy1E/PxXZKN/GvrZELgg94gwRBZhi6 c7fejsbkSHuE89SoWl6rV0HWGnOBtw46Q8JvxfYgacATGW16hlIXf72X56m0PU9BMKCFHt76vw3 oHjV/4Sf/A2pyvDZ5vyTKNDR4e027u19HRG1+Bp6KXH6n66im58g5kDEGIr8ZD+cjJc5Bvlcwu5 yVVSJAqqptl7tlfzwph/eC8bRSI6puAYNoq8iX325jV7ZWl0B/EK2theufgTUnnSIO3VVvVnAav E53glHcvZaVGreQbNVg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-22_01,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 adultscore=0 suspectscore=0 spamscore=0 clxscore=1011 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605220080 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=148.163.156.1; envelope-from=amachhiw@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1779438427101154100 Content-Type: text/plain; charset="utf-8" While commit e68da5b7a2cd ("tests/qtest: fix discarded const qualifier warning") addressed the immediate strstr() warning by making 'found' const, there's still a room for improvement: getenv() returns char *, but environment strings are semantically read-only and should be treated as con= st throughout their lifetime. Replace getenv() with g_getenv() and strstr() with g_strstr_len() to maintain const correctness from source to use. This approach: - Uses g_getenv() which returns const gchar *, matching the read-only semantics of environment variables - Employs g_strstr_len() for consistent use of GLib string functions, aligning with QEMU conventions - Eliminates all const-correctness warnings with strict compilers Tested-by: Anushree Mathur Reviewed-by: Aditya Gupta Signed-off-by: Amit Machhiwal --- v2: - Rebased on top of e68da5b7a2cd ("tests/qtest: fix discarded const qualifi= er warning") - Split from previous patch series and sent as standalone patch - Updated commit message to clarify relationship with prior fix - Retaining tags from previous version as no major changes tests/qtest/libqtest.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c index b1e06ea364ec..cb80ab23182a 100644 --- a/tests/qtest/libqtest.c +++ b/tests/qtest/libqtest.c @@ -2145,8 +2145,7 @@ bool mkimg(const char *file, const char *fmt, unsigne= d size_mb) =20 bool qtest_verbose(const char *domain) { - const char *log =3D getenv("QTEST_LOG"); - const char *found; + const gchar *found, *log =3D g_getenv("QTEST_LOG"); =20 assert(domain); =20 @@ -2172,11 +2171,11 @@ bool qtest_verbose(const char *domain) * QTEST_LOG=3D,- (only false for domain2) * allows other separators, except - and + */ - found =3D strstr(log, domain); + found =3D g_strstr_len(log, -1, domain); =20 if (found) { /* reject options given twice */ - assert(!strstr(found + strlen(domain), domain)); + assert(!g_strstr_len(found + strlen(domain), -1, domain)); =20 if (found > log) { ptrdiff_t i =3D found - log - 1; @@ -2190,7 +2189,7 @@ bool qtest_verbose(const char *domain) * If filtering out a specific domain, all others are * enabled. */ - return !!strstr(log, "-"); + return !!g_strstr_len(log, -1, "-"); } } =20 base-commit: f5a2438405d4ae8b62de7c9b39fac0b2155ee544 --=20 2.50.1 (Apple Git-155)