From nobody Wed Aug 26 20:43:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1779366652; cv=none; d=zohomail.com; s=zohoarc; b=gfTfWao3eYajs3SpmUnpLriG9Rc6bV0m3xtCb5KBYzyvpvig41iv/vqEFae/5QlITO4TmXIz8kiIc80/Fd2qafajWDb9kWQNIXCOJHHD5Mw560DsW41k5WqFBraOkl/lde+nbVMNSqU99nVOPg5THmogfjI+Gx3TYj1hY4O3iZ8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779366652; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=W8ZF++qrDnuZBikX/tugNauIXQvtq2xExzyD11E2IKo=; b=ZaW9JQO6tlEWbQxW0l04xotUG3r6+GbCqWrYXNk/L97O6inn4lMcnQnSc39s0eECnOr6/ArX5wh5RAd/rwe/tjh3FDUfbGwSVS1qZIjKv9yoAA5xNdnwPpgl1WWdhSo+8H9riWkpqZdQAUvEJQR0VpD2s4xfjhuC+9HCTnbbpNA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1779366652572595.579603030121; Thu, 21 May 2026 05:30:52 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wQ2X9-00011G-FY; Thu, 21 May 2026 08:29:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wQ2Wg-0000xu-1w for qemu-devel@nongnu.org; Thu, 21 May 2026 08:29:24 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wQ2We-0001cZ-CD for qemu-devel@nongnu.org; Thu, 21 May 2026 08:29:21 -0400 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-4903dba5c3cso2095605e9.0 for ; Thu, 21 May 2026 05:29:19 -0700 (PDT) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49035c72c78sm22054245e9.3.2026.05.21.05.29.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 05:29:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1779366558; x=1779971358; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=W8ZF++qrDnuZBikX/tugNauIXQvtq2xExzyD11E2IKo=; b=q5AkWG4BEDQUFM2cogmJG8FduKuQn0sJjN/LLNnESzr2BLAix2d+t74a5ySest63gX CU65ulzWxY1jriAmCohlXP+SjcDRo32BZPDgyXxF/y8oJwPb6JB4U0ayr+mJuA3KxPCw KYFBtp6ovIwBvjWhEwTZcO/uWvOdH2Kjfv0qNGww3Uk0pvW3rALhYrW817nJYFv+DK/N Tm0W004vFj1/YQCKlBiXSCbvElRhyY76A1LGGXvu5TtKjJ1xXsi8O5Y7Pr8Ls5m3eQgY lGakIh3M9zTnTRWJNtngfgXTEjq5HiLE1x7rxZfLSeRXsc8dTdywjpZKTamHpb2J1OFF eqMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779366558; x=1779971358; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=W8ZF++qrDnuZBikX/tugNauIXQvtq2xExzyD11E2IKo=; b=iZUpDo7SmpUEHS52RzlCE5L03JNFvJe3QvR3fz7L2Il6m468bG2B2No8lIeTcxXZ00 X03OaORwvnT7qDb8v1LZNvqBqW5oYuGezvSKTZU4QO5kEogztJIcWzqwjHXeAV5cp1Jv sNPL6AihCwVImoWQ+DoIZgBoPYhGKCg1wK5KHu7Ev02ibUgSHzrY7jSmTZ32GTWwljn7 X24UsbbI0YHbl5nL7d/rGUdsF+6BHxLqJGNgwkxEp/QfooxmyOXfDDn2mf2Ul+TFbgRa HbuzyAsnfPAam7njTMdfdhMuyMH+223mkGD97TTRlOgleofQxyOERZwEEbaYjUV1zuVS GZ0A== X-Forwarded-Encrypted: i=1; AFNElJ+neyZuFOepRIYOqZKQVlEnOm5PHY1kbYwi2NBhIvQPthQ3HTLWzyJjpSVXM4tWlr8t/r00QN3XF8BL@nongnu.org X-Gm-Message-State: AOJu0Yz8R1K6qBwy2ClbvU9TSsPIwQJlswdVgeGpMafNOMjzcuUjD9fa A0Fcep0QpOg6EHKNHvmL3TfpN3Tw/T2jRP6ltA6nh4ChT4rZ5KKv3SW6+jsh6/Bz6Kh6uRgBdDw arnYC X-Gm-Gg: Acq92OEsLuHkIARVpbAhF+gT51R3oZMFfFxQ2gJdxfomWf4rQRFQTzT2MBPAf4/xoQs sOJvbCqeEIsMQS8dWggbgGgKM+oGLEO7A8FyGnGzPdupO6kOR4tJk3XhTo67WVDEqxVWbqz/Nrm NEZvw+C669TUumHLTaIeWJv5xAHPMo/Nc66JMc7v632O7FC9qAYpFRKuL8MZk/bmQjZ0sgZD1t/ CtSEwQ5ZlVjC/l36TQ2eXmWT8SwdaH2sEubLskx5XBJ4B8JuXDGsOHYe64BlwBHcE9LeHqkCrSe uH+N056sQLLK+QQap3LBTzHfOyuRKRBBsKJH89i1XaEjJBgv0vrxxuhwoKhQELr6Ppk+KjlOvoW vu0F67IJPhxdPyk7vhfM5tzEVTbMlNiE+tPIeMeTwflcOdHoWGpO7wYNXh7tKXkVo2ZRHAHSGZL COPMTtTYXWaKx2LfQKQ/jKk6ZLrITjd7fLZv/B+O8bpkOo+2lIvvB9NC/6P34mmko46Ks3tn3Qb CJOovOXG5JEk71mcKIVj5jjOOgw3b0= X-Received: by 2002:a05:600c:4e92:b0:490:3b84:c106 with SMTP id 5b1f17b1804b1-4903b84c8ffmr28205435e9.26.1779366557662; Thu, 21 May 2026 05:29:17 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org Subject: [PATCH 1/3] target/arm: SVE2 FMAXP, FMINP must honour AH=1 Date: Thu, 21 May 2026 13:29:11 +0100 Message-ID: <20260521122913.1565011-2-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260521122913.1565011-1-peter.maydell@linaro.org> References: <20260521122913.1565011-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1779366655481154100 Content-Type: text/plain; charset="utf-8" The behaviour of floating-point maximum and minimum insns has some odd special cases when FPCR.AH=3D1. We get this right in most places (for instance, the ASIMD FMAXP, FMINP) but forgot about it for the SVE2 versions of FMAXP and FMINP. Cc: qemu-stable@nongnu.org Fixes: 384433e70983 ("target/arm: Implement FPCR.AH semantics for FMINP and= FMAXP") Signed-off-by: Peter Maydell Reviewed-by: Alex Benn=C3=A9e --- target/arm/tcg/helper-sve-defs.h | 14 ++++++++++++++ target/arm/tcg/sve_helper.c | 8 ++++++++ target/arm/tcg/translate-sve.c | 4 ++-- 3 files changed, 24 insertions(+), 2 deletions(-) diff --git a/target/arm/tcg/helper-sve-defs.h b/target/arm/tcg/helper-sve-d= efs.h index c3541a8ca8..cd05dd0fb4 100644 --- a/target/arm/tcg/helper-sve-defs.h +++ b/target/arm/tcg/helper-sve-defs.h @@ -2914,6 +2914,20 @@ DEF_HELPER_FLAGS_6(sve2_fminp_zpzz_s, TCG_CALL_NO_RW= G, DEF_HELPER_FLAGS_6(sve2_fminp_zpzz_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, ptr, fpst, i32) =20 +DEF_HELPER_FLAGS_6(sve2_ah_fmaxp_zpzz_h, TCG_CALL_NO_RWG, + void, ptr, ptr, ptr, ptr, fpst, i32) +DEF_HELPER_FLAGS_6(sve2_ah_fmaxp_zpzz_s, TCG_CALL_NO_RWG, + void, ptr, ptr, ptr, ptr, fpst, i32) +DEF_HELPER_FLAGS_6(sve2_ah_fmaxp_zpzz_d, TCG_CALL_NO_RWG, + void, ptr, ptr, ptr, ptr, fpst, i32) + +DEF_HELPER_FLAGS_6(sve2_ah_fminp_zpzz_h, TCG_CALL_NO_RWG, + void, ptr, ptr, ptr, ptr, fpst, i32) +DEF_HELPER_FLAGS_6(sve2_ah_fminp_zpzz_s, TCG_CALL_NO_RWG, + void, ptr, ptr, ptr, ptr, fpst, i32) +DEF_HELPER_FLAGS_6(sve2_ah_fminp_zpzz_d, TCG_CALL_NO_RWG, + void, ptr, ptr, ptr, ptr, fpst, i32) + DEF_HELPER_FLAGS_5(sve2_eor3, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, ptr, i= 32) DEF_HELPER_FLAGS_5(sve2_bcax, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, ptr, i= 32) DEF_HELPER_FLAGS_5(sve2_bsl1n, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, ptr, = i32) diff --git a/target/arm/tcg/sve_helper.c b/target/arm/tcg/sve_helper.c index 062d8881bd..179cbd74fb 100644 --- a/target/arm/tcg/sve_helper.c +++ b/target/arm/tcg/sve_helper.c @@ -778,6 +778,14 @@ DO_ZPZZ_PAIR_FP(sve2_fminp_zpzz_h, float16, H1_2, floa= t16_min) DO_ZPZZ_PAIR_FP(sve2_fminp_zpzz_s, float32, H1_4, float32_min) DO_ZPZZ_PAIR_FP(sve2_fminp_zpzz_d, float64, H1_8, float64_min) =20 +DO_ZPZZ_PAIR_FP(sve2_ah_fmaxp_zpzz_h, float16, H1_2, helper_vfp_ah_maxh) +DO_ZPZZ_PAIR_FP(sve2_ah_fmaxp_zpzz_s, float32, H1_4, helper_vfp_ah_maxs) +DO_ZPZZ_PAIR_FP(sve2_ah_fmaxp_zpzz_d, float64, H1_8, helper_vfp_ah_maxd) + +DO_ZPZZ_PAIR_FP(sve2_ah_fminp_zpzz_h, float16, H1_2, helper_vfp_ah_minh) +DO_ZPZZ_PAIR_FP(sve2_ah_fminp_zpzz_s, float32, H1_4, helper_vfp_ah_mins) +DO_ZPZZ_PAIR_FP(sve2_ah_fminp_zpzz_d, float64, H1_8, helper_vfp_ah_mind) + #undef DO_ZPZZ_PAIR_FP =20 /* Three-operand expander, controlled by a predicate, in which the diff --git a/target/arm/tcg/translate-sve.c b/target/arm/tcg/translate-sve.c index aa7d72a35e..bf9f0ae179 100644 --- a/target/arm/tcg/translate-sve.c +++ b/target/arm/tcg/translate-sve.c @@ -7667,8 +7667,8 @@ TRANS_FEAT_NONSTREAMING(HISTSEG, aa64_sve2, gen_gvec_= ool_arg_zzz, DO_ZPZZ_FP(FADDP, aa64_sme_or_sve2, sve2_faddp_zpzz) DO_ZPZZ_FP(FMAXNMP, aa64_sme_or_sve2, sve2_fmaxnmp_zpzz) DO_ZPZZ_FP(FMINNMP, aa64_sme_or_sve2, sve2_fminnmp_zpzz) -DO_ZPZZ_FP(FMAXP, aa64_sme_or_sve2, sve2_fmaxp_zpzz) -DO_ZPZZ_FP(FMINP, aa64_sme_or_sve2, sve2_fminp_zpzz) +DO_ZPZZ_AH_FP(FMAXP, aa64_sme_or_sve2, sve2_fmaxp_zpzz, sve2_ah_fmaxp_zpzz) +DO_ZPZZ_AH_FP(FMINP, aa64_sme_or_sve2, sve2_fminp_zpzz, sve2_ah_fminp_zpzz) =20 static bool do_fmmla(DisasContext *s, arg_rrrr_esz *a, gen_helper_gvec_4_ptr *fn) --=20 2.43.0