From nobody Tue Aug 25 04:33:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1779313908; cv=none; d=zohomail.com; s=zohoarc; b=VKhd4zSSh4MjZTdiEtUsPSA3tu8pWW4IYCPan8dm9P3ixSIRxJBj83zJBfnJX2uOIUwBXr/mQfXkOLBciRObWOg1lpLE7aqtAk55+PrZNRfJhxa8MSJFnyL2icFChVr3DXLJ8CDBltIVVKUnvi2ULXj0VvAn8fWqKOWwlX4LvCE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779313908; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0eJdJcfyGT1m9XhcdoBH46HTaYnr0mwJYyndbnLTphA=; b=Fb7jok+OYfdh5m0d31FKSYDxExu6AGGqdxDjHkrZd012vtmmLfQ1lr+aN1ltinm9TWRhpZ+RZ9BfWnCbWVHQgxry3XE8NrgPSq5VNROpP4yYPKik6YppzRrrpuggVv2IdzhbRySes/cea6ld89OuH9VKpozy5XH80DTdOwabnqc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1779313908125960.9665537678258; Wed, 20 May 2026 14:51:48 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wPooA-0006tI-Kq; Wed, 20 May 2026 17:50:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wPoo8-0006sv-Vr for qemu-devel@nongnu.org; Wed, 20 May 2026 17:50:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wPoo7-00046h-Jj for qemu-devel@nongnu.org; Wed, 20 May 2026 17:50:28 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-441-KCKaaaZuNZWdS3KBdo7HjQ-1; Wed, 20 May 2026 17:50:25 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 942131956095 for ; Wed, 20 May 2026 21:50:24 +0000 (UTC) Received: from localhost (unknown [10.44.24.26]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 048D91800357; Wed, 20 May 2026 21:50:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779313826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0eJdJcfyGT1m9XhcdoBH46HTaYnr0mwJYyndbnLTphA=; b=HSCX/c27EGpvM4/WkyRQ94Ob7BIrefpZjzasBSOfIWMoOkBzCPzsollkqbHf3r0HhWO1GT XRcvHUBH4z97LHNXG8xL+iOyCefqVq3DoE50wUcn50D5ZqEpiKLkteuch1ymNQQNOD6KrR uQlqCqcfZYaloHOldCsJYtOW2m56PMc= X-MC-Unique: KCKaaaZuNZWdS3KBdo7HjQ-1 X-Mimecast-MFC-AGG-ID: KCKaaaZuNZWdS3KBdo7HjQ_1779313824 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Thu, 21 May 2026 01:49:04 +0400 Subject: [PATCH 03/40] hmp: fix snapshot_blkdev argument type MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260521-qemu-no-hmp-v1-3-d104f809e145@redhat.com> References: <20260521-qemu-no-hmp-v1-0-d104f809e145@redhat.com> In-Reply-To: <20260521-qemu-no-hmp-v1-0-d104f809e145@redhat.com> To: qemu-devel@nongnu.org Cc: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=908; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=cmSXXEvy+S/p9NUPm0pNCoVfh6+SHKQEGeOOZ3aepek=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqDiyCeToatH0zY34OITz8+Yr3AoljK1ZQnU703 KvSudVawtuJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCag4sggAKCRDa6OEJdZac 5RW9D/9nWnNhp4ViH3aUMX9HbqZxVAJD3STvdMRON7ZIB+QW+BVsWaHgge+Ysc0ErUFfWY+OO+u alkIojIkBND3dG5i9MguHKpb8zTPQ6eiaDYEfzCNSNG+rqdS82pwbB/8BFQMAXdFdyWSwOm+EyZ ap+I66DOyn94BBz22CmAy4QcctzboEzRwWcuH3v4/+YVhVFi7fxr3GODrn8g0QBXiEcbOCDSg2j rm32aW2vL8vhje+gPvjIlJ9ofrJuohJT7DplGIHmqyGggmqDGnNFYSuQWC9znk5RVeaJWp7bO2M rzu8+QDtpBqbUC0HyQDeHPKi67pL/IrUIOUNZYRUrJTvxxEEAaXmQF+9a+xvKgm2hwM8nURfRJK 6KN9K3snFcOoa4c1paeHRi93qSyOkV+C/b3XE9mTDwXlXIzjXg5ngEEhFKc7jEdlYQzq5kTvUbf 6aYHKIxibOtLuaNXm/2laM4Eqr6k0XJTMps1V4gC+savIDTwWZ3+eW7PR56qswRq+3O8uUOVJTm 2v1Y+zbBkypyFx5Sk4DzT2VNm7pUMf/QLOpEVlNN3FrqA1/QmbssJChiNcnEUF9waf8vfPe8/0F eNWotv374x0b3nvaXF+Wec5gTigogou6wp8EOjxOzWg8xJ/M7OPZygA17FOzNI5t9L6w43EjAz7 tNPRhfGneAwwt0A== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1779313910167158500 The `snapshot-file` argument for `snapshot_blkdev` is mandatory. Correct the `args_type` definition to reflect this. Fixes: 6106e2492fe ("qapi: Convert blockdev_snapshot_sync") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hmp-commands.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 750a2f42a80..705c8662f4b 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1168,7 +1168,7 @@ ERST =20 { .name =3D "snapshot_blkdev", - .args_type =3D "reuse:-n,device:B,snapshot-file:s?,format:s?", + .args_type =3D "reuse:-n,device:B,snapshot-file:s,format:s?", .params =3D "[-n] device [new-image-file] [format]", .help =3D "initiates a live snapshot\n\t\t\t" "of device. If a new image file is specified, the\n\= t\t\t" --=20 2.54.0