[PATCH 02/40] hmp: remove 'vcpu' argument from trace-event help

Marc-André Lureau posted 40 patches 2 months, 3 weeks ago
There is a newer version of this series
[PATCH 02/40] hmp: remove 'vcpu' argument from trace-event help
Posted by Marc-André Lureau 2 months, 3 weeks ago
Fixes: 89aafcf2a793 ("trace: remove code that depends on setting vcpu")
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 hmp-commands-info.hx | 6 +++---
 hmp-commands.hx      | 7 +++----
 2 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx
index 82134eb6c21..2695ff04ffc 100644
--- a/hmp-commands-info.hx
+++ b/hmp-commands-info.hx
@@ -587,10 +587,10 @@ ERST
 
     {
         .name       = "trace-events",
-        .args_type  = "name:s?,vcpu:i?",
-        .params     = "[name] [vcpu]",
+        .args_type  = "name:s?",
+        .params     = "[name]",
         .help       = "show available trace-events & their state "
-                      "(name: event name pattern; vcpu: vCPU to query, default is any)",
+                      "(name: event name pattern)",
         .cmd = hmp_info_trace_events,
         .command_completion = info_trace_events_completion,
     },
diff --git a/hmp-commands.hx b/hmp-commands.hx
index c3a1a95c5fb..750a2f42a80 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -299,10 +299,9 @@ ERST
 
     {
         .name       = "trace-event",
-        .args_type  = "name:s,option:b,vcpu:i?",
-        .params     = "name on|off [vcpu]",
-        .help       = "changes status of a specific trace event "
-                      "(vcpu: vCPU to set, default is all)",
+        .args_type  = "name:s,option:b",
+        .params     = "name on|off",
+        .help       = "changes status of a specific trace event",
         .cmd = hmp_trace_event,
         .command_completion = trace_event_completion,
     },

-- 
2.54.0


Re: [PATCH 02/40] hmp: remove 'vcpu' argument from trace-event help
Posted by Philippe Mathieu-Daudé 2 months, 3 weeks ago
On 20/5/26 23:49, Marc-André Lureau wrote:
> Fixes: 89aafcf2a793 ("trace: remove code that depends on setting vcpu")
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>   hmp-commands-info.hx | 6 +++---
>   hmp-commands.hx      | 7 +++----
>   2 files changed, 6 insertions(+), 7 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>