From nobody Mon Aug 24 00:42:39 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1779312995; cv=none; d=zohomail.com; s=zohoarc; b=O7xSVliQvAdT3e1O+UnQAWe7Gzd3A2LeI4WEuogp/0BAYeCCAV20tl2r4UNgaQrVV14sVxV1XsrSWNQ34QBKNRcbTaJZTD/H3vyfaEJvXrEsHDLRUJRSdmaTmXViZrbU80Zye0DHapNETq/dJoT9R77qtohO4sUOBVUWGmo/9fs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779312995; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=BN/SAy/s/zQ4OQntT5AIDwA9mLnJ4zwvh7mc8onZCok=; b=I7bDMf85K4ov7wOdO6HYJJFDHp3Qh4wOfE7nd4bRRleE0OSf6n8uiyx39gs303pMlCi5RwGD5uujoRE6ipdTNanXy1SC5k0yAt+NvI6pwF8D1jjYOi8xA3sgfV/WUegJFytZe43RNTGo24Ymi0YTl49wuANzleT5Y10XRWK+V2w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1779312995870524.9634207450492; Wed, 20 May 2026 14:36:35 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wPoZV-0002i6-G2; Wed, 20 May 2026 17:35:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wPoZN-0002IA-Ez for qemu-devel@nongnu.org; Wed, 20 May 2026 17:35:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wPoZL-0007f2-Pp for qemu-devel@nongnu.org; Wed, 20 May 2026 17:35:13 -0400 Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-531-0DP-C-hdPiaFktSfEtG4eA-1; Wed, 20 May 2026 17:35:09 -0400 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-514b673c8f1so58320071cf.3 for ; Wed, 20 May 2026 14:35:09 -0700 (PDT) Received: from x1.com ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ca360b362fsm133062716d6.22.2026.05.20.14.35.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 14:35:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779312911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BN/SAy/s/zQ4OQntT5AIDwA9mLnJ4zwvh7mc8onZCok=; b=O1qIjz1CTxLXk3XdG9eVcd5bXGrMYBzUxrlwdMr7T9v4KkDkZfbgJ7z46mDLJ6THGxlVuX 80za0SS7360xUuruCXQC8ARD9mrbG4qCAGtI6Q0nyYXMg385LPPszjovhY249zsOBszz3g Z6E5DMs/4+IYDBYNW6GDl0b9pZm95L8= X-MC-Unique: 0DP-C-hdPiaFktSfEtG4eA-1 X-Mimecast-MFC-AGG-ID: 0DP-C-hdPiaFktSfEtG4eA_1779312909 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779312909; x=1779917709; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BN/SAy/s/zQ4OQntT5AIDwA9mLnJ4zwvh7mc8onZCok=; b=FEoZMc/C/kaGCdbg9IRqeE4pj1bPgZyq+DtGC5XmrzIwMjAOizy52WShql14YmZmvV tyzdypW2BJtCcLvQIJ0hNxTQiBQfl8s46pOvCunMX6nznbaqhyb4SFk2RL+PVGkoYlhn hs2zSXelOYYEpy8iIhcLBJCaYc5emYTp46ZYynxdSXiTDzIYfKbGfUpkvMPK9rxQVa2o JzuTjgnh1+JwyclEh9arrlbZR8cwrhfM1S/8Xabf8yoATJ0aCx4ztGsl4XSmS0HuIsEv YhUcASRP84nqsoSvFIA3aaGRFwkvS684L2LGkPcTvLVcCmHyBLWsx+AGJpCTpPcG9MiL xD/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779312909; x=1779917709; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BN/SAy/s/zQ4OQntT5AIDwA9mLnJ4zwvh7mc8onZCok=; b=WZqa+AdMJQE0feVVBsiuP4BJ/vw77KAuaaWPdVQpmxssG14pyEymljhqeeWD8X6XaM kP0vKxPqRiVCBccTwcU+3CmoadTRqFKwUH62A2mGVXdJairEW/EPt+tRo0lfRUFxEtgz X2uDxINCEWaqv7mvVcthHRWmiEqv0vYWFc+/doYpw4B7QlvZGLigfr4yc5NJdxGm4XzB SfrdGiGEN8fCpa3fxHHJOIAxuvjq7p9MldZJpQOaWuM38pBhjQFN1LmtdD05BuLl5qxU KGo5HnMVlYfCU2iCIQMWlWw8mvaKjrnCp8YO8EtMciWigC7L5BqOkaXVVHt5O9q7B/O+ qVcA== X-Gm-Message-State: AOJu0YyDOMoIXXn0B3+IycMj1czS3CgzGTtXo2yfD/n6x79FQlRaa2VU wXdUEh6iSt9/W/l87gtjNfo4sgR/uaRoAb40GaNsyWiV/kccEE5RizOZ5G2bF9p9mKd3yPPJBBs nWG245RGKHcG3QxqO1SHXBwcwnG3oMG6OPBf8Chjv057o6bMGS9De7tnhtqqlU/A31MsmriwZkM /LjmmFuiJi/cC1UMijvDluacJjB+z62tfMCdBHmw== X-Gm-Gg: Acq92OFhr0wmXOuimn6BJAAoTMYffpefZlO3VnqqbeBGMTNS+yPUrlw2EQ559OIY0qR o7RW56Zyoq40mMDzs7GAxfSMGEhGFquwSlv9bNfY5gMvloSsKVWsOFic/cGsOOI9CFmfvPc1L2v eUJqko4HLb1+KRZtHImqY/OPgpBaYrS+iYXEdVwTQy2m9+KDLkqu1rHEGOFQUwVdKsqep3W2Xq+ 5gGQqeXgyxIoqNH/ggVkS9TohmFBXb631KrbgKVcihC9iw6c+IahHU8szLgv4r9VxRrWvBVPHSP JPBVMWfu+g6d2O3b29HAZOpn8L9hNQmDWslOCQA6RJJ6Bf3NRJmjITqhVP6CyyjAk1D+qLbJIVY BsMttf3VYtGDn+u0u09fikSIEWOdb85AS7ozMxJPjMJ4h X-Received: by 2002:a05:622a:190e:b0:50f:b494:7887 with SMTP id d75a77b69052e-516c55ba389mr3671231cf.51.1779312907931; Wed, 20 May 2026 14:35:07 -0700 (PDT) X-Received: by 2002:a05:622a:190e:b0:50f:b494:7887 with SMTP id d75a77b69052e-516c55ba389mr3670401cf.51.1779312907230; Wed, 20 May 2026 14:35:07 -0700 (PDT) From: Peter Xu To: qemu-devel@nongnu.org Cc: Fabiano Rosas , Peter Xu , Bin Guo Subject: [PULL 27/29] migration/multifd: cache channel count in multifd_send_sync_main Date: Wed, 20 May 2026 17:33:55 -0400 Message-ID: <20260520213357.40646-28-peterx@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260520213357.40646-1-peterx@redhat.com> References: <20260520213357.40646-1-peterx@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1779312996367158500 Content-Type: text/plain; charset="utf-8" From: Bin Guo multifd_send_sync_main() is called once per RAM synchronization round during live migration. It iterates over all multifd channels twice (signal loop + wait loop), calling migrate_multifd_channels() independently in each loop header. Cache migrate_multifd_channels() in a local thread_count variable at function entry, matching the pattern already used in multifd_send_setup() and multifd_recv_setup(). This eliminates 2 redundant config lookups per sync call. Signed-off-by: Bin Guo Reviewed-by: Fabiano Rosas Link: https://lore.kernel.org/r/20260518110112.21395-9-guobin@linux.alibaba= .com Signed-off-by: Peter Xu --- migration/multifd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/migration/multifd.c b/migration/multifd.c index 0ac3f5e719..dbad525d2a 100644 --- a/migration/multifd.c +++ b/migration/multifd.c @@ -611,13 +611,15 @@ static int multifd_zero_copy_flush(QIOChannel *c) int multifd_send_sync_main(MultiFDSyncReq req) { int i; + int thread_count; bool flush_zero_copy; =20 assert(req !=3D MULTIFD_SYNC_NONE); =20 + thread_count =3D migrate_multifd_channels(); flush_zero_copy =3D migrate_zero_copy_send(); =20 - for (i =3D 0; i < migrate_multifd_channels(); i++) { + for (i =3D 0; i < thread_count; i++) { MultiFDSendParams *p =3D &multifd_send_state->params[i]; =20 if (multifd_send_should_exit()) { @@ -634,7 +636,7 @@ int multifd_send_sync_main(MultiFDSyncReq req) qatomic_set(&p->pending_sync, req); qemu_sem_post(&p->sem); } - for (i =3D 0; i < migrate_multifd_channels(); i++) { + for (i =3D 0; i < thread_count; i++) { MultiFDSendParams *p =3D &multifd_send_state->params[i]; =20 if (multifd_send_should_exit()) { --=20 2.53.0