From nobody Wed Aug 26 17:02:28 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1779313011; cv=none; d=zohomail.com; s=zohoarc; b=bjJ0ycvjnEG1wD6ijF+FNhPbXFk0cP6hPfmcRTqZuVnhZ5nDDV8dRJGpPVTwf8P2ZRu04DGgzLY9MKWBGT938HFjgMJywVhUuhm4SJuWFdrj6cy3FCJOSFECjU9sxDvtE/GDC/mvPPtVJJo8QX4oghRRGd/4CiwQgo+0ToaKB28= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779313011; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=dOHplUY4YxSEbwAdUtwP8OIXWY9Sz4byjeqRgy2OfZQ=; b=ITfvSsUPKuHIQyQ6D2SO5BAwqyUgTO6N5hNe1PoLF160OnHyZs7gZiyPSO2y7T0giMW1b21EhKW4diCOAPuJJexn23V87A9j2GRxx4NmIgrGPYuSTPyEJGBP5VHJ3iE6vr0FvBBygktUHwYDvF2wRoReHm/YmR3vUFPP9ad2Cx8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1779313011445731.2411209770686; Wed, 20 May 2026 14:36:51 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wPoYt-0001Gx-FC; Wed, 20 May 2026 17:34:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wPoYs-0001GE-1z for qemu-devel@nongnu.org; Wed, 20 May 2026 17:34:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wPoYp-0007HO-Ej for qemu-devel@nongnu.org; Wed, 20 May 2026 17:34:41 -0400 Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-669-T_0iM7kEOau7i0kwCDQsgA-1; Wed, 20 May 2026 17:34:37 -0400 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-8cc0e037fe5so24588636d6.0 for ; Wed, 20 May 2026 14:34:37 -0700 (PDT) Received: from x1.com ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ca360b362fsm133062716d6.22.2026.05.20.14.34.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 14:34:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779312878; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dOHplUY4YxSEbwAdUtwP8OIXWY9Sz4byjeqRgy2OfZQ=; b=TKP9X5k81Dl/Phfze5JugMaSAQGUp/ZaqGi99UTa13Q6jm/++tHxb8hFviPDSML1bAH35P Oqo3b1CWtbBVxTc3HiPngjso0R+hb5D0dAmJrkPpocr8FOa1/+C/9G9MH9MASRUO0FfAYT /gEV9Vah+akp7kO/yivGrfaahDrVehI= X-MC-Unique: T_0iM7kEOau7i0kwCDQsgA-1 X-Mimecast-MFC-AGG-ID: T_0iM7kEOau7i0kwCDQsgA_1779312877 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779312876; x=1779917676; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dOHplUY4YxSEbwAdUtwP8OIXWY9Sz4byjeqRgy2OfZQ=; b=MMI3DDBkIBaFFzF6Rz7uT7M4eWPG5eQHVg9BLJ7KT9dhn3o0q8dIEu9mKSDJzo2nxX z4iomk8T15fx/bTLVDDUXAeRFXbYsUm2Zi9IFcGusHxuBDESfzNj3s7Vy4a6xZHJ78dN XzAp5fBXDWTfFny93uuG47QaxWUVOg2YGMwfPZ+al9qnSgbmm3pWW/QiQecvdwSwlGbt Tp8nLmuDLOv48lA8uS3E7Ng/QuaoSUoyWv5duojdO+pf3poxB1Ynb3OIEVPL4mzJEAub /GEjPWGy1veq8W4KPKwjhpXPGDQIV0LrSAvP+nh9eUxf6s8aFzi+pQn9GEM25trNjWBm +kyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779312876; x=1779917676; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dOHplUY4YxSEbwAdUtwP8OIXWY9Sz4byjeqRgy2OfZQ=; b=K3sdMZRgPW0rfIfzIP0Mt5KIRRxmHaSy1ClE8tLSkOPO6a6nkmm6Y1PhDfh8NWMBZx EhkEVfAdxLp4sNEtZk45+gWmtduVr7vanGmmZtGRj/mi4ev6+I3b0HfvoP5vk9HPlf67 Yc6bzBS5LAcIpgJl26XBLkC/nnOTWnzbx80LgcUTl4p+kmImEaUg9hsMkyRpVMtt+fhs EJk0JJ+/IygMVxqviI5cHJq7Hu9mds84SLBXrzOPq99EBj7LQe6nuf15CkFqOs9ayjHI /VzAAuPTpYRvYzn83P4MTuwJ4Y1pscenVQrmMcNhoz0ysTRQPmKdj0TI6dPFA0tHpjRk 2UBw== X-Gm-Message-State: AOJu0YyPaZgeyNqplEuPWYJCCkmaeHF4ChGatTBKib5B/zbKt1U/Puyy a0ISR+0DvgvckxJCeH8EMQU59k7AvyFALhGXMrmBw8DwJdgQUixvXsuRiOmOKlZ9zcAamGgoIpy J4PI7yNuuDh37gtQfAGSDL49WbDtVoWmXzTBrPTmqjwzy+UmUqFi3JVYXksa5+7zmUWVajQAxGX l9x4I2l3h0hcFDd/5aSObZqaSNE0vQ+KMXMANszA== X-Gm-Gg: Acq92OG9C4P3j0wkwrYMh4mgOrjesdtJDrOVCCAhGzXe7WISb3lbKIhHCf7/833gNqu GEmwPTtOyF8ew9fKb0OAJl0ZeBphJD9+T8zHTAd5h/rDxDZKjaUtfaIPGSbxFx91ZLaIaUFeqFT 3Eaad2ZuU0NGstrsUdhukCwOjWty1Uif92rIy62hFD8lkar8z8tRaEVI95PmYpjS+ZWDDrGp7/p YE23bgRXDRjBxYTyUHd4YkaJcK6JxuqIisWba0TlWSf9XAWVXn84uk4fx1UkrAJw1B05G+9zd0p HA+7RoVBzxgmXX0WtdvSDAaavGp2QZvFWk1K/xvM0oTiqmUVtSNA3f9YYS9NgT9LcJUuhei9W/y sbrHH/lo86/q8zhR9nbt3HL/iHhC/xyp+lpB743scbTqHJAUMjiJUPAw= X-Received: by 2002:a05:6214:568e:b0:8be:3c37:5e6a with SMTP id 6a1803df08f44-8cc6e327f92mr5364996d6.21.1779312876030; Wed, 20 May 2026 14:34:36 -0700 (PDT) X-Received: by 2002:a05:6214:568e:b0:8be:3c37:5e6a with SMTP id 6a1803df08f44-8cc6e327f92mr5363966d6.21.1779312875327; Wed, 20 May 2026 14:34:35 -0700 (PDT) From: Peter Xu To: qemu-devel@nongnu.org Cc: Fabiano Rosas , Peter Xu , Lukas Straub Subject: [PULL 13/29] tests/qtest/migration: Defer by default in precopy_common Date: Wed, 20 May 2026 17:33:41 -0400 Message-ID: <20260520213357.40646-14-peterx@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260520213357.40646-1-peterx@redhat.com> References: <20260520213357.40646-1-peterx@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1779313012643158500 Content-Type: text/plain; charset="utf-8" From: Fabiano Rosas As a design direction, we're restricting the usage of the command line option -incoming . The alternative -incoming defer should be used instead. Make all precopy_common tests defer by default. Using the defer option means that QEMU will not start the incoming migration automatically. Add the incoming QMP command. With the added command, the invocation at the multifd_common hook becomes redundant, so remove it. Signed-off-by: Fabiano Rosas Reviewed-by: Peter Xu Reviewed-by: Lukas Straub Tested-by: Lukas Straub Link: https://lore.kernel.org/r/20260505160915.25558-8-farosas@suse.de Signed-off-by: Peter Xu --- tests/qtest/migration/colo-tests.c | 12 ++++-------- tests/qtest/migration/compression-tests.c | 6 ------ tests/qtest/migration/framework.c | 15 ++++++++------- tests/qtest/migration/precopy-tests.c | 11 +---------- tests/qtest/migration/tls-tests.c | 15 +-------------- 5 files changed, 14 insertions(+), 45 deletions(-) diff --git a/tests/qtest/migration/colo-tests.c b/tests/qtest/migration/col= o-tests.c index ef880f5114..4add4a014b 100644 --- a/tests/qtest/migration/colo-tests.c +++ b/tests/qtest/migration/colo-tests.c @@ -45,7 +45,7 @@ static int test_colo_common(MigrateCommon *args, args->start.caps[MIGRATION_CAPABILITY_RETURN_PATH] =3D true; args->start.caps[MIGRATION_CAPABILITY_X_COLO] =3D true; =20 - if (migrate_start(&from, &to, args->listen_uri, &args->start)) { + if (migrate_start(&from, &to, "defer", &args->start)) { return -1; } =20 @@ -55,6 +55,8 @@ static int test_colo_common(MigrateCommon *args, data_hook =3D args->start_hook(from, to); } =20 + migrate_incoming_qmp(to, args->listen_uri, NULL, "{}"); + migrate_ensure_converge(from); wait_for_serial("src_serial"); =20 @@ -107,17 +109,11 @@ static void test_colo_plain_common(MigrateCommon *arg= s, test_colo_common(args, failover_during_checkpoint, primary_failover); } =20 -static void *hook_start_multifd(QTestState *from, QTestState *to) -{ - return migrate_hook_start_precopy_tcp_multifd_common(from, to, "none"); -} - static void test_colo_multifd_common(MigrateCommon *args, bool failover_during_checkpoint, bool primary_failover) { - args->listen_uri =3D "defer"; - args->start_hook =3D hook_start_multifd; + args->listen_uri =3D "tcp:127.0.0.1:0"; args->start.caps[MIGRATION_CAPABILITY_MULTIFD] =3D true; test_colo_common(args, failover_during_checkpoint, primary_failover); } diff --git a/tests/qtest/migration/compression-tests.c b/tests/qtest/migrat= ion/compression-tests.c index 7f2856b7f8..134bf44db6 100644 --- a/tests/qtest/migration/compression-tests.c +++ b/tests/qtest/migration/compression-tests.c @@ -33,7 +33,6 @@ migrate_hook_start_precopy_tcp_multifd_zstd(QTestState *f= rom, =20 static void test_multifd_tcp_zstd(char *name, MigrateCommon *args) { - args->listen_uri =3D "defer"; args->start_hook =3D migrate_hook_start_precopy_tcp_multifd_zstd; =20 args->start.caps[MIGRATION_CAPABILITY_MULTIFD] =3D true; @@ -43,7 +42,6 @@ static void test_multifd_tcp_zstd(char *name, MigrateComm= on *args) =20 static void test_multifd_postcopy_tcp_zstd(char *name, MigrateCommon *args) { - args->listen_uri =3D "defer"; args->start_hook =3D migrate_hook_start_precopy_tcp_multifd_zstd, =20 args->start.caps[MIGRATION_CAPABILITY_MULTIFD] =3D true; @@ -66,7 +64,6 @@ migrate_hook_start_precopy_tcp_multifd_qatzip(QTestState = *from, =20 static void test_multifd_tcp_qatzip(char *name, MigrateCommon *args) { - args->listen_uri =3D "defer"; args->start_hook =3D migrate_hook_start_precopy_tcp_multifd_qatzip; =20 args->start.caps[MIGRATION_CAPABILITY_MULTIFD] =3D true; @@ -85,7 +82,6 @@ migrate_hook_start_precopy_tcp_multifd_qpl(QTestState *fr= om, =20 static void test_multifd_tcp_qpl(char *name, MigrateCommon *args) { - args->listen_uri =3D "defer"; args->start_hook =3D migrate_hook_start_precopy_tcp_multifd_qpl; =20 args->start.caps[MIGRATION_CAPABILITY_MULTIFD] =3D true; @@ -104,7 +100,6 @@ migrate_hook_start_precopy_tcp_multifd_uadk(QTestState = *from, =20 static void test_multifd_tcp_uadk(char *name, MigrateCommon *args) { - args->listen_uri =3D "defer"; args->start_hook =3D migrate_hook_start_precopy_tcp_multifd_uadk; =20 args->start.caps[MIGRATION_CAPABILITY_MULTIFD] =3D true; @@ -152,7 +147,6 @@ migrate_hook_start_precopy_tcp_multifd_zlib(QTestState = *from, =20 static void test_multifd_tcp_zlib(char *name, MigrateCommon *args) { - args->listen_uri =3D "defer"; args->start_hook =3D migrate_hook_start_precopy_tcp_multifd_zlib; =20 args->start.caps[MIGRATION_CAPABILITY_MULTIFD] =3D true; diff --git a/tests/qtest/migration/framework.c b/tests/qtest/migration/fram= ework.c index 566437c17f..5da39eac76 100644 --- a/tests/qtest/migration/framework.c +++ b/tests/qtest/migration/framework.c @@ -834,11 +834,15 @@ int test_precopy_common(MigrateCommon *args) void *data_hook =3D NULL; QObject *channels =3D NULL; =20 - if (!args->listen_uri) { + assert(!args->connect_uri); + + if (args->listen_uri) { + args->connect_uri =3D args->listen_uri; + } else { args->listen_uri =3D "tcp:127.0.0.1:0"; } =20 - if (migrate_start(&from, &to, args->listen_uri, &args->start)) { + if (migrate_start(&from, &to, "defer", &args->start)) { return -1; } =20 @@ -846,6 +850,8 @@ int test_precopy_common(MigrateCommon *args) data_hook =3D args->start_hook(from, to); } =20 + migrate_incoming_qmp(to, args->listen_uri, NULL, "{}"); + /* Wait for the first serial output from the source */ if (args->result =3D=3D MIG_TEST_SUCCEED) { wait_for_serial("src_serial"); @@ -943,7 +949,6 @@ void test_precopy_unix_common(MigrateCommon *args) g_autofree char *uri =3D g_strdup_printf("unix:%s/migsocket", tmpfs); =20 args->listen_uri =3D uri; - args->connect_uri =3D uri; test_precopy_common(args); } =20 @@ -1064,10 +1069,6 @@ void *migrate_hook_start_precopy_tcp_multifd_common(= QTestState *from, { migrate_set_parameter_str(from, "multifd-compression", method); migrate_set_parameter_str(to, "multifd-compression", method); - - /* Start incoming migration from the 1st socket */ - migrate_incoming_qmp(to, "tcp:127.0.0.1:0", NULL, "{}"); - return NULL; } =20 diff --git a/tests/qtest/migration/precopy-tests.c b/tests/qtest/migration/= precopy-tests.c index 377597bc29..b73b73a807 100644 --- a/tests/qtest/migration/precopy-tests.c +++ b/tests/qtest/migration/precopy-tests.c @@ -162,7 +162,6 @@ static void __test_precopy_rdma_plain(MigrateCommon *ar= gs, bool ipv6) g_autofree char *uri =3D g_strdup_printf("rdma:%s:29200", buffer); =20 args->listen_uri =3D uri; - args->connect_uri =3D uri; =20 test_precopy_common(args); } @@ -214,9 +213,6 @@ static void *migrate_hook_start_fd(QTestState *from, " 'arguments': { 'fdname': 'fd-mig' }}"); close(pair[0]); =20 - /* Start incoming migration from the 1st socket */ - migrate_incoming_qmp(to, "fd:fd-mig", NULL, "{}"); - /* Send the 2nd socket to the target */ qtest_qmp_fds_assert_success(from, &pair[1], 1, "{ 'execute': 'getfd'," @@ -257,8 +253,7 @@ static void migrate_hook_end_fd(QTestState *from, =20 static void test_precopy_fd_socket(char *name, MigrateCommon *args) { - args->listen_uri =3D "defer"; - args->connect_uri =3D "fd:fd-mig"; + args->listen_uri =3D "fd:fd-mig"; args->start_hook =3D migrate_hook_start_fd; args->end_hook =3D migrate_hook_end_fd; =20 @@ -354,7 +349,6 @@ migrate_hook_start_precopy_tcp_multifd_no_zero_page(QTe= stState *from, =20 static void test_multifd_tcp_uri_none(char *name, MigrateCommon *args) { - args->listen_uri =3D "defer"; args->start_hook =3D migrate_hook_start_precopy_tcp_multifd; /* * Multifd is more complicated than most of the features, it @@ -370,7 +364,6 @@ static void test_multifd_tcp_uri_none(char *name, Migra= teCommon *args) =20 static void test_multifd_tcp_zero_page_legacy(char *name, MigrateCommon *a= rgs) { - args->listen_uri =3D "defer"; args->start_hook =3D migrate_hook_start_precopy_tcp_multifd_zero_page_= legacy; /* * Multifd is more complicated than most of the features, it @@ -386,7 +379,6 @@ static void test_multifd_tcp_zero_page_legacy(char *nam= e, MigrateCommon *args) =20 static void test_multifd_tcp_no_zero_page(char *name, MigrateCommon *args) { - args->listen_uri =3D "defer"; args->start_hook =3D migrate_hook_start_precopy_tcp_multifd_no_zero_pa= ge; /* * Multifd is more complicated than most of the features, it @@ -402,7 +394,6 @@ static void test_multifd_tcp_no_zero_page(char *name, M= igrateCommon *args) =20 static void test_multifd_tcp_channels_none(char *name, MigrateCommon *args) { - args->listen_uri =3D "defer"; args->start_hook =3D migrate_hook_start_precopy_tcp_multifd; args->live =3D true; args->connect_channels =3D ("[ { 'channel-type': 'main'," diff --git a/tests/qtest/migration/tls-tests.c b/tests/qtest/migration/tls-= tests.c index 4a3c404349..275d0b84d4 100644 --- a/tests/qtest/migration/tls-tests.c +++ b/tests/qtest/migration/tls-tests.c @@ -436,8 +436,7 @@ static void test_precopy_unix_tls_x509_default_host(cha= r *name, { g_autofree char *uri =3D g_strdup_printf("unix:%s/migsocket", tmpfs); =20 - args->connect_uri =3D uri; - args->listen_uri =3D "defer"; + args->listen_uri =3D uri; args->start_hook =3D migrate_hook_start_tls_x509_default_host; args->end_hook =3D migrate_hook_end_tls_x509; args->result =3D MIG_TEST_FAIL; @@ -511,8 +510,6 @@ migrate_hook_start_tls_x509_no_host(QTestState *from, Q= TestState *to) =20 static void test_precopy_tcp_tls_no_hostname(char *name, MigrateCommon *ar= gs) { - args->listen_uri =3D "defer"; - args->connect_uri =3D "tcp:127.0.0.1:0"; args->start_hook =3D migrate_hook_start_tls_x509_no_host; args->end_hook =3D migrate_hook_end_tls_x509; args->result =3D MIG_TEST_FAIL; @@ -544,8 +541,6 @@ static void test_precopy_tcp_tls_x509_override_host(cha= r *name, static void test_precopy_tcp_tls_x509_mismatch_host(char *name, MigrateCommon *args) { - args->listen_uri =3D "defer"; - args->connect_uri =3D "tcp:127.0.0.1:0"; args->start_hook =3D migrate_hook_start_tls_x509_mismatch_host; args->end_hook =3D migrate_hook_end_tls_x509; args->result =3D MIG_TEST_FAIL; @@ -658,7 +653,6 @@ migrate_hook_start_multifd_tls_x509_reject_anon_client(= QTestState *from, =20 static void test_multifd_tcp_tls_psk_match(char *name, MigrateCommon *args) { - args->listen_uri =3D "defer"; args->start_hook =3D migrate_hook_start_multifd_tcp_tls_psk_match; args->end_hook =3D migrate_hook_end_tls_psk; =20 @@ -669,7 +663,6 @@ static void test_multifd_tcp_tls_psk_match(char *name, = MigrateCommon *args) =20 static void test_multifd_tcp_tls_psk_mismatch(char *name, MigrateCommon *a= rgs) { - args->listen_uri =3D "defer"; args->start_hook =3D migrate_hook_start_multifd_tcp_tls_psk_mismatch; args->end_hook =3D migrate_hook_end_tls_psk; args->result =3D MIG_TEST_FAIL; @@ -683,7 +676,6 @@ static void test_multifd_tcp_tls_psk_mismatch(char *nam= e, MigrateCommon *args) static void test_multifd_postcopy_tcp_tls_psk_match(char *name, MigrateCommon *args) { - args->listen_uri =3D "defer"; args->start_hook =3D migrate_hook_start_multifd_tcp_tls_psk_match; args->end_hook =3D migrate_hook_end_tls_psk; =20 @@ -697,7 +689,6 @@ static void test_multifd_postcopy_tcp_tls_psk_match(cha= r *name, static void test_multifd_tcp_tls_x509_default_host(char *name, MigrateCommon *args) { - args->listen_uri =3D "defer"; args->start_hook =3D migrate_hook_start_multifd_tls_x509_default_host; args->end_hook =3D migrate_hook_end_tls_x509; =20 @@ -709,7 +700,6 @@ static void test_multifd_tcp_tls_x509_default_host(char= *name, static void test_multifd_tcp_tls_x509_override_host(char *name, MigrateCommon *args) { - args->listen_uri =3D "defer"; args->start_hook =3D migrate_hook_start_multifd_tls_x509_override_host; args->end_hook =3D migrate_hook_end_tls_x509; =20 @@ -734,7 +724,6 @@ static void test_multifd_tcp_tls_x509_mismatch_host(cha= r *name, * to load migration state, and thus just aborts the migration * without exiting. */ - args->listen_uri =3D "defer"; args->start_hook =3D migrate_hook_start_multifd_tls_x509_mismatch_host; args->end_hook =3D migrate_hook_end_tls_x509; args->result =3D MIG_TEST_FAIL; @@ -748,7 +737,6 @@ static void test_multifd_tcp_tls_x509_mismatch_host(cha= r *name, static void test_multifd_tcp_tls_x509_allow_anon_client(char *name, MigrateCommon *arg= s) { - args->listen_uri =3D "defer"; args->start_hook =3D migrate_hook_start_multifd_tls_x509_allow_anon_cl= ient; args->end_hook =3D migrate_hook_end_tls_x509; =20 @@ -760,7 +748,6 @@ static void test_multifd_tcp_tls_x509_allow_anon_client= (char *name, static void test_multifd_tcp_tls_x509_reject_anon_client(char *name, MigrateCommon *ar= gs) { - args->listen_uri =3D "defer"; args->start_hook =3D migrate_hook_start_multifd_tls_x509_reject_anon_c= lient; args->end_hook =3D migrate_hook_end_tls_x509; args->result =3D MIG_TEST_FAIL; --=20 2.53.0