From: Fabiano Rosas <farosas@suse.de>
Using a localhost TCP URI for testing is quite common. Set it as a
default for precopy tests that don't provide an URI.
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Peter Xu <peterx@redhat.com>
Link: https://lore.kernel.org/r/20260505160915.25558-7-farosas@suse.de
Signed-off-by: Peter Xu <peterx@redhat.com>
---
tests/qtest/migration/framework.c | 4 ++++
tests/qtest/migration/precopy-tests.c | 3 ---
tests/qtest/migration/tls-tests.c | 9 ---------
3 files changed, 4 insertions(+), 12 deletions(-)
diff --git a/tests/qtest/migration/framework.c b/tests/qtest/migration/framework.c
index 1d13b897a9..566437c17f 100644
--- a/tests/qtest/migration/framework.c
+++ b/tests/qtest/migration/framework.c
@@ -834,6 +834,10 @@ int test_precopy_common(MigrateCommon *args)
void *data_hook = NULL;
QObject *channels = NULL;
+ if (!args->listen_uri) {
+ args->listen_uri = "tcp:127.0.0.1:0";
+ }
+
if (migrate_start(&from, &to, args->listen_uri, &args->start)) {
return -1;
}
diff --git a/tests/qtest/migration/precopy-tests.c b/tests/qtest/migration/precopy-tests.c
index 849aef3ed6..377597bc29 100644
--- a/tests/qtest/migration/precopy-tests.c
+++ b/tests/qtest/migration/precopy-tests.c
@@ -180,14 +180,11 @@ static void test_precopy_rdma_plain_ipv6(char *name, MigrateCommon *args)
static void test_precopy_tcp_plain(char *name, MigrateCommon *args)
{
- args->listen_uri = "tcp:127.0.0.1:0";
-
test_precopy_common(args);
}
static void test_precopy_tcp_switchover_ack(char *name, MigrateCommon *args)
{
- args->listen_uri = "tcp:127.0.0.1:0";
/*
* Source VM must be running in order to consider the switchover ACK
* when deciding to do switchover or not.
diff --git a/tests/qtest/migration/tls-tests.c b/tests/qtest/migration/tls-tests.c
index 0677ca661e..4a3c404349 100644
--- a/tests/qtest/migration/tls-tests.c
+++ b/tests/qtest/migration/tls-tests.c
@@ -459,7 +459,6 @@ static void test_precopy_unix_tls_x509_override_host(char *name,
static void test_precopy_tcp_tls_psk_match(char *name, MigrateCommon *args)
{
- args->listen_uri = "tcp:127.0.0.1:0";
args->start_hook = migrate_hook_start_tls_psk_match;
args->end_hook = migrate_hook_end_tls_psk;
@@ -468,7 +467,6 @@ static void test_precopy_tcp_tls_psk_match(char *name, MigrateCommon *args)
static void test_precopy_tcp_tls_psk_mismatch(char *name, MigrateCommon *args)
{
- args->listen_uri = "tcp:127.0.0.1:0";
args->start_hook = migrate_hook_start_tls_psk_mismatch;
args->end_hook = migrate_hook_end_tls_psk;
args->result = MIG_TEST_FAIL;
@@ -488,7 +486,6 @@ static void *migrate_hook_start_no_tls(QTestState *from, QTestState *to)
static void test_precopy_tcp_no_tls(char *name, MigrateCommon *args)
{
- args->listen_uri = "tcp:127.0.0.1:0";
args->start_hook = migrate_hook_start_no_tls;
/* the no_tls start hook requires no cleanup actions */
args->end_hook = NULL;
@@ -529,7 +526,6 @@ static void test_precopy_tcp_tls_no_hostname(char *name, MigrateCommon *args)
static void test_precopy_tcp_tls_x509_default_host(char *name,
MigrateCommon *args)
{
- args->listen_uri = "tcp:127.0.0.1:0";
args->start_hook = migrate_hook_start_tls_x509_default_host;
args->end_hook = migrate_hook_end_tls_x509;
@@ -539,7 +535,6 @@ static void test_precopy_tcp_tls_x509_default_host(char *name,
static void test_precopy_tcp_tls_x509_override_host(char *name,
MigrateCommon *args)
{
- args->listen_uri = "tcp:127.0.0.1:0";
args->start_hook = migrate_hook_start_tls_x509_override_host;
args->end_hook = migrate_hook_end_tls_x509;
@@ -563,7 +558,6 @@ static void test_precopy_tcp_tls_x509_mismatch_host(char *name,
static void test_precopy_tcp_tls_x509_friendly_client(char *name,
MigrateCommon *args)
{
- args->listen_uri = "tcp:127.0.0.1:0";
args->start_hook = migrate_hook_start_tls_x509_friendly_client;
args->end_hook = migrate_hook_end_tls_x509;
@@ -573,7 +567,6 @@ static void test_precopy_tcp_tls_x509_friendly_client(char *name,
static void test_precopy_tcp_tls_x509_hostile_client(char *name,
MigrateCommon *args)
{
- args->listen_uri = "tcp:127.0.0.1:0";
args->start_hook = migrate_hook_start_tls_x509_hostile_client;
args->end_hook = migrate_hook_end_tls_x509;
args->result = MIG_TEST_FAIL;
@@ -586,7 +579,6 @@ static void test_precopy_tcp_tls_x509_hostile_client(char *name,
static void test_precopy_tcp_tls_x509_allow_anon_client(char *name,
MigrateCommon *args)
{
- args->listen_uri = "tcp:127.0.0.1:0";
args->start_hook = migrate_hook_start_tls_x509_allow_anon_client;
args->end_hook = migrate_hook_end_tls_x509;
@@ -596,7 +588,6 @@ static void test_precopy_tcp_tls_x509_allow_anon_client(char *name,
static void test_precopy_tcp_tls_x509_reject_anon_client(char *name,
MigrateCommon *args)
{
- args->listen_uri = "tcp:127.0.0.1:0";
args->start_hook = migrate_hook_start_tls_x509_reject_anon_client;
args->end_hook = migrate_hook_end_tls_x509;
args->result = MIG_TEST_FAIL;
--
2.53.0