From nobody Sat May 30 18:34:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1779265577; cv=none; d=zohomail.com; s=zohoarc; b=CC2YqzJzF3UA1s96u4kgWvZ9UOwn12mgSzoR9Tf98wXmfZI5Kh8Zc3boIkYGlT+QRh5IJDFkubbt7SCQ59Y0IHG9I2xIf54pCJahB7Q138IFcxMpAb8cLyPj8Q+0iEBhfpkunpAUdYkp/c3HyVq2255ZoKkaPmBSG2gGZKtfr6w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779265577; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=GoJTCndkOEu+XgqdJ0Z/Yka2EHwqV8tzCu2ovOWfxNU=; b=jg36Ww6Fd0SZVLvHflivwKS/AGKrj0KIDBtOzAPn4O8BvhuMw6TK03gbEszoFb50UxyCNDVpqzDYyxuKDewPsgbw+kUQbEo55OKnltM5w/UUdubCPpl8bdOXsM9f+8il9phArOqUqXu87XHRRMNJeFmCuc55y3cpoV1i2k8RZ7w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1779265577663779.4646507391006; Wed, 20 May 2026 01:26:17 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wPcFF-0002V3-Af; Wed, 20 May 2026 04:25:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wPcFB-0002UK-DV for qemu-devel@nongnu.org; Wed, 20 May 2026 04:25:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wPcF9-00030m-Dh for qemu-devel@nongnu.org; Wed, 20 May 2026 04:25:33 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-333-hj5kJKXONrCbkByI93k0Eg-1; Wed, 20 May 2026 04:25:25 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 80BEB19560B0; Wed, 20 May 2026 08:25:24 +0000 (UTC) Received: from berrange.com (unknown [10.44.49.211]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 729901687; Wed, 20 May 2026 08:25:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779265529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GoJTCndkOEu+XgqdJ0Z/Yka2EHwqV8tzCu2ovOWfxNU=; b=JWjhr2X0ML+kLEXYvH/JMiux1VDyxEXqSVH/e/2PyNB4wC1NI2uElcADvZGHCCLmXKAafv +dlTkgkiRsGICXbb2VH/nHIsRSVF0KEr9fhfwmi+PBGRJ4beb792t5wwV6K4ILoxuZUc1Y L9JASJ5rBxdmDMIKKlFVPLD9WF6HstM= X-MC-Unique: hj5kJKXONrCbkByI93k0Eg-1 X-Mimecast-MFC-AGG-ID: hj5kJKXONrCbkByI93k0Eg_1779265524 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: John Levon , Thanos Makatos , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH] hw/vfio-user: use a valid object ID for iothread Date: Wed, 20 May 2026 09:25:00 +0100 Message-ID: <20260520082459.1132051-2-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1779265580486154100 The objectg_new_with_propv/props methods failed to validate that the QOM "id" was well formed. This allowed the vfio-user code to use an invalid ID of "VFIO user" (space is not permitted) in its internal code. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: John Levon Reviewed-by: Mark Cave-Ayland --- hw/vfio-user/proxy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/vfio-user/proxy.c b/hw/vfio-user/proxy.c index 314dfd23d8..3d0d72e8b7 100644 --- a/hw/vfio-user/proxy.c +++ b/hw/vfio-user/proxy.c @@ -933,7 +933,7 @@ VFIOUserProxy *vfio_user_connect_dev(SocketAddress *add= r, Error **errp) qemu_cond_init(&proxy->close_cv); =20 if (vfio_user_iothread =3D=3D NULL) { - vfio_user_iothread =3D iothread_create("VFIO user", errp); + vfio_user_iothread =3D iothread_create("vfio-user", errp); } =20 proxy->ctx =3D iothread_get_aio_context(vfio_user_iothread); --=20 2.54.0