From nobody Sat May 30 18:34:27 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1779125193; cv=none; d=zohomail.com; s=zohoarc; b=IxlGAdSqaoh3HeNPEHt31BuK6AmocrkXla2WogZKUoTsn0KvV0QL88tzdNA/iom6TvsDpH3nHRnoWPZTYCubXn651TZMUyl1TZVF6UC9ICmEOQ9Qp9GNtRmER3Rvj1Gfq2BH1ZAPwul5IofojTEut+ALm0WXdTfsFZoKBI6b/lk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779125193; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9o+ZPd+Dq5mzDzpO+zbMazocWrqDmu+Ib19Mxw1Xvdk=; b=FvgsX40zqlS1vxwZkgM80ZBpz1gSZvahw075NOllszHUOyblix8XV0r4qkW26g5eomdpVTSxsa3Y9TMQ+nA7wBDkHlrF6m9TNxyVUvBLQfgQ6p0NPjVLvPGouozzSYrfktdaXGWoh3rbjm/zd4GM0ScAODImV8kGqS/oFpK6IdE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1779125193529204.46043082166955; Mon, 18 May 2026 10:26:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wP1j4-0007pW-P8; Mon, 18 May 2026 13:25:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wP1iz-0007ns-4u; Mon, 18 May 2026 13:25:55 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wP1is-0005Ez-8t; Mon, 18 May 2026 13:25:50 -0400 Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64IB9VHA1950620; Mon, 18 May 2026 17:25:44 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4e6h888rsj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 May 2026 17:25:44 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 64IHO9p0000992; Mon, 18 May 2026 17:25:43 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4e739vq3nt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 May 2026 17:25:43 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 64IHPdcI38994218 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 18 May 2026 17:25:39 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B50D720043; Mon, 18 May 2026 17:25:39 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CD65120040; Mon, 18 May 2026 17:25:36 +0000 (GMT) Received: from localhost.localdomain (unknown [9.39.29.56]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 18 May 2026 17:25:36 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=9o+ZPd+Dq5mzDzpO+ zbMazocWrqDmu+Ib19Mxw1Xvdk=; b=KPPTCmthLF3UG9amFItvKZSpiUh/1BV5z oo9oXZpY2+HvFlS3abbT8gt7md2Y6Lz9HGbutmv1Qw21gHs4cmNU63n2GM1glRzC 4yHe7o+EXtip1SxcU/dyxAkhUob3qkMf+4SLZ/+F5Z9qF/9cdKLI72zguAE+RnY4 LpKTP7PYkAIHDpbeZrF+vsusQZcxk/qCaRnQTYnXYxPJJaGZluN1FFLdxtTCZW9f 7JyYGrKiS+DKGCBBqpfBtrADvQPHiF8DUC603wEyTj1C0Ly1a9TLRf4T/B4qoT7C j+KF6JMfQALena2Ct+VrrGqVQAcvwTY63WXbvQ2YQasL6W0rx1HHg== From: Amit Machhiwal To: Harsh Prateek Bora , qemu-ppc@nongnu.org Cc: Amit Machhiwal , Vaibhav Jain , Nicholas Piggin , Chinmay Rath , Glenn Miles , Paolo Bonzini , qemu-devel@nongnu.org, kvm@vger.kernel.org, Shivaprasad G Bhat , Gautam Menghani Subject: [PATCH v3 1/2] target/ppc/kvm: Fix const violation when trimming CPU alias suffix Date: Mon, 18 May 2026 22:55:15 +0530 Message-ID: <20260518172517.12466-2-amachhiw@linux.ibm.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260518172517.12466-1-amachhiw@linux.ibm.com> References: <20260518172517.12466-1-amachhiw@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-ORIG-GUID: 9mUzMzoX7csFzem3tPuVm1nrS4J8QxBe X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE4MDE2OCBTYWx0ZWRfX+2uxiwIomGgA 8Skn3c4GSv0gU+WCS/rAU1E8JlnVk0S2h5xQpUHSedVWZN7J31cfNWKEgQmp59+7HnzYK2emDXS 4nv9B2oOPsW8vXcvNHL6pjofwzh/LgrBGyWOD0XTLDPssrUmcssHGt1g3gdvD3amMKBPQPubkit cuw679wHdz0oya6S5OI80uUWM4pbY/+A5gYtxwEhJyon3P9Fomcjft4cXwOv2X1vAgr8XhRheWX k0jGITARRv8T7Ome2ja5ZHmBs/md3Vf+h/h/w/8bGkf24e0qzG/M73ZViQpJ+85ieLiyGXQac37 3Y6kvilbm4lulokSdhK/iBvPcxJBQ/Zis4xPvNOGAqpmZOQEdirIS9oFy9Jl0KgroeWOvdJ4lPr 5mL+XxAmYVgrRqCOP7F5+iMJi2kwDsIwJQwC4EH+CqqBKNb/8WsJxVQMm5u2BnI1/4SaOTf740f x/CnAI2OozYVWzy0jwA== X-Proofpoint-GUID: amO-cARgsXVXDVNCRP8vYc6cb1FUsc8t X-Authority-Analysis: v=2.4 cv=apyCzyZV c=1 sm=1 tr=0 ts=6a0b4b98 cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=VnNF1IyMAAAA:8 a=AeOTFisfVSLvIChBu_YA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-18_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 suspectscore=0 adultscore=0 spamscore=0 phishscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605180168 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=148.163.158.5; envelope-from=amachhiw@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1779125195900158500 Content-Type: text/plain; charset="utf-8" GCC 16 tightens diagnostics around const correctness and now correctly rejects attempts to modify strings referenced through const-qualified pointers. In kvm_ppc_register_host_cpu_type(), ppc_cpu_aliases[i].model is defined as const char *, but the code was using strstr() on it and then modifying the returned pointer in-place to strip POWERPC_CPU_TYPE_SUFFIX. This results in a write through a pointer derived from const data, triggering a build failure with GCC 16: error: assignment discards 'const' qualifier from pointer target type [-W= error=3Ddiscarded-qualifiers] suffix =3D strstr(ppc_cpu_aliases[i].model, POWERPC_CPU_TYPE_SUFFIX= ); ^ Fix this by changing suffix to 'const gchar *' and using g_strstr_len() to locate the suffix, then allocating a new string with g_strndup() (to copy only the prefix) or g_strdup() (to copy the entire name if no suffix exists). This maintains const correctness throughout while preserving the original functionality. No functional change intended. Signed-off-by: Vaibhav Jain Signed-off-by: Amit Machhiwal Reviewed-by: Aditya Gupta Tested-by: Anushree Mathur --- target/ppc/kvm.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 25c28ad089c6..b94c2997a07f 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -2654,13 +2654,12 @@ static int kvm_ppc_register_host_cpu_type(void) dc =3D DEVICE_CLASS(ppc_cpu_get_family_class(pvr_pcc)); for (i =3D 0; ppc_cpu_aliases[i].alias !=3D NULL; i++) { if (g_ascii_strcasecmp(ppc_cpu_aliases[i].alias, dc->desc) =3D=3D = 0) { - char *suffix; + const gchar *suffix, *cname =3D object_class_get_name(oc); + + suffix =3D g_strstr_len(cname, -1, POWERPC_CPU_TYPE_SUFFIX); + ppc_cpu_aliases[i].model =3D suffix ? + g_strndup(cname, (gsize)(suffix - cname)) : g_strdup(cname= ); =20 - ppc_cpu_aliases[i].model =3D g_strdup(object_class_get_name(oc= )); - suffix =3D strstr(ppc_cpu_aliases[i].model, POWERPC_CPU_TYPE_S= UFFIX); - if (suffix) { - *suffix =3D 0; - } break; } } --=20 2.50.1 (Apple Git-155) From nobody Sat May 30 18:34:27 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1779125211; cv=none; d=zohomail.com; s=zohoarc; b=MqVlxZtMFKu4fB2NkdYoGx4UzjY9LVu7zpsYwFKp45sIHmUudEbBIaOZdnZek3mTquIM9JKbaxtT7dzElL6f362nAfSxYDm0jPY7P1FNMfq3w1oyPXXSPWFDjWKrEQIo8m46AnxsyvBUJhOtLNEkIOjLSMRbHYRSno6gNZebL2U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779125211; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=bWrbrH8Gbs1X+3YUyGyMnzOhsFrcZCHun3sMC4y2io8=; b=jvXyHvWH9mWB/1G2ssq4aivSSZ1U1cuuUW96WjjFAv36rwh4UFFHChq2NeflGKiLUXKfNw8NTlHfiKxyPSDpAdPrhAvyobRukvnXPYIQ9+MnJZzz5ygl0KRh8b0BmqeZlsMzFVYPZM2YaVfaLpWHAD334bY9B1A15SsfeT46ytg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1779125211216614.2329727102599; Mon, 18 May 2026 10:26:51 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wP1j6-0007qk-U6; Mon, 18 May 2026 13:26:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wP1j2-0007oc-7M; Mon, 18 May 2026 13:25:57 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wP1iz-0005Le-9Z; Mon, 18 May 2026 13:25:55 -0400 Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64IDLwST1522114; Mon, 18 May 2026 17:25:49 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4e6h9xsafy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 May 2026 17:25:48 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 64IHODWT006900; Mon, 18 May 2026 17:25:47 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4e74dhevva-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 May 2026 17:25:47 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 64IHPhOE19530156 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 18 May 2026 17:25:43 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A65522004D; Mon, 18 May 2026 17:25:43 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E7B2120043; Mon, 18 May 2026 17:25:40 +0000 (GMT) Received: from localhost.localdomain (unknown [9.39.29.56]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 18 May 2026 17:25:40 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=bWrbrH8Gbs1X+3YUy GyMnzOhsFrcZCHun3sMC4y2io8=; b=nr/xNdIQhEzEZwuuhbrUgkh3PPgncpNeI FUEpq16gPx5Cu3xG1JA++0X33d3pbx5K1y0JSuvaKvZTprHhbHLmy7fwIM2FHDzD nSko2hzjnh67kqvMMygmzNFw/4l3wSbUeCiPhoVP1FK+htk9Rp6XMWr1cJ+q+Rpn c1gmDhTw4dUFJf6TGGPajIE0HXbngV6mDGyVfhpLfjYHCnpfiK4xsBzRRZIk/gCJ /L8/S8uH+iSh6L+14AlkEt7NG4CcAWQZP9+wytcMB25hmVELK98tdrbpV7bdverc EjjWKazwUANu8k2n7+4YOxDLrrzUsGFZjZPQXFljvqbQGWYZyiQyA== From: Amit Machhiwal To: Harsh Prateek Bora , qemu-ppc@nongnu.org, Fabiano Rosas , Laurent Vivier Cc: Amit Machhiwal , Vaibhav Jain , Chinmay Rath , Shivaprasad G Bhat , Gautam Menghani , Paolo Bonzini , qemu-devel@nongnu.org Subject: [PATCH v3 2/2] tests/qtest/libqtest: Fix const violation in qtest_verbose() Date: Mon, 18 May 2026 22:55:16 +0530 Message-ID: <20260518172517.12466-3-amachhiw@linux.ibm.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260518172517.12466-1-amachhiw@linux.ibm.com> References: <20260518172517.12466-1-amachhiw@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE4MDE2OCBTYWx0ZWRfX6TePAApzi9PJ r/khQkeM2KYzNTMem6Uv9PtcoJiXRyDSRqDF68MskRO9KX7pUvW+AN5vTcMU5vjmM6S3GnEMu1y z7kBo1aPPfJYEyN4YaQGGabHrm6hcCJPi/FTIAXLMC7o9/SktclY1zyoGwLmW7bKCHUwP8FFgqi Sl8pnyM3tk/ap1BFiYdyvecyAEc1gLC51n7EYxXgnyjx4+xqc4vVLpJJyQ0Hbynqo9eOouET306 hIy9nOrAIYzYsZv8/Y59ABSfn7h9eKvPqnyu+MtBsLa865urQyW0xH19YkiCJ41L86ipRkES3Zu AZeHPdu1RZ7GCvCgc5T6a8eFTo4+GyhsMh7fDTD3YfHr14PCrEtEj00zp21bodxVuJy4fwrH97o Y3kszocgAXHEKYTV9wc7f/3ecVdEuQNvJX120F96ep0nj7/YXpA2HErNQV+W47Uj6qPQthERXPg bQ/OOWeCX9m3UqlAirQ== X-Authority-Analysis: v=2.4 cv=BNuDalQG c=1 sm=1 tr=0 ts=6a0b4b9c cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=iQ6ETzBq9ecOQQE5vZCe:22 a=VnNF1IyMAAAA:8 a=jvbmTW_T06IUh0XMFxoA:9 X-Proofpoint-ORIG-GUID: 5R1BAxSEQDTbegTqlLIBGzJfZE4Z_8sJ X-Proofpoint-GUID: 5R1BAxSEQDTbegTqlLIBGzJfZE4Z_8sJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-18_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605180168 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=148.163.156.1; envelope-from=amachhiw@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1779125213535158500 Content-Type: text/plain; charset="utf-8" GCC 16 tightens const-correctness checking and reports: error: assignment discards 'const' qualifier from pointer target type [-W= error=3Ddiscarded-qualifiers] found =3D strstr(log, domain); ^ in qtest_verbose() because strstr() returns a non-const pointer while operating on a const-qualified string from getenv(). While getenv() returns char *, the returned environment string is semantically treated as read-only. Use g_getenv() and g_strstr_len() so that the local string pointers remain const-qualified throughout. This maintains const correctness throughout and aligns with QEMU's use of GLib string functions. No functional change intended. Signed-off-by: Amit Machhiwal Reviewed-by: Aditya Gupta Tested-by: Anushree Mathur --- tests/qtest/libqtest.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c index bf9284b9a131..cb80ab23182a 100644 --- a/tests/qtest/libqtest.c +++ b/tests/qtest/libqtest.c @@ -2145,8 +2145,7 @@ bool mkimg(const char *file, const char *fmt, unsigne= d size_mb) =20 bool qtest_verbose(const char *domain) { - const char *log =3D getenv("QTEST_LOG"); - char *found; + const gchar *found, *log =3D g_getenv("QTEST_LOG"); =20 assert(domain); =20 @@ -2172,11 +2171,11 @@ bool qtest_verbose(const char *domain) * QTEST_LOG=3D,- (only false for domain2) * allows other separators, except - and + */ - found =3D strstr(log, domain); + found =3D g_strstr_len(log, -1, domain); =20 if (found) { /* reject options given twice */ - assert(!strstr(found + strlen(domain), domain)); + assert(!g_strstr_len(found + strlen(domain), -1, domain)); =20 if (found > log) { ptrdiff_t i =3D found - log - 1; @@ -2190,7 +2189,7 @@ bool qtest_verbose(const char *domain) * If filtering out a specific domain, all others are * enabled. */ - return !!strstr(log, "-"); + return !!g_strstr_len(log, -1, "-"); } } =20 --=20 2.50.1 (Apple Git-155)