From nobody Sat May 30 18:34:27 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1779111666; cv=none; d=zohomail.com; s=zohoarc; b=f/xAe2EB7qyYYrmQdWYpiW6cTlwPRc2iRCXv5O5Y64HO68AFV5TvJotV277c3dAzNWpJYopWyuB/FoYUrbJkumv2XhaJi0V6Pnj4qjjyA6aHhZmoAt4Rw8h0zLuYWQAEEDzxYvnq7zmx4EPKF/tPK2tXxc4EyYVq8uOeugYBD00= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779111666; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=3tOi+raTHMXceLcF0R8H4MmXYsLEwkQ1WQprPeDxA98=; b=cOSg5fB7MYQfwypxdgEkufDijbFXV+8Xwxq4kMFtUbd3rbV0DXA6JgIbU7Iz7typPvMUgvp31zyT9vJI+PaQD6OoBUnGJhlMsXllQgM89VkHdd/j39epHVo1EmNESHc3gYBaheHXtCaXrOy+rgHATXfEQWZl5Q8JAEAflCXjEj0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1779111666567963.7465694820535; Mon, 18 May 2026 06:41:06 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wOyCw-00052y-2X; Mon, 18 May 2026 09:40:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wOyCu-00052d-9b for qemu-devel@nongnu.org; Mon, 18 May 2026 09:40:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wOyCs-0007hi-Q6 for qemu-devel@nongnu.org; Mon, 18 May 2026 09:40:32 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-298-WuBgSzOPM0uXekokzzTMZQ-1; Mon, 18 May 2026 09:40:25 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6E82718002D0; Mon, 18 May 2026 13:40:24 +0000 (UTC) Received: from thuth-p1g4.redhat.corp (headnet01.pony-001.prod.iad2.dc.redhat.com [10.2.32.101]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2E16F19560A2; Mon, 18 May 2026 13:40:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779111629; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=3tOi+raTHMXceLcF0R8H4MmXYsLEwkQ1WQprPeDxA98=; b=VSxFD9AR62smxXewxP9q3iWStIDULQ+3I0E+RJkuOYBnhOqsDIFiDT0222HiX8EJQ9eRdL FyXMfSNdYdrEgSHApPQMG0Q3uzPA15ughSYxZLPOw08TlU2Xbqqw8v52oEC0QcNPxPT3bH k5VBHU4hb8PDrMC99oUmJq0z06Flb5M= X-MC-Unique: WuBgSzOPM0uXekokzzTMZQ-1 X-Mimecast-MFC-AGG-ID: WuBgSzOPM0uXekokzzTMZQ_1779111625 From: Thomas Huth To: Fabiano Rosas , qemu-devel@nongnu.org Cc: Laurent Vivier , Paolo Bonzini , qemu-trivial@nongnu.org Subject: [PATCH] system/qtest: Fix length parameter in the b64write code Date: Mon, 18 May 2026 15:40:20 +0200 Message-ID: <20260518134020.1420932-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1779111668393158500 Content-Type: text/plain; charset="utf-8" From: Thomas Huth The b64write code has a sanity check that the given lengths matches the real length of the given data, and calculates the minimum of the two values to be on the safe side. However, the address_space_write() then uses the original value and ignores the calculated minimum. Use out_len here to fix the problem. Fixes: 70da30483e7 ("qtest: Use cpu address space instead of system memory") Signed-off-by: Thomas Huth Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- system/qtest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/system/qtest.c b/system/qtest.c index a79d10d1361..d6db057b0a2 100644 --- a/system/qtest.c +++ b/system/qtest.c @@ -698,7 +698,7 @@ static void qtest_process_command(CharFrontend *chr, gc= har **words) } =20 address_space_write(first_cpu->as, addr, MEMTXATTRS_UNSPECIFIED, d= ata, - len); + out_len); =20 qtest_send(chr, "OK\n"); } else if (strcmp(words[0], "endianness") =3D=3D 0) { --=20 2.54.0