From nobody Sat May 30 18:34:14 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1779104777; cv=none; d=zohomail.com; s=zohoarc; b=fh/lnf96P+3s3nftexJ7K4B91NmSB5TnXV0SuBRuYkRGBjmJwMnPSyia8/9lx/ukagp1nQfaeoohFS2d/+wywrYFfZ+36jIW6sOVYwDLQ0umyGDg7OuONfW1wzi0zrvi54KhgEm6JgF2bTO8NlcpTYLZkA/AZL3DI6V17fz0VgA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779104777; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=BeP7MqfAFIImF5aeolAeS2ZR22BLSSc3zOo7u4TV5aM=; b=glT9grc5i3fRluPs2TICvON896lvqR9y7C2vYnF0I6aMb/KqNcYMGud5TPB9H/stBOLUfZILAP6Hs5QjpBov5MWvyUvVluuBbUSYa/b5SonzL0n/HwAzBC8etu2ApCl4TkN67FcukRTqUj0Y+uBMFaofuGBegcV+ViQTu7EGAlY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1779104777407553.6493931503908; Mon, 18 May 2026 04:46:17 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wOwPV-0003gK-P0; Mon, 18 May 2026 07:45:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wOwPU-0003e6-SB for qemu-devel@nongnu.org; Mon, 18 May 2026 07:45:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wOwPT-0002LI-Da for qemu-devel@nongnu.org; Mon, 18 May 2026 07:45:24 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-140-y1Kl0RImM8K2TNdEGYwAbA-1; Mon, 18 May 2026 07:45:19 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C61E618005B4; Mon, 18 May 2026 11:45:17 +0000 (UTC) Received: from thuth-p1g4.redhat.corp (headnet01.pony-001.prod.iad2.dc.redhat.com [10.2.32.101]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C07681800370; Mon, 18 May 2026 11:45:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779104722; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=BeP7MqfAFIImF5aeolAeS2ZR22BLSSc3zOo7u4TV5aM=; b=IRkhcfIJiu1W4wRPHz+493jeo4esUJ4FxvpfDQEZ/KPAWD818sEP8Nrj2MSPti9WlPABpO p2L0m107A2jIJSSp+1FJslEPeRJeMHlMSdbn6A0e/qYG+W15J2QQ0gyJTy/+NeFDkqsIDD HPe1micImQStwsSBhMROB7swGm9DwwE= X-MC-Unique: y1Kl0RImM8K2TNdEGYwAbA-1 X-Mimecast-MFC-AGG-ID: y1Kl0RImM8K2TNdEGYwAbA_1779104718 From: Thomas Huth To: Paolo Bonzini , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, f.ebner@proxmox.com, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2] system/vl: Free allocate memory for pid file name in case realpath() failed Date: Mon, 18 May 2026 13:45:14 +0200 Message-ID: <20260518114514.684401-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1779104779385154100 Content-Type: text/plain; charset="utf-8" From: Thomas Huth In case realpath() fails, the code returns early in the function qemu_maybe_daemonize(), without freeing the allocated memory. Add a g_free() here to fix it. And while we're at it, also free the memory in the qemu_unlink_pidfile() function - it's not that important since QEMU is going to terminate anyway, but some malloc sanitizers might still complain if we don't free it. Fixes: dee2a4d4d2f ("vl: defuse PID file path resolve error") Signed-off-by: Thomas Huth Reviewed-by: Fiona Ebner Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- v2: Free memory in qemu_unlink_pidfile(), too system/vl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/system/vl.c b/system/vl.c index d2f4044e5d8..a31b7f87230 100644 --- a/system/vl.c +++ b/system/vl.c @@ -1633,6 +1633,8 @@ static void qemu_unlink_pidfile(Notifier *n, void *da= ta) =20 upn =3D DO_UPCAST(struct UnlinkPidfileNotifier, notifier, n); unlink(upn->pid_file_realpath); + g_free(upn->pid_file_realpath); + upn->pid_file_realpath =3D NULL; } =20 static const QEMUOption *lookup_opt(int argc, char **argv, @@ -2670,6 +2672,7 @@ static void qemu_maybe_daemonize(const char *pid_file) warn_report("not removing PID file on exit: cannot resolve= PID " "file path: %s: %s", pid_file, strerror(errno)= ); } + g_free(pid_file_realpath); return; } =20 --=20 2.54.0