From nobody Mon May 25 13:48:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1778918414; cv=none; d=zohomail.com; s=zohoarc; b=T+cIeu0Faw3s1S5vn7uj/7DAUgRHSYyLLYRrBiVSZKoSxvqFbsKHE/nenSka9wC/KBWBUS0X83Hi/pH7ryPf020MwxR/Fcp7ttNnGk/0BsfPiaM8Iwrp90EU85Yr2E8ajhsmMutFTWqFVgy3YWRXHEfXF5P/z7u/ORY98C9nOv4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778918414; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=YqHaON9sRM1sYUEPXCKTDAIBSwAYfKHnhxW62Uz/IzA=; b=hDnvyp/pTfT/FWcqDLzK14en9iEIiSGRSkiBDZdCEP1e9o5gFXenNF14Asjg7vbJzhj2FyqwZXt4gCTBefZPRh1PkEa4AOC14qc3SKU0NY/8iCGyamPhDuDZGJH90p9XveLT0sp0S6CGOwApe8p3ipGav2KLCb7NU3IZvxMJ5gY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778918414673631.8640816033011; Sat, 16 May 2026 01:00:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wO9vn-0004xe-EB; Sat, 16 May 2026 03:59:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9vl-0004x8-Bb for qemu-devel@nongnu.org; Sat, 16 May 2026 03:59:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9vk-00070V-3Q for qemu-devel@nongnu.org; Sat, 16 May 2026 03:59:29 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-500-IdZXFMHHNYmli2Hvmd7QOQ-1; Sat, 16 May 2026 03:59:24 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 90420195608F for ; Sat, 16 May 2026 07:59:23 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 333D61800349; Sat, 16 May 2026 07:59:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778918367; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YqHaON9sRM1sYUEPXCKTDAIBSwAYfKHnhxW62Uz/IzA=; b=ALBXwURsu+sOswWbQn1vq0ZLR5b4r9ddqaTZTHQYCXygJjb3J8U9XJID9nZTzDjrx8S7cR rPsJwFC7DwGOLVG2FNWjvGGT1fBRaM56f0Sm/cjJTA3JZQ8B+mYeYuFXEzE8GgMYh5nw6m Ng3ER/SVv3xgwOlia0iJ0LatdL4NFOA= X-MC-Unique: IdZXFMHHNYmli2Hvmd7QOQ-1 X-Mimecast-MFC-AGG-ID: IdZXFMHHNYmli2Hvmd7QOQ_1778918363 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 16 May 2026 11:59:00 +0400 Subject: [PATCH v3 01/24] ui/vt100: add vt100_fini() check MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260516-qom-tests-v3-1-3f20c3a029a7@redhat.com> References: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> In-Reply-To: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=731; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=bfEx1K4mAI08LjIUdjB/lCDfLpaBYwml12JdZ6Td3rA=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqCCPOzxbOLCh96lR9HhZSwUlmTdddn+o4yFBH4 llKjNnBqGyJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaggjzgAKCRDa6OEJdZac 5XKYD/4vYIFpRtOjAbyaH6PavxXP2t3rfg2fvqTHlbburoLx+azCNNsfVsQ2294A9YJb9jT6/UI bz8v/2TG6ikBZkEk/k927yelFynTYoP9VA5KKcNZocSfwa7WoRFglqjdWQ20G+6veCGkaqdqR9u eiSpET+SXFUUqlEFWzRZQm1FmV3XUoce5TTbUMexptcViwaxF+FdIm+yssy8uG2cb88xkHnB1Ln 1y8MK+JfuC9iX9GTFHtsB0j3JFleySU30zjpXVQIezRnsL9USNNwJEtOMaIcbOr1ZdV1/zUXvWb LVElFf1dHBWFZXEE2xA+7toAepI6yy10Te26KkJ8n6XhSR569tuGcHMWfvDRIpMHERGaj5gEKAs 7o65QpJHUDn7gtwFvMrKSZsYcbjQN4pimqwlutq9EklA+i5QRWW55lwpVqoVpbMsyz5cU/NbkVc IF/MTiAJBHTh0k8OAjZWrhfR2yui5+I0xRG0j9tGSK8JcrMIeuzdbZ1asghswjn5ptH9QnX+WD2 gtm9bmjNF22u2VQjKoJLYZ0enh5NySoiJRC6JpIemKE9VsK1x1vz2+1fpkI6cRzpk+7TXBZVsuC uqkadOwFsyAaCfwqheG5ydClj3tOIr7EGK1vLfl8wvaMVNKJAw0E520HCmxm9cZwMsmOG6EWSrG yAsm7hVq/EB3HrQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1778918417589158501 vt100_fini() is called unconditonally from qemu_text_console_finalize(), but it may not have been vt100_init()/opened: fix the crash in that case. Fixes: 8fa294482eb ("ui/console-vc: move VT100 state machine ...") Signed-off-by: Marc-Andr=C3=A9 Lureau --- ui/vt100.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ui/vt100.c b/ui/vt100.c index e2fba822523..e5ad978bc8c 100644 --- a/ui/vt100.c +++ b/ui/vt100.c @@ -978,6 +978,9 @@ void vt100_init(QemuVT100 *vt, =20 void vt100_fini(QemuVT100 *vt) { + if (!QTAILQ_IN_USE(vt, list)) { + return; + } QTAILQ_REMOVE(&vt100s, vt, list); fifo8_destroy(&vt->out_fifo); g_free(vt->cells); --=20 2.54.0 From nobody Mon May 25 13:48:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1778918414; cv=none; d=zohomail.com; s=zohoarc; b=Y4zl+K9P5U934uQa7qxY9la1cYVufOm+WrvF4NvnYOXu94N8sqAEIIdZgcF1DvWIYCzjtnIVUmfwwnb9jJNfWOx58dYRP6R7pfU5X+7XUlzGKeN7G+f6yQTjKgN6j4Dkn4vIGRu5SmV/XzjPjovpqAStFPBWv1YJeXwukhHQT2c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778918414; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=7IYlECDaFjyC5jMVbOlYMcyFWCuAkt4a7pbuaTwHsVc=; b=n7sPOhKayqaA6r4MecantU2iW/tCNFICaeRVyMzZA1mYYWgFv68KJRi219ZSQDXTemYpF3Mu64jy8FjIF7Ui12VlQ6FL8DzUAX6LBOHdgtmUfGeEc7cREECMuV0Vqub0Ca6SpzSGJc4j/h6M8admhN5f2CLA35+I1pN3b6k7zYs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778918414673622.0294464575597; Sat, 16 May 2026 01:00:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wO9w9-0004zg-6T; Sat, 16 May 2026 03:59:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9vr-0004yN-CN for qemu-devel@nongnu.org; Sat, 16 May 2026 03:59:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9vp-00072L-Vz for qemu-devel@nongnu.org; Sat, 16 May 2026 03:59:35 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-605-BdSJBFriNyyIM04i0EcB0w-1; Sat, 16 May 2026 03:59:30 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 90284195608B for ; Sat, 16 May 2026 07:59:29 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 66C0830001A2; Sat, 16 May 2026 07:59:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778918373; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7IYlECDaFjyC5jMVbOlYMcyFWCuAkt4a7pbuaTwHsVc=; b=iFqpgO6/atjdgUKp/0bee5twt2d0012t2FEAXHAT2Dze+f8EdIBU90v5ljG3YwYh5F/GKC rYCmv/upDT2VEac2iEPHLX5HjCTwSBBWFwbJ+Zkgo4ov5+hS7QJsXgUS4MWkJpjCu5IakS fxkU1nTpb7yMb6wYaq9cP6gQ933/Cws= X-MC-Unique: BdSJBFriNyyIM04i0EcB0w-1 X-Mimecast-MFC-AGG-ID: BdSJBFriNyyIM04i0EcB0w_1778918369 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 16 May 2026 11:59:01 +0400 Subject: [PATCH v3 02/24] hw/pci: handle missing bus in prop_pci_busnr_get MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260516-qom-tests-v3-2-3f20c3a029a7@redhat.com> References: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> In-Reply-To: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1270; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=Gv49yL0vZomasnhGHVDQr9t1aDIXOgAlYIxo7kT+4zQ=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqCCPO75N7NTnEd+YD7W/C9SpWznUVWfkMZWUiW +DKusUdnyOJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaggjzgAKCRDa6OEJdZac 5V/SD/9/QcpeTRMQY1+X4+ozKJovcz2mYY9XJNGXJ6NXvfzimJ/BDccxMTu6dpphZLHUBFgFvyL 3g6HIlBYm3yMe+basiKE8xGLhmBWilvO1T90qpHLzJK16hYoI2pVuviljFrjJED1spbPUycXmYF Dv6g4kLlT9ahuDDYodpSUnQaAYsUoRuszJ7H/aimI1npIzldY7KbcplPH12dtWx0J8fAUQADBDx FpsUxtp/6HibXEjk18RIfO0em04xdxu1WXCP6gajZiQi9b3rB5BtLKm8a3O9wIXiXT0yuGoMJqd E0cNSzQFAYLgr2fLCr1Mh0jEc4IPBsKHJX6X2bejdewSsXN19+3c04ZMDkq2Fty2TH6feWeumz5 ohbciol87hYZRjyQ6yzf1/A1ifH90egT2lt8+BpG9GV+p2lgtGjewEWCXAUQGSfTqbMd+RASZkh gdhkCeWw/BeNvFUT5HE0XIZoVyY2Xns0K19KR+wkQbzdAyV/MZzaoAZvMfnsk31VwBoyGU39ce6 tIEgdU391rN29tyx1B2Juj6IB8ZMLpIgycSPeZJT8U1pEzkOdYr2dTzon2qKQJ8EI6TXHMKJFI6 DQ624Bk9J0rwmVgOhtoe+pL3dES3dXh+5RQoYuPjXedGysf8ExeDF7KnLL9bGsuFhwOiJ9iSHmY M0/4MlCoz8ynh8Q== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1778918417616158500 When called on an unrealized device (e.g. from qmp_qom_list_properties), pci_get_bus() returns NULL since the device has no parent bus. Check for this to avoid a NULL dereference in pci_bus_num(). Fixes: df9ac7254fd9 ("hw/pci: Add a busnr property to pci_props and use for= acpi/gi") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/pci/pci.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 4298adf5a0a..cec065d108f 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -64,10 +64,17 @@ static void pcibus_reset_hold(Object *obj, ResetType ty= pe); static bool pcie_has_upstream_port(PCIDevice *dev); =20 static void prop_pci_busnr_get(Object *obj, Visitor *v, const char *name, - void *opaque, Error **errp) + void *opaque, Error **errp) { - uint8_t busnr =3D pci_dev_bus_num(PCI_DEVICE(obj)); + PCIDevice *dev =3D PCI_DEVICE(obj); + PCIBus *bus =3D pci_get_bus(dev); + uint8_t busnr; =20 + if (!bus) { + error_setg(errp, "device not attached to a PCI bus"); + return; + } + busnr =3D pci_bus_num(bus); visit_type_uint8(v, name, &busnr, errp); } =20 --=20 2.54.0 From nobody Mon May 25 13:48:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1778918464; cv=none; d=zohomail.com; s=zohoarc; b=Vglum9Vgl0w6osHfOWeSioFLp6ulMk3y2vvoDVOYXSXfmWn8/+P9JropR86HT1oGSEz+yQ9K13p3NUGEcAa/wdZCHAN0q8+WuGM3aI+KxDnLHPXsV2ZarGWruiz4yaTMNY6HZ2NFDdFN+l8VsCxo5UmsTsr1pBs5rDwfjasYaXU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778918464; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=iO87o/0YYcEWxdVsD3TnBacBB5QSuCWhHLZQkTvzHEc=; b=nGqMAjKHiFMkHDQ89EzXdV5exvA7X1QsuWuaMnJ612O+IKB+kQC7nL15V3PIucyQf10UaczmfDJflT70JUm6vk/GmbZVumJN3b0A/oPyApjImt11KaQbf0mQIRYALMyoBldKcQB6V6GfwgeSMt0lSJiTVRnY4UQ0U0LEDkI0BkY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778918464914245.34397568094437; Sat, 16 May 2026 01:01:04 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wO9wR-00058V-EB; Sat, 16 May 2026 04:00:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9w1-0004zl-Ic for qemu-devel@nongnu.org; Sat, 16 May 2026 03:59:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9vu-00073O-Ea for qemu-devel@nongnu.org; Sat, 16 May 2026 03:59:40 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-695-PlIQ7_KDMlqjZCpLLk1UTg-1; Sat, 16 May 2026 03:59:36 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 58AB419560B4 for ; Sat, 16 May 2026 07:59:35 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 528B11800576; Sat, 16 May 2026 07:59:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778918377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iO87o/0YYcEWxdVsD3TnBacBB5QSuCWhHLZQkTvzHEc=; b=fZGxJovpAOFAfPONEPxlaRV77nEdlPcXzlKJGHKq7npLxNjzadTj9vzy0XnWjKJJNMEc7q xKsUoMseJznhfPaJ0m338z8HxXOF+Wd8veJSTg7NJkvxVuYRrMt1Lbn8alWzIR1sFLUJTW 5AXo22fbHJXcdJNbOkLfRaBBYJ6pd4w= X-MC-Unique: PlIQ7_KDMlqjZCpLLk1UTg-1 X-Mimecast-MFC-AGG-ID: PlIQ7_KDMlqjZCpLLk1UTg_1778918375 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 16 May 2026 11:59:02 +0400 Subject: [PATCH v3 03/24] chardev/char-socket: handle NULL addr in char_socket_get_addr MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260516-qom-tests-v3-3-3f20c3a029a7@redhat.com> References: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> In-Reply-To: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=807; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=ec79R6dwgSUru8iZAGVoGIdElFOC+Hue6wBEH561cpo=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqCCPO0GEi4Oiy0n6tqN9LMDmjOwzfMDX6knQyw 5o5Gl2b50yJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaggjzgAKCRDa6OEJdZac 5Qc1D/9ZvV8LLPeyRNlnzZzko7MRLhlUuHEcLqG/oLYZT6Ua/aaXxChg5hr3cOOa/EqbonuB909 N5JKrCI7nP1yXfeY4IivQCbNe6wz2/DQUN/oOVgv062R8nGF6i4T6qgDu6Fh3WrBV03t6aa7KGt 5d2VWudxFecxX88m4xh9C4LSvE/lJkmovNgY4C2wkarGQJBJuOyKtWlq0SzrcGrqP21U0xWWW0j YAViEYQN5dGMUDWnVnSr+UbbKGcelO2twcMtGKP3/bnk6M5H3Swsbo0ymJ96gAZFjRMZh6xSy0A bDg+7Tg48gfvLuICq3pR/5cZIFhCFGUEVEMc4OFyYBG0TsXxZT5EFEUo6ldYGmHEXgEjzxvP6A4 Mf9dzEcDApVqvLIAUt8fDsxByosAknDFGycYdoxLcPbP0AhUPA3kaqKh62UcJ6IbzWzP2PW/QoT eJ+2JiezfCOBxXrVU1y4tJvZFka9mAdOdmMJHEplOmIeLRoUmsVtOFnmeVexX/m2mgs+ZJj3hpJ 0HkdnGFpqFiGt9nE9EhCT48ycoVp0GUOkKtBpX8HTpjwS+Obfql27zgVoYu5WuyfG08Wx9xeGmM n9Veu09k0uZShfix1gghGO0u4+qc56NKxFJDM2ZztitMSmyK2bWXRlDxKEm1yqhLe0HhztolNg9 ORAJVPy1fH3bKXw== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1778918465736158500 When called on an unrealized chardev (e.g. from qmp_qom_list_properties), s->addr is NULL. Return an error instead of assert(). Fixes: 123676e9894f ("char-socket: add 'addr' property") Signed-off-by: Marc-Andr=C3=A9 Lureau --- chardev/char-socket.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/chardev/char-socket.c b/chardev/char-socket.c index e064b105c50..b629575fcf8 100644 --- a/chardev/char-socket.c +++ b/chardev/char-socket.c @@ -1529,6 +1529,10 @@ char_socket_get_addr(Object *obj, Visitor *v, const = char *name, { SocketChardev *s =3D SOCKET_CHARDEV(obj); =20 + if (!s->addr) { + error_setg(errp, "socket not connected"); + return; + } visit_type_SocketAddress(v, name, &s->addr, errp); } =20 --=20 2.54.0 From nobody Mon May 25 13:48:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1778918445; cv=none; d=zohomail.com; s=zohoarc; b=Ig6wVo+dJCmEdCKSS3eRaWne/onrc22Tq8oXxc3lrOSkRVlUN8P7i5SvD7BUD9gYSg2GhidqDOGo1rEPwjx2hV82TcKnN8+uWeEV3MTvLxUnFFCFD8hp26wFjwgPj9P1H2XkfuRDuHfYMhdnAczp4RSEFbVFkcwPlsH1B6PygJc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778918445; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1bgLA9Zp+Jow51t/607ELa0KrzfqLyYWWcupN4GZiYQ=; b=M+tRvd0b/WlapliHKxkEFoHbnR37cXj6dYRp0V795nIg2lwrVTvcNG6zcFYhWL0zJsbubANXrfxWkB8uuFt2phfNC6PbivuhTplUwXyOEQVxTaML50ljKOgqjTzSsIMv6Exo+3+tnHXEjLrGsdmydOP5dugwa1Cz1AudcFjThaE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778918445449768.3864091915657; Sat, 16 May 2026 01:00:45 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wO9wL-00055c-O8; Sat, 16 May 2026 04:00:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9w4-0004zt-6f for qemu-devel@nongnu.org; Sat, 16 May 2026 03:59:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9w1-00074O-LZ for qemu-devel@nongnu.org; Sat, 16 May 2026 03:59:47 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-92-2OcUxCa-OUKXCVe9cdG7IQ-1; Sat, 16 May 2026 03:59:41 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EB16219560B4 for ; Sat, 16 May 2026 07:59:40 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B6B4E1956053; Sat, 16 May 2026 07:59:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778918383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1bgLA9Zp+Jow51t/607ELa0KrzfqLyYWWcupN4GZiYQ=; b=CMmuouktOAyiM4GfcCmVZMAfnm8onUM1pHkCz5LMFz0rNjNhOAMGTwB/VSfKakhiWNyro7 vgT0R95/VBK6HUvlIP+kai/WUKlbut7/+WsaXYkH1zh73/z7E3Ltd50XZeHIitAfc25ecc dYQhYqmJfQmWxnDm5pyelDn4A1CCzWQ= X-MC-Unique: 2OcUxCa-OUKXCVe9cdG7IQ-1 X-Mimecast-MFC-AGG-ID: 2OcUxCa-OUKXCVe9cdG7IQ_1778918381 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 16 May 2026 11:59:03 +0400 Subject: [PATCH v3 04/24] hw/pci-bridge: handle missing parent in prop_pxb_uid_get MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260516-qom-tests-v3-4-3f20c3a029a7@redhat.com> References: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> In-Reply-To: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1195; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=mzt68/PqLMn279UizfyFsnOjTDYKE+7gRPi+R9njaM4=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqCCPOdD4FP/Vf8ZKVHFxfGuG1By+gHGcpkw3fT HOUhVWIkkCJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaggjzgAKCRDa6OEJdZac 5f7pD/0din+p/IOySFgUGen+Z6mStsWvqV339qoj2cghaRn0T3NoIDfWoqpQpYBK1Vkgyq+3NBX ACfpsJlF7zbopEPd49MT4ge8jVJgun+wme2TDomrLp35OF+A+Q8EZbm/aRRfCGQnQIwEvvu/+Zi fk9SDlTffVoxxBvKt3GCgpfWehAYWf32dod7zW/zOY2Uoh2QdR2f7otR3OViWmj1mj+MaD5YpuZ 3O/nZjDQQ2Bp5tM74WhwsQEGba7C0KB8zkaq5xICdKfR1Qqj3lNTyCosvc/mGq9ER+omNTgBaKI q0zjsPH9NedTxKOWg0ic6uD/K/zixfp1q8UirMeNFBUGm2ZgzlEPITCjYJ3RS/Gvn/d/Jo4/A8Y KUkJaPvjWI9IFcaRzDtl/p1iaRcnBqNRzkATRm88WUpveiuz5XGztv+bECeDlB2K0L01AR4bGda BcWqltausBKFM5JWo55O3APM1vtbfJed7iG4d8Qc6FwnBDipSRzbL0BOW5bsymCanHG0CKXf94e hWQklnPtcM/DocujvIH1/l1Sw2gK40kUe+azYr6mT4S4X9Yt1qCZhUOAaZHdT4cK0uWMOxp21Tw xCtneIpfHBZ9QaoSmceam48SlgFYFL6oTqT7wgc1ntMAB13HwIhU+lHoD6/AwxBoPPqBIixWHNW MBQKwd7PuJ6GnRg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1778918447722158500 When called on an unrealized pxb bus (e.g. from qmp_qom_list_properties), bus->parent_dev is NULL. The pxb_bus_num() callback dereferences it unconditionally. Check for this to avoid a NULL dereference. Fixes: 97b9cb066e5f ("hw/pci-bridge: Add acpi_uid property to TYPE_PXB_BUS") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/pci-bridge/pci_expander_bridge.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/pci-bridge/pci_expander_bridge.c b/hw/pci-bridge/pci_expand= er_bridge.c index 11623a5666f..40ffbc4e082 100644 --- a/hw/pci-bridge/pci_expander_bridge.c +++ b/hw/pci-bridge/pci_expander_bridge.c @@ -85,8 +85,14 @@ static uint16_t pxb_bus_numa_node(PCIBus *bus) static void prop_pxb_uid_get(Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) { - uint32_t uid =3D pci_bus_num(PCI_BUS(obj)); + PCIBus *bus =3D PCI_BUS(obj); + uint32_t uid; =20 + if (!bus->parent_dev) { + error_setg(errp, "bus not attached to a device"); + return; + } + uid =3D pci_bus_num(bus); visit_type_uint32(v, name, &uid, errp); } =20 --=20 2.54.0 From nobody Mon May 25 13:48:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1778918422; cv=none; d=zohomail.com; s=zohoarc; b=JYnBbcwa8+lbLLl3VtxkM9uCxuJJN38hJPQL+sjQKi7s3iY6CmAIZI/dDX04A5DucbINe4wzbmqOveY/PJbweaoUEJULGDFGYMsT86mJBRqPwaflMTMNVoLrDkHs0FG3NeHBI0OoNQr4G20/UGmF+Uy922P67t+quTsLGsuMlzs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778918422; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=AwxIXFRqNOFwSXEkTBL3lUfI3qRxviZUG2ZP9ptJKDg=; b=UkmmNXJ2OJmc5zotpvkgaxjZaIWua46NyMG08uWFEh1SeQii02a6cchNZLqaV8hdNWsffLrCmNRmt78mOEWcI8HgyE5C2Uhv3U6A47oT/X4FYNtzK8NuPX/4gkUVASQkjN6PF5XCOlJHz4gipZNFfdKssEyLjk6DBUE+E5pqrxc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778918422959590.3134395935392; Sat, 16 May 2026 01:00:22 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wO9wL-00055X-Oo; Sat, 16 May 2026 04:00:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9w8-00050O-ML for qemu-devel@nongnu.org; Sat, 16 May 2026 03:59:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9w7-00077Q-6B for qemu-devel@nongnu.org; Sat, 16 May 2026 03:59:52 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-82-TssSJwORMxO_TDZMHSWTvA-1; Sat, 16 May 2026 03:59:47 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6C06719560AA for ; Sat, 16 May 2026 07:59:46 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 50C5D1956053; Sat, 16 May 2026 07:59:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778918388; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AwxIXFRqNOFwSXEkTBL3lUfI3qRxviZUG2ZP9ptJKDg=; b=WFYJ7Tly/xbYrDNA2pLrFFjlyKcl7CMnj6i5/gOdqJeBmc+GLW7jFbq5+dF/kRu3Q53T7J flKtEidkJsLb6JaTTfaiukL6Hixyc1KcbFG6bxBDasDfuKp9daEi5gl5XA3qx/VxCjE+es 2t7o0vcXGtIxBG/FMaLtBaGIHphVbfo= X-MC-Unique: TssSJwORMxO_TDZMHSWTvA-1 X-Mimecast-MFC-AGG-ID: TssSJwORMxO_TDZMHSWTvA_1778918386 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 16 May 2026 11:59:04 +0400 Subject: [PATCH v3 05/24] hw/pci-host/i440fx: handle NULL bus in pci-hole64 getters MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260516-qom-tests-v3-5-3f20c3a029a7@redhat.com> References: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> In-Reply-To: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1937; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=Vp9y54qI7ZUxlsGcdaDjRbl1VRjgkXVwo0pQvUFYFlU=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqCCPP1mSk7lThYLXbz6gMpWnI6sXx4+4e6c5wj tJgg+PtvpuJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaggjzwAKCRDa6OEJdZac 5SYiD/91cUEgd4t+W5pjKVuPacPiP0u6CIXCoUuzWJoe6OCesufhYSWKlGa5JAz2aJhYCx9FYss 1rJGgmGv/0bvNoA+eTyopb7ScYqbcHJpLM/eh4HjpbI52Ar3qR11ROfMEqcXOOlZLVPMm2sKfit lv3twG+lB402ZKQl+VPUHO3PJfJisVuQL0OhqIDyM4bLLR1MiNtHPHTzzoZ9H78cCDgTKxnw5jf +LmS6E4kZwziGZOb06s2NGq/SJslfaQRN9P+nIhKcMPCSmCU02KC7F89siQZgNcCpcUHcyVPjH5 CmQXAnFqtojRMcs9BlP/R2hGpWXro65qmtlTp2gtaOq6dD+fSMQntZ/IhdXXXyRuA0NcfY/3rOt /a0Hc8dex/pcn9hxtGRp0a+bA5iOj6IE7bLJmEDUEO0RtcNVWeFM2hQAaXoICD63bOivf0Sb8Rv tJRglZszQHpNwG/FnEomSBP4JOjyfCRhDH0dwH7UCxeDi8d644vRFNTp/b4aVZuxfaLRsv5qS99 jXWUgje4C6PCy8SPrIx+INOHrmNddBjSdOugI3OUiYP6iSTSIioM+y8F5W9oNbuokdgsiU5OylJ R6HJF3LnflUvxOHm4sOY+wryEaBnwOxW3EuF0cll8j6WazDlwqniOf9uzlneokR7N8di56Df3K/ URUY5DiOFlFPPEA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1778918425651158501 When called on an unrealized i440FX host bridge (e.g. from qmp_qom_list_properties), h->bus is NULL since the root bus is only created during realize. Guard against this in both pci_hole64_start and pci_hole64_end getters, reporting an error. Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/pci-host/i440fx.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/i440fx.c b/hw/pci-host/i440fx.c index e7d638b296c..c1982f7962a 100644 --- a/hw/pci-host/i440fx.c +++ b/hw/pci-host/i440fx.c @@ -189,8 +189,14 @@ static void i440fx_pcihost_get_pci_hole64_start(Object= *obj, Visitor *v, const char *name, void *opaque, Error **errp) { - uint64_t hole64_start =3D i440fx_pcihost_get_pci_hole64_start_value(ob= j); + PCIHostState *h =3D PCI_HOST_BRIDGE(obj); + uint64_t hole64_start; =20 + if (!h->bus) { + error_setg(errp, "PCI host bridge not realized"); + return; + } + hole64_start =3D i440fx_pcihost_get_pci_hole64_start_value(obj); visit_type_uint64(v, name, &hole64_start, errp); } =20 @@ -206,10 +212,15 @@ static void i440fx_pcihost_get_pci_hole64_end(Object = *obj, Visitor *v, { PCIHostState *h =3D PCI_HOST_BRIDGE(obj); I440FXState *s =3D I440FX_PCI_HOST_BRIDGE(obj); - uint64_t hole64_start =3D i440fx_pcihost_get_pci_hole64_start_value(ob= j); + uint64_t hole64_start; Range w64; uint64_t value, hole64_end; =20 + if (!h->bus) { + error_setg(errp, "PCI host bridge not realized"); + return; + } + hole64_start =3D i440fx_pcihost_get_pci_hole64_start_value(obj); pci_bus_get_w64_range(h->bus, &w64); value =3D range_is_empty(&w64) ? 0 : range_upb(&w64) + 1; hole64_end =3D ROUND_UP(hole64_start + s->pci_hole64_size, 1ULL << 30); --=20 2.54.0 From nobody Mon May 25 13:48:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1778918423; cv=none; d=zohomail.com; s=zohoarc; b=S1NMAFkf7KT+1R6K3YO8O8RTkQ2JVqnNCz3FDLQJYuy4ot3sopWhufujodklRbeSnRiqZ22WTLDBAWBCvMwSp4BSUlsmvqlKX93E9eS8Vsx6pYun1DXNchFrGWP87IQtS5mlRyMukBqu7AyJQTqFfRFz5Lue8xHN+RYKaw3IDmc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778918423; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=CRg2XEz7g/q9Y9vnBcCYZpcSu3GsBjF6YOxJNwlUUiA=; b=mwDhBcTV7Xz0KkfYpkWw5JzIFsnlBxlFVYVmVNnpC7bhrkqKgUHJKVp8Zj27ITMMmWlbQnj31d7NkPczyGuinDCWLviEgrx2YBHFoF9UPzqTZh4ML9a1vQ8h97bvADgL9HQkgGGsozHmzus9RNsrHGGgo3yBTp/l/RVJ+Yr8Jo4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778918423262183.80918797248228; Sat, 16 May 2026 01:00:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wO9wU-0005Fx-9h; Sat, 16 May 2026 04:00:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9wF-000526-19 for qemu-devel@nongnu.org; Sat, 16 May 2026 04:00:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9wB-00078r-8z for qemu-devel@nongnu.org; Sat, 16 May 2026 03:59:58 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-136-0SVDDsLNPp2g1Ftsp5PR-A-1; Sat, 16 May 2026 03:59:53 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1CB8518005B5 for ; Sat, 16 May 2026 07:59:52 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id F07C11800349; Sat, 16 May 2026 07:59:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778918394; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CRg2XEz7g/q9Y9vnBcCYZpcSu3GsBjF6YOxJNwlUUiA=; b=g5a/YeBKe6JMAegy7Ms6zSwT1pLPdVfCr80EDuzaFexvrIQ4IEQHbAN5AkzaEtGMz+1kDX Wo+urkXdoq0zEnpyIgs1qJN7Ro7scdQ2KcCrKXVWkjBvkS4KJB2E19nMJ/wA27bLN3NOFU 0oK+6EL2ViNaaLzDlpaHB+pDamuV8ak= X-MC-Unique: 0SVDDsLNPp2g1Ftsp5PR-A-1 X-Mimecast-MFC-AGG-ID: 0SVDDsLNPp2g1Ftsp5PR-A_1778918392 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 16 May 2026 11:59:05 +0400 Subject: [PATCH v3 06/24] hw/pci-host/q35: handle NULL bus in pci-hole64 getters MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260516-qom-tests-v3-6-3f20c3a029a7@redhat.com> References: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> In-Reply-To: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1851; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=/fxZ1GAbhmt7eqzcBY0CxzgAhlT5phl8zL1KjrOh2so=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqCCPPIeH4X224yNHmEd8YJ/5v87ASv1zzIvt5o +OwWBJwr1SJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaggjzwAKCRDa6OEJdZac 5QevD/41lPbr6eeziJVuAmRcHk3C/Kv6WsudLJXvc+YR2ZOCFGsfN81ATiK4HaAfNVzLDTpSzre 2TDQcnGBblaFFgJNsfIY9FaNRXij6RclKiBLhwp2lczvFnhfGmM1pCFi7Ol5VUXuExXdOBzKlqK omjOa0B8Y1BXkuUaH8SHzs17bNLibE7KOyIRy0FMhh83oIao6K4GRGju+T0pqKV9OcHTD8NFFCD jwS2uyr6NXMkSy88AtBxaEeagei+vJpzvMVxBBOVVWTgcK+Hh+ag1x7f2d3DSYk3jL1eruNQJck hxBl9gZM/g4b2qTM/Imbrcu7RexeWXzk47xy/nqBRq95cdHRu78ExNnZG/oLFRbmcKF7noyRzuk DrJ/om+4QBPxpxTOF5jSOgaJwAz31bO+Bfct8mI++S45bi3DDS2aj3Yavu73wZOeHOI5rooBrPB xeS0u9pyH3XJDoND/Ku2rCif8mUoQRRIl476htRlW3hJpR49QPqveTvdEpwfmud1bQgbCoAzkGv i1EW0kzTgG08RoznsbJ0Whjz6O1V49NPIVYI67aOfWxIJ0XOfmdJ+9SmMDUE41dkl2glgEJN1r9 +WnrGpE17YxkREIQqU5goDMRcL6F0z1OVHVBc04prl2ZCAPY7F5V4BsBCB64+8/OYFR4eG7F0t/ 8U/9/HjQjxZK8gg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1778918425651158500 When called on an unrealized Q35 host bridge (e.g. from qmp_qom_list_properties), h->bus is NULL since the root bus is only created during realize. Guard against this in both the pci_hole64_start and pci_hole64_end getters. Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/pci-host/q35.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c index e85e4227b37..355e81bfa20 100644 --- a/hw/pci-host/q35.c +++ b/hw/pci-host/q35.c @@ -132,8 +132,14 @@ static void q35_host_get_pci_hole64_start(Object *obj,= Visitor *v, const char *name, void *opaque, Error **errp) { - uint64_t hole64_start =3D q35_host_get_pci_hole64_start_value(obj); + PCIHostState *h =3D PCI_HOST_BRIDGE(obj); + uint64_t hole64_start; =20 + if (!h->bus) { + error_setg(errp, "PCI host bridge not realized"); + return; + } + hole64_start =3D q35_host_get_pci_hole64_start_value(obj); visit_type_uint64(v, name, &hole64_start, errp); } =20 @@ -149,10 +155,15 @@ static void q35_host_get_pci_hole64_end(Object *obj, = Visitor *v, { PCIHostState *h =3D PCI_HOST_BRIDGE(obj); Q35PCIHost *s =3D Q35_HOST_DEVICE(obj); - uint64_t hole64_start =3D q35_host_get_pci_hole64_start_value(obj); + uint64_t hole64_start; Range w64; uint64_t value, hole64_end; =20 + if (!h->bus) { + error_setg(errp, "PCI host bridge not realized"); + return; + } + hole64_start =3D q35_host_get_pci_hole64_start_value(obj); pci_bus_get_w64_range(h->bus, &w64); value =3D range_is_empty(&w64) ? 0 : range_upb(&w64) + 1; hole64_end =3D ROUND_UP(hole64_start + s->mch.pci_hole64_size, 1ULL <<= 30); --=20 2.54.0 From nobody Mon May 25 13:48:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1778918467; cv=none; d=zohomail.com; s=zohoarc; b=lw4hgvYS7zNsXjEbmP7dza2iuoVab3ag+nUMjbda2ND4dBcKFNgdrc30BfwQ3SK9mQ2mxdxmzQqz0Bw4aLr7Yl2rQ3lD3tDDyGiX0UPAEZrRmq/DfM3MK4oO3sdu2s57FaqvSKK71BwOvt3fV2OjCpJ+x4NIfuqw57+EkXy6v+A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778918467; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=aUOSWzhXl/k5m1peWGpzHvutpmGh4e3ebknaM+K7zLs=; b=SGh/UvWoBCmUn1LEDr5UKVyI/knNyoQd5STRXiOWtPZ5fOYzi9jxuEeKi3fmZPanki5IubNMQH097MTd9tER7zpOCqkjD6rRC16M2ljrAQrMxBdCIG3FeoqzY3PSuZ1CVQE8CxAPeYDAPx++S444Cp3jUQrJ9em3EmyZlkzZgqw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778918467965504.5075775089716; Sat, 16 May 2026 01:01:07 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wO9wb-0005Nt-V4; Sat, 16 May 2026 04:00:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9wL-00055h-B0 for qemu-devel@nongnu.org; Sat, 16 May 2026 04:00:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9wH-0007AK-0q for qemu-devel@nongnu.org; Sat, 16 May 2026 04:00:03 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-76-ERnuTVFEO_i7KQSIvVg8ZQ-1; Sat, 16 May 2026 03:59:58 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D0DC11956094 for ; Sat, 16 May 2026 07:59:57 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 901BD1956053; Sat, 16 May 2026 07:59:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778918400; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aUOSWzhXl/k5m1peWGpzHvutpmGh4e3ebknaM+K7zLs=; b=arx1hqoF1pDNm3rMLp+s3VCvnOi2FDyUUoo0ukAloCB0vLeKEcHSBqh+hY/fj4c6d2Snbv aFpF5EwuQTE+hkuzN9fuVsu1n737jxOCbOphB9eLA7ezsJVjWxZ77dMLIHNDBUUZ9MkrZk rS/XqdufinEqI1znOt2NIapQSofL+JU= X-MC-Unique: ERnuTVFEO_i7KQSIvVg8ZQ-1 X-Mimecast-MFC-AGG-ID: ERnuTVFEO_i7KQSIvVg8ZQ_1778918397 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 16 May 2026 11:59:06 +0400 Subject: [PATCH v3 07/24] hw/ipmi: reject NULL 'bmc' property rather than crash MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260516-qom-tests-v3-7-3f20c3a029a7@redhat.com> References: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> In-Reply-To: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=711; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=hN3dhAnonNDSvyTPH4pe7+NR9c8xdMiWFLz/sdnw2qY=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqCCPPtFy5k6DHrXUircADXNtRAQLBxZPJbE0nP V1tpzFN7LKJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaggjzwAKCRDa6OEJdZac 5VshD/92cZRblsDR0GmpZX3t7ALc7ceboY7Cy4/D2i3x8jS8i2LnJJXA8Qfp1kZ+udJtLrlvaP2 QCMlBtNfvcrc0nCJNG4B5H7d/pnFdhpKOvTeFaKgsSAqiBJzNcppxgbS7TxkO4v72nAXeQb0wzz P3/WYvre3Ys5K5lBabsERidyVK8HJz/xs+/I2xhL2iaUOMqprUFvLmIB0pPBL6JVT7rGbDldnKL 753K/O5h82EaWVk9rkLECZwB6mvOQ7WpQEPFYyvch26dx6APYeNZgiTV4LJabxzVQClXcOyHnsg iLUm8LJkh55X+2fI+ij4kzN4KhdXNpoH3T5ludqw4ptRjqbA2WPc8rcVm5X1aOfKX6yMGoA+e0B zlIgOHncKHrZNUcZj5jxMbllEQo0/gOVrxEYSmw/g90PsNxKYtcd6UsDBq6XcWN7P+jYrGzPKV0 fpmonVvVLfniblb+Ffi7xIc4e+0wWUPFO442tOZPKeEviJo6RxUfq0+VxvLEVERn25D8ZIF3roL N1xLMPRs0Gznqa59JUVI3Kx7fKnAVHZD83+kCN89rDWqSkcLIaY0h6UY1ip8VudOebd4gzBFbSF jaH7V7SIjhK5mweAqCz/ig10IILtyDgV0P1WtM5WdQ4ZbOD97+ab9FAeLTpbwPR1ztzjcgUo8jv Cku9jlFc1+2VwRg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1778918473842158500 Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/ipmi/ipmi.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/ipmi/ipmi.c b/hw/ipmi/ipmi.c index b49affaccec..74818ff3cea 100644 --- a/hw/ipmi/ipmi.c +++ b/hw/ipmi/ipmi.c @@ -97,8 +97,14 @@ static void isa_ipmi_bmc_check(const Object *obj, const = char *name, { IPMIBmc *bmc =3D IPMI_BMC(val); =20 - if (bmc->intf) + if (!bmc) { + error_setg(errp, "%s cannot be set to NULL", name); + return; + } + + if (bmc->intf) { error_setg(errp, "BMC object is already in use"); + } } =20 void ipmi_bmc_find_and_link(Object *obj, Object **bmc) --=20 2.54.0 From nobody Mon May 25 13:48:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1778918479; cv=none; d=zohomail.com; s=zohoarc; b=eqJ0ZuFW1haH2z3XOGTSmtsE3SY33GYx+s1kkf8aQ2lF+4r5UC1fpluFx6L/oga2j8uyNNlNoDD/QtwyRXSkdpmSSv/bPKHkXJNj0jCxRozv7P7KUirJ5ivn/DvMRg9wSa3mJzy5UCNRTeBdOk/l5QOiAq02CR0lRkDgwQM4IvQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778918479; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9RujeSeL6ldPtOVDgPmFhHQObOMHuElmXzcyIjBot6M=; b=GqS376eTASekM0R05LLHxScKtu/lT+1SD4oCvgH13eLWKkY60+wEYpesqoaXoo9nyf54PZOdpgHK5N4TbS9HN3oSYojfn7lQzNYoTwYlnknzGXdMUL3mNCC6HE0I2T5KF66zdNi6MUjQMYMgDnDmPFzLA4BT3WDmBVfQUx1q+KE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778918479607145.03302360012697; Sat, 16 May 2026 01:01:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wO9wb-0005NO-Mc; Sat, 16 May 2026 04:00:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9wP-0005BK-Io for qemu-devel@nongnu.org; Sat, 16 May 2026 04:00:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9wN-0007OG-Jc for qemu-devel@nongnu.org; Sat, 16 May 2026 04:00:08 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-458-qA7-LmdHNdGh9QgeC1E8Vw-1; Sat, 16 May 2026 04:00:04 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CFF411956096 for ; Sat, 16 May 2026 08:00:03 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 96B2330001A2; Sat, 16 May 2026 08:00:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778918406; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9RujeSeL6ldPtOVDgPmFhHQObOMHuElmXzcyIjBot6M=; b=OWADxoVCJ1HEjtKF9srDAuMJwnJazd87MMT+mvrazVMtz0/xGhyNqCO1HhlGyv2Qfm4Cuj A7o7+jnw4JWudlPMAywii2wBz3JSB64CVdldbg5ui3vgxF9MOzaCTQYrl6L2tLXcLXToLl A0F2d3CM598Kr2Gi3P4fU+qEcnxfOpA= X-MC-Unique: qA7-LmdHNdGh9QgeC1E8Vw-1 X-Mimecast-MFC-AGG-ID: qA7-LmdHNdGh9QgeC1E8Vw_1778918403 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 16 May 2026 11:59:07 +0400 Subject: [PATCH v3 08/24] hw/xlnx_dp: reject NULL 'dpdma' property rather than crash MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260516-qom-tests-v3-8-3f20c3a029a7@redhat.com> References: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> In-Reply-To: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=750; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=jBOueGD3usojug1hoofNgWECywbfWUjlS8RM/1Fkkik=; b=kA0DAAoB2ujhCXWWnOUByyZiAGoII8/IHnbvLkus4ER0ZD5kzq3BvTI4GEcd12WjtbZUbiXcO YkCMwQAAQoAHRYhBIepvZM/h8YG0nb2Ldro4Ql1lpzlBQJqCCPPAAoJENro4Ql1lpzl+88QAKxA aAg/02bXucX9VgcwH02ndsg6Vg5vPljbYRY/BUrXs9G5u4xSRPRYfgBJ+3+AVkdkNC5UhWaIfpk h6aLTRWNErDGVk++dnujOD299xgyb843QEix5IvlpP0VXphh56iXGul4Z+rj+jWZzb45ggQM73e nMF2EVkt69h1PtN5doD7J/VSDv4m9d5Z4qoJadfXrDQc9jkAAuYjQ+13PjnUmVvflABflI6S56/ +sm6BY+uBowH5cIX/XJhn5roGAHQE93UeBgZcdqf6XlD7RX5MxjZ180iJPOtwMqNuzyJStmXqz4 44Y5YaV+JYZp2G9irMFULfhmI6wyfmgc2NPcdMynMA1FnrNwpi3hXGzAHeD3b3kEC4vrkagWmWx WB21LQdECZnXX8bBFFJ2tVVi8WOcM/jFgfk3l12vFBMQGuIUf59ZRGwSXdSwujEoSUS3RxciRhJ vN75AvBfPTJrbH4foZRvfvGyaPcZMQluh70eIGF+mcjoghV35bdb0WzvoTxRQjQu5Z+7UMCSjFE T/mHvrngjbHrxci3V+UzMTNR3ojCd6zvzzKfGBbF6llRzPromLPIiSIllvsmtYCaKz+esgdR5xZ gfCziUa150RqDhRj0vfyTJqFYaAEcxLWLYrFQMN2/N/qG0sIrngCkjfNS8Dtnt9ZRY9oYEbyBiM s45qc X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1778918479946158500 Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/display/xlnx_dp.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/display/xlnx_dp.c b/hw/display/xlnx_dp.c index 2486d9e5825..98126ef320d 100644 --- a/hw/display/xlnx_dp.c +++ b/hw/display/xlnx_dp.c @@ -570,6 +570,12 @@ static void xlnx_dp_set_dpdma(const Object *obj, const= char *name, Object *val, Error **errp) { XlnxDPState *s =3D XLNX_DP(obj); + + if (!s) { + error_setg(errp, "%s cannot be set to NULL", name); + return; + } + if (s->console) { DisplaySurface *surface =3D qemu_console_surface(s->console); XlnxDPDMAState *dma =3D XLNX_DPDMA(val); --=20 2.54.0 From nobody Mon May 25 13:48:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1778918433; cv=none; d=zohomail.com; s=zohoarc; b=YwfgzRJXgq/2Xa/d9kgdqNJYuNmppjUa7DIoOA0GOXAmav2K1JeBWEfLu/1LHvwYXf9Ogz9NcBefZp43oyVk1BdFiQKctYgpEtilWYBLPdVE24bDxlpltUhJnYyMBhagvdqrrh6VhESlh+PImW1tc6ZfEf0cq7xlmiPgQJS3X1I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778918433; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Svp94K9ltl7osqc8aHL2v+NM7N1LmXuvHp5XMBZkMxE=; b=RRx6Swc1j8pE4n6Jl/i/nqYqMs6VoWwj8qYs5v+7PQ5O54lVX7MkQnP+wwQI1O5ITPXDOq/un8+aN3edeUIEer9KCVpQoee3VG6V0/O6GO5eYDm9o1Tu2SCZBEYq7cJp5VMOy+2UaakTDgnLDgXJa0wkv/7QJKhDmpyylQA7gAg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778918433736861.465530988292; Sat, 16 May 2026 01:00:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wO9wg-0005cr-RA; Sat, 16 May 2026 04:00:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9wV-0005LP-KX for qemu-devel@nongnu.org; Sat, 16 May 2026 04:00:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9wT-0007RC-EU for qemu-devel@nongnu.org; Sat, 16 May 2026 04:00:14 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-607-QbR6auFVO6az4tPXj2roRQ-1; Sat, 16 May 2026 04:00:10 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BE5AB180034E for ; Sat, 16 May 2026 08:00:09 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9E6DB1800349; Sat, 16 May 2026 08:00:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778918412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Svp94K9ltl7osqc8aHL2v+NM7N1LmXuvHp5XMBZkMxE=; b=Qd09JKlVOUlhbYF4gPw7QXfkWiEkptzQc/8SBRuKOAXf3K4l9TZt4WEKnlDRlWJpId58dY RJRUZ29ptKZknAWKd9R6ttp8iM7Y6WJsli1xfrS8TeClKL/eg0JmfMhPq+5HH4hLMgZHm+ a4kmabkC2dzUAuQqX4I7bFzum3jyX1s= X-MC-Unique: QbR6auFVO6az4tPXj2roRQ-1 X-Mimecast-MFC-AGG-ID: QbR6auFVO6az4tPXj2roRQ_1778918409 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 16 May 2026 11:59:08 +0400 Subject: [PATCH v3 09/24] hw/intc/apic: move checks to realize() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260516-qom-tests-v3-9-3f20c3a029a7@redhat.com> References: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> In-Reply-To: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=2954; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=M65iE9wl2UK083ridVP7VDYH3qQY8kBa9mO0RUTKoIE=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqCCPP1XOm7SuEKzvDbeSugf4S+Ni+m5ZMLTxuw hTdiN68drWJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaggjzwAKCRDa6OEJdZac 5SCPD/9MxYEL2/cIRvbweAKeug7NAUArNO1LMdzEchkaASneoJMC806R13nKh0bc7c5qlEYoMOc rqlq4l8hoaqYTiQQ2Lrz+ZAK0WVIISEWBQopj/znZHxQ//zpVt3hDaBhTRf2PRcLFwXI1jcs1fk +E+OijBGyBKSXSgMf7Af2HYMXAfhmKB4CTo0UTqMRB5MuGldm2dImtv6D2D9ilAv7eDGfYCQ6fe ThCFHEIb5mxUNSi3s19TeWptQSI/V0X685V3az9Be6GLWW8fzoRCEVPCi2mJDpZG2C5Wp6GMxi+ 9Ur6Gup1+KXUnoWLn9REUMDogCENUuH4j7zC9K2yJ/e3762R4taktXGkcwoQ4ACD4RhciYjpX8a EgPq7jAf5DQ9eOmrSFOmD06zH9ZFzSCf/Z14CdvK7sg5z1JtGopVWEGXGFAr/9OqQmpK0gYMoH/ BoHv+klWEmB4fFk625Ktl5UZw9iOqAh1scrE9cK2QmP2zBZfyoR/zB/lVE8yextAiRPi9VZpkuS PLjS4SLppm+lSP6D/SO6dow9MZN65f/OJukPLSb5O9LkTB3YlA8GWXtZOIrsF6QkqMWKT+aoRat UtmMKcdLD+O8vWLyeFL/+pVw7fZINb5kNDt/14f2fSiM8ACoKL6K5fsVwsU7sjGwuEDq87uBTPK T4jfqNHRhVwtESQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1778918435647158500 apic_common_set_id() dereferences s->cpu to check for x2APIC support when the APIC ID is >=3D 255. On a standalone APIC object that has not been attached to a CPU, s->cpu is NULL, causing a segfault. To solve this, move validation during realize(). Fixes: b5ee0468e9d2 ("apic: add support for x2APIC mode") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/intc/apic_common.c | 23 +++++++++++++---------- target/i386/cpu-apic.c | 6 +----- 2 files changed, 14 insertions(+), 15 deletions(-) diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c index bf4abc21d7b..49c03a5bcee 100644 --- a/hw/intc/apic_common.c +++ b/hw/intc/apic_common.c @@ -257,6 +257,19 @@ static void apic_common_realize(DeviceState *dev, Erro= r **errp) static DeviceState *vapic; uint32_t instance_id =3D s->initial_apic_id; =20 + if (!s->cpu) { + error_setg(errp, "APIC is not attached to a CPU"); + return; + } + + if (s->initial_apic_id >=3D 255 && + !cpu_has_x2apic_feature(&s->cpu->env)) { + error_setg(errp, "APIC ID %d requires x2APIC feature in CPU", + s->initial_apic_id); + error_append_hint(errp, "Try x2apic=3Don in -cpu.\n"); + return; + } + /* Normally initial APIC ID should be no more than hundreds */ assert(instance_id !=3D VMSTATE_INSTANCE_ID_ANY); =20 @@ -410,7 +423,6 @@ static void apic_common_set_id(Object *obj, Visitor *v,= const char *name, APICCommonState *s =3D APIC_COMMON(obj); DeviceState *dev =3D DEVICE(obj); uint32_t value; - Error *local_err =3D NULL; =20 if (dev->realized) { qdev_prop_set_after_realize(dev, name, errp); @@ -421,15 +433,6 @@ static void apic_common_set_id(Object *obj, Visitor *v= , const char *name, return; } =20 - if (value >=3D 255 && !cpu_has_x2apic_feature(&s->cpu->env)) { - error_setg(&local_err, - "APIC ID %d requires x2APIC feature in CPU", - value); - error_append_hint(&local_err, "Try x2apic=3Don in -cpu.\n"); - error_propagate(errp, local_err); - return; - } - s->initial_apic_id =3D value; s->id =3D (uint8_t)value; } diff --git a/target/i386/cpu-apic.c b/target/i386/cpu-apic.c index 5599a4675c5..04b7257ad12 100644 --- a/target/i386/cpu-apic.c +++ b/target/i386/cpu-apic.c @@ -56,11 +56,7 @@ void x86_cpu_apic_create(X86CPU *cpu, Error **errp) cpu->apic_state->cpu =3D cpu; cpu->apic_state->apicbase =3D APIC_DEFAULT_ADDRESS | MSR_IA32_APICBASE= _ENABLE; =20 - /* - * apic_common_set_id needs to check if the CPU has x2APIC - * feature in case APIC ID >=3D 255, so we need to set cpu->apic_state= ->cpu - * before setting APIC ID - */ + /* cpu must be set before realize, which validates the APIC ID */ qdev_prop_set_uint32(DEVICE(cpu->apic_state), "id", cpu->apic_id); } =20 --=20 2.54.0 From nobody Mon May 25 13:48:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1778918489; cv=none; d=zohomail.com; s=zohoarc; b=Cq0XC+7An+tFE/3i1XSIPiqdllFO10wrMf7rpgwCbIfI/I70GgwXWVfGBT4NwZwi8bkFyjoZ5RQgt3WsLHLOdPy6qSeQnB53vEH1idGVZk1b4skyHb0y4qj+yh/r6bCry/jWgXS3wWXGnYucSkGBVdlqbuq1zY3P5ENJxLZv9UE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778918489; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Feyzoi72st3BK6uw08MumeJ0heMFM0ajonX0WOp0f0U=; b=GOcJYuGsFSJbXAuIvk0o0iBjE/HgUzbNhGjI6Eyv7NJ9VW12Ept9KqP03JzQaeM16PgLgHpIclq+Q61lBD9aHvyRTN+3wfvt03voxyMKxkW1soufIckOq+n0EVm5TPLT80GmKk7ZF2FobGE9rokRIHLciSYG63M3lTi+87ONRbw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17789184898647.288804566029171; Sat, 16 May 2026 01:01:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wO9wd-0005TZ-Tm; Sat, 16 May 2026 04:00:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9wb-0005Nr-7c for qemu-devel@nongnu.org; Sat, 16 May 2026 04:00:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9wZ-0007TP-H2 for qemu-devel@nongnu.org; Sat, 16 May 2026 04:00:20 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-693-34Qqa2qrM564gibyahUvxw-1; Sat, 16 May 2026 04:00:16 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B1E1F1956046 for ; Sat, 16 May 2026 08:00:15 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7AA2518001D2; Sat, 16 May 2026 08:00:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778918418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Feyzoi72st3BK6uw08MumeJ0heMFM0ajonX0WOp0f0U=; b=ZVbD47+Ng+q1k8SKktsGbIawKZ2AByC8XcVgAeENINVX4KBdYkpSxPgDwLF4LVyOIvgtO7 9QCiQhPOjg0UdVStUJcJdKS7wd6wBT6+wEo3WuBisfi1CItwiDgFEAPsUwqnAC5vlRVKnn E0Ts8PzBnNhUCAt59Yw1/iFLEMJeDG8= X-MC-Unique: 34Qqa2qrM564gibyahUvxw-1 X-Mimecast-MFC-AGG-ID: 34Qqa2qrM564gibyahUvxw_1778918416 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 16 May 2026 11:59:09 +0400 Subject: [PATCH v3 10/24] backends/cryptodev-lkcf: skip cleanup when not initialized MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260516-qom-tests-v3-10-3f20c3a029a7@redhat.com> References: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> In-Reply-To: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1186; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=XKESI/0DSqdUBTRFIDl2KEKlv25ZaJ+0o7RYfGRaK9M=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqCCPPXjoFYqe82ja7TeolINHMRI0XBYapOmkZ2 3rAWE/bXcOJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaggjzwAKCRDa6OEJdZac 5SGsEACDYr0SxoYLF/VScqblNrVaiqwORbiOd2bZ8ddMRNXQ0ZBbs5hoz+8JM7pNfhzHy1xcCMa wFJOeInRjjLr7smSIQgAWCKTrCXuZl5ErBRRhyeWbPm3QTSEfZ6sIX1ponFad6I3j06bDJUXZRH K1cn/dIIT7RfAOkLcT7kjtZp5igqVuHWZx7rIEvvyurFxmNi/67kBeNTRccENlFPGo032yv1Jt1 VeAGJPUqiEsoJGUjQJ9UhRbTLT67mI7qDo8Hbli/iSPQPc6FPpV9hRSEqBcjIcF4xmN1S/dyv20 /B9EDcLkVAi4PjjeoVqeJYixABQF6h68H6uLcd0E1owPIrJI1eKa7+661CE76I+T7MLiMxxIyCp +/BwdLc895q+Sg9+vcxJbebBbiKQdY02ZkHNvtop5O9AKSKmkDRrocywoPLjBFOnsXeUydLS76c Nzqq9H2kruOU08iBNNHOvEQcVIIFtatHn5wg08V+cSBDtF8uncVganMNfAYZZ1XOMXLXuHy/UzB 4sxJbAePtUJmmAdUQPoAW02oRzGDsv7UwmDqEG8xeG74bNVWxC7zfIg6nV47oBAI/jFdvXm+mrv pP7lnyU422d2k2cay2rMDikRQlPADZzDaIpu0W+vVbGU8jsZ346HlrAr1KUwQxdP5Up/y6xgQ8y HTillYk9Wvdy20A== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1778918492303158500 cryptodev_lkcf_cleanup() locks a mutex that is only initialized during the init vfunc (called at realize time). When the backend is destroyed without ever being realized, the mutex is uninitialized and the lock aborts. Return early from cleanup when the backend was never started. Note: it looks like cryptodev init/cleanup callbacks should rather be regular complete/finalize overrides (calling the parent method). Fixes: 39fff6f3e8b3 ("cryptodev: Add a lkcf-backend for cryptodev") Signed-off-by: Marc-Andr=C3=A9 Lureau --- backends/cryptodev-lkcf.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/backends/cryptodev-lkcf.c b/backends/cryptodev-lkcf.c index 40c7bd3c5a0..3fe29d3104c 100644 --- a/backends/cryptodev-lkcf.c +++ b/backends/cryptodev-lkcf.c @@ -255,6 +255,10 @@ static void cryptodev_lkcf_cleanup(CryptoDevBackend *b= ackend, Error **errp) CryptoDevBackendClient *cc; CryptoDevLKCFTask *task, *next; =20 + if (!cryptodev_backend_is_ready(backend)) { + return; + } + qemu_mutex_lock(&lkcf->mutex); lkcf->running =3D false; qemu_mutex_unlock(&lkcf->mutex); --=20 2.54.0 From nobody Mon May 25 13:48:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1778918460; cv=none; d=zohomail.com; s=zohoarc; b=hwOCleeUQ9Ey0hsHOjeoKmdNmx/Ekhjgw4M0G6e1s8wFAWyJ2nYdP1PKSJ75s5RKv+j2vtyoSD8iRas8th6Qy35omtJZ2V3ph0lWHewn083nx4IxTxTxvx0j1QoEGdAhLQOG0flXoKX3auNb2/CZ7aPFVBKB+4bwlsPOSu8PY1Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778918460; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=yus4S2SYQUMLq1BDWUFN2FdE2j7nuREFMtVonW6qulI=; b=V5q/JmXrUKFMOdPtcQ1uAY0qbgk3K8o9V4yM5fodB3wnhRJMU3i2jee65stnizHaLon84WcMKVjhhyg8XSVbY1lwVzT8xDuz6q6BqxUSTHEpisXzKmLVtS6sCFTxzAnN/EgAUNkKywgBl9qIlIntQVcrMGGyGqN0TptNf/Kb1II= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778918460379853.2238497602289; Sat, 16 May 2026 01:01:00 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wO9wi-0005f6-QB; Sat, 16 May 2026 04:00:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9wg-0005d2-Lx for qemu-devel@nongnu.org; Sat, 16 May 2026 04:00:26 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9we-0007V6-Ug for qemu-devel@nongnu.org; Sat, 16 May 2026 04:00:26 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-423-4GgyQVPHPuiWYhPMFZaWLA-1; Sat, 16 May 2026 04:00:22 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 879DF180044D for ; Sat, 16 May 2026 08:00:21 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4A1B11956053; Sat, 16 May 2026 08:00:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778918423; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yus4S2SYQUMLq1BDWUFN2FdE2j7nuREFMtVonW6qulI=; b=LAl67H8O3WvQvy3YUXyeYfqlRe0uw+We3MeFFlvGt/F/NE4ZizakNV+lkhe+6AZiS761C+ nk3oPlFaWEjcYtdUc7fdZmA8QvkwXuGaQ30jTTNzjet2yXnmnjyUtfluo/km6Na8INDp75 lcq1wMWZ9tLBwgmYHArgbnvexx48qwM= X-MC-Unique: 4GgyQVPHPuiWYhPMFZaWLA-1 X-Mimecast-MFC-AGG-ID: 4GgyQVPHPuiWYhPMFZaWLA_1778918421 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 16 May 2026 11:59:10 +0400 Subject: [PATCH v3 11/24] system/ioport: minor code simplification MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260516-qom-tests-v3-11-3f20c3a029a7@redhat.com> References: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> In-Reply-To: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=964; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=2PuZ/fAeys+M9YO5aUenOHdoFB4NeVEhYzeigXek6MU=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqCCPP0Jth6b2xjBk2JXtWayEHtuRBcdNJSdyGh EQ+JmSXrLeJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaggjzwAKCRDa6OEJdZac 5VpoEACQK5kb2zosHNXR3d39lOPLUvDxG+8mTpche/WUYWnhzzDES9Cy+r9eJATi4e9FZisQ/X9 vr+kwwPrCom7J/qF7WIBktbbmm3qJt0bTRSWhWmIiI1yiSpJ3TXY3JqgoyQ9rJIAQx47oqF8OIO 3Ug908nU4mdN+QTIjcpMena5+/vbacobRWAtcEZBpS+I/xNidvJFCbztCBkenUxDXdaILXFyb9q enJ86RRJ45KFj0u9FuimFvdCROre7BsDlA7ebjXTLQ2UzQ/mA4prsX3hbSA41Ab5i5S5FIOpaI4 vjVsJEj3RC0fzH0t+7tnTLPqxkEAnhBUnroANGq6A4WfowYhhyWD1+D1G4snHZGHxEIH2ara/2Q XcIPJsO8XakNgc0vjk9Je0agfU3ap43jqdqJHoX6R0v4E7PGpt60E3AXD+jX0bsOUN32xsA+x9A fKPsm0ya2UmerKhaUlrfpTATf+XgeJH1tHQo8/M+3h7T5dEy349Nut+ZUJJxQ26YqvAYihi3ijH CLfxp5d+iOnp228gnFpeoWwJrAN6T4/F4VSr8vsBGusCBvB67e9MPhdY6X+oZhecP+aKTrGe0ch PPlxV7jbe6MkRqLHE3pKO2B/9y4LQhmxxbW1roKKLslPL6JrN5NlE2WtKcBGtLue/pW3c8JP1dt KF4j1LsdWsnvreQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1778918461717158500 Drop needless memset() and replace g_malloc0() with g_new(). Signed-off-by: Marc-Andr=C3=A9 Lureau --- system/ioport.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/system/ioport.c b/system/ioport.c index 1a0e01fd06b..0a1b80f2994 100644 --- a/system/ioport.c +++ b/system/ioport.c @@ -230,9 +230,8 @@ static void portio_list_add_1(PortioList *piolist, mrpio =3D MEMORY_REGION_PORTIO_LIST( object_new(TYPE_MEMORY_REGION_PORTIO_LIST)); mrpio->portio_opaque =3D piolist->opaque; - mrpio->ports =3D g_malloc0(sizeof(MemoryRegionPortio) * (count + 1)); + mrpio->ports =3D g_new0(MemoryRegionPortio, count + 1); memcpy(mrpio->ports, pio_init, sizeof(MemoryRegionPortio) * count); - memset(mrpio->ports + count, 0, sizeof(MemoryRegionPortio)); =20 /* Adjust the offsets to all be zero-based for the region. */ for (i =3D 0; i < count; ++i) { --=20 2.54.0 From nobody Mon May 25 13:48:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1778918544; cv=none; d=zohomail.com; s=zohoarc; b=MY+tK6LNdmZPkSBB0R9JnJ+Wk28qxOUzzsGl4bkCepVMV4VEqu/NOdEKGBdU20hZcyHbkRPd7UaEbp1NCFJTYjjlaimqnS3S9/nOtjETl0rGe+/U5QGNGPipWpCYwz5OQ8zW7kU3lnwPlBWcnb0NSTlH4m8cStDE4ZR5w5LGsWY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778918544; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=2eZf1p5B9iU/LpmdGUTPslOXBQR4xs83NdisiayIy0Y=; b=QSW8RqQbgu+Qi38NWxmGll/3z8n0IpwlaZjFwAhqJCuFI9syykRRB9dKS1Q64SiHz8X9gu/n7D0razuK9UzwFa3JG8oqbftFHf6DpZ1tPtMaWNqK+uTq2Yr5uKfdZlzehZHwCnsGKeCVsReLiXp0xKBWLpDw3HMLlZ2VlOxe2VQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778918544693442.0317198535038; Sat, 16 May 2026 01:02:24 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wO9wo-0005rb-KC; Sat, 16 May 2026 04:00:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9wm-0005nr-U3 for qemu-devel@nongnu.org; Sat, 16 May 2026 04:00:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9wl-0007aO-DL for qemu-devel@nongnu.org; Sat, 16 May 2026 04:00:32 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-481-ndEpO671MNqBoSP6DSmlcA-1; Sat, 16 May 2026 04:00:28 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B9DED1800344 for ; Sat, 16 May 2026 08:00:27 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7DDD330001A2; Sat, 16 May 2026 08:00:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778918430; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2eZf1p5B9iU/LpmdGUTPslOXBQR4xs83NdisiayIy0Y=; b=eq7ZdKkjKEM08kcMH8dDVUPNOsePRQsC8Vn8RRb+z1dGZGJNlXjjToEOMYRqclhuUT0ohS U5wuHDUI2fxt+A5f9evvsCBZGVwr9B8shmjgHIUXkTbYHczFvlK/N+UQGEsBMSAulAzlW+ HkQIlZZJ1mA+dNESCMzJAYhgKBKU8RA= X-MC-Unique: ndEpO671MNqBoSP6DSmlcA-1 X-Mimecast-MFC-AGG-ID: ndEpO671MNqBoSP6DSmlcA_1778918427 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 16 May 2026 11:59:11 +0400 Subject: [PATCH v3 12/24] hw/core/machine: free shim_filename on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260516-qom-tests-v3-12-3f20c3a029a7@redhat.com> References: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> In-Reply-To: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=718; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=E+Mw/r+U2Z/IIOcJlVsJmQHnesFU93bUUoyxJd97jjw=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqCCPPNHBG76GY5F443n9VgJBZjkx386ayBoz0d p0wRjYXwg+JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaggjzwAKCRDa6OEJdZac 5RGDEAC2SxBsuLxLcmIVUv36KojDsdKp5IyqZWDhPykGvfcbDPL0xt6g4FYQv3iz5m3E2Ab4Svu 1VGelwgEOzs1EWJDJFB+nTG26ubAMHs7CJyzIMQwxNekdfoMxkdolPsCH5ODcZT7HKNx5lSDI/w ide9HEBF8pingCcAowY022zbTChXvXCOBHuBZyXzBistrkr0uKBeo7p8R8DB5KaZ7AI0nzKmp1o +8htqe3DhAJSxQ6YwcPLBu+cRSPW0TNTr5h64bK2uXUxrnHuoBHfqy3dhFJkc4g6Tdu1avKnvjs VU3KbzrUtFWtN/3FyD2wS03F5QZe+njx3P5zAdactD8oY82k0ueK4bUDJRYEhV8V1wjdomEqubu 5vU28mh/c/xGJuw4u7vEOrdwznPD401KbBouJLOu6PO1C9+MU1voOkNpBMwuYfU01hs6pndzAlO V053qBSctxJKmulbqQJ+vu6fDnfI9kfS68IhDQabYACM+ol48UkoTItYeAQFd7M799Xp0cpMLuD VsdmDEKftMP62QwlV1fcfv94YrKTShVrcAeAI/r/4QRTLpwabiFeSqF0lR/H23sD6GxQVIq5QnX ABhu6AVRcGN8nBFsS7rwSazjlqW+ZM4ots8zRIm1N+Z8CiuTUJ7E3srz7E60Lk5idYoBWVb/CH/ uN5hUS4d94VIypg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1778918546426158500 machine_set_shim allocates shim_filename via g_strdup, but machine_finalize did not free it. Fixes: a5bd044b1579 ("x86/loader: add -shim option") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/core/machine.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/core/machine.c b/hw/core/machine.c index 63baff859f3..95ddbf472b4 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -1284,6 +1284,7 @@ static void machine_finalize(Object *obj) MachineState *ms =3D MACHINE(obj); =20 machine_free_boot_config(ms); + g_free(ms->shim_filename); g_free(ms->kernel_filename); g_free(ms->initrd_filename); g_free(ms->kernel_cmdline); --=20 2.54.0 From nobody Mon May 25 13:48:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1778918449; cv=none; d=zohomail.com; s=zohoarc; b=GIsuCDc58Hsz8KHZ0BiyIT7BZK2/jC3MHW1AQPp6MxQbzYEe/JYseU9u0sC60BFzheTgQSoi6cfvvku+27sa8YQ6rXkJOjEgzAoX7KG+ZSsyeAxhrN06/zSFBtgG/OJ7w+BenzFK1f1edP/pQ/uFnMAFkQhaPjNm825P34ZUFqg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778918449; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=7Zb/FpFPrbLibrxoVP3tYb6acmE/CqanuyqC4h8y5uk=; b=mKVM8khwo84e3T1L68/CGazHRDzOQCKUQgGMtGkBPBrcHDknRxnlBplfak/M5FZyX793t9biDZMCOWGccfQk+wfbJEih1i0glGUT+MAwCwx2V8UWmnk6FAlzxEnfFfH9UmzCO4/bEi6UtEqkSKpupsY6abGVRBrCPzGe1Gwk6Bk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778918448808378.76950147243565; Sat, 16 May 2026 01:00:48 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wO9ww-00068j-6S; Sat, 16 May 2026 04:00:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9ws-0005xn-2M for qemu-devel@nongnu.org; Sat, 16 May 2026 04:00:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9wq-0007eE-N9 for qemu-devel@nongnu.org; Sat, 16 May 2026 04:00:37 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-1-pFJs5tZoOOuHmtgu4eyEOA-1; Sat, 16 May 2026 04:00:34 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4702F180035D for ; Sat, 16 May 2026 08:00:33 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0413030001A2; Sat, 16 May 2026 08:00:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778918436; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7Zb/FpFPrbLibrxoVP3tYb6acmE/CqanuyqC4h8y5uk=; b=WvnWBSdCB4YpLdM6FZJzGwtPPNHBFRIpKUAar/mFr0cJL+nKoYJJOubEV8a74Hc4dK4clc CIgcw2+ZbdV46c3qpaJW6d3gexwRI/E1i484+pt9AdWaYJsgq0NheJvU8uVn5Sq3efnog5 x2soQaxRJCbQZraGky9FrgxRjVbWwIg= X-MC-Unique: pFJs5tZoOOuHmtgu4eyEOA-1 X-Mimecast-MFC-AGG-ID: pFJs5tZoOOuHmtgu4eyEOA_1778918433 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 16 May 2026 11:59:12 +0400 Subject: [PATCH v3 13/24] net/filter: free old values in property setters MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260516-qom-tests-v3-13-3f20c3a029a7@redhat.com> References: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> In-Reply-To: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=946; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=0eCsezpNELUdUnbutLXfx310v4EwSLLeUmGSWbqSBBA=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqCCPPeRayCQ/ur6ynVil2TDtgWKFhjbCe+SyIX VS/ByV/btCJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaggjzwAKCRDa6OEJdZac 5V+6EACt4DHIHrVo7ACjK7JnCE35N0KDVgxyEzDcr0hLYX9Qzp9Z3xzKHv1459XRkv2xpCLx4m2 /BJKiTDnXnG6asMNxlT+lfYjqNgb2XiDUmnvKcZse96DRlDqgj0mdvrZgrgQSn5RQJHrW+7wNCn Acd5rBfAJY56abLVux69jbpPDkzFaHgRw/WHrISqi5piePM7GEq6vuc5tePL9YYrWDPGfL6o9KQ On+WcKqTK3GsuC836pb5t5tNJ9AsC+OAUsef/uzrpnGoZQnoFmtgiBCervorSA3DeE3FgKbEdCx vUzRKWkJ4WN7+IohOCSzCD6UmgSSHdyvFffMneHB5noy04TeqLMExh3en1ZY0ohhu512hwpLcz3 29OR9Tbo+/+y7rihROAw0O9As0z4ZJ6ibaPauRMLHHLoXaLatxEvzE70CxhQh+F3iLikHGGsSfb xnI/ekBbAO2Ge6zjBFnRYkkgneFWDfNhMRwDG1/+I0/25T09iDlFULBTmS7heJbhwgFgBkjK6yS Cye34gkGaIW3Z+mYoIIqEEo1PbnJiFyB5c/TisZaTpeYb3Ho9kF+ERcCA9yaFuNMTTJR3Izsl+h NanUCrFTy4cy8PLybqG6VhkvsOBb9Xhiw+v/78obmqdL5/rmfAHcPRmOsgAVoXdNFim4Myq7wZB +6u3vnIeWVzCGLQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1778918449675158500 netfilter_set_position and netfilter_set_netdev_id overwrote their respective fields with g_strdup without freeing the previous value, leaking memory on each property write. Fixes: fdccce459621 ("init/cleanup of netfilter object") Signed-off-by: Marc-Andr=C3=A9 Lureau --- net/filter.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/filter.c b/net/filter.c index c7cc6615dc9..389f3b0bfef 100644 --- a/net/filter.c +++ b/net/filter.c @@ -130,6 +130,7 @@ static void netfilter_set_netdev_id(Object *obj, const = char *str, Error **errp) { NetFilterState *nf =3D NETFILTER(obj); =20 + g_free(nf->netdev_id); nf->netdev_id =3D g_strdup(str); } =20 @@ -182,6 +183,7 @@ static void netfilter_set_position(Object *obj, const c= har *str, Error **errp) { NetFilterState *nf =3D NETFILTER(obj); =20 + g_free(nf->position); nf->position =3D g_strdup(str); } =20 --=20 2.54.0 From nobody Mon May 25 13:48:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1778918560; cv=none; d=zohomail.com; s=zohoarc; b=BGxgUDXQLSg3j7pfmJrzp7CHQtrh22jAUBR8Ag1bYZIJt+PaGE1ukvTVGxK8hW2GAWFKYDaV2oMoQplQc7PDlJ0CIkFDHRk21gp6RFPjGvk2v+Y3B/lRpjXjxsCa+4s9hJZ3rPXLjrCl0mEMcdi8fF4B5H4xzr5X19Viznr3qqc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778918560; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=VaiKNF5z9BmGchFrS9aThsXCf67S5QKfxJZYcnafPOM=; b=TQbBMB1aCCRAqtjHYTZQx1Ff8g3Ff0Mr7mPHFIFrwCi10e4TtpB6fV8DRWbKItDmpO0fdh9Nigvauw1qh8j9G5Qnd4BxTbDsxitPCnAi//mlAxsnzcysRrP+6madLAOKJyZWfSiOqigimBbQDkXc8fvLKMAsPGjsWPCkzNL8WaA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778918560941907.6371394474307; Sat, 16 May 2026 01:02:40 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wO9x1-0006XG-Rz; Sat, 16 May 2026 04:00:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9wy-0006JD-51 for qemu-devel@nongnu.org; Sat, 16 May 2026 04:00:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9ww-0007i3-BV for qemu-devel@nongnu.org; Sat, 16 May 2026 04:00:43 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-241-GzXesM3wP3uu8WvGNGGN0A-1; Sat, 16 May 2026 04:00:39 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C784F1800359 for ; Sat, 16 May 2026 08:00:38 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 847521956053; Sat, 16 May 2026 08:00:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778918441; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VaiKNF5z9BmGchFrS9aThsXCf67S5QKfxJZYcnafPOM=; b=AJi9olTnz/QZTz/mrhWoPMqltQLAticiSgwvrnRSXy4FTI0McEtiYT2mN332Fm/eHOsojM MprAyEc+itdujsgyn5qwbAf4VRCuUpO/z4kRsa7muRb7wzLW3cNM3Y5uTyfY+PiinN49re KW0EVMRhlWMflYWZnt6uOAxgJvM70+8= X-MC-Unique: GzXesM3wP3uu8WvGNGGN0A-1 X-Mimecast-MFC-AGG-ID: GzXesM3wP3uu8WvGNGGN0A_1778918438 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 16 May 2026 11:59:13 +0400 Subject: [PATCH v3 14/24] target/i386/sev: add finalize functions and fix leaking setters MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260516-qom-tests-v3-14-3f20c3a029a7@redhat.com> References: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> In-Reply-To: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=4011; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=cEcba1U4LTKDpIiK4YznFcHgQPU/xi7jFmGyPMMSfCY=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqCCPPuiW9IXgPLMP6vN8sMKY3tEbGtRQ7e0VDf 1Q5Qe+Yw6OJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaggjzwAKCRDa6OEJdZac 5UvpEACObZ5+x1u0lZ1FcVZpGsfTpnxU2rLVLXHoHNgeTys7YWIGRBz+GYFujEpBKs/YQSJ4UNn 3p396CA1B+LLJBYqcP6Qr2R/Ztmy7lXOeutVtdEz5ZNWpiKPNopSfP52UotBBGWkq+WmJu3003b Xv783Zg1CXp3jAvQT+w1osjXBRPgV3Iw866yIkaaJXrDcHWAxtDoo+l5+JMFogk9MQ+rd7cY6sZ ywpqE12Bwy/FVLj2f/4BtISqPfceKLFU82AiVqYgbtFlEi7uL2yHGTBI+m7bcxBndjxEp9GXYhT iuyXu/7IzJ6Cu5eR93N0A4/Ekc40YHIPtalVBkwCGR4JpvhC7Jw26rgN73XvohEeQg1fxo6x7lN 3Qtb65p4sIavh4++ZZNRBiButNaZCljwzKV1GDOW4mQmO5ScUsm/iVTvOAiYYF1IJoJoaSCVKzJ WgxtrSouzXZoEW0mVwrxnTyTQ9T9uUq+hhem4EDW8Rrg8Ta5JzbxTpbZqNCu5hzD5VkDz4a9yPl enQAcc5XiQhZ65SXMS87DqB5WVuVzpVGDyqhOO20xrj0xdzERaVT9YAwfoHgY2w6382eu9QonMu CgGDyW5uhisdb1Zj5QmUMfasKnSKuNuqCiN6h5PUTHEeENO7dnFzTu0m61LAh2brcOuYXxkolEn ej7bwb8FtG/K5Rg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1778918562649158500 None of the three SEV types (sev-common, sev-guest, sev-snp-guest) had instance_finalize functions, so all string fields allocated during init or by property setters were leaked on object destruction. Add sev_common_finalize, sev_guest_finalize, and sev_snp_guest_finalize to free the allocated fields. Also fix sev_common_set_sev_device, sev_guest_set_dh_cert_file, and sev_guest_set_session_file to free the old value before replacing it. Fixes: a9b4942f485b ("target/i386: add Secure Encrypted Virtualization (SEV= ) object") Signed-off-by: Marc-Andr=C3=A9 Lureau --- target/i386/sev.c | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/target/i386/sev.c b/target/i386/sev.c index b44b5a1c2b9..99cf30806be 100644 --- a/target/i386/sev.c +++ b/target/i386/sev.c @@ -2526,6 +2526,7 @@ sev_common_get_sev_device(Object *obj, Error **errp) static void sev_common_set_sev_device(Object *obj, const char *value, Error **errp) { + g_free(SEV_COMMON(obj)->sev_device); SEV_COMMON(obj)->sev_device =3D g_strdup(value); } =20 @@ -2830,12 +2831,21 @@ sev_common_instance_init(Object *obj) QTAILQ_INIT(&sev_common->launch_vmsa); } =20 +static void +sev_common_finalize(Object *obj) +{ + SevCommonState *sev_common =3D SEV_COMMON(obj); + + g_free(sev_common->sev_device); +} + /* sev guest info common to sev/sev-es/sev-snp */ static const TypeInfo sev_common_info =3D { .parent =3D TYPE_X86_CONFIDENTIAL_GUEST, .name =3D TYPE_SEV_COMMON, .instance_size =3D sizeof(SevCommonState), .instance_init =3D sev_common_instance_init, + .instance_finalize =3D sev_common_finalize, .class_size =3D sizeof(SevCommonStateClass), .class_init =3D sev_common_class_init, .abstract =3D true, @@ -2855,6 +2865,7 @@ sev_guest_get_dh_cert_file(Object *obj, Error **errp) static void sev_guest_set_dh_cert_file(Object *obj, const char *value, Error **errp) { + g_free(SEV_GUEST(obj)->dh_cert_file); SEV_GUEST(obj)->dh_cert_file =3D g_strdup(value); } =20 @@ -2869,6 +2880,7 @@ sev_guest_get_session_file(Object *obj, Error **errp) static void sev_guest_set_session_file(Object *obj, const char *value, Error **errp) { + g_free(SEV_GUEST(obj)->session_file); SEV_GUEST(obj)->session_file =3D g_strdup(value); } =20 @@ -2936,12 +2948,23 @@ sev_guest_instance_init(Object *obj) sev_guest->legacy_vm_type =3D ON_OFF_AUTO_AUTO; } =20 +static void +sev_guest_finalize(Object *obj) +{ + SevGuestState *sev_guest =3D SEV_GUEST(obj); + + g_free(sev_guest->dh_cert_file); + g_free(sev_guest->session_file); + g_free(sev_guest->measurement); +} + /* guest info specific sev/sev-es */ static const TypeInfo sev_guest_info =3D { .parent =3D TYPE_SEV_COMMON, .name =3D TYPE_SEV_GUEST, .instance_size =3D sizeof(SevGuestState), .instance_init =3D sev_guest_instance_init, + .instance_finalize =3D sev_guest_finalize, .class_init =3D sev_guest_class_init, }; =20 @@ -3194,6 +3217,19 @@ sev_snp_guest_instance_init(Object *obj) sev_snp_guest->kvm_start_conf.policy =3D DEFAULT_SEV_SNP_POLICY; } =20 +static void +sev_snp_guest_finalize(Object *obj) +{ + SevSnpGuestState *sev_snp_guest =3D SEV_SNP_GUEST(obj); + + g_free(sev_snp_guest->guest_visible_workarounds); + g_free(sev_snp_guest->id_block_base64); + g_free(sev_snp_guest->id_block); + g_free(sev_snp_guest->id_auth_base64); + g_free(sev_snp_guest->id_auth); + g_free(sev_snp_guest->host_data); +} + /* guest info specific to sev-snp */ static const TypeInfo sev_snp_guest_info =3D { .parent =3D TYPE_SEV_COMMON, @@ -3201,6 +3237,7 @@ static const TypeInfo sev_snp_guest_info =3D { .instance_size =3D sizeof(SevSnpGuestState), .class_init =3D sev_snp_guest_class_init, .instance_init =3D sev_snp_guest_instance_init, + .instance_finalize =3D sev_snp_guest_finalize, }; =20 static void --=20 2.54.0 From nobody Mon May 25 13:48:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1778918498; cv=none; d=zohomail.com; s=zohoarc; b=EzrGB9PNI4wgKxRm7fsvFNkOoGs4/R7WHfxS0Em9hz883092t5e2adOdMarDt0Gj1EosnCnVX9h+RRORgU/Krel49SEuS6fJFvX5Xt/9pRLONbHpjzjK9nbTk9mOl33XqLrLYSFVuyyFVkDzzZFJ91pBkJyDhnH3wxAghYTdBaQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778918498; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Cm1yArhtz5sU59WBphWUAJT4oX4EP1pkrBrfy7DzZ4I=; b=jJLH5eYFn1d/h4j73tX9KHAguxgUGlOV/uDETbRy8ftLFxAoSR0Sa/Mi5RT46H8FXxmqHu0/Dsg9USUXygGDf1OoQu4wljesm2of+jyVy9/6xblBCoG4ij8eEohVIzZJhHjnsPdLXPHFvhwuDrDQGpmn58z0cYkYTBAIya1Yk9A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778918498381369.9081172742085; Sat, 16 May 2026 01:01:38 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wO9x7-0006vs-Op; Sat, 16 May 2026 04:00:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9x3-0006ey-61 for qemu-devel@nongnu.org; Sat, 16 May 2026 04:00:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9x1-0007j9-J1 for qemu-devel@nongnu.org; Sat, 16 May 2026 04:00:48 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-475-F_t5smDuNXegxMF4cUb1uQ-1; Sat, 16 May 2026 04:00:45 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 63D881956053 for ; Sat, 16 May 2026 08:00:44 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 320EA19560A2; Sat, 16 May 2026 08:00:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778918446; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cm1yArhtz5sU59WBphWUAJT4oX4EP1pkrBrfy7DzZ4I=; b=Y95IVKq/tD/krZdUHc77EiWicFmxTPBwofddUVNu+1OWOM8KDGK2IJ3LVRE0MEssiUIDdm zu8uZ1otYRV6p79rj6k/Da3N675tHS2dRZZCvglRWwPETzHLp/gXn3TOIAhqCncvH3c8GR V4+MojprzvWAkzAtAdyRm0mvDafNnec= X-MC-Unique: F_t5smDuNXegxMF4cUb1uQ-1 X-Mimecast-MFC-AGG-ID: F_t5smDuNXegxMF4cUb1uQ_1778918444 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 16 May 2026 11:59:14 +0400 Subject: [PATCH v3 15/24] target/i386/kvm/tdx: free strings in tdx_guest_finalize MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260516-qom-tests-v3-15-3f20c3a029a7@redhat.com> References: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> In-Reply-To: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=837; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=MNRXqvTukQ+paxNe0QQZQxRe4jE5rhTlC8L20HzTXMs=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqCCPP/OtfgBQHwhiqz5NIlFFJrZM4xwFJmxjZw LOaQWi61j2JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaggjzwAKCRDa6OEJdZac 5Vf8D/4m7w4u3HvSqr1axC97FrXYYb9oYOs8IJ8p7WaFgTTEyW8Yc9BErxQh1T+7nsYnlY7vs/V KNAPkrL1tXqlNVRAhaXwcpRvuQGMhPLriNTEnpP0TXtOIWeqzDUaNhzRj/gzp84nA7jsXSe2bcw FFrl78ffezCz8j5ch1w2ilhPTepPTcz19MAFlQFNv9bTpAm67G6ht0ri9Mzf6YC6ySSNcS05RY0 IQhPshSJaIFmUbYMu0hxlVd7oqDHUD8t1CaEbtS3lJF/YjERYreJfP6kOw8omASYcodNI4SjZQQ YdwtbHIM8MF+huoMCU+gmN2WzFHbQL4mWziD5VotG+H0xyHgEqC3OzdyQpRG9L7csM2F7uXGk4t tE4qVculjBfeb5YlzC8nJzWBczx55kFKA2m9o3E/u4d3MibKGfgnEccsJBjymhItRhiH8/3DULS l2NouRlFzZsWRFOTItV7SnvutV0/Cb7VY3tSmFJtkiznXuDCkU0ucjGMEyyrF8uNo8HIwLBNCtt f9h27k9eBF7+hE9nOC+Kb5QoFcdbHdtYv5cyy+oRmztRekZKSADRIhn3sIG5vhW7XTtZ0m8cnDi 19BL3D046HGBXw2bQsEuInZ+WqnBZ1zwem8b0bi/B1W4YhimhNa8jhMgzq+SKTijIz1RmkJ9Jj7 D6SnrdLb/SSbv8Q== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1778918500140158500 tdx_guest_finalize was empty, so mrconfigid, mrowner, and mrownerconfig set by property setters were never freed. Fixes: d05a0858cf87 ("i386/tdx: Support user configurable mrconfigid/mrowne= r/mrownerconfig") Signed-off-by: Marc-Andr=C3=A9 Lureau --- target/i386/kvm/tdx.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/target/i386/kvm/tdx.c b/target/i386/kvm/tdx.c index 4714c9d514e..df46fce7693 100644 --- a/target/i386/kvm/tdx.c +++ b/target/i386/kvm/tdx.c @@ -1585,6 +1585,11 @@ static void tdx_guest_init(Object *obj) =20 static void tdx_guest_finalize(Object *obj) { + TdxGuest *tdx =3D TDX_GUEST(obj); + + g_free(tdx->mrconfigid); + g_free(tdx->mrowner); + g_free(tdx->mrownerconfig); } =20 static ResettableState *tdx_reset_state(Object *obj) --=20 2.54.0 From nobody Mon May 25 13:48:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1778918463; cv=none; d=zohomail.com; s=zohoarc; b=k2B3aNaJ/BUSPKxwql/oiAOEqAAOc9x4TeyM+ma+5mSPANi9p0KE8wlHX+PsPMjO0ToVT3C/M9j3uga/gGsB9en3JJz2kG15VmClCATh+ETGeGDnbPJbylAqIJQJkuw2zlYxYW8l/IsWz6XwW32c0+GQ/KrlgU369uSYe4QAbCQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778918463; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=2dJKu4geQlHBf6lMxppaNvhNAzdufK74d/8yyA8VcsE=; b=dWtxldTgUNPpbTjd/Mzltk9gwGyAdT0xPoVuna767Js482UiB+tvQSvKOFrVlkvVufFhUCwFBWBPS+runaf3oBrTJ9wLbME3+p1lRZAMNpFeGJP88g9BWbaVqa8EWqg6omGkB47VWmX96juVtqBTbTQRRYrNVkt3U9C0t62t94o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177891846329922.674043162362977; Sat, 16 May 2026 01:01:03 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wO9xC-0007Xn-8D; Sat, 16 May 2026 04:00:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9x9-0007Es-Vo for qemu-devel@nongnu.org; Sat, 16 May 2026 04:00:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9x8-0007kU-8V for qemu-devel@nongnu.org; Sat, 16 May 2026 04:00:55 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-682-cA0GX_VZNim7EJTBbS2jwA-1; Sat, 16 May 2026 04:00:51 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4FD561800344 for ; Sat, 16 May 2026 08:00:50 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 263F9180075D; Sat, 16 May 2026 08:00:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778918453; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2dJKu4geQlHBf6lMxppaNvhNAzdufK74d/8yyA8VcsE=; b=MS0VfWpB4v+Kc6JIU5bgBTb2nxq3yW6Bf+iTw0t6zB+kbZzZUw8KwOAx/X+c3qhF6UTGVh HyVaB4acZoxaK1ELWxWWUZry1Ocn4zWIRDM68YZ6RnQLJWzs0ryyx0JrCrYdA9V+8FfJZy rZXC81bSfXZR4aHp5UHKTDRRBJ3RH8A= X-MC-Unique: cA0GX_VZNim7EJTBbS2jwA-1 X-Mimecast-MFC-AGG-ID: cA0GX_VZNim7EJTBbS2jwA_1778918450 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 16 May 2026 11:59:15 +0400 Subject: [PATCH v3 16/24] hw/i386/nitro_enclave: add instance finalize MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260516-qom-tests-v3-16-3f20c3a029a7@redhat.com> References: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> In-Reply-To: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1427; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=tbNjVBuNQT1J/I99CQO+THdkJr89PRbTP6A2UGBoPgI=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqCCPP79zOW1ciGncU8WIwmLvlEl1cIEioq7QzD nP3+t2um5+JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaggjzwAKCRDa6OEJdZac 5YeTEACZdLcwoRhgG2vOzcP3rLROimTjjsFmCG0T6AupTyeTxsj/rFDVfr7kwD52AovpfOi2XTW +F0Ys/0vF56lh7WAEDPAvJCvRzhO04MtHBTuPG7P2b21uJqMsl8XCjz15U7rit5wiAqjEAP7DS3 leV5m8pKBlRuRhAGCeI5pZKmwugdDG1XHkXOUzrFzBayAwjxg6hnOpaceSSWEndBp8ij3pGAb3z JXRA93eypixPhkOcAtX9S0Rx5KRCLA6VRgurGtk5kixwucS3nHjQ0/cybNOx0Pm1KRCVnQlgxIk EOPy/PUlxI8O8F+LtXmiyx+comNJs2gzqDdYn9XDYakA6mfre97w48WEv3FIN/1KZb5mJBsUGyZ qKnhZ637WvV0LQDrfuVsDPQ5Tfuf85xBBqsX+CM2t6mE+dT07TFa68QI0Z2PhMBU6NhCHgp5Yew aR4pa4Z5VHYnrqPrbQlXf395Ub09fpA/pAhL9Rd0C8+X+TFVIWPlJPsacdNhYclUT/MSPYSX/lN S1e/WKCunwquh22l+3HVBuIrb3HrS8xR8enBd6EidbyKMz/NXtA7HltYBRJcDz4gx59DahX6xPI YdqSRBkpiJ2U0Mfu1hwyeBdKqKfEbONu1H/LEuoKR0uUZKHupfEEqXW6UqdrfIH6XXcRW4VpqZw 3suPoiNT3bdmdzg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1778918463811158500 Property setter strings (vsock, id, parent_role, parent_id) were never freed because nitro_enclave_machine_info had no instance_finalize. Fixes: f1826463d2e8 ("machine/nitro-enclave: New machine type for AWS Nitro= Enclaves") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/i386/nitro_enclave.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/hw/i386/nitro_enclave.c b/hw/i386/nitro_enclave.c index a29f0044d0e..1ce9ee3358a 100644 --- a/hw/i386/nitro_enclave.c +++ b/hw/i386/nitro_enclave.c @@ -337,11 +337,22 @@ static void nitro_enclave_class_init(ObjectClass *oc,= const void *data) "Set parent instance identifier"= ); } =20 +static void nitro_enclave_machine_finalize(Object *obj) +{ + NitroEnclaveMachineState *nems =3D NITRO_ENCLAVE_MACHINE(obj); + + g_free(nems->vsock); + g_free(nems->id); + g_free(nems->parent_role); + g_free(nems->parent_id); +} + static const TypeInfo nitro_enclave_machine_info =3D { .name =3D TYPE_NITRO_ENCLAVE_MACHINE, .parent =3D TYPE_MICROVM_MACHINE, .instance_size =3D sizeof(NitroEnclaveMachineState), .instance_init =3D nitro_enclave_machine_initfn, + .instance_finalize =3D nitro_enclave_machine_finalize, .class_size =3D sizeof(NitroEnclaveMachineClass), .class_init =3D nitro_enclave_class_init, }; --=20 2.54.0 From nobody Mon May 25 13:48:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1778918520; cv=none; d=zohomail.com; s=zohoarc; b=XhtT7NSlToxukMl+Aj6jKFjQKdi9s/MC0YYjaKWq8BdJW7JDNLiRbQ1w6ac5SBeHWpUcW3mj2EslgI/S1ZqRV2bctsJmcpOU13VAfNJx+MDsJFqm6GkPCnyBnrFuLxpb9CwHkVn56ZQuCV6Knht5jNS7Yp3iOh60ZFx3XxCKwHw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778918520; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=u94aymaMQos4Ok1FqE43DnNiM5L1ZW3yqR+cto55E4c=; b=BpK90zQ1gygmLNInz9FKTTfIMaqV2ZLYf1SyU5hsT3gkle1FIMBj7Hl/6aNS04aU72Fbk+cRqyDzdAX2appBxz9eJIe9aCzmqnb825FZWixNyrZu8CptbVmUCxX1IS6jt92h+ktYDHHjzu72bdSQduw9Q2qEVg6XYP/fyuV320s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778918520872356.8428080553264; Sat, 16 May 2026 01:02:00 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wO9xH-00087B-Go; Sat, 16 May 2026 04:01:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9xF-0007uE-C0 for qemu-devel@nongnu.org; Sat, 16 May 2026 04:01:01 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9xD-0007lY-OY for qemu-devel@nongnu.org; Sat, 16 May 2026 04:01:01 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-XvjIIlTVMA6nxBI9R1sBCw-1; Sat, 16 May 2026 04:00:56 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 032FE195606C for ; Sat, 16 May 2026 08:00:56 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id CD54530001A2; Sat, 16 May 2026 08:00:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778918459; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u94aymaMQos4Ok1FqE43DnNiM5L1ZW3yqR+cto55E4c=; b=V8c7buO6Y6JElkRMf6fwSt6XuSXwO2Qg24F6evk2T8n1st+Aez3gHJvTPXQ7XbkYHMxLXt a79zCBH7r/nHz0vFro7NmbbNLkUxNSTges2vcPYg0xz12DVSbUCtINLQK0czm+xpnoLuQ5 jnFouIPOFG34HoY48F0fUactXBWM5S8= X-MC-Unique: XvjIIlTVMA6nxBI9R1sBCw-1 X-Mimecast-MFC-AGG-ID: XvjIIlTVMA6nxBI9R1sBCw_1778918456 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 16 May 2026 11:59:16 +0400 Subject: [PATCH v3 17/24] hw/i386/pc: free pcspk on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260516-qom-tests-v3-17-3f20c3a029a7@redhat.com> References: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> In-Reply-To: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1234; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=nx/Hm05PL6UbVe3ziRxkh2R3TZg6+6BhzI4zbHucfHg=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqCCPPy8Px4iYVo3xLAAr6D3bC8A6YjjA1DEUfr YuaD1Y7GhGJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaggjzwAKCRDa6OEJdZac 5XUnD/wKHo3AlwLZxfxRM0cCAZB33bckddJtizWd3Ieo9vLZh9SsHE+xLxhI1XnPJDAuS4f4yIo iLEKq7sFeo3jk8aAQAF6JdGWkpBNLe/Wl4KygPQw86RYAyUpIqIwnfAycpEVpf7pjSBcvnVFMlC 5jTdRP1j+DlC97opRglpIfwP3vvYUdi+Obm2SU74M605jG+J/pa8PNycCgPBeeCAKM/4nOS9XM9 3HJor5p4KpXIQM/Se0C3Na3Dj1NemUX8OhF1Ydq4xHyQCMjQLzgdfhFVKpQGUU0DN5rX/AHb2MH lVu1HkTZFfAEK5k5E6vzg6k4+Us5+xAwW+waOkKyJbsOGLRCGL8W3Y9NVCZAN7OrhdBxgtRq7xr jGFVMQxcJNp68lXzW+y4oa2to9yecGoy7irfk2SNwrzM+rBzB0/OqSV84DaKBA/vUNgs+qdF9DF EQvG7Bq8EwfhpEx5PsERzxnBSlhbWDg7qIWFTsyW3WyWpFnqR3uzoUzllhkCNg+d3r5CLl7gGSj dndrAR42UeSWK4VPVTydS8SauE3dKl65lbIotsGIVRAQaRm0LQooWP83fOxRgcbch9jVNVIMmcL I1YrfKNrA9jQ1t9w76pvHMO5CkBPZTSofkfKZI52ueAFPLXXf7fRWWQZmt8O8xLM3k424zbSTET HLdN6cwd0bbYqMw== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1778918522303158500 Add pc_machine_finalize() to unref the pcspk device when it was never realized. Once realized, the bus owns it and no action is needed. Fixes: 6b8d1416482f ("audio: create pcspk device early") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/i386/pc.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 2ecad3c503f..7b6ad97e5a9 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1610,6 +1610,15 @@ static void pc_machine_initfn(Object *obj) } } =20 +static void pc_machine_finalize(Object *obj) +{ + PCMachineState *pcms =3D PC_MACHINE(obj); + + if (pcms->pcspk && !qdev_is_realized(DEVICE(pcms->pcspk))) { + object_unref(OBJECT(pcms->pcspk)); + } +} + static void pc_machine_reset(MachineState *machine, ResetType type) { CPUState *cs; @@ -1748,6 +1757,7 @@ static const TypeInfo pc_machine_info =3D { .abstract =3D true, .instance_size =3D sizeof(PCMachineState), .instance_init =3D pc_machine_initfn, + .instance_finalize =3D pc_machine_finalize, .class_size =3D sizeof(PCMachineClass), .class_init =3D pc_machine_class_init, .interfaces =3D (const InterfaceInfo[]) { --=20 2.54.0 From nobody Mon May 25 13:48:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1778918612; cv=none; d=zohomail.com; s=zohoarc; b=Vy5VQWBID0xt3sNA+iCGshw9bEfJHe8grdSBaziklFfwbj35yYjVNS5Qm5NpagEBT7LWrEQ/3qEKDTQMtV9nZtsrnskO3+ghBc6SW1fBfpe6QrZHHaNJS0r2PNuqDGdncCEdX5xc86ZNUmyYc0aAgGzDKd8UtS6BRLUrADzjQlM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778918612; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=UVBuI+EbJBte7cudwIUDMDVUZlvs1SZgaSQuqt1SPTs=; b=g8J76Voi6Ql5+yYmU7MvK5nHQX7CAK9n5/7bsx143zwCKO/DIOndaZpyD3y7SLM5LY1mSwcp1L7yuFFV1vXti/WWsVtEcwRjFdxah2C3tQu1a8UQYoWwnooSJbfkaGzH6sBjv9JF0cFovXMM7Ux8le0XBquIImf6Qyy54G1J8PU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778918612662512.0845704922198; Sat, 16 May 2026 01:03:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wO9xN-0000KP-FB; Sat, 16 May 2026 04:01:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9xK-0008WV-Uk for qemu-devel@nongnu.org; Sat, 16 May 2026 04:01:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9xI-0007mo-Ux for qemu-devel@nongnu.org; Sat, 16 May 2026 04:01:06 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-215-csKsCjIyNNG7MpOcuzNLDw-1; Sat, 16 May 2026 04:01:02 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D795F18005BE for ; Sat, 16 May 2026 08:01:01 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A74CF19560A2; Sat, 16 May 2026 08:00:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778918464; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UVBuI+EbJBte7cudwIUDMDVUZlvs1SZgaSQuqt1SPTs=; b=NVhox/SOfASvPAYe9iH3vlRizXy3qbo7RaS5rXWGwgJe34UTChEjHnmwjvSK+TRkCOS6lp oopI762KoCOGI9UiZv0Hb+S+UYlM/+LLJtdwHe7RvMrPwawY0zITr7B9FUsjMpasp0FCgh knqICj+82S4ai2babwUUmQb621moh7A= X-MC-Unique: csKsCjIyNNG7MpOcuzNLDw-1 X-Mimecast-MFC-AGG-ID: csKsCjIyNNG7MpOcuzNLDw_1778918461 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 16 May 2026 11:59:17 +0400 Subject: [PATCH v3 18/24] hw/tpm: free PPI buffer on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260516-qom-tests-v3-18-3f20c3a029a7@redhat.com> References: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> In-Reply-To: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1254; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=+gbtJ/99XwN9Q6M5HxsUiEi2wFIXez1EC/KRfHjlUrQ=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqCCPPP3nEtnDdW5+6p/1SiUp9CFyGisVLWDjPK fCBSgHNoSWJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaggjzwAKCRDa6OEJdZac 5VZID/9e7nqnhbv7ZqLFQ8Er+JlATKnq9UOqTl1DSXBTudwhNMfQVt2PQWN7uHUVIVEEFAkQXve 3B7WUn0aKIhlSW+HPgU/r9RQgTJcREzCr3Wy+urDMQrMVZcoRacnmRYFSOSG5wtnpydmySMcGWr m7yylywJBvSx9SgkSlQAObqtaLb8Ty864A8XW2iMfMF5dUUDOkFO4596vo193WpqZ8ZqWzUZLNl wICa9pQctBfpnTNnhySJcradUD4txWTnNh7OSroilCncO7GxraJ3KM/CG5c4X6F7SY1LgYgORk+ xWCehR57haX+WHDZSOrzthlDAGtA75RkEL+wQoiF50NYmZGSA9WEaNb01pzRh5h4GdibbaX6Ry4 nqdVfvYMwxF9Uw4Aqr1KQBj9xbiiMxlkQIDjKjSnnPbc6Et4c24jAPLY5hO0Llphajn3rJgo0Ns 11tCERwQIwXG1ZVbngOY1HOLpDE07DG2EtoknDd/BRiZ49zvaKWimxqU0tKnrKWgedI6rTSRQCn +v/w41uigEA+AQCwktZAbtQ9oVUDBWHt2QsxKCDYu0AIUJ8lqnZy9+3fQ+CZiWRra/2h6SfT09i SBp+EU5r67PSCzO+4iEo2zsnJ5nhmS6hs63lcuUIoH90Wtrrl02H8XRhzhU2ZV1HzVZHckUCdzn 2Goir/rxJYiWeDw== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1778918612867158500 The PPI buffer is allocated with qemu_memalign() in instance_init but never freed when the device is destroyed. Fixes: 46cd2c1050f0 ("hw/tpm: add PPI support to tpm-tis-device for ARM64 v= irt") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/tpm/tpm_tis_sysbus.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/hw/tpm/tpm_tis_sysbus.c b/hw/tpm/tpm_tis_sysbus.c index 6bec30c36fc..3984228c42f 100644 --- a/hw/tpm/tpm_tis_sysbus.c +++ b/hw/tpm/tpm_tis_sysbus.c @@ -150,11 +150,20 @@ static void tpm_tis_sysbus_class_init(ObjectClass *kl= ass, const void *data) set_bit(DEVICE_CATEGORY_MISC, dc->categories); } =20 +static void tpm_tis_sysbus_finalize(Object *obj) +{ + TPMStateSysBus *sbdev =3D TPM_TIS_SYSBUS(obj); + TPMState *s =3D &sbdev->state; + + qemu_vfree(s->ppi.buf); +} + static const TypeInfo tpm_tis_sysbus_info =3D { .name =3D TYPE_TPM_TIS_SYSBUS, .parent =3D TYPE_DYNAMIC_SYS_BUS_DEVICE, .instance_size =3D sizeof(TPMStateSysBus), .instance_init =3D tpm_tis_sysbus_initfn, + .instance_init =3D tpm_tis_sysbus_finalize, .class_init =3D tpm_tis_sysbus_class_init, .interfaces =3D (const InterfaceInfo[]) { { TYPE_TPM_IF }, --=20 2.54.0 From nobody Mon May 25 13:48:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1778918504; cv=none; d=zohomail.com; s=zohoarc; b=T+RQqPtSE8wTlJ1tf/uu2XrOlIg746GhKWTLPoeubt20KTu17J/BB8Hz3MRp2Xuuz85JM+VddpBBS2gTS8Flmx02/UM2/RVBfcn96uvLX3Uh9R5bhQdha3NSpHZau2+PUrbxRqC9CMtQ1G70WZznljRgh99eFcAeC9tbrcKM6Nc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778918504; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Y8BM6lk2d/q0uYMA25e6DLVH4Eu5sV0SBk59q2zky50=; b=MLpciStrPySBXN2u4Tj2388Vdf//MimxS46fGi0se/O9tRncpUjv8n0beaWr8Lp5ctgat1+g1WiiQnwakVoUpzGjN6rU+2k0ZFBQRh30HOrsd/tS4hkK3QMjnCKIvhYUsWfMV9c0IGRhW2TJV/gNJWIWdF3batoxftGva60gsmM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778918504531855.2531871819882; Sat, 16 May 2026 01:01:44 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wO9xU-0000pV-Jc; Sat, 16 May 2026 04:01:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9xQ-0000br-8B for qemu-devel@nongnu.org; Sat, 16 May 2026 04:01:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9xO-0007oM-Jb for qemu-devel@nongnu.org; Sat, 16 May 2026 04:01:11 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-153-Ctm3B7s1Pmiun2SYunlRyA-1; Sat, 16 May 2026 04:01:08 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5F712195605A for ; Sat, 16 May 2026 08:01:07 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 60B7930001A2; Sat, 16 May 2026 08:01:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778918469; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y8BM6lk2d/q0uYMA25e6DLVH4Eu5sV0SBk59q2zky50=; b=chEQGZYMzPr6DtHStFXgpPQ4sc2ATiO+h2QXPodzBch7eTtzufukdO1IXeY0gvyGOUyf5+ IhEEgrzGRaDOqQTu+GG0+yUW5FTz5wYJUZIs8nBKhLcYsVztJvk6GaTGqxaldt5t5BECjH dsnd7zcJIdPCk94NcA0q/FpyQRDq50A= X-MC-Unique: Ctm3B7s1Pmiun2SYunlRyA-1 X-Mimecast-MFC-AGG-ID: Ctm3B7s1Pmiun2SYunlRyA_1778918467 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 16 May 2026 11:59:18 +0400 Subject: [PATCH v3 19/24] hw/loongarch/virt: free flash devices and OEM strings on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260516-qom-tests-v3-19-3f20c3a029a7@redhat.com> References: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> In-Reply-To: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1763; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=x1kW1X7a1jUz1TjYHNTyxhXK429eLvO8CiKl+XNmePw=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqCCPPbnuRHouewAm5SfrgIZHhqem5WoXZqQPWi E0JLLr65NqJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaggjzwAKCRDa6OEJdZac 5ViTD/91j0R7dPa7bZSXpmOCsY+CH9d5IvW4z/rFU65Hwadu7aHuq4ClEUrWsuAJFy8GODECAJg R4YLBBUR8+8CUZXInCLCKB23yhHcSHt2JDR6Sae7tAIyr0X2OtRB2aOQUc3SoxISbNbTOzXFmHc 8foTCR/RI7chSdmQD/SpJko7/COal84ugaT/oE3U3zUoZVsB6VhGvaJUUgjc+5TcbX8u+LBlgz9 UYYDn2pR+t6OeATwcRXyVbtBqJ7z42RnoSZ7LoobLZ4lr0n8OtHJd1YBax4naXOtcvTSwbv5Med BFiXShs6GVBIgq1gvtUGUyQs3IAfTpJ+6ktGT+/mKMCSdOsddQyAzLtGi2M90PTJEdOFUT1CPJm OEAN/PEhjNwQcN+HjfEO8uYEEZyd8DkiqNvCnP1VlsY1db788L5AUPK/Y9Yp+NAOqAk9crQKzp2 b42JoJDRnfHdNALp2mQa3vxRd3Oepy7JuXhadU5eZ/eXHfVKxznXdnWMTGVqrPl0JKRCG+qcxRD 0nqacJ+PYs1I8Mn2rPFG8evw/ByY8CMqF5F2a79PgH9xrkI9YOAF6Ur6R3lhl9LUJBQnMJu9ViF vTQGSttz3z/EXHcicxzqihZyKJSFwtIoUMbdtaXo+0LGuuEam45d6enrnZZ5i2FXnmpCho+I/tG Hira0Jmqh5lx95w== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1778918506167158500 Flash devices created in virt_initfn() via qdev_new() hold an extra reference that is only dropped on sysbus_realize_and_unref(). When the machine is destroyed before realization, the flash objects leak. Also, the oem_id and oem_table_id strings from g_strndup() are never freed. Fixes: 445c9c645 ("hw/loongarch/virt: Allow user to customize OEM ID and OE= M table ID") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/loongarch/virt.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c index f68ccdb12b7..6693dea647b 100644 --- a/hw/loongarch/virt.c +++ b/hw/loongarch/virt.c @@ -1566,6 +1566,19 @@ static void virt_class_init(ObjectClass *oc, const v= oid *data) #define DEFINE_VIRT_MACHINE(major, minor) \ DEFINE_VIRT_MACHINE_VERSION(false, major, minor) =20 +static void virt_instance_finalize(Object *obj) +{ + LoongArchVirtMachineState *lvms =3D LOONGARCH_VIRT_MACHINE(obj); + + for (int i =3D 0; i < ARRAY_SIZE(lvms->flash); i++) { + if (lvms->flash[i] && !qdev_is_realized(DEVICE(lvms->flash[i]))) { + object_unref(OBJECT(lvms->flash[i])); + } + } + g_free(lvms->oem_id); + g_free(lvms->oem_table_id); +} + static const TypeInfo virt_machine_info =3D { .name =3D TYPE_LOONGARCH_VIRT_MACHINE, .parent =3D TYPE_MACHINE, @@ -1573,6 +1586,7 @@ static const TypeInfo virt_machine_info =3D { .instance_size =3D sizeof(LoongArchVirtMachineState), .class_init =3D virt_class_init, .instance_init =3D virt_initfn, + .instance_finalize =3D virt_instance_finalize, .interfaces =3D (InterfaceInfo[]) { { TYPE_HOTPLUG_HANDLER }, { } --=20 2.54.0 From nobody Mon May 25 13:48:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1778918543; cv=none; d=zohomail.com; s=zohoarc; b=cUY0+4Nl9ya9FankhYG5XPYvHgaaeFWeXgLit9knOA1BvND7Pn4OTWlKqcC1Q3L3/DWE3ZMX8o9Y3UolLTRyLZZnlSk3vCYZByR9qwdfsgBnpGBkjjIaQM7gf8PQjHr2TdskcCn93DUQXaEDs0kMvKL/gw3Ih9oTVq3Ob+cu670= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778918543; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=AtjRG2uOcioJaCs6Yzten5VTU1iCUoC5q9GYq6iXtUY=; b=Pn3mHTlUPkEffYz91wqblIwboYvmZMgAusr/K9zFj8s3gGMgwIWUQZLKHbxYdKl1hs93rYxj9UCQynGKtayabBxs3bpTWbhYHf+fN85pGQK7wouP8zBXf8IcMv/3esDFq56W3R5UGL6ZpGBttERZ0q+Ou7nGgOq/58qvXpraxvQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17789185437861022.4731757833805; Sat, 16 May 2026 01:02:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wO9xZ-0001Pq-0J; Sat, 16 May 2026 04:01:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9xW-0001CS-HD for qemu-devel@nongnu.org; Sat, 16 May 2026 04:01:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9xU-0007rw-LV for qemu-devel@nongnu.org; Sat, 16 May 2026 04:01:18 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-214-dsSEk6yvNDOvUQ-fhZOUDA-1; Sat, 16 May 2026 04:01:13 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0B6D619560B1 for ; Sat, 16 May 2026 08:01:13 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E5F1730002DC; Sat, 16 May 2026 08:01:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778918476; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AtjRG2uOcioJaCs6Yzten5VTU1iCUoC5q9GYq6iXtUY=; b=YKjHdjNC3KQNJgiTvv94heD6ZZkIV5mJwC45PSUJi/L7uIH4UsieNpRyTx46Mo35h8l/gL XT0OA/A42iBLHiE3gByon5NrfBrwcRpMGBeQsyHOyq+ot30mbp3MAgmE16Ncas933JHjkj COA82y4gxMG80qx3gjGSa2nSW3vTzMQ= X-MC-Unique: dsSEk6yvNDOvUQ-fhZOUDA-1 X-Mimecast-MFC-AGG-ID: dsSEk6yvNDOvUQ-fhZOUDA_1778918473 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 16 May 2026 11:59:19 +0400 Subject: [PATCH v3 20/24] hw/ppc/spapr: free host_model and host_serial on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260516-qom-tests-v3-20-3f20c3a029a7@redhat.com> References: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> In-Reply-To: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=811; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=q1VoyFbeNpTCUOW8T79Mb82LIAro7PYvZcbi1R2YJPk=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqCCPPBBV/pW20MitgvNVtoQhgN/w/3jvG7yq3U nnQnyDVYhGJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaggjzwAKCRDa6OEJdZac 5YV0D/4nEdR6kqSTLK+kXS5Jz9RhAXeKbXVie9TDEao6WY2Z+VdftNKYa6b/aJ9fQqIRjv4OE8N mwlMeUdzYNiHyWZgbl1fFAl7daZf7jfo0Ml3MbDe/SCoNrcXXONdYV3nDBNCzEMapHRdDMonGss pLB/OBxxxt3c1SNDB5mUaQUIBxhai07IfoESQkRldRoL4/Izfwy3CTOHavhYfUDJNYWS0gqI2le ZzuVCC2fChNvMNqHvpOJUiT9YB30maDqDeSv8w+6fCA2ci0cwqcm4avzbgEugX78SwZ3F9CO4J4 TW+GjXv6LFsS3GMYQhrtU8RzF/CpPu6mh7SvqTRv3wwR7mcW7mrYqtKg367+26qYP/aSsQuKNiJ foATeoY7Uc2l7AWQkhSDciumM0miCU/a+4hnI7TYvtqj+ztO4ycY1wtyW5tnGdZuo9bd0ZjUlBv y6bheZQ9rhoUL/5mBEFcPlfjUFDGqoqmcu+XrLUyRSS/mNn+JADs0vNshY+qUT57i6Xip5hA/PY GOrKNPRMYxW2sDJts1GhkyuhKwuUpgBFDMsXod5T5Gf7wOQ4gzab+OO+er2myPnP6ZlHnKW5qNN mfi7RzBOLjw0Si+mFZhPR2ClriMkGsPuXRzy8Vrk+VlSgheUby7GSo1eYlU3ybNGPgLFOUHMIJn cmF0q+IknZmPSyg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1778918544422158500 The host_model and host_serial strings are allocated via g_strdup in property setters but never freed when the machine is destroyed. Fixes: 27461d69a0f ("ppc: add host-serial and host-model machine attributes= (CVE-2019-8934)") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/ppc/spapr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index d40af312fae..4ec0a7d20b8 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -3517,6 +3517,8 @@ static void spapr_machine_finalizefn(Object *obj) SpaprMachineState *spapr =3D SPAPR_MACHINE(obj); =20 g_free(spapr->kvm_type); + g_free(spapr->host_model); + g_free(spapr->host_serial); } =20 void spapr_do_system_reset_on_cpu(CPUState *cs, run_on_cpu_data arg) --=20 2.54.0 From nobody Mon May 25 13:48:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1778918505; cv=none; d=zohomail.com; s=zohoarc; b=HWIilLMZ7FBTyHnXn5ABg7SKmItPTF0qSp7V/lYnBItPA3U2WJN+yYnYFopLY+XvPGMkacJinAMoKw2hZqD5qapnLXzcoSHENym6qjZWGntAlDtWDeahftBMkhsm/wSQMJj6wbdiBov2MwPYHa00dgOCt753k/lW73Rhhuedf5M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778918505; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=TiVpfAURbMJRJexkrYsuy4LkqPOHmyGZglcMijYKadc=; b=l8d+uq0aH2DXxTzdi3KzDGhxuaaqmR4XQD73EfydYuVzvIFUFTGYJgQ1cyRiGvug3ATyrYJBml2TKnFqX0PMPWgvKHaK0l5EC9WvrlBGff44XXmoOFb8PL4QcFFE40yszZGAVl88f7tShsYYAF1EbU8jAA3jbcg70kEy5vKszzY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778918505469398.4237601009502; Sat, 16 May 2026 01:01:45 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wO9xj-0001ta-9b; Sat, 16 May 2026 04:01:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9xe-0001ke-LE for qemu-devel@nongnu.org; Sat, 16 May 2026 04:01:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9xc-0007wk-8k for qemu-devel@nongnu.org; Sat, 16 May 2026 04:01:26 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-673--FK4itS0Opiy58xzXe_mLg-1; Sat, 16 May 2026 04:01:19 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 856D5195608C for ; Sat, 16 May 2026 08:01:18 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 696F318001E8; Sat, 16 May 2026 08:01:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778918483; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TiVpfAURbMJRJexkrYsuy4LkqPOHmyGZglcMijYKadc=; b=bCEKM+NsKw7YnOEqNSp7g5YHPLuXdOIjCBPrmIWsbQpooqOFK9qKjPmI254ZcHnFsGVFcF HG/wGUd4Ux4OIxFxZBGHqj7a2bVWMl3qryeMBUsfvGjb98k/0pdKsQsoDtuDUpMOJSI52P gQAYWbroxEw82q3xTlrTRbLHHfc7nHY= X-MC-Unique: -FK4itS0Opiy58xzXe_mLg-1 X-Mimecast-MFC-AGG-ID: -FK4itS0Opiy58xzXe_mLg_1778918478 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 16 May 2026 11:59:20 +0400 Subject: [PATCH v3 21/24] target/riscv: fix general_user_opts hash table leak MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260516-qom-tests-v3-21-3f20c3a029a7@redhat.com> References: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> In-Reply-To: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=9216; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=HSJyUZRh3kfWl1FGVv9/24mNwb8SAbISnT1vB5tCT84=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqCCPPsT5NozCdEiIsJd4E4gjhtTQkulw1iJIsz IpvbLtpEUSJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaggjzwAKCRDa6OEJdZac 5dpyEACQcxXZcLVtrP16I659NG4Bb9PFTyKxZKLfmI8cG6HhqreCjUjMeuLMex395i3nDL2ozcH O5tUR6jJeNt9OFPsL1vdXjMfRAK0+Kda69LR49opoN723D0hT9qXqoWQBWt7BrVRHaogMvST1SV DYGIQKQRK++4er9eavhTYFrrUO1dGKm4ZZcArUMSx6Jc/DY9jQVq1uh8AvKrWdqZAd8rT0XCa1/ Rm58l0fKhWlgf/ncNyHR7lRw1+Ruk4R2F5oioxfDtF3DKPcpYLURq3qlsXizgLYsx4H6YF1L7bu Kz1toSTrCHbTGKBzom7D2brggz9PnKMirIvLqOsk3Gd/lfvmViBus4qYR6hh86U7C+05nn4zeDZ OrtkMd9DDl1hHtkldm3p+gLbPL6RZupXud0H52HgNQVqSC1+NprCU8SxPMvVC4koq3o2gpBk7Sb itKact8TRbPB4BCUhY7nJlA+oIbn1pxZa1nGfdCo86cDdp/Pro0sujqhnOfYg3WFDePyeIHmUc/ V8QA4vSu1J4t18EBpmqdecRNTCnbCk8IR+FRYRyO6BRRnYSzH082RxPTFj9NXSrd3TAMDPKNNnf o6gWS7l2DKEHlA3yRTMZysWOW1DDM4gfZkrkN0jTnWU+sZctaYkyX/V1V10VKG3tWehxfbSjqYt tYERm/x5QMYCQhw== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1778918506304158500 The global general_user_opts hash table is recreated on every riscv_cpu_init() call, leaking the previous one. Furthermore, the CPU settings should be associated with their instance and not global. Add a finalize() to free associated instances. Fixes: d167a2247ede ("target/riscv: move 'pmu-mask' and 'pmu-num' to riscv_= cpu_properties[]") Signed-off-by: Marc-Andr=C3=A9 Lureau --- target/riscv/cpu.h | 3 ++- target/riscv/cpu.c | 53 ++++++++++++++++++++++++++++--------------= ---- target/riscv/kvm/kvm-cpu.c | 6 +++--- 3 files changed, 37 insertions(+), 25 deletions(-) diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h index fae839cade4..86a38a7288b 100644 --- a/target/riscv/cpu.h +++ b/target/riscv/cpu.h @@ -546,6 +546,7 @@ struct ArchCPU { uint32_t pmu_avail_ctrs; /* Mapping of events to counters */ GHashTable *pmu_event_ctr_map; + GHashTable *user_options; const GPtrArray *decoders; }; =20 @@ -619,7 +620,7 @@ bool riscv_cpu_tlb_fill(CPUState *cs, vaddr address, in= t size, bool probe, uintptr_t retaddr); char *riscv_isa_string(RISCVCPU *cpu); int riscv_cpu_max_xlen(RISCVCPUClass *mcc); -bool riscv_cpu_option_set(const char *optname); +bool riscv_cpu_option_set(RISCVCPU *cpu, const char *optname); =20 #ifndef CONFIG_USER_ONLY void riscv_cpu_do_interrupt(CPUState *cpu); diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 506a018d52b..bbdc9d8f5de 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -27,6 +27,7 @@ #include "qapi/error.h" #include "qapi/visitor.h" #include "qemu/error-report.h" +#include "qemu/timer.h" #include "hw/core/qdev-properties.h" #include "hw/core/qdev-prop-internal.h" #include "migration/vmstate.h" @@ -59,18 +60,16 @@ bool riscv_cpu_is_32bit(RISCVCPU *cpu) return riscv_cpu_mxl(&cpu->env) =3D=3D MXL_RV32; } =20 -/* Hash that stores general user set numeric options */ -static GHashTable *general_user_opts; - -static void cpu_option_add_user_setting(const char *optname, uint32_t valu= e) +static void cpu_option_add_user_setting(RISCVCPU *cpu, const char *optname, + uint32_t value) { - g_hash_table_insert(general_user_opts, (gpointer)optname, + g_hash_table_insert(cpu->user_options, (gpointer)optname, GUINT_TO_POINTER(value)); } =20 -bool riscv_cpu_option_set(const char *optname) +bool riscv_cpu_option_set(RISCVCPU *cpu, const char *optname) { - return g_hash_table_contains(general_user_opts, optname); + return g_hash_table_contains(cpu->user_options, optname); } =20 #ifndef CONFIG_USER_ONLY @@ -1103,7 +1102,7 @@ static void riscv_cpu_init(Object *obj) "riscv.cpu.rnmi", RNMI_MAX); #endif /* CONFIG_USER_ONLY */ =20 - general_user_opts =3D g_hash_table_new(g_str_hash, g_str_equal); + cpu->user_options =3D g_hash_table_new(g_str_hash, g_str_equal); =20 /* * The timer and performance counters extensions were supported @@ -1453,7 +1452,7 @@ static void prop_pmu_num_set(Object *obj, Visitor *v,= const char *name, =20 warn_report("\"pmu-num\" property is deprecated; use \"pmu-mask\""); cpu->cfg.pmu_mask =3D pmu_mask; - cpu_option_add_user_setting("pmu-mask", pmu_mask); + cpu_option_add_user_setting(cpu, "pmu-mask", pmu_mask); } =20 static void prop_pmu_num_get(Object *obj, Visitor *v, const char *name, @@ -1495,7 +1494,7 @@ static void prop_pmu_mask_set(Object *obj, Visitor *v= , const char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.pmu_mask =3D value; } =20 @@ -1527,7 +1526,7 @@ static void prop_mmu_set(Object *obj, Visitor *v, con= st char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.mmu =3D value; } =20 @@ -1559,7 +1558,7 @@ static void prop_pmp_set(Object *obj, Visitor *v, con= st char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.pmp =3D value; } =20 @@ -1599,7 +1598,7 @@ static void prop_num_pmp_regions_set(Object *obj, Vis= itor *v, const char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.pmp_regions =3D value; } =20 @@ -1637,7 +1636,7 @@ static void prop_pmp_granularity_set(Object *obj, Vis= itor *v, const char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.pmp_granularity =3D value; } =20 @@ -1710,7 +1709,7 @@ static void prop_priv_spec_set(Object *obj, Visitor *= v, const char *name, return; } =20 - cpu_option_add_user_setting(name, priv_version); + cpu_option_add_user_setting(cpu, name, priv_version); cpu->env.priv_ver =3D priv_version; } =20 @@ -1744,7 +1743,7 @@ static void prop_vext_spec_set(Object *obj, Visitor *= v, const char *name, return; } =20 - cpu_option_add_user_setting(name, VEXT_VERSION_1_00_0); + cpu_option_add_user_setting(cpu, name, VEXT_VERSION_1_00_0); cpu->env.vext_ver =3D VEXT_VERSION_1_00_0; } =20 @@ -1787,7 +1786,7 @@ static void prop_vlen_set(Object *obj, Visitor *v, co= nst char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.vlenb =3D value >> 3; } =20 @@ -1828,7 +1827,7 @@ static void prop_elen_set(Object *obj, Visitor *v, co= nst char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.elen =3D value; } =20 @@ -1864,7 +1863,7 @@ static void prop_cbom_blksize_set(Object *obj, Visito= r *v, const char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.cbom_blocksize =3D value; } =20 @@ -1900,7 +1899,7 @@ static void prop_cbop_blksize_set(Object *obj, Visito= r *v, const char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.cbop_blocksize =3D value; } =20 @@ -1936,7 +1935,7 @@ static void prop_cboz_blksize_set(Object *obj, Visito= r *v, const char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.cboz_blocksize =3D value; } =20 @@ -2975,6 +2974,17 @@ void riscv_isa_write_fdt(RISCVCPU *cpu, void *fdt, c= har *nodename) DEFINE_RISCV_CPU(type_name, parent_type_name, \ .profile =3D &(profile_)) =20 +static void riscv_cpu_instance_finalize(Object *obj) +{ + RISCVCPU *cpu =3D RISCV_CPU(obj); + +#ifndef CONFIG_USER_ONLY + g_clear_pointer(&cpu->pmu_timer, timer_free); + g_clear_pointer(&cpu->pmu_event_ctr_map, g_hash_table_destroy); +#endif + g_clear_pointer(&cpu->user_options, g_hash_table_destroy); +} + static const TypeInfo riscv_cpu_type_infos[] =3D { { .name =3D TYPE_RISCV_CPU, @@ -2982,6 +2992,7 @@ static const TypeInfo riscv_cpu_type_infos[] =3D { .instance_size =3D sizeof(RISCVCPU), .instance_align =3D __alignof(RISCVCPU), .instance_init =3D riscv_cpu_init, + .instance_finalize =3D riscv_cpu_instance_finalize, .abstract =3D true, .class_size =3D sizeof(RISCVCPUClass), .class_init =3D riscv_cpu_common_class_init, diff --git a/target/riscv/kvm/kvm-cpu.c b/target/riscv/kvm/kvm-cpu.c index b047ffa9c0c..e0241870ada 100644 --- a/target/riscv/kvm/kvm-cpu.c +++ b/target/riscv/kvm/kvm-cpu.c @@ -2025,7 +2025,7 @@ void riscv_kvm_cpu_finalize_features(RISCVCPU *cpu, E= rror **errp) } =20 if (cpu->cfg.ext_zicbom && - riscv_cpu_option_set(kvm_cbom_blocksize.name)) { + riscv_cpu_option_set(cpu, kvm_cbom_blocksize.name)) { =20 reg.id =3D KVM_RISCV_REG_ID_ULONG(KVM_REG_RISCV_CONFIG, kvm_cbom_blocksize.kvm_reg_id); @@ -2044,7 +2044,7 @@ void riscv_kvm_cpu_finalize_features(RISCVCPU *cpu, E= rror **errp) } =20 if (cpu->cfg.ext_zicboz && - riscv_cpu_option_set(kvm_cboz_blocksize.name)) { + riscv_cpu_option_set(cpu, kvm_cboz_blocksize.name)) { =20 reg.id =3D KVM_RISCV_REG_ID_ULONG(KVM_REG_RISCV_CONFIG, kvm_cboz_blocksize.kvm_reg_id); @@ -2063,7 +2063,7 @@ void riscv_kvm_cpu_finalize_features(RISCVCPU *cpu, E= rror **errp) } =20 /* Users are setting vlen, not vlenb */ - if (riscv_has_ext(env, RVV) && riscv_cpu_option_set("vlen")) { + if (riscv_has_ext(env, RVV) && riscv_cpu_option_set(cpu, "vlen")) { if (!kvm_v_vlenb.supported) { error_setg(errp, "Unable to set 'vlenb': register not supporte= d"); return; --=20 2.54.0 From nobody Mon May 25 13:48:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1778918509; cv=none; d=zohomail.com; s=zohoarc; b=mw3oQtpGj5uok78tJKMpGTc1cq+STZCdhitiY/vNghDft33D3miy2PFtgwZsZ/l1EZ+w99gAB/Z7PlOT+r/SJacb2Hi9fuQEfn8pzeVBwKfJeVpu+RwUQ+4FD112jMCy1EpBuHF+VeAGXBkScS3GCzS0vJcDPo4csoeBLc4IVaU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778918509; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=n4m7pmp7qnl/dyUVLbYMaT8ZipvvTkt7+0WBm0mtE5E=; b=BkzBwtgjz97WT8p2DLh6VALWal/CxKpfo58ufjeE4hmSjwnKvwqwfvYbd/0fQRarJcatrWTgr8Juo5Odx35TTc+9z7h5XALDj02iVon47v1Mkh2LjNxXqppBkipPIRewdHiWLgTW3ar0qsa8D+hK7X8gRBXA3VGSo47443taVUA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778918509373669.6001372325167; Sat, 16 May 2026 01:01:49 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wO9xn-0001y4-Co; Sat, 16 May 2026 04:01:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9xh-0001sC-12 for qemu-devel@nongnu.org; Sat, 16 May 2026 04:01:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9xf-0007xM-5c for qemu-devel@nongnu.org; Sat, 16 May 2026 04:01:28 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-363-boY4hZj2P1ebmvQ1A3Ffnw-1; Sat, 16 May 2026 04:01:24 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D216919560AE for ; Sat, 16 May 2026 08:01:23 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D3C4218001E8; Sat, 16 May 2026 08:01:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778918486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n4m7pmp7qnl/dyUVLbYMaT8ZipvvTkt7+0WBm0mtE5E=; b=EFYU8+LT8bX0JHsUMEbQr0tC3D2o4DQS1c9jm6zPY4gCi1MZvQ840MS9fO97/N8btBZr2v fFz+X2/mddzNU2jbAs8LDgIzgpJLgDCK04ERwnQdLObJ0rXcIR9hzVLvZI9RAGu+OWxFVx S7C6c1l6W97n9ySHrgl+rbJmQ6yLRJg= X-MC-Unique: boY4hZj2P1ebmvQ1A3Ffnw-1 X-Mimecast-MFC-AGG-ID: boY4hZj2P1ebmvQ1A3Ffnw_1778918483 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 16 May 2026 11:59:21 +0400 Subject: [PATCH v3 22/24] target/riscv: use hash table as set for user_options MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260516-qom-tests-v3-22-3f20c3a029a7@redhat.com> References: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> In-Reply-To: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=4750; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=rzQyp5DQ5nvhaO0TBZoOhaU+VtZA1JAU78E8mJirGw4=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqCCPQN4u0LHMf1Wf/VLxNx6N+CMJUkPRbupF8h SdoiwoFWbqJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaggj0AAKCRDa6OEJdZac 5b4rEACnA0l3Gh37hZD5yXoK1+ey7KUCJal5DFpC1nVWjI2OY23VaydfCZb2by0SVpGMkflh8QX IZqYoFOMVWScxZhdt5Z4bXsFdxqd4jj2ViBZBFxBT0opgGGGSG7t4WBYD3R9fkS1YfnuI5re3gY 8zVGEtu1ABL65bepBmckyxBgjdTIzgHO7caTf2A91wpai+WVUldj9iW4GHwWdlZaTjryb52Yb1u EVq3pg3cehKU5lG4Y+uqzbMssW1oYNCe5pTH8oOEfDY0WUeYo/jAVEwfd5TAM0vahHzTmKD/gdz rqFF2rGnUhdm3XV2JnKpf7xRMo9Y65DcTX5d0jOmaZSxC3UtVgCz5UPTHXwsrSBdN5CyZrRKLBu fDYXXGgMO6rgUr+IbAsBVU04VK1d9xADpknXcjgIkqHeFJdI7BupOjMSXj0y0hHDMXKvWJ2lMzT W64wZR4Uhtmil+cOow5SHpbG16CRURck3uJs26QDxPLzgtLvCYyWdsnjLxzq6GUGU2KJXU3E/zh hQ+AOGJMt8tfOdnl1c9ADRNL0b673O8UG73vmkvXmB0VVaol/nqcG92CLtsLKMwwNjEr7eLpJTG 5snDH+0H3U8br9FfJAUQVS3TDngLFKvJMRmOeNGKOgH3QODM/QW3rD/Xv6aXsi7ByCsXmMh/Puo 2kpXlYEpDdTtTxA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1778918510253158500 The values stored in user_options are never retrieved, only key presence is checked. Use g_hash_table_add() instead of g_hash_table_insert() and drop the unused value parameter. Signed-off-by: Marc-Andr=C3=A9 Lureau --- target/riscv/cpu.c | 32 +++++++++++++++----------------- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index bbdc9d8f5de..6adba597969 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -60,11 +60,9 @@ bool riscv_cpu_is_32bit(RISCVCPU *cpu) return riscv_cpu_mxl(&cpu->env) =3D=3D MXL_RV32; } =20 -static void cpu_option_add_user_setting(RISCVCPU *cpu, const char *optname, - uint32_t value) +static void cpu_option_add_user_setting(RISCVCPU *cpu, const char *optname) { - g_hash_table_insert(cpu->user_options, (gpointer)optname, - GUINT_TO_POINTER(value)); + g_hash_table_add(cpu->user_options, (gpointer)optname); } =20 bool riscv_cpu_option_set(RISCVCPU *cpu, const char *optname) @@ -1452,7 +1450,7 @@ static void prop_pmu_num_set(Object *obj, Visitor *v,= const char *name, =20 warn_report("\"pmu-num\" property is deprecated; use \"pmu-mask\""); cpu->cfg.pmu_mask =3D pmu_mask; - cpu_option_add_user_setting(cpu, "pmu-mask", pmu_mask); + cpu_option_add_user_setting(cpu, "pmu-mask"); } =20 static void prop_pmu_num_get(Object *obj, Visitor *v, const char *name, @@ -1494,7 +1492,7 @@ static void prop_pmu_mask_set(Object *obj, Visitor *v= , const char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.pmu_mask =3D value; } =20 @@ -1526,7 +1524,7 @@ static void prop_mmu_set(Object *obj, Visitor *v, con= st char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.mmu =3D value; } =20 @@ -1558,7 +1556,7 @@ static void prop_pmp_set(Object *obj, Visitor *v, con= st char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.pmp =3D value; } =20 @@ -1598,7 +1596,7 @@ static void prop_num_pmp_regions_set(Object *obj, Vis= itor *v, const char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.pmp_regions =3D value; } =20 @@ -1636,7 +1634,7 @@ static void prop_pmp_granularity_set(Object *obj, Vis= itor *v, const char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.pmp_granularity =3D value; } =20 @@ -1709,7 +1707,7 @@ static void prop_priv_spec_set(Object *obj, Visitor *= v, const char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, priv_version); + cpu_option_add_user_setting(cpu, name); cpu->env.priv_ver =3D priv_version; } =20 @@ -1743,7 +1741,7 @@ static void prop_vext_spec_set(Object *obj, Visitor *= v, const char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, VEXT_VERSION_1_00_0); + cpu_option_add_user_setting(cpu, name); cpu->env.vext_ver =3D VEXT_VERSION_1_00_0; } =20 @@ -1786,7 +1784,7 @@ static void prop_vlen_set(Object *obj, Visitor *v, co= nst char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.vlenb =3D value >> 3; } =20 @@ -1827,7 +1825,7 @@ static void prop_elen_set(Object *obj, Visitor *v, co= nst char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.elen =3D value; } =20 @@ -1863,7 +1861,7 @@ static void prop_cbom_blksize_set(Object *obj, Visito= r *v, const char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.cbom_blocksize =3D value; } =20 @@ -1899,7 +1897,7 @@ static void prop_cbop_blksize_set(Object *obj, Visito= r *v, const char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.cbop_blocksize =3D value; } =20 @@ -1935,7 +1933,7 @@ static void prop_cboz_blksize_set(Object *obj, Visito= r *v, const char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.cboz_blocksize =3D value; } =20 --=20 2.54.0 From nobody Mon May 25 13:48:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1778918524; cv=none; d=zohomail.com; s=zohoarc; b=QVQB0XUU1V+7os7PKbB5epDjd+DGUxWZ8+4i3oK6clyLxOYCTuCl+ouIIdd/t65OAJK9sZ7FSwI6hvytO88GDRioNcRaz1KU/tyx3TYK0Sp5FurShBQa9ajO4cHGDgwUaz7LyoBfdURSO0VoNEOfNK/fIk/MS1wHKoqzcUXK1Lg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778918524; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0OfyzipyaFyY1CMp4s0Vws0Sy7SQL4ehZCVUgrOMSFM=; b=FnqpLwhLYqzDkPgMHL+0bbrFOFszUEc0lMLV74WwFO8FOsU+kV/7LjxjsxX9/u8b5MlZIPcKHmEbR7B8Wr9yosWAU5SZf3X3w2yu6+ytaHf2SMUNZYlf8+mV6gTsfuM8wSQyZTzn0+9qwrWDh5gI/R6TM6ty8X1udLnvecob8BE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778918524484131.44136650360394; Sat, 16 May 2026 01:02:04 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wO9xt-0002B8-Hg; Sat, 16 May 2026 04:01:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9xn-00021B-Hr for qemu-devel@nongnu.org; Sat, 16 May 2026 04:01:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9xl-0007yk-Qd for qemu-devel@nongnu.org; Sat, 16 May 2026 04:01:35 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-492-GIrYqC9kNDC7GmpINsl3FA-1; Sat, 16 May 2026 04:01:30 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BF7B819560B7 for ; Sat, 16 May 2026 08:01:29 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7F6541956053; Sat, 16 May 2026 08:01:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778918492; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0OfyzipyaFyY1CMp4s0Vws0Sy7SQL4ehZCVUgrOMSFM=; b=NAl/HL6qVfiKu0bm5eFcoVEN3RvWkhYSp+ffR/YhoEPAunxkA4dW6eEzsMp4gbPpPgJlGL LypV45VDAk379ZelwOYAsPl9cH2C+3ZDC3ic97VlhUpKj3CZTq1NOTG0sSz3RMRUPM7eVJ htnUxk2K1igQxil44GWKCXWW+dHOgGI= X-MC-Unique: GIrYqC9kNDC7GmpINsl3FA-1 X-Mimecast-MFC-AGG-ID: GIrYqC9kNDC7GmpINsl3FA_1778918489 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 16 May 2026 11:59:22 +0400 Subject: [PATCH v3 23/24] hw/i2c/pmbus: fix undefined behavior in pmbus_direct_mode2data MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260516-qom-tests-v3-23-3f20c3a029a7@redhat.com> References: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> In-Reply-To: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1137; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=tLDFCKiyZ3IHoxFsadnpmt3a+eVCWPPwxdz50j2s6oQ=; b=kA0DAAoB2ujhCXWWnOUByyZiAGoII9CjBP9pOTrKkBw8FODUs+r8Sems975be0j7nkIEd+gsO YkCMwQAAQoAHRYhBIepvZM/h8YG0nb2Ldro4Ql1lpzlBQJqCCPQAAoJENro4Ql1lpzlvXAP/3lD uCS/BLbWgLZXNCVT000dA4ZKYrJUA4gHUkq8W0voMJCUH3OS2E4QbTrlHwzqWDwcF2Wp2YkhC00 qAU65ClLqy7lQHyLJ5MA3JM5esdJtwCwJIzfN4tZK/67TIjP92dKKfalVkbeJoVT5H5RgilB1Dp rgi5IRRljrmXvkYYC6puwLLxqo7iauUekQr6LijOBfje48lrmlDaxLACWEvv1VGuWoevZbzI1Q0 9QPC7YcnKcMK3Y8WpPWNhZbU3IO2YO11vQnglLoiiXUn3yXpp8b4Hvi28JdfI2j0yndSVjN/bXh OGtLCX+Se2XyJZjDwzaiySt2bxNzApumkH5dEChMnmnJY2MfZk3AiGbttVLblbmFlNPk+/2KJbB /THuSVMVNB+4y6BiFAzpsX2FWXOsqwzzC/dzNJ8Jyp4zfW3YUsZbW9miiq/KKqY+p+Q6XBJUYZx c8wY1o+mj0vgLI7HnbBxiCzolu43kgsO9yJjJiWDy8hhYnaBQlTDc8gi9fwhRDSONMVSpnS5/70 TuF4z97Cqjd2WSA0z9LAjfC0jK+tbERIAfKOwRq+gkFDiPA5kbysHlqAyG5U0iFpT73PRXjqx/H prVAJLodAPtr+/IfY7kLBuQfurMSWst9GlJSQ5fWkyY1i9lFDF7WghOyLtS2r4tDNVRlNedNsrr BoRPe X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1778918526412158500 The intermediate result of (Y * 10^-R - b) / m can be negative when the bias (b) is large and the raw register value is small (e.g. zero on an uninitialized device). Assigning that negative double to uint32_t is undefined behavior, caught by UBSan/clang. Use a double intermediate and clamp negative results to zero. Fixes: 3746d5c15e70 ("hw/i2c: add support for PMBus") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/i2c/pmbus_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c index 853dc4b4342..861f5b4fb63 100644 --- a/hw/i2c/pmbus_device.c +++ b/hw/i2c/pmbus_device.c @@ -23,8 +23,8 @@ uint16_t pmbus_data2direct_mode(PMBusCoefficients c, uint= 32_t value) uint32_t pmbus_direct_mode2data(PMBusCoefficients c, uint16_t value) { /* X =3D (Y * 10^-R - b) / m */ - uint32_t x =3D (value / pow(10, c.R) - c.b) / c.m; - return x; + double x =3D (value / pow(10, c.R) - c.b) / c.m; + return (x > 0) ? (uint32_t)x : 0; } =20 uint16_t pmbus_data2linear_mode(uint16_t value, int exp) --=20 2.54.0 From nobody Mon May 25 13:48:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1778918552; cv=none; d=zohomail.com; s=zohoarc; b=hXslJrcDsQG7qllQYuej7SweM3xJV973nOd1aNH7efqJVhKJ06zRv+71RrOplxiQBtCBR2Z9yOTbUnyFAXn2Xc7XBIJ9Jgs4tbRvODFDosvoz1lNF1xjB3spyom34Ff40JD645QlNwrr3NVAMChDhmYhYBFLeqV7nUeFpYrQqjk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778918552; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=fl1Dy3WaFG9c8O6pnjtrhobMJ11ap+Rioosxgik7G8g=; b=ToGs2W0cZYrq47nCu4Ifm9ov7oy4BnH4Q9VLG4NxohxJHHpYl7GUPboVOH8M6qyCx7Gyhw1Ogh5u/fn7Yhc9j3pFSk5oWTPeUOt1qLEhwUkWUA8LFoBWV+/AAOetponWe260yZS/5Ajc70Y/R+HSmvUSppdOPiQtsp9vg9RRSa0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177891855236239.15115459487879; Sat, 16 May 2026 01:02:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wO9xy-0002T4-42; Sat, 16 May 2026 04:01:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9xt-0002Cm-Kg for qemu-devel@nongnu.org; Sat, 16 May 2026 04:01:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wO9xs-00083H-0I for qemu-devel@nongnu.org; Sat, 16 May 2026 04:01:41 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-587-aI5uXwU0M5y_Cs6fgH1dug-1; Sat, 16 May 2026 04:01:37 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4E10D195605C for ; Sat, 16 May 2026 08:01:36 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 161FD1803A91; Sat, 16 May 2026 08:01:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778918499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fl1Dy3WaFG9c8O6pnjtrhobMJ11ap+Rioosxgik7G8g=; b=b42ZuHOJj+u1rZKRuJ15jVqi+/UcDGF+BZk/En9OeMVNTmhZFhn/Jkv7BbjDYW+qGhtugo o83VYrPmdsdUKZw2VxFkCCc1dJYo4POf9URhlFmDs1ptBV4tvXL/s1EyusPiOi680Ku/+o ZIIXZ7SnnRWs4hPE9AtiNO3hrbrGzKA= X-MC-Unique: aI5uXwU0M5y_Cs6fgH1dug-1 X-Mimecast-MFC-AGG-ID: aI5uXwU0M5y_Cs6fgH1dug_1778918496 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 16 May 2026 11:59:23 +0400 Subject: [PATCH v3 24/24] qtest: add "qom-tests" command MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260516-qom-tests-v3-24-3f20c3a029a7@redhat.com> References: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> In-Reply-To: <20260516-qom-tests-v3-0-3f20c3a029a7@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=4927; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=m7lYYOXvmZJ0VOnDjU3ju5AOmhVZo2a3PnThoOSL5yU=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqCCPQtKs1ABDoF5ddoAly1aEqTZvu9NzMJ5UmX sKL3Hejr+SJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaggj0AAKCRDa6OEJdZac 5eObD/9pkp98Y7xhf/AhrT8xtMuw7588x72mnZ8M2eM0ZEKyHCPoeISxRufWbS8U8A4FVXZ5tpq tCiO2319ncTSKbnHtyuSlf1ma9QFB4kMWeAZZYMPPS5ysXnjdgBEL/OwYeX7wFqalAWPMnwKDGr 7hVNr5nbIqpust8u6etZmx/w1XE84fMofvhEAPitV9rdYlLKc2n1CmKV0EJPcoC8Zi/ygEw/HdS VzKsZKhgIt2Q9vL/YNpuz+yNIGJkcVaOtd3hRYH1xKysAnA3SCpjyhB1Q3aLVt7ibCvW4TQKiyj iCNSVNJOHzC5RkKpK/1/UkkElcJbtfcg8PNLdeZmL9+ndSo3e4/tjeix10/RWjyVlF0qb5ssyXW c27Y7Wiw9qyhmPfQPB/LNw2tiBedJJusHypr+jYYRBeQBAwg4gjsnnkOLn+oLNDEipTnJukibY2 JhTYQ5S3l9u3/G9D74Bc9lwXEk0rn+TvpRB6T3nujRC3sV31sGvLyoNEmVNBZOneAs7gRATKvIh o8JgAcupjpiLdliA0AhoLOq1Qm+JBz8Td8XCiCoKy19k5wDOlOEg7BR3BE9LE9Vb6CVo//pYp2X XT7QueieCuWSkxP2d/4aRsbjiZr71FxNDB0EAoKcRNmrlUGu+0FwWdO0RdCs9QP3q4luYeWABLS dZElyIUeER/tj8A== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1778918554514158500 Add a new "qom-tests" to exercise basic object lifecycle. Instantiate all non-abstract objects, get and set properties and unref. This should quickly find leaks and other related issues that are eventually triggerable at run-time with QMP qom commands. Signed-off-by: Marc-Andr=C3=A9 Lureau --- tests/qtest/libqtest.h | 8 ++++++++ system/qtest.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++ tests/qtest/libqtest.c | 6 ++++++ tests/qtest/qom-test.c | 12 ++++++++++++ 4 files changed, 72 insertions(+) diff --git a/tests/qtest/libqtest.h b/tests/qtest/libqtest.h index 950ea2baafa..45217fb8dc0 100644 --- a/tests/qtest/libqtest.h +++ b/tests/qtest/libqtest.h @@ -426,6 +426,14 @@ char *qtest_vhmp(QTestState *s, const char *fmt, va_li= st ap) =20 void qtest_module_load(QTestState *s, const char *prefix, const char *libn= ame); =20 +/** + * qtest_qom_tests: + * @s: #QTestState instance to operate on. + * + * Run QOM property get/set round-trip tests on all non-abstract types. + */ +void qtest_qom_tests(QTestState *s); + /** * qtest_get_irq: * @s: #QTestState instance to operate on. diff --git a/system/qtest.c b/system/qtest.c index a79d10d1361..a44a581a518 100644 --- a/system/qtest.c +++ b/system/qtest.c @@ -31,6 +31,8 @@ #include "qemu/cutils.h" #include "qemu/target-info.h" #include "qom/object_interfaces.h" +#include "qom/qom-qobject.h" +#include "qobject/qobject.h" =20 #define MAX_IRQ 256 =20 @@ -754,6 +756,50 @@ static void qtest_process_command(CharFrontend *chr, g= char **words) new_ns =3D qemu_clock_advance_virtual_time(ns); qtest_sendf(chr, "%s %"PRIi64"\n", new_ns =3D=3D ns ? "OK" : "FAIL", new_ns); + } else if (strcmp(words[0], "qom-tests") =3D=3D 0) { + GSList *list, *l; + + list =3D object_class_get_list(NULL, false); + for (l =3D list; l; l =3D l->next) { + ObjectClass *klass =3D l->data; + const char *type_name =3D object_class_get_name(klass); + Object *obj; + ObjectPropertyIterator iter; + ObjectProperty *prop; + + obj =3D object_new_with_class(klass); + object_property_iter_init(&iter, obj); + while ((prop =3D object_property_iter_next(&iter))) { + QObject *value; + Error *local_err =3D NULL; + + value =3D object_property_get_qobject(obj, prop->name, + &local_err); + if (local_err) { + error_report("qom-tests: %s.%s: get failed: %s", + type_name, prop->name, + error_get_pretty(local_err)); + error_free(local_err); + continue; + } + + if (prop->set) { + if (!object_property_set_qobject(obj, prop->name, valu= e, + &local_err)) { + error_report("qom-tests: %s.%s: set failed: %s", + type_name, prop->name, + error_get_pretty(local_err)); + error_free(local_err); + } + } + + qobject_unref(value); + } + + object_unref(obj); + } + g_slist_free(list); + qtest_send(chr, "OK\n"); } else if (process_command_cb && process_command_cb(chr, words)) { /* Command got consumed by the callback handler */ } else { diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c index b1e06ea364e..4e22c66b754 100644 --- a/tests/qtest/libqtest.c +++ b/tests/qtest/libqtest.c @@ -1137,6 +1137,12 @@ void qtest_module_load(QTestState *s, const char *pr= efix, const char *libname) qtest_rsp(s); } =20 +void qtest_qom_tests(QTestState *s) +{ + qtest_sendf(s, "qom-tests\n"); + qtest_rsp(s); +} + static int64_t qtest_clock_rsp(QTestState *s) { gchar **words; diff --git a/tests/qtest/qom-test.c b/tests/qtest/qom-test.c index 6421f2d9d9f..cf4c6b5add5 100644 --- a/tests/qtest/qom-test.c +++ b/tests/qtest/qom-test.c @@ -227,6 +227,17 @@ static void add_machine_test_case(const char *mname) g_free(path); } =20 +static void test_qom_qtests(void) +{ + QTestState *qts; + + qts =3D qtest_initf("-machine none"); + + qtest_qom_tests(qts); + + qtest_quit(qts); +} + int main(int argc, char **argv) { char *v_env =3D getenv("V"); @@ -238,6 +249,7 @@ int main(int argc, char **argv) g_test_init(&argc, &argv, NULL); =20 qtest_cb_for_every_machine(add_machine_test_case, g_test_quick()); + qtest_add_func("qom/qom-qtests", test_qom_qtests); =20 return g_test_run(); } --=20 2.54.0