From nobody Sat May 30 18:36:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1778855187; cv=none; d=zohomail.com; s=zohoarc; b=fA8axTXWPhQZC8L8eXFYO0zB9rTYicbWbZrtTtN8x0hnoTF3hg6T9vwJtvXxD2AB0UEN2kSreNXuE0ykc4HkMLfvnQsEz+u+akd2Auf4u+BAFA8Mey9r+Yi7k6te4ho7HCi4r+WEWDll3V7ak1Hv9GbW+XXElEK6tFx8SCIEe40= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778855187; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=Yf8wcNB7EGw9UdeWFsayhgKXIy2x+KdJELXRYJSdqk0=; b=QZ01+mh1aMp3rKHnNWLgGRF02QZMB6Ex+iUumsvF58IlMfai/+gDUeFTkSySm4QvczFbnHveevEIWZlG5GyAED3ZfPeknYT/xHxp4+PScCN9gcKN5dtfok+r3Ed6rmLqlSgK3SOlbFjQXZRjlnwghKgs5vvoQh8g0P8SNFEo9LE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778855187411620.5718753851318; Fri, 15 May 2026 07:26:27 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wNtUB-0005mc-7X; Fri, 15 May 2026 10:25:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wNtU3-0005dz-FX for qemu-devel@nongnu.org; Fri, 15 May 2026 10:25:48 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wNtU1-0000uE-PK for qemu-devel@nongnu.org; Fri, 15 May 2026 10:25:47 -0400 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-44e1ebb3122so4968846f8f.2 for ; Fri, 15 May 2026 07:25:45 -0700 (PDT) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da15a666fsm13560603f8f.36.2026.05.15.07.25.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 07:25:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778855144; x=1779459944; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Yf8wcNB7EGw9UdeWFsayhgKXIy2x+KdJELXRYJSdqk0=; b=wbJCCcQy/nyPQD9steLrXg1kYhmWpCQA+B1QnAGGjYAAMwHIhnVC0pP1qAIE8am8XC rb+ZpHXf6MF6F+i230I2q3hiTrnpd8iIlTpABjRTjGjUN9TIskNcWyUjYBnbE9PVgbnf 4L6HwbbxtHgFdwI+uQ8ZiHTz1hDD1DxbErXQOrVrXevWJPZRP1NYm0+2gxJVLXj/Ambx u8s4UgxLzczDAQCMo14Omm88EGh65aY7LXg8S/zZlf/6fSBNA7nSBbLNvrABzU8fD4Id e4lchvIsB81ViTMXZfHQ0L7XL2PUOcGSYH/c+PwaXms0PQWM+wlLGHz/lMXki8ZtXUiY gFeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778855144; x=1779459944; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Yf8wcNB7EGw9UdeWFsayhgKXIy2x+KdJELXRYJSdqk0=; b=r9wMHP6JqbhrqzYhD7QrFGDcJaTGQNI0NipG5WLiktzteBRK4BdIHhNPSb2aOJKvOW ZGtb0aOzNnbJRJ45snknoiNjgaNmjvPMaXayF00l3wsmncOcRFKL8tboWRFa6gNPdVVL 6Wd3eIbp0kxtt3VxnNjhz+sHE8sJoAunLscLM6qxzCz0A8/GwMQ/yDDa49A9qKzzWXpv 6UK8zwJYAbc+wCNudi6anT9AhPN8hR5ciWU5kgbUkmeAit7Eo9IjSjmRF/rEFC1HkKRX xjOF7eVvyZP97hsMVoqZzpvbxxGhixV+XopYnSIAIb75+9WxSwlHb11yNuazlKAxy9pM vVXw== X-Forwarded-Encrypted: i=1; AFNElJ9CCy5DIYYB4zWSMgDpItwKTxkXKioYoPu7USmoTbSu24jgxoe3qLV9vQ6cwF+yOSMkM1tSNhrxfbZy@nongnu.org X-Gm-Message-State: AOJu0YzD0VHLvI2bpDuAFLFanVxFkGWeGkxT+ZYr2WblzZ/NMYHF+TmA CG1euApKCQmQvMKiqBQBbsz81ip/7Z7DumUe2EgVfHcqOSWIteJ8V33Z8kBHJkCdXRM= X-Gm-Gg: Acq92OHvGgSuBhCtu2e+vXy3602CO6LjSUW+ZTr3dd0FcV3MCQyT0CgaLRnuBBbhktw Wb1hq+7JezwpXGigzMAKjEzd25CNCKXA2Z0brgPF0ogBiSkaZ2BVDDooR4mjMNxuQaM7FS7Sdjz q6Or9oBZs530cnvxWIpefi+2cuW2t+htZDF44mRgtKIPdvLg+ZbJLzKqaQUb8/hvJcckkcL6C8u agJTfK+r0Lp6gJLFIHjNawPJdopC7OH8AS633xAVTviqv2dDCVtSqWJyxa/O/XW1Kl9FtXlVont D62PGibuigMDcEYFdIaYR6NOUQbRs5VrTbtTmrZfsXHlQ2J0Nu/XqLIyMsp2hAhVmcKcCE4/Ig5 byZPGm1bLoZJfu/f7J2vOzYpys6d89AX7ggLO83+ubQoNH6I+YKd32EMklrAKxfjgJlzfEaDl9G 3GU3XfwUhbfSZDZJnORkQxsB5CsqxEGeZ8s5Da/AG6tzjJMs6JI599gLVy/BQcEfMZfOMnUyPE+ eSyAfW3XPiq96lhI+BgpHz1NRUdWEU= X-Received: by 2002:a05:6000:1844:b0:43f:ea91:63ff with SMTP id ffacd0b85a97d-45e5c3673a5mr5736112f8f.10.1778855144101; Fri, 15 May 2026 07:25:44 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: [RFC PATCH 01/14] target/arm/ptw: Flip sense of get_phys_addr_disabled return value Date: Fri, 15 May 2026 15:25:28 +0100 Message-ID: <20260515142541.571911-2-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260515142541.571911-1-peter.maydell@linaro.org> References: <20260515142541.571911-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1778855188482158500 Content-Type: text/plain; charset="utf-8" We want to bring all the get_phys_addr* functions in ptw.c into line with the sense that translate_for_debug() has and which seems more logical: true on success, and false on failure. Start with get_phys_addr_disabled(). Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/ptw.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/arm/ptw.c b/target/arm/ptw.c index 8706dd59dd..8a412f463a 100644 --- a/target/arm/ptw.c +++ b/target/arm/ptw.c @@ -3506,7 +3506,7 @@ static bool get_phys_addr_disabled(CPUARMState *env, fi->type =3D ARMFault_AddressSize; fi->level =3D 0; fi->stage2 =3D false; - return 1; + return false; } =20 /* @@ -3548,7 +3548,7 @@ static bool get_phys_addr_disabled(CPUARMState *env, result->f.lg_page_size =3D TARGET_PAGE_BITS; result->cacheattrs.shareability =3D shareability; result->cacheattrs.attrs =3D memattr; - return false; + return true; } =20 static bool get_phys_addr_twostage(CPUARMState *env, S1Translate *ptw, @@ -3682,7 +3682,7 @@ static bool get_phys_addr_nogpc(CPUARMState *env, S1T= ranslate *ptw, case ARMMMUIdx_Phys_Root: case ARMMMUIdx_Phys_Realm: /* Checking Phys early avoids special casing later vs regime_el. */ - return get_phys_addr_disabled(env, ptw, address, access_type, + return !get_phys_addr_disabled(env, ptw, address, access_type, result, fi); =20 case ARMMMUIdx_Stage1_E0: @@ -3782,7 +3782,7 @@ static bool get_phys_addr_nogpc(CPUARMState *env, S1T= ranslate *ptw, /* Definitely a real MMU, not an MPU */ =20 if (regime_translation_disabled(env, mmu_idx, ptw->in_space)) { - return get_phys_addr_disabled(env, ptw, address, access_type, + return !get_phys_addr_disabled(env, ptw, address, access_type, result, fi); } =20 --=20 2.43.0 From nobody Sat May 30 18:36:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1778855252; cv=none; d=zohomail.com; s=zohoarc; b=G/K7LIARnsw3+mO7Dx19ifgVmeUxN0wptmWyhVUdQJJZ4/wFQg+w1SLYFVZfdui8W9HhBHIJT6wqy6M+qIsh4fLA8nZ+Y9vKKA/XsqZC19HbxOkZ4ZeDWU54UIfEtSNu4bprTvGq40dX3eDFKEWXVmbp2oXsvk5jKrIyepsMqwI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778855252; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=NIviysq2AqiFz9fV8rr10jJmjEvBfhW9uzxUqRTLkmo=; b=Gj9aLibIC0Cbz94xdAz53ZHTDR9VPkHTxmhD0P3wQsg6NuHFyBV52aF4jt2gDNYUvk2iKD/n2VAVpvdz4EMJ57zYphvo0+F2qPKjWY1hM2fJQNeVGxXI92xPErHOHOlwOpvB4cBDq6Xpt25Gihe1JM+0TfToTzjR32gvQ6O5ytg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17788552528731005.5003920505007; Fri, 15 May 2026 07:27:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wNtUL-0005xL-Og; Fri, 15 May 2026 10:26:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wNtU7-0005iK-7W for qemu-devel@nongnu.org; Fri, 15 May 2026 10:25:53 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wNtU4-0000uk-IS for qemu-devel@nongnu.org; Fri, 15 May 2026 10:25:50 -0400 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-43fe608cb92so5830410f8f.2 for ; Fri, 15 May 2026 07:25:47 -0700 (PDT) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da15a666fsm13560603f8f.36.2026.05.15.07.25.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 07:25:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778855146; x=1779459946; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=NIviysq2AqiFz9fV8rr10jJmjEvBfhW9uzxUqRTLkmo=; b=Zk1XrYKJ1IJnPsMwjhmk37DRz5hPFO2ybd+J43Gb0ZwwefXnQQHnFcQB1m03f5p7Xp MLoKu/riYFpVKqCKwlRztMMeobXo63vdu1ukWwL1CgYHLKzg1kWEf7l0PFHDUc7DdYjP b6zEIN3pAVsmOoBFxnJpuvvcWxAwEiuzUKW/nm49jgunLzVXSY3tGH5EUh0MyWkEt/ro uA0mtfOXllV8yc37AcDAvVM9E2mjjS341TMh8DOVLk9rpEwJ3Xx8S6LR1J9AOZ2kJu28 8iBrcF7xVqc4eiAWNagXcRwCoGaHHbushLIpbd82u93Y3qJmD6B1CYcy27c3kT9quIfh /LtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778855146; x=1779459946; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=NIviysq2AqiFz9fV8rr10jJmjEvBfhW9uzxUqRTLkmo=; b=py9Prv5wwTFn5RF+uSoCsQdfA3zhE2b/ZMOl4XE0VS58GTwVXc1DzqBjE4zwZSgYth CWCIxFCmofn4pGCUpk2A/FIvz0rO473+0j2wuNBvynB4bHoUjVRTywqxQ9r0RyBBpJvH pqu9GMhN2AJVCxuMfHbaLrrev1LRVZy8pAP/zzBhsXupSXb/k5fjae7ZB94Jg8er2eO+ voFuIjmt3YdDD6Tc4Ms/xPpK+xSiqJvhmJeAtdwm94GCToO7l5e9sfm6M2BwXvVzWIED 0rC4elf3MvMtjhmXJDWWUiTreerpnPhdWYa05PueTgoPHeJsxgnhMkbjO4NOP6OARKY0 W62g== X-Forwarded-Encrypted: i=1; AFNElJ/kMzu8k/UW+utM40Q4k4+jJyWRSAOgp+D8UmtB7W8sHU6gHzS1KRFOYuKSc9iql7LIODvO/G4yt8Mk@nongnu.org X-Gm-Message-State: AOJu0YxSsPBGbLqp6T8rAEBZhczpSZucNucyb+bWubQjtvtg8sAzt7ol +kavUk+59/RQv6m2fHsEELa0vpyc5wyu5sGjMJ9SsjN9Xu0UlUAoZ2Hy+2zP3qc/SM0= X-Gm-Gg: Acq92OEbEmEApmWJGq0v3vQs1SxwRYsFrxvz8ZZC7mkfWPI5iTVE095zy+k0zMxaYh4 e7Cb/0Hcf+pb5DCp4vV8J1Hcqn5nLOWhI0LVMvNImR9SM0wgzU8Rt6n0Nv0XLpdYuRAhkIZ7tID TmKB/T+vwzauTQ4pnbXMLXqeYxBxft1KpHVn0yJQtEvECi3oRkuzGOY2LwzOr35T0VQ6kJyxZ+f YSlnZMu1XtJMh05ggsUO31Ppv8OKSAMuUZ8qvzAv34qqm/C6Mia8HDyVyd3fSGaaODtJIeOclxe yszug541NHxEbdwGVmJM71sBSp3Zws6YsM29rvXUiybBDoypsY+SckZkOZHPr8SyRn6sHGYtwyk +wtRkIH2gcyULF6fAqP///Fk0W6jYGeWXI/F4cRh1h08YQp5/VEEmoS4zVRPHN0w71yDSWv3sR2 d0WNVhoUuQTtoGFoKqqCJvFRs4U1vKe1lRTQLE/5Dmj8THsixHpO1cWSkMzyQ+hrK0KycTO4fHw SzA6uH/0Ss4e/VvEYD3IvAF/K+csssWVtSTGmfj+g== X-Received: by 2002:a05:6000:26cf:b0:43d:7a97:78b5 with SMTP id ffacd0b85a97d-45e5c5ccbe0mr5803493f8f.33.1778855145871; Fri, 15 May 2026 07:25:45 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: [RFC PATCH 02/14] target/arm/ptw: Flip sense of get_phys_addr_lpae return value Date: Fri, 15 May 2026 15:25:29 +0100 Message-ID: <20260515142541.571911-3-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260515142541.571911-1-peter.maydell@linaro.org> References: <20260515142541.571911-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1778855253239158500 Content-Type: text/plain; charset="utf-8" Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/ptw.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/arm/ptw.c b/target/arm/ptw.c index 8a412f463a..93e77b3eb6 100644 --- a/target/arm/ptw.c +++ b/target/arm/ptw.c @@ -1842,7 +1842,7 @@ static bool lpae_block_desc_valid(ARMCPU *cpu, bool d= s, /** * get_phys_addr_lpae: perform one stage of page table walk, LPAE format * - * Returns false if the translation was successful. Otherwise, phys_ptr, + * Returns true if the translation was successful. Otherwise, phys_ptr, * attrs, prot and page_size may not be filled in, and the populated fsr * value provides information on why the translation aborted, in the format * of a long-format DFSR/IFSR fault register, with the following caveat: @@ -2432,7 +2432,7 @@ static bool get_phys_addr_lpae(CPUARMState *env, S1Tr= anslate *ptw, =20 result->f.phys_addr =3D descaddr; result->f.lg_page_size =3D ctz64(page_size); - return false; + return true; =20 do_translation_fault: fi->type =3D ARMFault_Translation; @@ -2445,7 +2445,7 @@ static bool get_phys_addr_lpae(CPUARMState *env, S1Tr= anslate *ptw, fi->stage2 =3D regime_is_stage2(mmu_idx); } fi->s1ns =3D fault_s1ns(ptw->cur_space, mmu_idx); - return true; + return false; } =20 static bool get_phys_addr_pmsav5(CPUARMState *env, @@ -3787,7 +3787,7 @@ static bool get_phys_addr_nogpc(CPUARMState *env, S1T= ranslate *ptw, } =20 if (regime_using_lpae_format(env, mmu_idx)) { - return get_phys_addr_lpae(env, ptw, address, access_type, + return !get_phys_addr_lpae(env, ptw, address, access_type, memop, result, fi); } else if (arm_feature(env, ARM_FEATURE_V7) || regime_sctlr(env, mmu_idx) & SCTLR_XP) { --=20 2.43.0 From nobody Sat May 30 18:36:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1778855170; cv=none; d=zohomail.com; s=zohoarc; b=AB837XaPI3yim1oYMYpILWWc7w0Zhr3dVUeW8a9oqH57mNc2CvKCp+W7Ho249yO6AtiaiQjZPzZvu3cSm6Zp7lypUFGWj/xDRHzbijcGxF197XihVFzVrX9VaZJPU3O0Hx0WEmqj5NPvUCrxGEbF81vCljSSaSmL0G3sF3ygN84= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778855170; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=PhqHUhwfIQWqhESGZ3sqsj6+o6aM/A5Mqby6FRMskD4=; b=NcPkQInt6j2PZgAVZ+nM+58NAPEjG00Gt/KG5rBnBxaMJKx0TFCV5SKxFB5GnrHdyCxITZ2fI6JTDNgEudO432YL0LlqYOPvbPp8oDxr4mdP1AcQY08919DUS/Bo0ij3zeYVqCvW2IGyzc9Z/c5iGxPCJzQfTm/C0Jg4UvUzKMY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778855170828452.0937414210281; Fri, 15 May 2026 07:26:10 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wNtUE-0005oZ-0n; Fri, 15 May 2026 10:25:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wNtU7-0005iL-6V for qemu-devel@nongnu.org; Fri, 15 May 2026 10:25:53 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wNtU4-0000vH-Id for qemu-devel@nongnu.org; Fri, 15 May 2026 10:25:50 -0400 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-48a563e4ef7so83786825e9.0 for ; Fri, 15 May 2026 07:25:47 -0700 (PDT) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da15a666fsm13560603f8f.36.2026.05.15.07.25.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 07:25:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778855147; x=1779459947; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=PhqHUhwfIQWqhESGZ3sqsj6+o6aM/A5Mqby6FRMskD4=; b=wwEJrwjDYoWAXYdcVhMhz4UHDnJ6v1+Aw5+Ql9q3IeGgI6xesyuYOZDImRzscHKnP6 ikL9TOtz+HaGBQTHWW448Az6F+N4zoeQyzeT90WmDft/QNPA/IJDfr8NL3W3W85Ajcfw Zisqsxwu2rv6o8cDUrumca6RB1HWhfU3SlhZWJkU5OJL9d8OdgSiYKK+gtYTMuiBta/m SK74qgSa06BM+PsS+W+CD9AK5Wm+NAXOLmhLB8yNDPZEBdTy0AwF3/jKWHlLD3cr/a64 8Zyg2tudOUTlCFgQ8YClE/eCAx0Lf/7R94dOVWQza5QQ6if2dzsq7QWGJwJq4/INj+2P Uv8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778855147; x=1779459947; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=PhqHUhwfIQWqhESGZ3sqsj6+o6aM/A5Mqby6FRMskD4=; b=GTtNIaIXrfZj1D7UEUPyFO1PtiKLcrFoHi098jbhq56CT+GJLPVh7NgeiiOd76zNkj 2RdLMJt0h3e+87N385xv4KjE2XwL67vOdZvJJrKFJt54EKmYhX5Jn/C9fiR/p3XoO2FF Rns9l8pdgr46pb+qlNNh9+IJdHVOrWaIygtL8YlmbYYUAq+q2HYT/77r2axj+QxHnPxN MI0uYM7sWpol6ipYzNagA1pePlQHzLyMKnmOT2JF3B5SJ75qIS6hKO0sjcT0uldT9MNy NxK0ISI7G/lm0CKUzAol03u1SwCN1ICbaG0pumto+UwlbfnB3UNpWSWHgeBHac52Wiiu sRGA== X-Forwarded-Encrypted: i=1; AFNElJ/qrii7Hjcens5iRvLhwR27EyIzV/ctTClKN8HmX0VRpaSGNlnDMOoLaFJTa4WpG7lAh/q2fvJ63azj@nongnu.org X-Gm-Message-State: AOJu0Yy77kaXM+VvXepnPnvQOifcTeSG6BmVWaxOUI3wzeepJUN3twUs CcNecD6P720yTUVm5WjvK4pY7DONnZ9719fEGcAnYsKzxu40NhyLeAQkVaqvOIsqccdziIRU68+ DsXpV X-Gm-Gg: Acq92OESzzHno4OEU25kcksuG7k9pYW3VkxOZMSrlJM1cWTvssI9LPbL5iA8fm51yqv /OR6B0nx3BVjItvD1V1A1n6a4vOdIYFpxGvSJNb7qoSL6RdNhbT2gYFk6aPeD16oKuNgtTWZL6j SoqGUGpxQX5iMhiGXBfbCljlEcGbqUSETYYftdQPZlYk6pK2pERO+SOpjY66BVyjEiY8q3EEaPb wNjvZaaKl8dYQ9L0gItbznkYG8zJ2zkRP/V6MjqdE+MG7QBCm1SFDzNgPJP4PriDE9RC5MH1Ybq mY46UPy3l1WQPyonLkpsV5dnC+mvyDsx18F6WBCA2IEX/WMcVcCe/yram8RAyfaVGWZjlMgIKfn iW4IvqODswA8JQjLDBqhYM1IFTw8RJJmcxbivX/uiAekpR3bBYfTVl5iT/AUjtPsPMpUuvp7zfd gzJvwTmkmwc6tzLKHf/ClH9+SpCU/9OoiASjqjmZxEQM+NChvgmaWEEu0WYzPVKSquxcrXBXuZh dDEuox4xLMuQaYJzcvBNu8Ji3Y9ymBBgCluyJRKog== X-Received: by 2002:a05:600c:a00f:b0:48a:5301:bb5c with SMTP id 5b1f17b1804b1-48fe63263dfmr59705095e9.16.1778855146806; Fri, 15 May 2026 07:25:46 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: [RFC PATCH 03/14] target/arm/ptw: Flip sense of get_phys_addr_v6 return value Date: Fri, 15 May 2026 15:25:30 +0100 Message-ID: <20260515142541.571911-4-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260515142541.571911-1-peter.maydell@linaro.org> References: <20260515142541.571911-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1778855172199158500 Content-Type: text/plain; charset="utf-8" Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/ptw.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/arm/ptw.c b/target/arm/ptw.c index 93e77b3eb6..fa251f5b5c 100644 --- a/target/arm/ptw.c +++ b/target/arm/ptw.c @@ -1326,11 +1326,11 @@ static bool get_phys_addr_v6(CPUARMState *env, S1Tr= anslate *ptw, result->f.attrs.space =3D out_space; result->f.attrs.secure =3D arm_space_is_secure(out_space); result->f.phys_addr =3D phys_addr; - return false; + return true; do_fault: fi->domain =3D domain; fi->level =3D level; - return true; + return false; } =20 /* @@ -3791,7 +3791,7 @@ static bool get_phys_addr_nogpc(CPUARMState *env, S1T= ranslate *ptw, memop, result, fi); } else if (arm_feature(env, ARM_FEATURE_V7) || regime_sctlr(env, mmu_idx) & SCTLR_XP) { - return get_phys_addr_v6(env, ptw, address, access_type, result, fi= ); + return !get_phys_addr_v6(env, ptw, address, access_type, result, f= i); } else { return get_phys_addr_v5(env, ptw, address, access_type, result, fi= ); } --=20 2.43.0 From nobody Sat May 30 18:36:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1778855300; cv=none; d=zohomail.com; s=zohoarc; b=KknTk3qVGKSHuVi6p5Izdx2h5eqIbDvBcjlOp4Gn9OOXhs6OOpKVPgg4f1DKY8eknDpCd42wu4mqCm8ihCB5Kaw44luIAqVcCapej43YjfOwwgAGZKsfe0i6BDM0lyeBx7Yd7tjXbSi1eo+BHGnGX9UQtnUh9pvd2nbjSbYENW4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778855300; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=iMeESVfxoQL4XM+HmSKggMAQZr6iHvyZ6SpMkCmyMlQ=; b=PfxdUIaDXPtPcCZjWRrZ4UTvo9CUIiGUOpUqJihFPsZdNGYf2fePqF1YpXey23sTCLk+QAMENIAj8iFLldNutCyKXO09eWTlS5Y9C/DbZqiqurZglx4HNtDM7qX+qpXCxl5AAM4r+VR0zP9Ek92h5qICWi1nWsSprJKVfLyA1EA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778855300412950.9556253059449; Fri, 15 May 2026 07:28:20 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wNtUg-0006DU-A1; Fri, 15 May 2026 10:26:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wNtU9-0005jF-O2 for qemu-devel@nongnu.org; Fri, 15 May 2026 10:25:53 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wNtU6-0000vf-Ps for qemu-devel@nongnu.org; Fri, 15 May 2026 10:25:52 -0400 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-44509921fbcso4770233f8f.3 for ; Fri, 15 May 2026 07:25:48 -0700 (PDT) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da15a666fsm13560603f8f.36.2026.05.15.07.25.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 07:25:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778855148; x=1779459948; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=iMeESVfxoQL4XM+HmSKggMAQZr6iHvyZ6SpMkCmyMlQ=; b=xxr4DHVjwldXXkWJzo/oYmfRlyJhob6KnbOcbisSzF0VfsumVe+yujXVMrKPt/2W2h 6XpUfeufdG0G28Bdf7mGPQNTGxO0xqq0W2qN6vHoQYHAYBnDluujhx/7V7VNbsGM8Ukn BUl45xc4Y9DaYzgxc7o4LzaqfB0vS0nInuKCP7hDb3md0JUq5/rzXp2e/krEFOBpKmxJ n8s3mCAUj8ykqdVmUI8XT7V82tRufW6FP0MXxDrC5B+xdyOryOe7XHCNmXhwijjS2ZWZ k/IMd4L+fE9v/SPXza6ie+iD3JA86QG9ioZaUM/K4FT3B2c/Fm5JvFk0+ViULDsjir24 rHag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778855148; x=1779459948; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=iMeESVfxoQL4XM+HmSKggMAQZr6iHvyZ6SpMkCmyMlQ=; b=CZTb0rqAtWS3auZQViWOX44hxZh3LtBf9AqIPnZYpwvS9+NTpCWut4XZN84lK8zCh7 W9z+6aTDD9nyKzwjwmAB2RmmUeccglYlVVwrjisZMlzlMBWOoD8B85HWZKks9A7sMRMj HjKxWxXu5YlqACLOXen/2jtbsm+SFJ+Vb2fCrJsAUA4gCK16hvvXRc8Fvb1ktx8NZGaQ pJWZLdT7xEeiRUZ8Jah/RSNfhg0H0cz1JR6LRwU18WmEpxP1+2Ly2OCvQIVhzGkZKcJk V6f6RYYtkPjmK729iH8TCAKZPYKzNnKAkd4iTfJ8PHBPRuTrpmi+E35oq/B+EEJoG08J zyxA== X-Forwarded-Encrypted: i=1; AFNElJ99Z1OBdHzRlxu1Br5unXiFeZ88fTsAWhNvdh0ayDcHBrTd+djkqshwoDvo+daj/hKxsbXUDDqpwORL@nongnu.org X-Gm-Message-State: AOJu0YxYmxFNIfVEnTdgaRjtd5PXYfVYvebK3oppjlNL483gScbK3ZcH 8kG1oYJjJE53eltMWLvJwvw7am1MdWemZU5QMbCEnA2Imf8ZvoFHgdCaKKdx1YtIDt1mV16opr1 +dzwP X-Gm-Gg: Acq92OE/dBNpWVOdKmMuPSR1gNojaRkIvSNf1wZ4kV9l4yTYPP+dvHC51PwtyqqLQy3 Sq91YgTAaEFYJx0eexnaCs8L99EP/kVxylcGyZiDjkc25hIMdKxf1NpSN9MbhjwsV4KqHxUIqQl 30mYpsgkt7JFoXTOlv33OQGv/U3bXd04yk759pBtLhyBbCMDwvekajmzMi1E6Cr4ovBbyhBQxtz CNT/PGTXITAahLEaoIM1P4m9KupMnUebx2cmUQiDHAO/c6NkAhmGvbHQf3t7lhm5HO7tt9NdHE2 gHBlHRzg1whz6RybCUXOi6HRbHKn8gnYdnFSlGJlD9wGqh5+3Dls6yZQ33wVv9lkCgkgscVPPm5 Vkt82FxH2wtQjEgEQvZxgGxZYoW09q8VAAILkdw0JqJNjXPU9ZRRIH43cMnRPN2tZuzN+i9p18E cD/uCqxZBV3HDNGjJpx7HjHVTZNu4ZWnS6A3yUjYe5zcvcQM+0XNOafzRUC2N3WRY17TRvMNqjm mx3LQxyBUjQdx1Jf8SpfPppUBvvSx4oHxQzkdWENYMUv/MTNDu/ X-Received: by 2002:a05:6000:2502:b0:43d:7e34:889c with SMTP id ffacd0b85a97d-45e5c5e68b7mr5918628f8f.39.1778855147705; Fri, 15 May 2026 07:25:47 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: [RFC PATCH 04/14] target/arm/ptw: Flip sense of get_phys_addr_v5 return value Date: Fri, 15 May 2026 15:25:31 +0100 Message-ID: <20260515142541.571911-5-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260515142541.571911-1-peter.maydell@linaro.org> References: <20260515142541.571911-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1778855301949158500 Content-Type: text/plain; charset="utf-8" Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/ptw.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/arm/ptw.c b/target/arm/ptw.c index fa251f5b5c..1730caf180 100644 --- a/target/arm/ptw.c +++ b/target/arm/ptw.c @@ -1169,11 +1169,11 @@ static bool get_phys_addr_v5(CPUARMState *env, S1Tr= anslate *ptw, goto do_fault; } result->f.phys_addr =3D phys_addr; - return false; + return true; do_fault: fi->domain =3D domain; fi->level =3D level; - return true; + return false; } =20 static bool get_phys_addr_v6(CPUARMState *env, S1Translate *ptw, @@ -3793,7 +3793,7 @@ static bool get_phys_addr_nogpc(CPUARMState *env, S1T= ranslate *ptw, regime_sctlr(env, mmu_idx) & SCTLR_XP) { return !get_phys_addr_v6(env, ptw, address, access_type, result, f= i); } else { - return get_phys_addr_v5(env, ptw, address, access_type, result, fi= ); + return !get_phys_addr_v5(env, ptw, address, access_type, result, f= i); } } =20 --=20 2.43.0 From nobody Sat May 30 18:36:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1778855255; cv=none; d=zohomail.com; s=zohoarc; b=XXjZhPaC9yrjq1wzBNxVnHnou13c83rFG3uLpKTev4geHK2USIdBF5K9XrH8nCpjoizUb1epqr5Q7pqsQW1XorJLJsVe7A0BSd0dw5U7mvsc0hpLaU6B3sy5oxS828L82UqzMGH2TKV+28UBfWqmAVUHspzbgXKHwxRIzI+LHfc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778855255; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=rXHKmMfulXONWFzDkmbeI3DvUTbX1A8YSRTRyTS3EJA=; b=nrpXqNpYNNiNrD5gLL7Mzc2y9c4nP1QbBO1tgH8ahoJBlf1lG+y3XslcQOdjpw6skVRnNV+niqg0tpa8a+FVPnXU2YYNzLjzLIlP4rNLIyFDlcxns24nECnxOH8p1oWm4s5Y1zqtpRF892Wk4hTE3PT09zJ8SSf7LH6dN1jPYbM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778855255331836.6762558993861; Fri, 15 May 2026 07:27:35 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wNtUL-0005wW-CG; Fri, 15 May 2026 10:26:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wNtU9-0005iz-KD for qemu-devel@nongnu.org; Fri, 15 May 2026 10:25:53 -0400 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wNtU6-0000wQ-Ql for qemu-devel@nongnu.org; Fri, 15 May 2026 10:25:52 -0400 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-44e1860558fso5989631f8f.0 for ; Fri, 15 May 2026 07:25:49 -0700 (PDT) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da15a666fsm13560603f8f.36.2026.05.15.07.25.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 07:25:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778855149; x=1779459949; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=rXHKmMfulXONWFzDkmbeI3DvUTbX1A8YSRTRyTS3EJA=; b=GAKPw49bznCkrxuzyZFTNU6FxXHROzkD0/u0mhghf77hnz7DFDTw46XtdIZutCDfVC DzM69toIpGFop08ppfN79jU3Tivk0iFpM0LZrup8A6TGWDbiLJcQjc5bjeqSncplt8z+ nNJN0lLrwadyNJnYumN7U3S67lErgqYCu07eBoz91KGwxFql542fZ+NWvWDJjtn38HqP CzLoSNWlk+jUgUVWMW+tp+7TSr3rgAukbswLz7nerzVxAmbJebtY8V4rgnji/U3dEwMJ Y2YBP6yzkGRtWOC6IATjudFAQj0LjpdZCStJtc8Y0I54mcGgvg0rxlseIkB6uuYCx5fV XN4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778855149; x=1779459949; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=rXHKmMfulXONWFzDkmbeI3DvUTbX1A8YSRTRyTS3EJA=; b=eoCMNL9bhqA9PCIFOhguoF1xFblhige7HIc/AX1RpZHNuLOpLYTj+mpKE1akNDfVtR pLv8b6xBciZThSbZIHEqWqoD+Rq9Ba4zy732HSA/cSiOgrRMb6g3gjTJRBRWPpbhjEAK gq5sPTAyY5KLUnWmxLcNwdnpGVdbIZ6st6+GrofIHa1/PlstCdAig3fZp1GTUAhQbYHn V+jnXWly4X+916Hw40CLIN/lKwH2e0A/UMWPuaOiJZlCUyEJAZT+cjiCi512zzskFAQo 7yJkS59dQzrPSiLnR4HRVQ9AnPOPsyP4Do2zd7OWfuMonuV7dGihWuI/ASNFXSSv0HUi 93tg== X-Forwarded-Encrypted: i=1; AFNElJ+yKR3mLAP5hGrzkx8djc4CwoBeRE49KUy7FUdYeIzqYCOcilfw8j6c+KZa9p8NOueNPqiUXiT7BsNE@nongnu.org X-Gm-Message-State: AOJu0YzYs6C+WFnLZMkEyNxqmfqsQyP2THkZqk2Uo1itX5ThyMEoywlE l6EtJWly4vRSQjxURm5ZVTzLyJdMLQ0TtbBBcT7myKDQunKQvuRM0mOrjELUBYEB2LZWMqKKLIu iNmbL X-Gm-Gg: Acq92OE8Xo0PUWOIbCWol38XIgfUQD6fe6TyROEAsxvXylUKGeiBgtACPUJjvtx/URB cnd42Dlp65D/GKCC08JKTFrPpAdwsDbrPD3RBE1nPrzO2z0xoagRMBJULKGNfv7jAS54jRt6jnN i71+ZhqwVEhhLSZweVH+2lKCqLn4L22UsIItI5JfqXYzNBZl6azeitxDWCp0CtPrxcGW9Bw1B1S bz9gHBUcxF6Y9oP/6fNWBbzAvx47yy1RLxZkWSIlY5Q0Axe3DBG7LiNcXdinH6gNSG0VAuoWVmj yQ3yz62Q1EtJnkJyvtSx9JtIMgwhHy3L2BkocAc0c1zTOCIZ5W0vEXeIrnDt5OezPUH4hsbt0Xr 8z0hBGkbLwIzAPKmL+PFu6BIPaC5d8dc0HrnKmwRWf7TPIe6667Pk3MlMC33APfxvrwipkRrsiU MBTCpMwCk/rYrG9cmTcRLRtLUzDLPOsM8xozMsIZJR8sDN1fizSR61wj6n2DSi4zTOToKXoTi82 xm4e1y3nXkKfvloHG2j4EjbDEWhxrI= X-Received: by 2002:a05:6000:2401:b0:43d:7275:c1eb with SMTP id ffacd0b85a97d-45e5c5dadeamr5980139f8f.39.1778855148643; Fri, 15 May 2026 07:25:48 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: [RFC PATCH 05/14] target/arm/ptw: Flip sense of get_phys_addr_psmav5 return value Date: Fri, 15 May 2026 15:25:32 +0100 Message-ID: <20260515142541.571911-6-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260515142541.571911-1-peter.maydell@linaro.org> References: <20260515142541.571911-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1778855257331158501 Content-Type: text/plain; charset="utf-8" Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/ptw.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/target/arm/ptw.c b/target/arm/ptw.c index 1730caf180..c9563557f9 100644 --- a/target/arm/ptw.c +++ b/target/arm/ptw.c @@ -2465,7 +2465,7 @@ static bool get_phys_addr_pmsav5(CPUARMState *env, /* MPU disabled. */ result->f.phys_addr =3D address; result->f.prot =3D PAGE_READ | PAGE_WRITE | PAGE_EXEC; - return false; + return true; } =20 result->f.phys_addr =3D address; @@ -2484,7 +2484,7 @@ static bool get_phys_addr_pmsav5(CPUARMState *env, } if (n < 0) { fi->type =3D ARMFault_Background; - return true; + return false; } =20 if (access_type =3D=3D MMU_INST_FETCH) { @@ -2497,12 +2497,12 @@ static bool get_phys_addr_pmsav5(CPUARMState *env, case 0: fi->type =3D ARMFault_Permission; fi->level =3D 1; - return true; + return false; case 1: if (is_user) { fi->type =3D ARMFault_Permission; fi->level =3D 1; - return true; + return false; } result->f.prot =3D PAGE_READ | PAGE_WRITE; break; @@ -2519,7 +2519,7 @@ static bool get_phys_addr_pmsav5(CPUARMState *env, if (is_user) { fi->type =3D ARMFault_Permission; fi->level =3D 1; - return true; + return false; } result->f.prot =3D PAGE_READ; break; @@ -2530,10 +2530,10 @@ static bool get_phys_addr_pmsav5(CPUARMState *env, /* Bad permission. */ fi->type =3D ARMFault_Permission; fi->level =3D 1; - return true; + return false; } result->f.prot |=3D PAGE_EXEC; - return false; + return true; } =20 static void get_phys_addr_pmsav7_default(CPUARMState *env, ARMMMUIdx mmu_i= dx, @@ -3763,7 +3763,7 @@ static bool get_phys_addr_nogpc(CPUARMState *env, S1T= ranslate *ptw, result, fi); } else { /* Pre-v7 MPU */ - ret =3D get_phys_addr_pmsav5(env, ptw, address, access_type, + ret =3D !get_phys_addr_pmsav5(env, ptw, address, access_type, result, fi); } qemu_log_mask(CPU_LOG_MMU, "PMSA MPU lookup for %s at 0x%08" PRIx32 --=20 2.43.0 From nobody Sat May 30 18:36:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1778855290; cv=none; d=zohomail.com; s=zohoarc; b=G/q0sxERTW7mVkFxS5xfx8mEEJq1IZLPVOg+vx3iydYQZg3gNfR/DxnWXFXrS60PLKBN6d3PfYai++Pej4p6hnoSPARoQ/xCaQ3biS5pauv1l99H09jgn7sxetOoy2x3diT99UxcQEgDbzZZ8F15JWnJR45H5uac7qDCjpSU0hs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778855290; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=3JaWcGkaE9fLWfSI8DU3cpDjO0IByAUy1JTs+IjAeEY=; b=BQ2M8HTytSRlD5eSFtAHMwE8py71aBRLXQw9GRmh7lJjZcOndmy3E8T1huPB8vexRbpGsrG4B3gwbLgTTFgv0K0NyEHDi3c14vZY7372N4mIU2gkY5nSlH8Pwpk1sPjV9rZs8u0HS26Z6DYW+tkVSLlWnMBcN2Yfdnguf4IV0rU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778855290842640.8970577706932; Fri, 15 May 2026 07:28:10 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wNtUg-0006JH-SZ; Fri, 15 May 2026 10:26:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wNtUB-0005o9-EO for qemu-devel@nongnu.org; Fri, 15 May 2026 10:25:57 -0400 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wNtU7-0000wg-8p for qemu-devel@nongnu.org; Fri, 15 May 2026 10:25:54 -0400 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-43d734223e4so660338f8f.0 for ; Fri, 15 May 2026 07:25:50 -0700 (PDT) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da15a666fsm13560603f8f.36.2026.05.15.07.25.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 07:25:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778855150; x=1779459950; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=3JaWcGkaE9fLWfSI8DU3cpDjO0IByAUy1JTs+IjAeEY=; b=EkrD13o4pmOBeroyHY964/H2db51/9CfMj1HhdMjSzUCP4dNLlmzUaIgcN8FRWix8n Qhknoy6jQhvE//5oYr/a2uSn/XZV3WN6JPXPS+BF27iyzVdUcnHPJeiv501OyTjtkOdc XTqcloNKr9Iqz5sfD6RUKyerNqnhrtmO8x75rcpSZr5eSGj1qIU0FygjVTU4wWYnlcdH eDXCOZrEuPSF9BVmt7cWVEyPFJcXvdv1Dmlh41rhjYmrvwxCAdsPqnK+vRxjlESOAWIh oF4uSoUOiT5JOzllxmJtAm/nZG8YnHLukWjqGoM/rWcXGgKWuwqKGOcVNSgTs9iJ5qVi 8B6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778855150; x=1779459950; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=3JaWcGkaE9fLWfSI8DU3cpDjO0IByAUy1JTs+IjAeEY=; b=Gc1zhADg+xqkwhNcst1K7ZzcfcRZafSpxYw7pxTOKCszPstvxWuAKxAJ68xevnIsEH YdfyQUVtaYjpphlmZ0F0EeKAE/eGTrNfDmabgUx3ObeHqk3yS5eh/lf4+7/1MQka5K6u ynRO8+d3exZIPlDZZ3uG3E6/lPFlsenx2zAJ2XC4H2jZZXDjQdlLY+lL5/X/M5HmcBJz RbmVbQfQcqvmowZqHX3sW2DrM+0iaUpB0ESIPrNj5v/yAs0oU7efcmEzBYsacJD8xbuh go/Nl9iOTXPlNcsl2+/wbCrvDl+Y3AqyMGz06rgXnZjyqJNR3uIDfMB3bkN0X7ATD0cq Xtww== X-Forwarded-Encrypted: i=1; AFNElJ+zWNIVzFGQx2PrlbjDi0quq8HP7asba+BGkTSq0hIWSFqNonXXLP5t7q6XlzlIVxgFmYt4KDBjf0vc@nongnu.org X-Gm-Message-State: AOJu0YzTshX5Fzzq/dPOwy7dVK+gvqrPpn2MJOW4K0QkQSdqFaMayNJs T+u6cBDm2Ge5MySj0KE+LkbZzVuX3powzmPwbGxBcZLIj26gNAoUK14Nmt5BcC1xTrlYgDh6E22 lk/bR X-Gm-Gg: Acq92OFVys+8YXh9IH5nfqWGpCmo1G694aXkDmDNEYmeBSUYewxM0MEBeVIZsqSM6L7 n2hRqphdHcv4Yol+k5RJwirub2JURog0a2IBSw5oFezuXHpgVyjmoPXP0JzENp9+NTxCMqLKiCK MMZPGfQFrqGamx1aEw/vHbPDl+3nfJdaa09gch4My/6oI97Y0dFlI8ewz9uygD0/SK3DXxALFC1 h+v0qQXbW/BnfX0L9sspAWASmOjKRiWx0PcdWOutIcP2r3le/Vo7jOSwxRSdf5U7oyOnGHCYDDd up2iC1/CqVzUQty66XjIrCpPD6Ct5BGL+MrE6z1k8o+YFkpcVq2qKM5e6VuxEKFwthaTJdPjU/g o6SgYXbO3It0rrIkeiHGmD+Cq37gLfJaixFvMOOgPvKpzG2Ys3EcN8efZY5hd8souwAy3piAf54 5QI26WYPo8xpzoaTatoDaP1NWBUDaZ3H1P238cg8J9LdL0UAmQEvVsoqa8pmBbzSSyZY32NLCcY Qzy7rKiqEXoHKZEVgxd6sOXi/FDSJU= X-Received: by 2002:a05:6000:230b:b0:43f:e978:148f with SMTP id ffacd0b85a97d-45d941b0bcamr12909063f8f.25.1778855149681; Fri, 15 May 2026 07:25:49 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: [RFC PATCH 06/14] target/arm/ptw: Flip sense of get_phys_addr_pmsav7 return value Date: Fri, 15 May 2026 15:25:33 +0100 Message-ID: <20260515142541.571911-7-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260515142541.571911-1-peter.maydell@linaro.org> References: <20260515142541.571911-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1778855291802158500 Content-Type: text/plain; charset="utf-8" Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/ptw.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/arm/ptw.c b/target/arm/ptw.c index c9563557f9..12e700fe07 100644 --- a/target/arm/ptw.c +++ b/target/arm/ptw.c @@ -2732,7 +2732,7 @@ static bool get_phys_addr_pmsav7(CPUARMState *env, if (!pmsav7_use_background_region(cpu, mmu_idx, secure, is_use= r)) { /* background fault */ fi->type =3D ARMFault_Background; - return true; + return false; } get_phys_addr_pmsav7_default(env, mmu_idx, address, &result->f.prot); @@ -2806,7 +2806,7 @@ static bool get_phys_addr_pmsav7(CPUARMState *env, =20 fi->type =3D ARMFault_Permission; fi->level =3D 1; - return (ptw->in_prot_check & ~result->f.prot) !=3D 0; + return (ptw->in_prot_check & ~result->f.prot) =3D=3D 0; } =20 static uint32_t *regime_rbar(CPUARMState *env, ARMMMUIdx mmu_idx, @@ -3759,7 +3759,7 @@ static bool get_phys_addr_nogpc(CPUARMState *env, S1T= ranslate *ptw, result, fi); } else if (arm_feature(env, ARM_FEATURE_V7)) { /* PMSAv7 */ - ret =3D get_phys_addr_pmsav7(env, ptw, address, access_type, + ret =3D !get_phys_addr_pmsav7(env, ptw, address, access_type, result, fi); } else { /* Pre-v7 MPU */ --=20 2.43.0 From nobody Sat May 30 18:36:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1778855244; cv=none; d=zohomail.com; s=zohoarc; b=oIGYGdHHmcZtvaH8FiNQgglQRk7zvihFY0Gd5dn6AVG278KgI/NzdzsrsovodFYiBnULryVDdI15sp9yNkGVrnD4mFUOpVsTN4vaPis3jS1saBdQVU4DHf4KONxWFJhu51ZFEHa4sADhaqA5Uvm+EBrOt1nsljWpBYRenSX0eic= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778855244; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=t0rq5jO3cSf426ienLyFOb1GQ8eVJAFyUw3y8YOuBwE=; b=IArA/e3JPZ8KNCsyldhcdAwCnzGwAaN323jR/v5WeFD1ggfQkQnf1xgAVDKXIrEJxE9+/RqS0yUWSTx+X2sgLqf8XEO4jP4jQ7/vtz4DT1wYcv3pC+GXPVCzQtBpMSDCAmnSWJuPdChQsBHmGIMEjTOO+6qV9bsD1iTtWh39alY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778855244833600.6214413091116; Fri, 15 May 2026 07:27:24 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wNtUN-0005zx-HC; Fri, 15 May 2026 10:26:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wNtUD-0005qn-Np for qemu-devel@nongnu.org; Fri, 15 May 2026 10:25:57 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wNtU9-0000xH-7G for qemu-devel@nongnu.org; Fri, 15 May 2026 10:25:55 -0400 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-48909558b3aso89053765e9.0 for ; Fri, 15 May 2026 07:25:51 -0700 (PDT) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da15a666fsm13560603f8f.36.2026.05.15.07.25.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 07:25:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778855150; x=1779459950; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=t0rq5jO3cSf426ienLyFOb1GQ8eVJAFyUw3y8YOuBwE=; b=r+QUfeeYhkdlwbtvEJTuR2tJwPoluPNI7xgfmWkCLK1QHluR3vGUzgyaJ9IyFgrNkw 9eJGDm12+zEjGdrsOAl2hlqYpkxjgCGMI/HFJ4Ad/1OXqquShY4CU6m/qckulM5BrWDn 9poKibNEEC+eLXO49FjqytiQNid1gq4WzT+bwGQUTn4eSyC4DEGNVm/Yi954YcoSyAJR aUiOerHt1v/rsIC8nDBx39r9z+1wfI8Xvmfo/nadHSotEhqyK8tei52ANGPXib+Epj+r e4zWlkLd3Zvv1qETNACf8OrlbMvmrYPZvYl2FDFQ5xZEgpyVwex1a51v9Muu+sqruM8t d5vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778855150; x=1779459950; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=t0rq5jO3cSf426ienLyFOb1GQ8eVJAFyUw3y8YOuBwE=; b=qsY9tqaDfpygJimm89qOoanOFaLFLQfT9BSecAIObWZeb7SyMYS+CITA5qjJH/gYc4 gLJV7WqvV79wZ1Elx2lBP4cABxc+LP7I0Q6Xgj5Kip6krBQB1Mae3eZwfn2HBPNVc1KR KmDcH81Jn0LPfltslLTekRrESjEWM4tUe5X9P9I0JALQ3dEOjoYEF9regjUpbhJ5rUXO EDF7QbNqQ52VoEXyGrkpe9LOZCBUGJvmm/UtkQfKOgCb/mrgZHWkJH54Lq4Ap3YNIQQt wr+9Oqv/Go8mqDDBev1QRpixmSryzhGfZjmjg354V6zTSLcn6bsxOKIuhsdRcWp84kzq jy3w== X-Forwarded-Encrypted: i=1; AFNElJ/S0pMJcTigd9UfCfFD8K3KBV8/nmwRFdKEsDKWFBDk/U16uQiHaD6ImcRaRfGClJRvyg6PnxAJ06fD@nongnu.org X-Gm-Message-State: AOJu0Yy9BD15jpYGdNcb3xH20ptVOdWGHmwuv1/grp9nH4LC/miGDghQ p9aX8y3C1HJ7QsLldAdWHm5EAFtQzoLUSwMn85jK4RnS2DEozVJcsNpAYZSXjPT/1Us= X-Gm-Gg: Acq92OFmsL3Vavlgmwk4B10xoKS8hFtRDncE3HDTn8uDni9ty+k1PE95VJCmq2tpLwt 7Dc7n9XGPct2Px0h5g8w3KicZx/wOdT1NRl5UzFD3lkpRM9zdqdV61s7OC4HnKtBjxrJdiOr0e6 erlsrSouberB11/mgBZg/rrPeK66NHNrsB52Lg78Ug1TmQLaw3TldHaCdJg5LF9HOoSASjTBmEw YJUiyp2AdjqEDQZt5HHtxmlXhvnkiZ3tBrKUC76v5zhVmMRJjXas5Hi0ZTPUs2uKV+FkfmVb+vp uO5VjNBJ76VlKyjlDbdKsWinJjVvcmFP3XXn4PKBC4DDRF8aUpNXHIT8CRi5DMZ+PV9ObzLfXFi +3oMcX/K0fSQvt8lajqbTBG9gkYsAEmpXzA+sP0V2NOFIAVQs9DWF0knEHxdFDmQcgTBGokJAvS xhjQQsrObl5kGhaa3lJGDSvz/okRmoQCG5Pi3gAg/tBDaaPdhcZt3Mbz/QVcSmyRjNYy+w+x6Rl NaPhYWJdo87S6GMdKrt83aFrlQ5qaQ= X-Received: by 2002:a05:600c:c116:b0:48f:e230:2a22 with SMTP id 5b1f17b1804b1-48fe6632e84mr45739435e9.33.1778855150544; Fri, 15 May 2026 07:25:50 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: [RFC PATCH 07/14] target/arm/ptw: Flip sense of get_phys_addr_pmsav8 return value Date: Fri, 15 May 2026 15:25:34 +0100 Message-ID: <20260515142541.571911-8-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260515142541.571911-1-peter.maydell@linaro.org> References: <20260515142541.571911-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1778855245190158500 Content-Type: text/plain; charset="utf-8" Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/ptw.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/arm/ptw.c b/target/arm/ptw.c index 12e700fe07..9e5a7e77c0 100644 --- a/target/arm/ptw.c +++ b/target/arm/ptw.c @@ -3191,7 +3191,7 @@ static bool get_phys_addr_pmsav8(CPUARMState *env, result->f.lg_page_size =3D sattrs.subpage ? 0 : TARGET_PAG= E_BITS; result->f.phys_addr =3D address; result->f.prot =3D 0; - return true; + return false; } } else { /* @@ -3217,12 +3217,12 @@ static bool get_phys_addr_pmsav8(CPUARMState *env, result->f.lg_page_size =3D sattrs.subpage ? 0 : TARGET_PAG= E_BITS; result->f.phys_addr =3D address; result->f.prot =3D 0; - return true; + return false; } } } =20 - ret =3D pmsav8_mpu_lookup(env, address, access_type, ptw->in_prot_chec= k, + ret =3D !pmsav8_mpu_lookup(env, address, access_type, ptw->in_prot_che= ck, mmu_idx, secure, result, fi, NULL); /* * For two-stage PMSA translations, s2prot holds the stage 2 @@ -3755,7 +3755,7 @@ static bool get_phys_addr_nogpc(CPUARMState *env, S1T= ranslate *ptw, =20 if (arm_feature(env, ARM_FEATURE_V8)) { /* PMSAv8 */ - ret =3D get_phys_addr_pmsav8(env, ptw, address, access_type, + ret =3D !get_phys_addr_pmsav8(env, ptw, address, access_type, result, fi); } else if (arm_feature(env, ARM_FEATURE_V7)) { /* PMSAv7 */ --=20 2.43.0 From nobody Sat May 30 18:36:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1778855285; cv=none; d=zohomail.com; s=zohoarc; b=H1voKR4Vcru4t3PO1W7X5ZeDA1zA5pPvHpdi3LiD7W1DwmAl3gBoychgDcgMuDJdeizNCce6o/6Pvk9NFAD6p6NancjX36hsbB2QQpCbmbb/zkF23cHD5Xd2OKsQm1k8E9Fc+gKQKwcNvkbLGEDHa0/hfN0Yd0ddW6AtT7e7ozc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778855285; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=dG4YbbQLzdn6s6+yCfVqlzQwYjjvxFEtdufrlxMzgL4=; b=oL5NAYyp3CCqhDWYMmgr6XTB0XlxiMwNSe0hAgtIrpsVQtTT8YdCaH+nLWx4Rb50a5kwf13J8W97JhRj0y+LxanVn31vcdd1t5RFHO5Da8XdYiqbr8c7h5ElaXgf9vw8Vz1XzAiwnir+R5CIAaGzv3LjkVjqDqzRkBmfuEtifFM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778855285711937.566338453126; Fri, 15 May 2026 07:28:05 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wNtUi-0006R4-2o; Fri, 15 May 2026 10:26:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wNtUD-0005qw-P3 for qemu-devel@nongnu.org; Fri, 15 May 2026 10:25:57 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wNtU9-0000xh-8o for qemu-devel@nongnu.org; Fri, 15 May 2026 10:25:55 -0400 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-44e1860558fso5989662f8f.0 for ; Fri, 15 May 2026 07:25:52 -0700 (PDT) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da15a666fsm13560603f8f.36.2026.05.15.07.25.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 07:25:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778855151; x=1779459951; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=dG4YbbQLzdn6s6+yCfVqlzQwYjjvxFEtdufrlxMzgL4=; b=Uw9g5njR/dDRRoyiPO0XdzmZa+lG1znEV6c8pA/tAgkOTb4j0W827XR92BD3hfZtiN o1/V7RME3zjLTyk630/S7agOfVbO2u+T5YIC6cY+blrziTMhEYMK8kHXr8tbiaydCzrK BEifc4zXV4d+YyXGgWitkvXuTFXbLGPoczVm/IxEZ6tngbj7lxi2lFSUEpTI4ouh/Jx9 8HXZ7llnbQZHKzq/Shm73auzJmt/oElrYq2zYnmy0vDwW2hsxpT921Wv7dZmmypy4VQ5 8BdNijsB12D2kT92D9B9NDpV0SemeOnde/jEqWruwR7+PkDXBPTQwltBn74HbOghzzrr 5qkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778855151; x=1779459951; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=dG4YbbQLzdn6s6+yCfVqlzQwYjjvxFEtdufrlxMzgL4=; b=UeD/qgOQeauwKYSc8JpI73dz2ABhc1peEG6iHU+guV1Ct9R08bEqCZCwq4s+kwM11d kkd40ooVPWGUSzoHq15pN24wR3H8KKLtUHDYPfSvxpfjvavoQkNpqTnJOzxWfSTHzRk9 QnJEUrUSdg0BZtnHdptqUIHh1TDk18xew4wZ6RNTYT4W8MLB3VgDXwNtBpvhE+Eo1sHG XO7CeTiwRX5SxEqhbjkfO4w9MPZl+qELeSo5usq0byXnZdmCIp0n3sfBg+MjgttoQxZI Q4Zz7iqrVMjP9eAKKaVpu7PzWTrvmatzs9dlyzbP6sRcA4OQ1gymNKeMVip266KTmdRb wdmg== X-Forwarded-Encrypted: i=1; AFNElJ/s8EBuzPqCj4gu2offFEjXOXh7+4pglStZgW7lokMj+cIxWTwxUjnHFhyUoWxFEZisTpR9ZW0VSXrk@nongnu.org X-Gm-Message-State: AOJu0YwRBnF2nLEXvjiRVVVRHT82o8QHZQ0ZmeMy9CTHxvFJlrN0m2MX PET9DwXC8nxte6oDtIc3frRvypMgFb0L8tmRf9wWn28DbnfrJ8ICXrqiRvn7mmUrS6s= X-Gm-Gg: Acq92OFdvI1d2o1+NiVELNiVLSO93lAwZqAKNHTa+yt3wP2iuQfXG1WCpbcwY4O1PtO OiYeLTjxUw7Gaw1ZbCV6qi36yYF0KERgA7NvTL+7UWScRATEt6D6DwExXpRqcUmrGk2CpoJ1qRw ZmiBb7PcSTyizi10DS6P5tbgHi0EIk+uygtvvB0QfI1F2UkrAWitUmZmeEHXo4s7DTbREf7zbt3 qrQZRkTuj7LNCjmkJFB/EynLwzEYkolMUEBfrJ4+zQgSalZKy9FijKlLAB/ai3XaoqCupbNT0h3 U0KGIwd+IJLyEFMxb4qjgIwjDjToxnQNGX3Q8JI/hH6z88clTTu1GohKX4jcSBZ0YUkXIprREsO m0U1geWET2+7Han8F3I/L4c9/wDkSbcMiC8Qk1G+aeQXNbGYjftWtOM8XNezl+KqFbMFb6djCtg gK8tpASM37/y7Ah/p+1zSh3uegRw+2z2pcOEHp3p50OhYKV+4EKngY0Nblgw1CFzAHQML5O/uq+ opYpXUPa2EPLPX53nzaCmND7O9mx9w= X-Received: by 2002:a05:6000:1ace:b0:43d:775b:c9bd with SMTP id ffacd0b85a97d-45e5c58906amr5815222f8f.10.1778855151388; Fri, 15 May 2026 07:25:51 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: [RFC PATCH 08/14] target/arm/ptw: Flip sense of pmsav8_mpu_lookup return value Date: Fri, 15 May 2026 15:25:35 +0100 Message-ID: <20260515142541.571911-9-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260515142541.571911-1-peter.maydell@linaro.org> References: <20260515142541.571911-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1778855289821158500 Content-Type: text/plain; charset="utf-8" Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/ptw.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/target/arm/ptw.c b/target/arm/ptw.c index 9e5a7e77c0..c89cccd431 100644 --- a/target/arm/ptw.c +++ b/target/arm/ptw.c @@ -2844,6 +2844,7 @@ bool pmsav8_mpu_lookup(CPUARMState *env, uint32_t add= ress, * If the region hit doesn't cover the entire TARGET_PAGE the address * is within, then we set the result page_size to 1 to force the * memory system to use a subpage. + * Return true on success, false on fault. */ ARMCPU *cpu =3D env_archcpu(env); bool is_user =3D regime_is_user(mmu_idx); @@ -2944,7 +2945,7 @@ bool pmsav8_mpu_lookup(CPUARMState *env, uint32_t add= ress, if (arm_feature(env, ARM_FEATURE_M)) { fi->level =3D 1; } - return true; + return false; } =20 matchregion =3D n; @@ -2958,7 +2959,7 @@ bool pmsav8_mpu_lookup(CPUARMState *env, uint32_t add= ress, } else { fi->type =3D ARMFault_Permission; } - return true; + return false; } =20 if (matchregion =3D=3D -1) { @@ -3020,7 +3021,7 @@ bool pmsav8_mpu_lookup(CPUARMState *env, uint32_t add= ress, if (arm_feature(env, ARM_FEATURE_M)) { fi->level =3D 1; } - return (prot_check & ~result->f.prot) !=3D 0; + return (prot_check & ~result->f.prot) =3D=3D 0; } =20 static bool v8m_is_sau_exempt(CPUARMState *env, @@ -3222,7 +3223,7 @@ static bool get_phys_addr_pmsav8(CPUARMState *env, } } =20 - ret =3D !pmsav8_mpu_lookup(env, address, access_type, ptw->in_prot_che= ck, + ret =3D pmsav8_mpu_lookup(env, address, access_type, ptw->in_prot_chec= k, mmu_idx, secure, result, fi, NULL); /* * For two-stage PMSA translations, s2prot holds the stage 2 --=20 2.43.0 From nobody Sat May 30 18:36:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1778855197; cv=none; d=zohomail.com; s=zohoarc; b=Kuq8QUSdUcPTtM/9LES/Wfc1FH6zBZDMbXezKT5XkxL9uRWT4/kRgSIJWZrfx3Iakzixa5Q4b2zSSAQZjiE6NVrko55hGyVQiCjvSmIksi5hDmN0D8x+nQwSY9nBQBM3ZNMhUIjtQCRzhsZ/PASeL1h6iQK4epcNgMRod3U/fH8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778855197; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=kPMoTfRy0PxJ4NavSRnM77Oz2TOV7srminG3TLvQHn4=; b=C2KXofpl8NfIo6lY2DuRqaJNDB/bPvIke4Q3dabkt7pWhwBbYlJLcUn5AkxBt/3W5Ls/uj7iFBXuvpZi9N3hYUZ3wgOBYDW/HivvxhPzy2rFg/9GK0/P+JYJ6Mrf4Q8+CXjDSUmZsjPBsOoIv87GFUGXXExShs8AoErXUdHnLz4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778855197596141.57798159071285; Fri, 15 May 2026 07:26:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wNtUm-0006iJ-8i; Fri, 15 May 2026 10:26:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wNtUH-0005tf-JT for qemu-devel@nongnu.org; Fri, 15 May 2026 10:26:02 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wNtU9-0000yC-RJ for qemu-devel@nongnu.org; Fri, 15 May 2026 10:25:57 -0400 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-44c350a5b87so5686372f8f.3 for ; Fri, 15 May 2026 07:25:53 -0700 (PDT) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da15a666fsm13560603f8f.36.2026.05.15.07.25.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 07:25:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778855152; x=1779459952; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=kPMoTfRy0PxJ4NavSRnM77Oz2TOV7srminG3TLvQHn4=; b=iIn3d3sylMCrFYNPPCLAxb06eemJORvwCmuxfOeSxTQdPHdOIwvoYMMFSSYoGVxd1/ nq4IecL/pQEmpgIKymtby1DynfICfcW/o83SFbwKHNM+2zDWUViV8NHs6vwo2fs09EWx QlAERlY4nzfRzGfK81JjTmYafWc2q+5tEuqkq5Og/DrMvGwdjdExth1jU+uoO3xO9GcB yN5xkZ+pDWZZqbvnIeeavC6ll7TldqfY8V7WEdhJ83MuZnH0b35R19qFUakey5oZLJOX I+v1p7ucA0sB45PgL76XlvhOeWBC693tUc8kXMN4hLTm/pK2cue8fqLfZbMWKi9MYC00 riHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778855152; x=1779459952; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=kPMoTfRy0PxJ4NavSRnM77Oz2TOV7srminG3TLvQHn4=; b=HfE+EtjdsgmV9N6IISlHjORwwts1/YWd3wqPfjOgwnlPZUQJRg7nE5yOibQNsNnP6e 62B+GEdRCn0YxUb5GUkmU3CBcmEIMfX4J0t11WdYjPVZPJkbc1q30AKJ3cGUl92bhoo9 sB1i0LHFha5F74mNytQu0RVXr8Vean+wWdc55cy1+MSfa8HgNTTzVPd/MKPBHtk92xf5 QVxYwNhBbqSgon6Yo/y7LgyneowCQyUAaKR02BFPZ9N1JpDpajrkvKlFOOkXrZ/zTX8i nCfsJXsWjeQLHwr2f88XUKsIIxCwFS+QbbvxQNMdCBqrjlRtnUvZM97LYwP8oRHwTMkH ur/Q== X-Forwarded-Encrypted: i=1; AFNElJ8BevdnI0m4fzJaFRrwfgYj7nlLg+HAgQFo6EfwsvFIjRJ+2p6eNuhJ4uHdl5MLCuVbfq6FQBfNJSwg@nongnu.org X-Gm-Message-State: AOJu0YzDtpZJjSyf7EoASO8CZCfEiC0ZJAC7VyjcDoEPK3NY7j4fMZVz sP2lykzic29UNdkpQ1/So/+jPoEiPZ5LA3+wohYNXpYbec9wMvs4y3YnRiTrrUW+fGo= X-Gm-Gg: Acq92OHL/wU4YiKuxP12atGuyfV36rrfz0ViIEvzeFQLznlFFiZlxZKPgJ7F9AXEAHH nRSsDGQ4b93srYRd8v56IqeNTthaZ2kYAqCc4fMpoObAqymRQp6rD2ARaMnW1fGY8+skwFyDpUn L2yiCw4+91RVZbnILeoTllsScYRZNUWVypZbvNSQcDfB0QSHSbnd/WHsJicKdsaFNKDu/anffQ0 9T8fwDUICmgoYrvcxyf/8s0jmWio7QnMzlp/gHqUlrm/4120jZnRWzFpEPX1d2wUgWAinVL0Xjo eh7wg/ALotOgsSXDC2M30J5I+nijsmGBwUJi+ptFhCKJ+q+SKaCLBUT5WPNMfx23zf3mXFsLWmM 0Cn4ntm6HbtomglpLn+2slpjahc/RFNg5aBQWneM9R1vv7wWJmLnukefsZUjexZ58rDR6Zq40nt ISc/3gPKEkUjEPEzWkzqk4RnvQWv6iLOmb7robs6/OShQIziLB4S9Lj30xDIf7D//Ry8LQjp0HJ /GuLBIwWYwmUzhc1PFJ5kxPJavHjmnpjNmcmjUsCg== X-Received: by 2002:a05:6000:290f:b0:452:273:5cd6 with SMTP id ffacd0b85a97d-45e5c5a5e3bmr5744950f8f.1.1778855152231; Fri, 15 May 2026 07:25:52 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: [RFC PATCH 09/14] target/arm/ptw: Flip sense of get_phys_addr_twostage return value Date: Fri, 15 May 2026 15:25:36 +0100 Message-ID: <20260515142541.571911-10-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260515142541.571911-1-peter.maydell@linaro.org> References: <20260515142541.571911-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1778855198770158500 Content-Type: text/plain; charset="utf-8" Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/ptw.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/arm/ptw.c b/target/arm/ptw.c index c89cccd431..545138464d 100644 --- a/target/arm/ptw.c +++ b/target/arm/ptw.c @@ -3571,7 +3571,7 @@ static bool get_phys_addr_twostage(CPUARMState *env, = S1Translate *ptw, =20 /* If S1 fails, return early. */ if (ret) { - return ret; + return !ret; } =20 ipa =3D result->f.phys_addr; @@ -3602,7 +3602,7 @@ static bool get_phys_addr_twostage(CPUARMState *env, = S1Translate *ptw, =20 /* If S2 fails, return early. */ if (ret) { - return ret; + return !ret; } =20 /* @@ -3656,7 +3656,7 @@ static bool get_phys_addr_twostage(CPUARMState *env, = S1Translate *ptw, result->f.attrs.space =3D arm_secure_to_space(result->f.attrs.secu= re); } =20 - return false; + return true; } =20 static bool get_phys_addr_nogpc(CPUARMState *env, S1Translate *ptw, @@ -3724,7 +3724,7 @@ static bool get_phys_addr_nogpc(CPUARMState *env, S1T= ranslate *ptw, ptw->in_mmu_idx =3D mmu_idx =3D s1_mmu_idx; if (arm_feature(env, ARM_FEATURE_EL2) && !regime_translation_disabled(env, ARMMMUIdx_Stage2, ptw->in_sp= ace)) { - return get_phys_addr_twostage(env, ptw, address, access_type, + return !get_phys_addr_twostage(env, ptw, address, access_type, memop, result, fi); } /* fall through */ --=20 2.43.0 From nobody Sat May 30 18:36:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1778855215; cv=none; d=zohomail.com; s=zohoarc; b=eV5olEnEHAD3qdD0N31/33AZty6aKuyZBCWmqPWLOyad7Z8sjEh9HY5qtJ3k8duxV1jqJ1wQJtczAtZlvmWcdR71mYMXG76RC3PHyUpn+Z9RZ+SAlcr4VNDEomN5zeRipMs+cGRkckZrIxUzE8UgMsoGv2QT2IXdyiMAslxc7VU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778855215; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=TydCV87eriJQbdUNFILWluMIKkiaW+xceKfCgA5Uw1s=; b=UNTJmMJ5U5/oSYnNUGaSvtIvI0FLks0gFgqDaeKgonqCzAul1cgRVICANaOye6lJYZMlTSEyHVybpLYs7fnnOJAFl8lFp/wEMyX69zg29pw2k9M6AAfCbL4s1v17JYePlQXQ/ads+A+Sz5j9UwHs2AhCw+PkN6qtQL54ExjUPpc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778855215561293.34941610575174; Fri, 15 May 2026 07:26:55 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wNtUh-0006OR-Og; Fri, 15 May 2026 10:26:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wNtUH-0005tZ-HW for qemu-devel@nongnu.org; Fri, 15 May 2026 10:26:02 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wNtUA-0000yu-KS for qemu-devel@nongnu.org; Fri, 15 May 2026 10:25:58 -0400 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-453903ee4adso7967096f8f.3 for ; Fri, 15 May 2026 07:25:54 -0700 (PDT) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da15a666fsm13560603f8f.36.2026.05.15.07.25.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 07:25:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778855153; x=1779459953; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=TydCV87eriJQbdUNFILWluMIKkiaW+xceKfCgA5Uw1s=; b=MDXKpYexTLeyhmI9cy7nfhH0uYJ0g5p7h1hw9DL7Sz+DO1kBmu1i5VaQ4P61kfS7nm muKBKEBzokavr8e7M2GqDLnsW50Nj9V70qYGSLUzRvf8QcbUceeb4u4MILmMG9yRF+9b biQFXjyFeG03c9E4kP00kT/uAVRKj0A3HKjcsRdnzRXtljRpaAAM5GGIbeCSqHptB9Zk JXYeTlDErPzBlNu0m+4JWEIT/3xY+rR4Z/i223zT9NtyU2Tq0mETEYfMdwyXTaLflbSM LU9UPTpqKxQVilITtp6isgNquGT3EESuaMT7ZprmxpnJDxQesUQdIKANcydHDJjuxWEV nrMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778855153; x=1779459953; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=TydCV87eriJQbdUNFILWluMIKkiaW+xceKfCgA5Uw1s=; b=K5MSuVqssIZ64kw1Px3wH056jyrvhOi7fAN6tm0B4B2hZDVbB90w1dxU7Umo+HeXrk cjeA/WtvIopCxUUQJOwFxNbfBK3C57HiZLQC1XcX05+l6HdYXDK/VP1rYLXaTIRUI37+ X3VLv9c3UQzQAOYuS/Jut8qhrda/DstFbyd57qgVyfkI8GETgXsvg4c98Eneh8LPic3R iSfOCrJmQUdcWctHppsUXSlbEtho8UFEEZzZqREBY9fJMOS7lET2YY5/+MNetHiM245R +911lld9xuNneBNYe/vCdNt1mI4+lHrwLnV8cBELfn+EUR0Jzl8O3iysnY1rX/06KF8f gzBg== X-Forwarded-Encrypted: i=1; AFNElJ8fqcZj2U1e+upzvr3HoD7DO0Lx5kPxVPJcYuTc/qzNHzubxm01t62mEstl1YugGNbw7UABKEM2TKy+@nongnu.org X-Gm-Message-State: AOJu0YwDMzXzOKOc7tPz1yL39C3b4NtNuxd6nT8q2zqsCHV/yQG1jLE1 YYyERXBg+YKgOuNnj0CEDoet8XSkJsyR9xSEIPPbCcGQWZI0PfHzfRFo3X10+5dtliXXdyrCnNL 4PXwK X-Gm-Gg: Acq92OFOfSrgb9EHB9y+4xK0FhvAkD+kBidRGn/UOMRGccFCCN2WEci5idZaE6mdUTY XIBF0jNXH7l+3ZVFjbHQAcQzf2rAOZvdz5WQGikPMWqZI7uMWgdb4zyZRFYh2Jej+xDoSrSfGnh Ebj6yxUH9cJng6HqRQiladlz+WUtF+yeeVFAcyguqQsl5IGc8o2P9Rfw+afbh3cog5c2uY7Yf5x Mpf9v8berd6hiob/QBy6n9nprbJ3t1cHtqQYvjF5LDxZyNB2/u/+aDStyuiNHyy4zvPu0jAXmOA G5NSZYf4/+WWFOgSwo+mg5tyS6qMV4zb9FVQXiwmWNXHX95t9asnwWrQP8TkWMMZkvk00Xs5gtV qarCvS2XM768mjYTCSa5Ckw5QVEbbph/rpDyHpefBvoXsQP6sMaw/vFdZ56cGFfk8ng7+vNZ2jh 2FrJf7TE3+ByOQTELF58HGscreunRFaDXwh5rSYhk/0zX9uPuYaqG2eCB9Y/AaDGv0eoUJMeN1G pOcTnyUoEIs/Mazrb5wd4dvIVQa7h8= X-Received: by 2002:a05:6000:2485:b0:44f:da08:18f2 with SMTP id ffacd0b85a97d-45e5c3673d9mr5972601f8f.12.1778855153093; Fri, 15 May 2026 07:25:53 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: [RFC PATCH 10/14] target/arm/ptw: Flip sense of get_phys_addr_nogpc return value Date: Fri, 15 May 2026 15:25:37 +0100 Message-ID: <20260515142541.571911-11-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260515142541.571911-1-peter.maydell@linaro.org> References: <20260515142541.571911-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1778855216881158500 Content-Type: text/plain; charset="utf-8" Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/ptw.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/target/arm/ptw.c b/target/arm/ptw.c index 545138464d..9ecb6238a7 100644 --- a/target/arm/ptw.c +++ b/target/arm/ptw.c @@ -3570,8 +3570,8 @@ static bool get_phys_addr_twostage(CPUARMState *env, = S1Translate *ptw, memop, result, fi); =20 /* If S1 fails, return early. */ - if (ret) { - return !ret; + if (!ret) { + return ret; } =20 ipa =3D result->f.phys_addr; @@ -3601,8 +3601,8 @@ static bool get_phys_addr_twostage(CPUARMState *env, = S1Translate *ptw, result->f.prot =3D s1_prot & result->s2prot; =20 /* If S2 fails, return early. */ - if (ret) { - return !ret; + if (!ret) { + return ret; } =20 /* @@ -3683,7 +3683,7 @@ static bool get_phys_addr_nogpc(CPUARMState *env, S1T= ranslate *ptw, case ARMMMUIdx_Phys_Root: case ARMMMUIdx_Phys_Realm: /* Checking Phys early avoids special casing later vs regime_el. */ - return !get_phys_addr_disabled(env, ptw, address, access_type, + return get_phys_addr_disabled(env, ptw, address, access_type, result, fi); =20 case ARMMMUIdx_Stage1_E0: @@ -3724,7 +3724,7 @@ static bool get_phys_addr_nogpc(CPUARMState *env, S1T= ranslate *ptw, ptw->in_mmu_idx =3D mmu_idx =3D s1_mmu_idx; if (arm_feature(env, ARM_FEATURE_EL2) && !regime_translation_disabled(env, ARMMMUIdx_Stage2, ptw->in_sp= ace)) { - return !get_phys_addr_twostage(env, ptw, address, access_type, + return get_phys_addr_twostage(env, ptw, address, access_type, memop, result, fi); } /* fall through */ @@ -3756,15 +3756,15 @@ static bool get_phys_addr_nogpc(CPUARMState *env, S= 1Translate *ptw, =20 if (arm_feature(env, ARM_FEATURE_V8)) { /* PMSAv8 */ - ret =3D !get_phys_addr_pmsav8(env, ptw, address, access_type, + ret =3D get_phys_addr_pmsav8(env, ptw, address, access_type, result, fi); } else if (arm_feature(env, ARM_FEATURE_V7)) { /* PMSAv7 */ - ret =3D !get_phys_addr_pmsav7(env, ptw, address, access_type, + ret =3D get_phys_addr_pmsav7(env, ptw, address, access_type, result, fi); } else { /* Pre-v7 MPU */ - ret =3D !get_phys_addr_pmsav5(env, ptw, address, access_type, + ret =3D get_phys_addr_pmsav5(env, ptw, address, access_type, result, fi); } qemu_log_mask(CPU_LOG_MMU, "PMSA MPU lookup for %s at 0x%08" PRIx32 @@ -3772,7 +3772,7 @@ static bool get_phys_addr_nogpc(CPUARMState *env, S1T= ranslate *ptw, access_type =3D=3D MMU_DATA_LOAD ? "reading" : (access_type =3D=3D MMU_DATA_STORE ? "writing" : "ex= ecute"), (uint32_t)address, mmu_idx, - ret ? "Miss" : "Hit", + ret ? "Hit" : "Miss", result->f.prot & PAGE_READ ? 'r' : '-', result->f.prot & PAGE_WRITE ? 'w' : '-', result->f.prot & PAGE_EXEC ? 'x' : '-'); @@ -3783,18 +3783,18 @@ static bool get_phys_addr_nogpc(CPUARMState *env, S= 1Translate *ptw, /* Definitely a real MMU, not an MPU */ =20 if (regime_translation_disabled(env, mmu_idx, ptw->in_space)) { - return !get_phys_addr_disabled(env, ptw, address, access_type, + return get_phys_addr_disabled(env, ptw, address, access_type, result, fi); } =20 if (regime_using_lpae_format(env, mmu_idx)) { - return !get_phys_addr_lpae(env, ptw, address, access_type, + return get_phys_addr_lpae(env, ptw, address, access_type, memop, result, fi); } else if (arm_feature(env, ARM_FEATURE_V7) || regime_sctlr(env, mmu_idx) & SCTLR_XP) { - return !get_phys_addr_v6(env, ptw, address, access_type, result, f= i); + return get_phys_addr_v6(env, ptw, address, access_type, result, fi= ); } else { - return !get_phys_addr_v5(env, ptw, address, access_type, result, f= i); + return get_phys_addr_v5(env, ptw, address, access_type, result, fi= ); } } =20 @@ -3804,7 +3804,7 @@ static bool get_phys_addr_gpc(CPUARMState *env, S1Tra= nslate *ptw, GetPhysAddrResult *result, ARMMMUFaultInfo *fi) { - if (get_phys_addr_nogpc(env, ptw, address, access_type, + if (!get_phys_addr_nogpc(env, ptw, address, access_type, memop, result, fi)) { return true; } @@ -3851,7 +3851,7 @@ bool get_phys_addr_for_at(CPUARMState *env, vaddr add= ress, * check is handled or bypassed by .in_prot_check) and "memop =3D MO_8" * bypasses any alignment check. */ - return get_phys_addr_nogpc(env, &ptw, address, + return !get_phys_addr_nogpc(env, &ptw, address, MMU_DATA_LOAD, MO_8, result, fi); } =20 --=20 2.43.0 From nobody Sat May 30 18:36:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1778855337; cv=none; d=zohomail.com; s=zohoarc; b=HjlG0z6Xe4fdTQxy1ooGnzfrG8NgMXulqSr10ZceDKyIoz5cSP1nUXxr/ylWFSqHEaxoPlLNINWFK4T6ZK5xD/7NHfaXFC6ktdvapuUQqlBZ5tOgs1yAoEe2ruGttfqt8u6yKaDTsPUntygPSjSKlYLdcroX9pqQrs/lUeZJVLg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778855337; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=lnHCoKfIHOU4NHMQe3Kj9Fosoqb2a9TyPNEWvgX/PmE=; b=hmZ4iizZJG8uRJ11v88jAN9cmabkkzcSK74ZOIbrX+aueboVtcO/xrS+KOzE3Ow8WWRBDu91NRBjByLYBdKsUHL2IEkDEg3Af4YgPcXxiNNUEqjrBIqtMrJp/+8qK/VO1JmjfLMHq6EBveyr6E6cuIskWDF//dUabQaCmlHwvTw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17788553372353.9329159208103874; Fri, 15 May 2026 07:28:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wNtUi-0006Wr-U4; Fri, 15 May 2026 10:26:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wNtUH-0005tY-Ha for qemu-devel@nongnu.org; Fri, 15 May 2026 10:26:02 -0400 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wNtUB-0000zq-RU for qemu-devel@nongnu.org; Fri, 15 May 2026 10:25:59 -0400 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-441209fb77eso611552f8f.1 for ; Fri, 15 May 2026 07:25:55 -0700 (PDT) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da15a666fsm13560603f8f.36.2026.05.15.07.25.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 07:25:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778855154; x=1779459954; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=lnHCoKfIHOU4NHMQe3Kj9Fosoqb2a9TyPNEWvgX/PmE=; b=iz/65VmB3ajRJmG1MFGIj3mGjENRTiG6B/9SlR458Wm6k8cLaJds/xtTDmbwuvCq6K AiTyHJCl0bhT/koNdTrIYbHhxFyfGJNtfzBFLGMk6JpkILZ4FgNqAqleH1hRZr8U0jkW rrX8Ahge8AkbcjAOT+pynakOacm3giROnN0xYeToqglQI6sXvOGYstuSlCvShqsDNRXf FBx4/Gmn/4eCW9TRzQ0pM/8t3hBXcXdYlqj3Ce5edxqyp8kWLDFJwyB0NBgw3goS3yJ7 NO9OI+72uECGFpItTgg292aX0v1irDUT2PGZ1kMpfbUlPQYXc8cXs1d9kZfILKD7dkhP hLaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778855154; x=1779459954; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=lnHCoKfIHOU4NHMQe3Kj9Fosoqb2a9TyPNEWvgX/PmE=; b=QsOzMa/i/SHcbDZ1GioxcheK+Pg9VCj3Ca9j+QmvjNdhWiA/x/MkGDzObj90lbJaXf PyqAO/bJ8qgB48557u36ipwVhpfEnmQCRjztNVoLpb7sX+Gf7P77fGbm4tFh/CZ9Oi2M Y5lk5zlrSqTsQBGrixXN0xn5VbBd0LlVD56IhiP4b6iNaTfFRdskegy9b0rM5cGdfJ2F UFaVCqXg1LQJgCxKOKthSOIH72iTD344HQPbkSZt66r3sQbfDhChMNQfSP8lpgzAwH5f TZYj7izhNwKXZAg2dlLeHEscNO3nz0+Xht7Sk/6VNyOhWWZaPvpeYDhgXF9YBGB1DKoc N3uQ== X-Forwarded-Encrypted: i=1; AFNElJ/BZvk42w1gAUF6fLUerGXY2IZPjfzG2FCvrA0tULPZFvXK9TVDB0aQTqWI13rJHyLaTKPVsC4cTArv@nongnu.org X-Gm-Message-State: AOJu0Ywd/tnsuYwVp8YtMgyG7JvU2+C9OPv93lIgPF5ZEs07JNIblLs0 AY/mHxnQXv63It7SgcSrAFc6pY7RjO5awkH3CQv51h0co6fEsa41vRGmhfDYEUXyk9TZwx4BCJj 2WiIZ X-Gm-Gg: Acq92OEXI5AFU+L4dv/HtiDz4d5Vj+A60AVtGQRLOcaOIgqAfoWCIuWOei+eddxJjp3 66P0eXjzLt6cPWnxVlgp7awFzx3La2Fv+KTNWHM6MftCb93PH5YsR9L2wytJvOtRzC1JIEzoS1l LE2+ko4dFHPRVkeborYEjnLzMeb3Ior2LYzguXhHYQjMQFBV42ATe9aU31Xhetmb0cptsv6wlmM saaKbHARL3oHtrnKl/q1gN2BwDMbHi4m0lw8EcI1j+vsZFpgEvLzH1QRIQlT7qMwP+se1uiWdRO j65e7/sXMD5OGZTBVd+6+uQ0zuGUu3AMITbpIa4LNRVqpwd7O1vFiYojiEEgqkjop5tbrr3NC2u y3izABMytl+UtcgTadTRoU40ULdnpFZP6EsIbr0gs/Ty52a06CYXJsy7ggQj8exS1RZSHVRe2eK 92qOY3rBBEZgCtGeX2ry6xvsJydRZjwrDY4yEjBehMACYcdeDDU+jvJ/6s0d0fSeBq3Hy0wQ7dk GESk+3Y/gj38VAABbrvWnxXZTN8wPY= X-Received: by 2002:a05:6000:4b07:b0:44f:69f4:39b5 with SMTP id ffacd0b85a97d-45d9502e84dmr13423623f8f.29.1778855153946; Fri, 15 May 2026 07:25:53 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: [RFC PATCH 11/14] target/arm/ptw: Flip sense of get_phys_addr_gpc return value Date: Fri, 15 May 2026 15:25:38 +0100 Message-ID: <20260515142541.571911-12-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260515142541.571911-1-peter.maydell@linaro.org> References: <20260515142541.571911-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1778855338513158500 Content-Type: text/plain; charset="utf-8" Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/ptw.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/target/arm/ptw.c b/target/arm/ptw.c index 9ecb6238a7..cb41146b9c 100644 --- a/target/arm/ptw.c +++ b/target/arm/ptw.c @@ -667,7 +667,7 @@ static bool S1_ptw_translate(CPUARMState *env, S1Transl= ate *ptw, }; GetPhysAddrResult s2 =3D { }; =20 - if (get_phys_addr_gpc(env, &s2ptw, addr, MMU_DATA_LOAD, 0, &s2, fi= )) { + if (!get_phys_addr_gpc(env, &s2ptw, addr, MMU_DATA_LOAD, 0, &s2, f= i)) { goto fail; } =20 @@ -3806,7 +3806,7 @@ static bool get_phys_addr_gpc(CPUARMState *env, S1Tra= nslate *ptw, { if (!get_phys_addr_nogpc(env, ptw, address, access_type, memop, result, fi)) { - return true; + return false; } =20 if (FIELD_EX64(env->cp15.gpccr_el3, GPCCR, GPC)) { @@ -3826,11 +3826,11 @@ static bool get_phys_addr_gpc(CPUARMState *env, S1T= ranslate *ptw, result->f.attrs.space, ptw->in_s= pace, fi)) { fi->type =3D ARMFault_GPCFOnOutput; - return true; + return false; } } =20 - return false; + return true; } =20 bool get_phys_addr_for_at(CPUARMState *env, vaddr address, @@ -3939,7 +3939,7 @@ bool get_phys_addr(CPUARMState *env, vaddr address, .in_prot_check =3D 1 << access_type, }; =20 - return get_phys_addr_gpc(env, &ptw, address, access_type, + return !get_phys_addr_gpc(env, &ptw, address, access_type, memop, result, fi); } =20 @@ -3956,15 +3956,15 @@ static bool arm_cpu_get_phys_addr(CPUARMState *env,= vaddr addr, }; GetPhysAddrResult res =3D {}; ARMMMUFaultInfo fi =3D {}; - bool fault =3D get_phys_addr_gpc(env, &ptw, addr, MMU_DATA_LOAD, 0, &r= es, &fi); + bool ok =3D get_phys_addr_gpc(env, &ptw, addr, MMU_DATA_LOAD, 0, &res,= &fi); =20 - if (!fault) { + if (ok) { /* translation succeeded */ result->physaddr =3D res.f.phys_addr; result->attrs =3D res.f.attrs; result->lg_page_size =3D res.f.lg_page_size; } - return fault; + return !ok; } =20 bool arm_cpu_translate_for_debug(CPUState *cs, vaddr addr, --=20 2.43.0 From nobody Sat May 30 18:36:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1778855213; cv=none; d=zohomail.com; s=zohoarc; b=jSPZxwaq/RVNP/Fssi/i2j7/Xjz926+IjAPgQiJbN/B7Hh1lqfErd2ZHHq69tMwpeXvEgKY1Vld1ViRbOyG/OnMv/yV+yXxDnKGeo/BWjUdBIqntM0A89Gs7FlHJjpmhhbIxSJ84+ji4H/iE3ZH/w4NeOOppocLbFdPq6D5sEAc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778855213; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=Z/7MUfTgV47m6A8fbfhuwF/fDPkNJxzNCWUG8nRDLD0=; b=M5JOqI8bG2SVQryx96O78royiSucXPszECgOQoKl75YlytFv3yKiz1qWzYxIKDr7NdiVkvJV7pbVtlyWIjU4cPPh3BzYBpCdcsIZ66wgMXnSJXWusMdhqLrYcb8pNZzA+2/uH6B9tJEnaeCXDNxNXlfDJgsWO8q5y/HsRr6aU3E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778855213840161.7982869307309; Fri, 15 May 2026 07:26:53 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wNtUl-0006eW-8d; Fri, 15 May 2026 10:26:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wNtUH-0005td-Jm for qemu-devel@nongnu.org; Fri, 15 May 2026 10:26:02 -0400 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wNtUD-00010f-28 for qemu-devel@nongnu.org; Fri, 15 May 2026 10:26:00 -0400 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-452169ae568so7146844f8f.3 for ; Fri, 15 May 2026 07:25:56 -0700 (PDT) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da15a666fsm13560603f8f.36.2026.05.15.07.25.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 07:25:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778855155; x=1779459955; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Z/7MUfTgV47m6A8fbfhuwF/fDPkNJxzNCWUG8nRDLD0=; b=EFk5TpolgdHdse0tcHqV5ABKapc7CvdPixXHcvWlQk9+dogcRplMkaBdorEJ/3jqip SHXByt5I8IRyoWHELSm3i2jrs6sJp8s1VNj0169ycxU5CVf8ZtUlTtOoiBAlVdOtOmD9 Hn++PdRFz28yGrrFpogtVdmYMu/237isC/gIqD2j4sK8RZvKbveA+FRoOayq+K2Q7MDI z+O6Cs2qDdVxHtSSTu0me4DUJ4tDV5MEvq56L7QRuCDfOj7bavJaTB+E0hCX1c5ZMCxp oZ+Vu6aluErP+cjowgWOtAEB/p6cJ1odUGUaXoGHX31cEWQYZYtUpgCJob0nGXuZaeTt HeGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778855155; x=1779459955; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Z/7MUfTgV47m6A8fbfhuwF/fDPkNJxzNCWUG8nRDLD0=; b=kqCfDWiPxRophLNn0tA3eWGG2QoMj4dNIV5DTbdFDwu/PtHiF7Y68tGDT9M+Jj6RJ0 MovsBfGLQpCw33+GxrbYbxCHuO+S+wVkfhS4ia45/6h4g3q1TZfwn6Pz9RSgN3YiHn3v YclSA/q9Mn9N6i+VP7bjUaS1eqF3NjwVidZr4jawBMAIBHdVFIceiWi/lZlW2g848iZ2 JOlFODKNMpvDSi3qxphFzUZ6Plu5lbTS3g/fjBDau7EtcrcpLadjKduVz+1ECFM0ymUK 8Hvf6yS+nCTE1vtVc886cWLYxxb35YzGpeYeEXp/2wuDA1Bhp+MJ193emUaiteJncUPY 1Pqg== X-Forwarded-Encrypted: i=1; AFNElJ9uOl6FOlLzLsrNBtEoAJ7r3FsO6BzkR0Bb9WIGh5ZdqKUJ9z8tWSNS6pqLfK0mrpx/Fg9HSYSfFOkI@nongnu.org X-Gm-Message-State: AOJu0YxGWtbZTtQMmSCEs4s7xlwWAsgn8QokjOYObkDWw/iWWHfSaW2j jqnFZKLZek5d+yWc8E0xTUxXXZscKUTf7pe0K576XdjI3KVfZHrD7TjrhStXG6EMAcQ= X-Gm-Gg: Acq92OE99fmKVEZSkpeQrAuR0xdXq2djMbmBiQlD5xi3fNO/0wi12uKPnUgLz6wbClp TkJ/5BFat7AumQwpdnIdYiVcJpkDEpkPTQ3DS9I16V+2oT12S6cKyGKwJl+Dg5PGXy0nnP0ZwbO w94vvthg5oE+REBxIcYUwfaTNYohTXdhMXEkQcP9JtqWst/KM2volfLp2bxd7gARlt74I1CQ73p ovBsyZKPD7prMZoQ1qIyl9AVMRSiW15Bo+7S9NMhx3WVmc1LPXAe7toR38cL1A/KY3zW9f7UwJs CmbBk9QsaoPvmh75bnGC5OOX8mIw4k36SDMg680bVDRCM8TSK4y6mc3M0XdJ7K1YZ6cdzCiouNb w2uvdxWRfJ3YXqflUbBA822chY3Kjk9/qBG70Dhy/ECuIWa4tfUhIkQlPqZ4k/zYkD/tcVlUE4V XDiN6b7eQKbKYGgIEh64C06hOTc75D3Qcy5cw8kiUTMVGoProZV9RVRI5TKmIzXWOmf7adsr/UB TA/L7eah/8w5QeCPNl/qsa6smGlVso= X-Received: by 2002:a5d:5d01:0:b0:452:a293:4d91 with SMTP id ffacd0b85a97d-45e5c34b279mr6227012f8f.0.1778855154848; Fri, 15 May 2026 07:25:54 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: [RFC PATCH 12/14] target/arm/ptw: Flip sense of arm_cpu_get_phys_addr return value Date: Fri, 15 May 2026 15:25:39 +0100 Message-ID: <20260515142541.571911-13-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260515142541.571911-1-peter.maydell@linaro.org> References: <20260515142541.571911-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1778855214776158500 Content-Type: text/plain; charset="utf-8" Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/ptw.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/target/arm/ptw.c b/target/arm/ptw.c index cb41146b9c..ea036a541c 100644 --- a/target/arm/ptw.c +++ b/target/arm/ptw.c @@ -3964,7 +3964,7 @@ static bool arm_cpu_get_phys_addr(CPUARMState *env, v= addr addr, result->attrs =3D res.f.attrs; result->lg_page_size =3D res.f.lg_page_size; } - return !ok; + return ok; } =20 bool arm_cpu_translate_for_debug(CPUState *cs, vaddr addr, @@ -3974,12 +3974,7 @@ bool arm_cpu_translate_for_debug(CPUState *cs, vaddr= addr, CPUARMState *env =3D &cpu->env; ARMMMUIdx mmu_idx =3D arm_mmu_idx(env); =20 - /* - * Note that this function returns true on translation success, - * but arm_cpu_get_phys_addr() and all the other get_phys_addr - * style functions in this file return true on failure. - */ - if (!arm_cpu_get_phys_addr(env, addr, result, mmu_idx)) { + if (arm_cpu_get_phys_addr(env, addr, result, mmu_idx)) { return true; } =20 @@ -3991,10 +3986,10 @@ bool arm_cpu_translate_for_debug(CPUState *cs, vadd= r addr, switch (mmu_idx) { case ARMMMUIdx_E10_1: case ARMMMUIdx_E10_1_PAN: - return !arm_cpu_get_phys_addr(env, addr, result, ARMMMUIdx_E10_0); + return arm_cpu_get_phys_addr(env, addr, result, ARMMMUIdx_E10_0); case ARMMMUIdx_E20_2: case ARMMMUIdx_E20_2_PAN: - return !arm_cpu_get_phys_addr(env, addr, result, ARMMMUIdx_E20_0); + return arm_cpu_get_phys_addr(env, addr, result, ARMMMUIdx_E20_0); default: /* translation failed */ return false; --=20 2.43.0 From nobody Sat May 30 18:36:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1778855233; cv=none; d=zohomail.com; s=zohoarc; b=MhDYjzK/gChe0aNDpl19qPbGp5aVhQLT0kF4hnTEL+Yt2ZzqmBJiEAg9cc4jHIezUWQW26CrkIiZOqHE+KcY2ozBItgEX6MjQgIFARy67K8EypYzTenb58pi1/2hrnuiG54EiTWZsQRxke8wCjmswovuBuhIz3cprersYxDmaZ0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778855233; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=sbEPi44KKLT30E1Ya7Xgq7lsZNIAggwXePt17au81Fc=; b=I1lZdhUZz+XZMVEjRgOGv6mUnKv+A2zgl0t+ys3XLRzSwgCk4wRD8pNMAgctlQrVSVWZhdMMJZrxXyz0AaNOCs/CkvkfuHEaoG99dxDbeGrqsCyOfzCif7TZpKNPYCoEqb7RDckT7ducwsCJwuuWX/GsQFjWocz/uPkTIoUMo9I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778855233754895.4950828064179; Fri, 15 May 2026 07:27:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wNtUm-0006iS-9P; Fri, 15 May 2026 10:26:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wNtUL-0005xQ-Cn for qemu-devel@nongnu.org; Fri, 15 May 2026 10:26:05 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wNtUG-00010y-W3 for qemu-devel@nongnu.org; Fri, 15 May 2026 10:26:04 -0400 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-44e1ebb3122so4969004f8f.2 for ; Fri, 15 May 2026 07:25:56 -0700 (PDT) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da15a666fsm13560603f8f.36.2026.05.15.07.25.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 07:25:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778855156; x=1779459956; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=sbEPi44KKLT30E1Ya7Xgq7lsZNIAggwXePt17au81Fc=; b=Y4rKCy4yMlvd3j9Pzz9hP55AuKtCx20xPo4/D3HUSetEqdRBMZDF7VudGwVUq41hQs HtKYNV3uIi6QRwATjm05FFYLxd7u3pQE0ljTM8H/Z+iG1X3rLxlkyeqHhsTiyMnYdsjR 2lNXYXfjRg8DYkFQLkqvFvvGg+ZcnO051sDjz54pv0rI6rUGkzrWoTiZbMNwr9lyxMmK NeDIFVDynYMAhvg1ztovqhhpTLkppTxwxYdK39eTmMk7Z0bF4X0/+jgIuJXvPoGX/sfl 4szHzC4IchEvtkdSx8bSZvAzHdCe2sqth23do0q1LT+K49sLJQaVdNuhemoSFf+XLOOU sIwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778855156; x=1779459956; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=sbEPi44KKLT30E1Ya7Xgq7lsZNIAggwXePt17au81Fc=; b=nrgcY4Dg2Obqx2YaXWQbqH1+rqkCjuwId3cmGkugREnDkrIMu0w5ijCbFQWWmCaVBN 5XeTb7Ofi1MXzHyc4wtP8y6P7dJ+FK0ybAWInrRgmSCUyr/b2isZZWAFzDYIihLWQl3c UKB548PyAba0ABZs7zWytH7NDzeYMP8Zc4EhwgL3Ytduam7x/dNii+1etpVWqMqr69UQ VwB6xP1WYsJ7shOWB4j9sPZgRJDC4ej295ZbL0jdomdmP5XCEEj3oxvizNXZP22tCdYA pKJfJNk63rOnPt2SYwkXRKa8rBvxvlsc5djPBDfGt7BmdXemVTpo4mE1g43d88B4dudh Tqsw== X-Forwarded-Encrypted: i=1; AFNElJ868h+p3BYIHOLjQSCmlOfZE6mEq6vqbMytHbwcfbnVG9NjKK69KAVgErj3zPhR4NOGuvbAK5Vb/30G@nongnu.org X-Gm-Message-State: AOJu0YwkT6fm5pma6PgQKXz5QFC1uw+EW/tzwNkjZdzxLBzK0qDHuno8 BbSpElCPRihfBmayvyneYsXzGok+Cxt+LJS8jVSUjbQrgTbJeIwhNi4/YwVszBzVQ2Cjv1Ukp7g XQool X-Gm-Gg: Acq92OH+v7DRnNT9T9ZJLpdULkbHGjXWjpU8sI0rt8zAmNykI80QhefBfnwWNMGbIDH HfrsCrjmaw6plTSAPjtr0E9jNQFh+882sLe3GcvxnI5z+/Jm6XhzaGDJgaYfNgUG4tzyVcbupwG S+MkXvTyvOp+kaiRjQnG5wSs5ALIgAYSCeaWgnxDt+LGHf+cwQjOIMiuSDlEAgIH0gnfp9AcCi/ cJYNT2zjnQogpxtIoFIbXTsHjCJkqZ6hQBzkR/XmNk0tvDEM5mIdLvDA3zmVn+4iSH4NKEMqfuY RjJHbRWVYd8oAs0ZwEfGj7rjNlPGEM6VPzI3wLv/9HXo2xz//v4/xQrtB81fSXV9xHB3EM2PiQA cKueOojUo8zQP0+tEPOwdZe8I24f/6TEzsxOPKtk7qPFXV+nnXjji2yPvOaWm+B29Jd/HzVzxuk 4rLTaE0/s9M/1RLwBLF5BS8Zya+wGPNrCoN8gw4Sfb7CavEYDUU4Lnj2wYAT4POhsQXzP5jx22V +YcNGHtWUdVSMydGaP1VanuOepsifYYVdT6tj1eDw== X-Received: by 2002:a5d:5d10:0:b0:45a:dd7a:e33c with SMTP id ffacd0b85a97d-45e5c596c14mr5570592f8f.33.1778855155760; Fri, 15 May 2026 07:25:55 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: [RFC PATCH 13/14] target/arm/ptw: Flip sense of get_phys_addr_for_at return value Date: Fri, 15 May 2026 15:25:40 +0100 Message-ID: <20260515142541.571911-14-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260515142541.571911-1-peter.maydell@linaro.org> References: <20260515142541.571911-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1778855235246158500 Content-Type: text/plain; charset="utf-8" Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/internals.h | 2 ++ target/arm/ptw.c | 2 +- target/arm/tcg/cpregs-at.c | 12 ++++++------ 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/target/arm/internals.h b/target/arm/internals.h index 3edc15c7b4..7fd8312477 100644 --- a/target/arm/internals.h +++ b/target/arm/internals.h @@ -1526,6 +1526,8 @@ bool get_phys_addr(CPUARMState *env, vaddr address, * * Similar to get_phys_addr, but for use by AccessType_AT, i.e. * system instructions for address translation. + * + * Returns: false on translation failure, true on success. */ bool get_phys_addr_for_at(CPUARMState *env, vaddr address, unsigned prot_c= heck, ARMMMUIdx mmu_idx, ARMSecuritySpace space, diff --git a/target/arm/ptw.c b/target/arm/ptw.c index ea036a541c..6a002c25e1 100644 --- a/target/arm/ptw.c +++ b/target/arm/ptw.c @@ -3851,7 +3851,7 @@ bool get_phys_addr_for_at(CPUARMState *env, vaddr add= ress, * check is handled or bypassed by .in_prot_check) and "memop =3D MO_8" * bypasses any alignment check. */ - return !get_phys_addr_nogpc(env, &ptw, address, + return get_phys_addr_nogpc(env, &ptw, address, MMU_DATA_LOAD, MO_8, result, fi); } =20 diff --git a/target/arm/tcg/cpregs-at.c b/target/arm/tcg/cpregs-at.c index 53dd67375d..1c819c1cdb 100644 --- a/target/arm/tcg/cpregs-at.c +++ b/target/arm/tcg/cpregs-at.c @@ -31,17 +31,17 @@ static uint64_t do_ats_write(CPUARMState *env, uint64_t= value, bool format64 =3D false; ARMMMUFaultInfo fi =3D {}; GetPhysAddrResult res =3D {}; - bool ret =3D get_phys_addr_for_at(env, value, prot_check, - mmu_idx, ss, &res, &fi); + bool ok =3D get_phys_addr_for_at(env, value, prot_check, + mmu_idx, ss, &res, &fi); =20 /* * ATS operations only do S1 or S1+S2 translations, so we never * have to deal with the ARMCacheAttrs format for S2 only. * (Note that res fields are only valid on ptw success.) */ - assert(ret || !res.cacheattrs.is_s2_format); + assert(!ok || !res.cacheattrs.is_s2_format); =20 - if (ret) { + if (!ok) { /* * Some kinds of translation fault must cause exceptions rather * than being reported in the PAR. @@ -144,7 +144,7 @@ static uint64_t do_ats_write(CPUARMState *env, uint64_t= value, if (format64) { /* Create a 64-bit PAR */ par64 =3D (1 << 11); /* LPAE bit always set */ - if (!ret) { + if (ok) { par64 |=3D res.f.phys_addr & ~0xfffULL; if (!res.f.attrs.secure) { par64 |=3D (1 << 9); /* NS */ @@ -169,7 +169,7 @@ static uint64_t do_ats_write(CPUARMState *env, uint64_t= value, * translation table format (with WnR always clear). * Convert it to a 32-bit PAR. */ - if (!ret) { + if (ok) { /* We do not set any attribute bits in the PAR */ if (res.f.lg_page_size =3D=3D 24 && arm_feature(env, ARM_FEATURE_V7)) { --=20 2.43.0 From nobody Sat May 30 18:36:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1778855293; cv=none; d=zohomail.com; s=zohoarc; b=IavcwQTHqoTeP6IAEbRTbQx9wevAwMkuUwZzvKuaZpe/Xf7f+m4ljukYR2F97BOwvD8MAZfFNW3LFL8WzvpXm/WSjtmKarIIIDmbsE0Nk8haSKrsikBXbvN46rG8BNyA9pWUkWhbzQIgLz1Dr3r4obtKTWp79h02DbhJNGhkZx4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778855293; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=vA+cQBnC8tVbvSe9RbhVXRcVemldMP+qSodEma1dh88=; b=RTtvaFXW/l5EH2nYPciVfBJOAN6q3y6goSFw9Kx1qT2q7AP7EZLd2SveW3W4KE6vbbJVd1eEoOESDuocu/OXLEIZslUoiopzmwnBhcrgxx33KSagxvNawV78Drle7VHCxEmST+GNKlj5U1mO8fslgUqeoqeMrMhBrFfq39dGxpw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778855293377827.85086071858; Fri, 15 May 2026 07:28:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wNtUl-0006ek-AS; Fri, 15 May 2026 10:26:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wNtUN-00060I-8G for qemu-devel@nongnu.org; Fri, 15 May 2026 10:26:07 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wNtUH-00011k-0D for qemu-devel@nongnu.org; Fri, 15 May 2026 10:26:05 -0400 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-4526a8170ceso5201533f8f.2 for ; Fri, 15 May 2026 07:25:57 -0700 (PDT) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da15a666fsm13560603f8f.36.2026.05.15.07.25.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 07:25:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778855157; x=1779459957; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=vA+cQBnC8tVbvSe9RbhVXRcVemldMP+qSodEma1dh88=; b=nCxZ1gWxX2NO8rdAx8x7oRSuhPmCuQ6jWXalV+VwFZPUzja7ZzsyInfHBueqqmOJP9 anfZzuSVE+M8rcdSDnu5MVoJWcFV0KO6znUEF2cHMYhBldTqwNcOfNCdCyr0IjO4Fbul V8MdYFQKfPLOaKbBshFjpQ80jca93pGkAI/vPIRvuuURZsixoH43k6b8jOM1epxnZ9I/ 0bTdmFWVr6PIdNe1SIYgq+qOsAaGoi3XPdX9BmB8+0ZktcNxk+8OCxOagNL1IYaJIWha +NEpwEsgoT+/+Jytl7pjZXC4hF34egQu65kfOeioyDKDHP2yi6aVdiC3ejv4AQrFTCzK s5Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778855157; x=1779459957; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=vA+cQBnC8tVbvSe9RbhVXRcVemldMP+qSodEma1dh88=; b=BqYL8WY98hOOsL64Q2zIFNmJgKoO8RIXDQaC0pIJHPcBJhvQrNF0CEMKHWhO/LUJ16 AcfE9g9kIdIplrrdaMZdsZKIhmbTLrp4MEgfgiH7thN7Dzm+UYMSVCZ84bzhutVvwaFR rc9ATp2CHjbv4716EoNaaH/nIRWSlSrWJhurwUYx4oYYjpejFoP7Xqz/zlQGNf1QrUPg KrlGpm+/Dxs0IU1n0pDYVlcrMf1VIArmdI5yIB86szQAO4MHgZUZBbUMeLXgbS5IZq28 g1GUU1BqeKjXklXgQlFBPKIvsG1W9iOaou/J2/a7a5Ydm0wD5naxsMnmwk9bljy4WlyU lICw== X-Forwarded-Encrypted: i=1; AFNElJ961FTbKNpvthwx8Q7TZjhRGrpWeb63AXCNH/b3nPweyy4I/KCquGs7rvwdxhQtyhKMT0/4vFEN+UNH@nongnu.org X-Gm-Message-State: AOJu0YzUlhq+Ra327kETp+Og3NrnJpOoVwmRPdGNQLjb8gdBKmHylSGA ISDKNACQs7NWraSlxVaTa17H1CHlDe0NyG0cZJ4umUA5gEI0kgQw5Uy5wXrrxYo44xg= X-Gm-Gg: Acq92OFUdvV7qlVcxtyWHgebGXH7ZmSHuvY7yP8i/Ji/gxsFBi4RMLXbRSyx8lkLG/x vv0FO9TxJOeG7Y7S8Xosl1tAjUQGFxDrBRyVnMH0Y1cdgtYV4Fw8v8w92k1mHT0UwPDEvqnTeyR LJUUXnlVTopoBZSZS8dymYpQ0NQmWX0EUIzAdhsIlLnP+zNcbHWXm1IiK4jExep3vuFjvBguEtH eig0sknlheJ6sOChBft4zcv9VFNfaf88LCsyuTUNn2V/nFQ+9gTzzgSI7oEVi6mLqNsX131UmUW vWSKy6H4UhNt6KRI4Qk6GdfZt//FhiZPq74k2fwhF8+zgqULbumsVUa4HEYFyJmSzvwYG3m6Ks+ hpEoVy1yt+EVSiKOmiQYGvgsr24optdGYaqikbJ3sagn0jAoK/yGYbxeYySzI232Z/LWQn1bZD1 uDWWOK6WOJS6DnkISH+ZFzLakU45L7SYyZrlCtSvhpadGQqXGuiOWL+OXZCZaR4+asUhn2jG/+8 nBvWRoZ6fiVDcyCf5gzR90TcrqrDVkivY3h88qU4w== X-Received: by 2002:a05:6000:2601:b0:456:e27d:d6aa with SMTP id ffacd0b85a97d-45e5c5b3975mr5677124f8f.2.1778855156777; Fri, 15 May 2026 07:25:56 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: [RFC PATCH 14/14] target/arm/ptw: Flip sense of get_phys_addr return value Date: Fri, 15 May 2026 15:25:41 +0100 Message-ID: <20260515142541.571911-15-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260515142541.571911-1-peter.maydell@linaro.org> References: <20260515142541.571911-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1778855293915158500 Content-Type: text/plain; charset="utf-8" This completes the conversion of this family of functions to returning true on success and false on failure. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/internals.h | 2 +- target/arm/ptw.c | 2 +- target/arm/tcg/m_helper.c | 8 ++++---- target/arm/tcg/tlb_helper.c | 6 +++--- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/target/arm/internals.h b/target/arm/internals.h index 7fd8312477..d47ffb67c0 100644 --- a/target/arm/internals.h +++ b/target/arm/internals.h @@ -1500,7 +1500,7 @@ typedef struct GetPhysAddrResult { * by doing a translation table walk on MMU based systems or using the * MPU state on MPU based systems. * - * Returns false if the translation was successful. Otherwise, phys_ptr, a= ttrs, + * Returns true if the translation was successful. Otherwise, phys_ptr, at= trs, * prot and page_size may not be filled in, and the populated fsr value pr= ovides * information on why the translation aborted, in the format of a * DFSR/IFSR fault register, with the following caveats: diff --git a/target/arm/ptw.c b/target/arm/ptw.c index 6a002c25e1..8dc9c67712 100644 --- a/target/arm/ptw.c +++ b/target/arm/ptw.c @@ -3939,7 +3939,7 @@ bool get_phys_addr(CPUARMState *env, vaddr address, .in_prot_check =3D 1 << access_type, }; =20 - return !get_phys_addr_gpc(env, &ptw, address, access_type, + return get_phys_addr_gpc(env, &ptw, address, access_type, memop, result, fi); } =20 diff --git a/target/arm/tcg/m_helper.c b/target/arm/tcg/m_helper.c index f2059ed8b0..c5a553a5d4 100644 --- a/target/arm/tcg/m_helper.c +++ b/target/arm/tcg/m_helper.c @@ -222,7 +222,7 @@ static bool v7m_stack_write(ARMCPU *cpu, uint32_t addr,= uint32_t value, int exc; bool exc_secure; =20 - if (get_phys_addr(env, addr, MMU_DATA_STORE, 0, mmu_idx, &res, &fi)) { + if (!get_phys_addr(env, addr, MMU_DATA_STORE, 0, mmu_idx, &res, &fi)) { /* MPU/SAU lookup failed */ if (fi.type =3D=3D ARMFault_QEMU_SFault) { if (mode =3D=3D STACK_LAZYFP) { @@ -311,7 +311,7 @@ static bool v7m_stack_read(ARMCPU *cpu, uint32_t *dest,= uint32_t addr, bool exc_secure; uint32_t value; =20 - if (get_phys_addr(env, addr, MMU_DATA_LOAD, 0, mmu_idx, &res, &fi)) { + if (!get_phys_addr(env, addr, MMU_DATA_LOAD, 0, mmu_idx, &res, &fi)) { /* MPU/SAU lookup failed */ if (fi.type =3D=3D ARMFault_QEMU_SFault) { qemu_log_mask(CPU_LOG_INT, @@ -2023,7 +2023,7 @@ static bool v7m_read_half_insn(ARMCPU *cpu, ARMMMUIdx= mmu_idx, bool secure, "...really SecureFault with SFSR.INVEP\n"); return false; } - if (get_phys_addr(env, addr, MMU_INST_FETCH, 0, mmu_idx, &res, &fi)) { + if (!get_phys_addr(env, addr, MMU_INST_FETCH, 0, mmu_idx, &res, &fi)) { /* the MPU lookup failed */ env->v7m.cfsr[env->v7m.secure] |=3D R_V7M_CFSR_IACCVIOL_MASK; armv7m_nvic_set_pending(env->nvic, ARMV7M_EXCP_MEM, env->v7m.secur= e); @@ -2059,7 +2059,7 @@ static bool v7m_read_sg_stack_word(ARMCPU *cpu, ARMMM= UIdx mmu_idx, ARMMMUFaultInfo fi =3D {}; uint32_t value; =20 - if (get_phys_addr(env, addr, MMU_DATA_LOAD, 0, mmu_idx, &res, &fi)) { + if (!get_phys_addr(env, addr, MMU_DATA_LOAD, 0, mmu_idx, &res, &fi)) { /* MPU/SAU lookup failed */ if (fi.type =3D=3D ARMFault_QEMU_SFault) { qemu_log_mask(CPU_LOG_INT, diff --git a/target/arm/tcg/tlb_helper.c b/target/arm/tcg/tlb_helper.c index bbe1e70bc4..f90765cb59 100644 --- a/target/arm/tcg/tlb_helper.c +++ b/target/arm/tcg/tlb_helper.c @@ -361,9 +361,9 @@ bool arm_cpu_tlb_fill_align(CPUState *cs, CPUTLBEntryFu= ll *out, vaddr address, fi->type =3D ARMFault_Alignment; } else if (address & ((1 << memop_alignment_bits(memop)) - 1)) { fi->type =3D ARMFault_Alignment; - } else if (!get_phys_addr(&cpu->env, address, access_type, memop, - core_to_arm_mmu_idx(&cpu->env, mmu_idx), - &res, fi)) { + } else if (get_phys_addr(&cpu->env, address, access_type, memop, + core_to_arm_mmu_idx(&cpu->env, mmu_idx), + &res, fi)) { res.f.extra.arm.pte_attrs =3D res.cacheattrs.attrs; res.f.extra.arm.shareability =3D res.cacheattrs.shareability; *out =3D res.f; --=20 2.43.0