From nobody Sat May 30 17:44:01 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1778650743; cv=none; d=zohomail.com; s=zohoarc; b=XRsCOavOZVdK27iUOsVGcG6ue13gXCnUx8m8kAAvOlew+wH4rEserkjIHRKs5F4EjbFXzZXK6IIoQDE4FDiNfvsQgsO8Gop4Mc/Cj9eXbe/V0E7JxLdxTdFIVG4bwtain9BqKDOZMGKOaAA7SuP/Ee1eP3oJZoB0xTHveGcfie0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778650743; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XkYNinsYEGPyxvrSjwgj1bi8typGS7e9QH2V7czgNYg=; b=GK9em+YYVmKembiLIBTx0xhLpBIM/xK6QIWte7QZVg7uHIxVvqM0vnRZoYRWIsJTXZRbeb+Q+QYVzmu4eXRIxMjJQCdSp74RMCzyHRSInOYcx6bkhgar0S1V9YsCJ5vK/NSyJlW98ps86gzZ+/mkoHAkXwpL0aWTjDo3YusRAw4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778650743385341.46295684161703; Tue, 12 May 2026 22:39:03 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wN2IO-0002gA-KH; Wed, 13 May 2026 01:38:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wN2II-0002fa-IR for qemu-devel@nongnu.org; Wed, 13 May 2026 01:38:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wN2IG-0004xT-Ff for qemu-devel@nongnu.org; Wed, 13 May 2026 01:38:05 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-363-Hv9iJrN3PPCwm3sO9CeqaQ-1; Wed, 13 May 2026 01:37:58 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DDE441800359; Wed, 13 May 2026 05:37:55 +0000 (UTC) Received: from corto.redhat.com (unknown [10.44.49.156]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C3B421800576; Wed, 13 May 2026 05:37:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778650683; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XkYNinsYEGPyxvrSjwgj1bi8typGS7e9QH2V7czgNYg=; b=W+HyKPnvCruS0iha0vVplOBs5SHQ3Lu1Unw221jK63/2r/SoMwYvyTRK+eDUyhrJpeRqRt 2fIz04ys2s6CMvgF9r7U6+iLcFF7eAzZ9FfpwniEkYXWxlnkz5qkSgJkqJPxHQ8SWRo68D da2c/qSQFENyYCylvYVXq45WexdloAA= X-MC-Unique: Hv9iJrN3PPCwm3sO9CeqaQ-1 X-Mimecast-MFC-AGG-ID: Hv9iJrN3PPCwm3sO9CeqaQ_1778650676 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-devel@nongnu.org, qemu-arm@nongnu.org Cc: Peter Maydell , Steven Lee , Troy Lee , Jamin Lin , kane_chen@aspeedtech.com, Andrew Jeffery , Joel Stanley , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PATCH] hw/misc/aspeed_scu: Fix AST2600_RNG definitions Date: Wed, 13 May 2026 07:37:49 +0200 Message-ID: <20260513053749.132759-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1778650745221158500 Commit e09cf36321f6 ("hw: aspeed_scu: Add AST2600 support") introduced a typo on the definitions of the Random Number Generator registers. Fix that. The implementation of RNG_CTRL and RNG_DATA should be rechecked on HW since the QEMU implementation always generates random data, regardless of RNG_CTRL. A comment in aspeed_ast2600_scu_read() admits uncertainty about the behavior : /* * On hardware, RNG_DATA works regardless of the state of the * enable bit in RNG_CTRL * * TODO: Check this is true for ast2600 */ Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/2350 Fixes: e09cf36321f6 ("hw: aspeed_scu: Add AST2600 support") Signed-off-by: C=C3=A9dric Le Goater Reviewed-by: Jamin Lin --- hw/misc/aspeed_scu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/misc/aspeed_scu.c b/hw/misc/aspeed_scu.c index e4160356e443..9d9f43e6b563 100644 --- a/hw/misc/aspeed_scu.c +++ b/hw/misc/aspeed_scu.c @@ -128,8 +128,8 @@ #define AST2600_HW_STRAP2 TO_REG(0x510) #define AST2600_HW_STRAP2_CLR TO_REG(0x514) #define AST2600_HW_STRAP2_PROT TO_REG(0x518) -#define AST2600_RNG_CTRL TO_REG(0x524) -#define AST2600_RNG_DATA TO_REG(0x540) +#define AST2600_RNG_CTRL TO_REG(0x520) +#define AST2600_RNG_DATA TO_REG(0x524) #define AST2600_CHIP_ID0 TO_REG(0x5B0) #define AST2600_CHIP_ID1 TO_REG(0x5B4) =20 --=20 2.54.0