From nobody Mon May 25 20:31:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1778481561; cv=none; d=zohomail.com; s=zohoarc; b=U00lUJ+Dm2/msPrC0cL5cOyhVhw58EvZPJOl90Dx1Kkiivk3x8zyABDQPZfTuJYeEv9ZsPhM3MKKHSG8QBDWr5EB5v/tWp00WpL5MHz7OtPz5/PzonL8oEBawhqIWX1GqMnVBQMor27+JxfUJvvNi83kMX2qjZBxRMP8FvI+8Ac= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778481561; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=GBu72odyTGge0+42NyrnTkyvavVr/t3/dkGBZgxa4r4=; b=FPcrweZ8u6Ln8ni6NDSCcldoVKeGvcumLN584NMRw98+vQbJwVt/BYK2e4vj2A42zX36ZlHT7OmiLJCZbD2hj9Nib93JxcIG6ptxfvet0q0vtF+jScgCi67JmzIwJ3ZQ7cIZbog3o8JCROJyyQPuU4j1er613PDxub1LiuZX5p0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177848156177160.973283040490855; Sun, 10 May 2026 23:39:21 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wMKHm-0007T7-T6; Mon, 11 May 2026 02:38:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wMKHl-0007SS-3Q for qemu-devel@nongnu.org; Mon, 11 May 2026 02:38:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wMKHj-0006ul-3c for qemu-devel@nongnu.org; Mon, 11 May 2026 02:38:36 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-32-f0hPScj6POirtfobSMmAhg-1; Mon, 11 May 2026 02:38:31 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B9F5A19560A1; Mon, 11 May 2026 06:38:29 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.48.145]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4AADF30001BE; Mon, 11 May 2026 06:38:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778481513; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=GBu72odyTGge0+42NyrnTkyvavVr/t3/dkGBZgxa4r4=; b=LvXxZquNyBAH5BFbPBIM9P0wsiX8hn7khFtgm22LjakrzTA9S4sDN/quATphJ9Bea2yj8C LRyuFcKR6COdCLI5z8ix8BIx0gxB7eCTjRFpfByfsITp0ZjfgvJNVG/koPEMyITgAtQKke uCm0RBDf3RuVc3p+LnG+RtxT9+SMpyo= X-MC-Unique: f0hPScj6POirtfobSMmAhg-1 X-Mimecast-MFC-AGG-ID: f0hPScj6POirtfobSMmAhg_1778481510 From: Thomas Huth To: qemu-s390x@nongnu.org, Matthew Rosato , Farhan Ali Cc: qemu-devel@nongnu.org, Eric Farman , Cornelia Huck , Halil Pasic Subject: [PATCH v2] hw/s390x: Fix memory leaks after removing elements with QTAILQ_REMOVE Date: Mon, 11 May 2026 08:38:25 +0200 Message-ID: <20260511063825.53633-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1778481564265158500 Content-Type: text/plain; charset="utf-8" From: Thomas Huth The elements that get removed with QTAILQ_REMOVE are never referenced afterwards anymore, so the corresponding memory should get freed. Fixes: 37fa32de70 ("s390x/pci: Honor DMA limits set by vfio") Reviewed-by: Farhan Ali Signed-off-by: Thomas Huth Reviewed-by: Matthew Rosato Tested-by: Matthew Rosato --- v2: Drop change to hw/s390x/s390-pci-bus.c (since it needs other rework) hw/s390x/s390-pci-vfio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/s390x/s390-pci-vfio.c b/hw/s390x/s390-pci-vfio.c index 7c754b656da..db6de00bd28 100644 --- a/hw/s390x/s390-pci-vfio.c +++ b/hw/s390x/s390-pci-vfio.c @@ -101,6 +101,7 @@ void s390_pci_end_dma_count(S390pciState *s, S390PCIDMA= Count *cnt) cnt->users--; if (cnt->users =3D=3D 0) { QTAILQ_REMOVE(&s->zpci_dma_limit, cnt, link); + g_free(cnt); } } =20 --=20 2.54.0