From nobody Sun Sep 20 19:52:19 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1778012882; cv=none; d=zohomail.com; s=zohoarc; b=LCp3YQJmxbpa6DkcTyuLW/FYnQ/5MtTNNQSS+mUicZd2705gPDkmfZYdDVCy86ZhGzzUa8ZrGgyMDYFHxK0W0Zt4cq8jV9fvZnGmRD/DHB6DwkRxPIJU1u6l97roivWJ3UwusudgxwqGalNj0y4/1M7f4Pdb0TqZ8wfsNRhRbZo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778012882; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=CmjHBJ8XbN1QfelMZFqFN+lYGBuxnVmoSMYFNc5rg38=; b=HogY6mp+Ydv/g6G0HC45jAti9gcbK7x3I/zA3PANpeUUC4AsLvoIzGicDr43hHGhx9v9pMxD6XnsytlmBc9ozw/Lq0q8GZDlM/hr6283BRphVxFIU705R9qXR3SSOqpzqQ0QuLcbqJ9vQQjHZLg69dnYwgqo5IIj3b9y9jKIPOY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1778012882322895.1391324320034; Tue, 5 May 2026 13:28:02 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 6C26141828; Tue, 5 May 2026 16:28:01 -0400 (EDT) Received: from [172.19.199.9] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id F032D41821; Tue, 5 May 2026 16:27:05 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id DD12F3F311; Tue, 5 May 2026 16:26:56 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 137CD3F2F2 for ; Tue, 5 May 2026 16:26:54 -0400 (EDT) Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-209-BL0Enlf6NuGuueivIbiyeg-1; Tue, 05 May 2026 16:26:51 -0400 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-8b49424ad88so135190706d6.1 for ; Tue, 05 May 2026 13:26:51 -0700 (PDT) Received: from x1.com ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8b53c6b8123sm155283806d6.35.2026.05.05.13.26.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 13:26:49 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778012814; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CmjHBJ8XbN1QfelMZFqFN+lYGBuxnVmoSMYFNc5rg38=; b=ejZw3B/A4XLz/1UWzOgE20uK8IBE7mZXH7rMmoF99YK3hfgwd1BBUBDpmayeut36aeoLMo l1DtKAB9wlx9OsCYWzleIkUKvTiuczwxJbxUJknKy0tE7qoSRAv8mt0BcDWywekv1JTL4D s9brCI0NIniz2ZLYHP0+UaRTs5qz8M4= X-MC-Unique: BL0Enlf6NuGuueivIbiyeg-1 X-Mimecast-MFC-AGG-ID: BL0Enlf6NuGuueivIbiyeg_1778012811 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778012811; x=1778617611; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CmjHBJ8XbN1QfelMZFqFN+lYGBuxnVmoSMYFNc5rg38=; b=bv5uTE5vxeSDAU/wEZhM25ao8d3BfEeq1RHeAkSxvpMg99iPASqlBoMMJfS9shZFrc vNZik397ajjkIMo/Xx6LF7+AcSYg4mLzzKhrNA2lTZ0sOqWHAeXD3PLYuoFrbw/UcgDf dmwVNmCfKr+5X/VRXBHtb/7btkWCTMUxzbiQ/zcqDq5VZP8PDE3obcqVq6KQr/bIcG+i u2KMyBUb+k4DMBRjtBKSk9jmXP0dKX2TJ9rstzB7mLfbFaH/uxNf5NkLJDSOHucgIhaz BbvDUKsEp4071I6NkUy7jBNx7AePuGuWZPqrew8F9hLmlV+E5MmvGsp4R0lNXUEPWseX mlhQ== X-Forwarded-Encrypted: i=1; AFNElJ/NPpB88ToobUXx84P8kHs//UczvtM50If1wb5wTK1qw8C3Xc67Qxl8KjTqv7wbG+3ntwe1Dg==@lists.libvirt.org X-Gm-Message-State: AOJu0YxY4Pv7QZcg1fzdtfmc+zqhnLtyBltAPSADpeTiHVjGDdTCBKex OU/BtYeHPmt6pkjIGcPYS+AKSfjYtwz0UjZWhAlZ+HmjUE/PQwu85uh4Z1WoD4jc3LXHxjekPRC eLmsSz8ct+Rto/BHd6xu+Wu484DlZm7ipTuw9qYBEiAF7cDg5iS4jxMtMJZo= X-Gm-Gg: AeBDiesMeffRTst6POA0AYwXPlQEZM5SNpKE6JtN7Pz12wKy8KW3hSXKXY9bROMNBTl 5GhxtUyFJQSDnlx/PC2LrhElZZHuJ2v2MTk0yaU9KajZ6hC5fkIE3DCI5DnHQZw6Z2JdGmF3n6x JVxIIgFV3pWhNqR85Ql5hpGoIlMjKPV+fJf+YbY+3Qn7Og/RTvJFOd0AMjHl66RkvQzmPYMabPH ezmcQGS36mg6Pt8BbnU1Kr+Zz8Avjn0GkLG32OYheyQ//Ppr7CwtTSKOLs2Ly850HyfuZ3twXDH UrfEm75WJuNXvAHtcU2Xefn8KNLhI7IPg7OvXSaD18t7rjJhyXYqzMzJFTnOu0P5Ekr/BMOyI+2 3+ODS9+y/KMhfz9idfW6pb/LAzroTqnXaRGXSU3JzXTFCCZ2FkCOOoXs= X-Received: by 2002:ad4:5de4:0:b0:8b8:726a:74d4 with SMTP id 6a1803df08f44-8bc42b6c5d7mr4961846d6.16.1778012810460; Tue, 05 May 2026 13:26:50 -0700 (PDT) X-Received: by 2002:ad4:5de4:0:b0:8b8:726a:74d4 with SMTP id 6a1803df08f44-8bc42b6c5d7mr4961096d6.16.1778012809818; Tue, 05 May 2026 13:26:49 -0700 (PDT) To: qemu-devel@nongnu.org Subject: [PULL 05/23] migration/qapi: Rename MigrationStats to MigrationRAMStats Date: Tue, 5 May 2026 16:26:22 -0400 Message-ID: <20260505202640.1011006-6-peterx@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260505202640.1011006-1-peterx@redhat.com> References: <20260505202640.1011006-1-peterx@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: RP7-VxLmA60Wui-fTJbC8cME-k6Pk3d5JsI1C1F8AWU_1778012811 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: FH5FPMA3SF5JWPKGK4T2TIT6MAJFJRNA X-Message-ID-Hash: FH5FPMA3SF5JWPKGK4T2TIT6MAJFJRNA X-MailFrom: peterx@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Fabiano Rosas , Paolo Bonzini , Peter Xu , devel@lists.libvirt.org, Markus Armbruster , Juraj Marcin , Michal Privoznik X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Xu via Devel Reply-To: Peter Xu X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1778012888823154100 This stats is only about RAM, make it accurate. This paves way for statistics for all devices. Thanks to Markus, who pointed out that docs/devel/qapi-code-gen.rst has a section "Compatibility considerations" stated: Since type names are not visible in the Client JSON Protocol, types may be freely renamed. Even certain refactorings are invisible, such as splitting members from one type into a common base type. Hence this change is not ABI violation according to the document. While at it, touch up the lines to make it read better, correct the restriction on migration status being 'active' or 'completed': over time we grew too many new status that will also report "ram" section. Cc: Daniel P. Berrang=C3=A9 Cc: devel@lists.libvirt.org Reviewed-by: Markus Armbruster Reviewed-by: Juraj Marcin Reviewed-by: Michal Privoznik Link: https://lore.kernel.org/r/20260421202110.306051-4-peterx@redhat.com Signed-off-by: Peter Xu --- docs/about/removed-features.rst | 2 +- qapi/migration.json | 10 +++++----- migration/migration-stats.h | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.= rst index e75db08410..626162022a 100644 --- a/docs/about/removed-features.rst +++ b/docs/about/removed-features.rst @@ -699,7 +699,7 @@ was superseded by ``sections``. ``query-migrate`` return value member ``skipped`` (removed in 9.1) '''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' =20 -Member ``skipped`` of the ``MigrationStats`` struct hasn't been used +Member ``skipped`` of the ``MigrationRAMStats`` struct hasn't been used for more than 10 years. Removed with no replacement. =20 ``migrate`` command option ``inc`` (removed in 9.1) diff --git a/qapi/migration.json b/qapi/migration.json index 0db115ec5e..ed475e4261 100644 --- a/qapi/migration.json +++ b/qapi/migration.json @@ -12,7 +12,7 @@ { 'include': 'sockets.json' } =20 ## -# @MigrationStats: +# @MigrationRAMStats: # # Detailed migration status. # @@ -64,7 +64,7 @@ # # Since: 0.14 ## -{ 'struct': 'MigrationStats', +{ 'struct': 'MigrationRAMStats', 'data': {'transferred': 'int', 'remaining': 'int', 'total': 'int' , 'duplicate': 'int', 'normal': 'int', @@ -209,8 +209,8 @@ # If this field is not returned, no migration process has been # initiated # -# @ram: `MigrationStats` containing detailed migration status, only -# returned if status is 'active' or 'completed'(since 1.2) +# @ram: Detailed migration RAM statistics, only returned if migration +# is in progress or completed (since 1.2) # # @xbzrle-cache: `XBZRLECacheStats` containing detailed XBZRLE # migration statistics, only returned if XBZRLE feature is on and @@ -309,7 +309,7 @@ # Since: 0.14 ## { 'struct': 'MigrationInfo', - 'data': {'*status': 'MigrationStatus', '*ram': 'MigrationStats', + 'data': {'*status': 'MigrationStatus', '*ram': 'MigrationRAMStats', '*vfio': 'VfioStats', '*xbzrle-cache': 'XBZRLECacheStats', '*total-time': 'int', diff --git a/migration/migration-stats.h b/migration/migration-stats.h index c0f50144c9..1153520f7a 100644 --- a/migration/migration-stats.h +++ b/migration/migration-stats.h @@ -27,7 +27,7 @@ =20 /* * These are the ram migration statistic counters. It is loosely - * based on MigrationStats. + * based on MigrationRAMStats. */ typedef struct { /* --=20 2.53.0