From nobody Mon Sep 21 15:56:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1778012955; cv=none; d=zohomail.com; s=zohoarc; b=RZ2ElClCYJ51YB2WZ6qjsfok4iw9uJQNr8rsgxMUYEJ4r39Z/hZo3FmoyXtEwTooGP5zVVW1EdiFULVM9E0FTTmvbRnyBhScLB6KjFxNaB2f0STFl8TCqm5UluNnY/PxCWda/rP7AKK/ZGL0HJmsccUsMlvUGcYxysAiKSv5czE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778012955; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=UrdJvZlwcHz7aiZ2PAnafLIUZGKxAgtWgdAZUAhTr6E=; b=RORJoNgIyiUiPPtRjPtFCNM+CaPoTwtmRex4Laok13cV68+cAnRD2dPQyBWeKLYy5c4d7yS6Q8zkU863a2Q+QRVWIKbxTVInjwuGKXiStNd+MLRb33DMUEj5FRXYO68axi36uED7HzolVg7zMk4e4Nv/4ceEGL7930c0Ta+oneY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1778012955212940.7178717028787; Tue, 5 May 2026 13:29:15 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wKMMP-0004dL-5d; Tue, 05 May 2026 16:27:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wKMML-0004ZD-Hq for qemu-devel@nongnu.org; Tue, 05 May 2026 16:27:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wKMMJ-0002fS-3d for qemu-devel@nongnu.org; Tue, 05 May 2026 16:27:13 -0400 Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-280-ax-VDKlwMP-XHDhM3CqKTg-1; Tue, 05 May 2026 16:27:08 -0400 Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-62f30279e90so2381900137.0 for ; Tue, 05 May 2026 13:27:08 -0700 (PDT) Received: from x1.com ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8b53c6b8123sm155283806d6.35.2026.05.05.13.27.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 13:27:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778012830; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UrdJvZlwcHz7aiZ2PAnafLIUZGKxAgtWgdAZUAhTr6E=; b=RqzPbWI4+yvYqBeV1CCNFh7sAGO3h/Dy5EUljN9JD2GrZ5u6O5kCiRtc5U48xotNWg26Wa BNhrmL5JeKUtm3JXTBV5gSHxo8RZ5V5BAtysQavSGowwC/cWfevkRDgY6EZ8rYo1H348XR 7M5c7mXf6s/05XPRiXzvZxtbWjePf1E= X-MC-Unique: ax-VDKlwMP-XHDhM3CqKTg-1 X-Mimecast-MFC-AGG-ID: ax-VDKlwMP-XHDhM3CqKTg_1778012828 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778012828; x=1778617628; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UrdJvZlwcHz7aiZ2PAnafLIUZGKxAgtWgdAZUAhTr6E=; b=MURegrAvqCmj9MQn8VXohb2TiCgXTacphvWGB0r9ADB7UJE7q5PlwYeectXZLrX0cg kh5KoXwz+YWfZU3gcw6QYAKT/JLyiXl18JpzPrJ4Ijua8Epy8ZRZFrXE/gNAejWXT/7a 9IvDP92sgOKwzrVkf17owlkxQC6CfX0Et1EANWw+wUTbsKcNA0aQ8zb0Xx8OitsXYkZL wz8TDerFdN9Y5UCZLGqhgeLrjOaYA7u/gvQ0lv6jGYYFUFB9y1cHNQhjIWterkKnOJUw o7/Fj2HEqYqyy7qxgF6TBpbCOZ6SA7WK2RKGR25gOlXDd0witzYJTVxf7gyOR5VuCjci Xe6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778012828; x=1778617628; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=UrdJvZlwcHz7aiZ2PAnafLIUZGKxAgtWgdAZUAhTr6E=; b=UNaxbrRKLkINoPUcAaEWU0rQBlwSWgQrIpzi+107LvpY083n9nKHc1JdjhQfZz9L5A tDCd+ZkT/pLlrGmciRToOSaIVsk+1BVS7hpJtei/j5pn4tfflFFcJh5AAYZVb9IU2tzc BHda/+8w6O/NK5K2ZAORYwk0P3Q04l6aWJNPYcHIwL4EuH0D2LkJZ2til14axeRxSLCz fhcT4L18ajWDwfam3fBBH6hU3vuE0/DDM5YgQy0k0VqeEAZT5eLm27di9EkpxhU8D45U C4JLe4pyQT2IkH+uqhlG8CbKovAP8XZmX6Y5yONDzzeRNkRW2I+0fBmtd9yrvwkSATKd jdaw== X-Gm-Message-State: AOJu0YxhbBcLa9HrluHNxrKHZg2G0Q8nVQzIqFc54k2haHa0bH188nTO zjYT3LNaYdHmXI2gNvf8whJ19UnSGzHvYAV7e/1TbMSJ5apXIju23VI/VDEWPlIVXF20DNb9zS1 N4XKlSygY1n4by68iFpxOw2CGvo2k9ofMKVOhOA0q76/1Cj4JxuDOVxBjicAuG4uOT7L6B5a4BC 8DqT1GyiwEl9DSV4fyUobywAR45tNs7pHTFyXbFA== X-Gm-Gg: AeBDietFUuHHi1EP9VEAA2eoBWRcXRAsvxAX2+MNZpMS9gPmvgYf/RnSHP2sbvEioiZ FIymJicA+1npq/JCFhW0rg/331V6ojYOz2sNv3zP2MOPKuUhUFDSECsoJFujFKVeC+RprbWqxSi FT41iMZUDOBbcmDX11GvSMSUpA92aaoruTsP05OUL8I3ieaUL+k00H2emvFw5vhF3rGrjgJPNUw 9KodJ8O5WR9fdvkeHHYVjM30BmkYs7mEgvdbbTyYbB3dqS7X4D3Ta9auEdF/IwRzGOTz16yzsUT U9KPTNbxQEYp4IJdpgB/Bs2krMGcwseIpmgNvGTMOPQRvunb5eD4g3IBzMnahdYrWpqvXmuI93i TLRjl84itVPm2oBgieyXLmHWduLVQDD66cNWGUwPW2Buf/3sqyIPrpPo= X-Received: by 2002:a05:6102:374d:b0:611:e0c2:1604 with SMTP id ada2fe7eead31-630f8fcf085mr136593137.19.1778012827446; Tue, 05 May 2026 13:27:07 -0700 (PDT) X-Received: by 2002:a05:6102:374d:b0:611:e0c2:1604 with SMTP id ada2fe7eead31-630f8fcf085mr136396137.19.1778012825823; Tue, 05 May 2026 13:27:05 -0700 (PDT) From: Peter Xu To: qemu-devel@nongnu.org Cc: Fabiano Rosas , Paolo Bonzini , Peter Xu , CJ Chen , Tomoyuki Hirose , Daniel Henrique Barboza , Peter Maydell , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 19/23] hw/riscv: iommu-trap: remove .impl.unaligned = true Date: Tue, 5 May 2026 16:26:36 -0400 Message-ID: <20260505202640.1011006-20-peterx@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260505202640.1011006-1-peterx@redhat.com> References: <20260505202640.1011006-1-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.443, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1778012957724154100 From: CJ Chen The riscv_iommu_trap_ops MemoryRegionOps specifies that unaligned accesses are not valid for this device but that it does implement them. This doesn't make much sense, and we want to add an assertion that registered MRs don't specify this invalid combination of settings. Drop .impl.unaligned =3D true, with no behaviour change. Signed-off-by: CJ Chen Acked-by: Tomoyuki Hirose Reported-by: Tomoyuki Hirose Reviewed-by: Daniel Henrique Barboza [PMM: reworded commit message] Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daud=C3=A9 Link: https://lore.kernel.org/r/20260428093339.2087081-2-peter.maydell@lina= ro.org Signed-off-by: Peter Xu --- hw/riscv/riscv-iommu.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/riscv/riscv-iommu.c b/hw/riscv/riscv-iommu.c index 7ba3240552..2b40ab2ce0 100644 --- a/hw/riscv/riscv-iommu.c +++ b/hw/riscv/riscv-iommu.c @@ -2434,7 +2434,6 @@ static const MemoryRegionOps riscv_iommu_trap_ops =3D= { .impl =3D { .min_access_size =3D 4, .max_access_size =3D 8, - .unaligned =3D true, }, .valid =3D { .min_access_size =3D 4, --=20 2.53.0