From nobody Sat May 30 18:36:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1777977498; cv=none; d=zohomail.com; s=zohoarc; b=IdRIW2wIiCgttmAUJVrmrJH3QZuI8EQMCtKjG10K0+dZtcH44RK4IMz0r1YKHXLGUSbPyNQoXu45YLMgERJEi+R88hZvT18xDH2mtFVEHgTqDkvQzbC6mwnei50wW+uliuTNNjyAnByVK85W62Xc5hTk0sThsNFiNjCLjMG3zkU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777977498; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0+VNM6tTV/nZT8ORsfGVd8wLoMc82NM31B45S3duO08=; b=Z3Jx9N/ueSr+T8s3ynUX/369HMduzxq4r655eFF7437mUD9Eyt8zsJj4pYxOHpoOjChXJmk9cuEBmrtteGA1LLeMb3B2dY2pC7Fg2OWK36vaG3moWuvQv/zDAPfpHQ6GtFYTC87ES1TMPoZKZkbqZvGUCqmIc3tVP8trKKmqH6M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777977498415180.60414369089085; Tue, 5 May 2026 03:38:18 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wKD9h-0001Xn-Cb; Tue, 05 May 2026 06:37:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wKD9g-0001Wu-AE for qemu-devel@nongnu.org; Tue, 05 May 2026 06:37:32 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wKD9e-0008Fp-3E for qemu-devel@nongnu.org; Tue, 05 May 2026 06:37:32 -0400 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-4838c15e3cbso41382315e9.3 for ; Tue, 05 May 2026 03:37:29 -0700 (PDT) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48d14781f43sm33183005e9.0.2026.05.05.03.37.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 03:37:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777977449; x=1778582249; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=0+VNM6tTV/nZT8ORsfGVd8wLoMc82NM31B45S3duO08=; b=gDKh7KYjsE/l9+BGUqvvA0NTuMGZwXRNDPNREvvzZ793rfXIz3dNwprmYJJqa6iC26 ASSnh4kJxUlA7gEpY7SpTCDIWc14UOjSUIryTsopgWqqlahdY7ndCq9h0p6AzxXPdOkp hSsfX7RorZEPjYp5W9DvP3cFIwHAzHiRNXewYjX0Ny9yg32zuhVa83i7dffg3hU7u110 L1/+h67Rp6zk3FrI9fwUL/h9wTlfFQuu34MHNPHss15QXx49gTrWfVoaRn0MY0HoYbn8 5dPeET8MB1MCWRXM2hEok8KZf3rTR5WZKZqLzpGj5waFmdqoueRV3ms8+u1tL8hvz5cm NdMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777977449; x=1778582249; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0+VNM6tTV/nZT8ORsfGVd8wLoMc82NM31B45S3duO08=; b=FZMDsIj7cD5vNcFGcHgB0rTbT2qk1+Zo7q+2UJM64hYURZ+C4LivVTpAeiWIx/lS7O bdP8LFRVEN0XzC9EEIWCHi6oqAVxinv8z7J/ExfPbeE0pwZlMZZSNDGhf0dnNZridyCm 83guNrsGo2fQg5ICg6yIDOoX67Fcx6wK8tMfiTl//FOXz7H0D9jB0ykQwr0Pjnti3uLd bV47dt5ILyPEbPAqk9rJOqyGb4nv8WJBvxC7r4O/LsbSBZNmmUFS5+63nocXt/HRgXTg wcyoratqkif1+dRR1FYjV5AI6wqTPsB1gU/CQ+6ghOf3fUgqavuTZTZTFv6c9FWI1+LP VxoQ== X-Forwarded-Encrypted: i=1; AFNElJ89xKhGC/uLau5HLISuS49Z6PCCZptzfStgNcjq9WdNAInbioneGS0bf49sL40lfLPMzjYeZbelSqgY@nongnu.org X-Gm-Message-State: AOJu0YzVwBF1v1lbj5tSVS8bycqlD5zome3HLVaEWbaNvgP8799zz86L X6WZ+uAm7roTC0lhNEAhyXu7umTOL+WsU+nJd2qFY8I8lWwDuYJqCKR+Fz6Ibq96n3Q= X-Gm-Gg: AeBDies9wFswjEPwPdb9dlPhs2IiotQt313FnLQHAsKLKVfS8y3v0BwFDUbNJ8Fx+Z2 VjAeC/rFV0/IMFwJhSDsE4yASwiQUnyB4jyN6dqJGQi96YsEQT4SMDIs7uzXg7Qly4ALuL5pvBv FA8Q3BNSwRTb0oDCSMFaTk8Lf6ny2bLnSxRarGdNmtH6CHVTiBu++e17Ye7QMP+Xv1HsvWf8ZIe /PT9syO5/s62Xf3tMqy6sCUrdoDxVvca3O5v1WC+u0wwGQK8MVAByhCga+0aQ8NqhCSoEwKot1F 81SFk6lcW4I2e8RCFT98/6z7kSQrV3rv5JllNXNaL1ECsB4jodIxnH8eM//UN0F/f6QUAp7deVt j6setIro0lqfWYvdBcCFWIB1aMraYIqBi8I/mKhe0aLfP59APqGaYfYKiZB2860XiB5JjNCTXgp IgXujKaoUxbRIRv8RfchF4FJMt8xNaNT8KZwcPmR64Au+QXIvyYcuz/XztdclzSgk925WlwPKHB 7BVFqjosPNZiU0KpnmuYkrojE2SvNlyZU+eFboTE7iffUQrC0yl X-Received: by 2002:a05:600c:83c3:b0:488:c078:bfda with SMTP id 5b1f17b1804b1-48a986713e7mr228011395e9.26.1777977448721; Tue, 05 May 2026 03:37:28 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org Subject: [PATCH] target/arm: Report IL=0 for Thumb 16-bit BKPT insn Date: Tue, 5 May 2026 11:37:26 +0100 Message-ID: <20260505103726.419195-1-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1777977500122154100 Content-Type: text/plain; charset="utf-8" The Thumb BKPT insn is 16-bit, and the ESR_ELx syndrome register definition requires that we set the IL bit to 0 for this, and 1 for the 32-bit A32 and A64 BKPT/BRK. We used to do this correctly, but accidentally lost it in the conversion to decodetree, because we converted the A32 BKPT first, and then when we converted the T16 BKPT we forgot that trans_BKPT() was unconditionally setting IL=3D1. Pass the right value for syn_aa32_bkpt()'s is_16bit argument. Cc: qemu-stable@nongnu.org Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3474 Fixes: 43f7e42c7d515f ("target/arm: Convert T16, Miscellaneous 16-bit instr= uctions") Signed-off-by: Peter Maydell Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/tcg/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/tcg/translate.c b/target/arm/tcg/translate.c index ce427c5a3c..7f76a57653 100644 --- a/target/arm/tcg/translate.c +++ b/target/arm/tcg/translate.c @@ -3580,7 +3580,7 @@ static bool trans_BKPT(DisasContext *s, arg_BKPT *a) (a->imm =3D=3D 0xab)) { gen_exception_internal_insn(s, EXCP_SEMIHOST); } else { - gen_exception_bkpt_insn(s, syn_aa32_bkpt(a->imm, false)); + gen_exception_bkpt_insn(s, syn_aa32_bkpt(a->imm, s->thumb)); } return true; } --=20 2.43.0