From nobody Tue May 26 00:49:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777930549; cv=none; d=zohomail.com; s=zohoarc; b=nHbeP/7fPGzrWnOJNTxoJAKA+h+yAc/Gc70aGq1803195IhEUI4IViwCDc++cZjuNDHgo8m6veYoAVwJ7oZXK6T4aPl7sWlDHwAHxLIhWOUQF80hKBsdb+uaZ36INuKSQ+D4GHFNd6xfoOAv4KVz8X6uTh3Tw1kOcElfKMn9WVI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777930549; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=KpNxqqbCaE16ObkPQbaDANH59VVhWzGebQaPpgbq4Ww=; b=LXfhF3iIIUxBUEXqoigj4oujxmSlDP0LUCbsVYGtZ3s3HYxCs8KNj8Z6CVDNemqT8Q2uCYPGbo+um6r+ioCIF0zBZ3UaTWNltEdb/+HudLS+7iNQKWizJOJjuMCicgJYJI8M53z5VNTT4S0aDAwnu22y3zweiwClUSmmIeCQb5c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777930549532158.34391320639168; Mon, 4 May 2026 14:35:49 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wK0w5-0006EQ-84; Mon, 04 May 2026 17:34:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wK0w4-0006Dx-0p for qemu-devel@nongnu.org; Mon, 04 May 2026 17:34:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wK0w1-0003UQ-WF for qemu-devel@nongnu.org; Mon, 04 May 2026 17:34:39 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-147-QG-s2IS6NDStU2t1pv1Etw-1; Mon, 04 May 2026 17:34:33 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AEBC51956095; Mon, 4 May 2026 21:34:30 +0000 (UTC) Received: from corto.redhat.com (unknown [10.44.49.208]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 322601944CED; Mon, 4 May 2026 21:34:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777930476; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KpNxqqbCaE16ObkPQbaDANH59VVhWzGebQaPpgbq4Ww=; b=b0YzT1ILp22FVgByNrk/fMKrqxVt18YCpkPfzWC6jMeXTJPADR3A3aPef5KqxETHQ+keS8 RVApkCjSzL5jgcESvMDOjuWZ3x7spE0QQQ9dKUUX3d4USm1WPcaswX/YHKr1XhQCbgqXXd f5xf2kxC8Yv6K2vFHl7+R2guU3GCOCc= X-MC-Unique: QG-s2IS6NDStU2t1pv1Etw-1 X-Mimecast-MFC-AGG-ID: QG-s2IS6NDStU2t1pv1Etw_1777930471 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-devel@nongnu.org, qemu-arm@nongnu.org Cc: Peter Maydell , Steven Lee , Troy Lee , Jamin Lin , Kane Chen , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Katherine Leaver , qemu-stable@nongnu.org Subject: [PATCH 1/2] aspeed/hace: Fix out-of-bounds read in has_padding() Date: Mon, 4 May 2026 23:34:20 +0200 Message-ID: <20260504213421.710035-2-clg@redhat.com> In-Reply-To: <20260504213421.710035-1-clg@redhat.com> References: <20260504213421.710035-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777930550122158500 The has_padding() function reads the last 8 bytes of a DMA buffer without validating req_len. req_len is guest-controlled (via R_HASH_SRC_LEN register or scatter-gather entries) and values less than 8 cause integer underflow. This can result in an out-of-bounds read of QEMU process memory. Add a check to ensure req_len >=3D 8 before accessing the buffer. Reported-by: Katherine Leaver Cc: qemu-stable@nongnu.org Fixes: 5cd7d8564a8b ("aspeed/hace: Support AST2600 HACE") Signed-off-by: C=C3=A9dric Le Goater --- hw/misc/aspeed_hace.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/hw/misc/aspeed_hace.c b/hw/misc/aspeed_hace.c index 23e8030cd966..ef698b3ecb72 100644 --- a/hw/misc/aspeed_hace.c +++ b/hw/misc/aspeed_hace.c @@ -154,6 +154,14 @@ static bool has_padding(AspeedHACEState *s, struct iov= ec *iov, hwaddr req_len, uint32_t *total_msg_len, uint32_t *pad_offset) { + /* Need at least 8 bytes to read the total message length field */ + if (req_len < 8) { + qemu_log_mask(LOG_GUEST_ERROR, + "%s: invalid request length=3D0x%" HWADDR_PRIx "\n", + __func__, req_len); + return false; + } + *total_msg_len =3D (uint32_t)(ldq_be_p(iov->iov_base + req_len - 8) / = 8); /* * SG_LIST_LEN_LAST asserted in the request length doesn't mean it is = the --=20 2.54.0 From nobody Tue May 26 00:49:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777930540; cv=none; d=zohomail.com; s=zohoarc; b=nT7bf6j8S9ai+zfFyAhjR7sGZZnY5T+No9AHs2hr1YpblA4t3Hjyv6ixN+ECExu/RKy38xdQwRRghTt8vGYrlx1ViFkD/hbGX/Re6k4Ptec4LdjeMlhnUrwfrYt0lOWsbr9XjydFthYkGToTOqdDPIkUzVexSxbnIhPSen9mRQU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777930540; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=s2z7DVl8CCKbYIE4KyajwhLcUk4shKNW2AynvfwhNHY=; b=lkJLkYUjPHyzInsOx0WusiliuhOaN6tNHlwnn9HT9RiqFMZRJ0okORpUa+uUik/eKpdPzgAC8kFZ+jHGwq65b9jdIMOL41siU8oKIgG36+gNtt3SSFuPUTUPYAvDfwhTbEkuIQsh20CLH18Gh5Vj9XCo0lJ8ydaB840BPs9XE2E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777930540795453.90832883625524; Mon, 4 May 2026 14:35:40 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wK0w6-0006FA-NZ; Mon, 04 May 2026 17:34:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wK0w5-0006Es-QA for qemu-devel@nongnu.org; Mon, 04 May 2026 17:34:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wK0w4-0003Xn-AJ for qemu-devel@nongnu.org; Mon, 04 May 2026 17:34:41 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-359-xgeizsITNj66w0IiGniUJg-1; Mon, 04 May 2026 17:34:36 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 41FEB1800366; Mon, 4 May 2026 21:34:34 +0000 (UTC) Received: from corto.redhat.com (unknown [10.44.49.208]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2A58B1944CED; Mon, 4 May 2026 21:34:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777930479; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s2z7DVl8CCKbYIE4KyajwhLcUk4shKNW2AynvfwhNHY=; b=I5l4yB0pAGx2yQ5qG4OiI9RnBZm4xDMdtMGRxy8AsGcyw8AtmHLK/RHNGQPejPPuS8LWDj qY2RgXBrmJM9xruTdnalAOPokuhEXqmZKRUj0Htcmp99R9icJowqP+NAe79jdcpbefc4m9 YU1Fi4rPc+o5ZGZ5BB147Xdyfxv9JtM= X-MC-Unique: xgeizsITNj66w0IiGniUJg-1 X-Mimecast-MFC-AGG-ID: xgeizsITNj66w0IiGniUJg_1777930474 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-devel@nongnu.org, qemu-arm@nongnu.org Cc: Peter Maydell , Steven Lee , Troy Lee , Jamin Lin , Kane Chen , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Katherine Leaver , qemu-stable@nongnu.org Subject: [PATCH 2/2] aspeed/hace: Prevent total_req_len overflow Date: Mon, 4 May 2026 23:34:21 +0200 Message-ID: <20260504213421.710035-3-clg@redhat.com> In-Reply-To: <20260504213421.710035-1-clg@redhat.com> References: <20260504213421.710035-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777930542479158500 In accumulate mode, total_req_len is incremented with plen (hwaddr) for each hash request. Repeated additions can overflow total_req_len (uint32_t) and potentially bypass validation checks in has_padding(). Add a helper function to detect overflow before incrementing total_req_len and reject the request if overflow would occur. Reported-by: Katherine Leaver Cc: qemu-stable@nongnu.org Fixes: 5cd7d8564a8b ("aspeed/hace: Support AST2600 HACE") Signed-off-by: C=C3=A9dric Le Goater --- hw/misc/aspeed_hace.c | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/hw/misc/aspeed_hace.c b/hw/misc/aspeed_hace.c index ef698b3ecb72..0504d61cbf0a 100644 --- a/hw/misc/aspeed_hace.c +++ b/hw/misc/aspeed_hace.c @@ -205,6 +205,19 @@ static uint64_t hash_get_source_addr(AspeedHACEState *= s) return src_addr; } =20 +static bool hash_accumulate_len(AspeedHACEState *s, hwaddr plen) +{ + if (plen > UINT32_MAX - s->total_req_len) { + qemu_log_mask(LOG_GUEST_ERROR, + "%s: total_req_len overflow, current=3D0x%x, adding= =3D0x%" + HWADDR_PRIx "\n", __func__, s->total_req_len, plen); + return false; + } + + s->total_req_len +=3D plen; + return true; +} + static int hash_prepare_direct_iov(AspeedHACEState *s, struct iovec *iov, bool acc_mode, bool *acc_final_request) { @@ -232,7 +245,9 @@ static int hash_prepare_direct_iov(AspeedHACEState *s, = struct iovec *iov, iov_idx =3D 1; =20 if (acc_mode) { - s->total_req_len +=3D plen; + if (!hash_accumulate_len(s, plen)) { + return -1; + } =20 if (has_padding(s, &iov[0], plen, &total_msg_len, &pad_offset)) { @@ -299,7 +314,9 @@ static int hash_prepare_sg_iov(AspeedHACEState *s, stru= ct iovec *iov, =20 iov[iov_idx].iov_base =3D haddr; if (acc_mode) { - s->total_req_len +=3D plen; + if (!hash_accumulate_len(s, plen)) { + return -1; + } =20 if (has_padding(s, &iov[iov_idx], plen, &total_msg_len, &pad_offset)) { --=20 2.54.0