From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894560; cv=none; d=zohomail.com; s=zohoarc; b=K754F+loIYB/jRWQcTDV9bi84LZ3PEL+GDc9Ko3an6ebkQIoPq7h0TMo8e71on0N/1IAgrv8K6+/DrdNuJVaYQONxzlyVFZ0t+og2YwUjqNEs/WqXNwDO8BXlGw3AQHLv9EWda7ctG4x0FMvQRrB7ntf3VJNDkN0j3+ioIAmm/0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894560; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=3LnmPj2a/SZ2VXKAkFID+9JaaVLfJOAgO0sBcWpZJog=; b=OWuENPY15xqGy2AZT+jrcTfIfAcfi7ZmpQn7Z3RKog4fZq4VMgPd/wyGweVxgS03IxIrilYFE28nSr9tUa0TaK2xCHQlumv8u7DwAyxrOdun/8PY9Lx7i2ZnkrTQ58gqfTxXuNV6XcZqJ6/CIy4pAbh6U2wX3cLUb56kcyBactk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894560887762.1047353156329; Mon, 4 May 2026 04:36:00 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJraC-0007Uq-FP; Mon, 04 May 2026 07:35:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJraA-0007UL-IJ for qemu-devel@nongnu.org; Mon, 04 May 2026 07:35:26 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJra8-0000m5-S8 for qemu-devel@nongnu.org; Mon, 04 May 2026 07:35:26 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-280-xRcAc9CBOECCGvfAeZKgsg-1; Mon, 04 May 2026 07:35:22 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 77640195608B for ; Mon, 4 May 2026 11:35:21 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 77CF71800347; Mon, 4 May 2026 11:35:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3LnmPj2a/SZ2VXKAkFID+9JaaVLfJOAgO0sBcWpZJog=; b=cuPyDpwqJBMWit5zpLWWebI6c2gcTL6jHuMknwwRgT3qkuXW7t4VnKGIKsHgRwJ3X4+eMo HV3Ft7aO5jZ0QMPic0vJfvqn5qb0E9nzN4vgLd317GHoDF3E4MTXLUy/ORWVQCgMuxcTXw mL9FV9pa6NrQBAQwUAL90ld4NjoxqWI= X-MC-Unique: xRcAc9CBOECCGvfAeZKgsg-1 X-Mimecast-MFC-AGG-ID: xRcAc9CBOECCGvfAeZKgsg_1777894521 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:34:49 +0400 Subject: [PATCH v2 01/46] hw/pci: handle missing bus in prop_pci_busnr_get MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-1-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1270; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=TNcMmHQOk/Cv/pMBfbzxmrySqL4hQAd92bEHD4UL6Q0=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRr//8ubAy8v2Oj1r0e7dXjo+CRyChMgnZ/0 A1+EgTV1nSJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEawAKCRDa6OEJdZac 5VcCD/9gGFYwE91xP9RdLb6fSOV65ujihzeQ0i1npwXmXc86tDhxFSXcMa/JNFrvBB43HbpHmZW ulj5WQFBerU7dJ9bx4kMNrz658dLKsIVOz96CF4vzBY35J5q0PukFG5FpeJEnPcclsNn3+ty47t YjIGnhx1liyTj8+p6rldYalAFC1FOM6Z52QKcopN1XNQe+Rdc7juxh/Nz7RLCzUwMg/9taof+/9 8Idmx0lPzuoh1l4D3IqB0LN1fm8ar450dDKJZz9PQcolWMHq+YZOk8/qG+COOvcD8bz2WgyjUsU YNwkfJ9rJYhfZwPi5eQR8KeCpX5nMSlASvciFtdc0HuaWZQw8yuL1sMDt/D1r/YBeJ+SqX4CVya Qlm2Bj/ccmmgT1eJMFUkVC1viBYz9R57r3+OkTjZAbROEoibo91BgS04j+69YPjXeGffH2UPkW6 0zvqR8JtABLSQOU9jU5A03ceQfx09ab3Rm3mlzUiIPbK7rxm1R2G19GYfjxRUZjtssq3NdEozVn syYGoahObkk7Cw/CDEgS6xNUHyGr68HKwR5jK4BkEBePAc//ZX2apFhfcLXjAjZ2nnE1XCiT52c BGdck9m9qGr4TzHUxQCn61OShf6UUJN/DQAscQXCsgbPC7bUN4wyvUvZV4IPP96xXO/3rIBlj+E pegFo4nZSU8x6TQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894562327158500 When called on an unrealized device (e.g. from qmp_qom_list_properties), pci_get_bus() returns NULL since the device has no parent bus. Check for this to avoid a NULL dereference in pci_bus_num(). Fixes: df9ac7254fd9 ("hw/pci: Add a busnr property to pci_props and use for= acpi/gi") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/pci/pci.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index a0dbb81fd90..bf13cabd174 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -64,10 +64,17 @@ static void pcibus_reset_hold(Object *obj, ResetType ty= pe); static bool pcie_has_upstream_port(PCIDevice *dev); =20 static void prop_pci_busnr_get(Object *obj, Visitor *v, const char *name, - void *opaque, Error **errp) + void *opaque, Error **errp) { - uint8_t busnr =3D pci_dev_bus_num(PCI_DEVICE(obj)); + PCIDevice *dev =3D PCI_DEVICE(obj); + PCIBus *bus =3D pci_get_bus(dev); + uint8_t busnr; =20 + if (!bus) { + error_setg(errp, "device not attached to a PCI bus"); + return; + } + busnr =3D pci_bus_num(bus); visit_type_uint8(v, name, &busnr, errp); } =20 --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894560; cv=none; d=zohomail.com; s=zohoarc; b=nIB04S2TxdqHhYDted1WShNUdrPE+8xqMxttpsxirVMGwImrTgD2ml0rhSE9qgCMLL6Y/MA/UOGwkgllX6ty+U0WVKwHq2jAf37lQnPdVRMuOwYYBETRzCR6MHEdOB2Lk5WGiJYBZ2LOxo61fxX1exvU8KkLundwLyrJDhVstnI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894560; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=iO87o/0YYcEWxdVsD3TnBacBB5QSuCWhHLZQkTvzHEc=; b=WMRmQhvd8JDXVfZLyavpfc+UcOkpDtTEbiVXxkDvyKRnZEC8GECAhD+3SNwi7DDLGe02zr18oJYyJ0kiCkKQUq+xssZVCyXA56Mn4BHOirrWk7UzvY5wUSHbX+0Fym4JyqLZ3H5iQWouu4IGZisiz29+Wwxx79xLcF9udxFsk8w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894560416326.70013428354844; Mon, 4 May 2026 04:36:00 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJraH-0007Vb-Sl; Mon, 04 May 2026 07:35:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJraG-0007VF-6Y for qemu-devel@nongnu.org; Mon, 04 May 2026 07:35:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJraE-0000mW-K7 for qemu-devel@nongnu.org; Mon, 04 May 2026 07:35:31 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-353-LF_L3OPCMDi3m07flGrlDw-1; Mon, 04 May 2026 07:35:27 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2D18418004AD for ; Mon, 4 May 2026 11:35:27 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D76311955D84; Mon, 4 May 2026 11:35:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iO87o/0YYcEWxdVsD3TnBacBB5QSuCWhHLZQkTvzHEc=; b=e62bol9j2kbUVOxGSNL30w5xgVHIQaB1gEzSlPh2vRy/w+oBiGaDB1GqKq8Mn0pzTA0bYm TbxZ0GlB+fO77SyJ8mI/hzd1iQmfC4enzr+Y37XF0rdkyeMCUvRmvkuqfyrGcN/UyS4IZb zeJzGUHjMpi9KtHOmxdlFV+V43CPoXc= X-MC-Unique: LF_L3OPCMDi3m07flGrlDw-1 X-Mimecast-MFC-AGG-ID: LF_L3OPCMDi3m07flGrlDw_1777894527 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:34:50 +0400 Subject: [PATCH v2 02/46] chardev/char-socket: handle NULL addr in char_socket_get_addr MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-2-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=807; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=ec79R6dwgSUru8iZAGVoGIdElFOC+Hue6wBEH561cpo=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRrp5dZG6laMv5/TNbO9JcdzAICs28J0fUZR I5MBj3QHtGJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEawAKCRDa6OEJdZac 5VrwEACLlYtxn40bBXyv/V2Z4ofbnVwaij0izQ2Y0cMi9QVZYaG1g80HttN/R5lsZ8igFpVevV9 5r7fQrL67GGz7q3PobcbjTvAA1IacujG1+LTfUoH+w1kuXyB0uTXnft2z8+tc78PZwgc5Z+cEix DuVzqZ0z8GsrvrIfcmoKNwEaFBKa5nMeTw0FPlD0/6OaWIOvzlpYGdIoTHcQCtTqNTtrZe9I8o9 h1Hc6zP/u+2x3GiwQaefcy85pETtwLzSsPjCJdrf2t1unZxadu83TYVu8P1WHgiwoOMDYccxjkk PbwiFJQwFHSJ+mBuIu93Z943Jm/L6B07nN0yaL6fT7LQDQUXj/6XUnnsx/A0NHLlWur5uO6DwVn yk3KfoVI9yw6Zo0GXmz9XyG1D8kYNcEQSfpESTKjFosO93dr+9fREEYCqw87P72IJmOONqJvNJP dzJWn7CYiA0kueS2RTaNnn0vRi/sZ6JnDrRzZzTHuYm+xt/XLIcwzRJSMM/98P0/FVhV6eRXp8m OtkyQPDlgaQnnrYOWGDB4CcM75v9OU1iFN6/l14SNxJJtgw52VgimzA3yZTFF/H34mmH8zE1cXE MojndqGq+mB7c30ZhQluRHllN3yjNhgi2lc3y8C7bkHcCAnp5xJPRs/F3ptA364JW2fIi6TkQwQ B8PZ5UPKVpN0ZOg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894563563154100 When called on an unrealized chardev (e.g. from qmp_qom_list_properties), s->addr is NULL. Return an error instead of assert(). Fixes: 123676e9894f ("char-socket: add 'addr' property") Signed-off-by: Marc-Andr=C3=A9 Lureau --- chardev/char-socket.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/chardev/char-socket.c b/chardev/char-socket.c index e064b105c50..b629575fcf8 100644 --- a/chardev/char-socket.c +++ b/chardev/char-socket.c @@ -1529,6 +1529,10 @@ char_socket_get_addr(Object *obj, Visitor *v, const = char *name, { SocketChardev *s =3D SOCKET_CHARDEV(obj); =20 + if (!s->addr) { + error_setg(errp, "socket not connected"); + return; + } visit_type_SocketAddress(v, name, &s->addr, errp); } =20 --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894646; cv=none; d=zohomail.com; s=zohoarc; b=X6b2b9499ZSVEDNiRLg7ohTZsQiUFttxvmj9BFZUPZUmShNCSfcE7eStMGtT7heH7tVBcTh92jc7kZZwl8rUAtXeGiyJHRaqsmn+wWmkogRPBukqSlg7h6SmndQ0c+CacNJObq6JVgxa6HhIViIQhU9D02uYKhYKFv+tVpCe8Jg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894646; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1bgLA9Zp+Jow51t/607ELa0KrzfqLyYWWcupN4GZiYQ=; b=aOiABPPa2bcJsXa1O7L7kBVxtaO2Jr2Ij0TYItz7DKQ80qrb55cFYWYW4ChU/Ry63+FNh0C/j0mOutpomYHWFZRii7HonXjZKcSdHUoT3f7trmA/6B6g3zljItmYoDRxLczpDeMLro/056Owoc8+Les2QdXxYJJ4SQSp/sXJGXA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894646515786.8549809478558; Mon, 4 May 2026 04:37:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJraM-0007W4-Qo; Mon, 04 May 2026 07:35:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJraK-0007Vi-Uo for qemu-devel@nongnu.org; Mon, 04 May 2026 07:35:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJraJ-0000n2-HW for qemu-devel@nongnu.org; Mon, 04 May 2026 07:35:36 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-443-PbwEgQtUPgqRxd4yaUU3sg-1; Mon, 04 May 2026 07:35:33 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AD3051956094 for ; Mon, 4 May 2026 11:35:32 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9CC191955D84; Mon, 4 May 2026 11:35:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894534; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1bgLA9Zp+Jow51t/607ELa0KrzfqLyYWWcupN4GZiYQ=; b=MhUWjgQ67+duDdvxRfRjraAn4vm4wLtemQDf4uAzhNXgfrk7tuJdBfwLIeBgEBtlXUIIat c1SHQkeI9OH2V6BpPeOF8zHIB6A7be66INg1pz416G36G5HghKYQn6gZp23xW/VQtjdhZy 5Hr1UxYtqoD971+h63Gxx/s/gAY/WNU= X-MC-Unique: PbwEgQtUPgqRxd4yaUU3sg-1 X-Mimecast-MFC-AGG-ID: PbwEgQtUPgqRxd4yaUU3sg_1777894533 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:34:51 +0400 Subject: [PATCH v2 03/46] hw/pci-bridge: handle missing parent in prop_pxb_uid_get MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-3-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1195; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=mzt68/PqLMn279UizfyFsnOjTDYKE+7gRPi+R9njaM4=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRsckuSlnRVxucpGu4M0o1VGTtJdQeSBN24i 0JKwN1ohfOJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbAAKCRDa6OEJdZac 5eaGEACcv47TTEn0QNkcSwsvf0I7AhjqGNBqwnrSqQpQa6H946t2+MD7BJ+v5vpxJYsS+f8l7JR Ip7W7cxPJQyqW4k3Xx26e2f6oeDeL5bbopzf7HJgfHQP1IitVsTOZFWimOvMTc5rKqSdd527X0n KGw9lBj+9ny2DNElw0Qaj8zAWeWUCSwvFuS/Imkivl3FpJPHrhyL8uNLDdbk2NPZeNmUu5HHq3l jpFRBSESPulgrKPhNeNuSN6+EI5VIWa7Ycp05tmCDjh1OO13Y4Q87pJH1bHteQbsp2pQ/O5F6iR /Jn+TeGIFSaK6ka8ZILlw0B4dVAMuENabn7vY2unPXMVPGm8mHR9M8cxHzwJG9/WBbwOUeKwTW5 ejXD3hUh+MKbm8wMRIissX6LIJ8DAmVbYXjEpCPY2LBDRykFf9VO0gt4AGTZ+ft1ifCMEe/u4eV YGYF/ag+uUQlqqME6lGimHSN0NSXegxdyKybGtCkNX+EdNooPQE7LPacXIjAgPzUgewrMvIRdHj IrZauSvO99khd5vR+wgaxMUP3V0i3VXE1VvPzKDdmd5/JLU24SNSrdza6eNKEviAw0TSW1oCyrB As4yo5KckwFGH5/XEsUilQ3huA7t41W+3N7X1KuaS8pnybYyCj/Lw8mS+hUPvn1bjSIH4DGgBV9 I/aUwA1g5O/HUKA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894648157154100 When called on an unrealized pxb bus (e.g. from qmp_qom_list_properties), bus->parent_dev is NULL. The pxb_bus_num() callback dereferences it unconditionally. Check for this to avoid a NULL dereference. Fixes: 97b9cb066e5f ("hw/pci-bridge: Add acpi_uid property to TYPE_PXB_BUS") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/pci-bridge/pci_expander_bridge.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/pci-bridge/pci_expander_bridge.c b/hw/pci-bridge/pci_expand= er_bridge.c index 11623a5666f..40ffbc4e082 100644 --- a/hw/pci-bridge/pci_expander_bridge.c +++ b/hw/pci-bridge/pci_expander_bridge.c @@ -85,8 +85,14 @@ static uint16_t pxb_bus_numa_node(PCIBus *bus) static void prop_pxb_uid_get(Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) { - uint32_t uid =3D pci_bus_num(PCI_BUS(obj)); + PCIBus *bus =3D PCI_BUS(obj); + uint32_t uid; =20 + if (!bus->parent_dev) { + error_setg(errp, "bus not attached to a device"); + return; + } + uid =3D pci_bus_num(bus); visit_type_uint32(v, name, &uid, errp); } =20 --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894560; cv=none; d=zohomail.com; s=zohoarc; b=KnuK4YWh65ULiesubj52eShEaJ5oeTTgCkeuIx4/COO5tk9vO6mVhE6vgHUnRdpXX4/TN7VAi3HaMX5znIZz8YPUeoIiPM4lQ8M3/UFjdZHGNI7fzBz7fjBhBIgNT5WWdpn6jD2vDD7zmvAYIjgtDmJyHdLA7Ssts26YHXsrNTE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894560; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=AwxIXFRqNOFwSXEkTBL3lUfI3qRxviZUG2ZP9ptJKDg=; b=dvwyKcb9Zn1xrPYsTXKr0IwD/wI1g5olwR23kuhTLWPZe0bk5f4JIQY+LVmdfcKNSLLgrbo8QQKtMQXYvfkOmm/6Ka75Te+A7jM2aJg4phgDHaSvfRp3dbfgpwVs4zT+aSjkR+I5N0vHyvWuPUA2fuIy8kbieAyntj91GIC9u/o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894560908701.4099575934268; Mon, 4 May 2026 04:36:00 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJraU-0007Wb-8R; Mon, 04 May 2026 07:35:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJraT-0007WT-1M for qemu-devel@nongnu.org; Mon, 04 May 2026 07:35:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJraR-0000nP-Dg for qemu-devel@nongnu.org; Mon, 04 May 2026 07:35:44 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-457-CUP8HtSzOquIerD66Dd8vA-1; Mon, 04 May 2026 07:35:39 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6D9761956088 for ; Mon, 4 May 2026 11:35:38 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2372F1800480; Mon, 4 May 2026 11:35:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894542; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AwxIXFRqNOFwSXEkTBL3lUfI3qRxviZUG2ZP9ptJKDg=; b=JOXTFxOQODdG82ja4wEc1S0LBCsxuh8+ASUozoChvw9ns5HSWJjt0OBkha54LpC8G4v1BA 85JjpOtrEfuRLdnIMrnIUQ6U+MssPu/BQkg63whxWaLIa2ZbDJNtwCe4XcSssrY181AqE/ gkPdTSbl03G5aL/qEkfN6Wk8EgXmmfg= X-MC-Unique: CUP8HtSzOquIerD66Dd8vA-1 X-Mimecast-MFC-AGG-ID: CUP8HtSzOquIerD66Dd8vA_1777894538 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:34:52 +0400 Subject: [PATCH v2 04/46] hw/pci-host/i440fx: handle NULL bus in pci-hole64 getters MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-4-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1937; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=Vp9y54qI7ZUxlsGcdaDjRbl1VRjgkXVwo0pQvUFYFlU=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRssfLPKs8rqp0fsRHkHmnUx86WnnRfRwN9f bXOVqUaXyKJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbAAKCRDa6OEJdZac 5YYCD/9Q/zcoQSSHK4vK62Q3/QmID+/EXvrcdFy6HiQpHPyh7uxwT0UWNC2FuZewCnd6ODd6UWd EnJxmhs2wX47UOnp82q3UBDQwQUZuhEp7nz390K9c/PaC1Bq4nvlpgtfHIY9WUneWPkEGtaH2G+ CIB9YvRqGzPwmIPwNeJlSDeyoieytoXnMiVI5ASVk42HHWb9l8eX4ysxdOtt1N8JIsi6OganlTm fPSaS/gI2N1IcTaiXIs1ya8lGB2J9rvfQ7m7rf9LoYCXiBQMd4do8zcf7xsZ2nq4+cAG0s54q76 TEB1ltEXWU9n2gbpakZs2YLahoSenR3QrfCspA6iPu2aC2JcWiFDjwUQwGYizx32VSb375RNnHT vhyOArvBVjTwYjSys/vxUWxfs/OMhW2Am4bQ4WnMqZk9Fgq8cVHCWBxf7egTdhbzUGs7vVorEE2 ZpAzNNVsNe/fqJGwSScK8hxG25KTSgeaTqrbs9BfdPpZEMrDzGzsU8eMrxCrMadSu83M3coOYrr W+36IPf1EF0rfarT4EZTXdKtrPS2QPnN+5sj6/1bnDJR4Z3kXoG+gv1F2kRsSzszQ0SkuRXfltl 1Cz3BbpRP/iXuhQd3lNP0bH/wH/0wWenIu8Pes+lr5n5f46bwzQDX22DTJw+1eVYRQqG9DeOe3m N+6Y/rrzNHQYgQg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894562352158500 When called on an unrealized i440FX host bridge (e.g. from qmp_qom_list_properties), h->bus is NULL since the root bus is only created during realize. Guard against this in both pci_hole64_start and pci_hole64_end getters, reporting an error. Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/pci-host/i440fx.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/i440fx.c b/hw/pci-host/i440fx.c index e7d638b296c..c1982f7962a 100644 --- a/hw/pci-host/i440fx.c +++ b/hw/pci-host/i440fx.c @@ -189,8 +189,14 @@ static void i440fx_pcihost_get_pci_hole64_start(Object= *obj, Visitor *v, const char *name, void *opaque, Error **errp) { - uint64_t hole64_start =3D i440fx_pcihost_get_pci_hole64_start_value(ob= j); + PCIHostState *h =3D PCI_HOST_BRIDGE(obj); + uint64_t hole64_start; =20 + if (!h->bus) { + error_setg(errp, "PCI host bridge not realized"); + return; + } + hole64_start =3D i440fx_pcihost_get_pci_hole64_start_value(obj); visit_type_uint64(v, name, &hole64_start, errp); } =20 @@ -206,10 +212,15 @@ static void i440fx_pcihost_get_pci_hole64_end(Object = *obj, Visitor *v, { PCIHostState *h =3D PCI_HOST_BRIDGE(obj); I440FXState *s =3D I440FX_PCI_HOST_BRIDGE(obj); - uint64_t hole64_start =3D i440fx_pcihost_get_pci_hole64_start_value(ob= j); + uint64_t hole64_start; Range w64; uint64_t value, hole64_end; =20 + if (!h->bus) { + error_setg(errp, "PCI host bridge not realized"); + return; + } + hole64_start =3D i440fx_pcihost_get_pci_hole64_start_value(obj); pci_bus_get_w64_range(h->bus, &w64); value =3D range_is_empty(&w64) ? 0 : range_upb(&w64) + 1; hole64_end =3D ROUND_UP(hole64_start + s->pci_hole64_size, 1ULL << 30); --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894614; cv=none; d=zohomail.com; s=zohoarc; b=BDHmhTya+4DfehLU8PJt7HSNLg4+eHpPtwgbHchJpgG35PHMO77NgGCiOp7r4GyvDwqXxBODMAvB14c3jLV5NoyhN6C4M2baJ8SAR3MC/MgDrRv7hvKUE7lQNIFgs/VsBrI5GiwO7Jcpc2grjV3mHTMn8e4HDTxsQgQlg3nRbf4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894614; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=CRg2XEz7g/q9Y9vnBcCYZpcSu3GsBjF6YOxJNwlUUiA=; b=Rb51Euo2Szp4T+STdw6y3ZT5PYpKTLmJrPYAXTlxO68bw8ic4sWYH8EoOeSvnqy4JEsdO4rs0s91gU33/uMj0/SuIdKk7NLpUpe1NCxNgWHfMPNG5wWNd4UCVb82SeqIHT9gl2aP3k92V54rzVvTQJZpIsfqmBsu8v52Ff+KZjk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17778946145061019.6383069418029; Mon, 4 May 2026 04:36:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJraY-0007Y2-Ko; Mon, 04 May 2026 07:35:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJraX-0007XT-TP for qemu-devel@nongnu.org; Mon, 04 May 2026 07:35:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJraW-0000ny-Kd for qemu-devel@nongnu.org; Mon, 04 May 2026 07:35:49 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-552-VbhkPFRcMu2o00hZ1s_NJg-1; Mon, 04 May 2026 07:35:44 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EC2C4195608F for ; Mon, 4 May 2026 11:35:43 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A24ED1800347; Mon, 4 May 2026 11:35:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894547; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CRg2XEz7g/q9Y9vnBcCYZpcSu3GsBjF6YOxJNwlUUiA=; b=adKFshqNToisbAbMGvgAiTxgCOIPJ4PbZbhbUM4tH7C69Ys36UpFMr0aG4UelWogAB5hny oRsFvQPfh2pYoBxpNJ6ab79YuqAyJiLL4XUeT/by8eHcb+6s03njmBx+8MQ5U/BFAPVWLM gQQpMV9bHdVpQz8fDeKVU2cMTB+G5ms= X-MC-Unique: VbhkPFRcMu2o00hZ1s_NJg-1 X-Mimecast-MFC-AGG-ID: VbhkPFRcMu2o00hZ1s_NJg_1777894544 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:34:53 +0400 Subject: [PATCH v2 05/46] hw/pci-host/q35: handle NULL bus in pci-hole64 getters MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-5-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1851; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=/fxZ1GAbhmt7eqzcBY0CxzgAhlT5phl8zL1KjrOh2so=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRsFAEBdR6ZsQVMihkZL7NzJXuLVMS1oXf5G vcsV3wnZhaJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbAAKCRDa6OEJdZac 5R77EACX8Tc21I9tc2XKTsnuryt3fSgO5EZKCd3wBC52QaydTFdj/MDT39BiJeyaPOa4ZAC/I1C rxQwUjN9gsR21ZhOpR9OHSUAc0sYQIrxzZqzic0v6We2DPx713dUFwOl1TVyHoWZ1UvCiTM2jLh HhHUExuB+P3Xw18ASWxHQG7AT5HO3aakoQqLXhzdb5STf4I1CkzIKfE7/q64hye6DlgSCXAwdcP kv2gmilbvixcMQ2/w74A4DDalwL9cLmZkIErw+MAEIkcQG1/kD0xVFmbch+AeePnhByZiwg4lJt 4dy3YEIqo29bk+T5/bxKKTB6S6CAPGEQBTgzmrGAqocr/G9BO/Psthhbhf1usgNLvpkm4zXOAsx CInIfLGbZSgBvgDpUxR5n38nDOpJpuvpuPifF9vgXc5535ARc5OZXnydYuQ1VSb/rmLPAgHub40 4WPsURpdsFtYxohNDjT3/eDtZ1Xt9XIISBbPBnfxCrZP/rVJxcVtO2hlGpaKbzCosxrLSp0Tp8f of9Ia1Yk6Cy1Y4eKCorK0v8GZHQHWlS+7E/s6+4O87pJ+bh3W9yC9coOSADkiCSqsyvJOfVazWZ pTZMqipZLC6KLWJqcWwLIlpoKmKInrEL/uMBGMLhH6pdfxqJpWj3kvl/PtOK+gOigN5nmV7EyPk 9neNP5linPspiBg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894617676154100 When called on an unrealized Q35 host bridge (e.g. from qmp_qom_list_properties), h->bus is NULL since the root bus is only created during realize. Guard against this in both the pci_hole64_start and pci_hole64_end getters. Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/pci-host/q35.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c index e85e4227b37..355e81bfa20 100644 --- a/hw/pci-host/q35.c +++ b/hw/pci-host/q35.c @@ -132,8 +132,14 @@ static void q35_host_get_pci_hole64_start(Object *obj,= Visitor *v, const char *name, void *opaque, Error **errp) { - uint64_t hole64_start =3D q35_host_get_pci_hole64_start_value(obj); + PCIHostState *h =3D PCI_HOST_BRIDGE(obj); + uint64_t hole64_start; =20 + if (!h->bus) { + error_setg(errp, "PCI host bridge not realized"); + return; + } + hole64_start =3D q35_host_get_pci_hole64_start_value(obj); visit_type_uint64(v, name, &hole64_start, errp); } =20 @@ -149,10 +155,15 @@ static void q35_host_get_pci_hole64_end(Object *obj, = Visitor *v, { PCIHostState *h =3D PCI_HOST_BRIDGE(obj); Q35PCIHost *s =3D Q35_HOST_DEVICE(obj); - uint64_t hole64_start =3D q35_host_get_pci_hole64_start_value(obj); + uint64_t hole64_start; Range w64; uint64_t value, hole64_end; =20 + if (!h->bus) { + error_setg(errp, "PCI host bridge not realized"); + return; + } + hole64_start =3D q35_host_get_pci_hole64_start_value(obj); pci_bus_get_w64_range(h->bus, &w64); value =3D range_is_empty(&w64) ? 0 : range_upb(&w64) + 1; hole64_end =3D ROUND_UP(hole64_start + s->mch.pci_hole64_size, 1ULL <<= 30); --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894587; cv=none; d=zohomail.com; s=zohoarc; b=T7IR77axJhJFYMWNlQtWpQui0GQhR9MAZA1A7nFB3TF3lVuI0Zt6eGKdOMOoDTKS8hjhBOuCUVrSl/bImfG94pntmCjztMoJ4j79ULld4v1BMNtI0hP9UFK8Trwk1h7+6V/WYSjb5GQGZVguv3t5V97qZOY1tISBPhZy1gq2cd4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894587; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=twbR98+azl1FkvcOd/wUh0yeF3jLiWAv75fxdQ2s+E0=; b=dQQ8Rg/8LasM5qvCmiNfNMjhqZpG9jVLuHLdsykMd+anjSIJbFpsHz1CEyvhXnTNm63yOB/K6OkpSQOYj0mu2oqrRnekVSyCrC5DKcrgfOCGtxM1/JSJwtnd+e0cAbG33iIuMmjYkZn2AhV25s68hzhsbnjY5nJrtWMMStyplOQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894587543362.3189917699542; Mon, 4 May 2026 04:36:27 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrag-0007Za-2v; Mon, 04 May 2026 07:35:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrab-0007Z2-Pw for qemu-devel@nongnu.org; Mon, 04 May 2026 07:35:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJraa-0000oh-Ea for qemu-devel@nongnu.org; Mon, 04 May 2026 07:35:53 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-323-pXubjQhIOfuLO3lkGMdDaw-1; Mon, 04 May 2026 07:35:50 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 89B701956095; Mon, 4 May 2026 11:35:49 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3C36E30001A1; Mon, 4 May 2026 11:35:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894551; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=twbR98+azl1FkvcOd/wUh0yeF3jLiWAv75fxdQ2s+E0=; b=cJ5YWN/uv/NDTE902JpusIHpB86pGDVhr/IeqCf6noUxQnEhIBruKvOIvcoAGniCzFZKyF GhQ/11jkdRAm25zlDJD3wEqj9CHjEb2DDGqYJUIt6OFBjw+S+lCuDkNMoQXDu1AqVVNc3F TxGq94Czwx1n7WAe1WR+0T1I3w89NWE= X-MC-Unique: pXubjQhIOfuLO3lkGMdDaw-1 X-Mimecast-MFC-AGG-ID: pXubjQhIOfuLO3lkGMdDaw_1777894549 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:34:54 +0400 Subject: [PATCH v2 06/46] hw/remote: check visit return in vfu_object_set_socket MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-6-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Jagannathan Raman X-Developer-Signature: v=1; a=openpgp-sha256; l=1072; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=L2BEfE5R8VEhm76+lymFWMxq2H9P0VB/u9ntt4F1tss=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRsLkMZf8r3xhP0bfbc05+BzOHRnHn7t3ZXL FmhOPNUK2+JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbAAKCRDa6OEJdZac 5ZQRD/9Lo+ATGQUt2vIinMLlnZOTrsTKCzFMPUY77jtpgij+dOTK4WyVHbcPm79ZfOzQtRVHKwH 4ZxDjjfiFWYi2yBvdea80HLx8vuWEMumK6jYXSU962t95jANkcRGJKNAiYyGH8YkHOSRGRsWl7X 5yjAoX8N75x6kXob8u3j97zRv49V1T9b2B/F1C09Z+QPsNNg2CE1M5b0vzvqe+ynvOg5sjUtDa5 Dko6N8hlY7f2K2UL7dOi+jpyGjSHzeOGg3PIA7+QC/Aj29O+eQo2FwavDMMaUPiCj0v+3AKHiE/ j4QjN5DFwCUwYPA2b65+u66yY1q0r/lVAtb//ORabmUoyHtWg/vg9HF+ZjxDFZHdmShqUjHZ0QB jzU9BokxziTmfsD9fcTIkoBkhKwE0zmbIQrUcsU8HPGwMAreaWMPH1K9DBczcBPKU/tK+GCu9zS I4oKogWt4HvgI0zTmWBm5OFvouffr+lASENQMrSawmHZu3St3gxmae9lg7BjMOHIU9+4G4mVvP1 ZWH1ImuElCodouNQqQj7rS12jqyN2qaa9DjZjB3DJRJ0DZnNHphGaQLQxtXOSbxyO3VxvL5fvg1 R4v7WOqgni3+mcNzcvoYrJz3vVRDTUPHNG4SJzY7NLYa4pKPPM+WOw4IAF2QFzOHC6TU3xZ5EaC A67h4NLf98aFlJQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894588057158500 vfu_object_set_socket() dereferences o->socket without checking if visit_type_SocketAddress() succeeded. On failure, o->socket remains NULL, leading to a NULL dereference. Check the return value. Fixes: 8f9a9259d32c ("vfio-user: define vfio-user-server object") Reviewed-by: Jagannathan Raman Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/remote/vfio-user-obj.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/remote/vfio-user-obj.c b/hw/remote/vfio-user-obj.c index 12ecdab6dea..49bf5ecae0c 100644 --- a/hw/remote/vfio-user-obj.c +++ b/hw/remote/vfio-user-obj.c @@ -161,7 +161,9 @@ static void vfu_object_set_socket(Object *obj, Visitor = *v, const char *name, =20 o->socket =3D NULL; =20 - visit_type_SocketAddress(v, name, &o->socket, errp); + if (!visit_type_SocketAddress(v, name, &o->socket, errp)) { + return; + } =20 if (o->socket->type !=3D SOCKET_ADDRESS_TYPE_UNIX) { error_setg(errp, "vfu: Unsupported socket type - %s", --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894585; cv=none; d=zohomail.com; s=zohoarc; b=idCcLSqxeVxeECVWfMdrA9zQSrFfwvVIm3cFCB5NBHEAR37q/tsSXpca7GWrZdC2LSowlvEsftSqAthfMraWz1jbo/XObyYsgqVIdVYzoqkOVx/TDwJ77PlkeARKO5a3LqlXKAavtNNwOfwOnveHervzptys9mOxRQKXRfmgaDw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894585; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Vk6EPK8YN6D3adylJlyTRAZVvpCyDA9Qp3WjzVTfNyY=; b=e7YaGaaUgynsWCi59rJ4BCMXUSseyn+eDE12RvWJjRC4wPyJHf4NqrrPVMJ8Mtp8why/ttCMxH3njt306u/SUa2DI7q46o8wKaqhAu8jKyToy6F1vExPhLJtxf+pTjC/NHpG00P75v7PzdVNDr2HLXv35wh4hvf8kyFcIaHt4WA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894585031985.5958395087281; Mon, 4 May 2026 04:36:25 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJraj-0007lJ-Aj; Mon, 04 May 2026 07:36:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrai-0007h2-2l for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrag-0000qJ-Km for qemu-devel@nongnu.org; Mon, 04 May 2026 07:35:59 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-48-tRbopzuzN3enjrmC0QXifA-1; Mon, 04 May 2026 07:35:56 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 591851956071 for ; Mon, 4 May 2026 11:35:55 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D3B741800480; Mon, 4 May 2026 11:35:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894557; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vk6EPK8YN6D3adylJlyTRAZVvpCyDA9Qp3WjzVTfNyY=; b=DB7IM9bdQdWZAZCEUDrgSqUviHsXKUBGuVKswUUkUP9mL9AapUyJsAOpnJOOeGT4q1049i 7RDbOUp9+U1aNk8t4fFtCLVUETo857U8WXljypZ37ARcUKHD0cx13FGlQSoTjd2EhKm1NC k/uIwq3GsuAM2Ws4LS2hz02fvAk7s1o= X-MC-Unique: tRbopzuzN3enjrmC0QXifA-1 X-Mimecast-MFC-AGG-ID: tRbopzuzN3enjrmC0QXifA_1777894555 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:34:55 +0400 Subject: [PATCH v2 07/46] hw/ipmi: reject NULL 'bmc' property rather than crash MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-7-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=845; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=IaYWXas6d6Tx+GiU2CWhWCCTpxN6xrywSSwek/zs5Bg=; b=kA0DAAoB2ujhCXWWnOUByyZiAGn4hGyiWY+f0R5WzkO9IDcoS0Rg+wsAzRMdGV8Wy3/uM+JED 4kCMwQAAQoAHRYhBIepvZM/h8YG0nb2Ldro4Ql1lpzlBQJp+IRsAAoJENro4Ql1lpzlUFAQAJDz Arx42qH/TZri8CDSArjgwM6MsZuAEG4p1MKyOqTlGJINSGl3FGKPH1D7mFB1OsZLX4Ng0631L09 pXZnEOkjPgsAaA2UnjDzkdJlPItsvnUEBiqNqKnOEdNilz1A0WIdBI0EiRH7X6qsf6B25tnT3v1 kW3yoJ4TIcdFjjfqd/juGta7jtySvCbo8DUtmzhvP37OrAnrXcsPALrn9bpQdg4uy0z0GlRBs5T WrF57NrV/axijvDMUjA4WQ/nQ+saSEsvgQ7IxtXnMzVGsydnc44j1QOCdQcjCVbhQEVQLkKSJnm TtI8KQk6CXbv2052hdYhwHUuexqpiQlTTW4Kp722C8mhbZWW3JxbbAekFqhcA1aoICvrzKF32hJ 5LMpkeVYYlcomtAPZlvaNLvq0wfKL8zU6NpB2eVebtu2gl8bJozmRCbfsXAkcHQNtN2/OghJMhP FV3rvXukv2W61KrXAl3oSJrlrw4H8/8chKke+Vl4Hlxvhu6Vik2O4wGCjH5aueAPTniz3J1/jCw Ac1EcZgr4ny79azUwvKajn07sdmD9bvVnfmejGo1R3mMsNMqhAZjrXtAMtgOj2qubOaP7eqJobn /xLlef6JW3EY0bII+4FGs6yd8XHpxCZHedxc7SyNq1Ply5WUaQl1jeG5RR84RZs9E9Vnn9x4x35 gbuNw X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894587265154100 The type-checking macros (IPMI_BMC(val)) which crash on NULL. Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/ipmi/ipmi.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/ipmi/ipmi.c b/hw/ipmi/ipmi.c index b49affaccec..d532d38e556 100644 --- a/hw/ipmi/ipmi.c +++ b/hw/ipmi/ipmi.c @@ -95,7 +95,14 @@ static const TypeInfo ipmi_interface_type_info =3D { static void isa_ipmi_bmc_check(const Object *obj, const char *name, Object *val, Error **errp) { - IPMIBmc *bmc =3D IPMI_BMC(val); + IPMIBmc *bmc; + + if (!val) { + error_setg(errp, "%s cannot be set to NULL", name); + return; + } + + bmc =3D IPMI_BMC(val); =20 if (bmc->intf) error_setg(errp, "BMC object is already in use"); --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894735; cv=none; d=zohomail.com; s=zohoarc; b=G7YQMN4yalGl9YV2B3QJYfgsMqYCoBnixl9UQgwgqVUsBigwpFcKfdA/1AZe0bEBbmibF0c5gVOPtvQ41CDZxHUewpHTBtjSMa+UN9fZzFIEfNvZrNTEGu0Ju4RZ8GU5D/rN0sRqFXiyVnNHuyVBkbmZ0hYF1rnaWR3MeHe4m/w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894735; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=GpiJsQbA6N4lVaGQnZSXpb0IqEmM+X+KurXrRNwGnJc=; b=OWc7FY7hlUyA0NFEZBUkBIDWHI+mWZACEM/DGwDIbMhpKqTASjXh0gqkr3Wt4p672DUeARi4YiaEJjtszzNyQId4GWG2q9Y48SuxnN+2aGss7tuuWNr+fAuwiv9k1Wfe1STUOJu9UbI51MT7n3eP3Lkr2k0QIrQidOYX/SRu6kQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894735265442.64812326035326; Mon, 4 May 2026 04:38:55 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrb6-0007qO-1f; Mon, 04 May 2026 07:36:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrao-0007o5-Rr for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJram-0000tS-Tk for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:05 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-519-Oh4z6cupP7Wo2GmZbvOeVQ-1; Mon, 04 May 2026 07:36:02 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 45B531956095 for ; Mon, 4 May 2026 11:36:01 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 100861955D84; Mon, 4 May 2026 11:35:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894563; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GpiJsQbA6N4lVaGQnZSXpb0IqEmM+X+KurXrRNwGnJc=; b=KSDjufmyX983zfuvcCBkpOjptT0D4M0AczKQx16oOlk8+Dki9wxgSVjbXhbj7BmDXM8nKO Jk0RIbKZwFFq0qV2rhsj8yBM4QNw2Qn5Cds7cYbIK0sBL/UV3lTV4AEu4VSPYEpGtK3nQy Y+7DbHEr7s9EPgXAqGV7ExxPjCwa6D8= X-MC-Unique: Oh4z6cupP7Wo2GmZbvOeVQ-1 X-Mimecast-MFC-AGG-ID: Oh4z6cupP7Wo2GmZbvOeVQ_1777894561 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:34:56 +0400 Subject: [PATCH v2 08/46] hw/xlnx_dp: reject NULL 'dpdma' property rather than crash MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-8-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=819; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=ust1ZuWfSfSA7Ib1bldNFkkVSryiOB6BQFu7ci9K6O4=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRs3Jb7MzUVjAZgRkGU611y5HPz03rcxztzK 2AZkNtYcy2JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbAAKCRDa6OEJdZac 5Wy2D/9g9uRtQ/LxB9wNV5i/PjAmI0Sc+zFik27774askZDfN88v58vcudoq+neG5lMt6sfkD1U +K2TK7l06ODi4Bl0s2eutAwnG3rO9h5eW3hSiIHxhynPcK7Ew9F6v39Huuy7Mi7yC00YjUX1AuH lrtkOcptq+E9arfJ8v9bBS7+6Es8xQ7/zKdh7ybWI0kTu5glGXJLZpJzvfHVb1N15lJ5K0KHLEL CgrgomikhRxWFeUWG/G4X6dCe1SPYkbxEPXhAFQ8dE6T50wdxODxLeMZZu9mya3nqkKCTYxFWr4 RHKZPVEKTcSOMLSWrbvznDbj5B02xJtefPeEgde9UobjS4GngrJr8/EjpXdmP1TnUzLUVqHjVuW ghL9/IrYkCSSsfz7C+2Fl8O1S2WQs8cCHT2x2hJU+iWfTpUQbNSpIPICUFL9ahcdg6BOS7B/ZH2 mIjnDmhR1mAIH0JAzu7r5C6V2GtNsUJPVyHpus8+V6Xha+M4lEzwa5cgaRO5Wk4Oj+fzsr59L2n JiHxWTdM5IITjBnfSxlrZQchG7Mh4Kg1we+fjjvkb7AVIt6IM5j3fhjjYh3yhQuqc5LmGlJNt6e y491eX8YtJZuglanjF41coPvjfUyomAUSIYOJikKQ2wO/rC0K4fB7r9SuB5e1HMjBrjoScLi0GJ 8EyGjdE2cMjAE6A== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894736815158500 The type-checking macros (XLNX_DPDMA(val)) which crash on NULL. Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/display/xlnx_dp.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/display/xlnx_dp.c b/hw/display/xlnx_dp.c index 50e6ef10984..876cb3d6642 100644 --- a/hw/display/xlnx_dp.c +++ b/hw/display/xlnx_dp.c @@ -570,6 +570,12 @@ static void xlnx_dp_set_dpdma(const Object *obj, const= char *name, Object *val, Error **errp) { XlnxDPState *s =3D XLNX_DP(obj); + + if (!val) { + error_setg(errp, "%s cannot be set to NULL", name); + return; + } + if (s->console) { DisplaySurface *surface =3D qemu_console_surface(s->console); XlnxDPDMAState *dma =3D XLNX_DPDMA(val); --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894646; cv=none; d=zohomail.com; s=zohoarc; b=PAP+c5csdEDgfzPI7iELPQPty81/W+7oDQuzHxYiLOoSfnJPebJAjfrH1S5EOb9kBC4UdZKfg5wkIsHrWugTeKnqfOCaOVxxzrsEzqxCpGgMqMV6Bwun8QItPcYkU66lpby3bsfgW5I/LtHPXfGr6OGVL0cmDzPR9AfA/bHqNSU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894646; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=jInBZ8zsBzMh+z9fHsz/7RZJ4fPUd1yGMbptU2nQSvs=; b=DvvTMTuYYzIB9l2GD5RttfWzD9dIJ6swxTSbmkd/SEm8TbC3wE3MyeRk0E1srnwT/khJvz+SyVHM8j4e1X30Mq11F7jiBCPH3whoGXytUrTld01aOv9aiTeWE7kq9uTWKDtZzJITb60mzG+ySI0xsI7CYXesBKXWWoDI8N5dykw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894646366661.6260979982281; Mon, 4 May 2026 04:37:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrb7-0007t7-G8; Mon, 04 May 2026 07:36:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrav-0007oW-TR for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJras-0000uk-8w for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:11 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-488-lVM7APVWPWORN6DV0wgTnQ-1; Mon, 04 May 2026 07:36:07 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D06F919560B7 for ; Mon, 4 May 2026 11:36:06 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7CE2B18001ED; Mon, 4 May 2026 11:36:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894569; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jInBZ8zsBzMh+z9fHsz/7RZJ4fPUd1yGMbptU2nQSvs=; b=euvALjr/izh+mqxUR9T6TFJBOpjuKSUdAxZdaBbzUnEbyPCEsvi5lYGyzu+VGuePyUywfQ nwQtWbEaslCidQzJBzfyUpQJGHbgqrotwutAhCFdJi/xz4etRISzKd2j7t+j5OyXKSYG7G e3Ul+hXnsvpheuBpq4r4N/IsgS66+jY= X-MC-Unique: lVM7APVWPWORN6DV0wgTnQ-1 X-Mimecast-MFC-AGG-ID: lVM7APVWPWORN6DV0wgTnQ_1777894566 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:34:57 +0400 Subject: [PATCH v2 09/46] qom/object: update doc about NULL values in link properties MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-9-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1094; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=bitStGXg9RVRje1l/XipUpcpuZbWjuaVXhuCCEDOM8o=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRs+nYJMaU0BzcQcAFfUJ7+z+Npmwpk/I27P jnDOb+lLRWJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbAAKCRDa6OEJdZac 5f9ZD/9WXzwABR/dnstRi37QqjBlgvqEc6crYCU83gRZCPCJKM2FyFB4zDldpbMsbiJWeqlXsO0 ANYJjamqsuDTJwzaRdUVLWAsHT29PipEjlvq5cmOdTtJxxJNF0vUn4qk3d/eR4xF8w/JCdu5ZF5 oRgoJOsPa6Aa0OtxH8CDULQuAcjDcrGS2vcPom3Ub+8TZYOuEURS8xNioV90GYuDsdcQoB85EaC PJxP+ig4ZZ1vIGls/4XmeUHvKIbHGQX9meSsyeEATAXk4QDFOeZWrcJY+Nw5+GhVjOgstRVVA6b TxTqwKYr+7M7TVS8nj9fFV+2iLxxMGFYWlw/wPqgH17q6DxNtkCJeYn1t4Lgi0PTrE2e0QonJsM jWws/KyjMzovq0pRtBfs8PcdCxXofIWzn7tGwIo2cKqeA0kM305lSk/H9KTL/gym6IfF61OpcRb h+RjCukO5q40zvPbJ7U/LyWzRceM47DGtJuqy2VYUMsiNKdF3HC05fHD5LIG/MQU8WxogoQa/A9 iHQPKz+Uln6to+S8n8T68wvZ9kbqkZEtjEPXwfECA0iVyrqpXezQTFkHrpXdMVREqTVnnRiLuNm t9H43GkJveh/OHilQHXYaPoGICDKnqJejFkyXNFth5ytjbk4BuCVhC2t7nAent1VYHvBwkIYJ5r bPYTOyO2yB90/LA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894648147154100 Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Peter Maydell --- include/qom/object.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/qom/object.h b/include/qom/object.h index 510885218ba..0a82e160cd0 100644 --- a/include/qom/object.h +++ b/include/qom/object.h @@ -1714,10 +1714,10 @@ void object_property_allow_set_link(const Object *o= bj, const char *name, * * Links form the graph in the object model. * - * The @check() callback is invoked when - * object_property_set_link() is called and can raise an error to prevent = the - * link being set. If @check is NULL, the property is read-only - * and cannot be set. + * The @check() callback is invoked when object_property_set_link() is cal= led + * and can raise an error to prevent the link being set. If @check is NULL= , the + * property is read-only and cannot be set. Care must be taken to handle N= ULL + * values for @val. * * Ownership of the pointer that @child points to is transferred to the * link property. The reference count for *@child is --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894614; cv=none; d=zohomail.com; s=zohoarc; b=RzDzk9qnU0LKdH0RaBd3/28cwRbKGlE1FQshGOYHH+qYg+SWqmD/WWfZjQ7elNtX2pGZBaXwGcjaeZwsVzSI6gWMUP7LRIUBK4mB87IevuvD0KBypsJk+rizDgHK31wmBM3VnUGGb/bMkmEUYGf74VW9fvGkY6PYUSdo6XR9oUU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894614; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=tzBsqml/dM6fWiSEjTcIGoL9jK84pwIUG7THdwR6FSc=; b=bGSwfn9NxLMq3keGD2FgJowiFWM0z4tKDntQoVFq2sfMVJCnxezcJw6isZCQjMS1LiRXnqtJgma4nVjYpnsUykzEaHXjpZFKObwSd8UCaXIhLWso7KlPDn9Wdgzj4FhrJdD5fMHJ+jfepTghqcO6xNtJ9ReBqcQ3dqWjhdZE/bY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894614474584.7947984588723; Mon, 4 May 2026 04:36:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrbI-0008NE-6k; Mon, 04 May 2026 07:36:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrb2-0007oz-8J for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:22 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJraz-0000v2-6x for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:19 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-434-xDvQBCAQM1STPmBlb00yLw-1; Mon, 04 May 2026 07:36:13 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8EB311800473 for ; Mon, 4 May 2026 11:36:12 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 458641955D84; Mon, 4 May 2026 11:36:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894576; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tzBsqml/dM6fWiSEjTcIGoL9jK84pwIUG7THdwR6FSc=; b=WBdzyYQSRpG4ZXVwjaDfQSXCHiAWJrd6SbkIGa0A92TO9jHFcHuE7jrZPKkiegAejKMWu6 cFtlJ1kPGc7xwCZuvtwHS4jO7lYEVfFvkEm079fXd6YvJCmhSJPy7XHZbxKF8kBgmybpb4 pEvTdmZmQiByEdQAANbU33ryl7up8GY= X-MC-Unique: xDvQBCAQM1STPmBlb00yLw-1 X-Mimecast-MFC-AGG-ID: xDvQBCAQM1STPmBlb00yLw_1777894572 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:34:58 +0400 Subject: [PATCH v2 10/46] hw/intc/apic: move checks to realize() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-10-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=2954; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=V/1REB7hPU3r4nVJQdLs+FCZBO0CucW41h7dOvCiAK8=; b=kA0DAAoB2ujhCXWWnOUByyZiAGn4hGzIPORZThbpGxpUr0ANHG0nhpVwWJ9c+X/SSwi4rpsGY YkCMwQAAQoAHRYhBIepvZM/h8YG0nb2Ldro4Ql1lpzlBQJp+IRsAAoJENro4Ql1lpzl7iIP/RpA Mj2HsuOXfqr66hJkiLvpWPwYVSC1Fiv3b5O7B43y2jtKkaU5OLNSvMo0bADgucmIkseS/g+1hbE WYnhjuTlsG07ckHNIFdoHHWHAuBa5bRmRmt/1Arp9EH0uKdmSSCyzO7EKWfyfgMWkmO5JT0eq9T lkyGfQ1hQS4HHwVfY1Ho02ne3dHPAhNtV+FEBkZXi46a0znR/pDFoVl/rEVCZSHY+G7WmBJDTC0 l/pNOjtIr1Car0pvMENUVJ3hIr69ry3foYmqReEOlK8G1INf0JCIB+V1mJnCp5AZhMambCUIz8p eSGxQG912nqN5gjIiQ8EaFweGLbxytYddVkh7CHFq4VcT0gKFRIVw5did+X6H8RnlXR/tHrtFBP H6T5rXt65p7quO8hlRAERdZ/nHNmkL9CfD0TbC6tMhFfJKBO/hMveafm8h7rSc0wZ8CQwyhcyu1 Sve8UDUQiqPuhLcuDWVFWadJFGL69lfGThcOuhHog3jZFbDKPihDl/iia8AYht1zm/71/kcrtJf NM2cDr2FIyXKkXG/vs/PEdANlSTA3p33Zkqz94UJWkLUzDNdhgMzkn8l9AOxd8RvgUjSOkuzT+j UzNEkF7a4ZN0Rhq9qVblC1A7S3uuXaLelpPPNAO0/mFqfjMWQFscRZFGPZDONtS1D7f1Tvlhzex 6xgRS X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894617690154100 apic_common_set_id() dereferences s->cpu to check for x2APIC support when the APIC ID is >=3D 255. On a standalone APIC object that has not been attached to a CPU, s->cpu is NULL, causing a segfault. To solve this, move validation during realize(). Fixes: b5ee0468e9d2 ("apic: add support for x2APIC mode") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/intc/apic_common.c | 23 +++++++++++++---------- target/i386/cpu-apic.c | 6 +----- 2 files changed, 14 insertions(+), 15 deletions(-) diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c index bf4abc21d7b..49c03a5bcee 100644 --- a/hw/intc/apic_common.c +++ b/hw/intc/apic_common.c @@ -257,6 +257,19 @@ static void apic_common_realize(DeviceState *dev, Erro= r **errp) static DeviceState *vapic; uint32_t instance_id =3D s->initial_apic_id; =20 + if (!s->cpu) { + error_setg(errp, "APIC is not attached to a CPU"); + return; + } + + if (s->initial_apic_id >=3D 255 && + !cpu_has_x2apic_feature(&s->cpu->env)) { + error_setg(errp, "APIC ID %d requires x2APIC feature in CPU", + s->initial_apic_id); + error_append_hint(errp, "Try x2apic=3Don in -cpu.\n"); + return; + } + /* Normally initial APIC ID should be no more than hundreds */ assert(instance_id !=3D VMSTATE_INSTANCE_ID_ANY); =20 @@ -410,7 +423,6 @@ static void apic_common_set_id(Object *obj, Visitor *v,= const char *name, APICCommonState *s =3D APIC_COMMON(obj); DeviceState *dev =3D DEVICE(obj); uint32_t value; - Error *local_err =3D NULL; =20 if (dev->realized) { qdev_prop_set_after_realize(dev, name, errp); @@ -421,15 +433,6 @@ static void apic_common_set_id(Object *obj, Visitor *v= , const char *name, return; } =20 - if (value >=3D 255 && !cpu_has_x2apic_feature(&s->cpu->env)) { - error_setg(&local_err, - "APIC ID %d requires x2APIC feature in CPU", - value); - error_append_hint(&local_err, "Try x2apic=3Don in -cpu.\n"); - error_propagate(errp, local_err); - return; - } - s->initial_apic_id =3D value; s->id =3D (uint8_t)value; } diff --git a/target/i386/cpu-apic.c b/target/i386/cpu-apic.c index eaa10ad2a3d..f4f7f6b4d67 100644 --- a/target/i386/cpu-apic.c +++ b/target/i386/cpu-apic.c @@ -57,11 +57,7 @@ void x86_cpu_apic_create(X86CPU *cpu, Error **errp) cpu->apic_state->cpu =3D cpu; cpu->apic_state->apicbase =3D APIC_DEFAULT_ADDRESS | MSR_IA32_APICBASE= _ENABLE; =20 - /* - * apic_common_set_id needs to check if the CPU has x2APIC - * feature in case APIC ID >=3D 255, so we need to set cpu->apic_state= ->cpu - * before setting APIC ID - */ + /* cpu must be set before realize, which validates the APIC ID */ qdev_prop_set_uint32(DEVICE(cpu->apic_state), "id", cpu->apic_id); } =20 --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894600; cv=none; d=zohomail.com; s=zohoarc; b=UwNsQ2RT9U3ReJ6KlTbYgHtr9rdf3HARVNM6zfdLKI/ZOyRZ5QOLU6WYjSR5rRaAi+JW6RUVGA6aPjRi4G25Mjp3LsQnqdl5W2zkV8iboJOe+/E1pytGjVl5Oai7qg59SpFvQFxjzxpEG1ojgPbSlEcpaH8Rn9uLavAEnJbRxFg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894600; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=V9+ErlHfhLuXXJDocSDtTnxTzm8IYph61vLIhuadgv4=; b=n3iwHrqTERi1yt6+YZR9bzjs9Uph1kMp0if2IO68HZpPtlUPftSybdsfDkRBpeNTzilTVBD6twNt/zYu3BpqbPWM9G6gSMzyzXpwOUPLWUpqjzFSSAeisZYlTsjCmiTjMMm6WPKu02ur6W8ilqnmoK9dG167TYUf8KQTAVtBNJs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894600621916.6515583038235; Mon, 4 May 2026 04:36:40 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrbF-0008DB-Cm; Mon, 04 May 2026 07:36:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrb6-0007t2-Rf for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrb4-0000vH-V4 for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:24 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-39-uMSpoYnrNdifZxl2Vf2cXA-1; Mon, 04 May 2026 07:36:18 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ACA28195608B; Mon, 4 May 2026 11:36:17 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B0A6F18001ED; Mon, 4 May 2026 11:36:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V9+ErlHfhLuXXJDocSDtTnxTzm8IYph61vLIhuadgv4=; b=e40d0bgqZYGGl0yd0cH6qtpbHecQfpb07bEehZTZcygroUijeZGBfnGlAaUaPWYNzaEtrn jOMnaU5Gfe4JTYF9OfDQB7UBajDewIlclbMZmE+R/YUCn67KWgyVWoHk35xL8F7C6yXfln s6sSLBnilhAEioa+jICa+2soYSwe9Ho= X-MC-Unique: uMSpoYnrNdifZxl2Vf2cXA-1 X-Mimecast-MFC-AGG-ID: uMSpoYnrNdifZxl2Vf2cXA_1777894577 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:34:59 +0400 Subject: [PATCH v2 11/46] hw/remote: guard listener unregister in finalize MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-11-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , jag.raman@oracle.com X-Developer-Signature: v=1; a=openpgp-sha256; l=1108; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=cDsvGetIC+t+iBzuuM/zUrAZ/YOiA8vpcWaT/aLjS2w=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRsHm81Ro8UxB2SLtloX7GzTzB2sutTEZhOf 6Xo1T/vbbeJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbAAKCRDa6OEJdZac 5YRZEAC0UprmduhQmKs2IhVE1Xw7i/4D2Izj1nu5UqC4I7Q71XF1J0vbU0g5YCu2YOtK3n2zZeV iwXjR1UV/YSGHllxZohyF0Begoli3oeBJ7SXhqfjEXnEuLm7zmujalQQPBnkgLQDPUA1v4+Kwa2 R6ac72rq/rk7XQEGHu51atJ7IjYE1cFPWMWcs+ThpKdXZyrhszcH20GDngjtGhKJ6atQ89ynUsA 99REwWmi3q1TU3/oM5PEppV3nsgYs/W4cudCfsWTUPafDWVCXkkb7K9cuvU8HHSlpT6O8FIlr3M 54E1qcNjrePvxsdEH6jBbMmY/iHCBrb8rdKOvC/8Pxmw8jeKWEqEcXDA04VtdIrtykaeBFHk82Y ofAfkc/gz+inT2lJh3/2rO4lpAygAqy5KMc9ZLG/sbMAEn7uMdF4nqTAKx9ZEep+QRuBzkPC9gf pfGHTnBMc5khuZ22FdRIyWHXzelkE0XOe3gfqdiJgtSt3IhYs4rurymrjl6D+hsuVTLQiBjOgTW loUm6eTBXRYdLUZBGNacW6Z1gFbTzv9zSIMDfsX9KUDeJ62vMxJ1eK+bzIZ6vVHiuXrH4f1m+wW R/puMpOqUNU2tNgmgg68W4nPkmZV6ssaoqc7WirA/i9tfV/dB5oS+extr5xAc8TvxbOzy0EzqOE Lr0DIOj9gJDWZYg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894603645154100 Guard the unregister by checking whether the listener callback was set, which only happens right before registration. This is probably better addressed by "[PATCH] qdev: test if DeviceListener is in use". Just adding this patch for completeness. Cc: jag.raman@oracle.com Fixes: c7d80c7c1d9 ("multi-process: Associate fd of a PCIDevice with its ob= ject") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Jagannathan Raman --- hw/remote/remote-obj.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/remote/remote-obj.c b/hw/remote/remote-obj.c index 86192dc8dad..4e74ae76158 100644 --- a/hw/remote/remote-obj.c +++ b/hw/remote/remote-obj.c @@ -154,7 +154,9 @@ static void remote_object_finalize(Object *obj) RemoteObjectClass *k =3D REMOTE_OBJECT_GET_CLASS(obj); RemoteObject *o =3D REMOTE_OBJECT(obj); =20 - device_listener_unregister(&o->listener); + if (o->listener.unrealize) { + device_listener_unregister(&o->listener); + } =20 if (o->ioc) { qio_channel_shutdown(o->ioc, QIO_CHANNEL_SHUTDOWN_BOTH, NULL); --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894615; cv=none; d=zohomail.com; s=zohoarc; b=fUXPjcHwIx0634CqFamZeKPleLXub5TfbpGFyOavVItPtTrfp/6/tgS0bwx0q0u4wVOtIOsIrSXcQttYc3K3V04lYPyTHmQEFtjGbWp0a1h8AV6zXHgclfNIkrWVgmfDo21C+fmfM8iKgxJgVWVNtzkcRC/4Y803nKGjYCI2HhU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894615; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Feyzoi72st3BK6uw08MumeJ0heMFM0ajonX0WOp0f0U=; b=BbkqNUpOhrFZT7zFRmoB4h5pqXYl9cYQFybXoQyOQwu38T06RPzzw+GpTULuUikrb5LAdYCe0Gs26V1aYsyzXuS5LNQodVpM50BTpG8TqMOKGEAAxkXMeak22GvxmXdlL1p8k6eTCC0RvnbH20ZhGyghf1KNLRG8GWt3xmIbfI0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894615584984.6960293641456; Mon, 4 May 2026 04:36:55 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrbU-0000BQ-N9; Mon, 04 May 2026 07:36:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrb9-00082u-K4 for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrb8-0000vc-3U for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:27 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-654-Pwc5-e1MNqSPd-zVpa3VCg-1; Mon, 04 May 2026 07:36:23 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EFF4E180034C for ; Mon, 4 May 2026 11:36:22 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E9AE81800347; Mon, 4 May 2026 11:36:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Feyzoi72st3BK6uw08MumeJ0heMFM0ajonX0WOp0f0U=; b=K7tYd2Z4HGQPIIE1xRGRFRDCgGgU/2aEFLLhRDWysWlybHoNJZVEyX4jpeT1inK8LAhG6x 7TrNfoC88RqBcqHarbKa3x99PlrA/9DGP0Z44fxVBMviV9XSiMiWV8lsj/sLUQZZyiT8zt pXUpY5zbt3CQQYHg0e3Qg23gw68Z+CI= X-MC-Unique: Pwc5-e1MNqSPd-zVpa3VCg-1 X-Mimecast-MFC-AGG-ID: Pwc5-e1MNqSPd-zVpa3VCg_1777894583 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:00 +0400 Subject: [PATCH v2 12/46] backends/cryptodev-lkcf: skip cleanup when not initialized MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-12-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1186; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=XKESI/0DSqdUBTRFIDl2KEKlv25ZaJ+0o7RYfGRaK9M=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRsFkq5gFoGkhdtbX0XtTDFatKfr3ENADZrN KHIfiztfiCJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbAAKCRDa6OEJdZac 5S6vD/0Qn/ePgQg1XfJ43ptN3E0NTKDPf8P2rc3lhhVr6HatnbxRMZyv3cckuT55Z5ls7sKtJSg AowLOFQHMGAr0NhjTmtH9x4TO0GdLxiH8PBdXFN9fKvEJvmmF9ajzOpcmuojb6/qs6Z9yuO9iV3 SxOua5lZyXpQoMbWKZZsW+ooB+TzRqgk7D8WHFcYXbMVnPP/pcOraYRFBIcPQECoMYx6gffMeKF Xa7f8q6SuIOLH9U9/kATD+TAsaL9eIqr1UEiGM1Nkd8qDbBDHhmsmpyzXVO+hePrbhBJilhwdCh OFhWFz4zA9zRKwbCZMYWFRMaKi+/bPGUgvE5Uvlx3YtnmzuqCqhtVKSaM/RTl0I9HyqYSTNhCE9 maQDKMkPQ0JkjEzrqc8hfQQKqJvRVi0OPN6VMSVVwZM9WYzdVlaXJdlGC7UF7+7tNr63QVQlAF3 zn3bMPK0OYXv7qRiOovnfUchN8Y9M1b1h2zUuFXFTCsEDBZecBJnLZdGgHTOj4WvlJGrUdU1hqz 3duQ9I5nUm2AiQBq0oMy/NwntzQxnoRADqdBX0lM1yRdTxDqYTvsoq3v91qFJL36z7Khl+l1xLv Lu3z1KRTfDX+fIAFG9xoFKEp8xsiQMEooK/ZDJoRxqT8b70Ded8qf6drMh2rXAmmahN8gDKiGET bgUFotrBHM1hj0g== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894617665154100 cryptodev_lkcf_cleanup() locks a mutex that is only initialized during the init vfunc (called at realize time). When the backend is destroyed without ever being realized, the mutex is uninitialized and the lock aborts. Return early from cleanup when the backend was never started. Note: it looks like cryptodev init/cleanup callbacks should rather be regular complete/finalize overrides (calling the parent method). Fixes: 39fff6f3e8b3 ("cryptodev: Add a lkcf-backend for cryptodev") Signed-off-by: Marc-Andr=C3=A9 Lureau --- backends/cryptodev-lkcf.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/backends/cryptodev-lkcf.c b/backends/cryptodev-lkcf.c index 40c7bd3c5a0..3fe29d3104c 100644 --- a/backends/cryptodev-lkcf.c +++ b/backends/cryptodev-lkcf.c @@ -255,6 +255,10 @@ static void cryptodev_lkcf_cleanup(CryptoDevBackend *b= ackend, Error **errp) CryptoDevBackendClient *cc; CryptoDevLKCFTask *task, *next; =20 + if (!cryptodev_backend_is_ready(backend)) { + return; + } + qemu_mutex_lock(&lkcf->mutex); lkcf->running =3D false; qemu_mutex_unlock(&lkcf->mutex); --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894696; cv=none; d=zohomail.com; s=zohoarc; b=OQU4yBKK0t4QK4xifrcvVPLsPEGzE+z1bseo6O5CFcWjy/FMkUwKFU40ZovItdJBJByUCBRfhgzAJ8vIRhl6fuAjWa0aVYLacN6/7APUMzXWFo0iXFaapNiq6yLGJxwT1RAubnyeA60fYb8CJ519JVWDY1nt1He+QMjjUsmVBXk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894696; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=hawV2zHhsLP3IpBpGcaKS5nofkenBW3wvzF/cqta4OE=; b=Goele0DRETRBweEYBxjJBBfK2OJfyt5GmWyqVhmT6gV44Ax/9m4s9Ne/Y/O9m/qWMLp8Eg66nyo0nqFjFn79hFrEElGVWrjUnvIZoVnPUfjnHkvCuznh00UVC1QFQ1S1b5EiBHxSyg8JZYNZXkGul3+uIWBo3Hvtf2ethDIFUco= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894696011379.6043509842725; Mon, 4 May 2026 04:38:16 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrba-0000KT-O7; Mon, 04 May 2026 07:36:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrbF-0008NG-GE for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrbE-0000w8-2E for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:33 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-577-4uwF6CMcMQ67mA6abelspg-1; Mon, 04 May 2026 07:36:29 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D8C021956094 for ; Mon, 4 May 2026 11:36:28 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id ACF621800480; Mon, 4 May 2026 11:36:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894591; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hawV2zHhsLP3IpBpGcaKS5nofkenBW3wvzF/cqta4OE=; b=KQSlUy0dVQunrN5cd3nIeC3qb+awXH2+DxLYSvL0F0fppOY+l9Vvu8eg6bfxOGkMWJZDCD N1/NzTuq9YVToreQnXdKiZaAy1KlGxqDJrjcZeTTStd09PXL07Tey0xGe9lsAthu5vnyx7 5Z5FDA6HPcMG6JyoXuurPQYX/HHozYE= X-MC-Unique: 4uwF6CMcMQ67mA6abelspg-1 X-Mimecast-MFC-AGG-ID: 4uwF6CMcMQ67mA6abelspg_1777894589 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:01 +0400 Subject: [PATCH v2 13/46] io/net-listener: move mutex init to instance_init MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-13-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , peterx@redhat.com, =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Peter Xu X-Developer-Signature: v=1; a=openpgp-sha256; l=2097; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=FO0JbNzdhqKOcr/H+UXjPEtyLHouJa/+KfqAHcSin8A=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRsXDsGstuJZzUMHFI049qftwUp6PKECYBUG W8ebphBuiWJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbAAKCRDa6OEJdZac 5b90D/9igcAOdVBdS2aP/I9NuJ8WCrcCQrf6jeu2mZSQyRH9OYAutk2uhdrvAhhL/Ga5p/vt1ut XxmzmVvN+jLZcD68rn5o7z8/KwdpJwOSuVxlPKrt1kpIE4hLW2a3V4SSy4sBC4DtNZGiT8MUiF/ 1ozq4f1vWu079roA0g4CMxdEBuJy8vJ9v1X14m052sCmrV6y4iDV7jN0W8UNrGcYMmtuZRWLCGe WWDfgTQ9BkAvhFo5zQcZOgSMJvYg+u3vQcVATkcRQvqFMriHLoWxzmxuktICHyaxKdEltL7maYy p9foo2Gnmnkb6MfHxzICON4zhErf/9cUfW6BsD5fsgnOwKQMdGhgpW/ror+uAyWJcY3OU7kO4Zk hNbOS5N3JdWNp7NnmVX4n1bD+gaz/aAHR46Owbm/74JAtwbKVsOxZAGOO+tbELSSMUT05NwEMuD UsOICv3/qkO8S+BvNyTefJ9ep2+OA+e5bvVs5plm/v8wvXd1Rs0f6JjvtLykReUV88Norl8AFIY ACeZHrUlXLdbYwSny0Q6WAwg6vWqdZ2SsUnF5CqO3x5EVTOLAIB+I0kEdJj/wFzR5vWcWgv8ZvG 6p/IcklxZjf4pxp0LHsabkv6uOwnu+dKyHSqDqkBwz2XVncU8SyXAYGZqotPPzAhpO0i39DById 7QZb5quy+yCQ/8A== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894696888154100 The QIONetListener mutex is initialized in the convenience constructor qio_net_listener_new() rather than in an instance_init. This means a bare object_new(TYPE_QIO_NET_LISTENER) produces an object with an uninitialized mutex, but instance_finalize unconditionally calls qemu_mutex_destroy() on it, which aborts. Move the mutex initialization to a proper instance_init so that init and finalize are always paired regardless of how the object is created. This patch is just added for completeness, but "qio: Fix qom-list-properties crash on net listener object" from Peter Xu is basically the same. Fixes: 9d86181874a ("qio: Protect NetListener callback with mutex") Cc: peterx@redhat.com Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Peter Xu Signed-off-by: Marc-Andr=C3=A9 Lureau --- io/net-listener.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/io/net-listener.c b/io/net-listener.c index 9410d72da9c..1fd0f6cb5ab 100644 --- a/io/net-listener.c +++ b/io/net-listener.c @@ -38,7 +38,6 @@ QIONetListener *qio_net_listener_new(void) QIONetListener *listener; =20 listener =3D QIO_NET_LISTENER(object_new(TYPE_QIO_NET_LISTENER)); - qemu_mutex_init(&listener->lock); return listener; } =20 @@ -440,6 +439,13 @@ qio_net_listener_get_local_address(QIONetListener *lis= tener, size_t n, return qio_channel_socket_get_local_address(sioc, errp); } =20 +static void qio_net_listener_instance_init(Object *obj) +{ + QIONetListener *listener =3D QIO_NET_LISTENER(obj); + + qemu_mutex_init(&listener->lock); +} + static void qio_net_listener_finalize(Object *obj) { QIONetListener *listener =3D QIO_NET_LISTENER(obj); @@ -463,6 +469,7 @@ static const TypeInfo qio_net_listener_info =3D { .parent =3D TYPE_OBJECT, .name =3D TYPE_QIO_NET_LISTENER, .instance_size =3D sizeof(QIONetListener), + .instance_init =3D qio_net_listener_instance_init, .instance_finalize =3D qio_net_listener_finalize, }; =20 --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894629; cv=none; d=zohomail.com; s=zohoarc; b=h8OvD+iRwDKiidVPmRDk/FYMzcWi8jLU/HvL9TuzgFup/MLY9n1oERKRqZqA/UOVh/vFox8WZGPkBonWg0lGjmkndkkbN/RXGT3lto8Jo+5ChPRPvoetXJnVx5um9BxPtO6dWtucON9TaqkRXwz7BEtOHRw6vpjvHN6BHlehYMw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894629; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+iCE38jqlJCBLLcHpTqZ9+JVULDCpuuOY0DmjcBZNX0=; b=BqhBh91XuZoX4mwviHfAh7poCKzJro+3355A4nhagEx1oWskKpQJ6fOijQEOS/8djoXMZf5rfeSP7c8x4r5dalkNq0Fw1RgAPh8CSY/cexGomCg32dpTZPgwHz1GqxVud8yVhGwk8yKpsmTJVM+yE0XbZBP2vOb+uDNc2J1tiT0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894629987593.0394200302038; Mon, 4 May 2026 04:37:09 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrbi-0000gO-U8; Mon, 04 May 2026 07:37:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrbN-0008VB-Ax for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrbL-0000xB-HC for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:41 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-528-LlMReqR3NvK4PTAI2A0i8A-1; Mon, 04 May 2026 07:36:35 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B5E3C18002CA for ; Mon, 4 May 2026 11:36:34 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 58A7419560A6; Mon, 4 May 2026 11:36:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894596; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+iCE38jqlJCBLLcHpTqZ9+JVULDCpuuOY0DmjcBZNX0=; b=BOEcFusAkH/VBPCTZyTn6XyY+uQ2jn5h9RFpbR63kbdCQqL6l1N7LXy/7jVyntL597skzM /7Mv3L9KZuf1luHA0bAAxk6fgW7FHADHPr7a/evWSKvSPf9RtD79WBj/QZCVqkwWg+eEJq XMsxxE8/CuGoL2Q3TG8b891hw7C1ccU= X-MC-Unique: LlMReqR3NvK4PTAI2A0i8A-1 X-Mimecast-MFC-AGG-ID: LlMReqR3NvK4PTAI2A0i8A_1777894594 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:02 +0400 Subject: [PATCH v2 14/46] net/colo-compare: guard finalize against uninitialized state MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-14-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , peterx@redhat.com, Peter Xu X-Developer-Signature: v=1; a=openpgp-sha256; l=3019; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=ZF3TTPjvQzahlqd48t2i0EXIpqN0l7MjdPJ+auYGt8Q=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRsZoHtXsl7/p/bMftfDtmG6o5dxrTlnuorF 9Nn6p+gRZ+JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbAAKCRDa6OEJdZac 5WhRD/9Io3z5CxnKgzdQzwLchLrExLXrbExVDg5J1QxcusG04SiVp3fdkomxEQqj78G8xIFzUXV zOogkSONWpW//0HsAgV/i+VbslwhJ6npnQYgkHKt9Dy/ayTMbNjhJyI1lUFiMBq88kONbj6m0vB qkBwfuyc0UCGQyyqhW0VCeUiYvgLXPuT3YH4rFDUkpP/QXuuM3BxZaMBzVkU9mySfxqesLgwj8k scJGFg3VoKT6T+CybUJ0Q3aUsimnx2y4d6mK831AJAcnpcrvh87HXejELRYguQqjDQL7VSBWYHf vb2zoRxUAxlwckF6AyyQT0zL5r6OFcQwYtqzOK5qhRfwQuRLcpRrK0QqA54R0ILvrc8InRg3SJz btDivouHrXiMYVawVDgyOpVu4sbauT52YC7XxsFUr1mPaqf/5BbJqL8wCSv92vJErw/47o7LYf/ XnF5gLz4olifXRyDHZuzhzPpBEanI/Aqo3b1LiGwcBKIWUBQsRO8HYxQinj7yeyB5QRlx8nGsJH WKa3PvICT98X5c7VSfcZQlEvhzQfE8SW7AVnaEJCAZJlO61g67njaSxze81SCLVTcmtA+EvTkQZ do4BdXcPoVk+iX1Q8Q6oWYK037wrnhjnjVfAhd9zatCRtU+70TFmEumYZWLxdvL8Wcd2l3SM7Lb yOIsCS1DGEZOZjw== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894631930154100 colo_compare_finalize() assumes the object was fully set up by colo_compare_complete(), but a bare object_new() followed by object_unref() skips the complete callback entirely. This causes two crashes: - qemu_mutex_destroy on the static event_mtx which was never initialized (colo_compare_active is false) - qemu_bh_delete(NULL) and iothread dereference when s->iothread is NULL Guard the event_mtx teardown with colo_compare_active, and the iothread-dependent cleanup with an s->iothread NULL check. This is an alternative to patch "colo-compare: Fix QMP qom-list-properties crashing", sent earlier, hence the RFC. Fixes: 45942b79b9f8 ("net/colo-compare.c: Check that colo-compare is active= ") Cc: peterx@redhat.com Acked-by: Peter Xu Signed-off-by: Marc-Andr=C3=A9 Lureau --- net/colo-compare.c | 31 +++++++++++++++---------------- 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index c356419d6a8..be819db06c9 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -1416,7 +1416,7 @@ static void colo_compare_finalize(Object *obj) break; } } - if (QTAILQ_EMPTY(&net_compares)) { + if (colo_compare_active && QTAILQ_EMPTY(&net_compares)) { colo_compare_active =3D false; qemu_mutex_destroy(&event_mtx); qemu_cond_destroy(&event_complete_cond); @@ -1431,30 +1431,29 @@ static void colo_compare_finalize(Object *obj) } =20 colo_compare_timer_del(s); + g_clear_pointer(&s->event_bh, qemu_bh_delete); =20 - qemu_bh_delete(s->event_bh); + if (s->iothread) { + AioContext *ctx =3D iothread_get_aio_context(s->iothread); =20 - AioContext *ctx =3D iothread_get_aio_context(s->iothread); - AIO_WAIT_WHILE(ctx, !s->out_sendco.done); - if (s->notify_dev) { - AIO_WAIT_WHILE(ctx, !s->notify_sendco.done); - } + AIO_WAIT_WHILE(ctx, !s->out_sendco.done); + if (s->notify_dev) { + AIO_WAIT_WHILE(ctx, !s->notify_sendco.done); + } + + /* Release all unhandled packets after compare thread exited */ + g_queue_foreach(&s->conn_list, colo_flush_packets, s); + AIO_WAIT_WHILE(NULL, !s->out_sendco.done); =20 - /* Release all unhandled packets after compare thead exited */ - g_queue_foreach(&s->conn_list, colo_flush_packets, s); - AIO_WAIT_WHILE(NULL, !s->out_sendco.done); + object_unref(OBJECT(s->iothread)); + } =20 g_queue_clear(&s->conn_list); g_queue_clear(&s->out_sendco.send_list); if (s->notify_dev) { g_queue_clear(&s->notify_sendco.send_list); } - - if (s->connection_track_table) { - g_hash_table_destroy(s->connection_track_table); - } - - object_unref(OBJECT(s->iothread)); + g_clear_pointer(&s->connection_track_table, g_hash_table_destroy); =20 g_free(s->pri_indev); g_free(s->sec_indev); --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894699; cv=none; d=zohomail.com; s=zohoarc; b=drVkRqAQ4cKZhEKucyqtkZV4S4fqQtqHJAEwu52ly07CPTxqVi1H8Rqj6ztWHPCxXUiwzpVCo9LhDXRnYd/8J8S3eOMYQR1zEpEzv61zrx8PB53CvCw4kLwFEMhlEm98W1V79MZfv5uqCy0dNwzyDDl+10dXw+asql4udS+DYtI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894699; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=5Shw0+M1QV2kNpKWt/rvuQRHoFmA4/rBBLUi/fyiGtw=; b=c2wG8QNvIgsXSDc07qXJgIRTCRTW3C3xCh7x/f0avJxUPIGmu7m6pgSAyrJpUP7A+9SBENJuf7d8aDQSiWGNjuJC7CwTaasR0fYFv9sek8wSqanOuL+fPT1ryC7DFcKUeRGlI8l8zoNcekNkI8SlKXgWeH/LtiyT2tn4k1MCcoU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894699787326.1861331836607; Mon, 4 May 2026 04:38:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrbm-0000mr-Fo; Mon, 04 May 2026 07:37:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrbR-00009T-GQ for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrbP-0000yB-Bm for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:45 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-671-GTH2DcJPPtqah5l4BiCOCw-1; Mon, 04 May 2026 07:36:41 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 52FD8195606C for ; Mon, 4 May 2026 11:36:40 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 08ABF1800347; Mon, 4 May 2026 11:36:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5Shw0+M1QV2kNpKWt/rvuQRHoFmA4/rBBLUi/fyiGtw=; b=CATyFV/BqeA7KkiEKwuS7LInnvwWpA5Qkb3oOeKQjCDMFHlZOBZzwtfrQXQDMaoSdTIXDI reiJBhK5KukMmZ9cC6thfKZFOOT91c7qGvsw6jbDtXvxuL1V4jn+xE+s3OXl9bZN0IF2cG yIvfSj9UndkfFbx3KxWzJRWzpGFRKhg= X-MC-Unique: GTH2DcJPPtqah5l4BiCOCw-1 X-Mimecast-MFC-AGG-ID: GTH2DcJPPtqah5l4BiCOCw_1777894600 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:03 +0400 Subject: [PATCH v2 15/46] system/ioport: minor code simplification MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-15-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=964; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=XnNTj9CprNc1j312e9lBdRBLP13rqWwWv5O8h5OKvSE=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRsAFJDjTy/ub8Mf5oowt9Xsu7g4+h3BMMGn qALpjXG8SKJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbAAKCRDa6OEJdZac 5bKFEACGqzdkUZKxraf5d9GRoEXCExkER58dkolT/gCUmGRHoWutXamKWZAtkf1Npw2Zlq3FO90 RDTzusYcm4CzZuPISaonzefEZpUMSbHKjMg7nWhIXxu4PBhPdbM/HyO9qAJ6cc3f3sFjV4Il4/x YQydjuhfstopfp+Gey75TEHi4qi8sWgu0+FdKCiEtEUk/QEPvWrHDt25Euh857vLX+iLo+7Eeto 17/2s3JLJxfAr3pAwtVj/b37UQnmYVP1nSYd8A3lXqNzjkkQdV4EjakRzqLsNt3mWz5HzUbkcnu E13KABdeiyVWQ8m13Dgic8gua93nFLKUMEBElC+0LD0bGjs5PwuEYx/94ERvUXtrvl0/34Mq5dg rGQwAmfz4m/H9dMkyycT9S9cwf8Hfy1StbtJFGT2ih4EW3UzSDer0Sj+JAQINJjUjFRmIbmxn8Y FrHIobj5/8LbsBKPPagwEsX/5enjzO53P1gobL63IyYzwPh0XgpoGH0p+3FFMBcDSoTiX5P4wwQ mlpYlJKaDb3C6xkMqNTm04eVulmZnNVBkgnXMnzFSqtM7Y+xfXD0k+FAjBpR4PtcPXsWPwAxHzO lRJj+XheiiwAqtbJOFwQQwjLywZFKZCZb9TNADkVsytzBIJGtfeOCsL1F+75ezNLYbONKM7d1bI m+N2foUNg1bfazQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894700998154100 Drop needless memset() and replace g_malloc0() with g_new(). Signed-off-by: Marc-Andr=C3=A9 Lureau --- system/ioport.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/system/ioport.c b/system/ioport.c index 9209bff2eab..303fabf063e 100644 --- a/system/ioport.c +++ b/system/ioport.c @@ -230,9 +230,8 @@ static void portio_list_add_1(PortioList *piolist, mrpio =3D MEMORY_REGION_PORTIO_LIST( object_new(TYPE_MEMORY_REGION_PORTIO_LIST)); mrpio->portio_opaque =3D piolist->opaque; - mrpio->ports =3D g_malloc0(sizeof(MemoryRegionPortio) * (count + 1)); + mrpio->ports =3D g_new0(MemoryRegionPortio, count + 1); memcpy(mrpio->ports, pio_init, sizeof(MemoryRegionPortio) * count); - memset(mrpio->ports + count, 0, sizeof(MemoryRegionPortio)); =20 /* Adjust the offsets to all be zero-based for the region. */ for (i =3D 0; i < count; ++i) { --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894696; cv=none; d=zohomail.com; s=zohoarc; b=dkvDdwZ2lSD4g9FkC4LNJ2JA3UxyFzODy6T0e+igVFPHlI/FwYgVF9SHgb1uw7fCPDshpZsdo10UjLH6zep2ggDKFeWR1xpl5rDMKJRh3KWR3eARMPtMcczhwOBzDjrZuVHHEbkdMMhUuU1Z/efr0eUlnxxmmNguWs+S+MzVTCU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894696; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=WA7HCr6BRcLTeqx4HsKUg3WORqn8eiFYwWxgxz8jrOY=; b=XpzBULK1NzrtfST+woS34oiD+InAe953v0ASKrDUaOyBdBzLO8o29XgugSyyoDxOuHvx9mcRPMLj4Jc8r3QbwIRDa/9QZ6puhR+ZZGKHwKYygQHJklTz6GmezYRLJTJhDqVx7CVg3BvbohVM5m7C6+9VDIRDAR0e9GiBxxcWYDg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894696421560.1103516447349; Mon, 4 May 2026 04:38:16 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrbq-0000s4-DV; Mon, 04 May 2026 07:37:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrbX-0000Hj-KT for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:52 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrbV-0000zq-NJ for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:51 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-147-cqOgIstqNLq9FGGxZ15TAw-1; Mon, 04 May 2026 07:36:46 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BCA41180034C; Mon, 4 May 2026 11:36:45 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 71EF219560A6; Mon, 4 May 2026 11:36:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894608; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WA7HCr6BRcLTeqx4HsKUg3WORqn8eiFYwWxgxz8jrOY=; b=JpWRXBLnLhY7ZhA+NfWHnyGBM3+t5n6spRlO+wneN2fxrrq/ZbHY8chm+zKe/it2OjAJku GshjBWF9Ay3mbmpYAG3GFCOtkm4nLQOrniU7eslDpgPwBLoZgmKatMidipUda7DWSxRSCH wPpGDNr7/k6BPQcEjIrXGoLuinrvSns= X-MC-Unique: cqOgIstqNLq9FGGxZ15TAw-1 X-Mimecast-MFC-AGG-ID: cqOgIstqNLq9FGGxZ15TAw_1777894605 From: marcandre.lureau@redhat.com Date: Mon, 04 May 2026 15:35:04 +0400 Subject: [PATCH v2 16/46] system/ioport: Fix qom-list-properties crash on portio list obj MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-16-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Peter Xu , Mark Cave-Ayland X-Developer-Signature: v=1; a=openpgp-sha256; l=1608; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=OiojSRVbGrDtH2nEC2hxpx2beSqgCFB6TOBqj8+YtAk=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRsP7CyQfyq6qKr1yVRRE2pUfqrXKwRoezQn MZ2EWNfkjKJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbAAKCRDa6OEJdZac 5cCgD/0UN3lXBmEslYfzE732Gn6/8UEPqTUft3IfE9TODBxP0G9ttQWDyhX+/+eBGBfHbPARhiY OUvDtZBE6I7HlLQYgBR2VVd3t5blDGIOM9WH2wVC8jFCKNq1n+NCyIyI+0aBrtgnbGaeC/X/OSh 50gtot4GdmK8lupw3SDbYCP9uh4TEgMatbSSk8H2GpKshLampPR3V8Q6QEjQeSQDdv9rUZEe3rn um9xDRdR6SIxxdp9fCU8qHvjpS2sO4uLE9AfmMIJuqnHXl0QAosi9M/b7gxcYw03hAzhxJBxfeq +6UF+79zGAwI8tCN9CYZyosK5w4kqSlFi3KsUxyw4HPGSqGaVEpKI4IJPa0QAsdnrKDU5ar53SU PBFtxQyVUXG0PCgnrgn9FWI3fbN4CNT2wq9P2qcWR46Fn5YA3f4iBMDLOdmuJLbTsWxB5avHeBT gIQZpC8t1Mb6g6lFfEOwQ58zswAoiN52c7VAu9FWlNkbeLmRDMuL/5Rpidy3gpxu7LKRtqWR9pd 8ohGdF0fxGNW7Gid36YNNIXgx9mG+RJv0PTnYjb4Z7Qna/KTnpwK9TR8Rcv2SV8PEfiH1pKofFr ARtmxC7iw6o1AXhpy8UlMZL0pfaZKcHJxfVy9fA0Di2UcwQaShTd58Y+dmO9i6rWh6YFkEoQuLx 1y5p6bvLpw9CE/A== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894696782158500 From: Peter Xu Currently qom-list-properties QMP command will crash when querying the portio list MR object. It's because its finalize() assumes full initialization done in portio_list_add_1(). Provide a simple fix for now to avoid the crash. There is chance for a longer term fix, ideally MR should be initialized in instance_init(). However that'll need more work, and that should also be done with cleaning the hard-coded MR operations in portio_list_add_1(). To be explored. Cc: Mark Cave-Ayland Link: https://lore.kernel.org/r/87a4uvw066.fsf@pond.sub.org Reported-by: Markus Armbruster Reviewed-by: Marc-Andr=C3=A9 Lureau Signed-off-by: Peter Xu --- system/ioport.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/system/ioport.c b/system/ioport.c index 303fabf063e..0a1b80f2994 100644 --- a/system/ioport.c +++ b/system/ioport.c @@ -345,8 +345,15 @@ static void memory_region_portio_list_finalize(Object = *obj) { MemoryRegionPortioList *mrpio =3D MEMORY_REGION_PORTIO_LIST(obj); =20 - object_unref(&mrpio->mr); - g_free(mrpio->ports); + /* + * This check makes sure any random object_new() (without doing the + * rest inits in portio_list_add_1()) will not crash when finalizing. + * One example is QMP command qom-list-properties. + */ + if (mrpio->ports) { + object_unref(&mrpio->mr); + g_free(mrpio->ports); + } } =20 static const TypeInfo memory_region_portio_list_info =3D { --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894681; cv=none; d=zohomail.com; s=zohoarc; b=YFrzIc/6+qvUgy5ZTzD6tLVdo+Qnie88zeK3xSYtpfNX46PXXiRNBlmsGVl+qDl4GciMJznOrxpMKNMgBVjuRQeO5JZ9qV/YKFT7sGLk64K5Ig0hZelgD90xjI4bLSANPjRpeSMV9VTlCzo4Rum324H83g542ATBESvNeYprLqw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894681; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=tn0OCpP159HA+f6R+KQP0S44C9uWxut2R7clX9nuNXk=; b=e+72mdm3DLEzK9FEGNGLAmXt3YYJ+thWBJoAiDvLZHPRMnycdZwBt+fN2rZf1eEV7tN7IN6T8oeg5YG+fA/B2KUJLyTP6DE4B9j14EUxMbu7+IYtcmmH1k8RQqMndF/UGUHr664dymzrtOAu9nrVrVDFv2bB1cz4N4yFWSxC/J8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894681185903.5416997033467; Mon, 4 May 2026 04:38:01 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrc3-0001Ay-AH; Mon, 04 May 2026 07:37:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrbb-0000WV-QX for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:57 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrba-00011K-BR for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:55 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-452-nCrX5OxGNl6fPPGtpfiS2Q-1; Mon, 04 May 2026 07:36:52 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5D4821800578 for ; Mon, 4 May 2026 11:36:51 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 127FE19560A6; Mon, 4 May 2026 11:36:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894613; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tn0OCpP159HA+f6R+KQP0S44C9uWxut2R7clX9nuNXk=; b=SlHD6ZgtUZO2w6OoQnO/LScgHVhjPBWX2FZXFcLZmVabszpMYliTu9ybZp3ULa4lr4kY/B SGioiBXL8E4tLN4wxWZ4sm7iV8hCD2pf+WUZlc8s3ZGxmpL40o3b1A1BiWAD6TFoWCYKT0 F9inb2bZDtaYEBk7anHGp58o29me7zU= X-MC-Unique: nCrX5OxGNl6fPPGtpfiS2Q-1 X-Mimecast-MFC-AGG-ID: nCrX5OxGNl6fPPGtpfiS2Q_1777894611 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:05 +0400 Subject: [PATCH v2 17/46] ui/console: remove console from global list on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-17-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1375; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=mcTfYn3iaVcXEtf37PXP/OHeHd23/2dVTmMNCHATXSw=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRsDmam5idYskbVhqMU75Wwoe6oS5IUKeUog mZkSoIx+uOJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbAAKCRDa6OEJdZac 5bnKD/9x/MtQkRHJYXCgDOYTS7fOYJiRYwH+KP75H0e4shXK5aLXrow7IhNuSIBYWWVXKDs2dAY jWZhZb8g7qjZs10t5yTySq4u1Fr+wYNLOWbUm4L+hPJiywCmqx/aDMVWqVIaghwKJ/lHANtGMpi acYkOsxOBi8jGdGOGjTYAmgI0Hi3+B1jL+252xtscdGY5mbcERwuWqQVLCiDSIGyN8fg8mWg2Gg ojdkjej7MwgKNWvh+yL8NvcHQkWf22KRecpTvWngCLnnZY3MyOWIl4AotAqhmrNtUv66+b8bn6g /myeuLhjV44qALUapHkY/5iMA9l50BJSrfcU7BqD1nj7TOxWS6wW0Vsqe29ARx1p7YGONSx1AZQ uYRMluAY/r39tcEasxVdeleTu/phQSNf+H8IG3lmySn0aCB5wlfiZ1POUeHLhL1WAGUd+c8muX6 v2c4WYoa4uOGU2e0Hk0bgM5O7qFtl2ONQ/EXNykuqTK5MgXJNbZZq8zw9VlwXttrBryQN048dqU mu3a2REcVPl9ILq0p2q2GlsM7DFeEIO6hXRgR7OGxedvXI+jEr7OUTITzWoOj6J7jgNdBURAQHN IjE83gWjL6wvF7d+7p0pNP/g1Oiimm6SzsTl+4Qh9QVRCMImZ15ZI9L1zI4KFt11IvNcIvp4zgy 0BoS2NNwYfvJWMA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894682536158500 This commit removes the QemuConsole from the global "consoles" list when it is finalized, fixing use-after-free on throw-away objects. Reproducer: QMP command qom-list-properties with typename "qemu-text-console", "qemu-fixed-text-console" or "qemu-graphic-console". The assertions added ensure that `dcls`, `gl_block`, and the `dump_queue` are empty before removal, confirming the console is in a clean state. This is left to handle correctly in a future series for hot-unplug case. Reported-by: Markus Armbruster Signed-off-by: Marc-Andr=C3=A9 Lureau --- ui/console.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ui/console.c b/ui/console.c index 799d61ec1a5..2adffb6f04d 100644 --- a/ui/console.c +++ b/ui/console.c @@ -390,10 +390,13 @@ qemu_console_finalize(Object *obj) { QemuConsole *c =3D QEMU_CONSOLE(obj); =20 - /* TODO: check this code path, and unregister from consoles */ + /* TODO: fix hot-unplug support of consoles */ + assert(c->gl_block =3D=3D 0); + assert(qemu_co_queue_empty(&c->dump_queue)); g_clear_pointer(&c->surface, qemu_free_displaysurface); g_clear_pointer(&c->gl_unblock_timer, timer_free); g_clear_pointer(&c->ui_timer, timer_free); + QTAILQ_REMOVE(&consoles, c, next); } =20 static void --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894706; cv=none; d=zohomail.com; s=zohoarc; b=UI+bSjCbrk1qy5taGSUDjVoUZifwt/bVa0gjNTgOYgI9hemPBekfmuf8Gitp3y6ckX5qi2ykRXnyLhA+V5esg2d7jebSLWpLLYHLtHLvrnAT7o9mtAaaSoKiKuIvLYJnaWw+xFltVrXZBeJYmhGvPejQkdURMf3D5c+GG8KvEEs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894706; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=eveSPPinlS5ge22zD59cWM5/VNbVy81aT0zg3hIugP0=; b=VO5rGNUnawWGPWoyklxeUOcyIAYYNILbzPvj3JtbiW8R3HVV37g6Ky93TATASuwF7xKkLZK0bf5RYRpwh/bUNVreQVGs1XBkDR5GGt53l9EDvdVri6WnfDsvrvaWXdBbcebbdP+kCLHMdns/rWv3iP9e+ysaiPQB5V6NbuIOcWE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894706056858.8377671888384; Mon, 4 May 2026 04:38:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrbt-0000xz-9Y; Mon, 04 May 2026 07:37:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrbj-0000lD-Gs for qemu-devel@nongnu.org; Mon, 04 May 2026 07:37:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrbi-00011p-4T for qemu-devel@nongnu.org; Mon, 04 May 2026 07:37:03 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-81-1ug8KojwM6ixqBUVbli2BA-1; Mon, 04 May 2026 07:36:57 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1812818005AC; Mon, 4 May 2026 11:36:57 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B13E030001A1; Mon, 4 May 2026 11:36:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894621; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eveSPPinlS5ge22zD59cWM5/VNbVy81aT0zg3hIugP0=; b=B3Su6JUd878QMeZfs5fvi4necCdywzng/ulAXJjbJX0jy+rKxaQkpJ+iFOFI25USH1iawB AoDHosbGJ9pPZMAe4pyHFAA4afQB+/bBzEMIeYCIiJSM8ojpcZoM2QNvWB4+HoBFypft5X JnBRHvT6mfUb4zEQNIUU/cdl6NR7IIQ= X-MC-Unique: 1ug8KojwM6ixqBUVbli2BA-1 X-Mimecast-MFC-AGG-ID: 1ug8KojwM6ixqBUVbli2BA_1777894617 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:06 +0400 Subject: [PATCH v2 18/46] hw/i386/x86: free oem_id and oem_table_id on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-18-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1438; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=V+2eXo/TucBNqV2DxgpQIOrwZ4TdO+5VekaKqMhBHdM=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRsmXMbrvbLPcc1njAZ4kl81Be3nHve/fEzC I0fbECuFI2JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbAAKCRDa6OEJdZac 5cW8D/43mfpZX7a0IYtZxXdnRmUDOeMA7FkZg7PGh3wp/nxYgRGEk+tNZkey5crQz44XXyBQEzt WsJWJt0c3F8o3x7H8btkcpsQANNEWrPLfCWEH0CZdENquo+d0Oexg4KdOWM8+Tjo2FQT5xr2iOG DlN3y6YFJsiv5+nYUIVxKBosr4wqX4VzJSrZJ4a0fxoUK8iGQjUo6u29hvneagaYRTVT4LeSJbV ehZsmejowpUhKMhU9egvXWgKrwDki+WVrgp9BLNPvgWzgQt1Pfx31QUVTcqEb4cxzdq7LPPAHNx gSvq0QqvAhqFWUai0sDfo7NTCPleaImtbxaqMxN0qf/P57LpqRsD+7n6dJYjX3C6NjwYSq0s2U7 Ht2b2NM32da05BbPfyl2QGv8DuzyhK3fQg3XauXTw9q9b7lZlFkKJTh0BW6OQ9qU/EEDeeMBMbg zVXk2/4nV7YMWi6V7Ok4NhTYaI12lQv0IFYLVHrrsp8Hiqh5p/EK1zPj2BYd6VrSHfuw6mcOOLH 5kmDGa1cInxFZiugR2p9Zm9Dl4k8k4w1McUlBp9FtI4CsZ2hG3mbPlHMx+9B2H0DPALxQawgKwE kU6LlfXGqPKJS4xm/T7eo5kfoHaqhwlrqWmpKFiJCO7L9/H8jKAl7oIjwtjvHJ8NEmH4h2SH+bJ yaN7wbZqUFgFhdQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894706675158500 x86_machine_initfn allocates oem_id and oem_table_id via g_strndup, but no instance_finalize existed for x86_machine_info, so these strings were never freed when the object was destroyed. Add x86_machine_finalize to release both fields. Fixes: d07b22863b8e ("acpi: Move setters/getters of oem fields to X86Machin= eState") Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/i386/x86.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/hw/i386/x86.c b/hw/i386/x86.c index 01872cba073..dc7f0d56b01 100644 --- a/hw/i386/x86.c +++ b/hw/i386/x86.c @@ -372,6 +372,14 @@ static void x86_machine_initfn(Object *obj) x86ms->above_4g_mem_start =3D 4 * GiB; } =20 +static void x86_machine_finalize(Object *obj) +{ + X86MachineState *x86ms =3D X86_MACHINE(obj); + + g_free(x86ms->oem_id); + g_free(x86ms->oem_table_id); +} + static void x86_machine_class_init(ObjectClass *oc, const void *data) { MachineClass *mc =3D MACHINE_CLASS(oc); @@ -445,6 +453,7 @@ static const TypeInfo x86_machine_info =3D { .abstract =3D true, .instance_size =3D sizeof(X86MachineState), .instance_init =3D x86_machine_initfn, + .instance_finalize =3D x86_machine_finalize, .class_size =3D sizeof(X86MachineClass), .class_init =3D x86_machine_class_init, .interfaces =3D (const InterfaceInfo[]) { --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894715; cv=none; d=zohomail.com; s=zohoarc; b=m5RvQezI6ZGW2sSmG2sP0jLy85L/2ORLJfxSWWYMGWAenGYGipyvhlfkDR85mDkBfOdi4Ung2qR91r7l7yP0fa40FCxncamwcHh95S8my+dCWDuhZ6VfNCFVpMN2z5M3fTZm5ineMQF4aO1JoBDRpD2wTBXmizLiqE2eqdBV/PE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894715; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=8YvsVsIi/1TFcOv3yrrnCyz6XIRwOmOuXGjMWoQQNxM=; b=hZYah0SVPVgUOmBX9aAbdkVvtFMzi5CKYzKv96RBc5wxg3DcPotjRJf47xgovKnW+QQ3UHz59eFMdVbMq7vHN7nNrzsi6QbJXZNYSn1Y4dRH7uDeCsZASqIwr+mmM5VlShzL9oKauNrAwzCPaF/1Y992jWenWlExyLuAcilIU4U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17778947151290.6144571296698587; Mon, 4 May 2026 04:38:35 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrcE-0001YY-Os; Mon, 04 May 2026 07:37:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrbn-0000q3-Oe for qemu-devel@nongnu.org; Mon, 04 May 2026 07:37:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrbl-00012L-Ox for qemu-devel@nongnu.org; Mon, 04 May 2026 07:37:07 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-696-RyWBl1BlNaeLXqANzqKcgA-1; Mon, 04 May 2026 07:37:04 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2EC0E1800578 for ; Mon, 4 May 2026 11:37:03 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id CB7051800669; Mon, 4 May 2026 11:37:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894625; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8YvsVsIi/1TFcOv3yrrnCyz6XIRwOmOuXGjMWoQQNxM=; b=BImmZ+gsjt0fdtjn/XsHeoo5FkgNUkb5yvjKLmdSqcpF7e6hBQi9U7pzB8SHPAksJjlZ0I qJSAdXWAKT4NyvGV9VEET+a/j/keLkKZWWywneDILkfFr39ZbnwnG8Oco8BWW5jHHYcDwF 1GkvYRCUIG7ZsHNm23Hj7NAUA3a8NTQ= X-MC-Unique: RyWBl1BlNaeLXqANzqKcgA-1 X-Mimecast-MFC-AGG-ID: RyWBl1BlNaeLXqANzqKcgA_1777894623 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:07 +0400 Subject: [PATCH v2 19/46] hw/core/machine: free shim_filename on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-19-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=718; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=HkzWuVnjpE18HvhyvwlZdG6XDtkdNuA+nhZi8wBpL2I=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRs4Hm9zgRLx2kuLaxEm4HhimPiCJDmOl71p AzLhPQY/5yJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbAAKCRDa6OEJdZac 5d9JD/4scmNdG+cc6cR0bPnR/rX6WWnaMXCjPe5Kxo8Rbv0FA0IlejLziuEb/ujsrrYnyknPfMq Im3AIYiPRlQKVWh1V0BSDc8/k8EQm5kH9qrpQv7HYx5Uy+3bGrD0Xr9/8lnF0Hn0Of2UqEPd75n StesVQj68Z/JVzN+AvGtPSttrrv84csAESI+2AGWeE230NqQyDg+XkguUbYXWICmmxOK7iKYGcz A8wKPWUnlCFvgTMYVGa4o+gRUuUFbN6aXnaKSuJGapP4I7TOjsG1vo4U1gloFPPaMnUJiNb4YQg sYMFeXG9lGczuOeLoXXs+71UEKknaRSEBnFaoQBW6shGumDDep2DuBjiM7FlgHyXZ6sr8HnM/hp HGEMYgzsnCOYPgbpCViZsv5QgawkczFFsKGQEpjXtroAjErAzdJ1WbHuAH0BCsZ/rKQ7mEkB3Fy V/1298RyvaDVYZewmlwG2ZN9/ucICOqlH93HoMYzoQFXQ3fj9M8HQ99zxkI7HOq/11bIwm2KhTc /ihDfTCGt23TrB6h2KqDOC0InOQ201+zLrU1q9RqNlCIe2ymiUMH1CbBkA2lipt0KNWfG04KaGh nSjglhZQsEo039U+idcVsUnbu/EpHV9H31wiqQVwhF96Iq0ZzCXRcI7dCQx42K4Me/B1cyuLUuJ er88ryI+WFMX/+A== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894717205154100 machine_set_shim allocates shim_filename via g_strdup, but machine_finalize did not free it. Fixes: a5bd044b1579 ("x86/loader: add -shim option") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/core/machine.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/core/machine.c b/hw/core/machine.c index 1b661fd36ae..6a7fb312eb6 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -1282,6 +1282,7 @@ static void machine_finalize(Object *obj) MachineState *ms =3D MACHINE(obj); =20 machine_free_boot_config(ms); + g_free(ms->shim_filename); g_free(ms->kernel_filename); g_free(ms->initrd_filename); g_free(ms->kernel_cmdline); --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894697; cv=none; d=zohomail.com; s=zohoarc; b=AnSt2Pctl5yOR9y9obVIHdZyixFutTN0pzWXkzjuBk9TZUJsfK1xjUOfvuUo/Tj5EF1AfuN8S9zBpoo6zXwUjrWb+RnuoRRE2Qqfy24DcxXvNdJHuvgcN4+u/hFFbnYX8UhfVrOWtDHQI2AqZooqecFVaav0mWpXv4CoOKaFQW0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894697; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=vZjGVhYb4QZLufbxawDaTzTncLfnO3BZmIoFwaaoY5k=; b=f8J3+ffP/PxoRd/x0ht7214QlTzrPEv8+jqFFWAEMVrrDnqfMzwHi4fSII3+E3Nibdr9h5iq7epznUvaxCk3TTuUAdzxpF/hkUB+b5f0CRmqrcVo9Igxk6syVxI+PtvQnOJZfPdT01p9DYwdhkaeluZJAvkIjyHZmaABlBD+rKE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177789469718174.45958532401335; Mon, 4 May 2026 04:38:17 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrcd-0002Kb-3n; Mon, 04 May 2026 07:37:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrbt-00012t-2T for qemu-devel@nongnu.org; Mon, 04 May 2026 07:37:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrbr-000132-Eb for qemu-devel@nongnu.org; Mon, 04 May 2026 07:37:12 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-611-YTQjBe9qNzWIE5qtKCYItQ-1; Mon, 04 May 2026 07:37:09 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A08E9195605E; Mon, 4 May 2026 11:37:08 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 953AD18001ED; Mon, 4 May 2026 11:37:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894630; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vZjGVhYb4QZLufbxawDaTzTncLfnO3BZmIoFwaaoY5k=; b=J4RCXpdpAZ+SoLqcWwh4p186/9sTkRTr81BJNcpRcbcuhhCQGKnvbCycOe+BajE9gUSssQ Y358owUIfXeDij7F97rPkSXnJHBk/ceGOTDW9Pm5O74RtJKMhcEzKR1QfSdlcJ2Vy+wCHB Qv2JRU65O/HUhNEbQqdBu2XKmu+gaWA= X-MC-Unique: YTQjBe9qNzWIE5qtKCYItQ-1 X-Mimecast-MFC-AGG-ID: YTQjBe9qNzWIE5qtKCYItQ_1777894628 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:08 +0400 Subject: [PATCH v2 20/46] hw/core/resetcontainer: free children array on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-20-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Peter Maydell X-Developer-Signature: v=1; a=openpgp-sha256; l=915; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=ecp3xjUIPOFrGW3mQ6rq12qeT8hrpA6G57ukebTH0ew=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRsys3drwFThkmwqHtjXN8JdvOS0zp5hc5xj GD1+knW/DaJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbAAKCRDa6OEJdZac 5V4mD/9UlRMmm4YAug/ZYGAtC1pjCVCyUW0Wla6ZebxF6KPQH/vDNxicMdI9oO0G/PJEg69kVjo MiS7cUJVtmKvjV8wU4HG5b91SYQH3a6OHj0o5/vQ63Ewf8wL6CHhXky+BmFHLm6NwlexaitVtSY tumBOVxG3AvcjjR72XguN+eoS7MZmi4XdCM0Aw3hZW+t75Mjr9ucFACIq1PBpLJTkdIx0OkkdRE /Z4pJXHXNTDvnCEFF3DFDNj9ORyiFCeB5B7eaXTkBTKUbZEqYd5GwvapUe0h2hw/Ij5qkG759fp 3wVYtN8c0hueZMMDod50IpKiZUE53pawUw8sGNauquAksiUF6cujHI6BLeJguozGa5pRh4OL2p5 runJ7w7viZ5elBzVFvA2hmgg/Ecvpq9Dmebsq28qB30PK/kiI6vj4QVuQV3WLGcz4CjkHo9ut53 uF2hcfgI+2LN4Fcz+LEyZQICALhzpscVumQr1d6QzQNaj7oYZgR+aRWs6bF5rz/TmKP0f0XxS7t Q5+zmhocrctWXpyyxfAryOT7+W1AdU1mINub3oCF72OF8HBCjxpDeGkwjgmUnIOpHP0Ink18uuX zSyterv8StUMbTDsKgNv/IN37+ya/3LVwdNyMxvrqb5BDtw56GLCVJ9vgCS0o+3vaELbn4631/z rSDxipKAlb4PXLQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894698827158500 resettable_container_init allocates a GPtrArray for children, but resettable_container_finalize was empty and never freed it. Fixes: 4c046ce37af0 ("hw/core: Add ResetContainer which holds objects imple= menting Resettable") Reviewed-by: Peter Maydell Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/core/resetcontainer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/core/resetcontainer.c b/hw/core/resetcontainer.c index ef84aa2374a..a4a6476a036 100644 --- a/hw/core/resetcontainer.c +++ b/hw/core/resetcontainer.c @@ -66,6 +66,9 @@ static void resettable_container_init(Object *obj) =20 static void resettable_container_finalize(Object *obj) { + ResettableContainer *rc =3D RESETTABLE_CONTAINER(obj); + + g_ptr_array_unref(rc->children); } =20 static void resettable_container_class_init(ObjectClass *klass, --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894652; cv=none; d=zohomail.com; s=zohoarc; b=W82Pw/hwaEAL9Vkkm+w0G1/kgNtN3SvI/3RcmBZ5bP4+L5bK7TtfaPMWRa51sH6LyMlCzAV1aDrfVedUoNA3+zeZg0JKXGj4JKj5LegBkDaIzxONFYqWRV3JXi68zcsXZluEooEShWl4FVfCyI25uCdc02mtRsvLDhp6KzMpqMI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894652; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=7Zb/FpFPrbLibrxoVP3tYb6acmE/CqanuyqC4h8y5uk=; b=JsFBMIGibnU6ikEvlZjuBDqRl9zcFU+sJHt20LcJd6Rt7w9Vf8aEQa4px17KQDKeDPHQBZFDA5VaH0lloimdfJMACcyJ2LEG8x3HjzviayxeD2p0yopVhgc0iezI0D6sHHL9LC/9vbYmkPjZUayCNZ1Fm9cYOgiTTrBQ6EkdErg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894652273604.0395605092706; Mon, 4 May 2026 04:37:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrc9-0001Ra-DO; Mon, 04 May 2026 07:37:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrby-0001B9-W4 for qemu-devel@nongnu.org; Mon, 04 May 2026 07:37:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrbx-00013L-4V for qemu-devel@nongnu.org; Mon, 04 May 2026 07:37:18 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-458-9ukkhWDoNoOaDgV4odR6-w-1; Mon, 04 May 2026 07:37:15 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 616771956076 for ; Mon, 4 May 2026 11:37:14 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1B60C1953952; Mon, 4 May 2026 11:37:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7Zb/FpFPrbLibrxoVP3tYb6acmE/CqanuyqC4h8y5uk=; b=TMojME30pCRS7TUG1j/K9ESFYnQajhja7/wCqUWSgcNx1DTazwLhsMfbAhFl6e1DzJWBaj l9FfkpdqhokwxiEgmOtFd0QXYbyqrbrxqFFjP5DAw2yhKFOHYjxHrzaNoFMTsBVj9PNm9H n5Vi8DrXB1na8SG2wZ21P5q5qg5Z18M= X-MC-Unique: 9ukkhWDoNoOaDgV4odR6-w-1 X-Mimecast-MFC-AGG-ID: 9ukkhWDoNoOaDgV4odR6-w_1777894634 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:09 +0400 Subject: [PATCH v2 21/46] net/filter: free old values in property setters MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-21-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=946; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=0eCsezpNELUdUnbutLXfx310v4EwSLLeUmGSWbqSBBA=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRt/N9h3CTfx/HpuRc4Qtd4rIZcx1yEBslKf qC1hjwvlpKJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbQAKCRDa6OEJdZac 5TiSD/4uovqyJFwbCy/vqaPcdiHe1MW6zqpbjuzou5mTA3gFLOMxjxA2eZf49Ue2aQarZ1lXRzM W6k/heh0pzHbXVvW6+yhjOV6Hj8njQ8e29rRES/Yn3+cVMuQjNMnaaUdlG6tq2QpdWQHZQHcpGr zp8GLPG7/cEwyCYawIFyQOVwYefgALMZ5zAXEE2Yoz5IRy8N2AcW9fcGevuzVMxxAF4aFzIPJMY ik7w5Agf0y+D4S9jXglgmnJPRzDuJu9Z9Pk7pxnNkHZVEIrHih0GPkR8/4aHpVm9YXd2xy9doJg o+rWZBcIeNZoAPx+x4aaxdyFhEGDQLUPMlNgYb4cfbSF76GbzvUY2yoEyN8AHhtRLr+GTZiAAU9 KA3ANnkWHr2cLQdrloKnAT6xxgqouQ2dnpN4qtfjQTotGGUDGmO2HqEADgZgkqmdH+Wx9u9IB8F PQ5NCTfEISJSEtd7afz6VzfZI4jqJ6hWBghkrcDDvlzvvt1GnVwJuIpSWdX86MDm4O7hHl4sn3c 375eCMuuPp9FkxmGXN6kxsJlLC+Bl8ImVM7kvdCj2u/Jo1zOFS9saZY/bEJyCEofNtPzgBtnzST uy/br4S27hu4AevWvmurYk4e0qaZ3y+UnAbTMFQQSDF8nE0jc+IsvKznBdVGKrZ08ltdoLIS6Df u+xAqsxAIKA10cQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894654440158500 netfilter_set_position and netfilter_set_netdev_id overwrote their respective fields with g_strdup without freeing the previous value, leaking memory on each property write. Fixes: fdccce459621 ("init/cleanup of netfilter object") Signed-off-by: Marc-Andr=C3=A9 Lureau --- net/filter.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/filter.c b/net/filter.c index c7cc6615dc9..389f3b0bfef 100644 --- a/net/filter.c +++ b/net/filter.c @@ -130,6 +130,7 @@ static void netfilter_set_netdev_id(Object *obj, const = char *str, Error **errp) { NetFilterState *nf =3D NETFILTER(obj); =20 + g_free(nf->netdev_id); nf->netdev_id =3D g_strdup(str); } =20 @@ -182,6 +183,7 @@ static void netfilter_set_position(Object *obj, const c= har *str, Error **errp) { NetFilterState *nf =3D NETFILTER(obj); =20 + g_free(nf->position); nf->position =3D g_strdup(str); } =20 --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894708; cv=none; d=zohomail.com; s=zohoarc; b=cat6yTzHWdd6wBemQq8XThgs3lz8PWRsZvcPx1Sjt/F9IJ33uiVm30yvRIejaeW+OOVkFlkOxsN+F+wsjlUabmCOwdn8KkGVZZqYf+kme3yDKSg4xatuSgPQag+bdLIhmL7RpBEKqfZbVESfk5Cd+tsV3sSAEVz5gGDZsholHk0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894708; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=wuKJe960C3JZZMX2EjW66DJfgAaebcTF8mCh47fG1f4=; b=iwSMULPnjCKo7YuDsPws8NLpq9/vEXm7/0gQAidq0QgMTEKZcq/NadMz8kg3hAg5IBtEu988/fJWUsEsEmidBmwwhngOP6fXQMfOY4YhMoVj/MwqmzRlxdv7cBPqkBHHq5Mjonpk8N9gvFxvrcPh3mzsVchfKY8xWcdaH9lkvjg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894708888891.198440038904; Mon, 4 May 2026 04:38:28 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrcY-00027D-NB; Mon, 04 May 2026 07:37:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrc4-0001Ji-8W for qemu-devel@nongnu.org; Mon, 04 May 2026 07:37:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrc2-00013o-Un for qemu-devel@nongnu.org; Mon, 04 May 2026 07:37:23 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-88-lqtieBFCNfCZajFnBsL6Sw-1; Mon, 04 May 2026 07:37:20 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 171C31956089 for ; Mon, 4 May 2026 11:37:20 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id ADF9919560B6; Mon, 4 May 2026 11:37:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894642; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wuKJe960C3JZZMX2EjW66DJfgAaebcTF8mCh47fG1f4=; b=QddjaYdBS/bR77PWO/IPkc6JKLgxWB9h4imhVY//FkwG0mm0dBU4P3jK1HC6sKSG2YbxtD tcu+M5ISufpGhOt3tjf2V/xuiFmh1Y7oBPrBltctmfhKgTKIvPD0FoydonAzYUpNNflt9p aWgQuDgj1Hcj3LO7WKHxJdOzwMyWuQY= X-MC-Unique: lqtieBFCNfCZajFnBsL6Sw-1 X-Mimecast-MFC-AGG-ID: lqtieBFCNfCZajFnBsL6Sw_1777894640 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:10 +0400 Subject: [PATCH v2 22/46] ui/console-vc: destroy fifo on text console finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-22-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=699; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=bgNRmMvCBvL1ntBm5XZWmDb8LVMsoFnZArE91z4s6o4=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRtO7phVAlWYpF4TCjtZwfAj939qgYKLygx7 0vCCgovMPKJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbQAKCRDa6OEJdZac 5Y+mD/9Jm+KqyGh4+ef084LUueX7ikGFIUeql7wCvxbqmnZPcphitttwTcblon50pO3P+FdthrP dsUamZW79QeHmLkb/q06s6FbKLdRIY2HmrF94aHwb7ZaFQkJuQBJ4bRAMSn3V7DJ+ChpU8Giv7J E1dj0mlXwm+JPBbdI5gVbwwRBt16qtdj51mhGrJNTq+jwXjkLmf77CjLMgEMNKbMn0FdL8ZjO70 tiUR6TzNmMGErjYLJT2+Et+Ii3DxT337dCOX0E+BMAWDBwtGJdJFHkBFzl22Y6uVWs9N6iMSI49 AAPhtip4AB4yAOGmUHQcURrTlHJQ0bhyA82JYiNyArOONVKkzsRYQsnQoRldataXDkFSo2HHH/h ZRMNTMNO5fS4yc5TcSFcX4IDHx5J/sOdVkuFybL6hLzOdK+Sf/1RjYqoZ2Y9+k6qrK0Z2PSNtqD DLbA6dzv5WSilW5Re4HqxC/VZXiV8Q1nBckAqWpSxdONXFG73rgYBG5kauzl8AWpOGKqSM0E8gp VV3hA2IDPL1KXlpmPoT8Nf5GW26o7IfeWgCuc6cqr/nxZwdyeOgYT0mF4VKUqtSm1SPwIwUl1yG +HuI2sQP8OK/XUKkdi0qf1JRGUziTX4WGNKJL6Xf5RwmuZSCxzsPZqqyr/8oGSkw6rEUauV3u1d go8H4i2oFoN09XA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894711092154100 qemu_text_console_init creates a fifo8 via fifo8_create, but qemu_text_console_finalize never called fifo8_destroy, leaking the underlying buffer. Fixes: 0c9d0641ac ("ui/console: replace QEMUFIFO with Fifo8") Signed-off-by: Marc-Andr=C3=A9 Lureau --- ui/console-vc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/console-vc.c b/ui/console-vc.c index 6163e21d2c6..3e00d2588c3 100644 --- a/ui/console-vc.c +++ b/ui/console-vc.c @@ -1082,6 +1082,7 @@ qemu_text_console_finalize(Object *obj) { QemuTextConsole *s =3D QEMU_TEXT_CONSOLE(obj); =20 + fifo8_destroy(&s->out_fifo); QTAILQ_REMOVE(&vt100s, &s->vt, list); } =20 --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894714; cv=none; d=zohomail.com; s=zohoarc; b=E7NWakQAmVFEh/KdOWYTV9GvEgfRS1CVNSTT4h0etsrNF5nCZJ2TPtNZ4dpmF/F4CFsrwpZkrN58JVhOMRUPhq6YtXgxCg2HWSMZP9sexD861aUSptbSy+XNbcG28AsVqenemwHWzzniE0uKOFycsWnEVSsp31+3J3EL3GPOkS0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894714; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=5ENGPfGHgIxg5og8PJbEFyPyG4amh78c3jp6juMJV6s=; b=g5oyA63575PSpWdgx4lUwQP8sFFobxTJIlec9UCfQ1nAUucmUmMvQTB7BU2VSyN5FqRBLM4XvAMwW93atZ5ECTIKT0BA/pdvkED8g6dLTAQXozJDsODQVm/Z9A2k6LwFX+PFLV/sx0PwwAJwdXXRremtt5hqbDScC61GTeRdnlo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894714839811.5731022145447; Mon, 4 May 2026 04:38:34 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrcj-0002k4-9F; Mon, 04 May 2026 07:38:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrcD-0001r1-Kx for qemu-devel@nongnu.org; Mon, 04 May 2026 07:37:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrcB-00014k-JJ for qemu-devel@nongnu.org; Mon, 04 May 2026 07:37:33 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-689-5IfPf7sbMcyTG7_TmCahuw-1; Mon, 04 May 2026 07:37:26 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A0799195609F for ; Mon, 4 May 2026 11:37:25 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 488511800347; Mon, 4 May 2026 11:37:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894650; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5ENGPfGHgIxg5og8PJbEFyPyG4amh78c3jp6juMJV6s=; b=cC3NhggG6cMHvpthJqvUf1hfmOF0dYDpEYfy2DoFLzmFnH22oaC85TxgnRReiNTK3RRj7G 8O4h9VUHGY6KRny3arEiijnm6Jk+Tng+SnyINz3upZiagW+giS8kyg2swJigtEF+X/gvH8 08rdfMyD+D10Tlf8o1WGuS1quQb4w8M= X-MC-Unique: 5IfPf7sbMcyTG7_TmCahuw-1 X-Mimecast-MFC-AGG-ID: 5IfPf7sbMcyTG7_TmCahuw_1777894645 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:11 +0400 Subject: [PATCH v2 23/46] target/i386/sev: add finalize functions and fix leaking setters MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-23-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=4011; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=zRlvvqdJmibrYhLu3KatjR2sweNhvE5A5QyCSWJFiSM=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRtv9i4nWbqcSRh4XRHK8cZfB8BtohLyh2dW Q2OdWn1JpuJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbQAKCRDa6OEJdZac 5TznEACzfdpLL3CuuNibAHzg2RXB6tM9cTDK18PV7xEVb839s32gfuKVr0GBt0d8LcJTEiyO/SA HtdxikEMzXQvDbqxMx42Hmdrdt7WXNO3JhB1ZFjrVhJSU8GFibF1558yZ1exoNDIPcsSoUb5eTu wP6kIr03cDzB++GUYh2naX9UGqywWPTcFOylHGKk3zUX+a7b+UowElxfWrQsvRYbs0kk8uyfsnu Yrds/p/HgRIDlwE4jfmh4SJlHOTb/SrCe42/7PO/Xuqrz79I465xfnCqf2RBoxn30KinaM/t63C 8VKx3wbUnqluehKMH8gycEsZbAa9PCosFmRC3xxbnDzeJhZ2aswvVKexlwvC/2iOYim8vK8IHpO NpBzTsUZ9zBpYl8F2+kag8n3a5EHNzZBZSnBjgbZRcJrzAXTM3IR/uChMl+sS7BemfcMFR5vDmD sYhJUp+3GeBJv10aLMQsnPn/DvMpnK4TDuh61Onx7GEsW9Gkg6dp2eIxXL8j49/FMy0DhadZxp3 7uLqPC2qDObfXJd7B42Pv6ZfW+MkQ6cP0LNCcPUdp0NOU8CJoD7NxS5J1c4F4o9gcz0WPYZg8Fu bXfS4oBGCCqLeXNO6oyESqROMwHJ924G6L8zxUuNTJcRNgcDm379u8syhqD4df3NaJ7v2rIfDp+ 48L3bx8b6B2qN2A== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894717245154100 None of the three SEV types (sev-common, sev-guest, sev-snp-guest) had instance_finalize functions, so all string fields allocated during init or by property setters were leaked on object destruction. Add sev_common_finalize, sev_guest_finalize, and sev_snp_guest_finalize to free the allocated fields. Also fix sev_common_set_sev_device, sev_guest_set_dh_cert_file, and sev_guest_set_session_file to free the old value before replacing it. Fixes: a9b4942f485b ("target/i386: add Secure Encrypted Virtualization (SEV= ) object") Signed-off-by: Marc-Andr=C3=A9 Lureau --- target/i386/sev.c | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/target/i386/sev.c b/target/i386/sev.c index 261b6aaa37b..3c2734ad83b 100644 --- a/target/i386/sev.c +++ b/target/i386/sev.c @@ -2527,6 +2527,7 @@ sev_common_get_sev_device(Object *obj, Error **errp) static void sev_common_set_sev_device(Object *obj, const char *value, Error **errp) { + g_free(SEV_COMMON(obj)->sev_device); SEV_COMMON(obj)->sev_device =3D g_strdup(value); } =20 @@ -2831,12 +2832,21 @@ sev_common_instance_init(Object *obj) QTAILQ_INIT(&sev_common->launch_vmsa); } =20 +static void +sev_common_finalize(Object *obj) +{ + SevCommonState *sev_common =3D SEV_COMMON(obj); + + g_free(sev_common->sev_device); +} + /* sev guest info common to sev/sev-es/sev-snp */ static const TypeInfo sev_common_info =3D { .parent =3D TYPE_X86_CONFIDENTIAL_GUEST, .name =3D TYPE_SEV_COMMON, .instance_size =3D sizeof(SevCommonState), .instance_init =3D sev_common_instance_init, + .instance_finalize =3D sev_common_finalize, .class_size =3D sizeof(SevCommonStateClass), .class_init =3D sev_common_class_init, .abstract =3D true, @@ -2856,6 +2866,7 @@ sev_guest_get_dh_cert_file(Object *obj, Error **errp) static void sev_guest_set_dh_cert_file(Object *obj, const char *value, Error **errp) { + g_free(SEV_GUEST(obj)->dh_cert_file); SEV_GUEST(obj)->dh_cert_file =3D g_strdup(value); } =20 @@ -2870,6 +2881,7 @@ sev_guest_get_session_file(Object *obj, Error **errp) static void sev_guest_set_session_file(Object *obj, const char *value, Error **errp) { + g_free(SEV_GUEST(obj)->session_file); SEV_GUEST(obj)->session_file =3D g_strdup(value); } =20 @@ -2937,12 +2949,23 @@ sev_guest_instance_init(Object *obj) sev_guest->legacy_vm_type =3D ON_OFF_AUTO_AUTO; } =20 +static void +sev_guest_finalize(Object *obj) +{ + SevGuestState *sev_guest =3D SEV_GUEST(obj); + + g_free(sev_guest->dh_cert_file); + g_free(sev_guest->session_file); + g_free(sev_guest->measurement); +} + /* guest info specific sev/sev-es */ static const TypeInfo sev_guest_info =3D { .parent =3D TYPE_SEV_COMMON, .name =3D TYPE_SEV_GUEST, .instance_size =3D sizeof(SevGuestState), .instance_init =3D sev_guest_instance_init, + .instance_finalize =3D sev_guest_finalize, .class_init =3D sev_guest_class_init, }; =20 @@ -3195,6 +3218,19 @@ sev_snp_guest_instance_init(Object *obj) sev_snp_guest->kvm_start_conf.policy =3D DEFAULT_SEV_SNP_POLICY; } =20 +static void +sev_snp_guest_finalize(Object *obj) +{ + SevSnpGuestState *sev_snp_guest =3D SEV_SNP_GUEST(obj); + + g_free(sev_snp_guest->guest_visible_workarounds); + g_free(sev_snp_guest->id_block_base64); + g_free(sev_snp_guest->id_block); + g_free(sev_snp_guest->id_auth_base64); + g_free(sev_snp_guest->id_auth); + g_free(sev_snp_guest->host_data); +} + /* guest info specific to sev-snp */ static const TypeInfo sev_snp_guest_info =3D { .parent =3D TYPE_SEV_COMMON, @@ -3202,6 +3238,7 @@ static const TypeInfo sev_snp_guest_info =3D { .instance_size =3D sizeof(SevSnpGuestState), .class_init =3D sev_snp_guest_class_init, .instance_init =3D sev_snp_guest_instance_init, + .instance_finalize =3D sev_snp_guest_finalize, }; =20 static void --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894714; cv=none; d=zohomail.com; s=zohoarc; b=gTkXwHviRqHLtrbOi094ykUpflaj1pBbi4tiDQbTtQ2GnYPa3b+nmRgB81WnPaRIRggJUoILf1raamtQ1Cp2aSnjccFWgiuB0evfLiCFCCVa8wjkLNS90v/wXTFovPa0Itw/KGj/+IGt+dTXiU33QGFJCYNdIGNjoWHsWLpSZkc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894714; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Cm1yArhtz5sU59WBphWUAJT4oX4EP1pkrBrfy7DzZ4I=; b=X41VtVirZOS4o2t2sr7koIDiZSUprYQr2pejZWsvUDiN9MMO5RqrO+gZxz5qamqxVzwXTI++cuTsq3WMwZryk2lmoEUkG+xwjVJkBJUa/AUnW7EMivIRYqcLwISsjbShYJH42u/Q2kRfNYKkdpSJwDQJu5ccSwlGO6ikU1vZ6sk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894714858285.99774020340305; Mon, 4 May 2026 04:38:34 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrcm-0003EE-Gf; Mon, 04 May 2026 07:38:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrcL-0001yt-JR for qemu-devel@nongnu.org; Mon, 04 May 2026 07:37:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrcH-00014v-Mh for qemu-devel@nongnu.org; Mon, 04 May 2026 07:37:40 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-441-iVFG4InJNDqPsfsJ76hqwg-1; Mon, 04 May 2026 07:37:32 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9455619560A1 for ; Mon, 4 May 2026 11:37:31 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3A44F30001A1; Mon, 4 May 2026 11:37:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894653; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cm1yArhtz5sU59WBphWUAJT4oX4EP1pkrBrfy7DzZ4I=; b=hxsfnZSw0DNvb11THHnFQ/n91eWSbER40CIvEPgJ0z6o0bBDvK5ypUpT5L7WZdfpwWvG2b oNwa/C0dyKV5mU8SvOEOUh/jJLXJGBxrxKlINaeQIgckZXcfPm20JCXfsgkxxZ/IKdaryN Is/KXgAGqkbCxV81nv5Ra1/bxKbyyG8= X-MC-Unique: iVFG4InJNDqPsfsJ76hqwg-1 X-Mimecast-MFC-AGG-ID: iVFG4InJNDqPsfsJ76hqwg_1777894651 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:12 +0400 Subject: [PATCH v2 24/46] target/i386/kvm/tdx: free strings in tdx_guest_finalize MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-24-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=837; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=MNRXqvTukQ+paxNe0QQZQxRe4jE5rhTlC8L20HzTXMs=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRtQtX9JxEv+O0kJbEHXz4bE2RWRVIZgpamM tHpQOFLiqmJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbQAKCRDa6OEJdZac 5Yc0EAC43PcJp56qBFLKLkT2I1GTl3qEU5ehBc1lJRnhdk4ULP9WynqEA2kYWbC7AGgIRoUGXSV FUjq+xoS249crsL6pWItXd2eFDVjhZOdY0WBFycDDXCFcJ4scysM1gbL5ifomVdplxRihhjDmih TFoTGMiSqANzcQwCHNHb2tBtUQn1ZIedeiINrxkTPukO9eYikJpbtW0GGuZoXbn0IRtNqaejMVp k/t74mUH0UzT1VP1nhf6pGLBHCopdyCOt1k0HpDnNfuQMbGQFtUiU3NQhX1dScyRRObEafqPzEy GxBYpgf7BR8978MMD3ILUH7uc8noNZjhHlKEVSkPGLx3MTe2+H9lRSVJMi7ROTr5U9CgK3KKr9f 38qhvox+bEcy4bsuzOrjnbKIS5JKcyYyquBTvAapKhEDpAcypA/PQ7uowJb5l/KHlbIE1N93tQX WIXaiYWGcKgNC8UcyW43XkAB+riIJlE4V+x/gYHdzjxN0Ll/HWTuUBssWVp72X5nzLlAyoEMW2Z paEDCua9+U2mnIqEtZq32Y7vt/+nDCzPhGIb8xmyCPl/yJOMoaPcgjlYypd23sHDiSMwDTBmECI rASkVUg9ZO/tZ8FpMnHjN/5t3OorNRd9NwYfERzIFPgmjagjMZ3DIfYB8zgv7DDAK4jKPQ72aO8 pRfhPvQsv71rBFQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894717203154100 tdx_guest_finalize was empty, so mrconfigid, mrowner, and mrownerconfig set by property setters were never freed. Fixes: d05a0858cf87 ("i386/tdx: Support user configurable mrconfigid/mrowne= r/mrownerconfig") Signed-off-by: Marc-Andr=C3=A9 Lureau --- target/i386/kvm/tdx.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/target/i386/kvm/tdx.c b/target/i386/kvm/tdx.c index 4714c9d514e..df46fce7693 100644 --- a/target/i386/kvm/tdx.c +++ b/target/i386/kvm/tdx.c @@ -1585,6 +1585,11 @@ static void tdx_guest_init(Object *obj) =20 static void tdx_guest_finalize(Object *obj) { + TdxGuest *tdx =3D TDX_GUEST(obj); + + g_free(tdx->mrconfigid); + g_free(tdx->mrowner); + g_free(tdx->mrownerconfig); } =20 static ResettableState *tdx_reset_state(Object *obj) --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894702; cv=none; d=zohomail.com; s=zohoarc; b=g+iJotPEQYGGbxGJQKgwC2a8ihMxUlUg4MB/UeCyow2+eR/BI3BKusP2MhVdL3RudM2pzgiW2CdqraXLiFfB0qXpB7X6mLA3IzJrrmEzkbbXdiOs4fVb2a3Uup4NzlvKKSRdThkLsY3m1o3rY3TsuhE5B1XdgyGQcOk7/LJxuFw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894702; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=2dJKu4geQlHBf6lMxppaNvhNAzdufK74d/8yyA8VcsE=; b=aVF/7fpP+a2owRizwl1lzy1HVsyLWs2cSJKVcWDtyE3upw/exq95ZKI1qBphqjzl7rwqrOtV9l/2ZPOaJrQkcUqMOp9FKg0cqJgGyrepU8mjVjFNz9E0E2aLOlgmRH8I2BLJYfdmYH6oIjDL3RMX/e+odJ+ikMxyvmZSCIANLhY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894702860759.9474526010546; Mon, 4 May 2026 04:38:22 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrcj-0002ng-Cj; Mon, 04 May 2026 07:38:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrcN-00022J-Di for qemu-devel@nongnu.org; Mon, 04 May 2026 07:37:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrcK-00015Z-KV for qemu-devel@nongnu.org; Mon, 04 May 2026 07:37:42 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-650-HDi1kYHgMW6cd0UT88kUng-1; Mon, 04 May 2026 07:37:38 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4843E19560AA for ; Mon, 4 May 2026 11:37:37 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id ECDD319560A6; Mon, 4 May 2026 11:37:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894659; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2dJKu4geQlHBf6lMxppaNvhNAzdufK74d/8yyA8VcsE=; b=hT+zUrmzvAhULmZjBMmPsdGcGc5eo6qBtzf+pnfOqLTIm8hzSZh7LVGj5iOyJ6V6dcc261 NafalVVgESj+j3yMhOZ32YKI2BPevoYy0s9X2SKoxBNYmgh7QHyiy+DstQs/NQJct5XEMT iiIfMldudq748SP0A+vLAOxjYwJOftI= X-MC-Unique: HDi1kYHgMW6cd0UT88kUng-1 X-Mimecast-MFC-AGG-ID: HDi1kYHgMW6cd0UT88kUng_1777894657 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:13 +0400 Subject: [PATCH v2 25/46] hw/i386/nitro_enclave: add instance finalize MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-25-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1427; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=tbNjVBuNQT1J/I99CQO+THdkJr89PRbTP6A2UGBoPgI=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRtmBKol32OpJV6oTQ8cR3y1lC51DJYEKUI1 S2tEmx7FUGJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbQAKCRDa6OEJdZac 5Z1RD/9i8R/fipjKEfksf2lx9vzypHpkp2xUNzocXZqK7JZpEs69FWntDO/1zYUYvkedP9EVL0t PDYptBhb3C5Ts+wLC/doT4yilggEVZlp09Gia4NSwMx7a7Jf/uHzmPXQLVG4ZGQvQi5//6+NOrk N6A+XFOi143N5GHmFrCjZKq4N7WkafE5BT1dGxFsbcerYN6R99yb1iAnygqTJHPJdlFJdnsTleF xdkHZoRYzIE58E402RewfKbh0ayowuOMKFmR9+dpiT+FOcMIbFDeLVzFp3jnxgTU2jY0OeYuzdH r15Bg1oJHEdkmTY1dcpKGtYXUnMcQmAvXGk2vz7CMpfw1gGRAKRpN79X8qaEo5shLOh9x7Qeqy+ B9NsN646SQd6OQ4gJQnmc1PjapKxfVolUr/JH8k9FrESsgiVp2y1u0njgawgIp8JJyWV20Q8Yfr nBap+muQK1ITURyz8Og2KrlelDAylUkBv3smMRnD4MXRiBs3IMqCpx0dI3yPA3wtlGJ1uYFVvdw n/z+37lCVEEUq5xoIXopTs2WTNvTzPNS5JkPUZQcrPmRnU2aFZOwTXlbKEjBMEMbdh7jjrEL7YU UxVaj/Zj0CRNIVmeuHOwPQYHdDQwCQLHJSYlrkBCHH17rulRlx7vGFlTr20T4nYyE1GfS/eBXN+ WeDYngWxepZFmBw== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894705010154100 Property setter strings (vsock, id, parent_role, parent_id) were never freed because nitro_enclave_machine_info had no instance_finalize. Fixes: f1826463d2e8 ("machine/nitro-enclave: New machine type for AWS Nitro= Enclaves") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/i386/nitro_enclave.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/hw/i386/nitro_enclave.c b/hw/i386/nitro_enclave.c index a29f0044d0e..1ce9ee3358a 100644 --- a/hw/i386/nitro_enclave.c +++ b/hw/i386/nitro_enclave.c @@ -337,11 +337,22 @@ static void nitro_enclave_class_init(ObjectClass *oc,= const void *data) "Set parent instance identifier"= ); } =20 +static void nitro_enclave_machine_finalize(Object *obj) +{ + NitroEnclaveMachineState *nems =3D NITRO_ENCLAVE_MACHINE(obj); + + g_free(nems->vsock); + g_free(nems->id); + g_free(nems->parent_role); + g_free(nems->parent_id); +} + static const TypeInfo nitro_enclave_machine_info =3D { .name =3D TYPE_NITRO_ENCLAVE_MACHINE, .parent =3D TYPE_MICROVM_MACHINE, .instance_size =3D sizeof(NitroEnclaveMachineState), .instance_init =3D nitro_enclave_machine_initfn, + .instance_finalize =3D nitro_enclave_machine_finalize, .class_size =3D sizeof(NitroEnclaveMachineClass), .class_init =3D nitro_enclave_class_init, }; --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894696; cv=none; d=zohomail.com; s=zohoarc; b=Sw6LsA/Ndt44IDeDHaro3rL74SNwIYlLWVb9e0lCPzzmztbW2FH299YuofhpvfTPcfFgkheA6cIQKK5vOpyrV0F2XdhEpru5OlYgaVMHrYxzowSHZTiOSPaK4Jl4mBRXHQmQ0p8wrsa1tMbiNuE9OTNC7ZF8mPXnJC5kSi55IvM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894696; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=gVFopIo4aSSG9uooap2o+5uLHAWlxkdOp59XKcHx7rk=; b=AUvdyPGu7cY0p0rmhkumRbtBYabUFJOEqzML7ox4ouriU15YgexbocjwyJkwXsY0hcbZvQCK5HrUgZDQjsLaQoZ3qkYcFTtfMLJhCUH555/TcM3RUPKmU0Oz1fYI6Bl2F6f1snAwIFgPYCqYSoEegFvh4EKTgv8qTFjLQ4DqDpo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894696215254.13650925378465; Mon, 4 May 2026 04:38:16 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrcl-00039M-V5; Mon, 04 May 2026 07:38:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrcY-0002Dh-Na for qemu-devel@nongnu.org; Mon, 04 May 2026 07:37:57 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrcV-00016G-6l for qemu-devel@nongnu.org; Mon, 04 May 2026 07:37:53 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-652-HogCm4hkNRioY7Qz0HDcsQ-1; Mon, 04 May 2026 07:37:44 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5BD5118004AD; Mon, 4 May 2026 11:37:43 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9843B180045E; Mon, 4 May 2026 11:37:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894667; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gVFopIo4aSSG9uooap2o+5uLHAWlxkdOp59XKcHx7rk=; b=HZif3JeQ1zs3KM8uNLb0JrV3QX47kvc4Q0j9fQco3nbXduwx8DqEX+tYaHMeNKkGixxRyT ADLBjudCvyIeM+QeZ5pCv4B6PYnlRBuzkKzWyG9pi8yP8MVdy4546d3Tdcd1h3sAKMuMVn ghrU/ltKNaaGKK+/QZjvMIKz67bHEq4= X-MC-Unique: HogCm4hkNRioY7Qz0HDcsQ-1 X-Mimecast-MFC-AGG-ID: HogCm4hkNRioY7Qz0HDcsQ_1777894663 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:14 +0400 Subject: [PATCH v2 26/46] net/can: free ifname on socketcan finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-26-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Pavel Pisa X-Developer-Signature: v=1; a=openpgp-sha256; l=1201; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=Zz6LxsmODDv3AxwQF3PTITI8cMLmWmAnaqtuQzNPavQ=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRtP/pxDCUA7gzmwBBgDaAXf2tPzWjir9CVN mhXb5fLtfGJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbQAKCRDa6OEJdZac 5aqZEACoc+x0pzK3+Ha3fErGfb03Im66Oig27xFf5Y6akdleok27fjDwFwSky5yfDpTvsXt8mmC LuwdwRs0mRqKovcPX7P/if68pxukbBPcx8GiRGoS6kryKapjh4ntRrn2D6r4Oe5AIsaPXpQgOk/ b6V0LcCIPLv2E4O9pllHl96NGtxoGitiiKajVpTllqAMB7suMMa/vBnnHY/V+THQP/o9hbWR7sA 0AvBKfVKIJT1Wsb+I29yojnRR3aVDpdVLRorBGPF9+Q+aXiG3FBBaYweXyrF2R4iX0CXQptxlsn cBzY0aW0O5Q6SHbo70sdAoZij+irCqKNOKzWnOB1/RuECQNoXkYwBHaCHkden7+3k3xEOO2FKVD a/yaOTXRzlrRKfQLv1WgTVGPJVntBQ/zaS5PHQDcyTrc1HS16/uz8bt3Mx+H/LQX3evvGrhncdz YFTSqUx88oKDJFT0ZH3jXd5jDy5F6DS/hx8FUax0n+wZWQFLkMMAZ3+1kHLMFDDBXpp/0FzcAHH vYREhtL9SMqGVoLoEb73SH0e0hBChy1ChkZnYvFPUXlPW85J2Pugo2fkcNVEOuP0tlq716kzvQE 3Soa/KvrD9oggdpX9Y6MSSOxmSdinqSXRxCkB88L8bh/DMmeDrUKF7HpqfkgCKNeykjQhAXZ5N9 onDFho4D8ihSSAA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894698954158500 can_host_socketcan_set_if allocates ifname via g_strdup, but no instance_finalize existed to free it. Fixes: ea15ea8a7c67 ("net/can: support for connecting to Linux host SocketC= AN interface.") Acked-by: Pavel Pisa Signed-off-by: Marc-Andr=C3=A9 Lureau --- net/can/can_socketcan.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/net/can/can_socketcan.c b/net/can/can_socketcan.c index 8a57ae07178..be67ed7f5a9 100644 --- a/net/can/can_socketcan.c +++ b/net/can/can_socketcan.c @@ -319,11 +319,19 @@ static void can_host_socketcan_class_init(ObjectClass= *klass, chc->disconnect =3D can_host_socketcan_disconnect; } =20 +static void can_host_socketcan_finalize(Object *obj) +{ + CanHostSocketCAN *c =3D CAN_HOST_SOCKETCAN(obj); + + g_free(c->ifname); +} + static const TypeInfo can_host_socketcan_info =3D { .parent =3D TYPE_CAN_HOST, .name =3D TYPE_CAN_HOST_SOCKETCAN, .instance_size =3D sizeof(CanHostSocketCAN), .instance_init =3D can_host_socketcan_instance_init, + .instance_finalize =3D can_host_socketcan_finalize, .class_init =3D can_host_socketcan_class_init, }; =20 --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894728; cv=none; d=zohomail.com; s=zohoarc; b=bH6FXWAAm4utbYxZa3A04Id23PCybIiaXTrMt0ZA1qLcylC1CSlJc60up3djjXxSUcomIBRvg29digq22hC50GRpFRI2RD47fBFZew1LaToh69hAqtBEkmZo693QdWSpVXyzgBJ7OTrqjl1d+yJASMaRDTRcyeathZ/L5ekTSyU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894728; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lembz9v6KiZv95jZsVDR5zvcO57s8El7eDNrktCu2eg=; b=ZU1h3Gf6uPTqSDmm8aZoFhjJA7R3yuTKc9vSzEWSKvNfkL2xAqv/R450Gr+80hX5lsKAChMfEhAo7gzSLF3I6oweP7yMkRP7JPeS9mcBCS/fGcc95cXGw7aSiZWD/iwXKmWGbjIbneME3QcFViULMuBmbQJqM7fQJLwoaZGDe7s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894727934418.0344839896103; Mon, 4 May 2026 04:38:47 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrcj-0002uE-Vu; Mon, 04 May 2026 07:38:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrca-0002Fq-TH for qemu-devel@nongnu.org; Mon, 04 May 2026 07:37:57 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrcZ-00016n-5G for qemu-devel@nongnu.org; Mon, 04 May 2026 07:37:56 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-75-a5eEdbHbOPSh4uvtxhiIHg-1; Mon, 04 May 2026 07:37:52 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2CCF41956088 for ; Mon, 4 May 2026 11:37:52 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id F08081800357; Mon, 4 May 2026 11:37:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lembz9v6KiZv95jZsVDR5zvcO57s8El7eDNrktCu2eg=; b=Cjk+bgMa2YddpRuvd1Ic9vz4ur9y0gI1QJiY3M9v0Z2Pkb/8g/jYjYP11RMp/20RttUmy6 AhT0lAl7CIv+Z2szcfJv6lTWgGZK8afN0tWzStd0l0E99YNGgBy+ZjzyxvFZc/beyq1F/9 qtNf50rdQ3kyop8QqHd2SedDiP6nO5Q= X-MC-Unique: a5eEdbHbOPSh4uvtxhiIHg-1 X-Mimecast-MFC-AGG-ID: a5eEdbHbOPSh4uvtxhiIHg_1777894672 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:15 +0400 Subject: [PATCH v2 27/46] backends/igvm-cfg: free filename on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-27-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Gerd Hoffmann X-Developer-Signature: v=1; a=openpgp-sha256; l=672; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=6Kfg+v+zwzKqJTlQOBc+OfvlEB3y2XxqohbTMPw02RE=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRt+TA86+VjVqhw+r+eD8MN/qk9ChBONSL/x FZQML/1fPiJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbQAKCRDa6OEJdZac 5Qj4D/4yZgH8Lz6kB2nOtI5hb9tndiTuVlGet2o61VJy3kDM7/IgQM6H4cAQdPVWtGBc3DtKUj4 6cE75UF4GoVetiTyl+HwJSbAo3WO3Nhe9Z97PAZsNC/rCVOkg8vymPSRKCbW5lLptZB4AVhllJ0 D3/jLW4QdIs/A8lGjsOWha0QJf69URUmmPM+XDaCLFB9N4LXV8IPNRMgN/XpZz+3ca6ic1E3VbW P2FEOkoKTvglNu0UigGNZaOYxA1Xbwn8WLPueX/E8RN3PTKtIU+tQ3KpP57WxY8SLnfjvPEmUAh XmB5I5QYn8bCrPQ35rGpiDX5nd52zv26xuriZIpj0oH/W0IXTmqZcHY7K4sPskXjNW/oyqSvRps ZpIQcXPtBRQcOZMYYIQflGDR/rHq3IcqNCn7vdsXlT47mDP2+VNVYPDp2BI1Nk1h3MrZBOFY2vg cg7z+CPfSucNNlGJtA8wtEYC+5qWs6GF7MBdXhw/YPCNFNI89e02uJq9rWgOuzcDtFR6LNzYuYL Gb3Kb/tkjBmDWRWC7/+CBBUXpjBahRzlc/seiCofsHDsb+2dBjBYEsykcQ0De1XyeJnlEuet5Qb te9OaMNNhLex/Wxg4EvUrVyvr3LIWSaSQeWKCC7kzwf3s1jtNhx5GG7VC6efbxyYmXHbnzUDXfC g6kR6dqTAU6ilwQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894728755158500 set_igvm allocates filename via g_strdup, but igvm_cfg_finalize did not free it. Fixes: c1d466d267cf ("backends/igvm: Add IGVM loader and configuration") Reviewed-by: Gerd Hoffmann Signed-off-by: Marc-Andr=C3=A9 Lureau --- backends/igvm-cfg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/backends/igvm-cfg.c b/backends/igvm-cfg.c index 64589ca34f2..e1f09855f66 100644 --- a/backends/igvm-cfg.c +++ b/backends/igvm-cfg.c @@ -108,4 +108,5 @@ static void igvm_cfg_finalize(Object *obj) if (igvm->file >=3D 0) { igvm_free(igvm->file); } + g_free(igvm->filename); } --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894735; cv=none; d=zohomail.com; s=zohoarc; b=bS6G/TJN3FvwQdGOJAHs1WQ0u1N332k8imQkhYuo5o4L6jkWNxZ9mRNKxFOeXsTlVvrG/bUbOlFOYnP9J2MJNTIDdP/xHruTIwYY49tj1hWjFG5faRAaHeuNjV5jfTEGKFAm3xNNYmy+ksXZE6gb3saPngC2J3jESkCmL4rMagw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894735; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=OVmQ7IUeUk12NUknieiIH7qn0uIUvETj0FJeOsX0UJY=; b=WLxfkxcQDYRV/595bA1dA54sC2gJQQ1/XtuKWkvEdp2+mqQzM4cIEQm+/rqDAV9FNnPgfsJHYR4/xx17bPu/5zl5Du51j0dyB9p6Ld28EKlLPsnDHgHUDy6e6gZckYvIbKx44Rh+X/lV4sWR9JJgNVYzmKnNHakNY2C2EUNyfSw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177789473548987.6522802493995; Mon, 4 May 2026 04:38:55 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrcp-0003bP-Is; Mon, 04 May 2026 07:38:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrci-0002oo-Oq for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrcg-00017T-AH for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:03 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-308-q3q6YFaFPZK3lQODvOpSYQ-1; Mon, 04 May 2026 07:37:58 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B5C1E1800366; Mon, 4 May 2026 11:37:57 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5A83530001A1; Mon, 4 May 2026 11:37:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894681; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OVmQ7IUeUk12NUknieiIH7qn0uIUvETj0FJeOsX0UJY=; b=RRJoRhCQ2KFJtS0JlzSajiMdUG+XIrInsYw1PDmCA2D1BOUC+//xDgHEu9GPXrHVPH1f+O 5BFE3nagvCDKYOmsV3qdh6CNiTkTrXsscOCmeKeG/mnaPOML35NB8d63mxrhcnPNvyRfLs fw46pXSaME95O/QMJcNHhpKMPGtZRvU= X-MC-Unique: q3q6YFaFPZK3lQODvOpSYQ-1 X-Mimecast-MFC-AGG-ID: q3q6YFaFPZK3lQODvOpSYQ_1777894677 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:16 +0400 Subject: [PATCH v2 28/46] scsi/pr-manager-helper: free path on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-28-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Peter Maydell X-Developer-Signature: v=1; a=openpgp-sha256; l=822; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=xkwAcgxCLEsSnJnOju9M5/XFWfwI9OD8yYJlkmPakUQ=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRtBxrwfx1k+VMOrCEFbSOrmVFzEqHaC10fS LwU9SSBhNGJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbQAKCRDa6OEJdZac 5UMID/9a1shVChUuSZSMsz7VxZhHohExTsONlnb4EwugLnhkPvTI3LEDgdaGCJIq+HZ2FyTp72K 377a+hq+sjJSMgYtEJh7z2TpT/4u/S96KW86lXX0xwZRaQyY6jKCQ7++sDvAUzvxNAPn1rHRa72 Y+elm1WTGj6fDQLULnMiJMRJJnshngHX2lx//ViIZYAoaEBXHvJOhzM/OlErlvpWpwX6UB3i/G5 sAHWUQH0cu5UrQe+O5RA+jkl2aS/YuCeIi7495YULFYP+XREnphxupmDjsUR+JtVwdmsCn6Lym4 SzAxOBV5DzvDciFNNvL3SAilH99Prb8xBHzVPTkx34PAywytZlLe7qPLz83QzGZp7xZjQvkcONM Sj3fWF+P1iK1DkSJpBK+sNBWbTsB/cS+HQyGqfN1AGkm8ggAhFq5xHVennHuC8JCJtWSw8DkwAH +Qk0VDwn6qQu1f1+WhI2KEL24CEibUIYdcfgZ9503VbAwBrce+i2sTiSAvknK1+RxObVCyDBzx2 OiRKeRvDB+2+AUI1PXptA/fK/3ciWN3viWrD5dVUI6w35YDSB9QlZb+fmQya737b9+EnKaipzdR 6jmKrdV6Mx/DiMMYH1BuDxS6h+wVDPtq46FThU6kLbaXdU4mIRqomkXUXbEhjkXsuRmRNCP80wT gsSBbw20hYN1yDg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894737679154100 set_path allocates path via g_strdup, but pr_manager_helper_instance_finalize did not free it. Fixes: 9bad2a6b9d0a ("scsi: add persistent reservation manager using qemu-p= r-helper") Reviewed-by: Peter Maydell Signed-off-by: Marc-Andr=C3=A9 Lureau --- scsi/pr-manager-helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/scsi/pr-manager-helper.c b/scsi/pr-manager-helper.c index f6454cd80de..53432e6d606 100644 --- a/scsi/pr-manager-helper.c +++ b/scsi/pr-manager-helper.c @@ -284,6 +284,7 @@ static void pr_manager_helper_instance_finalize(Object = *obj) { PRManagerHelper *pr_mgr =3D PR_MANAGER_HELPER(obj); =20 + g_free(pr_mgr->path); object_unref(OBJECT(pr_mgr->ioc)); qemu_mutex_destroy(&pr_mgr->lock); } --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894729; cv=none; d=zohomail.com; s=zohoarc; b=NfQVMPrc8f6G0H4ipslUZoJNRaUAgfYwNIl7H/xp6q8mMwuZCOM+9L6BtQSxwtb0Rx+/8NjSsqocl8KI1tq92yAqCNzTKKRafuIMfbdNdWIIHGfvsz3kCjpAl7Moak/jufhbAFIXeFcq5ZhZoNuuzPFVccka3Jr15CTW4A3eE+8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894729; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xc4SYT3UnDMGDLgyYV/qbHsyXvfJpgId4SJTPvnG1QY=; b=g+PFdH0RaxvCNYebaC98a2N9inHL1dBr1m/l4g2X+f/uYDFnpIVHZruARff6kxq9kdwXE/UvOOTCaAs2p69HgN5BQ0q8urHKqtbpLkx9b4u6zXoI5Csx37IjkZUju9TjfarnF1eOTsLnf3xGxRdarQ0LhandYDgfRR4OLPaYHuE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894729537485.60102828537083; Mon, 4 May 2026 04:38:49 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrcr-0003pG-O7; Mon, 04 May 2026 07:38:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrcn-0003Rw-PY for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrcm-00019E-6I for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:09 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-294-J3WzS-EkPz6dGcGkuAukjA-1; Mon, 04 May 2026 07:38:04 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AC9BE1800348; Mon, 4 May 2026 11:38:03 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 55F951955D84; Mon, 4 May 2026 11:38:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894687; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xc4SYT3UnDMGDLgyYV/qbHsyXvfJpgId4SJTPvnG1QY=; b=Voal91GO1/1uKbf3xrIUQ1A4fSwJDuLerhJugPkA3AFc5hNu/V+zgjlncAF1OzLSTgoySE TqK87WYyfijZToMG27Haq9wPMUPKCRaGgA+IURtUx0EiCEx7ZWaJzLbWi0JNX8j74WsvL2 llH0rf6T/Kz1u8fdSZIy7fPNdJEYScI= X-MC-Unique: J3WzS-EkPz6dGcGkuAukjA-1 X-Mimecast-MFC-AGG-ID: J3WzS-EkPz6dGcGkuAukjA_1777894683 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:17 +0400 Subject: [PATCH v2 29/46] accel/kvm: free device path on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-29-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Peter Maydell X-Developer-Signature: v=1; a=openpgp-sha256; l=1095; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=+3VxTolW7meb5x/gWd6Oe4Wp6U24+GJpNUhUzxlJdXM=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRtXo4gNvFN5HsiKYwHneoRWVXav8hTQaR9/ EN2lVcNGwWJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbQAKCRDa6OEJdZac 5ZBLD/sF0VqaziShcXG9xeWw77zl588M9pJcs/ZQYVWCQ/IlBXh6bm8n4cPzffKDtQ2gIiXl61L Jr4LMbhviar5ovhH2XAExwvFs9afnt8eUouzjp8SeXuyJP0YfBAFUv4TzVWf0ss3pNW/tAg7L8W 515m8v8/PJ5lesgjc1Nhq/J7iIWcaaCzU2cSY6SuwMcj3NQMcr6rW8UUfUvIoXBEpiH7c1ZW/ZV qnz6SzdjDGs7QObn4kfnCmbKSqPX21a7xHibrBfcJnzU6MkFoYGWQsTTHocJD3pzQQ1MaxZhLuY lSwdZ6V9u3Sl7Yu6Tdv67VU4m1pqlk97jsvqEkUwZA/PxllwpLko7g87kU8KQj0ty3epXf/XZ07 /q5BUE9RucA/DClbHWmQ0Qkb7MfiN+Iauic9XmHlbZLW52mytAJGqT0ZUX2QmbAFJFFE2ADbhB7 NLKx+SB1UHoMuYCMx4xW3+I7uFstuQQusPAsVWMRXxKtiFAbtwUvAFf1sIRI16rObmXGQ4GjTIn 2fVAj8PzTqeHVr9efIy8+uOeid87g/p26ioZJWvGAwBg7+Vk8IUxsDbdlUK3dqhRnoQCXSj/947 gYhADucZ10I9ZlYiw2Vxkk3VdC0EHtwW89V339GzANaCA7dpi1DD1WBbgFos8tp93+aiSRvDxim IlRoC1M85MVVM9A== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894730777158500 kvm_set_device allocates device via g_strdup, but no instance_finalize existed for the KVM accelerator type. Fixes: aef158b093b9 ("Add class property to configure KVM device node to us= e") Reviewed-by: Peter Maydell Signed-off-by: Marc-Andr=C3=A9 Lureau --- accel/kvm/kvm-all.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 92af42503b1..96f90ebb240 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -4342,10 +4342,18 @@ static void kvm_accel_class_init(ObjectClass *oc, c= onst void *data) kvm_arch_accel_class_init(oc); } =20 +static void kvm_accel_finalize(Object *obj) +{ + KVMState *s =3D KVM_STATE(obj); + + g_free(s->device); +} + static const TypeInfo kvm_accel_type =3D { .name =3D TYPE_KVM_ACCEL, .parent =3D TYPE_ACCEL, .instance_init =3D kvm_accel_instance_init, + .instance_finalize =3D kvm_accel_finalize, .class_init =3D kvm_accel_class_init, .instance_size =3D sizeof(KVMState), }; --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894716; cv=none; d=zohomail.com; s=zohoarc; b=QwBBow1sMxPEw4JP2JwWo8q2qTHHkYIxqewzwWPPPhLqFDboYUQ9em1pasJ/QEAFkNXdyfpz9ud7jemE8bYTV6dJiJtuun2RQCb2foeqUE38eZH6x67vFwhk1gZst0X0JbEUsuI8Oc/GNfPSN2WlQSD0YrHHRH8VygsoOV9wt80= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894716; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=82+lAluaZQmwO0cbys/HebvHtb8nAYQwYC80HeZ2EvU=; b=kOOK5WZ4kXnO8OAvXzdEv5hNgN5J9oWmw5tTjnryYuMuJE58C/NLHbDdvbDlIxKj6PU5LXjkuLI1dEm72u7/totmns3tmxjB1Q5YIQThq7hK3MotOroh/fPw2UBgM946IBvVNM0VAAu3Qo5oaArJhI5NJB/s/IUGUVIpL5VgG+w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17778947161791012.6733589732148; Mon, 4 May 2026 04:38:36 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrcu-0004Ek-Vu; Mon, 04 May 2026 07:38:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrcs-0003vm-A5 for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrcq-00019h-Qc for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:13 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-584-uqYrgyp6NxiyfV6WVTYoUQ-1; Mon, 04 May 2026 07:38:09 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1D73D1955F1A for ; Mon, 4 May 2026 11:38:09 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id F00B930001A1; Mon, 4 May 2026 11:38:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894692; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=82+lAluaZQmwO0cbys/HebvHtb8nAYQwYC80HeZ2EvU=; b=YSlPYKf3KRhjh57+iTLR03f8qfd5vYCOe07eYSOju2l+BAFr5dRaeo2J5AWavgyxTHDtiJ 8UzN11r5LHh/wR6LNlguxVzGtK8hOwAQ6J/IoDGeLRa3kWmp548HqMIHaLUZV4gqk9p2dd aoRS/v/wK9jrPYlPdVqVN00GVP0fY4Q= X-MC-Unique: uqYrgyp6NxiyfV6WVTYoUQ-1 X-Mimecast-MFC-AGG-ID: uqYrgyp6NxiyfV6WVTYoUQ_1777894689 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:18 +0400 Subject: [PATCH v2 30/46] system/qtest: add missing qtest_finalize() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-30-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1010; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=9AkKHVjOuoPxJmyGfw1IlVjKN2smzpd0Yrdw/2aWqhM=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRt5jmaObgzU+ELnzZ/U2VrHYFUIjUD7qGuW VrwfVDGAKCJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbQAKCRDa6OEJdZac 5UlMD/9Y7laAhkCD4IlrZ+9OIj253VKlPtvz8cnjIvsrGzN5OJwKYyObcyxvFmbNXnqpXHElPMk JU7ALdZiQCwihD5EmI3Ri71aK8MaEym7BTNh3jaFMrCqcTrKTpzocuC4hu+dRCLSzCPijD/aU3C +rsoem+frqG6hIzF3g4BcI/VpfUua6G3WjK46rGWslX0M21oWaYEx0r7FSdL0YvpPPbrsdeC9dp PhXKKN0EYgpoIxXOPL39G/jEhuGclQaPlQ9speX7PrqZlBXl2bBX1wHmPRU9J3gSvwsftdjvRLc LMA8J5gYyKNdBnvLqFjuWXKqr9wO6hDGj0CgilAGd4ktZvlu+vXfG8ki/+p016FXH/piYyFKJcQ Kf15FDoOdS1Kg8WYcohFIHeeYoUpb7IU2HNYXXgEPXR4h2n6MoG8gZclOR5774c2u92FQ6jOSzS iBbDWcSa6CiA1atSmruNqp02pueOCVB3QXZRbrSn8KrXvo67J/JbLlLIGNIUFEXk/FsvQOFwcaB tSrCFx+zCuiEzWi4jRI1PXCTp9834+LRriV9uC4jMNEM6mhEG+Tmcik6pJZlrCtFGo1K4urBy5m IwE+yTy9uvv+6nEBYiwEXgkTnKFeo+7B8TcC9c+YiYZSL3vGnC126FSAyjlf6PYH4V/WEQI5Whv 4wlG50M5cWRDmEg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894716720158500 Free owned resources on object finalization. Fixes: 6ba7ada3559e ("qtest: add a QOM object for qtest") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Peter Maydell --- system/qtest.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/system/qtest.c b/system/qtest.c index cf90cd53adb..a79d10d1361 100644 --- a/system/qtest.c +++ b/system/qtest.c @@ -1020,10 +1020,20 @@ static void qtest_class_init(ObjectClass *oc, const= void *data) qtest_get_log, qtest_set_log); } =20 +static void qtest_finalize(Object *obj) +{ + QTest *q =3D QTEST(obj); + + g_free(q->chr_name); + g_free(q->log); + object_unref(q->chr); +} + static const TypeInfo qtest_info =3D { .name =3D TYPE_QTEST, .parent =3D TYPE_OBJECT, .class_init =3D qtest_class_init, + .instance_finalize =3D qtest_finalize, .instance_size =3D sizeof(QTest), .interfaces =3D (const InterfaceInfo[]) { { TYPE_USER_CREATABLE }, --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894755; cv=none; d=zohomail.com; s=zohoarc; b=EJu91EQ5PDPNJBR2Ng9mlEPfH7vOMF/8WBymKwhSnndupYJVq+KX4vrjtLA9R6WtxdO8QTPMfX4gGZ7ah6j7L+iKwiFa2DTk8KciRmwxeWMYX9w+sclNH8lkv5suQdpH6QlFF0KhU8msjHep3VEtKS5SCVv/LwT82ZhzuDJMYWw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894755; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=u94aymaMQos4Ok1FqE43DnNiM5L1ZW3yqR+cto55E4c=; b=c9axAVO2oj2an7ZdGYaNQ82DJEocPXaNB0vuL18MptMcAM5dWL9Um8JyryFGkiWv881lXRcRwb0lluZnUPFY2hvjJNCGpx2EG/axLZxfl0Nr5rh7L4mtT3AWKV9XodF7ZE0VOSogFQr4Hn44MUzsGAGqfNYVH6mj4x1zTqnPBIM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177789475590581.92708684035779; Mon, 4 May 2026 04:39:15 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrd1-00056J-2J; Mon, 04 May 2026 07:38:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrcx-0004bd-16 for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrcv-0001AU-Al for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:18 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-318-zvlHHODKOOG1f7_53V6GZg-1; Mon, 04 May 2026 07:38:15 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9409E1955F12 for ; Mon, 4 May 2026 11:38:14 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 372461800480; Mon, 4 May 2026 11:38:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u94aymaMQos4Ok1FqE43DnNiM5L1ZW3yqR+cto55E4c=; b=S1Ibgy0SLLNBuTcNWJLyOVb4z3WWkzmzcfsNgd/YWSGuJfTjWflDA2US2BTG8pvYpPes6U wITNlOFxd6eIn5ESjCzwriimzdnVaHsimGQjpg3tdn4kiTQfBQmtjBM0YYGdRPcNSRQO8N f7BLerkPiu9krmL1/F137u4tC2CRihU= X-MC-Unique: zvlHHODKOOG1f7_53V6GZg-1 X-Mimecast-MFC-AGG-ID: zvlHHODKOOG1f7_53V6GZg_1777894694 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:19 +0400 Subject: [PATCH v2 31/46] hw/i386/pc: free pcspk on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-31-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1234; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=nx/Hm05PL6UbVe3ziRxkh2R3TZg6+6BhzI4zbHucfHg=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRtm7mN7Afu/0v0L3zWLhbBpXKAZusND8HOT VQpfdOuuieJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbQAKCRDa6OEJdZac 5ReWEACLpjVlXaq/KPe5L00IqE6NJs6VX7jhxffAfw6cr73p9YC8IFL7VKMHyVAKLOEa3M8CNZH 3JvjxbDtEEyKXxYVWemhDTucRtDtAJBhPXyMUaMWd8F82CqFCxBC1dDJ38fVDMt/Vd+nFlvH3b+ lpuWNG+HjIrmn5XgfFBxHVPLVQr4jAHTRSJTbVT/ZJup400f9voWmf5GMQr1+gW2P4H7eSP3K1H F3sBVz8hwEfTvzxd0dbPUOMZXQCoXP/sgSG1eMSnIhY8Z2ubaSRZvYeHvClmX6P5DzcL3pcJfpu L4UbqahC9JRTprHohCVStmTq5Cd7Ypi6DDzUHEXvJFVYEsiTOwkbRo8LwH1QMppUmMOjRR96ZcU 43uC2wNduII/qJL+q31eAcWwmoFftikgO6X3kP1jq9tCwkJNG535mjS0Kj4e4JptclLyOLB7dIg GbxusVrdYfy5yKP5ECAERAf/5vTqieIpj94ikOS+D+4fdbFGgs9BHujqjjM5pMaNXCGSbWtDlP0 GN2zlLzQRiwRnJ90W27OoCr5lrkCb2vRgCnsufAHmMlWECMkozWGyl6uG7VrZ3FTgQfOB5fIR7a DIwNowhr9DrjOtbsSbGWLx5ELm42tA+XAhUzf4OKjl55l8NN+qJufYg2aGcw4ja6hLweBbvkQ3m x/+I5YujeOQhmUg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894756928158500 Add pc_machine_finalize() to unref the pcspk device when it was never realized. Once realized, the bus owns it and no action is needed. Fixes: 6b8d1416482f ("audio: create pcspk device early") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/i386/pc.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 2ecad3c503f..7b6ad97e5a9 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1610,6 +1610,15 @@ static void pc_machine_initfn(Object *obj) } } =20 +static void pc_machine_finalize(Object *obj) +{ + PCMachineState *pcms =3D PC_MACHINE(obj); + + if (pcms->pcspk && !qdev_is_realized(DEVICE(pcms->pcspk))) { + object_unref(OBJECT(pcms->pcspk)); + } +} + static void pc_machine_reset(MachineState *machine, ResetType type) { CPUState *cs; @@ -1748,6 +1757,7 @@ static const TypeInfo pc_machine_info =3D { .abstract =3D true, .instance_size =3D sizeof(PCMachineState), .instance_init =3D pc_machine_initfn, + .instance_finalize =3D pc_machine_finalize, .class_size =3D sizeof(PCMachineClass), .class_init =3D pc_machine_class_init, .interfaces =3D (const InterfaceInfo[]) { --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894747; cv=none; d=zohomail.com; s=zohoarc; b=hm8Sk7M5jU4ARHA1PMz3ESNRJWraNRmUVSyHlWas4JqmRR4I+/nBD+Vtqb3lybxkvI9pB9NPyHMIieBxp1IIGprE5HoXECcUPEkXdj09a2vAJSnxMLcWp8gR7MXfTE3jDlVYcNu7NkeL3xIYObj6KuenGW3ENc8Ck360tOTqhm0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894747; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=UVBuI+EbJBte7cudwIUDMDVUZlvs1SZgaSQuqt1SPTs=; b=B8Qj4wY15iWRvtz8+kVL5ArqVmOTNOuQLVIevZVREG4G8VFdjb/eiiXVbTGOXHJk9a48GnVmDtnuEit1McIwPATn4ea9l/INum4ZxezT2rhtQ00OF7o6jeMda3PJjR7HNaGxjVZ2GTT5KWzHs9x/JSh5gQrikFK48xorJWz5hOk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894747330592.9370482985337; Mon, 4 May 2026 04:39:07 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrd6-0005fz-Qa; Mon, 04 May 2026 07:38:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrd3-0005Tn-BM for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrd0-0001E2-NB for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:25 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-63-mANkXZGIMmKkzw6VvpauBQ-1; Mon, 04 May 2026 07:38:20 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E6881195606C for ; Mon, 4 May 2026 11:38:19 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id EAAEE1800480; Mon, 4 May 2026 11:38:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UVBuI+EbJBte7cudwIUDMDVUZlvs1SZgaSQuqt1SPTs=; b=UqlYLBPabTfy/Eo13lWpxZnaW6zFyaYkXW8GuPVs1oNqaGDVGm+grawwkigINmbiZBvIRc F9MKOJs2yJ5T+aShRYD/KPlcOmZzHhLnk7RTCOtsqEzLrTDcOb7BP+xbS8CyzO9tb/ch7S y7VSXIL5zAGeqIXJ3pQ/NeeG4FSxdmk= X-MC-Unique: mANkXZGIMmKkzw6VvpauBQ-1 X-Mimecast-MFC-AGG-ID: mANkXZGIMmKkzw6VvpauBQ_1777894700 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:20 +0400 Subject: [PATCH v2 32/46] hw/tpm: free PPI buffer on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-32-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1254; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=+gbtJ/99XwN9Q6M5HxsUiEi2wFIXez1EC/KRfHjlUrQ=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRtYTmF8+gyP72Dd5S8PuxtBhXsxpTe6eXQ3 SnGgW4VnyGJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbQAKCRDa6OEJdZac 5fAjD/4/BstuHa1Wyv3+WBmBEPEga/Y/nAduf1UrVa4DU6CYB0w4lbNIf3RVmoYX+2bz3uFgvfi Gbc5jTMlP6bqujYi64wQ8nZfn4IAfyW0nVHTTFLfajRHChuU14NhAHqghX09UAYK6P2FfI3iyx6 xlEflvCZJXdcZNde4X+q4FT+S9PGa4MtcWJn6PlBrwcSvGHRhEOWv0GsrJogx9aYUk6/9fKWqZh LPNgfy91uu3Al8KcR3YdpWp+66qzDjQJtgXbTIQO3XTiKBCkORa7ADijXjcp3lqDQ6lkiDdwneP iUn4znghYJKkaU8Uo8f1YEoGkF6tPqhKpn0bKhvsRza+sCBqK99lxZohBobyzUeXBzeKBdMhWS+ zipbUKnI96bDoark9hu0WhMXNEDB2APIn2WoH4ht/r+v6ANHVuxp2Rw+ADbtofiVaK4PBZJfXRE f6ZRb6H0vPVQrHmdZBJcddFbUizkEYbran8FsmOBNIYIn232P+q1RL7cda/pYwdDMn3cQocRyT3 H1QZlmTggT1C672gm2bT05kvn3VvdBdK1Vjg+QPqtBuR64imZmCf5j92glexxMZ+aKyId9L6YMp lRy2NQywR2x9ycxKcnfgcd9GZPAdpyysv+bqn+hpVgilztKM2VHioXKJ/nSCRfVHqPj0DhH4F8d XQjGPfmYAo9GAFA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894748872158500 The PPI buffer is allocated with qemu_memalign() in instance_init but never freed when the device is destroyed. Fixes: 46cd2c1050f0 ("hw/tpm: add PPI support to tpm-tis-device for ARM64 v= irt") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/tpm/tpm_tis_sysbus.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/hw/tpm/tpm_tis_sysbus.c b/hw/tpm/tpm_tis_sysbus.c index 6bec30c36fc..3984228c42f 100644 --- a/hw/tpm/tpm_tis_sysbus.c +++ b/hw/tpm/tpm_tis_sysbus.c @@ -150,11 +150,20 @@ static void tpm_tis_sysbus_class_init(ObjectClass *kl= ass, const void *data) set_bit(DEVICE_CATEGORY_MISC, dc->categories); } =20 +static void tpm_tis_sysbus_finalize(Object *obj) +{ + TPMStateSysBus *sbdev =3D TPM_TIS_SYSBUS(obj); + TPMState *s =3D &sbdev->state; + + qemu_vfree(s->ppi.buf); +} + static const TypeInfo tpm_tis_sysbus_info =3D { .name =3D TYPE_TPM_TIS_SYSBUS, .parent =3D TYPE_DYNAMIC_SYS_BUS_DEVICE, .instance_size =3D sizeof(TPMStateSysBus), .instance_init =3D tpm_tis_sysbus_initfn, + .instance_init =3D tpm_tis_sysbus_finalize, .class_init =3D tpm_tis_sysbus_class_init, .interfaces =3D (const InterfaceInfo[]) { { TYPE_TPM_IF }, --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894725; cv=none; d=zohomail.com; s=zohoarc; b=DBpdM5zur8ZpIbCr0NNWUlUD2djX37xNkFoa/F4rUosuMYRvnfBnZrW1NEHxkH/r1TolEOqZKOerSXgcOR1IHxEnMYNzmQCnCnIw8Pe64tmp4DZKKLOLEx4WpQEAIFi0Q4WFcPEhT6dalmdvgmbahQolc96vVXwcMVH5B78Rmn0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894725; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9uhmtc7dYjQMN1jMZa6kxMNc/KRWfHf/T/TyMWiJ680=; b=FO1NH/MhXbTB5p6gtgXRjtyDRcbD8h4006IKQ9LPCzcvgGoiH1xRJY/1BDXKt/1N7050I3Z3oM9t5KtU4UbLuzMBa2ngynBrF+DuOyE+S1v0BIgptP9/8GCy3+wh4xQQMLtU6W0Lh88B+goffDpaj7/uKoD6SwZ5x3tJ9QwMbyk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894725249339.29833697745994; Mon, 4 May 2026 04:38:45 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrdB-0006Bf-Ta; Mon, 04 May 2026 07:38:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrd8-0005wv-6d for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrd6-0001Hr-J1 for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:29 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-654-OiiLnOkQOAqJYO9hq9Jasw-1; Mon, 04 May 2026 07:38:26 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DFD4F19560B5 for ; Mon, 4 May 2026 11:38:25 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 18B1F1955D84; Mon, 4 May 2026 11:38:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894707; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9uhmtc7dYjQMN1jMZa6kxMNc/KRWfHf/T/TyMWiJ680=; b=MXbgAK35imNkJpE2eg/t6l8Ue5e/ZA7EzrpyoYosBLF7DDeSyIrESJhIRvE9VQ1ElNMZcf rqfIDGA70ChhB2hfdIaVqPzHT5ljSvzJ7XJWQ5TOLCO4g95wzhn4bWxDk+XA9yqbOIR4j6 NSWaeBdJOHhhinxhk0e5SNo6H28uZz0= X-MC-Unique: OiiLnOkQOAqJYO9hq9Jasw-1 X-Mimecast-MFC-AGG-ID: OiiLnOkQOAqJYO9hq9Jasw_1777894706 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:21 +0400 Subject: [PATCH v2 33/46] hw/fsi: move OPBus address space init to realize MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-33-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=2041; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=KILJnJhSBQUK/Muq0oJYoyL0XcLZf7mKortd6mZZUGU=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRtkHwrDnUZIC+S8Ez13lnmT8rBpw5EvgQr5 /BfpM/ui5+JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbQAKCRDa6OEJdZac 5V24D/9UPKuMHvfCzcumfKeS063iVTHyhYb+539Vpig5f4Xp18Gk/cr7lAmMnfkeQ66xvsYfRZk iKZFEEIePAmQrG8LBmG/G9tUaKuPL1aFRdGKKLP45XUaHmecI9LRmE71jZuNf24YfH7C0Y8MN6K Cajm+UoUMOTswAVKPNZLvWVmgRBVgFd6PgFPdtzhWAxtJpGLyKKGo9KxSVYCQmdIPgml8jE1lhL hVgPFydheMT+iQUT261nY3osxemGUnp21EGE5wwTZczFgzR++P+NGJupvroIQdOZwVuVDmyp7L8 qYDVCkdogbNje4GvoodbliYMYe5mBoiVZZlJHLa5TwIgEAVJslk7mUc91OWDtbSYpYW+L3w2hTg rIYEOvENz5X55fQtCPwxcB6rTdLQzii5UYXKJ0FtkhdHLpLr+WtoYgjxPlT0x9rRTossPSeZR/G XDTB2xfM/vP3XR+BYbhmQ6ZfkBw9rjb7yfGch3lUgGezNJb3Oj5dC3iqsPYBIcoCloV1+6zE/Vs oIhY5srXSVNjhPiVZNfrclwC2MrJS9QyslklOtARpvGYWJCqS96cbfVJR1EyHqGGaZjUqvVWMsg sK1LdtFBKHT6duhsHvbQY7kr83XVoXaf7y1JUVhjzpI+n6W17xsyZgrZD0KBlrj87E/T1MVR7Df XjsicoeWiiYMUnw== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894727360154100 The OPBus instance_init initializes an AddressSpace, registering it in the global address_spaces list. When a bare OPBus object is created and destroyed (e.g. by qom-tests), there is no finalize to remove the stale entry, leading to a heap-use-after-free when a subsequent flatviews_reset iterates the list. Move address_space_init to the bus realize callback and add the corresponding address_space_destroy in unrealize, following the NubusBus pattern. Also fix the memory_region_init owner from NULL to the OPBus object, so the MR is properly parented instead of dangling under the "unattached" container. Fixes: eb04c35da2c0 ("hw/fsi: Aspeed APB2OPB & On-chip peripheral bus") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: C=C3=A9dric Le Goater --- hw/fsi/aspeed_apb2opb.c | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/hw/fsi/aspeed_apb2opb.c b/hw/fsi/aspeed_apb2opb.c index b9d72f3ecf6..36092468391 100644 --- a/hw/fsi/aspeed_apb2opb.c +++ b/hw/fsi/aspeed_apb2opb.c @@ -348,15 +348,37 @@ static void fsi_opb_init(Object *o) { OPBus *opb =3D OP_BUS(o); =20 - memory_region_init(&opb->mr, 0, TYPE_FSI_OPB, UINT32_MAX); + memory_region_init(&opb->mr, o, TYPE_FSI_OPB, UINT32_MAX); +} + +static void fsi_opb_realize(BusState *bus, Error **errp) +{ + OPBus *opb =3D OP_BUS(bus); + address_space_init(&opb->as, &opb->mr, TYPE_FSI_OPB); } =20 +static void fsi_opb_unrealize(BusState *bus) +{ + OPBus *opb =3D OP_BUS(bus); + + address_space_destroy(&opb->as); +} + +static void fsi_opb_class_init(ObjectClass *klass, const void *data) +{ + BusClass *bc =3D BUS_CLASS(klass); + + bc->realize =3D fsi_opb_realize; + bc->unrealize =3D fsi_opb_unrealize; +} + static const TypeInfo opb_info =3D { .name =3D TYPE_OP_BUS, .parent =3D TYPE_BUS, .instance_init =3D fsi_opb_init, .instance_size =3D sizeof(OPBus), + .class_init =3D fsi_opb_class_init, }; =20 static void fsi_opb_register_types(void) --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894799; cv=none; d=zohomail.com; s=zohoarc; b=JV4AoYsdYmOkw4VN/ZQD68FoIJrwvAfkelyaE+E9vxK7bwlste+IaR9C7HY5ToWTxU2Fgb26koLWW4xxgc5AmiQuLUWcr66SvGXWybQkG8SXuU0+cGkkyCON+iZkWSfL8D2iN8+VAvx1r7efwLt0MXbQWfiikRVyJEfs+9/3ZRg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894799; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=R0bsIIMKhxFpIJn0xl6jXJpi31e37LsGmYzmuzP6pM4=; b=SuiIc18ZXR+G60FUg7+iv8a5ide2xKqwMYkpmXEqYiZXNxkh3yi7CbkZI7jEbWjjnpTFiIdoyyZ36iQ8hwhqgDC+Ab/AYtfqAs0wcK1/ytI3Mcj0rB83SJ4P2vwlIxxBojQAdOqluAyirdjgs+mraI0336y4X2oBRFPmS5NWhZQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894799338119.32195732005891; Mon, 4 May 2026 04:39:59 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrdK-0006qm-Fk; Mon, 04 May 2026 07:38:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrdF-0006Wo-Gv for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrdD-0001Il-Ps for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:37 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-30-_x_9NHkxMY-Wyjy6jtvc5w-1; Mon, 04 May 2026 07:38:32 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F1C2D1956053 for ; Mon, 4 May 2026 11:38:31 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 63E3E19560B1; Mon, 4 May 2026 11:38:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894715; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R0bsIIMKhxFpIJn0xl6jXJpi31e37LsGmYzmuzP6pM4=; b=J5E/rmy/0VZOWMUXTa5OV8E0ItAvZzjRgZ7dXKZXC3vjGme9wLSH7Fs+NO0rjd6a9BUhyu F2FMETXDFtbBqSdW8LEreHCXEWeQlRHjUfU+/Fdve9P3lzvxznM9fsItgNtqFbQzM4MVng hxfnurcrcuEDoWTl7givFprLbidBU2I= X-MC-Unique: _x_9NHkxMY-Wyjy6jtvc5w-1 X-Mimecast-MFC-AGG-ID: _x_9NHkxMY-Wyjy6jtvc5w_1777894712 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:22 +0400 Subject: [PATCH v2 34/46] hw/fsi: move OPBus qbus_init() to instance_init MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-34-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , =?utf-8?q?C=C3=A9dric_Le_Goater?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1604; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=CVudjOeCyZzDTPF5IBNWQlIgSw+1Rz8G/fZyKfzNExw=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRtZ79WtCadqntEqeNDEhdxBLIEkOMbnlciD NtU3PK2QwmJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbQAKCRDa6OEJdZac 5a8/D/4pwdSQCD7+NMRTqLTM6CNdc2m1lYb/kNngSd6LxcPoc3wHUylgG4L8nbQkNSkdLq7nGxO NfR9mSYuVrylntmbxQtES8uzvB1COP2N/OH+N/c+z3RsvV/StSaymDCkgD/yIBVbKqHPk35Z6EM POVN2WknnJbXQClJDBpfIb5Z5XVZ8QPXIVZxEf5L0gEL0piDDbaRAPVkWQJFf1cH6ad2inAonw3 LJGvymaLYpHhdHc9p0RhDVx1e8LoWwN4Fgafe2YfLbHMPlnubgH8MIOXLsr1/Vso+dxQN/YJwvm JOeoxgl6qBf6jWLTu7NFuKHqco4wkSNxCni+zffWbfzFdNnApvhSBr3cFMFLGvwIrcTUQk/T9j5 RfHn6MQ/3sBhDfKBurs+e9rK+BXkdNIVCgPcFlMEVQyz4KXmdJBWvHB4adf8LAtA+1kU4xVMTHk 2D3/nxnuMqNvSMy4mDuxcWgdxba2xKfy+rXiYoIiAGQTWA3S6kE4GxSiFuDxhLyfIKi73ZTqnCF P5qqmzDIj94djIj8oQ5R872cQKqYGdMMEZh08GPj+/htnNoZbvop3geB9cHgDgaaS4C6pguMwfi 3XKXNRqwArLJBrtXc5cmMK1w31lNgOiqj3I/kFl5aCzhkQjmXucwt+Aq4o63gUBTLnXkp3BbCP9 gb2RFcVrF3UtdIA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894800547154100 Remove the TODO comment that documented the workaround, as it is no longer needed. Suggested-by: C=C3=A9dric Le Goater Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: C=C3=A9dric Le Goater --- hw/fsi/aspeed_apb2opb.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/hw/fsi/aspeed_apb2opb.c b/hw/fsi/aspeed_apb2opb.c index 36092468391..058abc86452 100644 --- a/hw/fsi/aspeed_apb2opb.c +++ b/hw/fsi/aspeed_apb2opb.c @@ -273,6 +273,7 @@ static void fsi_aspeed_apb2opb_init(Object *o) for (i =3D 0; i < ASPEED_FSI_NUM; i++) { object_initialize_child(o, "fsi-master[*]", &s->fsi[i], TYPE_FSI_MASTER); + qbus_init(&s->opb[i], sizeof(s->opb[i]), TYPE_OP_BUS, DEVICE(s), N= ULL); } } =20 @@ -282,18 +283,6 @@ static void fsi_aspeed_apb2opb_realize(DeviceState *de= v, Error **errp) AspeedAPB2OPBState *s =3D ASPEED_APB2OPB(dev); int i; =20 - /* - * TODO: The OPBus model initializes the OPB address space in - * the .instance_init handler and this is problematic for test - * device-introspect-test. To avoid a memory corruption and a QEMU - * crash, qbus_init() should be called from realize(). Something to - * improve. Possibly, OPBus could also be removed. - */ - for (i =3D 0; i < ASPEED_FSI_NUM; i++) { - qbus_init(&s->opb[i], sizeof(s->opb[i]), TYPE_OP_BUS, DEVICE(s), - NULL); - } - sysbus_init_irq(sbd, &s->irq); =20 memory_region_init_io(&s->iomem, OBJECT(s), &aspeed_apb2opb_ops, s, --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894853; cv=none; d=zohomail.com; s=zohoarc; b=Wb7auqP+O9rLjQYzZOA3hhgOUrsdYvN1GGkuOeBjdWj6Rq5FQt5UKAE3ZZg5nwsLRiD3c1gDztm4cjravq7L8z6Ol8s1J2SqfEVb/ospJ2V4J4h73OWCXdRXN9ZyZErkClwlU1QMXLszYjue8v2snjtStUciTEHYFNtR20KUTkY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894853; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=pE6Pca7W7tBGiOTIVoQ+zK1N9Z4QVqZ8xEfNADow84I=; b=at4WAy+9le1lnHSg6sBBB52UHdUec8KdMC07ftXxZ5PY5qvG3k1CNZu0VCDd3xFIRz2Ccz+Nquw3wtgPJZ9gphf52qDOysYHnhG+kXTTXOXDTDlsAmcduR7pfGad6I4vN0dEpRm5z/iKd9zyBYip/Sw90s69aFBpoIWvyfL0u9k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894853943609.8529137092; Mon, 4 May 2026 04:40:53 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrdP-0007aZ-9i; Mon, 04 May 2026 07:38:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrdM-0007HG-Nv for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrdL-0001Je-4m for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:44 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-456-IddKBZgKOvKx3xT3MPB0Rg-1; Mon, 04 May 2026 07:38:38 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E1FC018005AA; Mon, 4 May 2026 11:38:37 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D1DA619560A6; Mon, 4 May 2026 11:38:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894722; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pE6Pca7W7tBGiOTIVoQ+zK1N9Z4QVqZ8xEfNADow84I=; b=ifZUWnEefo2g0fCZUx/EQCAJBX5dx781UJa/1HNsJDmGwTqt7g1bGHCPkNnyuCRrIe2D// aeJkkhOaSVOrbEyc8kCuY+nGCE8sq2/Tv989MMuwQEoPKRO9UGN50fj2F6kkZgosF5yDj2 0uxQL9ZPfdVJ5CIZnQXAQoRemqBz+js= X-MC-Unique: IddKBZgKOvKx3xT3MPB0Rg-1 X-Mimecast-MFC-AGG-ID: IddKBZgKOvKx3xT3MPB0Rg_1777894718 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:23 +0400 Subject: [PATCH v2 35/46] hw/gpio/pca9552: fix state_str leak in pca955x_set_led MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-35-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Glenn Miles , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Developer-Signature: v=1; a=openpgp-sha256; l=930; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=Yyqdk4pqgUvsNBnd22QgjuieBpuRTzwJTZeeL08X0pU=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRtH0un1uSz1Bb/OU6ul3laQWKoZiN4dZE1f 3PZdd5HWgOJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbQAKCRDa6OEJdZac 5WR3D/9OYyZdGvCz6KFa6bFLMtxwCIJjxG20speZdkTR6W2lTwXTNIOztZhYcyRmmzZjQt6PvME II1Tb6lLCrInlElu7wZDLDYsIZzRp6rtwD74wJC2klLF1JHGkKa4PyVsz8gKIGNrJq8R5aZ/vJH mWbwhxgCeYcATFCpfDyj21ynB6IXTYBUrYCVbz/off1OZutvb2OPENZeGPNuvBCEXXHsT7Xc6QT mjrq6Y0KyWh1rr9FEFGLYqgUr5KwbDiVrd4GC/4NYJzHjYdswErwN9gHfl/sAZO9We6PMC4gnyD DKbHQnEbcUSuDLVK0f+//bys5RBL28+AjSWhiLB7ffmiWI0GhtIYZHSytL76UnD2IykyD6W74tv t2qltbZqlt6mp2jYadC+FjUFszhLhAohRr1eqANhWiZG6uRBfgG50iNT8//Gw7Uugz4PDhllC41 sdOd4cD/bfCFzpVgwOSlonfGf0roPhkoCtfmIXEl7LpeAkAzY2yVvtvyhOupY3Q+l7F850JaHdN 4fU/JZowuxVWu/DX8qBH7/UuqnLIwAeDGN3wrC7PW4CjpM4WqShUE5io3nAv/E2bJfihHcuiKSL NTK9PTznYbyJyhwNdM+wvGxOYmGqUXkMhutbKNL5nCdPIIcjORHmeaY0pueKPn8XwGJ/3DN8HBo nk1lBk4/cWXke2A== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894855400158500 visit_type_str() allocates state_str, but the function never frees it on any code path. Use g_autofree to ensure it is freed on return. Fixes: a90d8f84674d ("misc/pca9552: Add qom set and get") Reviewed-by: Glenn Miles Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/gpio/pca9552.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/gpio/pca9552.c b/hw/gpio/pca9552.c index dd3f1536b65..472d8ad9571 100644 --- a/hw/gpio/pca9552.c +++ b/hw/gpio/pca9552.c @@ -342,7 +342,7 @@ static void pca955x_set_led(Object *obj, Visitor *v, co= nst char *name, PCA955xState *s =3D PCA955X(obj); int led, rc, reg, val; uint8_t state; - char *state_str; + g_autofree char *state_str =3D NULL; =20 if (!visit_type_str(v, name, &state_str, errp)) { return; --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894776; cv=none; d=zohomail.com; s=zohoarc; b=ilhyvpuzcsJeHi5pd4pkj6oi/M/5rHdwIhhtcFcK0Ld0cGmKw6TfyW3XD3mMtj73COYt0dWzJMK/KH8L2F2U9f97XXAeagpjq/qVgpfkeRaQAEckoIh9kl6qeSXPpI156kOObi8i8Slg+7SjfTmAlNkQR/eh9O668KN5yiIadUA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894776; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=6GxczfIUezB8LDmHE3u3mH9fTJmiCKopfl79kKH/Kww=; b=Dl/veCZ1EjjlCt03c4z1oJW0V7TnoJMGLlrZsygJ83wPjTeIQj+9tqfujM/uYPK9RP3eeKLUulmCdsJUlXWB1ti9eiAhhdwoZT/5h8ek+peyUJoG8QAn9bkBe50TWwr6ixZNpFn+QCFanpTvC3bmWLrXyTJgaHQbo4vpkt0TQhs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17778947767431009.0409770663979; Mon, 4 May 2026 04:39:36 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrdS-00084F-HS; Mon, 04 May 2026 07:38:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrdQ-0007p6-OJ for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrdP-0001KB-7w for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:48 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-597-gridOgSdM9ahhmp1Rg4obQ-1; Mon, 04 May 2026 07:38:45 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7A59D195609E for ; Mon, 4 May 2026 11:38:44 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1F87F1800480; Mon, 4 May 2026 11:38:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6GxczfIUezB8LDmHE3u3mH9fTJmiCKopfl79kKH/Kww=; b=Rff7229Q+bFglJrSohySWC4XbCWvXFuLNcuy4Be3vMpb3SIsMq+BraOIadTYV7oFK87qjL B7I8BFyRUFjsk46IUz/CUY4ifQjFkqYQXfK91aV3ds1tOiM+OY/XsUvHIC8Ezvv6XGVR8Q xdYHEwmNOeya1L58Wls/7tXzGTEZcxw= X-MC-Unique: gridOgSdM9ahhmp1Rg4obQ-1 X-Mimecast-MFC-AGG-ID: gridOgSdM9ahhmp1Rg4obQ_1777894724 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:24 +0400 Subject: [PATCH v2 36/46] hw/arm/aspeed: free fmc_model and spi_model on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-36-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , =?utf-8?q?C=C3=A9dric_Le_Goater?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1366; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=PkTZRbkufOoEKwzeptnlFgLn3nglmLBi5Zuslh0iOS0=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRtJxDqxwfr091qv+GTM7qI3HJ3ULK1xpqnJ TcJlry/lFqJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbQAKCRDa6OEJdZac 5co/D/9AXzA/rYOf0bjnSKTbPvAyqkm9LAH19htqAe/i598peTuTux1ZI33zRMtjnnW8gYmswsV fmhycaAg/5PWIqsKpIApvKHz6h11oTWGXmIlE0TYmddYqiQSEmP72+VKihtJuu+wi46022CqQw1 xGr8kb6eKrwuazz7/LzsAVB621masF8cLOWS82z8OatCxZNjh6i1ShoauShq0OIehJEn3K7Y0Q8 ziUoXMGRwSBsENHLe3YbFIA702uZsAdTYVtLc4xVUxr6hCIH4pctxJbqyXtpcbgydUtWYlJ6CUZ QbThNwRA55t0ePfZkiLQcXCWOqOWFk+7WkPEEvnBai7qzQPWRsmOE9ovXiAIZdN/oMpJZw0JvaB b79I/dAxrqeu/uLkXM2G2H/xPZFrv1QbaibtTFeGc0nzY8mi75eDBilA7GVjKMiI2aLbQnqjDsZ SGORiEHjGheOUWF8MfrVUfrPJsHON/AWhUulCFlOei7niFErqv3R0tjOaxAVezaTnEPvYHDgJou 0BsQ77m90xVIsh5E3htRR15jzWO3uP0wWYcsn59y7dl3PMuQo5/1dKXHWQhwjinMCFUjYWRsvAU B5hH5ZdOUuNBhAv3p65ErqosRgxq0l0rnrexFj1ZZdy0eTnGMsONewz1M5I/PycWc663trdi9Dp M67IDp5pf8xJYkQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894778181154100 The fmc_model and spi_model strings are allocated via g_strdup in property setters but never freed when the machine object is destroyed. Fixes: 9820e52fbef7 ("hw/arm/aspeed: Add machine properties to define the f= lash models") Reviewed-by: C=C3=A9dric Le Goater Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/arm/aspeed.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index a3db3406c5f..a48c4420583 100644 --- a/hw/arm/aspeed.c +++ b/hw/arm/aspeed.c @@ -419,12 +419,21 @@ static void aspeed_machine_class_init(ObjectClass *oc= , const void *data) aspeed_machine_class_props_init(oc); } =20 +static void aspeed_machine_instance_finalize(Object *obj) +{ + AspeedMachineState *bmc =3D ASPEED_MACHINE(obj); + + g_free(bmc->fmc_model); + g_free(bmc->spi_model); +} + static const TypeInfo aspeed_machine_types[] =3D { { .name =3D TYPE_ASPEED_MACHINE, .parent =3D TYPE_MACHINE, .instance_size =3D sizeof(AspeedMachineState), .instance_init =3D aspeed_machine_instance_init, + .instance_finalize =3D aspeed_machine_instance_finalize, .class_size =3D sizeof(AspeedMachineClass), .class_init =3D aspeed_machine_class_init, .abstract =3D true, --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894761; cv=none; d=zohomail.com; s=zohoarc; b=Nnsv4FgFZ9zAFPOH+6a1Mg9+AZZgnAinlL27sA9+oE1KddCLu3Hz7wUzkf2kDHvk/sT5M5wUmfi8fCPydWuoZgVXgEwI9Q7YnRoHGCfZj5bxFcpyj4GiVy3yvxr3nwWgghD+P6iw8U/RkFa/RDtUPt26sCN3e/MC0cIiEOr1Rqw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894761; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Qwk/cPhu7UiB2QxXvkLjHJKVC7UchevJ1zlM3zy8ly4=; b=TDiEfb0QQQFOEQX8Yeyg2B7331koeoOyoG1i6nnB/00LPB23twK9sH5iXBPCCec+eMSMF8UA1xnu4IEQx9Z3pfW6wHE/If5/9l/zkboLynfZWM6fXgYZr0sxC1HB+ewd5MW7fgTEad1zfFRDrpgG48LbrhzyUEBPHFOh99YpSwo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894761726456.25535226350496; Mon, 4 May 2026 04:39:21 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrdZ-0000Cn-S8; Mon, 04 May 2026 07:38:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrdX-0008WC-S4 for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:55 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrdW-0001Lh-8e for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:55 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-376-di518TOJPcuj4pfkM_gpSw-1; Mon, 04 May 2026 07:38:50 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 94A47195608B; Mon, 4 May 2026 11:38:49 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9A5951800446; Mon, 4 May 2026 11:38:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894733; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qwk/cPhu7UiB2QxXvkLjHJKVC7UchevJ1zlM3zy8ly4=; b=F6Wqw/r/cwCHyU0io7dZ8/UwCrQ6C93YRMoHTRzjcxt5ZyPYKhkNnleI4E9WvAe4EjnKsF uAa0bH6eQuARnA6vUISKdYg3+0tlusyV0A3bdFCeytqWS7JITjEbIUDZsKVc2LBsPbR551 A6G4+RbU/2EE4t98ofZy6jnlxEgPf+w= X-MC-Unique: di518TOJPcuj4pfkM_gpSw-1 X-Mimecast-MFC-AGG-ID: di518TOJPcuj4pfkM_gpSw_1777894729 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:25 +0400 Subject: [PATCH v2 37/46] hw/arm/sbsa-ref: free unrealized flash devices on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-37-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1687; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=UpRnWtRlRxB4ZnNVthl20Ci4luK2JJ70Vb6M6RFsMfw=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRtrKG8NmbKLnZ+HalbC4Ok8ONizvY9uQGIB MTXx+XfXCWJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbQAKCRDa6OEJdZac 5YCSD/4s/p1Rut93TOLBObWt+uWtyBEy6kPDzCwhacOUn+Od247rSUh4sjYQbJEhHRWkdY8rWGo sBLsyarNpgO6WqaXcm+iHaFN0Ynbe1b46FZPor5NL3uhSIwyAgtzidZe+ULoGXjdENKCCWytVLJ bSpLuN2JBtxxQRFgty0WQfkLrORhTpTCBC7oW/D0IWZlmnxq6UtI8dmjW+c7wxVSrLJFiQRD6eJ VkXB9hOCP10Cs+CiFJYLHYWSxhRW22dM/lUdJt5nSsre9Hv50jrD8FBcX365WCrNatuxw1648fD cpXeTHyftzb6hL/p1uxARwBpEeHsX/TSkSARVU5SG63eSeHUhxbGNbKqx+9yyT9UyMiuaJJHmvl u36mpXdcj80ymr209l8bUAx2evdapK0Z83olGKOhPTYauGCs1OVDnf2IdDB3HyyUXDf0467FAFV vKVsaHVw1/XQls2YN0fmRxCcxxl06foI+RC4SUXZAaPL21EnXS/JgRh52LJO7VetnCL8IF7pKQt gkai/Ku9N6j3kSMI5B0mpS4yLEP7zuOq7bLtgh8gJA3bW6wtr5KaHrsKnMnaxzU/RkZwS/LmZM0 PWs0RjuKjHhaTQOapvHO3Fhea52fbL1jiN7dpfpG1icXYzk78f9qa8qIeVVklqOEHhkhIsSaFyo g7ez1+7tAkMCy2w== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894762921158500 Flash devices are created with qdev_new() in instance_init and added as children, but the initial reference from qdev_new() is only dropped by sysbus_realize_and_unref() during machine init. When the machine object is destroyed before realization (e.g. during qtest device introspection), the flash devices leak. Fixes: e9fdf453240e ("hw/arm: Add arm SBSA reference machine, devices part") Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/arm/sbsa-ref.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c index 52c35e10c2d..484b90053e8 100644 --- a/hw/arm/sbsa-ref.c +++ b/hw/arm/sbsa-ref.c @@ -892,6 +892,17 @@ static void sbsa_ref_instance_init(Object *obj) sbsa_flash_create(sms); } =20 +static void sbsa_ref_instance_finalize(Object *obj) +{ + SBSAMachineState *sms =3D SBSA_MACHINE(obj); + + for (int i =3D 0; i < ARRAY_SIZE(sms->flash); i++) { + if (sms->flash[i] && !qdev_is_realized(DEVICE(sms->flash[i]))) { + object_unref(OBJECT(sms->flash[i])); + } + } +} + static void sbsa_ref_class_init(ObjectClass *oc, const void *data) { MachineClass *mc =3D MACHINE_CLASS(oc); @@ -930,6 +941,7 @@ static const TypeInfo sbsa_ref_info =3D { .name =3D TYPE_SBSA_MACHINE, .parent =3D TYPE_MACHINE, .instance_init =3D sbsa_ref_instance_init, + .instance_finalize =3D sbsa_ref_instance_finalize, .class_init =3D sbsa_ref_class_init, .instance_size =3D sizeof(SBSAMachineState), .interfaces =3D aarch64_machine_interfaces, --=20 2.54.0 From nobody Sat May 30 18:34:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894817; cv=none; d=zohomail.com; s=zohoarc; b=bTdTlJAKDKnSN223U4ijzB3/KQEtu1H9gd8zA7CJhPgrndL0GFk+Q8rrJ60u/IrWh3mcBTVkYz7Z2iFn2o4KnbMuWs455S6u2JrukiYKCn7RLH8u1i5sjmeqFZzt/AuHOPJCDzCKTvRuq8msnnV83aK/hZdfioTjHt/LzQ72RLQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894817; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9KEGTmyxrc7XP1G2EZKa1n2uGmD818fX8zVRKUr15Fg=; b=dBYJw+xVJmvB6WRaE2i7qVCVImjxhnJ0FNfclS6t7T9WA1uv6DFcfu5gtF2hNy8Z7/qt5CiNF8Zpe+b5JInOjqZ75g1VrZn3wddbF/YnQewdVKlxcYqc5Nki/wjJN10t9pj0sK7hlfAH0e8VpUxkNqxTwT3LIpgdbfaG+6e4cMs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894817580999.6255935108527; Mon, 4 May 2026 04:40:17 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrdc-0000SN-H6; Mon, 04 May 2026 07:39:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrdb-0000Ja-4F for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrdZ-0001Mq-Kr for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:58 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-629-sRnLC6nFNxKppvSnhqseyA-1; Mon, 04 May 2026 07:38:55 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B116E195609D; Mon, 4 May 2026 11:38:54 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B5E5D180045E; Mon, 4 May 2026 11:38:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894737; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9KEGTmyxrc7XP1G2EZKa1n2uGmD818fX8zVRKUr15Fg=; b=dk7RY4evrTiFQSCO2SHDTa3A55oVMOzdBiByDajppbP0t6boDqUBt5NtqbcJ1cGzwc3z2H tqmFgSGg81e6vlbfkfHEVygJoJoC8C7HOLNHh9cEU4EiXJ6IvF/tuaBoKJzAN4BECDtz2J pS4MOcOXAzD6Q5WsA7f71cmQUQHZFmY= X-MC-Unique: sRnLC6nFNxKppvSnhqseyA-1 X-Mimecast-MFC-AGG-ID: sRnLC6nFNxKppvSnhqseyA_1777894734 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:26 +0400 Subject: [PATCH v2 38/46] hw/arm/virt: free flash devices and OEM strings on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-38-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1696; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=GsOgr5n9WQyuSxd7SPoMPhp96GkvsouIHeYWWY0Z4NY=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRtSd3cW5fVMopqWZ6WH+5cYZt5gx9n1TDp0 oWm94/m/W2JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbQAKCRDa6OEJdZac 5W6kD/43TeJjjgdu+X5R0pWhIhGDM2jPxwvb8YNHtKy6qqS3bmx+sK3JJyruznthCwQDbh+kG9G 1S4ifsokqBH3kXAC01h+HumUFy2BIfura09GtVyvHcOPhFBbyBB9WYsY0SuDp7D/7kg1m8bek7Y 7Tu1lSs36XtbUQ+gLeLPGu0zFYfbga75MadukDyVXbnzD2uiyxNgXhM63imLrBpExJYaNtHE5yk ug6PogyFrME9AyGrSTdjjP717YR27nAPbJmvKRHocN+emvfLDGIVdme92AO6SVXsQ+Ldr57x/ga JY2BRC6z4JxrNoQztiiNg37waRm1ZRPFnGvNK5YcpJI4cm7rJiybRm6aR6U9VqYK7VWi++lxmE/ VVVKZXucl9lQy9cNLLLdUvFKzqft6Yp3dkAa2/nHNXyTDaNiMz2Mkj5y4sPiWtmCKA1MGh8fr+B GrVAQIxlGGKh9tGW70BUYF3Q07hHhnfcgu6br7rVBldWypKR1+qAMtQxYLBHcSUX57OSkvYxagO lU5LlP+XQOuqs1SqCzLrksIqQS4MNFoC7Aac8eC29OTgsQ32yP8S37GuPByFT/EeTSvdOpon7Jc OCkMurnWCFZbyoAS+XT0a7GcdSJKlPusP6O5XB1BFCHeu21QidovuEsBTBy20FkOKYHZk6j14/R 7RSJSrEcjp31CWw== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894819220158500 Flash devices created in instance_init via qdev_new() hold an extra reference that is only dropped on sysbus_realize_and_unref(). When the machine is destroyed before realization, the flash objects leak. Also, the oem_id and oem_table_id strings from g_strndup() are never freed. Fixes: 602b458201ff ("acpi: Permit OEM ID and OEM table ID fields to be cha= nged") Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/arm/virt.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 77891f08200..9510d9eea73 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -4031,6 +4031,19 @@ static void virt_instance_init(Object *obj) cxl_machine_init(obj, &vms->cxl_devices_state); } =20 +static void virt_instance_finalize(Object *obj) +{ + VirtMachineState *vms =3D VIRT_MACHINE(obj); + + for (int i =3D 0; i < ARRAY_SIZE(vms->flash); i++) { + if (vms->flash[i] && !qdev_is_realized(DEVICE(vms->flash[i]))) { + object_unref(OBJECT(vms->flash[i])); + } + } + g_free(vms->oem_id); + g_free(vms->oem_table_id); +} + static const TypeInfo virt_machine_info =3D { .name =3D TYPE_VIRT_MACHINE, .parent =3D TYPE_MACHINE, @@ -4039,6 +4052,7 @@ static const TypeInfo virt_machine_info =3D { .class_size =3D sizeof(VirtMachineClass), .class_init =3D virt_machine_class_init, .instance_init =3D virt_instance_init, + .instance_finalize =3D virt_instance_finalize, .interfaces =3D (const InterfaceInfo[]) { { TYPE_HOTPLUG_HANDLER }, { } --=20 2.54.0 From nobody Sat May 30 18:34:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894850; cv=none; d=zohomail.com; s=zohoarc; b=l3pp4+qFCgb9QaZ9b3PgyOn6ftZiHkRlZY3zzpH8udDOhr26jOt5xWa8w/tn09I6Wu6bNWfvMpAM4XPa85H0w/lqgqL+q31QSY4zvoTnkkGr5hwvv/8KjPN99ecFiNNEiuiU8QAgQBCnbV8yz4Z2Tsp0ff0tStTSgR9YutPZDQo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894850; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=GjvZTAfOLRLSAwyVKRo9KUHII2BC/gQ7W5YOrQTDwCU=; b=hU9/uOJCkTiaRUY0C33c3D9hL6RYtJK0ig+05BX1v83s/da/7lm9MdoDiT4H4GbMrstOO0/IhF4VDp6pKkJXZElG0Zx/TEf3Ip8NoBZLb8x+oIpgjM8VGKHXJB5rNVJOBpKw0Agb50jnIHjRU7HP2JsWftWsxGKY6Zec4YO7bOQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894850558743.9588372090421; Mon, 4 May 2026 04:40:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrdm-00013V-Fl; Mon, 04 May 2026 07:39:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrdj-0000xj-Ba for qemu-devel@nongnu.org; Mon, 04 May 2026 07:39:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrdh-0001TU-Sp for qemu-devel@nongnu.org; Mon, 04 May 2026 07:39:07 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-644-EWytoH3JPeqFDMH34i6ugg-1; Mon, 04 May 2026 07:39:02 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5827B1800579 for ; Mon, 4 May 2026 11:39:01 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id CD127180058B; Mon, 4 May 2026 11:38:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894745; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GjvZTAfOLRLSAwyVKRo9KUHII2BC/gQ7W5YOrQTDwCU=; b=fbH3LP53EFjPyh77LlfB1cMAY8d3GBNo4vQdv9EIaxQhJsDhWIX2z/ywcfAmgb5Ay4R8qK OZ769dzzSWofhafLspp4HBmKTwZ7wefn6IJwhWWzGfqGPp1FXiXgzVE4mNCW5eDj74jeMX 46pIUd4uO8W2spg+VMPHuB5exD5UqsE= X-MC-Unique: EWytoH3JPeqFDMH34i6ugg-1 X-Mimecast-MFC-AGG-ID: EWytoH3JPeqFDMH34i6ugg_1777894741 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:27 +0400 Subject: [PATCH v2 39/46] hw/loongarch/virt: free flash devices and OEM strings on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-39-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1735; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=gG7Ydo0sglWNAjrldcyy9F1jHx9Rn6zTspjlf6OHzK0=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRuUDEVC6J4myYWHD80PIi2OFE2zHlbN8wzX NKPsKYbSsqJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbgAKCRDa6OEJdZac 5c/nEACnNSQ68RlRPRVfkxL7cxy1bvmmcIn5Wz6Nx1TiL446vdfCJ+a+3l69ZrRMhfT4Aj1mkrm HD7CUDB4CK5sh9AEMQGFd3fZ/lAyM87Mw8/QDeZK5AVD6hTybHbzvhQ8uTs06MCFQLuiHKfRf5j 1F0NuZPjy6N8qXUgAIWqxoevQGuMgBETAwGt+cORal8Li0WPv9H5yFwCfV7GTn3qTWuHRgkILjN //15W3pUcPDNwMhijzIly2MiHuSIslvzbKkwr+DEXIXprLWcvRNdItegqZGyVp+5fY35MatAiNU pJuciWfOfh91nWpuYLL7fd9mWQMO27oY8Bkbk0ZqQwQkckPume1pFCYQ/0ljq9qpRUsmLo3KB4d IcTkb3vZYSOnX7/OIgfRq8uew8g70ZR8QIyDcJSUOEc10zLcO1pXMpFEdR+v5bWEOenBtMngmgc 5PiEaDPMs5+BUNWka3WCgnsUSOnnDGoAUQs3o9h7cnyxpCJRepXcmwMUKuWIdYI3nuSGQ4pfXeJ GcQxSDyepFUdOG5a6Pjhm4JFvTBTkW4ZcEqQ+rsJvLJrBo4ovsMRKGKh/uwDSo4U7hWY4P3zwU6 rZEzJwNjy1W3xamCtsyWfRWVPZ/ZgPBw0/rEAwyhYHTTfy2DMMUvjAPmMPxV+7Fm+vTgXbhBm9q lPY3oU6uo3RtFtA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894851371158500 Flash devices created in virt_initfn() via qdev_new() hold an extra reference that is only dropped on sysbus_realize_and_unref(). When the machine is destroyed before realization, the flash objects leak. Also, the oem_id and oem_table_id strings from g_strndup() are never freed. Fixes: 445c9c645 ("hw/loongarch/virt: Allow user to customize OEM ID and OE= M table ID") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/loongarch/virt.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c index 2fc15261309..188fbc86c0c 100644 --- a/hw/loongarch/virt.c +++ b/hw/loongarch/virt.c @@ -1535,6 +1535,19 @@ static void virt_class_init(ObjectClass *oc, const v= oid *data) "for PCI MMIO"); } =20 +static void virt_instance_finalize(Object *obj) +{ + LoongArchVirtMachineState *lvms =3D LOONGARCH_VIRT_MACHINE(obj); + + for (int i =3D 0; i < ARRAY_SIZE(lvms->flash); i++) { + if (lvms->flash[i] && !qdev_is_realized(DEVICE(lvms->flash[i]))) { + object_unref(OBJECT(lvms->flash[i])); + } + } + g_free(lvms->oem_id); + g_free(lvms->oem_table_id); +} + static const TypeInfo virt_machine_types[] =3D { { .name =3D TYPE_LOONGARCH_VIRT_MACHINE, @@ -1542,6 +1555,7 @@ static const TypeInfo virt_machine_types[] =3D { .instance_size =3D sizeof(LoongArchVirtMachineState), .class_init =3D virt_class_init, .instance_init =3D virt_initfn, + .instance_finalize =3D virt_instance_finalize, .interfaces =3D (const InterfaceInfo[]) { { TYPE_HOTPLUG_HANDLER }, { } --=20 2.54.0 From nobody Sat May 30 18:34:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894794; cv=none; d=zohomail.com; s=zohoarc; b=BSgn6sAhIR163/l8EW8BY2m+kpCYJdhYqrRYcbbvqua1k1WlKO3TP21nXdyOMuXO8AOJLiyeh9re1FAtewOUqBqkjuUH1Tem66saIRqqvPGcz+KT6+zzk78v4X47Ta4exL2p+LaioHIsSh4mmYWRWWFrnJqIEXAJWFODqR+Y058= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894794; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=V93smpOYjPMFE/CXbcn7oVoksJ5mZfm+za0KRUBYHRo=; b=d4rscVeRjP2Xqa9u09kE7Gun1d6OiNXe75/9TMyNtsXe1tZ+vcrYTlSmt9oFqOa8L1VzpEcqfr1x7z10YcGm93D/DhY+WEzwE8XY7aDzc1Odb7aqeRqXvdwC33w+7QJxrEXPJ41DC9QIdDWtYAiyOToGcMX/v5JvsGEduZ9neiE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894794217549.7047865894205; Mon, 4 May 2026 04:39:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJrdw-0001Kd-IR; Mon, 04 May 2026 07:39:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrdm-0001Ag-WB for qemu-devel@nongnu.org; Mon, 04 May 2026 07:39:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrdl-0001Tq-MP for qemu-devel@nongnu.org; Mon, 04 May 2026 07:39:10 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-686-4O1IajnlN4CIb2kBpj64_Q-1; Mon, 04 May 2026 07:39:07 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EFA1219560BD for ; Mon, 4 May 2026 11:39:06 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A295330001A1; Mon, 4 May 2026 11:39:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894749; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V93smpOYjPMFE/CXbcn7oVoksJ5mZfm+za0KRUBYHRo=; b=EGgOEaQ9UQ0ZBUGWbcNkEUImFEjzLnJVFGZsFeU+M+p/3orVNJogWXhVWlBe1E7Igr842s 4W5ju4jSJpp/cvh7W7f4mLUVnsJ5GRzsr4wpE5jn+thg2ip/OXK7OeYZ1EQwh9SDJp/RgW G6l091FG+M3ntt67KJfL7DD/+lzMjwM= X-MC-Unique: 4O1IajnlN4CIb2kBpj64_Q-1 X-Mimecast-MFC-AGG-ID: 4O1IajnlN4CIb2kBpj64_Q_1777894747 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:28 +0400 Subject: [PATCH v2 40/46] hw/ppc/spapr: free host_model and host_serial on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-40-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=811; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=+InROhAu3uVVe3JZYaKX/PVJJdZL4PD8YW4nWEaRCIQ=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRuNisafQD+IpMgPq/5zWIjKRuNnT4+lMIyv bcbFpFQXPSJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbgAKCRDa6OEJdZac 5bflD/9QsCN8C/EJbDSqqXDfo9Qq65YylgF+W73UuDLEonDYXC90J+0fN3+Efclya/v79HrpICq 5FY/LcFHLFl3uaomfi5/PNddOZa//E7iSr0UmU6FfPLA28zEDbtxMipVd9u7zds+CA6bJa/WYsg AOP51jk0KwL4EJbv8/3AR/5S7NAlEVULXEXOss1f7NkMkzXzdd1JXtX761iEDAjeV7/LIcqEExS RJ0s+uyK5IAIdk6V3BxUHFj/BXNnEwx40gVwBfvmYD1Jg4on8xZqnRKismm5DFrLc4z2yxOVPnJ kEChtNt0HDeCFIsy9/7ZLKFYf9MzXZcTO6urMXX/r197t1eS+k8jLRz0Rn5Cw/nqiVYX1wzLpUL pTClf6lpw4dn34/VPyVcLAGFR/12pdbAp1rg9z+43mWID4qk7b/oAxCdTf2ezududh4/Qi5+j+9 dAiJnDum9sWPxfcfghxO+lSVTuNQHdPKKmepxt0fBdCVHUFewyLtG2ra3Jq+ThNunz66dAjMeoR TphTfplGnTvdSmZMoeNrzPMItR31iSN9N9BfX5eIS2Hcd7zWd79MGtFjJQnMSfxwAlDhPkvjKSz RhbNTPv/mcuxHEk7MZNqHmIziOJ/wCCRXNIn20auVzFl5qPVMdaGwfjugvtQsSVjQc0gFDrMQvD fVTZS4yIocn5P/A== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894796475154100 The host_model and host_serial strings are allocated via g_strdup in property setters but never freed when the machine is destroyed. Fixes: 27461d69a0f ("ppc: add host-serial and host-model machine attributes= (CVE-2019-8934)") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/ppc/spapr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 428b491a7df..5c673bbf0dd 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -3517,6 +3517,8 @@ static void spapr_machine_finalizefn(Object *obj) SpaprMachineState *spapr =3D SPAPR_MACHINE(obj); =20 g_free(spapr->kvm_type); + g_free(spapr->host_model); + g_free(spapr->host_serial); } =20 void spapr_do_system_reset_on_cpu(CPUState *cs, run_on_cpu_data arg) --=20 2.54.0 From nobody Sat May 30 18:34:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894812; cv=none; d=zohomail.com; s=zohoarc; b=f7i5MCsqGyCHiEuR4b71sFsKrYUBLGpGkCC3S8tv3quUgMVcLe1S9HX1liH383bz81irjxcjRdPaIzhAxEhFXsIrRqzxxo9LgRd6z18ecKjLLauzs6iPaNRzhfupy7OHM2z3OW3iQwrSdaSr86dP7fz5TJXGoI14U7AHG+xiVAM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894812; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=uN4d/Ai32GNB01MP0kVHTE8CTIe9T+EFJ95fCaxFhxM=; b=VxROYTSKRiZSpU9wmNq205obn96twuaq25aVbp4SrdOUqA8Jm5MtDZTJDnXxxAeIZmecwbWYY13kiVsxC8ggSFI25MMurFUR+VhXkrPyC61jh7n/+RPxl++l3JXlGNCahcRsBKSGQct+UDpKv6PSLVO34tfDuQy/RcCkFAydYB0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894812812594.9104913729232; Mon, 4 May 2026 04:40:12 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJreI-0001Pl-B0; Mon, 04 May 2026 07:39:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrdu-0001Jd-FC for qemu-devel@nongnu.org; Mon, 04 May 2026 07:39:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrdq-0001U6-SA for qemu-devel@nongnu.org; Mon, 04 May 2026 07:39:17 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-156-HR5T5EXFNwmf2kJhHhzYIw-1; Mon, 04 May 2026 07:39:13 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 558F0195609E; Mon, 4 May 2026 11:39:12 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 28C6330001A1; Mon, 4 May 2026 11:39:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894754; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uN4d/Ai32GNB01MP0kVHTE8CTIe9T+EFJ95fCaxFhxM=; b=DMf2N/o2TjCzxPJM6/ZyH68pWHSW41Xhdb8qWygG0rvEaYP7Xi72fwDJxFVMGii1xZaq3o bo9pxh/hBxNHuzEZGsNOV5KaIaO1hTmSzk36eKaLoRKmWWgF2wl5hSEecEKGqKVY1wlwET hfKPMoBg0zuofbj5KzicUzlpG3kLp9A= X-MC-Unique: HR5T5EXFNwmf2kJhHhzYIw-1 X-Mimecast-MFC-AGG-ID: HR5T5EXFNwmf2kJhHhzYIw_1777894752 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:29 +0400 Subject: [PATCH v2 41/46] hw/ppc/pnv: drop extra ref on PHB after adding as child MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-41-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Glenn Miles X-Developer-Signature: v=1; a=openpgp-sha256; l=888; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=QLJRPPI4OhAwrexFX8/IzFHm2ibPBZdLsobimTM9SOo=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRuqxZtILqQZ/YW6Xjh/H9/JZT69ixll/KSw NI+rrm7uYyJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbgAKCRDa6OEJdZac 5ZGjD/9h9+WsQce9b+cImLwAJ3lpV3NTJGaGshmo12ZKwmZlh1h2MvxL5bf7arIrCHBZMpZlDpo EU1o/x/WCexFUM3SoZJZBO/FikLpBK/hQmlUEtR7P0Fv2N9rqjJWAVLp5sZ0/hF9BnMCAD+uJ0h 2ErXitvXfE+B6oP45OD6MjDR8WJpveW8oWvPBG8J+AwXI1FnWQ8Pt8NDLrwTWZ3vgxbu9+zZAL2 yJnSvrQMlmK1Zz62SmnLyX6s4SMhIr88JfrcA3AFiu3y/GRAcPIItNXfZgNC5ECygw5/vKw878+ AtD4qDNheFtaKktyIllMdFoS3+OxPDZAov64DemqckM5idkOoVI8QGlgYcgAJ8LVMux7fVdMXsJ KqYkxAbiUFwl142OT39ut1tePgEzvEcamJE9MdJOD3745w6ScA1Ezyt5bglT3sMUGpMFxr4lel2 26B0p/mVQDFBrfC0MADG2DQA6DeMEhL8LAnmstn/ec34hoZ5xrZAqhPn/irtwfzBc2UpiOMb/h5 Qag7U5+WSd7gU7o2WQthD6HPXMxYE9ByqOcB1kzwHp9x4M2Nl7SCBThFow1yUBTZjwUKZW734Kp km19oPoxbKbAzQanPkwloc8MNsQt2Yv/D3TXoioqjVwLzHwcGMHPECq9QtyN237UYaN1oX2crsd 3gTbmnpSecdM8cg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894814773154100 object_new() returns an object with refcount 1, and object_property_add_child() adds another reference. The initial reference must be dropped so the parent becomes the sole owner, otherwise the PHB objects leak when the chip is destroyed. Fixes: 0d512c7120a2 ("ppc/pnv: turn chip8->phbs[] into a PnvPHB* array") Reviewed-by: Glenn Miles Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/ppc/pnv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index 9ed918fa6a1..8306754d9ad 100644 --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -1696,6 +1696,7 @@ static void pnv_chip_power8_instance_init(Object *obj) */ object_property_add_child(obj, "phb[*]", phb); chip8->phbs[i] =3D PNV_PHB(phb); + object_unref(phb); } } =20 --=20 2.54.0 From nobody Sat May 30 18:34:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894807; cv=none; d=zohomail.com; s=zohoarc; b=JPWqX9qXebp5bDwr63eTho5KYsp83qPMUDg3MCf32RHWUmE2/m1B0Q866QnO8yoVqeg8c1/O2U+1CRyH4pLU80Gp+lPWvVf7cViNCJjY5epqAPVoSKl5AjXBLrGEGCrS35iXgpcIVYjezuneBSJTtFNbUQXUyFvbHLAGN9tLc00= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894807; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=2Nacj50LPwl+uBll+r6QnniZ9uS9YJmwxauJLN2L6nE=; b=X+8moOHG+OGnx62zYFD2ZklX7papcAF2qsdPItBUXROUvsbUgIlujp2n1Aax+Rovgid5WQgHVHsQkPkqWqTwBOLbax8aLFCEA2WkCpDaXiWNu7HbRgX3U6VACZzBA+ChrBlrfqeS4D++NPHnsX3G5camtBmmKrIci6EC4djHyAM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894807206946.1445148015747; Mon, 4 May 2026 04:40:07 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJreN-0001kb-Ob; Mon, 04 May 2026 07:39:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrdz-0001OO-49 for qemu-devel@nongnu.org; Mon, 04 May 2026 07:39:26 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJrdx-0001UR-4y for qemu-devel@nongnu.org; Mon, 04 May 2026 07:39:22 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-266-stn6ZXEuPpWW9eg6w9dbpg-1; Mon, 04 May 2026 07:39:18 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F28A7195608C for ; Mon, 4 May 2026 11:39:17 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9B7291800446; Mon, 4 May 2026 11:39:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2Nacj50LPwl+uBll+r6QnniZ9uS9YJmwxauJLN2L6nE=; b=bC/0fQNOyWn4GgAWrzwW8fd+FNw58veT3Rn6+zMVdAAO3PdzTASlpV0vlmlzxxR/Dx+Wsz L7VJ6caNGVnf54G5++OwDPYgJ8y/F0CRXjEAmR3N2QYn+TavNm1oqg9UkbJ25dKrzCfv6M MAjxtwUAc+Qah8GUS9eWCZym2v6Adw8= X-MC-Unique: stn6ZXEuPpWW9eg6w9dbpg-1 X-Mimecast-MFC-AGG-ID: stn6ZXEuPpWW9eg6w9dbpg_1777894758 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:30 +0400 Subject: [PATCH v2 42/46] target/riscv: fix general_user_opts hash table leak MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-42-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=9180; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=GjCZY+GZGV2ac+w3QLM0yqTi7RE9xdyPxBERvh9403I=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRu2hLIppNgBuAIu/zuHxJf1Tg3X2buL/5+N ujKKWaShuqJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbgAKCRDa6OEJdZac 5RKAEACp6Alx6d/pM78suhudt9UMj97s4LvtWt8MkeFagR6xt4G7RZ3MVz+HuBkDXLbWD7Pvgcj O0YxVLsFy9eqE5OvtknFydi5U+nQNmjmoG2EWZL91vKTZh/2rvPCzgEDw2KVgKk+j9I87EXhI9n iLfpXdsOpakIPOGkOb4CTO91RZ/hf/xl8ICQCMuC5ai7tFlgbg7y15puUCnnrqEWchRABWU0VBo wG/LHWPHhmrnSakVIKiDUSNka0sWGVp0X+iyB8IvOmJJIP+Xh+8x6F61/Y3EsecQ/66o6pIeW5c zumjzhIQMWlSr8kimPTXaVWoXehx49o5lENa9k1b9OwhXMHtyN+/nlIyN4+bRGMrAKgm3TxouV3 m+O0QOfNL+WWb4wl8U7/onVbf20Ubidw+H6BlBf3zcnXzhs75lljIMWI88uMARCUHNY8k3sylUE vtI7dOvoWyJpQN9a0Yk7ZSZkzEnJivkRzcujw/jD09qknwO6No4yNMggMIqd7nN/zwqzkfwhnQg I+MRm+mtP4xBcFU/03IcFunSWf5Zd1E3gE2kkPc7iZf3OBAQBnjdSt5VvOFUmtRwBm29JOllDIt CueeNSYgP50xydbJVD5uzfHTpyrmo6AZYySWGR2Ss14ywrXEl3jagpygNonsFXm1RAuBFRamjoO NQ0bw61kX2gt3Eg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894808825154101 The global general_user_opts hash table is recreated on every riscv_cpu_init() call, leaking the previous one. Furthermore, the CPU settings should be associated with their instance and not global. Add a finalize() to free associated instances. Fixes: d167a2247ede ("target/riscv: move 'pmu-mask' and 'pmu-num' to riscv_= cpu_properties[]") Signed-off-by: Marc-Andr=C3=A9 Lureau --- target/riscv/cpu.h | 3 ++- target/riscv/cpu.c | 51 +++++++++++++++++++++++++++---------------= ---- target/riscv/kvm/kvm-cpu.c | 6 +++--- 3 files changed, 35 insertions(+), 25 deletions(-) diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h index 81c41e34296..55a26aeb5be 100644 --- a/target/riscv/cpu.h +++ b/target/riscv/cpu.h @@ -546,6 +546,7 @@ struct ArchCPU { uint32_t pmu_avail_ctrs; /* Mapping of events to counters */ GHashTable *pmu_event_ctr_map; + GHashTable *user_options; const GPtrArray *decoders; }; =20 @@ -619,7 +620,7 @@ bool riscv_cpu_tlb_fill(CPUState *cs, vaddr address, in= t size, bool probe, uintptr_t retaddr); char *riscv_isa_string(RISCVCPU *cpu); int riscv_cpu_max_xlen(RISCVCPUClass *mcc); -bool riscv_cpu_option_set(const char *optname); +bool riscv_cpu_option_set(RISCVCPU *cpu, const char *optname); =20 #ifndef CONFIG_USER_ONLY void riscv_cpu_do_interrupt(CPUState *cpu); diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index ce15a17c37d..be9a3ac13e7 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -27,6 +27,7 @@ #include "qapi/error.h" #include "qapi/visitor.h" #include "qemu/error-report.h" +#include "qemu/timer.h" #include "hw/core/qdev-properties.h" #include "hw/core/qdev-prop-internal.h" #include "migration/vmstate.h" @@ -59,18 +60,16 @@ bool riscv_cpu_is_32bit(RISCVCPU *cpu) return riscv_cpu_mxl(&cpu->env) =3D=3D MXL_RV32; } =20 -/* Hash that stores general user set numeric options */ -static GHashTable *general_user_opts; - -static void cpu_option_add_user_setting(const char *optname, uint32_t valu= e) +static void cpu_option_add_user_setting(RISCVCPU *cpu, const char *optname, + uint32_t value) { - g_hash_table_insert(general_user_opts, (gpointer)optname, + g_hash_table_insert(cpu->user_options, (gpointer)optname, GUINT_TO_POINTER(value)); } =20 -bool riscv_cpu_option_set(const char *optname) +bool riscv_cpu_option_set(RISCVCPU *cpu, const char *optname) { - return g_hash_table_contains(general_user_opts, optname); + return g_hash_table_contains(cpu->user_options, optname); } =20 #ifndef CONFIG_USER_ONLY @@ -1103,7 +1102,7 @@ static void riscv_cpu_init(Object *obj) "riscv.cpu.rnmi", RNMI_MAX); #endif /* CONFIG_USER_ONLY */ =20 - general_user_opts =3D g_hash_table_new(g_str_hash, g_str_equal); + cpu->user_options =3D g_hash_table_new(g_str_hash, g_str_equal); =20 /* * The timer and performance counters extensions were supported @@ -1453,7 +1452,7 @@ static void prop_pmu_num_set(Object *obj, Visitor *v,= const char *name, =20 warn_report("\"pmu-num\" property is deprecated; use \"pmu-mask\""); cpu->cfg.pmu_mask =3D pmu_mask; - cpu_option_add_user_setting("pmu-mask", pmu_mask); + cpu_option_add_user_setting(cpu, "pmu-mask", pmu_mask); } =20 static void prop_pmu_num_get(Object *obj, Visitor *v, const char *name, @@ -1495,7 +1494,7 @@ static void prop_pmu_mask_set(Object *obj, Visitor *v= , const char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.pmu_mask =3D value; } =20 @@ -1527,7 +1526,7 @@ static void prop_mmu_set(Object *obj, Visitor *v, con= st char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.mmu =3D value; } =20 @@ -1559,7 +1558,7 @@ static void prop_pmp_set(Object *obj, Visitor *v, con= st char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.pmp =3D value; } =20 @@ -1599,7 +1598,7 @@ static void prop_num_pmp_regions_set(Object *obj, Vis= itor *v, const char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.pmp_regions =3D value; } =20 @@ -1637,7 +1636,7 @@ static void prop_pmp_granularity_set(Object *obj, Vis= itor *v, const char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.pmp_granularity =3D value; } =20 @@ -1710,7 +1709,7 @@ static void prop_priv_spec_set(Object *obj, Visitor *= v, const char *name, return; } =20 - cpu_option_add_user_setting(name, priv_version); + cpu_option_add_user_setting(cpu, name, priv_version); cpu->env.priv_ver =3D priv_version; } =20 @@ -1744,7 +1743,7 @@ static void prop_vext_spec_set(Object *obj, Visitor *= v, const char *name, return; } =20 - cpu_option_add_user_setting(name, VEXT_VERSION_1_00_0); + cpu_option_add_user_setting(cpu, name, VEXT_VERSION_1_00_0); cpu->env.vext_ver =3D VEXT_VERSION_1_00_0; } =20 @@ -1787,7 +1786,7 @@ static void prop_vlen_set(Object *obj, Visitor *v, co= nst char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.vlenb =3D value >> 3; } =20 @@ -1828,7 +1827,7 @@ static void prop_elen_set(Object *obj, Visitor *v, co= nst char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.elen =3D value; } =20 @@ -1864,7 +1863,7 @@ static void prop_cbom_blksize_set(Object *obj, Visito= r *v, const char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.cbom_blocksize =3D value; } =20 @@ -1900,7 +1899,7 @@ static void prop_cbop_blksize_set(Object *obj, Visito= r *v, const char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.cbop_blocksize =3D value; } =20 @@ -1936,7 +1935,7 @@ static void prop_cboz_blksize_set(Object *obj, Visito= r *v, const char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.cboz_blocksize =3D value; } =20 @@ -2974,6 +2973,15 @@ void riscv_isa_write_fdt(RISCVCPU *cpu, void *fdt, c= har *nodename) DEFINE_RISCV_CPU(type_name, parent_type_name, \ .profile =3D &(profile_)) =20 +static void riscv_cpu_instance_finalize(Object *obj) +{ + RISCVCPU *cpu =3D RISCV_CPU(obj); + + g_clear_pointer(&cpu->pmu_timer, timer_free); + g_clear_pointer(&cpu->pmu_event_ctr_map, g_hash_table_destroy); + g_clear_pointer(&cpu->user_options, g_hash_table_destroy); +} + static const TypeInfo riscv_cpu_type_infos[] =3D { { .name =3D TYPE_RISCV_CPU, @@ -2981,6 +2989,7 @@ static const TypeInfo riscv_cpu_type_infos[] =3D { .instance_size =3D sizeof(RISCVCPU), .instance_align =3D __alignof(RISCVCPU), .instance_init =3D riscv_cpu_init, + .instance_finalize =3D riscv_cpu_instance_finalize, .abstract =3D true, .class_size =3D sizeof(RISCVCPUClass), .class_init =3D riscv_cpu_common_class_init, diff --git a/target/riscv/kvm/kvm-cpu.c b/target/riscv/kvm/kvm-cpu.c index b047ffa9c0c..e0241870ada 100644 --- a/target/riscv/kvm/kvm-cpu.c +++ b/target/riscv/kvm/kvm-cpu.c @@ -2025,7 +2025,7 @@ void riscv_kvm_cpu_finalize_features(RISCVCPU *cpu, E= rror **errp) } =20 if (cpu->cfg.ext_zicbom && - riscv_cpu_option_set(kvm_cbom_blocksize.name)) { + riscv_cpu_option_set(cpu, kvm_cbom_blocksize.name)) { =20 reg.id =3D KVM_RISCV_REG_ID_ULONG(KVM_REG_RISCV_CONFIG, kvm_cbom_blocksize.kvm_reg_id); @@ -2044,7 +2044,7 @@ void riscv_kvm_cpu_finalize_features(RISCVCPU *cpu, E= rror **errp) } =20 if (cpu->cfg.ext_zicboz && - riscv_cpu_option_set(kvm_cboz_blocksize.name)) { + riscv_cpu_option_set(cpu, kvm_cboz_blocksize.name)) { =20 reg.id =3D KVM_RISCV_REG_ID_ULONG(KVM_REG_RISCV_CONFIG, kvm_cboz_blocksize.kvm_reg_id); @@ -2063,7 +2063,7 @@ void riscv_kvm_cpu_finalize_features(RISCVCPU *cpu, E= rror **errp) } =20 /* Users are setting vlen, not vlenb */ - if (riscv_has_ext(env, RVV) && riscv_cpu_option_set("vlen")) { + if (riscv_has_ext(env, RVV) && riscv_cpu_option_set(cpu, "vlen")) { if (!kvm_v_vlenb.supported) { error_setg(errp, "Unable to set 'vlenb': register not supporte= d"); return; --=20 2.54.0 From nobody Sat May 30 18:34:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894849; cv=none; d=zohomail.com; s=zohoarc; b=ag74lt0tTCZqnQ3Jamclio6vU5UHiQ849PwpvLR8A4o9vB9KdnLr21rgVqdQagNe9FDDoojm7g6LrIo8LlSPCzI8lyEnrNYNikIkVLn6IDq5Zj7SRPmKQk8gSj5P+0kDK0GAsg2+bnB5zbBDXfo/Pnv1KB5pXfeM3zOZRY0j8mk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894849; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=42hjY28IGCdulA5mo/QwK+Hh01CMs8vQW8q3n61V0m4=; b=ZanGQzgdiBZFzeGtoqxOqfwu+/L3fuL7FGGZLPeeCI9D+D1fptzFvwUtZEbAjetBHPL75cUfosiLUxbIEcJuMbaR7WXwpqR4VE2cKMKSXU3zJIHswJX8rLngiE1XtjvHzBLEEBbVjTUHLLU7dwh34cmiqh3ENh93Z+e2aBrQ0zY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894849866758.0913931505926; Mon, 4 May 2026 04:40:49 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJreN-0001kt-P9; Mon, 04 May 2026 07:39:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJre6-0001Ri-Pj for qemu-devel@nongnu.org; Mon, 04 May 2026 07:39:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJre2-0001Uh-Iq for qemu-devel@nongnu.org; Mon, 04 May 2026 07:39:29 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-400-xqMvUuXYN42jy80Wv5BOOw-1; Mon, 04 May 2026 07:39:24 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CC6FF1956089 for ; Mon, 4 May 2026 11:39:23 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4FD4319560B1; Mon, 4 May 2026 11:39:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894765; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=42hjY28IGCdulA5mo/QwK+Hh01CMs8vQW8q3n61V0m4=; b=FZYihoy/4Yp6deNS4UGUfkGaJOUJWtjMeVocutNPjAe7vgUid3OJ1/sKJYXs7Kv76KTujL MDQB+ao3UqfEFxy6uScIOCXiL2bnKanRmaey5sYHgbkTxCWyinvZa9ycJHuxvGYwYayoal f3aIxPGhjYlTjAEZ+HBrvPrqXZnWHiY= X-MC-Unique: xqMvUuXYN42jy80Wv5BOOw-1 X-Mimecast-MFC-AGG-ID: xqMvUuXYN42jy80Wv5BOOw_1777894763 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:31 +0400 Subject: [PATCH v2 43/46] target/riscv: use hash table as set for user_options MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-43-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=4750; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=54UipZhX3LhBC9douJgP5Ilofu4C5/F+Xe5+6aIzMYI=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRuxC2J2JbOk0qhObiNeQTTAwuC0UuX9oUFc etWTpDay7OJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbgAKCRDa6OEJdZac 5W8XD/9DTzLInq4OCKY5xexqCOK4vp6zvv0yfpoUyimFh18JfQF4B9B2xjMOkggs3jWxuGYsHyl iQNL5liQ5qQV93AWmKrYLiWMCNBSNozaUQuLFKAYuhxrIljNPVf9G98/UwqX8jWOxxTChFpVhel vU7OL8izw5F75bM/SOEElDM3SmyztH7YVkG2NQFlOOef+8VU6w3fcO0zfB7XE4Q9rHP5cz1tm4j 8onYn+h45mJ6k+Y00OBeeh4fgPDZiuDnoCON/dr2+5RlvREkckwm9mSKjcI6WPz143nxA8udo/t b9azjL/WfUTK7keQMdaEs+1NwUzwXMhGXWW6pBOixWcmu5inaYWtfPcSNygRyl8PWtlWmD7Cj3e 6zsw8OK48vXP2JgN/9srO11oB963oS1TVZNWXxf3hjxyApEgl+2KQRO4kir1V7/Ts+ABHCZBGQ7 EfZ91c9RYf+fhk4NbPUIt8J5nzIhvKF7j2lpD8N9odyOUNGwX0y25tAdHbCbgEEA3nl1nzzj+sE St/mVI6rwbrywZJBdidAsIva/LkOeQIWPsq22J/WjSYjb56AMvrJzLvwRzFYobw6/5LbhKH46nB 8smdd+Uyb4A+FU5C7eKVLQQwNt2COG8SngoKZy0UVrcH7IL+BVJUlCBkI27ddsUZXkbBXz88kfz sW+ZbIkOnzbC0Wg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894851314154100 The values stored in user_options are never retrieved, only key presence is checked. Use g_hash_table_add() instead of g_hash_table_insert() and drop the unused value parameter. Signed-off-by: Marc-Andr=C3=A9 Lureau --- target/riscv/cpu.c | 32 +++++++++++++++----------------- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index be9a3ac13e7..52b89e274f4 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -60,11 +60,9 @@ bool riscv_cpu_is_32bit(RISCVCPU *cpu) return riscv_cpu_mxl(&cpu->env) =3D=3D MXL_RV32; } =20 -static void cpu_option_add_user_setting(RISCVCPU *cpu, const char *optname, - uint32_t value) +static void cpu_option_add_user_setting(RISCVCPU *cpu, const char *optname) { - g_hash_table_insert(cpu->user_options, (gpointer)optname, - GUINT_TO_POINTER(value)); + g_hash_table_add(cpu->user_options, (gpointer)optname); } =20 bool riscv_cpu_option_set(RISCVCPU *cpu, const char *optname) @@ -1452,7 +1450,7 @@ static void prop_pmu_num_set(Object *obj, Visitor *v,= const char *name, =20 warn_report("\"pmu-num\" property is deprecated; use \"pmu-mask\""); cpu->cfg.pmu_mask =3D pmu_mask; - cpu_option_add_user_setting(cpu, "pmu-mask", pmu_mask); + cpu_option_add_user_setting(cpu, "pmu-mask"); } =20 static void prop_pmu_num_get(Object *obj, Visitor *v, const char *name, @@ -1494,7 +1492,7 @@ static void prop_pmu_mask_set(Object *obj, Visitor *v= , const char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.pmu_mask =3D value; } =20 @@ -1526,7 +1524,7 @@ static void prop_mmu_set(Object *obj, Visitor *v, con= st char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.mmu =3D value; } =20 @@ -1558,7 +1556,7 @@ static void prop_pmp_set(Object *obj, Visitor *v, con= st char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.pmp =3D value; } =20 @@ -1598,7 +1596,7 @@ static void prop_num_pmp_regions_set(Object *obj, Vis= itor *v, const char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.pmp_regions =3D value; } =20 @@ -1636,7 +1634,7 @@ static void prop_pmp_granularity_set(Object *obj, Vis= itor *v, const char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.pmp_granularity =3D value; } =20 @@ -1709,7 +1707,7 @@ static void prop_priv_spec_set(Object *obj, Visitor *= v, const char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, priv_version); + cpu_option_add_user_setting(cpu, name); cpu->env.priv_ver =3D priv_version; } =20 @@ -1743,7 +1741,7 @@ static void prop_vext_spec_set(Object *obj, Visitor *= v, const char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, VEXT_VERSION_1_00_0); + cpu_option_add_user_setting(cpu, name); cpu->env.vext_ver =3D VEXT_VERSION_1_00_0; } =20 @@ -1786,7 +1784,7 @@ static void prop_vlen_set(Object *obj, Visitor *v, co= nst char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.vlenb =3D value >> 3; } =20 @@ -1827,7 +1825,7 @@ static void prop_elen_set(Object *obj, Visitor *v, co= nst char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.elen =3D value; } =20 @@ -1863,7 +1861,7 @@ static void prop_cbom_blksize_set(Object *obj, Visito= r *v, const char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.cbom_blocksize =3D value; } =20 @@ -1899,7 +1897,7 @@ static void prop_cbop_blksize_set(Object *obj, Visito= r *v, const char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.cbop_blocksize =3D value; } =20 @@ -1935,7 +1933,7 @@ static void prop_cboz_blksize_set(Object *obj, Visito= r *v, const char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.cboz_blocksize =3D value; } =20 --=20 2.54.0 From nobody Sat May 30 18:34:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894859; cv=none; d=zohomail.com; s=zohoarc; b=EOsQgTzfDy9nAFxXDK61LwmkUkY0BLViLIveFA24rTZc5Su81TqpnMDwsJkWxCMNp8MJc1ABl5I2WK5CZu/B83y4bKd779t8srlytyCY8KsF3gKjns4wZJ/iEdGQSYkumcneSWmdmlJM8bd+0A89PJ4nUzMEFX0bHU3PkD/9IMo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894859; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0AAWAtCladMOl9qwPLP2iDIrISuEXK2bC2mKMxeA798=; b=AIIYCLqu0xz7D6TUq5Yfif0b/LuMdOm4932pCCvo5OjviYRu95HsGOAQqm4VuNghokdRgr0eW1jpidyK50YZElybOjs08vZ1w84Jsyi02HhyrT65+zMcvIqS3xGudzRHYPfeH8s5pPTDYH2lDeFGf978QfRNZ1w7LNfviDGLfEM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894859088392.8462831757397; Mon, 4 May 2026 04:40:59 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJreR-0002LM-U8; Mon, 04 May 2026 07:39:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJreB-0001Rw-UN for qemu-devel@nongnu.org; Mon, 04 May 2026 07:39:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJreA-0001Vh-D4 for qemu-devel@nongnu.org; Mon, 04 May 2026 07:39:35 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-441-sv7wAvg0PU28B5cmbu4PfQ-1; Mon, 04 May 2026 07:39:30 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B2047195608F; Mon, 4 May 2026 11:39:29 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7F2CB19560B6; Mon, 4 May 2026 11:39:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894773; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0AAWAtCladMOl9qwPLP2iDIrISuEXK2bC2mKMxeA798=; b=AEr5Pno4+ZlDJnf0vu1JNH+HLZ5J1NpxFRAEN+TrNh49XoSZZIyEmKobjqbAKn3RFF6cps xbbN/6pZly/pXufunm5In4GpgfOeoCkv0tx7V8TPR7YN1rTwfg9ULT5VwMMSJcTJvx/qDt oWT0FeIBw4jQILAwvL6UGMy1MM4AV8I= X-MC-Unique: sv7wAvg0PU28B5cmbu4PfQ-1 X-Mimecast-MFC-AGG-ID: sv7wAvg0PU28B5cmbu4PfQ_1777894769 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:32 +0400 Subject: [PATCH v2 44/46] hw/riscv/virt: free flash devices and OEM strings on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-44-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Alistair Francis X-Developer-Signature: v=1; a=openpgp-sha256; l=1650; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=/h+ea/YAa+zMZaaz+w77We67RHGhjm3ilp8FFp4bR8s=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRu7Cb7PLVUHTSESuurD/2/2vJ1Gom2XrysP 9DCSV09gWWJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbgAKCRDa6OEJdZac 5c7mD/4kkJGzwQA+qeasTaVIf+Cbvsj1vjH8ZnEvNKa7xhDGlup63W8UVIVJFMCUmmYk3dhrVV0 4KA4OWilDH5ErPbvgYI6X0CnmpupEodQO9OEsgo9pS681V3tfIoyjUGzFu3dxTg+p7QPQwNBk6+ lizsPgPLyi4xOH313/5H+rAyehaFjGwyWPC+/SWeKzhG1FDBv2/6M5zvGBmivaW95RNth9Rt0xi WnG+vnRk0o34tMf6Ottln0DJKJtVsXURM9sBDANOqbsJkVIvu/DddOdUoSjWdUMrBjgyXs9Jevi qUMiCM13dju8JLVJT7/ge9cU7/zXiJwCx8YfjGa1vE/niAYPeGEJeZRgSEbYNP/A4G8qOuOOAym dvIpetQiQdWdfyBKallJCotmORyQ0Z0Y9dxmDtMFaoenXAT+e9Mw54JkxKjXIYubVo02KKo34GN pWxEJzxWyjUywGbJEakzQxxAB+8u4PyakKfrTn+KZGjwTM4Kbgb1mjV/UNxQCP49ZUyT/0X2rMf mqe+IzMcB6kTL9I73TuKSR48Hw95Q/WDzoeoxpVBGne+RY3jn6FlWgm+YG4cgOaN7cSNa4qiAoP BgQcc+npdNg+u6wHQ+agPPz34Irkuqlr1/JdcZWEyEix+xpYCs46TwS8dL4+uHTvMKI74q0KGS8 fgF1iMr5kEcBOkg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894861530154100 Add instance_finalize to free the two pflash devices (when unrealized) and the OEM ID strings allocated during instance_init. Fixes leaks found by ASan. Fixes: 71eb522c4063 ("riscv/virt: Add the PFlash CFI01 device") Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/riscv/virt.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index a1c323e66df..315049bc86c 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -1745,6 +1745,19 @@ static void virt_machine_init(MachineState *machine) qemu_add_machine_init_done_notifier(&s->machine_done); } =20 +static void virt_machine_instance_finalize(Object *obj) +{ + RISCVVirtState *s =3D RISCV_VIRT_MACHINE(obj); + + for (int i =3D 0; i < ARRAY_SIZE(s->flash); i++) { + if (s->flash[i] && !qdev_is_realized(DEVICE(s->flash[i]))) { + object_unref(OBJECT(s->flash[i])); + } + } + g_free(s->oem_id); + g_free(s->oem_table_id); +} + static void virt_machine_instance_init(Object *obj) { RISCVVirtState *s =3D RISCV_VIRT_MACHINE(obj); @@ -1984,6 +1997,7 @@ static const TypeInfo virt_machine_typeinfo =3D { .parent =3D TYPE_MACHINE, .class_init =3D virt_machine_class_init, .instance_init =3D virt_machine_instance_init, + .instance_finalize =3D virt_machine_instance_finalize, .instance_size =3D sizeof(RISCVVirtState), .interfaces =3D (const InterfaceInfo[]) { { TYPE_HOTPLUG_HANDLER }, --=20 2.54.0 From nobody Sat May 30 18:34:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894849; cv=none; d=zohomail.com; s=zohoarc; b=gaIkZQRGzgd9+hzV1wHY+2wKxOH+TS7hFev4O4kUnuYPSfZB5uo/XMr44dKiTEcbTv9Y4JUtgD6eWV/Tp7U3Tsk+YFPYX6xs/ftdaW19BfLmrhkENe0UQjh4i9vG1FHe1wvm0mZz4qJb4hT0SOHtKweCIL7KO6S0N966gstmThI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894849; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0OfyzipyaFyY1CMp4s0Vws0Sy7SQL4ehZCVUgrOMSFM=; b=C7CfvPxMUOv1p9IyE/nDyF3WX3IcM+j5law+VwtbWu4j01EL7CjU+RMwk2Oedl2ADVf5i7pCnJ2MTgML+ivSMopyQ1fX6rVQ+iHOO8aOww+kfTJlA/NI7TjZMMWNm7SaNJ/EBQUYqH52+kC4PPTfTHnLvL9dWx8cfAB1ZNhRK9U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177789484991123.369654186409434; Mon, 4 May 2026 04:40:49 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJreO-0001mn-00; Mon, 04 May 2026 07:39:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJreF-0001Vc-OY for qemu-devel@nongnu.org; Mon, 04 May 2026 07:39:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJreE-0001Vx-G3 for qemu-devel@nongnu.org; Mon, 04 May 2026 07:39:39 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-246-r1_Ggph-NZChr9b0jYWtXw-1; Mon, 04 May 2026 07:39:36 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B810B19560A2 for ; Mon, 4 May 2026 11:39:35 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6D3CB1800446; Mon, 4 May 2026 11:39:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894777; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0OfyzipyaFyY1CMp4s0Vws0Sy7SQL4ehZCVUgrOMSFM=; b=QXK/VMs3zfNoQqCKTFZHm/YIatSeSekRscxchlXNzre0EjYfrjwwRqUrCzxCFdsBIDGUJK qYsZGw2fmYJ8C6nkHygM27KfcU6fID/ttGQWmZPtwgI23qZfJtUAOGdDKTh45MLCEGfyjx Q9mtWmDz/vNyv3P9WcGTI9ngFA2lyhk= X-MC-Unique: r1_Ggph-NZChr9b0jYWtXw-1 X-Mimecast-MFC-AGG-ID: r1_Ggph-NZChr9b0jYWtXw_1777894775 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:33 +0400 Subject: [PATCH v2 45/46] hw/i2c/pmbus: fix undefined behavior in pmbus_direct_mode2data MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-45-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1137; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=tLDFCKiyZ3IHoxFsadnpmt3a+eVCWPPwxdz50j2s6oQ=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRuzEwHy/3uM3LhfvD1h1GLoHgnQh+T9RSov wVKj8uq/8uJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbgAKCRDa6OEJdZac 5fbKD/4o51Pq9FXe5oLI4wtU1/Ymo3XZd/+0e1d8KTK2M055ke++G5391NeFtV/Xy648iKRZjNV o0mL0c3F3TRlZOM7EON4dzylMpnwe3e4MW15Ft0QmluYpApHDFSSfFc6A4RSKN0IrkwnM2c4Oc1 L/4GAIxQYu4EZpbrw5GVheLQppS3Dtwk8ne0DdAEQSC21WuDOZWzwjeN5Jjy0WG8WNhToV3Jpu1 B78P8jualYUQRf3FlD3Gsjdn2AxxTR46x155ExQjhVwEcS6KqQQbzHmHmcu55e5lGvt3C1t0pLG 3xUzAUYaZUn+NF+C8x/TKXXKol4XaCWtj6jJobwAvYu5KFYhEB7U8oXMSKOxsW5COob3BkpCANt sAOcanAyy4RNcpunC998zo8F6mFbm3Jlo/oLYJW00eCXaSjqFsOcEZ2MV3yWBG8wR0EOurdGA3B aYNR3O3szQXJX4IJjkTCC8jIQDgDBSasGluwz7Q3w4y1z7rhdFBSPThEn1wF38mqRzmcKKOrI1s pSSL1dMTdCuoFzrPo1CipyuPnAlJzJRVugxKLfpT/4Jj1+gb2vl7eMLUcsvVa8jJoEdoDUh8P6C TACksSE3N/CPmSK9+gaqDa1gn7xt+SKYb8qf+7N6Fh2L9oaM9ki70nmY8hNXS49UsVMXKMtmlC+ GMb/wkxQXXM0/Vg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894851387154100 The intermediate result of (Y * 10^-R - b) / m can be negative when the bias (b) is large and the raw register value is small (e.g. zero on an uninitialized device). Assigning that negative double to uint32_t is undefined behavior, caught by UBSan/clang. Use a double intermediate and clamp negative results to zero. Fixes: 3746d5c15e70 ("hw/i2c: add support for PMBus") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/i2c/pmbus_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c index 853dc4b4342..861f5b4fb63 100644 --- a/hw/i2c/pmbus_device.c +++ b/hw/i2c/pmbus_device.c @@ -23,8 +23,8 @@ uint16_t pmbus_data2direct_mode(PMBusCoefficients c, uint= 32_t value) uint32_t pmbus_direct_mode2data(PMBusCoefficients c, uint16_t value) { /* X =3D (Y * 10^-R - b) / m */ - uint32_t x =3D (value / pow(10, c.R) - c.b) / c.m; - return x; + double x =3D (value / pow(10, c.R) - c.b) / c.m; + return (x > 0) ? (uint32_t)x : 0; } =20 uint16_t pmbus_data2linear_mode(uint16_t value, int exp) --=20 2.54.0 From nobody Sat May 30 18:34:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777894853; cv=none; d=zohomail.com; s=zohoarc; b=Os5ayi5w7ufA727ikN5bpl3UiocPeVJbiGXNA8EnIPHp5jK4aAsj/VZX6J5lZw/2xGtEGMrP5dqQ+hb+XKiswk6X3rYBYS4DEw2g4oxOlFd4lRYNl6By7qevD4mbWi+9cziHqmGKX5qXdYw7OhtDprefVxrSE3GJUbPNGYe06h4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777894853; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=OR1htZtPy9/ewnuvz0qTtYpMlOdlZO7yT3IR5sS3quc=; b=bgBhjzd3eUogC8RLKqwWtRDnfiK2rIBlxO1Qw+ZNhaBLwHQ0aQMk3QST/DomZ284Oj4jYx/cAiUXktRZL3rfcb6dS1p18DDvG5NlpXVPQ/SXoWaAEp5iOogMlsejw7aVdAV/sbWJFUcNdT+FOxbCpZSC13EiLiHpFfPc6KNPoBY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777894853526429.16810122081324; Mon, 4 May 2026 04:40:53 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wJreS-0002Q9-E4; Mon, 04 May 2026 07:39:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJreL-0001a0-Js for qemu-devel@nongnu.org; Mon, 04 May 2026 07:39:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wJreK-0001WJ-2F for qemu-devel@nongnu.org; Mon, 04 May 2026 07:39:45 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-496-XtjKbE28NnWnxmF-LCI41A-1; Mon, 04 May 2026 07:39:42 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 619D2195609F for ; Mon, 4 May 2026 11:39:41 +0000 (UTC) Received: from localhost (unknown [10.44.24.4]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 01CB91800480; Mon, 4 May 2026 11:39:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777894783; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OR1htZtPy9/ewnuvz0qTtYpMlOdlZO7yT3IR5sS3quc=; b=hnR/fSlg9C+LQDwFrLraBI1nOUOAkTSGN/Cy41RfthbbI2Km3RAjhc8FZlGLD+xrYPEs8X 3uLfxcYwcYajcsuzdOyiXChhfr4zp68qbBn4EfBKE5OLHZDgscpUUUPdHAGQ/pNa7Vu1zC AZmZck0Aun5lkVI3HMOJp60wdS/Hxoo= X-MC-Unique: XtjKbE28NnWnxmF-LCI41A-1 X-Mimecast-MFC-AGG-ID: XtjKbE28NnWnxmF-LCI41A_1777894781 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 04 May 2026 15:35:34 +0400 Subject: [PATCH v2 46/46] qtest: add "qom-tests" command MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-qom-tests-v2-46-ef7e3dc94f7a@redhat.com> References: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> In-Reply-To: <20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=4927; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=E9TpC9GWV8bqxBoLpoxzMTuPROZJrQcouJvw3SoAg8M=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRuaF0a9jmoWRbNyjGaxuhLUmB4IG74V+4C6 enXj/Iu1EeJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbgAKCRDa6OEJdZac 5bUmD/0fsu4AwWUA/xzLySW6gtXHT2lYcJtT1dGUy00pPv43BP3Zy+8hqF71RwUQ0kdq+BfMciV 39OO+Y0hUUl8vjtfO//FsVklsl0pIIHjtSFHEqPBEvsCKz/lXfPSNDtpCpy9S0yRt9r5Qvxe5Td 0irJWDhspBACxtg6rIwQgs4mW1Ow0KHEOJaUQNj5s947+VYXoqTATNvmLxBLd6GMq49dSpoFCr2 qyCNfMNdwMZ24QIccLepfGgDmyMmPdypn0R97IuGxN0F0cIo0qmI17croDoNCk2bijXBo7YL4eT o9pRRI8uQHzuR4LhuzzEPFamOPhb42cd5HJAzFtW9HBo9gIhqcYe2sAfRW2RTITrFGdGinz+uXe 5F7h+lDGENiuEHzsYHVAZgkw8TIGn7kQgmkVmr7nuCpoRto5RvyM2TT3IVUsYwWteT30CZV8Q9y JtBaBYqDBrpb3U84FnpIj5WSuIVB3T1EVnxidj1ylovGIytWW400b+nO3dZ7/pAlT587wH3KzSG kccOTafecCAwZ36+wI80sWikGPo9BMiaifHQehW/2os0LhWoT35VHuPyYxpF9uV1OrKYHE5foB7 CkVzsCDgQ5pBc1BQXjvgze11jyd74yZJg5On/T1+t6K8y/TqlaLoQNR/UdT8boqOd7VlFLAuk7A wgV7IL/rKK9JpLg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777894855383158500 Add a new "qom-tests" to exercise basic object lifecycle. Instantiate all non-abstract objects, get and set properties and unref. This should quickly find leaks and other related issues that are eventually triggerable at run-time with QMP qom commands. Signed-off-by: Marc-Andr=C3=A9 Lureau --- tests/qtest/libqtest.h | 8 ++++++++ system/qtest.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++ tests/qtest/libqtest.c | 6 ++++++ tests/qtest/qom-test.c | 12 ++++++++++++ 4 files changed, 72 insertions(+) diff --git a/tests/qtest/libqtest.h b/tests/qtest/libqtest.h index 9c118c89ca0..02d65ecb65d 100644 --- a/tests/qtest/libqtest.h +++ b/tests/qtest/libqtest.h @@ -426,6 +426,14 @@ char *qtest_vhmp(QTestState *s, const char *fmt, va_li= st ap) =20 void qtest_module_load(QTestState *s, const char *prefix, const char *libn= ame); =20 +/** + * qtest_qom_tests: + * @s: #QTestState instance to operate on. + * + * Run QOM property get/set round-trip tests on all non-abstract types. + */ +void qtest_qom_tests(QTestState *s); + /** * qtest_get_irq: * @s: #QTestState instance to operate on. diff --git a/system/qtest.c b/system/qtest.c index a79d10d1361..a44a581a518 100644 --- a/system/qtest.c +++ b/system/qtest.c @@ -31,6 +31,8 @@ #include "qemu/cutils.h" #include "qemu/target-info.h" #include "qom/object_interfaces.h" +#include "qom/qom-qobject.h" +#include "qobject/qobject.h" =20 #define MAX_IRQ 256 =20 @@ -754,6 +756,50 @@ static void qtest_process_command(CharFrontend *chr, g= char **words) new_ns =3D qemu_clock_advance_virtual_time(ns); qtest_sendf(chr, "%s %"PRIi64"\n", new_ns =3D=3D ns ? "OK" : "FAIL", new_ns); + } else if (strcmp(words[0], "qom-tests") =3D=3D 0) { + GSList *list, *l; + + list =3D object_class_get_list(NULL, false); + for (l =3D list; l; l =3D l->next) { + ObjectClass *klass =3D l->data; + const char *type_name =3D object_class_get_name(klass); + Object *obj; + ObjectPropertyIterator iter; + ObjectProperty *prop; + + obj =3D object_new_with_class(klass); + object_property_iter_init(&iter, obj); + while ((prop =3D object_property_iter_next(&iter))) { + QObject *value; + Error *local_err =3D NULL; + + value =3D object_property_get_qobject(obj, prop->name, + &local_err); + if (local_err) { + error_report("qom-tests: %s.%s: get failed: %s", + type_name, prop->name, + error_get_pretty(local_err)); + error_free(local_err); + continue; + } + + if (prop->set) { + if (!object_property_set_qobject(obj, prop->name, valu= e, + &local_err)) { + error_report("qom-tests: %s.%s: set failed: %s", + type_name, prop->name, + error_get_pretty(local_err)); + error_free(local_err); + } + } + + qobject_unref(value); + } + + object_unref(obj); + } + g_slist_free(list); + qtest_send(chr, "OK\n"); } else if (process_command_cb && process_command_cb(chr, words)) { /* Command got consumed by the callback handler */ } else { diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c index 116a8a32583..1d77d003112 100644 --- a/tests/qtest/libqtest.c +++ b/tests/qtest/libqtest.c @@ -1138,6 +1138,12 @@ void qtest_module_load(QTestState *s, const char *pr= efix, const char *libname) qtest_rsp(s); } =20 +void qtest_qom_tests(QTestState *s) +{ + qtest_sendf(s, "qom-tests\n"); + qtest_rsp(s); +} + static int64_t qtest_clock_rsp(QTestState *s) { gchar **words; diff --git a/tests/qtest/qom-test.c b/tests/qtest/qom-test.c index 6421f2d9d9f..cf4c6b5add5 100644 --- a/tests/qtest/qom-test.c +++ b/tests/qtest/qom-test.c @@ -227,6 +227,17 @@ static void add_machine_test_case(const char *mname) g_free(path); } =20 +static void test_qom_qtests(void) +{ + QTestState *qts; + + qts =3D qtest_initf("-machine none"); + + qtest_qom_tests(qts); + + qtest_quit(qts); +} + int main(int argc, char **argv) { char *v_env =3D getenv("V"); @@ -238,6 +249,7 @@ int main(int argc, char **argv) g_test_init(&argc, &argv, NULL); =20 qtest_cb_for_every_machine(add_machine_test_case, g_test_quick()); + qtest_add_func("qom/qom-qtests", test_qom_qtests); =20 return g_test_run(); } --=20 2.54.0