From nobody Sat May 30 19:20:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1777489679; cv=none; d=zohomail.com; s=zohoarc; b=hNA30/mx2psgJU7wsPM7TPe6rDC6Uq4b0PtXZkKa3V0kZ4Kxlk4Xwj2KF1YoWK+/Urrvly4xvYTX7lLR2sT14LYAaajHitbIB3pJ+z9d6ZDtraxD0hv1Ec0rHBwRCtih7NW6uMkXrCEiSM9snBJDDkzK3XK8c+oO/mv+3BBU7gA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777489679; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=eUxDq/SnIjAGROivgUJT7M70dRNJv1YG66xD1uHbj4c=; b=HbnMlTreemnTscwS/GMXeeG1GZ7P1bUjS0iOaZaGZgeUcOI5LLWKbRsQWukxKIKDvyLmBlPwr7nTXVAnK8O46KyVi0yPEOCvieSQq7TgAeYetnnO+OghPS4HnEIVn1kUXQAjQvnwyrkYcKGefkIwiuzrwDm84nV3sTaq1C0nkks= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777489679969935.7426388920845; Wed, 29 Apr 2026 12:07:59 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wIAEV-0001lU-BQ; Wed, 29 Apr 2026 15:06:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wIAET-0001k0-1c for qemu-devel@nongnu.org; Wed, 29 Apr 2026 15:06:01 -0400 Received: from smtp-out1.suse.de ([195.135.223.130]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wIAEQ-0000LF-5o for qemu-devel@nongnu.org; Wed, 29 Apr 2026 15:06:00 -0400 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4EC176A815; Wed, 29 Apr 2026 19:05:55 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id EA272593B0; Wed, 29 Apr 2026 19:05:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ELK6LZFW8mm/eQAAD6G6ig (envelope-from ); Wed, 29 Apr 2026 19:05:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777489556; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eUxDq/SnIjAGROivgUJT7M70dRNJv1YG66xD1uHbj4c=; b=pkwV8D+es/Mq2FDs3LFf3Xn6L5FYJ5EqRhO8wqPH86alJD1MsnVGUvZDvIu3I7JxYWO7h4 m2Bo3+AzkaM291W9XM3AOGJ3HzHeBEbH9BsXp0pFdqxA1LmWhrOZyaeRNVUtZxw0loZ023 OBFuvyu+vP9ZiZnfSbhbGxeRqmL0Wlg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777489556; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eUxDq/SnIjAGROivgUJT7M70dRNJv1YG66xD1uHbj4c=; b=1If5pFj+dtSPaBRyH3HLT1QCV6IXLeG30k2uyKDlnkHnkkMFxWateXobdVsrrtcVO9ZcNS RZP29h2Yp/6NcNBg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=1B8+HuC3; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=bME7acoI DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777489555; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eUxDq/SnIjAGROivgUJT7M70dRNJv1YG66xD1uHbj4c=; b=1B8+HuC3k7/rbbhTdO1yZjVFm4X77j14GOXDfOeTq8KpppTiMPemio+69/Ar4t5XJyfq7r qTXwaWwBbdEvifr5IDtPvp2p6HwzlG2jlQqbkNk5HXBpJ66mHduxj+7wLr8R/GvZDBvvUj Y0Xa2zTM/FhZLUjzmEoMCR5hJe01R6E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777489555; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eUxDq/SnIjAGROivgUJT7M70dRNJv1YG66xD1uHbj4c=; b=bME7acoIXKngUIVFdLcyg9RETTp+zRWMDqS7xAkQz4SiznduE2MLn2oR0mXXGOf3aPOece oqh6DFjMKVMgmkCQ== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Peter Xu , marcandre.lureau@redhat.com, Laurent Vivier , Paolo Bonzini Subject: [PATCH v1 1/5] tests/qtest/dbus-vmstate: Bring the test up-to-date Date: Wed, 29 Apr 2026 16:05:46 -0300 Message-ID: <20260429190550.20122-2-farosas@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260429190550.20122-1-farosas@suse.de> References: <20260429190550.20122-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_TLS_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.de:mid,suse.de:email]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Queue-Id: 4EC176A815 X-Spam-Score: -3.01 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=195.135.223.130; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) (identity @suse.de) X-ZM-MESSAGEID: 1777489681515158500 Content-Type: text/plain; charset="utf-8" The dbus-vmstate-test has been disabled for years. Here's the things that have changed in the meantime and how to update the test: - Migration tests got new headers. Update the includes. - migrate_qmp got new parameters. Update the caller. - migrate_incoming_qmp is now used instead of -incoming URL. Use -incoming defer. - Tests expecting failure should not check non-zero return code. Check for failed migration state instead. - The test result enum was introduced. Replace the migration_fail flag with the enum. - The DEVICE state was added. Replace wait_for_migration_complete with migration_event_wait, which won't trip on intermediary states. - Migration completion was reworked. Explicitly wait for the RESUME event before asserting runstate is RUNNING to avoid checking too quickly and seeing FINISH_MIGRATE instead. - The FAILING state was added. Wait for it before waiting for the RESUME event. - Sanity checks were added to migration_get_env(). Start calling that function in main. - qtest_add_func now has a wrapper. Replace qtest_add_func with migration_test_add. Update tests' signatures to take MigrationCommon, although it's unused. - meson now sets up G_TEST_DBUS_DAEMON. Remove the logic around it. Signed-off-by: Fabiano Rosas Acked-by: Peter Xu Reviewed-by: Marc-Andr=C3=A9 Lureau --- tests/qtest/dbus-vmstate-test.c | 71 +++++++++++++++++++-------------- tests/qtest/meson.build | 7 +++- 2 files changed, 46 insertions(+), 32 deletions(-) diff --git a/tests/qtest/dbus-vmstate-test.c b/tests/qtest/dbus-vmstate-tes= t.c index 0a82cc9f93..90c050b448 100644 --- a/tests/qtest/dbus-vmstate-test.c +++ b/tests/qtest/dbus-vmstate-test.c @@ -2,8 +2,8 @@ #include #include #include "libqtest.h" +#include "migration/migration-qmp.h" #include "dbus-vmstate1.h" -#include "migration-helpers.h" =20 static char *workdir; =20 @@ -29,7 +29,7 @@ typedef struct TestServer { =20 typedef struct Test { const char *id_list; - bool migrate_fail; + int result; bool without_dst_b; TestServer srcA; TestServer dstA; @@ -190,6 +190,7 @@ test_dbus_vmstate(Test *test) g_autofree char *uri =3D NULL; QTestState *src_qemu =3D NULL, *dst_qemu =3D NULL; guint ownsrcA, ownsrcB, owndstA, owndstB; + QTestMigrationState src_state =3D { }; =20 uri =3D g_strdup_printf("unix:%s/migsocket", workdir); =20 @@ -224,17 +225,33 @@ test_dbus_vmstate(Test *test) =20 src_qemu =3D qtest_init(src_qemu_args); dst_qemu =3D qtest_init(dst_qemu_args); + + migrate_set_capability(src_qemu, "events", true); + qtest_qmp_set_event_callback(src_qemu, migrate_watch_for_events, + &src_state); + set_id_list(test, src_qemu); set_id_list(test, dst_qemu); =20 thread =3D g_thread_new("dbus-vmstate-thread", dbus_vmstate_thread, lo= op); =20 migrate_incoming_qmp(dst_qemu, uri, NULL, "{}"); - migrate_qmp(src_qemu, uri, "{}"); + migrate_ensure_converge(src_qemu); + migrate_qmp(src_qemu, NULL, uri, NULL, "{}"); test->src_qemu =3D src_qemu; - if (test->migrate_fail) { - wait_for_migration_fail(src_qemu, true); - qtest_set_expected_status(dst_qemu, EXIT_FAILURE); + + if (test->result !=3D MIG_TEST_SUCCEED) { + QDict *rsp; + + migration_event_wait(src_qemu, "failing"); + wait_for_resume(src_qemu, &src_state); + migration_event_wait(src_qemu, "failed"); + + rsp =3D qtest_qmp_assert_success_ref(src_qemu, + "{ 'execute': 'query-status' }"= ); + g_assert(qdict_haskey(rsp, "running")); + g_assert(qdict_get_bool(rsp, "running")); + qobject_unref(rsp); } else { wait_for_migration_complete(src_qemu); } @@ -270,7 +287,7 @@ check_migrated(TestServer *s, TestServer *d) } =20 static void -test_dbus_vmstate_without_list(void) +test_dbus_vmstate_without_list(char *name, MigrateCommon *args) { Test test =3D { 0, }; =20 @@ -281,7 +298,7 @@ test_dbus_vmstate_without_list(void) } =20 static void -test_dbus_vmstate_with_list(void) +test_dbus_vmstate_with_list(char *name, MigrateCommon *args) { Test test =3D { .id_list =3D "idA,idB" }; =20 @@ -292,7 +309,7 @@ test_dbus_vmstate_with_list(void) } =20 static void -test_dbus_vmstate_only_a(void) +test_dbus_vmstate_only_a(char *name, MigrateCommon *args) { Test test =3D { .id_list =3D "idA" }; =20 @@ -303,9 +320,10 @@ test_dbus_vmstate_only_a(void) } =20 static void -test_dbus_vmstate_missing_src(void) +test_dbus_vmstate_missing_src(char *name, MigrateCommon *args) { - Test test =3D { .id_list =3D "idA,idC", .migrate_fail =3D true }; + Test test =3D { .id_list =3D "idA,idC", + .result =3D MIG_TEST_FAIL }; =20 /* run in subprocess to silence QEMU error reporting */ if (g_test_subprocess()) { @@ -320,11 +338,11 @@ test_dbus_vmstate_missing_src(void) } =20 static void -test_dbus_vmstate_missing_dst(void) +test_dbus_vmstate_missing_dst(char *name, MigrateCommon *args) { Test test =3D { .id_list =3D "idA,idB", .without_dst_b =3D true, - .migrate_fail =3D true }; + .result =3D MIG_TEST_FAIL }; =20 /* run in subprocess to silence QEMU error reporting */ if (g_test_subprocess()) { @@ -343,15 +361,8 @@ int main(int argc, char **argv) { GError *err =3D NULL; - g_autofree char *dbus_daemon =3D NULL; int ret; =20 - dbus_daemon =3D g_build_filename(G_STRINGIFY(SRCDIR), - "tests", - "dbus-vmstate-daemon.sh", - NULL); - g_setenv("G_TEST_DBUS_DAEMON", dbus_daemon, true); - g_test_init(&argc, &argv, NULL); =20 workdir =3D g_dir_make_tmp("dbus-vmstate-test-XXXXXX", &err); @@ -362,16 +373,16 @@ main(int argc, char **argv) =20 g_setenv("DBUS_VMSTATE_TEST_TMPDIR", workdir, true); =20 - qtest_add_func("/dbus-vmstate/without-list", - test_dbus_vmstate_without_list); - qtest_add_func("/dbus-vmstate/with-list", - test_dbus_vmstate_with_list); - qtest_add_func("/dbus-vmstate/only-a", - test_dbus_vmstate_only_a); - qtest_add_func("/dbus-vmstate/missing-src", - test_dbus_vmstate_missing_src); - qtest_add_func("/dbus-vmstate/missing-dst", - test_dbus_vmstate_missing_dst); + migration_test_add("/dbus-vmstate/without-list", + test_dbus_vmstate_without_list); + migration_test_add("/dbus-vmstate/with-list", + test_dbus_vmstate_with_list); + migration_test_add("/dbus-vmstate/only-a", + test_dbus_vmstate_only_a); + migration_test_add("/dbus-vmstate/missing-src", + test_dbus_vmstate_missing_src); + migration_test_add("/dbus-vmstate/missing-dst", + test_dbus_vmstate_missing_dst); =20 ret =3D g_test_run(); =20 diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build index b735f55fc4..0d04e2cbaa 100644 --- a/tests/qtest/meson.build +++ b/tests/qtest/meson.build @@ -126,10 +126,12 @@ if dbus_daemon.found() and gdbus_codegen.found() # Temporarily disabled due to Patchew failures: #qtests_i386 +=3D ['dbus-vmstate-test'] dbus_vmstate1 =3D custom_target('dbus-vmstate description', - output: ['dbus-vmstate1.h', 'dbus-vmstate1= .c'], + build_by_default: true, + output: [ 'dbus-vmstate1.h', 'dbus-vmstate= 1.c'], input: meson.project_source_root() / 'back= ends/dbus-vmstate1.xml', command: [gdbus_codegen, '@INPUT@', '--interface-prefix', 'org.qemu', + '--output-directory', meson.curr= ent_build_dir(), '--generate-c-code', '@BASENAME@= ']).to_list() else dbus_vmstate1 =3D [] @@ -385,7 +387,8 @@ qtests =3D { 'bios-tables-test': [io, 'boot-sector.c', 'acpi-utils.c', 'tpm-emu.c'], 'cdrom-test': files('boot-sector.c'), 'dbus-vmstate-test': files('migration/migration-qmp.c', - 'migration/migration-util.c') + dbus_vmstate1, + 'migration/migration-util.c') + dbus_vmstate1= + + [gio], 'erst-test': files('erst-test.c'), 'ivshmem-test': [rt, '../../contrib/ivshmem-server/ivshmem-server.c'], 'migration-test': test_migration_files + migration_tls_files + migration= _colo_files, --=20 2.51.0 From nobody Sat May 30 19:20:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1777489740; cv=none; d=zohomail.com; s=zohoarc; b=ivaJgiAYmIAPK9esg6pCZfRZuS0KIiYe/bqlZ1gDznFqcAxd+pyfxo1cSKax/JZk3DIaFfc14L1vX5ldk7jPaH2De8uYSVHQf88T6IMrMZiUOkCNGKefEm3XZvt9Xt2Kd/Nikr/vl0g7An4jAD1ZKsaSSiZLRTFJu1HGdBFLW8M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777489740; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=5Q11033ixT9HAxDsw1JBkEAYwLqftpwNv4tC1cNzWxc=; b=gey6u3VcZ8PgmzDUCtkHnYTdog+S+F3sn2ykODj/yLw6WemzX7qOcA7p8BUVv6JT9+cvGPn7nUMDZhECMNwbJBSa/0n2cB3r3l8koEDGcO6OQAaV/qMhNorxK+DhH0VBdZe2j6lVqo0HWXDVK3g0jgb1juLp5lK+Q7s79iCtZpA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777489740251665.4995113344445; Wed, 29 Apr 2026 12:09:00 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wIAEa-0001nN-1m; Wed, 29 Apr 2026 15:06:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wIAEY-0001mR-Gr for qemu-devel@nongnu.org; Wed, 29 Apr 2026 15:06:06 -0400 Received: from smtp-out1.suse.de ([195.135.223.130]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wIAEW-0000Nh-GQ for qemu-devel@nongnu.org; Wed, 29 Apr 2026 15:06:06 -0400 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 16F656A81A; Wed, 29 Apr 2026 19:05:57 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B3317593B1; Wed, 29 Apr 2026 19:05:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id MMhBIJNW8mm/eQAAD6G6ig (envelope-from ); Wed, 29 Apr 2026 19:05:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777489557; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5Q11033ixT9HAxDsw1JBkEAYwLqftpwNv4tC1cNzWxc=; b=fWoIChkEdsZIGGjQyYF+d9cMjEAw+7I6okZFA8A2NMBuYbyusXkNOURG5VsSii5DZIUc1v 0FH935L9kyl1hhU/ImlfwhIDQrgZAPWKfYj8baVg+rRYLWZ4R6K9GMhIm7wuy33anU4qYQ G9r4x58wZGRV8uel4sETiF2qzp7uwJQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777489557; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5Q11033ixT9HAxDsw1JBkEAYwLqftpwNv4tC1cNzWxc=; b=lIOiwFlEO/SIqa/N/BLmB4/Dxsb+Mk8mzZbhahih0SC6pgzlyq7FBqGxDh+qex8A1egxxj rJNK2Zqs6J6PToCg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=fWoIChkE; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=lIOiwFlE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777489557; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5Q11033ixT9HAxDsw1JBkEAYwLqftpwNv4tC1cNzWxc=; b=fWoIChkEdsZIGGjQyYF+d9cMjEAw+7I6okZFA8A2NMBuYbyusXkNOURG5VsSii5DZIUc1v 0FH935L9kyl1hhU/ImlfwhIDQrgZAPWKfYj8baVg+rRYLWZ4R6K9GMhIm7wuy33anU4qYQ G9r4x58wZGRV8uel4sETiF2qzp7uwJQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777489557; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5Q11033ixT9HAxDsw1JBkEAYwLqftpwNv4tC1cNzWxc=; b=lIOiwFlEO/SIqa/N/BLmB4/Dxsb+Mk8mzZbhahih0SC6pgzlyq7FBqGxDh+qex8A1egxxj rJNK2Zqs6J6PToCg== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Peter Xu , marcandre.lureau@redhat.com, Laurent Vivier , Paolo Bonzini Subject: [PATCH v1 2/5] tests/qtest/dbus-vmstate: Mute Glib complaints about g_unsetenv thread-safety Date: Wed, 29 Apr 2026 16:05:47 -0300 Message-ID: <20260429190550.20122-3-farosas@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260429190550.20122-1-farosas@suse.de> References: <20260429190550.20122-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; DWL_DNSWL_BLOCKED(0.00)[suse.de:dkim]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:mid,suse.de:dkim,suse.de:email,gnome.org:url]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-Spam-Score: -3.01 X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: 16F656A81A Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=195.135.223.130; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1777489741708158500 Content-Type: text/plain; charset="utf-8" TLDR: GLib is bugged, the dbus-vmstate-test spams debug messages unconditionally. Mute them. GLib is trying to protect against the lack of thread-safety of setenv/unsetsenv functions by warning when those functions were invoked after a thread has been started. https://gitlab.gnome.org/GNOME/glib/issues/715 Unfortunately: 1) GLib itself starts a thread pool via _g_dbus_initialize when working around a bug in its type dependency chain. This happens in many places, but the test triggers it via g_dbus_address_get_for_bus_sync. https://bugzilla.gnome.org/show_bug.cgi?id=3D627724 2) GLib itself calls g_unsetenv after the test calls g_test_dbus_up. 3) The debug message at g_unsetenv is issued to the G_LOG_DOMAIN defined while compiling the library, i.e "GLib", but this domain is never initialized, so the log functions go into a fallback chain that results in ignoring the G_MESSAGES_DEBUG environment variable, causing the debug messages to not be suppressed when they should. Mute the messages by implementing a handler for G_LOG_LEVEL_DEBUG in the "GLib" log domain and honoring G_MESSAGES_DEBUG. Signed-off-by: Fabiano Rosas Reviewed-by: Marc-Andr=C3=A9 Lureau --- tests/qtest/dbus-vmstate-test.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/tests/qtest/dbus-vmstate-test.c b/tests/qtest/dbus-vmstate-tes= t.c index 90c050b448..51c5fdb995 100644 --- a/tests/qtest/dbus-vmstate-test.c +++ b/tests/qtest/dbus-vmstate-test.c @@ -357,12 +357,33 @@ test_dbus_vmstate_missing_dst(char *name, MigrateComm= on *args) g_test_trap_assert_passed(); } =20 +static void log_func(const gchar *log_domain, GLogLevelFlags log_level, + const gchar *message, gpointer user_data) +{ + const gchar *domains; + + assert(log_level & G_LOG_LEVEL_DEBUG); + + domains =3D getenv("G_MESSAGES_DEBUG"); + if (!domains || (!strstr(domains, "GLib") && !strstr(domains, "all")))= { + return; + } + g_log_default_handler("GLib", G_LOG_LEVEL_DEBUG, message, NULL); +} + int main(int argc, char **argv) { GError *err =3D NULL; int ret; =20 + /* + * GLib currently emits debug messages that ignore + * G_MESSAGES_DEBUG. Set a custom log handler to work around the + * issue. + */ + g_log_set_handler("GLib", G_LOG_LEVEL_DEBUG, log_func, NULL); + g_test_init(&argc, &argv, NULL); =20 workdir =3D g_dir_make_tmp("dbus-vmstate-test-XXXXXX", &err); --=20 2.51.0 From nobody Sat May 30 19:20:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1777489649; cv=none; d=zohomail.com; s=zohoarc; b=LlsKLiOHNMbBSCLy3kXkH5IrW2X3PrUSWtiICUInAevC1xYKOFTMZy6TeIyxRMsPTyamrZDO/KvdasT2AWIcos8JeEueXX/KrW3SNzOqlQio9h5ddGWZLk4KHh8p0QNgRYgwFImBj+162OlA2KRZFEvNy18oBIS88uDHquJ84xk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777489649; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=7W+LG/e4N84hX6vct4e3E6sskFPEJKhlBBC5LD9xxeI=; b=GjbQQNA60pc3pqwwX0tBVvXKOPgkI50v2HG/mcs4f+K0xtosfqEoKHHZpBSFiaOYjWM/P51GKD/mZinffrsi6fXh+cmYnCX/Cz64aHRAxCJLYYLSy+3Blibs0IHC+E19SMlaT8bRe7aCUIdY5mL8lUqTY75cn/b+A3cbQw1C01I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777489649395900.5811457015864; Wed, 29 Apr 2026 12:07:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wIAEf-0001wc-Tb; Wed, 29 Apr 2026 15:06:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wIAEf-0001uN-23 for qemu-devel@nongnu.org; Wed, 29 Apr 2026 15:06:13 -0400 Received: from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wIAEc-0000Rs-Ru for qemu-devel@nongnu.org; Wed, 29 Apr 2026 15:06:12 -0400 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D65926A81C; Wed, 29 Apr 2026 19:05:58 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7D44B593B0; Wed, 29 Apr 2026 19:05:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 8NEgE5VW8mm/eQAAD6G6ig (envelope-from ); Wed, 29 Apr 2026 19:05:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777489558; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7W+LG/e4N84hX6vct4e3E6sskFPEJKhlBBC5LD9xxeI=; b=wXD1NvKKOa6nwk1FEdsR9VXb4sxy95k2w4iBSh4ox6N5vaOVvOZfusKXe8dzon42pmTCeJ QTPTonDhclVFyKJNUHXAqWMQzXqNUAzp2dZDsRJu9Kp0w45zjDSkRnTguICavHHRImGpno ncY0MgVXr99jaS6+to0sGa+a6oWNGsw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777489558; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7W+LG/e4N84hX6vct4e3E6sskFPEJKhlBBC5LD9xxeI=; b=rpjVOoXpYhgqDWOru3XggElXVsaR3Kn+FpIGjy1XQDZPHECKi60i8sr+jn+hhKHFvzTD/L QBvQNVpJUQhASeBg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777489558; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7W+LG/e4N84hX6vct4e3E6sskFPEJKhlBBC5LD9xxeI=; b=wXD1NvKKOa6nwk1FEdsR9VXb4sxy95k2w4iBSh4ox6N5vaOVvOZfusKXe8dzon42pmTCeJ QTPTonDhclVFyKJNUHXAqWMQzXqNUAzp2dZDsRJu9Kp0w45zjDSkRnTguICavHHRImGpno ncY0MgVXr99jaS6+to0sGa+a6oWNGsw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777489558; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7W+LG/e4N84hX6vct4e3E6sskFPEJKhlBBC5LD9xxeI=; b=rpjVOoXpYhgqDWOru3XggElXVsaR3Kn+FpIGjy1XQDZPHECKi60i8sr+jn+hhKHFvzTD/L QBvQNVpJUQhASeBg== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Peter Xu , marcandre.lureau@redhat.com, Laurent Vivier , Paolo Bonzini Subject: [PATCH v1 3/5] tests/qtest/dbus-vmstate: Honor QTEST_LOG env variable Date: Wed, 29 Apr 2026 16:05:48 -0300 Message-ID: <20260429190550.20122-4-farosas@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260429190550.20122-1-farosas@suse.de> References: <20260429190550.20122-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:email]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_TLS_ALL(0.00)[] X-Spam-Score: -2.80 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:1; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1777489651231158500 Content-Type: text/plain; charset="utf-8" Don't hide QEMU error messages unconditionally, make the tests that expect to fail honor QTEST_LOG and show every output if the variable is set. Signed-off-by: Fabiano Rosas Reviewed-by: Marc-Andr=C3=A9 Lureau --- tests/qtest/dbus-vmstate-test.c | 28 +++++++++++++++------------- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/tests/qtest/dbus-vmstate-test.c b/tests/qtest/dbus-vmstate-tes= t.c index 51c5fdb995..05e598a3e3 100644 --- a/tests/qtest/dbus-vmstate-test.c +++ b/tests/qtest/dbus-vmstate-test.c @@ -324,17 +324,18 @@ test_dbus_vmstate_missing_src(char *name, MigrateComm= on *args) { Test test =3D { .id_list =3D "idA,idC", .result =3D MIG_TEST_FAIL }; + bool silent =3D !getenv("QTEST_LOG"); =20 /* run in subprocess to silence QEMU error reporting */ - if (g_test_subprocess()) { - test_dbus_vmstate(&test); - check_not_migrated(&test.srcA, &test.dstA); - check_not_migrated(&test.srcB, &test.dstB); + if (silent && !g_test_subprocess()) { + g_test_trap_subprocess(NULL, 0, 0); + g_test_trap_assert_passed(); return; } =20 - g_test_trap_subprocess(NULL, 0, 0); - g_test_trap_assert_passed(); + test_dbus_vmstate(&test); + check_not_migrated(&test.srcA, &test.dstA); + check_not_migrated(&test.srcB, &test.dstB); } =20 static void @@ -343,18 +344,19 @@ test_dbus_vmstate_missing_dst(char *name, MigrateComm= on *args) Test test =3D { .id_list =3D "idA,idB", .without_dst_b =3D true, .result =3D MIG_TEST_FAIL }; + bool silent =3D !getenv("QTEST_LOG"); =20 /* run in subprocess to silence QEMU error reporting */ - if (g_test_subprocess()) { - test_dbus_vmstate(&test); - assert(test.srcA.save_called); - assert(test.srcB.save_called); - assert(!test.dstB.save_called); + if (silent && !g_test_subprocess()) { + g_test_trap_subprocess(NULL, 0, 0); + g_test_trap_assert_passed(); return; } =20 - g_test_trap_subprocess(NULL, 0, 0); - g_test_trap_assert_passed(); + test_dbus_vmstate(&test); + assert(test.srcA.save_called); + assert(test.srcB.save_called); + assert(!test.dstB.save_called); } =20 static void log_func(const gchar *log_domain, GLogLevelFlags log_level, --=20 2.51.0 From nobody Sat May 30 19:20:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1777489646; cv=none; d=zohomail.com; s=zohoarc; b=DDIiaYA4g953orakjOEhRu0AYdnuE+7enIL6TPm0fT//xqxOJO3K68LvFh3ZBaLjfxf9PoFFgDhS4uAr49WNyITVyaXb8ojYOcZSeeyztPdDfglt86+nB4ECjPwVHErKV4APWoGKy+VCVE38fNmbRiLfS54322b8FDbLKFvtjxU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777489646; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=YuIC/5ApKnZIeBsrthfG2kENi8s5IqdSqJq9eBy6xCM=; b=byWLXef1aVlaw5197bnYvP3egj+uHtzIaO2yQm+OzPcHdbThiHOdIR1TubNHT0DkQhbAWwoZ0MaX5qDKUKJxr7qjPttBnweeq1x+GIaomqRe86AqLttPnMoh0TNbnX3rzzl0iUmukMlZ98bja52u8yXJeVukVNEPzUMRjxP+hZs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777489646344498.2677057426006; Wed, 29 Apr 2026 12:07:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wIAF0-00024j-FA; Wed, 29 Apr 2026 15:06:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wIAEk-000235-Us for qemu-devel@nongnu.org; Wed, 29 Apr 2026 15:06:18 -0400 Received: from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wIAEi-0000V7-UP for qemu-devel@nongnu.org; Wed, 29 Apr 2026 15:06:18 -0400 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A01896A820; Wed, 29 Apr 2026 19:06:00 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 44CE2593B0; Wed, 29 Apr 2026 19:05:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id UHZXBZdW8mm/eQAAD6G6ig (envelope-from ); Wed, 29 Apr 2026 19:05:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777489561; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YuIC/5ApKnZIeBsrthfG2kENi8s5IqdSqJq9eBy6xCM=; b=QvNqfviQ46jREZ/i5WFNKBEg35w5OTN5KdX1WZ1RdVPRkYLNxOpWUPulzP7pxHZs+QO7aO fiD8WBMmTDawcUOWBqulvo+2TNpfKGnC/SbNm8VPKOYRLT9yhxIuy/1eqMntskLVXAD6+Q pSbo1y3xrjrXOZt5KaS9JQOSogbTPiw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777489561; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YuIC/5ApKnZIeBsrthfG2kENi8s5IqdSqJq9eBy6xCM=; b=Cg5YxdUH9yV3tBfeumcCIs4X1DSXFpwTIOTsH2jJW5kT20hdJnZosss0PmlsBVb/+AFNoz 1LhUbshL8DK7NhAw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=SyqCtA9l; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="yXNb0n/1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777489560; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YuIC/5ApKnZIeBsrthfG2kENi8s5IqdSqJq9eBy6xCM=; b=SyqCtA9lV3j6YpTOyCJhHmubdbg4KVAQQGnrbS8lYF/fr/puHQ1NyfU3UosFQ/KUu9GLlR ylz/Cy9HNZurogUtzTbdIcYKbaUd64urXM9UyK2Ut611grSLZ2iKVhx3zNIejrTBRlvBtm jNgOl9igduX3iC2J1q84LO0jzoXZYyc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777489560; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YuIC/5ApKnZIeBsrthfG2kENi8s5IqdSqJq9eBy6xCM=; b=yXNb0n/1ofw2PcJXkOmxcnfgCdvDQwgOja0WXX6QqZm6gXtKwVeoYZgo1aupLmXRGdHn3I 7UHYI8GVvkjgujCw== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Peter Xu , marcandre.lureau@redhat.com, Laurent Vivier , Paolo Bonzini Subject: [PATCH v1 4/5] tests/qtest/dbus-vmstate: Stop the daemons explicitly Date: Wed, 29 Apr 2026 16:05:49 -0300 Message-ID: <20260429190550.20122-5-farosas@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260429190550.20122-1-farosas@suse.de> References: <20260429190550.20122-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DWL_DNSWL_BLOCKED(0.00)[suse.de:dkim]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_TLS_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:mid,suse.de:dkim,suse.de:email]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-Spam-Score: -3.01 X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: A01896A820 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:1; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) (identity @suse.de) X-ZM-MESSAGEID: 1777489647308158500 Content-Type: text/plain; charset="utf-8" The dbus-vmstate test is currently non-deterministically emitting a "cleaning up pid" message, followed by the PID of one of the dbus-daemon processes used during the test. This is due to a race between the GTestDBus g_autoptr destructor and a child process that does cleanup when the program ends. Add calls to g_test_dbus_down() to make the issuance of the SIGTERM to the dbus-daemon deterministic. Signed-off-by: Fabiano Rosas Reviewed-by: Marc-Andr=C3=A9 Lureau --- tests/qtest/dbus-vmstate-test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qtest/dbus-vmstate-test.c b/tests/qtest/dbus-vmstate-tes= t.c index 05e598a3e3..15c35e7c0f 100644 --- a/tests/qtest/dbus-vmstate-test.c +++ b/tests/qtest/dbus-vmstate-test.c @@ -260,11 +260,12 @@ test_dbus_vmstate(Test *test) qtest_quit(src_qemu); g_bus_unown_name(ownsrcA); g_bus_unown_name(ownsrcB); + g_test_dbus_down(srcbus); g_bus_unown_name(owndstA); if (!test->without_dst_b) { g_bus_unown_name(owndstB); } - + g_test_dbus_down(dstbus); g_main_loop_quit(test->loop); } =20 --=20 2.51.0 From nobody Sat May 30 19:20:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1777489727; cv=none; d=zohomail.com; s=zohoarc; b=hEniqWE0tfVTkbZHaPXad5fTagjFC9P0hd4gL2rjcd1+aDlOEQMnoxQz+chmrANfEpBEyReNaCB41iMgL1O+H/FN+SHIDPDpraHlTqjVoQbFWur6yKUKA268PDZ4Kdh+xN1KOxv4fdlzK6tv47xbndOmsHpV2aUiuunzhSIxK8I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777489727; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XFuWhPG5UR/GLn09TTRumzpk9PUd1gSL+5XeS232Sak=; b=MGUkFJkfGVeC1IGLd8cloAOvFSSd+Zol9nCLXup2+1+F0JPJup6vXcGBJLuh/5+wyP6KHyb58FMkAkaEi8O3ZHkdAH4jcbJw9NJ4dg2GhPkCp8LiAR+XNDhh5Sch9eSRJX3WCv1+Mz9jlPlQyJ+FLLf4h8Zxc1kGTZeq8Dm9Pos= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777489727425155.614403765941; Wed, 29 Apr 2026 12:08:47 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wIAEa-0001o3-Lb; Wed, 29 Apr 2026 15:06:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wIAEY-0001mG-AP for qemu-devel@nongnu.org; Wed, 29 Apr 2026 15:06:06 -0400 Received: from smtp-out2.suse.de ([2a07:de40:b251:101:10:150:64:2]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wIAEW-0000Nd-GJ for qemu-devel@nongnu.org; Wed, 29 Apr 2026 15:06:06 -0400 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6622A5BD6D; Wed, 29 Apr 2026 19:06:02 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0E031593B1; Wed, 29 Apr 2026 19:06:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id eNyaM5hW8mm/eQAAD6G6ig (envelope-from ); Wed, 29 Apr 2026 19:06:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777489562; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XFuWhPG5UR/GLn09TTRumzpk9PUd1gSL+5XeS232Sak=; b=M+GCoO8SS8lhNzIleffL96cJL6qYywrPHdUGSZsrH1jWg8vGYsHS5SjwutRJDQ6R8PkIVR hAoP5Myy/JMCsRqom2tSGVyKOcIJ1/2xmyV/LuACS+oR3wZUN40xXKm4ovMX8TdeAX9Wa9 9+Zb80HMfUIxf9mZUtLlRKUs7NsNtPc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777489562; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XFuWhPG5UR/GLn09TTRumzpk9PUd1gSL+5XeS232Sak=; b=O3h8RVBoB3iJKL/tuwBnFXG/wWK5mt+f4YYqh+tl7yk0Lfodp+GCVMlaGL3RHV7ZTEpqOi txIHI5HuyeW0PYAw== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777489562; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XFuWhPG5UR/GLn09TTRumzpk9PUd1gSL+5XeS232Sak=; b=M+GCoO8SS8lhNzIleffL96cJL6qYywrPHdUGSZsrH1jWg8vGYsHS5SjwutRJDQ6R8PkIVR hAoP5Myy/JMCsRqom2tSGVyKOcIJ1/2xmyV/LuACS+oR3wZUN40xXKm4ovMX8TdeAX9Wa9 9+Zb80HMfUIxf9mZUtLlRKUs7NsNtPc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777489562; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XFuWhPG5UR/GLn09TTRumzpk9PUd1gSL+5XeS232Sak=; b=O3h8RVBoB3iJKL/tuwBnFXG/wWK5mt+f4YYqh+tl7yk0Lfodp+GCVMlaGL3RHV7ZTEpqOi txIHI5HuyeW0PYAw== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Peter Xu , marcandre.lureau@redhat.com, Laurent Vivier , Paolo Bonzini Subject: [PATCH v1 5/5] tests/qtest/dbus-vmstate: Re-enable the test Date: Wed, 29 Apr 2026 16:05:50 -0300 Message-ID: <20260429190550.20122-6-farosas@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260429190550.20122-1-farosas@suse.de> References: <20260429190550.20122-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.80 X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:helo]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_TLS_ALL(0.00)[] Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:2; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1777489728999154100 Content-Type: text/plain; charset="utf-8" Back in 2020, the dbus-vmstate test was disabled by commit d46f81cb74 ("tests: Disable dbus-vmstate-test") due to Patchew failures. We don't use Patchew anymore for CI, so re-enable the test. G_TEST_DBUS_DAEMON=3D../tests/dbus-vmstate-daemon.sh \ QTEST_QEMU_BINARY=3D./qemu-system-x86_64 \ ./tests/qtest/dbus-vmstate-test Signed-off-by: Fabiano Rosas Reviewed-by: Marc-Andr=C3=A9 Lureau --- tests/qtest/meson.build | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build index 0d04e2cbaa..b3f62e8cd5 100644 --- a/tests/qtest/meson.build +++ b/tests/qtest/meson.build @@ -123,8 +123,7 @@ endif =20 dbus_daemon =3D find_program('dbus-daemon', required: false) if dbus_daemon.found() and gdbus_codegen.found() - # Temporarily disabled due to Patchew failures: - #qtests_i386 +=3D ['dbus-vmstate-test'] + qtests_i386 +=3D ['dbus-vmstate-test'] dbus_vmstate1 =3D custom_target('dbus-vmstate description', build_by_default: true, output: [ 'dbus-vmstate1.h', 'dbus-vmstate= 1.c'], --=20 2.51.0