From nobody Tue Jul 28 01:48:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1777294532; cv=none; d=zohomail.com; s=zohoarc; b=OSJaWv6bp877Vz56HjSThPT+CxjXVejFBpVzPAFwlXoNyEqG5cw5TXe6/8H4GAhZDNyBwlnmNwrXDjMFi+9vAC+mSRddrzz8H2D83W5+LDy9KYl0U+H3HSG8DZbLi677CyJ/EFJslEMHQ61i/yIjk+nSyb4HLgFvSPX4hUvjJt8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777294532; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=EoqVhLGhx4yCMUlMBNquuLKcWQ2+z8TbZ+uuLLh8Iag=; b=Fk87lv/SVq6cH+t3EgK3BcYJfU2u/h4/XWmcoBij40njgXh0djp9LUt7ad3URgJvjWKawc95qvdXkhAra6x67XU5TM+u+9yZ3Op8D+Wc2cKHF+nReOsZg5JOmMdrezGcytUo9wnMIL4Fw4wwoHmjDaBe+fNxxdGeDqakI8GV8t4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777294532169846.0802575379635; Mon, 27 Apr 2026 05:55:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHLQz-0002sh-OP; Mon, 27 Apr 2026 08:51:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHLNy-00087g-WC for qemu-devel@nongnu.org; Mon, 27 Apr 2026 08:48:31 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wHLNr-0005hI-Up for qemu-devel@nongnu.org; Mon, 27 Apr 2026 08:48:25 -0400 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-488af96f6b2so134257745e9.0 for ; Mon, 27 Apr 2026 05:48:15 -0700 (PDT) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488ffc5e3f4sm448974115e9.2.2026.04.27.05.48.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 05:48:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777294094; x=1777898894; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=EoqVhLGhx4yCMUlMBNquuLKcWQ2+z8TbZ+uuLLh8Iag=; b=XhAaqXETDXRjknmsL3MLmjQIjjxvkxuRQBNdylLUXbZ02VhMsLl39zDbmn3OQNNf1N Q0wHSO0zYrmq7+eskWLNekeEmYtF8n0LLa3vQIJEM2DNcVeRjSmT3h6y+sTLQrAO2vTz zh7DB277WTjV5lKdOGatJ7hc729P1Kps7GCWKloeeFw5rZDtOu2NGy6CCE17ESBwSBFQ hB+4csreLLgLe3mNiXx3vIDqiUaAeTH8bxz92LNq28SvJOr0UAVBNFxmjvGnGOZj1hov YTbN6Ok2FpQwMNByms7EK7Im7OHhiWmA8m5UttrMv1W0sjRvMBzZrJ0+khRjfefs3zPh h+rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777294094; x=1777898894; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=EoqVhLGhx4yCMUlMBNquuLKcWQ2+z8TbZ+uuLLh8Iag=; b=Xyu70JGigjEK2W+QCMR3kSpXA8hjpvthoEhz7z6JRjXlA4HTiNUk9T/Ze1E3cb4+Mn t/Xw7rdO2eEv6/g4mNzwwesfK59saVIZ5l6MUAqQokMjGxKsXY8YT0xYVRRw/e2Ggm0/ 9vxE8x2cIbURnQd8bbzdbrx4IZiG4xdvc4l/mnN8e+rKHqiWXkp9W50i7gF0GnB89Gl9 JaVX/rC8pjhwoujXiZpD6i0ucyZqry+6cNhyy94/FG5+j8E6RHuyJPghS0vjCWr886cq p9h7o5zxOtQiru7mOpxG9S9V+NQ7TfZXejA6vU2vlY3B4PpmsyRVS6CUaxqNyp1Dj0eM p1+Q== X-Gm-Message-State: AOJu0Yw2aC6omu0LY6IzNlt1UVFwMSzZ20E0cqOOvJJYO2u29LkPE8qE 8uD1DyA8tXOmngyJ0WwwI+wcxcs5EEb4Hj/YHXTXI5+0DkMgVF645NR0idV9J2lKPO5ArMyIEVe hvXTS X-Gm-Gg: AeBDiesWswc7kTXI8DnrYgTsZgyIoLQG/M2DZhwB4TBc/obQk22BekFcficAiPOevT+ 2Zl5/QEr9yhhy1xqFjYXSbuos48GtuH2zhGejubFWF3N9eQ4OYSqJ4R6+AkiS8eZOLi+npToVq/ WINEzrjzY2/UQC4BYhBLjdeF3et6UHys3TwpHMYKBn5TrtDwoUu8q/voxZN6Ld7g9CIPJAmZR9H 5Q60aOOlvMU8+3orJA6P9dhbbnJaTDkmtMgyd/OJO8B0IAM3qdKDDckoylS5IHwLeoFQsbUF4ei T2eCS9aOcAZIqZUlOx1tJUVhaz3b3toFkeIhr69++bT/WQc2QeGtGXYv8WLeiPotFhu4pCEVbx8 BV8FGdseWk171ZeTtTykTswxiuftoqTxgnMSDpmx7mIW4pbqAund49IlrPAbKXRVwcOiCNTCnOg PaALWwr5Wz09gC6aB02K8pUvKGhJzZ/bGs9sU6xK8aaZRq5Sg/8f+ha0rXXjyxnDevn25ECJ+ur 0kA6gFqTqaYHVZmJmgDwMy3CCpPgIzZdlEETDpKMw== X-Received: by 2002:a05:600c:190f:b0:48a:6315:da26 with SMTP id 5b1f17b1804b1-48a6315da72mr207675615e9.26.1777294094151; Mon, 27 Apr 2026 05:48:14 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 37/63] Revert "target/arm: Reinstate bogus AArch32 DBGDTRTX register for migration compat" Date: Mon, 27 Apr 2026 13:47:11 +0100 Message-ID: <20260427124738.966578-38-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260427124738.966578-1-peter.maydell@linaro.org> References: <20260427124738.966578-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1777294532860158500 Content-Type: text/plain; charset="utf-8" From: Eric Auger This reverts commit 4f2b82f60431 ("target/arm: Reinstate bogus AArch32 DBGDTRTX register for migration compat). We don't need that commit anymore as the AArch32 DBGDTRTX register is declared to be safe to ignore in the incoming migration stream. Signed-off-by: Eric Auger Reviewed-by: Sebastian Ott Reviewed-by: Peter Maydell Message-id: 20260420140552.104369-8-eric.auger@redhat.com Signed-off-by: Peter Maydell --- target/arm/debug_helper.c | 29 ----------------------------- 1 file changed, 29 deletions(-) diff --git a/target/arm/debug_helper.c b/target/arm/debug_helper.c index 352c8e5c8e..8477ca5def 100644 --- a/target/arm/debug_helper.c +++ b/target/arm/debug_helper.c @@ -171,13 +171,6 @@ static void dbgclaimclr_write(CPUARMState *env, const = ARMCPRegInfo *ri, env->cp15.dbgclaim &=3D ~(value & 0xFF); } =20 -static CPAccessResult access_bogus(CPUARMState *env, const ARMCPRegInfo *r= i, - bool isread) -{ - /* Always UNDEF, as if this cpreg didn't exist */ - return CP_ACCESS_UNDEFINED; -} - static const ARMCPRegInfo debug_cp_reginfo[] =3D { /* * DBGDRAR, DBGDSAR: always RAZ since we don't implement memory mapped @@ -240,28 +233,6 @@ static const ARMCPRegInfo debug_cp_reginfo[] =3D { .opc0 =3D 2, .opc1 =3D 3, .crn =3D 0, .crm =3D 4, .opc2 =3D 0, .access =3D PL0_RW, .accessfn =3D access_tdcc, .type =3D ARM_CP_CONST, .resetvalue =3D 0 }, - /* - * This is not a real AArch32 register. We used to incorrectly expose - * this due to a QEMU bug; to avoid breaking migration compatibility we - * need to continue to provide it so that we don't fail the inbound - * migration when it tells us about a sysreg that we don't have. - * We set an always-fails .accessfn, which means that the guest doesn't - * actually see this register (it will always UNDEF, identically to if - * there were no cpreg definition for it other than that we won't print - * a LOG_UNIMP message about it), and we set the ARM_CP_NO_GDB flag so= the - * gdbstub won't see it either. - * (We can't just set .access =3D 0, because add_cpreg_to_hashtable() - * helpfully ignores cpregs which aren't accessible to the highest - * implemented EL.) - * - * TODO: implement a system for being able to describe "this register - * can be ignored if it appears in the inbound stream"; then we can - * remove this temporary hack. - */ - { .name =3D "BOGUS_DBGDTR_EL0", .state =3D ARM_CP_STATE_AA32, - .cp =3D 14, .opc1 =3D 3, .crn =3D 0, .crm =3D 5, .opc2 =3D 0, - .access =3D PL0_RW, .accessfn =3D access_bogus, - .type =3D ARM_CP_CONST | ARM_CP_NO_GDB, .resetvalue =3D 0 }, /* * OSECCR_EL1 provides a mechanism for an operating system * to access the contents of EDECCR. EDECCR is not implemented though, --=20 2.43.0