From nobody Sun Jul 26 00:33:36 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777283990; cv=none; d=zohomail.com; s=zohoarc; b=SNz6NCIuPJzNOXvGpwsmcCziaF1/Gud/QYCvKGoR03O7CPzvj/WAGlcblbjs79XRKxLztwud2Gb6+8fSyy7L8TjPstJKjCwfrTMkBvx6lHJm9d91/5ZGIcF4ixfTN0+wAdjS8wk2dzbodGuUR1Y6tKqfdkqE4tyCRhD6KFOGJGE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777283990; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=eFljm/P3eCUbucxFKDa5ngURwEtaHUriqo3+3248PFA=; b=hwOm5Z5Al6OTwFZl/qPci9J+4BPjZte6GlcTuV639BWU92sDzlJBlnche/Qf2RmdkZzoTk7zd/GfmpWegwvpTZ58f1HOEjbEe6KjsM1UHf2dQU7Ee3febZnccK2QwgrkTleCY9gjnMEzeSa1dFgn7VF6ZzU7pBETX4my0dV5GRc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17772839902126.221310022961234; Mon, 27 Apr 2026 02:59:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHIjW-00083D-Lb; Mon, 27 Apr 2026 05:58:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHIjT-0007tN-0d for qemu-devel@nongnu.org; Mon, 27 Apr 2026 05:58:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHIjR-00088v-7t for qemu-devel@nongnu.org; Mon, 27 Apr 2026 05:58:26 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-379-qbTtMEC1NXiyxGYl5HWiqA-1; Mon, 27 Apr 2026 05:58:20 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B141819560BB; Mon, 27 Apr 2026 09:58:19 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.48.146]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DC6CC3000707; Mon, 27 Apr 2026 09:58:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777283904; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eFljm/P3eCUbucxFKDa5ngURwEtaHUriqo3+3248PFA=; b=HQgYZyNHGbU+ZdiHwIqPe4ZYGSTvq5yCor/MguKEl2g9wMHA0QYwE3PhMDC9bvSj3xTEn+ xxHE4ZjzzZq4Wse68TYdRqO+hr+Uezjtv5jop+Krn+lsME/lZqqnIbCexRjd2h/iiiqkvR T7jTH5GbBvWbae7qiCqyxF6450ay/Ek= X-MC-Unique: qbTtMEC1NXiyxGYl5HWiqA-1 X-Mimecast-MFC-AGG-ID: qbTtMEC1NXiyxGYl5HWiqA_1777283899 From: Thomas Huth To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Sourish Duttta Sharma Subject: [PULL 08/10] hw/i386/fw_cfg: Use g_new() and g_new0() instead of g_malloc() Date: Mon, 27 Apr 2026 11:57:45 +0200 Message-ID: <20260427095747.1070244-9-thuth@redhat.com> In-Reply-To: <20260427095747.1070244-1-thuth@redhat.com> References: <20260427095747.1070244-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777283992322158500 Content-Type: text/plain; charset="utf-8" From: Sourish Dutta Sharma Replace g_malloc() and g_malloc0() calls that calculate the allocation size using sizeof() with the type-safe g_new() and g_new0() macros. This aligns the code with QEMU's coding style guidelines, improving readability and protecting against potential integer overflow vulnerabilities when allocating arrays. Signed-off-by: Sourish Duttta Sharma Message-ID: <20260224160020.137036-1-sourishduttasharma770@gmail.com> Signed-off-by: Thomas Huth --- hw/i386/fw_cfg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/fw_cfg.c b/hw/i386/fw_cfg.c index 858e6ca9c53..2876490f069 100644 --- a/hw/i386/fw_cfg.c +++ b/hw/i386/fw_cfg.c @@ -91,7 +91,7 @@ void fw_cfg_build_smbios(PCMachineState *pcms, FWCfgState= *fw_cfg, =20 /* build the array of physical mem area from e820 table */ nr_e820 =3D e820_get_table(NULL); - mem_array =3D g_malloc0(sizeof(*mem_array) * nr_e820); + mem_array =3D g_new0(struct smbios_phys_mem_area, nr_e820); for (i =3D 0, array_count =3D 0; i < nr_e820; i++) { uint64_t addr, len; =20 @@ -207,7 +207,7 @@ void fw_cfg_build_feature_control(MachineState *ms, FWC= fgState *fw_cfg) return; } =20 - val =3D g_malloc(sizeof(*val)); + val =3D g_new(uint64_t, 1); *val =3D cpu_to_le64(feature_control_bits | FEATURE_CONTROL_LOCKED); fw_cfg_add_file(fw_cfg, "etc/msr_feature_control", val, sizeof(*val)); } --=20 2.53.0