From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319072; cv=none; d=zohomail.com; s=zohoarc; b=G8TK9Vv+CE4BBokl+mMsh7ywyBZ8x6rakqzh0cF6iA4p+iTz9nxgKIAkUZvTMtBg/t0QJkxql95gGlZNTjD9/U70Rv3e5WtqoAZLgY25fiNQWxTJuBm9VaKGIkvCCXgf3aA3tHAh104atmc//v3ZY5K/AT6DMQvLdidltyRWvuE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319072; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=LNwbxYxWQ04sNy4bBLSed8SroTUWt0gC5fF5Xjj2gTA=; b=goz+p430UngrDCX63Hg0edbAf3t/q1NRUUEHqA0IPt67MiWcDS6L0HV9geTy8vLllp1/crhkoQIfgnxQa1ofiRc/lCjRTWf8EIP/PfzH6SBBUfbMr3aKP29f/NddhRtJMV0HUpIzdgdVld1VNj4grrt70tq7EwWYT1e3yxLE3Jk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319072039330.78963367087965; Mon, 27 Apr 2026 12:44:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRqy-0000r2-2Q; Mon, 27 Apr 2026 15:42:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRql-0000pC-UF for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:42:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRqk-0007ez-0u for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:42:35 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-680-aXZnIwACP_CyMswST68e4g-1; Mon, 27 Apr 2026 15:42:30 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 00A461956089 for ; Mon, 27 Apr 2026 19:42:30 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9F3A11800664; Mon, 27 Apr 2026 19:42:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777318952; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LNwbxYxWQ04sNy4bBLSed8SroTUWt0gC5fF5Xjj2gTA=; b=i+IZEjTPWOImh31CwMqoJOFdeBzksG2aEXXRxevtfFHHXuhq3eoEn6f+S1s1mFoFv7TcC+ rMlb1J5vAnqjfYn2Lc76MUceFVPY4Dod1x2NBjJD1a9QxVgmYQY/RjJsrXzM1Sz13KtHac S25uFb0P9qjWa8OULYKkJMK2pvqniAI= X-MC-Unique: aXZnIwACP_CyMswST68e4g-1 X-Mimecast-MFC-AGG-ID: aXZnIwACP_CyMswST68e4g_1777318950 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:00 +0400 Subject: [PATCH 01/41] hw/pci: handle missing bus in prop_pci_busnr_get MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-1-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , "Michael S. Tsirkin" X-Developer-Signature: v=1; a=openpgp-sha256; l=1270; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=P8mQvnMK/kAJD5u8Y7BnOIAYXw5cBODLSGhSeHfU+Ug=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wUCSpgafM7qyg1PvbrmiREBZP6oFhStmU2U tMJvXGTP9CJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FAAKCRDa6OEJdZac 5XTqD/9CvkfW7mTllAvHZ2AT6f9GPWMs9EBtQEzZjBMTPmdJy2wbEVOOKeEwIWpSxGQPqt9ZqUV T0cTkQ3auWdpDBlycfhmpqugb6q+u1QZVlXA88J3nSGrXKRDXODy+t0L3j6mZchbhT2h9ZlN52D vgsi2Ch4ueqM8xrT39ec1PFzwRd4C9OPbWhwreS/PrX+SUirssX8MMEolodvH6yoX5Ytdh+gRtv aeYy7IKN8gIDRBAoPuIFd6MwwWk4KT0A76lDl0pd4dMCAYVoqgJKJ7zzxL92Ny3cMztFU1oQpLN +0aodTrLuSIcA53sWxsFEJb3bqAFoAEEeT31GbomLDDDa/p7mVsb3Se/LuV9mAD2omY3ZbzwUSl lHYCHdVySrqv3PUITuwyrpxmuion5UGJ/bouN+oxn0Tots8BgzcTdBaqObd57hTFTf+ljg4QLEI 4OGGGFHjjpZ8LP5sYZA22vNLP94Cl+wXW7JA7ch/1iWCwZLJhMC6ftDLP1jhlAAbCDh2BEOwSJ1 I9RFHew3jMWG7kYscKJH5LEy3gqKrcof70DH119fvOV26ik5cjvjILiakQWIUy1HZEj58MfX9cZ sXmqarT4Yn21o8bAgSFq/lx04J9Dq9Xi3+/MeVpHWCuisQONlnbN31J6u2A0HfE5cfjt1q9fC2a CNS+/Mbrn6PxdCQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319074946154100 When called on an unrealized device (e.g. from qmp_qom_list_properties), pci_get_bus() returns NULL since the device has no parent bus. Check for this to avoid a NULL dereference in pci_bus_num(). Fixes: df9ac7254fd9 ("hw/pci: Add a busnr property to pci_props and use for= acpi/gi") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/pci/pci.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index a0dbb81fd90..bf13cabd174 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -64,10 +64,17 @@ static void pcibus_reset_hold(Object *obj, ResetType ty= pe); static bool pcie_has_upstream_port(PCIDevice *dev); =20 static void prop_pci_busnr_get(Object *obj, Visitor *v, const char *name, - void *opaque, Error **errp) + void *opaque, Error **errp) { - uint8_t busnr =3D pci_dev_bus_num(PCI_DEVICE(obj)); + PCIDevice *dev =3D PCI_DEVICE(obj); + PCIBus *bus =3D pci_get_bus(dev); + uint8_t busnr; =20 + if (!bus) { + error_setg(errp, "device not attached to a PCI bus"); + return; + } + busnr =3D pci_bus_num(bus); visit_type_uint8(v, name, &busnr, errp); } =20 --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319076; cv=none; d=zohomail.com; s=zohoarc; b=arL7TnITU7PoTyK3+1r3E1RAuWz8EhJ3g4HoD/p/6y9OnR45D+02cQ3F5gYEzR2+4vWZwLqRGyEtHU+w2k6blutj+dbWrQxJZiSuPTvf7COPxKhiVfm7hSirk4FyLaGpvAbGiz0CZbV2AmotrZM62vjDfyc3gZLQ53uMkb+sKo0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319076; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=MpZfxbMbvI+LoOauwmGQ7lN3E+YKy7RIysjR5B8VSug=; b=HVhp9up1KgIZRIQfnevCLenIKcbmP7ii276jUF3XU98f0NyzyfoBCyJ+gbkAjUoloAuCtZ9CCFjkJFtmW4i+yYWwdO6HNIBKfecAsJOgYpx6OxXKYuILD74i9xc2BRhyPpWJ3M5xBK4wKC1JuWCrqF0ezdVVuRFfndOlEO6ciqk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319076188191.05882936582464; Mon, 27 Apr 2026 12:44:36 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRr6-0000uZ-QJ; Mon, 27 Apr 2026 15:42:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRqt-0000qO-MW for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:42:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRqq-0007hy-KD for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:42:42 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-82-A30x2vMEM1abmnukM2kG7g-1; Mon, 27 Apr 2026 15:42:36 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D67D71800454 for ; Mon, 27 Apr 2026 19:42:35 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8DDB0300070A; Mon, 27 Apr 2026 19:42:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777318960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MpZfxbMbvI+LoOauwmGQ7lN3E+YKy7RIysjR5B8VSug=; b=JV8GUm8pbR2c+KmSHsNGnN/Hui3wVLeuz75s+T+AdcvmV0wA5dnw91ocANRHg0jM9pDDCb 6a382HEfsQX74f6rNG3LKqQojU/Qp27j0QBe/ZLrqGxS8rS0dWx8mYDvif9v8WTammrCPq HU0WxfcDZp5bFZOghmEfuJ8dK2B8RVs= X-MC-Unique: A30x2vMEM1abmnukM2kG7g-1 X-Mimecast-MFC-AGG-ID: A30x2vMEM1abmnukM2kG7g_1777318955 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:01 +0400 Subject: [PATCH 02/41] chardev/char-socket: handle NULL addr in char_socket_get_addr MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-2-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini X-Developer-Signature: v=1; a=openpgp-sha256; l=807; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=OqoZXlzFf70MD8aVuu81IsB2OfurhLf51jzWd985d5c=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wUxNaEGAUSFoncgex/xqbAlH89hcs0waV6p dDsIi5LKZqJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FAAKCRDa6OEJdZac 5V9+D/42oppCsFcGimP/mQ10jT/G5+69yF/oXFUc59ryhiXA+GeMCbb67j/yqNnraHKmLG4dc9k 4tet53MeLMCWDNxh+TOG2/Ta0CClETSTD2Va+8traDjLyKkK8FcfIxfFoEqa2OJ+Urmpv8jP7XA kkbQU23JOIPjd+qzKzxKpUuNxn1s2Vgt2ZHHh/tMUYzpxiOGsMgGmnmpOlki8p/C9y9jUm5PVde o6+gGig4BvHr1vN9CY2e3mqQZE/Ou8EirTqgUE5Mt0HUmFIOxLHpNmqVxNgDOevXQMJ3goDH+vv nOFYYJuvQT8/Je4HtDxnYNQaQ6MKth5FNgs+DuH1Gfju/NjrqS2Uge03nbnTZH39X7UV2U1LaA5 aNRZjMow9VCuvqTt4u7IsqPP//Mo1HewMGIuCWDRsZVnSruDv/n5A3Zt+sk7bAhPEfIb7mdaIfz SoByF5+7CIb01+Q4dnjAZ7cqDZFUNh9ahxieyYlEEjf5DgkAVD+bHCHlSKlauq6HiNhgHoiiB9O 7p19VPiczrGR0g4oJm/ArqM80LVltWR72lwwtioar3Mk+lQ5Ils82vLC509mf9AavJVurobHMpy KU1On7gjT83mMsqOZ8d4dTLcfAgSLUaR7sg08Pqe/HV0ZdiNB/uKBJspIV+gzSchnEmbs/Hy+xq 5iZM8w4cMgjm4iw== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319078986154100 When called on an unrealized chardev (e.g. from qmp_qom_list_properties), s->addr is NULL. Return an error instead of assert(). Fixes: 123676e9894f ("char-socket: add 'addr' property") Signed-off-by: Marc-Andr=C3=A9 Lureau --- chardev/char-socket.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/chardev/char-socket.c b/chardev/char-socket.c index e064b105c50..b629575fcf8 100644 --- a/chardev/char-socket.c +++ b/chardev/char-socket.c @@ -1529,6 +1529,10 @@ char_socket_get_addr(Object *obj, Visitor *v, const = char *name, { SocketChardev *s =3D SOCKET_CHARDEV(obj); =20 + if (!s->addr) { + error_setg(errp, "socket not connected"); + return; + } visit_type_SocketAddress(v, name, &s->addr, errp); } =20 --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319104; cv=none; d=zohomail.com; s=zohoarc; b=ahQUrYLlw9kqjhqDD/bXso0gULXHPhIFHaP/xIJpmehwaYekzK5gNc6dLS4FlhGZhuIQkDy8MIqFOwDszzUjob+eaBRWREKvBOoFdl+Osif6KhOJbG4ZS0HOJ9s1NGtQD/TzSRGvn32kj17oFhKNU0QqxXIYGJN8VV4tizQtIMo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319104; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=sAuYAhy1cX7XBXjOLthJfEq8jJm8Z2hVUkA1DREfIfI=; b=Gb+FWXFn27UVmbmz9e8vmxPdf1KUvRGOgjVUIx0rcreMVE5VzHUF4YdmYBeQlZk86CYZEAEQQFrgCzYhlUaPCa8SHxRUw6BMcLDsgb7y7ILAgFTgrXbT/FoBU/C7YQzv9IB+pMnfUlG9KN2ewKbVTZMx9OrYbfToxS3leNgOvg4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177731910421092.2894931861581; Mon, 27 Apr 2026 12:45:04 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRrA-0000vF-6F; Mon, 27 Apr 2026 15:43:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRqy-0000rk-PX for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:42:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRqv-0007jM-Lz for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:42:46 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-472-1jwxN4HQNgCg54yE6XrU0g-1; Mon, 27 Apr 2026 15:42:43 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9580B195609D for ; Mon, 27 Apr 2026 19:42:42 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D2BE4195608E; Mon, 27 Apr 2026 19:42:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777318965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sAuYAhy1cX7XBXjOLthJfEq8jJm8Z2hVUkA1DREfIfI=; b=evjlNtY9ITisemuonp510myOUJA1IqPlB1+WDoVmHEjQWnUM+5qZjffwftUdeCzG0gSnMr i44727thjwc82nmjCBIMbZEf6jArxXi92Gy15xfaEIZ2dlmPiu4VKyyhR75GdL448UeTYP KkxX9jJpPptZM6p6+FPq4F9iPIQWUCc= X-MC-Unique: 1jwxN4HQNgCg54yE6XrU0g-1 X-Mimecast-MFC-AGG-ID: 1jwxN4HQNgCg54yE6XrU0g_1777318962 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:02 +0400 Subject: [PATCH 03/41] hw/pci-bridge: handle missing parent in prop_pxb_uid_get MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-3-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , "Michael S. Tsirkin" X-Developer-Signature: v=1; a=openpgp-sha256; l=1195; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=7IzFtyW5t8Gf12v8GCg2dNaN6ZsDHP4zF5gwn8PfMpc=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wUxXrEGyOfqXJtmyjiR7kGhiC9PY3OuVy9q xBEprUUWW2JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FAAKCRDa6OEJdZac 5Tq9EACUumLvmV3Yhiw+Fjqg5+mbboRkvntsilf5BiEJAydH/nFWLvm+WWq06JBcVEGbesvP5r3 xxxyjMAPelAS+ywlVUSnslPuMfjEn2Mkc2iyuGJEe5KGbw1z1JTlzAvbUPV5e0wXkCxiVY4F05r kKPp7/qNw4vjxfw2ona30Fnn3PaN0KvYit75DSGoqXM5FqHboQUICtwJ53d+R8UwOL/6LyIfK+M 3Ls8WX7BRRU/6AcUINYABz8LxQ5vxwbX8ErDbQMlPTRZlIySD9F1MWvFfm4C56bD7uVQ+TVZw+i aCK+F79m2/v7Cuj4o44QZOVFK4YJUgOMmJ6esmCJD/WglFFVvMH24+KdGbkMXF5RwevG2wJcEse 9VFclGaCyGuReOfB2McBj2GUpBVY4yja2jl35cK/ofH5Y6BEU840iLZ+fWrzr2LrkHcvlpueTCf LNfGiXC6Fy2N9vCubHrUU/bNDMerlyQ1P1U0Pz7P8XxVM1H86sSkhDAa0qvx8EkHZZw+wyt3wVf imBPp9WE4lLloeAH9A5oHQzHgerEnNjINGk0tWs+yk7PGXJoQt6MMqzMJWMc/Pitptdqpqk3g/t yJqflIUP9lnnd434ynI5+OungsjcDmZbnaUaAIu0XSBjVkJzYo9yWYH0Ea4U0iQYC5jPOuGzfpM V1tipA2S7Sk2PMA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319105295154100 When called on an unrealized pxb bus (e.g. from qmp_qom_list_properties), bus->parent_dev is NULL. The pxb_bus_num() callback dereferences it unconditionally. Check for this to avoid a NULL dereference. Fixes: 97b9cb066e5f ("hw/pci-bridge: Add acpi_uid property to TYPE_PXB_BUS") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/pci-bridge/pci_expander_bridge.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/pci-bridge/pci_expander_bridge.c b/hw/pci-bridge/pci_expand= er_bridge.c index 11623a5666f..40ffbc4e082 100644 --- a/hw/pci-bridge/pci_expander_bridge.c +++ b/hw/pci-bridge/pci_expander_bridge.c @@ -85,8 +85,14 @@ static uint16_t pxb_bus_numa_node(PCIBus *bus) static void prop_pxb_uid_get(Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) { - uint32_t uid =3D pci_bus_num(PCI_BUS(obj)); + PCIBus *bus =3D PCI_BUS(obj); + uint32_t uid; =20 + if (!bus->parent_dev) { + error_setg(errp, "bus not attached to a device"); + return; + } + uid =3D pci_bus_num(bus); visit_type_uint32(v, name, &uid, errp); } =20 --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319000; cv=none; d=zohomail.com; s=zohoarc; b=GlJaqEzqbCNH3nZ1F+v6ARaBykI3mU24IEq/VD+pzjoXX7/ObKS1l3fn2dqmLHYjNz1K7ukegFogpJUzXg3QFQAGFfOqZhuMZHadge76egUfv0f3i06sRQt0LKf2c64H+Ej6nABpR2cYK5eRQQPay1AuuHKj60zh0fwd5g1l7ac= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319000; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=A6/s7+wbN+K4kjVcPjREQTdrbnwvUrhPZpIX3sPM1qs=; b=ao5HXJ+j3fxTavi+bcwarEmefv+abFJWIRue4dbjbjbSQvf39u0GXIixz1mE4cB3iaHhxNqwEz3+BcR7p2Jde4Le7yKO9lGZw4JNPsCe6lgvq01iZnF6nqiwqYaPnFxbuQdRAZ7ywoz1L6ExdnuKQW6zVNdDRSgDf1wxpJ2SO+Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319000655661.2702644358335; Mon, 27 Apr 2026 12:43:20 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRr8-0000up-6m; Mon, 27 Apr 2026 15:42:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRr5-0000uO-RJ for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:42:55 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRr2-0007jz-3J for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:42:54 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-561-QLneicrQOvehu5TPtD6kpw-1; Mon, 27 Apr 2026 15:42:49 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3B1D918004AD for ; Mon, 27 Apr 2026 19:42:48 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D754619560B7; Mon, 27 Apr 2026 19:42:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777318971; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A6/s7+wbN+K4kjVcPjREQTdrbnwvUrhPZpIX3sPM1qs=; b=E5u1o/nBGYoLx+Wz/KQMbmec15V5HXq8AhBa+lPOSqq7Vdna58BDel6km4yh0y/9AAAcvB RG7Z9zzOeDcBHzCcWp3kX8XkcysF3o5+wCDvaqbAbEipmssGWVjJU+ybr+WG9o3JpCggBj 0iUnQ+SUMT2nPH4V/x0IYAoyV7PQBVo= X-MC-Unique: QLneicrQOvehu5TPtD6kpw-1 X-Mimecast-MFC-AGG-ID: QLneicrQOvehu5TPtD6kpw_1777318968 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:03 +0400 Subject: [PATCH 04/41] hw/pci-host/i440fx: handle NULL bus in pci-hole64 getters MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-4-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , "Michael S. Tsirkin" X-Developer-Signature: v=1; a=openpgp-sha256; l=1913; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=RxT0UeQOktv5seL6iNPTJqxIzApIk7GMQLzeeYc8LL0=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wUev64TFRUjOwIkRbb907noV5mDEkWj0PCw vosv/MzszeJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FAAKCRDa6OEJdZac 5bYpD/91JphflRw5SJCK2kJxxj2l0f5q2z9fW1/QsjCE6QiUuwZgT2msMkDFKAkY6kxYp4VxsnW 1NwBcTM87zTo98anvr8Id4eHEnWDRNUXah7CWEWrbshZh9o5LWfNtsDPQRiKgjcUJ5fwTaEGXja HONgHMv3cUrefKCrfyUcewZBE3pr/eC1qpc6QfNUQmvyqVfxJ8AKzKzYu+tK4dH6CUBTIXP2Ac+ BR91a5sQb/JCMVwiPadpyCyg8tTA+snwqgAHTXLKC1kb7wJUgXiFXqMHJ+xBpE4sHoBW//tEmt+ 9zY0/Uh0fuku6ffCJ76m95O/D6Ysw0GNmh7VR6gVc/C9JK9xEm/1Lm38IBzQ5tjvuVoGTvlWCF/ LwRe1gcd7dIo1ptU9lMegZCJwcWyXM1UCtAcf9PyPf/lklHaML9MksUrTZ5qg7As0TwvFb3iL0a 0vvdYz+LnEzy2AJBoURLVztDOtP1IGuYv2A0+cmfwxDQJFdeYbrwtoax3jm5i2st4HkSBBNYRoS 3tiaw7fSNhVmV4BQw/Q5MO3h8tMWPHk+/+uAfig2aX+acT4lVgWUUoR+maJr60Gow1dVZAxdt2o VXlb7SkvGJZG6tgmPXIy+l8sD1JpOdUKBTnSW9bG1JH5uGcS+wl991klxzUkCK/y5SLAcWAODaC MyAYDnuU3dIXkug== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319001753154100 When called on an unrealized i440FX host bridge (e.g. from qmp_qom_list_properties), h->bus is NULL since the root bus is only created during realize. Guard against this in both pci_hole64_start and pci_hole64_end getters, reporting an error. Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/pci-host/i440fx.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/i440fx.c b/hw/pci-host/i440fx.c index e7d638b296c..6952094510d 100644 --- a/hw/pci-host/i440fx.c +++ b/hw/pci-host/i440fx.c @@ -189,8 +189,14 @@ static void i440fx_pcihost_get_pci_hole64_start(Object= *obj, Visitor *v, const char *name, void *opaque, Error **errp) { - uint64_t hole64_start =3D i440fx_pcihost_get_pci_hole64_start_value(ob= j); + PCIHostState *h =3D PCI_HOST_BRIDGE(obj); + uint64_t hole64_start; =20 + if (!h->bus) { + error_setg(errp, "bus not realized"); + return; + } + hole64_start =3D i440fx_pcihost_get_pci_hole64_start_value(obj); visit_type_uint64(v, name, &hole64_start, errp); } =20 @@ -206,10 +212,15 @@ static void i440fx_pcihost_get_pci_hole64_end(Object = *obj, Visitor *v, { PCIHostState *h =3D PCI_HOST_BRIDGE(obj); I440FXState *s =3D I440FX_PCI_HOST_BRIDGE(obj); - uint64_t hole64_start =3D i440fx_pcihost_get_pci_hole64_start_value(ob= j); + uint64_t hole64_start; Range w64; uint64_t value, hole64_end; =20 + if (!h->bus) { + error_setg(errp, "bus not realized"); + return; + } + hole64_start =3D i440fx_pcihost_get_pci_hole64_start_value(obj); pci_bus_get_w64_range(h->bus, &w64); value =3D range_is_empty(&w64) ? 0 : range_upb(&w64) + 1; hole64_end =3D ROUND_UP(hole64_start + s->pci_hole64_size, 1ULL << 30); --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319073; cv=none; d=zohomail.com; s=zohoarc; b=fFjtmlLSnn+e/s4YcBc9govFNEsxkjafQ2qNfwNkdLWJVbodUsZVgUnQa+UItEsJsT77xPBDyyGjMnyizfP14rN5tCHqpMsLQTaAvL+xn5tj0WqQKfg6e/ryWF3REA7pp8yQ4orq2AR+l2mN1zMesr08u+Y8XlLgNuRPJYDXCNQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319073; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=8SNI1+7ODP9d4wGo3twIW0HT5Ncz2Zi9RbkwAn71yk4=; b=Wo0gE7mPlBNwI2MaBfyihx/95W9Pm2V9Zhg9zGJ0wUuYp7IWd2YoWYiiHd9KBxEVw/McCdM4vMl/culB4aHj2kFDnN0PWU2hdr7bZc2aEL9oeVJy/b+NGnvBKEtqyelDnS71Ub+2X653gWTa0HVhnBZ4GIIUb+bj36SodVSkZ64= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319073638657.9137204470265; Mon, 27 Apr 2026 12:44:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRrX-00015j-M2; Mon, 27 Apr 2026 15:43:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRrD-0000vT-08 for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRr9-0007lJ-Mu for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:01 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-600-iRs8dY4ANxiqQ6iN1C1KvQ-1; Mon, 27 Apr 2026 15:42:55 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AB4F6195609F for ; Mon, 27 Apr 2026 19:42:54 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5C44619560B1; Mon, 27 Apr 2026 19:42:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777318978; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8SNI1+7ODP9d4wGo3twIW0HT5Ncz2Zi9RbkwAn71yk4=; b=U3luQWN0dldfJXlciHpgZYlubIEbOu5uFkpdDg2xC7jYkJ2qBmSMfMXCKViIx0uH07KcWr xx9DI30F29LHLM3Uqlc8OdUIEpz6a9bZK8VnYMqGm/gYS6bN4O8G9boaM6f3BA/OANBNsd tejjomjVbsCjt+cusuMTN/3nBMdfVkQ= X-MC-Unique: iRs8dY4ANxiqQ6iN1C1KvQ-1 X-Mimecast-MFC-AGG-ID: iRs8dY4ANxiqQ6iN1C1KvQ_1777318974 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:04 +0400 Subject: [PATCH 05/41] hw/pci-host/q35: handle NULL bus in pci-hole64 getters MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-5-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , "Michael S. Tsirkin" X-Developer-Signature: v=1; a=openpgp-sha256; l=1827; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=8e76537D5foz+/YCdH5/+xzv4nxJP353Lst5euJM2Tk=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wUpdJX9/qeaPQuc7r/VS2SBxeRwFhSvpzXn v9AnGks56GJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FAAKCRDa6OEJdZac 5cfzD/4twr3PbCkYodwlk2w7Z0fmNWOyK7bC9ESXDQVCUhzTka1DAMyqfj1CLK87TxyVE5tV0Eh cWf+5PXzmahDXqvxoV6J5F92nZSt5/uA01CSznlKszwBdJDliiWEBy0J3OjRoijoXFsfnMniOjA ovExHDbNQdMyv8fC13ImVQqlye/YFcGUvMOCz9p3hM9Lpy4FOQaslu3sF3QHn/JaEfGueD1VaEf UdGTmycNRgpupOwRzmUFCnVp4GJ/oK2ffAHdKNuDC8v21kjdkw8EzkgigJqK2kTkBpe7kNbcoWP IwOUKk8dJtjDlnIQBQBcFXOSsJv1PkaSvQWSYBvXrxlKNvbRSysqveRhxwFyc4o3s1j5/gNO4Uk uk3AngOVu7bY78APJIbH/nVKpZSKJN8SBlsVbU56NH+X4spOTb52f20aA0TqJ4MD9Cj2L3aCd/p ZDDdrWMUdn3LRhLOu8t9qD7p9MTXqi3ejlFwMb3TzD0Hu2R/TUY50vDFE+tV33vGKvE+fNBCJto CDxYAP8xOBCAhrPoo3UCKU+4+ERGQytbNkjcy5KaSVeQ++R4kc8IoZHYlWmGo3xlZWMBpZQrbR/ JgHCk7LrCXIfrTt2qrjEaZFCFayPelzVdSKg9ii+5kmerRtSgXsu9yzCgt/lN/WzWqgWcbGXe/t IEWi1pW/TH9jaoA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319075203158500 When called on an unrealized Q35 host bridge (e.g. from qmp_qom_list_properties), h->bus is NULL since the root bus is only created during realize. Guard against this in both the pci_hole64_start and pci_hole64_end getters. Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/pci-host/q35.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c index e85e4227b37..149c32b4b0e 100644 --- a/hw/pci-host/q35.c +++ b/hw/pci-host/q35.c @@ -132,8 +132,14 @@ static void q35_host_get_pci_hole64_start(Object *obj,= Visitor *v, const char *name, void *opaque, Error **errp) { - uint64_t hole64_start =3D q35_host_get_pci_hole64_start_value(obj); + PCIHostState *h =3D PCI_HOST_BRIDGE(obj); + uint64_t hole64_start; =20 + if (!h->bus) { + error_setg(errp, "bus not realized"); + return; + } + hole64_start =3D q35_host_get_pci_hole64_start_value(obj); visit_type_uint64(v, name, &hole64_start, errp); } =20 @@ -149,10 +155,15 @@ static void q35_host_get_pci_hole64_end(Object *obj, = Visitor *v, { PCIHostState *h =3D PCI_HOST_BRIDGE(obj); Q35PCIHost *s =3D Q35_HOST_DEVICE(obj); - uint64_t hole64_start =3D q35_host_get_pci_hole64_start_value(obj); + uint64_t hole64_start; Range w64; uint64_t value, hole64_end; =20 + if (!h->bus) { + error_setg(errp, "bus not realized"); + return; + } + hole64_start =3D q35_host_get_pci_hole64_start_value(obj); pci_bus_get_w64_range(h->bus, &w64); value =3D range_is_empty(&w64) ? 0 : range_upb(&w64) + 1; hole64_end =3D ROUND_UP(hole64_start + s->mch.pci_hole64_size, 1ULL <<= 30); --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319024; cv=none; d=zohomail.com; s=zohoarc; b=Lywn/TnK9Roi36HC9NDGi1dvNR7XmDOYP+rS8r/m5LBlWptRh+ET+VitDQGJKuxa6RUFmUYIJcLe97+CBHsxxv3I5R4Mtl7UiziepmaKGwsLc8Se8uZBCqD39jtFSiHs9YS1idnnIMaXnZOhK1YGcdUQ4agE1CNVxoBBytYbxN0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319024; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1pEn/2hVVxeAUWb0BmkZAfz7mfTs19c+tKrVGD3uLaA=; b=di5FM78EB8s4Tpm2mC5E7StOFILYhEanoz1s4TZ7Ll6nhlGwfl4jZmKMfTHKj2cpQlrDX4oIwOfdObRwPDlnVFx7tIVVw3c1h5s0rSTNi6TZTbdB0AxpJ2DuuLp7q8TBvzF0qn8ecWFEu0IGKyloHurWp1kAxhO/7CedyS+45XA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319024520162.8772120578726; Mon, 27 Apr 2026 12:43:44 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRre-0001Dh-BO; Mon, 27 Apr 2026 15:43:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRrM-0000yi-6U for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRrE-0007lk-So for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:08 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-331-uY5k2CaGNz6QCrNEUz8r8g-1; Mon, 27 Apr 2026 15:43:02 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2410A195608B; Mon, 27 Apr 2026 19:43:01 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8017A19560B1; Mon, 27 Apr 2026 19:42:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777318983; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1pEn/2hVVxeAUWb0BmkZAfz7mfTs19c+tKrVGD3uLaA=; b=HndBesjua9M3q88FNIMiSz7Mf4qOcF6MJjigZaMJaaEXa6vAXQFGkpT4aKrxTi9agaJ01d xhgIuVnL4P7nu39nIILORr5Scih/haLfUCJB7BlMRZwHofNwxj6jppkimCXj94cFUXoAlS RuLehzr8zlwAGTcPGfCB9BPsmrjpsqo= X-MC-Unique: uY5k2CaGNz6QCrNEUz8r8g-1 X-Mimecast-MFC-AGG-ID: uY5k2CaGNz6QCrNEUz8r8g_1777318981 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:05 +0400 Subject: [PATCH 06/41] hw/remote: check visit return in vfu_object_set_socket MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-6-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Elena Ufimtseva , Jagannathan Raman X-Developer-Signature: v=1; a=openpgp-sha256; l=1017; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=OO0tb8zQyK1Y9je3PseFy7KqoAQ349m+oesD3AFJRzk=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wU86khG3YZJuikiYHMH9sfKpSwXyEdq8g2x RpYPJHmxPCJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FAAKCRDa6OEJdZac 5QUdD/0fBGHHHdAkPVR5h0zXL0jd5tdmTxVYBKZh7iydIvp/mgBymlidKHBeDa3RMIO7hagKzRv fjh5G6kZOLl0X7Q9WwliRbTmqorCBTIGUqYWCA+d3sQeVZ4/i0OaI8K7nsX0iuY3iLIO78n1Lc5 8BEgVlVD9vGYYBARzRio9isOKPip48S8BtyJbzn77yaVYggfEgOVhh8bSjNBHwg4DvZy0ugvHAK qqr3tz5mtASoCPRRLRPeVvKlEBu64107gxHudvVLJp6uauqLK7phR48/8QlU4masWcymIzkqEol MP7TqiDA18jE1kCQKs3G/G+G2MPS9qi9Z9c0Xn9V01O8qimncpLcaC82a/xZv3TGB5qQ1ctIdIz ZbhO52ddIevbqpnlMwJUajpjqukuhlRf0fIkUGgBUzUeWDhr1lXW+NMT8PA5BdfO/O5Jqbgpy9a gXdg5YUGcddQHQkvSHBtoieZTAwPZA/8DG4GoHkjvITi6+CFn3zVVpP8rdOiZAoO2V2HICz0Yeh /2t47gEL68Zm/W6tV5AloRnyhi+QHEr6v2bowce8RBAgNj/2AVt8NSE79lIBYdwnn2HyhrtqHcN YpMxgpFSRPAOb7wFKYx0PV4UIkSHr2KeJT8R/MkqPZD57N9+/hwXD921bVeQvqnAFzVcVG8IWZl bLZxinbNIQpMl8Q== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319028106154100 vfu_object_set_socket() dereferences o->socket without checking if visit_type_SocketAddress() succeeded. On failure, o->socket remains NULL, leading to a NULL dereference. Check the return value. Fixes: 8f9a9259d32c ("vfio-user: define vfio-user-server object") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Jagannathan Raman --- hw/remote/vfio-user-obj.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/remote/vfio-user-obj.c b/hw/remote/vfio-user-obj.c index 12ecdab6dea..49bf5ecae0c 100644 --- a/hw/remote/vfio-user-obj.c +++ b/hw/remote/vfio-user-obj.c @@ -161,7 +161,9 @@ static void vfu_object_set_socket(Object *obj, Visitor = *v, const char *name, =20 o->socket =3D NULL; =20 - visit_type_SocketAddress(v, name, &o->socket, errp); + if (!visit_type_SocketAddress(v, name, &o->socket, errp)) { + return; + } =20 if (o->socket->type !=3D SOCKET_ADDRESS_TYPE_UNIX) { error_setg(errp, "vfu: Unsupported socket type - %s", --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319062; cv=none; d=zohomail.com; s=zohoarc; b=EFWolqbkUyA7lwrx2jlr+WgQqdXh4qinPKJq2f+zK/azE6J1h2u+cu6RfSvKm5LUrNRT9XosyCpgAwvdp+Qv8rbHamm6xCERZYzfo9WZmI8SxopHJO/F6OWUT68qLcbiTZ0Lef6EQ7gCaOsYpHEU+uLw/BJrMInk0jxf80t+iZk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319062; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=dkX4SaBJSWzoDN/sOyJvVpRC/vSgOt3wi3wuQ84cUVk=; b=gf6m3v+c8iNqiE/0oKUiLL2WqOsXbv1IejuVPKMjaJuxPpA1C02w1H/lPsPdYtleIYDBVrwmAZTcx1F8LdR89V4yX1gBWJxeJ2DljjtoSdnHm0AQdEWhflhQmGZf9YQ9+CHC9i9ZSoOdtvrNHxERdAZfLBZnNCxdAZIyidK56lY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319062240768.678739694287; Mon, 27 Apr 2026 12:44:22 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRs1-0001VL-Vo; Mon, 27 Apr 2026 15:43:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRrU-00017l-4Q for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:22 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRrL-0007mG-0D for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:13 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-511-owOWmJtIOk6rRrLYNehKWA-1; Mon, 27 Apr 2026 15:43:08 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 423B41956094 for ; Mon, 27 Apr 2026 19:43:07 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E0ED33000C22; Mon, 27 Apr 2026 19:43:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777318989; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dkX4SaBJSWzoDN/sOyJvVpRC/vSgOt3wi3wuQ84cUVk=; b=QepGUPc7ydkDS0Kqkk+XA0k1WNAakvGbDH6VQgAA3C0GznQj7B7BIV5SQkKFR+HiBHd3YA VDvASYvQeE2JpTiyU1Qc5b8IPNhl0kg5pfol558I1nBbJkDqKEAEyVVMUwGN00q9MhHobh puZpwNSzla2OxNO4iyXTdCPxDMMxrSI= X-MC-Unique: owOWmJtIOk6rRrLYNehKWA-1 X-Mimecast-MFC-AGG-ID: owOWmJtIOk6rRrLYNehKWA_1777318987 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:06 +0400 Subject: [PATCH 07/41] qom: skip link property check callback when clearing link MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-7-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1162; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=vC5EqRuLT1EHVRF50SbrOTYnlQJlgmg5h0I92toPkN4=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wUuEHAbsYlatMksb7LilqMPlMdLwvSSQuJl 9b1KUoGSH6JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FAAKCRDa6OEJdZac 5RYuD/sFkxlPXbMwzaV6K6bhiZH2HINk243XPDTtBVV9408K/K28p5QpmJFcCxnJPqyCF8EACkQ Cpn1L1irJP4EqS9YVShUOVlBDA5duSI0a+sGT396B5AM6mIScBXnNY/TpqSORTRR6WuqS4KafzY XcydlKxzP5HocaxiE4Jts5J1ODhVFRrEg+OCbZ7OFHP4r/gitaXslJDatrH9NidHdW2gixaR63p FLvWnG3ZB3k5q/6ajWR93MYE5Ahpj+34GPAu9a1Ex+d6FCTU/7E8PMyok9uPL1jZy88+1CH2pfA CBu8DK3e5yO1j93ykVKYTvCkfuIdVfujJyhnEfouSAVnglCNUCk0V3rAJRvePy2cpsaZjYAnQbZ f/T041/yRT7VoPEFtPXnoz2Cofi8TgTeEV+NXyeeuI2sikiPPUixyvcj7ecz308sCVwLtpyatuE fItz+BikPN3kFoN81TG/cK4tjtWIOPBYluaP7nA+7UI2nLU5e1MFgRnkn1y5mXrpIAAJ7k8CfGX jRiIED/i2Grt5S3dW30zWsC+Pba/RN7tUDiXGsXqmz/KHgf793A+sesrz9pyZwtb/H3/mwCSn5p 9nrDqTD96OWKtabsAU0sOp6TIeNL025tSeBQev04e7dp+noKD8p27tK5PDbi7RBANxSFe9VGodC XtRPbqT5PmDKbug== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319064897154101 When setting a link property to an empty string (clearing the link), new_target is NULL. The check callback is still invoked with this NULL value, but callbacks like isa_ipmi_bmc_check() cast it with type-checking macros (IPMI_BMC(val)) which crash on NULL. There is nothing to validate when the link is being cleared, so skip the check callback entirely when new_target is NULL. Signed-off-by: Marc-Andr=C3=A9 Lureau --- qom/object.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/qom/object.c b/qom/object.c index f981e270440..c50334b3023 100644 --- a/qom/object.c +++ b/qom/object.c @@ -1903,10 +1903,12 @@ static void object_set_link_property(Object *obj, V= isitor *v, =20 g_free(path); =20 - prop->check(obj, name, new_target, &local_err); - if (local_err) { - error_propagate(errp, local_err); - return; + if (new_target) { + prop->check(obj, name, new_target, &local_err); + if (local_err) { + error_propagate(errp, local_err); + return; + } } =20 *targetp =3D new_target; --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319046; cv=none; d=zohomail.com; s=zohoarc; b=VPPSlU77pa8Pt7NQN8hm1j4gRFUGY206iMKx9RUbJ6j0dCjaZdzDDhPtlTXm0OBa0umbz/UYK7LdOzj5upa7TZup1gWvtRhBQ2/uJtvVOTrcUrvxSEMU1JBMHQrGRrw68FBi8h6J2hZTquXiGh4X/vTeWsvCftaX23cU6/ceMqs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319046; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=jsDuVbJMnbV55+CZsRKXWrAKU/qLmpyZfnS+LXbfJaY=; b=M9QDQ+6ybWR4dKWkd00GKa4FJKGnecSjUQYRj7hHUjuZ/5H1NlqzrkiBLA2Jc/3Wkyt6rqYmO3Ow38hygAhXGOy24EkB6eAWD3YmxJdPCG6Rvd7Dlo3kfH0AIKuO0UQZicDWHoC/ruREcx3SFoVZIR2AHZ7rRsiTgj5DYvzePrw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319046112658.7041810870015; Mon, 27 Apr 2026 12:44:06 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRrx-0001TO-O8; Mon, 27 Apr 2026 15:43:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRrX-00019j-D5 for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:26 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRrQ-0007mp-Cn for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:20 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-287-SzoP2UELNFC540owXlEy3A-1; Mon, 27 Apr 2026 15:43:13 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ED6E919560AA for ; Mon, 27 Apr 2026 19:43:12 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A20AA300070A; Mon, 27 Apr 2026 19:43:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777318995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jsDuVbJMnbV55+CZsRKXWrAKU/qLmpyZfnS+LXbfJaY=; b=flVgYHmPT75D0jvzMyVeuIhQuKrRqCl2xOr72SbC//uO57GegAYyNqZnZTKs83Heg68CbN nynZHp8dLkv8xBDsYBwx742JxxtB8ZtfvPd8Wjgya0pceTPoHHC3s4Z1me6hVFXVS92gYI X3e9bP+gehfXkufGPzihWNVQNr1w5NU= X-MC-Unique: SzoP2UELNFC540owXlEy3A-1 X-Mimecast-MFC-AGG-ID: SzoP2UELNFC540owXlEy3A_1777318993 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:07 +0400 Subject: [PATCH 08/41] hw/intc/apic: guard against NULL cpu in set_id MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-8-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , "Michael S. Tsirkin" , Paolo Bonzini X-Developer-Signature: v=1; a=openpgp-sha256; l=1117; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=H/f0y1ZnM9kksExg6Lf8cmvRVM4vb76ZFVmLHYG2Wgc=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wUYlNFKpccl4gxJ2U0GJ/9luzgYzhAvxbdX Nk0MqWZG5eJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FAAKCRDa6OEJdZac 5ZkoEACUuA5REwi62+En3zKbTk8/3i/t12qRrpbkH8piICTfxS32qkvA1P/U4agWSacmWTcuaxy 4Gtq87Zb48YRIxxRiCBBW9dQY8pKKmgIoBSc2vYteW9lRpkS7CQBlyazvpG75LSFznmXh7HGDMG Zrlmq4RreXplBPcAe9FKT4Fn8yCJMw9w0VJ1maXwStnFNyYf9XB4aOVpZx9rvw/iirpprXgtA65 GFsWbLxOYeg3piPyoVSLID4L01fGlovT5gWuoYDtSDau16YvK4QeseXaaeJJTWipqenwsHi3ieD SdcK30Np+NeUBgso7abywsme8ocaRQRBh4gqUpkr0VMH8b1y0wO8WtyVUobgfaDMb8iulQtx3eS sUwBW0uU11SgRV8HniCKHQqeFITYjLgnS/zP3pCRzpj9Iu2XSm1vLIrmzt2J8emi91xsvNh6d/J Js/LvAYcuXrCY+eutgdgl7ZDfwhYfmrHV+GASpaHcTs+dMjYSVLMVxTihtTHsc9q0q3G8DyPSwR Xdtb4IsBLLQaXEEjnP/v1gIw13pXGtd+fj2BDjnatqhkSDg1NgRFhPgvE2Y1gg2G9pc5581y0cp CrQ2flZaN+wUTXCXX5bst87KNRIYzLUjuVLjFDliFfkZLaxWgExGKZcmkJUzOiVQKo83OTcyUIV wh26Y4vgqphxk0g== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319047252158501 apic_common_set_id() dereferences s->cpu to check for x2APIC support when the APIC ID is >=3D 255. On a standalone APIC object that has not been attached to a CPU, s->cpu is NULL, causing a segfault. Add a NULL check before dereferencing. When there is no CPU, the x2APIC feature cannot be verified, so reject the large APIC ID. Fixes: b5ee0468e9d2 ("apic: add support for x2APIC mode") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/intc/apic_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c index bf4abc21d7b..874a05e529c 100644 --- a/hw/intc/apic_common.c +++ b/hw/intc/apic_common.c @@ -421,7 +421,7 @@ static void apic_common_set_id(Object *obj, Visitor *v,= const char *name, return; } =20 - if (value >=3D 255 && !cpu_has_x2apic_feature(&s->cpu->env)) { + if (value >=3D 255 && (!s->cpu || !cpu_has_x2apic_feature(&s->cpu->env= ))) { error_setg(&local_err, "APIC ID %d requires x2APIC feature in CPU", value); --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319069; cv=none; d=zohomail.com; s=zohoarc; b=SYWqppV4u56YYBUCDDiTOC3hMUhslnzLX5FaneSsklsAyw5SbF/QwGXOYHINAvb6ct0/yhxjZaiJQjbuTtkFpMRnScLLPWk1FWTWpnX+rg5gxhjZ9EgZ8k63LN4m5oTKeAr0e4G9FCaBkvz0Wfl9Ff/mxarYpEslJXhk6pSpSrg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319069; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=4FfbGAaXb/Oy6tWZC1/CKBN/B78na+K25Zj2q9/5zhY=; b=VNKgpiuxdtr1V/hAN4JpveNtarepdiOq+wvP8C4tU7QcbQVM1yMA30nzMPsD7b7uKf5wpXrfD/NGiq+euu7QVwzkrnh7i42/VVNx7bGRQzBW1f4QuJyeqFEpweqzfK/gdYrj0B0gqGsL2LgYVfvx/PdrzKAQhEoeIsdox0K14oY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319069021777.080005420066; Mon, 27 Apr 2026 12:44:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRs7-0001kZ-W6; Mon, 27 Apr 2026 15:44:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRrf-0001Fs-UP for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRrb-0007nw-P5 for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:29 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-577-yCwMi048NfGGtorr2jsrJg-1; Mon, 27 Apr 2026 15:43:20 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 28DC519560AD; Mon, 27 Apr 2026 19:43:19 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9D3C81800349; Mon, 27 Apr 2026 19:43:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319005; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4FfbGAaXb/Oy6tWZC1/CKBN/B78na+K25Zj2q9/5zhY=; b=QVqupSye8CI4Y0DpoO4NuitxFdO/jsXZDn7HMFgDYjN7tfDl3jgx8FuRy1UQYkFUG4SMzW q9P4M9WJwj3TxCmdIKuQo1EqujNgTWCbCbCdvodWAsCpyqn356/oVMukl9TmbXvyVLkDGi 1Xma8FkN7S/4Jrva3RL6KluKeZBTKqc= X-MC-Unique: yCwMi048NfGGtorr2jsrJg-1 X-Mimecast-MFC-AGG-ID: yCwMi048NfGGtorr2jsrJg_1777318999 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:08 +0400 Subject: [PATCH 09/41] RFC hw/remote: guard listener unregister in finalize MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-9-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , jag.raman@oracle.com, Elena Ufimtseva , Jagannathan Raman X-Developer-Signature: v=1; a=openpgp-sha256; l=1108; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=HH5UXO7Edv6cxrRxb3xlPtP6qMYIGzXppxNCDLNUXEA=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wUiV+S5EUisFrZViZ+m3Nvqw0to9nqOnaOc tRJUi6J4laJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FAAKCRDa6OEJdZac 5UUkD/9zXw3TYjSmRzTZpwlOtteDS9BC4gvxSY5EseEfOP+gPCIVtJti4fK1AwLPFy/C9SSE1ya HA39QXEnaRB3NeV77F5J9uS6H556gpMUUo4xz3pOWCZqeP80a1GuvXMlusBfWDy/sW1uwhQ+22y 8Sw7mbkQqAvMFK4zvZ34v5ROjhYnObYWwGZIBebGQJPVqGyNpdWcCyOrTnxWPbFMNKrQv0/p8Nd XnoCp3JUo8Yamsq1ismFUqkbIJ3/WC9iiylo1JIjOogcw+qq7O13AWcXG8G8SgCcVijQzcT++oU P2rWXFarjSvWozuaKlSL/1aR8Cj5OS/ZJUVlOQS08nihrVDKrumC1QgMQ0JcOs7snCFlSeGBaRe byWTwZE8VjG+ctxAdF4wKlIdqExGGVbwrQuOkdc89HdgOsJZiwBGR/xS+qsIezrTjOVRAuSo5SJ t7Ft0sxrigmGnQvzG11NV0VTxa9SlQ0gndXVHozDKJtgPE3HfgvH2YemHCzBM98QC7Py+PXb3zA Q42EFweeI2NPMCLPScnD3NxUwHu3bZB7uHtck0VZ7nMWsSUGCWcP8eP7vNpq6PEG9c0Oyx3oXBO AcsIiXnjz9VYB0GV+EegxIA98AGKWzme4f5jtamgBSQD57AQ5FdYl0Eo/I7Ekr+3RdzUoofhwOs EqxLL68PBMJwHBA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319070839154100 Guard the unregister by checking whether the listener callback was set, which only happens right before registration. This is probably better addressed by "[PATCH] qdev: test if DeviceListener is in use". Just adding this patch for completeness. Cc: jag.raman@oracle.com Fixes: c7d80c7c1d9 ("multi-process: Associate fd of a PCIDevice with its ob= ject") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/remote/remote-obj.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/remote/remote-obj.c b/hw/remote/remote-obj.c index 86192dc8dad..4e74ae76158 100644 --- a/hw/remote/remote-obj.c +++ b/hw/remote/remote-obj.c @@ -154,7 +154,9 @@ static void remote_object_finalize(Object *obj) RemoteObjectClass *k =3D REMOTE_OBJECT_GET_CLASS(obj); RemoteObject *o =3D REMOTE_OBJECT(obj); =20 - device_listener_unregister(&o->listener); + if (o->listener.unrealize) { + device_listener_unregister(&o->listener); + } =20 if (o->ioc) { qio_channel_shutdown(o->ioc, QIO_CHANNEL_SHUTDOWN_BOTH, NULL); --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319124; cv=none; d=zohomail.com; s=zohoarc; b=hQeXoqDuI5QWEmMiZCfGBLHPRrDMyJgeV+3ttV+jDrj3gZuyvX1zYUNf2a54pGmQxdM4PuXHIEsY2F5HFgTJ3cS/5JL9N6wUQup11lDH0Ibsk5m0EGsfcg9An5CyFH4pGR5aFqFWR0XrN+1uFTbQvGtohwrV1SuUBekJ+s9lfi0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319124; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=I+eC6NQYMsyddRo7PFwbRV3xFGGbIUsTRsbhZr7HhNM=; b=A98Hrx7aM05/kzfhAKuYEpHTHWMrQ1uuI5A6+llIkWl4Phav/+ynre0Y1nMlGAoQAdszyKY+fDFka5BJfWmFoD6jYN/XvwbpRzdap8mWc3iVBBihzP/kZQ0dE30raMFCce7omT5wWfnT+MepHbE2tV1SS9wIAWPQ2yh3Ods7Y6c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177731912462844.308616621921715; Mon, 27 Apr 2026 12:45:24 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRsL-0001ze-PM; Mon, 27 Apr 2026 15:44:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRri-0001I4-NC for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRrf-0007oh-N2 for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:34 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-582-EytumEKpOAGGqVZzecd0Gw-1; Mon, 27 Apr 2026 15:43:27 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DBB021800282; Mon, 27 Apr 2026 19:43:24 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7B313300757C; Mon, 27 Apr 2026 19:43:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319010; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I+eC6NQYMsyddRo7PFwbRV3xFGGbIUsTRsbhZr7HhNM=; b=hiu9rLcBro0M6Kj2SI7r2F2q90MAX0s1YUxJoSkWbXIhcVAW/HpKG6TYLRpaw/QehdbFMp YbaFVlOBOULNbZiiLCfBVtq5FNcmXrt0C0mVcgszQDRy1W2jrw3SnPOlcUQtrkFj+MMEXD STAhI8nH/3ZPe+MF37/Mzq/5IyvV3Mg= X-MC-Unique: EytumEKpOAGGqVZzecd0Gw-1 X-Mimecast-MFC-AGG-ID: EytumEKpOAGGqVZzecd0Gw_1777319005 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:09 +0400 Subject: [PATCH 10/41] backends/cryptodev-lkcf: skip cleanup when not initialized MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-10-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , "Gonglei (Arei)" , zhenwei pi X-Developer-Signature: v=1; a=openpgp-sha256; l=1164; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=HrppNKbbNxohb7YDYQ92lXKgUl9QPVoSeBjpfd/wmpc=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wUVsUu48ebgWl2IieQbcdJdJN9Z8NKmaH2I dUqTTBFDc2JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FAAKCRDa6OEJdZac 5YvAD/9AYxD8efG/BQzajgGHPRt51FSZdQNbMk818g8Aivr1flz3uaINzf91x8JZrX7+9of5otf zjKs/PJzbFkm5jqGfS0DkhsI5KE2uXYNKsBzJH6TofR8JixB9d8hT75VO07hdBe4PIDaYRDTKNL hYyWZPn3tbVqY73fRP+pdT2rJQC/Y6Ph+JTX+M/x6DBKD6sHZrJ6FELop79KCv2BTilLfLCW6Dl xB2c2l/EyUqizeaffMds1doj57Qkxp+dyFV8WnCvIyTpz/IiZKRluR+0NqCH/ahqKRsQtHv4WNO NcaZH+s3EKFtyP54JQ11H8n5nWdc/utu6vwRDW6lIGYUQTpIKKQcmB07auUEsScUb/UJg3ZeGhx xnnnL0of9S5vmr2UxwaSkUDfqxmQUeAVa7XE8qoQRi8J4tk4d4bHx3EQpZcYzrg67F3E4nn+McL 1Q6kYWA0+L7b82/q8SjwVAHKf+nDucm3fzWNv6QwOxSBxAXsH0rzuBQKkXY7ZIE49QXmDuNsjA0 7h+JfZ0YRZ185+tZhFgNP+G0ouA5xO97AFf29ahGgUlpIzLUJw4K6fz4r69eTy8u1wJ9rladnwB ouJET7bjYe+yxho5jbIg5bb6D6VKgGcau/cI+rYr0J+fQCuJKtpkqIaXFsfGifZ0k/zPeG8Sg5s tUpne4rlXYfFy3A== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319125511158500 cryptodev_lkcf_cleanup() locks a mutex that is only initialized during the init vfunc (called at realize time). When the backend is destroyed without ever being realized, the mutex is uninitialized and the lock aborts. Return early from cleanup when the backend was never started. Note: it looks like cryptodev init/cleanup callbacks should rather be regular complete/finalize overrides (calling the parent method). Fixes: 39fff6f3e8b3 ("cryptodev: Add a lkcf-backend for cryptodev") Signed-off-by: Marc-Andr=C3=A9 Lureau --- backends/cryptodev-lkcf.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/backends/cryptodev-lkcf.c b/backends/cryptodev-lkcf.c index 40c7bd3c5a0..74db03fe96b 100644 --- a/backends/cryptodev-lkcf.c +++ b/backends/cryptodev-lkcf.c @@ -255,6 +255,10 @@ static void cryptodev_lkcf_cleanup(CryptoDevBackend *b= ackend, Error **errp) CryptoDevBackendClient *cc; CryptoDevLKCFTask *task, *next; =20 + if (!lkcf->running) { + return; + } + qemu_mutex_lock(&lkcf->mutex); lkcf->running =3D false; qemu_mutex_unlock(&lkcf->mutex); --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319095; cv=none; d=zohomail.com; s=zohoarc; b=Emg5LW9IK3TYfVF0lxjzVoi9r9bILvAsL3+6XTWkeHYQqXI85dGfbLcw6Zn+YiXWU1fNMivct0h6dApar1NQquSI12SQkCy0M6xVfICz+HuioDnZ3N0e6pb8sKe2NyVb4+bdwOKW8oDeOrva/dF1Efuu5qKkeIXE319Zx6ZtrE4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319095; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=bCdTxip8FNtJt22m42Ll7TRz6Zd06sy9UeGEc0+Czr8=; b=TJa0I+1LSwWUSVUb4aF9kqZVY+5ARDTlcxV3egYKIT8Px++UxqwdvewK4Qh//dqtqyxJhcdNkl4wMRebRI33O1KV0feQ1gMWImzZNCkAEcBXyfDhzBaIh18f5Ptfd6Y1HClC/zOJHFyV6B8x+VIG7tzrHgAAduRxQhGLYbOKidY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319095307612.9019165581202; Mon, 27 Apr 2026 12:44:55 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRs8-0001lc-O8; Mon, 27 Apr 2026 15:44:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRrk-0001JV-HH for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:43 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRri-0007qk-GB for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:35 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-155wX3K5NM25kz0SWDP0TA-1; Mon, 27 Apr 2026 15:43:31 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C400519560B6 for ; Mon, 27 Apr 2026 19:43:30 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6C806180045E; Mon, 27 Apr 2026 19:43:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bCdTxip8FNtJt22m42Ll7TRz6Zd06sy9UeGEc0+Czr8=; b=f3A9fCvJpf5xWSfH6nlhZfK/k994QHoXyWsAaZ9pzlTy++FIwsdpBiQftbAj2FYUGMqp3/ HPZdF8Tcn7AMvJxSCVQQKKNbTcictPR7Ry2bxWNB90LCI6f02iNy1bUfuvL3U6ar2cDxQm gNnKF5W/vZ6jAOelfRHYoQ6YG9GMXHk= X-MC-Unique: 155wX3K5NM25kz0SWDP0TA-1 X-Mimecast-MFC-AGG-ID: 155wX3K5NM25kz0SWDP0TA_1777319010 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:10 +0400 Subject: [PATCH 11/41] RFC io/net-listener: move mutex init to instance_init MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-11-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , peterx@redhat.com, =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1998; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=AI5iHywR+QJtls1SfbIwtt7tGFLKNLtYM1nZ2EPFdE8=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wUTPj7CJgSq8YwiimLt+PkyyUp1rMGmtyHC fUZCH1hgIqJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FAAKCRDa6OEJdZac 5biiD/oCqLacfxTJFTvmKcd+iTxjz1hp0q4/2fXdcMOyWC5NtM7bFf4vvyuObSTCDUrePO7S3Lb bK4VliKw3SWZVBqy0/XmXv6ipdScP6ww7bCog11BdzpsSFb1yHWB81SawlPJ80cS29Cm7wRC1Sz wEEBMqAsTcqM0+WnknyAoQmo0ase6qshynQLT74CKNkRtL41ucPLeU8D+W3kEz9/1tk0Xl69oy8 zsI53Ae9f/atKlLFrwswDGfaRB9lgB689yY03EjyimHefgR5P8dl4gBgo/1x0AThBIP6zjEHZ2o CagxczwoCazE44ytloYJkU8z08r/jGRYMuLfnUKXUCaee6FVTbcsXHmtcIcze2dkjha7U/TfmKD rRRiLUF4DBWnLH8JO4ejwopNKQK9y2zwsEp2iIUpO9itNCrurd6/0pAw1DyXlXAqpCjy+nXt1wJ jIqtNE9RTwFbk8CPwVQIcA6SEZIdb2M/rmegtSX4ZngyOCgwJQKRKY0GXdZoNIyAL/DdXCs4DSw 1o8HQEMQJhnSiaBAvDjAtc5MQJ/+QQhCvTbbPW1+QRMQD2exEh32BLYcy/s1hRDgg8srPqRtqXc 3AM9uFG7tiKUP6qMyDqu5UJ4YCBYw4lqSrcO/8obt0YmA59H8zhvxuCFhNnERCtQDYCSYCWP4C8 omTw+LsJqwH9lvA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319097185154100 The QIONetListener mutex is initialized in the convenience constructor qio_net_listener_new() rather than in an instance_init. This means a bare object_new(TYPE_QIO_NET_LISTENER) produces an object with an uninitialized mutex, but instance_finalize unconditionally calls qemu_mutex_destroy() on it, which aborts. Move the mutex initialization to a proper instance_init so that init and finalize are always paired regardless of how the object is created. This patch is just added for completeness, but "qio: Fix qom-list-properties crash on net listener object" from Peter Xu is basically the same. Fixes: 9d86181874a ("qio: Protect NetListener callback with mutex") Cc: peterx@redhat.com Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Peter Xu --- io/net-listener.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/io/net-listener.c b/io/net-listener.c index 9410d72da9c..1fd0f6cb5ab 100644 --- a/io/net-listener.c +++ b/io/net-listener.c @@ -38,7 +38,6 @@ QIONetListener *qio_net_listener_new(void) QIONetListener *listener; =20 listener =3D QIO_NET_LISTENER(object_new(TYPE_QIO_NET_LISTENER)); - qemu_mutex_init(&listener->lock); return listener; } =20 @@ -440,6 +439,13 @@ qio_net_listener_get_local_address(QIONetListener *lis= tener, size_t n, return qio_channel_socket_get_local_address(sioc, errp); } =20 +static void qio_net_listener_instance_init(Object *obj) +{ + QIONetListener *listener =3D QIO_NET_LISTENER(obj); + + qemu_mutex_init(&listener->lock); +} + static void qio_net_listener_finalize(Object *obj) { QIONetListener *listener =3D QIO_NET_LISTENER(obj); @@ -463,6 +469,7 @@ static const TypeInfo qio_net_listener_info =3D { .parent =3D TYPE_OBJECT, .name =3D TYPE_QIO_NET_LISTENER, .instance_size =3D sizeof(QIONetListener), + .instance_init =3D qio_net_listener_instance_init, .instance_finalize =3D qio_net_listener_finalize, }; =20 --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319073; cv=none; d=zohomail.com; s=zohoarc; b=m5AuB3ikkscYerDtl1eQRS5QMR5+mq2B12+IfbqiTB/nkH/XPoKuvngLR/qaNpiBpbQh4R30isAjnIea+MKZF6YrBmuHeOZ7mcrQ3kz42DeQ5Kl3271by5uWwqeRKdija7clccRXNXs/EO/7tYmI8zfZwvZufoe6oEo7DT6Ybsw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319073; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1VqF0c2mTa8FvKXeY4elAFuahUQbbqA9YzOgLwlQqoY=; b=Jyxa9vH4UsZAdx8yBYkKLNB7qPopPsR2OO6C+ccNnj9kX8dxLk8+it8kXIawj4BSLwP90EqrcPkZU+v1TUKQpDjvDK17/DhnNlENgjdoZvSU5206Jw4IUEZTI40/oyzDL2Inl3hYJbnSCcSSnlIuIV97MQ+3lL1ip7yRxS0mpDk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319073791615.1274353236903; Mon, 27 Apr 2026 12:44:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRsC-0001nC-69; Mon, 27 Apr 2026 15:44:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRrr-0001Od-9M for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRro-0007tu-7J for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:43 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-124-i_E1BIMSOvawB08oIqZ-Lg-1; Mon, 27 Apr 2026 15:43:38 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 35DA0195608F; Mon, 27 Apr 2026 19:43:37 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 384F3180045E; Mon, 27 Apr 2026 19:43:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319019; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1VqF0c2mTa8FvKXeY4elAFuahUQbbqA9YzOgLwlQqoY=; b=isqVzbNtiZ3DuP3CCjWi3HkPo9B48bHWjwQuiS7cPqaGJZP1qjsm9Xd9Umd0iocMXrUrLU wOwHZXHEp/OXMqQmf3flCo+m79JvxBAKGMarptWvP2wauTNlTD6P1Ioi5jwA0gb/ox2Bf5 Dflm03FwvP1IdId2AxMbZev0KYmZaGc= X-MC-Unique: i_E1BIMSOvawB08oIqZ-Lg-1 X-Mimecast-MFC-AGG-ID: i_E1BIMSOvawB08oIqZ-Lg_1777319017 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:11 +0400 Subject: [PATCH 12/41] RFC net/colo-compare: guard finalize against uninitialized state MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-12-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , peterx@redhat.com, Zhang Chen , Li Zhijian , Jason Wang X-Developer-Signature: v=1; a=openpgp-sha256; l=2979; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=kxmSjH+HqdSVTIPt3wYQYv2C7Vi1QsvEwdqKLo4jzD4=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wUjI9iWiFZPPEqnmLGNs8xkazFOZ8KyIhMQ wZxmU0YFzyJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FAAKCRDa6OEJdZac 5QA4EACzV/hk+sozwkWT0flUZLm5udNENR8k0XbsMTDlqYn4O8VhAOAw54vV6tdQChhyl3W9Vtc IGGNKH/+yNk1eTKq0pM54avHNHCbnaxCjTCsbr3sfMtNnLZGMRMCS0VeqJtHE+0IS7RpvoxmrbW aJheLRu9vTAVzn4gZeehJ/65R9E3onxFQB70La3ekrc6+l6j/jO0DglxgimGcl9ozZsXPPNYPAN BZ1r/uxMsmNkyH45Tgb/KGGyxyJPU4bQqgT86ATxr7AOKBsUChBvRsdSKawjDsBNYB5Nd3Olj+K eaymbeFnuFiHFps2PBLvQzuY++zJhqmW1w6bdAXZS8USZdbkmJdVYRGq+6Tj/8q8k5OAOlLUn0i vuzckHxc8SzDMErJcwR00YXDaHMpfXKtbGVPh/xXYza+cIadhZHmtBUxWitaDwR4BXi5qJP0uM+ wb3JStnTY5m1i/NwX0CZPoVjagjsViG5nhlLcM/tIEAIFC8aBc4pv8PmHMWOWAo7uTXa3S0t0Cq ZL4YZm+3RKTEMk7HMZdSix1a3/eqfSwW6Op1jt1YPOPAx887wM/kb0DCKymmVlT6DqnjrJCIv0E u0TO8DLTLJFS3FlhnKqF4mxcZ8OMmUnI8JVUPtGO14RfzXmEIRrzyYPBb8e/J5J1pSmmXNsS+tu bv7EkBC4Ml96FsA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319076897154101 colo_compare_finalize() assumes the object was fully set up by colo_compare_complete(), but a bare object_new() followed by object_unref() skips the complete callback entirely. This causes two crashes: - qemu_mutex_destroy on the static event_mtx which was never initialized (colo_compare_active is false) - qemu_bh_delete(NULL) and iothread dereference when s->iothread is NULL Guard the event_mtx teardown with colo_compare_active, and the iothread-dependent cleanup with an s->iothread NULL check. This is an alternative to patch "colo-compare: Fix QMP qom-list-properties crashing", sent earlier, hence the RFC. Fixes: 45942b79b9f8 ("net/colo-compare.c: Check that colo-compare is active= ") Cc: peterx@redhat.com Signed-off-by: Marc-Andr=C3=A9 Lureau Acked-by: Peter Xu --- net/colo-compare.c | 31 +++++++++++++++---------------- 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index c356419d6a8..be819db06c9 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -1416,7 +1416,7 @@ static void colo_compare_finalize(Object *obj) break; } } - if (QTAILQ_EMPTY(&net_compares)) { + if (colo_compare_active && QTAILQ_EMPTY(&net_compares)) { colo_compare_active =3D false; qemu_mutex_destroy(&event_mtx); qemu_cond_destroy(&event_complete_cond); @@ -1431,30 +1431,29 @@ static void colo_compare_finalize(Object *obj) } =20 colo_compare_timer_del(s); + g_clear_pointer(&s->event_bh, qemu_bh_delete); =20 - qemu_bh_delete(s->event_bh); + if (s->iothread) { + AioContext *ctx =3D iothread_get_aio_context(s->iothread); =20 - AioContext *ctx =3D iothread_get_aio_context(s->iothread); - AIO_WAIT_WHILE(ctx, !s->out_sendco.done); - if (s->notify_dev) { - AIO_WAIT_WHILE(ctx, !s->notify_sendco.done); - } + AIO_WAIT_WHILE(ctx, !s->out_sendco.done); + if (s->notify_dev) { + AIO_WAIT_WHILE(ctx, !s->notify_sendco.done); + } + + /* Release all unhandled packets after compare thread exited */ + g_queue_foreach(&s->conn_list, colo_flush_packets, s); + AIO_WAIT_WHILE(NULL, !s->out_sendco.done); =20 - /* Release all unhandled packets after compare thead exited */ - g_queue_foreach(&s->conn_list, colo_flush_packets, s); - AIO_WAIT_WHILE(NULL, !s->out_sendco.done); + object_unref(OBJECT(s->iothread)); + } =20 g_queue_clear(&s->conn_list); g_queue_clear(&s->out_sendco.send_list); if (s->notify_dev) { g_queue_clear(&s->notify_sendco.send_list); } - - if (s->connection_track_table) { - g_hash_table_destroy(s->connection_track_table); - } - - object_unref(OBJECT(s->iothread)); + g_clear_pointer(&s->connection_track_table, g_hash_table_destroy); =20 g_free(s->pri_indev); g_free(s->sec_indev); --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319075; cv=none; d=zohomail.com; s=zohoarc; b=KGJbOD+p0RiPifVQTJYFE3GEGnvyYa2ZRBkFOuL8R11vkUbLOyzH0FASpgYxE2iU+FGdfcxVsns3P5nSqLQF/SyHg52mDuc7uAnHB2lKWnElq5zEORfNYdN520jHiPuAWDbIo92lvkxGTrIhom/vEaiLqdhuztQy5mpRI1TtDIM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319075; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=obrpckS7iH34v1YoqBhaWwTyK91hVQnXne3ur+tLSJo=; b=XYaOeZbvkCSdvSmuPgVHO/cJmj7WImotb8IC0713ME3+44TUv7pdVSVJRJKMKRTSrfYzqKWA8qbqGqM9ebuwODpX2PeXf3UB+fbMl2wNDnylCtVEVS/h7qIDKyB2NcSd6uhB1UTkYP79maBG9Qce8OlxY61CCjXy5XRnnvp3VEk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319075589955.4970883395772; Mon, 27 Apr 2026 12:44:35 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRsa-0002cQ-UZ; Mon, 27 Apr 2026 15:44:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRrw-0001Uv-TB for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRrv-0007uJ-AO for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:48 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-9-PYToC1IyOp-NuJRWFJdgYA-1; Mon, 27 Apr 2026 15:43:45 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0AF3E19560B7; Mon, 27 Apr 2026 19:43:44 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A746519560AB; Mon, 27 Apr 2026 19:43:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319026; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=obrpckS7iH34v1YoqBhaWwTyK91hVQnXne3ur+tLSJo=; b=NkDcNg8M6r3pBeha6zuiVdGdFYoYLLHgMcaXFrB1yEt9s9GOYFvccUc+OF3LcjkprS8q5u cwIRsYU99Ka+6J62hbaM0td3uyUnyACYx/HlkNtfdAuucvRYJXBhZs2uNvhRHQEpOBIa+2 bOUHo7UCQ3KSklVcWG7Y3tVPXBo2Vg0= X-MC-Unique: PYToC1IyOp-NuJRWFJdgYA-1 X-Mimecast-MFC-AGG-ID: PYToC1IyOp-NuJRWFJdgYA_1777319024 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:12 +0400 Subject: [PATCH 13/41] RFC system/ioport: move embedded memory region cleanup to portio_list_destroy MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-13-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , peterx@redhat.com, Paolo Bonzini , Peter Xu , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1706; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=RVIgJ+CKJPiIQNDTIeDKy6h8zXHge6yaQ/kw2SNexDY=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wUCbYdI8sm3Wl/Y+5ecL5Qob5gxsyoKCyy5 3yEyxiGPbmJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FAAKCRDa6OEJdZac 5YaCD/oCF7F8ll2wVQMUzZqrg6AW2iVPjgGlqrRMkntM5VLZhJqNZ9DtyFxGtmIw8LYV+srL23b D8pbqBPqZu3AY8WerwAoHrFWNkqkeCxZaaBuX4YfcMqFIaJ3/+iIh/ZuV/J6OSs4sUollMrNZPr u/CV6h4+yL/ttBtneEMFpSYcBZd+hmk9JBa8VLTZroeoLmJ3bZ3I6nTLbPjn8UUj4hmdDnxvA2n yjO0x5hCcyC2k+QyIVjMchTjYMK1SJv1GpFkCR+a8hSHy+SX+xSQUzKG01GwehOlH6437psbHka 6zWPrTbviuPEK+Ns30O9lTDus8+xG2Xec4MWY5Jck+1E0sRWJ+A96GfyDnEMLLtCM4F/ncO2BS6 8p7/ksvM9jFEjixp8AMD0DWOCVt9oez6Li9BzqBgIbAiiOthPubdYYg5yHR5T2xPvULeDbsUSWM B+f0OSa663ZVlQ+tglnpJW9/K827U8j9xgb4TXG7iiV1yAiUvdVD6N8H1jzPMbhbQJ1cOeZXz0p 3qlghv7p8HYS5xPDoGqT85gG9FknSM8fH1Ic1px64+gMIt+IOkjPp4FuzeEiSsjtRQXWMqgav5/ 3887DjDbQV0ZndsrE4zE1qNSayW4RSOenABUvCi6KUCuHZ4hcC8rTJdCT64kDZKSJDp2E4Yl/g3 xlz/3XcOJFv2xPg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319077222158500 memory_region_portio_list_finalize() unconditionally calls object_unref() on the embedded MemoryRegion, but when the object was created via bare object_new() the MemoryRegion was never initialized and has a refcount of 0, triggering an assertion failure. The unref in finalize drops the keep-alive reference added during the reparenting in portio_list_add_1(). Move it to portio_list_destroy() where the cleanup belongs, and assert the refcount is zero in finalize. This is an alternative to "system/ioport: Fix qom-list-properties crash on portio list obj" patch, hence the RFC. Fixes: 690705ca0b0f ("softmmu/ioport.c: make MemoryRegionPortioList owner o= f portio_list MemoryRegions") Cc: peterx@redhat.com Signed-off-by: Marc-Andr=C3=A9 Lureau --- system/ioport.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/system/ioport.c b/system/ioport.c index 9209bff2eab..aa8f3229804 100644 --- a/system/ioport.c +++ b/system/ioport.c @@ -145,6 +145,7 @@ void portio_list_destroy(PortioList *piolist) for (i =3D 0; i < piolist->nr; ++i) { mrpio =3D container_of(piolist->regions[i], MemoryRegionPortioList= , mr); object_unparent(OBJECT(&mrpio->mr)); + object_unref(OBJECT(&mrpio->mr)); object_unref(mrpio); } g_free(piolist->regions); @@ -346,7 +347,8 @@ static void memory_region_portio_list_finalize(Object *= obj) { MemoryRegionPortioList *mrpio =3D MEMORY_REGION_PORTIO_LIST(obj); =20 - object_unref(&mrpio->mr); + /* dropped by portio_list_destroy(), or never initialized */ + assert(!mrpio->mr.parent_obj.ref); g_free(mrpio->ports); } =20 --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319129; cv=none; d=zohomail.com; s=zohoarc; b=A22YiPTc+V4O3VY5EufKyAFtACCD5l+mKTgK3CD/KiwXvCDH6MR+roaLx8eeGKmnNWoOahjTVvJqaWIWo4O0vYsw3KL3LPrax2Xc0xwHVMxXn/9O+RoSAaTctpjD4laSxqMuZ9wqEjhSrWyb79T2FYeqMUT5nAHmUqNsPyPhAms= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319129; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=egYIv/p9RXUeDoiMYZq9As3HoDtdRyVZwD6hR7aG2Jo=; b=OMA7nkZ6jrTmfAJ6PrC+XS/yC2UQZRxyTMpm5S/xevEQjk9rJIlfLBVRPkN1KtV0+OvruE30QUDkmZm1mFjzZJJyvhIJIoWwdVQQVAjCDcoEKlLp5RVcTak9i9Td2ex2SJzPqRaOCmPn75o729UghKW4alCUJuyLH4m474JToQY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319129570945.5113534943764; Mon, 27 Apr 2026 12:45:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRsQ-00022Q-5C; Mon, 27 Apr 2026 15:44:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRs2-0001aT-SE for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRs1-0007vB-3O for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:54 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-553-ijAB9nJkNeaqWpZ13AfHCw-1; Mon, 27 Apr 2026 15:43:50 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E382A1956089 for ; Mon, 27 Apr 2026 19:43:49 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8FC811800347; Mon, 27 Apr 2026 19:43:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319032; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=egYIv/p9RXUeDoiMYZq9As3HoDtdRyVZwD6hR7aG2Jo=; b=CllAZTpTPVT1oCUmFqnI06r/lJAzEykUA1izlTX9pf/sSXQ7X0nkqAbGBh/NMsmjGOT4Is VtZNwEWpVWLQxtD+JTVaATgVj9yBFaK8zcWW9DaIPQA4jJ5PBoH1sxp36cum/PWt+6QgzA KlS5ZWUVFNah2ROL5n6Eropt/jXi/os= X-MC-Unique: ijAB9nJkNeaqWpZ13AfHCw-1 X-Mimecast-MFC-AGG-ID: ijAB9nJkNeaqWpZ13AfHCw_1777319030 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:13 +0400 Subject: [PATCH 14/41] ui/console: remove console from global list on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-14-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1404; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=Wp7WR0az9Jyz+mnAyK07uOQyeMTXWYE2QIBV7PHHnZE=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wUhOPyGzvb2BgMJUMAWRwr83cuFs2T6dHMt +33n93FZ/+JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FAAKCRDa6OEJdZac 5Qe7D/9dBYxhksySVuJ9gtIVqop0gMCze1pLRzlTeAHdFVEl0Xtt8Fe24yynvJy5nV90Lc3uFZT RKgn+0b15JXgUJRcZppnlZhQ3YcFiwla8TuR0O0lcwZQmPl968sfTQTGLo5dg8F0vd5cmXpkFEA HajIQk5hPrQbGYOz6A5v0Aomse7DKtvq60qjtSensOhxKdHRFKaPKmHqfj+Zl5Yw6YqbUsjZfo8 IxzIMMv2+8iJhpdk0nLJowobPfa9CvekyMGz//QPH73FcJ4xC1k6sgLnWMarB3vVRWfRXpVbIBt JN2F3pAYKWRVTh6AK0ShEvK+/duotjiLlUiHZ3VSQiwy5ci3z7E/t141SqLRQkiXHfmSbGTjm1i SvKxfX/6EYWxyYwakcxJllSqaj9oLPUmrPebLQKRSimQ6lpzxSFQ8pkNId9vnHzEfMBxzV4rqcP wGwOsuKVnPFY2OfxuEetyQSZEUsbaoBeSWdzsi2FjdO635ZZYyIXCZb/RM17Z2Q0gwARndat47N IZSuzG2EukcQDbLKKYCy3IQj/0lnmQR5OBxvNpHlxvMpgCSYYCT25Pj2I2BkHV3Dsd4D8+2IaI8 j1I4/MFELMZquvPKd5/rGiyA+GDTM4li88ha7lpxfbIVFk9TJCVHqwvVmapZu0jOTaL26JCgRY2 LWq9c5nZXgVlHBw== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319131712154100 This commit removes the QemuConsole from the global "consoles" list when it is finalized, fixing use-after-free on throw-away objects. Reproducer: QMP command qom-list-properties with typename "qemu-text-console", "qemu-fixed-text-console" or "qemu-graphic-console". The assertions added ensure that `dcls`, `gl_block`, and the `dump_queue` are empty before removal, confirming the console is in a clean state. This is left to handle correctly in a future series for hot-unplug case. Reported-by: Markus Armbruster Signed-off-by: Marc-Andr=C3=A9 Lureau --- ui/console.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ui/console.c b/ui/console.c index a7bd22515b9..fde8f50db21 100644 --- a/ui/console.c +++ b/ui/console.c @@ -394,10 +394,14 @@ qemu_console_finalize(Object *obj) { QemuConsole *c =3D QEMU_CONSOLE(obj); =20 - /* TODO: check this code path, and unregister from consoles */ + /* TODO: fix hot-unplug support of consoles */ + assert(c->dcls =3D=3D 0); + assert(c->gl_block =3D=3D 0); + assert(qemu_co_queue_empty(&c->dump_queue)); g_clear_pointer(&c->surface, qemu_free_displaysurface); g_clear_pointer(&c->gl_unblock_timer, timer_free); g_clear_pointer(&c->ui_timer, timer_free); + QTAILQ_REMOVE(&consoles, c, next); } =20 static void --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319126; cv=none; d=zohomail.com; s=zohoarc; b=jy3Etracg7uATKRGSeBZMFGT+7cdenBUjiGTL6q+bucv8eSJ5DwA1Iin5HKybYL78brOVNwUxAlp7XEWP9IVxA6s3WO0+Augyz4/BpUyybfBfDPI/V1nl+jfRuGJqb85SMT7Hz7wN4Ym48MofZZy7PH5i691UoUck/B5Hb2sRWk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319126; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=FjtgSdF/RmKZsYPVx79tmSgU9IPq9ejhGQ1cMOPcuRs=; b=AEcMmUmrg1QoPv2+BUyiHpsSeYK1zEs8D3vTprFeXRS9QZTY49xyKbd2cZh3jfz/Iy5eRErurq4CncvHoL3YZQmP6vKqtt0/EcAwOEmYz6eRFAGdfL5+Ln/sjp6lLHmxScFHhwHq+eiW5N5p2N0xHTwwNEk5Hw7/790Vr6uK/60= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319126213734.1728171686764; Mon, 27 Apr 2026 12:45:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRsZ-0002R6-OP; Mon, 27 Apr 2026 15:44:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRs9-0001nk-4V for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:44:01 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRs7-0007vq-7l for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:44:00 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-413-NHRMhUqBMceaEsuhhYz0cw-1; Mon, 27 Apr 2026 15:43:57 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 36C56195609D; Mon, 27 Apr 2026 19:43:56 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D61581800352; Mon, 27 Apr 2026 19:43:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319038; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FjtgSdF/RmKZsYPVx79tmSgU9IPq9ejhGQ1cMOPcuRs=; b=Ybz9liMvSiAQNcxUhu9XsFJ/l9eOZMDgxDqSVvQnqbmz5oVIkiuSX44Citx4/DQ/kuhJVx UJNwVuzFkYrwZzUbedHOCJpC6eHSuK0hMv8H3ZhduQGMlmy+0675qzz0uwyWVN8hWXOwwl B906fVBEY4WHZuPEgdeVWzZn6L70RwU= X-MC-Unique: NHRMhUqBMceaEsuhhYz0cw-1 X-Mimecast-MFC-AGG-ID: NHRMhUqBMceaEsuhhYz0cw_1777319036 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:14 +0400 Subject: [PATCH 15/41] hw/i386/x86: free oem_id and oem_table_id on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-15-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini , Richard Henderson , "Michael S. Tsirkin" X-Developer-Signature: v=1; a=openpgp-sha256; l=1380; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=xERWYRvCuiLTWF3DPmtzusKt3TfQ56Tk1JuAhFbMaJw=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wUdq/Ah6awE67u+JM6xKjDPtqDWwrspPswn bwx9l2qBDmJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FAAKCRDa6OEJdZac 5bt4D/9TLOyiF/NMkcEgHcxikbz8iBM/t4O0SpFAHIjWf/NZrlNSJaEycYalGNUoD8W7qbbn3Ww ZJd4mrRuytXzTQTkS3oqNZLW0ADhV3r4vu2ZOCzDudfpiRQdPRFoP4DWo2PXo/DAzbtNH1KZOSG A3gEdFXQjEzRcY4VyCscVSCs57tWZXe1FdTCJNKiXZnI2zDp4QIZPYlm1OqttLdYzYyKZoIem13 Nh3XwRMKQOfT1xLoeqCNy6mA4jLxZyAKUwRUuITk2bWHFsDQblt95Rmulvz52Tan5pdiAZw0bLz HP7iZRUjTt0GGz+VOpP1iF/3/S9v6ca6iRGmq2UvPJmI+24MgSaZ+0FUH32Gknn87pUPyal9Ugj krqdRsz0S+3I08+z7jjZ3KNE21fWCmRmdAnwFyoDdAHuM0e9t49Qjwmr68RijbXi2PUDzXVK6x7 ZvBSWTD071aRR+Swrs0BkObJc6IVdmr2oK68lJouLJZWMsEHk4ZQzi6UuCISnTzRMdoZ0n4joTX f7iA4HNEjUp1h2TO/gfngtvMC6JUMq2kH09cy8KSGfiRLzFSrO/ioZAg+X00RvwwevBHG9E6oFl rugkX+g58JNpBiJ2NF5TVvCElWw//JFA4eAe5+fbIOqvhgM6/PH/bI761+qRfr7855ecZviUS7s 3yEzpZkKgDhGvcA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319127539158500 x86_machine_initfn allocates oem_id and oem_table_id via g_strndup, but no instance_finalize existed for x86_machine_info, so these strings were never freed when the object was destroyed. Add x86_machine_finalize to release both fields. Fixes: d07b22863b8e ("acpi: Move setters/getters of oem fields to X86Machin= eState") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/x86.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/hw/i386/x86.c b/hw/i386/x86.c index 01872cba073..dc7f0d56b01 100644 --- a/hw/i386/x86.c +++ b/hw/i386/x86.c @@ -372,6 +372,14 @@ static void x86_machine_initfn(Object *obj) x86ms->above_4g_mem_start =3D 4 * GiB; } =20 +static void x86_machine_finalize(Object *obj) +{ + X86MachineState *x86ms =3D X86_MACHINE(obj); + + g_free(x86ms->oem_id); + g_free(x86ms->oem_table_id); +} + static void x86_machine_class_init(ObjectClass *oc, const void *data) { MachineClass *mc =3D MACHINE_CLASS(oc); @@ -445,6 +453,7 @@ static const TypeInfo x86_machine_info =3D { .abstract =3D true, .instance_size =3D sizeof(X86MachineState), .instance_init =3D x86_machine_initfn, + .instance_finalize =3D x86_machine_finalize, .class_size =3D sizeof(X86MachineClass), .class_init =3D x86_machine_class_init, .interfaces =3D (const InterfaceInfo[]) { --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319127; cv=none; d=zohomail.com; s=zohoarc; b=QvclTR8Dl5b64JXzH/tnxkkpbNy4h733BCFnzghgsULEqV0tXxQVBbeO2+VN8KXaAADWhD3eJnW75eRm2wuCyrSmkQKBJWboZiOIVf7bxNUVa5kr6Znnoago0la5pVf5BcqgzUXM8AWZpI7v0HCJsQdozbSdxIFXY4FNvCDYG+Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319127; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+CKxosstsBFm9NGxdMF/2Vjh6b8zrpeqrvImdWrXbxY=; b=etm+MbotfoD2mRHgkf0kUUofry5MQDLw/zamK2f9vpLYsm3UR+DWzs4n8HWIOlCTNYupt4r6MAfE19nTyhsTo0eiw78/wvmL2aEwCzVGIHnY+N8xOv8GGgACJbbY8wwxOKj9p2poP5Tn33O0u93v/H1lyW2eFKhfKo32pePThEM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319127545673.2567829024068; Mon, 27 Apr 2026 12:45:27 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRse-00037h-Bg; Mon, 27 Apr 2026 15:44:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRsH-0001zZ-BY for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:44:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRsF-0007x7-Vi for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:44:09 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-54-ZIyzNzX8Mba14BW0169wTA-1; Mon, 27 Apr 2026 15:44:03 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A2AB819560B9; Mon, 27 Apr 2026 19:44:02 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4F4BA195608E; Mon, 27 Apr 2026 19:44:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319047; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+CKxosstsBFm9NGxdMF/2Vjh6b8zrpeqrvImdWrXbxY=; b=gkg7q72uj4HImrTTosgTwGOIwrQm3lAErXEH51bVAIIFV0zFvQmTBoo4M7jqBckXU47a2S mXNZQmi7E6iI5s7UksXZEMW8OeyJstUgacc8WsrAkotSVtZ1F7nnyzfTo7JMe/v0O8yWFl mC5EZUnabopt96GAs39JsfhylvXVwDA= X-MC-Unique: ZIyzNzX8Mba14BW0169wTA-1 X-Mimecast-MFC-AGG-ID: ZIyzNzX8Mba14BW0169wTA_1777319042 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:15 +0400 Subject: [PATCH 16/41] hw/core/machine: free shim_filename on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-16-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Zhao Liu X-Developer-Signature: v=1; a=openpgp-sha256; l=718; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=stDB52tVG7otdFKkTlHIFtUfl3V1tWQRHiMH9NIjmEQ=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wUAEBYx0UiBUk6IBWs+snbdteWNiVc6yRh4 /sTIDiKSYiJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FAAKCRDa6OEJdZac 5fylEACp/1gNYLHgJXwWzxyPzCitUqJL842m6rlm69GC8jCRyvOmDAeG/QCrU3OD2100QPImeXN d17O5fKB+7eqrX2arfXeNOqxVEVB+kmdFXGsks2PIGhoL3UJIVDx2Pqq+oHn4qVzsHFC4eFkSGG XnZ87zJMqIH6KVTBh5ATRnKaKirxE3PrUx49fNsnb3mpK7t0fzW8rfYqOcrvEDm/x4kpUxt/JzP zjsEdWNdeffn5LVM1WxBO1JlAbpG8+PzqmhYjuwSuCxGLxNgzMckCp0dP2V560/x1XBtzYSAGoa igz05Tlv8qE9LRJKpgley0ODyyMdDg/Zu9vr+KPScVoH3H+CC+PVSFl8DB/gOdOGdip0SjU7Px4 BZBW3Cp8TvoB/L3Yh2pC9kEk2BxiBzKKn8eM5660ZgDEVsZfEq4z8U/P7AIjmk6ouEKsk+zrFjE XPoklbi2n4vUCqqCmvZHOs4fQLI+hvKU1ovyED+1a6HOZKbIfOCxE3XnFRE8A0hZzohixRrG6tl PCHBsvxb9E4TQp0XykYT6+4/PRzDehWaehIrZyRmN65C/llRfFhZV3bteTzVOtcihhBLRXSGu0P IPWnEBU5DBRDVUmHNyuDvdo5sEbALHAOKvo1IoFH6ge5FwTuLPymJTZbSu8lQ09DyuQf4/0lJXz KEnQ7wdnOWlKx3A== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319129988154100 machine_set_shim allocates shim_filename via g_strdup, but machine_finalize did not free it. Fixes: a5bd044b1579 ("x86/loader: add -shim option") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/core/machine.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/core/machine.c b/hw/core/machine.c index 1b661fd36ae..6a7fb312eb6 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -1282,6 +1282,7 @@ static void machine_finalize(Object *obj) MachineState *ms =3D MACHINE(obj); =20 machine_free_boot_config(ms); + g_free(ms->shim_filename); g_free(ms->kernel_filename); g_free(ms->initrd_filename); g_free(ms->kernel_cmdline); --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319106; cv=none; d=zohomail.com; s=zohoarc; b=N6iYNww9yPkaJsj5nz7O0cIbZ97ZREOLyp958tZEF2iYOqazviANmDoo1ojrPLbtH5oW9U9Di0qFnQj2DZKc9OivQ6xSZEB+l0CH1ywOTjOavSvHaM4yGNa21P8sb6ZXe6TD505Cy4FKZSHbHPlmORGZSIu+/AyqhG+NBKR0AQs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319106; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=v2nUewpRlfcuzS7BbkUxVYKnJ4w1wM50RV/7mph3xcA=; b=oCVF1seRAJw/7NBMTa+9Pp1ZMaNnXVInXQ3AKyuU9UTUTi+GLpHvSEZAyrny+dC3vrAi+cYZd83n5HpLWZnEfzxXeFQTtdK5YDv0hgLT3AQLUz8fJDDTKp0svFVa1QfZiKPA90tSmluKl3TQw8IXVOsnnU0hJ1WCWvDxpB6XH0M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319106950726.4065962205216; Mon, 27 Apr 2026 12:45:06 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRsc-0002tm-MM; Mon, 27 Apr 2026 15:44:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRsN-00025Q-F6 for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:44:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRsL-0007xy-U2 for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:44:15 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-460-e-SwKzz6PNeMLCmtQLU5RQ-1; Mon, 27 Apr 2026 15:44:09 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8C8D718005AA; Mon, 27 Apr 2026 19:44:08 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 425C319560AB; Mon, 27 Apr 2026 19:44:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319052; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v2nUewpRlfcuzS7BbkUxVYKnJ4w1wM50RV/7mph3xcA=; b=fkx/Zy5WfWK4mZqFUvistrD5+81JpLHxiV/ZjY1qGERcGF2RtYVlN4VlbScYee1PUibSwo XhnUIkNgj0UQjzmmHfld809oX96aFTtyI1QtFQNbueYVPA6p9uHADj4vaFQzi2wiV8OBAW 3IuUTwehxDdOIZI96PvPre4E76duQe4= X-MC-Unique: e-SwKzz6PNeMLCmtQLU5RQ-1 X-Mimecast-MFC-AGG-ID: e-SwKzz6PNeMLCmtQLU5RQ_1777319048 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:16 +0400 Subject: [PATCH 17/41] hw/core/resetcontainer: free children array on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-17-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Peter Maydell X-Developer-Signature: v=1; a=openpgp-sha256; l=860; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=fxwKGK8u2FdwGWFYQyu8CRzaHlO9/OVt+VeAwfQGL24=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wVfJXC1LbJJWXnRmWRMGAyvK8GB4FK7DzjC tSzk0nQIJ+JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FQAKCRDa6OEJdZac 5a5PEAChPy4deRq3TzLpjQ+SVu6xW03+o2sv9DrCGqsRyGVDaxaToqQK1j3o/RtIVwjdmuXTlO+ Ixu0Osf3e1n/S1zElORKGIQ/hQZDH0kyjwBaWrGcbJOHKEmWzaUMnT8vCQfbMG4HCqsSfad3y8j kT1HHkE5I3S9Z7lwZwdW/JJS4QK+p+Pj/QRAOXp+Zpmte4zvztAlIrF3SVReXSrx3A4pxYxNtIG F3TQ1INFpvAr2qVStClHuv/iH4hIP9tR0y+BAI97bG7IuUojdBj/5+ydKIWYz1IN5ZWkQjVOgc2 nzrtNIZmEMHO2H2TGVZ/Ppsi4s/WoMu9MjCLvZUnKzrLFGOrg/Z7r1Vz4ODaNYO/yQVNSrASREm SupO9EAIzNNxe42/IsNcSgLfU7WVAhhuRvZC8vdlhZJXKX+gBtM06kkzHM4m/aBjyZlzyVgxl9l S+OYg1imbUxB3HgdJRAVASXkxuoq1240m+uzZhyEeWCBiTFw+GqkliJGkFh9yYarBMLv1e72X9m ABMcwY2c3t+AEpLfvP12nm6SCahWwtl7ZOE/bY0mvjSZZnlnOyjunvbGo/WoEO2wq7DfhnuYZAb vQsDyOgDx2w7Ef9YDsyktaNqf69kYT333M+RTVRP0N407Y3wWWABTGvd328zT4I5Dg8DPfFtomP 7vNpfUpJrPlOrKg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319107386158500 resettable_container_init allocates a GPtrArray for children, but resettable_container_finalize was empty and never freed it. Fixes: 4c046ce37af0 ("hw/core: Add ResetContainer which holds objects imple= menting Resettable") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Peter Maydell --- hw/core/resetcontainer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/core/resetcontainer.c b/hw/core/resetcontainer.c index ef84aa2374a..a4a6476a036 100644 --- a/hw/core/resetcontainer.c +++ b/hw/core/resetcontainer.c @@ -66,6 +66,9 @@ static void resettable_container_init(Object *obj) =20 static void resettable_container_finalize(Object *obj) { + ResettableContainer *rc =3D RESETTABLE_CONTAINER(obj); + + g_ptr_array_unref(rc->children); } =20 static void resettable_container_class_init(ObjectClass *klass, --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319128; cv=none; d=zohomail.com; s=zohoarc; b=PJo2L68jEJA3meIxJucdLfMKZYh85H+lpSo9qiEw4e6AtQDBbGWgW0LSmrI//qcbzg2tXnBkJwUbfdry3w78fCjMNaZvVodLJKZo0nz1pXTmSqPS6onImeExN2PQYCzuXkKsgxC+Q2QJxEp8Kamc5ySCDqH/+bamXQ9QNf/Vjp8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319128; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1vODrsVhyVyPcxPKeorFPGsjKDbcWUqmWEDNJlt/Brc=; b=m0WlfDXKadQ7CLeRVrm5qSkj/CJEPyhlBnKZKSPfwTijpaxFfAWCE1OFIruQOqqDmUXc7+Q8dU/SGGldcSbTEJdS0Zd6c3UlHRMuPMOKNhYsSz8CNHRiElAW0Dm0e3DnERzJkNWa7IhD0TsFpmFdsFOcBZ5Al0er5lLHjh19tsE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319128116407.9021956107323; Mon, 27 Apr 2026 12:45:28 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRsb-0002hO-AH; Mon, 27 Apr 2026 15:44:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRsR-0002AX-Fw for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:44:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRsP-0007yS-U5 for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:44:19 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-77-0lrkFSldMOeP6j2n0Pkgwg-1; Mon, 27 Apr 2026 15:44:15 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8C7C61956088 for ; Mon, 27 Apr 2026 19:44:14 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 50EB919560AB; Mon, 27 Apr 2026 19:44:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319057; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1vODrsVhyVyPcxPKeorFPGsjKDbcWUqmWEDNJlt/Brc=; b=hcbZWHYmED1gMsqADEc0om3Knn97SmDde4IWkEacbDMiN71YMN3/wlNE7oKqDVPHGoxTmZ yVVV1Tlk8GOYpybcEVXP/uw50e1f9A9xCjQ6iU8iVLKlzqa73dtF/p8oHoBJUwYON7v6Xj qwu2GzqheRbARHSrz9fBoEUNa4C4jHs= X-MC-Unique: 0lrkFSldMOeP6j2n0Pkgwg-1 X-Mimecast-MFC-AGG-ID: 0lrkFSldMOeP6j2n0Pkgwg_1777319054 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:17 +0400 Subject: [PATCH 18/41] net/filter: free old values in property setters MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-18-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Jason Wang X-Developer-Signature: v=1; a=openpgp-sha256; l=946; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=t0rAI0UZ5Soh2qRGC318tnu7sO3f1cUnwR6syUG2oKk=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wVWcppFqMLXn0ij9ZMApbly/sE+yM8IvHiB 1Y+SFmx3aKJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FQAKCRDa6OEJdZac 5erRD/0XXT4ZyuEVpGlELeWNS3a9VAe4RYLGrS/nReCzsauJFqFCAY/zAFDqiqwxEOBnDHRfMXd 3l5K4rb/vPouSNaVku4+mzzGVh3he1dFmwuDpy8alnGe6sFMU5s6st+MrcSs1jvH09VpiZjhprv GH8GYOI825ecOIuNG47ytPb/OoUNfpExBGuf4V+H6hTi/BvCJddm/UyVmbLLNNSwsCcoSrZV5x5 RL+in1mvxIw9vrT7dbN2T3jNhTf4lDRdfhNuFCogQ/x9PXaczDAqDcno6HX0tO8jhLoZaReoDTm fAH5zWVMX0wX81Bnzrd3AefW57QxJfN+i9kZNl+U+4ISrYE4UbXNLqS/A0WDFGVQVJ8VzW0rljE PK4oC5fiXIvHKZSwTqgXWf2YwjwGI8HpR7jK01CjeIz4SZShJZiWVQFZYHkspHmrHx5f1f3C1xL onNKrLzElS8fhZEGxEk3l8stOBXKJWDR264Q1j988ccc+yDl5Rjo5pYPV+p6V6FtOZpHWU5zWY3 l633tZu1fgZjEZoacz2InpP893ljxOfSFpNf7MvV50jjkV21nNd9DbXic6VYFHrhBaxN4W4D37i /TJTKFjH8WlXcDPDTzzBCiKjQbXyt2RYyzbpiydidhdXJO06N5heDAMerlxVpIwJx0nakIwSKqf x+dwd+wdp/2H9nQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319129530158500 netfilter_set_position and netfilter_set_netdev_id overwrote their respective fields with g_strdup without freeing the previous value, leaking memory on each property write. Fixes: fdccce459621 ("init/cleanup of netfilter object") Signed-off-by: Marc-Andr=C3=A9 Lureau --- net/filter.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/filter.c b/net/filter.c index c7cc6615dc9..389f3b0bfef 100644 --- a/net/filter.c +++ b/net/filter.c @@ -130,6 +130,7 @@ static void netfilter_set_netdev_id(Object *obj, const = char *str, Error **errp) { NetFilterState *nf =3D NETFILTER(obj); =20 + g_free(nf->netdev_id); nf->netdev_id =3D g_strdup(str); } =20 @@ -182,6 +183,7 @@ static void netfilter_set_position(Object *obj, const c= har *str, Error **errp) { NetFilterState *nf =3D NETFILTER(obj); =20 + g_free(nf->position); nf->position =3D g_strdup(str); } =20 --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319128; cv=none; d=zohomail.com; s=zohoarc; b=NRGTievWxyA6k/eQcAyBC9dkF9BIVIr7kSQO9H+WcbHFC3TRtCnsg/gFNYxuivxPuUu9MmHeOgi7/HYgdvpnoh7iFD2E+YQ0oOPmUFJX0OXZlPpTwgQ1KFWjpo7tm/rSFPgkT9iTRtc6mNpsoQqEO4fyEqHXYNC470s+ynNZ5+g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319128; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=7mO1Q1PX7LwqKmv4izDa+Ri7d+hEtOWbrxErFRjbh8M=; b=KwZ87BOKFLOYvugHHE16Av0uEbxqvcaCg0QOEmCiSiVIrDjGOhL77nLzFwoXM1PCp8DVwaWsIZ0dHLEJrtRkvDiiT8TDZjViXO9t5pLyZiIRiqvwPnMJPctT4T4/loTW6JGF/bu0JlzK72MotziwgOLAV8JMLLySIeG2NE/I3Fc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319128425997.0845572133236; Mon, 27 Apr 2026 12:45:28 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRsc-0002qh-A8; Mon, 27 Apr 2026 15:44:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRsX-0002HY-8Q for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:44:26 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRsV-0007yr-RS for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:44:24 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-629-0iS2rUBqPbqQ72lXHqwNDg-1; Mon, 27 Apr 2026 15:44:20 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EA2AD19560B5 for ; Mon, 27 Apr 2026 19:44:19 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id EE73819560AB; Mon, 27 Apr 2026 19:44:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7mO1Q1PX7LwqKmv4izDa+Ri7d+hEtOWbrxErFRjbh8M=; b=Ms4nB/5qcl3A1Qc7Rals0oDREQ3aBgQv7GT+DqX/rZVXzVcyweItxOEz0dNb6E9N6qNh8h nMd3NH3ipCZUsJY093fuWBOoKK9MRWNjWFgN+QQX1GIFDTAutLq2eEQvyz3g5tgn39Hsff TTyvEA4Fck5UzDmu1HPLzQlIWu1shN4= X-MC-Unique: 0iS2rUBqPbqQ72lXHqwNDg-1 X-Mimecast-MFC-AGG-ID: 0iS2rUBqPbqQ72lXHqwNDg_1777319060 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:18 +0400 Subject: [PATCH 19/41] ui/console-vc: destroy fifo on text console finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-19-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=699; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=/copMMdgfN/IQj7Op8a3U5/jQ7AvugHm22MyFvCxwcs=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wVDWc2RTzTdzVaACw0HBTV7aFjGoUZeyq/P futjwZkBG+JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FQAKCRDa6OEJdZac 5TKuEACYTWAOJR1BUnf0ErDjRwkFUsggntWcKEhW661y6xonoNUubqd9bT9XDm8ZDPPVhkX7hp9 NdyFyk5IAnf5Ctjir5T7KHpimpj1EvgOe/qA2my5/oOq/ndXuUfVMJXwnUhjm3hhNr3oKen/3Cx 2RjkRiojnG8z7S1EG7YINO2qrzgY2KBuf2K6elgSxVnOfVBeOOeIu9uAoF0u2wcE8qQTA9YOy0G b+9zBslSRfLrHuHKowdTUXhAkjhNcf9qzDq5uq5okAHRDWEpLZIq+ZhdBdzVV0GYykSsXPv23Bi kpGx62E/H13Jk14+vYA5hquDbr/CoJv1K3J1qucS1FA4hXUmYRy4O8a3c3QDk3n+72uFaZKZNXZ CpzDhpXfsUPVWI1Y8q9fG0nIX2mELeOsSEOIirWUg6gSXdg3ErIQNtNZKc5jgYLdpErd7hBKGKj W1ZY0ySKjekfB1uQ8Z/OQWPkjkL3SxrUfP6cYKiYtgaZepd7Pl4b7d8KvjC8dULkKuBaU0HaN6A LfRCApulxDvgX4enDISQb8kluC3hyXE9BSBspx+K2gy3UJ9e2abKsZZt+7auWmBMMsrFcLH57md aqWDrOnZMCz7L/Abf6+XrN9MQ3r5W2QLouDQKp0GaBGM7qNa5eOBi+cwFKQPksUQX82U5lNyzvd nT7oanfPcuUQP6A== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319129895154100 qemu_text_console_init creates a fifo8 via fifo8_create, but qemu_text_console_finalize never called fifo8_destroy, leaking the underlying buffer. Fixes: 0c9d0641ac ("ui/console: replace QEMUFIFO with Fifo8") Signed-off-by: Marc-Andr=C3=A9 Lureau --- ui/console-vc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/console-vc.c b/ui/console-vc.c index 107294af1cc..89fa9a216e1 100644 --- a/ui/console-vc.c +++ b/ui/console-vc.c @@ -1081,6 +1081,7 @@ qemu_text_console_finalize(Object *obj) { QemuTextConsole *s =3D QEMU_TEXT_CONSOLE(obj); =20 + fifo8_destroy(&s->out_fifo); QTAILQ_REMOVE(&vt100s, &s->vt, list); } =20 --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319086; cv=none; d=zohomail.com; s=zohoarc; b=D2Yd/p6M3Mugo3G9jVRcKsTKXqe6QU+XGK4KeQb2uDVSMzviomFIeImc7D/LaCg8ttolv+olRLiz1Qd6E05IQc3UrObdiqrEx/3X1Bfs1vAvxZFBbTTxLfijU/MWxXljXnQFSivHcGPlO3Wr2C5yhwVBJ8HsLyCHnnUsAlHiLfw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319086; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Z3mpIj7kKLWQd1wHYRB/isiRg9MwxmXnW9JJf/oFUXQ=; b=S4K9FxmJ3H6AmVmQCi1iZ/COijzH5sw4C6nmnRPsKfrt1TEjBHAKJtYyyfzE7z5hWwh7M03BcWlooKte6E/T1DToIab81FgeIzyzbH3loSOzJiDkOM6Bx0wEV1t97ppm8BziltyLYmdA1tvrPa3Bdwpr5bj+0hna7lDNkircGfg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319086567183.47411071149088; Mon, 27 Apr 2026 12:44:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRsj-0003ru-Pd; Mon, 27 Apr 2026 15:44:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRsg-0003ZR-QE for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:44:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRsf-000806-4F for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:44:34 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-623-66sLjyeEMly5eSJMVCE_XQ-1; Mon, 27 Apr 2026 15:44:27 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 21D2A1800345; Mon, 27 Apr 2026 19:44:26 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id CBEBE300070A; Mon, 27 Apr 2026 19:44:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319072; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z3mpIj7kKLWQd1wHYRB/isiRg9MwxmXnW9JJf/oFUXQ=; b=A8fjODblbnw/+fItA3KyI/i+wnMYTXUT4MNyn7xuaCflpYNsm8Njs4py0LCUeOygvunVic I6gQi//rbAHRiOFiMXIP162AtHUWMZO8DRupb9mGap59BDYhCMGsRsBBIbvNKDtr346AIb gqbZy1aKu2Mx5LTsiTZEnZRLzEpvxtQ= X-MC-Unique: 66sLjyeEMly5eSJMVCE_XQ-1 X-Mimecast-MFC-AGG-ID: 66sLjyeEMly5eSJMVCE_XQ_1777319066 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:19 +0400 Subject: [PATCH 20/41] target/i386/sev: add finalize functions and fix leaking setters MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-20-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini , Zhao Liu , Marcelo Tosatti , kvm@vger.kernel.org X-Developer-Signature: v=1; a=openpgp-sha256; l=4011; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=owTdgCW7z+9rJcjQ83R8ZEybDyEY8YNmwtxW2tfBqxA=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wVh3bge/hfu7M/mrWwNzqJk9dgdWrhJfDTA kRvwWFs6TaJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FQAKCRDa6OEJdZac 5YS/D/44TGXRiKZhlIVanFn8435rX5HTctjAkmt5JVuGq93W2jX/6NB9o6p+UYPrvNcz9xeRued +67951etfZW+rt4Eht7tX7nN0YOf/FTLnHAcrkFfdyMR8r/lP1Bne4qhDdLnTBkqwfR2IbgT+Uw hGQMpc83p4WHRo+nQpHAO93xbH6bOW2XgbTemdwaO7DVK55JxBA/0713I6qlm7+QcF/WdRTSYEU sKU+9Dm0DSqltJQ51JM3jRvLju6Q8PNeybeDNSlHVDjoD1aVJu0TN6KCcPALc9i1LCwmgcK6qyx ALotZh3NJtOPxjSX57aKsaJZvFetSCXYrNE3ql9JR1GxYX4GzEsOQW7er/UZ9bLBaASoCdGjORe P9sgw6t/PW9pYfqPl9cIaMKmia9jQo/ZRJZna7AhQ45RL05aFzfMNeLgumaNBVRE1czuRFJyCv1 Samt+ncT7GrJeym2Wez9sNueqBlRrs66CYhuxSHHDkivA1N2xS/d36PeLP5+2jutCNLBM+zm/R0 CWHbHUYoDSByF3H2u8jnMcnBU8EQhbF3JS4EgMgb5EgDucaoY+Rl+cfDDNJzjGIEZLkI/eWP3PQ WD8uGBEZb2cFIMJLQP978qKhVyi5RV2oyjGehUIHCIGv/HeorfSWgIfBQdFTUS8224kAPRlquV7 Pt/qLRCMLtb+Xag== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319087352158500 None of the three SEV types (sev-common, sev-guest, sev-snp-guest) had instance_finalize functions, so all string fields allocated during init or by property setters were leaked on object destruction. Add sev_common_finalize, sev_guest_finalize, and sev_snp_guest_finalize to free the allocated fields. Also fix sev_common_set_sev_device, sev_guest_set_dh_cert_file, and sev_guest_set_session_file to free the old value before replacing it. Fixes: a9b4942f485b ("target/i386: add Secure Encrypted Virtualization (SEV= ) object") Signed-off-by: Marc-Andr=C3=A9 Lureau --- target/i386/sev.c | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/target/i386/sev.c b/target/i386/sev.c index 261b6aaa37b..3c2734ad83b 100644 --- a/target/i386/sev.c +++ b/target/i386/sev.c @@ -2527,6 +2527,7 @@ sev_common_get_sev_device(Object *obj, Error **errp) static void sev_common_set_sev_device(Object *obj, const char *value, Error **errp) { + g_free(SEV_COMMON(obj)->sev_device); SEV_COMMON(obj)->sev_device =3D g_strdup(value); } =20 @@ -2831,12 +2832,21 @@ sev_common_instance_init(Object *obj) QTAILQ_INIT(&sev_common->launch_vmsa); } =20 +static void +sev_common_finalize(Object *obj) +{ + SevCommonState *sev_common =3D SEV_COMMON(obj); + + g_free(sev_common->sev_device); +} + /* sev guest info common to sev/sev-es/sev-snp */ static const TypeInfo sev_common_info =3D { .parent =3D TYPE_X86_CONFIDENTIAL_GUEST, .name =3D TYPE_SEV_COMMON, .instance_size =3D sizeof(SevCommonState), .instance_init =3D sev_common_instance_init, + .instance_finalize =3D sev_common_finalize, .class_size =3D sizeof(SevCommonStateClass), .class_init =3D sev_common_class_init, .abstract =3D true, @@ -2856,6 +2866,7 @@ sev_guest_get_dh_cert_file(Object *obj, Error **errp) static void sev_guest_set_dh_cert_file(Object *obj, const char *value, Error **errp) { + g_free(SEV_GUEST(obj)->dh_cert_file); SEV_GUEST(obj)->dh_cert_file =3D g_strdup(value); } =20 @@ -2870,6 +2881,7 @@ sev_guest_get_session_file(Object *obj, Error **errp) static void sev_guest_set_session_file(Object *obj, const char *value, Error **errp) { + g_free(SEV_GUEST(obj)->session_file); SEV_GUEST(obj)->session_file =3D g_strdup(value); } =20 @@ -2937,12 +2949,23 @@ sev_guest_instance_init(Object *obj) sev_guest->legacy_vm_type =3D ON_OFF_AUTO_AUTO; } =20 +static void +sev_guest_finalize(Object *obj) +{ + SevGuestState *sev_guest =3D SEV_GUEST(obj); + + g_free(sev_guest->dh_cert_file); + g_free(sev_guest->session_file); + g_free(sev_guest->measurement); +} + /* guest info specific sev/sev-es */ static const TypeInfo sev_guest_info =3D { .parent =3D TYPE_SEV_COMMON, .name =3D TYPE_SEV_GUEST, .instance_size =3D sizeof(SevGuestState), .instance_init =3D sev_guest_instance_init, + .instance_finalize =3D sev_guest_finalize, .class_init =3D sev_guest_class_init, }; =20 @@ -3195,6 +3218,19 @@ sev_snp_guest_instance_init(Object *obj) sev_snp_guest->kvm_start_conf.policy =3D DEFAULT_SEV_SNP_POLICY; } =20 +static void +sev_snp_guest_finalize(Object *obj) +{ + SevSnpGuestState *sev_snp_guest =3D SEV_SNP_GUEST(obj); + + g_free(sev_snp_guest->guest_visible_workarounds); + g_free(sev_snp_guest->id_block_base64); + g_free(sev_snp_guest->id_block); + g_free(sev_snp_guest->id_auth_base64); + g_free(sev_snp_guest->id_auth); + g_free(sev_snp_guest->host_data); +} + /* guest info specific to sev-snp */ static const TypeInfo sev_snp_guest_info =3D { .parent =3D TYPE_SEV_COMMON, @@ -3202,6 +3238,7 @@ static const TypeInfo sev_snp_guest_info =3D { .instance_size =3D sizeof(SevSnpGuestState), .class_init =3D sev_snp_guest_class_init, .instance_init =3D sev_snp_guest_instance_init, + .instance_finalize =3D sev_snp_guest_finalize, }; =20 static void --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319121; cv=none; d=zohomail.com; s=zohoarc; b=Pyvvwr9m2MEg2CIWONiwB5ei8MpO+aILV169gz//BZwy62kPDOrEAlq/BKotqc+AxL6bkZpQ6QD3B8+UW7Q06cajfyjdVfOS9oiB1PpbXT09ipU/bD44dSfqsddIOjSJ8zP+cl/YyKa7ClQYys4G0iJX73oa7ZNFf+iZyBcdOuc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319121; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=bMnEmi3v8/QqeA6DDuFhvLERp1GfLcHeEYC6X5UXDMs=; b=JEqdPQSM0CCQhUxSJhxpo0t8Q+3znYiUj9IbyOGhHeeVdVfH3jM/ZzTrB4N5he7+tvWSVMaDOGNEE90wsEvs5jkAJFUayfLbgQ5DUDSD7LpiBx0ReqCzStlRL6JfEJEdnLEOjFOM4xzGgjnY35UoqHjzwlj6yNwphx/pzim/ScY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319121713988.4669940111485; Mon, 27 Apr 2026 12:45:21 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRsl-00040r-9c; Mon, 27 Apr 2026 15:44:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRsi-0003mL-8Q for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:44:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRsg-00080D-Pq for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:44:35 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-562-9-KmE8VJMyim9euSymLtBw-1; Mon, 27 Apr 2026 15:44:32 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C6F6E1955E9A; Mon, 27 Apr 2026 19:44:31 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 69E9F180047F; Mon, 27 Apr 2026 19:44:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bMnEmi3v8/QqeA6DDuFhvLERp1GfLcHeEYC6X5UXDMs=; b=RmKa9p6B4J79ok+PAvh6ocqWhivVcM1fRlOGJ1YOmOgX3R7CAsoMSkwghabTuTPv/lXELR zvCC8Q5TJcQS8s8pYmFapxoXq8kNA0nYLKxfScg9n3kKa7zg541TypnPHSTXtUDtm1IEEL wDOvQ9WlpIMvPSujytxgdOaUCwoaZuQ= X-MC-Unique: 9-KmE8VJMyim9euSymLtBw-1 X-Mimecast-MFC-AGG-ID: 9-KmE8VJMyim9euSymLtBw_1777319071 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:20 +0400 Subject: [PATCH 21/41] target/i386/kvm/tdx: free strings in tdx_guest_finalize MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-21-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini , Marcelo Tosatti , kvm@vger.kernel.org X-Developer-Signature: v=1; a=openpgp-sha256; l=837; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=HEXbom8w6BaN+wnuMFqRD/qko2iqRyMwfut0S8bMS2A=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wVvhksEAaDilerpCh7L2D/LJtSDHrTV/YOI JtQDppNNjKJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FQAKCRDa6OEJdZac 5SblD/9F6GLRocqj6HK3EDhpWsm763/GmQ+d+FKaaP9TgBgpqpbtshl7JDgKzNKw3mYjol7asfD 8irw2eHDICvJiaSjPwofwI6H/qs5EadLeuc6mtU3CopHJbmgwSZXEVwohbCHTVb5nx0NmpVko81 yOKK/hpHOX5fNL0vaiC/yJrMSftf5pb3iCUy+8bXCTfuyqF0mQp0btrlCC9Ium4sW7ZY49+Ab6t uFJd/eTkw1y5hqbxnFu+z8OqxuQVw8O/8nlK8q4/BjOASkcwkbyJiNKova7lqnjI5HnMZvUdtzj viBdWlip/6NSp6Hs60SQNP7Jfh9hxI6ITSJI2f558WvPQFESrmFC9my7RJowzFumnfZHXd3agN5 rq4wWl0yYSKs51CVMBa+evChZm7eNRadiAllxF/RTxToJfxzFKrugyf3aiI3vFzhxs8naTl/q24 MaDg4HQjPAHKLrMdt50+d65t/88ECnJPYJIHPj+rPf/g8JMESz1CaC/5Ii9RbHA91kE3WvNHqH+ q0JRiwncISmZYlblCWD9BOgR49eW/TQoDR689LrAU4wqjcXQQgCZx0XcoHRcS8QwGGlGRdRK4j8 4AocIXyOH3+s6PmZA6Gu4diPHMzq6cocvxA9hvuVgPqzgtFIniCMszr+50t2GuMcSMuBDlnF1I1 mpjlBDZu/NQYM1w== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319123516158500 tdx_guest_finalize was empty, so mrconfigid, mrowner, and mrownerconfig set by property setters were never freed. Fixes: d05a0858cf87 ("i386/tdx: Support user configurable mrconfigid/mrowne= r/mrownerconfig") Signed-off-by: Marc-Andr=C3=A9 Lureau --- target/i386/kvm/tdx.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/target/i386/kvm/tdx.c b/target/i386/kvm/tdx.c index 4714c9d514e..df46fce7693 100644 --- a/target/i386/kvm/tdx.c +++ b/target/i386/kvm/tdx.c @@ -1585,6 +1585,11 @@ static void tdx_guest_init(Object *obj) =20 static void tdx_guest_finalize(Object *obj) { + TdxGuest *tdx =3D TDX_GUEST(obj); + + g_free(tdx->mrconfigid); + g_free(tdx->mrowner); + g_free(tdx->mrownerconfig); } =20 static ResettableState *tdx_reset_state(Object *obj) --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319117; cv=none; d=zohomail.com; s=zohoarc; b=hqAroMANyJDnIJ9bX5eJotKy/oE1F/fIxyu/DH2JyYrCAl114bYZjDOZRd05MQTfMUA+eFUVjweyaPnGrJoBa0mzgx80juuEAQdB1WsHdDV0lH8Aa9AOCWMIlzbxacTr7bbmp1qDFqn7t1j3FxKvLuEbJbzpmauk620zwyPlgJQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319117; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=N5iQUKbZP8zujOPvMI08chGq/OJpRT5TuzZ9VyP7o4g=; b=WqqyQoZrJqyiPj/1PbYpJacblBoH8v1W5v3koj8GcWcU+UcwKKRbpx/5GUpqkRdbhwZIbKQBN6obAVnsoOuvdRNlt5c5ZcIKHXACKS7ea5JPlSshOBxvCdqEp54eJFDzC8bsypiHAVhel2W3aIjEhb+1L0FpLy6XjDM/mfANOeo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319117503584.6469284013324; Mon, 27 Apr 2026 12:45:17 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRtB-0005AH-PT; Mon, 27 Apr 2026 15:45:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRsw-0004gB-A6 for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:44:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRsu-00082I-TU for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:44:50 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-22-7Goht9LqO8ybHpsB2T8qdA-1; Mon, 27 Apr 2026 15:44:46 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 051EB19560B8; Mon, 27 Apr 2026 19:44:38 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6B76719560AB; Mon, 27 Apr 2026 19:44:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319088; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N5iQUKbZP8zujOPvMI08chGq/OJpRT5TuzZ9VyP7o4g=; b=R75bSFiX9eNcuNKvuUmR1OHVRMUWCM9IFKId7QwRsxZPWjVDE/ilFsUyLGx0RNmwIeLci6 7xs96wyWLVmpLEppu4Lz+d/igN0zUYrggh1sPLBegLiex8WSiaLbFUODq0qutmieUwzwHJ J/Q0Nzd1UUSxgcaxHcxG+PwvQ/afUgU= X-MC-Unique: 7Goht9LqO8ybHpsB2T8qdA-1 X-Mimecast-MFC-AGG-ID: 7Goht9LqO8ybHpsB2T8qdA_1777319078 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:21 +0400 Subject: [PATCH 22/41] hw/i386/nitro_enclave: add instance finalize MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-22-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alexander Graf , Dorjoy Chowdhury , Paolo Bonzini , Richard Henderson , "Michael S. Tsirkin" X-Developer-Signature: v=1; a=openpgp-sha256; l=1427; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=ky2BNto0UCWYm+5t0f6AgVp5RVCDBWwnYNiNyNbKi5s=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wVJtiinN1Nw+U1eSXwgM7UXadi6GnL7vyCA QCzbvybpieJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FQAKCRDa6OEJdZac 5WraEACm+lrN9ji+8C+X8qXlo4uk2Ipv9iD7FwKo6j3IA2pKwbk4TiXNjW9SEPu++g+P1VaadQK 3bleSRmh091TM5S3SxIgUaezpgC7rxHXYNiPj6Eg/GYiMHJOrG8Dg31PzyhS9BMzX24fURuuQFB IPbYcvVijojvWNkRCI27Tu37rHQf8+AKEeUV6qKSLZLPTn5NNUO11P5e1EMp6wgeIt4W2Qq/9YY cRVA4lwkj1C+s8LxhlBtP3Hno70NcLxtglo79ZDTuLyh0/12HtagEdDltSmIYts0IG5lKXs8Jq7 55PtwKybV/6tDqQ6Vkxjq+68SgyTfZIDv8j/UTLVkwL5Aps6o4xCTWTxgImS4szB55N7stG/iF0 mXZE6zLVeXtROJv3QDQ+ulugf83DMLyVKYJGTSe4IQ4EcpyRpX9siK0fzrYUVw1D+un9dSWo+X9 n2AsPMPwpgl475ltsqlK/6VFbq/osU8DFb5EQq4BfNwYD9/ykOSWAAqwvVcW3dJja3iVUKs+PPP /uLxI8Lu9f44rBaAByzuTdIscJ2t+BwCm6BIEwhDpTl/Fwg2TqYIxYmhuFQP4Wmf2v5Jgs993Y1 LSkJx3OwIxdaBanhFeURpcwR7sea54O5CuLRC2koIQkwTyVUygCtNKSYgYQto0SNZJygy5Xw0o/ EwJx1tJzlK6DGpw== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319119611158500 Property setter strings (vsock, id, parent_role, parent_id) were never freed because nitro_enclave_machine_info had no instance_finalize. Fixes: f1826463d2e8 ("machine/nitro-enclave: New machine type for AWS Nitro= Enclaves") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/i386/nitro_enclave.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/hw/i386/nitro_enclave.c b/hw/i386/nitro_enclave.c index a29f0044d0e..1ce9ee3358a 100644 --- a/hw/i386/nitro_enclave.c +++ b/hw/i386/nitro_enclave.c @@ -337,11 +337,22 @@ static void nitro_enclave_class_init(ObjectClass *oc,= const void *data) "Set parent instance identifier"= ); } =20 +static void nitro_enclave_machine_finalize(Object *obj) +{ + NitroEnclaveMachineState *nems =3D NITRO_ENCLAVE_MACHINE(obj); + + g_free(nems->vsock); + g_free(nems->id); + g_free(nems->parent_role); + g_free(nems->parent_id); +} + static const TypeInfo nitro_enclave_machine_info =3D { .name =3D TYPE_NITRO_ENCLAVE_MACHINE, .parent =3D TYPE_MICROVM_MACHINE, .instance_size =3D sizeof(NitroEnclaveMachineState), .instance_init =3D nitro_enclave_machine_initfn, + .instance_finalize =3D nitro_enclave_machine_finalize, .class_size =3D sizeof(NitroEnclaveMachineClass), .class_init =3D nitro_enclave_class_init, }; --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319118; cv=none; d=zohomail.com; s=zohoarc; b=P1yB+eK2rQf630tsFShJGkmerMxDWGeXXmPR8IZCnSA/8B6T7LU68KgmYLZEb1uP8T8p/KGSLLwD7jvXqgI/Q68ZgB2fVyHuKaykCflNASzFpdbzacivQBOYEKVFR3x+t68mmfDAtyX9HJvSAApHxPhxDe/yZZOY51oZPuEiTfY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319118; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=hQRjqUoc7vncI0l+hyaSVFOjsbZOyeIpqu/UWPsxqd8=; b=H68Q7ij3o0GY0eOHgCyGDEivZBJYDp2e5bpDlbU4Y9EnkNF8Cg8nXpPoZFzzHKRsQEt63bIkHlP5Kj7y/NCz9Wp+gMGnaz3Vq7C4cPNZH9EG7rTmMVlBSgi4Yc+IOWzol5rNuGo4yn8TawwmMydoRPbGFwJ0ukunkHnjoQUVx1M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319118679986.9464383022771; Mon, 27 Apr 2026 12:45:18 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRtB-00056y-0s; Mon, 27 Apr 2026 15:45:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRsy-0004hg-9f for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:44:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRsw-00082U-Or for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:44:51 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-82-scGLjG0uPeGo4vpIL5PzDg-1; Mon, 27 Apr 2026 15:44:45 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DBE501800282; Mon, 27 Apr 2026 19:44:43 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 508DC19560AB; Mon, 27 Apr 2026 19:44:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319090; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hQRjqUoc7vncI0l+hyaSVFOjsbZOyeIpqu/UWPsxqd8=; b=jKi/P6MUcDd1GFKwkS14DjExy5xHoLD03NSdpSJRalRMVVBEurgrBUTiSykilT8GXxaDBo rIa7ZspPLHWLB8WzytZdohd+FMO81u5/5cYVhLPe9wq/DqJvcS9Pmxeu7UsQh1a37FIu6A Ac6nEzaBUkZIsr61pRza4Zj+h4Vzuyw= X-MC-Unique: scGLjG0uPeGo4vpIL5PzDg-1 X-Mimecast-MFC-AGG-ID: scGLjG0uPeGo4vpIL5PzDg_1777319084 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:22 +0400 Subject: [PATCH 23/41] net/can: free ifname on socketcan finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-23-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Pavel Pisa , Francisco Iglesias , Vikram Garhwal , Jason Wang X-Developer-Signature: v=1; a=openpgp-sha256; l=1160; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=T+85e7xuXg9EayFeuwtfh/5N5bXTovQE7UAq/AO7gww=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wVrFjRixhuNCY+Q+nnAmVzh1gFmLm0rQZAa okmszpZ5kaJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FQAKCRDa6OEJdZac 5YJ+D/wJYhK5np4MRUDtWxcOCulAj+2vUx4Llktz765wYx+7LQEVGHj2/ejeM+MwLGE2WE9jjRy 8f5CVktT+9nodqQlnzRXqI0h8aolM2tnoUtZQGtQ6oqPEgDwzbY//8fLZUUQ3cZ0nJ8kxXSKg17 6v6KutTP6MQUNYqCoT3fLOLJyNuJDHGQCuT7VmkKBCAjWT0aSsqi889FnkMIuhEy16V50jXXU0e UtdE7L2XJnANmuCVIUZq3M23vFm/UVg+SAgnM4ZhtHFHuqC4FkFK7egu81+MTrLCMW2NmWKLnDZ Szpyp9HpyxzRnviqrSsiHFUfTFBfAGrJjF2UkjnZLqW5Gmp5mypYC20+Ocdwmn77w5X0yh2BASF uq0VhGMciP1DugO65bOcth1gA/v6RihqTJpOjBFa1mgDLcT86J7a2tQ2BgxSFIK2i5auBi/wqwe GG5lwp2D9KbSRabiN7mQT5od4hVg5Pm48ZDyAJsp7wwFFgx8OQ9CrHLXtv9PyhVF0CcciShgYD2 1ODKQEPsLupfKaOD+JreJQUTJn1JeefRQBwlW8wBdJ1cYTJx+YZhenuALrzVA0J5HXZrxEum/J+ 3R1MvR6YRFRlirx/G7/KEcyGCocsOhGPBUaIW7l0SHgZ2R4CmoRV9cfHxBv/5m5mrJBUAHm2Rd6 yJo+lpNFz3wDvbw== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319120115158500 can_host_socketcan_set_if allocates ifname via g_strdup, but no instance_finalize existed to free it. Fixes: ea15ea8a7c67 ("net/can: support for connecting to Linux host SocketC= AN interface.") Signed-off-by: Marc-Andr=C3=A9 Lureau Acked-by: Pavel Pisa --- net/can/can_socketcan.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/net/can/can_socketcan.c b/net/can/can_socketcan.c index 8a57ae07178..be67ed7f5a9 100644 --- a/net/can/can_socketcan.c +++ b/net/can/can_socketcan.c @@ -319,11 +319,19 @@ static void can_host_socketcan_class_init(ObjectClass= *klass, chc->disconnect =3D can_host_socketcan_disconnect; } =20 +static void can_host_socketcan_finalize(Object *obj) +{ + CanHostSocketCAN *c =3D CAN_HOST_SOCKETCAN(obj); + + g_free(c->ifname); +} + static const TypeInfo can_host_socketcan_info =3D { .parent =3D TYPE_CAN_HOST, .name =3D TYPE_CAN_HOST_SOCKETCAN, .instance_size =3D sizeof(CanHostSocketCAN), .instance_init =3D can_host_socketcan_instance_init, + .instance_finalize =3D can_host_socketcan_finalize, .class_init =3D can_host_socketcan_class_init, }; =20 --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319147; cv=none; d=zohomail.com; s=zohoarc; b=RQupcrA5Nd+f202amto/mTJfEAGmlMnjhYpvOHfW2NpuM+GYssa57mcHDZWxVpc0atlbvw4ADqmFlXeFNhGO7gGloxI4xlk+op5UXPDIihhrul9HFsRqxv5J1NW+vebaOLpxTdXOzgz0/4beCQ4Kem8INNryZNZD8Xjk87NIH8E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319147; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=VNI+7RuNgeguzRcMAnuOXHaYamCM21plVJM8ieUdN0Y=; b=X8lPci7ALMYhcycSrsGGR5y4mZZbyuWjwJlU1Jp0TN34KedpetzeWqlfFhhpxoUiigH3avbWA/8UFsCH1AAz7+DyjX3Y11SF6thavFSpHpx3AH3a+U7yfTthf5eaVkZHY0aC61oDcZYDMNIVXRYkGxV5bQnQ8FKrED0+xFrhUFY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319147564795.5628796855499; Mon, 27 Apr 2026 12:45:47 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRtA-00050p-2S; Mon, 27 Apr 2026 15:45:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRt1-0004iI-44 for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:44:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRsz-00083k-HF for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:44:54 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-630-EhEAy0_3OzW9-T40XtVfKQ-1; Mon, 27 Apr 2026 15:44:51 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 97E7B195608F for ; Mon, 27 Apr 2026 19:44:50 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id CA951196B8FB; Mon, 27 Apr 2026 19:44:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319093; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VNI+7RuNgeguzRcMAnuOXHaYamCM21plVJM8ieUdN0Y=; b=CiNMw02K5jt9SApjpOYMK1YAfxDJ+WVcRmrvNeyRmRmV3pm9ycJHO4ZXWXeFHsXAzmBbJ+ HeGIKwt2U94H2jIl7X5EuX8CK52wRsAiUlm8emShFSjAE33JEf6OTyp9So+gbTDUnccD2W vTRM1e7nH2VnL7LHUxSuifjhg+DbZnU= X-MC-Unique: EhEAy0_3OzW9-T40XtVfKQ-1 X-Mimecast-MFC-AGG-ID: EhEAy0_3OzW9-T40XtVfKQ_1777319090 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:23 +0400 Subject: [PATCH 24/41] backends/igvm-cfg: free filename on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-24-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Gerd Hoffmann , Stefano Garzarella , Ani Sinha X-Developer-Signature: v=1; a=openpgp-sha256; l=624; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=mwo7Gc8ngczrYSCsTlaVmEs9ndTwAzIJd46MK4vsgA0=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wVeSdX18imhdsbfAOwwyQ1PwuqS+VzC+C3k 0FQfSvHdeGJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FQAKCRDa6OEJdZac 5QPuD/kBzm4VTlQmfP0YtAtTUnTQyGhAro0LhfyngVJXxM1avfmQEN/mCeZUPM3dE9m/C0Ex36p ynNBbjGC7x5SbYPTxGvSpzaHrasuqk5CtOfoFl9pvGjtcxNDWfFlmUjjFNX+kuu4tFcizsnlm99 ePrsB4po4ga68BsCcEEe47MdTpzqMEUWFNAYkCEdzPU/6DjNWltYWdxYAIlY1IlQFjhUqKr0ViP BldQ4X97Vh1YJNdHsmIFhf1v7DnAyTiG/oTHja/KelmqG1dLhH8Y/gCbP+9yboMX0XJ/wzV4rLW 8LtwokNpA6B0Y5OXXtsk3ZLj/hK+Dze5HV92nivdtGDjqBLHwsi0NgD4S1rnsQzjrR5cl04Lo2I rNX7nN/lXWq5XbWI4QZJInoB/obdivrFklCpVXp4vhNqxoaVwASK1vefLch8TFhkLYSQOVWhCtD jdIlcsMQpUdS+ZG3WySXKklYGj4hYKLdosjkciTlPVRnTL7zJBcCXwNt0q+0V9Bfa/EdRXNUkEy R6NsCsTUNlfc2XoT3COHLpWFaAcQ4yTJJ0ko2klGkD6LSlW8b10X2Xve/ZNZVmva6B1hnsWRsxi DM9SfQqiMSYcUfEqKTnK6nWFfW0ywg94ikY+fP8jvafaxKE0MtGEpXl8QP/8FbI1MqU5Hu1XMJr yAG12J000lZSYXw== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319149654158500 set_igvm allocates filename via g_strdup, but igvm_cfg_finalize did not free it. Fixes: c1d466d267cf ("backends/igvm: Add IGVM loader and configuration") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Gerd Hoffmann --- backends/igvm-cfg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/backends/igvm-cfg.c b/backends/igvm-cfg.c index 64589ca34f2..e1f09855f66 100644 --- a/backends/igvm-cfg.c +++ b/backends/igvm-cfg.c @@ -108,4 +108,5 @@ static void igvm_cfg_finalize(Object *obj) if (igvm->file >=3D 0) { igvm_free(igvm->file); } + g_free(igvm->filename); } --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319147; cv=none; d=zohomail.com; s=zohoarc; b=KS/xs1d6YBSa3bF2hCeN57t0QC1Ve+cnLAiEmAum4/hWs2qMHYEFHrjNaZJNI2JIYS4TIfa8D/WQWSEodOmHZg5u3gz+a9O5hHBKVOL2DKSfFu3WhTkXziNQ4U2bpyLaai4Ez+rM3+6TKdXdwoNQsh3aBehuNkz8Laa9yb0LYJM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319147; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=c50C/fqcjt5STbS/kpqFqW5X5bJR7MmNwC/4fZ513P0=; b=FV5tmV+rBKOSF36JSAyIJFiV1ZvSNiKruaZaCIND4Y7VpXcqovu3udbHwIEUaV+Su5ido1heSr/DG1AVMc2GMP6b4ny6AC9lmk2HOK0ivQftR4lvI7uyMqQsSU7n4Zhn5Ti5qNvmwSCi6F6RuClfH5H97RtrF6vS+relGEqJmYU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319147732553.256140289269; Mon, 27 Apr 2026 12:45:47 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRtU-00066U-B4; Mon, 27 Apr 2026 15:45:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRtA-00056z-AH for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRt8-00086O-Rj for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:04 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-400-LNYHKle_OKamkUrb1QlVLA-1; Mon, 27 Apr 2026 15:44:58 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EA6B31800370; Mon, 27 Apr 2026 19:44:56 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5DA19196B8FB; Mon, 27 Apr 2026 19:44:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c50C/fqcjt5STbS/kpqFqW5X5bJR7MmNwC/4fZ513P0=; b=jWAkRCV9iK9NlaR1XlZXLv4ozo+IET81sOkL4h3Nt8FFmcmNh7aYKbv8wDpt7vtJfIT/nF ujhtEI0kal+c+BQOoiOEJSd9UGpfJXjoD3oQ60DHWfaUeca25VHQlqK3A8YFHuPY4Uq4tv B2WDBtXVN7DtFMz+dUCElGutuOzYCD8= X-MC-Unique: LNYHKle_OKamkUrb1QlVLA-1 X-Mimecast-MFC-AGG-ID: LNYHKle_OKamkUrb1QlVLA_1777319097 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:24 +0400 Subject: [PATCH 25/41] scsi/pr-manager-helper: free path on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-25-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini , Fam Zheng , qemu-block@nongnu.org X-Developer-Signature: v=1; a=openpgp-sha256; l=767; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=UiXn9NoTnAbA1lpC5ACGVlHyT0tT/S14loIvcqiqBV0=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wVQFo5/JdU7UJEeBDIXOPDepvW3z36FkcLa DxcwscRFqCJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FQAKCRDa6OEJdZac 5YkxD/4h/of3wW9SvwaPUQDMFt/Ci44GRCwXOeFdRMH9mraL4rl0VURNIT41LyteFBPsmiVEVg7 YtmHL+d141fDfq9btax3IhOVSNPdhk8LLtWcqEnCwrQ9SQ6ZkeNI08dn2CF/Gb0wjSKue7ePSPS fanh+8wRLszWu+BIoSjlnuwvHG2tz1QYRynsPRTnbBgWNyDQuOlhoqzQMfERPftHjwN3DSg3qg9 mbAShRlpDjvOWstC1ta9nFiNptb8ni+tzfaajCqbANEOlh2Skt76r5/D9Eg4LV47cimrxgvqZjE 08hzjL0zR1kT3D1vneQT594pJeo8EQ3zTiab69gQvCX/oSOh5T68AUVpWMosPBF8ocC2Mbl9ng6 aOklbuGb684LHB0OT2qRQEWlZ+1586jBV0Sm2s6KyWcshK/IymiS4bRICFQ/v6cnx3alFvd33ud qVeAPOR2UNvufa7bmtDtGy42pkeCKm/z62rDWMvPFV9yXowy+XRCaMhmJCJ4jrWGD7sI8sAJBFM SUm1IZZP+Fg6SWWBWljCoCL41HLpKOAYcGny1bBcpj1G9ejVDvSAqcrTP9bDamUATHcbW93VCaW 4Lyk1uzGARkwTSfLM+GM6WmY5GWZgKfhdTrGMgm1CZv2a0E0Z4+PgWH//nngE/JJ1MrzrCt3vje D4Kv51k+C/HN/rg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319149632158500 set_path allocates path via g_strdup, but pr_manager_helper_instance_finalize did not free it. Fixes: 9bad2a6b9d0a ("scsi: add persistent reservation manager using qemu-p= r-helper") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Peter Maydell --- scsi/pr-manager-helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/scsi/pr-manager-helper.c b/scsi/pr-manager-helper.c index f6454cd80de..53432e6d606 100644 --- a/scsi/pr-manager-helper.c +++ b/scsi/pr-manager-helper.c @@ -284,6 +284,7 @@ static void pr_manager_helper_instance_finalize(Object = *obj) { PRManagerHelper *pr_mgr =3D PR_MANAGER_HELPER(obj); =20 + g_free(pr_mgr->path); object_unref(OBJECT(pr_mgr->ioc)); qemu_mutex_destroy(&pr_mgr->lock); } --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319129; cv=none; d=zohomail.com; s=zohoarc; b=Im+3NvppecV5fWqLQ2o4TJQRJyYYqpn2r7J7oxR7cQsSk7a96wfzbU2UAhk1k1J6dryNVEMiIFK3tLkjjkx50O3GmP9Q1Zxdjt0qpTaMgsW43NHlo1AdwqRUi2/db5vl2/slyR8/n1hJv8A72mAtLD0aAw9UkT+fwSULqAwPzdA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319129; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=jswsE+qpixbv6iOMTTcNCxgSkRm1F5eNCKVbDRXPEJ8=; b=cWAcRcDhtylq5Xd06WwZFwrOUslq2iXGFr/pg0VWpA0zbEKfoSP8YGCNWFlCDaTVsGctUSXCQPCRCeGGP4O31f8/6vPRQ3OgRjI31Mzx3zcDMILBiYg/jL8xdFm4/GGtKhpozwvvXCC4zYbTstuYMg4trsgiKSW90ICVNzpOUnU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319129478344.4621674269446; Mon, 27 Apr 2026 12:45:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRtU-0006DM-LC; Mon, 27 Apr 2026 15:45:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRtF-0005Nr-MM for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRtD-00087C-Lq for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:08 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-99-lz-EHQIzMRC18mRq1xyT0w-1; Mon, 27 Apr 2026 15:45:03 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BFE8719560B7; Mon, 27 Apr 2026 19:45:02 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6B2D1180045E; Mon, 27 Apr 2026 19:45:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319106; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jswsE+qpixbv6iOMTTcNCxgSkRm1F5eNCKVbDRXPEJ8=; b=YYQd2AwAmx21tOQ3TjtUDUoD4Mk2su053npf8Vw/hkvE++3bwHjSWVAWlBnk2HDghDL9iv fVjSmG73Zr9Qvou8qCkZUMmDEvZMEaUsXj73qQjdSX5uSyaTtQIfkEmHyRuyr/kp0uJ9v8 b9a3Ti6gfhkK6l5XZ4hUTNsghsQcfL0= X-MC-Unique: lz-EHQIzMRC18mRq1xyT0w-1 X-Mimecast-MFC-AGG-ID: lz-EHQIzMRC18mRq1xyT0w_1777319102 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:25 +0400 Subject: [PATCH 26/41] accel/kvm: free device path on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-26-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini , kvm@vger.kernel.org X-Developer-Signature: v=1; a=openpgp-sha256; l=1040; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=kb8aCpIeuANYOHpQ9UF6rV+rRvi+Joa1R7pBjpmZggY=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wVXPLyYwKimOxS6oHWzamgH/Fh9RyoF6TkM V5JZpGSwF2JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FQAKCRDa6OEJdZac 5d70EACNGoq43OB3CaDM+7/7tFMzAAPCltI8juSVy+j+3BQDmaiciMy8bMR3VtcqDRoH55QM7xI IqP0HNxUcWeJh2XLTOBJ5hYzF/nir0jZ6tgSfu1c4sy11+ubmdXSkNzCQJs8VUQcZJp5zbFBkZU h9wDDUuWH+UpbZJ6Sm7vh5ZdOlNKEYQoCtAb6oBaa27BeQdEcYqtXFQYI+Pq0ts8xMrR0bJP12o PGMgtKvnEaFp9oR4tzjePuSx8m8kyG+591qp7sdFwzYUdawCKzTlp9J6tXqp8u0xmHjXWzUuTDl ngjv8zO0wc8g8qUu9qLSMEfPA+8xv4jIPjTHKJL6sqn8WUtdLcNKdwivbLIGeNLOKXykNT6Fa6C 1zo3UYF4Q9rN+9d0OHJgdRk8dn8uPoAPv/efVD5eZWXSK1tWxLH0bqhSjy4Rf5QD0+3N8e0a1d4 IalaY4y2lxfv5e/o8xyO/b7ctnx27/liTCmbgkuGULj8jItFCXahZt+Po6mS7Z14I6iAJUGdwxd Wguq+pOIjKJu5Kza1R8xjFXXgpUTSUCtBBlY6lVTq4CDlxx9w4s5t4k49hTurX4w7KEIRt8gX8c uxJ1w9Jo9SuXddTwQsMwzb5Yn5EYY0/tc++BnB/2qNWPzZp6LoLE46Vr96YTfex1wsMMubbuVfJ fKPAsHDnqtqFmqg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319131554158500 kvm_set_device allocates device via g_strdup, but no instance_finalize existed for the KVM accelerator type. Fixes: aef158b093b9 ("Add class property to configure KVM device node to us= e") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Peter Maydell --- accel/kvm/kvm-all.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 92af42503b1..96f90ebb240 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -4342,10 +4342,18 @@ static void kvm_accel_class_init(ObjectClass *oc, c= onst void *data) kvm_arch_accel_class_init(oc); } =20 +static void kvm_accel_finalize(Object *obj) +{ + KVMState *s =3D KVM_STATE(obj); + + g_free(s->device); +} + static const TypeInfo kvm_accel_type =3D { .name =3D TYPE_KVM_ACCEL, .parent =3D TYPE_ACCEL, .instance_init =3D kvm_accel_instance_init, + .instance_finalize =3D kvm_accel_finalize, .class_init =3D kvm_accel_class_init, .instance_size =3D sizeof(KVMState), }; --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319161; cv=none; d=zohomail.com; s=zohoarc; b=NcvKcm/pK2gkOo6NMW6wtIQeNrv36JmPBihY0uhGlNg4tGM6PSxEOUEih+v5SI+utaYJMYNQKwnIA5T66Xgkg1qKEp8sMoahVZMX7TIaNHT1jokt5b5nT+iSMyHHpLRYBcPxfxgf045jiXDfjk9OkOkVgbXhsGxanKgb5Ts8n0A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319161; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=YDtpaZFoApAnKThlAbsCdyTdSRS0TaBslbFfhxXNOYc=; b=SpX0T0VCOHMBsBiypP63XqHCbiHkBRgEkQ1pi9L0DR3H0UilDgmwRNIeVz9aiDoLPFtv9wE3tZ0hS/CZxWBVHsrlsyjTzg0H0C9LIGrLcEWB1TLecAuJkhU4EQHkcxok0NmLm6Ybw+5j6awzWHYzO7eP21y8fOuPSqgthCUHv18= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319161846235.54926311352347; Mon, 27 Apr 2026 12:46:01 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRtT-00063C-KM; Mon, 27 Apr 2026 15:45:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRtL-0005aA-VR for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRtJ-0008IW-OD for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:14 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-556-iMw9gmEtNXW4_wLa3d5IVg-1; Mon, 27 Apr 2026 15:45:09 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A64A918002C0; Mon, 27 Apr 2026 19:45:08 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 439D11800349; Mon, 27 Apr 2026 19:45:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319112; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YDtpaZFoApAnKThlAbsCdyTdSRS0TaBslbFfhxXNOYc=; b=EryZjkP2JD1+dQy3gDDbGEtPNcPtcaB9g0qCI9jMrxMKv/+lIKhG+qmDZcXTgqABejFcUf j9ldWCBGiS/d6Yu0NdNheKNal2vAkqFY4AsOjsSaVAdg+fVrpfydDrZNxq76PG9JPrkRqj BWi4+MxpOCdUuN4+6JlA6Q0fzUZ/OnU= X-MC-Unique: iMw9gmEtNXW4_wLa3d5IVg-1 X-Mimecast-MFC-AGG-ID: iMw9gmEtNXW4_wLa3d5IVg_1777319108 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:26 +0400 Subject: [PATCH 27/41] system/qtest: free log path on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-27-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Fabiano Rosas , Laurent Vivier , Paolo Bonzini X-Developer-Signature: v=1; a=openpgp-sha256; l=1002; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=oUcgYvxDMbjcVVL4+rKdZP5X8MfYcAB3srIVB+yU/jg=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wVdvi9M0Yk1HEjYko3i4AiOzhd0AUA6WlFM PcBHOgYyqiJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FQAKCRDa6OEJdZac 5aKdD/41g/ze5sZI/CUX4VbJs9QyTFQhupKv7Hg0GMP9/C9C6bNjX7eYHBykzA4vuXuQ0Ifqo5j zIZRqkL4CK+Jzooni7ymGLUHLnfIFROx6xxls9y/D1PMKcXPAYJAtC5Vwyr+/TyJjgPc9gY8H02 I1Djrsp1J1S3o6bLOq1nmzVwwXGbOEDPnacq098H9AnVaZ4dbEEL+2U2k6BI98m8dtvOpgxGNoJ eDy8Jv+xYC780qYw+tc/bl84ixLQ3X9UzExqqPkzL+bXyH2oqxkVGGBSekCcnBw6q7myabueT4S PX+9mclenH+AmGiuSIyP+XH8umCA3kHsiUVcMQwTHg7VigmsNe4x9lRAG57CUy6+SUoL5ZA3fj5 zgLOuEC8YSglSfVcU7JylutW8HLcH9z+zb9dD+ILpu2+Bp6PgJHzqBtbxm3XF+4MkZJ2BFR92h/ yuxUyT8ih5DBzarcACvX6Vpp27AIkd5yRGV7gZWRj/YXZ/DmlS9XK56Yj/1p2ROPw1wcGF2asbD pXv0nANtJBfOPpEsE8K0xZrqrtkYmDiWs2i5ZuZvNuM/6U7Jc+1tvwkbpkLgt8GlbqwviFENqxu FQMAqKS/u+dNR+43WxGq2nqk2TGVSRsWZVjQAE6fYPBKE/4y5RjPholQgRuco8G5f2SVGAf9RsX siRLzLfwkBsWNfQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319164208154100 qtest_set_log allocates log via g_strdup, but no instance_finalize existed for the qtest type. Fixes: 6ba7ada3559e ("qtest: add a QOM object for qtest") Signed-off-by: Marc-Andr=C3=A9 Lureau --- system/qtest.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/system/qtest.c b/system/qtest.c index cf90cd53adb..e9e5773341f 100644 --- a/system/qtest.c +++ b/system/qtest.c @@ -1020,10 +1020,18 @@ static void qtest_class_init(ObjectClass *oc, const= void *data) qtest_get_log, qtest_set_log); } =20 +static void qtest_finalize(Object *obj) +{ + QTest *q =3D QTEST(obj); + + g_free(q->log); +} + static const TypeInfo qtest_info =3D { .name =3D TYPE_QTEST, .parent =3D TYPE_OBJECT, .class_init =3D qtest_class_init, + .instance_finalize =3D qtest_finalize, .instance_size =3D sizeof(QTest), .interfaces =3D (const InterfaceInfo[]) { { TYPE_USER_CREATABLE }, --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319325; cv=none; d=zohomail.com; s=zohoarc; b=f8yZ6thWM8J92rjpMlUEolxnl2WYmGE+fdmt/rProis4HY0AQO/odZKO+DeBsya7Po7uisb2JHxIK5aCUhRTDGvFKHhtDuEciajhLePIoNPtSUWGKCVRos0bDa1kgECB5r2zYjz7gXlqKr1dv1BCGvjh0dxwVYxX4L9gS9qo0MI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319325; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=fVTOEc0IiI6uSpSRFYv4vHJMS6ES4xPhZF55+W0yW6Q=; b=Rn5kIf9dEtXDzxUyPkFXyX8nzUKijHR5bHVymUUlokEgC9H5F+Ppivn3zRFlaNN3UGJFt3ep2x96PGUhviXBaQK4EWLzsvIgqhCvkYnrTwAUvoiVAYmwcXBMeTdoKF0FSLvz71xYULPT4auPeeO21fXBgJKYzaBTbu5EXJOKMKk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319325371266.3455979709248; Mon, 27 Apr 2026 12:48:45 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRtV-0006KE-9f; Mon, 27 Apr 2026 15:45:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRtP-0005ic-Te for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRtO-0008JZ-E1 for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:19 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-5-_XWIiMtdN8Civ23OQsMPyw-1; Mon, 27 Apr 2026 15:45:15 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 06718195605E; Mon, 27 Apr 2026 19:45:14 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id AC874195608E; Mon, 27 Apr 2026 19:45:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319117; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fVTOEc0IiI6uSpSRFYv4vHJMS6ES4xPhZF55+W0yW6Q=; b=I7JsGtKRs+ugn4y+UHR3ROniHx2u6An60LNANDNP49Ejj/RE6Gzq+L5oTfw/H7vM6YlHKb uvsewnYRr6NuKMUI2TZiJuG8BxdmUJPsTD8kFpt8bdjtcuWS7/8GROSMUvKhr4//0wRg+E nC1RJbOODHSqmjWnGxf5//OuQU+SvKs= X-MC-Unique: _XWIiMtdN8Civ23OQsMPyw-1 X-Mimecast-MFC-AGG-ID: _XWIiMtdN8Civ23OQsMPyw_1777319114 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:27 +0400 Subject: [PATCH 28/41] hw/i386/pc: free pcspk on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-28-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini , Richard Henderson , "Michael S. Tsirkin" X-Developer-Signature: v=1; a=openpgp-sha256; l=1234; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=MMJi309YeIRVDxOCPmIe2ejVLAl8h+a+IJoTKniQZdE=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wVLJBf9rSI+B0oe3XCCh6vD74yXpagfvXIO cVXYf8T3NWJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FQAKCRDa6OEJdZac 5VN3EACwyykIpeyhUnQ0CYMUrtu+T+pAzyxXXo4QYTpGGiZZllZlHuZTSIWQRhGDTE17uvZxobF KrAcHSUj9b7A0fPyyNQ2bxdwfY/5SvQve2xuz8hyUaDlABO2tROfnRp6KO7YJYoVhN2HXRndFyk W4nMtfU1m9XIE3B38s/DhonuGcgH3Iggj6v76fY1WuO2PW7KKf5Hk9sCcovdE3h4ZrYFOvUXaZC 61kHemP6UWJlAwHUFBt1R+m9qJlifsuAnORj+zS15sicXdzTxLQi/NEunc/TttYeNSAZcA56unV otWvyzxVOgVcWw9dprKc8TiBEMoDpzYgfwA1ekCCDANs0N9TF/hKy91ZYvEG7yjvXe65SrRjKyi dhaU9BEc7qunbLKsD6pGaiH1l4KPgBmf2fuZEXsa+FBqFuS+cpoKrLd19OZxWcNcb/5/xKu3VPq DjAuJ/j6JldvzzQRpEd5KO8N27pkWtEF5oWi9QfG6za+KFH0VoF7UPWNlapIbec7qHk4UaSl3bT 7P7whEF4l07S5jkznz1wudVjgEatyHn3imreNjnPxflceyzKFqZt1o/HyK7Nwa10tpQsXywCRR+ HuY6yHkoB8EQ4EpCCX1Uoqad8I0Z25LFrCmiZ9S/DHeg8tpk+eC7CUd556VZ8v4zWRLzIu/iAeB 1rU0PMWyJSFgnpQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319326687158500 Add pc_machine_finalize() to unref the pcspk device when it was never realized. Once realized, the bus owns it and no action is needed. Fixes: 6b8d1416482f ("audio: create pcspk device early") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/i386/pc.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 2ecad3c503f..7b6ad97e5a9 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1610,6 +1610,15 @@ static void pc_machine_initfn(Object *obj) } } =20 +static void pc_machine_finalize(Object *obj) +{ + PCMachineState *pcms =3D PC_MACHINE(obj); + + if (pcms->pcspk && !qdev_is_realized(DEVICE(pcms->pcspk))) { + object_unref(OBJECT(pcms->pcspk)); + } +} + static void pc_machine_reset(MachineState *machine, ResetType type) { CPUState *cs; @@ -1748,6 +1757,7 @@ static const TypeInfo pc_machine_info =3D { .abstract =3D true, .instance_size =3D sizeof(PCMachineState), .instance_init =3D pc_machine_initfn, + .instance_finalize =3D pc_machine_finalize, .class_size =3D sizeof(PCMachineClass), .class_init =3D pc_machine_class_init, .interfaces =3D (const InterfaceInfo[]) { --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319292; cv=none; d=zohomail.com; s=zohoarc; b=cHzHDNwyRjCb7KXWLiyKxtMBlrnNVC3lZgLWBKKFpKVbtXu6Kb8NQYXrFUqZbLUL6Oa6wmjo9zNUJoKm9eDxdsO2eBNsooWn4tmNIn4yHXZRC+I7DLUy1qnSJlzJxhvu/DiTAYSzMcFFHZelmTiMh8qTnNHOSFQ2jqDzKxk4wyo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319292; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=oU4SNskSDPFZiif/NOcNoCJdXW+fc2i/XPbr9XUbsk0=; b=iosRyFSroI3n8HT4ryqHoZHMTQ/9wbBfFz9hipepoBP8YaHvICmfUbnzZPXMxftW8lM6gv6NtLL7bmKIirU7hKmS4d41z99ahExa9xaAQBh2rjm1XQ5/gKaBOFL1woMHzMRkwxl6tlG+rlKjaMet5UqbZa5+Ugz3/33GpWRpk20= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319292947617.2799792683103; Mon, 27 Apr 2026 12:48:12 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRtd-0007bf-GU; Mon, 27 Apr 2026 15:45:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRtb-0007O3-Pm for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRtZ-0008M7-TY for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:31 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-302-DZew6p90MVaRME9onTFi8Q-1; Mon, 27 Apr 2026 15:45:22 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 64BFE1800367; Mon, 27 Apr 2026 19:45:20 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B05FA196B8FB; Mon, 27 Apr 2026 19:45:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319129; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oU4SNskSDPFZiif/NOcNoCJdXW+fc2i/XPbr9XUbsk0=; b=NSavbMoTPGRzwSDClFBJydnaeFkHeeE2JSzCEOirDsDsbbSUnQVS/nKmrvpVQCKQmf1iyf 2t2mTffnoRQfYgdoB8e/hwoT4giAApLMKX2Gwq+CYvOuOToEF+y0Qli2kykNS9Sx2JybRE NFULJriShssolYHl1cgVOhphdNmXOJs= X-MC-Unique: DZew6p90MVaRME9onTFi8Q-1 X-Mimecast-MFC-AGG-ID: DZew6p90MVaRME9onTFi8Q_1777319121 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:28 +0400 Subject: [PATCH 29/41] hw/fsi: move OPBus address space init to realize MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-29-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Ninad Palsule , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Jamin Lin , Kane Chen , Andrew Jeffery , Joel Stanley , qemu-arm@nongnu.org X-Developer-Signature: v=1; a=openpgp-sha256; l=2716; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=BS8tdTzpkf4ZJcQmTy07g8mUo37sYFyz7sUGqL/kRMQ=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wVAfCGmF7+C/wG/j5UXHa8K7V/bavziGb/I 4m4DPa4chOJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FQAKCRDa6OEJdZac 5d44D/9oYfS6O6eLw30OBwOwiUXqwI+itdapJnwCWfu+Gi+CmBIiIyuATT/LL+x9PrTukg6/OM2 cBKaJT/ShE+tjzg+2g0X9oSZS2pHVV70LCBCF65nanhCL8ww4xFVXOfFd8b8Yt/lih/EeL6cA6Q 8xnfNwXGo4MkpLQPyxs9ReVXyPh4KTUHeTWyP377R3YP3OQErDTigSLlJMUNXd4wVT4q+ZuflSx aTTviPy4GVXih+ZHpgHhnPA/J+valLmY4Jhz0kytR/8A3UX7rrq13j5Wz6/zdbXE8HSQfi/mdJs YcFLjg+pox4EZwFRDsvyupY3A4iPbq5olpCIRSWZb5lMOKHiywauRmVEuCuoh4O0rHdzPq+3hFI cioO4Q8PAdQCtV1YtDEkJLpgnpnTMMBHr/ZQvAbIpU1N1LrKen/3iK+78D0dBCxAAuNwNUAGBmX OTNTow+JgHX46z3uwTiH6bUX7lZRSOyVUrUa0OT+LUO1XhYW5Ni9AZ391SXwcGa+eyDDsRGceCT nFAfI6kcknXxgg20qAhwCc//RjIwfmDoRFqM1BKIXDjMzeapojx6271IW04OZeKwbFCxCTNFcKb GuBqVEc+W1EjLK+Jc1gaGhTtV/yiqGCkG75IFs42nCzznfeLrdUo3tirD3r+ZczAylYAlLHaP51 jqxPPlUnAmWD7uw== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319294381154100 The OPBus instance_init initializes an AddressSpace, registering it in the global address_spaces list. When a bare OPBus object is created and destroyed (e.g. by qom-tests), there is no finalize to remove the stale entry, leading to a heap-use-after-free when a subsequent flatviews_reset iterates the list. Move address_space_init to the bus realize callback and add the corresponding address_space_destroy in unrealize, following the NubusBus pattern. Also fix the memory_region_init owner from NULL to the OPBus object, so the MR is properly parented instead of dangling under the "unattached" container. Fixes: eb04c35da2c0 ("hw/fsi: Aspeed APB2OPB & On-chip peripheral bus") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/fsi/aspeed_apb2opb.c | 31 +++++++++++++++++++++++-------- 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/hw/fsi/aspeed_apb2opb.c b/hw/fsi/aspeed_apb2opb.c index b9d72f3ecf6..5d1e471288b 100644 --- a/hw/fsi/aspeed_apb2opb.c +++ b/hw/fsi/aspeed_apb2opb.c @@ -282,13 +282,6 @@ static void fsi_aspeed_apb2opb_realize(DeviceState *de= v, Error **errp) AspeedAPB2OPBState *s =3D ASPEED_APB2OPB(dev); int i; =20 - /* - * TODO: The OPBus model initializes the OPB address space in - * the .instance_init handler and this is problematic for test - * device-introspect-test. To avoid a memory corruption and a QEMU - * crash, qbus_init() should be called from realize(). Something to - * improve. Possibly, OPBus could also be removed. - */ for (i =3D 0; i < ASPEED_FSI_NUM; i++) { qbus_init(&s->opb[i], sizeof(s->opb[i]), TYPE_OP_BUS, DEVICE(s), NULL); @@ -348,15 +341,37 @@ static void fsi_opb_init(Object *o) { OPBus *opb =3D OP_BUS(o); =20 - memory_region_init(&opb->mr, 0, TYPE_FSI_OPB, UINT32_MAX); + memory_region_init(&opb->mr, o, TYPE_FSI_OPB, UINT32_MAX); +} + +static void fsi_opb_realize(BusState *bus, Error **errp) +{ + OPBus *opb =3D OP_BUS(bus); + address_space_init(&opb->as, &opb->mr, TYPE_FSI_OPB); } =20 +static void fsi_opb_unrealize(BusState *bus) +{ + OPBus *opb =3D OP_BUS(bus); + + address_space_destroy(&opb->as); +} + +static void fsi_opb_class_init(ObjectClass *klass, const void *data) +{ + BusClass *bc =3D BUS_CLASS(klass); + + bc->realize =3D fsi_opb_realize; + bc->unrealize =3D fsi_opb_unrealize; +} + static const TypeInfo opb_info =3D { .name =3D TYPE_OP_BUS, .parent =3D TYPE_BUS, .instance_init =3D fsi_opb_init, .instance_size =3D sizeof(OPBus), + .class_init =3D fsi_opb_class_init, }; =20 static void fsi_opb_register_types(void) --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319224; cv=none; d=zohomail.com; s=zohoarc; b=caVTvvAWlC3gy+GZZKtegJ8eq2jSePuMjpjDkDK+tUEza/HGRba3/PASLq9zK/ytE9/T/R38ij28iOYXSVCOg/C/QexvxKGhjCxmLIKPTvFiMvU6dHyMzIRK1SCRIL63mevT2Bk49L9BBUGYFjgDeJRRlAEey535GZfWzvsOxqY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319224; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=4KHj4DqAixgKGdHuYS54zcv/K3U7GmPCNfmzT2qJpNY=; b=ivBvm8vtZasNP0wWlSFnpssnlwQGDHuXI//Mrl7Pjfjk3rWo7z3Bug+cR6XrOV0VC4oRi19oNblg5YLgaMzHiOA+N3lzSUxXP7aZYvoyrJepHWER7gUOTS6hGYSADt7if/89yzZLv7BI2e2e7Ukm26Oo+cpPpu2o4GpRcaaNHBg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319224606830.9267413277972; Mon, 27 Apr 2026 12:47:04 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRth-0007wE-DC; Mon, 27 Apr 2026 15:45:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRtf-0007mG-6z for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRtc-0008ND-SN for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:34 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-522-xZiJ-uQyMDCxZMmiLV_ZfQ-1; Mon, 27 Apr 2026 15:45:28 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C42C0195606C; Mon, 27 Apr 2026 19:45:26 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7B483180045E; Mon, 27 Apr 2026 19:45:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319132; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4KHj4DqAixgKGdHuYS54zcv/K3U7GmPCNfmzT2qJpNY=; b=C3lHIV+oP7m9d7Z+LlXaukVExa2UNek9LeewYheemZGctSOP0IDIyuAILDFj4p8LLGTf+2 KyvmPcMerWVGILbm1NcUm+jfHVjoGhSfkD5UXbIRTZZVC1dR60g4XC5ocWIzDqXelS/sUe 1UByROZtBMzD3EbB/SUxLvD/wXuFRLY= X-MC-Unique: xZiJ-uQyMDCxZMmiLV_ZfQ-1 X-Mimecast-MFC-AGG-ID: xZiJ-uQyMDCxZMmiLV_ZfQ_1777319126 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:29 +0400 Subject: [PATCH 30/41] hw/gpio/pca9552: fix state_str leak in pca955x_set_led MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-30-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Glenn Miles , qemu-ppc@nongnu.org, qemu-arm@nongnu.org X-Developer-Signature: v=1; a=openpgp-sha256; l=823; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=3S6fSXjyZtEol8E2g5mMSZCzx5rxZBsHBZ3CL9TbmuI=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wVK0C4iwVzskgkTX0g6J8GOfDk4Lj2dMQhL 4AV5EeTFvGJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FQAKCRDa6OEJdZac 5VHpD/9YHfDTPdbCHzUL6KTtqT0i/O/aHZyHqX7yD4Ha0REqGtpXWx47X3ryM9XRoxJamQmB/3y dRyMB1xcwSkelCHeK7Z6dXvRFfzQZXRFmM3+XpJRI5/H4f0JL7yigKGb7jTipSgYzhq+ugfQms3 USgNG4zcM6VGQLfv9NR6GM5vCluwgHl4ktZaO3usjCC79SwUTry6ESajrYg4JvYID/HWB/ekC1y M7cn5VjWvAFgaPJ6V9hkEystqETGOnpqoKcSjd1+yq/jnPL1ZiSfRbAi/kUYvoJC2fdAXVIhkpw coiA/8U2WfuWzb21hkG2Lb82Yvks7GhdNxUV+qkttbTYWuNaX7DeUq7IABFMy67adCS/qTBiAJZ SaPVZvtRfdGlNi3ZzhAyHXi+fBjY7CMDPwzK7PYfTfQj3eYMq532hO4N+Au4FA/JyzH+QH8tbjS P+ESBFuHlScLIryYBVVDB7c3QlfA2vIhbXILUVfI9Ms5XfnzCqNb1/gPdTDssNvbXRv6NexlExo Sohd+C1Uvj3gPJz8q1X07X5slARIlUCEM3xDAJB+8lLrj+ueyBGHtq5/ZaAJ8G0MTHKtxTGfiUm XOSSb1b/n5Qle6/MXuyiy4spVpzLB7bR/WJ7+Tq22Ob5wAgvPvL4EKBmFbghsT4Z7E5UzrIExiJ ioDNpKJD2mgzakQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319225341154100 visit_type_str() allocates state_str, but the function never frees it on any code path. Use g_autofree to ensure it is freed on return. Fixes: a90d8f84674d ("misc/pca9552: Add qom set and get") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Glenn Miles Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/gpio/pca9552.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/gpio/pca9552.c b/hw/gpio/pca9552.c index dd3f1536b65..472d8ad9571 100644 --- a/hw/gpio/pca9552.c +++ b/hw/gpio/pca9552.c @@ -342,7 +342,7 @@ static void pca955x_set_led(Object *obj, Visitor *v, co= nst char *name, PCA955xState *s =3D PCA955X(obj); int led, rc, reg, val; uint8_t state; - char *state_str; + g_autofree char *state_str =3D NULL; =20 if (!visit_type_str(v, name, &state_str, errp)) { return; --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319293; cv=none; d=zohomail.com; s=zohoarc; b=Nk/tezuaX+h+PlB69NszSZh0r57RPFWLrLErxvMIrRkCsw8fLB58XDgIOnYH+10tkAABeMoBqIfk8BoT/WmixWE3bzxWtmjKEyr7aR7sJG7CSZ779pvy+ldC7gCl6lW/6u7jQ/lwZaHm11r9iF4g0SihbAOnlpZu1Zezq6srrZ0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319293; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=TrJVVZU6/Vb8qTLcl1rdJM/fVCkqBrqY+cxIoO1k+u8=; b=Z+xNZNdgSmAT8USM2HpM/hy+M9BhxzUqracoEKimj/0oYw4v3NQ2v3tpplyR6gz0eYq8MdnP27jT1peLWleUJVzirDEn0Skf7KIvl5jkq3Rpydkh7lvuabF97z1On9ASbKL6AZh+FdMw5YJ2U4cTqgm7g3/VEbnYu31je+i/ujI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319293592536.9481360520542; Mon, 27 Apr 2026 12:48:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRtm-0008UR-Al; Mon, 27 Apr 2026 15:45:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRtk-0008IE-8M for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRti-0008Pp-KE for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:39 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-400-jdhpb1OVPYiS51WHP1gnmQ-1; Mon, 27 Apr 2026 15:45:34 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EA0E01800EC6; Mon, 27 Apr 2026 19:45:32 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 137BB19560AB; Mon, 27 Apr 2026 19:45:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319138; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TrJVVZU6/Vb8qTLcl1rdJM/fVCkqBrqY+cxIoO1k+u8=; b=WXitdktzg5/WFxeTY3l73tOfaHPObzCi3EeKw4OjBPtmp7pHXKn1CEkKOm0vUror+HnmtD OQAaj5BhlvcPjfh47HqNa2iL3qhcTHHHeAJfalfVZWIP96A6cc4kkXa2LRMPL4ygSXpAqk 8IXfI7Q6jwyC13DJpH8yiwvjWoNS4ik= X-MC-Unique: jdhpb1OVPYiS51WHP1gnmQ-1 X-Mimecast-MFC-AGG-ID: jdhpb1OVPYiS51WHP1gnmQ_1777319133 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:30 +0400 Subject: [PATCH 31/41] hw/arm/aspeed: free fmc_model and spi_model on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-31-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Jamin Lin , Kane Chen , Andrew Jeffery , Joel Stanley , qemu-arm@nongnu.org X-Developer-Signature: v=1; a=openpgp-sha256; l=1317; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=QmEwAllDpvGZxHEBIiH8j7FQV0Uib/7g87F76P7ZxvM=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wV9VjLQBf/gHgH1FKdJL2Xn8D2iHAdgciYJ l6K3wXMshKJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FQAKCRDa6OEJdZac 5c4sEACZaigFcm1E8MQN8NsoAQIovauBv5iv6cFaus+D6+fU767G9Zs7kc0nr2iWWVRFTuwGzZk YqNLBe6id+Pf4E7m+zyPMXbYLe42uqgSKXkSQEkSvayCrp/+W+33mHJLzeJlw2ZS65DsAuKwn5e W8xXmODioL8/X1lYcCLmXWWFLaf5R5KbkVyFFjJX7PzdLlnXf+cxdmuqYlBqztrDf0StboLKIgf 7osIkojRoMkWIegtouNvidYKxLPfc2qKy+Df4Xp6VdC1mM3sXDJ8TqL8iTLr0i/6/gBejWCiTwj jJ2h1imxulmhxr4Dl9eNyeT2VprRCzb+xPlCTE7K75KpeBSm0QZURjISalPzLkybi80WuEu+tGC U3fGZvwrY6F1zmDeMJNQjIOu5HDy/oH/uMmlGBSxcMKfeceUWkc1wA2J96Eb0PBVU6tFcLdfNId 7PZzcZkUOmrBQvKVZ/IKgOKIL3YtBnYehLHTqPwQL4OeGuclVFCNXzuW5bTLjMiETtFOm6vxizg 5MUe3Y1qjbknjVb9FBNk05dws6rIYS0NpHGWXWu+7cwNCUZTnpBquPk4Glpt/ENe7G0BJXmB+1N phiEMzPZnmLd2q8xtF7tG95fYvHZwFAKcNsZQ2N0GmLDOLjp6P+MQ6F7XrnKmJXFt1rmGl7Qw+i wFsKC+lZ7QfVI3A== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319294461154100 The fmc_model and spi_model strings are allocated via g_strdup in property setters but never freed when the machine object is destroyed. Fixes: 9820e52fbef7 ("hw/arm/aspeed: Add machine properties to define the f= lash models") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: C=C3=A9dric Le Goater --- hw/arm/aspeed.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index a3db3406c5f..a48c4420583 100644 --- a/hw/arm/aspeed.c +++ b/hw/arm/aspeed.c @@ -419,12 +419,21 @@ static void aspeed_machine_class_init(ObjectClass *oc= , const void *data) aspeed_machine_class_props_init(oc); } =20 +static void aspeed_machine_instance_finalize(Object *obj) +{ + AspeedMachineState *bmc =3D ASPEED_MACHINE(obj); + + g_free(bmc->fmc_model); + g_free(bmc->spi_model); +} + static const TypeInfo aspeed_machine_types[] =3D { { .name =3D TYPE_ASPEED_MACHINE, .parent =3D TYPE_MACHINE, .instance_size =3D sizeof(AspeedMachineState), .instance_init =3D aspeed_machine_instance_init, + .instance_finalize =3D aspeed_machine_instance_finalize, .class_size =3D sizeof(AspeedMachineClass), .class_init =3D aspeed_machine_class_init, .abstract =3D true, --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319344; cv=none; d=zohomail.com; s=zohoarc; b=lxnAe2YHdwprzuPORnlxushIcJimpd175YxI47+Onp1QDhzD6hdBC+M7rSzXm2oKmMA2PdHHmdfPGU5zchhXNd1/HG+pnVWSwjdk4i3+0uDoqPJbADSDBRlUFFJHpP7ftJE6P9WfpBJ7VBrmxY+GTG9xZwLpb7bXoGonLHLi4Mc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319344; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Zwr78nSyzsd0DrKYZjmxnd5WP2JnUPCWfhydW/PE7V4=; b=VUt8EvEF3g9yNa1MoB21LT1CD8txpRgPIgcEM0ApCFz7ldTvZeD4JOgsn2+T20z62QA96m8LXrRC+RHfzDW8WOAmxVVIJzb4QmiUiiiRMCwbqOxvm409mDSPLDLSTkXLm1bDU2OjG4atNYBwnnqPZSj/cA6pGlYQxfBbgX7Bym4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319344540214.9333035586642; Mon, 27 Apr 2026 12:49:04 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRts-0000sB-Av; Mon, 27 Apr 2026 15:45:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRtp-0000Xi-Qw for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRto-0008S2-CB for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:45 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-375-3VYbIdaWPZuPSMTDml-vpA-1; Mon, 27 Apr 2026 15:45:39 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 09F9E180034D; Mon, 27 Apr 2026 19:45:39 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0A25619560AB; Mon, 27 Apr 2026 19:45:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zwr78nSyzsd0DrKYZjmxnd5WP2JnUPCWfhydW/PE7V4=; b=Ys4DuV4iNqd9xgEckAUwPGosNp389MwQPkXj5HMTIZs/JqBLOUJxcfywPGhSVNuRNM6vnF yIhj+ucRJ/nQP6KAwi9EmjPsBzQ5WjyiaesBpCb6ouuB072OOzwV3WQX8OVQPaA9ETQkA6 tc5Xt7qzeoxpU+Z8GfjPVAK+XsLZEoE= X-MC-Unique: 3VYbIdaWPZuPSMTDml-vpA-1 X-Mimecast-MFC-AGG-ID: 3VYbIdaWPZuPSMTDml-vpA_1777319139 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:31 +0400 Subject: [PATCH 32/41] hw/tpm: free PPI buffer on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-32-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Stefan Berger X-Developer-Signature: v=1; a=openpgp-sha256; l=1258; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=U9Mzlvq0rrjlmHM8sXAmGAsGCpP4e3dRZe1kgmOmuHM=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wVDJwLi20apizk6puKvICJAKyj3t1kRPDZ3 HhkiYxNrbuJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FQAKCRDa6OEJdZac 5Zz5D/91pAuelqe9FJFUKfA88vofp5pVr+PVjRqjfFbDYiXdq6pmbbzfk3OL8U4pAxbzMFNGl1k OG4wkTO4SVOICrWW94i/hKDB38BBypqupIfbi2EThhyrTaWqnnjEewNgfpBqog2hEPVK1bXN+1D hiD2Dsm8enOevm6LMObEa+4AZrhOTsLz2QGoVNtSY5fkQ/vcgxMnkLjCP2yzHPSBndmYfHRy7mC APPTamZf+la66ZcuVfC42RrJGkl51NZ0cAZTjMjzdaq1fh4J+qOzemOywGBk6RtFkjhMEKaRQWq qz4acAexpo31TFMUoBO2dJoU8hm5TatkCnbKZI0qA4wWWpWlV1S/ByW9vXG586bHv8XmfybzD12 b1xhWTCqMYu9DMw4PahmFBTq1lCdh+3/37KwB0GBxYcUU2p/prJzDvk0vTfRkH1S/Nd9sHit/GO tKKRcwlwmoyIQxrOTT9Ly3x0aYnZUGMsoKyoNvUtKQQOA1PhAec1ycfj2sT2ZDZpDHhEkKvE2/b ha0xvP31EG7RPpOW//3uX2MFPNi00vZ4DuhlnN0V35rhCU1MzXU43BZtqPmNwp2wlCFPt4yWR24 edEs5GynMqQeV+HHnJDEGyARvDNJe6Ek9LPEhDO2ozCdQKiAI1E/ABOF9IgkcZngMbV3+VY1pHk gOL9WKSAD4EsKIg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319346695158500 The PPI buffer is allocated with qemu_memalign() in instance_init but never freed when the device is destroyed. Fixes: 46cd2c1050f0 ("hw/tpm: add PPI support to tpm-tis-device for ARM64 v= irt") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Stefan Berger --- hw/tpm/tpm_tis_sysbus.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/hw/tpm/tpm_tis_sysbus.c b/hw/tpm/tpm_tis_sysbus.c index 6bec30c36fc..891766ee03c 100644 --- a/hw/tpm/tpm_tis_sysbus.c +++ b/hw/tpm/tpm_tis_sysbus.c @@ -150,11 +150,20 @@ static void tpm_tis_sysbus_class_init(ObjectClass *kl= ass, const void *data) set_bit(DEVICE_CATEGORY_MISC, dc->categories); } =20 +static void tpm_tis_sysbus_finalize(Object *obj) +{ + TPMStateSysBus *sbdev =3D TPM_TIS_SYSBUS(obj); + TPMState *s =3D &sbdev->state; + + qemu_vfree(s->ppi.buf); +} + static const TypeInfo tpm_tis_sysbus_info =3D { .name =3D TYPE_TPM_TIS_SYSBUS, .parent =3D TYPE_DYNAMIC_SYS_BUS_DEVICE, .instance_size =3D sizeof(TPMStateSysBus), .instance_init =3D tpm_tis_sysbus_initfn, + .instance_finalize =3D tpm_tis_sysbus_finalize, .class_init =3D tpm_tis_sysbus_class_init, .interfaces =3D (const InterfaceInfo[]) { { TYPE_TPM_IF }, --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319169; cv=none; d=zohomail.com; s=zohoarc; b=JQN3gMgtykce1mPSvG4uwCp8jucFgE7dhXBoSkvvJ6ctZXLTUHoh7bH65+GW8FHDjUqhWvcdxVJsv4W4d/ClAIogxLC8UUHL3Eg61MLDeB0+rt0hbxH1XX96NXQet/6vILVbSPWcihAlz3ZjxqjwAkEM5OSu+SWsX7EHRT59Dkg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319169; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=M2PkMqAC5vaH2G5gTELChNOqj8Q/G8/EbVxLibW6cbY=; b=kslcola5yTznra0ZWSn0lPgRaUKcFscYfYqtZ8nFyoMnMM2UVUpVdH9GQo08KTdLS19onKhGT45O1MD2cdWfCvnsPCZWP2BzPtJB+Da7q2oS7vw4QeU2wYt7cIgeLmv4i8mmBdpG48l8UCG1bL/42GG8QtyMwl3H0XdVSpYsR7w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177731916958931.43023952551198; Mon, 27 Apr 2026 12:46:09 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRtz-0001hk-Mz; Mon, 27 Apr 2026 15:45:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRty-0001a0-1N for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRtv-00008n-Tg for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:53 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-556-_eoWI6QNPJ-W5oCIJLgS-g-1; Mon, 27 Apr 2026 15:45:49 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8302A195608E; Mon, 27 Apr 2026 19:45:45 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id EA00330078C0; Mon, 27 Apr 2026 19:45:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M2PkMqAC5vaH2G5gTELChNOqj8Q/G8/EbVxLibW6cbY=; b=NxjvNPvctK0kk/qPwmKQcJdlz/WKoAi6fFeu6KjE8A5+/4I7MwtnsIgPyM0dOolM7/jxRI 3s7Ey8IXqRX2p2sFjn44r0H+SshgeIAB/BUlw6E6PTpzz1aYbGR+TN0oFSQ4B/mRb0u01Z CgYnzqJXcXbdZofa0DjDa93Z3jLZmgo= X-MC-Unique: _eoWI6QNPJ-W5oCIJLgS-g-1 X-Mimecast-MFC-AGG-ID: _eoWI6QNPJ-W5oCIJLgS-g_1777319145 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:32 +0400 Subject: [PATCH 33/41] hw/arm/sbsa-ref: free unrealized flash devices on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-33-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Peter Maydell , Leif Lindholm , qemu-arm@nongnu.org X-Developer-Signature: v=1; a=openpgp-sha256; l=1629; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=8wpYSEdYwoIU5tUZLybA2hUuHMnCp+KlNmMB/+ET4dQ=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wV06CFj7hU2c0ZsBhZ0KcgP4PY3RTTUXEPN bRTQukYYHqJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FQAKCRDa6OEJdZac 5eBIEACXMPEDc3nHnUDB7r7nxHaJQV7rnZW20f4A9ijvHe1etzhDlhofGT9nPrC9rOpd1x1ZbI0 /82NqaELAEkcGEsU7U8xj7AYdKjPeoJG4/On99rxa3gtAptqfo84oHPEqV/PLmef1ghkA6rMDvQ t5wZWe2taCU3Xztf/bgENfdp7xq1meGpXdCzvT2dNC8800yc4n903es+6DJiL1H8jJBrKQoJ/SY sa26dFWazW4YkDx2pgCLtdJWt3aiK0LyVN9zlsLlHhKKV4kBLHQURLxJ1i10/oUMGLOTuEUkg0W uv9loq7oSH25EGtvVMSfFGIaVi+5zB0iL2lD7OW3am56GOT5y3yEaPt3Yh3QK9ExvNnMf26wT6b M0KsLYQqc3sZImyvd/VaN7uj2XXtOd3k7A52kUjr6aA1duMo/LddkHqIPTlXT3qZ5azcXPkynZc kb3zaSfiKnZlI0nNS7x9GmnWG4DKiHNHmUaR9g38u5Y1kzQgnn7ZvvyeU9CJJW08F2Jf8OUgI9X Ht7+Vp18PFksUIc37C2YJ4iTCJldw2WIIHMHNWkZE+f9g57DCzOpuVMqHn0EtQGJQLOVhxvKmNC zdkE2e72gujIwCbvubhl+oW+paYXtWNQSy9uYt/CNPjbizGkSzn3XA9R+lxTLLK2MuPFYK0nDGu dRo/021qlK179eg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319169726158500 Flash devices are created with qdev_new() in instance_init and added as children, but the initial reference from qdev_new() is only dropped by sysbus_realize_and_unref() during machine init. When the machine object is destroyed before realization (e.g. during qtest device introspection), the flash devices leak. Fixes: e9fdf453240e ("hw/arm: Add arm SBSA reference machine, devices part") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/arm/sbsa-ref.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c index 52c35e10c2d..484b90053e8 100644 --- a/hw/arm/sbsa-ref.c +++ b/hw/arm/sbsa-ref.c @@ -892,6 +892,17 @@ static void sbsa_ref_instance_init(Object *obj) sbsa_flash_create(sms); } =20 +static void sbsa_ref_instance_finalize(Object *obj) +{ + SBSAMachineState *sms =3D SBSA_MACHINE(obj); + + for (int i =3D 0; i < ARRAY_SIZE(sms->flash); i++) { + if (sms->flash[i] && !qdev_is_realized(DEVICE(sms->flash[i]))) { + object_unref(OBJECT(sms->flash[i])); + } + } +} + static void sbsa_ref_class_init(ObjectClass *oc, const void *data) { MachineClass *mc =3D MACHINE_CLASS(oc); @@ -930,6 +941,7 @@ static const TypeInfo sbsa_ref_info =3D { .name =3D TYPE_SBSA_MACHINE, .parent =3D TYPE_MACHINE, .instance_init =3D sbsa_ref_instance_init, + .instance_finalize =3D sbsa_ref_instance_finalize, .class_init =3D sbsa_ref_class_init, .instance_size =3D sizeof(SBSAMachineState), .interfaces =3D aarch64_machine_interfaces, --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319221; cv=none; d=zohomail.com; s=zohoarc; b=cALjIo/RdIDY7MowLQQpEaIWcShQ6T9BJLLaefYeb48kuHu8k+ot29xSnH5sf0IFDoq9Z+8JbZWeeUpJP8i9U75VM3MmSAIL9XI8GYl5V2NWx/ZWtB4/Gt2pFI3Ke6vRVMa4zCqA0vXy3hu8eu3uA2WH4OB9IW9t3UMvNWVJ3lc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319221; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1c8VsTz/sTG4tzp9Faceii6mKYJmoEBKWa3DjmDQEWE=; b=NPBEQAmM+yqhA8gA7u92i3L/nwQg8cQR79K70Yk8k5v23elOojUXH+24HvM56tPJM+54knfC7HCdiusbibmCHcZ/9Rd+OcKZUx3IDj2Ai1YvZW8ndqI8pHzl2C4Tlt6bwbKNd+V7JpttQsuarIuYCSzzrokOGEtOfJxCK/dB20A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319221532786.1020856144091; Mon, 27 Apr 2026 12:47:01 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRu5-0002KF-LP; Mon, 27 Apr 2026 15:46:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRu3-00029E-M8 for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRu2-0000AS-7U for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:59 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-175-L27mdzMwMXW_UBxAymJhQg-1; Mon, 27 Apr 2026 15:45:52 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 80B53180065B; Mon, 27 Apr 2026 19:45:51 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 04833195608E; Mon, 27 Apr 2026 19:45:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319157; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1c8VsTz/sTG4tzp9Faceii6mKYJmoEBKWa3DjmDQEWE=; b=Wmd+6lx8wSGw0mmYKzeE7L+VtI15wFRghR01JPd5gtjQo008T2dq1Urqpyd/v12qlDG+6B EOTJ1pKE95LCVTJm6nDQ7Xt3dYUrGLa9iGCRluD+Q04lt3yfVivUxOzuQeB251GtCB9iD+ obuYHJtURkfChUtK5rlOCxQ5uFQ1bHA= X-MC-Unique: L27mdzMwMXW_UBxAymJhQg-1 X-Mimecast-MFC-AGG-ID: L27mdzMwMXW_UBxAymJhQg_1777319151 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:33 +0400 Subject: [PATCH 34/41] hw/arm/virt: free flash devices and OEM strings on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-34-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Peter Maydell , qemu-arm@nongnu.org X-Developer-Signature: v=1; a=openpgp-sha256; l=1638; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=o92YyJD/bOFOENYE87KlzSXzoL53pQjL+BGFBW2kk0s=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wW48UjKTU8KoPx74n2xI5CJTczJW/EUjYlC R3ZW1ir2jmJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FgAKCRDa6OEJdZac 5WoWD/9dw9rvRCWsv0ETBfKlzGEEGcrQO1E77pa4/nW2MaZjxOBMlucGXfhnDoQBBMD4PVg8I9z f02jLPGBD6CN8wQcbCkG24hYz42o3oxxu7fb2Vbhklx+U4aH5HnjnTPA7darMNvF6NTynKIdqXQ +Fdrs1fbQKScqWWRQ5Lgg/gOH2XFAKMEebv0B+2lN0pbU5/c2ju6CR+IeoL1hjtGfAsjELlTAb3 J6u5gAIWdWRq3GsyALc3CLeWy+xAUP7q7FYXvETchMa6rkpM7BEIbW7YVnXipqwZEw19bpjrRxE xHs4OdrK1Ei1AeavuXn2ZDpSkWw0NVVaoYuAXENLYO74j4DbF9zPAMnXO5iFJ9X43DsaqBZOXZx Y6XNAcchBzGg24RQvz9YB2xlL/bMCylsdzDZFtDAvO+q98SOnh0qop2MFpTGTeSkCGPvfmFikwv M7cF54ulM5wpU+rYmlwekDKJezkDNw4P4psluQeDwau7v+jrQQAAdq1THoMrPr+PHh6wISNpEXc AOoLaO6fq2Xyeh2BSBtnhKqk6j9h1U+NAS+YkSKfkaAs/8rPh9aL3POG2rkXPWEYnLLpSlbpvDG wOIXVlM1Sr68v54HJVNOf0Lz9bCRYimvm1X2RpcAETQwzAKiqM3NjASLoNnRdh5sr7tB9BDH9Jl 9VwjIDwjIxrEeFw== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319223111154100 Flash devices created in instance_init via qdev_new() hold an extra reference that is only dropped on sysbus_realize_and_unref(). When the machine is destroyed before realization, the flash objects leak. Also, the oem_id and oem_table_id strings from g_strndup() are never freed. Fixes: 602b458201ff ("acpi: Permit OEM ID and OEM table ID fields to be cha= nged") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/arm/virt.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index f62253e1aba..fac825ccd47 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -4032,6 +4032,19 @@ static void virt_instance_init(Object *obj) cxl_machine_init(obj, &vms->cxl_devices_state); } =20 +static void virt_instance_finalize(Object *obj) +{ + VirtMachineState *vms =3D VIRT_MACHINE(obj); + + for (int i =3D 0; i < ARRAY_SIZE(vms->flash); i++) { + if (vms->flash[i] && !qdev_is_realized(DEVICE(vms->flash[i]))) { + object_unref(OBJECT(vms->flash[i])); + } + } + g_free(vms->oem_id); + g_free(vms->oem_table_id); +} + static const TypeInfo virt_machine_info =3D { .name =3D TYPE_VIRT_MACHINE, .parent =3D TYPE_MACHINE, @@ -4040,6 +4053,7 @@ static const TypeInfo virt_machine_info =3D { .class_size =3D sizeof(VirtMachineClass), .class_init =3D virt_machine_class_init, .instance_init =3D virt_instance_init, + .instance_finalize =3D virt_instance_finalize, .interfaces =3D (const InterfaceInfo[]) { { TYPE_HOTPLUG_HANDLER }, { } --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319173; cv=none; d=zohomail.com; s=zohoarc; b=OMVEkacIFBR+RXUPZK1EmgVNwgd/ApDuLuIK9VAbXgLFAL8nM74pJHTD0+Loe4OQBksw5vQmnK/MAbXiVz1Pqqgvu+Vlzi8We+VhAb2ShI+gszsWJs+H7vKFePxumXJeJmsIEYQfSM2C/wQ/gS5QGBmTtu/OFRmfzX+KtuLnFiw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319173; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=7KmAH1cH3IHfFz390iyZWiA2Urz4yiNrRXozv9253eI=; b=Gmz6nJbtJB/pNAK0asy0kjm+e5FclEzVh7kRBb5KyxcR0Q8kjSHO2hJQXvbQdbaIXzHG1HfkNKB6gRtSWt6xLuN5mJgspAn820ipavyHaJHtYScfrKF0vnw+zuO3jhQWb8tVYsPme1CXVY8kHP+YSWEHSzD059lh9iIA3KXx+y8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319173538868.686371972797; Mon, 27 Apr 2026 12:46:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRu8-0002UZ-Qx; Mon, 27 Apr 2026 15:46:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRu6-0002QZ-Vh for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:46:03 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRu5-0000B4-F7 for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:46:02 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-528-N2PSMl7XO-KlPkVH-a3LGQ-1; Mon, 27 Apr 2026 15:45:59 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E46FD1800245; Mon, 27 Apr 2026 19:45:57 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 90858300070A; Mon, 27 Apr 2026 19:45:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7KmAH1cH3IHfFz390iyZWiA2Urz4yiNrRXozv9253eI=; b=LblhJczXqqc7kXRh4zpZE0KVFyMZ1c+Og7o4/4+LG1BHAwQIO8CEAwUuIgb7U6GOAKQVN0 G+4a6y7KjOIooGz2oyvwOtgLmjxlzEQ3B/iHwVIMFTjNZX1zHu9BMTNwo1FrlG3JOvDzmM QlBKPc38JUqJ05lk+EV4qryhAkD0a8E= X-MC-Unique: N2PSMl7XO-KlPkVH-a3LGQ-1 X-Mimecast-MFC-AGG-ID: N2PSMl7XO-KlPkVH-a3LGQ_1777319158 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:34 +0400 Subject: [PATCH 35/41] hw/loongarch/virt: free flash devices and OEM strings on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-35-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Song Gao , Bibo Mao , Jiaxun Yang X-Developer-Signature: v=1; a=openpgp-sha256; l=1735; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=dxCTCxNaCfORhGdQQtAC7ccm1POGZcOgxYtSD5YETCc=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wW+05ardbd/hj7Op+m929pAm4FEmkm9Ust2 E8ltKtHXE+JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FgAKCRDa6OEJdZac 5RJjEAC4Ifcaa17MbvTtqopgNgrGGBodzZ4MuMz7lEs19qyQ0UUYrCsD9GZoAmK158d1+dJcqro pLB6wS6jjTr7L2yoyLGDox/I4yMg0/4YQr3RLvYx+IDNTA/kQ3V7h3870AOQ5qRXaOfZth0rcC8 o7TxUwUZ5lqbV+sMsH26AEUPjuRf2ecduQ4inG+K0agz6+I3z3Ry123sQ2rGvUp7YvpAtpNCtxB JyCKb6hlcXVx2EDVjZW/lgSBIYqYcDHPKJkadQBudDpYvrtpPdGMX9mlDq/GUdBT4x1TnjLsrmz u/Z+1RRtif7fsatjHXpMCB6mx00RnvI8lGnQ9Aeb044XuWu/d9bHDlRUY0oySgGJujeWW8g2a1U zkfbdCgAlFV1BZu3f5DQ5KhoaT7inHPWcJ5BPObGv0Sa6EmUlLjVxS0YqItjZx46h/+OgbOU3E2 dDs2F/zVvfzI5H6KW1mXmgstTcOKE6i9+wiNfGSfr+8MBtv+YbemIOQVa9eA1agvhGxc4XfwsV3 f4+rt1dP1ORwUmp5L8xV5zmM4Lq1y9iT/El89a+k9cWaI1jbbvW64aRQK2eIiIOHq2b88+EL4sw 9uAVmCUK1wv7NbiekLXOvNqtqAQmCdNOPLOC2cED4Ok+3Vh0TMYg0BVzFiaEwO0xEnUJoSCq2c/ aWVqWlWmGnBLplg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319176662154100 Flash devices created in virt_initfn() via qdev_new() hold an extra reference that is only dropped on sysbus_realize_and_unref(). When the machine is destroyed before realization, the flash objects leak. Also, the oem_id and oem_table_id strings from g_strndup() are never freed. Fixes: 445c9c645 ("hw/loongarch/virt: Allow user to customize OEM ID and OE= M table ID") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/loongarch/virt.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c index 2fc15261309..188fbc86c0c 100644 --- a/hw/loongarch/virt.c +++ b/hw/loongarch/virt.c @@ -1535,6 +1535,19 @@ static void virt_class_init(ObjectClass *oc, const v= oid *data) "for PCI MMIO"); } =20 +static void virt_instance_finalize(Object *obj) +{ + LoongArchVirtMachineState *lvms =3D LOONGARCH_VIRT_MACHINE(obj); + + for (int i =3D 0; i < ARRAY_SIZE(lvms->flash); i++) { + if (lvms->flash[i] && !qdev_is_realized(DEVICE(lvms->flash[i]))) { + object_unref(OBJECT(lvms->flash[i])); + } + } + g_free(lvms->oem_id); + g_free(lvms->oem_table_id); +} + static const TypeInfo virt_machine_types[] =3D { { .name =3D TYPE_LOONGARCH_VIRT_MACHINE, @@ -1542,6 +1555,7 @@ static const TypeInfo virt_machine_types[] =3D { .instance_size =3D sizeof(LoongArchVirtMachineState), .class_init =3D virt_class_init, .instance_init =3D virt_initfn, + .instance_finalize =3D virt_instance_finalize, .interfaces =3D (const InterfaceInfo[]) { { TYPE_HOTPLUG_HANDLER }, { } --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319210; cv=none; d=zohomail.com; s=zohoarc; b=YKu9d0mtXvVBUyMZN1EmxbpWEBQ+HTrvcAJs2/4hGnVVIz5exMRAHae2v7KHSMoS54GEVOvz+llkGXV1cYc0etoaZpLe4/LFm9WG9TNFGv5lS2Qz5Bg/BM+nbbrk/Su8/4YZw0UjJFT0klVpFS1k1X6Z2/7fAj/Oisq354fvGz0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319210; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=cwyJtVk4gZDCf3olCQ+pCOZAHvZnX9kcneYgWVf/Mnc=; b=DEDPrYYfb6WOFM6F7+TzfBYxqHxO9By+gMOkdWwKHacUqjqH09s3nZ2wPxBedhYkTmzra/NEsA4yucCrOzCdj/pWnkTPHMlGfeEg8VLjN3YGv+wt1W46wWwUVE97S5UUe1HU1eg5ztzMKPAG2tWeYMqpsp4AD8mAG0qyG6bWEa4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319210004640.5623871638302; Mon, 27 Apr 2026 12:46:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRuF-0002eY-TM; Mon, 27 Apr 2026 15:46:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRuE-0002dt-8n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:46:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRuC-0000CF-Rk for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:46:10 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-2pOS_qvENMalQJvoj-_60A-1; Mon, 27 Apr 2026 15:46:05 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DC89E19560AA; Mon, 27 Apr 2026 19:46:04 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 63FCB3000C22; Mon, 27 Apr 2026 19:46:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319168; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cwyJtVk4gZDCf3olCQ+pCOZAHvZnX9kcneYgWVf/Mnc=; b=Fi94aOOnBPSaAX4CDUreYOPoPj8LyELCLRGRRuAQG5kAl69Sg4Dt+dMSLdBMG3fLtErHN3 6v4OeJBXfrvpoOHzSKfPTXT1l8AgK2IHJmz0OD1lXT4kxBFYxhSYSy1DAH44Tegzur56RS SNEjblxA1mtYThyltyItXU+IQ/VY91M= X-MC-Unique: 2pOS_qvENMalQJvoj-_60A-1 X-Mimecast-MFC-AGG-ID: 2pOS_qvENMalQJvoj-_60A_1777319165 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:35 +0400 Subject: [PATCH 36/41] hw/ppc/spapr: free host_model and host_serial on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-36-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nicholas Piggin , Harsh Prateek Bora , qemu-ppc@nongnu.org X-Developer-Signature: v=1; a=openpgp-sha256; l=811; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=C/waKYfI9NUHCunT5MhxZ5oKPP6LJDlxOCNQ5Vxmebg=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wWCZfUqyAh/HfDSL4bKHf5p6cB93FirPV3c 5ZGERybEECJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FgAKCRDa6OEJdZac 5XLKEACX7zjn61OcRIA2H5/B8KUfdG5mrN5mx/IgtzE/otKDw4wA3PPYVwBJEkjVnBPAkIrRbG8 ZJKoeGs5j7cXr2AqcYRATuNaFz/NcNRweBUWiFWbCgoPKUhCRV1NROTSTfe6oEhICeuaoruiCQs CdeXVfbtz6l7lYp9Ip4/1LSwJT0xuhiMWVFpqHJXt0Wd1JxvJiiQbCNTFn2iRUsoXeqRxsDD7YT 2Pl7gSxDfEVEjLJWhTumIYG/E/ocdzlwgmgKWWABfNhTClYaewTIjrlDTNl6xkK8bMblk9VsqGZ 32MstI1ARCq3dsrcGA6jptorwsRxBIAPwb0Nz9iBjGWs5lGyNzMg384gt0fh/jzVXM+Y567JzPk 1pPGF2631sVx9M9bmzIFo7HgsKH7vQ/tuuadibc7yeEj4sqMCotgR9YqV3FGlE10dfCl7QcxgIT Ty1Cdj3HJHdJZs/OJZBdaczLIKK5hEfppjhKBd7Cc/Z7USZb21UYMAtqbVljMIsfJZNP4hwcxYA VG7suV0NnvkXOFWnqKenui+EmbaW/VVoAMGj0o+KTpSIm2qYopW0UlAufQtlT9lFbY2zu2ZHq7A 3JvO/eXzetZXw4/r9VOiRBQ1at4BtUNF/xEn6fr5+ZBnROppLDj8si++0FQqwPXWAAk04qc3Zen VO6QNHyXkaetEYQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319211956158500 The host_model and host_serial strings are allocated via g_strdup in property setters but never freed when the machine is destroyed. Fixes: 27461d69a0f ("ppc: add host-serial and host-model machine attributes= (CVE-2019-8934)") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/ppc/spapr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 428b491a7df..5c673bbf0dd 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -3517,6 +3517,8 @@ static void spapr_machine_finalizefn(Object *obj) SpaprMachineState *spapr =3D SPAPR_MACHINE(obj); =20 g_free(spapr->kvm_type); + g_free(spapr->host_model); + g_free(spapr->host_serial); } =20 void spapr_do_system_reset_on_cpu(CPUState *cs, run_on_cpu_data arg) --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319245; cv=none; d=zohomail.com; s=zohoarc; b=APhqvk6yDeKFn1VNWGS0iSArefYu+snLLrDJb0W/CCeBgWwb2hI2AzdhObZmA9+xc1OLb0b3TygvEErZtU1+8Ncx/cRJ/UI/85sM0guK7l8SgY/Kp8sWrMy9/YjzOeVwYa0+lpnCZrB4RvHOVmQ6fc+XVnzM3tJqMjXRHRkKUkc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319245; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=4tw5Pz6kISkF6KqFnDKbV4J48BYB8c89DHYYaZAxmEg=; b=PNpvhi2HWjZO8JqxHnaYueBU6RTOPdEbaFbBBDu7T5YvTZhlhW0legKRGwTORytW5usqnUcFuX67vLqS2cHdT22LAb7Eicr+vXmMfEVqjt7s5QY3IVK9TEiEoGU8STys7ndLTWE5HMpqTueRgx8LkzqutbJI4s6jicZNX1JGsZQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319245290232.79611101728335; Mon, 27 Apr 2026 12:47:25 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRuq-0002pr-PH; Mon, 27 Apr 2026 15:46:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRuK-0002j1-5T for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:46:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRuI-0000D1-T0 for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:46:15 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-115-6hGOBmWaNsW2Vm7aygMAgw-1; Mon, 27 Apr 2026 15:46:11 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7FCEA19560AA; Mon, 27 Apr 2026 19:46:10 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 41E9119560AB; Mon, 27 Apr 2026 19:46:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4tw5Pz6kISkF6KqFnDKbV4J48BYB8c89DHYYaZAxmEg=; b=fTaHu+mmyF6XCoUl70/0Y7gzLXtlpl6kYER2w49Ug7/Tfx/Bha12yF7/pR/PxsDkz699Q5 QPcM4juXDwdU2zSPb9WIqVIJ6jVZ6OjB3jRDM7h+M32roF98/inrVYX7yIBwfewQEnewaS TKkxviusdxn99rtV9Wo+zb8DR1eP5N4= X-MC-Unique: 6hGOBmWaNsW2Vm7aygMAgw-1 X-Mimecast-MFC-AGG-ID: 6hGOBmWaNsW2Vm7aygMAgw_1777319170 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:36 +0400 Subject: [PATCH 37/41] hw/ppc/pnv: drop extra ref on PHB after adding as child MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-37-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nicholas Piggin , Aditya Gupta , Glenn Miles , qemu-ppc@nongnu.org X-Developer-Signature: v=1; a=openpgp-sha256; l=839; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=hrUoAdeW0FsiiSJDTGr0GcRKIqh6cuaaSL1z6lxFAPo=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wWqiCTtJuQDEw1RwUnMaqqC9IuLDAg5htXc iWgqpDwb2aJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FgAKCRDa6OEJdZac 5bTtD/4+7qNBB2zipjY6/9ow4dez0YcGW8jeo7FfiSriSWCiRV5J/uE0n7KNEUNatQlwaw5p+Yq PRx5+iF8tHO/40LRPmOqJ9cjHs0kLSP/Mo79BBqtf18G6Yk1luw5YsqHD3kndx4UPTr9NyV04By fgK1yGm9NPDgmo2HgmleG4shId/Lss5LS5FC6B2bP7V/Nlub/RFeKNZjhJ6BNBrOlhC858xCAhd RsbRQCTnRA6g5i22UJI7TDaRu9NNd5qaEZ1GJlut7pcjb+cBA7jpDvkNkY6cBtDpvP9UOGjm+mR CuLkUs/EpeOZcKXGMT43Dq8UvDLnLoBh1X7sSo7e652uLNJ9N9kgFcJV4SBSyd8420AwG3oEZLh X90OkT05/X8Q68Jwy/FFSpCiOMliHnjc6dPW4ppC4c0wHvHIqP/ovJHq2eopx43RwFguiPvqjKs Uzu3RCca+C8GYJ/erFXcmC018L4efyzCcskgcmSgeHDgUotQlrgt5gjljBOyJ1bVM3QHjm4zUH6 28c8laCYZ13v+RVARC9R2k4us2gu1YcRQUXv1lLoo+TiNao3BBuXreSXRzxF6+mt9m/OYIM3QZo jQx2+WDBTYvvMVbYHAvqjFcgF0Xsf6sF3rZ73/ZUJKNwHIr1EyvCtJnR5dRTXug6C6LIppnws8j ugX8WebIMfcDVzA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319247459154100 object_new() returns an object with refcount 1, and object_property_add_child() adds another reference. The initial reference must be dropped so the parent becomes the sole owner, otherwise the PHB objects leak when the chip is destroyed. Fixes: 0d512c7120a2 ("ppc/pnv: turn chip8->phbs[] into a PnvPHB* array") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Aditya Gupta Reviewed-by: Glenn Miles --- hw/ppc/pnv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index 524563dcfc2..476255b722f 100644 --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -1590,6 +1590,7 @@ static void pnv_chip_power8_instance_init(Object *obj) */ object_property_add_child(obj, "phb[*]", phb); chip8->phbs[i] =3D PNV_PHB(phb); + object_unref(phb); } } =20 --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319372; cv=none; d=zohomail.com; s=zohoarc; b=TpW2+NJ/7bucNbQJCRiMdE9P3eWRUY5nrlrZMCreHPk37wgPRLxwPHkirh1q5inRKu0c3Bk1ZmZv84sC4DvkzEPBYUrtvGTxWI5KJVzVGfSQOhbDky/xRxqWFTT3rYOS2eLlj4ITPG03n4i5rMPZ2M2au9NDKXazwD1P9XM2dPI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319372; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=l6i+QH3SjfjPRSHNBCrqV1LYOaaUKzs1HKnK3Bilxho=; b=RV+SLYQDzoFhiv5Bo19Fgjnz9PZJ3PgIjALcHFOOVovNynx/m2D6N21mFbcQxYpzlOXVpCmRGLga58NOmEurUiHlwSRTThxXlLsO6mIVW4Oge8AyUHCaxi2AnRO1lDOcp9G3ho98DuGJVknY8cuLphlCGcNZoF0uYsPFZwcRZCs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319372955356.01131751035734; Mon, 27 Apr 2026 12:49:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRut-00030N-7I; Mon, 27 Apr 2026 15:46:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRuW-0002kx-Gf for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:46:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRuS-0000EP-SH for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:46:27 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-10--tR7JTepPMSEozC2RIB65w-1; Mon, 27 Apr 2026 15:46:18 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 560AF1800464; Mon, 27 Apr 2026 19:46:16 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D29D8300070A; Mon, 27 Apr 2026 19:46:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319183; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l6i+QH3SjfjPRSHNBCrqV1LYOaaUKzs1HKnK3Bilxho=; b=cZM+23B4J8odJSHwdE6FaVi1B8mv+JJ7pfwwewCEp/VE4rrn+/6z3fkdC0Z07VrEBOSXVi K28bAhFHyrrwwTZFZnQckPn80y0Pc+7URQjxAYKLRk8foXUqdKFKFIPJN32U56n9cwOVY9 wN68YfYdpjNVYBx3OD4/Va0Qi1ciI9Q= X-MC-Unique: -tR7JTepPMSEozC2RIB65w-1 X-Mimecast-MFC-AGG-ID: -tR7JTepPMSEozC2RIB65w_1777319176 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:37 +0400 Subject: [PATCH 38/41] target/riscv: fix general_user_opts hash table leak MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-38-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Chao Liu , qemu-riscv@nongnu.org X-Developer-Signature: v=1; a=openpgp-sha256; l=1716; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=ohWQ4ogs9grZ7aGeieqq2xi6Mm2yl57k/5oP/ZyoGyE=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wWY7ZTkeW15/SrtnvRCsP8KCpaGLL3aZisI pRCltWKIoiJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FgAKCRDa6OEJdZac 5U86D/9GvHmn4W0G0j6vfpJCCGnTQ2XR7qJeScmBMKakAQUe6RPe/nHP89IE7igLhDyEE3Ny9Ve 3jLmsIiyOLLH8ppP7KbAHow0mfL3ScJbW96VBhkSzUeEHNKVtdi6ruuvQG106nz+E0KiPsTG1vt sP179uozxOdWO+T0sAxs8TBDDAnJxsdOTsPk8KJfBFl4HXmGPXS2nL07aElPJRafRlfyjI+qQIu fqqw9OMjb7aMf0SFCo4ZTQC8gslVnVp7rAkihQ6Y3bSKFtHVbileJ79pJoP6scKp8//R6n7h4YC rXMDS7qhTzJvkNSr/4mEX8IqZ97KLJM2RYMiSNbrWJXou9riUGdLI/n4UVTcyF3st78i7O31pZZ +pkdJsHT5CIjchStuhDbG2go+8vmdgIw0HRZSNKpj9XiewgwfHUcKvPdKwnW8lq5Q4FFPpEXdrd 4Am0/6JsQzMZq0TqJngerTueAJED3jOwxMMUr5WkX8oMqnMiVA9dUyJ3qg1e9ldg3T0lm5jt5jI pzA2DC/z3hEqQe3GRlux9BUPGHcQyaTF1bb69fviGOk26DqmUd9UsM/9cHPa/u/x5zf/j+lVBGb vtcgUR2SxZdSc8Y1Zu1tjiazmfwoe+2wwMFVY0btwhOR2AZJIe8xQEb1s5BpnmpGomEKMQmKbfI f1Z3kDEDrdrrUBA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319375501154100 The global general_user_opts hash table is recreated on every riscv_cpu_init() call, leaking the previous one. Clear any existing table before creating a new one, and destroy it on CPU finalization. Fixes: d167a2247ede ("target/riscv: move 'pmu-mask' and 'pmu-num' to riscv_= cpu_properties[]") Signed-off-by: Marc-Andr=C3=A9 Lureau --- target/riscv/cpu.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 8ac935ac06e..15fa03e22a4 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -1101,6 +1101,7 @@ static void riscv_cpu_init(Object *obj) "riscv.cpu.rnmi", RNMI_MAX); #endif /* CONFIG_USER_ONLY */ =20 + g_clear_pointer(&general_user_opts, g_hash_table_destroy); general_user_opts =3D g_hash_table_new(g_str_hash, g_str_equal); =20 /* @@ -2961,6 +2962,11 @@ void riscv_isa_write_fdt(RISCVCPU *cpu, void *fdt, c= har *nodename) DEFINE_RISCV_CPU(type_name, parent_type_name, \ .profile =3D &(profile_)) =20 +static void riscv_cpu_instance_finalize(Object *obj) +{ + g_clear_pointer(&general_user_opts, g_hash_table_destroy); +} + static const TypeInfo riscv_cpu_type_infos[] =3D { { .name =3D TYPE_RISCV_CPU, @@ -2968,6 +2974,7 @@ static const TypeInfo riscv_cpu_type_infos[] =3D { .instance_size =3D sizeof(RISCVCPU), .instance_align =3D __alignof(RISCVCPU), .instance_init =3D riscv_cpu_init, + .instance_finalize =3D riscv_cpu_instance_finalize, .abstract =3D true, .class_size =3D sizeof(RISCVCPUClass), .class_init =3D riscv_cpu_common_class_init, --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319344; cv=none; d=zohomail.com; s=zohoarc; b=bgS8KaYlaP/WIQ/s9XwOf8+rQQbxN/RYKi7owxY93v/qNS1RMtSN7AkuyQdoUw3XMNfQeNwMmcq4mpgMmb2pIHkw20GJg+c09S20+e6Jy0w9c655dzKdL6eLYU8ICdzKjIy+ZLWOIz06HcDndfzD7feZ1vegGsaMWqDuEWQpJY0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319344; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=21tqP8lo9LBFSvH7A6FrcFDu2dSjpwHDzyS3XvE13w8=; b=Q1G+VFzehXvpUnZhYEary1MIfLkLWxmLm2pqr78wnUk939MCWSwAW8IOHxOqIFlMhTwYkwdFfComn+yqrChk/obJMqnlA9zqHk0ZuSgx+TEkBYse1POgvR5r6hiwD9+37YQSqAZAxtTIAMCdfRsO0GUXAjwmHzvmH9oF39GWJxA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319344454350.8369835643425; Mon, 27 Apr 2026 12:49:04 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRur-0002sq-R3; Mon, 27 Apr 2026 15:46:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRua-0002lu-72 for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:46:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRuY-0000GU-Lm for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:46:31 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-398-rl599GoVPO68LvpiNffp2w-1; Mon, 27 Apr 2026 15:46:25 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E560419560BB; Mon, 27 Apr 2026 19:46:21 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9B01B1800664; Mon, 27 Apr 2026 19:46:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=21tqP8lo9LBFSvH7A6FrcFDu2dSjpwHDzyS3XvE13w8=; b=R2eVyqsD360L99In3+ml3News5eF/OqHvayVfFDt2PKEVdyTkZdBRXd0QTLHk9ybUACIsk dgiIvvLSENJqNCaJphifMP/uP5mnODNiegsEbUnGaVrm1r9vEY/55sooXZFGHRRZZwp9Mr pGd/764wIFk1tuCrDeQetb8LdHtqHSA= X-MC-Unique: rl599GoVPO68LvpiNffp2w-1 X-Mimecast-MFC-AGG-ID: rl599GoVPO68LvpiNffp2w_1777319182 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:38 +0400 Subject: [PATCH 39/41] hw/riscv/virt: free flash devices and OEM strings on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-39-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Chao Liu , qemu-riscv@nongnu.org X-Developer-Signature: v=1; a=openpgp-sha256; l=1534; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=jKlBV2vW9MmXkiDj0aUyz1PT6pjDCbRhdhlP2u5ZfZk=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wWrBOjNVGMG8NnDAHrZQTa3DrhN2Eh3pJhD NLOPtOzJ0iJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FgAKCRDa6OEJdZac 5XYBD/4va9fk8mS/iZgqHaK0/86XuSW7lHtQ5WAV6LpWmskhApa+J/mU87vD9WqgysnhHQ468do 12diWTF9Avk8iKXUXteLBoG1WE4oMA/hcV5LMIzFAuRVSLcyB4Jmh5jq9UxvcKCfsaaELYrzNOb T85l7ok27K1F5LCAPqXJb19NNknc270Rs7YNPtDjscdSTxIvp+H0abuvmq6QjC2fMNweQICk228 WwfQPYI7NUvY5C+pyYljg/AEbKD4fI0Deb5hyMNAK+Y1tt9NU6ZS9UdmLnA7AUn8yDJWBxXhPaS PV7z02nun18JHQ5QY+uisY4+R9sCKjL3ZLK55bCxDm4jDyJ/vpNoBaW0VwTEsINRVYcdNFbVyh3 SyDH5tmuLwjiRqFWwtyZV2xYJ38xoHIlwRxILVopETvgTVLWX7swRJ2kK+70whTSQXArEmz+4ur JjXzrazKVVjMgDSE2yd/QHy5tyMZXW6c5qMqhjouFzJufsZKa7oxHFi3ehtaDUlAdsAY7rZsnvY U6MVJ+KPFAsVzFWP6qc6obG+G4U34eZAJoY3wuQxgCVBg9ThhrbXKDJLWYY5jSsbFYbmLb6OqiF jK+6i/tqVOSkOaqLE0Co7B87Qoy5MoGqK0JO/5GicbV/G23nzB8/1QRDM07+YfiKJzii7r03dlJ UX0VuL+lSxTLpKg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319346759158500 Add instance_finalize to free the two pflash devices (when unrealized) and the OEM ID strings allocated during instance_init. Fixes leaks found by ASan. Fixes: 71eb522c4063 ("riscv/virt: Add the PFlash CFI01 device") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/riscv/virt.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index a1c323e66df..315049bc86c 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -1745,6 +1745,19 @@ static void virt_machine_init(MachineState *machine) qemu_add_machine_init_done_notifier(&s->machine_done); } =20 +static void virt_machine_instance_finalize(Object *obj) +{ + RISCVVirtState *s =3D RISCV_VIRT_MACHINE(obj); + + for (int i =3D 0; i < ARRAY_SIZE(s->flash); i++) { + if (s->flash[i] && !qdev_is_realized(DEVICE(s->flash[i]))) { + object_unref(OBJECT(s->flash[i])); + } + } + g_free(s->oem_id); + g_free(s->oem_table_id); +} + static void virt_machine_instance_init(Object *obj) { RISCVVirtState *s =3D RISCV_VIRT_MACHINE(obj); @@ -1984,6 +1997,7 @@ static const TypeInfo virt_machine_typeinfo =3D { .parent =3D TYPE_MACHINE, .class_init =3D virt_machine_class_init, .instance_init =3D virt_machine_instance_init, + .instance_finalize =3D virt_machine_instance_finalize, .instance_size =3D sizeof(RISCVVirtState), .interfaces =3D (const InterfaceInfo[]) { { TYPE_HOTPLUG_HANDLER }, --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319389; cv=none; d=zohomail.com; s=zohoarc; b=hqwlnUfJ9v0XpSlCTNN1WyJ8JfLsT56CEW45AgK+w+Hqm8le8zQTuZ++NF+N4D9ck0vqbzThegg8Njprmoigoll0Q397B1gYzRlZKqmM1OIHqyOI+Ww1q6LDYp7giCxXBN59WpVG8/UqvotxHM/findyfBxXsPMsNhPKlpb2xl4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319389; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=P0KOMOV2ogglfBJzbaKZEamIRSJ3b0RsobP2ZvazQx0=; b=jUioZ7+fUwUiJbPfDyr2Z1lwFeNO/md7UA9lAmlNX2uR639f4G6o/YnhBolD1PaPAxMCg3SkgqZz6gTh7H5zgIgWmfXOcUl2sV/s3vTC3V8aOiop8FzAkf3UhKCEIazEth1Uef3BzuadyhokbdPyhXQQoW1tk/P5Rs90lbR+h1U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319389062543.7454958551747; Mon, 27 Apr 2026 12:49:49 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRuu-00038R-FU; Mon, 27 Apr 2026 15:46:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRuf-0002nx-Qb for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:46:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRub-0000Gv-Lv for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:46:35 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-596-e1jmEIloNt-gV5R66mKh2A-1; Mon, 27 Apr 2026 15:46:28 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D87181800282; Mon, 27 Apr 2026 19:46:27 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 781A7300070A; Mon, 27 Apr 2026 19:46:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319193; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P0KOMOV2ogglfBJzbaKZEamIRSJ3b0RsobP2ZvazQx0=; b=Ac0jO+erCTCFHnkItgONE0ulGfORY+UfSjbTbOgZJB+FrH+OM7U8X4iLlIzNtottM88qo+ nOEmhh62KWHfsu0K340y9zTBmOXMrK9IIRt1qH8RCjRaW1WkjTX/n2G15Vfys2u18oco4S lW0HoBbTLZkNo4rqAls3H1o1nqohQGg= X-MC-Unique: e1jmEIloNt-gV5R66mKh2A-1 X-Mimecast-MFC-AGG-ID: e1jmEIloNt-gV5R66mKh2A_1777319188 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:39 +0400 Subject: [PATCH 40/41] hw/i2c/pmbus: fix undefined behavior in pmbus_direct_mode2data MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-40-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Titus Rwantare X-Developer-Signature: v=1; a=openpgp-sha256; l=1137; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=2dC++hVlKU9GL8wkcDvF8pRIuTJVc02X3ZdB8ioXtmc=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wWCSMLWSFlL5vt4DE7S0EM5qpi04Dpc02qu p6FV0ylYJOJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FgAKCRDa6OEJdZac 5aqGEACx0uhHWEOvrKH+OM/eJnMfLtK/oZ2FIQ06+ockve3mGc8evJRD6BiAD6iCEwLqKCuxT/J A4YMSPcegVtKYcFNcPYGogfeMIQ3KWDKOhuOmXHBCh2EBlEABp60YnPFb93dMCwbD3LsSllmP/2 WXGMoAOmoHM7LPRulsKa6AFsQYZbrehZcJYt+cXwDpKa0rMJUHGs1VQ8PQBhDsJRCESEfGgPDhi dtsO1SX3ILQOQ7fValcvDFkKWxVNnXdKq5EfTKKy+VzT5bAisceOddWJsPcdHT5GIoBQLaz0K6/ ZbapY7KqiC5yDY4hF84hz9aeeK6Ar8zOOmo+wnkYvr3C1Bs489Unpli9Uk2BJZGeZPvkfTncgM+ U286pHCRVv+0Ngi91sNuB9Qrf/rvlDAQelxUimNZPj73Vu7qpJpzJK8vAutlLGKwBf8IM4hTEqy F0Wdcg6qJUiqtPhYWi5ZS6+PO9QIF5H+7+1iu7EDqs3vukoA7U2VV+7KMCd/x2LeI41H/yu0SK+ PL10FcYWCS6Kok/b2djb7SMv2X2m1yxakQspVPnc6UaXuFdYDZURwSgGu7nI7rdOBQyb9/GDNnb 1iwKqkTWmdd/Bs7GbtwDDEH44myq5pLgWDg7EXrpeI9koKc3ANE2cQlt96CWUHthMLvnLr15kMi n630XJ939sJxjXA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319390911158500 The intermediate result of (Y * 10^-R - b) / m can be negative when the bias (b) is large and the raw register value is small (e.g. zero on an uninitialized device). Assigning that negative double to uint32_t is undefined behavior, caught by UBSan/clang. Use a double intermediate and clamp negative results to zero. Fixes: 3746d5c15e70 ("hw/i2c: add support for PMBus") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/i2c/pmbus_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c index 853dc4b4342..861f5b4fb63 100644 --- a/hw/i2c/pmbus_device.c +++ b/hw/i2c/pmbus_device.c @@ -23,8 +23,8 @@ uint16_t pmbus_data2direct_mode(PMBusCoefficients c, uint= 32_t value) uint32_t pmbus_direct_mode2data(PMBusCoefficients c, uint16_t value) { /* X =3D (Y * 10^-R - b) / m */ - uint32_t x =3D (value / pow(10, c.R) - c.b) / c.m; - return x; + double x =3D (value / pow(10, c.R) - c.b) / c.m; + return (x > 0) ? (uint32_t)x : 0; } =20 uint16_t pmbus_data2linear_mode(uint16_t value, int exp) --=20 2.53.0 From nobody Mon May 25 13:48:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1777319409; cv=none; d=zohomail.com; s=zohoarc; b=OVz9ngCSnxNi07tEa4R60RFPlZqX6+NGEdjY8bKumtWYb99RBYceM4M7G9QLRDZ+AKdqT+MdGFQ9dAh1GEFZhZa/gd7frB674dDVLvKrDiQbYv303hsIdRX2ifqzmGZr1zsblByKGeiFpNb5QR+stbnAiCKxkuwVXRtinb0eZKI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777319409; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=HEApZps73Ho7aFOZh1+bQSHeMmOHaneoKeZvjd0sWTM=; b=OANSq7kS4z8Ae67P3CoenM0grlaUevMr9wOETF0PD3dks0mwrelCAlyQfHnKnOQhZNlCRMkJ2MWYDfZcWnzBuQRoyPGLta1sRfAYjlUheZFqrrEfIxsAWSTjtfRmBgbBm94wGdU6fBERrV2TCkQDmgLSRsAe2wEq1bcU0CtXxhQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777319409962378.63853436517365; Mon, 27 Apr 2026 12:50:09 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRuu-00036y-9U; Mon, 27 Apr 2026 15:46:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRuj-0002o5-BQ for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:46:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRuf-0000HM-P5 for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:46:39 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-561-XyMDERm4M0G3qTkbTuBaMg-1; Mon, 27 Apr 2026 15:46:35 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6FB97195608D; Mon, 27 Apr 2026 19:46:34 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C5AC8195608E; Mon, 27 Apr 2026 19:46:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HEApZps73Ho7aFOZh1+bQSHeMmOHaneoKeZvjd0sWTM=; b=agzF/f/IYq85lNVLm7BZbU8l01t67YsTrtzgF9D7DZfLA6GlyNqg34EB5mkGFuAPm3l2ZU 6tA83Sgrog4CQ2rH+znK4m8TEnbeEk5fhkSL0GCG2MV47So42lG1JG6q0hYB7gr21mBP+x D6l8tCLRIAmNb9XrMprd2odFkdhwSfU= X-MC-Unique: XyMDERm4M0G3qTkbTuBaMg-1 X-Mimecast-MFC-AGG-ID: XyMDERm4M0G3qTkbTuBaMg_1777319194 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:40 +0400 Subject: [PATCH 41/41] qtest: add "qom-tests" command MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-qom-tests-v1-41-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Fabiano Rosas , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= X-Developer-Signature: v=1; a=openpgp-sha256; l=4927; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=TkaCs7mNmnZ1B+TylAApTAOAEYAjeYCYy5SFEzjEKNk=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wW2ZACVw4f/iGQ4ZmTSUmhufIHN6vhfETm3 2y3Bfs5XvaJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FgAKCRDa6OEJdZac 5SinD/9ccyvjzHnR2Ej+g1W8x8eECA6wfmZKW5Z0+RRLoIeHFahwrnKV7aJGeZRuA3Rqy3zYa97 6OCczmiUPt+mtXqqJQfqBzHWgaxmixLbtLf0lT/mF/QXsJK2arLLApEcHmiLc82Q8B2hKxSYVkZ jJB2GW5lqqyv1ajMWx1dUiWV2a5FbpZLK9spY9OTKM5bnIthtKm9W1pXJgGU7k2Zew2jgK/IYoU Afh743adISuNxxxJew63ZnmhxLXe9mFETLE94bVVH5ZHU0lln6dexVrPwvcpyD4kMyiK8xI0YTe QhXDa8aVJ4g2eJ1HO1RZs9YKKzlLv35HinS/Qr/Wo5Lb6T5O96VY0vwK2QUzsCHGD6uvcXe+ouj XnAOB1rMgVRBIomFd7pD8CdJYBGfU/7nXUxkDq1Dg63BkDiBeO3/xsZLFBYuEmcjQJC4nH/moVf yB0yHQHryVJLhiN1bQbZCsBvC3f1YcfVwk0tKIqx5F0msgR1HDEQqdIwLcqVkNHR0WR3Sl/0391 xiab8AI8EWFnZfc7vMiVgfJBx8fzEYqZstNBQbC6Kj4GEFKiwJhGBbsOki0DNQQtDC5KxWatYuv 3wGbNjKiFytzElK0oHn360vmMd3DDchDEI9XtfjZtdslYgQq5Sb7mbQbh9Od+07uQvx0r6RShuF CojWRMpIW5xiEPA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1777319412085154100 Add a new "qom-tests" to exercise basic object lifecycle. Instantiate all non-abstract objects, get and set properties and unref. This should quickly find leaks and other related issues that are eventually triggerable at run-time with QMP qom commands. Signed-off-by: Marc-Andr=C3=A9 Lureau --- tests/qtest/libqtest.h | 8 ++++++++ system/qtest.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++ tests/qtest/libqtest.c | 6 ++++++ tests/qtest/qom-test.c | 12 ++++++++++++ 4 files changed, 72 insertions(+) diff --git a/tests/qtest/libqtest.h b/tests/qtest/libqtest.h index 9c118c89ca0..02d65ecb65d 100644 --- a/tests/qtest/libqtest.h +++ b/tests/qtest/libqtest.h @@ -426,6 +426,14 @@ char *qtest_vhmp(QTestState *s, const char *fmt, va_li= st ap) =20 void qtest_module_load(QTestState *s, const char *prefix, const char *libn= ame); =20 +/** + * qtest_qom_tests: + * @s: #QTestState instance to operate on. + * + * Run QOM property get/set round-trip tests on all non-abstract types. + */ +void qtest_qom_tests(QTestState *s); + /** * qtest_get_irq: * @s: #QTestState instance to operate on. diff --git a/system/qtest.c b/system/qtest.c index e9e5773341f..217fccf8544 100644 --- a/system/qtest.c +++ b/system/qtest.c @@ -31,6 +31,8 @@ #include "qemu/cutils.h" #include "qemu/target-info.h" #include "qom/object_interfaces.h" +#include "qom/qom-qobject.h" +#include "qobject/qobject.h" =20 #define MAX_IRQ 256 =20 @@ -754,6 +756,50 @@ static void qtest_process_command(CharFrontend *chr, g= char **words) new_ns =3D qemu_clock_advance_virtual_time(ns); qtest_sendf(chr, "%s %"PRIi64"\n", new_ns =3D=3D ns ? "OK" : "FAIL", new_ns); + } else if (strcmp(words[0], "qom-tests") =3D=3D 0) { + GSList *list, *l; + + list =3D object_class_get_list(NULL, false); + for (l =3D list; l; l =3D l->next) { + ObjectClass *klass =3D l->data; + const char *type_name =3D object_class_get_name(klass); + Object *obj; + ObjectPropertyIterator iter; + ObjectProperty *prop; + + obj =3D object_new_with_class(klass); + object_property_iter_init(&iter, obj); + while ((prop =3D object_property_iter_next(&iter))) { + QObject *value; + Error *local_err =3D NULL; + + value =3D object_property_get_qobject(obj, prop->name, + &local_err); + if (local_err) { + error_report("qom-tests: %s.%s: get failed: %s", + type_name, prop->name, + error_get_pretty(local_err)); + error_free(local_err); + continue; + } + + if (prop->set) { + if (!object_property_set_qobject(obj, prop->name, valu= e, + &local_err)) { + error_report("qom-tests: %s.%s: set failed: %s", + type_name, prop->name, + error_get_pretty(local_err)); + error_free(local_err); + } + } + + qobject_unref(value); + } + + object_unref(obj); + } + g_slist_free(list); + qtest_send(chr, "OK\n"); } else if (process_command_cb && process_command_cb(chr, words)) { /* Command got consumed by the callback handler */ } else { diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c index 051faf31e14..5f4588b128d 100644 --- a/tests/qtest/libqtest.c +++ b/tests/qtest/libqtest.c @@ -1121,6 +1121,12 @@ void qtest_module_load(QTestState *s, const char *pr= efix, const char *libname) qtest_rsp(s); } =20 +void qtest_qom_tests(QTestState *s) +{ + qtest_sendf(s, "qom-tests\n"); + qtest_rsp(s); +} + static int64_t qtest_clock_rsp(QTestState *s) { gchar **words; diff --git a/tests/qtest/qom-test.c b/tests/qtest/qom-test.c index 6421f2d9d9f..cf4c6b5add5 100644 --- a/tests/qtest/qom-test.c +++ b/tests/qtest/qom-test.c @@ -227,6 +227,17 @@ static void add_machine_test_case(const char *mname) g_free(path); } =20 +static void test_qom_qtests(void) +{ + QTestState *qts; + + qts =3D qtest_initf("-machine none"); + + qtest_qom_tests(qts); + + qtest_quit(qts); +} + int main(int argc, char **argv) { char *v_env =3D getenv("V"); @@ -238,6 +249,7 @@ int main(int argc, char **argv) g_test_init(&argc, &argv, NULL); =20 qtest_cb_for_every_machine(add_machine_test_case, g_test_quick()); + qtest_add_func("qom/qom-qtests", test_qom_qtests); =20 return g_test_run(); } --=20 2.53.0