From nobody Tue Jul 28 16:15:53 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1777211522; cv=none; d=zohomail.com; s=zohoarc; b=HqB4s9DUgwWi7VzwR+LJ98pz7oZ1yjKAMHImF+R0zQloNKLgMEU7J7K8HNk32Kt69opEw7YVIiP26uaiT80ffxhpBSeAuLVw/qRCm1R1/ALShs3OICB/TIqya0g4h/TKPs0Ay3ra94JZAp+9/QrV0wbiOERsxjtkyDDkcHmH6EE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777211522; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XRyWdsWWDBWhjEZurZCmmfQh5TH8x0OJuXWPwMpCiKw=; b=UAJan114YB3Jvu9n0zbpMWPaFzXcCz6dgNJgSZJpaxKg9Rs4to57on5gWB7RudDp2mxm/BEafCGQvoWEY03b+ZBHHvi1SCL1pdoJWD2d1cM/yAWTxfh43xU8ICWGC92NPbrmpsk5FqNkLYwyCz7HWUq2cFFn7a4BK/ymIlO7fsQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1777211522536930.4731973578686; Sun, 26 Apr 2026 06:52:02 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wGznI-0005FL-S6; Sun, 26 Apr 2026 09:45:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wGznC-0005CD-Cf for qemu-devel@nongnu.org; Sun, 26 Apr 2026 09:45:02 -0400 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wGzn8-000107-R5 for qemu-devel@nongnu.org; Sun, 26 Apr 2026 09:45:02 -0400 Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-2b2503753efso97400225ad.0 for ; Sun, 26 Apr 2026 06:44:58 -0700 (PDT) Received: from stoup.. ([180.233.125.15]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5faa34ea7sm280544085ad.34.2026.04.26.06.44.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2026 06:44:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777211097; x=1777815897; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XRyWdsWWDBWhjEZurZCmmfQh5TH8x0OJuXWPwMpCiKw=; b=e6w9dCACOVfjK+FffcTQWYsde08GhMJCkv9wikHPM1hGClOhu1aKG1ObhJeyvl2KGt 2Ryz8IMeIA4saLlleYOgIPnKAeSRgv0s0eSsdfBH55zw4ax71MWt0gZt237GLJrrP6fw 9UJdRKYSKebSennIwKpNBYjh3DubcEriqYVfftM8b/tSjymvYccl6FrWUlY9C1KLyxKH l2TCAsFGaGza735B2F9vTIAhSqFB1rnETuTISALzUF3dLnCehycG1nxkIAe2F8EFToch 67/DVvtifeZFLoUM/YL/MvkE5myoSqHuMJSZQ8ytRH6m2KnDpyQM1HqZJ25JKTv/0a7b i3Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777211097; x=1777815897; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XRyWdsWWDBWhjEZurZCmmfQh5TH8x0OJuXWPwMpCiKw=; b=SWP5y4sDxj11YbrsZeALA9CRoNsMAmOhfsU6XPRxqUjygpTJpLRcrzA0kvaAYd4aZq bQtlPa1i3Ul81vcFw/8PtOos7OlK/ahu1gTa8iqEnncrMe9tm4BYFmFVcjt3l7LSuhWJ ZDxI+RLCRie/+BgXPlboKZ2DqN8zZBoTaQ+AR+CxuskE4tqaI7krR04V03FV1jx6buSK B0/CDkB/kUullpbkdBf/SVk1QSIBxkjHbsux0G/1AemTV7DVOXyQa1rL7vFi5p5/ADic f0yivaAzYdGEq4H3CUNOeznBVcK4EUify8civ9Do/hGSxrX9fCdH3Oi8hUmkDm7TALfM 96Yg== X-Gm-Message-State: AOJu0YwXeAoK+d9kwQQpyhFpIpInEYwLb5uQsWLh6VnAFa+TiBaKnYt9 ZsF9oE27qokkGlJcVYbuuJoamKOG7ZclUrwgEYsDHdQytEycfSAgFNI5a5+kO5TPf2HpzkJo0qp Xz9eZgy0= X-Gm-Gg: AeBDievOmGCRNenFB6/Chh9wd0btJVE0ScH2AOtppEj/Hjt+Wy/TT58beGqsL/Vb5Xz 1INBVJ2Ykb1K6BCeGY5Mf3Daf4P2vioSdSVaVa6m7VHj8FgAQd9O8tx2zDbnwOng2V0MKPXtyQf 32hIg05UDLnZJgcgGGc7wlX7RxJjgfUAKA1acWO99P5DVdtKaoY2JaSkmGgp93Bacl1foCAAI7b olysNPFKa/BJu/tA4Y/AH7rZCW/NpccN07oO03sMoTdHl4HydqfHgKxPX0M1aiSOYNoqcLk3EQg O01JaBHb6CF3OQyj/hYmqo4HQc3pJk5xaZQdvhXAJuyFIAhYyhF7SZu+Vict7JYCzW8tqrgBHsP /WCAjB9nWhyiWOHu1XmSTlKLrzIBhj2+Jt1f3Ue9xBrIx7pvnSBF6h2V955TYHt3KCFq1sp81mz w2LxSb0tLK30KDj56BuylNyE4I71bNO/XZexXvBHWU X-Received: by 2002:a17:903:17cb:b0:2b2:67cd:9963 with SMTP id d9443c01a7336-2b5f9fd5c04mr397208345ad.38.1777211097069; Sun, 26 Apr 2026 06:44:57 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-s390x@nongnu.org Subject: [PATCH 40/84] fpu: Return struct from bfloat16_unpack_canonical Date: Sun, 26 Apr 2026 23:39:17 +1000 Message-ID: <20260426134002.865628-41-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260426134002.865628-1-richard.henderson@linaro.org> References: <20260426134002.865628-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::636; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x636.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1777211524063158500 Content-Type: text/plain; charset="utf-8" Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- fpu/softfloat.c | 108 +++++++++++++++++------------------------------- 1 file changed, 37 insertions(+), 71 deletions(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 566154a729..19cca8fb85 100644 --- a/fpu/softfloat.c +++ b/fpu/softfloat.c @@ -1482,11 +1482,11 @@ static FloatParts64 float16_unpack_canonical(float1= 6 f, float_status *s) return float16a_unpack_canonical(f, s, &float16_params); } =20 -static void bfloat16_unpack_canonical(FloatParts64 *p, bfloat16 f, - float_status *s) +static FloatParts64 bfloat16_unpack_canonical(bfloat16 f, float_status *s) { - *p =3D unpack_raw64(&bfloat16_params, f); - parts64_canonicalize(p, s, &bfloat16_params); + FloatParts64 p =3D unpack_raw64(&bfloat16_params, f); + parts64_canonicalize(&p, s, &bfloat16_params); + return p; } =20 static float8_e4m3 float8_e4m3_round_pack_canonical(FloatParts64 *p, @@ -1873,11 +1873,9 @@ float64 float64r32_sub(float64 a, float64 b, float_s= tatus *status) static bfloat16 QEMU_FLATTEN bfloat16_addsub(bfloat16 a, bfloat16 b, float_status *status, bool subtrac= t) { - FloatParts64 pa, pb, *pr; - - bfloat16_unpack_canonical(&pa, a, status); - bfloat16_unpack_canonical(&pb, b, status); - pr =3D parts64_addsub(&pa, &pb, status, subtract); + FloatParts64 pa =3D bfloat16_unpack_canonical(a, status); + FloatParts64 pb =3D bfloat16_unpack_canonical(b, status); + FloatParts64 *pr =3D parts64_addsub(&pa, &pb, status, subtract); =20 return bfloat16_round_pack_canonical(pr, status); } @@ -2013,11 +2011,9 @@ float64 float64r32_mul(float64 a, float64 b, float_s= tatus *status) bfloat16 QEMU_FLATTEN bfloat16_mul(bfloat16 a, bfloat16 b, float_status *status) { - FloatParts64 pa, pb, *pr; - - bfloat16_unpack_canonical(&pa, a, status); - bfloat16_unpack_canonical(&pb, b, status); - pr =3D parts64_mul(&pa, &pb, status); + FloatParts64 pa =3D bfloat16_unpack_canonical(a, status); + FloatParts64 pb =3D bfloat16_unpack_canonical(b, status); + FloatParts64 *pr =3D parts64_mul(&pa, &pb, status); =20 return bfloat16_round_pack_canonical(pr, status); } @@ -2276,12 +2272,10 @@ float64 float64r32_muladd(float64 a, float64 b, flo= at64 c, bfloat16 QEMU_FLATTEN bfloat16_muladd(bfloat16 a, bfloat16 b, bfloat16 c, int flags, float_status *status) { - FloatParts64 pa, pb, pc, *pr; - - bfloat16_unpack_canonical(&pa, a, status); - bfloat16_unpack_canonical(&pb, b, status); - bfloat16_unpack_canonical(&pc, c, status); - pr =3D parts64_muladd_scalbn(&pa, &pb, &pc, 0, flags, status); + FloatParts64 pa =3D bfloat16_unpack_canonical(a, status); + FloatParts64 pb =3D bfloat16_unpack_canonical(b, status); + FloatParts64 pc =3D bfloat16_unpack_canonical(c, status); + FloatParts64 *pr =3D parts64_muladd_scalbn(&pa, &pb, &pc, 0, flags, st= atus); =20 /* Round before applying negate result. */ parts64_uncanon(pr, status, &bfloat16_params, false); @@ -2418,11 +2412,9 @@ float64 float64r32_div(float64 a, float64 b, float_s= tatus *status) bfloat16 QEMU_FLATTEN bfloat16_div(bfloat16 a, bfloat16 b, float_status *status) { - FloatParts64 pa, pb, *pr; - - bfloat16_unpack_canonical(&pa, a, status); - bfloat16_unpack_canonical(&pb, b, status); - pr =3D parts64_div(&pa, &pb, status); + FloatParts64 pa =3D bfloat16_unpack_canonical(a, status); + FloatParts64 pb =3D bfloat16_unpack_canonical(b, status); + FloatParts64 *pr =3D parts64_div(&pa, &pb, status); =20 return bfloat16_round_pack_canonical(pr, status); } @@ -2791,36 +2783,32 @@ float32 float64_to_float32(float64 a, float_status = *s) =20 float8_e4m3 bfloat16_to_float8_e4m3(bfloat16 a, bool saturate, float_statu= s *s) { - FloatParts64 p; + FloatParts64 p =3D bfloat16_unpack_canonical(a, s); =20 - bfloat16_unpack_canonical(&p, a, s); parts64_float_to_float(&p, s); return float8_e4m3_round_pack_canonical(&p, s, saturate); } =20 float8_e5m2 bfloat16_to_float8_e5m2(bfloat16 a, bool saturate, float_statu= s *s) { - FloatParts64 p; + FloatParts64 p =3D bfloat16_unpack_canonical(a, s); =20 - bfloat16_unpack_canonical(&p, a, s); parts_float_to_e5m2(&p, s, saturate); return float8_e5m2_round_pack_canonical(&p, s, saturate); } =20 float32 bfloat16_to_float32(bfloat16 a, float_status *s) { - FloatParts64 p; + FloatParts64 p =3D bfloat16_unpack_canonical(a, s); =20 - bfloat16_unpack_canonical(&p, a, s); parts64_float_to_float(&p, s); return float32_round_pack_canonical(&p, s); } =20 float64 bfloat16_to_float64(bfloat16 a, float_status *s) { - FloatParts64 p; + FloatParts64 p =3D bfloat16_unpack_canonical(a, s); =20 - bfloat16_unpack_canonical(&p, a, s); parts64_float_to_float(&p, s); return float64_round_pack_canonical(&p, s); } @@ -2982,9 +2970,8 @@ float64 float64_round_to_int(float64 a, float_status = *s) =20 bfloat16 bfloat16_round_to_int(bfloat16 a, float_status *s) { - FloatParts64 p; + FloatParts64 p =3D bfloat16_unpack_canonical(a, s); =20 - bfloat16_unpack_canonical(&p, a, s); parts64_round_to_int(&p, s->float_rounding_mode, 0, s, &bfloat16_param= s); return bfloat16_round_pack_canonical(&p, s); } @@ -3100,36 +3087,28 @@ int64_t float64_to_int64_scalbn(float64 a, FloatRou= ndMode rmode, int scale, int8_t bfloat16_to_int8_scalbn(bfloat16 a, FloatRoundMode rmode, int scale, float_status *s) { - FloatParts64 p; - - bfloat16_unpack_canonical(&p, a, s); + FloatParts64 p =3D bfloat16_unpack_canonical(a, s); return parts64_float_to_sint(&p, rmode, scale, INT8_MIN, INT8_MAX, s); } =20 int16_t bfloat16_to_int16_scalbn(bfloat16 a, FloatRoundMode rmode, int sca= le, float_status *s) { - FloatParts64 p; - - bfloat16_unpack_canonical(&p, a, s); + FloatParts64 p =3D bfloat16_unpack_canonical(a, s); return parts64_float_to_sint(&p, rmode, scale, INT16_MIN, INT16_MAX, s= ); } =20 int32_t bfloat16_to_int32_scalbn(bfloat16 a, FloatRoundMode rmode, int sca= le, float_status *s) { - FloatParts64 p; - - bfloat16_unpack_canonical(&p, a, s); + FloatParts64 p =3D bfloat16_unpack_canonical(a, s); return parts64_float_to_sint(&p, rmode, scale, INT32_MIN, INT32_MAX, s= ); } =20 int64_t bfloat16_to_int64_scalbn(bfloat16 a, FloatRoundMode rmode, int sca= le, float_status *s) { - FloatParts64 p; - - bfloat16_unpack_canonical(&p, a, s); + FloatParts64 p =3D bfloat16_unpack_canonical(a, s); return parts64_float_to_sint(&p, rmode, scale, INT64_MIN, INT64_MAX, s= ); } =20 @@ -3590,36 +3569,28 @@ uint64_t float64_to_uint64_scalbn(float64 a, FloatR= oundMode rmode, int scale, uint8_t bfloat16_to_uint8_scalbn(bfloat16 a, FloatRoundMode rmode, int scale, float_status *s) { - FloatParts64 p; - - bfloat16_unpack_canonical(&p, a, s); + FloatParts64 p =3D bfloat16_unpack_canonical(a, s); return parts64_float_to_uint(&p, rmode, scale, UINT8_MAX, s); } =20 uint16_t bfloat16_to_uint16_scalbn(bfloat16 a, FloatRoundMode rmode, int scale, float_status *s) { - FloatParts64 p; - - bfloat16_unpack_canonical(&p, a, s); + FloatParts64 p =3D bfloat16_unpack_canonical(a, s); return parts64_float_to_uint(&p, rmode, scale, UINT16_MAX, s); } =20 uint32_t bfloat16_to_uint32_scalbn(bfloat16 a, FloatRoundMode rmode, int scale, float_status *s) { - FloatParts64 p; - - bfloat16_unpack_canonical(&p, a, s); + FloatParts64 p =3D bfloat16_unpack_canonical(a, s); return parts64_float_to_uint(&p, rmode, scale, UINT32_MAX, s); } =20 uint64_t bfloat16_to_uint64_scalbn(bfloat16 a, FloatRoundMode rmode, int scale, float_status *s) { - FloatParts64 p; - - bfloat16_unpack_canonical(&p, a, s); + FloatParts64 p =3D bfloat16_unpack_canonical(a, s); return parts64_float_to_uint(&p, rmode, scale, UINT64_MAX, s); } =20 @@ -4296,11 +4267,9 @@ static float16 float16_minmax(float16 a, float16 b, = float_status *s, int flags) static bfloat16 bfloat16_minmax(bfloat16 a, bfloat16 b, float_status *s, int flags) { - FloatParts64 pa, pb, *pr; - - bfloat16_unpack_canonical(&pa, a, s); - bfloat16_unpack_canonical(&pb, b, s); - pr =3D parts64_minmax(&pa, &pb, s, flags); + FloatParts64 pa =3D bfloat16_unpack_canonical(a, s); + FloatParts64 pb =3D bfloat16_unpack_canonical(b, s); + FloatParts64 *pr =3D parts64_minmax(&pa, &pb, s, flags); =20 return bfloat16_round_pack_canonical(pr, s); } @@ -4496,10 +4465,9 @@ FloatRelation float64_compare_quiet(float64 a, float= 64 b, float_status *s) static FloatRelation QEMU_FLATTEN bfloat16_do_compare(bfloat16 a, bfloat16 b, float_status *s, bool is_quiet) { - FloatParts64 pa, pb; + FloatParts64 pa =3D bfloat16_unpack_canonical(a, s); + FloatParts64 pb =3D bfloat16_unpack_canonical(b, s); =20 - bfloat16_unpack_canonical(&pa, a, s); - bfloat16_unpack_canonical(&pb, b, s); return parts64_compare(&pa, &pb, s, is_quiet); } =20 @@ -4587,9 +4555,8 @@ float64 float64_scalbn(float64 a, int n, float_status= *status) =20 bfloat16 bfloat16_scalbn(bfloat16 a, int n, float_status *status) { - FloatParts64 p; + FloatParts64 p =3D bfloat16_unpack_canonical(a, status); =20 - bfloat16_unpack_canonical(&p, a, status); parts64_scalbn(&p, n, status); return bfloat16_round_pack_canonical(&p, status); } @@ -4711,9 +4678,8 @@ float64 float64r32_sqrt(float64 a, float_status *stat= us) =20 bfloat16 QEMU_FLATTEN bfloat16_sqrt(bfloat16 a, float_status *status) { - FloatParts64 p; + FloatParts64 p =3D bfloat16_unpack_canonical(a, status); =20 - bfloat16_unpack_canonical(&p, a, status); parts64_sqrt(&p, status, &bfloat16_params); return bfloat16_round_pack_canonical(&p, status); } --=20 2.43.0