From nobody Sat May 30 19:21:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1776969186; cv=none; d=zohomail.com; s=zohoarc; b=VhEZyW72vwifYMfCJ5rnDt6cVYs5rF7b6WTdfCyAPymyC91bN0ecBROQKcY42ukbPZcDpsNy0YElFqPYBc9RUUd7OJYdP/pot0+gmIQq6/inzyrQat8bUzutvvf8E5sERuv/tzqkAAjc2WFRUZ4ItTv9l5W+MKzioVZEXNCdLs0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776969186; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=8Y2Ve4V4QEYXRrJPSWkdiI5lVBGKfF9N/aa0OwJDsJY=; b=Fznd331AXV5uWdXevoCphG79waWbY6VZIi+vS+YrKVVsgyO7CpJTeMb2z7xdBJxUintNSvBOgtL9R5bhUDOfYF0XhKw4omtDTMHdGit1r54sI8zpVc8PG/ogkap4e4AQBDOofElKM2TUV+dM7Wc8ScDn8jYJwGU4tTjm/W+S/6w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776969186225504.74714234844294; Thu, 23 Apr 2026 11:33:06 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wFyqm-0003ct-Ok; Thu, 23 Apr 2026 14:32:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFyqj-0003cX-Db for qemu-devel@nongnu.org; Thu, 23 Apr 2026 14:32:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFyqg-0001KG-QQ for qemu-devel@nongnu.org; Thu, 23 Apr 2026 14:32:29 -0400 Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-594-q7GmzJdINIiX8lA0q09KJQ-1; Thu, 23 Apr 2026 14:32:22 -0400 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-89fa878662bso159775846d6.2 for ; Thu, 23 Apr 2026 11:32:22 -0700 (PDT) Received: from x1.com ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8b02ae92fc8sm160665566d6.40.2026.04.23.11.32.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 11:32:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776969145; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8Y2Ve4V4QEYXRrJPSWkdiI5lVBGKfF9N/aa0OwJDsJY=; b=dC3dMSN97gvC+XrBkt5IBDUqj368FfbAFy5eDfgnUHuCAHk2Lqy61uuMSvDpm/qj1oUB6y skWhFoQ+0DF2zNp0oLE2++/yzCGwGE0mc7z7TqlHh2eB+SmVw5rFo+JT6AmEloyrwNlvsd ITuVvDXf1p0nkPZslTNRHFqpwAdG1qY= X-MC-Unique: q7GmzJdINIiX8lA0q09KJQ-1 X-Mimecast-MFC-AGG-ID: q7GmzJdINIiX8lA0q09KJQ_1776969142 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776969142; x=1777573942; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8Y2Ve4V4QEYXRrJPSWkdiI5lVBGKfF9N/aa0OwJDsJY=; b=lEDmO0dW8CoYcmNRsPpiLMoyWA914O9DFpU4dnFxd/s9UaFR7Yzjb/BLQKbza5J0hJ P6DpI7j8ALcAUc8unlBFuyaxnSwELTLsnewElbvwy6OR+wriXWDUfoI9cQrhsNrbAJoq gcGHP0IYYmbd5yGAMKfSuKqrHxa+mK5kpPtBvxmCpxVdiLsNn3YGfXHleLILHD13nlVj kPdSyxApyVJ96Ietiar5rIXoPMh8ZJuV2tOFsqmE9G+6pkVb9v+DmHYlqbDTv8P4U8qd GboEv/BniUr5yxMMc2iN6UfRylw/oTN3hzpRX9n3J9ywsxKURccPpIuWWhw3PKfb0sxg zU2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776969142; x=1777573942; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8Y2Ve4V4QEYXRrJPSWkdiI5lVBGKfF9N/aa0OwJDsJY=; b=lms2/jdQk56PCcEoPBOY5O/HcFbLCV8fJbB4s3xsIseh6jE8yaseJazOI1FUI6rQm5 fDd81ANr3SpnAlN8/+P8fXyR81Cldnfs9tiNZw5gqw1E26dLLj5mRghYXFdFXO/GDLx6 BVOO/KXGObcgSRsS4XxcLA/Fz+cDrce0yWiVTY/sSn+plgHwXvNUhrrkSXwB2hAi5zc8 XCPbG4SQjVF39t+qjWElcfVrndOpgCdYrQDEHQebhLRQiwZSXl2jCca3BTcZk2YF4KE+ Lcv9FgeXpDiRMBYOzxHSOl/sf/BuV5k9qGNN8eW4Ahbhh5fecF327gAndBpY60kGqHfy 3dfg== X-Gm-Message-State: AOJu0YxZAxRCB1lVDKNTa7IERoNxuW+LMCf8B86mSY61zaAkEng0s2Dy WSwzwKs5+TzlM8HIPEfB/u4AQAHFE6zWAGSaNvJoIz3PTTFGH8bDZsuT7uzaLAAAUFv97N9wPiW 251qTS2aVGaaHv2qcV0wOCsIl3w+LtPou4GU5N6NC0ZD/BMk5W3NC3gLFnTrLB3PkDsLzJPI/i/ k6NuhkX811fLvoqJX6NCzZXluchi+SALWpUPqbPw== X-Gm-Gg: AeBDieux1/xWeWia0v9otAon4TpkAqb+aulN6ivkLY3NCLEBNv3QroPb07d12hYeVQb 3iOuNN/COXjSvh8RHeChIEYXo1I/tUeLgMvKVF5Tbwv0WuH3toigRnS6pmBB+mpzxnZmq1udguz 5XIaezaLFwuVtHzMSb/sMH/MLSA8wqAbZyWxR5NvsDN+1gQHn66MyF8RN2BYfDI8aswvhaJWjNi FZHeBRvtF9phOLPVthE6WqjuS5+cN3+MLExFYByI8qGOZZ6aj8YtLDPfjv952j8kEuD9XvdodcI W52fKraSeysWdyjfy2cdpvq6gYgS/MEXtspHW4+/cI6NpIq7BtMaKcjbbIO6yfllSikyxrHnPNx VTFGUeKb8UWzHU2Eylxqwc16/8xXjI/iTSfYG700qw44LZY714NrKmDU= X-Received: by 2002:a05:6214:4783:b0:8ac:b2e1:37a4 with SMTP id 6a1803df08f44-8b02812e432mr406399776d6.25.1776969141775; Thu, 23 Apr 2026 11:32:21 -0700 (PDT) X-Received: by 2002:a05:6214:4783:b0:8ac:b2e1:37a4 with SMTP id 6a1803df08f44-8b02812e432mr406399176d6.25.1776969141260; Thu, 23 Apr 2026 11:32:21 -0700 (PDT) From: Peter Xu To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Li Zhijian , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Fabiano Rosas , peterx@redhat.com, Zhang Chen , Juraj Marcin , Jason Wang , Markus Armbruster Subject: [PATCH 1/3] colo-compare: Fix QMP qom-list-properties crashing Date: Thu, 23 Apr 2026 14:32:10 -0400 Message-ID: <20260423183212.468047-2-peterx@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260423183212.468047-1-peterx@redhat.com> References: <20260423183212.468047-1-peterx@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1776969188101158500 Content-Type: text/plain; charset="utf-8" Many of the colo_compare_finalize() code relies on complete() done in the first place, hence the crash. Fix it by detecting if complete() is executed, skip the rest when not. Link: https://lore.kernel.org/r/87a4uvw066.fsf@pond.sub.org Reported-by: Markus Armbruster Signed-off-by: Peter Xu Tested-by: Markus Armbruster --- net/colo-compare.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/net/colo-compare.c b/net/colo-compare.c index c356419d6a..bae9d9c07a 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -1416,6 +1416,15 @@ static void colo_compare_finalize(Object *obj) break; } } + /* + * If this object is never visible (colo_compare_complete() not invoked + * or failed), skip the rest. One path to trigger this is QMP command + * qom-list-properties. + */ + if (tmp !=3D s) { + qemu_mutex_unlock(&colo_compare_mutex); + return; + } if (QTAILQ_EMPTY(&net_compares)) { colo_compare_active =3D false; qemu_mutex_destroy(&event_mtx); --=20 2.53.0 From nobody Sat May 30 19:21:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1776969186; cv=none; d=zohomail.com; s=zohoarc; b=GpcyzkqvGGQcf3AWMtdnXUpCEuEVFJFk2Q/rzqWzyfUfARxXAlkqGrg8DTOpUE5Lxi0ZEEKZvTiqltJMF10QtBTIE9bdl7dCq8FWKkXTL+qd+ERVPpkpxSC+MVTBMq/AIklI9uEUPoUSUsvyMgqX/O1u3Fm/goR7rtIPHIJcEPY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776969186; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=O4TOxFz2OPjQ/+oQDmc3kby3Xa/zYowkiRjWGoIPwB0=; b=Qz+3ZBFOKyAqwk08Vurjf2QG8RMmsK8hQFdH1GxSc5HaUs15nq7sCJoVgrNVEGMX/5jIUazRMdaFgWsbslcAxRpPXY9qq+Jnl1hWtJL56yelPpBuEkfHJ3UY3jMlm5CG6qshmCZ0ISg3EARCvJG7MahW7T7xqJyCNVZwZ9LjQI4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776969186313413.31679885932465; Thu, 23 Apr 2026 11:33:06 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wFyqq-0003dU-8R; Thu, 23 Apr 2026 14:32:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFyqj-0003cW-Dh for qemu-devel@nongnu.org; Thu, 23 Apr 2026 14:32:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFyqh-0001KY-2p for qemu-devel@nongnu.org; Thu, 23 Apr 2026 14:32:28 -0400 Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-642-dP2DTSY1P128HbBspiyExg-1; Thu, 23 Apr 2026 14:32:24 -0400 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-8a275472d89so106458876d6.1 for ; Thu, 23 Apr 2026 11:32:24 -0700 (PDT) Received: from x1.com ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8b02ae92fc8sm160665566d6.40.2026.04.23.11.32.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 11:32:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776969146; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O4TOxFz2OPjQ/+oQDmc3kby3Xa/zYowkiRjWGoIPwB0=; b=aT8O5QItOrQg96kILQZ91bZ6F/EhYCdkB8sw8As4UyX64nTizdNf4P/0sXCMEsZP5fAkH6 DzG8BFCzzgH9JrizBs1X1vhuWHIMhRhqZXPBJjp5T+HyL4vaF5OweXgXtBWjWL92hiMw4M qZW2W6NJ5qBNQ6ZcVfoa4PzsYV/5H5E= X-MC-Unique: dP2DTSY1P128HbBspiyExg-1 X-Mimecast-MFC-AGG-ID: dP2DTSY1P128HbBspiyExg_1776969144 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776969144; x=1777573944; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=O4TOxFz2OPjQ/+oQDmc3kby3Xa/zYowkiRjWGoIPwB0=; b=Df92nuZ1fhwCHxzub0eWHTF/6sYYOi1eztP7I3zApvmEOg906erANy51grSsr69Sca P9DIHGyC9rndyzKMH4KMSlrQbkVtElovtRQks5m0I7qDJRnD+/VkVfXFLjwgFi40nI2D ym0z5cGjOqlGEWoVDTj2fKUBnIBoUe7FrzGhI1KB1yzX2EQhNbrXNwH786G+dzaVWhVv 10/mM9sKG6OpJiQtEhEcc29hAjsGhizYT1VqPagvT13TGWorByurjoANws9tD7O5YZq3 s9jH6/evaXz3wXLzTn2BrfSY8RyV/KLvHCzMWvZYh4KADEdhEuaKDyWJvBsY8GCslsJb BWzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776969144; x=1777573944; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=O4TOxFz2OPjQ/+oQDmc3kby3Xa/zYowkiRjWGoIPwB0=; b=Akh1adFZCLZOi91wKSPWTa+xhPcYsEPnNbtaE2qPeaoXdFHHUgke9AjJaQns6ma/wv Li7KmuUUwm11zmaGsSbaQHUfFeMHTo6gr05T9lXFEKBDKS0Opr169c9uEG6LmYhPADiO mWMLRR3A+w4IC4wXmBWzXC/AyF9q+w5bGlBGfCoNmChBYrpT/ns9uea7c4rR3Zcxm4Ia CoiSdf6KRSENyUaSHLDG8ny9ROReLoSNUL3BuZC0So6MnOLKK+HorcAs/dBRqMGSUQpd 4rThjDrl3x2q4vDvwbecIPgc0ePN1Zg3BDhlm6OykfjSRYfL8vvqheeIbxTRD5N5mcRA xKFg== X-Gm-Message-State: AOJu0YwG7a2L5udvEQJrvR0uwJBRctxxaPaDiHICcN2krxC0710fx3CB fHJS+l2yuyWlb9HwRCJiz8mpdkAV3cUzB/Ybdcn5st240oSKpYKFkUOWj4LDYqoP7em+b3Nt0FQ I5yy/tPhLyAwl+/V9L5dSdeWGbk/DGG6Evm5LphLB7Feu68IWPKbMvz6dZHelRyChh1W0k6EPCT mO1eYKCLUuk57IBScb1e7qIQvm9m6cNOPY2ftlFQ== X-Gm-Gg: AeBDieuPlyOYortTIB0FyYhLC+s1IdXbSfhsmTSHGTHYt8v+j4AVa8GupWnAj7T8SZV hC3vE42SiWXpmBrR+xHEm9MVQaP4Fpcg38sYPcdleqaTV0pXQCu5oQTcfpGIuza3N+Y4Px6/hU3 WVhAWjXpXWh5+9bdiDsbaKfmthGzdL3unQrIno7eRel/x/uLgba7saOy4ys6FhEordoC6EPyfzI TfECbqs0GFweB1enEvol0yFUUaRAiFB+doWZEAxIp8ZlzBGPeWmzcnZXYEFsAaY6y8OxS/eDbhH lJtonbP2SaNOXEoCFIM8+j0tZQYb7W7AFGi/cocaZpLm8d8jFfoTz70h2m7o5uXDl6oVvL6GVHg oE2SB5l/Rq+TX9DzgD8feQJXU34crQKJtDn8ZRgyNBs7TG2DXVx9rG2g= X-Received: by 2002:a05:6214:27ef:b0:8a6:1216:fb78 with SMTP id 6a1803df08f44-8b02815a617mr443043396d6.46.1776969143589; Thu, 23 Apr 2026 11:32:23 -0700 (PDT) X-Received: by 2002:a05:6214:27ef:b0:8a6:1216:fb78 with SMTP id 6a1803df08f44-8b02815a617mr443042586d6.46.1776969142872; Thu, 23 Apr 2026 11:32:22 -0700 (PDT) From: Peter Xu To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Li Zhijian , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Fabiano Rosas , peterx@redhat.com, Zhang Chen , Juraj Marcin , Jason Wang , Mark Cave-Ayland , Markus Armbruster Subject: [PATCH 2/3] system/ioport: Fix qom-list-properties crash on portio list obj Date: Thu, 23 Apr 2026 14:32:11 -0400 Message-ID: <20260423183212.468047-3-peterx@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260423183212.468047-1-peterx@redhat.com> References: <20260423183212.468047-1-peterx@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1776969188110158500 Content-Type: text/plain; charset="utf-8" Currently qom-list-properties QMP command will crash when querying the portio list MR object. It's because its finalize() assumes full initialization done in portio_list_add_1(). Provide a simple fix for now to avoid the crash. There is chance for a longer term fix, ideally MR should be initialized in instance_init(). However that'll need more work, and that should also be done with cleaning the hard-coded MR operations in portio_list_add_1(). To be explored. Cc: Mark Cave-Ayland Link: https://lore.kernel.org/r/87a4uvw066.fsf@pond.sub.org Reported-by: Markus Armbruster Signed-off-by: Peter Xu Tested-by: Markus Armbruster --- system/ioport.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/system/ioport.c b/system/ioport.c index 9209bff2ea..1a0e01fd06 100644 --- a/system/ioport.c +++ b/system/ioport.c @@ -346,8 +346,15 @@ static void memory_region_portio_list_finalize(Object = *obj) { MemoryRegionPortioList *mrpio =3D MEMORY_REGION_PORTIO_LIST(obj); =20 - object_unref(&mrpio->mr); - g_free(mrpio->ports); + /* + * This check makes sure any random object_new() (without doing the + * rest inits in portio_list_add_1()) will not crash when finalizing. + * One example is QMP command qom-list-properties. + */ + if (mrpio->ports) { + object_unref(&mrpio->mr); + g_free(mrpio->ports); + } } =20 static const TypeInfo memory_region_portio_list_info =3D { --=20 2.53.0 From nobody Sat May 30 19:21:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1776969203; cv=none; d=zohomail.com; s=zohoarc; b=MQWnToylxEiQencyWTcb6XkqO3Ycl8NoXKydWqRIDKhGIkImU3kHyiuugal82v4yo+xjgdkb6WO+qn5vVR4QQzfjk/e0EcCQzXkJGv12L2Drfgpdu8pjSlWNL25jbG/j8aHB1OodYS3z34GQv9cwPznS+gjCEvPZIZrecStBHvc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776969203; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Vc/pJGjkgyWmQP2xxj1GO1bV3g12ILLASq9+yGdKiXc=; b=OUuFg7FC0zQtUBSvlSNuXPvHfnNgPTKloKT2h00atmIKn1Ftrn/dhBrpjfWW3Z5fP0SCaGiug8TBUhYHRA+onmrxYrnUhOWX4HFkK+UVOHlaOyR3s4CHwIE93uR7V9cXNeime7YbJ+VCea7aR9Av1ghw7pPBFkz+FVC+sUhk6/c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776969203971505.82058230606003; Thu, 23 Apr 2026 11:33:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wFyqt-0003eQ-W4; Thu, 23 Apr 2026 14:32:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFyqr-0003dg-MO for qemu-devel@nongnu.org; Thu, 23 Apr 2026 14:32:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFyqq-0001Lm-58 for qemu-devel@nongnu.org; Thu, 23 Apr 2026 14:32:37 -0400 Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-443-atrXGNEUPUOcnYAuEOsHfw-1; Thu, 23 Apr 2026 14:32:26 -0400 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8aca4660827so202096256d6.3 for ; Thu, 23 Apr 2026 11:32:25 -0700 (PDT) Received: from x1.com ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8b02ae92fc8sm160665566d6.40.2026.04.23.11.32.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 11:32:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776969154; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vc/pJGjkgyWmQP2xxj1GO1bV3g12ILLASq9+yGdKiXc=; b=bmslIhkO5jFNHPNc3qlPoOFhRg1+4qwESMDbfv5sQmcafrczyAQJ5gLeJC/NqjfeAoGarA gsFBr57OJ91BdHce/C/Do0AhkVU7pqM5ucYT7x39i4IZfNy54maeabp4YgHQpQ/BERs8B0 GcY9MDjv+e9IhJrXvbHcyVyjiuC02rM= X-MC-Unique: atrXGNEUPUOcnYAuEOsHfw-1 X-Mimecast-MFC-AGG-ID: atrXGNEUPUOcnYAuEOsHfw_1776969145 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776969145; x=1777573945; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Vc/pJGjkgyWmQP2xxj1GO1bV3g12ILLASq9+yGdKiXc=; b=FvB+vSkohgwRYE+GYPX+t+mSNfuNnVmclrTraztq8sn7QSQdc7MRTpwV1LpAaNfDxZ dxtwAJE1wRtw5GJu4AfEFhOrmzZ+sfBQ8MvToNXL6+H1helXPEqVw86IwVEykMv5wB5A rX2+y2MmLeLEhEEFgQmFqsQeTNchYr3GG+7y9Urt+PO0NVXEy2+Pwk8rSJv9c2anRuiD YK/Fu0HYTvXdUmQeIRdnNj8XN9xaCdOQuw0J/vk8aQykxCV8BnVqSHykfwgFiVl/5v/I ney6zIMw2q39ioF6BLk3JXsg6EEiDM5gBv3x0sj8snpaKgxB0yYFXIqQy9jC9Z0OSsFI 9g+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776969145; x=1777573945; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Vc/pJGjkgyWmQP2xxj1GO1bV3g12ILLASq9+yGdKiXc=; b=VvAEp3pHximMr8QfT9Gnj/S8ORIdOQ+jvm2xYFS20R9Qz6eWunM2HLt7RMVnC39ux0 w4Yo9hu5tFnTmGV1wiiAOF06e//VTpU3CrXob0Bx7SGSYOBdTVQlBNI7eN6cREliG0j3 clLEcr0xTYOPMdvqLk5adyvHLToS+empl2P/GAwP4+kBVdPCVEFVt7D0+/xMod7uVjU8 +qi+W+TkwTi6qAQkGMKUAaNSNVfxo/ECy1/lEe5R2OwnwBPaW0rlznJpWQfhW5MMu3DO NeUzZs+P8zjNDIKl85/mADCXakotkLRot/5o963sumUIwpJoFejzX+9bmv9vYTjiFTMQ WrXA== X-Gm-Message-State: AOJu0YxrwDf0wxXs4Uh89RxV6QXMvDaJPgg2nHIffpQC5QrwwTeXVKAb FH+hmWHzPpkvsvIjRwMeKcGwO00IM71/PAYvQlvBfHITs6V7FHNdHv5aNL5pNkdmuePuhxIbwRy 3cpAXemBabR0uulXO1rGIoMnAAu8PZD+bAkkhZHwAYuiCCeDGMem5wAHsmLWKb5yI0T04lovbvl /yW8xGjMF4wIqrI7zDs0mcR3F80hcjJddenW/AIA== X-Gm-Gg: AeBDiesp/gRil08oHpUooaL9p/oRkQon7wgP19JwcZ5o/9nBZSpq48J4KazS3km4ddM 3ulcUZShAjQ4hbWESLHUj/+t36fbC+lc+PG/rbjnTt4imoyPP0iQgocUa3Bm15cFLaWT7jUSjHY j1U96rQKcqS0Cty/aL7WCRo7F7foUa9B9jwh0yDjOwNDkfM6ub8kRQMKSAfpgz9VGjy/4WM3mI2 qwybj0H3wOKKDb6uwxxLKMHPzZxLwIc7a7k2/qVI70ozhYNMADeUwIRWK8PV4fDf2NXuHaI8Yv6 kRazfqQDSCNzW5g+48w9nMeY1HSmA0mizdBZemLXp9Wb15YvYgNm64GHltcP+6ZRMdcP6LUmUPG Ql3LlV/F4DO+ePsLVQBcJscdtvh/yc7N4BiYU0xKz0cuZHInkERv1ai0= X-Received: by 2002:a05:6214:20ad:b0:8a7:e3fd:4d8f with SMTP id 6a1803df08f44-8b027ff7df1mr414627306d6.8.1776969144877; Thu, 23 Apr 2026 11:32:24 -0700 (PDT) X-Received: by 2002:a05:6214:20ad:b0:8a7:e3fd:4d8f with SMTP id 6a1803df08f44-8b027ff7df1mr414626366d6.8.1776969144212; Thu, 23 Apr 2026 11:32:24 -0700 (PDT) From: Peter Xu To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Li Zhijian , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Fabiano Rosas , peterx@redhat.com, Zhang Chen , Juraj Marcin , Jason Wang , Markus Armbruster Subject: [PATCH 3/3] qio: Fix qom-list-properties crash on net listener object Date: Thu, 23 Apr 2026 14:32:12 -0400 Message-ID: <20260423183212.468047-4-peterx@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260423183212.468047-1-peterx@redhat.com> References: <20260423183212.468047-1-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1776969205864154100 The QIO net listener object will crash with raw object_new() then dereference the object, like what QMP command qom-list-properties would do. Fix it by moving mutex init into instance_init(). Cc: Daniel P. Berrang=C3=A9 Link: https://lore.kernel.org/r/87a4uvw066.fsf@pond.sub.org Reported-by: Markus Armbruster Signed-off-by: Peter Xu Reviewed-by: Daniel P. Berrang=C3=A9 Tested-by: Markus Armbruster --- io/net-listener.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/io/net-listener.c b/io/net-listener.c index 9410d72da9..a772756eb5 100644 --- a/io/net-listener.c +++ b/io/net-listener.c @@ -35,11 +35,7 @@ struct QIONetListenerSource { =20 QIONetListener *qio_net_listener_new(void) { - QIONetListener *listener; - - listener =3D QIO_NET_LISTENER(object_new(TYPE_QIO_NET_LISTENER)); - qemu_mutex_init(&listener->lock); - return listener; + return QIO_NET_LISTENER(object_new(TYPE_QIO_NET_LISTENER)); } =20 void qio_net_listener_set_name(QIONetListener *listener, @@ -440,6 +436,13 @@ qio_net_listener_get_local_address(QIONetListener *lis= tener, size_t n, return qio_channel_socket_get_local_address(sioc, errp); } =20 +static void qio_net_listener_init(Object *obj) +{ + QIONetListener *listener =3D QIO_NET_LISTENER(obj); + + qemu_mutex_init(&listener->lock); +} + static void qio_net_listener_finalize(Object *obj) { QIONetListener *listener =3D QIO_NET_LISTENER(obj); @@ -462,6 +465,7 @@ static void qio_net_listener_finalize(Object *obj) static const TypeInfo qio_net_listener_info =3D { .parent =3D TYPE_OBJECT, .name =3D TYPE_QIO_NET_LISTENER, + .instance_init =3D qio_net_listener_init, .instance_size =3D sizeof(QIONetListener), .instance_finalize =3D qio_net_listener_finalize, }; --=20 2.53.0