From nobody Sat May 30 20:11:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1776940268; cv=none; d=zohomail.com; s=zohoarc; b=c3taezZURru1RFA41nZT+KTjsALM5h6swgM4fU9mT+ZLJQuRgB/sy81xJ0l4FROxyN/7RBn0ivZiyWX1inHDUWDFTOV35Qgsue+04eCF+XAJGHRQ27S6cHTkcEKgEgTJnAxSJCXBac+yoaI+pbELo1KptkKcA0Ps/4gvr3OZOkA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776940268; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=uYphRU7kz9gFoWjRUHCk/rn7ErgA8kbffjc6IiVv/rQ=; b=nr7XUaLm2LMlaGX0x0PS5FiZGHIFU72n8yWV+nbPdLtK94NvL4jxMNEkUq/LVyJP3wky+/7wGUtdLmO/sjrjRP+l+KWaAuM46PIDID6U2CCmB2s2Oxduo71n9OMjI7XDJJwHf7YAajIjAk5Tv0ly1O3XEBNiwsdO/j3xPQL1EDM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776940268912887.2510235890487; Thu, 23 Apr 2026 03:31:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wFrKB-0000bz-VV; Thu, 23 Apr 2026 06:30:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrJU-0000Vu-63 for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:29:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrJN-0005GL-EI for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:29:36 -0400 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-135-ni9tgMkpNsCfJSClubtazg-1; Thu, 23 Apr 2026 06:29:27 -0400 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-48a5952c635so20519725e9.2 for ; Thu, 23 Apr 2026 03:29:27 -0700 (PDT) Received: from [192.168.10.48] ([151.49.85.67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488ffc558f2sm377062475e9.1.2026.04.23.03.29.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 03:29:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776940169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uYphRU7kz9gFoWjRUHCk/rn7ErgA8kbffjc6IiVv/rQ=; b=PyLG/P/p6h9ny9SQJGzSlG51tlr6snoqleAwsJq6uxnPvU3pPScTEpnvEaqSLu4Vq6At7f N0Y6AVltEzfVKxtbeIsxce+UA/hlB0ty0sni808uU5HGsr6Xf9oTQh77gPPR/fR91ZjEaq 1Dlewt8mI7ns+9RuzaXSwP4StQ9BD8o= X-MC-Unique: ni9tgMkpNsCfJSClubtazg-1 X-Mimecast-MFC-AGG-ID: ni9tgMkpNsCfJSClubtazg_1776940167 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776940166; x=1777544966; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uYphRU7kz9gFoWjRUHCk/rn7ErgA8kbffjc6IiVv/rQ=; b=GWoE0j6LRtyt9B71l7KVVRhFDAFzSPKviZEPVNOjaKq5yAKdsc7lIFKWyJlQ2iPG6z w3w4+hnf23nqvIhU7smThoTfiFLchQudlzEa7rFYm3pqOUK1PY1VhhWlqat3nDXtA9Hb 5OQ55flVqPG4XgeyIzhfjDLTHXrMCInTK+0hzjPmsG5e5crB/JZkAH458r3iFmh9AHFq rgnoB0zx3NCN71dRYMAkPvcqrGDEJSgqJO21HY2r1t+wdA5qN55P1ly9I33HZW8y11mi ugfF29lQuwtguBEFdM0E+tLUOYqdUpLx15ZuPbSATlLl2hnAGsxIqw8rgxgCNr8MAj2Q zL9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776940166; x=1777544966; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=uYphRU7kz9gFoWjRUHCk/rn7ErgA8kbffjc6IiVv/rQ=; b=GmCQx3I93wpOSqYWH+tnydioXHh8P+zke6p00b/eY7KfiksHUj8yiiNmTsvfGnQImR 7Gl4gZctQmuI9NA4YtBJFLY2KlRwiWL/JeUP8vGzaMGyYpszs+DTZMIb2sB/xPx+AR4w R+b0JuyQO+ih48FN9wGmoVf3UC/w55iZ0hFLd43SKxVqa4/Rmw30lfYazUgyZwj01v1m Vagj0t0kz4c+qteC+UjbRZnLr7ffywUORQJqOK5zRIxCSq3eeYwTaMoQlhfV+H3/dMRQ qnhpId+gqlh50jlIdv6zatsvQKU0B2ihZU6eWIO7YHEoykrDm4YVx8YNUKaPH/xg52q0 SdtA== X-Gm-Message-State: AOJu0YyHXTLHnTvvK1sfN+5lgv7ZoCORaKmzntATQMLW4ld1vreuQ5lw Ww1qLs64bzD7u2ecK/Diny43/JbzGWMudgLLzQUTu2B1uTGY0lyNX4aQHzqvAUnZUe8ikOCFY61 lb2OaCEwGb+XUBIVy1juX0n/ovkWNN41EZ0mYtc5hTZKYTW+6z/eweRyJHPb9GPIqnE4dgqurDV 3LGEH8WfdCfcKWqz3KOlWE/ceCUw3pA3lzt5fJb0ly X-Gm-Gg: AeBDieuqU7GNl7LqvayXM8b/eRHcG4H+r5uvcoOGFOKDXC+KShuHVXpf/zFtPNphhV9 cZa1HIMhd/ns0M2o401vOIFPJQbD3OS8P9gp8zxG2MYks2Rw+YApqZuVvyj1p7hJ1L6sXlUSnut K6Ao46YMpKbRTy8PSHVacpuDz78w+bfDwNqHJ8n/ltu2257t2f/0V+RLwhnLOy61ZFQtLJ98YO/ 7H7N9ihY3ThtF1aryuIInnAPw1nh32h+XM0oaJfMEe/GOX2PeFEwGaZNdtY8c89UtkGose/f3Mi TVWxTonXbFjhcLyp+ZGLQ0p82XRlLFm63m3JQG2HhA9QTE7RrWZyrQZ45VM3jbT3sshmLsrmaeD fs7OEKJgnn2lM77d0Iza36gH4ZqCVe8ClmTHMVxsfO+Ij77mdukAA9xSTiP/BY6khwLb9Owp3ED dgCoL2ib1iKBmzaLutSBRyVqpZ1nPbN4cCZuc= X-Received: by 2002:a05:600c:a40a:b0:489:1ba8:5bf0 with SMTP id 5b1f17b1804b1-4891ba85dc1mr217400795e9.21.1776940165994; Thu, 23 Apr 2026 03:29:25 -0700 (PDT) X-Received: by 2002:a05:600c:a40a:b0:489:1ba8:5bf0 with SMTP id 5b1f17b1804b1-4891ba85dc1mr217400565e9.21.1776940165543; Thu, 23 Apr 2026 03:29:25 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , qemu-stable@nongnu.org Subject: [PULL 01/25] target/i386: fix strList leak in x86_cpu_get_unavailable_features Date: Thu, 23 Apr 2026 12:28:58 +0200 Message-ID: <20260423102922.443639-2-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260423102922.443639-1-pbonzini@redhat.com> References: <20260423102922.443639-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1776940271661154100 From: Marc-Andr=C3=A9 Lureau The result list built by x86_cpu_list_feature_names() was never freed after being visited, causing a memory leak detected by ASan. (the getter visitor is VISITOR_OUTPUT kind and doesn't own data) Fixes: 506174bf8219 ("i386: "unavailable-features" QOM property") Signed-off-by: Marc-Andr=C3=A9 Lureau Link: https://lore.kernel.org/r/20260413125040.3842686-1-marcandre.lureau@r= edhat.com Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini --- target/i386/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index c6fd1dc00eb..9d126600c05 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -7842,6 +7842,7 @@ static void x86_cpu_get_unavailable_features(Object *= obj, Visitor *v, =20 x86_cpu_list_feature_names(xc->filtered_features, &result); visit_type_strList(v, "unavailable-features", &result, errp); + qapi_free_strList(result); } =20 /* Print all cpuid feature names in featureset --=20 2.53.0 From nobody Sat May 30 20:11:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1776940270; cv=none; d=zohomail.com; s=zohoarc; b=Y57HGxso0tnS+oi1+vkkBoCcAHb4JswnfahHipCn/hdEKjcHX2K2ViLj0FZzLMRcWOR+fX3X0m5bEyOL8rzqAOMEBiYw8B4nYO0HHhlWOQO2heNxECjfC3b6V9KJFKm8XcP5F9syUmsKlfNUY5si+ddJeaWW4h9yK9W+bgX1f+o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776940270; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=wp33Zu4qX2y8IsRyjTpZaoSUC9xqRB2bWLr9ktJjOXU=; b=CaiC4hPGTqz8/Q7XvZj7TKEqwDODi92/R6vjUHG69a5QMN2LxWSrw8OKh4N7JvKvfj82zbojlcn2j2qSQYyxv9TlgLJJIyXbRkThs1jPnpAuAyMvEQ02OJeSB573bDrGDHU5XpZhls26Fj5B4f9geTBH/yH5rqB+7NnhshFoADA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776940270260275.6642191657912; Thu, 23 Apr 2026 03:31:10 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wFrKk-000118-Mv; Thu, 23 Apr 2026 06:30:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrJU-0000Vw-76 for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:29:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrJN-0005Gf-EL for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:29:36 -0400 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-127-_02stSVoNa20Kzszx5lWvw-1; Thu, 23 Apr 2026 06:29:29 -0400 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-488dcaf2f2fso52902285e9.0 for ; Thu, 23 Apr 2026 03:29:29 -0700 (PDT) Received: from [192.168.10.48] ([151.49.85.67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a5549f582sm64450985e9.33.2026.04.23.03.29.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 03:29:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776940171; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wp33Zu4qX2y8IsRyjTpZaoSUC9xqRB2bWLr9ktJjOXU=; b=e3TTqoB53qAyk+6vnR/GgyqugX8Qky95l3gHxMoeGlTilh93WHowXkq1hqRwdRJFKItKmb 3OY4yQyOzRAx6+aaSc1yNJ9Dm7N2loPOkg2GJl1ieXQADQDpoonNzZSj4Frfp7ew1qG0wZ EaL3r9orndvS+Ci2xRnmPmLCRP5qTGE= X-MC-Unique: _02stSVoNa20Kzszx5lWvw-1 X-Mimecast-MFC-AGG-ID: _02stSVoNa20Kzszx5lWvw_1776940169 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776940168; x=1777544968; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wp33Zu4qX2y8IsRyjTpZaoSUC9xqRB2bWLr9ktJjOXU=; b=rqJYVfThLjWhJcs2j2khdSgRg48jmr+tMQ29M01x2ESkLa+RFUgsoSLC6hH900l857 pEjf51MPJPJIhqiS783ayoRYsaEOx+E9GJ+1at5wJtJK7SCs2rmLSdjoDT7VI1DdV1q+ OJwRVpioclSDX4G/HCVgmNj8fueW2krlxys5iZ3v0fHIungLB5JKOHLPXVdcNp6aClQI bcNnd/U29fvfzm7i/p8oUM/UF618mt80x2XfbEdpKE/YeLewCrzf/6sxl3Q20WeBQCu5 a61HMEhtRKl7De/GWqvI+9r/xbr4jn4itlSgfrSZ3UWmhWjB2mOnh5X6BQk5aStBoaXI N6jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776940168; x=1777544968; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wp33Zu4qX2y8IsRyjTpZaoSUC9xqRB2bWLr9ktJjOXU=; b=A56nLrdg4pD/y4TvYdufDR6DThZQXPmiKLJ1j485Ad44QMH24DvncYwkNpqnTHV2WL aaZsF6phdYWfmXYGyGeM2lMrZsGv9+dmBzces9YeXbDqWhUvosKFEPJck4e1SFe1Dfjd 0/XmqNF5gMRj7Gf2MKeJW93fbDGqMLYCOx6Ks6P6SdYS79LBFzq2OywuaJujiSHreilE vbx6jJ0pDoqUUC2I725F+3Xn8iVITcjyG/fQHapZyJZaZBCvsed42ArYCektjoqlR4o8 aSKfI5K+2gX53BJLgbcvZnDtRno3UhkqdqbggGSt9LdBs9GaGKHmMGHz0NduQlUgGuES XgOQ== X-Gm-Message-State: AOJu0Yw5mxTMGB7Bmizs0auBSXz2IiCUfj2/jca+SnDLlrkKAnU1o0Kt KwNNfVQuoII3gPx/LD5qbKcSDGnLXwtCUw4rZZ1o25R9StD2t+QbkB0TD3eufyIZUFwLnoo/GnK C+8UbZfOLexmPBLA6+NlL6A5JAABajAgI9JlszA8ed0IuWIbE+wQiU4uimkmZ4dBhPYTCWdZyBH umqB32evJVq7s3CqsN0FZREZyP3MnA/ZUxzmRjC2du X-Gm-Gg: AeBDiet32hxGRW7yD3CsKnhxxJWtSMwF2lRKeAr2N/5BaN9Ihuf6grdjfR6e8+ven0s q4DmgKU1G4CUMnFHKTFMsnG+CJxj3HTKhO97vWkgtE2bhm2o5Hp+todD9WEB8ZjBmkhnYiscSdl vYg2jNKJ/Pal3tA6k2g6F05k8mHOq2ZGsq8D1TC/DUYgPygmpVzv+A5BZxwZVkn+2Yn44mnb0hJ 38nRJO40XD5J1ckuzbFC+GeZRynBNWQmIE1IB7SkswyexZBCuKAnRSnD7M/4y/nr0YuvnwxgGhj sDoiACvJRXm+kZKOywxp2en/C7SfjpXO8L+jt2TDxZsD5Bak2/gN3GJCe4jjC4t1JNnDQY3CMhP e05XUXrRj4faV5Cg/lqg1fcq+enE0zkguUCme8yAU3yz9YyH1SZP+j+9yhL2tQTTnvSBWLB496c fjOk9TUYoup9aKqaCd3BT5G8YlsH0hB1w2pxE= X-Received: by 2002:a05:600c:c108:b0:488:a82f:bbb6 with SMTP id 5b1f17b1804b1-488fb78e576mr259686055e9.27.1776940168151; Thu, 23 Apr 2026 03:29:28 -0700 (PDT) X-Received: by 2002:a05:600c:c108:b0:488:a82f:bbb6 with SMTP id 5b1f17b1804b1-488fb78e576mr259685645e9.27.1776940167591; Thu, 23 Apr 2026 03:29:27 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Simon Scherer , qemu-stable@nongnu.org Subject: [PULL 02/25] target/i386: fix missing PF_INSTR in SIGSEGV context Date: Thu, 23 Apr 2026 12:28:59 +0200 Message-ID: <20260423102922.443639-3-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260423102922.443639-1-pbonzini@redhat.com> References: <20260423102922.443639-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1776940273647154100 Content-Type: text/plain; charset="utf-8" From: Simon Scherer When running linux-user emulation, the SIGSEGV handler does not correctly set the 4th bit (PF_INSTR) in the error_code variable of the context argument (context->uc_mcontext.gregs[REG_ERR]). Because this bit is never set, guest applications cannot distinguish if a fault was due to missing executable permissions. This patch ensures that when a page fault occurs during an instruction fetch, the PF_INSTR flag is properly populated in the signal context. Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3384 Signed-off-by: Simon Scherer Link: https://lore.kernel.org/r/20260413115622.160212-1-scherer.simon89@gma= il.com Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini --- target/i386/tcg/user/excp_helper.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/target/i386/tcg/user/excp_helper.c b/target/i386/tcg/user/excp= _helper.c index 98fab4cbc3f..6c5df5e0e88 100644 --- a/target/i386/tcg/user/excp_helper.c +++ b/target/i386/tcg/user/excp_helper.c @@ -36,9 +36,10 @@ void x86_cpu_record_sigsegv(CPUState *cs, vaddr addr, * signal and set exception_index to EXCP_INTERRUPT. */ env->cr[2] =3D addr; - env->error_code =3D ((access_type =3D=3D MMU_DATA_STORE) << PG_ERROR_W= _BIT) - | (maperr ? 0 : PG_ERROR_P_MASK) - | PG_ERROR_U_MASK; + env->error_code =3D (maperr ? 0 : PG_ERROR_P_MASK) + | ((access_type =3D=3D MMU_DATA_STORE) << PG_ERROR_W_B= IT) + | PG_ERROR_U_MASK + | ((access_type =3D=3D MMU_INST_FETCH) ? PG_ERROR_I_D_= MASK : 0); cs->exception_index =3D EXCP0E_PAGE; =20 /* Disable do_interrupt_user. */ --=20 2.53.0 From nobody Sat May 30 20:11:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1776940268; cv=none; d=zohomail.com; s=zohoarc; b=SKpxQsxQwdn2ZEEQcYytl0JaN+UcKGPhI06J2t/MTJHDs69xumCJEE1NlDUoOd3f+w+S8w2ZrBIesJZwLP0163srmUU9q+funb9voFigTRyCW66WBgCZ2E/T/Klr3fe49Ouye0Qvfz1YMHUUcQKi209kI7BNw5Jt4wayfc98DOY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776940268; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=bLxexF+6kBYyQWr2xc6HvpRiGk0E/Hk77bvEsEzd9Xo=; b=D85JWQjaVgW0pQExxfJ63vhjte9tKo/KRVX9bWHPi52U1/gryxK6c6JzXNanXq8u+/rt4KfCGtaZSiAVKnSaQSS9f+7/MDx1uoeojVdqUUtSjBzKkyop5qx/0Uf6HmsVjU+8ABH6BvvC5ZhPuqn8hm/3nXYUQYMKSAn6eYvjIBE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776940268677694.9357613187026; Thu, 23 Apr 2026 03:31:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wFrKb-0000pv-Ro; Thu, 23 Apr 2026 06:30:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrJU-0000Vv-6F for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:29:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrJO-0005HP-Ui for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:29:37 -0400 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-441-ijUCVcYZOJiVQ6Q3aRJdEw-1; Thu, 23 Apr 2026 06:29:33 -0400 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-48a55d82e0eso21134625e9.1 for ; Thu, 23 Apr 2026 03:29:32 -0700 (PDT) Received: from [192.168.10.48] ([151.49.85.67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc0f82bbsm875435925e9.3.2026.04.23.03.29.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 03:29:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776940174; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bLxexF+6kBYyQWr2xc6HvpRiGk0E/Hk77bvEsEzd9Xo=; b=FZzSXdwunZru/7UAR32X6cr3eYfYqbQgrN2R7+eXo0mmPk8NJIzJexoV1h+Jap8vZ73OHT yKeN3JiQg2GJKdm5yYa3vqOZ2qWvDonKEwtYtK+A43LR0kelAlsncCrXeIzstMW9i8+xSt AAQa+VqED9kUJFEXM6jKNsFHUHYgv1U= X-MC-Unique: ijUCVcYZOJiVQ6Q3aRJdEw-1 X-Mimecast-MFC-AGG-ID: ijUCVcYZOJiVQ6Q3aRJdEw_1776940172 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776940171; x=1777544971; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bLxexF+6kBYyQWr2xc6HvpRiGk0E/Hk77bvEsEzd9Xo=; b=PVpJxZsjKop5CN3bVaLOQ/t/nYfcjUmS1Bt1x3R9kxkH7xsdjiEAJg4ZM9+nSl5HDr z3A9GeALTo1xv5UrAf5Ra8Emzs+bSkeH8gx78qXEA/43Pb5RvGlOOtxzL5Ay3rajePC/ uQP0Pl4wLFc4vW3t29w5lFluimidw208eYpL9nrzqCmLaG/hAeG/G325TOCj/6Yac/MK p+dMXfskX5Vrdl83vZnFllkp879JGESentqSELs8ak/WX5D2UyLsRaXEBKUWrUoTw/ai b758i7sD/Fr3dUIVlLdSpxk0C0kHcA1ZJm7SmVy5Zyrx3UzgP8a95Xp2UuXJwB1uoQKp muBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776940171; x=1777544971; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=bLxexF+6kBYyQWr2xc6HvpRiGk0E/Hk77bvEsEzd9Xo=; b=lX11/Zk5e6R3/gHKIkhl66SAp6SRk22vFyZ+bVOHw0zhQQtBIGrpTu9czcGxWegsT5 3VbNXB+rwWXBIGQ1FpPeTlNLosHPStmyaPsXdGzCxWne0YLx1VOz4xut3egEar/HA4Vr X/PMYHmsOulzVuyawZUK7pqXOdG8BIuC8/N/FE60ShNjdf3yqyhZIB3Rom+cWDlFZEUC Lv9zulMKeAbocvW5Xl0WECipuqi3XN4CfFUkA3y4aWz4ktwNRK5CUEKv8j+RrB54pV6r sGADiGjWcvK7tWF2I1vjJEFTR63V1k06JDvoyS88o2Sla22Z5WQLnr5JV/8Rkg5k5gSh dkig== X-Gm-Message-State: AOJu0Yx+17GYcOBOT24wWE0NMX6CDFFCyVhJfAuP+Dr/eHVlqx8Y0Oel XgBbAJU8NSE/hU9KGGMnI9edePic+ay9ZDhFSGRNxIuyS5FfG08lySoQSjBxlKXWUTn+hxIXqTo AkWEp+QwJtIgDnU/MDQAif+lHPvPhQ0EAIya4XxQxGN1x9ZyMPuF04T8/cusH62WX0rNAvmrazq wHvm9MsspOHnIlN/tzQQYA2DehiMkj95xXkm1y1j9X X-Gm-Gg: AeBDieuPH4/5yY5obbNjh0W/6VRT6Bz9/9HnUNcY4j8Rt3K9AHfHv3gAE+7Z1updolN t5TlQfPjAkGSl5bS4vrhuhE15Xc/hnuUswsE4fhPlUIDybZ6b+dyZJu+TDQidcHlXHKXUUML6RH pzE4OFKHopPZ/NLHlPd+XjFMPa5ACMPZ3drdaWx2X9iwmEJSgsKm1IUf9btTHOk9bW7RpOq0H7l Fk8RVljnwm+8hxUK4ag8xqddDkEfVLziK0ZhTlvBu0E8GOU4o4KFuc9QTfqmgwgFN+T3V9v+iiY WuKxxgcswW1XMClutSqH9OtWD6KVmolnSj7I/F4bqoTwDTEu1WCm3RlPFHIndH5fLYp77CwbN+2 lTECvZvpRMutIWgj/FJG2Tk1HHzdYtnp9SyGkborIeaRlDLLJqW37caM26MPdaw01n4/L8JmF8n Z064qBWmrw5Qb8DVNPZ4tFxoECJpJezdavDYg= X-Received: by 2002:a05:600c:a30b:b0:485:17a7:b9c7 with SMTP id 5b1f17b1804b1-488fb750a2bmr261298475e9.10.1776940170704; Thu, 23 Apr 2026 03:29:30 -0700 (PDT) X-Received: by 2002:a05:600c:a30b:b0:485:17a7:b9c7 with SMTP id 5b1f17b1804b1-488fb750a2bmr261298145e9.10.1776940170234; Thu, 23 Apr 2026 03:29:30 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: rickgcn , qemu-stable@nongnu.org Subject: [PULL 03/25] hw: i386: vapic: restore IRQ polling for non-kernel irqchip backends Date: Thu, 23 Apr 2026 12:29:00 +0200 Message-ID: <20260423102922.443639-4-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260423102922.443639-1-pbonzini@redhat.com> References: <20260423102922.443639-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1776940271664154100 Content-Type: text/plain; charset="utf-8" From: rickgcn 69dfc078 extended vAPIC handling for WHPX with user-mode irqchip, but it also changed vapic_write() case 4 in a way that excludes TCG from apic_poll_irq(). Before that change, IRQ polling happened whenever no in-kernel irqchip was active. After the change, it only happened for KVM or WHPX with a user-mode irqchip. Under TCG, both kvm_enabled() and whpx_enabled() are false, so the poll never happens. This regresses 32-bit Windows XP guests on a Windows host with -machine pc-i440fx-10.0,accel=3Dtcg, causing a STOP 0x0000000A during boot. Fix it by making the decision depend on whether KVM or WHPX is using an in-kernel irqchip, instead of whether either accelerator is enabled. Fixes: 69dfc078a6f0 ("hw: i386: vapic: enable on WHPX with user-mode irqchi= p") Signed-off-by: rickgcn Link: https://lore.kernel.org/r/20260418061429.16898-1-rickgcn@gmail.com Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini --- hw/i386/vapic.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/i386/vapic.c b/hw/i386/vapic.c index 41e5ca26dfd..1acb9f91b2a 100644 --- a/hw/i386/vapic.c +++ b/hw/i386/vapic.c @@ -716,8 +716,7 @@ static void vapic_write(void *opaque, hwaddr addr, uint= 64_t data, break; default: case 4: - if ((kvm_enabled() && !kvm_irqchip_in_kernel()) - || (whpx_enabled() && !whpx_irqchip_in_kernel())) { + if (!kvm_irqchip_in_kernel() && !whpx_irqchip_in_kernel()) { apic_poll_irq(cpu->apic_state); } break; --=20 2.53.0 From nobody Sat May 30 20:11:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1776940349; cv=none; d=zohomail.com; s=zohoarc; b=IOoD2DvLP0HjbmgAm73kNJ0fM5VKmDuj8TeT7kcYEIKCmQLQuSfrjMzXdisph1DDeXnaZ1D/VxOPFHUucwMT7ehTHehLuzr9YOjtBify2lHmAxh0wOzR/q5bn+W7JfqARbvyoCPz9jG5KDC1+FVnPGqjybvAGl/7dOg/rXRttbw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776940349; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=GkiSAJE0vQoiSR4PIKYvL4RDNMj7yYo++qu0kxfwAkc=; b=H1tw77AguGmHwAxKMSsyQEHDhno+TNBL7h70RrG3YOqbp86hpieJfnzGTo/D15GAD5p9jRTVBzBlqp1KoawW7HJkJmdb2+TYJZDavDDKyS+9HmyGfPxrZ76XiQ0e7T2lMoe49yDKJIVL7B5aOb4nhv7ElSwLZX4kl2eHwTFpUW0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776940349230319.2348450712227; Thu, 23 Apr 2026 03:32:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wFrKj-0000xf-9m; Thu, 23 Apr 2026 06:30:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrJW-0000Wp-2L for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:29:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrJT-0005I1-W1 for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:29:41 -0400 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-517-osxRmsUSMy-Z9fvA87m6TA-1; Thu, 23 Apr 2026 06:29:35 -0400 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-43efc93e4f6so5207748f8f.3 for ; Thu, 23 Apr 2026 03:29:35 -0700 (PDT) Received: from [192.168.10.48] ([151.49.85.67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc1c0354sm478940715e9.11.2026.04.23.03.29.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 03:29:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776940177; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GkiSAJE0vQoiSR4PIKYvL4RDNMj7yYo++qu0kxfwAkc=; b=CnV2jSAU/jY7+Eo6zABVlffhV8uILsxFyJAnsm2S3ngU3ojj8R60qXVHY27wj/dm19X1n3 wG2lC8jrV6ziKVmp1nPjMEX/RDnjd9fB4BFUDYg+NR5Oiub1tZDWasJnPpMHaSXeB+x/UE j+OUCqIn1uxHUay8jqQmW58JgFQrkXc= X-MC-Unique: osxRmsUSMy-Z9fvA87m6TA-1 X-Mimecast-MFC-AGG-ID: osxRmsUSMy-Z9fvA87m6TA_1776940175 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776940174; x=1777544974; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GkiSAJE0vQoiSR4PIKYvL4RDNMj7yYo++qu0kxfwAkc=; b=oEPnFAKKRoPBhnWiI6tkq7Q0a1AczImgfqTDqA/HmkSbK4Btth1bIENWioZa66G1WX XlhuoHkVNXGLXViBstkuLu5zgTRdMzmpG38mzqZDfePa8fSRSIW8XYX3XE0vGTxa1jEJ 3VPkJjHsSTs4ozsgkyNc0bAz+tMhBmDDzDHYc9eiB5IFq2TvBitQlPYQvGQvu8vMHIdG 1Usw/NnkoqJViRdgVc8py5Bo5fwa6I91KeXhAuRlGxIM+CJPHHSVL8utLl2WCc6sLTFQ rC2h769K1+ymv9ia1MUAJN56nYCg+/eNsRcEsMmgOzBOLarpBnbTZP5kTZ9mmU96TM7m I0uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776940174; x=1777544974; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GkiSAJE0vQoiSR4PIKYvL4RDNMj7yYo++qu0kxfwAkc=; b=hms2Mt5LEwlAysdDv3pz5iemcJV3uEKHvwmXaBn7wEWL7ixzY0xViKRotroVnfF+s4 /17vAepcZWygJvhyl9ptSJk/PiBAgUWTh9yb7WI4TMQdJYLkpTryEnLexeio8JGVQtw2 iAWQRn17YhvOLWw+FqfPpFl84bLECsAvOgsVfVAGe/IhHg0/pTcTmETQujg5YXdjj0mZ ikzg5F3Y3WzB+xZLkHz8TsDteKDtnyctTrcVp7Y9AJ0+yB9+iw2FqmwC3Y/a2QNtizv1 HfSYCtHDAdMltCNPsKpBQn8oV/Ads85emfjbJKkO1bxmwrCtCL+IMjJv544iusKKF0p0 9egA== X-Gm-Message-State: AOJu0YxnWCQV1Mt9V4OdUAjr2ZFM+2CuvMjV5bamUKgebLYxfE6CwKck BexvcAefNEPvBPQrOEkelip3Mi8t+Ynw/BSz5GmDZITzx6viNCzm3eqcbERFMnbSl6IPwvz1JiZ EZ0V5GBCIUqzfVrRNce9XEEs09mo8FLLHma6oCpewkn5Xyx4deEd/mAv/htuLC8MFS3ihDzOobk PFhT2zf/pZiS+b9mRkZ86hVtoBMPFduN6x4zswZV1Y X-Gm-Gg: AeBDievkkBvYtA46Tarq0OlbIUk0KkS8G5QkoHBViIKi4MlJABZc4bgi0L1zud/optw EeJsTETcKfBhzur51p1EJlvSWp7Kc9dhDv46qYh1+M8n/+JUqTzess+wtL+qt6Ng6/dT/3jv/BC bPXHYo/CeVGM+VxuWC/VTbY/ysGuuNAdkGhjBY7q5s2VoDTPZDfOwQaxrExD2qWRQqDcBdmAZoh yNY84CBqePbeNW40+aQyhTUpfBRPqu3adfFAunSqcKPx8so88nj1Cyy7tcGMGhCezLI2vMdsmj6 pOnqSK5BkteDSQm9OubxyWUxPahW9M6EslpOpvHZ7WO340bbhbalggm0dqHpUdzqZsL8Z0a3Tgt eg+ckJEGvTf9EGkKeL28LdCy3y++n0Ze4O6hp/I53QVEk5AJoVyPxKW0IoBf8kjhyp/uDes+aJX +Q9Hj8PKphdVnY7JzYU3X45R9cMSziDXrcY+4= X-Received: by 2002:a05:600c:c090:b0:488:c744:49b with SMTP id 5b1f17b1804b1-488fb74a53dmr277736885e9.7.1776940173701; Thu, 23 Apr 2026 03:29:33 -0700 (PDT) X-Received: by 2002:a05:600c:c090:b0:488:c744:49b with SMTP id 5b1f17b1804b1-488fb74a53dmr277736625e9.7.1776940173168; Thu, 23 Apr 2026 03:29:33 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Kostiantyn Kostiuk , Peter Maydell Subject: [PULL 04/25] meson: Use stddef.h instead of unistd.h Date: Thu, 23 Apr 2026 12:29:01 +0200 Message-ID: <20260423102922.443639-5-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260423102922.443639-1-pbonzini@redhat.com> References: <20260423102922.443639-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1776940350700154100 Content-Type: text/plain; charset="utf-8" From: Kostiantyn Kostiuk POSIX says stddef.h provides size_t, which is the only thing we care about here. unistd.h can be missing in non-POSIX runtimes, so include stddef.h instead. Signed-off-by: Kostiantyn Kostiuk Reviewed-by: Peter Maydell Link: https://lore.kernel.org/r/20260327134401.270186-2-kkostiuk@redhat.com Signed-off-by: Paolo Bonzini --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index ab3e97eb9f4..457491c34e2 100644 --- a/meson.build +++ b/meson.build @@ -1068,7 +1068,7 @@ endif =20 if not cc.compiles(''' #include - #include + #include =20 #define QEMU_BUILD_BUG_ON(x) \ typedef char qemu_build_bug_on[(x)?-1:1] __attribute__((unused)); --=20 2.53.0 From nobody Sat May 30 20:11:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1776940363; cv=none; d=zohomail.com; s=zohoarc; b=IXKv/R67SnWbzIYz7J3naqUglBoJIvgdeG8oyb2WHVUbCvYTBB30Me204Y0HDvIZIqiUGF4OqRNuSxLFQGPI7v1nNlB/voJQvLb1O++hyRu7VNDg+IbJ2aoIOHrUxDHNTkzMoAwG/hS7GkXtt/ycQHKPDlO8UhCokaaswMTTE1k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776940363; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=GEvldXsvdFOl0SSzAqnBPPCDIN4gE9YKYHWFJZ424fA=; b=WD8bNVgIaGvYud33n5UOdw2dRFoITOaMtSL17JQ67bZPwk0vTFPrS7yRuqivb+B/CP6nSWtjw/y3fMqda1cjviGX/VumBslar0S2Dv05kvItQDUg8zsYT/nx1xcYD+U6EqzYdl/kxQViyC7CIgJAjtS70ausG1jT1LzRf98mvfg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776940363651737.1081319245228; Thu, 23 Apr 2026 03:32:43 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wFrKm-00012q-OS; Thu, 23 Apr 2026 06:31:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrJW-0000Wr-6Y for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:29:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrJU-0005Ic-5N for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:29:41 -0400 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-178-bKlyIBj8NI-mR3gpmbzMNw-1; Thu, 23 Apr 2026 06:29:38 -0400 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4836abfc742so63244275e9.0 for ; Thu, 23 Apr 2026 03:29:38 -0700 (PDT) Received: from [192.168.10.48] ([151.49.85.67]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4e3a341sm56819161f8f.24.2026.04.23.03.29.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 03:29:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776940179; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GEvldXsvdFOl0SSzAqnBPPCDIN4gE9YKYHWFJZ424fA=; b=CkmlXbDzI1HfKRYkd7on54zPJVcSfpwocIpTcX6xVhdxx1rNMhCEn6lfDEXiCEtIDhDvUB Vj5oE5Cicmyhimc48fGhJpO7cRTRUrzjLc0VToRYpq/Td3i0p0yV5uea55qIg6EbhqAe1J XbbVfK7uslm3gMDho5Lwb8F2GJgh+mw= X-MC-Unique: bKlyIBj8NI-mR3gpmbzMNw-1 X-Mimecast-MFC-AGG-ID: bKlyIBj8NI-mR3gpmbzMNw_1776940177 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776940176; x=1777544976; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GEvldXsvdFOl0SSzAqnBPPCDIN4gE9YKYHWFJZ424fA=; b=m5hCN+htbt7L6mbY8IVjQNhKDtEvMB1756fZdM185iUWzMez46pRpRWDpk79r1Ku3/ fXNVT+dRbv29fpMXg2FEZOmUfDXjwAYvd9+st1C5RJ32NI5+xhaWuAjyVNQplkpRUS5b 4NAjlXQOzRwq2mzJeUW3JrvWHgmoJTg2E14RFg2yz77itOArNh3umLaAF1xF5aFcTC6q AdSqi1j6aIErLATFA0iqQKP/NTGPtgwykhKiFNPwM/OgN84z+NUmTZY5qjYcp38KcfIA hZVTKH4fTQPnPSsQXV5bCxVlauLB0rWRUSYKWxNkcJI8kLzrhSoZoN/w65EjU4koTbC1 8Aig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776940176; x=1777544976; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GEvldXsvdFOl0SSzAqnBPPCDIN4gE9YKYHWFJZ424fA=; b=k/8yPWngxnLXon6K0ecXPWHNiV5zzsMdir6VofiIsXUkecwytdqqZNsO8SQ6ErO70w GQtO0Pfd9bBJH6MerAYIlvcD91vSL/qbs/agm62vIS6X9ptqPPq6z0pqAoonEW/QKBbb Tp65bwp9FWwnMW5degxAI/ijPPEjhXkxfuM2rDeQren5uWcJrgXFp9ct8ylLI6ldQ44Q XIR4tybASZisUgsadUsx3tkJtdIgE9XJ10fnSqqJbSgjett+e23ji9I9BQhoORvhGB31 UKUuOPlb8kIrhHLPrPrmDFbFsqp3K0cZ5f01ZqC/dCVp97uTJAQEeLs+9SrgWcyEOwl7 DQ7A== X-Gm-Message-State: AOJu0Yz5ockENeSYOlzkhn9Ho91HXV09SyHSKRr7AoDKQYGSWuVgjUBJ 5KiKFAHCUSSZML+FSp0z1Aytjp0XvtfDR7GW3fhtdFzwb6TT/Fq43VKQw/iiMNMAYoN/GsxGepX 07JLcZP+kplNHDkNUHwNPdVX4v0xX3aHw4KCdhn3sjvCrtTKqNbK1fYMpPqp/LiqD0Hpj9BsvrF 9ZCWcCCJCdAx2r4g1vUcYH1fPSpyYIW2TZxyv9mnKI X-Gm-Gg: AeBDieue2lfvZuaVGtXPlbIb5BuSSeb+aaiBB3Kpm0SoLRXomJHGQdw0j+lDniaP31F Zd9HsiSphE8n1V3YP/WsB+NxmsXKDpMcBgx3RCGEo6PIanp7fXn5LtKMd7MIKSrdTlP97Ta3VPJ KwUG6Sy4CZpUP5qrV6oPAmBsFtUzt6vfZIyQRVs2NKH89zQnnWv6yHP/xDwYUi/Y2WZklk8+P5g t03TplWi0u7btzqTHXi1lisDohRxjTaat+KK2+Ee0arYROO/pWWAz3b1rcmrTCRdQzrTuxVlrSU muMrIy+ueE7JV5kGifUeBz4/3g0utdLUGrhx1a0pXZ0dVmaL59E/kh6+IYxaHeH9pX1ZEB1XeuR zUpMbI3ZD8jHjXMct/E41D6JqqcaH1RrwHw/wtrAPYyFvfR+Jx1fryjQAy+m0V+Eec1yQPr0B0s 6ywDxnroeZYO9bXTbjfh6i87WoVqF0F84g0Rw= X-Received: by 2002:a05:600c:8207:b0:485:3193:6ddb with SMTP id 5b1f17b1804b1-488fb73cf74mr398924715e9.3.1776940176157; Thu, 23 Apr 2026 03:29:36 -0700 (PDT) X-Received: by 2002:a05:600c:8207:b0:485:3193:6ddb with SMTP id 5b1f17b1804b1-488fb73cf74mr398924315e9.3.1776940175655; Thu, 23 Apr 2026 03:29:35 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Kostiantyn Kostiuk , Peter Maydell Subject: [PULL 05/25] qom: Use g_ascii_strcasecmp instead of strcasecmp Date: Thu, 23 Apr 2026 12:29:02 +0200 Message-ID: <20260423102922.443639-6-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260423102922.443639-1-pbonzini@redhat.com> References: <20260423102922.443639-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1776940364598158500 Content-Type: text/plain; charset="utf-8" From: Kostiantyn Kostiuk This is a change in semantics. g_ascii_strcasecmp() doesn't honour locale but strcasecmp() does. But this is OK for at least one reason: (1) QEMU always runs with the C locale so there's not an actual behaviour change here (2) we want the comparison on class names to be a plain ASCII one, not to do weird things with "I" in Turkish locales, so g_ascii_strcasecmp() is better as it's explicit about that Reviewed-by: Peter Maydell Signed-off-by: Kostiantyn Kostiuk Link: https://lore.kernel.org/r/20260327134401.270186-3-kkostiuk@redhat.com Signed-off-by: Paolo Bonzini --- qom/object.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qom/object.c b/qom/object.c index ff8ede8a328..e5c0c2f53ed 100644 --- a/qom/object.c +++ b/qom/object.c @@ -1193,8 +1193,8 @@ GSList *object_class_get_list(const char *implements_= type, =20 static gint object_class_cmp(gconstpointer a, gconstpointer b, gpointer d) { - return strcasecmp(object_class_get_name((ObjectClass *)a), - object_class_get_name((ObjectClass *)b)); + return g_ascii_strcasecmp(object_class_get_name((ObjectClass *)a), + object_class_get_name((ObjectClass *)b)); } =20 GSList *object_class_get_list_sorted(const char *implements_type, --=20 2.53.0 From nobody Sat May 30 20:11:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1776940345; cv=none; d=zohomail.com; s=zohoarc; b=L3kebRJv3ZBk7QYiDUwdgVjBJatHvXQyBnBw5tZbJvWE88W2SFr+OG4e2/7GJq5r0a2T792tbD5Cvh5JVZI6Lo3NVpXvwWc0YnY4a00QYGkpH0F7WZxV8vAxJHM7uuJg5Zt+L444pQNM5tkSqHC0vruNCbZCAndFTr3sgspP7pc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776940345; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9a3hhCSXfvl6hrvS8EB9HmHH4pMxsfQNH+Ao/VJt6go=; b=FEdOgct5VyU2YmaVTemROdm0GZWplKrOjzbVZne3f6xW4/++vz+mIUaYD8xoa4KLXEdJ3070s3eRqTCCrVizJxQ7bh82pUndmAyeC0cnxUbXyW6+Anf/QK3anhrrxtWpwWuDVjzc+2DQ1EBbt4FTo8PtVOZ1djewgBvtpyxApbs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776940345258282.7974987845522; Thu, 23 Apr 2026 03:32:25 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wFrKj-00010k-Vq; Thu, 23 Apr 2026 06:30:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrJZ-0000XM-Mh for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:29:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrJW-0005Ji-Uq for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:29:44 -0400 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-448-kScmvEiMOIalq9zcPfK6hA-1; Thu, 23 Apr 2026 06:29:41 -0400 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-48a5adc12ffso12879285e9.0 for ; Thu, 23 Apr 2026 03:29:40 -0700 (PDT) Received: from [192.168.10.48] ([151.49.85.67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fb7aa593sm160874585e9.24.2026.04.23.03.29.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 03:29:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776940182; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9a3hhCSXfvl6hrvS8EB9HmHH4pMxsfQNH+Ao/VJt6go=; b=GyMc9ZoxUe8s9jl4mO2hiY9PoTQMy7hvVL9lhzOyH1Vd6P5oNOwOOoOXNa/PoQy/28+tD1 QxLQ80Ow3xALUuVxeiFU2r/JSaizYeBW6XWKMriVqdCnjgrk8kliTEztqiros1pfsNCjPP D4Yp3VF+acLRWoeRsZsTxonXk8Y+/i8= X-MC-Unique: kScmvEiMOIalq9zcPfK6hA-1 X-Mimecast-MFC-AGG-ID: kScmvEiMOIalq9zcPfK6hA_1776940180 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776940179; x=1777544979; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9a3hhCSXfvl6hrvS8EB9HmHH4pMxsfQNH+Ao/VJt6go=; b=K/LxdhGwTuM3wm9gPkL9Nv9XYFlx6GoCevy1seu+YO+LGOpxj35rubG0v6JNgC4Rd/ 1b0Bt4yTd2foEF9DrCw4uV9fELnnANV3ivttneAxBl0Fwa8DP+F9rsjFYvAcKg11ZBDu FFOm6leAvY97CuHOCDI844ET8t+XOWcHmUs4j1Hnfc9Jr2LYxs/gPJa97FTLgJvzf7KL NbFdAKmC71R50QCxb1jWelvlmElujyW2G7/UXyq96QPXQCRDgchm8433I+6XOzsu8Qas FvBpRbb8xQpV50y7wzVyxJOGY0JLXPlzZyiKWLHMZDdaRhIiOCFbhjtE74Tdj+JHb/2F UU1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776940179; x=1777544979; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=9a3hhCSXfvl6hrvS8EB9HmHH4pMxsfQNH+Ao/VJt6go=; b=TvD13ilWEPqKkyWUDa3K39RpnPrKV3y2pDXF1QInq/fHxjdJWAv/9RmHqqDU14yf8T mCGUQ0Wqz+2i1AGDHVJ8p1SnYzoC8hqSX+4AiMzUWXT6mdAtsOta3pJvOFSWFYQFIB93 n13rBZ1Qc8Wrs7MJLdZ12p8PMOJaWlVWP8e1PxxaxOGwYzu3n3WEjGDFkkoO+GBveM92 O8Wgy7z1vyo42H7dQ6TiFnajdFx7qvZL3A5rvEXLmlVyQVtGQm0w/f2xK2VmBvfY0lHh rP8siODuI61Fmk7hnEiwjRENLaWzGBtg6jUbIfxGEGybz+22oOnVevdzeoDfj6oTxXZY NjDw== X-Gm-Message-State: AOJu0YzSkmWhcM00IMPyUyJHeLZWUFBJHUZVxor9hAUnswuMefj1CVrc 6WhOsB9CQJ5hg0+OojO0ZFdkQaPt00H2NdMUe3mIFyEI51tzSdbh7yDFVSVHv3ST0QA3PCpwyaA vdMOY2TBz2co/DlLsu6eHcW3fwAkV76uQ3tU5MTT8UB6teNKGSDYoDrcJgDLxrUnRdsdO3fOhCH 5DUikXpv6a0OVWag7SGtWBflOVXz5gK7zyQvPVV2IF X-Gm-Gg: AeBDievk/N6jPOTRhhc+CKXjWVpeM0nMBMJLbKixb3WamRt2aC2x+bTwJXPe7YSin57 tA/31IpxC/rO0MaIp0PEnYfc38tQt3cXfuUFjp4C7YxrdtWVFglh5+FyUFFEuUnoH+/oftGMPw2 RnZG0t+i6rXgUhHB4A7T1a6++KuEsn/bd/RnKeb2KxMbBrTngoVZmNmQaAglbUm8xGhwOX239Mu w6nictTZyphEdS+Ua0kHsFRftUVMi64jX35OhaHzOAmL634ov+4sPHnRMqWy3RItfiYW2sWaa0e lguGf7Q3HNDMmK0M2ImfhpnbsTwFILiX2VpnKqWi/JdzhEA7JoiC6lfga2IIX7oWGnYo00/yoyc rWuwXNU/0JOyqy6TSexbwJmsM+nTGOhFbMQ3/P4gjqbTa0a9NfjmSn4UMDZyxhUAUF1hmjbAh26 dTlJXBcNElFNyC6msKSu9OgC3zzyTZaRCvJIw= X-Received: by 2002:a05:600c:6209:b0:48a:592c:e63d with SMTP id 5b1f17b1804b1-48a592ce89emr114081385e9.14.1776940178951; Thu, 23 Apr 2026 03:29:38 -0700 (PDT) X-Received: by 2002:a05:600c:6209:b0:48a:592c:e63d with SMTP id 5b1f17b1804b1-48a592ce89emr114080905e9.14.1776940178347; Thu, 23 Apr 2026 03:29:38 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Kostiantyn Kostiuk , Peter Maydell Subject: [PULL 06/25] block: Use glib2 instead of strcasecmp/strncasecmp Date: Thu, 23 Apr 2026 12:29:03 +0200 Message-ID: <20260423102922.443639-7-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260423102922.443639-1-pbonzini@redhat.com> References: <20260423102922.443639-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1776940346522158500 Content-Type: text/plain; charset="utf-8" From: Kostiantyn Kostiuk This is a change in semantics. g_ascii_strcasecmp() doesn't honour locale but strcasecmp() does. But this is OK for at least one reason: (1) QEMU always runs with the C locale so there's not an actual behaviour change here (2) we want the comparison on url prefix and it should be a plain ASCII one, not to do weird things with "I" in Turkish locales, so g_ascii_strcasecmp() is better as it's explicit about that Signed-off-by: Kostiantyn Kostiuk Reviewed-by: Peter Maydell Link: https://lore.kernel.org/r/20260327134401.270186-4-kkostiuk@redhat.com Signed-off-by: Paolo Bonzini --- block/curl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/curl.c b/block/curl.c index 419df78258b..684c677ef71 100644 --- a/block/curl.c +++ b/block/curl.c @@ -871,8 +871,8 @@ static int curl_open(BlockDriverState *bs, QDict *optio= ns, int flags, goto out; } =20 - if ((!strncasecmp(s->url, "http://", strlen("http://")) - || !strncasecmp(s->url, "https://", strlen("https://"))) + if ((!g_ascii_strncasecmp(s->url, "http://", strlen("http://")) + || !g_ascii_strncasecmp(s->url, "https://", strlen("https://"))) && !s->accept_range) { pstrcpy(state->errmsg, CURL_ERROR_SIZE, "Server does not support 'range' (byte ranges)."); --=20 2.53.0 From nobody Sat May 30 20:11:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1776940328; cv=none; d=zohomail.com; s=zohoarc; b=P27kK2u4VskO/T5MtmDdjPj/Yt4PmqHOnlH1Zrdb5Wtuh4Rd6qUCX20Vde/wEWeDlRTQKgluuTIBrjMV3wtdOX04Bh/xyXQjKOJn2F5AC7nnmbg4q+VsOmVFIAAKWHKgWe+98UOl5OUVnCzi2V/38NLiiAuQGMK1lYvH0iSVjUA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776940328; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=OiXQsll1JQj9gR6NKDgvKQISqWBpMBuRG51hECRcEGM=; b=jrUTgNutb+V/L+jwZYQfI06ui0jtnJj1RBwpTs/E43cNcouaikQ5DLMBj4h1lEpGD4W5uhIugrda7vlmMubFTTQVUtG0G3pcY/IHZcNEqbFpH7JpnXflQkKeYwVVXdTa1Srn26mX4LBlEyj3tQF2wovw3wa+saidR9eJUWDPDcg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776940328146283.0766163654789; Thu, 23 Apr 2026 03:32:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wFrKk-00010z-EP; Thu, 23 Apr 2026 06:30:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrJb-0000Xe-AG for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:29:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrJZ-0005K1-JF for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:29:47 -0400 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-101-RgiusbgTPOSWAH4DdUzCJg-1; Thu, 23 Apr 2026 06:29:43 -0400 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-48906aa28cbso37291905e9.0 for ; Thu, 23 Apr 2026 03:29:43 -0700 (PDT) Received: from [192.168.10.48] ([151.49.85.67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc1c01cfsm535266635e9.10.2026.04.23.03.29.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 03:29:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776940184; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OiXQsll1JQj9gR6NKDgvKQISqWBpMBuRG51hECRcEGM=; b=LmeeZGWibVsHRimT3BdNWHoURht+aBeuwVAyx6LbHrqF1sI5hCVoCjQO0Rx9GLQhn8PgkX wZ0ZLsvG5ABPIHwCsYfriwlAuMpAPRna1TeLumD8omln+thFKTWCv9QyCcMBZ48WH1nbKo xhKAUXcqDgZjWVh9KFbzsfkwoVi29rY= X-MC-Unique: RgiusbgTPOSWAH4DdUzCJg-1 X-Mimecast-MFC-AGG-ID: RgiusbgTPOSWAH4DdUzCJg_1776940182 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776940181; x=1777544981; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OiXQsll1JQj9gR6NKDgvKQISqWBpMBuRG51hECRcEGM=; b=bG/QHtNnIr3t9onhqnnd5qWb7b4hB2qHSCGC/Gxa4jv7f2UJt0seN4leNo1zBIrRIP zFnQKMBwg1BriUy8J8fkcdVQy4XMRpsC7vkWgV5dygv+v9zSSiLyNTJeVBYfZUarOGG3 wy+CQ/Q/dMtx5ZjQUgcszX2wdH/RhLnzmGH/3n6hICJAO6DY9C/liUbMYawZD/H34bSd tu+GIoBagJcY/HuB5tnC3T2xu54cYVmPsspqkBGXzhOE3RVIhNw+NbQ2HVZuJQ90N9mz +aJfrhn5VwzGPicuW1/9Hk3IcixMiaSyma4MO9185B0cXBuh6Fc19387xP0igqYNidza 0afQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776940181; x=1777544981; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OiXQsll1JQj9gR6NKDgvKQISqWBpMBuRG51hECRcEGM=; b=cTuZ4Xi6kasxX/VDC6nrr8alTsyUvg1UQESMO7y9J3y1wjZg5gMH0jDm0xyomx3huy 3SK8AR9G9e6sQuvBGDPOPGzbFTsIVerlekQreRl+NkhwQdCsVba0xeSNJjXOveHw+PDw vTOa5ZZ4vzdGQm1drW5edpFelDeSQNjygbzi8k4cBBbxINbsdsmD7slheqxt/cFJ7MiT IO6wQNeVKO6KGUA4BmyQaPYY3opLysMU9VhubW8HIo9z0d/Z2ErlNVMmGg9VFvNyM/T6 lMQTS0DZr8s51RpV7Ka7/1xmCHlYpDA63/O0aBMguyUSBPojJ0gwspFO06yEMDXJXrxP ACbg== X-Gm-Message-State: AOJu0Yyc168RpuDhopphdgkntI7Oqm+qg+qNG/V9cUs956FJTgfDXv95 LkcvKRcW+A1ZhPhXhtAIJzV73nuSEmkOMZS0nXXKPDeifBgcKRK/7SpT0j934xGalue2n4obsBv QNoNDBwUFiGKexh3mrUOpyFN5mwNMo6hov8xh73hVuSEcXu3Rm6vO4NJjKUoBQUgRCP5XSOTud6 An6vJwceML0Ki/Xt61aXesA3yuObTLLBRmFeZguzA9 X-Gm-Gg: AeBDietUsdD+x485CcSdWBdJOwxHmIRAHtDqxcaUMxXk+F9hXkFqorupsEYUoVN+Zwr UJLqep3BV+w4/BC9zg7wDAk46+GKkuSx7bYpSKKWL27ZB+KgYv/ghbedrRH3UTIBxFHOV0IUymf t0eWRlkFe/kaMM9pC1YrJ1OxN9+imjVG0tpWga9qYl4YSeUpBA9k5gNQmYyRFQFkuptf46Ck+Xt lY7LdRHwTvDQIBF53k0j0LnHpyt5+sHzf/3GurPlSRF+uu5rutYyt8dcBinqUUk9ydNi4QW5yOW gLzm2B/jkwc+CG/uavONHEXjaMiocFJCYZqDhdUM7WMSZZAG+WinxIcRGDNv85g1RIOBEBwkeAk u6DB76FnEr/wB/OsWHWl3CJ0RQ5U3mYI/SILN+ZzK9Y8bMQQ5V2k41p3mf0Yw5m8e19Zhpdy3ok a9fa22fTPDtZhhGrMKVk4xckPS2X5zXb2Yxu4= X-Received: by 2002:a05:600c:8b6b:b0:485:3c2e:60d5 with SMTP id 5b1f17b1804b1-488fb8859ddmr348261785e9.2.1776940181368; Thu, 23 Apr 2026 03:29:41 -0700 (PDT) X-Received: by 2002:a05:600c:8b6b:b0:485:3c2e:60d5 with SMTP id 5b1f17b1804b1-488fb8859ddmr348261265e9.2.1776940180815; Thu, 23 Apr 2026 03:29:40 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Kostiantyn Kostiuk , Peter Maydell Subject: [PULL 07/25] io: Use glib2 instead of strcasecmp/strncasecmp Date: Thu, 23 Apr 2026 12:29:04 +0200 Message-ID: <20260423102922.443639-8-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260423102922.443639-1-pbonzini@redhat.com> References: <20260423102922.443639-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1776940330411154100 Content-Type: text/plain; charset="utf-8" From: Kostiantyn Kostiuk This is a change in semantics. g_ascii_strcasecmp() doesn't honour locale but strcasecmp() does. But this is OK for at least one reason: (1) QEMU always runs with the C locale so there's not an actual behaviour change here (2) we want the comparison data in HTTP header and it should be a plain ASCII one, not to do weird things with "I" in Turkish locales, so g_ascii_strcasecmp() is better as it's explicit about that Signed-off-by: Kostiantyn Kostiuk Reviewed-by: Peter Maydell Link: https://lore.kernel.org/r/20260327134401.270186-5-kkostiuk@redhat.com Signed-off-by: Paolo Bonzini --- io/channel-websock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/io/channel-websock.c b/io/channel-websock.c index 9902b014f79..85b22a8822a 100644 --- a/io/channel-websock.c +++ b/io/channel-websock.c @@ -457,7 +457,7 @@ static void qio_channel_websock_handshake_process(QIOCh= annelWebsock *ioc, connectionv =3D g_strsplit(connection, ",", 0); for (i =3D 0; connectionv !=3D NULL && connectionv[i] !=3D NULL; i++) { g_strstrip(connectionv[i]); - if (strcasecmp(connectionv[i], + if (g_ascii_strcasecmp(connectionv[i], QIO_CHANNEL_WEBSOCK_CONNECTION_UPGRADE) =3D=3D 0) { upgraded =3D true; } @@ -468,7 +468,7 @@ static void qio_channel_websock_handshake_process(QIOCh= annelWebsock *ioc, goto bad_request; } =20 - if (strcasecmp(upgrade, QIO_CHANNEL_WEBSOCK_UPGRADE_WEBSOCKET) !=3D 0)= { + if (g_ascii_strcasecmp(upgrade, QIO_CHANNEL_WEBSOCK_UPGRADE_WEBSOCKET)= !=3D 0) { error_setg(errp, "Incorrect upgrade method '%s'", upgrade); goto bad_request; } --=20 2.53.0 From nobody Sat May 30 20:11:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1776940340; cv=none; d=zohomail.com; s=zohoarc; b=VWErqDDh6FK9KENcENqQ6/xkicgti2CMH3MTWH5C8rpInN0OtGJzC/agymKZflOH87HA/L+20RhixJKnrNZeA14jKjkpsRORTuABdgaGRa3dogMsg1fiKmGbBJ1W6uJklWsCZio+7byxgssPkz96ZA9zSZzyUzFKJI6NkdUojGI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776940340; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=EUM7sRP+EF1GJe9I9RrbGzDUC5BjmqJIysVBw/wHvzM=; b=Db2ah4BTi/lvXaixY4qnnV5zlueFfTskbvuSjJb3+T20Fyvc8RdbE4nSUi8hUckcP2OSyPx9hTPG962zOhjBMrZhTk0KzE32YapR3IuWTZyU/fX8NvUN++yBw1G31GHdbrrprRDCU6j3OPBX4gLN9eH4GNBjflUd5sS+RiRd4no= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776940340720121.51763386650691; Thu, 23 Apr 2026 03:32:20 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wFrKk-00011D-N2; Thu, 23 Apr 2026 06:30:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrJf-0000Ys-Ie for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:29:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrJd-0005Lm-J5 for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:29:51 -0400 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-629-Ntfa6YtCO_uDLK3b-rucUw-1; Thu, 23 Apr 2026 06:29:47 -0400 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-48a55ecc249so21962925e9.1 for ; Thu, 23 Apr 2026 03:29:47 -0700 (PDT) Received: from [192.168.10.48] ([151.49.85.67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc0f8188sm539944375e9.2.2026.04.23.03.29.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 03:29:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776940188; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EUM7sRP+EF1GJe9I9RrbGzDUC5BjmqJIysVBw/wHvzM=; b=haEXb0k2T5vSbJTmILftLZWLNbe3UDWCZdIpcl1m24rllyw2D9ajU0bgAldl9VIiA7ggqK VIIKAXmpLz4phz2DGPe0Gj0TB77rlqlO5agxqB1gzk0iLDn+m1LU/naOI0QdTuIDSaEpiz 7GZOrXCiENB6speUGiZwv1QderITyGk= X-MC-Unique: Ntfa6YtCO_uDLK3b-rucUw-1 X-Mimecast-MFC-AGG-ID: Ntfa6YtCO_uDLK3b-rucUw_1776940186 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776940184; x=1777544984; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EUM7sRP+EF1GJe9I9RrbGzDUC5BjmqJIysVBw/wHvzM=; b=OBLBnB6p8H7YaidS8klGAw2SC2Q22aZ1NaMUvKFYSXIdE4NQBahBzlQ0lhOrwp6ILb ZQ8dLNLnD30vM3yZY69bYkYCrY+zsf/38tIcTbzYgS6vgFl8OWf1lxuX1rShhxs4WTQo pJH9GPv1NyGFiOkxXqfUmsvXm+WuqUJWmUem2wQBcf4OytTZ6ZVRFwlhrZGfFKoFeHTb f1d5YH73p0x5+lOQpdK85czPuvcE5k1D5bwf6P7pX3ikNJTgtPfvNtsRpqu7xoZrWuc6 CVbrx/PF9+UxfFaB+v99SP4BA+EOaZwVdPRx5MHL4ZmwKSjDRbwIsBnQTqqLjj0Vk9+y 7kkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776940184; x=1777544984; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=EUM7sRP+EF1GJe9I9RrbGzDUC5BjmqJIysVBw/wHvzM=; b=dE6d5f2swKegRk12QURzgLYuC2Fv7CeopVnwO0pDSwVvc/sfuq9zO0LJlwrKXus7ks kUgN+3nNCSrelYJjcD5q4p9UwyMqhrpIu+WfFrNG9Hz1xjBnxKUxMUuC9frdIboPBUS1 8oJmkrD2P/6AEVCbCvHZa4w6YCRC3wqJ+eXho8wsass4VS9Q74iOgRm5As6tIhOsB3i/ lycF8dNcFRAu+95zeDrq/LgSWpx0OLKiTwYRMxZnl9DV6vBScHP+Ra0+9ANPKo4DUAf1 IOgWJHzF+i6O6c65zovWSnz21bC7Jaw+T0wKuS9Kx99NKe7zh4H88bp4n0YbJJkqNVc+ jCbg== X-Gm-Message-State: AOJu0Yz+K0JaKbT12VKV15eSFiMYHtBM0hCqk8BVU5p0SBFe4bgZwkJN w0hH49/cO1KeVdJbed2ufxasQ5lfN6rEqPk3fxOGwtzkfUDOjeHIxGKfdngkDuhUHcVF2umGCHQ QmPS+hc+nuNHYze8Gyni2ICm96cxzfycNzrDaSmRBbwPAynyUDLGsFpKmYjd94PiVolLN7ERJqD X1xaAZNysZKK7MLlRSJN/PEnIPzJl3OFioo6EZf0MI X-Gm-Gg: AeBDieu/i6Bmf230Kz6XOPuQ8FheBLMQLjxi2KjHgYnOJn4EmrfmDm5Dw7FDINg1tI9 7pt4o+EsZd1JSHr95RN+tGJUlVDDYVKSJMg7DOFQ2behnmRpWvQDqcIZbwtfik9km8q57p4OQeG InJ7WM3yoIStgyG67lWe3o0u+qWALsVRW1d7cuto6RY1UUkF3o33+ADWxJ5VaHhXk36t4m+ov9/ CA+WtByc2LfFDFL6U6jiU0V4qHBrRw3SR4wo0sl9fZFBlYY29HFAU74lgSqPXtIHNClFA+LBd4T wOsw4gaci0HmhJE4KomJ+GeblhljY6xJ6CxbrEQQzO04zvbk62IBeQnh93QbDS3hmfAAElgfVjT yDcwko8a7H4L4RoQYwxXlRGZ27wJ3Mc0+kyWRIq+yTStgxmcOosIxFBzbYAB8sRgjtfBODqeWb6 nSfRQDDKG9LAHat4R5CmWaa5tC338bIjKmN68= X-Received: by 2002:a05:600d:b:b0:48a:56de:d63c with SMTP id 5b1f17b1804b1-48a56dedadfmr106686765e9.27.1776940184541; Thu, 23 Apr 2026 03:29:44 -0700 (PDT) X-Received: by 2002:a05:600d:b:b0:48a:56de:d63c with SMTP id 5b1f17b1804b1-48a56dedadfmr106686525e9.27.1776940184009; Thu, 23 Apr 2026 03:29:44 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Kostiantyn Kostiuk , Peter Maydell Subject: [PULL 08/25] target/sparc: Use glib2 instead of strcasecmp/strncasecmp Date: Thu, 23 Apr 2026 12:29:05 +0200 Message-ID: <20260423102922.443639-9-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260423102922.443639-1-pbonzini@redhat.com> References: <20260423102922.443639-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1776940342499158500 Content-Type: text/plain; charset="utf-8" From: Kostiantyn Kostiuk This is a change in semantics. g_ascii_strcasecmp() doesn't honour locale but strcasecmp() does. But this is OK for at least one reason: (1) QEMU always runs with the C locale so there's not an actual behaviour change here (2) we want the comparison on boolean property value to be a plain ASCII one, not to do weird things with "I" in Turkish locales, so g_ascii_strcasecmp() is better as it's explicit about that Signed-off-by: Kostiantyn Kostiuk Reviewed-by: Peter Maydell Link: https://lore.kernel.org/r/20260327134401.270186-7-kkostiuk@redhat.com Signed-off-by: Paolo Bonzini --- target/sparc/cpu.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c index 1493336e7a2..77046104284 100644 --- a/target/sparc/cpu.c +++ b/target/sparc/cpu.c @@ -174,10 +174,10 @@ static void sparc_cpu_parse_features(const char *type= name, char *features, * TODO: remove minus-override-plus semantics after * warning for a few releases */ - if (!strcasecmp(val, "on") || - !strcasecmp(val, "off") || - !strcasecmp(val, "true") || - !strcasecmp(val, "false")) { + if (!g_ascii_strcasecmp(val, "on") || + !g_ascii_strcasecmp(val, "off") || + !g_ascii_strcasecmp(val, "true") || + !g_ascii_strcasecmp(val, "false")) { error_setg(errp, "Boolean properties in format %s=3D%s" " are not supported", name, val); return; --=20 2.53.0 From nobody Sat May 30 20:11:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1776940268; cv=none; d=zohomail.com; s=zohoarc; b=a7jz+ouMm5HYTXRqsRCCihIuQxvOk6jd3J4IHWuDTWUBFp3zrnKsuc/1EH2wxxontQUeC8NvSvqoaUgKhqCuUoB625hRH362OPoInvxa+kiAXg8b8EKzr+/JOqSlwtQx0rwaH0oTgypYhBdw49lm74q8HXCkSsxm/yUSNNNXsac= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776940268; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=wwkW5JCG7FWgbyoekfLFNx81cj7HS6BDKB+OcGK2C+Q=; b=GPo7jlKlv3VWTSoN+DN2O7QCaAee/Dh6r3xh+VGnauSwLCugQDCb9rSuNABClX/fyCZXTQZPgLfwjVdviXTA5a9nQQT7cc1M8/K+81mJDh370Xsfx1DBqjnzN/CtDdSO0jUaidiszhsMNRZ7SomAl5lCFDhqAH7Nye6yzx+nqqA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776940268903676.8564899597551; Thu, 23 Apr 2026 03:31:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wFrKl-00012B-GD; Thu, 23 Apr 2026 06:30:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrJi-0000Yz-GP for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:30:01 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrJg-0005MM-U8 for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:29:54 -0400 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-295-qFUH6toCP_C6XLWj7LBwxg-1; Thu, 23 Apr 2026 06:29:49 -0400 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-4411a215f17so3385348f8f.1 for ; Thu, 23 Apr 2026 03:29:49 -0700 (PDT) Received: from [192.168.10.48] ([151.49.85.67]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4cb11b4sm53159726f8f.2.2026.04.23.03.29.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 03:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776940191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wwkW5JCG7FWgbyoekfLFNx81cj7HS6BDKB+OcGK2C+Q=; b=ePMbu0WsPClW6dtdsUmDgKCKNITCNhBelnw1ks1Yk64WU8ygSch1oFCqmivVkFD+X8/de0 Wm0OcriYhzqIEYDL77wdaJqDlmjcn6g92dNVAtH2kVbC6trT3/xMWs7VYHTyBAnifJLOEg JB4sGqbiDgl1XFKS/UE78/l74VIydC4= X-MC-Unique: qFUH6toCP_C6XLWj7LBwxg-1 X-Mimecast-MFC-AGG-ID: qFUH6toCP_C6XLWj7LBwxg_1776940188 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776940188; x=1777544988; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wwkW5JCG7FWgbyoekfLFNx81cj7HS6BDKB+OcGK2C+Q=; b=JH8AVdsVbTgdE6zGX3t4fDESVRMzrPEEsUenhchfZGFdrNr5r3ip7rNjqvtWri+QZH yOKxTt6nH0fvKzRtEGcIufMI4aH+lSSf0Q6TbY8qg3dmfD8VYTOYMIaOwDrTMF+Tg+64 Sg1Hd8Zg/23DrxwVGTVq5Q8PyesJ14XZenEFf3xsYkLjeqFlY/juN+MsgdXHJ3ShPVub dB4uwVIJ4/3K+NGbSjU84Yp9ngLrFzN4db3h0fAG8lHgif7/+LUtL+qN9Vxn0nTfkN0q Pgz1m7aadNpv7eT7YLsenqTL+1JClzS5vCWGGg3K2FD0L7P7iOKeR0JKBGQJKV6plgi5 p/BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776940188; x=1777544988; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wwkW5JCG7FWgbyoekfLFNx81cj7HS6BDKB+OcGK2C+Q=; b=okwvvQzUspfLOj0nj04IG+XmC96cLfwKekDLBeu1yS+FJz3YEkn3YYL4Yc0KubyuzZ 30TppzzbDX93fMtmRklrUtrjsP7RPaaYDeXLdC/e7Gx0zl5ee2rHcIdC+iMVFP49Q0vV IoDbuhuyuzU/mEWsy/VVycVRTYaglCSoxcVT8pk9IUTJWwK63u8ko5Pwz5Jo1A+mKwHe cHDxuT2Tv6hIw6z3B46ckayRMUqkp6SKok81IVp+S28VecfJd0FfWABRyPGYSDAaU+s9 6qR2axiJe1TDf9O3bXbtTQ/C5oCrnL5FOWF1jaT9O2nMOf0lAcDAaO5j5egQ4dkUmB7Q kJBQ== X-Gm-Message-State: AOJu0YzWuiaO5zf4qCe8b7izFtl422eJjzUVB//AAFxJi80c3PeDOQoc hXWQxAK050O5lWWjKJ5Ow33gkDOvO/u3M7eYDoJHZtbOKHVczGVZH6gg88jDSCSMcWlrLnW64I9 UOV8fMAtRQYLJEHi3jH0NjgHwfqYChmmZhHcrPf/HccqOVS8O7XiSeS4JlX95Po/l0Z88qVN6iP 7BGC+IlJcLljAs/W9CDOVJ8kWwOUmoGt3UvJizR7nF X-Gm-Gg: AeBDiesee6VmdpLGZ4mbo2Jc6bIwKCK7sbiaV8N6f9lArJYZotKglnATcGKlsqx4qZ5 wJlLwfR75w88j3T7ibaMRzoWviDR3C2W/XlEXkvGfMaHKyhAKfKdDE7U6crNtSDPQFqGSgyV9r9 eHO6hFAj47aORPldwNPNdTc2JvxRfgAN1sRZuh1A5DOCtOckgUBRn/wWFfmDu9CSeCkZV9wvwCs 8BLN//LKkaYqJfRv29Q2CKurnO3mbnZyUVxsFFkmscngcsMrVy9zC5uDKkJ421mhT5ndEvmExxh MDI8DZg6BXYyHFktUVBeT7wfEbrBiBbdbLErFVJECvuXjB8Ysk2vxNQk2XRlq/ZCKaiYzhc69Xf FtIYuP7wiD/8MTGk7u09nbbqheCv3PP7egtZZaLpJZ3bN7BKuQ4AuX282cfLRtLK8IhKdeaAn65 ne1OFk4DsWvfKUg9hCqqrbJGH2Jelp8e49IjQ= X-Received: by 2002:a05:6000:2503:b0:43c:fde7:f1 with SMTP id ffacd0b85a97d-43fe3dd3a84mr41721130f8f.18.1776940187972; Thu, 23 Apr 2026 03:29:47 -0700 (PDT) X-Received: by 2002:a05:6000:2503:b0:43c:fde7:f1 with SMTP id ffacd0b85a97d-43fe3dd3a84mr41721083f8f.18.1776940187446; Thu, 23 Apr 2026 03:29:47 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Kostiantyn Kostiuk , Chao Liu , Peter Maydell Subject: [PULL 09/25] target/riscv: Use glib2 instead of strcasecmp/strncasecmp Date: Thu, 23 Apr 2026 12:29:06 +0200 Message-ID: <20260423102922.443639-10-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260423102922.443639-1-pbonzini@redhat.com> References: <20260423102922.443639-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1776940270925158500 Content-Type: text/plain; charset="utf-8" From: Kostiantyn Kostiuk This is a change in semantics. g_ascii_strcasecmp() doesn't honour locale but strcasecmp() does. But this is OK for at least one reason: (1) QEMU always runs with the C locale so there's not an actual behaviour change here Signed-off-by: Kostiantyn Kostiuk Reviewed-by: Chao Liu Reviewed-by: Peter Maydell Link: https://lore.kernel.org/r/20260327134401.270186-8-kkostiuk@redhat.com Signed-off-by: Paolo Bonzini --- target/riscv/monitor.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/riscv/monitor.c b/target/riscv/monitor.c index a9d31114442..bca04a7580c 100644 --- a/target/riscv/monitor.c +++ b/target/riscv/monitor.c @@ -303,7 +303,7 @@ static bool reg_is_vreg(const char *name) } =20 for (int i =3D 0; i < 32; i++) { - if (strcasecmp(name, riscv_rvv_regnames[i]) =3D=3D 0) { + if (g_ascii_strcasecmp(name, riscv_rvv_regnames[i]) =3D=3D 0) { return true; } } @@ -358,7 +358,7 @@ int target_get_monitor_def(CPUState *cs, const char *na= me, uint64_t *pval) continue; } =20 - if (strcasecmp(csr_ops[csrno].name, name) !=3D 0) { + if (g_ascii_strcasecmp(csr_ops[csrno].name, name) !=3D 0) { continue; } =20 --=20 2.53.0 From nobody Sat May 30 20:11:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1776940347; cv=none; d=zohomail.com; s=zohoarc; b=j0ErpupC26/g3uAV45NEBSGaqREM77h1amKyfssF6CD6mreuq5CC5rb4MDj4RuUAI/WZigSonj9l8RMW0WL2AUE+mlVLV3DmMUzE4AZxtpdwBMn8b6pBnReeehVUw+SW46mk6E75EWSuBjuDpG47CPShaqNplvzkjxx95GM7JC0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776940347; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=rdylYCYaibZL9hnF4r7zw4wbjkS++okPS4qty1yblkg=; b=HRIGsh/vB+xmJe4oUXeUUaQlrW+vbyySm2SeUFCj5/uTj8hWYiq3jnVOULW5eFSJ0QRrqaZCasypO71I2puF8qr7v0wyTc1149HlKjr9tOIUMGvTIHuze1puGRpZKVUFflHUtU35VIrfju3Pr1Cq5ccrLjCyDrYb7wiazvOicec= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776940347919767.6079107244624; Thu, 23 Apr 2026 03:32:27 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wFrKn-00013r-TF; Thu, 23 Apr 2026 06:31:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrJk-0000Z8-Ut for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:30:01 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrJj-0005NM-GU for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:29:56 -0400 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-42-35Y2LagMM7qmxg6n7MoK8w-1; Thu, 23 Apr 2026 06:29:53 -0400 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-43d77286244so4296446f8f.1 for ; Thu, 23 Apr 2026 03:29:53 -0700 (PDT) Received: from [192.168.10.48] ([151.49.85.67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc10019bsm524458115e9.4.2026.04.23.03.29.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 03:29:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776940194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rdylYCYaibZL9hnF4r7zw4wbjkS++okPS4qty1yblkg=; b=FvD+oDoOxL1QoQJnRP+hfhMSoomTi5f0lzGT2G08Lia0qpKTrWlMxinEAEWN7Nllzw1gIH MphH+AcoM2WF6ixDBu7/C4p2hwcQMcUjSznCuWp3lrxYanAXXRXfId11T1RICAZ47kv/86 6YNqUz+6/Xz4JfkBFcdTBItPpWVv0xg= X-MC-Unique: 35Y2LagMM7qmxg6n7MoK8w-1 X-Mimecast-MFC-AGG-ID: 35Y2LagMM7qmxg6n7MoK8w_1776940192 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776940191; x=1777544991; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rdylYCYaibZL9hnF4r7zw4wbjkS++okPS4qty1yblkg=; b=l+YfKlnFnhem7RG6mxJ4dl0KTQfknhwpSuhqYMnzmgRQ9YIwnMtF/Ir+uWEYlzgwjF Z8a0gp8SOU/b4gc4k8glzHIorffKDtmctce1ivD7zugs+aVLXBlSOTw67r8TgbICmfwG amECgh5N2oZloEsr1RFINSotyCFJBon2N5oW8D8EfJGZNzpnhcQJqayz0JjEsFkim2X0 ZypbdnwHxxLiXNNAN9p214a/bhX5BObt7DKMvxxywushuJ3Hms/TqLweCYDNYX+3dckW WxPp1ZmwEiqNwiTU+6n0diaAPY2i9y6FtqJoFYZZKIfIwrXr57Qh31VtFqWopEXSMxCc sA9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776940191; x=1777544991; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rdylYCYaibZL9hnF4r7zw4wbjkS++okPS4qty1yblkg=; b=NTCmPfkislSQJeYsAcUR1QzCC7IGoPgwBjbMMge0GiQrMs9JQX1Y86X2e3LpPj6Z/H coFE9Aupb/V0tQiPv//DWrhZiBO0hZ48etVZ5qumfnYsS2yzSFnfmevZgqGl2zWf+RBf 8+FzfOMBz5JSatmJUsI3DrjIQ9mb7Y/iov2ogG0kRRX3XVab+sX++2U8BhglpUjs+KXV dmd98affSGRYlxQJ5FwaIjr1hEh2lQ9V1Kg5EBTWooAMPr9oW9jRZ0V2kzGslcq7cJZv +ajfcD9V+n+dno84SfpEy8wM6e/XwaJV57Am2z9rqwiYbY/M/R6rDdH0xsdLyoZt0KoK 3FuA== X-Gm-Message-State: AOJu0YxHtFWZ1YjLmyPs+/vrLCME4hGIJcUQZRKsYFDAC7M66wfm+t2Q efFBdOPCYxmXwg3DkIXgjzshy/54TP7af+1Mshq3c6ZdLQGGPwYegY6g6ngW9BILek6Vyc5OMvf 6bdhtoHrmmZaoi9RtK1LaHUigB4GnwrDHkFdI0EsIHlmS/7ZWzFRImKCBN2gmAyjqSz5AfQxilf YH0iG1GErQwOncz7ng9cxdyzHAPpRf/ocNxcdQGPWI X-Gm-Gg: AeBDiev6ynvFCPhvSSBEHRLUIG7Ap20Gpnyjz7b4PFQuJn0Cy+N4TY6x5bRBV7f1Fi3 z3iOVzf43ZIfIIDu7p+Pzb8Gc041rF9WgAUMAHlCwJwb7PVN0SPr9eMJ9idaV07Ie+bZueo7Vtv 5CsYRB6/9/TGYzX12cFDIVhp/oQEFlC2QYClRPqImkV6xuqBu15OhoxM3h+ME7MJPAkzvCxSwwW oP+HfGhr5iPKschkPMnLTAl0LlwTPXuHclgWT/2lCY1JZm2csoKyMyUn1OwLyU8pJxq3mDVxHdd WSI7TCMrGDOiPLxCOIwoDHNwR7XT5T7l1/jmIdbIsVXeJzcvfIj/fAuuLqefksG1kvpqK9Kou3D CeW/b9RxMdLwfAraW25Gra6AKYvAhXqrXV1Zg0BOPm+l+vcWvy1rGk6TqKxB5gRR/uX/3zssS8A rkFDWEZZdQQxVJt3H1D+/0k11pFAspk33Bjl8= X-Received: by 2002:a05:600c:46cb:b0:488:a723:ea53 with SMTP id 5b1f17b1804b1-488fb744fbemr375426855e9.7.1776940191410; Thu, 23 Apr 2026 03:29:51 -0700 (PDT) X-Received: by 2002:a05:600c:46cb:b0:488:a723:ea53 with SMTP id 5b1f17b1804b1-488fb744fbemr375426385e9.7.1776940190887; Thu, 23 Apr 2026 03:29:50 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Kostiantyn Kostiuk , Peter Maydell Subject: [PULL 10/25] target/ppc: Use glib2 instead of strcasecmp/strncasecmp Date: Thu, 23 Apr 2026 12:29:07 +0200 Message-ID: <20260423102922.443639-11-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260423102922.443639-1-pbonzini@redhat.com> References: <20260423102922.443639-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1776940350703154100 Content-Type: text/plain; charset="utf-8" From: Kostiantyn Kostiuk This is a change in semantics. g_ascii_strcasecmp() doesn't honour locale but strcasecmp() does. But this is OK for at least one reason: (1) QEMU always runs with the C locale so there's not an actual behaviour change here Signed-off-by: Kostiantyn Kostiuk Reviewed-by: Peter Maydell Link: https://lore.kernel.org/r/20260327134401.270186-9-kkostiuk@redhat.com Signed-off-by: Paolo Bonzini --- target/ppc/kvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 41bd03ec2a2..25c28ad089c 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -2653,7 +2653,7 @@ static int kvm_ppc_register_host_cpu_type(void) */ dc =3D DEVICE_CLASS(ppc_cpu_get_family_class(pvr_pcc)); for (i =3D 0; ppc_cpu_aliases[i].alias !=3D NULL; i++) { - if (strcasecmp(ppc_cpu_aliases[i].alias, dc->desc) =3D=3D 0) { + if (g_ascii_strcasecmp(ppc_cpu_aliases[i].alias, dc->desc) =3D=3D = 0) { char *suffix; =20 ppc_cpu_aliases[i].model =3D g_strdup(object_class_get_name(oc= )); --=20 2.53.0 From nobody Sat May 30 20:11:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1776940349; cv=none; d=zohomail.com; s=zohoarc; b=RMrxd+ywJlI0grLLGrIW6VpHOyfqYF4720vQ/ZaVS0UuMZbsVtE6mcOTmYQQV1jC49XBaynzDPLpQd+7wG/WJhkc3oEiz7TpJzwBVSxcvs+1PJffofy/pkFsbuJHVt9n2flSWMbhC9CowZVCgEiUZPsWp8PYO0At5HOU7OHYeyM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776940349; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=mvlY+/LRKuKta0O23HLcvzCcFpZOHfGgT1RnwB29Db0=; b=f1it6f6Ze7TWnC1LhZO81IvSTPFgRRIupE6kSKUar9syu9PhBg7XiL0K7o+xCqgztHvbUQeJ7ENVbdgeHSFpAy3q9cHco+dZXScrNSTEPPtoCJMRIL4+WN3NvW/73HOkyPKBSk8yBda9MrKuzU2atGVMZPLrADvmO8jS6Ft5UZ0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776940349254893.7411803395464; Thu, 23 Apr 2026 03:32:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wFrKl-00012H-K8; Thu, 23 Apr 2026 06:30:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrJo-0000ZK-RN for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:30:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrJm-0005OB-Dv for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:30:00 -0400 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-294-YsPCU3-gMaGhBYkuzFcYrA-1; Thu, 23 Apr 2026 06:29:56 -0400 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-48a5775d647so25606155e9.2 for ; Thu, 23 Apr 2026 03:29:56 -0700 (PDT) Received: from [192.168.10.48] ([151.49.85.67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fb74c789sm152488885e9.5.2026.04.23.03.29.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 03:29:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776940197; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mvlY+/LRKuKta0O23HLcvzCcFpZOHfGgT1RnwB29Db0=; b=IT2TciSvweJsP9h5y7cRP0S5Y88wb4dUjGrC/JLuNhoqPy25+UoQ1ImEz6guU5u59fgiDH Bogu861GQh93t2xt4rW2YqryL0P/nWr9XR/3sS7kwIfN55LiiePVHaM4jHHnT0A59R60Cl rYdX6KIPycNn3ukomq0k4I3qb8tZ36A= X-MC-Unique: YsPCU3-gMaGhBYkuzFcYrA-1 X-Mimecast-MFC-AGG-ID: YsPCU3-gMaGhBYkuzFcYrA_1776940196 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776940194; x=1777544994; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mvlY+/LRKuKta0O23HLcvzCcFpZOHfGgT1RnwB29Db0=; b=bUoBNzKJC1g5u/cuSQakEISvayEhXxRA10CkoFOPnodB75dKCrFhecOZcRcefNxsDy uAaUX0D/IE3j2OQY1Pj3u7JsyIDnbdzxuW5fzdBrvLB8bNuPY0v5TOWb5Xy8UW27Wsik Ff27jY4lb1Je/zs8EzaFadftlCplIxJM4cMf8A9zRvIlVmEoqcBxfdtDAkyTUaqBFSU1 P3qS+GmPNlns+XqTmWdDKKhcjCCuezbcQ2tiT45WfPAI5Jhw+8Zn6b6B9O8U0Jhbf3Je shh6tYhhU2dyqSTvbj2NdeHFy89gpEjIGEsirTdDTPLf6tr0E5P6NHXHWNOQdj3bJQzD LV4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776940194; x=1777544994; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mvlY+/LRKuKta0O23HLcvzCcFpZOHfGgT1RnwB29Db0=; b=KViiNj4T+dmEEobNKG9For/3DKKeZjqpDReYJPR8ygCeUzItH8jdYpXc1FvoPgTgFt wevl8mrMiISXxCZ5D7ZY6lNJvbm5JUGgHbOC3jg0fGTCUAMSJfCjSgs/cFeIOr3ymlFS VSUXc1t1uBOSyytS0G8SUbFqcRybhJKWykU/lahviBVxx4HcPqQw2b+8ga8/PY7JsfJn FGIFtXZIIy9yuMNFoh2nBoAEb/8HJutAdtjjVHdgelITkUeBqSD5TIH/wANywDXYfoen lqEMzlxZ44XcgEU6ba/OVQbNaHEBuDQtJmo0QPq9bl5zuFZ+urB5gcuOJHj6dsSKFxRI 4aIw== X-Gm-Message-State: AOJu0YxWU7G7wee4H0ZDp442IFGb4JMOhbLnsA2IV81OiAXiLka7cpuS daI+9QM5VC39KAo0gK/+RJAzYxby5A6dvxXTaCUukreIeaTYIXksh8SieZcWvLBkOpTVJZxkmAM PZnqwsIdyRu1W66brIb1u4z8EFLjMhTMOzIwWdCYxcXTN6gEU3kYM39DSa1QIHelBpqZJc3sr7m yc/7l3RM+Judr5jq/zXn1Q2vVsWYNIrngFXKUUyamv X-Gm-Gg: AeBDieuwPAEY8+qQnd4XQ5WlXc5bQRQBJi0kmie0dxSTBO7UuEp2kcLkAx89D3IptR5 JHoY8VOHv3FK8BvmBCG3Oyje84OEVzek+WLLF8SesAuiSxAGlcBYJ2l6I/sONsJmEX1LEOIwoeG 7UQZMoxWnrV2FaQfx6MKP57oUSi5X+Nf+e0ulNtysjCV5/JdPPMbUz1cUAAx932j0UHxGfPVxgF WyIYtp5nqtRUmUTptVLYzGbqugOxL6MQY0GXFaF6ePleeK4COeW/gE25uj2cl8PS+ug2HwVLeOu SGpjU2wEz3Or2pFZzAzKKXH/O9K/nZhu636J+hiRhT5D/dmPtbyG3SpwggLeUMP3OZeG+Xx8++L NXTwwQnNOsieySQnz9rSBShSKQtxsfz7ON0MRLxAjXsnyJTpJs/n8AJWkC2CBrUcv7q5rLSXy7q 3h/V4Tyd2byx9QU/B4Xy79QeGvIyFsjIJ6j8c= X-Received: by 2002:a05:600c:4ec6:b0:489:1f98:71e3 with SMTP id 5b1f17b1804b1-4891f987487mr225663325e9.28.1776940194589; Thu, 23 Apr 2026 03:29:54 -0700 (PDT) X-Received: by 2002:a05:600c:4ec6:b0:489:1f98:71e3 with SMTP id 5b1f17b1804b1-4891f987487mr225662835e9.28.1776940194097; Thu, 23 Apr 2026 03:29:54 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Kostiantyn Kostiuk , Peter Maydell Subject: [PULL 11/25] target/xtensa: Use glib2 instead of strcasecmp/strncasecmp Date: Thu, 23 Apr 2026 12:29:08 +0200 Message-ID: <20260423102922.443639-12-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260423102922.443639-1-pbonzini@redhat.com> References: <20260423102922.443639-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1776940350710154100 Content-Type: text/plain; charset="utf-8" From: Kostiantyn Kostiuk This is a change in semantics. g_ascii_strcasecmp() doesn't honour locale but strcasecmp() does. But this is OK for at least one reason: (1) QEMU always runs with the C locale so there's not an actual behaviour change here Signed-off-by: Kostiantyn Kostiuk Reviewed-by: Peter Maydell Link: https://lore.kernel.org/r/20260327134401.270186-10-kkostiuk@redhat.com Signed-off-by: Paolo Bonzini --- target/xtensa/xtensa-isa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/xtensa/xtensa-isa.c b/target/xtensa/xtensa-isa.c index 630b4f9da1b..c564af340fa 100644 --- a/target/xtensa/xtensa-isa.c +++ b/target/xtensa/xtensa-isa.c @@ -370,7 +370,7 @@ int xtensa_isa_name_compare(const void *v1, const void = *v2) xtensa_lookup_entry *e1 =3D (xtensa_lookup_entry *)v1; xtensa_lookup_entry *e2 =3D (xtensa_lookup_entry *)v2; =20 - return strcasecmp(e1->key, e2->key); + return g_ascii_strcasecmp(e1->key, e2->key); } =20 =20 @@ -513,7 +513,7 @@ xtensa_format xtensa_format_lookup(xtensa_isa isa, cons= t char *fmtname) } =20 for (fmt =3D 0; fmt < intisa->num_formats; fmt++) { - if (strcasecmp(fmtname, intisa->formats[fmt].name) =3D=3D 0) { + if (g_ascii_strcasecmp(fmtname, intisa->formats[fmt].name) =3D=3D = 0) { return fmt; } } --=20 2.53.0 From nobody Sat May 30 20:11:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1776940378; cv=none; d=zohomail.com; s=zohoarc; b=Elpb1bRyyX5XtxgKgJ4ti2PaY9uBiIyqFvdsLgUrc3zeEpBV+5g5aJal/2LBeRKRyHKkwnGYi0sXsSf6b7C2nVrzpdhkZMXFA2oq5YTjN56GD67+W/kunCB6wrGqYOb2hgntHjtwWauchmoLkdWR78jNKOytSv3qbYjv1cQhq5U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776940378; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=O/bgzj+cBYzib+ZwvZuAeH+b8dmvXBVQIfVS5BqtNx8=; b=g/19AxUIbAZV6EbGlx7ezKXhhcPp2D8+WRhBkZCIL02IVuVdF6Osu/ZyuIxadY2suD4+0ms4JYN3iOVw/A24h36T3SSSprbVNY2wUcF0SV03v1EeiAdd4PKiN814uwrZlUBN+HljzyP8xXucpDB0KD6E1etJCHKwViUChE6UHb8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776940378913427.121181692665; Thu, 23 Apr 2026 03:32:58 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wFrKn-00013E-Ad; Thu, 23 Apr 2026 06:31:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrJs-0000bg-O4 for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:30:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrJp-0005Vg-Pi for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:30:03 -0400 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-549-3T8SnFItPgOMS_JBTPQM-A-1; Thu, 23 Apr 2026 06:30:00 -0400 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-43d7757463eso4263767f8f.0 for ; Thu, 23 Apr 2026 03:29:59 -0700 (PDT) Received: from [192.168.10.48] ([151.49.85.67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc177dafsm625788495e9.4.2026.04.23.03.29.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 03:29:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776940201; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O/bgzj+cBYzib+ZwvZuAeH+b8dmvXBVQIfVS5BqtNx8=; b=ipXaEupIMA4otQsdm6y50Z+OG9yTBXuIIeO0KeyQabDlqi+y+OOeWBwTMz4+NRgMM3Loxp HFVaBD7IbZCkRgvqav8f1fWwSnoZyGmPaIvHz1/S1rry4AINGL+m4TFoEPA0tsX/vfOfOk XskFKt/aWl8e3r3249NwZWSPQpigcV8= X-MC-Unique: 3T8SnFItPgOMS_JBTPQM-A-1 X-Mimecast-MFC-AGG-ID: 3T8SnFItPgOMS_JBTPQM-A_1776940199 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776940198; x=1777544998; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=O/bgzj+cBYzib+ZwvZuAeH+b8dmvXBVQIfVS5BqtNx8=; b=WK+ORbR8Mge7X5nhIDXcob8WYorZB44VvSxO69Bvmy9EGQVXbBcTKVAffhdQH1VArC tZ0kAj7hR8ArsFTaPAyLhsUVaWjQ1L4glhAjUEwRiss4oUAARXeWimDvQzUKMWNpriPt FWdyv62AbKcjgRlAQ6N+z3F6H/r98KTSOKLL0CssY3rmSqPz6OnMMOo4DPh7ttnvxiTm PkUoBkXAHBnFuVIjdF8s3dSgBnxLlgOgaVg+0zz4LVMTViNIEFly/l822rjlUnj4zY8b N4M1CTK1cImGJut/UoAUr8xsmLqdFKnoRBFX0hNem4+6Zmzjcs3g29UPacHac+Ip64Va 9a3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776940198; x=1777544998; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=O/bgzj+cBYzib+ZwvZuAeH+b8dmvXBVQIfVS5BqtNx8=; b=XdswzJxz8fLtEgVQMTm+BX8OCAzJLzajRu4QgWFraY2qmnSxMjf506y10yi0uVj4m4 pXZdwnRYjPuSr1A/JdUrH4uutnAcjwIT784ppbAvzvdbQ06R1Dwh/R498hQpWMpJO5n1 X0OkipkVgCKt7S/nfyxPj/FP5xxYtMhWAxfXdOzEyXWZ/qfJz0b6UF8b1lUzjwOSScO0 GKR9SyXH7tjdiUIn8qR7BLWxa5arXKJomJXCQJnEY1jpEFZMOxKd5SKynfuNuXPPvLrG pp1cqvuhFe5X0iU+WS2qRUR6VgbmZRTEgOXzTW/mcKIP9PDiDxyL8kBwlGHAGDiBDnFk yZSA== X-Gm-Message-State: AOJu0YyVx//5b8IbVbOqNmELTH+vgzhd3I//Bma1hRx9E1aJwEyiFYyf D2S1Fdtffj6LZI41+MX87RFVaGRI5iHUCrib7ukLiMb5LTYzgwpuvC8MxWafnp3sxnUPANF95Az jInZHyHMIK2The6MrC6LJEQo60hb7dnASaNfXw7rr0dV6Hh4RHUaSPOx61R8pUJwzhghwdhyobf em86QYAAAUYqtMKRSggzYsx19HRyfPPaPx3pCLEUhy X-Gm-Gg: AeBDiesP6ZGblTor1ZrKbvoygWuJvCLwza4foHE0qii6WCLo4/hZqGTNFO2M84bq0lA jZ0IGkNl7fmkv4nglOX5dcu1EvsiI108rjmZtmdUklcO/gsJIqevMEsbDTD4YLpmWoY632yAMAs uXgZp8uF8xTrvG07nc0S84uQkJgTFtSAkDL3cGJVlsd/waxIUr0q+T/GRm88EwY3CLueyYpmvtx Bhk1C77vsR47c+IzBpB/V4kaxlKSV7qTRO0KPy48eas4939FFP8ejHTQCkW0lGmoQ7PX4PcnZTi 23dGnr2Y1u0++9408eMenE9JGtYFJWvnsEWgK4Zn9ObquQnPG1sFNfOX/tMm0V1xLWcdpUSrQwq ZAwIFEmBJJebzhTf0yEDc3vPBds/JS2hcdxylCiZbu49rXZ5m+91E43vlFUc8LrMDSzPvEWKdNh G04lWD2KVAu/Y0oMXUkFENUm5bQaaT4Aevusw= X-Received: by 2002:a05:600c:a305:b0:48a:53cb:8604 with SMTP id 5b1f17b1804b1-48a53cb8949mr138056665e9.14.1776940197839; Thu, 23 Apr 2026 03:29:57 -0700 (PDT) X-Received: by 2002:a05:600c:a305:b0:48a:53cb:8604 with SMTP id 5b1f17b1804b1-48a53cb8949mr138056365e9.14.1776940197330; Thu, 23 Apr 2026 03:29:57 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Kostiantyn Kostiuk , Peter Maydell Subject: [PULL 12/25] hw/ppc: Use glib2 instead of strcasecmp/strncasecmp Date: Thu, 23 Apr 2026 12:29:09 +0200 Message-ID: <20260423102922.443639-13-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260423102922.443639-1-pbonzini@redhat.com> References: <20260423102922.443639-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1776940381237154100 Content-Type: text/plain; charset="utf-8" From: Kostiantyn Kostiuk This is a change in semantics. g_ascii_strcasecmp() doesn't honour locale but strcasecmp() does. But this is OK for at least one reason: (1) QEMU always runs with the C locale so there's not an actual behaviour change here Signed-off-by: Kostiantyn Kostiuk Reviewed-by: Peter Maydell Link: https://lore.kernel.org/r/20260327134401.270186-11-kkostiuk@redhat.com Signed-off-by: Paolo Bonzini --- hw/ppc/spapr_caps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/spapr_caps.c b/hw/ppc/spapr_caps.c index 170795ad6ad..f4a26a85b50 100644 --- a/hw/ppc/spapr_caps.c +++ b/hw/ppc/spapr_caps.c @@ -129,7 +129,7 @@ static void spapr_cap_set_string(Object *obj, Visitor *= v, const char *name, return; } for (i =3D 0; i < cap->possible->num; i++) { - if (!strcasecmp(val, cap->possible->vals[i])) { + if (!g_ascii_strcasecmp(val, cap->possible->vals[i])) { spapr->cmd_line_caps[cap->index] =3D true; spapr->eff.caps[cap->index] =3D i; return; --=20 2.53.0 From nobody Sat May 30 20:11:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1776940390; cv=none; d=zohomail.com; s=zohoarc; b=U6lwr4zPVWCkaCCPuF7VykI7C57QkBIp+kyCpvhwbBGLyPdjcfdx4SD+Eirq8eNVwKjDoqLJp6OLll4WPAPZcBPKyrzu8MrOs5s2fXz9KSwWapLy2BPLq/72JY5M7EzzSGfJgK5PB1twpSVgEYghROGfJxyAil57Pgv8joyo4cE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776940390; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=90Nm7NqoW1g4/eHo1L/Hmiw+1BI8KJhwBEhR9+JgtqI=; b=C55fX2p7E0dWKtJnTl2fXPqcG9hbP8jvQ0fuY4X0MXADX4gHIUV1gQv1Bqtt/7T1yAhiQ2azgNJ8j653zPgEqO59NzFM434a2xH9u1TlTHFh4p32nJdmWGuWofLjswFyEQT04PxPbqrpSCxtIQardjTq+t7Wp9MfvpWan/aTQcM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776940390330833.8495624726294; Thu, 23 Apr 2026 03:33:10 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wFrKm-00012g-IF; Thu, 23 Apr 2026 06:31:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrJv-0000gr-An for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:30:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrJs-0005gC-IJ for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:30:06 -0400 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-561-XdF1ZRRLNqW72baUwtPSgA-1; Thu, 23 Apr 2026 06:30:02 -0400 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-43fe4674d3eso6130095f8f.1 for ; Thu, 23 Apr 2026 03:30:02 -0700 (PDT) Received: from [192.168.10.48] ([151.49.85.67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc18bccfsm466743445e9.8.2026.04.23.03.29.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 03:29:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776940203; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=90Nm7NqoW1g4/eHo1L/Hmiw+1BI8KJhwBEhR9+JgtqI=; b=aYb0kL9EhJiLdlvwqtQMbpHINpoRsN7/QCX9i3WccYWgbbML008JOK73KaHjHVVjfky5gC 51tNf4uWCHWBFgf4ZFZS4QLsscIoOOaw/oi4bb+FY7b8CJVyocIGRf6G/chq1SMSKM8qhD zY0joK9wH4ucSUD4K3fEhJg+ukShCQg= X-MC-Unique: XdF1ZRRLNqW72baUwtPSgA-1 X-Mimecast-MFC-AGG-ID: XdF1ZRRLNqW72baUwtPSgA_1776940201 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776940201; x=1777545001; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=90Nm7NqoW1g4/eHo1L/Hmiw+1BI8KJhwBEhR9+JgtqI=; b=FBuVxmhYCdBL5zT7hjEmD+70ambo3GvDkyQtti+q+HHib07NGa93b1CK0+cFWg4EXT y59Ukv+MU5MdMgtxM+5jbkQlajpA7XwvGsIOsUPFvFJmibOUehb7ViEbEOhKziP9H5Vt HKZOYmahp+9f6bZVNg462Qc9TTZgaQMmnt8N4Ff7asWb3rLq/it2/eVZvD48foFNtzFw uWQwnTcp8McK2xZLiKTtd8/PAZbfj6fNnQQ+pH4nltCUX5mqhF2XUZJhcUw6yLtLdY6v j2L+j1meQDCgfgQkb7nL3hdIS8QHhU7P5Pt0S8Qf0nr63NRoBGLMPbXiALSAKFDZImj3 7PqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776940201; x=1777545001; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=90Nm7NqoW1g4/eHo1L/Hmiw+1BI8KJhwBEhR9+JgtqI=; b=QoWBhnM5mv/tiwbW3O3+51OPkDiCg01u8mjYH659OgMpgJuSp74Kr+97LEXIb4JBZv iFS2kqRK/6YVFvQs2WHLNcsBFzD/HtXS5P7HCpPgcOUn+lwz5L99VbPLROhnKcsvjG7j U5LZRGpq3ldMOF3dgSDJ0WaurjOhGlxpcyo9NRfSBCN4pETLjh1qnWzSiMYvx38Cprqt lSnLo5QZpZYZkhUvmiGhHXAmYtDqyhJSzMTS6UkPgeZ4GKD8Ba1PkwplqaWCG3aRluCR aHUXPD/qsUPLBgDP0rLmnkqnBrfcNGthBchHvVZaYNf/NVkvNoV3K2mUDRN/RVNlI+Ug 0ypQ== X-Gm-Message-State: AOJu0Yz6xAnHgPD0cDatpeAaRr56QkTwhP2BZSqQKSBJlweJliaEtue+ z4QUrLjICwIgLI/4bS+KKPdAC7H2LEY2BCwck1IQKdiK0/MvdKK/mOBYoK9o7Ac6rkWBt9/KB1W 3kuOY4e9fyFOaiHIyZwDaikpbGa4F/GSCWo+C1mC0aeNShLKe6S9jM0soxkPsXe7fiaEt4eNC/3 5ZJQp6f29AcJAdMa5GiYortoiya1dfzDFPhHmTsfuQ X-Gm-Gg: AeBDiesQIqdJluufK9L3RbjoYQSXHcxNp17RmKOzgyrsBA+3WuamzHpsyxWI+TTJVAz suRzzDnLjyE4F2OXpWsi7CtSrmeoRyLirg0VkNUr/l6cm8JLvofasc2yyBZpnFg1DCuri6dDNbG WD/dYKO1bQxj+5j2eBBl8VBP+XFFZubXuE9siR1bPr0AC3zov+iTkQR4ajvTREQDS1URC+3evLG DeEDdK1kz1mUdWD3H5c9Vw60UD4Irm3Ohd6wQxWumxfU1IE53KLm7xgylIRwcz8WENgrZMAWrpT N95sY8syqUB4as0OWWhkSm5eStKzyzP/VITOS6DCttGftXj9OCqk2c+nihsqYi5DH43z2EMa46N rn9569SdG1lQTH+xQXtDmAgevq2ystu6hJtXC7hzZkfEOD+7G3ugqoEHbz7qdscFNTMpMpa2pES 7QiHnrUvVJDfLN0cQLqhKUMgLpoxfMXyVgs4Q= X-Received: by 2002:a05:600c:5299:b0:48a:5342:36b5 with SMTP id 5b1f17b1804b1-48a54514646mr174394695e9.21.1776940200644; Thu, 23 Apr 2026 03:30:00 -0700 (PDT) X-Received: by 2002:a05:600c:5299:b0:48a:5342:36b5 with SMTP id 5b1f17b1804b1-48a54514646mr174394275e9.21.1776940200199; Thu, 23 Apr 2026 03:30:00 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Kostiantyn Kostiuk , Peter Maydell Subject: [PULL 13/25] osdep: Remove unused strings.h Date: Thu, 23 Apr 2026 12:29:10 +0200 Message-ID: <20260423102922.443639-14-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260423102922.443639-1-pbonzini@redhat.com> References: <20260423102922.443639-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1776940391386154100 Content-Type: text/plain; charset="utf-8" From: Kostiantyn Kostiuk We don't use strcasecmp/strncasecmp anymore. Also, we don't use any other strings.h function. So this include is no more needed. Signed-off-by: Kostiantyn Kostiuk Reviewed-by: Peter Maydell Link: https://lore.kernel.org/r/20260327134401.270186-12-kkostiuk@redhat.com Signed-off-by: Paolo Bonzini --- include/qemu/osdep.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index f151578b5ce..2f0e61ad6b2 100644 --- a/include/qemu/osdep.h +++ b/include/qemu/osdep.h @@ -114,7 +114,6 @@ QEMU_EXTERN_C int daemon(int, int); #include =20 #include -#include #include #include /* Put unistd.h before time.h as that triggers localtime_r/gmtime_r --=20 2.53.0 From nobody Sat May 30 20:11:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1776940338; cv=none; d=zohomail.com; s=zohoarc; b=aSi0dh4VTKq2UtakPW/nF6nE+UuPmTPg0mnSXfr2QSBrm5CbrH9Ta4sfK1LguHmLTCAUk9oQXLgz7MotKcCXXzXN4Wi7XY/ERDHYLrx2wCWYX8d7I5xaPaI1k9+hmwd3QPDXxbrDk43p8Qo7/edLQO68K50LQQbLtvYbHb72TXI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776940338; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=zOuPjc89EHllUFep7jGoHo94oMz+W7UU+Hi8tYvFcJs=; b=ClmDWukrTfJOIyE5ZpX1osQ1r1WQeFuPaWVDrRfgoeCwW0rU2gFwY6FhgHqHPuLSukILRpqexDJK/5P/9mZJ6rQxTwPLiGjdcFLyjEFna1cY+5c/QElc0r4ec/Gd/KOU5VLGz2MqZdUcRsD1IAt3uchW5uliJ77SRpRsI/bt6+o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776940338336300.4508299772036; Thu, 23 Apr 2026 03:32:18 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wFrKl-00012Q-QY; Thu, 23 Apr 2026 06:30:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrJy-0000ib-DZ for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:30:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrJw-0005kK-5c for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:30:10 -0400 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-57-rfv0lUC-PTOPt6F-nFkk9A-1; Thu, 23 Apr 2026 06:30:06 -0400 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-488d1b5bca0so37746815e9.2 for ; Thu, 23 Apr 2026 03:30:05 -0700 (PDT) Received: from [192.168.10.48] ([151.49.85.67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc0f82bbsm875487775e9.3.2026.04.23.03.30.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 03:30:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776940207; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zOuPjc89EHllUFep7jGoHo94oMz+W7UU+Hi8tYvFcJs=; b=OJY8FrRgOsrPssycs26+jCyvwbwGIgxfeDvmLjJVzPKc583coFZEQxN6V6a6Z/iXvHKYCC hjDgepTA5Nwcrynp9KrFV4d4K6O+acGkD+bvPVy5IZQfnyjSM0ag3QNMHEowLxjHtP7FLi lhe0Wqt1tfx23CDFLTKfelqZ+/5Uw3c= X-MC-Unique: rfv0lUC-PTOPt6F-nFkk9A-1 X-Mimecast-MFC-AGG-ID: rfv0lUC-PTOPt6F-nFkk9A_1776940205 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776940204; x=1777545004; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zOuPjc89EHllUFep7jGoHo94oMz+W7UU+Hi8tYvFcJs=; b=l4viq246YTVDn1Byn2rA4ABjdkxVm82Vvt3Z5rEXl8+uq/9Sm94w6aVGX6Sz0RzEFu S/0rrhLnqxG2IQ9SZYYFhGAwbNZBVEXAdnWBfzW2Ihgr5MtCBAeDwmIQfZqYIiGXJfbu eUK//tpRh8/jDEqzMURdLHHQq5ky5MVa7A0iQDbOFPU8EeO9DpB6ZB0+TndOkdH0gEgT dVVusvSXAeljLQmqvCLhH/E+C7fKvhCxzZAtYAw5JhRIbwBPWmcqOoWCq0jpavjcsqBF W4ZChF1NB3vKC5JP3au2Hx42HAwHIz0mWRddNn6bwgqulxrnCfpMEyVlhhK010eGaiZF FG2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776940204; x=1777545004; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zOuPjc89EHllUFep7jGoHo94oMz+W7UU+Hi8tYvFcJs=; b=gVLyjsYOnRv0t++sN9WenBiYM4K158LCTK9zff1fbS2XGXNQokyJ/nmE9EfPtpSkmW jJXN0RMZCsIuoCCw978wv9jJOmR9T3LGJnPBrGwXcvTL07e0TPgXOPxLVfBlTedqPPmg W+lCRgO1ZYppwFXFvcZfxKPO+D0nJiKlmFqSF6HwsWExh4ojrLhz1klwFHXMap8tezYv sVaVu40ONx5jV0rJ+ZsCVLaT4on5eDI8/uWv4z58z9atBW2nNWK1mpRS+rZxOwjFOR/3 AEPdyvT1V6yrQY3/WsTV9M5iGSHcAiyhpC4x52K/OESc13adYOepPeKGz0Miuj0iyO1z pDwA== X-Gm-Message-State: AOJu0YxRR155HqHXfaYkkM4Rs7CJ4u43mdenCxkgT2lX2tZmcLIj5QWf 3dF21a0et6JTUrmYAtgaStAmVeE9p2+73h1RjAGcSPP31eF+P6GrVMtcn8n4wzoJGOIjjeBXLwx txp4u0K+wVxf5In4yB5ZWWC2sTfy1EmkAv42BTlBRvB6o7XLk3uGnEMFDTCqz+LoLusBxyUYX5W PR4xVIyb/6ETd12rdQPROPamrDIPehBsdRnttnrlrR X-Gm-Gg: AeBDieuAsETQDnSdJ740elBFOiGIEEOg4Umivc16uXg3iaxwA5yn99byAIV3dkzDpmp r55gyWWQTa5Yin5grP+NvmPNIIMjj1Z3cc0IQkVKz6fJkxA9lgCM1U7ncDboRlQfk6Xw9Fifvrj TFUKaxYtKJ3seTTDG89ptQPHT5cvviZfHoZy3/MaD47Q/MD3T4gK0J3imN1bBRkHBqKh78Vs31I WyY3FUaVH15KoNo1pgW4kwpszADWU+1tX/lpH37nNxxVlV1+29EuJL83+Y9UuPz1fGjAqUAWr/M xw1/k6XicA3qFDXr9CsJLhbYxase/d2qLiUqRef0lMsRfxod/DMYP8z6wjlsvwJ1tpXiPNltlu7 HjqxQNNf7PsfQ3gl5EqSucGlATLlbhOLQ1ljkcF+/X6Rvmj8s1W1wmSi1PXMyY93kWQhivN0klh wVyg13Dae78W8GPiKrxKB/YQzdweHpdBzZf4o= X-Received: by 2002:a05:600c:a416:b0:483:8062:b2f with SMTP id 5b1f17b1804b1-488fb73b31dmr316563415e9.6.1776940203938; Thu, 23 Apr 2026 03:30:03 -0700 (PDT) X-Received: by 2002:a05:600c:a416:b0:483:8062:b2f with SMTP id 5b1f17b1804b1-488fb73b31dmr316562845e9.6.1776940203364; Thu, 23 Apr 2026 03:30:03 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Kostiantyn Kostiuk , Peter Maydell Subject: [PULL 14/25] util: Remove unused dirent.h Date: Thu, 23 Apr 2026 12:29:11 +0200 Message-ID: <20260423102922.443639-15-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260423102922.443639-1-pbonzini@redhat.com> References: <20260423102922.443639-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1776940340586154100 Content-Type: text/plain; charset="utf-8" From: Kostiantyn Kostiuk This one is OK to drop, because the rewrite of path.c in commit f3a8bdc1d5b26 removed the uses of the dirent.h functions. Signed-off-by: Kostiantyn Kostiuk Reviewed-by: Peter Maydell Link: https://lore.kernel.org/r/20260327134401.270186-13-kkostiuk@redhat.com Signed-off-by: Paolo Bonzini --- util/path.c | 1 - 1 file changed, 1 deletion(-) diff --git a/util/path.c b/util/path.c index 8e174eb4364..72a255890e5 100644 --- a/util/path.c +++ b/util/path.c @@ -5,7 +5,6 @@ */ #include "qemu/osdep.h" #include -#include #include "qemu/cutils.h" #include "qemu/path.h" #include "qemu/thread.h" --=20 2.53.0 From nobody Sat May 30 20:11:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1776940275; cv=none; d=zohomail.com; s=zohoarc; b=NEDY0V3MPhDXaQjbL2S+5yAuKYVBGG7cSIHy1eFFmbbngGqH7vhrrp37OckGZk8uAa8Gk01XDAsNGpuaz+Hm4+eHNvUm34lSFNDYEDKMq/ab60qnQzRhAsk65oygISgdofCfY3PpNXUGN780JmkecZ2hV4LK66rZOdkpd+XH9e4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776940275; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9hk+it+aWf+hIiKfd3aH+Bql7T1PmX28V5gYZq4O1mI=; b=klDedesXq3nAwPFdGdd0YMEkf3VfJYHdd1xRGYAROf+OhhQwg+3NIUIj2R0ezz0XiyX2UIZyg+VO3v0KJ5xgGHZcWmmOrt+2EvCJgTZnLC6doyTsv8wtc5smMJqPK6VqnUEHaoXp58/JsgX4/usCPGrKSBY1x41PkcZqoON1ITY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776940275961797.096119183451; Thu, 23 Apr 2026 03:31:15 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wFrKo-00014c-EG; Thu, 23 Apr 2026 06:31:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrK2-0000l4-6y for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:30:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrJz-0005kt-3u for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:30:13 -0400 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-490-96H_4pUhMK6EUrDDmO5YSA-1; Thu, 23 Apr 2026 06:30:09 -0400 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4837bfcfe0dso72599695e9.1 for ; Thu, 23 Apr 2026 03:30:08 -0700 (PDT) Received: from [192.168.10.48] ([151.49.85.67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a575ad67asm155359945e9.2.2026.04.23.03.30.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 03:30:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776940210; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9hk+it+aWf+hIiKfd3aH+Bql7T1PmX28V5gYZq4O1mI=; b=HN03l5RkuBEL0fx0EXNftjBURHJLTX67/Z+BthjU+tdk04KOkB430oHksXGzWa01M5WmiY jvD1q/KYtLDF2xrzkLMipLfO7FzNKK2G03rNflP2MU8+zgFai5UltDjlwu3Mfb11PIlK8V IY82gh1OiiTO5mZ2vkbNP/Ew0iwvHtA= X-MC-Unique: 96H_4pUhMK6EUrDDmO5YSA-1 X-Mimecast-MFC-AGG-ID: 96H_4pUhMK6EUrDDmO5YSA_1776940208 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776940207; x=1777545007; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9hk+it+aWf+hIiKfd3aH+Bql7T1PmX28V5gYZq4O1mI=; b=aQgyikV20FvL7oGyWb97vL6MAJ3GOdtL994ZnIoOo2Lmba6xQtsJxnnlouDaQY8vai 2hpyGbZheL5mG5AIaQ+Hh7hllXeuPCwBKeSnQ4QZTatJNtqvaw0Bp0QqvAwA3KYjoRTI 8cnVAd+hDo8B0aSkRMM2TmaIVM9qj2v4ZlAUFs7BpS8t0eHCgXDEVRO8NNuktuHx8INK j7ccbQub/ZPyWAr0RGVQjtGuf5hJdWjXc+W1dWVcIKb4cUCKLYZCcGKiALchncGWQ6e/ e6Nai71F1llx3z+apZxjPKAKRo8aroq0qKiRl8SXNI3d11GYBnxMAQUUgqfk4Uu4ozov 9oEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776940207; x=1777545007; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=9hk+it+aWf+hIiKfd3aH+Bql7T1PmX28V5gYZq4O1mI=; b=CB62dragHRAj2UAmnCerJOyAuIem0/s7EriNSzvK5ad8sgogc7IbPR4cYvSn/4GIFX guIE3clJD7wxE1hPg2MhvRFeILytXMEpnxVejsbBRaB5u5BJ7mKwlQDM1Xwb0oMKQdU4 7KAoDZi2dnuDtFCd9VTCjOZ9KTh1LAYrIsgVXZEHWp9ZMmO3fFXCYHSZMrITHT2WecOw PBTmtnwYIxN3OWvFI73Ldv4VhE7TtdvdbQilpL5WsmmT/tXLpKGBkhnNhPEZHVgR9NxW 9ly5uThG3hDnrAXD5e50oYP3uHAwQzR+N+kK/HunlOXCOO21t9LUl5HPLBIqdGiMCN7a 7XZQ== X-Gm-Message-State: AOJu0YzMMwVurJPz4henhDp8KTM2bG5gWjCYeSPRzEMIzYS3e8Ik9RMp gXaL/Rpp023D080a0zGMhciShemvcZ1+NfHPlExNkJUKZ1ytv4qOEu5sSGN8cYTlSyCwwr/s7k/ BurKvDcRx0wC/qbjKrVH7KGAzpHnO1+hIY6gaougsPZQOn8f6D0RUFKVO02LCJIwLiXodmYP9L0 SUR5EltHLSWNZZ2FVYU1AcYgECK5xj2X7QfIg0ggM6 X-Gm-Gg: AeBDiesaNsv7hXSAOXGyuop9YBPfiXbqj00/hyGQm/v/LgUSKe5mKPjaPcCUV5St9ej Eb0FkBCgpeb3DQTx6dOFp9THHMI9VSVvapKCLKr9aYbJSgYCfChzDjdWSbw8Z10qm8+X1VpotEC aJw1QPkeI+ZGRGCun0V6F7x6k8ZUe5CFHmeH/Mpk3qQXW5uHo3VbdF8IcF1XR5BoB3PW3QYfSfY IMPhh2N29o35tiZo+GN8GsQ7UFXr06xa9Wo8K6QXmyBiuq7/hn6puUaELhGCDOKjjEShXKM55+C FO1S3fEHE5khMZPrFe7ZenW3MBcTkKxYrSjw1QS6X6gv7IcXxW3naQf8eRHy2twyleTe7u7oxx8 80H9dypRsFzI+GwbZIsWSURw4OwopwsDJ/3YoEMfDw8/e7GG2BJ+ZrlB7Ljx3MZjJvdPz1KNbx5 YvTh+jqbWtJcG+Fdx2eWC2K7za/yE/CaPbpCU= X-Received: by 2002:a05:600c:1616:b0:489:1cd2:6106 with SMTP id 5b1f17b1804b1-4891cd261f1mr133250505e9.6.1776940206886; Thu, 23 Apr 2026 03:30:06 -0700 (PDT) X-Received: by 2002:a05:600c:1616:b0:489:1cd2:6106 with SMTP id 5b1f17b1804b1-4891cd261f1mr133250025e9.6.1776940206286; Thu, 23 Apr 2026 03:30:06 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Kostiantyn Kostiuk , Peter Maydell Subject: [PULL 15/25] util: Remove unused sys/param.h Date: Thu, 23 Apr 2026 12:29:12 +0200 Message-ID: <20260423102922.443639-16-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260423102922.443639-1-pbonzini@redhat.com> References: <20260423102922.443639-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1776940282212158500 Content-Type: text/plain; charset="utf-8" From: Kostiantyn Kostiuk We dropped the use of PATH_MAX in commit f3a8bdc1d5b26 (which basically completely rewrote the path handling). Now we don't need any sys/param.h defines. Reviewed-by: Peter Maydell Signed-off-by: Kostiantyn Kostiuk Link: https://lore.kernel.org/r/20260327134401.270186-14-kkostiuk@redhat.com Signed-off-by: Paolo Bonzini --- util/path.c | 1 - 1 file changed, 1 deletion(-) diff --git a/util/path.c b/util/path.c index 72a255890e5..e1565894d20 100644 --- a/util/path.c +++ b/util/path.c @@ -4,7 +4,6 @@ The assumption is that this area does not change. */ #include "qemu/osdep.h" -#include #include "qemu/cutils.h" #include "qemu/path.h" #include "qemu/thread.h" --=20 2.53.0 From nobody Sat May 30 20:11:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1776940325; cv=none; d=zohomail.com; s=zohoarc; b=aH3bp7Fqrp811pPstADndJQmHqY6Y/j/r/5nfmxNLIe1sGxxnmKuAiMzfE3h/A5o6waFXPI4Zg9n4Wq78m+GxkdJrWzwFkg9wLa/avPuenDlL6qAVHCGP0lopXaxzCTN23ERSVeIiLIhdT6TiVJD69kqwqjr+olgxflK7DIwzV8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776940325; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+opM6B29NFnMnoIK3LpgwpjJGXql7WfZ6osp4sHpqPE=; b=OTx/Wvqzk0R2u0j1VDsgvZ9M8svDQY4YPhhoIxGgf3+TlCVUIlYbB5GX10n8wnSeM5dTXSNNE0LdibVP0UifynXRB+lIqmgdkN5Rppc4dxZrgD/p3brqFqK0FoTCCOPGb8z/boQZRvgGHqCxArL/qrfkZU/FZlmGWWwQ1+PZRng= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776940325922711.9836919274503; Thu, 23 Apr 2026 03:32:05 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wFrKm-00012a-6T; Thu, 23 Apr 2026 06:31:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrK6-0000lM-EC for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:30:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrK2-0005l9-9z for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:30:17 -0400 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-302-B-XholsZPeqehq5eG_4Oww-1; Thu, 23 Apr 2026 06:30:12 -0400 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-43d7b7bacddso4602255f8f.0 for ; Thu, 23 Apr 2026 03:30:11 -0700 (PDT) Received: from [192.168.10.48] ([151.49.85.67]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4cb135asm56685330f8f.6.2026.04.23.03.30.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 03:30:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776940213; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+opM6B29NFnMnoIK3LpgwpjJGXql7WfZ6osp4sHpqPE=; b=JtuQ/jw4VQhLTwpX9TrDzPLLxQdoP8nRp0HjTG0qO2kf4AL8gyh4P8l0ZtenbxFHrXpPhb iFBFAWgwzqSIYfBB+Y5DqPK+esia2IwMn+qC0m0zIOmuWrSsy9oO+Q4KfclyBErwW3UDob 63TKqr1TNqw+GcK9izznb45qzdemEmw= X-MC-Unique: B-XholsZPeqehq5eG_4Oww-1 X-Mimecast-MFC-AGG-ID: B-XholsZPeqehq5eG_4Oww_1776940211 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776940210; x=1777545010; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+opM6B29NFnMnoIK3LpgwpjJGXql7WfZ6osp4sHpqPE=; b=DG0s/oUKMH2QU8cCQT90vRSIgKiH0GZbCl392q2rn4mvU6TSCqo54MhZSEOEV1kI11 j3j5YycTALsj8qho2R/pDyYIKz4XhjsHRAaY2KUZil/iYf+pJbSjHWGm0TBYEoco7tMv 5QQBbBn2Wg9UTK5yCu3ztyx6ODWCYEoYtfkdLbH+SxlWRH2R/dLKm8/KdJxnD96zPRTJ y764+9kiHJKx+hcV8lMXRfs+0AA+85QhqgTPQnpQ8X7XD5imNVS+b81I7EfEfe/HIPAt YqxttDyS4jnHlRbTph2HrpnyNscNFMGsiXsuKbdcM8+GiiS0QUbEVVICROYVgPXl4rbI cDLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776940210; x=1777545010; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+opM6B29NFnMnoIK3LpgwpjJGXql7WfZ6osp4sHpqPE=; b=MqwPakOYmpmOW9Hdl4T5BhmbxSjvG3LZwc5BlvY3GzEHN0z/GCRiJk+dNc4M6lBVsy n1UNNSdLzq9X7GIg6n/Xl7vTsOAY06yifqjiqQLC9/ILGcGicTNkM6NvhoLOKtjk016G 2H9SJn/sPYVHpHUnpk7A9Yk5Kxu80tutCAi8ACGlGrzy2ee6MXXzfMEDI1jRiZcphc2v moJJQrmbWz4DcuaDufNLLx3MvzaUeqCkjrTn99/SApmrWneXbV0Zmx3O2SfVfXE7vgeo aUU4nTE9fwkrKgTiHW31G5aIZqH1lWkl494gYWUgF1/PjoB57zsmZGQMLnhGJipMtxiN J0vg== X-Gm-Message-State: AOJu0Yw97tfSwhtspo5uHS0MoKNwhRNJA4Y+j8XDPjvcZGU0g1ZZDqaQ yPxFakV7SR7talIDL9AE+6NMxRgDofmHfEpzsUwTD+iKJ+ijb2r7sr9zQOTgyJ0BZuMqN5TObzn gIYoba6ZcFp7j7AUi71XJkvgt5eWqsbhohWRVvMGPTY+3xcaIchGgfXyFuuSwOSfdpNq1w8+hWf ZshmWhQrOiLf1oGrrk3pWU9vM4ZmFMkJiQv1ucX3Nc X-Gm-Gg: AeBDiesO+B4GPPZd0DOyz7Awz09Q5b97iiK+dLADjS2OiVoMV4UmwO0VQrZkUwGEA+D gvPkSiAQ7jbzAhvMGTPvaI4sEh3HagW0164ff1tnsJhcVek1GYAxUylPg1zizv3bH20g/SeLRK4 CsDfmzINBlPe4XsdE0e3SGt/kcxBK4xX98gPtBwEGFAxTMS5riFaAtTyUYS86K56OCr74visfQC fx1FzgG5PhcdmZEzjdre2mq4egb5wp+zwdqcAjWExJAvR3Waquwdp9T6DylABFzHEEbX/5Ct4j4 ta5DEWNwTF/bLGY+0F01/GvJGJ6tW29sak4f4u0s9hyH65QiYAm3QyZfiZeuDoue/WYzbRWiRHc M4EYUJD5eplE5m6Vr1WyiXtUjYoFIRbmcUJua3SW3/rFenBI3tpQbubCBrRtttxufl8pvmdA5DJ mJHssRebRrORzleUBVZMGc/uLkhe8zYZ/+/tc= X-Received: by 2002:a05:6000:2087:b0:43d:6787:9933 with SMTP id ffacd0b85a97d-43fe3dcae81mr41832464f8f.13.1776940210254; Thu, 23 Apr 2026 03:30:10 -0700 (PDT) X-Received: by 2002:a05:6000:2087:b0:43d:6787:9933 with SMTP id ffacd0b85a97d-43fe3dcae81mr41832379f8f.13.1776940209573; Thu, 23 Apr 2026 03:30:09 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Kevin Wolf Subject: [PULL 16/25] storage-daemon: use same link arguments as other tools Date: Thu, 23 Apr 2026 12:29:13 +0200 Message-ID: <20260423102922.443639-17-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260423102922.443639-1-pbonzini@redhat.com> References: <20260423102922.443639-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1776940328563158500 Content-Type: text/plain; charset="utf-8" Reviewed-by: Kevin Wolf Signed-off-by: Paolo Bonzini Link: https://lore.kernel.org/r/20260327134401.270186-15-kkostiuk@redhat.com Signed-off-by: Paolo Bonzini --- meson.build | 8 ++++---- storage-daemon/meson.build | 16 ++++++++-------- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/meson.build b/meson.build index 457491c34e2..09cdd317699 100644 --- a/meson.build +++ b/meson.build @@ -4505,15 +4505,15 @@ if xkbcommon.found() endif =20 if have_tools - link_args =3D enable_modules ? ['@block.syms'] : [] + tools_link_args =3D enable_modules ? ['@block.syms'] : [] qemu_img =3D executable('qemu-img', [files('qemu-img.c'), hxdep], - link_args: link_args, link_depends: block_syms, + link_args: tools_link_args, link_depends: block_syms, dependencies: [authz, block, crypto, io, qom, qemuutil], inst= all: true) qemu_io =3D executable('qemu-io', files('qemu-io.c'), - link_args: link_args, link_depends: block_syms, + link_args: tools_link_args, link_depends: block_syms, dependencies: [block, qemuutil], install: true) qemu_nbd =3D executable('qemu-nbd', files('qemu-nbd.c'), - link_args: link_args, link_depends: block_syms, + link_args: tools_link_args, link_depends: block_syms, dependencies: [blockdev, qemuutil, selinux], install: true) =20 diff --git a/storage-daemon/meson.build b/storage-daemon/meson.build index 5e61a9d1bdf..fc088cbea7f 100644 --- a/storage-daemon/meson.build +++ b/storage-daemon/meson.build @@ -1,14 +1,14 @@ +assert(have_tools) + qsd_ss =3D ss.source_set() qsd_ss.add(files('qemu-storage-daemon.c')) qsd_ss.add(blockdev, chardev, qmp, qom, qemuutil) =20 subdir('qapi') =20 -if have_tools - qsd_ss =3D qsd_ss.apply({}) - qsd =3D executable('qemu-storage-daemon', - qsd_ss.sources(), - link_args: '@block.syms', link_depends: block_syms, - dependencies: qsd_ss.dependencies(), - install: true) -endif +qsd_ss =3D qsd_ss.apply({}) +qsd =3D executable('qemu-storage-daemon', + qsd_ss.sources(), + link_args: tools_link_args, link_depends: block_syms, + dependencies: qsd_ss.dependencies(), + install: true) --=20 2.53.0 From nobody Sat May 30 20:11:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1776940370; cv=none; d=zohomail.com; s=zohoarc; b=MF8zPmNq+n6xKyPB9P0hU7XF9a8hwNQOMzFlrBfMvolAwEpgHBXKLh921MbpzOXAT7p+DVx8fTON6L+k+kkUgkXNhLTRqqMT7u1MZt2pX/PEZPqnlAbzwXkcWWVCGfCq+L9DrTMhBhEOnIyOEK9LtJD8MhpxAfM7bSZuSwNxorg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776940370; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=SvezQ3MLTmkGpNYucQ8nhsSa/DAi1TK3VmsXEHyf4wY=; b=JMd4AYbIf/ubduDLHaG8YzzCDPnW1PumD3ZwpWEkWwxakH8bHrbtOJmmUkBYJs3PZl0LluVwSY7NRMAIGWEx0ad/pqUK/1LypsprP8hZp7BAJtB2x2kRJ3kaA15Ib3dvXv7fRlX3+3/W57ObhakzwuMW1SHjdNMNpbvRnSPBsYY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776940370985771.2498059433957; Thu, 23 Apr 2026 03:32:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wFrKn-00013H-B2; Thu, 23 Apr 2026 06:31:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrKE-0000nE-FC for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:30:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrK9-0005mh-Tj for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:30:25 -0400 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-80-re61eB8AOFK1pKUH7-GGfg-1; Thu, 23 Apr 2026 06:30:15 -0400 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-48919890a95so31319045e9.2 for ; Thu, 23 Apr 2026 03:30:15 -0700 (PDT) Received: from [192.168.10.48] ([151.49.85.67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4891bb3d121sm484876215e9.14.2026.04.23.03.30.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 03:30:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776940218; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SvezQ3MLTmkGpNYucQ8nhsSa/DAi1TK3VmsXEHyf4wY=; b=Xo1KHFjLNekvErf6Cji7IGAHmDM5FhH7Is0CjjEvHMK3YolqaHPgLSntgW184ZEoH7QeHq rpIJ/F+qIgBWpmDh+A9/1EbSV0fDVkGThAd+xjFFCYPayfxkwBrcj+7d3uIIb8GsqYnCbt c5m4InQaFwuxvBTpJsxj/82x2eNRknw= X-MC-Unique: re61eB8AOFK1pKUH7-GGfg-1 X-Mimecast-MFC-AGG-ID: re61eB8AOFK1pKUH7-GGfg_1776940215 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776940214; x=1777545014; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SvezQ3MLTmkGpNYucQ8nhsSa/DAi1TK3VmsXEHyf4wY=; b=dMlg3r8inZRJG8H86pqQR2AdPDsA3NKwfqffDMOkHramzGuM+6mzhWldzU2WN/n7BO yvGT6gMIbXAPVrKm7qdwi4Wjix3pd869LYhEud18p2odT28RRF2lM9wnmGY4PErM0Ozj WiVX7CSHB/KeqCmBOGi4x3VFEIfjIsiQuMo4/kQR8Iqmnu4AwOvEBLQrlsHzSchOKbDV f8Et/qiCZGrVecACrkXSWTv//UKRuGQ6xkDs/sXokbGPEmG4dAo/4f8l7d9SwFeK0AOS tXIab7wJ6pUubOi5LKzNX+PuWmRRudUsh/BGUQ0EvJY14rdK8vbl0ha1I/KKgmjPvDCo YHzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776940214; x=1777545014; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SvezQ3MLTmkGpNYucQ8nhsSa/DAi1TK3VmsXEHyf4wY=; b=Cc4Lnd5b3/8yT9M/GKRoW/rWKvIvcc1+N2BSdidHxDItgCtonnscEjJtqMJiWR+SIW CuzrBcahfuRcX6KHqpgKGTOKS8NKBoikCcvTRLef2oFBTSMVYGLD7dCsXNTfnvdYBMqb v5b1DwT/L6MPk2o8d6ZJXakCLsi2jl7eQBXDr9cJYOkuNxapW1f1Eq0Bif59qa0LY5jS XM287+dc2cSzOoB24i55ferc0qNrtEcWhRZZSEmZRMVeoChpo5t7ItRdoSbUSLeVLu3e 292e5pp2fYGHGLwHIwkPdRuLYXReRAnWMJyNv7QU9aE/cA3ozFvBOEcnJlQLJmrBuzH0 H8HQ== X-Gm-Message-State: AOJu0Yx13Zy+AeINTEZ7weGkSX3hQtrbUJ9ikRX4Q1E9aYJWbQlw8aE4 BW4QOZZuERiPGQ7A65JjP7NUun5AI9Sr53G9RLSa91qpQ7DQpa3G5VacZB6iFkDRRfaSBBcB0Ti mTCYkLy/9dlyk0n6dAJRsP4/qtJ8TUmFsMg234Ruzxj2q69mlHPNRcktZ6n5DKUn4Zo9hmuYJna d5I8IWsVdwJIt0DsaFTqxOmCCgnJmPe7+oEhnDS1Pq X-Gm-Gg: AeBDiesETDzaQ7w7JGmBCbiR6h9GM1dIfriIYt1BSJdzbXY5NfBOEJuZVilxV7xzJXp hH80QXVvkIbTbEdH2ySC/zb91nX/7jz3QWM0fkuWO5dmqQ0NUd0+8T68wD7hhbSL6yb3H6p5Vuw H2rWdDdRKD9LIkHh+3Vx8+Qrsnyx6pdJ8EOBAdH2kMZVsAVF0IHRUiYBGSCNbWRCwPHYMiIiZGC u3Q61OvOSDSo9zsz1smfe/R775RDuNXAIULwl9LiPfMyzig1+Z+q3rOQvxwHGZ87wjDCmy+5gQ4 JZaciezuZUkMC0X2eiG/xcd17xIkgzJ8yBkqHEuqZ/0sZRSI+jQL4AdPAeQ4l4EUx7fOky/9zQY 7q2GPm5TAj+tBiWjMXEwtlgnW2PIAaexGHBhVJPkcfhCSa+lVDGvt8j0gjUKJ826v9dKBg7jhMy 1q1JPL240hV3ZM8bZ+dk+Yub1wJbTTRQ52cqk= X-Received: by 2002:a05:600c:64c7:b0:488:a2ac:a334 with SMTP id 5b1f17b1804b1-488fb73aa3bmr395055905e9.3.1776940213384; Thu, 23 Apr 2026 03:30:13 -0700 (PDT) X-Received: by 2002:a05:600c:64c7:b0:488:a2ac:a334 with SMTP id 5b1f17b1804b1-488fb73aa3bmr395055225e9.3.1776940212695; Thu, 23 Apr 2026 03:30:12 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Kostiantyn Kostiuk Subject: [PULL 17/25] meson: Don't require nm for non-modular builds Date: Thu, 23 Apr 2026 12:29:14 +0200 Message-ID: <20260423102922.443639-18-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260423102922.443639-1-pbonzini@redhat.com> References: <20260423102922.443639-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1776940373104154100 Content-Type: text/plain; charset="utf-8" From: Kostiantyn Kostiuk In the MSVC build environment, nm is missing; at the same time, scripts/undefsym.py exits with code 0 at the beginning for non-modular builds. So, this change is harmless because it already didn't do anything in non-modular builds, but remove the additional tool requirements. Signed-off-by: Kostiantyn Kostiuk Link: https://lore.kernel.org/r/20260327134401.270186-16-kkostiuk@redhat.com Signed-off-by: Paolo Bonzini --- meson.build | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/meson.build b/meson.build index 09cdd317699..a962b181e64 100644 --- a/meson.build +++ b/meson.build @@ -3906,6 +3906,9 @@ modinfo_generate =3D find_program('scripts/modinfo-ge= nerate.py') modinfo_files =3D [] audio_modinfo_files =3D [] =20 +block_syms =3D [] +qemu_syms =3D [] + block_mods =3D [] system_mods =3D [] emulator_modules =3D [] @@ -4021,18 +4024,18 @@ if enable_modules if emulator_modules.length() > 0 alias_target('modules', emulator_modules) endif -endif =20 -nm =3D find_program('nm') -undefsym =3D find_program('scripts/undefsym.py') -block_syms =3D custom_target('block.syms', output: 'block.syms', - input: [libqemuutil, block_mods], - capture: true, - command: [undefsym, nm, '@INPUT@']) -qemu_syms =3D custom_target('qemu.syms', output: 'qemu.syms', - input: [libqemuutil, system_mods], - capture: true, - command: [undefsym, nm, '@INPUT@']) + nm =3D find_program('nm') + undefsym =3D find_program('scripts/undefsym.py') + block_syms =3D custom_target('block.syms', output: 'block.syms', + input: [libqemuutil, block_mods], + capture: true, + command: [undefsym, nm, '@INPUT@']) + qemu_syms =3D custom_target('qemu.syms', output: 'qemu.syms', + input: [libqemuutil, system_mods], + capture: true, + command: [undefsym, nm, '@INPUT@']) +endif =20 authz_ss =3D authz_ss.apply({}) libauthz =3D static_library('authz', authz_ss.sources() + genh, --=20 2.53.0 From nobody Sat May 30 20:11:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1776940367; cv=none; d=zohomail.com; s=zohoarc; b=mm3z0cjLUQvBD35bMjZSvQxvZ8lQ5Vk9TVh/c9rNRKbKAg6lrBUOGFeOPuqUeTts4gng53bhL0rCFZU16hPiA/kYpswoZGD9vwlRsAg220ETx/jO+oozaW9jwpKINliX9ptxVghvaeYLNzLbAHrv3zkIyVVArNO18vyFIIA8/QA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776940367; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=3n3FxpdFX8QEwtruRPtTMxey3qCGIDC6XniieDlmvks=; b=K9qOggiBl8r3flTpwiLAXiZjQNYyhfmJPouvqOnSR0EKfQFAZNKogS1XEPnREkkr2GO8tE7XPf53pCxKCSQ+CBgg7C08dQPAjVScKJDFL0zsx9901iczxeJIan4JBGX9z3I1aW9qz4+aTcYa8g0mnDdAEjKhof4UbaMvXSoibeI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776940366994662.868097035006; Thu, 23 Apr 2026 03:32:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wFrKn-00013C-3H; Thu, 23 Apr 2026 06:31:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrKE-0000nF-Gl for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:30:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrK9-0005me-SS for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:30:25 -0400 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-610-MonI686aNKKAVkVp6Akexw-1; Thu, 23 Apr 2026 06:30:16 -0400 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-48a5adc141cso11521485e9.0 for ; Thu, 23 Apr 2026 03:30:16 -0700 (PDT) Received: from [192.168.10.48] ([151.49.85.67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-489fec8f7cbsm240212955e9.11.2026.04.23.03.30.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 03:30:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776940218; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3n3FxpdFX8QEwtruRPtTMxey3qCGIDC6XniieDlmvks=; b=iCkJJWZHzQob61GE5rMV9/unt8vQiTCtjEcvSixopUVlXuKWlhoEFOsFahAAXpO3MazcEP KBL/612/mSsYA+iVw+SchJ2iMVQppaDpWqIeh1imYJ3aXKCcdzpjvVAOEqt2pvRTJYW5pG xilHA2mCTn4w4/ur/9YnGH971TQweRA= X-MC-Unique: MonI686aNKKAVkVp6Akexw-1 X-Mimecast-MFC-AGG-ID: MonI686aNKKAVkVp6Akexw_1776940216 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776940215; x=1777545015; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3n3FxpdFX8QEwtruRPtTMxey3qCGIDC6XniieDlmvks=; b=Y4d//JbOmcRqbs0meMaGdXK66/bxRBIG097ZNx+9TOMuZos8bTuTxadBEa2zFI01yL eqFJjiPeZm4GbZSkmvAeQq4mo5qrJlNFjhqXxuHHq1/90gymr4JNrx8nKNmLgxYLCV3v SK188mW5yj4urQKblK3NziejpgGU/YxUcPtreF8rBvzDDll26313OEy8AAMs+EUz0o/i eWwQ/E71bv2EekR4YL3DEsP/cSLmYW38PUJqZH8oXIgkbZPS03wTtdW4GXdHHFmelFOE tGDZaIUS1G8hti5Nn1gPQnMKeqP/r8lpoQ7xXJvsMe0trrXWyqNQyHrXV8FM0Eok8wyA NaLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776940215; x=1777545015; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3n3FxpdFX8QEwtruRPtTMxey3qCGIDC6XniieDlmvks=; b=U430X7N+TIVLWt+zr9nERHi7j4nDsUfpUaJebsRB2TjC+wbDcrToV6fnM7TWTRMHR3 TMXgod58pKordk9lsqPKQtlf7zY66kVLadZVFZp4YRB3a9EPgW8Qhi0P7XvfHtokd1rO zKNgddwyY0Gu1IovysdbGh/n8O+g9u1jdZNmha2AUq6d5/ySm4uX9LlbQnjxCSoB9KIN nZ7RHkXmd6zg5DFEOVJq4zALyxBPbSQ5Mvm0vqszGdrGAfGLsfvY1eG0pUJkTA5VkhRC vBnZ2BDYPcNajoJKNpbKggFRMCVQ4cOcn9p49WHNZA1F4jpHE87HtQWki7AOm2/O8vwL YIRw== X-Gm-Message-State: AOJu0YwYVe7yHJUHxmhOiWQy2nFkXLu1jtlmHOuvbwq1TV1c679+oUpj oTK64g+0TYo04RxQk2wac0wSJaR321s60oVn3YBS5ybvPHtDHd6jCGNfSyqpFr07PtplxV6x3ys cSynBK049f/iBVil15mNdt6o4VA+PTk1EUQO1ZsTAl097aQRSTZrJXirLLe7z7nZO7LhsAYot/0 Auhz2AtRMTXHuWI/1EkmLoEakVetGPgpXKDnPruS3n X-Gm-Gg: AeBDiesGVlvlrqYtZikLvf5y3CuGXgn+R10iMMM0Ix9etosSo7Q+cOQNxJHFB6uP6cS GN9kz+Y98jILEoIAYrZmyihifoAslGOvETGtaS3MCo82UZ3g8zFvfWhIhb5wC4dlockanKY8uPi gsqRG6TcR40islAy9KgMF4KuRYmXFD20f+vl3HgnaFIhgm5xAh0MLalPJ12T5Gg3mAgoB2TACtt NXIzlehEsUmwFiD32YKOE/IaYKcTFl5lvp+ioSjAPn4vpYYrx0MSE6iCE11QfkttrrElw1PNXci AWkjYJbKzTAnVeNlenrId+BzRLezUSAwSAB5WLOzkTUKHDW/MHicn/yiVa/C0u4zHlWfR3FZeTy gWuED+PovUS+sxdLHMeavXw9eRX0RwygiPBNyRf9Jzz0R/vyfhcXH51n0lUvy3FzntqvfTBajaQ IbQV1ZixjXXqu7HNTdCURhZwrUBbfazIQ9/Co= X-Received: by 2002:a05:600c:8b6b:b0:485:3c2e:60d5 with SMTP id 5b1f17b1804b1-488fb8859ddmr348293255e9.2.1776940214993; Thu, 23 Apr 2026 03:30:14 -0700 (PDT) X-Received: by 2002:a05:600c:8b6b:b0:485:3c2e:60d5 with SMTP id 5b1f17b1804b1-488fb8859ddmr348292585e9.2.1776940214393; Thu, 23 Apr 2026 03:30:14 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Magnus Kulke , Mohamed Mediouni Subject: [PULL 18/25] target/i386/mshv: Fix segment regression in MMIO emu Date: Thu, 23 Apr 2026 12:29:15 +0200 Message-ID: <20260423102922.443639-19-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260423102922.443639-1-pbonzini@redhat.com> References: <20260423102922.443639-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1776940369032154100 Content-Type: text/plain; charset="utf-8" From: Magnus Kulke When the segmentation code has been reworked, there is now an unconditional call to emul_ops->read_segment_descriptor(). The MSHV impl was delegating this to x86_read_segement_descriptor(), which read from the GDT in guest memory. This fails for selector.idx =3D=3D 0 and when no GDT is set up (which is the case in real mode). In the fix we change the MSHV impl to fill segment descriptor from SegmentCache, that was populated from the hypervisor by mshv_load_regs() before instruction emulation. Fixes: 09442d98ab (target/i386: emulate: segmentation rework) Signed-off-by: Magnus Kulke Reviewed-by: Mohamed Mediouni Link: https://lore.kernel.org/r/20260410142652.367541-1-magnuskulke@linux.m= icrosoft.com Signed-off-by: Paolo Bonzini --- target/i386/mshv/mshv-cpu.c | 37 +++++++++++++++++++++++++++++++------ 1 file changed, 31 insertions(+), 6 deletions(-) diff --git a/target/i386/mshv/mshv-cpu.c b/target/i386/mshv/mshv-cpu.c index 2bc978deb25..4ed6e7548f6 100644 --- a/target/i386/mshv/mshv-cpu.c +++ b/target/i386/mshv/mshv-cpu.c @@ -1552,17 +1552,42 @@ static void read_segment_descriptor(CPUState *cpu, struct x86_segment_descriptor *desc, enum X86Seg seg_idx) { - bool ret; X86CPU *x86_cpu =3D X86_CPU(cpu); CPUX86State *env =3D &x86_cpu->env; SegmentCache *seg =3D &env->segs[seg_idx]; - x86_segment_selector sel =3D { .sel =3D seg->selector & 0xFFFF }; + uint32_t limit; =20 - ret =3D x86_read_segment_descriptor(cpu, desc, sel); - if (ret =3D=3D false) { - error_report("failed to read segment descriptor"); - abort(); + memset(desc, 0, sizeof(struct x86_segment_descriptor)); + + desc->type =3D (seg->flags & DESC_TYPE_MASK) >> DESC_TYPE_SHIFT; + desc->s =3D (seg->flags & DESC_S_MASK) >> DESC_S_SHIFT; + desc->dpl =3D (seg->flags & DESC_DPL_MASK) >> DESC_DPL_SHIFT; + desc->p =3D (seg->flags & DESC_P_MASK) >> DESC_P_SHIFT; + desc->avl =3D (seg->flags & DESC_AVL_MASK) >> DESC_AVL_SHIFT; + desc->l =3D (seg->flags & DESC_L_MASK) >> DESC_L_SHIFT; + desc->db =3D (seg->flags & DESC_B_MASK) >> DESC_B_SHIFT; + desc->g =3D (seg->flags & DESC_G_MASK) >> DESC_G_SHIFT; + + /* + * SegmentCache stores the hypervisor-provided value verbatim (populat= ed by + * mshv_load_regs). We need to convert it to format expected by the + * instruction emulator. We can have a limit value > 0xfffff with + * granularity of 0 (byte granularity), which is not representable + * in real x86_segment_descriptor. In this case we set granularity to 1 + * (4k granularity) and shift the limit accordingly. + * + * This quirk has been adopted from "whpx_segment_to_x86_description()" + */ + + if (!desc->g && seg->limit <=3D 0xfffff) { + limit =3D seg->limit; + } else { + limit =3D seg->limit >> 12; + desc->g =3D 1; } + + x86_set_segment_limit(desc, limit); + x86_set_segment_base(desc, seg->base); } =20 static const struct x86_emul_ops mshv_x86_emul_ops =3D { --=20 2.53.0 From nobody Sat May 30 20:11:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1776940268; cv=none; d=zohomail.com; s=zohoarc; b=O8Vh5UAM7xBM2FBvvg7uisWYdMYq8kTnSy6rMgc5xLN+BrRQGCAyfogL7QRr77dohh/dhGQvOsc/XM0P/eZgePbr0nI02WMpC3YjDBuDfO1beXQEaGw8DmlEtfQNWPC6IRbFbkochD+O+rpYwH/QdyCROg2TPDHKX50Xk+PWlXU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776940268; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=w1EAW752fwbHwayHLV05aNOwJKZc6TGPZUvpqkhrmX4=; b=CgGWKtsovV0B+TbV/ocIACxK2K3C0XEzWhd2M5WQeQOyiHFkQ/sSobJGkSyISsYFgXOciFXMQVtvVYcrsk/AdKN1wx1GhJvt8ntAUqkK4wH33aJEyv15whCYUzg9RrphDzZwCrIo9epHMCx7y/aUgPajrm5ogpl0Ld2Da0YQiGE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776940268558609.1968668457351; Thu, 23 Apr 2026 03:31:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wFrKo-00015L-Ub; Thu, 23 Apr 2026 06:31:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrKE-0000nD-FN for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:30:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrK9-0005n8-UB for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:30:25 -0400 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-279-GkVIaYBzOXi8KYvQDrCnfg-1; Thu, 23 Apr 2026 06:30:19 -0400 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4891f97aef0so23563655e9.2 for ; Thu, 23 Apr 2026 03:30:19 -0700 (PDT) Received: from [192.168.10.48] ([151.49.85.67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4891cc84a1bsm116263315e9.0.2026.04.23.03.30.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 03:30:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776940220; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w1EAW752fwbHwayHLV05aNOwJKZc6TGPZUvpqkhrmX4=; b=aPXp66xglUozw9NOOyDyl1J4bL+vIbMcv/sbPk/9mDHrfQcZCZ/1xVKV8mlkIB9zVO0j4R O1V0VuPzObnkwcZwhrTVd238FxGLRMJoGeJ20P4vyzrQgcLAl4Ge1Gz2bNgZJWWjdgltTo p65RiKOijkEadnevgpxZQmRbnn+iEt8= X-MC-Unique: GkVIaYBzOXi8KYvQDrCnfg-1 X-Mimecast-MFC-AGG-ID: GkVIaYBzOXi8KYvQDrCnfg_1776940218 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776940217; x=1777545017; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=w1EAW752fwbHwayHLV05aNOwJKZc6TGPZUvpqkhrmX4=; b=LfxFAbSmH9nb8G13nlKUokoSsFonmMjSP5zbA/Qrx9flAj3ol8J7vqVtQ82p4TVitm mRY2wyooU4AkqSkTu+4hgWBNf8sIn8dRC382R969g/vB/DpT6nCIi9VUKvcbq4oinT+n oygL8mlGy1f9JiZZUPfP/d3oJZtivwIvW/gYJ8/Lf0F3YAjnQFj88PtWMOOPKsKY/KrH PetOchojGFBK28jpx4RYaosXkfvOux6cSP3AMRWLhnZSUZDF3gaNeuR+Ksr/P9SGGNju vVrScUffG0hvA3lZSgOmLBbpVHclr6q5pVBTyF2YZkbjqNmF1OBcZxxI0X2VKHfCJ3A1 NU3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776940217; x=1777545017; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=w1EAW752fwbHwayHLV05aNOwJKZc6TGPZUvpqkhrmX4=; b=rhDqRzUuYKy84LD2gbbPmjopUmbbsealGP0+7l12lxsNAXMjsDwwa+X4cxNgW4oxR0 BvWVLhVh+ra1rpOqwC1alI4puaUp04YSCuxeMumVJjReOFjbxv2iat62Fvp88ejSQh0j XO+hiGvCZ4hP7ZEmkNxNXsfVLpW1S2dFT0JTuFepi2Vh3x+ZtbU8nc6XJSTXSohceMPI ehgwoA8hwOfNVLkOjiqa4MOdJVyCR6oePeGvwmKi7xXRFCbdtG5gvwb/rCepN9AqjUHr czj8jBHUcVpiyyfPX31ZLrYO0Aa3yk/BVYqZa3XzRspJ+/EQ6NiL6hhr6gIkYst5oRKS d/zQ== X-Gm-Message-State: AOJu0YzIu6M/tat/eVxfEwSv5SZA9a8tuC95fEsVOuOIYhy5zq4lqfDc auSbQl/mDVgXH39DNVCxpnrMFvLR9282x4T7YxYvx5m+KboczB7/Wm8epYxBdkozJqYZ6ILDavs WzCw/e2Dl4RwuJo8rjU6BGjtYBG/kMbCGXA3A7usgmYHN5gGj87s8bdXvv6W89oo00cHKr8+Maq ENPSnHqaFXDAxtJ1U3kxDgibRJwHKWs52uGOczzUIa X-Gm-Gg: AeBDieuJG8nSmmPBjHcjw133Alu9foDDKJiqk+nuiTZFmOOzVcUw6Fhu/Gw60F8qcki Q+p6xYUE2HLYcFixYCsMM+mGbTkFks/xmU4IrZ0s7zBQFDKSFWCejUtWqNm5xvvv207VposnU5U xejVOxqSmDDlcu5Ibs/1WGVjfdXPmQsrn9sgXgUSWGoV7agXRrHblx3YEwz0DZtiW63fl+keDw2 KWCFYgFt5SGq8IEyj+AC1B8vIQAqqCOyyLcknP9zgLfLUTLthshYyPXdDAti6VtlVDAIm/Q7YdF zxKpvnZrGc6Ykj7LHdHX14h8ZTMEqfF0XxHqetldgDgYfZgktertU2nBtfJhoMCQAJkgjzGXYwy vCL+UV2L8bnk+G3yGQlI2ixOtJFkh7Xr3ooW/5hS6GH3O2rMoMd38iQI2sxg/E6ZHogL+BLowvi VKrvtwlNwPDH+uez7imrPBN2C9Qg3CsEkrIBc= X-Received: by 2002:a05:600c:1587:b0:489:1f97:6b1d with SMTP id 5b1f17b1804b1-4891f976b4dmr124433595e9.28.1776940217138; Thu, 23 Apr 2026 03:30:17 -0700 (PDT) X-Received: by 2002:a05:600c:1587:b0:489:1f97:6b1d with SMTP id 5b1f17b1804b1-4891f976b4dmr124433115e9.28.1776940216495; Thu, 23 Apr 2026 03:30:16 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Aastha Rawat , Magnus Kulke Subject: [PULL 19/25] accel/mshv: fix ioeventfd deassignment to forward correct datamatch value Date: Thu, 23 Apr 2026 12:29:16 +0200 Message-ID: <20260423102922.443639-20-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260423102922.443639-1-pbonzini@redhat.com> References: <20260423102922.443639-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1776940271662154100 Content-Type: text/plain; charset="utf-8" From: Aastha Rawat unregister_ioevent() is not forwarding the datamatch (queue index) to the mshv driver, causing only the first VirtIO-MMIO queue to be deassigned correctly. Subsequent queues fail with `-ENOENT`, triggering a fatal abort(). This failure was discovered while booting arm64 EDK2 firmware with mshv accel. Signed-off-by: Aastha Rawat Reviewed-by: Magnus Kulke Link: https://lore.kernel.org/r/20260409-fix_ioevent-v1-1-053b810ae6fb@linu= x.microsoft.com Signed-off-by: Paolo Bonzini --- accel/mshv/mshv-all.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/accel/mshv/mshv-all.c b/accel/mshv/mshv-all.c index d4cc7f53715..e1a8d62f8d2 100644 --- a/accel/mshv/mshv-all.c +++ b/accel/mshv/mshv-all.c @@ -278,13 +278,22 @@ static int ioeventfd(int vm_fd, int event_fd, uint64_= t addr, Datamatch dm, return ioctl(vm_fd, MSHV_IOEVENTFD, &args); } =20 -static int unregister_ioevent(int vm_fd, int event_fd, uint64_t mmio_addr) +static int unregister_ioevent(int vm_fd, int event_fd, uint64_t mmio_addr, + uint64_t data, uint32_t len, bool data_match) { uint32_t flags =3D 0; Datamatch dm =3D {0}; =20 flags |=3D BIT(MSHV_IOEVENTFD_BIT_DEASSIGN); - dm.tag =3D DATAMATCH_NONE; + if (!data_match) { + dm.tag =3D DATAMATCH_NONE; + } else if (len =3D=3D sizeof(uint64_t)) { + dm.tag =3D DATAMATCH_U64; + dm.value.u64 =3D data; + } else { + dm.tag =3D DATAMATCH_U32; + dm.value.u32 =3D data; + } =20 return ioeventfd(vm_fd, event_fd, mmio_addr, dm, flags); } @@ -337,11 +346,12 @@ static void mem_ioeventfd_del(MemoryListener *listene= r, int fd =3D event_notifier_get_fd(e); int ret; uint64_t addr =3D section->offset_within_address_space; + uint64_t len =3D int128_get64(section->size); =20 trace_mshv_mem_ioeventfd_del(section->offset_within_address_space, int128_get64(section->size), data); =20 - ret =3D unregister_ioevent(mshv_state->vm, fd, addr); + ret =3D unregister_ioevent(mshv_state->vm, fd, addr, data, len, match_= data); if (ret < 0) { error_report("Failed to unregister ioeventfd: %s (%d)", strerror(-= ret), -ret); --=20 2.53.0 From nobody Sat May 30 20:11:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1776940354; cv=none; d=zohomail.com; s=zohoarc; b=m3lp0+09JT3c9oezxyjQuFeZJDfn1p2yGL1yA+zR1EnoUXI0PlFky5iC79MnEDqs08uqIkouHs+byKLRksIEjM0qlHkQ/13y6t/WhphiNEdF63NdOS+VVFqlO+PhMB774IYmynd1/I0RkpxLgpfigmXi4dD6D7C4UPhW6cQ45zg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776940354; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=IvSIdII6V+yTFOn7yhXDIrp7CakQLXmMya/y/bCpBPA=; b=QATaQE5GGYKjE+tkhqtjJ87u1jEDfC2UncgeoKZGFEAfbZAn2NXnto3HtFS4nihFiEfnaji7Oc41t/QEUe0cOx4KNMe+pjPRdvKm5sIfehX8RfL3eSf6U4JHv5YhvnEYKBBNdRROLpK/nzaLqgLu5JSTIdzV6VUnluYoSd8BCn4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776940354242715.4677298295026; Thu, 23 Apr 2026 03:32:34 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wFrKn-00013Z-L8; Thu, 23 Apr 2026 06:31:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrKF-0000nP-0C for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:30:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrKC-0005nX-M1 for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:30:26 -0400 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-347-AuHGB3TKNlquNde91OmEbA-1; Thu, 23 Apr 2026 06:30:21 -0400 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-4411a215f17so3386346f8f.1 for ; Thu, 23 Apr 2026 03:30:21 -0700 (PDT) Received: from [192.168.10.48] ([151.49.85.67]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4e4d112sm56741935f8f.29.2026.04.23.03.30.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 03:30:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776940222; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IvSIdII6V+yTFOn7yhXDIrp7CakQLXmMya/y/bCpBPA=; b=RPHpqyswnn4UzW0BgLBsuz8gE1ljalVShvvBakZge6pJIhCp3w6uRjc6nfARtHhrUWxaeg dV3+8IWrb/9bhJ5oFjGrIndWnIvAE53Z5yGJr9+SP/foxwSG6k3+RjepaO4k+dfpbdeojQ J258qpP9YDhgXUpXqZLKNYY8qg2cjr4= X-MC-Unique: AuHGB3TKNlquNde91OmEbA-1 X-Mimecast-MFC-AGG-ID: AuHGB3TKNlquNde91OmEbA_1776940220 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776940220; x=1777545020; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IvSIdII6V+yTFOn7yhXDIrp7CakQLXmMya/y/bCpBPA=; b=UbZigWtJ7vqCDISiMJfwnKrkeaSnbQJUyPkbHkmsQUaqIMctXzL7CA5GpEouV5gHxH amZV6YTlaHut97iwaz55cq3BKA1RlH0m8Pb3wg+t0TSmB8FY5m4Zjl4NzdXrda2/y7tH 9r4AT/t3v/sR3w6JZFi4j3WRYvUjA8kzMYC5VDiayBERCpEPNHn3iYsE80x8WP8tnFDt 41LvxtmYbyiAAUIW9b6z4clPevcVE5hEG0VQg6detT++7jHuu5dC3IIXqCHAHQy9sNkd /o83Ajbv2MXSiBhlv6MCNDx/dHHjjWolwver2wkn3SbzZD2P0VzZKliXYVzG/21H+YOc hgmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776940220; x=1777545020; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=IvSIdII6V+yTFOn7yhXDIrp7CakQLXmMya/y/bCpBPA=; b=sli11mhDneP6XD6/GWpqYmG0Gc/dku2PW5qBQuVZnXrlpGClR3EwfzgczXiZ4KPqkv cdp0JUrdwK3r/4cOg8cSpVGcccyX3IuRYGJ9znTGcmzQs2G1fruqKckSgq8noGRL6Y6L AwIiD2yojzYi1EJs7YmXULp8Af46O32Z5xRCThVg2Mvq+0HAKvTbzl0VTtby4bLb9xUR f3tHmxaZPFt9IlkpjfjgIs2MlPQvj7fV3yfujPc5zalu9Tge4/BL1SHvvttXjJLqoZnb qEdF+m3QvFXy/ciUO+8W7gBxvfFAa1NdJ5+Pq3VxrYAL7qewelZqI5SgpDiVhHb/cMUh oNsw== X-Gm-Message-State: AOJu0Yyj0oZ/wHWF+Q17sk3x1tq1mZp4DAsu2wbV3vYDh42A3DOe05MB 9mlCswDIhePup0bg4iJVIwIcKvya5nkjweuvqqa+59zrLc661LcK53r71L311e626rUmKd7+JnE rKki9R3V7rpGYsjz3pVWSCFGIEfw8NSukNsjqJt9VputBBqa9+c3vBCfAi6pTnl2kxR6bNYTqHp 6AbFLNv0tluwp6E5l+cuam1Sdt3cKTzv4Rk4ktB5Oi X-Gm-Gg: AeBDieulUsj/U34TatS88Cx4Mp78j2YrN35WyPflArZ+IonV6a9LChuSSvH14/p5PEf r1DAQaw6VK9tLH+MsmovQaEaVkOy+ksTYUvl3rA3+Wzqjyp6yR6zPrxp34G0XUMG4bg55pLfE3b GCuJvZvbstlVHg0V1lw7/NlVY8YXRmvwYO8XlXKnVMgd0AN+QIBtnfhmOJDz3zC+jasSy0zttbr yLmSE1uqoGxNxi7CZjqzDUCt+RFWOIMqxAZunBZ4GXT8ZuSUAyLnRL8ASG92nAmX/MSAJZEe+PH /Kj6MdBfLYY+NMllCKcUb62qMjNW4Sn0x8RrIm2dIpbdTtKA9TAnhD8GHTYuwjbkygZHN0YEKsn Fty92h9INT7RMb2z9T7iX7kHeDlfJUmEEMaJhMy/LTx/hn9BUCd3WQW090fL8qD9uRNpBT9WIdj QCIEF4dUyQIoQ3Jq5WE5vy3StfobF56msSLF4= X-Received: by 2002:a05:6000:1889:b0:43d:7b7b:ab76 with SMTP id ffacd0b85a97d-43fe3dc54ddmr40751332f8f.10.1776940219651; Thu, 23 Apr 2026 03:30:19 -0700 (PDT) X-Received: by 2002:a05:6000:1889:b0:43d:7b7b:ab76 with SMTP id ffacd0b85a97d-43fe3dc54ddmr40751259f8f.10.1776940219051; Thu, 23 Apr 2026 03:30:19 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Aastha Rawat , Magnus Kulke Subject: [PULL 20/25] accel/mshv: return correct errno value from ioeventfd failure Date: Thu, 23 Apr 2026 12:29:17 +0200 Message-ID: <20260423102922.443639-21-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260423102922.443639-1-pbonzini@redhat.com> References: <20260423102922.443639-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1776940354567158500 Content-Type: text/plain; charset="utf-8" From: Aastha Rawat Returning the raw ioctl return value results in misleading error message. Ensure that actual failure reason is propagated by returning -errno for ioeventfd failure. Signed-off-by: Aastha Rawat Reviewed-by: Magnus Kulke Link: https://lore.kernel.org/r/20260409-fix_ioevent-v1-2-053b810ae6fb@linu= x.microsoft.com Signed-off-by: Paolo Bonzini --- accel/mshv/mshv-all.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/accel/mshv/mshv-all.c b/accel/mshv/mshv-all.c index e1a8d62f8d2..58af674bd99 100644 --- a/accel/mshv/mshv-all.c +++ b/accel/mshv/mshv-all.c @@ -275,7 +275,12 @@ static int ioeventfd(int vm_fd, int event_fd, uint64_t= addr, Datamatch dm, } } =20 - return ioctl(vm_fd, MSHV_IOEVENTFD, &args); + int ret =3D ioctl(vm_fd, MSHV_IOEVENTFD, &args); + if (ret < 0) { + return -errno; + } + + return ret; } =20 static int unregister_ioevent(int vm_fd, int event_fd, uint64_t mmio_addr, --=20 2.53.0 From nobody Sat May 30 20:11:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1776940386; cv=none; d=zohomail.com; s=zohoarc; b=Kc3AcKDeSomIMluL0ySRS72eA1V/8vAEUbQsA8ZLEa3WIWeH7ALp8T5SGaMdk6kujDJxbppws9XPu9yzpjfiIEIncYFBLYhTDExLMifb/se1SohkBF6sXp3otliBFBdFG4BZlNPcv64fajhUJ3EusCm8M4nwSmnO+8WubW3pMLM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776940386; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=rof6tYmA3yNSs60ICHlduhezXCmfZD19VtF8nxPlTLg=; b=KrH3j7+wjQjWOPEnKJhssw4VG1E2hgbaXs4XOCL/eQdMvV1UjjN+Lyftx8iCyNI3TGRmoSvqraZibYm3SfZOoYWrYJkcb6DnhiZ8wbFhkPeg5len2Ma7xbLcJM0xh7pB24gBvHUwPIw89CM2J7KcGEUOBM98UF66uxuLaclBO1o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776940386763213.8222444898455; Thu, 23 Apr 2026 03:33:06 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wFrKm-00012x-PL; Thu, 23 Apr 2026 06:31:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrKF-0000nQ-Vd for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:30:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrKE-0005oG-Ak for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:30:27 -0400 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-519-vqH1qa2_OweYdi6H6atJ_Q-1; Thu, 23 Apr 2026 06:30:24 -0400 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-4362197d1easo5041791f8f.2 for ; Thu, 23 Apr 2026 03:30:24 -0700 (PDT) Received: from [192.168.10.48] ([151.49.85.67]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4e3a174sm57683843f8f.18.2026.04.23.03.30.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 03:30:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776940225; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rof6tYmA3yNSs60ICHlduhezXCmfZD19VtF8nxPlTLg=; b=E2xPyUv7YaTbTB1rFKl7yssTxlDJCFXN7Ye1rTuIAc5aTfvatHfhh/yKwaXV0+1zILxqOg 6vi1oqr0XocRFE21e6mlNuIv1nh3ylbPteaadurQ9L7RX/LXirBMHZHI297YWFKgYqmS2J LUSLlSL1DZMWex03E4a34LBBjw5thD4= X-MC-Unique: vqH1qa2_OweYdi6H6atJ_Q-1 X-Mimecast-MFC-AGG-ID: vqH1qa2_OweYdi6H6atJ_Q_1776940223 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776940222; x=1777545022; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rof6tYmA3yNSs60ICHlduhezXCmfZD19VtF8nxPlTLg=; b=I+zEV4OWOj7OBKqhkEWpT8ZKqzEBa7MEQ0a1KAD/CE0jO9of8diJyfY+qCckjHjTQs g456YiJblAw4CWNK16eGDpocFRGfSY6litDNpgJBBe3DPpWnV/qHhiEZoK7Y/3ND9Ume mGNFj/Njuu/u48JdLk9dyAtafQmU9VPlYNu66DPhFydNnPKxHOKzaxZV6uhtYcPvihDt mhhzgcGrWvUpD7STdt7eTivgNdWcStGvlh7mu3bQB8yfyM0Pqp89NDcAtA2qwS8JC3+X 26SJ8UFU4DnS46mSabZRfM2lwcENbuoyzQwY+K+jqFQPtP0fJEcSh+6H94F8nrvbUswy /EOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776940222; x=1777545022; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rof6tYmA3yNSs60ICHlduhezXCmfZD19VtF8nxPlTLg=; b=RnLkzZsE5LuE3jtCfB9N/HMK+lQO6+q6OiK9IGruleeZSZHsXiM51tvurUHBsghJqQ aJhrRyKT8gQ0Nb23oBlWu6WCkl4rpXJKp4bQf++F8loHNYUxqVKiScIx7fp+WDHJpH0i 2WsuJE6aNfl3lbftIyds4xQkYvbiq8vPXDKzsP25rVq8DTjfFX94viiI0E5s1oCjPeAo TfFWupHuvss2bZzvGg0pQQ2cJEKYVSU2nZZH50B+wUhTEQtikt2+D3NLhV9c1hqAR6NZ ZSA93aMqC/zkuY3+j9PMI5vtn/79B22O7C1wPXK+LFXtTdNuVVKxb004AMyR98N95Omi 1Dgw== X-Gm-Message-State: AOJu0Yxxef8xFTWPnBL5esNTaCleyAjYzk82hPvHTReSfNuTKco41Oz3 mQ8ZlaPLGagJKqhp7P0dqo2MpnP/LYOhbmAncDegaLMm3O3OP0p1ndDO4KSzEsXUAEyop0TtJnt 2ds7XwiFlgrE1ZwXLbFbJqhTq9Id+eH9vwyqMf+9Qil5sRG1C2Hf5RVDHNz1qBSB2xRyyxftvL3 BVojRr6tUNsz2efPMpYfqTqBwVOOCdGROgkLMM57PA X-Gm-Gg: AeBDieupXuf0maasowoNZUrBk2JB8+ZzTCHJAchtHVFBcuF7FH3h2B4Y+wmqwiRvO3l +jdT4gtFZx2VXSGDDbVnFXPkdVJH7/AJLoEwWOMdrFw3EA8BN6jeP8SFWOLxhPUuhjixk/g4UOQ ww/g04YWnXi8ep5TYeUF7XuINRRuhO2N2U4KFtIu07fIKPweKBpRPHtk8egvZD/XgFvhzIE1xxr 2jBnrOsyUhjTyM6x9RDhevTwatYnguPMcPylZj9xnqRxsK21se5cpYvjgkEpdJJuctfvsF8+/Zt mIqqA1Nl/hjNA5RHSxtHC/ZRfyYiverhI8MUdEcwapgsOxbm64xApwIfZWvNncwhgkdThxiFC5F K2vIOoAAwhr4GJhM9SPesWl6D4oBLVeqWj7HGy7jmtt0ypmLDNiDaklwpv2hfmbrN6dW5KksJKp FcyGPeCCqbema2IP9zHh86278CVAj6okrxRDo= X-Received: by 2002:a05:6000:310d:b0:441:202e:3d2d with SMTP id ffacd0b85a97d-441202e3f4bmr17381114f8f.19.1776940222099; Thu, 23 Apr 2026 03:30:22 -0700 (PDT) X-Received: by 2002:a05:6000:310d:b0:441:202e:3d2d with SMTP id ffacd0b85a97d-441202e3f4bmr17381045f8f.19.1776940221494; Thu, 23 Apr 2026 03:30:21 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, Richard Henderson Subject: [PULL 21/25] target/i386/tcg: fix decoding of MOVBE and CRC32 in 16-bit mode Date: Thu, 23 Apr 2026 12:29:18 +0200 Message-ID: <20260423102922.443639-22-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260423102922.443639-1-pbonzini@redhat.com> References: <20260423102922.443639-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1776940389383154100 Content-Type: text/plain; charset="utf-8" Table A-4 of the SDM shows F0 F1 Reviewed-by: Richard Henderson -------------------------------------------------------- NP MOVBE Gy,My MOVBE My,Gy 66 MOVBE Gw,Mw MOVBW Mw,Gw F2 CRC32 Gd,Eb CRC32 Gd,Ey 66+F2 CRC32 Gd,Eb CRC32 Gd,Ew However, this is incorrect. Both MOVBE and (for 0xF1) CRC32 take Gv, Ev or Mv operands. In 16-bit mode therefore the operand is of 16-bit size without prefix and 32-bit mode with 0x66 (the data size override). For example, with NASM you get: bits 16 67 0F 38 F0 02 movbe ax, [edx] 66 67 0F 38 F0 02 movbe eax, [edx] 67 F2 0F 38 F1 02 crc32 ax, word [edx] 66 67 F2 0F 38 F1 02 crc32 eax, dword [edx] versus bits 32 66 0F 38 F0 02 movbe ax, [edx] 0F 38 F0 02 movbe eax, [edx] 66 F2 0F 38 F1 02 crc32 eax, word [edx] F2 0F 38 F1 02 crc32 eax, dword [edx] The instruction is listed correctly in the APX documentation as "SCALABLE" (which means it has v-size operands). Cc: qemu-stable@nongnu.org Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- target/i386/tcg/decode-new.c.inc | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/target/i386/tcg/decode-new.c.inc b/target/i386/tcg/decode-new.= c.inc index bc105aab9ea..c8b5bd6ad26 100644 --- a/target/i386/tcg/decode-new.c.inc +++ b/target/i386/tcg/decode-new.c.inc @@ -875,19 +875,23 @@ static const X86OpEntry opcodes_0F38_00toEF[240] =3D { =20 /* five rows for no prefix, 66, F3, F2, 66+F2 */ static const X86OpEntry opcodes_0F38_F0toFF[16][5] =3D { + /* + * MOVBE and CRC32 are incorrectly listed as always doing 32-bit opera= tion + * without prefix and 16-bit operation with 0x66. + */ [0] =3D { - X86_OP_ENTRYwr(MOVBE, G,y, M,y, cpuid(MOVBE)), - X86_OP_ENTRYwr(MOVBE, G,w, M,w, cpuid(MOVBE)), + X86_OP_ENTRYwr(MOVBE, G,v, M,v, cpuid(MOVBE)), + X86_OP_ENTRYwr(MOVBE, G,v, M,v, cpuid(MOVBE)), {}, X86_OP_ENTRY2(CRC32, G,d, E,b, cpuid(SSE42)), X86_OP_ENTRY2(CRC32, G,d, E,b, cpuid(SSE42)), }, [1] =3D { - X86_OP_ENTRYwr(MOVBE, M,y, G,y, cpuid(MOVBE)), - X86_OP_ENTRYwr(MOVBE, M,w, G,w, cpuid(MOVBE)), + X86_OP_ENTRYwr(MOVBE, M,v, G,v, cpuid(MOVBE)), + X86_OP_ENTRYwr(MOVBE, M,v, G,v, cpuid(MOVBE)), {}, - X86_OP_ENTRY2(CRC32, G,d, E,y, cpuid(SSE42)), - X86_OP_ENTRY2(CRC32, G,d, E,w, cpuid(SSE42)), + X86_OP_ENTRY2(CRC32, G,d, E,v, cpuid(SSE42)), + X86_OP_ENTRY2(CRC32, G,d, E,v, cpuid(SSE42)), }, [2] =3D { X86_OP_ENTRY3(ANDN, G,y, B,y, E,y, vex13 cpuid(BMI1)), --=20 2.53.0 From nobody Sat May 30 20:11:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1776940331; cv=none; d=zohomail.com; s=zohoarc; b=g6BT9rHIev69IO+6Qa8bOXs+DvZMCjX8qtOHCDrv7pvyj0t8jToQDa7z1w9Yne94/Krn7JbWfOgpKjlRStqlqxmILYPCAAFi9WA4BZPHWu4+WKkuaGgbT8s8mWpHxNc6kw+dsdjeZkPTvlaWjo9hHv/qdHaqwzMADpJ2PMsEsuQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776940331; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ERyMgSdbJE1FXknEB9Czp6yuKXaax6AJGVhcoUdtg0o=; b=Eq0AsLNcIiwmv32MozGBBqoZIvypZiL4/Isqs5563NlTq1bjJlKXDVAFvpu9DNMp3sIXg5/jv7Akb/N6uPKmENBC5Akd+zcn5vDMebQY6oVp69xTRfmwdOoaXF8AqqzGGwm54FXiElK5woQdjxqqlGIPVYaHMyurrhVLcoAF5yY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776940331890329.1191894012102; Thu, 23 Apr 2026 03:32:11 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wFrKr-000177-Rv; Thu, 23 Apr 2026 06:31:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrKn-00013q-S7 for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:31:01 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrKj-00067l-1g for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:31:01 -0400 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-91-1lzhnvH7MYyhrEl_X4ErsQ-1; Thu, 23 Apr 2026 06:30:54 -0400 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-488bd1ee9e7so53870425e9.1 for ; Thu, 23 Apr 2026 03:30:54 -0700 (PDT) Received: from [192.168.10.48] ([151.49.85.67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4891ffd2030sm83443695e9.20.2026.04.23.03.30.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 03:30:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776940256; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ERyMgSdbJE1FXknEB9Czp6yuKXaax6AJGVhcoUdtg0o=; b=bdR7gY4aZOGreSeFOgN3jjhgXncX3QhJBLjaiVROehayffNGJ9WN/dbnqk3beZpWCwRPnX 5EoAX/Qtl39gpgAuoCsvuFiDl2OyS2Vp7AVXe5kmUlXnN/doSc3rBzUeXq8y0TmBRB73no f3x0sFhDYvNkqLCoUIdCg/yfVRhUBhs= X-MC-Unique: 1lzhnvH7MYyhrEl_X4ErsQ-1 X-Mimecast-MFC-AGG-ID: 1lzhnvH7MYyhrEl_X4ErsQ_1776940253 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776940252; x=1777545052; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ERyMgSdbJE1FXknEB9Czp6yuKXaax6AJGVhcoUdtg0o=; b=pv0FabqwL0C8n6cF9bINB3L7kGcWsUUlLWNRfqHybcNRBokEo6cNBQY5MbUnGCW/5N eCXfAW4e7RAiWeghux7QLp309yQi1hJ6vW5vr6Y0y5ekWZSoJim2Cx2PQFUijnTJleuy jn+gcYAPr60IttjdPnxhNF4F8DgKDVT2QghfP5UVq5Is09vGc8TRZi0FVgRlkLPRSTf5 4HqTXHrTP/BwSHlV8aZM7M4wzEUtLBTcNYwMeZ8G5vx+9BI8adaC4fZhnEee/zNypTNv CQk7r/EklkXnGUUX/8MqH+Mqx+q7YcLNYu8fKVjnxmxy3mDbyg01vmKK1/sZN0WtGJOZ rYqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776940252; x=1777545052; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ERyMgSdbJE1FXknEB9Czp6yuKXaax6AJGVhcoUdtg0o=; b=J7z+LPCdqP2vt1L+z9e3R7NZa1VdzUC8rzlpz/iZkw+E0nvm2hnRjhw3WZKppl1CiI gOCON4koNP+9mdySQ4qyhY8gX2MtuHoqhiMxlnzdC3A7KirHsFjZ2CQ/1rB8TTVmguQS NX4lVeeEdQRwxlaemsnCDZp70YrWVNRpaKEBW7HHNlFQk5mv8qsVhInWnEe0odBMjDB3 gx42P7wXmvUdbsvtauBK/gPuZIxCb0oOFz09R3MDewyl1yyPfWoc56iVJI0/kqbIH/ez jnHCkMzzU1klLg+1aJCOz0abC4dkjK0MAJdgNjQ6Pp1FzqZqQrayM/SK3/nqZjMJjJJG f8oQ== X-Gm-Message-State: AOJu0YyvivorjZF2vuBm0vvxXpfTgQ4MQHdu6PVoDE6bgk3ojdke9uNb L7TzqOpOnQUo9JpC84uQ6gsMC/AEEWHdjIwyfrfw2VdC/c8o19rCFnXbXrda1F9wXr0btaJiF4c xdkeIFuquzYuyfF0C1XH8K7ype5tdptBdTUV9GUFiPWUQbFuG7GQNl+ez4u/hebLnhrXT2ypNnI +GJbzejQVnjYhdkf5UeVpOZXGpEjFFDtVQgY7oDbIZ X-Gm-Gg: AeBDievhNXgYV/M6/uHOsV5ryHROX325FqByRgIqT5oIFo3ztLFYpfHDM9ChgWdDpc0 ocmxu0Oo8uz1/4MDdE/0YxDiEdBTE6NptWJxIF4ZZ3I1XmpBTGUSnXVMwMcyU2PsL3QdoO9TIK9 SjmN4xf4wYODSxeST0bagajS/N6Mo3mv/mqAnU+Zh1We0pvL2P+nSmRjljG7BhtUUsI4yqgXWzh HyS03OibmrOc3rsaz9km/LBIJRen9ShTxuvznxLkYrETiPoKYc7LAZAxavSvt+XCi6+esE/TWPC LxjAu3vYPYjMUkOz2M/YtFF/r3Xh7CYTPg/etILeZLAoal+dH0CF2J4EZhAtU84TaTyEHgfU/Uq 5VphJVDuhSH1gkT7aYUcbcVeKDx7uGhXKXUn8T1HWGE9MKFGjfpvx6+wGvk8SDp1QzoqYtA7ggf qiUc8SsChvk5fIOQJRf8VytgtHCDNhshpnN/M= X-Received: by 2002:a05:600c:530f:b0:48a:56de:d640 with SMTP id 5b1f17b1804b1-48a56dedc17mr156046625e9.16.1776940252411; Thu, 23 Apr 2026 03:30:52 -0700 (PDT) X-Received: by 2002:a05:600c:530f:b0:48a:56de:d640 with SMTP id 5b1f17b1804b1-48a56dedc17mr156046065e9.16.1776940251780; Thu, 23 Apr 2026 03:30:51 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Kostiantyn Kostiuk Subject: [PULL 22/25] thread-win32: replace CRITICAL_SECTION with SRWLOCK Date: Thu, 23 Apr 2026 12:29:19 +0200 Message-ID: <20260423102922.443639-23-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260423102922.443639-1-pbonzini@redhat.com> References: <20260423102922.443639-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1776940332481158500 Content-Type: text/plain; charset="utf-8" SRWLOCK is a much cheaper primitive than CRITICAL_SECTION, which basically exists only as a legacy API. The SRWLOCK is a single word in memory and it is cheaper to just initialize it always. Reviewed-by: Kostiantyn Kostiuk Signed-off-by: Paolo Bonzini --- util/qemu-thread-win32.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/util/qemu-thread-win32.c b/util/qemu-thread-win32.c index 272afc33856..3037732a6fe 100644 --- a/util/qemu-thread-win32.c +++ b/util/qemu-thread-win32.c @@ -242,7 +242,7 @@ struct QemuThreadData { /* Only used for joinable threads. */ bool exited; void *ret; - CRITICAL_SECTION cs; + SRWLOCK lock; }; =20 static bool atexit_registered; @@ -295,9 +295,9 @@ void qemu_thread_exit(void *arg) notifier_list_notify(&data->exit, NULL); if (data->mode =3D=3D QEMU_THREAD_JOINABLE) { data->ret =3D arg; - EnterCriticalSection(&data->cs); + AcquireSRWLockExclusive(&data->lock); data->exited =3D true; - LeaveCriticalSection(&data->cs); + ReleaseSRWLockExclusive(&data->lock); } else { g_free(data); } @@ -328,7 +328,6 @@ void *qemu_thread_join(QemuThread *thread) CloseHandle(handle); } ret =3D data->ret; - DeleteCriticalSection(&data->cs); g_free(data); return ret; } @@ -357,6 +356,7 @@ void qemu_thread_create(QemuThread *thread, const char = *name, struct QemuThreadData *data; =20 data =3D g_malloc(sizeof *data); + InitializeSRWLock(&data->lock); data->start_routine =3D start_routine; data->arg =3D arg; data->mode =3D mode; @@ -364,10 +364,6 @@ void qemu_thread_create(QemuThread *thread, const char= *name, data->name =3D g_strdup(name); notifier_list_init(&data->exit); =20 - if (data->mode !=3D QEMU_THREAD_DETACHED) { - InitializeCriticalSection(&data->cs); - } - hThread =3D (HANDLE) _beginthreadex(NULL, 0, win32_start_routine, data, 0, &thread->tid); if (!hThread) { @@ -406,14 +402,14 @@ HANDLE qemu_thread_get_handle(QemuThread *thread) return NULL; } =20 - EnterCriticalSection(&data->cs); + AcquireSRWLockExclusive(&data->lock); if (!data->exited) { handle =3D OpenThread(SYNCHRONIZE | THREAD_SUSPEND_RESUME | THREAD_SET_CONTEXT, FALSE, thread->tid); } else { handle =3D NULL; } - LeaveCriticalSection(&data->cs); + ReleaseSRWLockExclusive(&data->lock); return handle; } =20 --=20 2.53.0 From nobody Sat May 30 20:11:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1776940333; cv=none; d=zohomail.com; s=zohoarc; b=LrmwZ5bTI/n6kUhDkBnwjW10EoygySUzOq12mJ9s3c3goVg8dW122kdEfF/ciGPCuYsxnr/NOVQiMdufDikMbRcakhNwHOmdKh4CccQw1bYGUkF1pZAYGbRwixU00Cjq65LHLw9ffeL15aXdvpVgIyJFb87XC3O/jrm2u0AM/fI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776940333; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1ZgCBxZaWUy47pwY1lJ5j+kzE+lzpZxqs4AG0JiavTI=; b=jRXHOtAVOlkEXo8lwHq3+p28f0gqOIe7/NcfH3MkmztFLQl3Zrf4Rv7st+zBdWvCkQzLQ07WuiJ/QB5TVxcmda91Kx+yc/0GnHUQB6qCkKZek5CVnqmfJ/BsAeZD4H66BBHFP/UMSmimVU2VntM0VGk8LoS2yZASgOExOCconWs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776940333065607.6369259198548; Thu, 23 Apr 2026 03:32:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wFrLN-0001zm-Lq; Thu, 23 Apr 2026 06:31:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrKp-000169-Oh for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:31:03 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrKl-00068Z-In for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:31:03 -0400 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-554-lBSUd1U1PReKG5DLf7p1gw-1; Thu, 23 Apr 2026 06:30:57 -0400 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-488d2cd2674so50152585e9.0 for ; Thu, 23 Apr 2026 03:30:57 -0700 (PDT) Received: from [192.168.10.48] ([151.49.85.67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a5d27d6casm21943005e9.27.2026.04.23.03.30.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 03:30:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776940259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1ZgCBxZaWUy47pwY1lJ5j+kzE+lzpZxqs4AG0JiavTI=; b=RVn02mFh1rAtcS83Ocol1hLF4nai8QlJapCsJMp3++PYbDcESBUMn8nz1ec/OrEEH+OALs E2FEFi7HN6kkOh37JS5z//fUKOYNLOQEMq25Q86yudYlOHbE8/q6vuoVNFTRNXJGRgb4DQ VrS4fgf4fGkrHWo73bQspdkXWunRXIo= X-MC-Unique: lBSUd1U1PReKG5DLf7p1gw-1 X-Mimecast-MFC-AGG-ID: lBSUd1U1PReKG5DLf7p1gw_1776940256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776940255; x=1777545055; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1ZgCBxZaWUy47pwY1lJ5j+kzE+lzpZxqs4AG0JiavTI=; b=bp1S49Ni2skfU3I9C9zQvHliDhe3eoILdY6W6aMUeY7tUVyggCNxe3frocrJTvWhC/ 2hxPV9/KTMhDlFfsEp5uwDBWVebseZepmeogRo59bhyI2tagJaLJNdsjPByap8ZN/CSo ZY6nQQ/KrmKtGjQatzzQqjQDwB/rBEfbQzupElWX3Ue88q4i9HVgG65YzLS2YdqkDoKT MEg8ViYspggjB1R9RVlErFwI1syZVSIXp/XqBC7jST27CaMaFbWlkxUrARCLNnFSzvxg 6nuj9S8oLxNL/PkdateaMVnMLdbGb/oEOKRw7rrrZNWJ6KlP/Q5lNty65KCppiab2Mg6 ebiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776940255; x=1777545055; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1ZgCBxZaWUy47pwY1lJ5j+kzE+lzpZxqs4AG0JiavTI=; b=gPNyLDZAh3xgrwWbX3BOewaocwyiftEW7d58txB48KTqPyhIGpuJtXHLO6J/JJsw0c UmyDFTq6hMcIfKXkx8ARwCcfYD0mdWvy0j3/WM/PVMtY+EkNQANKGf/uMx0FqyrN9ZoU lmGsoy58FSE/SrrezKMP5TZS0ZfiIWCXJz+IHmm3TfD7assUMmtVrXGdsD2RncZbIw7U IW5rhX+5apKqzgxD+E0U4iXVWO3MgF+Cl25XrSnWeD2+QIKd5G11fumfcT2LhLwj/E64 N/mV8WF8Y/iiwPdHT5PZwC/W3mQTq5+eXHu+F7CVQ6phFzjAsa1n2nDKr/JCRi7z40H3 1Muw== X-Gm-Message-State: AOJu0YwG9w1ZGDLSmrFmixg/sAsO/gj5bFekM0XqQqBybElwG/9SmFrt O42/kSzliyow0bH3hWhsFLFHezksb8MZEvCtKzJxFqza+xGw+ImdS301yA+PLjaXsttvUGJLeIy hBk5o69iQQQdqcjH3besgCnihKMB4uhSC9BgLEzLxCdvvc83DTtM6OD9AV3SBMls9INfnkMPFWu zJ06U7DGiKTGMn6XpCaWUMv/hozD85TFVT2/nG2V4Y X-Gm-Gg: AeBDievVYGrd6YRVA+d0PTjSZHOsGB8xMvN5mfTgUaBTQsZKKCjLKkDJM5h1+KWQA7g exwlS02WQKjOSTKwAAdIc7oGqwB9ucjpcIv8zV0TRxg/nSkzh0MnzwItkQNEU2/23US+a9wJgEj qZRE640Ef5FR4G8yMt2+WAxCphp/0/5WgUgD5owEd5Ukryeyyu44A8SjB/E1tPAol0Bp2iJ/Ukg 28wjyIMt9jJ5zKXaHTB1Nai8nJZk0yG9WeLJe/IXX4PAQCYPo1dBqSuCyDikCVHORDu7FKk+30i CYoqQROw0pW1DuTXeB3pV2iRsZXtDqseiXvAv7YPqG6vVd/UTJFtCpFCY4bf7dEnlshBq65VtTN uSuSDlycSW2iHIbL8ponqioMRf4EKVSA94f7S1Ar1XBEN2TY47d0jRPOMtMTk3qKvabwZXkFjT3 arYOEZT49IOwrQ+KCQ5PUBIKmDZjY5Zpc2FHM= X-Received: by 2002:a05:600d:8408:b0:485:46fd:7887 with SMTP id 5b1f17b1804b1-488fb74c61fmr293882325e9.13.1776940255335; Thu, 23 Apr 2026 03:30:55 -0700 (PDT) X-Received: by 2002:a05:600d:8408:b0:485:46fd:7887 with SMTP id 5b1f17b1804b1-488fb74c61fmr293881945e9.13.1776940254767; Thu, 23 Apr 2026 03:30:54 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Stepan Popov , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PULL 23/25] meson: add missing semicolon in pthread_condattr_setclock test Date: Thu, 23 Apr 2026 12:29:20 +0200 Message-ID: <20260423102922.443639-24-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260423102922.443639-1-pbonzini@redhat.com> References: <20260423102922.443639-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1776940334456154100 From: Stepan Popov The test code was missing a semicolon after the pthread_condattr_t variable declaration. Signed-off-by: Stepan Popov Reviewed-by: Alex Benn=C3=A9e Fixes: 657ac98b58c ("thread-posix: use monotonic clock for QemuCond and Qem= uSemaphore", 2022-02-22) Reviewed-by: Marc-Andr=C3=A9 Lureau Link: https://lore.kernel.org/r/20260330131406.87080-1-Stepan.Popov@kaspers= ky.com Signed-off-by: Paolo Bonzini --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index a962b181e64..096303f021c 100644 --- a/meson.build +++ b/meson.build @@ -2890,7 +2890,7 @@ config_host_data.set('CONFIG_PTHREAD_CONDATTR_SETCLOC= K', cc.links(osdep_prefix + =20 int main(void) { - pthread_condattr_t attr + pthread_condattr_t attr; pthread_condattr_init(&attr); pthread_condattr_setclock(&attr, CLOCK_MONOTONIC); return 0; --=20 2.53.0 From nobody Sat May 30 20:11:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1776940325; cv=none; d=zohomail.com; s=zohoarc; b=aN0caFUgtPz3JtVb/t/FV+i/gg8ixLuLJFBnOT4q/R3pcNjMRQQCbAJnIsyr2YKeVQPza8FW0lj+n3gfRSjJvOka9lZrEa3lf+vY1FtTSjf3k1Y//I0luwpSzlgX1bbYf1nJgzz6i3tLkUdW2s6Zi2wCWajxzvon7nE83i6Z8SI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776940325; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=W4XmyksHBVIs3iLa2by4RHAdXjQPeU40gX9yVyb+E/Q=; b=lxs64pOg6FWm0CmbSd4EGWX+uWjO8N+eqVDT+CTXwgQdcQX/1aZjLL7txv5EMYvgGVwvfB19HOrBXXF0pgwpqkX0iMuLjRJgcvrVlnX2JNrqRLJutZMdqxduTJdErx/uPHyc767MVo/hdoxRrHaUqAbKibvnBmMIpyBmtcNtNfE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776940325824754.955431154278; Thu, 23 Apr 2026 03:32:05 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wFrLL-0001x1-1T; Thu, 23 Apr 2026 06:31:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrKs-00017L-Ke for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:31:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrKn-00069Q-RA for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:31:06 -0400 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-570-liG5WVPDPNqDH3rKyJG6qg-1; Thu, 23 Apr 2026 06:31:00 -0400 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-488d8deb75fso53070565e9.3 for ; Thu, 23 Apr 2026 03:30:59 -0700 (PDT) Received: from [192.168.10.48] ([151.49.85.67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4891cca5743sm301552685e9.9.2026.04.23.03.30.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 03:30:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776940261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W4XmyksHBVIs3iLa2by4RHAdXjQPeU40gX9yVyb+E/Q=; b=PQpmXOC4nm5JZ/M2l9V+L8+sAMKycN028WXZA0XBkaLSVmCuUhdQaR7SODlJCpr42xwRAo HYHUSgxCfqzuiLcTGJzzVzXcHaFDVRRmpXYrBa7pMwslwWPMixiRlNiz1AbGTRrSUoHSqC uoHd7k80QUnc89GElmJ37T/3r0F6ejQ= X-MC-Unique: liG5WVPDPNqDH3rKyJG6qg-1 X-Mimecast-MFC-AGG-ID: liG5WVPDPNqDH3rKyJG6qg_1776940259 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776940258; x=1777545058; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=W4XmyksHBVIs3iLa2by4RHAdXjQPeU40gX9yVyb+E/Q=; b=LmUCWITuOFvlOSAZWC3MkUmn1LVqcNpeXHxAQkz3+d+/K70m1d/nOKz1Bkz60/YoNk BiyuzSiUj4k4bSVm6EhmmTyxiJc7Vix3e4QetglCvJWiAxMitlDmQGm6G9O0fPcVvpMQ LO3fwR18/nSTHIl+wjglCLM35kGysvAZPAsOK2nnD11qeaLDCYw+tX5HK45UoI+6J2co VO+GBOKCcTamqOe58VcFwN9FCQbTKnes8qqwhHJPMArci3msXvQ7jOfj/14DDXUw5FwK AlCOf5ViNVp5eNJNIRRxMaT4l7CCYEKJDCkh+/pnVzP4ZXotacQH5uIlDIyiGaapLpXQ 2cIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776940258; x=1777545058; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=W4XmyksHBVIs3iLa2by4RHAdXjQPeU40gX9yVyb+E/Q=; b=d4OTzVpfeOhSpNNXbcuUdc2FQ9YVFI/zV9ZyQg0JBLRpSLHIjc4bYed5oNnAlyee8u MghV+mmWeDzwDIPQPjfXMTsHgxviOWr7oE2MafrOCFXJax86VBGTRTD6T/db8Dz3U6HQ ybnygpxM94bw05At/7OuyFmqk9wkdWAx1JSmJSR4JJ+xrtYeG1UCWiRsnIjTpV8l+W67 PnRwvJEz8L0yi4fWU51C9ztYcIVPAhZkvxdMu145JicaPXOm6y9eY3RYNfHnRBXUR6xh nj5n5Mm7uGCh8xspjrsRK/SUuiwI5dS2DObRtzygVkxa83vyOj+MjT54u1nYJj9cgWZX gnag== X-Gm-Message-State: AOJu0YwcyiqKTMjDDHau/yb6I288io+MhYwlMkuI5NQ3RDwpHQEK8twD PhRoLT3/rzqvNncXsuFTAJUfp1nrP6YCdPu1CgVgvuCxtGMPKmpsxBFns/rv3tvwgGliWUJr3s5 hXyBvZLi3zY+5CeYby4d9T1sydhuwgguMpAm3hzFnHSrrgTXaooE/YA2F8tqKgW7qHmo8TFqR8q 0nbko5jVWkfNruwBpj5QTW5fcGkpVSsNXiaGZnv5Ra X-Gm-Gg: AeBDieveDdjbujD5ymQ+RaXzew6ZtYLjg6mxWLvB1mojmidS33W/YDiNEHrraKpm9Ov ucgXgCzYWz5w8M6goZY87wu3FUwy2ud9zpNDX8P5nZNdX1liJ2rt31M9CjaPtuXZ/DOd1aDwbl8 tshgx2erTuZ/Uw9foq6M+DROnzeDKQZCttV4DsjmYw7aXJMWbMNc/QTcZOAgli5B0WhFtUF6Cs2 GK2w9gfP/agI9FWKEeVqd/Fqdv1ZSub0OZFA5gqzLllwe6WI4GzQMKNz94NggshJxeOf1noZa9w LfxDQfcPba8bO260K5FgxJJ2dxcddQhdizO9wPzt8p2fNKk6fTEL9taEmQ5k5YXuGJdhZUxWK8T 72hgVGzq2HVgZV5ayF5GY/2tlGfqPsnVmfgSufhEhsXMUSi92bwHvvK7wN2sYySg9UkRsbFwsl1 OLRmeZC0+3+angPdbEagbmmqWrO1e79BGCG4s= X-Received: by 2002:a05:600c:3f10:b0:485:35d3:ce59 with SMTP id 5b1f17b1804b1-488fb753c9amr345342055e9.10.1776940258242; Thu, 23 Apr 2026 03:30:58 -0700 (PDT) X-Received: by 2002:a05:600c:3f10:b0:485:35d3:ce59 with SMTP id 5b1f17b1804b1-488fb753c9amr345341595e9.10.1776940257727; Thu, 23 Apr 2026 03:30:57 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Bin Guo Subject: [PULL 24/25] memory: Optimize flatview_simplify() to eliminate redundant memmove calls Date: Thu, 23 Apr 2026 12:29:21 +0200 Message-ID: <20260423102922.443639-25-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260423102922.443639-1-pbonzini@redhat.com> References: <20260423102922.443639-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1776940328564154100 From: Bin Guo The original flatview_simplify() implementation uses memmove() to shift array elements after each merge operation, resulting in O(n=C2=B2) time complexity in the worst case. This is inefficient for VMs with large memory topologies containing hundreds of MemoryRegions. Replace the memmove-based approach with a two-pointer in-place compression algorithm that achieves O(n) time complexity. The new algorithm uses a write pointer i and a read pointer j, where i =E2=89=A4 j is always maintai= ned. This invariant ensures we never overwrite unprocessed data, making memmove unnecessary. Signed-off-by: Bin Guo Link: https://lore.kernel.org/r/20260331060731.82641-1-guobin@linux.alibaba= .com Signed-off-by: Paolo Bonzini --- system/memory.c | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/system/memory.c b/system/memory.c index 56f3225b21a..0ff066c3484 100644 --- a/system/memory.c +++ b/system/memory.c @@ -336,24 +336,25 @@ static bool can_merge(FlatRange *r1, FlatRange *r2) /* Attempt to simplify a view by merging adjacent ranges */ static void flatview_simplify(FlatView *view) { - unsigned i, j, k; + unsigned i, j; + + if (view->nr <=3D 1) { + return; + } =20 i =3D 0; - while (i < view->nr) { - j =3D i + 1; - while (j < view->nr - && can_merge(&view->ranges[j-1], &view->ranges[j])) { + for (j =3D 1; j < view->nr; j++) { + if (can_merge(&view->ranges[i], &view->ranges[j])) { int128_addto(&view->ranges[i].addr.size, view->ranges[j].addr.= size); - ++j; + memory_region_unref(view->ranges[j].mr); + } else { + i++; + if (i !=3D j) { + view->ranges[i] =3D view->ranges[j]; + } } - ++i; - for (k =3D i; k < j; k++) { - memory_region_unref(view->ranges[k].mr); - } - memmove(&view->ranges[i], &view->ranges[j], - (view->nr - j) * sizeof(view->ranges[j])); - view->nr -=3D j - i; } + view->nr =3D i + 1; } =20 static void adjust_endianness(MemoryRegion *mr, uint64_t *data, MemOp op) --=20 2.53.0 From nobody Sat May 30 20:11:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1776940331; cv=none; d=zohomail.com; s=zohoarc; b=AflY0tE4bYTgFQE6TNlDUJIr14x4Lwz1FH2OXwjMo8T5pkndllNJh/nBDF3n+0DKRP/bwu/klNYInDLEcb6l39u0KPSZkd+EeSBC+dinhyZqmPii0jjqS/mOnDrY2Eq2KpUPnAqvYaJMwJOwISbdvGh+gWdaz1+cgANI8HRkWFE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776940331; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=CXEYBCQhBS8pyO+GypVhIKr4nLl0vrpRMrlByTutUAw=; b=GFSZ7xZpqswAwo+gnbbPf7po0PrTZY+uwnQe0BUaCb9RZXmEyNYKjeItxn+16iyAEhyPzbRAa/gVTCdM1CzAal5XYTT+4KH2ao1TIeUg4sqiOIuQAcqCgwte93DYJeWNSSeHH4x9dbJAoL8VhBt3vGRQsApDH7IpxXTBHorSfSg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776940331612649.8033082381605; Thu, 23 Apr 2026 03:32:11 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wFrLe-0002Ax-KW; Thu, 23 Apr 2026 06:31:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrL1-0001dT-VM for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:31:17 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFrKq-0006AO-Uc for qemu-devel@nongnu.org; Thu, 23 Apr 2026 06:31:09 -0400 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-594-klV8Q2n4MSWTBlG2f37WYQ-1; Thu, 23 Apr 2026 06:31:02 -0400 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-43d780757eeso3979444f8f.1 for ; Thu, 23 Apr 2026 03:31:01 -0700 (PDT) Received: from [192.168.10.48] ([151.49.85.67]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4cb1249sm48801208f8f.5.2026.04.23.03.30.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 03:30:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776940263; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CXEYBCQhBS8pyO+GypVhIKr4nLl0vrpRMrlByTutUAw=; b=QhMtouFWeK3fKjzy07h8Pbdx+F2THA5AZsYYIdfku/K388DNAHOzr/5SHX+P0AqyTChbsO aQWqBCQx0pSTY2mZGzB3SyRBu3eL49AorfhiuRPbagarS+ibuiklqsVNQAQw0qF6VzJlwD HSa9kiF3Gsi7yR8ChRAlaHvsrOJYdfY= X-MC-Unique: klV8Q2n4MSWTBlG2f37WYQ-1 X-Mimecast-MFC-AGG-ID: klV8Q2n4MSWTBlG2f37WYQ_1776940261 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776940260; x=1777545060; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CXEYBCQhBS8pyO+GypVhIKr4nLl0vrpRMrlByTutUAw=; b=qaXx41k5XgFOQz0anBPfz1m857sf6BUE8bYuB78MLmtk1eGWWpF/NU2KmlSbpSHoeo 7/3fDZD62Q96agtPrbpuwXRlI5CqeaQIe2QuBUH/ijQTkS9Mw3APPOwr/LudKDZRwSdW ySBdx33b305z8w5jafzDSN35rRvBde7XG+7tAJowR/BUAhO2gPd5JhBtPet60HNP2Sg1 4pp2FHJvJe0/drg1PJT74d5lmABpbpi1vlCSSMN7AjQBeFAjAXFDlm/REDKG0hxUOV93 4HnDxyexdBEFdAHOB7rdEYY1WfPtq1xbs6Gg+q/9EoYSBjBjTjaVKpHfp2zIc+Oon6Ty Z3ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776940260; x=1777545060; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CXEYBCQhBS8pyO+GypVhIKr4nLl0vrpRMrlByTutUAw=; b=EPjzhrWwQMLG3/x0XCw6JEY+Eq55xMplVa+G3qbu7pGD+vW8n3XGJh+HYF08huWRp+ CdExDn9FTJsloUpTXYcwBJ3EuFCjKct86wAiW4lPJoTmed7F8uSaRs3O+up6daw8/07M d8/D4XU46672KE1f5xPgpHjZQUvtbFe9P1UjipI8hYU5+LX1acQ0mKqvaBC9iDyIN+bk uvodROUHMuf08GFvk9ByuyZfN63LLdwPZdvI4yiLRPz5y+B3NawKOIoiZxGa8ezUD1PL 6DTk0Zvl6EIT6ZWQyI7ZZ/D1ORr7/kJSER8/Og5Cu5SCQZoPztB2bYqTEIDOjSQV7HKR XmaQ== X-Gm-Message-State: AOJu0Yw+jtxhIwvwRYE1JegMmgl1Mry0xgQXIOJjOw0wsk7oOMNKR3Ik 4Wz5eXFqZ3bGtnnBnACscwS7T/p/S/TxU+Unsl0uSmPZJLp8iBrXArxn1AJOIKB9SlpJ4p2q6D4 AsfSKlIBXKGDrkASTNc+2C7bNg+AKOXVwCGr5AYLuUTC3k4dsVjzn+ht9l+G6nx4nKaOArm07BG qsRUdwzaOC7tTc1rMmQHQBkXmhDYSV6wXN8BZUVYTS X-Gm-Gg: AeBDievpNGhrPgulbrc/b1xwZuqdEz055PcbJQLN18v7FE0ACbCPcElfAIKy1A2/T8N OjhYd7G4tJWL45u981LEobDmTLDcNCK0KFtOpJeI/SsCBATbaA1T/0TRf0d34LyDjqROEsj0EN+ 6v9BVD7vrkDc6NBnuLdEvw96LFODiQUUM9hnveVob1UNA6EfjiPBWVxEtndCXqtGpC0vucbHXiy CNcOEHiggYx6KPWJUCWSnUj49Xanyv5gdTmtrn5UDM0gCMEhPwhn7xaE2CjK77VabekJ9q+8WDG ASqmV70sZVMbW593x1jR/4WgEmFJu6rI557nb3KoK6lBMARzF/aXxUtL7OwXpT/bmwRTSW8nr9H RaXk+gfjAC70UxWD2DsSulRxy6yL7/AaE1sh0KFGrXqgcfCdy+ptF47le8eGvx33lLz0a3Sn8nL 0D1BroK1z56amYcKL+w4wg+jQvneV/VsaLrBA= X-Received: by 2002:a5d:5848:0:b0:439:bee4:8a93 with SMTP id ffacd0b85a97d-43fe4073758mr42827328f8f.12.1776940260434; Thu, 23 Apr 2026 03:31:00 -0700 (PDT) X-Received: by 2002:a5d:5848:0:b0:439:bee4:8a93 with SMTP id ffacd0b85a97d-43fe4073758mr42827260f8f.12.1776940259903; Thu, 23 Apr 2026 03:30:59 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Mohamed Mediouni Subject: [PULL 25/25] target/i386: emulate: include name of unhandled instruction Date: Thu, 23 Apr 2026 12:29:22 +0200 Message-ID: <20260423102922.443639-26-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260423102922.443639-1-pbonzini@redhat.com> References: <20260423102922.443639-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1776940332762158500 Content-Type: text/plain; charset="utf-8" From: Mohamed Mediouni Instead of just the command number, include the instruction name to make de= bugging easier. Signed-off-by: Mohamed Mediouni Link: https://lore.kernel.org/r/20260407141809.16862-2-mohamed@unpredictabl= e.fr Signed-off-by: Paolo Bonzini --- target/i386/emulate/x86_emu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/emulate/x86_emu.c b/target/i386/emulate/x86_emu.c index 55b1a68eb6c..c2da1a133f3 100644 --- a/target/i386/emulate/x86_emu.c +++ b/target/i386/emulate/x86_emu.c @@ -1399,8 +1399,8 @@ static void init_cmd_handler(void) bool exec_instruction(CPUX86State *env, struct x86_decode *ins) { if (!_cmd_handler[ins->cmd].handler) { - printf("Unimplemented handler (" TARGET_FMT_lx ") for %d (%x %x)\n= ", - env->eip, + printf("Unimplemented handler (" TARGET_FMT_lx ") for %s - %d (%x = %x)\n", + env->eip, decode_cmd_to_string(ins->cmd), ins->cmd, ins->opcode[0], ins->opcode_len > 1 ? ins->opcode[1] : 0); env->eip +=3D ins->len; --=20 2.53.0