From nobody Sat May 30 20:13:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1776889626; cv=none; d=zohomail.com; s=zohoarc; b=NSaX+3KCByJhz3+LtWO4hkh1YISggDbsRotqsNEaogM3PEDAFgd6PQtNGoeYaiOaIbnwwRdaw1JXiKz7lVPck8iA3np2lcPG9MkrWQwfIVAslc7812jtgFv52CF+eXcIwZuXbXD7BeK/3jpvrkLgyt9TndmY3T0sQa4mzJyVKCc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776889626; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0mii0mnRtaDc1CmXFegMYX9tvRFhCT1ymqZhMmQAPr4=; b=ekYKH30g15U0p8EbvEIhul5bfAoLUaMWxE254MIMlor7GuChobuhdkrMbjRYSuMQng4FwUIjJedRG3ilCMCDQ64bPFiPfvBFz28iDnj+rb8bVp3coEKt8lgz5l3eniTlNoyaomW39GqODCyrZCx/CTKCBMUZgE6CJlkreRXjn5w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776889626947138.30707027410244; Wed, 22 Apr 2026 13:27:06 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wFe9y-0005JT-4l; Wed, 22 Apr 2026 16:26:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFe9w-0005JK-VW for qemu-devel@nongnu.org; Wed, 22 Apr 2026 16:26:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFe9v-0007UM-Gq for qemu-devel@nongnu.org; Wed, 22 Apr 2026 16:26:56 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-xq3skhz5OTKUTjBFHH6rFg-1; Wed, 22 Apr 2026 16:26:52 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 041A019560B7 for ; Wed, 22 Apr 2026 20:26:52 +0000 (UTC) Received: from localhost (unknown [10.44.22.21]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A3DAF30001BE; Wed, 22 Apr 2026 20:26:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776889614; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0mii0mnRtaDc1CmXFegMYX9tvRFhCT1ymqZhMmQAPr4=; b=JJkdCNypJBtDejIB4x6SmOvKwFyiSE6UNmXLcywdrwC3Pq4or7g3oE3EBt8za+/pdSGIzK m1KitvA7NCdNoX41MlUdbXS5XQQrHV0mrvmWWjihh79y3p6ylgpCe7853zZXuBZE7PGWqY kmAiZUc1SNTVlAsncNcl3bVx2PmLh/s= X-MC-Unique: xq3skhz5OTKUTjBFHH6rFg-1 X-Mimecast-MFC-AGG-ID: xq3skhz5OTKUTjBFHH6rFg_1776889612 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PATCH] ui/console: remove console from global list on finalization Date: Thu, 23 Apr 2026 00:26:46 +0400 Message-ID: <20260422202646.272081-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1776889628409154100 From: Marc-Andr=C3=A9 Lureau This commit removes the QemuConsole from the global "consoles" list when it is finalized. Previously, there was a TODO comment indicating this path needed checking. The assertions added ensure that `dcls`, `gl_block`, and the `dump_queue` are empty before removal, confirming the console is in a clean state. Fix potential use-after-free crashes when a display console is removed. Reported-by: Markus Armbruster Signed-off-by: Marc-Andr=C3=A9 Lureau --- ui/console.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ui/console.c b/ui/console.c index f445db11389..b64e2122f34 100644 --- a/ui/console.c +++ b/ui/console.c @@ -394,10 +394,13 @@ qemu_console_finalize(Object *obj) { QemuConsole *c =3D QEMU_CONSOLE(obj); =20 - /* TODO: check this code path, and unregister from consoles */ + assert(c->dcls =3D=3D 0); + assert(c->gl_block =3D=3D 0); + assert(qemu_co_queue_empty(&c->dump_queue)); g_clear_pointer(&c->surface, qemu_free_displaysurface); g_clear_pointer(&c->gl_unblock_timer, timer_free); g_clear_pointer(&c->ui_timer, timer_free); + QTAILQ_REMOVE(&consoles, c, next); } =20 static void --=20 2.53.0