From nobody Sat May 30 20:15:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=reject dis=none) header.from=rsg.ci.i.u-tokyo.ac.jp Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776860114617309.8972476841575; Wed, 22 Apr 2026 05:15:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wFWT5-0003XN-Rl; Wed, 22 Apr 2026 08:14:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFWSv-0003WC-VD; Wed, 22 Apr 2026 08:14:03 -0400 Received: from www3579.sakura.ne.jp ([49.212.243.89]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wFWSt-0003VK-6C; Wed, 22 Apr 2026 08:14:01 -0400 Received: from h205.csg.ci.i.u-tokyo.ac.jp (h205.csg.ci.i.u-tokyo.ac.jp [133.11.54.205]) (authenticated bits=0) by www3579.sakura.ne.jp (8.16.1/8.16.1) with ESMTPSA id 63MCDTNX030696 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 22 Apr 2026 21:13:47 +0900 (JST) (envelope-from odaki@rsg.ci.i.u-tokyo.ac.jp) DKIM-Signature: a=rsa-sha256; bh=c6f8xHZahEQDw28PGKsEGeLYdPm2CEUuNXUGAafH/bE=; c=relaxed/relaxed; d=rsg.ci.i.u-tokyo.ac.jp; h=From:Message-Id:To:Subject:Date; s=rs20250326; t=1776860027; v=1; b=K5Y+q+NEM9CIQi34hFmbkuZOigsKb3+zWv5nzi9VKx5LXXaUAAL6Y1NgK4lBjMEJ jLNYXhfgj8a8Ab9qMNxdYDRbEKorOdX8Ut4GUGI+UeId/7g85j1VszVX6UoP+ru0 drQFgaLj6tjh0zeQjpCxxMn2NHQ7offGRKyeVu5CYjJmcF2G+eG+DXIv2dgF15Ze OqnovCytaaDKIQKabeR4PBhWktf6nffKZ+dqZRuw10Hk9C/cuBIaSUQjdFEiO6Bm 8TPxHuIXugT4nAlIZzC7UYt9mbibwaztojjLBJe7V4Ws9hJnHZ4RS10oJsB6zgCN TF+7ohEPHxzG/UnsJw/Wwg== From: Akihiko Odaki Date: Wed, 22 Apr 2026 21:13:26 +0900 Subject: [PATCH] target/arm/kvm: Mark host feature cache valid last MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260422-arm-v1-1-106a9a9e22dd@rsg.ci.i.u-tokyo.ac.jp> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDEyMj3cSiXF0LkyQj45TEFANTM0MloMqCotS0zAqwKdGxEH5xaVJWanI JSKtSbS0AP/7gvWcAAAA= X-Change-ID: 20260422-arm-84b23dad0561 To: qemu-devel@nongnu.org Cc: Peter Maydell , Paolo Bonzini , qemu-arm@nongnu.org, kvm@vger.kernel.org, Akihiko Odaki X-Mailer: b4 0.16-dev-16047 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=49.212.243.89; envelope-from=odaki@rsg.ci.i.u-tokyo.ac.jp; helo=www3579.sakura.ne.jp X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1776860120034154100 kvm_arm_set_cpu_features_from_host() treats dtb_compatible as the host feature cache valid bit, but kvm_arm_get_host_cpu_features() set it before later register reads could fail. Set target and dtb_compatible only after the feature data is complete. Signed-off-by: Akihiko Odaki --- This fixes a semantic issue I found while writing the next version of [1]. I am not aware of any case where it manifests as a real bug. [1] http://lore.kernel.org/qemu-devel/20260225-kvm-v2-1-b8d743db0f73@rsg.ci= .i.u-tokyo.ac.jp/ ("[PATCH RFC v2] target/arm/kvm: Choose PMU backend") --- target/arm/kvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/arm/kvm.c b/target/arm/kvm.c index d4a68874b880..03c3346d50ed 100644 --- a/target/arm/kvm.c +++ b/target/arm/kvm.c @@ -329,8 +329,6 @@ static bool kvm_arm_get_host_cpu_features(ARMHostCPUFea= tures *ahcf) return false; } =20 - ahcf->target =3D init.target; - ahcf->dtb_compatible =3D "arm,armv8"; int fd =3D fdarray[2]; =20 err =3D get_host_cpu_reg(fd, ahcf, ID_AA64PFR0_EL1_IDX); @@ -472,6 +470,8 @@ static bool kvm_arm_get_host_cpu_features(ARMHostCPUFea= tures *ahcf) } =20 ahcf->features =3D features; + ahcf->target =3D init.target; + ahcf->dtb_compatible =3D "arm,armv8"; =20 return true; } --- base-commit: 98b060da3a4f92b2a994ead5b16a87e783baf77c change-id: 20260422-arm-84b23dad0561 Best regards, -- =20 Akihiko Odaki