From nobody Tue Apr 21 14:36:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1776760223; cv=none; d=zohomail.com; s=zohoarc; b=UE7CGtC07wjK0+mDzC3iPBjUklx2s+FqiqTJsAkiEgb4F/kiBy1F8qMdF+4hjIw6b0H4JT50mJ1vSUxHvnTvtzFfmFsitC5v/nW8nmBr45JXeOjp4DF27kAV0UgLWiqCjsLzSBQitREM7VDMMhCzWOoIwHW6rUESEWvT90pgqeM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776760223; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=QaaiJUC2YBK4ZQi2KQoDSjX+y0kVGZ2x+704p/2Lf5c=; b=WdQOSwvP/IYmvQoyJ3hRqqgnkd2qKT5sojzQnagyBO7uImI+/Dj+HIt6KTJ98ETXBWRlCQu9tti1sROtCrLpeFPNcwmfYlg9L3IHglSl9J1av3eYrl8Z43JLYZLZCSNtKXBuWP2eCPMS+z8TFKxIK+gcgfLjRY93GhMXrnpnDnY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776760223594851.7306433025046; Tue, 21 Apr 2026 01:30:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wF6UM-000440-WD; Tue, 21 Apr 2026 04:29:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wF6UL-00043c-Oo for qemu-devel@nongnu.org; Tue, 21 Apr 2026 04:29:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wF6UK-0008Ll-CO for qemu-devel@nongnu.org; Tue, 21 Apr 2026 04:29:45 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-404-6b2oZwZQOa27zC8lbWiIUg-1; Tue, 21 Apr 2026 04:29:41 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CD5AC19560B2; Tue, 21 Apr 2026 08:29:39 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.49.140]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9E9BC1800906; Tue, 21 Apr 2026 08:29:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776760183; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=QaaiJUC2YBK4ZQi2KQoDSjX+y0kVGZ2x+704p/2Lf5c=; b=WkGIh14ILNaQeLrcjFYEFx7XZualB/NcO8VS4egLOqNXWH0aEWq+QBJLW9xVASAOFdHGI9 c4PnGsbVkEyYsilKiy5aj41YfjYlHJBENw0HTtmDvSDibepvToj22L07Np6oXeeD34o5nC IVAvMsS+LjFe5DVmkdGNyyFiOrZq/fg= X-MC-Unique: 6b2oZwZQOa27zC8lbWiIUg-1 X-Mimecast-MFC-AGG-ID: 6b2oZwZQOa27zC8lbWiIUg_1776760180 From: Thomas Huth To: qemu-devel@nongnu.org, Michael Rolnik Cc: Peter Maydell , qemu-trivial@nongnu.org Subject: [PATCH] hw/misc: Fix the valid access size to the avr-power device Date: Tue, 21 Apr 2026 10:29:35 +0200 Message-ID: <20260421082935.85995-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1776760230637158500 Content-Type: text/plain; charset="utf-8" From: Thomas Huth Accessing the device with in non-single byte mode currently causes QEMU to abort: $ echo "writew 0x800064 0x4142" | \ ./qemu-system-avr -M mega2560 -display none -qtest stdio -accel qtest [I 0.000000] OPENED [R +0.001784] writew 0x800064 0x4142 qemu-system-avr: ../../devel/qemu/hw/misc/avr_power.c:58: avr_mask_write: Assertion `offset =3D=3D 0' failed. Aborted (core dumped) Set the valid max access size to 1 to fix the problem. Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3393 Signed-off-by: Thomas Huth Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/misc/avr_power.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/misc/avr_power.c b/hw/misc/avr_power.c index f42cf4fd906..42be2656911 100644 --- a/hw/misc/avr_power.c +++ b/hw/misc/avr_power.c @@ -73,6 +73,9 @@ static const MemoryRegionOps avr_mask_ops =3D { .impl =3D { .max_access_size =3D 1, }, + .valid =3D { + .max_access_size =3D 1, + }, }; =20 static void avr_mask_init(Object *dev) --=20 2.53.0