From nobody Sat May 30 20:11:55 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1776400045; cv=none; d=zohomail.com; s=zohoarc; b=GGSfzDY/NikdyQ+elxFB3e6YSkNLoy8LP9B6MDRJFkfiruOQuaB7F+B0JttLpBDldOZJ3cFWDouuPYOhBAJQ9Xcwo0cQ+picjZ+4eYTesFL1WZJX/Lo5K094OIbsCVwE0FjtQjbqEelNNTnVk7AXmKc607TQN5zwklJWmBlPhog= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776400045; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=r2/j0lOvBO3DmQSFFQJaOFAPLEgLpTImUbZ3zpQz9DI=; b=nXV7yfEc/AJiNn/aEDbf0CDYoUalqDsugQCKyxCDTSnZHw8ex3FJbneRNvdeF+DPfwvw8oL3qUguKeS3Pq6xTeHEjyH1DOvbtJoLRBNdCmKDC+UM6f2dzrlwQ5DYtOzauq2d9eepaR55Mkfwb/9LDNCMoUw0/arTaLa03xLVf8c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776400045210810.3886026708649; Thu, 16 Apr 2026 21:27:25 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wDamn-0005z4-Nk; Fri, 17 Apr 2026 00:26:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wDamm-0005yi-3z for qemu-devel@nongnu.org; Fri, 17 Apr 2026 00:26:32 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wDamk-0006Mw-Kj for qemu-devel@nongnu.org; Fri, 17 Apr 2026 00:26:31 -0400 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-488a9033b2cso2244875e9.2 for ; Thu, 16 Apr 2026 21:26:30 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc1c01cfsm12609935e9.10.2026.04.16.21.26.27 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 16 Apr 2026 21:26:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1776399989; x=1777004789; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=r2/j0lOvBO3DmQSFFQJaOFAPLEgLpTImUbZ3zpQz9DI=; b=ncs+cKY3R9yRhdRvBZBsd1op8zXPvMXH90+Td3d+lJ1ik72zBUQRL5NnnmQJhb17wx l9UvSqpE1PleHXdrGaoC5KWZpuonOmfBkjU3FOs2zi9RuX79tWQIi9M/BwOCRPjqKx4c DkwxnpWLfIsMPwIQ3pjFhoKmtYMEiVXti4JAruA396m4vbFfZ0I6qDXlbNNSLl06tXSZ X8WQftD5z6MA1IlXZ6GCU9bNTU4OnfmcbZzpP+jtW1uwJ/N+vgwhZFq4IKD5HO9CgR58 ildZJE0o46VcyHLDYoM+hnEB9diTQD+qv5y2WT6hHzZbUlV3cra8algUaieymOguHfd3 77qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776399989; x=1777004789; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=r2/j0lOvBO3DmQSFFQJaOFAPLEgLpTImUbZ3zpQz9DI=; b=dqqhb1juqGeFxGj1trktkT2e4LN2X9zyK7+JwezWDhybRb7b8ybKkGxK4m1o6bRdgF BFYMz6ctR6/WgidCLTqTQjPW/DGAFEPlQuDnpPvwmCnEyZUWUiSqlCcKscLiMWZKsDZf xKpmn7KRxZBmXqi4xlSHGXyh+t11rvWl1tZP34dQrALk36yIwrJi+CUsnGa3moAxqkyF jUnKxkeKQrX9LIkPXdoQgS8RtN4tNPHRlx6VEA9/ZL5x18eJew/FlbE5kcU2T1AINCV+ cWmm87oDJoznlrHc2gA+mc+ivyPzyU3cSrWiTI99qmYVun31OtQWIzwqCsdVaoui3GEN wYFA== X-Gm-Message-State: AOJu0Yzlr7g5cpG0jbxNqKs4nQP6kM+EZwiuRQc9cwYRvfdjq32Mf9o+ KqXQvwpZjiH+tOqAR3+y9nNzs50lHDuQFMfdqZO5WUVN13KhNSyXfTxOviOowYQU2ghqTRC+LPH wFLcmJLs= X-Gm-Gg: AeBDietZOCjGr8ZzC4odRbndhZyN42mV8nx91HIIjEJvRgADI/b9mLVhBGozyhJs4/U 7RkjbQFaNnupyQm2sCCaMkLjVZYV0sZSXCl5KhkA4AgRlzl2cYQfX4mOQQ+VvALaRqGiszqPZVl HK+lvMfBvzZsXfFiqjSuTyeFWGJhNPmICeRaiy/6jFZ2Z5Zb83CJmQWt19QzMGaGm//vnYani48 IG4jpSPAKzXa61pN7Q/JikNubDw3QfgV9M8xtgsBGQptSvM/Jdim7Pq/DRh61KEzJEXY7mQKYam sJF5QREo4++qwowHIG6y0EDGv9AIxKYTQq2Y2MZ8/ozJJ4IVn4WpNoZp9L8cgvGom2M7owQtCyB ZYGEU4qll2pRL15iDV5rofrFgMjOmHc95pY7Rh9Mdl6XrKgrtWGjoX6wR3jP7bTrxF+cboJXW67 GZxF/88PdEBA+FV0UzXhOTwFhKvcYOHGbbAbdB3L2tAqodOCIXJZdqPHw5CtNNbwL+WpZzKpxJA 7dUxy5U5A/ciF8n3atLlQ== X-Received: by 2002:a05:600c:3513:b0:488:a977:8de with SMTP id 5b1f17b1804b1-488fb77a3a7mr14414325e9.16.1776399988832; Thu, 16 Apr 2026 21:26:28 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Aleksandar Rikalo , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH v6 1/4] target/mips: Pass MemOpIdx argument to Linked Load/Store helpers Date: Fri, 17 Apr 2026 06:26:16 +0200 Message-ID: <20260417042620.35329-2-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260417042620.35329-1-philmd@linaro.org> References: <20260417042620.35329-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1776400045718158500 In preparation of using the MemOp content in the next commit (thus stopping ignoring it), pass it as MemOpIdx. The helper prototype declaration always took a TCGv_i32 as last argument, correct that. Rename the ignored 'mem_idx' argument on user emulation. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/helper.h | 4 ++-- target/mips/tcg/ldst_helper.c | 5 ++++- target/mips/tcg/translate.c | 7 ++++--- 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/target/mips/helper.h b/target/mips/helper.h index e70a3942fac..10c6470514d 100644 --- a/target/mips/helper.h +++ b/target/mips/helper.h @@ -10,9 +10,9 @@ DEF_HELPER_4(swl, void, env, tl, tl, int) DEF_HELPER_4(swr, void, env, tl, tl, int) =20 #ifndef CONFIG_USER_ONLY -DEF_HELPER_3(ll, tl, env, tl, int) +DEF_HELPER_3(ll, tl, env, tl, i32) #ifdef TARGET_MIPS64 -DEF_HELPER_3(lld, tl, env, tl, int) +DEF_HELPER_3(lld, tl, env, tl, i32) #endif #endif =20 diff --git a/target/mips/tcg/ldst_helper.c b/target/mips/tcg/ldst_helper.c index 10319bf03a6..b725c6d0333 100644 --- a/target/mips/tcg/ldst_helper.c +++ b/target/mips/tcg/ldst_helper.c @@ -30,8 +30,11 @@ #ifndef CONFIG_USER_ONLY =20 #define HELPER_LD_ATOMIC(name, insn, almask, do_cast) = \ -target_ulong helper_##name(CPUMIPSState *env, target_ulong arg, int mem_id= x) \ +target_ulong helper_##name(CPUMIPSState *env, target_ulong arg, = \ + uint32_t memop_idx) = \ { = \ + MemOpIdx oi =3D memop_idx; \ + unsigned mem_idx =3D get_mmuidx(oi); \ if (arg & almask) { = \ if (!(env->hflags & MIPS_HFLAG_DM)) { = \ env->CP0_BadVAddr =3D arg; = \ diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index 6d4b6412d70..839bfe18bab 100644 --- a/target/mips/tcg/translate.c +++ b/target/mips/tcg/translate.c @@ -1922,7 +1922,7 @@ FOP_CONDNS(s, FMT_S, 32, gen_store_fpr32(ctx, fp0, fd= )) /* load/store instructions. */ #ifdef CONFIG_USER_ONLY #define OP_LD_ATOMIC(insn, memop) = \ -static inline void op_ld_##insn(TCGv ret, TCGv arg1, int mem_idx, = \ +static inline void op_ld_##insn(TCGv ret, TCGv arg1, int mem_idx_ignored, = \ DisasContext *ctx) = \ { = \ TCGv t0 =3D tcg_temp_new(); = \ @@ -1932,11 +1932,12 @@ static inline void op_ld_##insn(TCGv ret, TCGv arg1= , int mem_idx, \ tcg_gen_st_tl(ret, tcg_env, offsetof(CPUMIPSState, llval)); = \ } #else -#define OP_LD_ATOMIC(insn, ignored_memop) = \ +#define OP_LD_ATOMIC(insn, memop) = \ static inline void op_ld_##insn(TCGv ret, TCGv arg1, int mem_idx, = \ DisasContext *ctx) = \ { = \ - gen_helper_##insn(ret, tcg_env, arg1, tcg_constant_i32(mem_idx)); = \ + MemOpIdx oi =3D make_memop_idx(memop, mem_idx); = \ + gen_helper_##insn(ret, tcg_env, arg1, tcg_constant_i32(oi)); = \ } #endif OP_LD_ATOMIC(ll, mo_endian(ctx) | MO_SL); --=20 2.53.0 From nobody Sat May 30 20:11:55 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1776400042; cv=none; d=zohomail.com; s=zohoarc; b=bqnnaLDdnDdex+Ng+fl+DPdd1GNKTSEGAtE+rv3EyDGqY3EvYYPFNcTihd/xKWxHk2ba9q8uicZZvXGcbR+Ko3lIN1ik4nDeOSOpvCIEBma9zP8JS1byYUx9qOL7T/SzjCtcMXQTSCw//5VUGHPSfWqV3rc9xT9pEFFUOnTdf1A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776400042; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Gw9TjGxlM4a7z2UtfxxhY5WNWrcHe6UnFE+Ln152chE=; b=XPO6G4jUkthctWTABx9igc5LYnwHs3p+6ocoohe2UA0urWGEme7Ots6YcHiKEABn6LnCYYJkdDaGMGpSP7A5sfOtktwTtx5+4o0VKhuNnnR2E26olTRo31BWgh4crPAGCLOYAUeAe75hgGmsD3Yi0qLTEjX7HhCoOUkWTWJekEs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776400042057298.25626599079226; Thu, 16 Apr 2026 21:27:22 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wDamy-0005zg-2k; Fri, 17 Apr 2026 00:26:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wDamw-0005zT-53 for qemu-devel@nongnu.org; Fri, 17 Apr 2026 00:26:42 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wDamt-0006NO-4W for qemu-devel@nongnu.org; Fri, 17 Apr 2026 00:26:40 -0400 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-43cff5dafc3so135011f8f.1 for ; Thu, 16 Apr 2026 21:26:38 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4e4eec9sm1146400f8f.34.2026.04.16.21.26.34 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 16 Apr 2026 21:26:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1776399997; x=1777004797; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Gw9TjGxlM4a7z2UtfxxhY5WNWrcHe6UnFE+Ln152chE=; b=PDidk0qwY7N4R/NMy5Z1UWAdFvt0oPjlvuDOMYEjIltIbF1QeWIyCmtdCGsQ2TeDZ+ RVCut3Rdk0VUI/sija+7euXEQX4l56YEN4zE72E6Y+BMOf9iqBRNYCUrZEvPq2e97PZb JtKhbPQCM8wUbr+FiVHHBs07aEMqFzyDZTNJ9w8VyZyBbWDcoQzRdxDD5XRbCgGGwYB9 2QahSPTG7LEHc2wTMWzTZxjLh/jIy5eB5gpnx4zTa2PUSHe64ZgT+m0QgtLQVAiEd5/F KCmdaKvlPBXFz535vBtOFKklT4AxnOkQyIwZb+XXiIzvYy+vLNRTM1p/7vp/ETcSdNkW Q0ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776399997; x=1777004797; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Gw9TjGxlM4a7z2UtfxxhY5WNWrcHe6UnFE+Ln152chE=; b=fzII5nsl0YnTtAi88mnv7Ihvgg5jc4P8YPkbMG47s5ANf4ZUW1SLqbCHxE2yVHqWP5 EqWpuAPQ9IaY8N6rxUwRNThAOJ8WGMfHySu4HD6UIHtVMIal7OPQ2TCRX2Qv7Yi7EWgP JwYPnD0sDc9Idji4mgnY0hf9IKTfrxlB8yw5+GX6lANOXf2+PNwdP4RWW2lwcPnXLQ7m nP6V0E4diKogcKGmpGZjU99ldNleSUPPLKi1/7YiMimcPCWH7EeLhVMk3fIz/HSzWWfK P0bKBxB9NU+2JshteUY5Q3U6+xX3U5emmhxVW591N2lFUIchHY6r7fFbrC0HX6TrY0v/ d6zg== X-Gm-Message-State: AOJu0YwOKkFyebfe1wlNQ3X9fzOEM0kXXsjv9OiDmFCSeoiFWEkuXtuV 9EFcOGHYcldXI65aOpQu0nHnng60chrTY3th4QQTQB1keRWMjAoLSERr48in4Ed6Ntwd6xki76J AKDAZ/O0= X-Gm-Gg: AeBDiet60CL5xsvG1xlOdJj/D2kVB1GRQrVPsrRy/9e80uM8z3RNBfDUxSLeTRVP3tt f2yAFLwWCa/JEBzPGmeFIPwGUKIIN9NKoZQiKDdTZzDxoJmrD2KN+9XbkgFrMJ655mTsuXY41+n q0yJvMLVyHZluHBqhC5l6ph1xEKCovyJhiTZxcTWZboir0u3vZEa1iX2rLmLlkkL0n1enTsKYWY VERw5823Cv0NbpKNYK5DaCS2bNRfHRokQ5VbUHBa161QVe4m/Iv0I0ff5q/D18N8uL+qe8RN9Pw eic1VtudHvc57vdCGla5eIkBI06tvEN+Bupu66IqLpfYcV3l4Sipk+AYBUnfCoFUfiunF1u2J+T MrOiyBKxEmCPIDJoP8YMN4PK/D7I5G4v+mZG5RqeeOdvm04KY11rTKs6OTWUm9PrV0b7OxHb40k U1OV2Ks4VDi8i0jVEwtth6aySDkweiki3rNcvII/ASlT3QtHgKg7vFxqEvx7fEdf+aiXGLaO4Di +6ClDdGCoeTAzlxNum2fg== X-Received: by 2002:a05:6000:2284:b0:43d:7377:8772 with SMTP id ffacd0b85a97d-43fe3e25982mr1537120f8f.46.1776399997326; Thu, 16 Apr 2026 21:26:37 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Aleksandar Rikalo , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH v6 2/4] target/mips: Inline cpu_ld/st_mmuidx_ra() calls in Atomic LD/ST helpers Date: Fri, 17 Apr 2026 06:26:17 +0200 Message-ID: <20260417042620.35329-3-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260417042620.35329-1-philmd@linaro.org> References: <20260417042620.35329-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=philmd@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1776400044828158500 Have callers set MO_ALIGN in the MemOp bits. Perform the access first, filling the TLB in the process. If the tlb cannot be filled, access is not permitted, and an exception is raised. Thus remove the now unnecessary do_raise_exception() call. Since the TLB is filled, use probe_access() to get CP0_LLAddr. Move env->CP0_LLAddr and env->lladdr assignments so we don't update them when an alignment fault occurs. Since we have a handy MemOpIdx, replace the legacy cpu_ld*_mmuidx_ra() calls by cpu_ld*_mmu() equivalent. Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/tcg/ldst_helper.c | 26 +++++++++++++++----------- target/mips/tcg/translate.c | 2 +- 2 files changed, 16 insertions(+), 12 deletions(-) diff --git a/target/mips/tcg/ldst_helper.c b/target/mips/tcg/ldst_helper.c index b725c6d0333..4d67392369a 100644 --- a/target/mips/tcg/ldst_helper.c +++ b/target/mips/tcg/ldst_helper.c @@ -28,23 +28,27 @@ #include "internal.h" =20 #ifndef CONFIG_USER_ONLY +#include "accel/tcg/probe.h" +#include "exec/tlb-flags.h" =20 #define HELPER_LD_ATOMIC(name, insn, almask, do_cast) = \ target_ulong helper_##name(CPUMIPSState *env, target_ulong arg, = \ uint32_t memop_idx) = \ { = \ - MemOpIdx oi =3D memop_idx; \ - unsigned mem_idx =3D get_mmuidx(oi); \ - if (arg & almask) { = \ - if (!(env->hflags & MIPS_HFLAG_DM)) { = \ - env->CP0_BadVAddr =3D arg; = \ - } = \ - do_raise_exception(env, EXCP_AdEL, GETPC()); = \ - } = \ - env->CP0_LLAddr =3D cpu_mips_translate_address(env, arg, MMU_DATA_LOAD= , \ - GETPC()); = \ + MemOpIdx oi =3D memop_idx; = \ + unsigned mem_idx =3D get_mmuidx(oi); = \ + unsigned size =3D memop_size(get_memop(oi)); = \ + uintptr_t ra =3D GETPC(); = \ + CPUTLBEntryFull *full; = \ + void *host_unused; = \ + int flags; = \ + = \ + env->llval =3D do_cast cpu_##insn##_mmu(env, arg, oi, ra); = \ + flags =3D probe_access_full(env, arg, size, MMU_DATA_LOAD, mem_idx, = \ + true, &host_unused, &full, ra); = \ + assert(!(flags & TLB_INVALID_MASK)); = \ + env->CP0_LLAddr =3D full->phys_addr; = \ env->lladdr =3D arg; = \ - env->llval =3D do_cast cpu_##insn##_mmuidx_ra(env, arg, mem_idx, GETPC= ()); \ return env->llval; = \ } HELPER_LD_ATOMIC(ll, ldl, 0x3, (target_long)(int32_t)) diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index 839bfe18bab..4889bd1e518 100644 --- a/target/mips/tcg/translate.c +++ b/target/mips/tcg/translate.c @@ -1936,7 +1936,7 @@ static inline void op_ld_##insn(TCGv ret, TCGv arg1, = int mem_idx_ignored, \ static inline void op_ld_##insn(TCGv ret, TCGv arg1, int mem_idx, = \ DisasContext *ctx) = \ { = \ - MemOpIdx oi =3D make_memop_idx(memop, mem_idx); = \ + MemOpIdx oi =3D make_memop_idx(memop | MO_ALIGN, mem_idx); = \ gen_helper_##insn(ret, tcg_env, arg1, tcg_constant_i32(oi)); = \ } #endif --=20 2.53.0 From nobody Sat May 30 20:11:55 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1776400052; cv=none; d=zohomail.com; s=zohoarc; b=Cbw8VkjegcYXYKrq9LhIXPbov5o+rIyqDpk55Ok/yrVk6wH2L6jgdiqjoJIq9OZk3gYaaFLMm2Rot1wlIDiiJw05+YZdoUQRWtiA6EvHLRuL+zqo7MdXOHdmpFcFRv475E90f1ZKIxhxyF3iLptxak/ToAmhz9SKRVqvx/rc0eM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776400052; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=nN2LV2iBk8TS7rfDPF67a2VsFd0jJs7Szwor3jxaf7Y=; b=N6EEY1vvRO91tLFP8VOT2mRcypqRNTu6XiuLlWBEfpryo68U0Ag9LElmeqglrjO9S+HUNEd60BY+fESaucuIed40MKERVG5d5p0bMFOhlexgCWvfP2eL0FRi5vuYeQwaldPUhnTks56ukyP8kGjbFQbu04fNAk0R2QeIPnQLY3g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776400052848374.54987513344327; Thu, 16 Apr 2026 21:27:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wDan6-00060T-Cd; Fri, 17 Apr 2026 00:26:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wDan1-000603-Pu for qemu-devel@nongnu.org; Fri, 17 Apr 2026 00:26:49 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wDamz-0006O0-Vn for qemu-devel@nongnu.org; Fri, 17 Apr 2026 00:26:47 -0400 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-43d03db7f87so111320f8f.3 for ; Thu, 16 Apr 2026 21:26:45 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4dc26a3sm1249153f8f.15.2026.04.16.21.26.43 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 16 Apr 2026 21:26:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1776400004; x=1777004804; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nN2LV2iBk8TS7rfDPF67a2VsFd0jJs7Szwor3jxaf7Y=; b=g7UWd3W2wrGQbGBvzwXA3a/QMGk9H7bMKrqdym4veqRUoQyfAfjl53K8qTrPJG4AGY 9/J3yyK8iYb3DxKrb9nIyN7uk2q5nwLkA7H9K9fytahZ9mYWZj7gKen5t8mYz1ruwG+U StmJcFqNQykYeiQECutThgB1nKrgrgWQXjHK/uNHSAU/ZtW0xWjbl4WFP+zMnblaOpEK PhAy6RVH1RhlFh6N67u6vPSYsuxxSHoqmvqlqg3PMrkJVxLIeyhWPX/ywiPBJgL/Bc9N eVW5owtsVzOVgr+QFfjRbG2KB+KXrraZ+EKxY9siZxjvlPrp7NA2IdCO6kxZH9JpuR+p cQxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776400004; x=1777004804; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=nN2LV2iBk8TS7rfDPF67a2VsFd0jJs7Szwor3jxaf7Y=; b=gH3i6oY8nGVzfQy94dEKVqMgWdZAmMt2NATZEUsB7tjOTyExjBTe87U2L4cPjghABT zIaPZu/pDb3K8LPMloz2rXRF+gx0J/TiwytIe5Gj/6TzU4Y6/0Xhsx1/6uLp3vVYGjbi x8dL/Oi6q7gy1w30X+aNnGNLt7u8n10Ij3GsN8meyk/7m+xG06V7qev62bg7buiBmZog ZJzyoaCJ1R54Dw+HPnLTKXrol5xHPowjyib/3rWWYbDzkGaWG8xvOMsIGydFTu10ea68 l0xv3GMZmV4lLCtUqXVl5L5KUTwcio+OBITDAU5AfGvaQQQ0QpC8Jh6d7uaOADmcnIYu Ju0A== X-Gm-Message-State: AOJu0YxXI0ii5BvziGM3yAksLjOffvVtuaLNwRQQZR6FVARBkdmNRwFp QIpGQnFVZtHp7m+YTPfWaETMpecZyXNxrYIGlt4CqrvX9pfaXHASEt5febr4tvr6HPIHBg8pydm xg10Mp3s= X-Gm-Gg: AeBDiev5XQKNixnbn7nt247q90N9XEWePpiVCg09aeGv6MT6kwfsJ1RRFYimcmmXbO/ 0dmwvFD2lhgpvWVf7/S/OJqvXtLAQDybsgS52yaxXsM95yhzt9o2iMGBZd9kWojfPcNB9NQklH6 BoxQ5Q6wB/uAnaNKIh6Vi3Roq54lvm+C5QG48l7XiUkRfhovvjCIr3iQkSv+4avHzXcIwdgRJLV 6FC7lvBy3WGIEEGUjvQQwfmqbhSnOaGPLzQWipxAfr6T78/6mmPPj7uCvbtCzE58Nr0gMyQLsGK l01njChgsmFNcqa87rsZv22oqH/sj/GTZGhnx0yYLgemSZadfYdYsu7IAGFDNK/4y13RlJcEzCj gbgDl+azYiZGDQ5P9kZer1fftc7JOIqHrIhosCCLfRFZshjDZ5qhJXt4wYbkD0kBWHUHaTK2HZ0 2MHhJBtLMOjcRYjgFZIDJefuublcWpI9imL7m2K8tWcWtsrHcdOhj+wLaneVMNOSp/PesXYspUP GJGcdnhOfc= X-Received: by 2002:a05:6000:2890:b0:43d:7aa8:f64e with SMTP id ffacd0b85a97d-43fe3e0a2c4mr1540321f8f.32.1776400004139; Thu, 16 Apr 2026 21:26:44 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Aleksandar Rikalo , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH v6 3/4] target/mips: Inline translator_ld[uw,l,q]() calls Date: Fri, 17 Apr 2026 06:26:18 +0200 Message-ID: <20260417042620.35329-4-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260417042620.35329-1-philmd@linaro.org> References: <20260417042620.35329-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=philmd@linaro.org; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1776400055155154100 In preparation of removing the translator_ld[uw,l,q]() methods, inline them for the MIPS target, expanding MO_TE by a runtime check on mo_endian(ctx). Mechanical change using the following Coccinelle 'spatch' script: @@ expression env, db, pc; @@ ( - translator_lduw(env, db, pc) + translator_lduw_end(env, db, pc, mo_endian(ctx)) | - translator_ldl(env, db, pc) + translator_ldl_end(env, db, pc, mo_endian(ctx)) | - translator_ldq(env, db, pc) + translator_ldq_end(env, db, pc, mo_endian(ctx)) ) Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/tcg/translate.c | 12 ++++++++---- target/mips/tcg/micromips_translate.c.inc | 2 +- target/mips/tcg/mips16e_translate.c.inc | 6 ++++-- target/mips/tcg/nanomips_translate.c.inc | 5 +++-- 4 files changed, 16 insertions(+), 9 deletions(-) diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index 4889bd1e518..8b570188538 100644 --- a/target/mips/tcg/translate.c +++ b/target/mips/tcg/translate.c @@ -15147,17 +15147,21 @@ static void mips_tr_translate_insn(DisasContextBa= se *dcbase, CPUState *cs) =20 is_slot =3D ctx->hflags & MIPS_HFLAG_BMASK; if (ctx->insn_flags & ISA_NANOMIPS32) { - ctx->opcode =3D translator_lduw(env, &ctx->base, ctx->base.pc_next= ); + ctx->opcode =3D translator_lduw_end(env, &ctx->base, ctx->base.pc_= next, + mo_endian(ctx)); insn_bytes =3D decode_isa_nanomips(env, ctx); } else if (!(ctx->hflags & MIPS_HFLAG_M16)) { - ctx->opcode =3D translator_ldl(env, &ctx->base, ctx->base.pc_next); + ctx->opcode =3D translator_ldl_end(env, &ctx->base, ctx->base.pc_n= ext, + mo_endian(ctx)); insn_bytes =3D 4; decode_opc(env, ctx); } else if (ctx->insn_flags & ASE_MICROMIPS) { - ctx->opcode =3D translator_lduw(env, &ctx->base, ctx->base.pc_next= ); + ctx->opcode =3D translator_lduw_end(env, &ctx->base, ctx->base.pc_= next, + mo_endian(ctx)); insn_bytes =3D decode_isa_micromips(env, ctx); } else if (ctx->insn_flags & ASE_MIPS16) { - ctx->opcode =3D translator_lduw(env, &ctx->base, ctx->base.pc_next= ); + ctx->opcode =3D translator_lduw_end(env, &ctx->base, ctx->base.pc_= next, + mo_endian(ctx)); insn_bytes =3D decode_ase_mips16e(env, ctx); } else { gen_reserved_instruction(ctx); diff --git a/target/mips/tcg/micromips_translate.c.inc b/target/mips/tcg/mi= cromips_translate.c.inc index 8fda7c8a214..b38c37194ad 100644 --- a/target/mips/tcg/micromips_translate.c.inc +++ b/target/mips/tcg/micromips_translate.c.inc @@ -1623,7 +1623,7 @@ static void decode_micromips32_opc(CPUMIPSState *env,= DisasContext *ctx) uint32_t op, minor, minor2, mips32_op; uint32_t cond, fmt, cc; =20 - insn =3D translator_lduw(env, &ctx->base, ctx->base.pc_next + 2); + insn =3D translator_lduw_end(env, &ctx->base, ctx->base.pc_next + 2, m= o_endian(ctx)); ctx->opcode =3D (ctx->opcode << 16) | insn; =20 rt =3D (ctx->opcode >> 21) & 0x1f; diff --git a/target/mips/tcg/mips16e_translate.c.inc b/target/mips/tcg/mips= 16e_translate.c.inc index 97da3456ea5..beb5b04ea29 100644 --- a/target/mips/tcg/mips16e_translate.c.inc +++ b/target/mips/tcg/mips16e_translate.c.inc @@ -453,7 +453,8 @@ static void decode_i64_mips16(DisasContext *ctx, =20 static int decode_extended_mips16_opc(CPUMIPSState *env, DisasContext *ctx) { - int extend =3D translator_lduw(env, &ctx->base, ctx->base.pc_next + 2); + int extend =3D translator_lduw_end(env, &ctx->base, ctx->base.pc_next = + 2, + mo_endian(ctx)); int op, rx, ry, funct, sa; int16_t imm, offset; =20 @@ -686,7 +687,8 @@ static int decode_ase_mips16e(CPUMIPSState *env, DisasC= ontext *ctx) /* No delay slot, so just process as a normal instruction */ break; case M16_OPC_JAL: - offset =3D translator_lduw(env, &ctx->base, ctx->base.pc_next + 2); + offset =3D translator_lduw_end(env, &ctx->base, ctx->base.pc_next = + 2, + mo_endian(ctx)); offset =3D (((ctx->opcode & 0x1f) << 21) | ((ctx->opcode >> 5) & 0x1f) << 16 | offset) << 2; diff --git a/target/mips/tcg/nanomips_translate.c.inc b/target/mips/tcg/nan= omips_translate.c.inc index 9d4e0bee81f..4b0b01ba37a 100644 --- a/target/mips/tcg/nanomips_translate.c.inc +++ b/target/mips/tcg/nanomips_translate.c.inc @@ -3551,7 +3551,7 @@ static int decode_nanomips_32_48_opc(CPUMIPSState *en= v, DisasContext *ctx) int offset; int imm; =20 - insn =3D translator_lduw(env, &ctx->base, ctx->base.pc_next + 2); + insn =3D translator_lduw_end(env, &ctx->base, ctx->base.pc_next + 2, m= o_endian(ctx)); ctx->opcode =3D (ctx->opcode << 16) | insn; =20 rt =3D extract32(ctx->opcode, 21, 5); @@ -3665,7 +3665,8 @@ static int decode_nanomips_32_48_opc(CPUMIPSState *en= v, DisasContext *ctx) break; case NM_P48I: { - insn =3D translator_lduw(env, &ctx->base, ctx->base.pc_next + = 4); + insn =3D translator_lduw_end(env, &ctx->base, ctx->base.pc_nex= t + 4, + mo_endian(ctx)); target_long addr_off =3D extract32(ctx->opcode, 0, 16) | insn = << 16; switch (extract32(ctx->opcode, 16, 5)) { case NM_LI48: --=20 2.53.0 From nobody Sat May 30 20:11:55 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1776400048; cv=none; d=zohomail.com; s=zohoarc; b=Hu3YRv9pCTZzQw9wQ5AhxaoDKwh9/dhjtzUrccyRvaCWXCvz+kJ44D8r1oNRfICpfgC+fPb18e2CpFYZuPjfFeZIrVjcGVTe19MwdRpRFae8eHqvbYLAk2tIHjvJ/M42y6sq8AFdad+DHkKpQhIyJB2EbkYd+09ocDEzrZ+oQyA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776400048; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=FOkTJe5q76NlJ9pYBZFYxgrP1+yuHZk0NW640n8cnlQ=; b=Zw+pXOUI2t6yr6VZLHNRWyoK/B79tvlfwzZpkJuNHvj5uMegx4Yzexu3bdIZ23xsjvIifB2ioWusWmKYYAh30EJgCA3O31aIodP6gvlkE55qkmlRxmYNxEe29BmZVNFqBast7C6nEwabf0/A6Nr9UXg4s0s/xTDDcvGZ70pTTps= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776400048578441.8123432547211; Thu, 16 Apr 2026 21:27:28 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wDanB-000616-EX; Fri, 17 Apr 2026 00:26:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wDan9-00060i-7l for qemu-devel@nongnu.org; Fri, 17 Apr 2026 00:26:55 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wDan7-0006OC-GQ for qemu-devel@nongnu.org; Fri, 17 Apr 2026 00:26:54 -0400 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-488ba6366a7so2629835e9.0 for ; Thu, 16 Apr 2026 21:26:53 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc1c0354sm10873215e9.11.2026.04.16.21.26.49 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 16 Apr 2026 21:26:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1776400012; x=1777004812; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FOkTJe5q76NlJ9pYBZFYxgrP1+yuHZk0NW640n8cnlQ=; b=N8rCzIc0CXH/5ZJD9uYdpeCP+rkShRQ8Afj7eY1e/2MPjaUYbOgnYWf8fN2bnQ7LAt uyqMPJOMejscTVENCqECFVVcU6Vsxidgs2/U2e88H11sapNL6lSXXyb5/G96CAeEDZcf Vl5LmxnAr971ewgLbdVMxDyj/IDRoVVdlPkPkDd3lYs2SdfX5DtzPys0zfeo1/Gn2qDC 47VcAK0ujt0fr/VlAamKi2Bp7X1GXmJ21NGEOSptphVLNEgeZJcTp73VuNnT31dSmEH5 vYXr64N1GcFgprTSJ4Vc1rnBy6t4lLsl43VaMnI00usgX/MhWjTS5SvvLss3zJeIdg+g xG8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776400012; x=1777004812; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FOkTJe5q76NlJ9pYBZFYxgrP1+yuHZk0NW640n8cnlQ=; b=LUKQv7/1fSO6CiAyinDlwB4P9ZjVg5DGcEGZVwqUxV9yR1v6aD4BMEk1ocRV6MUjLQ GgULM4FjBQqM5af55sBA1XBZKbbw//hHxGS5ZUcs/FQ9dfqTGeKWU4epvmhj5cu0G78+ Cr69NgJF/B0WzsT69T1Jfv5VhVUld6e9HMNAwWPuuBmvQHTbV1ylEH+4lmLsfHjLaJxf KUtQjhy8LxI0+uFQGeZlQNZZyLGwEiLpyxz6Y7iRA0+RyeHYz1hYewo20QOgVvo6Zsmy xVf0m7Mo8SFgMZKkUjrvJxmR5teey0kdFT8veU6FXfGZ8cV6lLNc6JexuJ2vjEGQ6ANR MaMw== X-Gm-Message-State: AOJu0YzooszT8pzPqlIfykuVPw6kQkeUmk6fjgsdbSVo0ZofVZwZE1oJ Inxptd5wLm/GLiLGwyzUfpkQBOR8PxgU7ThhjThNmqUhb89G3i+VGjFlbQSxc+SgpzbqvteY4bc JLtQxlXo= X-Gm-Gg: AeBDiese4b6coBU++Oy60pWNo0xzhwXX9n3y+uPDdDWoVRbz/rH/Idqq6EYM4Fsua/c c8nPEPDYi5wdNEURgANbLx4u1Z8voVc48bRdUFmKg6yO4A2cepl5MrzXwwik/yBt9s0zXt+0q31 CgHBZCYEgi11tLv9N7rGaZbbsGnGxjIzpz7OAoGngL985wLuvDnNFvsvsOUxlXj7FPz9AZhsAtT u2LiaDKWt9pjCqC0GiqATP9UOzNO1BrGwYGNZ2NdPcFu4s0+g/+OSNQBq8btxReXu3V6zuxrLLc VGPRZgzASEQsAOK+lkwDSOGPDIbeOdI6zS8dsL9aO7wqYcL5LE15+BsYAH7pYWf7jouBogL4fxF aQ1Z3cZiAmICNqirtnEkl60c9wH/2q+smvCKv8N8EcIFQJ/K61GQwlrOGghN7LJDGxuUS/s88YX n16+BLQIcI/if6tp7itJSNHKqNYHK4DLG8V1JebSPRUlX8OrIfmBWCOu9NErR6Y/D+s83iVBYsB yWSr0yU2OM= X-Received: by 2002:a05:600c:33aa:b0:488:ae6c:42c0 with SMTP id 5b1f17b1804b1-488fb742e7fmr9370165e9.7.1776400011742; Thu, 16 Apr 2026 21:26:51 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Aleksandar Rikalo , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH v6 4/4] target/mips: Remove last MO_TE use Date: Fri, 17 Apr 2026 06:26:19 +0200 Message-ID: <20260417042620.35329-5-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260417042620.35329-1-philmd@linaro.org> References: <20260417042620.35329-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1776400049815158500 Unfortunately commit 54821ff6e90 ("target/mips: Convert mips16e decr_and_load/store() macros to functions") got rebased on top of commit 2803e24694c ("target/mips: Replace MO_TE by mo_endian") and we missed the replacement. Fix that. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/tcg/mips16e_translate.c.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/mips/tcg/mips16e_translate.c.inc b/target/mips/tcg/mips= 16e_translate.c.inc index beb5b04ea29..e83587971d4 100644 --- a/target/mips/tcg/mips16e_translate.c.inc +++ b/target/mips/tcg/mips16e_translate.c.inc @@ -293,7 +293,7 @@ static void decr_and_load(DisasContext *ctx, unsigned r= egidx, TCGv t0) =20 tcg_gen_movi_tl(t2, -4); gen_op_addr_add(ctx, t0, t0, t2); - tcg_gen_qemu_ld_tl(t1, t0, ctx->mem_idx, MO_TE | MO_SL | + tcg_gen_qemu_ld_tl(t1, t0, ctx->mem_idx, mo_endian(ctx) | MO_SL | ctx->default_tcg_memop_mask); gen_store_gpr(t1, regidx); } --=20 2.53.0