From nobody Sat May 30 20:11:36 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1776398296; cv=none; d=zohomail.com; s=zohoarc; b=RR/g95z2OkPZE4E2Rc3UJgBVX59cO+aRoZ5hNpKT7qBJpBrFW9X0Dby5ywLpT9ZsihlvkU/84vzRzH4G+Pc81BSNhXephNeqGg7UL+H9icNWLRo2kFilBoZ80UsVrvzK2vFig5aCIrPzd7c0LCd2c+cBm8MW8O0xxCnsrMHSyhY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776398296; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=6FrY0N+MlqE1VqAmJP5+zOpwJgQamw0o/zYm1s6GqUI=; b=H4F2C/hZC0g1/PdPrMOeWNIaieqy2Os6VuPW+IQuqv371Jk/zeRt8UbBsu223VfhfGZqqV9aadLE6bdSOelCKQ3xCIp1PvNORFa00GYaVkekpa+8UeYLbPTNJncCzkEQ70bYt6tFz2vE7Xp/Ckf+C67gVFNckkZ1zYRAb7qUMbc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776398296175158.8381191975751; Thu, 16 Apr 2026 20:58:16 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wDaKy-0000AV-RF; Thu, 16 Apr 2026 23:57:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wDaKx-0000AK-Pz for qemu-devel@nongnu.org; Thu, 16 Apr 2026 23:57:47 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wDaKw-0001Dz-7J for qemu-devel@nongnu.org; Thu, 16 Apr 2026 23:57:47 -0400 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-4887f49ec5aso2956895e9.1 for ; Thu, 16 Apr 2026 20:57:45 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fb7bd700sm6959855e9.31.2026.04.16.20.57.42 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 16 Apr 2026 20:57:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1776398264; x=1777003064; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6FrY0N+MlqE1VqAmJP5+zOpwJgQamw0o/zYm1s6GqUI=; b=lm3/nY0LB0UU+NxWyqZI13gnId6IZIdVemkRF4xaa8Rgw7xtrQoafZptNK1CzSrWex lCkXx92De89BlirjYnsUtyuE1P9Lty1A3n+QvFDZJUE8LMqOQbxaYU4tA6hYmVItfhf1 ZoD4q3CVUzESBxrA3zqT6K4w2pv71yYopW56A2yrq/VapxrLtWH5P8dlsWpfj8jTLxe5 Ke4MvJzVwhbAgxnRqxTSV3jG3NOx4XLmxhSbgDajoeQl+SXey1nBKzbIGxhPSQK2m9Qp mtsi1ZFXqQ5jlexjnLbUwOH3/2IKa60X1wp7vDzueTD8V7VrrMLhfz27+vLnMiRToRVc XOKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776398264; x=1777003064; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6FrY0N+MlqE1VqAmJP5+zOpwJgQamw0o/zYm1s6GqUI=; b=AWjd4N2LkbwUn8Ite7B0A+BW2p1MGzywCtPzntHOqp8FcE5YFE7gZQ7IkO+xSiTCj/ PvE8bTrkiXuItNTgrAbHwA0sGDc7PDmcH/O+MyPZMi46BXCenFQEK0JBpC88mgn6rkuW mh6Ex7OOhZv4m7zM8A5df9IrsGR0VyfKp1xshKO1mA91Rk9UpYP6JYkRGkGj1zsf8g/h 6516Kg8UortDQJzjKfTRgPN+v5MgtZyyKAoKfSJI2y5Tnl2LwfoHdjv8fv67eDETRVuv i8g5Z4Mwy+BBVWNW2soX8ZmAQKQIuodoFrR18YGXuxluhcOALasx8OE4034XaU3T0BZ2 uQBg== X-Gm-Message-State: AOJu0YzjNcjyaM9k0/FYZS9GihGTqbz72+JYgEBlenSdueFohfKsyjWe oAB4ywFpvWdT/1rEuZ6AtFFPouhJPGTMGJcChaW9kl2I03/EWzYrQ4KJ1BF7hqxMmqoDkRQqo4X EYIn0lNk= X-Gm-Gg: AeBDies8hFO+fH/OgUPAoSMlTsvFPkSgIr4r+zEHNA5tPhnR0t2jCrNAshvQX2zXwAM yC9n/lxtnW5iJJonGSA5qlrkI6lD57Y4zpqP4KYwzY4yT6CqUtSZwqVcrZfoVc6A8JnSiw7y4Gr lk8Xx+dj8lHEKPrLAmgS701/JBrexTQ1lM6EdHJLgS5zyeyUNb9iLR/yWziI6bG0IMG61pbuSi7 G+am6o4zvLyArazoImzsmK2iEklmYZ6K7K3y5tWn3sBh2Sb2/bkzRa4muhZ+0OIQUNJ4bw4eJ8Y qc/rPVsGQDa0BUynYEFEFKPfJOhGOrC1h/TzZPdyQZ97qnGLN/+EZt3cKAYbqw3Abx0TUmyAEQW 8+EwbMvyAjd2Bmvhx/g8NSuBh4YCCXRfFpIbc7ce2hJdsECBTKnLSPspJZxFYBifgZWF9pJ3dei 7IfJa63puYEtHv9bsiiRq4ng0AbEPVwfBvszNgAnMN0frcgrnbHxP1yuWosYaPfaCOdrgOGac2K Vsh9CpvwNE= X-Received: by 2002:a05:600d:13:b0:488:869c:edaf with SMTP id 5b1f17b1804b1-488fb7419c4mr10915175e9.8.1776398264331; Thu, 16 Apr 2026 20:57:44 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aleksandar Rikalo , Aurelien Jarno , Jiaxun Yang Subject: [PATCH v5 1/4] target/mips: Pass MemOpIdx argument to Load/Store Multiple helpers Date: Fri, 17 Apr 2026 05:57:31 +0200 Message-ID: <20260417035734.32334-2-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260417035734.32334-1-philmd@linaro.org> References: <20260417035734.32334-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1776398297904158500 In preparation of using the MemOp content in the next commit, pass it as MemOpIdx. Include the access size. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/tcg/ldst_helper.c | 16 ++++++++++++---- target/mips/tcg/micromips_translate.c.inc | 16 ++++++++++------ 2 files changed, 22 insertions(+), 10 deletions(-) diff --git a/target/mips/tcg/ldst_helper.c b/target/mips/tcg/ldst_helper.c index 4ebf72d610e..7be2cad89d6 100644 --- a/target/mips/tcg/ldst_helper.c +++ b/target/mips/tcg/ldst_helper.c @@ -224,8 +224,10 @@ void helper_sdr(CPUMIPSState *env, target_ulong arg1, = target_ulong arg2, static const int multiple_regs[] =3D { 16, 17, 18, 19, 20, 21, 22, 23, 30 = }; =20 void helper_lwm(CPUMIPSState *env, target_ulong addr, target_ulong reglist, - uint32_t mem_idx) + uint32_t memop_idx) { + MemOpIdx oi =3D memop_idx; + unsigned mem_idx =3D get_mmuidx(oi); target_ulong base_reglist =3D reglist & 0xf; target_ulong do_r31 =3D reglist & 0x10; =20 @@ -246,8 +248,10 @@ void helper_lwm(CPUMIPSState *env, target_ulong addr, = target_ulong reglist, } =20 void helper_swm(CPUMIPSState *env, target_ulong addr, target_ulong reglist, - uint32_t mem_idx) + uint32_t memop_idx) { + MemOpIdx oi =3D memop_idx; + unsigned mem_idx =3D get_mmuidx(oi); target_ulong base_reglist =3D reglist & 0xf; target_ulong do_r31 =3D reglist & 0x10; =20 @@ -268,8 +272,10 @@ void helper_swm(CPUMIPSState *env, target_ulong addr, = target_ulong reglist, =20 #if defined(TARGET_MIPS64) void helper_ldm(CPUMIPSState *env, target_ulong addr, target_ulong reglist, - uint32_t mem_idx) + uint32_t memop_idx) { + MemOpIdx oi =3D memop_idx; + unsigned mem_idx =3D get_mmuidx(oi); target_ulong base_reglist =3D reglist & 0xf; target_ulong do_r31 =3D reglist & 0x10; =20 @@ -290,8 +296,10 @@ void helper_ldm(CPUMIPSState *env, target_ulong addr, = target_ulong reglist, } =20 void helper_sdm(CPUMIPSState *env, target_ulong addr, target_ulong reglist, - uint32_t mem_idx) + uint32_t memop_idx) { + MemOpIdx oi =3D memop_idx; + unsigned mem_idx =3D get_mmuidx(oi); target_ulong base_reglist =3D reglist & 0xf; target_ulong do_r31 =3D reglist & 0x10; =20 diff --git a/target/mips/tcg/micromips_translate.c.inc b/target/mips/tcg/mi= cromips_translate.c.inc index 8fda7c8a214..4dca11b84b4 100644 --- a/target/mips/tcg/micromips_translate.c.inc +++ b/target/mips/tcg/micromips_translate.c.inc @@ -693,7 +693,8 @@ static void gen_ldst_multiple(DisasContext *ctx, uint32= _t opc, int reglist, int base, int16_t offset) { TCGv t0, t1; - TCGv_i32 t2; + MemOp mop =3D MO_UNALN; + MemOpIdx oi; =20 if (ctx->hflags & MIPS_HFLAG_BMASK) { gen_reserved_instruction(ctx); @@ -705,22 +706,25 @@ static void gen_ldst_multiple(DisasContext *ctx, uint= 32_t opc, int reglist, gen_base_offset_addr(ctx, t0, base, offset); =20 t1 =3D tcg_constant_tl(reglist); - t2 =3D tcg_constant_i32(ctx->mem_idx); =20 save_cpu_state(ctx, 1); switch (opc) { case LWM32: - gen_helper_lwm(tcg_env, t0, t1, t2); + oi =3D make_memop_idx(mop | MO_UL, ctx->mem_idx); + gen_helper_lwm(tcg_env, t0, t1, tcg_constant_i32(oi)); break; case SWM32: - gen_helper_swm(tcg_env, t0, t1, t2); + oi =3D make_memop_idx(mop | MO_UL, ctx->mem_idx); + gen_helper_swm(tcg_env, t0, t1, tcg_constant_i32(oi)); break; #ifdef TARGET_MIPS64 case LDM: - gen_helper_ldm(tcg_env, t0, t1, t2); + oi =3D make_memop_idx(mop | MO_UQ, ctx->mem_idx); + gen_helper_ldm(tcg_env, t0, t1, tcg_constant_i32(oi)); break; case SDM: - gen_helper_sdm(tcg_env, t0, t1, t2); + oi =3D make_memop_idx(mop | MO_UQ, ctx->mem_idx); + gen_helper_sdm(tcg_env, t0, t1, tcg_constant_i32(oi)); break; #endif } --=20 2.53.0 From nobody Sat May 30 20:11:36 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1776398296; cv=none; d=zohomail.com; s=zohoarc; b=NYJ1T7kXUIJOxyMw2qIKqaJ9IndV3df8laeOBylm+pTJR/14mH54piCx7Th7vYbqNQTcB9hrUMixzqOstPgMWNFU/n3t1PLJ2wim0pfDoGuq5DjZn9r1T0z8Oqjld8EQri7vy1BrNSNxL8SpZgOX4hBAa9YKk5yhSdRn1NHJX+I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776398296; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1wvsgcQ/M31Z4/UMXnX5x+3B1m7b5ZzzUe0LHeA1Em4=; b=ggr0lW/Z3a6JxB4Zao31rbTSpZL+74uYCaEH18vtkSybA0Wzk1EwgwPuh4FqRXfEJQXgRHCZkSzLi4Xx5+6nMna9XPRQOHYHKUdFlTNQICvecuLTwIxGAPDevGuevbO5qva81Zs1zT3WK3h9/eS2ab89RhBvDu8FFbfqCzbgQQo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776398296465315.4117901604934; Thu, 16 Apr 2026 20:58:16 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wDaL6-0000C1-NE; Thu, 16 Apr 2026 23:57:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wDaL5-0000Bc-B3 for qemu-devel@nongnu.org; Thu, 16 Apr 2026 23:57:55 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wDaL3-0001Eh-Mm for qemu-devel@nongnu.org; Thu, 16 Apr 2026 23:57:55 -0400 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-488b8bc6bc9so1136895e9.3 for ; Thu, 16 Apr 2026 20:57:53 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc0f8193sm11083345e9.1.2026.04.16.20.57.50 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 16 Apr 2026 20:57:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1776398272; x=1777003072; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1wvsgcQ/M31Z4/UMXnX5x+3B1m7b5ZzzUe0LHeA1Em4=; b=GnrrIL0ea52TEIcIAIV8RP9exf7ysxiXaETXVxAuKEuroV6SgDVyiGJfzhu2AsTvXa sQqZVgYNcu1UArD3G/adzBarT15Iycst8Y3742C1AI/mL2DhB5Z0kIQ6igWPlhpzXLcx JUuYDM47TMtoQBY2RKjbhFJ804F8TSFIdxL0oD92TqFE28Bekd48Bd9+6nEGkZmiT3iz EsxMLZmN9SEd+jDMpo4j14U98nr25MJR4dAdIQ2oyNd0/+KNtnokc/55HBS/H5DPhJs3 n19bG4D9QkeQALwNBjKcqgKj4BjYA3+/pRqvQ7F3fKDXgD7KqBx/UaeG7VNhNHJiOu1I jJJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776398272; x=1777003072; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1wvsgcQ/M31Z4/UMXnX5x+3B1m7b5ZzzUe0LHeA1Em4=; b=OX7qVwm2tO5YgNkqXRA59bTBgO3s83+DK7flsogZDDMtHxL3pNZ/cKYUiimqewXKbQ yaeoHIlyzX8XUUzpaYT7YXB95dBzZ3Sdt1nf9sx4G4ATNobmvpBHNFIxfQcfIYppf2kU z7gEwJ8n42pgqZHwgw5EVfABxoUcGbUtxgOqobdG+uR+1gdIQmTwwNFZfvjRaK9XvNcw ExJamjKBosgB0arDSMIFPPCu1dJZL7i9KESRMN7PT/wkLLzHXm9tCxFol/cREFTxT/E2 qZucIPJZlHf+z+k+Xca+oA7nsZbxnz/JSkBmisnWDgUVWg5LKmjFOX6he0nKM2k0VeKX RfrQ== X-Gm-Message-State: AOJu0YzYDB1mUeKoLlTCVs44mibuoFNohdYpDHNo0Jd44VAsPOtvf0BG ktMwrEf8zRHfxkxJAgNZVAdRn0Isx/bq8s17+t254lx3rxZKfhisvo9gVQ78+LR06iaywzpjyCh WkeW8UBk= X-Gm-Gg: AeBDietr9haFtaHc6GgqYS8tn8f2MT49TrsbBkqMIcuqCQQMMyvmXp8w9PXToOmVW4o qNvtMT/6ZJ3f2/hKPnwNzHO+7AhVvvQwS/cxFM6oOxMO6RblUWZvv0JQWG0P3azUyZ4WyPtqJdt qY/Jt3ebr1+NXS7j5KTcoHGrH3h/xnd3ak0FTQE9ipOL4fiNVUwrHf7t8eAXNLVwSTn36DiZukz y0ZMPne74hMei2v6n1fnXzB2X4QgONdDznnEad2uPRPhQnVn1jaCn3vR/pw0GoSXSXllAF0QtW5 8v7h4TYuR5YJBgsn4ITFL7/xUH8pOJyfmlNQh7Nfk86AgcB+lOqsBIzWbHrVPrI7HJgmpS+zE+I sOW1eRzCNsj1mo2ndZfxQ/rrSL/VF4n6zad5rr9UNRRTb8fMOtGIKa0Vk+nI9cthU+2b6VNbmON 9vQC3VdtNv/bI5eoOLZWG2q5hxPi3K/ylHtKeS9xlw0/sClSU6JCTIjSs4X7sO50ASqNJ+ht+D+ BfDfVFMz2E= X-Received: by 2002:a05:600c:8207:b0:485:3193:6ddb with SMTP id 5b1f17b1804b1-488fb73cf74mr15430345e9.3.1776398271918; Thu, 16 Apr 2026 20:57:51 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aleksandar Rikalo , Aurelien Jarno , Jiaxun Yang Subject: [PATCH v5 2/4] target/mips: Remove unnecessary target_ulong uses in LD/ST Multiple Date: Fri, 17 Apr 2026 05:57:32 +0200 Message-ID: <20260417035734.32334-3-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260417035734.32334-1-philmd@linaro.org> References: <20260417035734.32334-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1776398297908158500 @do_r31 is a boolean, @base_reglist an unsigned size and @i an unsigned index. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/tcg/ldst_helper.c | 32 ++++++++++++-------------------- 1 file changed, 12 insertions(+), 20 deletions(-) diff --git a/target/mips/tcg/ldst_helper.c b/target/mips/tcg/ldst_helper.c index 7be2cad89d6..07a4aa99bae 100644 --- a/target/mips/tcg/ldst_helper.c +++ b/target/mips/tcg/ldst_helper.c @@ -228,13 +228,11 @@ void helper_lwm(CPUMIPSState *env, target_ulong addr,= target_ulong reglist, { MemOpIdx oi =3D memop_idx; unsigned mem_idx =3D get_mmuidx(oi); - target_ulong base_reglist =3D reglist & 0xf; - target_ulong do_r31 =3D reglist & 0x10; + unsigned base_reglist =3D reglist & 0xf; + bool do_r31 =3D reglist & 0x10; =20 if (base_reglist > 0 && base_reglist <=3D ARRAY_SIZE(multiple_regs)) { - target_ulong i; - - for (i =3D 0; i < base_reglist; i++) { + for (unsigned i =3D 0; i < base_reglist; i++) { env->active_tc.gpr[multiple_regs[i]] =3D (target_long)cpu_ldl_mmuidx_ra(env, addr, mem_idx, GETPC()= ); addr +=3D 4; @@ -252,13 +250,11 @@ void helper_swm(CPUMIPSState *env, target_ulong addr,= target_ulong reglist, { MemOpIdx oi =3D memop_idx; unsigned mem_idx =3D get_mmuidx(oi); - target_ulong base_reglist =3D reglist & 0xf; - target_ulong do_r31 =3D reglist & 0x10; + unsigned base_reglist =3D reglist & 0xf; + bool do_r31 =3D reglist & 0x10; =20 if (base_reglist > 0 && base_reglist <=3D ARRAY_SIZE(multiple_regs)) { - target_ulong i; - - for (i =3D 0; i < base_reglist; i++) { + for (unsigned i =3D 0; i < base_reglist; i++) { cpu_stl_mmuidx_ra(env, addr, env->active_tc.gpr[multiple_regs[= i]], mem_idx, GETPC()); addr +=3D 4; @@ -276,13 +272,11 @@ void helper_ldm(CPUMIPSState *env, target_ulong addr,= target_ulong reglist, { MemOpIdx oi =3D memop_idx; unsigned mem_idx =3D get_mmuidx(oi); - target_ulong base_reglist =3D reglist & 0xf; - target_ulong do_r31 =3D reglist & 0x10; + unsigned base_reglist =3D reglist & 0xf; + bool do_r31 =3D reglist & 0x10; =20 if (base_reglist > 0 && base_reglist <=3D ARRAY_SIZE(multiple_regs)) { - target_ulong i; - - for (i =3D 0; i < base_reglist; i++) { + for (unsigned i =3D 0; i < base_reglist; i++) { env->active_tc.gpr[multiple_regs[i]] =3D cpu_ldq_mmuidx_ra(env, addr, mem_idx, GETPC()); addr +=3D 8; @@ -300,13 +294,11 @@ void helper_sdm(CPUMIPSState *env, target_ulong addr,= target_ulong reglist, { MemOpIdx oi =3D memop_idx; unsigned mem_idx =3D get_mmuidx(oi); - target_ulong base_reglist =3D reglist & 0xf; - target_ulong do_r31 =3D reglist & 0x10; + unsigned base_reglist =3D reglist & 0xf; + bool do_r31 =3D reglist & 0x10; =20 if (base_reglist > 0 && base_reglist <=3D ARRAY_SIZE(multiple_regs)) { - target_ulong i; - - for (i =3D 0; i < base_reglist; i++) { + for (unsigned i =3D 0; i < base_reglist; i++) { cpu_stq_mmuidx_ra(env, addr, env->active_tc.gpr[multiple_regs[= i]], mem_idx, GETPC()); addr +=3D 8; --=20 2.53.0 From nobody Sat May 30 20:11:36 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1776398301; cv=none; d=zohomail.com; s=zohoarc; b=KNLYuxKz9GvIKBMlzVDA2vvJl6mb1Ps7Snpif9EI4nZfJhvw3ZWHq59Vlg3qRGtFc3Af1m3XUxFL/n5EgKUA7LwwVJ346NfQoJNiSCNCAuW90tWnzU/N4xiVPGLzjqfcwCqT90d8nWvJV0EGZK4qjWfdzIceAxTPh4tD9bXB9kE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776398301; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=DuGg9pUZL3Gz2qa48QcSeTXKXs/rKf7aigVuhjjWHME=; b=FAPGeu+ngBjxC6v80WyXApCF0HXWQnCOE2BmHaBMk4J2mZcqKLyfV6tvzGo/31h6KICH0aWoqM4xA7IT09m01LQvVgdK6JLDRFttrWLuMh1F/lfGbqEDALWKKaGJYsVMkYvTAgc6wpWD486NdktVKstaKXc1TUKA+fiDwnBvuMg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776398301529893.9555934925719; Thu, 16 Apr 2026 20:58:21 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wDaLE-0000CX-3q; Thu, 16 Apr 2026 23:58:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wDaLC-0000CI-Af for qemu-devel@nongnu.org; Thu, 16 Apr 2026 23:58:02 -0400 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wDaLA-0001FP-NG for qemu-devel@nongnu.org; Thu, 16 Apr 2026 23:58:02 -0400 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-488aa77a06eso3805095e9.0 for ; Thu, 16 Apr 2026 20:58:00 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc181c6dsm11066225e9.6.2026.04.16.20.57.57 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 16 Apr 2026 20:57:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1776398279; x=1777003079; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DuGg9pUZL3Gz2qa48QcSeTXKXs/rKf7aigVuhjjWHME=; b=nGhfy2f0Ykpba5PvPyFSS7YBXDU9IBDJfD7kzsFycd9YgFaA9+3BhFbFjG/P2rV3uD 7/VGWOuCb+ih6F0tMJIUWM4uMMWzoFjLpS/m6wsrVeo1UzzNKGm8ESO8OQagdiw0Et8q icgmZ960NbnREGLzxeLTTBADm944NcReXx6K8uz9CGaJp4IR+RbfmM6CPfbdNSrSNd64 UOdCuvLGRctDsqrjNmjoKML9rrRlfBdNmVg1Zf2CTIy1SlIJpJjkbiUidwPSv95W5tuE rm3PP/0PdYRIxYkZbSltLCaK5iWzqeH8C6jUXNq+QF9MyVR5+ruofJPwdAkEpFsedBrm sy8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776398279; x=1777003079; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DuGg9pUZL3Gz2qa48QcSeTXKXs/rKf7aigVuhjjWHME=; b=Jdq9Wpxok2+Kv4A4aVJFrZU6ZIF/4MXhHbwaW+nAP/5HiFXzR9nRZTSqhkpDx8P//S elFQuTHh7CnJJMSedS0tBih/T+8FLOyrHViPKeqzsyjcHFyEl7zdiwftWRuf4jlUQ/3m IHsx9CQgRmEZagtreSEQbakhI3gwPxBqLzT+LC7T3T+tQczjx51L8RMDi+hsKWEkWZp7 Bk4iH7Dc4FlGmShXtlBmzOts01wMQ+gTIU7EjK47hSJMYDCWjOejswBF9N9sXi3jV5et /FsCq1iNMDxikXmLMykVCOnh+BTx1g4d8BoS/e/+JQDPwexdubUbyvCo3ACJJaKyF1Cg tE6g== X-Gm-Message-State: AOJu0YxdwXPWntI3/y90XffbPuCAZhUJg8pfIbU2ry18bSpD9mIy/51O YaPkQZfudNFdiXuxJoLqXNHhoxYc+mOdN8lDitE3pUxWVktJ+5RT4LvuydQK/zlnZSXtNd9QS16 EJDOFBrI= X-Gm-Gg: AeBDiesoGtfXd9kxw4RMc7DHd2VC7e0s4FCv8dPFWdXzK2UNMBvGTMHQSUDTmYi/Ebn uMiJTpCkxgOX0ySCL+TpD4SRTnVSNXz018k+pWZly5CTCRDw9u31N/JrkGvlxu6yhyPdIdMxu6B eqeisPjliR7XRPvCp0WPDWu0roja/6aCHkYwQm6GNmbC/LuqSlAqIXSayi4JrqTam075qD3UG2V 9f9Gt3HXR1HlRxjZBHYtjfnWrLsbQlPJM1hGJBGPmNbbosvgdsOpu7/A2q+6NKQG3JTCGk766aC oY9f47WA9AMyDuaxfKIfEd91SsAajWE30r4uccMbyb/PnPNr3uxGxevMOYmpIzTF1dAAj523FBH GEmQyRi+M/ul0ZQc1QiOhmE7G3wiYupgftRkBFOc9rqGgbNMat28jEgyY0yIxizUS4LkThNcSan AN2mT6gn0aFv1rF3+2cJJnLhSkisEHtSn2H8mK8aYIOt22pHQviJCNgNj5dH6Nsuj3iEEiCfxqB Gfh0SbH9bY= X-Received: by 2002:a05:600c:64c7:b0:488:a2ac:a334 with SMTP id 5b1f17b1804b1-488fb73aa3bmr13217165e9.3.1776398278740; Thu, 16 Apr 2026 20:57:58 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aleksandar Rikalo , Aurelien Jarno , Jiaxun Yang Subject: [PATCH v5 3/4] target/mips: Inline cpu_ld/st_mmuidx_ra() calls in LD/ST Multiple Date: Fri, 17 Apr 2026 05:57:33 +0200 Message-ID: <20260417035734.32334-4-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260417035734.32334-1-philmd@linaro.org> References: <20260417035734.32334-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=philmd@linaro.org; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1776398303604158500 In preparation of removing the cpu_ld*_mmuidx_ra() and cpu_st*_mmuidx_ra() calls, inline them. Expand MO_TE to mo_endian_env(env) in gen_ldst_multiple(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/tcg/ldst_helper.c | 34 +++++++++++------------ target/mips/tcg/micromips_translate.c.inc | 2 ++ 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/target/mips/tcg/ldst_helper.c b/target/mips/tcg/ldst_helper.c index 07a4aa99bae..b3ea4f05192 100644 --- a/target/mips/tcg/ldst_helper.c +++ b/target/mips/tcg/ldst_helper.c @@ -227,21 +227,20 @@ void helper_lwm(CPUMIPSState *env, target_ulong addr,= target_ulong reglist, uint32_t memop_idx) { MemOpIdx oi =3D memop_idx; - unsigned mem_idx =3D get_mmuidx(oi); unsigned base_reglist =3D reglist & 0xf; bool do_r31 =3D reglist & 0x10; + target_ulong *gpr =3D env->active_tc.gpr; + uintptr_t ra =3D GETPC(); =20 if (base_reglist > 0 && base_reglist <=3D ARRAY_SIZE(multiple_regs)) { for (unsigned i =3D 0; i < base_reglist; i++) { - env->active_tc.gpr[multiple_regs[i]] =3D - (target_long)cpu_ldl_mmuidx_ra(env, addr, mem_idx, GETPC()= ); + gpr[multiple_regs[i]] =3D (target_long)cpu_ldl_mmu(env, addr, = oi, ra); addr +=3D 4; } } =20 if (do_r31) { - env->active_tc.gpr[31] =3D - (target_long)cpu_ldl_mmuidx_ra(env, addr, mem_idx, GETPC()); + gpr[31] =3D (target_long)cpu_ldl_mmu(env, addr, oi, ra); } } =20 @@ -249,20 +248,20 @@ void helper_swm(CPUMIPSState *env, target_ulong addr,= target_ulong reglist, uint32_t memop_idx) { MemOpIdx oi =3D memop_idx; - unsigned mem_idx =3D get_mmuidx(oi); unsigned base_reglist =3D reglist & 0xf; bool do_r31 =3D reglist & 0x10; + target_ulong *gpr =3D env->active_tc.gpr; + uintptr_t ra =3D GETPC(); =20 if (base_reglist > 0 && base_reglist <=3D ARRAY_SIZE(multiple_regs)) { for (unsigned i =3D 0; i < base_reglist; i++) { - cpu_stl_mmuidx_ra(env, addr, env->active_tc.gpr[multiple_regs[= i]], - mem_idx, GETPC()); + cpu_stl_mmu(env, addr, gpr[multiple_regs[i]], oi, ra); addr +=3D 4; } } =20 if (do_r31) { - cpu_stl_mmuidx_ra(env, addr, env->active_tc.gpr[31], mem_idx, GETP= C()); + cpu_stl_mmu(env, addr, gpr[31], oi, ra); } } =20 @@ -271,21 +270,20 @@ void helper_ldm(CPUMIPSState *env, target_ulong addr,= target_ulong reglist, uint32_t memop_idx) { MemOpIdx oi =3D memop_idx; - unsigned mem_idx =3D get_mmuidx(oi); unsigned base_reglist =3D reglist & 0xf; bool do_r31 =3D reglist & 0x10; + target_ulong *gpr =3D env->active_tc.gpr; + uintptr_t ra =3D GETPC(); =20 if (base_reglist > 0 && base_reglist <=3D ARRAY_SIZE(multiple_regs)) { for (unsigned i =3D 0; i < base_reglist; i++) { - env->active_tc.gpr[multiple_regs[i]] =3D - cpu_ldq_mmuidx_ra(env, addr, mem_idx, GETPC()); + gpr[multiple_regs[i]] =3D cpu_ldq_mmu(env, addr, oi, ra); addr +=3D 8; } } =20 if (do_r31) { - env->active_tc.gpr[31] =3D - cpu_ldq_mmuidx_ra(env, addr, mem_idx, GETPC()); + gpr[31] =3D cpu_ldq_mmu(env, addr, oi, ra); } } =20 @@ -293,20 +291,20 @@ void helper_sdm(CPUMIPSState *env, target_ulong addr,= target_ulong reglist, uint32_t memop_idx) { MemOpIdx oi =3D memop_idx; - unsigned mem_idx =3D get_mmuidx(oi); unsigned base_reglist =3D reglist & 0xf; bool do_r31 =3D reglist & 0x10; + target_ulong *gpr =3D env->active_tc.gpr; + uintptr_t ra =3D GETPC(); =20 if (base_reglist > 0 && base_reglist <=3D ARRAY_SIZE(multiple_regs)) { for (unsigned i =3D 0; i < base_reglist; i++) { - cpu_stq_mmuidx_ra(env, addr, env->active_tc.gpr[multiple_regs[= i]], - mem_idx, GETPC()); + cpu_stq_mmu(env, addr, gpr[multiple_regs[i]], oi, ra); addr +=3D 8; } } =20 if (do_r31) { - cpu_stq_mmuidx_ra(env, addr, env->active_tc.gpr[31], mem_idx, GETP= C()); + cpu_stq_mmu(env, addr, gpr[31], oi, ra); } } =20 diff --git a/target/mips/tcg/micromips_translate.c.inc b/target/mips/tcg/mi= cromips_translate.c.inc index 4dca11b84b4..fb107eb91fe 100644 --- a/target/mips/tcg/micromips_translate.c.inc +++ b/target/mips/tcg/micromips_translate.c.inc @@ -701,6 +701,8 @@ static void gen_ldst_multiple(DisasContext *ctx, uint32= _t opc, int reglist, return; } =20 + mop |=3D mo_endian(ctx); + t0 =3D tcg_temp_new(); =20 gen_base_offset_addr(ctx, t0, base, offset); --=20 2.53.0 From nobody Sat May 30 20:11:36 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1776398320; cv=none; d=zohomail.com; s=zohoarc; b=M89UdWYLr5Y3l3HHNBP5h4KFWI/C4ENTJR9slKGcH1BMWRZr3Q1kswRoQXdpeyiRB79uJMTiUWghlotvFxgqUrGL0/CA+/+L4uZypDG9XYBvi4TMTTR0gdeoVhO1O9mJzPU6PrzEg+qXgI3si5XuBQvAMZHIWulsK1uQ/7VOzOw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776398320; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=KYn7MiYiIimHUCCwf9g8QaU0c9vwpWnSWkhJsSMHx20=; b=UXrCTN2MK/cLpLbRsnWLcgxuBFODiEvCuoLICW93UFFODno48sbaLUClJ+WWM6bx//rV5jY4vUTVc/LMCh7umbD4TAD2tJX19d1krMarYb3n2XS0/rhCtNwEo8P3uHM/2/qRFrLWAfsNVNLpJ4PdfX9H2YzAmSMQT7J3eqNYPVE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776398320284710.7174466783282; Thu, 16 Apr 2026 20:58:40 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wDaLK-0000E0-9l; Thu, 16 Apr 2026 23:58:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wDaLI-0000DT-Qd for qemu-devel@nongnu.org; Thu, 16 Apr 2026 23:58:08 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wDaLH-0001Fy-F9 for qemu-devel@nongnu.org; Thu, 16 Apr 2026 23:58:08 -0400 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-488b8bc6bc9so1137385e9.3 for ; Thu, 16 Apr 2026 20:58:07 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc0f8188sm10761015e9.2.2026.04.16.20.58.04 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 16 Apr 2026 20:58:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1776398285; x=1777003085; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KYn7MiYiIimHUCCwf9g8QaU0c9vwpWnSWkhJsSMHx20=; b=rJ1/gILGLn+h6MFLok7Yx+dO0D5EVsViemqhRsLbk3w/OV/uWQhWlCfpNFTvtm8K/b zlKgsKMVjwXnGuWcBqvEzIDMw5EI0VWB9zCIObFZ7J1oJcYqf76dLP3uZ9IWEjcuCtvk olIfOFWAdEaCgjXiTqxTHLcoxNUVSa6GYo96+8isxz615w4mOx2t7QQnz2ZChAcZ4EcK FjKpLt8RijzPMM95u0oL4dyojVRKyU9LAnL0yUPpTFSPR2WtvHrebrGuT4MRVmxqa8cr ZWnnLSPDoTW50o1VZmguVNfUTbO/0edmXwSd28J74qkJmiM70GfQaJsmF4gre2+WYuko Bjwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776398285; x=1777003085; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=KYn7MiYiIimHUCCwf9g8QaU0c9vwpWnSWkhJsSMHx20=; b=Jff0eXxM5h/HtJdz4g582Rw72XXY8sbn8UUVYnoWx8gYe0opBoO47uOySfIA31r/dV iAVQOOXn3m1+4lntmjxIwqVWwL5BkDfRyZ254bMgCCGxDKpV4Fe4zVPxZEIav7pKoJ1E 2GqneABBh70vAvo2UpqpArc1U+MbfElsa71r1RPFh5kIgIx/bewkwLTfqYJOLPTUWPCr j3C4HamZHAJEGap7bSrvLjjKBn6BHE5uaYzyTlKOTmI9qjWQ//r3XXiFZ8OmB+GJWKNc MbGwGxVQz0R7sMVoaNQRNgYxz3tm93OuQ9+Jjjew8VpzsSangGAxnoQVBUk774kDDz7c yJ+A== X-Gm-Message-State: AOJu0YwJvKLoNAlcCoajC2a8w2FLA21N6DOAUervSjX5U6k/Dc+Ucb1m J7nQBLhqhzeFilUSSHEG0n8zjmPxWNCsR+to+VcvqHKI6RBl2eSPpxBHIHxVNn6bjVkvX+5g1Q3 LRlgWQQI= X-Gm-Gg: AeBDieu8jyCS2yVu3w+ywZW1aYVexkeihdtV6ZRElft4BZTB9UeTpJM8NlDIqdeFNiI rcim1Mdogg50JThEPHcyhwv/QD81Jv5LEb9/AjMmoogABSTJzLDgNL7OOCYKAIBPaU79+AVy55X dO5fnjAqulW5+gV99dj1nHz2xGDv/CdRIJ8icHiQN1YIEP2hiabNqss2JotIU7OlhLaM+2o4s/b EZV01D1cC4jBW+e1GxGvYjcUbAXaGMsCqWobDq0lLap9Gsdcrw/QN7e+TEgN0GYWsR+Y5C36FVy 87k597iCtea+DPtuZvUuUIUo9QPvy/7Ke0IxVNuvA1vi2zd0ljoifS2d8xCN8SpzhddIOdV49E1 1Eb4Cm94szYF/B0yN2xonvXs3Ta556YpH0CJ9Zw1f/Yi1bL6CbGCF+nWsdsTCAZEWS9uPpj0Aao VUa96D7VAjACJGNke6m1CrONGYbSLwLP5p/imI252Fw79LCNX+2xwVTBpaJBQmjX5V8s4RDZoXb X5Upk0342Q= X-Received: by 2002:a05:600c:8183:b0:486:fd5c:2b35 with SMTP id 5b1f17b1804b1-488fb750809mr13146045e9.13.1776398285585; Thu, 16 Apr 2026 20:58:05 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aleksandar Rikalo , Aurelien Jarno , Jiaxun Yang Subject: [PATCH v5 4/4] target/mips: Check alignment for microMIPS pre-R6 LD/ST multiple Date: Fri, 17 Apr 2026 05:57:34 +0200 Message-ID: <20260417035734.32334-5-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260417035734.32334-1-philmd@linaro.org> References: <20260417035734.32334-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=philmd@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1776398321486158500 Pre-REL6 microMIPS requires alignment while REL6 microMIPS does not. Use @default_tcg_memop_mask in gen_ldst_multiple(), it is set to MO_UNALN for REL6 but MO_ALIGN for pre-REL6. Fixes: 3c824109da0 ("target-mips: microMIPS ASE support") Reported-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- Good enough until making it explicit in a decodetree conversion. --- target/mips/tcg/micromips_translate.c.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/mips/tcg/micromips_translate.c.inc b/target/mips/tcg/mi= cromips_translate.c.inc index fb107eb91fe..da2419792eb 100644 --- a/target/mips/tcg/micromips_translate.c.inc +++ b/target/mips/tcg/micromips_translate.c.inc @@ -693,7 +693,7 @@ static void gen_ldst_multiple(DisasContext *ctx, uint32= _t opc, int reglist, int base, int16_t offset) { TCGv t0, t1; - MemOp mop =3D MO_UNALN; + MemOp mop =3D ctx->default_tcg_memop_mask; MemOpIdx oi; =20 if (ctx->hflags & MIPS_HFLAG_BMASK) { --=20 2.53.0