From nobody Sat May 30 20:11:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1776290214; cv=none; d=zohomail.com; s=zohoarc; b=l/nh6FQRdeH6sm9LXxD4MqczGUi/d5h31paU6HsGcMO7KywHZEKNZbzsJqaARuf+hjywnL6cqnqSwraVHGXfxcf6x9/OmYJXvxZrZwwziUvTyFML12r5S5v1kqgCxIH8hZrzYXxn9s3V+/vBEwYpnkoBa3L+Ub14nWS143Qs4VI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776290214; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=VuzviMl1wmLNCePSminxPRECrcBokMjkzSTP18yd1OY=; b=ThjNJ27ZY2B1jy4wEB43OTJPbGCeO+ViBIVkXoOw9W9lx9WIHVzN3TfPv40ipzDNF/oacqyX2EqVoIDcjRgCknBvo7x8dJ8tPed+CvCkKTSmFIghSYM/d+dWk64f9pjaHFZ9bWiEKWE6bO5W3U009JI3hSBrbUQzFDjZRc0et8g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776290214623365.11083204096144; Wed, 15 Apr 2026 14:56:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wD8DE-0002DY-Qh; Wed, 15 Apr 2026 17:55:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wD8DB-0002BI-8g for qemu-devel@nongnu.org; Wed, 15 Apr 2026 17:55:53 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wD8D9-0002cy-16 for qemu-devel@nongnu.org; Wed, 15 Apr 2026 17:55:52 -0400 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-4852b81c73aso68085395e9.3 for ; Wed, 15 Apr 2026 14:55:49 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488f5813954sm651235e9.3.2026.04.15.14.55.47 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 15 Apr 2026 14:55:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1776290148; x=1776894948; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VuzviMl1wmLNCePSminxPRECrcBokMjkzSTP18yd1OY=; b=pD98zgRopECYuPYK/ack7Mbgy/S61amnk5yVpz9Z9Ic93O9pJV+Sma9oMs/Cucy9Hz vU4EwX+eUQP+bHzsgGnNqI7xorveQAZjJYFwsX1op2eeG7s2ktSjLpBmYfHSnUU36fDp s9cUjhIpMBm5ElGKZX7qw1bRLbOU4MIhTZckdZ6Xvu9RkNNYMYhGTVUIMRPAY85vacoG DTmYDGjXKhB0yFNm3RhgnfJDe/l0Qrikmat0nW0ftdb/U8n7qYcEnbihlJQm+j9jH/+h DaEqnxxvTy5bz2RxnLZwcMp4IyzlWjRegngTZBi/XTdk32SsOG65nXXqcCB9utwKxwW1 LVnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776290148; x=1776894948; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VuzviMl1wmLNCePSminxPRECrcBokMjkzSTP18yd1OY=; b=NGV8zlX7DIi8C3iWp+MXwpg6UHHmECSlKqj6csd4IjMPKheJV9Rm0udA41jqdYpg6Z oV9zoCxcH6dKBHIRnQ6OHz3ac65ElEP/RgaOaCp1FO817Ujt9gD7Af/IoABC55A3+GU2 jlgYgDghsUypO1+QhD5xc6pV88IAL+NHGJ4o4WS/dGKMIWc5AqQ3aRB2rWJhiHp9JoPD AwUBQZuniUFZDOzwZm947/Ic/81wtIyZcZIJfzu1o4ocFGPz6pZUD4LpjZWOc4VvXizW qk2JjaXoqKKL0+EPhjM9hZPPpwE9/ZaekjerCD9vKs12lOmpRWOJCH9Jg/z1yQbuaO+O wcWQ== X-Gm-Message-State: AOJu0YxTyOpALu9INZxszORw11NHCxdsOhn2iDZXc3sqZFxAvXW2LorO HoyS0ZJHpe/K8jO0IJtJbY+ZZBbxXzr/AxYeGLCICZRhewCEeo4JfFO9ZYk6jr/9zRhV4XjA7jI AMl6Eyag= X-Gm-Gg: AeBDiet+ub2UF6Q11riSEZ9Y/9+e85V0V7u+brXAsDmnqcACIY4q+4ki6MG2Euq3+MI CPyQaFXA7ksA42xXXmc5PAzY/jwIZqpRbBCd0bNr2Mbdxh83reZgAuXq5MfOpCXqtRTtrPLjGCn jeBLlqMfXU2dQsNFBoylGsdm3WFqT2uSMgwBQsCFJ2jcmi181+sSwd2vzjKV7QzjEsSA/aLIHfI e2yHSUAwWZZZTPrguEwgycGhyVFs0OOzY24Jq14SDzHmdepQV/uVkhAhc1LIIrEYP/bo9Xp2gko P/GD4LcJSJsVRwRJgneWlmzPMqLiD95t0m9I/ty/6jxMElVv8xcyCLmYkVujJKH+z6eOeoilRIM H5WwKCsx/B1VMgnvfh4r84SOR1BLCTsxG1WKyeuggOdZXqP+h84+HYXTfGMV/N5fVPex4KzrSVe uTzCbLtHCykqc4ftpn1xe28tJDRy4Vlczy8RdQUw1pTVeq+HwxFa220oaCmKyHMmArBdWJw+38 X-Received: by 2002:a05:600c:34cc:b0:485:557d:9fe with SMTP id 5b1f17b1804b1-488d67e65e7mr307710595e9.12.1776290148183; Wed, 15 Apr 2026 14:55:48 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-s390x@nongnu.org, qemu-riscv@nongnu.org, qemu-block@nongnu.org Subject: [PATCH 1/8] cocci: Do not initialize variable used by QLIST_FOREACH macro Date: Wed, 15 Apr 2026 23:55:32 +0200 Message-ID: <20260415215539.92629-2-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260415215539.92629-1-philmd@linaro.org> References: <20260415215539.92629-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=philmd@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: 4 X-Spam_score: 0.4 X-Spam_bar: / X-Spam_report: (0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, SUSPICIOUS_RECIPS=2.51 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1776290217468154100 The QLIST_FOREACH() macro, defined in "qemu/queue.h", always assigns its iterator variable when entering the loop. Remove the pointless and possibly misleading assignment. Mechanical patch using the following coccinelle spatch: @@ type T; identifier e; iterator FOREACH_MACRO =3D~ ".*_FOREACH.*"; statement S; @@ - T *e =3D ...; + T *e; ... when !=3D e FOREACH_MACRO(e, ...) S Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier --- block/blkio.c | 2 +- block/gluster.c | 4 ++-- hw/arm/virt-acpi-build.c | 2 +- hw/i386/xen/xen-hvm.c | 4 ++-- hw/riscv/riscv-iommu.c | 2 +- hw/vfio/cpr-legacy.c | 2 +- hw/vfio/listener.c | 4 ++-- hw/xen/xen_pt_config_init.c | 4 ++-- 8 files changed, 12 insertions(+), 12 deletions(-) diff --git a/block/blkio.c b/block/blkio.c index 20f138a38c5..fb8bec27d71 100644 --- a/block/blkio.c +++ b/block/blkio.c @@ -124,7 +124,7 @@ blkio_do_alloc_bounce_buffer(BDRVBlkioState *s, BlkioBo= unceBuf *bounce, int64_t bytes) { void *addr =3D s->bounce_pool.addr; - BlkioBounceBuf *cur =3D NULL; + BlkioBounceBuf *cur; BlkioBounceBuf *prev =3D NULL; ptrdiff_t space; =20 diff --git a/block/gluster.c b/block/gluster.c index 4fb25b2c6d8..279f650241c 100644 --- a/block/gluster.c +++ b/block/gluster.c @@ -251,7 +251,7 @@ static void glfs_set_preopened(const char *volume, glfs= _t *fs) =20 static glfs_t *glfs_find_preopened(const char *volume) { - ListElement *entry =3D NULL; + ListElement *entry; =20 QLIST_FOREACH(entry, &glfs_list, list) { if (strcmp(entry->saved.volume, volume) =3D=3D 0) { @@ -265,7 +265,7 @@ static glfs_t *glfs_find_preopened(const char *volume) =20 static void glfs_clear_preopened(glfs_t *fs) { - ListElement *entry =3D NULL; + ListElement *entry; ListElement *next; =20 if (fs =3D=3D NULL) { diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index 591cfc993c6..a38a835d48d 100644 --- a/hw/arm/virt-acpi-build.c +++ b/hw/arm/virt-acpi-build.c @@ -146,7 +146,7 @@ static void acpi_dsdt_add_pci(Aml *scope, const MemMapE= ntry *memmap, { int ecam_id =3D VIRT_ECAM_ID(vms->highmem_ecam); bool cxl_present =3D false; - PCIBus *bus =3D vms->bus; + PCIBus *bus; bool acpi_pcihp =3D false; =20 if (vms->acpi_dev) { diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index 67d3e836eb1..d3ce082e07a 100644 --- a/hw/i386/xen/xen-hvm.c +++ b/hw/i386/xen/xen-hvm.c @@ -184,7 +184,7 @@ static void xen_ram_init(PCMachineState *pcms, static XenPhysmap *get_physmapping(hwaddr start_addr, ram_addr_t size, int page_mask) { - XenPhysmap *physmap =3D NULL; + XenPhysmap *physmap; =20 start_addr &=3D page_mask; =20 @@ -200,7 +200,7 @@ static hwaddr xen_phys_offset_to_gaddr(hwaddr phys_offs= et, ram_addr_t size, int page_mask) { hwaddr addr =3D phys_offset & page_mask; - XenPhysmap *physmap =3D NULL; + XenPhysmap *physmap; =20 QLIST_FOREACH(physmap, &xen_physmap, list) { if (range_covers_byte(physmap->phys_offset, physmap->size, addr)) { diff --git a/hw/riscv/riscv-iommu.c b/hw/riscv/riscv-iommu.c index c3c9ed6469a..bdc64b70ff2 100644 --- a/hw/riscv/riscv-iommu.c +++ b/hw/riscv/riscv-iommu.c @@ -1681,7 +1681,7 @@ static void riscv_iommu_ats(RISCVIOMMUState *s, IOMMUAccessFlags perm, void (*trace_fn)(const char *id)) { - RISCVIOMMUSpace *as =3D NULL; + RISCVIOMMUSpace *as; IOMMUNotifier *n; IOMMUTLBEvent event; uint32_t pid; diff --git a/hw/vfio/cpr-legacy.c b/hw/vfio/cpr-legacy.c index 033a546c301..c431d899731 100644 --- a/hw/vfio/cpr-legacy.c +++ b/hw/vfio/cpr-legacy.c @@ -212,7 +212,7 @@ void vfio_legacy_cpr_unregister_container(VFIOLegacyCon= tainer *container) void vfio_cpr_giommu_remap(VFIOContainer *bcontainer, MemoryRegionSection *section) { - VFIOGuestIOMMU *giommu =3D NULL; + VFIOGuestIOMMU *giommu; hwaddr as_offset =3D section->offset_within_address_space; hwaddr iommu_offset =3D as_offset - section->offset_within_region; =20 diff --git a/hw/vfio/listener.c b/hw/vfio/listener.c index 960da9e0a93..cf2f9ef5e8f 100644 --- a/hw/vfio/listener.c +++ b/hw/vfio/listener.c @@ -337,7 +337,7 @@ static void vfio_ram_discard_unregister_listener(VFIOCo= ntainer *bcontainer, MemoryRegionSection *sect= ion) { RamDiscardManager *rdm =3D memory_region_get_ram_discard_manager(secti= on->mr); - VFIORamDiscardListener *vrdl =3D NULL; + VFIORamDiscardListener *vrdl; =20 QLIST_FOREACH(vrdl, &bcontainer->vrdl_list, next) { if (vrdl->mr =3D=3D section->mr && @@ -467,7 +467,7 @@ static void vfio_device_error_append(VFIODevice *vbased= ev, Error **errp) VFIORamDiscardListener *vfio_find_ram_discard_listener( VFIOContainer *bcontainer, MemoryRegionSection *section) { - VFIORamDiscardListener *vrdl =3D NULL; + VFIORamDiscardListener *vrdl; =20 QLIST_FOREACH(vrdl, &bcontainer->vrdl_list, next) { if (vrdl->mr =3D=3D section->mr && diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init.c index 3edaeab1e34..bbc82a2bcfa 100644 --- a/hw/xen/xen_pt_config_init.c +++ b/hw/xen/xen_pt_config_init.c @@ -62,7 +62,7 @@ static int xen_pt_hide_dev_cap(const XenHostPCIDevice *d,= uint8_t grp_id) /* find emulate register group entry */ XenPTRegGroup *xen_pt_find_reg_grp(XenPCIPassthroughState *s, uint32_t add= ress) { - XenPTRegGroup *entry =3D NULL; + XenPTRegGroup *entry; =20 /* find register group entry */ QLIST_FOREACH(entry, &s->reg_grps, entries) { @@ -80,7 +80,7 @@ XenPTRegGroup *xen_pt_find_reg_grp(XenPCIPassthroughState= *s, uint32_t address) /* find emulate register entry */ XenPTReg *xen_pt_find_reg(XenPTRegGroup *reg_grp, uint32_t address) { - XenPTReg *reg_entry =3D NULL; + XenPTReg *reg_entry; XenPTRegInfo *reg =3D NULL; uint32_t real_offset =3D 0; =20 --=20 2.53.0 From nobody Sat May 30 20:11:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1776290214; cv=none; d=zohomail.com; s=zohoarc; b=FV10hIBQFYJw9P5ePymS4Hv/i5c8vrVHkPxKFG2123fwyEx0W3GTqAW6V7jIHqy8rdiQoE5qFrsTNoFACBgNJ7XZXDE0dpaIBzPC8Z/cd9yxvt4v8FJHsxm9L0deSJOdHLC0FGkuRFDE6oFQgs/b4G079WJqJvF3qJPWoOOFs8M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776290214; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=jHqQq9mgfz0/IbHwfpAA/ZimJYVnAn25wtx09Q5wcT0=; b=TExKv/1QxwdvBcMyyctPSGhIGcFNbIsxfLAk10aFe8HSPCGkhx6D931kH2PWoFLtfIDL73R8QvAEO7C8hhQ0zyDEzVZodeZMrtRz5NKUWrBRMb8mO49jDpqz4B/M/iRIpwDdzFdeZ+x+GX3HjeyZhYSl/QbVBJtHPOLVqmrGg5Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776290214802763.8083322353817; Wed, 15 Apr 2026 14:56:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wD8DR-0002IT-Se; Wed, 15 Apr 2026 17:56:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wD8DI-0002Fx-Et for qemu-devel@nongnu.org; Wed, 15 Apr 2026 17:56:01 -0400 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wD8DF-0002h1-05 for qemu-devel@nongnu.org; Wed, 15 Apr 2026 17:55:59 -0400 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-488ad135063so71634205e9.0 for ; Wed, 15 Apr 2026 14:55:56 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488f57da2aesm2566985e9.0.2026.04.15.14.55.53 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 15 Apr 2026 14:55:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1776290155; x=1776894955; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jHqQq9mgfz0/IbHwfpAA/ZimJYVnAn25wtx09Q5wcT0=; b=eq0xDjgjWtN1ErEI6QXip1IE3qJrJ5spiDesBpP/e59VghsVMAZDbc3TiWwefmwFjz ci3RRIftPxU+ZQimrmHk04duDHRgRv+hFsYiWeqPQJm5d15o+fiLAPZEzXsm2P96TaHA 79HPAyDiQGZe0lIkWGRlV1Fnk9KHmiOWnwST1gVBTN0Ea8fd0nxCI3K9zg3zsC05k1YZ CRRnVO8rRIHuY2yhX8pB8ThyiggqdZkN2bRmeemxloM9qSPCKmxfp9jQezAnQxfpcS+S UwBkLmrAXPxmV3XQsA3s9D9iMKW/OOrExruD9933w79jNZFzHJooAMULoV4qWacLG/WX NS9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776290155; x=1776894955; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=jHqQq9mgfz0/IbHwfpAA/ZimJYVnAn25wtx09Q5wcT0=; b=nWpmHFMXYOyHVuJpAAeuE7AJVKoSJa75chdeidG8Erm8NKPoZAce+2b1FTZz7rLQ8I q2T5eREhqNUZNbhwInJ/FhQKLqG1hEaDUm3I1pUeybu/OMWGQNxsro+Dl9ycxRIZ+njx dYzcG6pu4KX9G/NOTqnCOFjvkq/ODMqwNhNVdy8iLu1z0o8r8VDurRU8vhAAmxOuLoB4 Rlxn8AFjIYF8leGSejITM/SfLx6Mux0LttpDzq0Uv/8SlUulKhL3gldOY8aCK1nWfPrM 2ZXfWYfhrQMYHZiFYlyqXTrXyMyOk6l0p3Bk/wXuPsbeVPgAziVrsagCf/DFfQMS3ie4 EJHg== X-Gm-Message-State: AOJu0YyJAnHbNA1JNS3XPvli2z8INxAMi2AoeJiM319B99r5jnvAOl+J hkbNp6L0A/W5DVxFNEeCYNfdfm8PcX+Nx6w4zbKp0+8Hgh64cm1t5gxtg/FHfXEobfeCz/avl+1 B0ENnobQ= X-Gm-Gg: AeBDieufqcDIxDNgPf3lxhSXhQbNzi+dE4gxu/neHAzZHj+Qpn6JkZGeWC2FCH2paYX TZsacHLyC4veBIEjCE+NU80Wfs3GmqHh19IT6Z+BHmPUdW+eAOMIedUCPI6HqEt0wYusGV/SC2k TNeKUkUAYbrEP1RgAGOalfikMddQ/cg+cCjP4A8pFS6wGX+LRlzlQnNpe+L/P7mA9CvOuI7d1Qz 5LjtuMiCSHFUr/5gJGHSzz+gal1ke5TE9H7QAZbX0XqztNq7XOba7pDZyFGeGXvI22qPbJKAhZ/ 2Q7HXnl2Yd5tyEbHSdnC/nSbdAVsXhU0uWADhLHe+MBowKC07POY1jJ585/cNJY85Ba4FP69CoL RF86cWDQe9BeHI7UiN8nAEUyR7vfVZ+Gt2NdKVG7SjY7cR+MC9YD0MJdqbf0MH0T3FtkgCUE2gz 5YVH8wQ9ixLfyWRBb3LUJ6UjBdf7CSyBOMIyWtbQs3GVlSh4tpXggGImUCLtby0ElUaRGJ4FzvG RQbcelGt5k= X-Received: by 2002:a05:600c:8595:b0:485:3b00:f93b with SMTP id 5b1f17b1804b1-488d6ab8082mr238560215e9.31.1776290155006; Wed, 15 Apr 2026 14:55:55 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-s390x@nongnu.org, qemu-riscv@nongnu.org, qemu-block@nongnu.org Subject: [PATCH 2/8] cocci: Do not initialize variable used by QSLIST_FOREACH macro Date: Wed, 15 Apr 2026 23:55:33 +0200 Message-ID: <20260415215539.92629-3-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260415215539.92629-1-philmd@linaro.org> References: <20260415215539.92629-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=philmd@linaro.org; helo=mail-wm1-x32e.google.com X-Spam_score_int: 4 X-Spam_score: 0.4 X-Spam_bar: / X-Spam_report: (0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, SUSPICIOUS_RECIPS=2.51 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1776290217393154100 The QSLIST_FOREACH() macro, defined in "qemu/queue.h", always assigns its iterator variable when entering the loop. Remove the pointless and possibly misleading assignment. Mechanical patch using the following coccinelle spatch: @@ type T; identifier e; iterator FOREACH_MACRO =3D~ ".*_FOREACH.*"; statement S; @@ - T *e =3D ...; + T *e; ... when !=3D e FOREACH_MACRO(e, ...) S Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier --- ebpf/ebpf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ebpf/ebpf.c b/ebpf/ebpf.c index 2d73beb4796..a8d441b02c1 100644 --- a/ebpf/ebpf.c +++ b/ebpf/ebpf.c @@ -40,7 +40,7 @@ void ebpf_register_binary_data(int id, const void *data, = size_t datalen) =20 const void *ebpf_find_binary_by_id(int id, size_t *sz, Error **errp) { - struct ElfBinaryDataEntry *it =3D NULL; + struct ElfBinaryDataEntry *it; QSLIST_FOREACH(it, &ebpf_elf_obj_list, node) { if (id =3D=3D it->id) { *sz =3D it->datalen; --=20 2.53.0 From nobody Sat May 30 20:11:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1776290275; cv=none; d=zohomail.com; s=zohoarc; b=iVE/y6WcMIA1XcJrw3VLU5W7u7qnQtKBt3UN6Z24/aegyqqT8VOzsPCUIs5fZJOTWd6bleYXYiQVJJP0r7HxNNw4NvKudRIjliKhEQIiE4ncLYN2hfkrBh9fYGVv7tySL8BvOMWgSRj2D4pEjjJ/qzvFDb1E3SF2UdjLsYmsK+U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776290275; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=3YcATVaIISTbgVGscn8e0nT489EMZwoo2OUk1DH7jcY=; b=SIxknSmjrwRggo1D9hJQszhk9MRGj1UXSqEMRv5h5suSI+vVU5i8L5eOJ3pybhH85+U7auh6AkWtNlN10t3kUpv841+Beqa900TjxiMFcJ3rWC2+RBkaWiMPFwbQ1bLZO2hyCuHMNkl0pJ68LNCIDZZHm0LhIl5Fnh/iLV0Gm4g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776290275479198.64131804965746; Wed, 15 Apr 2026 14:57:55 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wD8DV-0002K2-DR; Wed, 15 Apr 2026 17:56:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wD8DO-0002HG-QJ for qemu-devel@nongnu.org; Wed, 15 Apr 2026 17:56:07 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wD8DL-0002jL-LH for qemu-devel@nongnu.org; Wed, 15 Apr 2026 17:56:06 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-482f454be5bso311205e9.0 for ; Wed, 15 Apr 2026 14:56:03 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488f5818e51sm1034545e9.5.2026.04.15.14.56.00 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 15 Apr 2026 14:56:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1776290162; x=1776894962; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3YcATVaIISTbgVGscn8e0nT489EMZwoo2OUk1DH7jcY=; b=ULCXDeA47qpjtuY9x+BL6qRbuLadcmM9f+Im7pKFIfCq4bTwqwiJE1+rGCOwQWHNDM oyp1KZC88kNC/74O/IUSJoeYIxwCtwjV/JN+s/PcS9mlF4yWbTlxN3ReesObdMbHSZiE W7/sDzIUBpJJdsi9vZFlMTMiL9YoFJQBo6kQtYf+7Wq/SQTymMZ8i9/yAmUvS9cCjbE5 HZGNCYTpWSW9TBRGvj4CCkQeRZfjiP2AcVXlS01smhb/3h5f2KoHUvXOy0ZLtQ6A7ods Z8tfhayFxQjpBdPZOGV71R4KqEODdPi/1LR2nbx2LEqZhoKBAjm89H/VvqlOitcImVev bXJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776290162; x=1776894962; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3YcATVaIISTbgVGscn8e0nT489EMZwoo2OUk1DH7jcY=; b=IzZW3Zclxzud57qoOTTtE9o059YiDxgsOQ1mOTfdZ+53JwbndRkZmtkuat2Z/XwAMx NSlmZrcyFnNARmi+RLJVCTLHW9c2vpSFCNjzHsiIwRMmZ4Kf6txEjncf6LARK3gC6Taj ZSnBezi5dAtauLR4oqkC7crV4sxBkXo++bMApg2HOJpbP6RLw6ORGGMolRu2g0s2t96y vegaQhdpV5MMne+fptJwCBfI5lex4qs1iw+XXDklxyCRQ83yIfJ6j3GMTt9XLerm9XFh +4rDLT2djtOJ3JCJQ7BmW/Jbp7AJLcu7IRsEjBYN9GRe/C+lo/+VRvuALcEeR8H/mMAs 7jSQ== X-Gm-Message-State: AOJu0Yy/L5re16L6D+iqrPkf5YJGSCugGMXVEReoSzJ9PyRjNm0Uf/Wy REbN3fY3LF6qTeM+A66u771Ry9P1EsdksB160b/OubURkrxd7DkhsOKV11Lg8VGLk0Ha+BLC0Lg Dh83wYGE= X-Gm-Gg: AeBDiest23wh+0B7Vp++tR8Kc+XImC6drW7SIg+rP5QIARZ9qlrYUK9rOhXcfnFzeNy CDzWyl8enOQpuaX+wsZ3TkVh/60aWWD/VLbK1Orxm/Xho3Wztffv5IyojUYLgV1ZaJ/Znw/iabU W6q9b13kQ4n/2kW+r+69dCL5eedE8k74JU2Zbxr5H+IPZiTqn3fiMPaGxBMruq1xvWXAGiAl9nY mYJlo8H3vSrBeSOePAbBmTfIu0wDZuJcnGJF9O78G2zEVnIPSz3U3NKySUS6UaPf1jDhMkVxK/B cVG82oYANpo3W1L1S3ckRV866MTKuG/HioWcp9mVcwHABfFYlBH+hNHEauLTRKGoH6FtYJ0MtJO H74gH/Ue0ZrT3FmrEGFVdajIc8OTocMNUjkNj3dEiL/YQrNpOBz2Zk8kgIMBd9j0p/RMuRh+cu3 3Qxztn+KXWjq+CoYw1vVKtInPSzkSMJvD7TsRBMLH4v8QWVlw1g9ONTdP+9PnS4EOpEnzHvOSA X-Received: by 2002:a05:600c:c090:b0:485:fbd2:f72 with SMTP id 5b1f17b1804b1-488f45cc70amr10941795e9.1.1776290161823; Wed, 15 Apr 2026 14:56:01 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-s390x@nongnu.org, qemu-riscv@nongnu.org, qemu-block@nongnu.org Subject: [PATCH 3/8] cocci: Do not initialize variable used by QSIMPLEQ_FOREACH macro Date: Wed, 15 Apr 2026 23:55:34 +0200 Message-ID: <20260415215539.92629-4-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260415215539.92629-1-philmd@linaro.org> References: <20260415215539.92629-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: 4 X-Spam_score: 0.4 X-Spam_bar: / X-Spam_report: (0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, SUSPICIOUS_RECIPS=2.51 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1776290277352158500 The QSIMPLEQ_FOREACH() macro, defined in "qemu/queue.h", always assigns its iterator variable when entering the loop. Remove the pointless and possibly misleading assignment. Mechanical patch using the following coccinelle spatch: @@ type T; identifier e; iterator FOREACH_MACRO =3D~ ".*_FOREACH.*"; statement S; @@ - T *e =3D ...; + T *e; ... when !=3D e FOREACH_MACRO(e, ...) S Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier --- block/blkdebug.c | 2 +- migration/block-dirty-bitmap.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index 8a4a8cb85ea..fdc96d1f45d 100644 --- a/block/blkdebug.c +++ b/block/blkdebug.c @@ -591,7 +591,7 @@ static int coroutine_fn rule_check(BlockDriverState *bs= , uint64_t offset, uint64_t bytes, BlkdebugIOType iotype) { BDRVBlkdebugState *s =3D bs->opaque; - BlkdebugRule *rule =3D NULL; + BlkdebugRule *rule; int error; bool immediately; =20 diff --git a/migration/block-dirty-bitmap.c b/migration/block-dirty-bitmap.c index a061aad8177..87009c45182 100644 --- a/migration/block-dirty-bitmap.c +++ b/migration/block-dirty-bitmap.c @@ -1216,7 +1216,7 @@ fail: static int dirty_bitmap_save_setup(QEMUFile *f, void *opaque, Error **errp) { DBMSaveState *s =3D &((DBMState *)opaque)->save; - SaveBitmapState *dbms =3D NULL; + SaveBitmapState *dbms; =20 if (init_dirty_bitmap_migration(s, errp) < 0) { return -1; --=20 2.53.0 From nobody Sat May 30 20:11:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1776290291; cv=none; d=zohomail.com; s=zohoarc; b=OoOWDMMvxKHlZzImO5Mt9Vv7fWD139DIizJByZFrbAvXx9WwH466tqdxjHgIdkPt5Y62WoxEMQEg9IqCc8u0xbGRcXxKsD+fgeml7n/Y8CHq6MyVsjA3Zhzkjoksvr2Ec5tKFh+3em989eHmZ2apMCcj266nXEemqoBWgdfBfpM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776290291; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=SbzRYXXryYZ+mwGu76PWqGXVlNyCIhPPUDzA8n+lP6I=; b=Rk/qKPxj/c80nauStWC8yF7b3ulwKgza+72cTPa+kfd+u9c/v3I+LQbJ+N7J3eYb1Xft0hUuh0Y8wYoEMYJefHIdtU9yHThJswQKbNwnxkhaPiVD1nq4J63213WdhyogaxID4Fu/yz/tgLSIVCMQP7sTzj1eQWXAedwHVu9w6I0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776290291838672.0465513711994; Wed, 15 Apr 2026 14:58:11 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wD8Df-0002O6-Ds; Wed, 15 Apr 2026 17:56:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wD8DW-0002LM-Mv for qemu-devel@nongnu.org; Wed, 15 Apr 2026 17:56:15 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wD8DT-0002lJ-KH for qemu-devel@nongnu.org; Wed, 15 Apr 2026 17:56:14 -0400 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-488a88aeec9so96977495e9.2 for ; Wed, 15 Apr 2026 14:56:10 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488f584e243sm261015e9.10.2026.04.15.14.56.07 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 15 Apr 2026 14:56:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1776290169; x=1776894969; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SbzRYXXryYZ+mwGu76PWqGXVlNyCIhPPUDzA8n+lP6I=; b=izI+MYoJthDgTj44brPRhQa+liqJvitMw8GBXLbPFV8PQ+nFHWFIQSL46YFnDHnZIj VKpXUI7zEU/N+10hQPdO/bP01SbgofIbhxVAQMtg1fsPd0A9YCjqgbhnxtmbgvB8jqBT gUWCXOy8aOTCimwRMuZeo4yoXKcWTLjMCIu7vBdv1kc3kxS2xmzj9mfLNnkpBKFb/jyc fdjlyiyfz78Yv+vf0nz7T6a+l7pkv7I+69P3pIfW1dZf2J3yH5RWL9kXlSSvfzYjaLRO Ium8NgZdoYD3r4qjEhXzx1fuwdAf2/pmnEk+zgyReUdE1xmfQ78WsHt0Jl2Kts0TVvwT CWoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776290169; x=1776894969; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SbzRYXXryYZ+mwGu76PWqGXVlNyCIhPPUDzA8n+lP6I=; b=fge3HXQgGziO7CFFrTawtBv5z9LyCN/lOUyW6e93Ste2h2N1HD4OgASONOjU90I7g4 ZlV04wRFK/EjtBbTbS70xHlfA/BecLKRrLuhIw+jGHRxmyeuGz7sudOmR7cHn3fD2Gss 9Btyv0CtCxO7bRq+pHwAXTBdUdaTPRpQ4NgfIylfH2QtcKLVImZWIAOOKw5NbqtoPaGU 4BEmXSZG+t+Cz+mwPPOU6d1TjuLmNvnY2xjanLCvD0BPHkkfe0fillYyRsjAdBO0JKfB feJERBvjaCKx1GW5z+jPQ2vhau5iDqSOQsmNUVBbLRit3Zz1G/FkKJukfQX29PDIRtTI 7zbQ== X-Gm-Message-State: AOJu0YwAqylBevh5kxIJe0bVvYCumHmoH6agBlrdti+PEYIqegOlY8ti 46CJKqPU+UsAWsNCkxLE21yI+H163k9ls+uHfOG3b4BuOC22F+xodlI02RC9tu947Uq51e34Jd3 RvRggnOY= X-Gm-Gg: AeBDietiZp6c/2KFtGb6v+piVhXIahsvXS+LNV+8SpCk+p/F5ygaJ13V99R/O/kjIrQ HWvQHivyU/wj3xn/T95PGMrGTy79cHcZeM6uo9JeueXINK5gQ3/g2q4aoa6/vBW6GiocvnjqEVL s/U/XM0EBMlCBd04wEhK3vOQe5kjNiFp/nIcLutge5nn9MBazEZXKOVk+YO0tA0FwSkC2Q3HKMm NDWNDAzUi5/zmL/ZIWwKIwUIetoK9oTzgUqF6R6FIEsRZCpTyKKwpU2/htzF/LFi+0qutVtaPPG 2R66Jcqsh+D81ucPi87nKYOnLWnqatVr2ANlIEBhIpdShLfjXBilsnq7//rQRMfoGxtWORY5Ztd yu7NZS+Etv5+6YOvbEpi2urrxLSWKxSUyWOc7pgz5BEzXj8hO0ktK5SGtFw/2ChJgh89hLYX9cP Wfetlv/Zju0WP+BIPBj4D+LHXo8+ZDLhzt6+SDYuaqdPZbj51uFnN7W6HCmGf4TK9MmkuLs7xf X-Received: by 2002:a05:600c:348d:b0:486:ff92:63e5 with SMTP id 5b1f17b1804b1-488d67df5aamr346175875e9.6.1776290168733; Wed, 15 Apr 2026 14:56:08 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-s390x@nongnu.org, qemu-riscv@nongnu.org, qemu-block@nongnu.org Subject: [PATCH 4/8] cocci: Do not initialize variable used by QTAILQ_FOREACH macro Date: Wed, 15 Apr 2026 23:55:35 +0200 Message-ID: <20260415215539.92629-5-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260415215539.92629-1-philmd@linaro.org> References: <20260415215539.92629-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=philmd@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: 4 X-Spam_score: 0.4 X-Spam_bar: / X-Spam_report: (0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, SUSPICIOUS_RECIPS=2.51 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1776290293434158500 The QTAILQ_FOREACH() macro, defined in "qemu/queue.h", always assigns its iterator variable when entering the loop. Remove the pointless and possibly misleading assignment. Mechanical patch using the following coccinelle spatch: @@ type T; identifier e; iterator FOREACH_MACRO =3D~ ".*_FOREACH.*"; statement S; @@ - T *e =3D ...; + T *e; ... when !=3D e FOREACH_MACRO(e, ...) S Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier --- hw/ppc/spapr.c | 2 +- hw/ppc/spapr_events.c | 4 ++-- net/colo-compare.c | 4 ++-- net/net.c | 2 +- target/s390x/kvm/stsi-topology.c | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 0ab39dfea6b..bc7232e774a 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -3685,7 +3685,7 @@ struct SpaprDimmState { static SpaprDimmState *spapr_pending_dimm_unplugs_find(SpaprMachineState *= s, PCDIMMDevice *dimm) { - SpaprDimmState *dimm_state =3D NULL; + SpaprDimmState *dimm_state; =20 QTAILQ_FOREACH(dimm_state, &s->pending_dimm_unplugs, next) { if (dimm_state->dimm =3D=3D dimm) { diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c index 1a21ac7bbf8..ab23e3f477b 100644 --- a/hw/ppc/spapr_events.c +++ b/hw/ppc/spapr_events.c @@ -460,7 +460,7 @@ static void rtas_event_log_queue(SpaprMachineState *spa= pr, static SpaprEventLogEntry *rtas_event_log_dequeue(SpaprMachineState *spapr, uint32_t event_mask) { - SpaprEventLogEntry *entry =3D NULL; + SpaprEventLogEntry *entry; =20 QTAILQ_FOREACH(entry, &spapr->pending_events, next) { const SpaprEventSource *source =3D @@ -482,7 +482,7 @@ static SpaprEventLogEntry *rtas_event_log_dequeue(Spapr= MachineState *spapr, =20 static bool rtas_event_log_contains(SpaprMachineState *spapr, uint32_t eve= nt_mask) { - SpaprEventLogEntry *entry =3D NULL; + SpaprEventLogEntry *entry; =20 QTAILQ_FOREACH(entry, &spapr->pending_events, next) { const SpaprEventSource *source =3D diff --git a/net/colo-compare.c b/net/colo-compare.c index c356419d6a8..abc1326b704 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -1396,7 +1396,7 @@ static void colo_compare_init(Object *obj) =20 void colo_compare_cleanup(void) { - CompareState *tmp =3D NULL; + CompareState *tmp; CompareState *n =3D NULL; =20 QTAILQ_FOREACH_SAFE(tmp, &net_compares, next, n) { @@ -1407,7 +1407,7 @@ void colo_compare_cleanup(void) static void colo_compare_finalize(Object *obj) { CompareState *s =3D COLO_COMPARE(obj); - CompareState *tmp =3D NULL; + CompareState *tmp; =20 qemu_mutex_lock(&colo_compare_mutex); QTAILQ_FOREACH(tmp, &net_compares, next) { diff --git a/net/net.c b/net/net.c index a176936f9bc..2892f1730d1 100644 --- a/net/net.c +++ b/net/net.c @@ -653,7 +653,7 @@ static ssize_t filter_receive_iov(NetClientState *nc, NetPacketSent *sent_cb) { ssize_t ret =3D 0; - NetFilterState *nf =3D NULL; + NetFilterState *nf; =20 if (direction =3D=3D NET_FILTER_DIRECTION_TX) { QTAILQ_FOREACH(nf, &nc->filters, next) { diff --git a/target/s390x/kvm/stsi-topology.c b/target/s390x/kvm/stsi-topol= ogy.c index c8d6389cd87..301d41b68d2 100644 --- a/target/s390x/kvm/stsi-topology.c +++ b/target/s390x/kvm/stsi-topology.c @@ -285,7 +285,7 @@ static void s390_topology_fill_list_sorted(S390Topology= List *topology_list) */ static void s390_topology_empty_list(S390TopologyList *topology_list) { - S390TopologyEntry *entry =3D NULL; + S390TopologyEntry *entry; S390TopologyEntry *tmp =3D NULL; =20 QTAILQ_FOREACH_SAFE(entry, topology_list, next, tmp) { --=20 2.53.0 From nobody Sat May 30 20:11:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1776290251; cv=none; d=zohomail.com; s=zohoarc; b=YQXKYT7vQjfHyUBwf7PqaUlxspcOJ2rhq643hgQlqUJe1cmEyK3N67LlRRs9n1JPAzk0U3jHmeyJ8wV2Aa+sPRIiak4l5Wui8/fghczZIwoi1rjFpp+1HUhzYKKLUABbF+/wwrG+eeflkJ7BzAsiiIYv4fQOupq81iXEj4hkSbM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776290251; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=J61p27Quk4EZorcOVqxk0jX5dP0dgc/X3RVLAwpYOiA=; b=jZEqY7uq1E++fC78d6k8DCtcp9oBtIn+tK2BQvYqmZ321I2S2Bh4QjFqVlgbpYm+J7sgx7bT8UDeGG2lxI6+VT1NVvY5YwSY3mslwu9hIIm+Nx834O2HkdGjuKP1tnlv/rC1R3bDxhVZaM9JmFaLAdjWMzeWm4ZFbX5e9Tik0Vo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776290251371269.42653168159745; Wed, 15 Apr 2026 14:57:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wD8Di-0002S2-5a; Wed, 15 Apr 2026 17:56:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wD8Dd-0002OS-Tm for qemu-devel@nongnu.org; Wed, 15 Apr 2026 17:56:23 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wD8Db-0002me-7n for qemu-devel@nongnu.org; Wed, 15 Apr 2026 17:56:21 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-48374014a77so96838505e9.3 for ; Wed, 15 Apr 2026 14:56:17 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488f5818da1sm651695e9.6.2026.04.15.14.56.14 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 15 Apr 2026 14:56:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1776290176; x=1776894976; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J61p27Quk4EZorcOVqxk0jX5dP0dgc/X3RVLAwpYOiA=; b=kpInVKQGAMeTNalefhpPzZAscPAh/ks+gblWUXCFG1YP97XLsf2INUBFOVR5sgEXCA c+HxmMNDNasWdtHAC7eK92y23t5H7UHjQeRaJYGczoxL8qvnHNcXS1CSuJ0LB/4l2txO zcYG0X30Q4v6mUXvlK+bsR5CJ6nc4YI28fvgcsuosgaxV7hC8Kwpg8uZD96WpG1/w2P7 01P/6Jql6Zil/MurgeQYn7g9nvkqbzzJQD6d6Gt1oOh6Bowqoi+eP5q3UmkAdwFOxfBR ekscZO70tDNooZi9fhbCyjZwSPKwawIJ9TSYSms8HOJImT5i55vhr3zxblEnV8AKHTEq r98g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776290176; x=1776894976; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=J61p27Quk4EZorcOVqxk0jX5dP0dgc/X3RVLAwpYOiA=; b=f1nIyzEDARbqIYdB0lsnDhzi0ACbQbogHCZVu1+mCgITjJTdWqtXDgrTGFBMYUS7G2 LfZaOXMfHAhL2r+lTDJoJO1y+zrRMza/iPGfBbTnHSIaeh1z2dV+nH2toDHFSNGz7EFi ex/Sr1+7AOnY9j0Kflx+q55VLN3gDCxDqfi6U0zo6cJJr/Mq9Sxls5qcWUClel+Ry0hx e+glyBPSZxssrRVtyVzCSryhDBeVOtoSnOatjbooA8bKjIQWCn23drfEfSy7cOUEJ1AX 5nkMy3z1BNthfn1Hxw9ETUnMYzgtHmAlXLxm++xY39Zzt555Q6137HN61fbwCtACMK20 s5vQ== X-Gm-Message-State: AOJu0Yw+BZ289YPDjcFS8f4la1q7ijBm/5jNxnmKAUiSR+1DgxPApJF/ tsfVBC74IclgmW7V16aNChZZCwH7uaHkyYMZYe/S0nJcLmMkFZVJyHnjnjdsphxqmprHHFFrZgo Me6PPCeU= X-Gm-Gg: AeBDieuPn4AlqFFhmDBv075p5rbH5byGFgpGTI3SVj1HwpYdz/AgJ487KRjruCVFFbF u3wDvBiY44ctgayr/9/1bbq0K1v8xjiXd5SuTdo8ZJaZyzmllhdKa+dHoVuLJjpVeGSam9hsjEH 2uSiL3CNYQeowC/iNI88+iIcDYxG1wFXsj42N6GkZJ4O91uFKZH7Y9HJgXWln+qsUdvuiM41ux+ B7/WULLl/PVawnQIS9AGPp1n2WlriALKTMrF5Cs1ZEThcRGwlvYXP3jwyvwvxaHz2EMVIDcvGAw R1LS5aaK1N0HnMm/K7fl/GUBRVfiFbDb/iQZ0XJJCRHGEt3kVASIClATlMOF7FcXb6jGqvhWzgJ Zcb4ShQCHQdKHR+xF40+L807vuU4iMMIVsWov7C/ZBm/MmYLS1qmgNpE14Z+W3yW8DkzhbHQmao JP7KR7ih7FX1RrXGZRFEA5aIDj02brqXay5gdNzbaZsrl5WWNS8xZEJuc37UmNOD1L97KcnLMO X-Received: by 2002:a05:600c:a105:b0:486:d76c:fa57 with SMTP id 5b1f17b1804b1-488d685b75emr226950265e9.17.1776290175874; Wed, 15 Apr 2026 14:56:15 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-s390x@nongnu.org, qemu-riscv@nongnu.org, qemu-block@nongnu.org Subject: [PATCH 5/8] cocci: Do not initialize variable used by RAMBLOCK_FOREACH* macro Date: Wed, 15 Apr 2026 23:55:36 +0200 Message-ID: <20260415215539.92629-6-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260415215539.92629-1-philmd@linaro.org> References: <20260415215539.92629-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: 4 X-Spam_score: 0.4 X-Spam_bar: / X-Spam_report: (0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, SUSPICIOUS_RECIPS=2.51 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1776290253600158500 The RAMBLOCK_FOREACH_MIGRATABLE() macro, defined in migration/ram.h, ends up calling QLIST_FOREACH_RCU() which always assigns its iterator variable when entering the loop. Remove the pointless and possibly misleading assignment. Mechanical patch using the following coccinelle spatch: @@ type T; identifier e; iterator FOREACH_MACRO =3D~ ".*_FOREACH.*"; statement S; @@ - T *e =3D ...; + T *e; ... when !=3D e FOREACH_MACRO(e, ...) S Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier --- migration/dirtyrate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c index 58f04670629..b360f49efea 100644 --- a/migration/dirtyrate.c +++ b/migration/dirtyrate.c @@ -485,7 +485,7 @@ static bool record_ramblock_hash_info(struct RamblockDi= rtyInfo **block_dinfo, { struct RamblockDirtyInfo *info =3D NULL; struct RamblockDirtyInfo *dinfo =3D NULL; - RAMBlock *block =3D NULL; + RAMBlock *block; int total_count =3D 0; int index =3D 0; bool ret =3D false; @@ -568,7 +568,7 @@ static bool compare_page_hash_info(struct RamblockDirty= Info *info, int block_count) { struct RamblockDirtyInfo *block_dinfo =3D NULL; - RAMBlock *block =3D NULL; + RAMBlock *block; =20 RAMBLOCK_FOREACH_MIGRATABLE(block) { if (skip_sample_ramblock(block)) { --=20 2.53.0 From nobody Sat May 30 20:11:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1776290261; cv=none; d=zohomail.com; s=zohoarc; b=koIv9aGCtf6q6zjZtNHsnoz6V8Qlf4X/oNqHHqG56biJ48kycwKzpamSRTgHH9AhCVvMsPa1TnELrQOwRNqUPORG4P5p69zmK2TgMxdF4tZOEpuJHkTcpAbJFQ3o/KqjFS9weHfrtgDwMqeSAYVbKhhxEOEmTi9ejrkzmmCmJgc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776290261; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ChYobPnwj4tKATx8rDrb5+LPUUeRhqbHM1XXErD9y5Q=; b=nNjoJW6HblRe67oCDX1dsTEhKkXoynnYmaGwvtwr54FOdMidBewoDBRr8/D+Yexct0UcDV6F0c8rqOI9fOL05ylxN2QdlWyvFpwCFuZP1w0hitjj9QcuUp0a9Afycm3SA1BBPLpozgOy4gy3VQC5jSFR2nPDtSznzlMBWcP8sn4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776290261115403.64508785311466; Wed, 15 Apr 2026 14:57:41 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wD8Dk-0002V4-Mj; Wed, 15 Apr 2026 17:56:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wD8Dj-0002TR-CF for qemu-devel@nongnu.org; Wed, 15 Apr 2026 17:56:27 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wD8Dh-0002oM-IP for qemu-devel@nongnu.org; Wed, 15 Apr 2026 17:56:27 -0400 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-488b0046078so71182165e9.1 for ; Wed, 15 Apr 2026 14:56:23 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43ead3d5f11sm8921436f8f.18.2026.04.15.14.56.21 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 15 Apr 2026 14:56:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1776290182; x=1776894982; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ChYobPnwj4tKATx8rDrb5+LPUUeRhqbHM1XXErD9y5Q=; b=PjHFefcNU0A5xS8WW5DSM5gMSt0Al2KEbo3fch2PhCodCk3H+LJgGPChpLedIMuRSh AdhTVENaEPI1pqqi9GvVHromZu0KMiR4wwvQO6ZUeUxgLrHOFGvAaUNVtyG8FjfZHUw5 CXiVCJ/871g1eHozro8N4vJ0a2cKCWWJ9Y83wprVZ2zYd/Xv376h0/LOFDEoi3tETEsZ rToMkC27NchS7tS3psvArg1E69v6P6Npj+XkCwu4abz3u88tOogUzKCLKOz+0EqC4AAV 7fGRSzJC+U11DhCCCyTtiMiVZ9asiDNi+GSxCTk+hZ6jfcSv/Q8USgiqgrfsLz2Uba28 W1kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776290182; x=1776894982; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ChYobPnwj4tKATx8rDrb5+LPUUeRhqbHM1XXErD9y5Q=; b=SS9KovbxT8yUITGFGfYhazmjBgOoeDEMny+FjOO4abNTsf5oe9urm/MFXn0g9auXhL TCKO5XjMuMnTq+lPxW4m649NWpx+FN+wVPHmuC1ciBKzetVgcd/CjIcLjtYtGleZDZ/s oTOJyu/yT1v47jCShvxoeWoK/n5OugLPWCMBq3cePf24Ue8xXfdYMBK2U8HDsy01DO65 /OmWvJSl1aQhHONYodncAsf/PSeicE2xAefgEf24R5J4hU4IiLUjXvnr1b73sQ1pf0Si Lto42XkQ5lswekLpLEKAdIp6fcupyKsiAi/OjWGBFMif4N7T8RMWsw5S5AdqV4ZRXriz f3vA== X-Gm-Message-State: AOJu0YxokvJm58EOk2BjPTnD6RwKCwS7kFMJrl4R/oqDLoFVKo7YthV0 Xt7gFkDwc/8G7YSXPNGwI2WAhYhaGQvEvuD2m76J1LSGgPme6vYYblGC6ikjYd7oNtsJcyq5iMF 2dVL0jrI= X-Gm-Gg: AeBDieub7x5PdAjSGsoKDoH+yPt6e1HBKk5mNgCkC0Vk1MhVL8vmaVXSKmcCCEanW9x gDYTs0pLEiV2wPGqs8HNeT4VUewjuE/PE4++1JPB5fjZ1wMzJmal5ycb3qU67eJ3YZCkbe2hy+t qIYm1trrlsS9hq3lo2eE6JH6Ky7OVjeCuZ812tYVxU6OHPz0O5y9RXt/uRoe/oTJp+TYw7D0p3f lir9Ozuq219Mjtehb8oNnBxe/7GnsFWybTRI8f2EYaoZLJ3HSqTohltKMeyPud/d5gq4NJJkbtm osqmvM/Ts3pLmyaMPWOvQh0TEUvyXUnEEs1PwgaUopn29n57FAWlTmiGBVELT/irNfoOAQ/ogjm GmhbeNUwNTykt4gOnIJn6MApoYp5Gr6+lU4bCjtZDE7/SrNIyI5vRpDbRJByfAUlVavTp8oDx4G ChtLddG0yFjsJYoEIX5urJdhttLlsOkSvIkmsaGvzoOClP9iuO1kOWBaOmMKL1qZZ4RBT2udoF X-Received: by 2002:a05:600c:a415:b0:485:419c:4eba with SMTP id 5b1f17b1804b1-488d67bf7abmr258106465e9.1.1776290182579; Wed, 15 Apr 2026 14:56:22 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-s390x@nongnu.org, qemu-riscv@nongnu.org, qemu-block@nongnu.org Subject: [PATCH 6/8] cocci: Do not initialize variable used by CPU_FOREACH macro Date: Wed, 15 Apr 2026 23:55:37 +0200 Message-ID: <20260415215539.92629-7-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260415215539.92629-1-philmd@linaro.org> References: <20260415215539.92629-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: 4 X-Spam_score: 0.4 X-Spam_bar: / X-Spam_report: (0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, SUSPICIOUS_RECIPS=2.51 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1776290263361154100 The CPU_FOREACH() macro, defined in "hw/core/cpu.h", ends up calling QTAILQ_FOREACH_RCU() which always assigns its iterator variable when entering the loop. Remove the pointless and possibly misleading assignment. Mechanical patch using the following coccinelle spatch: @@ type T; identifier e; iterator FOREACH_MACRO =3D~ ".*_FOREACH.*"; statement S; @@ - T *e =3D ...; + T *e; ... when !=3D e FOREACH_MACRO(e, ...) S Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier --- target/mips/internal.h | 2 +- hw/misc/mips_cpc.c | 4 ++-- target/mips/tcg/system/cp0_helper.c | 8 ++++---- target/mips/tcg/system/tlb_helper.c | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/target/mips/internal.h b/target/mips/internal.h index 28eb28936ba..c6cf69dfb6a 100644 --- a/target/mips/internal.h +++ b/target/mips/internal.h @@ -279,7 +279,7 @@ static inline int mips_vpe_active(CPUMIPSState *env) =20 static inline int mips_vp_active(CPUMIPSState *env) { - CPUState *other_cs =3D first_cpu; + CPUState *other_cs; =20 /* Check if the VP disabled other VPs (which means the VP is enabled) = */ if ((env->CP0_VPControl >> CP0VPCtl_DIS) & 1) { diff --git a/hw/misc/mips_cpc.c b/hw/misc/mips_cpc.c index 924de855ee2..240ccf4d312 100644 --- a/hw/misc/mips_cpc.c +++ b/hw/misc/mips_cpc.c @@ -44,7 +44,7 @@ static void mips_cpu_reset_async_work(CPUState *cs, run_o= n_cpu_data data) =20 static void cpc_run_vp(MIPSCPCState *cpc, uint64_t vp_run) { - CPUState *cs =3D first_cpu; + CPUState *cs; =20 CPU_FOREACH(cs) { uint64_t i =3D 1ULL << cs->cpu_index; @@ -62,7 +62,7 @@ static void cpc_run_vp(MIPSCPCState *cpc, uint64_t vp_run) =20 static void cpc_stop_vp(MIPSCPCState *cpc, uint64_t vp_stop) { - CPUState *cs =3D first_cpu; + CPUState *cs; =20 CPU_FOREACH(cs) { uint64_t i =3D 1ULL << cs->cpu_index; diff --git a/target/mips/tcg/system/cp0_helper.c b/target/mips/tcg/system/c= p0_helper.c index b69e70d7fcf..99f43ad9e11 100644 --- a/target/mips/tcg/system/cp0_helper.c +++ b/target/mips/tcg/system/cp0_helper.c @@ -1559,7 +1559,7 @@ target_ulong helper_emt(void) =20 target_ulong helper_dvpe(CPUMIPSState *env) { - CPUState *other_cs =3D first_cpu; + CPUState *other_cs; target_ulong prev =3D env->mvp->CP0_MVPControl; =20 if (env->CP0_VPEConf0 & (1 << CP0VPEC0_MVP)) { @@ -1577,7 +1577,7 @@ target_ulong helper_dvpe(CPUMIPSState *env) =20 target_ulong helper_evpe(CPUMIPSState *env) { - CPUState *other_cs =3D first_cpu; + CPUState *other_cs; target_ulong prev =3D env->mvp->CP0_MVPControl; =20 if (env->CP0_VPEConf0 & (1 << CP0VPEC0_MVP)) { @@ -1599,7 +1599,7 @@ target_ulong helper_evpe(CPUMIPSState *env) /* R6 Multi-threading */ target_ulong helper_dvp(CPUMIPSState *env) { - CPUState *other_cs =3D first_cpu; + CPUState *other_cs; target_ulong prev =3D env->CP0_VPControl; =20 if (!((env->CP0_VPControl >> CP0VPCtl_DIS) & 1)) { @@ -1617,7 +1617,7 @@ target_ulong helper_dvp(CPUMIPSState *env) =20 target_ulong helper_evp(CPUMIPSState *env) { - CPUState *other_cs =3D first_cpu; + CPUState *other_cs; target_ulong prev =3D env->CP0_VPControl; =20 if ((env->CP0_VPControl >> CP0VPCtl_DIS) & 1) { diff --git a/target/mips/tcg/system/tlb_helper.c b/target/mips/tcg/system/t= lb_helper.c index 566924b079e..680b4da29fa 100644 --- a/target/mips/tcg/system/tlb_helper.c +++ b/target/mips/tcg/system/tlb_helper.c @@ -346,7 +346,7 @@ void helper_ginvt(CPUMIPSState *env, target_ulong arg, = uint32_t type) uint32_t invMsgVPN2 =3D arg & (TARGET_PAGE_MASK << 1); uint8_t invMsgR =3D 0; uint32_t invMsgMMid =3D env->CP0_MemoryMapID; - CPUState *other_cs =3D first_cpu; + CPUState *other_cs; =20 #ifdef TARGET_MIPS64 invMsgR =3D extract64(arg, 62, 2); --=20 2.53.0 From nobody Sat May 30 20:11:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1776290294; cv=none; d=zohomail.com; s=zohoarc; b=TP/eTOB0zwVq2dSjidcDJfF1cLvHRvTk9tiq9mzx9aSlH59SJhsayqdFcn5MFYQ+WPM6WBPHkFt4JofUvy0uRJYqTB1e529rcv0TAuJ1bDWvuzznul9uZjEQDHhjNqEOH+PNMYlrofOO9MYHR7kyafM5QusFuBBYZmMylf1efYM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776290294; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=r3cMxdZZE+yzFr7Fv4iBfref+oMD0q3gkn6aoHsy4iQ=; b=QBnjx8Jt/KAPHYoQm7XP7wFzR40O9t0U81STD1Wd9rQnNR+vPyRptLihzEOYLk6DxMzN6F7Cpd9v83VVFizGPEmpZXAn6o5frgdmIBDVdGdndqSsBU1o9vOUwgS/vMWainTkMUn1FH0ggYrTw5qvdivOHDOVwoHLTckre9qA4wk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17762902949251021.2697379092186; Wed, 15 Apr 2026 14:58:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wD8Dr-0002YY-OR; Wed, 15 Apr 2026 17:56:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wD8Dq-0002XU-HK for qemu-devel@nongnu.org; Wed, 15 Apr 2026 17:56:34 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wD8Dn-0002q7-Mm for qemu-devel@nongnu.org; Wed, 15 Apr 2026 17:56:34 -0400 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-43cfce3a195so4514004f8f.2 for ; Wed, 15 Apr 2026 14:56:31 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43ead3566c4sm7805821f8f.12.2026.04.15.14.56.28 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 15 Apr 2026 14:56:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1776290190; x=1776894990; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=r3cMxdZZE+yzFr7Fv4iBfref+oMD0q3gkn6aoHsy4iQ=; b=FCby5oxxYAvBW6aaOFdzp+GkYpF5Co8SfEZlq3D3y3XRGcqZce2pyfbx7jlTIhl3iu ckU0j4rdq4VdB0tGB3KI+2GBZh6yoVs0kWsF9pkFZ/LQ25GRugQid1Y/VXOMGvBWwSEJ NBmGIjeJELizQc1EOB5BZ0281ibKRZXS5HdQXNeD3v8rzMclMgBBTooTOW0Of/sQRPZe Ar0/6dgbyhhg9LJUetpDNwltRlUZk6LEyow7DelTrdDQUN10GDZAPKbeslrD0k3T3KoP aEhQJtkA+6d/3Vz412juo4TljdIz2zgtiJDYQBr52v3iwk4Xzu6/n5T8d3OlcRrY0wga 3hHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776290190; x=1776894990; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=r3cMxdZZE+yzFr7Fv4iBfref+oMD0q3gkn6aoHsy4iQ=; b=HmO2qx3zGuvfMq9tY/bBxNmGmFgaix6wkdX/Ur05OKQvTmkZI/WunM0TblUZoWxPS5 +P2r3NPKk2AkUp70WSOoiO2qoAEtkKjRk22eBtb/efWbKEVDzQNbbbB6diJDHp4yB+c3 nWGJjhwUEkdapPP3/CBuqyjihHjJ0YHfgnlLZBFtlGbMl3mIGkE4Rj4aupR1w8IzLRmL 3ZPkwjLhJBEyMoUgsbuodvvZhcZPDlToTd8+jkHrEs1sKgWjR3mGht8GVkyeQ8TXs//7 ZbfOlli2dH+MzkKP9FEa29ksqXedtpQh2bHxGNWZJL5Bc/6FWL3e432oactd1ZlzKOJs M0zA== X-Gm-Message-State: AOJu0YxtvKqrSoY4LeZSriC+1J/GRrWmRsy/E6yaxIn0gDRdjZFtgsaG r48GakLIHQL3m0SkDwxviAQFfATfjnJA7/ItgPEGAYPTNL1rLXqaiI3dmktcVZz7p8H5K+FtSzu feuNVERQ= X-Gm-Gg: AeBDievzGR4w1nc8vCpAskRew7JSvDXCTsvKDjS8AgniDKJYwg/QX7alWURs+bmqalX m5jrtqPMjszRXrbnvA1gqZlVSArsQ93NpP+tOhoJ/hxBv8iAcZz73ilkJaYwj3syssnKhzPgexL Q8cWEkvHfHnOl11G2KyXBijS/yrU+cBQMBsDFkP/glrZw+F0ezLiVf6AC4FDNREPZo4oiLF2ksM JMwyUukjeUFV/aNxjn2JlvzSJs/JAmONX8NV4Uav7vmu7aWiVekhw+zdfPyEmGRfaJjMrP7zSPB nmdqcHQ/BirvEOCO6P2KKP3R+XeZvH80Ok+nahY4CoqSx1qXpnuCyVveH+j2zGfccBFRQoMcKlM DFNNV9pCF+VospXyiOJ4jruiDn/xiNvuNXu/kLsYlXbFw1SPkfm+0dw7bkgxii+FQVG7EPDp9XH 0E9NHrOKpKOSnKADHFGipCIlMN/228qiWzDVnAPRGT7GFjQa+ueoLKOCoDwHQP2mbvUy9yNEn2 X-Received: by 2002:a5d:64e4:0:b0:43e:a638:250f with SMTP id ffacd0b85a97d-43ea638264cmr12924286f8f.1.1776290189684; Wed, 15 Apr 2026 14:56:29 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-s390x@nongnu.org, qemu-riscv@nongnu.org, qemu-block@nongnu.org Subject: [PATCH 7/8] target/mips: Reduce CPUState scope when used with CPU_FOREACH() Date: Wed, 15 Apr 2026 23:55:38 +0200 Message-ID: <20260415215539.92629-8-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260415215539.92629-1-philmd@linaro.org> References: <20260415215539.92629-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=philmd@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: 4 X-Spam_score: 0.4 X-Spam_bar: / X-Spam_report: (0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, SUSPICIOUS_RECIPS=2.51 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1776290297874154100 When possible, reduce CPUState variable scope. Prefer cpu_env(cpu) over &cpu->env. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier --- target/mips/internal.h | 11 ++++++----- target/mips/tcg/system/cp0_helper.c | 28 ++++++++++++++++------------ target/mips/tcg/system/tlb_helper.c | 7 +++---- 3 files changed, 25 insertions(+), 21 deletions(-) diff --git a/target/mips/internal.h b/target/mips/internal.h index c6cf69dfb6a..cc031662ef9 100644 --- a/target/mips/internal.h +++ b/target/mips/internal.h @@ -279,7 +279,7 @@ static inline int mips_vpe_active(CPUMIPSState *env) =20 static inline int mips_vp_active(CPUMIPSState *env) { - CPUState *other_cs; + CPUState *cs; =20 /* Check if the VP disabled other VPs (which means the VP is enabled) = */ if ((env->CP0_VPControl >> CP0VPCtl_DIS) & 1) { @@ -287,10 +287,11 @@ static inline int mips_vp_active(CPUMIPSState *env) } =20 /* Check if the virtual processor is disabled due to a DVP */ - CPU_FOREACH(other_cs) { - MIPSCPU *other_cpu =3D MIPS_CPU(other_cs); - if ((&other_cpu->env !=3D env) && - ((other_cpu->env.CP0_VPControl >> CP0VPCtl_DIS) & 1)) { + CPU_FOREACH(cs) { + CPUMIPSState *other_env =3D cpu_env(cs); + + if ((other_env !=3D env) && + ((other_env->CP0_VPControl >> CP0VPCtl_DIS) & 1)) { return 0; } } diff --git a/target/mips/tcg/system/cp0_helper.c b/target/mips/tcg/system/c= p0_helper.c index 99f43ad9e11..4ec1312f016 100644 --- a/target/mips/tcg/system/cp0_helper.c +++ b/target/mips/tcg/system/cp0_helper.c @@ -1559,12 +1559,13 @@ target_ulong helper_emt(void) =20 target_ulong helper_dvpe(CPUMIPSState *env) { - CPUState *other_cs; target_ulong prev =3D env->mvp->CP0_MVPControl; =20 if (env->CP0_VPEConf0 & (1 << CP0VPEC0_MVP)) { - CPU_FOREACH(other_cs) { - MIPSCPU *other_cpu =3D MIPS_CPU(other_cs); + CPUState *cpu; + + CPU_FOREACH(cpu) { + MIPSCPU *other_cpu =3D MIPS_CPU(cpu); /* Turn off all VPEs except the one executing the dvpe. */ if (&other_cpu->env !=3D env) { other_cpu->env.mvp->CP0_MVPControl &=3D ~(1 << CP0MVPCo_EV= P); @@ -1577,12 +1578,13 @@ target_ulong helper_dvpe(CPUMIPSState *env) =20 target_ulong helper_evpe(CPUMIPSState *env) { - CPUState *other_cs; target_ulong prev =3D env->mvp->CP0_MVPControl; =20 if (env->CP0_VPEConf0 & (1 << CP0VPEC0_MVP)) { - CPU_FOREACH(other_cs) { - MIPSCPU *other_cpu =3D MIPS_CPU(other_cs); + CPUState *cpu; + + CPU_FOREACH(cpu) { + MIPSCPU *other_cpu =3D MIPS_CPU(cpu); =20 if (&other_cpu->env !=3D env /* If the VPE is WFI, don't disturb its sleep. */ @@ -1599,12 +1601,13 @@ target_ulong helper_evpe(CPUMIPSState *env) /* R6 Multi-threading */ target_ulong helper_dvp(CPUMIPSState *env) { - CPUState *other_cs; target_ulong prev =3D env->CP0_VPControl; =20 if (!((env->CP0_VPControl >> CP0VPCtl_DIS) & 1)) { - CPU_FOREACH(other_cs) { - MIPSCPU *other_cpu =3D MIPS_CPU(other_cs); + CPUState *cpu; + + CPU_FOREACH(cpu) { + MIPSCPU *other_cpu =3D MIPS_CPU(cpu); /* Turn off all VPs except the one executing the dvp. */ if (&other_cpu->env !=3D env) { mips_vpe_sleep(other_cpu); @@ -1617,12 +1620,13 @@ target_ulong helper_dvp(CPUMIPSState *env) =20 target_ulong helper_evp(CPUMIPSState *env) { - CPUState *other_cs; target_ulong prev =3D env->CP0_VPControl; =20 if ((env->CP0_VPControl >> CP0VPCtl_DIS) & 1) { - CPU_FOREACH(other_cs) { - MIPSCPU *other_cpu =3D MIPS_CPU(other_cs); + CPUState *cpu; + + CPU_FOREACH(cpu) { + MIPSCPU *other_cpu =3D MIPS_CPU(cpu); if ((&other_cpu->env !=3D env) && !mips_vp_is_wfi(other_cpu)) { /* * If the VP is WFI, don't disturb its sleep. diff --git a/target/mips/tcg/system/tlb_helper.c b/target/mips/tcg/system/t= lb_helper.c index 680b4da29fa..8537798a53f 100644 --- a/target/mips/tcg/system/tlb_helper.c +++ b/target/mips/tcg/system/tlb_helper.c @@ -346,15 +346,14 @@ void helper_ginvt(CPUMIPSState *env, target_ulong arg= , uint32_t type) uint32_t invMsgVPN2 =3D arg & (TARGET_PAGE_MASK << 1); uint8_t invMsgR =3D 0; uint32_t invMsgMMid =3D env->CP0_MemoryMapID; - CPUState *other_cs; + CPUState *cpu; =20 #ifdef TARGET_MIPS64 invMsgR =3D extract64(arg, 62, 2); #endif =20 - CPU_FOREACH(other_cs) { - MIPSCPU *other_cpu =3D MIPS_CPU(other_cs); - global_invalidate_tlb(&other_cpu->env, invMsgVPN2, invMsgR, invMsg= MMid, + CPU_FOREACH(cpu) { + global_invalidate_tlb(cpu_env(cpu), invMsgVPN2, invMsgR, invMsgMMi= d, invAll, invVAMMid, invMMid, invVA); } } --=20 2.53.0 From nobody Sat May 30 20:11:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1776290288; cv=none; d=zohomail.com; s=zohoarc; b=hW6EyJQ/9wKLuzYNdrAIhf7HGr7udlUipmSwD4kaAY7mYWL4N1/mMIStlXh4PhaICVG+8DX938GLCEQebIZpU8V5O+mJ4mkGeqnASZfs7d7MruGbOgJcNbmLtNlobn1x8mH1DNc1K6SYpIp3S4CqiXCpf8p2lsW3wkqYMKnJhQA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776290288; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=vuIqjkDFYw/UkV0TZBDvRk6uXE3wlZHhGyuhp0aPUMA=; b=lWH0r4prEvo3CGF4rmWycma4Y1DMC4g8OVtMSkMUI6pHuKoYzwr/OJ1GGj4TmcCirt5SHIoWYJ9+TxE6q+8ep00VthJvoVIIBO705NZuz3A5oWk+eNMh+0OQPboVDE1Ilc8noaiQuexB3RLWxULPOWeBnhZ96DkJSYtlhCl/MsU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776290288627581.4525823418824; Wed, 15 Apr 2026 14:58:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wD8E5-0002kp-24; Wed, 15 Apr 2026 17:56:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wD8Dw-0002bC-Rc for qemu-devel@nongnu.org; Wed, 15 Apr 2026 17:56:40 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wD8Du-0002sm-Ju for qemu-devel@nongnu.org; Wed, 15 Apr 2026 17:56:40 -0400 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-43cfd832155so5059383f8f.1 for ; Wed, 15 Apr 2026 14:56:38 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43ead3dfff3sm7480881f8f.26.2026.04.15.14.56.35 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 15 Apr 2026 14:56:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1776290197; x=1776894997; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vuIqjkDFYw/UkV0TZBDvRk6uXE3wlZHhGyuhp0aPUMA=; b=RBKDgv7ximPB2GInQa14ECT1DEJGv4A/AdgyP+RbMjl8kGjtMnOc5X1JkqwqoQnmc6 +KomiWK1hPZ2CfXcxesobPv0clIQ1niG0i8cXGcPg2FhSZw9z9/1oeRzTQkNmVA/akW9 x8jvlEQEJYXX+V050irB8IiMOUEjQvxyQKLBwahmcTyKC7HKZI9mvDYPK2sgm98LPtz9 znWuMexzUxjTzqL1W266+8PzjcBdn52vfOlU2kHH/O9Ao29LAIu42p9CS/rTcQZlNKT6 8JNz/b/tr5op9VB5E6yOGcxe0rI22BtU+hlDAHpZtpA4GeJyhcCfXmzB45rAhcaWDSYA ni1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776290197; x=1776894997; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=vuIqjkDFYw/UkV0TZBDvRk6uXE3wlZHhGyuhp0aPUMA=; b=N267g47wUdFpMVOfBFeNN1VFvKr8MNwl0oFnEHFrtUNM7T9dXzijaLzXDmMUBzecs5 BzUyOQkkHYe3pFPRgKarF1gruBvxJELvf4+5HobRs5/IeUvUPbCepOe/3N9UBI25Wxsn cz4hutZHhFzjkq4R0+h++xAoWRjRBbbKiDuxcRuiK46zocCDU6sbS/O+AhKOPRdtunXU aTkj47HM11rylwVhuu2RUiSTAuV+jHMwJ/DpT1jeEXfjJARHNyczM0KxIAD9qSHhTmxW 8jm77fMCAnjpzVf8x0FPBVvChKFsDuTFQ89F3mG2c5OjhLkEtpdWJn/YOtqokPDJm0CZ Vi/Q== X-Gm-Message-State: AOJu0YyLmj7oyjUUl+kryNAXs7ULL24j8NlSlkNeYbM2WNHRBFDbh279 fLhTbMBc7nb8t9dTi50hSuGlXQWrBS+FtBxf+2O5V4EUYOpvWmXyJOYO6WaVw4TAB81Yc/lXXBY DH/8yQ9c= X-Gm-Gg: AeBDiesk/if4hqemWtTBFT5twtWI8x+0DKM//cf0OGF+p7+oVllvRWA/ZtMbiMQhbtv OHcTBa2mO3R4cMDqGe0QiIW1glZz1P5MDQ+wVY7D3tNg3eXSDXRxjJBdnPddkpZr7vxSEjf0CuO B/4loDuamKEnDJzoWkhUaq9paLNWxAEpL/vthhaR2grAhly+BEyMLUGZUjht2t6lR61jkEObUpy +dhl5K/sj7rcbtr+niYeZE5+dMWWrHzvDqbH9l6xGDkTzS+LrCI8m9EkFQDtry7kZOat2uwwiEE +MP7MQB6aAQos3DiJikiKZy3cIl6/Tn+RY4QkWzmnLO3PkQDq0aYweuyrlFtGp2ZDWCz7+/BX7p zP/fb/1cweO//bFFbifo1YFk7skpS9XHVM2J/xVneAuVaeBAWIA2nLDvPkd0xdrIdnZRx2u0WLG 5fOq5weiJY9OB1Fwj3+0yJoHuJmxqdihyokAv4aNO3xz7jYki0GyIoyzMH3hZtSABFOv/CLcJo X-Received: by 2002:a5d:5f92:0:b0:43b:60f7:2283 with SMTP id ffacd0b85a97d-43d64289753mr35084545f8f.22.1776290196656; Wed, 15 Apr 2026 14:56:36 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-s390x@nongnu.org, qemu-riscv@nongnu.org, qemu-block@nongnu.org Subject: [PATCH 8/8] target/riscv: Iterate vCPUs using CPU_FOREACH() macro Date: Wed, 15 Apr 2026 23:55:39 +0200 Message-ID: <20260415215539.92629-9-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260415215539.92629-1-philmd@linaro.org> References: <20260415215539.92629-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=philmd@linaro.org; helo=mail-wr1-x435.google.com X-Spam_score_int: 4 X-Spam_score: 0.4 X-Spam_bar: / X-Spam_report: (0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, SUSPICIOUS_RECIPS=2.51 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1776290289402158500 Most code iterates over vCPUs using the CPU_FOREACH() macro. Prefer cpu_env(cpu) over &cpu->env. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier --- hw/riscv/boot.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c index e5490beda00..61e21678cd1 100644 --- a/hw/riscv/boot.c +++ b/hw/riscv/boot.c @@ -490,10 +490,11 @@ void riscv_setup_direct_kernel(hwaddr kernel_addr, hw= addr fdt_addr) { CPUState *cs; =20 - for (cs =3D first_cpu; cs; cs =3D CPU_NEXT(cs)) { - RISCVCPU *riscv_cpu =3D RISCV_CPU(cs); - riscv_cpu->env.kernel_addr =3D kernel_addr; - riscv_cpu->env.fdt_addr =3D fdt_addr; + CPU_FOREACH(cs) { + CPURISCVState *env =3D cpu_env(cs); + + env->kernel_addr =3D kernel_addr; + env->fdt_addr =3D fdt_addr; } } =20 --=20 2.53.0