From nobody Thu Apr 30 00:39:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1776153851; cv=pass; d=zohomail.com; s=zohoarc; b=fGSamEQsj9aj6MzbtlbTu4ApsFlzSLaKOFjLksr9PF2kMD7qWNaz017UbpMYaXBWxRagQzO70Zk5QhCbGGEdmd5YzOhYpkprqyHN+ltpPJhKVNpv0GUp4FV1Iq0P66R875j1ug1Q5A24hw36ftl4OZ/SLPTJ/ApV+cqyTSJC8Po= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776153851; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1+qkXLls/pt40Z1VqrqM0+XkmKAxAHjDWMBW47cohns=; b=eOO8im3w7CG7ZlMTof97fpxfOostKeNTXL873aV/EynDD7zEN1v4H9ioIvZoaHKQI3N22VMl85x20PxuIBQcJe5kkqzXKvwoHmefpvBjLahOmYUk4UqeI+ZiA8lS90MlIRIEDrghCD5ylFv8V1wFJ70p4ehg6xDTY8Q1ekj6gL8= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776153850999627.5176642956416; Tue, 14 Apr 2026 01:04:10 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wCYhY-0003Yt-7p; Tue, 14 Apr 2026 04:00:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYhS-0003X2-2D; Tue, 14 Apr 2026 04:00:47 -0400 Received: from mail-koreacentralazlp170130006.outbound.protection.outlook.com ([2a01:111:f403:c40f::6] helo=SEYPR02CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYhM-0005oL-LE; Tue, 14 Apr 2026 04:00:43 -0400 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19) by TYZPR06MB6745.apcprd06.prod.outlook.com (2603:1096:400:45a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Tue, 14 Apr 2026 08:00:27 +0000 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9769.046; Tue, 14 Apr 2026 08:00:27 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=esZ4GZqikxOn8U2Di9yPgsDNZZGD/mUyT4xLoaVHIyMQUlKlZWhB8Fkowne6RbhKxQQjqpfJJh1TkGolVjdQJRVqs+hhmyZ3s8eoNRVbdWMduioQmh5ZXUz2R26FpxcpXRwCr0hbi0NaX2rJn12C+NvxiHymvM6LJ5BxbmiMP2KkOw2WY/dfXvO8FAHnIY2T64b1bDo+WGVjrBdSFrAi5OxC/Hg4huZhlk75XeKjb8kJEbGdnRgA05quKLAj0BfQVydwoAOVK1VPhiZdm8Pifsah+iPiQhW5JQkbF83JJcp6mbP6TQcqUVwNzQOrkbHM27J7mVzTWpdqz79m/ntCLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1+qkXLls/pt40Z1VqrqM0+XkmKAxAHjDWMBW47cohns=; b=lTpA8k+hoo8qxizavmA8UAm92b3q1MBxsghrwomXVM805Z0Jer73dBZ00FU3gwdEM3g0x8xnRacZbFcdgbJbl1VKetVz5IuPGZf+6XGsBpmKVI+oxnbqJYu2Mlo+HTcmtUZ4MNSJEIj/DZCq5AwXfxgwYIYRNVY6Zq60/QCNuxhHMDMM3FiiTUBfRQjAO3tn3CdQmaNeqEuHutBEdAqwqK6lGOo6cLZPeql5xViuLhRX1AaEgMYOcRd8fu3slBf0xg5PSAXLQ7WDP5CAufKXoj52HbtpVbAHoEYhaNrsDvWlSR8SR4wCDHv5/VTT3HEjr40ZkPdhHOmAUeisEx0rpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1+qkXLls/pt40Z1VqrqM0+XkmKAxAHjDWMBW47cohns=; b=McWJvBoJ+BV8XOAP7OO+gITyt/Wf3ffX9MfnhNrVp9x7GnJzYxXWza2e5NstnmDeUKIvsthxe1drnrDkgRodPlpHOAk/+JGyRUdJCISnciOfFTybf0npcHzXT2SPAuOv6A2tWIBCaVxbC9R9Q9vx5N1J4ixw6wWoWC4jUqSoN977m3BUzUbJGoJeldpB/7Ra/Xh+J8zD0WmXRTvGPNlH1C4alnIqLK6mVDrOGkfUhPik6XpMOi7n9IXjiLcD6ozZT04vMSFYR5YipVXVGdr2V0lrxlqP5kIZuWX/539aMkfK1YfXr3JlvRQMG1XjwD36yV43wSFHN0uzqOBJ//5Ung== From: Jamin Lin To: =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , "flwu@google.com" , "nabihestefan@google.com" Subject: [PATCH v2 01/17] hw/usb/hcd-ehci: Remove unused EHCIfstn structure and dead code Thread-Topic: [PATCH v2 01/17] hw/usb/hcd-ehci: Remove unused EHCIfstn structure and dead code Thread-Index: AQHcy+TBUiPPKxc1sEqzhE5+L5C51g== Date: Tue, 14 Apr 2026 08:00:27 +0000 Message-ID: <20260414080025.3005916-2-jamin_lin@aspeedtech.com> References: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYPPR06MB8206:EE_|TYZPR06MB6745:EE_ x-ms-office365-filtering-correlation-id: 7f009c84-72c3-45ec-02d3-08de99fbe427 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|38070700021|22082099003|56012099003|18002099003; x-microsoft-antispam-message-info: Aak86oRoS53oGy/9YXzmVE25SBQoCzq4b9CmeBMLDwVMdccV1Seqh7e6izxU21M1u+oeJcAU+tDBNsSA1YbAb+qoErqL4uKCnaM4VPiFyhZ+mwYt+pHxSInf1+EIyjDSdusQLAK0oBNYXdhznSb7wjZnDHaM34ar9+Z/43r7dG1akglLshJQ5nPAdI7rGb9aB0ELtBwl8e89Wiq7849KNVACrD/isPBS6BTYb8uVsHqWNE6n1OntZxhsTliP6koRXdWtbb5cRL4fV4QRV7v99CEX1u4dJRwe+2l8xvVr2XLCRSS/lAiynEvgnYczzwTtAZ3nm1hzn0VDh8F6z9Ce6urdwo6utonD9b05axwZdf9ssULN88RuxsZM74U/akXbnRNnQtDjOdywURDEEnGgL7FwtG4XMRDz+rxB1ModZQ6kDAHnQD8ZJFf7rKocVNVX9Kn7suh5D87UeNL/gvgWSCnn0OO/2DoRAGtpH9pZeIF2N+N8OxPAO881LTxJHIolNJYAFnLB+qfhlKOdOS9WO3YjYQTlwRcptXBPZHgLvNApfSQD/gpbOmBpz6SjZoXRidQY+9GLwfIRfF04YkbOKuo/0wyf1uP/NumJW9c4FXT4WAtXKbMQMAhaeIEsMSu6GOqW37LY93C/8XHU5l9vSby/Lz1G8DL6+2TcwQM2RxnoRh2IVjjXoMVb6rzqYLhOO1bbpzXAJKvigLmxRMkg8j9LbtV1N+5FevSFdPh0AXVDLP8I/8rXGTYLWxQyzjHiUSlO945PXsoiesvPJjvDX7pe4UCP0QaRQp4yY+gvdOs= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700021)(22082099003)(56012099003)(18002099003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?kDdpW5lAKO/fszwQrZxaR3II+TKNl4qnGp3B4D5/UZb48nhjoHd3FeKYpL?= =?iso-8859-1?Q?jfdQDBQNRHeYoJPPIGaUcBrMAFSIsHxB5Zx88AVPyqUY3X8PFZYPoGXtPH?= =?iso-8859-1?Q?d/4k196CWmBb6KgC+ot3ln/fRXYf51XqCSNaXI0NeeNdYTkHGLWhkVdZf7?= =?iso-8859-1?Q?URtPlTMmQoyAR2du/JTCDCsGnP4J24AzBd8Q0uW+mr3MPow3dcZ/diqXlU?= =?iso-8859-1?Q?lwTytKBd8vwryoaK3Zy/Q8ZBGWRd0IAwcKD+v4lRbdP7ZNJfqkFJ2h3JGz?= =?iso-8859-1?Q?yfRGyK37fufipU7TdB0kKgyBeQiO1dWxVV4FmysJSFPzw+MCkFq6dc7yLR?= =?iso-8859-1?Q?UAs/M6vwaWvBuiqHvVkamSR4dw98Q0/Z1mEAuwL9KUVy5V7WEQGxG+FhTl?= =?iso-8859-1?Q?Gq8e+NbbbYcO4mIX8cie4EX6ISa30oPfMbZPK47gVVjsInoQCQTm9+H4Ie?= =?iso-8859-1?Q?AooYFGOIs+5geaMs0GayTGDFJ60iWslmfpGwIOM+Gw+n+7PFqfWutzUlRe?= =?iso-8859-1?Q?PESiM0N82rRWBXheUK1REKVo9DG5obiL5A8pz0Tn2kxjtoyYW1OmvHhurS?= =?iso-8859-1?Q?uT9CHSxIsQPcac7ToPjvA0FEAZGtlhMiFgsCgqHCd//S5Xo6HZ7odTSVbs?= =?iso-8859-1?Q?wNQ0cB/kQCLZKOwDWbfPW16h/mf40Mv/bvZmg8HQ7gZ6vBcC5TBDURQAOo?= =?iso-8859-1?Q?x/9Tv7Q3Vs2+HUuKNqJEdho90RV9ldnLRmvbsK8lSW37u0SF2POu5IgHR/?= =?iso-8859-1?Q?1GtUnyoPHTk1EOh0Gm3pH9f5SVqqLbKznKIFwVYYYVdjT1iUt3utbx/UTa?= =?iso-8859-1?Q?sPeyETLC81JfPHbsELYYziSj6ApdMHYo2ihGuLtQvuahFtT1UNZiODe484?= =?iso-8859-1?Q?0mFfjQBr5qkoOFqKk8Etpq/qL6gSZEg3MqVXyhWDBSUsdhVwGLfCx4fvOi?= =?iso-8859-1?Q?SVpC/4+9WRs6/pwAT4SSry0Frpulb62fOJAnGj6UbpYPVriJvNS3OSzlUX?= =?iso-8859-1?Q?q2sP6JEZQEmxBibRJ4OnigRL6Ta2//awP9MXQoMXF5bslRSd4Bmr0GKVZY?= =?iso-8859-1?Q?gvO7WCBVN1F1gayQb6on0AzTHRZCVEehXgjdZF7jrG+Wf8RCJxlU4DGjau?= =?iso-8859-1?Q?ZidHeKaqenKOp3rjf8U2M4gPCxEEc/gn4hOXx4Jhb4+xWBlKsmR+k0E5WW?= =?iso-8859-1?Q?LSbRUHP0W+pWWLJuF5iVrCnY/WD6Ua7w+MzAAacWvxo4hADJ/VbmHnbAQR?= =?iso-8859-1?Q?t83LrIs1jmtpb7YZ6RX9mqNEeUWWZY6aiIL1J2HYyZHAECgDf5iHRMgIC3?= =?iso-8859-1?Q?UZO7YD6+Yx/TRhoScEAJDK73Oa5V2GzRBxo+gJGmeS5JK39F1FisDKAhcB?= =?iso-8859-1?Q?Y8kH4/H24g8gI84KvMp+Go1ioiQwYVRVYiK/Y/UgMjpF0WCAuFebCw07bM?= =?iso-8859-1?Q?3mmnCNVTB53mW/YO08k13BnRCvOK/X3rjrbUapUGWuuVw0JhJ8ZvBsR7cv?= =?iso-8859-1?Q?50ep0IvCkim81A1cA0Q3mlM2Ndl5sdwIHrpBQKaQoaCol8rRnpHqNqAH7W?= =?iso-8859-1?Q?Tqm++TxrHtNOOKvwjl1M/pwT9Xs8yWdclQK7l2sJUZcBbhFuDj3ES+80Z0?= =?iso-8859-1?Q?2kcZp6VYo4jFsrYHrvR01MlPt+OYfdV/4LFJF7wFFjuUGsqyfDZpt2vPLG?= =?iso-8859-1?Q?mLCLq6uaCorkZB7ujf7x/tb+8a4cJPFd8MH2HjddrSW8I+YhpfmAv+r7Z3?= =?iso-8859-1?Q?TrudqBOUc751i1mumKY/bh40f4c/LWC/etj77MwOqPv/IS1yyWrEu/LTp4?= =?iso-8859-1?Q?fPnVLHZ5Rg=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: czZXOIbOvmTKIwVXOXB5zF6MjCqBSgc78aK8Dkpl40qhYsjY5eK/a5upz0jUCcIrLhBRoKb4DC8e/oYpCkUO04kOnUengJTRYdLUTg+OGJQlFLYm2g18dKmMaPrR9JtSGbPIu52qe5XLm+SkUfctOilwGg1/OlcIbGVajN0IS5G5gVdVjb8pVNieYrL/lr5LoKoMXeDDfD83XQrDdxtrmLwP9MqgYkyda0tSWq9y8AzSjZ3keaVTdrv2Wx+YYUlfWrJYa1grNGe0g5tQvxGh1IWaS6Rxiz54FZ9AV9GqPhPHOXjol6NmlZ3Gec0IfxpjxSNHBHb3rmkUwZYqjA6aBw== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYPPR06MB8206.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f009c84-72c3-45ec-02d3-08de99fbe427 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2026 08:00:27.6149 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hBp4j80pb2Ez1UYtqkidiaii7XrKCfPNY6r0CK2cnKQ8dL9MX00gJkBXpBYHiMrtGMQvr2F54IZuwxYsdicz8wGg2YCiYg+7PrOKiMJ580s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB6745 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c40f::6; envelope-from=jamin_lin@aspeedtech.com; helo=SEYPR02CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1776153852580154100 Content-Type: text/plain; charset="utf-8" The EHCIfstn structure, defined according to EHCI spec section 3.7, is currently unused in the EHCI implementation. Remove it to reduce unused code and improve maintainability. Additionally, drop a block of disabled (#if 0) code in ehci_state_advqueue() that was never implemented. This code path is incomplete and has no functional impact. No functional change. Signed-off-by: Jamin Lin --- hw/usb/hcd-ehci.h | 7 ------- hw/usb/hcd-ehci.c | 11 ----------- 2 files changed, 18 deletions(-) diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h index 0ae8c06331..3aec0e047c 100644 --- a/hw/usb/hcd-ehci.h +++ b/hw/usb/hcd-ehci.h @@ -202,13 +202,6 @@ typedef struct EHCIqh { #define BUFPTR_SBYTES_SH 5 } EHCIqh; =20 -/* EHCI spec version 1.0 Section 3.7 - */ -typedef struct EHCIfstn { - uint32_t next; /* Standard next link pointer */ - uint32_t backptr; /* Standard next link pointer */ -} EHCIfstn; - enum async_state { EHCI_ASYNC_NONE =3D 0, EHCI_ASYNC_INITIALIZED, diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 57f930b099..5ea8461f70 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -1756,17 +1756,6 @@ static int ehci_state_fetchsitd(EHCIState *ehci, int= async) /* Section 4.10.2 - paragraph 3 */ static int ehci_state_advqueue(EHCIQueue *q) { -#if 0 - /* TO-DO: 4.10.2 - paragraph 2 - * if I-bit is set to 1 and QH is not active - * go to horizontal QH - */ - if (I-bit set) { - ehci_set_state(ehci, async, EST_HORIZONTALQH); - goto out; - } -#endif - /* * want data and alt-next qTD is valid */ --=20 2.43.0 From nobody Thu Apr 30 00:39:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1776153888; cv=pass; d=zohomail.com; s=zohoarc; b=cWW2M4GUee/Jwyrf4eguQZb4/Ybl7dmeYFpanWNoW1vIgVCBDaZK7qgtjkXW0MSFf8xBIIuqm/jQONZ1ov6V6HwcfD+7YDNbLP/EwEQyx+JTRff4roQaEoeia6ni072GS/uHBDnBEyB7zYYfIZP/yCloG09FxcX0hpUVphU+Dmc= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776153888; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=bTu2IAjLcue9nOqgFQF/jmkPRZ3iMUww9o8bDsUQs40=; b=BKrGDfAPwZy+qWTfoVQj9kU8AWNy5et+dkwiKw0no/SdIFIZOrgF5sIshmjYuXDab4bvn04EjpD7HCp/AC4ovwK1L0CCCvzGjVZdEHZYMWOBm2VN62zwFYyMvozAZFeluToQPPiKohH1U6mr65+TtQwiJ7rJ8xEgRTBcSRZBCvY= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776153888069894.8290200454605; Tue, 14 Apr 2026 01:04:48 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wCYhX-0003YB-4N; Tue, 14 Apr 2026 04:00:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYhP-0003Vp-8g; Tue, 14 Apr 2026 04:00:43 -0400 Received: from mail-koreacentralazlp170130006.outbound.protection.outlook.com ([2a01:111:f403:c40f::6] helo=SEYPR02CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYhL-0005mG-C8; Tue, 14 Apr 2026 04:00:41 -0400 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19) by TYZPR06MB6745.apcprd06.prod.outlook.com (2603:1096:400:45a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Tue, 14 Apr 2026 08:00:28 +0000 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9769.046; Tue, 14 Apr 2026 08:00:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=q/BKG2YJUOoylLGTzLMQmukcXEwCm9UhY0x5+4jR0kBIfEH6YYd7nqeMUeXhs57Wj+J9TyU0H9De7fg8k1Ek8hFwWOvb+qmt7s25ETVNzsN7wQpkc/5Apq0qJMiWJ1nHzU86GEuzSuB3E4FthA6qzy+KF2xq91eu5VNjhNdKQkgfcdBM5dkAw7DhvnqY6xvRm9dUIgBEXPe8/nPsbpAhZIojPUZCfj9stQvKq8NSq8vo6Qbn7hySG+Bc9+/GcgtuSrikEsemMmM5gsWPOlGDDLTgH0B+GG3QxYX7I5prTGDZxtY7l2hTbFzXJDLI2bxYxivaSZ0JJzlbN99r3xQB/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bTu2IAjLcue9nOqgFQF/jmkPRZ3iMUww9o8bDsUQs40=; b=xNQx8hvwyoV7ScGoAZc4juBFOr4iaSWdK4cigvV0uwI0tgT1nI+iN0ur9egisa6D8bEn69NYmzmWwyblM3jGoIJEXmoClPNpD3oVHu5g7MIk58SG481UCNOWFAt2a/wVX+NQ8WMTfKexq2DNTB6eJpIgozP01LDMSIE2gBA6xkSzfIAV5dRPeZyoTE1PviA2KfSmxPhOfAh1gb3QC83deQwdIcx5E6rYHVqdiXl6P4nCNN3Grti+Ny34c1WeluEnd+0pSCtnlfre5Oq3ChWQDpDwuVdL1e3dniCCBqs0jNAGwMVDFamFVrXlsilixlY8tw88IWfWwiadhxVGt2nG0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bTu2IAjLcue9nOqgFQF/jmkPRZ3iMUww9o8bDsUQs40=; b=d+U0S/PSbSUMGHCNSUV7SG5zmWUiki63DdrQQa9pQs3rEygOWRc8K/o/BbnHJFm88YMd6yXAsRNUsuvfldEuE7pRi7Vc4G+VDI8o1LvfNODVL1wlB4Iqd2BFSRH9Dk09Uc4evEF+f3n+IsE1XYTNljUZhUAFRe6fRVizcfAjQ2rGL4JWC4dYJ6Up9lvhLxP2wJmLjy0pvEdSAqr8e59vha8Lf7MjgxYsc7s6++/cyxocRdWGPQEObOuOtcOCErC/c9XnuVoWYUnFgJUSjZ4FYiOyenCMqD2Hok7mNpPZmEBbiEG8G2wFSXOJ2hS8Tu8te6vF2fE2F1PsnnmtlcZYFg== From: Jamin Lin To: =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , "flwu@google.com" , "nabihestefan@google.com" , =?iso-8859-1?Q?C=E9dric_Le_Goater?= Subject: [PATCH v2 02/17] hw/usb/hcd-ehci.h: Fix coding style issues reported by checkpatch Thread-Topic: [PATCH v2 02/17] hw/usb/hcd-ehci.h: Fix coding style issues reported by checkpatch Thread-Index: AQHcy+TCNOgV2TLDAkutiizYczb8+g== Date: Tue, 14 Apr 2026 08:00:28 +0000 Message-ID: <20260414080025.3005916-3-jamin_lin@aspeedtech.com> References: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYPPR06MB8206:EE_|TYZPR06MB6745:EE_ x-ms-office365-filtering-correlation-id: eae767dd-de83-4cce-d333-08de99fbe4d4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|7416014|376014|366016|1800799024|38070700021|22082099003|56012099003|18002099003; x-microsoft-antispam-message-info: j+RRBju21TgI6YcCKgESSJx9ImjX90yjAWAEUV8+1ku22X0AMfEBhFWFEoI8397JhqnVfyzuXWjIE1ZAlwdkJX3h3NBCa9tJXDnkjSFt3NUdDj1qo2LgfkJ9HNOhlfEbeOfmzHkn00ZAlBHKsc3Rd40jjBafjy+vUM7zmKbgQuGDlM5incIIlkbBXVE10Qjs7E5E0ENWHx2LdIcUxKHzsH6QLIIp7+6zwnL1gTbtG/f1p2N3Dlzrgj5j7fdnL4NGyZcUS7j2ZnzbOF7l4Z3DkRrHRJhobb3kR7Vx/d5i6fs2kNcterBj0ENH7bMsswhi7kPVRbpxk1aVG3bfFkr7nrZllVGRkabyuoCXtwcvJrIQMk+VyL2Doc13gPR0XwmvwWxxERtIv+7pVqdo7vM4huC7qZ3x0EwuWaFRBGvstKvi0fI76KSaFobuylv7dPXdNx45/qJgzwaEiw67C+FM+XRDHykESby+5FZxHIDss8KwW6Qm7HmelZnHL72y//AkkHuIvQ+dcYH5aBeyxnYVMGUNU/6I7Yt3joYRdILPLEw/8mfkGxuCWGZSZa9uRsUM3ljjVnt/ySXMZCm3y08WBWsFFGkVRnbaLaTDs0RXmLhEqgYvJzXhOSJJs2FaAt3CymJu6YZvrzusgnwNoR9lLyCfkK27cLaktvuxnDuqockfZXo3Pdh+3Xe0gvpLzXeCpcv/WXKhUVguTo8UB1XwG32rgrB0LpkHoU8dEO2YWxtVMn+OE0ufViksW1XLE06/Xn1tcOrmzBEXRwNKWhMW8C6fd0oPHyWKL3bFVcfYLoE= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(7416014)(376014)(366016)(1800799024)(38070700021)(22082099003)(56012099003)(18002099003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?7N/BU17QhaaHVmJAzacwYcW9udeTsn5FbWE8FOC/piLNWXL+Su1dslQZRf?= =?iso-8859-1?Q?BDGIXoGV4UZygH3vj+DdI4545Eg20cv9Vn50XcUlZae59j05S82x9zhl0f?= =?iso-8859-1?Q?zgZp7Drj8gD0+1x9Lxq0oDxDm1Mb0lzT3kwMSYhI3Op3e8C60/1G0VwQBw?= =?iso-8859-1?Q?pTXzBCCY6CL+CxafIB08gJd4bS0Cad47FuW0NP0yZJnAljAFjwtg1UAxg9?= =?iso-8859-1?Q?AiPnq3BJASd/6YdNeB13oS4EpjMA26ny+FnYVLqYglk7P7hI5CS7+JFq3j?= =?iso-8859-1?Q?ue4s8wmTpHlSGTjxOsqjEIAvaI2d2duDwErTYYwVw7w82BVY/VY927WPIo?= =?iso-8859-1?Q?JFLwQQjCcbK+MWfe6/mJ2vYohN0TGirPTp35fyB0WijR7SZ9YfzUXwmZbe?= =?iso-8859-1?Q?M3geGyrQ/IFID9nnxHEvDJbEaFFNOd6bYwknR/S/KQxnG30xc9eVHwUYhi?= =?iso-8859-1?Q?bdQO3hsaKObaEQdB0IoIoGf3OqFu+RaqkmcTcBzmNOPAbLlUYGXs36Vh/W?= =?iso-8859-1?Q?fLERfiktQ9fwdpqo95pa35D46On4Qvouf3n9ngs2kqPXt8kXYubZTAFcV7?= =?iso-8859-1?Q?GZdeP6S+HTL3gF3DYgvhGcPzzHPXtXtRsPpAPoJHt8mCNRUsgTdEZb0nv2?= =?iso-8859-1?Q?xkdqOBg/41lgvCH3AOtIbF0NdhpHbnnj4Y8AUudWsWw+m52f7HdaFIlcRU?= =?iso-8859-1?Q?9IC7MC/RVOYNQfkBlGbNDohRG3d8U2ABjMEhO1pz+DjGgRL0L8iCvl2rX3?= =?iso-8859-1?Q?/9qnK/oCcmXxZgiIYYAH2TYX8ZoFLc3cx/kXymPatlnqaaAPxRIi6Jr4d5?= =?iso-8859-1?Q?YXEcjRs1/ATUCOMuQJDP3xqdF7ntkwkEM2qugJCktc5BSodNQ5V6W/DBUk?= =?iso-8859-1?Q?xZX+QYubwjlDZftTKD3Rf88+5f+HsOCiqwVF7cgA58XN5HsGKsyMTiBgF4?= =?iso-8859-1?Q?u2NZaadJwHvD65OoQODG9kQLf6FVGuvt8jygSc7oGOsFV+47k52lqCHcXY?= =?iso-8859-1?Q?bey//ni4IgeKnJM4yDfqnFeannWwze18nJMLocdLo2wOr4UVxh7AQTbp6k?= =?iso-8859-1?Q?C/CuX0Rd6qKCC0e4ErPWQsSt8ldcrIu1uVo6M9LXqFHgz8iSrPqdFWfHW+?= =?iso-8859-1?Q?QODDg1X8OVc0VxFby40/sctsUrKEy6352B8fZYyvz1LIomB6XvkmsDdyOk?= =?iso-8859-1?Q?Q5kFsHyOgjfXWDUS+3v6CrbzT2h4MbkEl0F5SmWJLKNasmv4jxURIUJR70?= =?iso-8859-1?Q?eC37EhkLLM2gbCJyP8HdtYc6c3iWXK+d0oL3+CJfEW5bfWx/bHl9ZFBErq?= =?iso-8859-1?Q?sulnKzH3j+5X7SMYWT2MNbom5w0spuIGG8xWFTBY2qrI0OxnAymoBw653C?= =?iso-8859-1?Q?fZT2BKzKuh56E7l9uxqJR9etV/aHuV/LbSIL+zBk7lGbskISGjaXrEQYYC?= =?iso-8859-1?Q?b9kO7eGqSGjINc2dhvzF+vjnR9WR7KltykFC7Idw0R13zjN7t6bg6Nx6s6?= =?iso-8859-1?Q?QiD1bxa5o+R6+kex9lwPDVujriMBaWqHcAGRBFWLJN/j0OYU3eAOfj7G5G?= =?iso-8859-1?Q?0lUw+Tk1jb6BMbkC2qy28Jmyz3lJi35aKfDqY5XeAXOQEIB9pJgedWD+EF?= =?iso-8859-1?Q?l5w9CVWKUI9Gf6Env3iUKC5nxVcE/mWZjI0B4LJHc0oXfxn51GVJRew/xH?= =?iso-8859-1?Q?njtpUD19fQ9T0yPLbFGAcCrTet5/n9Dac0zNfOCXQGBYPpFPGElL6eZ6M5?= =?iso-8859-1?Q?JRQxtAIb3cOoc3bngsJEARhLjy1DWEQdVkVnLPfjVQvFi+abulOAc4xi5Z?= =?iso-8859-1?Q?SvZBJBD1dw=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: qkII6Q+OInMIryu+ISWAiocUFAYpqD7E5g9wP7ThRwzws9IMqWd70dEFpUzRQZ0D7l3TMpDJAVt1iiVos+ol1rPBfhvj24wTtP/E8JXltLyDQqnps+sEs0+GT6pUMvY/ioo6Aelser6+P+FHhYvkdOWFnNDknqI5ImmLp1qbiMaouoypWJNy/Tk+tsn15RauDYBjKzlfO3yRKzsE6NlnQv39/RDekYrBo7V3wGwQZAOB0ELcg2txSN5gdj/IE2IhDIi7GLZ6cRLj2ubLPAK7fr0s2LSEHrv2bIg4lya5xfqOLVxbiWAd3TlPDGygSve3bfKtoDKBAS1gtLl4ly8JmA== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYPPR06MB8206.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: eae767dd-de83-4cce-d333-08de99fbe4d4 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2026 08:00:28.7660 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lIm+AJ1a7Xvuuu3zubKBxS9g+XsgGB5oMzwK+Q3PxRyreQBuxIl5YFs8aD1DaY5dDXohgD0QuDxTSrlX4fAMQ7b2zHXmYM5S3TvhNNqlBdY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB6745 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c40f::6; envelope-from=jamin_lin@aspeedtech.com; helo=SEYPR02CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1776153889036158501 Content-Type: text/plain; charset="utf-8" No functional change. Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater --- hw/usb/hcd-ehci.h | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h index 3aec0e047c..736407fd52 100644 --- a/hw/usb/hcd-ehci.h +++ b/hw/usb/hcd-ehci.h @@ -43,7 +43,8 @@ typedef struct EHCIPacket EHCIPacket; typedef struct EHCIQueue EHCIQueue; typedef struct EHCIState EHCIState; =20 -/* EHCI spec version 1.0 Section 3.3 +/* + * EHCI spec version 1.0 Section 3.3 */ typedef struct EHCIitd { uint32_t next; @@ -74,7 +75,8 @@ typedef struct EHCIitd { #define ITD_BUFPTR_MULT_SH 0 } EHCIitd; =20 -/* EHCI spec version 1.0 Section 3.4 +/* + * EHCI spec version 1.0 Section 3.4 */ typedef struct EHCIsitd { uint32_t next; /* Standard next link pointer */ @@ -118,7 +120,8 @@ typedef struct EHCIsitd { uint32_t backptr; /* Standard next link pointer */ } EHCIsitd; =20 -/* EHCI spec version 1.0 Section 3.5 +/* + * EHCI spec version 1.0 Section 3.5 */ typedef struct EHCIqtd { uint32_t next; /* Standard next link pointer */ @@ -148,7 +151,8 @@ typedef struct EHCIqtd { #define QTD_BUFPTR_SH 12 } EHCIqtd; =20 -/* EHCI spec version 1.0 Section 3.6 +/* + * EHCI spec version 1.0 Section 3.6 */ typedef struct EHCIqh { uint32_t next; /* Standard next link pointer */ @@ -230,7 +234,8 @@ struct EHCIQueue { int async; int transact_ctr; =20 - /* cached data from guest - needs to be flushed + /* + * cached data from guest - needs to be flushed * when guest removes an entry (doorbell, handshake sequence) */ EHCIqh qh; /* copy of current QH (being worked on) */ @@ -268,7 +273,7 @@ struct EHCIState { */ uint8_t caps[CAPA_SIZE]; union { - uint32_t opreg[0x44/sizeof(uint32_t)]; + uint32_t opreg[0x44 / sizeof(uint32_t)]; struct { uint32_t usbcmd; uint32_t usbsts; --=20 2.43.0 From nobody Thu Apr 30 00:39:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1776153874; cv=pass; d=zohomail.com; s=zohoarc; b=EEY1zDBoy+nNBPmqHIZ/VraFg1cm/w+oEZYvlR/Md7gKRNE1YlnZtY024grSd4XlPUCOQnMaqbQRxQR9hNaRd+ot05iNUjdCP/ujkl5jzZmWV9M+WLWC+l0kM99SPLT1gLnP5V8bbGV/fnEiM/NP0jscA4NGJj0lRlNtR2zzUAU= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776153874; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=aCVYDin/aI2j3cdnv7i8SYpme0GrUJ0vo7kGdjFa8Bs=; b=JO1QPw2hHOhEX8xBGvJtset41s6bmd+vRLx9Wh+BtiCpXRwwm5fYp0tRjnrHPT5jEMppvE2eADmfORA0E4zYsXR1Nr4WQ87zuYkQGVjYhn3si6DM9IkM2tMzxfWtgP4sgLPx+6Ln2XKmZbcAVFLYWr8B8vZqvQZTh7mrtqPryk0= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776153874679194.1041478714195; Tue, 14 Apr 2026 01:04:34 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wCYhY-0003Zo-Ud; Tue, 14 Apr 2026 04:00:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYhW-0003Xi-36; Tue, 14 Apr 2026 04:00:50 -0400 Received: from mail-koreacentralazlp170130006.outbound.protection.outlook.com ([2a01:111:f403:c40f::6] helo=SEYPR02CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYhQ-0005mG-Or; Tue, 14 Apr 2026 04:00:49 -0400 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19) by TYZPR06MB6745.apcprd06.prod.outlook.com (2603:1096:400:45a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Tue, 14 Apr 2026 08:00:30 +0000 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9769.046; Tue, 14 Apr 2026 08:00:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MyWHAQHqLN4zLVLlYuZn/2VTd0acyS8KvfAAYrtd28TOMMXkyQ/NsoQYmMAMavkIvkimXmZM5Z+soBjGUZ+uZNuVkVqSwACbpAcXqo2WuIz9+w8+M3HmQ4CoNSzfiPA99kpSQ1rDUHgmjokjs9V4dzrtnSUVcL6kCw6bQpKoMPocXvxod0yux85F8a2daK6k1VR7iUAHSQp8QEAgogm/CUm0q89ULnfz2C7Ql+c4yqS8eGgbmpbH0i7ypDWIF4s3SlajeGM5JpKeclTE30F0Znr9Qg+7OzbDHpiNeAezBe3P4JfvxxrMKGT8mIM6rjgfS2ie8x/couoX3/9uydPUFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aCVYDin/aI2j3cdnv7i8SYpme0GrUJ0vo7kGdjFa8Bs=; b=vqYimjFGhOt53R2+AmDWrU9viwR269O6Dzp6ophOniaH4lrZulvc3YZBSPJXDyphSR1A9vTe2HtwT+2KSEEfo5hEYu9yuRjrilqnlLUOGM7HRnYl3S6HW2YiO3j+t7QAAXJk9P7E2xn+exKOj5SyPR8kIdushPIQb/HxzCLsGgdK8NSItzcrGiXEfK3tKPECHBRi6UYIjoapRT5vBYgMC0ViRmRTCBkt6D/L3Amiv2fri9abBXVCmWd284Run3FizoiVk6xGvL788vP8JUPQUGmTWnxzwzyhGNvil8LBm18ivLvPqW2fyfsUcxKo1+3FPxX0AF+gmxo2GPZ8YI8GYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aCVYDin/aI2j3cdnv7i8SYpme0GrUJ0vo7kGdjFa8Bs=; b=McGoGWTYdKK2jovOXuIf1wErc1BlgM6Dl+ccBn+2SU79A2r/xSTG8XPmtCbEp4UKxFJ3VzIIVBCC8QgdJkmuPD1VgHwzg0Qobu2j68Owzvth1cVt504enbmRrEezQHVbDgJ3mpVLyLf0GnxsDHdlmTZ5H5y/IcU454hPiH4ZcvsZg6tf34Qjo2v9F29BK8u9hI9eXqzkFRE66sQfTOGgZFxU38dIBqR/i6c1+HUAO06GNGQQcDJvmckclHqIQpQ4lzsseBGXEVnHwUlEauNT4O4u/8Fvl7R36uTLj/S2nzw5c5Egdnl9Xp10lMQB5HNJaEhVozb/OtYCKDk/hdTh8Q== From: Jamin Lin To: =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , "flwu@google.com" , "nabihestefan@google.com" Subject: [PATCH v2 03/17] hw/usb/hcd-ehci.c: Fix coding style issues reported by checkpatch Thread-Topic: [PATCH v2 03/17] hw/usb/hcd-ehci.c: Fix coding style issues reported by checkpatch Thread-Index: AQHcy+TDy0vA1uWMN0SiUxPy+4xIQQ== Date: Tue, 14 Apr 2026 08:00:29 +0000 Message-ID: <20260414080025.3005916-4-jamin_lin@aspeedtech.com> References: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYPPR06MB8206:EE_|TYZPR06MB6745:EE_ x-ms-office365-filtering-correlation-id: 6761a910-219b-423e-6d14-08de99fbe582 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|38070700021|22082099003|56012099003|18002099003|18096099003; x-microsoft-antispam-message-info: dIuRUMxPbsZ4Q4U1VXBkkxNMmOHac7SzELi/UA8eprneLW44C8IGO6TrAEwoBFpqJyXK7DZT5HDTat/iA7NjWjDHhTdS+6yiR/mzTRFMCgfdUj9Qk9SdzocxcjO78FRdlOuyTAoocjhjTmkSQBmFgbj9qU4vLohBrKuGvsJrTb8IX1W0oiOC4kZFVKWJ0b8QlgBztu/YegfZXB0freWMRQijis0S5UfVjjggiFBJJGVyLJ2amI369M/hW+/x9hLrE17gpGmOP/kcAF29mzinbLV7sGLibT99vHcbV1ZJzDoMbvil+H83V3CiM35ofkOtfPQBFgluursXhHBxh7nZ5nj7QqUgB2D0/LsXcoJu9lFjKyd6v0jIDDhyw8BDefz0Z7qkKcg9uLmq2TJXzGfw0wCAMRWNZEPH9K+YqUZAxDQnoaj9OP0w2e+WMz3JfiSR/tzLYReFQBh3ZMrJOnY8lXW0IOo+5EXPQY0rK9bhLaqwnIuDeQpyKnGbiIRa6vpZhWqTQT8vyhRvh942CNNvZ7JOFaXOQoVQnVBNEmVDO9ARhpOCxdvr1Y3ZQt3dmORk2Sqgi1hAxpOR3nwVmZwvuthg1mr+SJ0JQYXiKJDLQWmWwPtXvrj/jXLaqqbkAQ2bTH2FNgebFiNnn+pRguBe9+DuSHsqndvYgWX/dSUzRzsMJrfgfp27r7lmdN9TnYd3FWDkI9RXZl6UZ4YiWAyQeEMzx9aZP8JOudcY40CWUamtA9D7Sxprg883NsCvKW1aLOL6nvLOshqoWTW+myFxzZpPj/BHt7pu0qK5NQZ6Zf8= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700021)(22082099003)(56012099003)(18002099003)(18096099003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?CNQKpaobNnriYU0fKtBVFRpLN1YXJMoIi7JBZ3RxfCCUsp4FDGyB6Pk8aH?= =?iso-8859-1?Q?mOG9M1uynGQkblq2xrMC329NoulmTsbKmoINmha/H8ZVRnMWoLB90AywI4?= =?iso-8859-1?Q?f13jTomz0aCLgEnnQaodjecQlDr0HErwoRztS0/rc56V0OCCvhIl8+oVM1?= =?iso-8859-1?Q?FGFODwsqB3T6jyUotaD+ZcwPNac8mW/b2VfDFHgkDLiS+5d8dLLi8f6fQ+?= =?iso-8859-1?Q?BwdKacNSOoK8YrXC0RX3j9IOILfY7IxEc5VPkg+VIRUmz9X0h09xW9f3EL?= =?iso-8859-1?Q?wSfiGhE46ztk9TR0oEWo8xfQIG222nyi2UJclruS555TWOd+pMHfwvEOi9?= =?iso-8859-1?Q?zynOTFaT2tQJNlnurNpz3ucmxY3NvgMvZeZr03ClO2loWNgwadmPZSCg6C?= =?iso-8859-1?Q?LucWFVX7fd1OFAmH0PIcK+pJXsOWa/F99LyoAZ3MBhgQ/RZdzKZT1TIEjp?= =?iso-8859-1?Q?mMHX/cbylmz21lKK4g7o+lylZgL6ehFeqe285auyr8i2czBgVBky8lYW+b?= =?iso-8859-1?Q?GJIGuJIl7bnKlMlv/2Fs01iAYcL1+Jp9OI9LgOcTurQFxz3MvQ2b/DNJdJ?= =?iso-8859-1?Q?eRB6VOX8Qbwf91wYNsBIvs6Su/heDtfctYUVkVMi7Zx+XK5zXPyTUCmPQX?= =?iso-8859-1?Q?VeKn3tHNgAAQ/YNWi635rgDgX2nIaIqW8bdS5EqCr3OGSpVqZb6wNA+6XT?= =?iso-8859-1?Q?rG1pSLtyeVsomewmyyHn+l6qmo6NOVFphX6eebgRzkOIGtDvywcJuehuYz?= =?iso-8859-1?Q?U+OvywGOxSOtwuuSqYHzslOKdZZBThLoYzUgkuBWaIqZyP2/8i1fUhoebS?= =?iso-8859-1?Q?1npQ/E/1VP09Ify68lJSPXW8K6BpGxdPWkWNdK/gQHNz5TGmCqeKMHjYYi?= =?iso-8859-1?Q?Rj5zDV73sxqkrSTBfRXtcUhuRWDF8gyu/OBBJl8nd7RLnFRn+hi5A+rDia?= =?iso-8859-1?Q?aLZK016n3Derq7rJsp0d4cYVX0Nj1r/JasaSzD1ojznQuE8Pmj6212+fJo?= =?iso-8859-1?Q?8G7AhOpCwkjQ/8lHOXEMFqFGwCpJp+s/1rxxEK1Lt3LMileckSRFLgg/5U?= =?iso-8859-1?Q?yTAXE+dASdU7aSjy23QhyMU9uuq1ASBC6xZn4BK4fcaK1T/S/DWGfURmFI?= =?iso-8859-1?Q?3IUARCF5eXNs1Mj9LH7MyktEFenZmq2zxhFJ72smxuXYyE6SAZphIWglI3?= =?iso-8859-1?Q?6OQk9pEXF493B9rs9YnmlzX4I/+2WuUEQAo4R8nc6gmx7WvHR/Bsy+Dux5?= =?iso-8859-1?Q?xVMcQaOvpoUkWBbh0QjDM/N0Ft3zuuoc9xYyfADQr6QV9CAHPixY6wZXr7?= =?iso-8859-1?Q?REWZRx7YbSivCZc9C4falM0Xcb9jCm45TyXCHP3yN3AfUaDbYIHqLtJv2y?= =?iso-8859-1?Q?niYZl50V9Pb8jNmvkI2p9PJq/qQZNiD3je2MH/tz3US9Eo0DnBHtv75BoN?= =?iso-8859-1?Q?zFnT2lP8p2i3TPGfPryMbbAKOnLS7EyBbWn+Sws7znd4Hic68TSz2uPmhY?= =?iso-8859-1?Q?VldyROItYsvKsybWmbwszG8r4tCtq2yPU8YCQQoAYda/vPptUTUL9yVz3F?= =?iso-8859-1?Q?ciqKt93QzeBT/sA+5K5//NW+Ffx9d2ne1+A0p9AIwuZ1gkyS3fmMkNOzXW?= =?iso-8859-1?Q?4i3AvJJBa4XsOxIcd2EPQaEzRJ7bqnjflFF8IZylpm3d7oqFpLQIIJR3J1?= =?iso-8859-1?Q?bYQHk/3G3meOoPH9W28S96Kpr/aOF8EENCNmDA84LtINHSr2aORcMlYG3t?= =?iso-8859-1?Q?3LRYPxK2L6qdLkC+vMF9neU1fPyhGIDVMr2gwr4KlnlsHYSkvsHUsd0cvq?= =?iso-8859-1?Q?29cgPJ4P+g=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: v6P07gQwZrZx+vmzpYVFAjm+Dnrk09kvWn+2pIDLjm8gggKdHcWeW/lPSy2Z44gwlsXIM39EX0gCf1NG/zA9B0bzJQ2pxs04ekuPe0/eznvrnT2m70KaTEcTfh3wik1+8wY2f5STOZ/aDw5BgvzHHW65suwKXUz/jm9aYfZYPf1TWU898Bb9V+EoxtC7y3HytaDsgiaeg+MARgFp9MR4tgerWpi3FhsKKrZZeL+vPxiHF9YjfmCX/xH5gfzFf0tu101AVT8D0yM6vS4n1CasxkrdQARakULiOBHTS2CfCNeAHgWoy8HgBFDHVxZANIB0jsm/GKSKM8TlWuUc7Dl/Mg== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYPPR06MB8206.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6761a910-219b-423e-6d14-08de99fbe582 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2026 08:00:29.9379 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OdFzTXSkwqLzTQKTYMzLg8SJyquUOZQj1pCh+nJivJVfUynwo1eHtxM6eoLtTHadUZEbDwTfYzS5jRCt9LFczLZkDo+IHurhZ8QN62ev1Ew= X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB6745 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c40f::6; envelope-from=jamin_lin@aspeedtech.com; helo=SEYPR02CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1776153877276154100 Content-Type: text/plain; charset="utf-8" No functional change. Signed-off-by: Jamin Lin --- hw/usb/hcd-ehci.c | 126 +++++++++++++++++++++++++--------------------- 1 file changed, 69 insertions(+), 57 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 5ea8461f70..9b92384bac 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -41,21 +41,23 @@ #define FRAME_TIMER_NS (NANOSECONDS_PER_SECOND / FRAME_TIMER_FREQ) #define UFRAME_TIMER_NS (FRAME_TIMER_NS / 8) =20 -#define NB_MAXINTRATE 8 // Max rate at which controller issues i= nts -#define BUFF_SIZE 5*4096 // Max bytes to transfer per transaction -#define MAX_QH 100 // Max allowable queue heads in a chain +#define NB_MAXINTRATE 8 /* Max rate at which controller issues int= s */ +#define BUFF_SIZE (5 * 4096) /* Max bytes to transfer per transacti= on */ +#define MAX_QH 100 /* Max allowable queue heads in a chain = */ #define MIN_UFR_PER_TICK 24 /* Min frames to process when catching u= p */ #define PERIODIC_ACTIVE 512 /* Micro-frames */ =20 -/* Internal periodic / asynchronous schedule state machine states +/* + * Internal periodic / asynchronous schedule state machine states */ typedef enum { EST_INACTIVE =3D 1000, EST_ACTIVE, EST_EXECUTING, EST_SLEEPING, - /* The following states are internal to the state machine function - */ + /* + * The following states are internal to the state machine function + */ EST_WAITLISTHEAD, EST_FETCHENTRY, EST_FETCHQH, @@ -71,13 +73,13 @@ typedef enum { /* macros for accessing fields within next link pointer entry */ #define NLPTR_GET(x) ((x) & 0xffffffe0) #define NLPTR_TYPE_GET(x) (((x) >> 1) & 3) -#define NLPTR_TBIT(x) ((x) & 1) // 1=3Dinvalid, 0=3Dvalid +#define NLPTR_TBIT(x) ((x) & 1) /* 1=3Dinvalid, 0=3Dvalid */ =20 /* link pointer types */ -#define NLPTR_TYPE_ITD 0 // isoc xfer descriptor -#define NLPTR_TYPE_QH 1 // queue head -#define NLPTR_TYPE_STITD 2 // split xaction, isoc xfer descrip= tor -#define NLPTR_TYPE_FSTN 3 // frame span traversal node +#define NLPTR_TYPE_ITD 0 /* isoc xfer descriptor */ +#define NLPTR_TYPE_QH 1 /* queue head */ +#define NLPTR_TYPE_STITD 2 /* split xaction, isoc xfer descrip= tor */ +#define NLPTR_TYPE_FSTN 3 /* frame span traversal node */ =20 #define SET_LAST_RUN_CLOCK(s) \ (s)->last_run_ns =3D qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL); @@ -88,10 +90,10 @@ typedef enum { =20 #define set_field(data, newval, field) do { \ uint32_t val =3D *data; \ - val &=3D ~ field##_MASK; \ + val &=3D ~field##_MASK; \ val |=3D ((newval) << field##_SH) & field##_MASK; \ *data =3D val; \ - } while(0) + } while (0) =20 static const char *ehci_state_names[] =3D { [EST_INACTIVE] =3D "INACTIVE", @@ -472,8 +474,10 @@ static bool ehci_verify_pid(EHCIQueue *q, EHCIqtd *qtd) } } =20 -/* Finish executing and writeback a packet outside of the regular - fetchqh -> fetchqtd -> execute -> writeback cycle */ +/* + * Finish executing and writeback a packet outside of the regular + * fetchqh -> fetchqtd -> execute -> writeback cycle + */ static void ehci_writeback_async_complete_packet(EHCIPacket *p) { EHCIQueue *q =3D p->queue; @@ -733,7 +737,7 @@ static void ehci_detach(USBPort *port) ehci_queues_rip_device(s, port->dev, 0); ehci_queues_rip_device(s, port->dev, 1); =20 - *portsc &=3D ~(PORTSC_CONNECT|PORTSC_PED|PORTSC_SUSPEND); + *portsc &=3D ~(PORTSC_CONNECT | PORTSC_PED | PORTSC_SUSPEND); *portsc |=3D PORTSC_CSC; =20 ehci_raise_irq(s, USBSTS_PCD); @@ -858,7 +862,7 @@ void ehci_reset(void *opaque) * Do the detach before touching portsc, so that it correctly gets sen= d to * us or to our companion based on PORTSC_POWNER before the reset. */ - for(i =3D 0; i < EHCI_PORTS; i++) { + for (i =3D 0; i < EHCI_PORTS; i++) { devs[i] =3D s->ports[i].dev; if (devs[i] && devs[i]->attached) { usb_detach(&s->ports[i]); @@ -877,7 +881,7 @@ void ehci_reset(void *opaque) s->astate =3D EST_INACTIVE; s->pstate =3D EST_INACTIVE; =20 - for(i =3D 0; i < EHCI_PORTS; i++) { + for (i =3D 0; i < EHCI_PORTS; i++) { if (s->companion_ports[i]) { s->portsc[i] =3D PORTSC_POWNER | PORTSC_PPOWER; } else { @@ -942,8 +946,9 @@ static void handle_port_owner_write(EHCIState *s, int p= ort, uint32_t owner) uint32_t *portsc =3D &s->portsc[port]; uint32_t orig; =20 - if (s->companion_ports[port] =3D=3D NULL) + if (s->companion_ports[port] =3D=3D NULL) { return; + } =20 owner =3D owner & PORTSC_POWNER; orig =3D *portsc & PORTSC_POWNER; @@ -988,7 +993,7 @@ static void ehci_port_write(void *ptr, hwaddr addr, trace_usb_ehci_port_reset(port, 1); } =20 - if (!(val & PORTSC_PRESET) &&(*portsc & PORTSC_PRESET)) { + if (!(val & PORTSC_PRESET) && (*portsc & PORTSC_PRESET)) { trace_usb_ehci_port_reset(port, 0); if (dev && dev->attached) { usb_port_reset(&s->ports[port]); @@ -1065,8 +1070,10 @@ static void ehci_opreg_write(void *ptr, hwaddr addr, break; =20 case USBSTS: - val &=3D USBSTS_RO_MASK; // bits 6 through 31 are RO - ehci_clear_usbsts(s, val); // bits 0 through 5 are R/WC + /* bits 6 through 31 are RO */ + val &=3D USBSTS_RO_MASK; + /* bits 0 through 5 are R/WC */ + ehci_clear_usbsts(s, val); val =3D s->usbsts; ehci_update_irq(s); break; @@ -1131,8 +1138,7 @@ static void ehci_flush_qh(EHCIQueue *q) put_dwords(q->ehci, addr + 3 * sizeof(uint32_t), qh + 3, dwords - 3); } =20 -// 4.10.2 - +/* 4.10.2 */ static int ehci_qh_do_overlay(EHCIQueue *q) { EHCIPacket *p =3D QTAILQ_FIRST(&q->packets); @@ -1145,8 +1151,7 @@ static int ehci_qh_do_overlay(EHCIQueue *q) assert(p !=3D NULL); assert(p->qtdaddr =3D=3D q->qtdaddr); =20 - // remember values in fields to preserve in qh after overlay - + /* remember values in fields to preserve in qh after overlay */ dtoggle =3D q->qh.token & QTD_TOKEN_DTOGGLE; ping =3D q->qh.token & QTD_TOKEN_PING; =20 @@ -1170,7 +1175,7 @@ static int ehci_qh_do_overlay(EHCIQueue *q) } =20 if (!(q->qh.epchar & QH_EPCHAR_DTC)) { - // preserve QH DT bit + /* preserve QH DT bit */ q->qh.token &=3D ~QTD_TOKEN_DTOGGLE; q->qh.token |=3D dtoggle; } @@ -1397,9 +1402,7 @@ static int ehci_execute(EHCIPacket *p, const char *ac= tion) return 1; } =20 -/* 4.7.2 - */ - +/* 4.7.2 */ static int ehci_process_itd(EHCIState *ehci, EHCIitd *itd, uint32_t addr) @@ -1411,13 +1414,13 @@ static int ehci_process_itd(EHCIState *ehci, =20 ehci->periodic_sched_active =3D PERIODIC_ACTIVE; =20 - dir =3D(itd->bufptr[1] & ITD_BUFPTR_DIRECTION); + dir =3D (itd->bufptr[1] & ITD_BUFPTR_DIRECTION); devaddr =3D get_field(itd->bufptr[0], ITD_BUFPTR_DEVADDR); endp =3D get_field(itd->bufptr[0], ITD_BUFPTR_EP); max =3D get_field(itd->bufptr[1], ITD_BUFPTR_MAXPKT); mult =3D get_field(itd->bufptr[2], ITD_BUFPTR_MULT); =20 - for(i =3D 0; i < 8; i++) { + for (i =3D 0; i < 8; i++) { if (itd->transact[i] & ITD_XACT_ACTIVE) { pg =3D get_field(itd->transact[i], ITD_XACT_PGSEL); off =3D itd->transact[i] & ITD_XACT_OFFSET_MASK; @@ -1513,8 +1516,9 @@ static int ehci_process_itd(EHCIState *ehci, } =20 =20 -/* This state is the entry point for asynchronous schedule - * processing. Entry here constitutes a EHCI start event state (4.8.5) +/* + * This state is the entry point for asynchronous schedule + * processing. Entry here constitutes a EHCI start event state (4.8.5) */ static int ehci_state_waitlisthead(EHCIState *ehci, int async) { @@ -1531,7 +1535,7 @@ static int ehci_state_waitlisthead(EHCIState *ehci, = int async) ehci_queues_rip_unused(ehci, async); =20 /* Find the head of the list (4.9.1.1) */ - for(i =3D 0; i < MAX_QH; i++) { + for (i =3D 0; i < MAX_QH; i++) { if (get_dwords(ehci, NLPTR_GET(entry), (uint32_t *) &qh, sizeof(EHCIqh) >> 2) < 0) { return 0; @@ -1564,8 +1568,9 @@ out: } =20 =20 -/* This state is the entry point for periodic schedule processing as - * well as being a continuation state for async processing. +/* + * This state is the entry point for periodic schedule processing as + * well as being a continuation state for async processing. */ static int ehci_state_fetchentry(EHCIState *ehci, int async) { @@ -1674,7 +1679,7 @@ static EHCIQueue *ehci_state_fetchqh(EHCIState *ehci,= int async) =20 #if EHCI_DEBUG if (q->qhaddr !=3D q->qh.next) { - DPRINTF("FETCHQH: QH 0x%08x (h %x halt %x active %x) next 0x%08x\n", + DPRINTF("FETCHQH: QH 0x%08x (h %x halt %x active %x) next 0x%08x\= n", q->qhaddr, q->qh.epchar & QH_EPCHAR_H, q->qh.token & QTD_TOKEN_HALT, @@ -1924,8 +1929,10 @@ static int ehci_state_execute(EHCIQueue *q) return -1; } =20 - // TODO verify enough time remains in the uframe as in 4.4.1.1 - // TODO write back ptr to async list when done or out of time + /* + * TODO verify enough time remains in the uframe as in 4.4.1.1 + * TODO write back ptr to async list when done or out of time + */ =20 /* 4.10.3, bottom of page 82, go horizontal on transaction counter =3D= =3D 0 */ if (!q->async && q->transact_ctr =3D=3D 0) { @@ -2036,7 +2043,7 @@ static void ehci_advance_state(EHCIState *ehci, int a= sync) int again; =20 do { - switch(ehci_get_state(ehci, async)) { + switch (ehci_get_state(ehci, async)) { case EST_WAITLISTHEAD: again =3D ehci_state_waitlisthead(ehci, async); break; @@ -2115,21 +2122,20 @@ static void ehci_advance_state(EHCIState *ehci, int= async) ehci_reset(ehci); again =3D 0; } - } - while (again); + } while (again); } =20 static void ehci_advance_async_state(EHCIState *ehci) { const int async =3D 1; =20 - switch(ehci_get_state(ehci, async)) { + switch (ehci_get_state(ehci, async)) { case EST_INACTIVE: if (!ehci_async_enabled(ehci)) { break; } ehci_set_state(ehci, async, EST_ACTIVE); - // No break, fall through to ACTIVE + /* No break, fall through to ACTIVE */ =20 case EST_ACTIVE: if (!ehci_async_enabled(ehci)) { @@ -2153,7 +2159,8 @@ static void ehci_advance_async_state(EHCIState *ehci) ehci_set_state(ehci, async, EST_WAITLISTHEAD); ehci_advance_state(ehci, async); =20 - /* If the doorbell is set, the guest wants to make a change to the + /* + * If the doorbell is set, the guest wants to make a change to the * schedule. The host controller needs to release cached data. * (section 4.8.2) */ @@ -2180,13 +2187,13 @@ static void ehci_advance_periodic_state(EHCIState *= ehci) uint32_t list; const int async =3D 0; =20 - // 4.6 + /* 4.6 */ =20 - switch(ehci_get_state(ehci, async)) { + switch (ehci_get_state(ehci, async)) { case EST_INACTIVE: if (!(ehci->frindex & 7) && ehci_periodic_enabled(ehci)) { ehci_set_state(ehci, async, EST_ACTIVE); - // No break, fall through to ACTIVE + /* No break, fall through to ACTIVE */ } else break; =20 @@ -2210,7 +2217,7 @@ static void ehci_advance_periodic_state(EHCIState *eh= ci) =20 DPRINTF("PERIODIC state adv fr=3D%d. [%08X] -> %08X\n", ehci->frindex / 8, list, entry); - ehci_set_fetch_addr(ehci, async,entry); + ehci_set_fetch_addr(ehci, async, entry); ehci_set_state(ehci, async, EST_FETCHENTRY); ehci_advance_state(ehci, async); ehci_queues_rip_unused(ehci, async); @@ -2235,7 +2242,8 @@ static void ehci_update_frindex(EHCIState *ehci, int = uframes) ehci_raise_irq(ehci, USBSTS_FLR); } =20 - /* How many times will frindex roll over 0x4000 with this frame count? + /* + * How many times will frindex roll over 0x4000 with this frame count? * usbsts_frindex is decremented by 0x4000 on rollover until it reache= s 0 */ int rollovers =3D (ehci->frindex + uframes) / 0x4000; @@ -2315,8 +2323,9 @@ static void ehci_work_bh(void *opaque) ehci->async_stepdown++; } =20 - /* Async is not inside loop since it executes everything it can once - * called + /* + * Async is not inside loop since it executes everything it can once + * called */ if (ehci_async_enabled(ehci) || ehci->astate !=3D EST_INACTIVE) { need_timer++; @@ -2334,15 +2343,18 @@ static void ehci_work_bh(void *opaque) } =20 if (need_timer) { - /* If we've raised int, we speed up the timer, so that we quickly - * notice any new packets queued up in response */ + /* + * If we've raised int, we speed up the timer, so that we quickly + * notice any new packets queued up in response + */ if (ehci->int_req_by_async && (ehci->usbsts & USBSTS_INT)) { expire_time =3D t_now + NANOSECONDS_PER_SECOND / (FRAME_TIMER_FREQ * 4); ehci->int_req_by_async =3D false; } else { - expire_time =3D t_now + (NANOSECONDS_PER_SECOND - * (ehci->async_stepdown+1) / FRAME_TIMER_FR= EQ); + expire_time =3D t_now + + (NANOSECONDS_PER_SECOND * (ehci->async_stepdown + 1) / + FRAME_TIMER_FREQ); } timer_mod(ehci->frame_timer, expire_time); } --=20 2.43.0 From nobody Thu Apr 30 00:39:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1776153800; cv=pass; d=zohomail.com; s=zohoarc; b=KYa8WWCkEf7ZoBap26V8OG2kAmxskQygDRJ/pdHVKlGHlworkaX+BetWtWHkBXBg1rgS9wFBI7WeQKEj1x5is+zRWdL2BUXSi1HhbigQjRswYAersWnD/2Y8DuoVTUfuJexH5N/zTFyuCl2H9J+Uw8AbL4UblyVnz7pbQEjf2SE= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776153800; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=DPUuYGkfIR6j1AbiEpDRbnOQ1Z8Qp5SXYAhDVwcsM6k=; b=dJ1Ndy4nRMat9qd/R1Os9mcMt5CvfRreWlwi6CYrE2wFf+26I9lNg1NT6vEyQ1zolUK2zsx/ojZBfYDnIa2qRb6TrZ58/ZZTVcwQOPNv1h95d7KLw/LC1LqcTUPElKBS/LoxPix4z+LVgPhAIB85NNV9PDBWYIF8LQVYbhEq8tg= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776153800930809.6821605228822; Tue, 14 Apr 2026 01:03:20 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wCYha-0003bP-UT; Tue, 14 Apr 2026 04:00:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYhX-0003Yd-P3; Tue, 14 Apr 2026 04:00:51 -0400 Received: from mail-koreacentralazlp170130006.outbound.protection.outlook.com ([2a01:111:f403:c40f::6] helo=SEYPR02CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYhT-0005oL-OR; Tue, 14 Apr 2026 04:00:51 -0400 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19) by TYZPR06MB6745.apcprd06.prod.outlook.com (2603:1096:400:45a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Tue, 14 Apr 2026 08:00:31 +0000 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9769.046; Tue, 14 Apr 2026 08:00:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=o7g+Z3inz6QzgxRht09uHgjFx6bBEPYUXc8/YT1EmhDdDyIsoUo4/e9axwyY+RilMbrxtskuaLtkldJM1SfdO/ozpnqnEGP7L5dLPSXTYWhxKole2ZlN7YvDaeT0FMbca113Lu56Nl4QeMKAsevEZSzHa/csc/AsHxOp9KxIcVxIhZ64dsqEA6w40vzDJecnSH3shM0sCCGSObh0Mkz6UsGhj6QLQsChX3J2wxCgRVkyUkXGE9P/2RW850BA3nDgFx/HfseCkdQ5u3jUQZDRSCJEvqoKlb2Ja+Kn+cLCKin6qFN6WhwF43gUDJ15kl6kri8Hz5QSqzJC2KszrcWpHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DPUuYGkfIR6j1AbiEpDRbnOQ1Z8Qp5SXYAhDVwcsM6k=; b=g0/+gJiPdZh2YUkk3w4ip/ssVO8nV+CWn/hh1c+rDidVj3BAKNY0P2LAPXPXXAXx5IVq+5J35NFWaY4Iqw0rggxKy30iTHyqVwWHPu/Y+e3lZRdcSwO38jFX4qB1taTazSPkvFNxnwnRInF6NSItBYFBm07qzzpvXqfSFbZUWoieM1ktgEj+oOuQdoZ7PrB4zXzqoX4Ovpcva9NNfRJQuOIIobnmF/c2KHJdUdafO1J4q1zcM3Dx0h8N9igw6pgGzpiNIC264o/gWZQFBqeKVWiTIZSfki5VZhANomdmoHsq3uMYd+GoD+1JbEdi0oX8nofM9JWn4TxcaU+xWLLjKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DPUuYGkfIR6j1AbiEpDRbnOQ1Z8Qp5SXYAhDVwcsM6k=; b=JKLD+RZ04GFuqLVXVkpyaN+hDWn4DfcCYyNXi9w7TaJ7mR91t5m/xsyu3Sp1efTzbI9yRJqPCD9Fu6tl5unhXu5THiFw+rUon4Jh9SD5Fq//lqfIFZFA4LCQcI7CaqtUriGPJ3zVTKdMYyMnp43URnuhZ/n6b6TBZiW6X37MnROHj2y1q4dmqDtKXxS/OA9tnysEZsRVghUnyN2s1bh9sTlI9jXt8HazBXiD15CzdBpj0x6WPtg3VNN2kNftXQgsQBoK94BRHjo/hlLsZ5KLUpVYLCMc7qtn+eapJxJjiIMsReIbKCODEtYzBnsA5R8EbZoy6T19FryfnUAO8JE2Sg== From: Jamin Lin To: =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , "flwu@google.com" , "nabihestefan@google.com" Subject: [PATCH v2 04/17] hw/usb/hcd-ehci.c: Replace fprintf(stderr, ...) with qemu_log_mask(LOG_GUEST_ERROR) Thread-Topic: [PATCH v2 04/17] hw/usb/hcd-ehci.c: Replace fprintf(stderr, ...) with qemu_log_mask(LOG_GUEST_ERROR) Thread-Index: AQHcy+TDZKmGzP6rPU6jtNcClXZIGg== Date: Tue, 14 Apr 2026 08:00:31 +0000 Message-ID: <20260414080025.3005916-5-jamin_lin@aspeedtech.com> References: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYPPR06MB8206:EE_|TYZPR06MB6745:EE_ x-ms-office365-filtering-correlation-id: fdbfc5b8-6845-41ce-1399-08de99fbe630 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|38070700021|22082099003|56012099003|18002099003; x-microsoft-antispam-message-info: FCMEUqbkZJQopC+Z3SHbNcjYlC4KvgrjGYlloTCxDqdLtU3LKIG957xjrDxdj2LBJZ7LYGs6Y0NdFfUQR1JPW0NTMo+tam8GlWmK0CBo96iLF2mrORtt8Q/FsDUfEKKNYgu7N1LB9jWAtd8wH2AShCIJJoJ+aeUPhB6ud/bnfz1KMDgRAqmBb9qYmf94lofj32sKhUYpq1O7gxDFcRj7i5yC7y2TrqVmaORFmq9IhydimGM0cSPvnj6H/1FgvwOY7SbPlwhNw+UGAkt65j82akVtm54RcYYjRmDMlZFdTdOnKj1/23AimvUrU4w6ZdNJ7U625WXkb9J1vBJ4XKwn+st5CsC4sQYGA3y9ujZUy5CJ9bzDsicFlQxR8mxhA6i1k+0wZQrXP/HbQxXxif9cyjCAh0VJI4C/xih5ztKhAS98gR2zoUCz1rTGSubNniiQoU9ltO5rNId22YLtDGtyrALGh5DHQOOCVgUWf49kVwhYVnsN7JYd9uEyNgoytic1SpMxz7iLosy6dk1xkRvEz4AuutGyI651zk5Q6263jc4wXxzcK1wvR+Kx5pVv6AyyAXEG0OsvqIGnEqbKumQnn+H5VKqetWKFwHFpsLpSnhcQ4yB948/aV3vfms95cmIYIC/HLSoZEw9OPW4bE7POC/LgISbim6TRlIPqqwWPjZVi+oCv0zafEFyb3OMxiC2RtXRvZGQu2c391++QJpuNIk4wgFnuPBwu/GyiLVwz1gaYR8uxP/JaAaPWjwzB5GTz6fgVE/Y2SVM/d30AxsJlcR5Fo7sZuEbOO5U+XXXaHys= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700021)(22082099003)(56012099003)(18002099003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?IGNC8zogezfWFKSUmMvPwV+0tyIUUGhrA+EkcPG21XFukP6A6u8WZusevm?= =?iso-8859-1?Q?Reury8erif56lNpwOAxWoBrv3WW5yhiPAc4kD7fMDs62Hq9m7nR/+/DX2Z?= =?iso-8859-1?Q?7GytBbrU90KUyt2U62+cs5AH8NitP8W/hgjk18//w4Zs9O8te8rCWVPsCE?= =?iso-8859-1?Q?xlzzSNFl1zdt8Uxql30KbDIvmsm8UmgOgwt6l7ykBazPZl1k9J8qban+8p?= =?iso-8859-1?Q?uMze3sWly1PnO5tdxEYIKJLFiMfuhl0qb/vwYqMxpnkCjUTbJho80WLVfO?= =?iso-8859-1?Q?OzLQIdJ8ytRH9RXW7eqWJQyKShMA2ug6IEycQZqzdnlB69HctwdaWxLwrt?= =?iso-8859-1?Q?JhmO5f3WYc9VLA8QwbvEMU5LhPq7qTiiPMtOOYczMX2kWYufLbUC6HpfPm?= =?iso-8859-1?Q?CB6cpKIotENLwNifGhWqfXi7MtPAYU1wkSgqZlPnjL+4Nddw4dupmV7Bnp?= =?iso-8859-1?Q?jvVDI/OxxuwqJcOgJqG8jrHOnrlGudPtL2nH9M9cIHuaBllZ4MOyJh1tF5?= =?iso-8859-1?Q?gFP27nmQEdf7p+scz55KCnAbu2kUNh4utu94wZ7zy91E2SwFKX1s+rgMzA?= =?iso-8859-1?Q?w3FJgTT5uYbr11T3EQKayHC1hy1PZGq2ePnQ/xhaf24ixlMzsnStWDntJH?= =?iso-8859-1?Q?J8XRWLeVMpJ+1ONkQXZ1HJJniuzkjrNqmTfHS7LHCBgkltV6Qxs/4uL0ms?= =?iso-8859-1?Q?dVd2MThVS6/rsmmegmLTKEpnBeVaWpdSquTWEFZT+o/6orHWd5u6lgPqib?= =?iso-8859-1?Q?0HCxULvXgHJOROA7WZY6rtZhRVjXOFpah2+70fF9fP+5gSSbSYy46gaHL7?= =?iso-8859-1?Q?LNxog1J6fo3gLFd6DKQUzKn6j3WLNSTP6q61Rsm0lJYoIDjGajN732UPuv?= =?iso-8859-1?Q?76Ocel91D+CpMAeybpO5KBHmuVfiDBrzIYI1pH9zkGrG86yk0BC6vibjD8?= =?iso-8859-1?Q?QUvhQG3z6b25HdiiS2Szpsgwo6DRfhiiUM9PzZ6dsqZbfJ2X+MllX2+Hh0?= =?iso-8859-1?Q?ITzn4W+wGMs9uG22EC2RTIRN8c1ltpoWBp4xZIKKlY6q1JC6Qp2p42hvhg?= =?iso-8859-1?Q?q6qDYwYmI0nm3IM/vIdDW7K2idUtaCR3VlTcnG2GTf+3JGZfK1IBPdWZiG?= =?iso-8859-1?Q?UAJaK29LcyScaVqrsb1lmWfEBsJfITIZGwSDUAR7GCQHi5dftbxCsxzD6E?= =?iso-8859-1?Q?xzlVaNu5tmUdO8MHwlaDLnuBpvoPvgcH0SSkAiKGfnJrV9z74FMkGIjY0E?= =?iso-8859-1?Q?erNf8AXtlLfzfSqVQCNT2f2jUhEoDTd76AYQ3A6LErVotm/vWrAlNPxc7D?= =?iso-8859-1?Q?0Z6B4QRq7nPNelCTWhuRdX4oyTvm2ZALHj2wqzPJwRg2KV3+glGzsyNgzY?= =?iso-8859-1?Q?4It9Cj8wggy1cWDpKoO6vTNVUG+KC3Kb4TpZrNAfSoshNA1BO7AqPTzvdr?= =?iso-8859-1?Q?2nColzgJZ40uW+LacKpez22PmZgaYBL3uRG8HTVYj+HDBG7JVuwc21+770?= =?iso-8859-1?Q?s6//KA9moE9Xncv0Mi8dDma+z4lsYgcCq4Hiy2jGXVftNMtgsPxKBOxScH?= =?iso-8859-1?Q?p6O9NI+/hr3z6ToyW/t/Hpxf6Hb12UQxL2vDdppZLZ9VOaq76wMXgn9GNH?= =?iso-8859-1?Q?VfzqF8yYKmMLuJMB0bNInPQTj4XqvNSjobPLvAn4z1/Z5IGWeiJ6wQNKSr?= =?iso-8859-1?Q?+q5kEmDcDbpT1bhshM7Um3Sv+O8S389bsEw92qHhJF2+bvJm1k7qlg2PWN?= =?iso-8859-1?Q?tX0O8ZLxwbMexYpr9PicXUTXANFKCvcSBqnyWOH7MAXpndmrU9wSdOWi4S?= =?iso-8859-1?Q?eYjGadbYgg=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: ct+FEKADV+dqXqlD9N+H4xNHJtGkEbF+Aw8C7SNyx/4DtYIdOCdeaGlY9Q+vykL4ytHXhQzryJsM+pzEwDCQkt7n12WsJljK38arKi4eaD2MNl6SBvOd4BD95bb/EhQ9ObWXuJ2VO9KGIDrkBiuW9O+IrVXsegmwPaUMaZ0WX0X0f9zZNkOSP3VXldBxkuX9OldN5eqguM40YK8Qbf1zAUBf7uIv8ssmiT6sxQKcJzJsenQJom+lGhpDEt1aTvnmcHnrb5cJ1blwFJquJ5nwgHinFw6uzNOltTLF9btTy7NBBy3SxTh0byGACTH1tqsoGeZ4f1ts8ISySCXbea3sFg== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYPPR06MB8206.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fdbfc5b8-6845-41ce-1399-08de99fbe630 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2026 08:00:31.0485 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EllFd4w8eATkRgTeXzrWOBeazI+JbVSiNg45zUZzTDbwUdkTepJdsKE9OQte/xrLWzMLRveORZ+gKTCC9ztrjnisRhrv5gm7/jx+RShd1j8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB6745 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c40f::6; envelope-from=jamin_lin@aspeedtech.com; helo=SEYPR02CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1776153804314154100 Content-Type: text/plain; charset="utf-8" Replace direct fprintf(stderr, ...) calls with qemu_log_mask() using LOG_GUEST_ERROR in the EHCI controller implementation. Direct writes to stderr are discouraged in QEMU as they bypass the logging framework and cannot be filtered or controlled at runtime. Using qemu_log_mask() ensures that guest-visible errors are properly categorized and can be managed via QEMU logging options. All affected messages correspond to guest-triggerable error conditions, so LOG_GUEST_ERROR is used consistently. This change improves integration with QEMU's logging infrastructure and aligns with upstream coding guidelines. Signed-off-by: Jamin Lin --- hw/usb/hcd-ehci.c | 43 +++++++++++++++++++++++++------------------ 1 file changed, 25 insertions(+), 18 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 9b92384bac..bebd137f94 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -36,6 +36,7 @@ #include "qemu/error-report.h" #include "qemu/main-loop.h" #include "system/runstate.h" +#include "qemu/log.h" =20 #define FRAME_TIMER_FREQ 1000 #define FRAME_TIMER_NS (NANOSECONDS_PER_SECOND / FRAME_TIMER_FREQ) @@ -425,7 +426,7 @@ static int ehci_get_pid(EHCIqtd *qtd) case 2: return USB_TOKEN_SETUP; default: - fprintf(stderr, "bad token\n"); + qemu_log_mask(LOG_GUEST_ERROR, "bad token\n"); return 0; } } @@ -532,7 +533,7 @@ static void ehci_free_packet(EHCIPacket *p) } if (p->async =3D=3D EHCI_ASYNC_FINISHED && p->packet.status =3D=3D USB_RET_SUCCESS) { - fprintf(stderr, + qemu_log_mask(LOG_GUEST_ERROR, "EHCI: Dropping completed packet from halted %s ep %02X\n", (p->pid =3D=3D USB_TOKEN_IN) ? "in" : "out", get_field(p->queue->qh.epchar, QH_EPCHAR_EP)); @@ -1042,8 +1043,9 @@ static void ehci_opreg_write(void *ptr, hwaddr addr, =20 /* not supporting dynamic frame list size at the moment */ if ((val & USBCMD_FLS) && !(s->usbcmd & USBCMD_FLS)) { - fprintf(stderr, "attempt to set frame list size -- value %d\n", - (int)val & USBCMD_FLS); + qemu_log_mask(LOG_GUEST_ERROR, + "attempt to set frame list size -- value %d\n", + (int)val & USBCMD_FLS); val &=3D ~USBCMD_FLS; } =20 @@ -1101,7 +1103,7 @@ static void ehci_opreg_write(void *ptr, hwaddr addr, =20 case PERIODICLISTBASE: if (ehci_periodic_enabled(s)) { - fprintf(stderr, + qemu_log_mask(LOG_GUEST_ERROR, "ehci: PERIODIC list base register set while periodic schedu= le\n" " is enabled and HC is enabled\n"); } @@ -1109,7 +1111,7 @@ static void ehci_opreg_write(void *ptr, hwaddr addr, =20 case ASYNCLISTADDR: if (ehci_async_enabled(s)) { - fprintf(stderr, + qemu_log_mask(LOG_GUEST_ERROR, "ehci: ASYNC list address register set while async schedule\= n" " is enabled and HC is enabled\n"); } @@ -1200,7 +1202,7 @@ static int ehci_init_transfer(EHCIPacket *p) =20 while (bytes > 0) { if (cpage > 4) { - fprintf(stderr, "cpage out of range (%u)\n", cpage); + qemu_log_mask(LOG_GUEST_ERROR, "cpage out of range (%u)\n", cp= age); qemu_sglist_destroy(&p->sgl); return -1; } @@ -1306,7 +1308,8 @@ static void ehci_execute_complete(EHCIQueue *q) break; default: /* should not be triggerable */ - fprintf(stderr, "USB invalid response %d\n", p->packet.status); + qemu_log_mask(LOG_GUEST_ERROR, "USB invalid response %d\n", + p->packet.status); g_assert_not_reached(); } =20 @@ -1354,7 +1357,7 @@ static int ehci_execute(EHCIPacket *p, const char *ac= tion) p->async =3D=3D EHCI_ASYNC_INITIALIZED); =20 if (!(p->qtd.token & QTD_TOKEN_ACTIVE)) { - fprintf(stderr, "Attempting to execute inactive qtd\n"); + qemu_log_mask(LOG_GUEST_ERROR, "Attempting to execute inactive qtd= \n"); return -1; } =20 @@ -1395,7 +1398,8 @@ static int ehci_execute(EHCIPacket *p, const char *ac= tion) p->packet.actual_length); =20 if (p->packet.actual_length > BUFF_SIZE) { - fprintf(stderr, "ret from usb_handle_packet > BUFF_SIZE\n"); + qemu_log_mask(LOG_GUEST_ERROR, + "ret from usb_handle_packet > BUFF_SIZE\n"); return -1; } =20 @@ -1479,8 +1483,9 @@ static int ehci_process_itd(EHCIState *ehci, case USB_RET_SUCCESS: break; default: - fprintf(stderr, "Unexpected iso usb result: %d\n", - ehci->ipacket.status); + qemu_log_mask(LOG_GUEST_ERROR, + "Unexpected iso usb result: %d\n", + ehci->ipacket.status); /* Fall through */ case USB_RET_IOERROR: case USB_RET_NODEV: @@ -1584,7 +1589,8 @@ static int ehci_state_fetchentry(EHCIState *ehci, int= async) =20 /* section 4.8, only QH in async schedule */ if (async && (NLPTR_TYPE_GET(entry) !=3D NLPTR_TYPE_QH)) { - fprintf(stderr, "non queue head request in async schedule\n"); + qemu_log_mask(LOG_GUEST_ERROR, + "non queue head request in async schedule\n"); return -1; } =20 @@ -1606,7 +1612,7 @@ static int ehci_state_fetchentry(EHCIState *ehci, int= async) =20 default: /* TODO: handle FSTN type */ - fprintf(stderr, "FETCHENTRY: entry at %X is of type %u " + qemu_log_mask(LOG_GUEST_ERROR, "FETCHENTRY: entry at %X is of type= %u " "which is not supported yet\n", entry, NLPTR_TYPE_GET(entr= y)); return -1; } @@ -2112,13 +2118,14 @@ static void ehci_advance_state(EHCIState *ehci, int= async) break; =20 default: - fprintf(stderr, "Bad state!\n"); + qemu_log_mask(LOG_GUEST_ERROR, "Bad state!\n"); g_assert_not_reached(); } =20 if (again < 0 || itd_count > 16) { /* TODO: notify guest (raise HSE irq?) */ - fprintf(stderr, "processing error - resetting ehci HC\n"); + qemu_log_mask(LOG_GUEST_ERROR, + "processing error - resetting ehci HC\n"); ehci_reset(ehci); again =3D 0; } @@ -2175,7 +2182,7 @@ static void ehci_advance_async_state(EHCIState *ehci) =20 default: /* this should only be due to a developer mistake */ - fprintf(stderr, "ehci: Bad asynchronous state %d. " + qemu_log_mask(LOG_GUEST_ERROR, "ehci: Bad asynchronous state %d. " "Resetting to active\n", ehci->astate); g_assert_not_reached(); } @@ -2225,7 +2232,7 @@ static void ehci_advance_periodic_state(EHCIState *eh= ci) =20 default: /* this should only be due to a developer mistake */ - fprintf(stderr, "ehci: Bad periodic state %d. " + qemu_log_mask(LOG_GUEST_ERROR, "ehci: Bad periodic state %d. " "Resetting to active\n", ehci->pstate); g_assert_not_reached(); } --=20 2.43.0 From nobody Thu Apr 30 00:39:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1776153874; cv=pass; d=zohomail.com; s=zohoarc; b=OGIVhRKcMJ4oclQgNZxlYW/i1EfzUc1mJ4lIZy/NHVxADDJ+/o5QL7TWeUZ77IBJAM/fUyQ1VvRkistczDPX6m8SKILyKk1/kmzgcHu3kMzFQ+5tYWr+NfyvjffihIzof5hgf/LBZfnI+2Oa1iGfCqcCTG6fOVQZXRBByzzQnG4= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776153874; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=H6usZ5mXShBCQUWpF5kXm4oFlG2iJBMpiedjEUoqbNs=; b=JGy0kXu5kXGqOvxeGAgGOAFSrpELKLWsDOq2Lvkt05hCdEzz+tdsRQ9Ow2S8WoDBXSZrvOLRv9z8U3w4Z5k8fTwOyMVwuJY5xCfvHC55gC+fyaWegNvK2HtIkvz1Xu/UYwcG/WYFLWjF5/QJofX1ChJ3b1Q/P3fjtBGO0H1jiGg= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776153874654827.2957636532977; Tue, 14 Apr 2026 01:04:34 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wCYhc-0003co-4E; Tue, 14 Apr 2026 04:00:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYhZ-0003aA-2T; Tue, 14 Apr 2026 04:00:53 -0400 Received: from mail-koreacentralazlp170130006.outbound.protection.outlook.com ([2a01:111:f403:c40f::6] helo=SEYPR02CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYhW-0005mG-Vw; Tue, 14 Apr 2026 04:00:52 -0400 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19) by TYZPR06MB6745.apcprd06.prod.outlook.com (2603:1096:400:45a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Tue, 14 Apr 2026 08:00:32 +0000 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9769.046; Tue, 14 Apr 2026 08:00:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TevAsJ4Cmw8Ib8xR6XKE7rjmv0AKVI9ovGfNmmnsk9DbuKU6mJf4DoAQBYlPN/lATYnxtCcqEC1QH+MYb0IPpIzytb3K+/i++MzBxAKRTZRsoGVx6g+jz854ykeXLbEoWe+beOnP7523eEZCAV+NloARCmdgtOElLlKWl41XgOZOa47YpJCK6CnF0FYoAlHOun4g2l2L6CVs3eBp/ENYaOtVxeo0RjZWp+CPWx6YYoyTLBjxQlrwHHlAGpu8FVkFC6qK4sn0pqN3kSME2OjDnaHWrbz2zxfAvfSTnBAXq5ED1ElXA7WzfprPTSVxS83c7TLGpS0h/lkrOL4NxFSNBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H6usZ5mXShBCQUWpF5kXm4oFlG2iJBMpiedjEUoqbNs=; b=J4a+s2ci5/+BV3fehzGkfo5859lqHCXQzB3YqozBaVR2B8Y9V+oBXJ6NKzBEKU2Dws/l0Gt2cGQe9MtM61bomuN/P5wPWNK5Mby/LW7NETk8tqji/sHuugH2WynOHi0U6BIUhuqC9l5ZCq1E+zsD//W7TxDX5z9jxjBg1AjNsWDIm4GQsW701UoWpJHHPU0dVG9Tik3QQiO/lH/8gTqd+lHn1hWsyvKyVwE2/RcLK9/+Vt+aJfRidchuQtN3LurHFONVxMMNytrOvNFHEseuhdUC36AvgU9LNi2Xih3LX2+679rswP8tRGtC3t/ZflfGX3mdi8LgIrKcRlGxlBojmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H6usZ5mXShBCQUWpF5kXm4oFlG2iJBMpiedjEUoqbNs=; b=BLGdGc/wjNGdGiThDkjw93+DlKapxRrT29y/XVuml+iCEJx8ytme2woiC/fnpH/kJ9LMWugxDY8DUdqu//ZPKMj6LvS2nBzdSb+O3fCUiaRI0wY0ymiAcbA6JIGfrTXB9x2/x9sIZh1TJNcpdLNKd//J5Jieq5OaOuTwJIs76WbQr7ijqpQANEYSNocB57qB007dbRaJoWSq7Jl1vzF+ii1g6WnZn12m+7FNJUizVqQPkTlI69RZT8m+EMtbYiScQj86P8/lrRZEjdH9z7hV3Auwafq2e2HhuduveY0lTn2+BP2RIWa8LZ3QwZ+PZLdberovgPsCeyM0GslGhvqxJg== From: Jamin Lin To: =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , "flwu@google.com" , "nabihestefan@google.com" Subject: [PATCH v2 05/17] hw/usb/hcd-ehci: Replace DPRINTF debug logs with trace events Thread-Topic: [PATCH v2 05/17] hw/usb/hcd-ehci: Replace DPRINTF debug logs with trace events Thread-Index: AQHcy+TE5hvsGeJpgkGHytOuSshyKA== Date: Tue, 14 Apr 2026 08:00:32 +0000 Message-ID: <20260414080025.3005916-6-jamin_lin@aspeedtech.com> References: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYPPR06MB8206:EE_|TYZPR06MB6745:EE_ x-ms-office365-filtering-correlation-id: cf982349-d447-4955-227a-08de99fbe6dd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|38070700021|22082099003|56012099003|18002099003; x-microsoft-antispam-message-info: lHuwosqcuehK1AJrmnocPphK3GHzszDHlGSLbWPDeyjiI7csRi4ec7zgu+QLGPVjK+82tj5in6U5yQBS/Y16caM/T846ZRzEZoZQGRgfnPW/wknvXWuwhAYw2m5xP8pGET+T3XwjVxTrQttH4TUutjEjLadSKTNNWgHZlWB6zgDPUetGoWzM14HMd0U1Z/AslbAxi7RTawgg1xAByq1DD0onkQLI69Mb8y55iWrdQwdTl/Gp7EsdRtKPqpeefYfumWgonlxC74599mwWFY9hbAjrHIRNvyjYUG3ksKj7/j57CHVyyhpYjOrtNFo8VqSYhEwR4E/t72nWh8+oWE76jNEMfYGdQ2VlC6J/JXMf7erD2O0BJndKeItp1nqW1GiCY4t0AyrUSTEMmZYxJy9kKySRR4juGyi3IEPEzUnkOIgMwmdnQ3bJZ45ZmRXrpWbnMt5vvafLZYVrlGBtFCiu3q3s8MC86qX62Plx74DXNpa1UkfqYu7vC9q6KRNR0he2YCi6OEAnKzrlrFf+ymPXmgmgChfdkaPPfe2GEH697QBzw3pDjbSGedX8Bcb06S6jvH2y60uYMRGFcHSD1bLL52u3MLyLAkUE77J6iGfKIsHtlP9q/VLHx6+t51y+GfUx2yOJg/1M5JURNje+kITAmNsnxHzjTMraSyXJOUW6cquiEK5SZknfH+TtHAxQGkddkA7InmtI5o311bWkDa6F4/6C1a8wfGg5OKJX4xuaV4qjxc5y2BYjYhvdfxxeapeh6Vmwp0rOCRvs4sE8cfP6JKVVa3BVD0/ZM048QkOmWjQ= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700021)(22082099003)(56012099003)(18002099003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?u8F3U8lsV9S/WYjao8vu+7B+ek+2Mget0CCAPyLqRVMIPu1gMjugS9qWPw?= =?iso-8859-1?Q?Lprz1s/Yqo51GrCtidUqDulFFunMmaWUz5Du4+aQGnlCLarQYDzBQfgCd7?= =?iso-8859-1?Q?ySlX4MSkKXKTUTY5kuLyL9RV6ISaACx0Tnc2TezOg39Kc91iNY6kH2DxWQ?= =?iso-8859-1?Q?jvX24qZlc9ronElPKUNRPEuLMzGuMm9/+ewaNJk6Ta9uKp2xmm/TGT4ZNS?= =?iso-8859-1?Q?9OpkaTjGb49GHTTVENFuaA3rrJP/zMRnFvPTPRerODJ9+nqI7ytFxSfYet?= =?iso-8859-1?Q?7hSgz/MiCZi2pFzhCYRUlFSFJy8UJEqlRM2OPQLToAKhC+HXlkfzWADo4B?= =?iso-8859-1?Q?SFnk8jyqPM3vqQr8cdnXRtUjp6lW/1XLVLM2i9hXoGYL7K1yYWC4wacGy+?= =?iso-8859-1?Q?MprZdjDMS6h+o61AuScSKd+/G6be8e1JMSUSEfPEmPXG1XNKS7TJTTxe1C?= =?iso-8859-1?Q?oKbLGUAgYEWKxEwoNJ1Rdy9T8mIN60A1t8kaXkLdTu+ZQguDSSpLUBqPUl?= =?iso-8859-1?Q?ZBFC9q5KTWckx9go7rt6ed2S4zqwZ6NrE0Sec92+H4VzoEo0i6jzPKAnrk?= =?iso-8859-1?Q?2IpnIZ4Vags8Abdb8aE6VX+JQ97zXOI68XioZ8AeZU6zaklgxqOfNRcbe8?= =?iso-8859-1?Q?5M2UFOldSg8l8lUS+pKfwH6RcXNKSLJYj2tIM7t3hxsMcpsBuzTm/7Dqq2?= =?iso-8859-1?Q?oJzpZtaojJnZDM8iLIGK33qBUgmpX+4YeG6wg02seCZfaZGn6Gy7wQItrI?= =?iso-8859-1?Q?43MF0eHNHXvGXNUik5+cceeAH8qYuhQSBwFBxXAf3dcqUpNl0wDFgWKx2Q?= =?iso-8859-1?Q?k6kb4qnvidE/B9Z2AMDy8ELkd9TSQKdBBYmgtQ1/V1uCIgxOnwyFAnNAjU?= =?iso-8859-1?Q?B434VJ2kOuz/UWEdil3i4Y4HgJsPaGv1tc7NhVJxg5HF56Nz4jz/2nir+O?= =?iso-8859-1?Q?7SKt6GfeMdMlqMFwG4Xn6dmlzGqwFX0nJ9ioMi86GPNJwqdoYi96XsYE4y?= =?iso-8859-1?Q?m+Q3p6F8Hd9mj2xYMzvMGDxwzHmhOzUfUTMSwjKs4TpoAUdSfdh61A1n/H?= =?iso-8859-1?Q?xaAQoMUvnMTOuZn3NYXEvy42Mre1ElHTUaSAUmPwNYeGh13MayCQNc8t6R?= =?iso-8859-1?Q?/PKjNdRCYcB9pbW78dZ3VRkPuW9M1A1hTjvOp9pjCPwGUH3DuRCuF94oAo?= =?iso-8859-1?Q?RC3XwZTNbXfaZnYGQ/ymOiOSSpmDp/6lBfVFfx2+WaS/2fjT8xByB7pA9D?= =?iso-8859-1?Q?5TBjvz8rzWEPN7OUEhKUX+6GO4rmPkLD/qAS1eB78vA8XtbzZqxV14xsyD?= =?iso-8859-1?Q?usNqt1ztnFZ+ZH9G1/dxMfsDBnhSh0anF7SfTUaGs712gDUtdWfDaNg0/b?= =?iso-8859-1?Q?510QIPJ1MvtAtMOW4TuuxAlqXaevca6xuKVaPdShHdaMomdWVwbHpMRwtJ?= =?iso-8859-1?Q?eNfKfgs1TVcAyAvblugIhpEu1gGIppnsRqi3KVCvB6rPrI0UDnwvehEVDY?= =?iso-8859-1?Q?/E/V1aqNhd3nmr+qAQHSuvGf/iXyRUZGLZCm90hWm2CI/yzyYxMDK+Wysi?= =?iso-8859-1?Q?6kU35/mGjKIt8LmtpLss2hJpILDhoe2W2JREoKyTswKC3xtYBKDdCyJgnc?= =?iso-8859-1?Q?2kTWuHRLnfnYI2DohvvvyYuZXaiej5AkcNtKM9GHd7v3aKz7bZaXF7pOa4?= =?iso-8859-1?Q?Kdk4EYCRvLkaFoGbrGl/3uXhFP9z+6m70sErWLDoHMAcdi3jDoQG4Hi0m4?= =?iso-8859-1?Q?Hlb4jhYy09r8vxkyPWC8sxabi31ulhfqOCSqAPKGJCNXDzL6oZtrvtco/Z?= =?iso-8859-1?Q?m2R10IHoKw=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: wAt0LZtmTK4WBjNYgluYSVRtDPKiuauCfHyy/4YAgGXlvP/nYSJFLyBn5Hoe1lUEs779HaDina/JnhXauMDcl+Fid1pqDkPlBBeW9Wj5TrEMRKSjbISfkOVMaos96/WNt73DB6xTsChFgVdwIZPFhbgDR81W+xtE/xmJE5G2/xoMjrsShCa1pmCSX62PT+9o+tdqwgc86D6+JGtv/lQT7XfI5KRXSlIw9A5wfxuRnwJnGmKyFOkeIMq6cqk3Z1XCUngy/6TLqgRXU7cSbLebHtMBijmgdJZXQd4Txxsazisr0EIDtzTN+/4L8jxDmwM3KuYkJVkNrNOg3guCIzBGwA== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYPPR06MB8206.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf982349-d447-4955-227a-08de99fbe6dd X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2026 08:00:32.2014 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aMF2q4+TkrevANoClYuBvrLpKLeGn99DvahqoOFOhhaPwEJ9GWYvXvBepcVg7YK9MVv1dPR4Cl+6hjemrHK6tzdmRCWQF5tndo1+eNjdw+A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB6745 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c40f::6; envelope-from=jamin_lin@aspeedtech.com; helo=SEYPR02CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1776153877166154100 Content-Type: text/plain; charset="utf-8" Replace legacy DPRINTF() debug logging in the EHCI host controller implementation with QEMU trace events. The EHCI_DEBUG macro and associated DPRINTF() definitions are removed as they are no longer needed. Trace events are added for: - packet submission and completion - queue head execution state - periodic schedule advancement - ITD error conditions - port state handling - skipped microframes No functional change. Signed-off-by: Jamin Lin --- hw/usb/hcd-ehci.h | 10 --------- hw/usb/hcd-ehci.c | 49 +++++++++++++++++++-------------------------- hw/usb/trace-events | 9 +++++++++ 3 files changed, 30 insertions(+), 38 deletions(-) diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h index 736407fd52..4234591cb4 100644 --- a/hw/usb/hcd-ehci.h +++ b/hw/usb/hcd-ehci.h @@ -24,16 +24,6 @@ #include "hw/pci/pci_device.h" #include "hw/core/sysbus.h" =20 -#ifndef EHCI_DEBUG -#define EHCI_DEBUG 0 -#endif - -#if EHCI_DEBUG -#define DPRINTF printf -#else -#define DPRINTF(...) -#endif - #define MMIO_SIZE 0x1000 #define CAPA_SIZE 0x10 =20 diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index bebd137f94..d0ea4949f9 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -839,7 +839,7 @@ static USBDevice *ehci_find_device(EHCIState *ehci, uin= t8_t addr) for (i =3D 0; i < EHCI_PORTS; i++) { port =3D &ehci->ports[i]; if (!(ehci->portsc[i] & PORTSC_PED)) { - DPRINTF("Port %d not enabled\n", i); + trace_usb_ehci_port_disable(i); continue; } dev =3D usb_find_device(port, addr); @@ -1281,10 +1281,8 @@ static void ehci_execute_complete(EHCIQueue *q) assert(p->async =3D=3D EHCI_ASYNC_INITIALIZED || p->async =3D=3D EHCI_ASYNC_FINISHED); =20 - DPRINTF("execute_complete: qhaddr 0x%x, next 0x%x, qtdaddr 0x%x, " - "status %d, actual_length %d\n", - q->qhaddr, q->qh.next, q->qtdaddr, - p->packet.status, p->packet.actual_length); + trace_usb_ehci_execute_complete(q->qhaddr, q->qh.next, q->qtdaddr, + p->packet.status, p->packet.actual_len= gth); =20 switch (p->packet.status) { case USB_RET_SUCCESS: @@ -1327,7 +1325,7 @@ static void ehci_execute_complete(EHCIQueue *q) } else { tbytes =3D 0; } - DPRINTF("updating tbytes to %d\n", tbytes); + trace_usb_ehci_qh_tbytes(tbytes); set_field(&q->qh.token, tbytes, QTD_TOKEN_TBYTES); =20 ehci_finish_transfer(q, p->packet.actual_length); @@ -1392,10 +1390,9 @@ static int ehci_execute(EHCIPacket *p, const char *a= ction) =20 trace_usb_ehci_packet_action(p->queue, p, action); usb_handle_packet(p->queue->dev, &p->packet); - DPRINTF("submit: qh 0x%x next 0x%x qtd 0x%x pid 0x%x len %zd endp 0x%x= " - "status %d actual_length %d\n", p->queue->qhaddr, p->qtd.next, - p->qtdaddr, p->pid, p->packet.iov.size, endp, p->packet.status, - p->packet.actual_length); + trace_usb_ehci_packet_submit(p->queue->qhaddr, p->qtd.next, p->qtdaddr, + p->pid, p->packet.iov.size, endp, + p->packet.status, p->packet.actual_length= ); =20 if (p->packet.actual_length > BUFF_SIZE) { qemu_log_mask(LOG_GUEST_ERROR, @@ -1472,7 +1469,8 @@ static int ehci_process_itd(EHCIState *ehci, usb_handle_packet(dev, &ehci->ipacket); usb_packet_unmap(&ehci->ipacket, &ehci->isgl); } else { - DPRINTF("ISOCH: attempt to address non-iso endpoint\n"= ); + trace_usb_ehci_log("ISOCH: " + "attempt to address non-iso endpoin= t"); ehci->ipacket.status =3D USB_RET_NAK; ehci->ipacket.actual_length =3D 0; } @@ -1675,24 +1673,22 @@ static EHCIQueue *ehci_state_fetchqh(EHCIState *ehc= i, int async) if (ehci->usbsts & USBSTS_REC) { ehci_clear_usbsts(ehci, USBSTS_REC); } else { - DPRINTF("FETCHQH: QH 0x%08x. H-bit set, reclamation status re= set" - " - done processing\n", q->qhaddr); + trace_usb_ehci_fetchqh_reclaim_done(q->qhaddr); ehci_set_state(ehci, async, EST_ACTIVE); q =3D NULL; goto out; } } =20 -#if EHCI_DEBUG - if (q->qhaddr !=3D q->qh.next) { - DPRINTF("FETCHQH: QH 0x%08x (h %x halt %x active %x) next 0x%08x\= n", - q->qhaddr, - q->qh.epchar & QH_EPCHAR_H, - q->qh.token & QTD_TOKEN_HALT, - q->qh.token & QTD_TOKEN_ACTIVE, - q->qh.next); + if (trace_event_get_state_backends(TRACE_USB_EHCI_FETCHQH_DBG)) { + if (q->qhaddr !=3D q->qh.next) { + trace_usb_ehci_fetchqh_dbg(q->qhaddr, + q->qh.epchar & QH_EPCHAR_H, + q->qh.token & QTD_TOKEN_HALT, + q->qh.token & QTD_TOKEN_ACTIVE, + q->qh.next); + } } -#endif =20 if (q->qh.token & QTD_TOKEN_HALT) { ehci_set_state(ehci, async, EST_HORIZONTALQH); @@ -2154,7 +2150,7 @@ static void ehci_advance_async_state(EHCIState *ehci) /* make sure guest has acknowledged the doorbell interrupt */ /* TO-DO: is this really needed? */ if (ehci->usbsts & USBSTS_IAA) { - DPRINTF("IAA status bit still set.\n"); + trace_usb_ehci_log("IAA status bit still set."); break; } =20 @@ -2221,9 +2217,7 @@ static void ehci_advance_periodic_state(EHCIState *eh= ci) if (get_dwords(ehci, list, &entry, 1) < 0) { break; } - - DPRINTF("PERIODIC state adv fr=3D%d. [%08X] -> %08X\n", - ehci->frindex / 8, list, entry); + trace_usb_ehci_periodic_state_advance(ehci->frindex / 8, list, ent= ry); ehci_set_fetch_addr(ehci, async, entry); ehci_set_state(ehci, async, EST_FETCHENTRY); ehci_advance_state(ehci, async); @@ -2291,8 +2285,7 @@ static void ehci_work_bh(void *opaque) ehci_update_frindex(ehci, skipped_uframes); ehci->last_run_ns +=3D UFRAME_TIMER_NS * skipped_uframes; uframes -=3D skipped_uframes; - DPRINTF("WARNING - EHCI skipped %"PRIu64" uframes\n", - skipped_uframes); + trace_usb_ehci_skipped_uframes(skipped_uframes); } =20 for (i =3D 0; i < uframes; i++) { diff --git a/hw/usb/trace-events b/hw/usb/trace-events index dd04f14add..0d4318dcf1 100644 --- a/hw/usb/trace-events +++ b/hw/usb/trace-events @@ -89,6 +89,7 @@ usb_ehci_state(const char *schedule, const char *state) "= %s schedule %s" usb_ehci_qh_ptrs(void *q, uint32_t addr, uint32_t nxt, uint32_t c_qtd, uin= t32_t n_qtd, uint32_t a_qtd) "q %p - QH @ 0x%08x: next 0x%08x qtds 0x%08x,0= x%08x,0x%08x" usb_ehci_qh_fields(uint32_t addr, int rl, int mplen, int eps, int ep, int = devaddr) "QH @ 0x%08x - rl %d, mplen %d, eps %d, ep %d, dev %d" usb_ehci_qh_bits(uint32_t addr, int c, int h, int dtc, int i) "QH @ 0x%08x= - c %d, h %d, dtc %d, i %d" +usb_ehci_qh_tbytes(uint32_t tbytes) "updating tbytes to %d" usb_ehci_qtd_ptrs(void *q, uint32_t addr, uint32_t nxt, uint32_t altnext) = "q %p - QTD @ 0x%08x: next 0x%08x altnext 0x%08x" usb_ehci_qtd_fields(uint32_t addr, int tbytes, int cpage, int cerr, int pi= d) "QTD @ 0x%08x - tbytes %d, cpage %d, cerr %d, pid %d" usb_ehci_qtd_bits(uint32_t addr, int ioc, int active, int halt, int babble= , int xacterr) "QTD @ 0x%08x - ioc %d, active %d, halt %d, babble %d, xacte= rr %d" @@ -100,13 +101,21 @@ usb_ehci_port_reset(uint32_t port, int enable) "reset= port #%d - %d" usb_ehci_port_suspend(uint32_t port) "port #%d" usb_ehci_port_wakeup(uint32_t port) "port #%d" usb_ehci_port_resume(uint32_t port) "port #%d" +usb_ehci_port_disable(uint32_t port) "port #%d" usb_ehci_queue_action(void *q, const char *action) "q %p: %s" usb_ehci_packet_action(void *q, void *p, const char *action) "q %p p %p: %= s" +usb_ehci_packet_submit(uint32_t qhaddr, uint32_t next, uint32_t qtdaddr, i= nt pid, size_t len, int endp, int status, int actual_length) "qh=3D0x%x, ne= xt=3D0x%x, qtd=3D0x%x, pid=3D0x%x, len=3D%zd, endp=3D0x%x, status=3D%d, act= ual_length=3D%d" usb_ehci_irq(uint32_t level, uint32_t frindex, uint32_t sts, uint32_t mask= ) "level %d, frindex 0x%04x, sts 0x%x, mask 0x%x" usb_ehci_guest_bug(const char *reason) "%s" usb_ehci_doorbell_ring(void) "" usb_ehci_doorbell_ack(void) "" usb_ehci_dma_error(void) "" +usb_ehci_execute_complete(uint32_t qhaddr, uint32_t next, uint32_t qtdaddr= , int status, int actual_length) "qhaddr=3D0x%x, next=3D0x%x, qtdaddr=3D0x%= x, status=3D%d, actual_length=3D%d" +usb_ehci_fetchqh_reclaim_done(uint32_t qhaddr) "QH 0x%08x H-bit set, recla= mation status reset - done processing" +usb_ehci_fetchqh_dbg(uint32_t qhaddr, uint32_t h, uint32_t halt, uint32_t = active, uint32_t next) "QH 0x%08x (h 0x%x halt 0x%x active 0x%x) next 0x%08= x" +usb_ehci_periodic_state_advance(uint32_t frame, uint32_t list, uint32_t en= try) "frame=3D%d, list=3D0x%x, entry=3D0x%x" +usb_ehci_skipped_uframes(uint64_t skipped_uframes) "skipped %" PRIu64 " uf= rames" +usb_ehci_log(const char *msg) "%s" =20 # hcd-uhci.c usb_uhci_reset(void) "=3D=3D=3D RESET =3D=3D=3D" --=20 2.43.0 From nobody Thu Apr 30 00:39:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1776153901; cv=pass; d=zohomail.com; s=zohoarc; b=ey7UyJRDhYOOQDa6aOvIqEWFGBQCD27iFlWpof01TLbBy/HLNSVS77N+aIoXGlb5TDXyWS41PIh4z7EHx324+NjVqGg0VLcUqCDJ2I/F2oxs5jAaKzzSBVFvFH64C1wd553POvZ0wB1hkkWHD9XbdkgU0AzXoC/55dmEwSZYwRE= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776153901; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Pv6QKdzh9Nm4FFVP4g5cAlSzrWOdTp1N1mcV47oO0zI=; b=HeZs1B6UaulaHOva1CJvYwmy+p8x/UE+nisxEIJk7kKgU/lxtJ1eMtsUskWoe1XhS198MhBzNzoIE+DKwFmrgnPgGdakjI1beXzq+fUlwcITr5pM9f2nFqq08jvhmWetKbzSqY7x+9h8tyZ1RyHMfLxlTYuht7MgV7CzZR1iG68= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776153901240716.3154641103167; Tue, 14 Apr 2026 01:05:01 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wCYhg-0003gd-Nu; Tue, 14 Apr 2026 04:01:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYhb-0003bT-1i; Tue, 14 Apr 2026 04:00:55 -0400 Received: from mail-koreacentralazlp170130006.outbound.protection.outlook.com ([2a01:111:f403:c40f::6] helo=SEYPR02CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYhY-0005oL-Ko; Tue, 14 Apr 2026 04:00:54 -0400 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19) by TYZPR06MB6745.apcprd06.prod.outlook.com (2603:1096:400:45a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Tue, 14 Apr 2026 08:00:33 +0000 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9769.046; Tue, 14 Apr 2026 08:00:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wBRL851vpr9H5S7iH5fj8wMIK7s6fi/GJEJPY7rzovI6kgRm3Z+tsXUzutgJqylywhPSpHF2oChvwJJ/sREYOzCVCOQwn8ZPfu/xavTMwEyxm5p0K5uAuOnT8yRbHCCD+drriD3VnC+HOXp63Kp2HzWAU9nl0D7IoN8adKQ/TAmO4JMAvRJR6vTWPV864UThClCCpiDeN6H+noIarnh3+Vd4zTFqDC1GyUCQUBUxySjxW85rZnwoW22TTcN5tJpEvI+VHy5gYD4PsslyDltNidTDMZ5jWAPxgXP+39zoo3NVEG6YtTWPGBrmcozxwiX1et7hGyUCI6upTIQIQ+Gwbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Pv6QKdzh9Nm4FFVP4g5cAlSzrWOdTp1N1mcV47oO0zI=; b=gDE60W1hvrv7CCaFrG4URHNIyzB9oHX0ouVugESDf4EWC9TfV90ioXNiVmh5rxuQmS3mKwpqIcfFPQ4/GOSRsfOVjBOe09nOHEA3SvvkFzQA13XOJ8LCyii3JLPw99IhEYB7M7fnJ7ECViRbCZ2uZsN9dNz7ieRTP6DU8JlZVQVAjiSMtuAwFEwC9uuVRBFj0zKeQkIPd2e6y5lcufUjFWn/hcImoQcnK5DJ/qeCQmfN/o3VeZo1VeChL2SvK+UKAw0+a1uxBvkzzODrQs3BcbxX/rKdRhamKkafbfIPdn7GE9CYqFp78+rkcq/n4kdNA+xDoOdh8ENuOby+kOUe4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Pv6QKdzh9Nm4FFVP4g5cAlSzrWOdTp1N1mcV47oO0zI=; b=VoPjgrcP1Y8FWPPjxfqk4SWimHrRtfg0rIZCTqyw81zDO32euqIwcHSb8WkKZ2+MUfS0bTsSqD3iFQlnLLMGx2wH11YLGob8wnqa8Bew758ZDKIIowtwKB2znKsgHLCFQkRakkoU8gPhWjTl1gMg1cjdCc7aNJXdO8pZc92n6zk+pdyyznvyKHmCCpea2CtAl6/4yPkYnKTMrGcQOynnYy02zGYcTUyMesQKQiHrpEiQh5BOD1Z2xqjxnbc0RW4S+7CJYsop3K52l3HtelCodqgtov6SlD93vl2vnggGip6ygpqD2e+DROJGeBRIn0gJj7Vvoqgj1jZOsKB/4Y8SYQ== From: Jamin Lin To: =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , "flwu@google.com" , "nabihestefan@google.com" Subject: [PATCH v2 06/17] hw/usb/hcd-ehci: Change descriptor addresses to 64-bit Thread-Topic: [PATCH v2 06/17] hw/usb/hcd-ehci: Change descriptor addresses to 64-bit Thread-Index: AQHcy+TF38PfbBLNdk+9bahbf3ZsMQ== Date: Tue, 14 Apr 2026 08:00:33 +0000 Message-ID: <20260414080025.3005916-7-jamin_lin@aspeedtech.com> References: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYPPR06MB8206:EE_|TYZPR06MB6745:EE_ x-ms-office365-filtering-correlation-id: dbccabde-b665-4d79-05f0-08de99fbe79e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|38070700021|22082099003|56012099003|18002099003; x-microsoft-antispam-message-info: EFOKpB1GbMtWxeQ22BvBLTNGnOBu6GDYEhjF1yA0EQgjQrzC2et3sj1aFrAYq0aNi+2kKY0XUYo2OeCowhC6Tem4tKlOeNXE7IjqIYN0+pgQ3BnUYcH5P+baNhTkq1gH7ujGT3A9e/DfPwR08qkl1MH5jLMX2vKGfyMUnCKf5gEqGovrkMBnB3ChJwM1+BcjWEGuEcUd6yS/bFkgzyuEMqVGYdQYhRIfB0Rk9eolO+5QG1dqusSFptQ7IHodjuWlz1geSuZOBOTK32sfTp0+bi/P0pHdI+7ss24tJNcdWjiQBZGosSfJaPlGA8XjL6VwkOHKbj54NhlIfbNh89XA4a5WrNjiC2o0GLRncxwZH8m6wntYpirDqqmbdTfgXr2IAQtRJZZbEj5mHTCPo4EeUKfydmMHa3i2wRCIshsTfFhnW1Gz7O/sGnH/HF/TFipSbgLPg9JKRbpezHvZWWaXaLkUc46z6VozogFjYbp2IYnR+0fez+KO9/etV/ZXxb8uUhm+7o5HWdH5OcJTblj6eBXVmiZXOEAdZg6o/4qHAgiC9t3fj/7/v8vzFUdWtB2gcjgStamNApG97fQ8MHrgtVyNUm75/emM9BpkoCL8ZyklSUx1uK28SorbNcL/Q2SZrZSCGloT+nGxvftuAwBXlbuICdIR7YLqXncl3MWNyzC4qbT19166pXqLiXZ8bX0AInwn3iULQ6pjKNqQ6imk1RRd26MFp9eVj4ogrRzgMYzzYpbHMU3iaBWc4UPFgyk4k4fN/v4UvliT/uPrNVgD76aSEFqLM8onZujin7/c++4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700021)(22082099003)(56012099003)(18002099003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?bzMF6AnCGH49qVtKmsWYmPeDI5+Vn+iBF7klGJ23KROgB1I6dJKKAYYJAx?= =?iso-8859-1?Q?N8EFaulkHs+uAIlU9Gq4k9bD6RvAeYncoEAx5pyX4MIeZd9hzDJOR4O+7I?= =?iso-8859-1?Q?npwl31RO0t4X926g3HKUCXxo4wtQJw3foZPmeNJ9iQaHabNZtQHlO3FhzD?= =?iso-8859-1?Q?dUwnIbNIErxxRbFFJ+ftaOoe8eQjED0uEysHRq/Wh2oZbMSU4adso/GaEa?= =?iso-8859-1?Q?h92Aaq0eP6Bx3XC+kCbXH753L8jmNs0828txRYU/nt29J+7fVsPEVgqCzX?= =?iso-8859-1?Q?8RNdXU2NmRC32VQ/CbbEyP8LsO8E7Ul2TSK2jUD+5N+FuARhMDyOaOBkPU?= =?iso-8859-1?Q?a+Bp3SGOaLJuICyU5R+WS1JT2yEaGYXMPfQYnBCLvqyvlkP3uNXO8vtykt?= =?iso-8859-1?Q?3uqPE+I1WtAX5W7dLMv5tevEsxe2thofamyo0dvAD5XI4YegPoDQFvCBBh?= =?iso-8859-1?Q?6WzeKbUsoQEldqN6pdVYCXzQ8YdDy1ytor7/TAQOGIycl16YPvBNlfFOow?= =?iso-8859-1?Q?wwvzwv0zSe2R7WbHmlPq9Z0wegtxYjcJfBGBIVqrEDpt6NLlNAprJCXmQh?= =?iso-8859-1?Q?pyjIIykKO1JlApWTLusfJRyds36DjhYWs+Sa0dUa6jS44kApbRhhKpt0ZS?= =?iso-8859-1?Q?6BevNFToHn/Jdk8NmC1veLnUrGcrEZCkTVrVR8Dgv75ElJBwQZ0gVFYR6q?= =?iso-8859-1?Q?ntcJyDiBONwufIw7g1/vfZSjmpVRO0LCAaQmaRwioizyhpa4/IBi77fbES?= =?iso-8859-1?Q?IMIzOoQ6NKIaSO5v9+xfajuUbYKCI4FEGd8FT2yuCs7D5i3Wn7leO9CgGC?= =?iso-8859-1?Q?OLo9aVELjG2Vc2qGeUp8vh2V19Bdq9tc6kUV/B8pg1vK+yN1Oy7F/hinfx?= =?iso-8859-1?Q?uPlsrnxaBC6gURG50V1LKcvUZhz3G0PeERoBnLk29npkUMZjh2bwqBe1bn?= =?iso-8859-1?Q?7Y/9iCX0u25MG9NZKxNAlHedx2ahhLjwRAlXfwVmU/1ARXT/HwtQuc0Ixq?= =?iso-8859-1?Q?Lj0OZdk96RJQGaVGPVNb/ZMPUsxhgq/uwXLGpxHj7V5WmKXHBpXT1paE99?= =?iso-8859-1?Q?XJn7Ern49OFql9uhXsUK8yuKGt5adJmQ4YTMfOamaRv5/UeMo11KIXiRZM?= =?iso-8859-1?Q?qh2GOZovifIrO+cdTDKMZh30ycn3q1I54oZarfeL4PXcNvDBir5+JHQp/+?= =?iso-8859-1?Q?nHMXeulVfQ5AqAjwooa3p0MZEWJ8KrHciO4OqXn0pdw8cWzQu2NyS4MDWw?= =?iso-8859-1?Q?ReJCMiMyzp5BDYDrYvMiCfoFZSiB05PITqn4VSKFZpBqi8LbmWwbpilFcK?= =?iso-8859-1?Q?GrXdggT+P9sbLmhslDLUz5DbQjoQsguPwCGMTrMSSxf0U2sVNXNAZdRlda?= =?iso-8859-1?Q?C7FZXUBbkhi0JLBX3QFYNCV8C8pUsz1+SrUCETa9kFhelUrquNhuW6YzVM?= =?iso-8859-1?Q?R8sqtc8QkUWg/TDK2BoaEu8cRzEiQ082hiVSDfnFcqoQs2SYahzau81f9S?= =?iso-8859-1?Q?+IdVgh30RFePax2bTnjDfkYi8FbIVAT4EM8xA/siAe4krsWw9rNW4GFHgv?= =?iso-8859-1?Q?gLzK57jwKMFMyv7Uube8LBZHQw3KaowMUz6LcOCIE8INVNUQ8QCOTdMFoK?= =?iso-8859-1?Q?RwIf2wHzSBFqWZxWpmaAkCfAJlpe1Iimcxyd+SFXXP+tYtLi2fhnyv9kpp?= =?iso-8859-1?Q?d52Dwao3tvcrTl7CuRk6oTO36osiJNk8wkEqLD4FjwdTMNmvl5VzzXv+1m?= =?iso-8859-1?Q?Pw4ikmgeinWEaIm17qPvc2tI35Xpg4MpyVZEvCutdhb/7fhxHXhyPJ24wk?= =?iso-8859-1?Q?9U62t17ZhQ=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: V4fwjy8dhM1EThl5tykGna0myuoTdXcLrBHnksqKUQwbikEr0V6MW11/y2tSLA4BT0MH9pAagyR/aagD7A3IvNI+rVoKQ5dFYrDVXBPpLQpClyyGPbIzJHe5mh1g3/tkS3TOArjpu/pnWhlSTLpMJiJQRAnwacrp/k/mcfQDfgoC+grQPgibvsLzrVd7l1DMBbBbwT13rTNf8YaH1d21wdgwVL3Rwd7agntILGNnRfAlj0Yjfb/OLMVMnYqtk4lt61I5BZGVRiqckKV2rH/4bQLJyaoLV5qiJLS1e6BqNsDw8RsY8C1+DoKTUSLcKvWKT2U0xuRk1TmJbbIn26gP0A== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYPPR06MB8206.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dbccabde-b665-4d79-05f0-08de99fbe79e X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2026 08:00:33.4582 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RH9TIFmHuGM2oEWagX0yCKFGhLVBr7elFRUn+ot77u0OaDkEjR2/bIE9Fwgp1hFcogCTwLQULUNot7NBSTU2Ol6REnKjLISiNZGxaxsxY14= X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB6745 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c40f::6; envelope-from=jamin_lin@aspeedtech.com; helo=SEYPR02CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1776153903046158500 Content-Type: text/plain; charset="utf-8" Change internal EHCI descriptor addresses from uint32_t to uint64_t. The following fields are updated: - EHCIPacket::qtdaddr - EHCIQueue::{qhaddr, qtdaddr} - EHCIState::{a_fetch_addr, p_fetch_addr} Update get_dwords() and put_dwords() to take 64-bit addresses and propagate the type change through the descriptor traversal paths. Adjust NLPTR_GET() to operate on 64-bit values: #define NLPTR_GET(x) ((x) & ~0x1fULL) so that link pointer masking works correctly when descriptor addresses exceed 32-bit space. The previous mask (0xffffffe0) implicitly truncated addresses to 32 bits. This patch does not change the on-wire descriptor layout yet. It only removes the internal 32-bit address limit and prepares for later patches that will add full 64-bit QH/qTD/iTD/siTD support. Update the EHCI trace-events prototypes for QH, qTD, iTD, and siTD to use uint64_t for the address argument and print it with PRIx64. This ensures full 64-bit addresses are shown in trace output and improves debugging of queue heads and transfer descriptors. Since the type of fetch_addr changes from 32-bit to 64-bit, bump the VMState version. No functional change. Signed-off-by: Jamin Lin --- hw/usb/hcd-ehci.h | 12 ++++++---- hw/usb/hcd-ehci.c | 57 +++++++++++++++++++++++++++------------------ hw/usb/trace-events | 24 +++++++++---------- 3 files changed, 53 insertions(+), 40 deletions(-) diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h index 4234591cb4..24eea9d23b 100644 --- a/hw/usb/hcd-ehci.h +++ b/hw/usb/hcd-ehci.h @@ -208,7 +208,7 @@ struct EHCIPacket { QTAILQ_ENTRY(EHCIPacket) next; =20 EHCIqtd qtd; /* copy of current QTD (being worked on) */ - uint32_t qtdaddr; /* address QTD read from */ + uint64_t qtdaddr; /* address QTD read from */ =20 USBPacket packet; QEMUSGList sgl; @@ -229,8 +229,8 @@ struct EHCIQueue { * when guest removes an entry (doorbell, handshake sequence) */ EHCIqh qh; /* copy of current QH (being worked on) */ - uint32_t qhaddr; /* address QH read from */ - uint32_t qtdaddr; /* address QTD read from */ + uint64_t qhaddr; /* address QH read from */ + uint64_t qtdaddr; /* address QTD read from */ int last_pid; /* pid of last packet executed */ USBDevice *dev; QTAILQ_HEAD(, EHCIPacket) packets; @@ -294,8 +294,10 @@ struct EHCIState { EHCIQueueHead pqueues; =20 /* which address to look at next */ - uint32_t a_fetch_addr; - uint32_t p_fetch_addr; + uint32_t a_fetch_addr_pre_v3; + uint32_t p_fetch_addr_pre_v3; + uint64_t a_fetch_addr; + uint64_t p_fetch_addr; =20 USBPacket ipacket; QEMUSGList isgl; diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index d0ea4949f9..315e8813f5 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -72,7 +72,7 @@ typedef enum { } EHCI_STATES; =20 /* macros for accessing fields within next link pointer entry */ -#define NLPTR_GET(x) ((x) & 0xffffffe0) +#define NLPTR_GET(x) ((x) & ~0x1fULL) #define NLPTR_TYPE_GET(x) (((x) >> 1) & 3) #define NLPTR_TBIT(x) ((x) & 1) /* 1=3Dinvalid, 0=3Dvalid */ =20 @@ -287,7 +287,7 @@ static int ehci_get_state(EHCIState *s, int async) return async ? s->astate : s->pstate; } =20 -static void ehci_set_fetch_addr(EHCIState *s, int async, uint32_t addr) +static void ehci_set_fetch_addr(EHCIState *s, int async, uint64_t addr) { if (async) { s->a_fetch_addr =3D addr; @@ -296,7 +296,7 @@ static void ehci_set_fetch_addr(EHCIState *s, int async= , uint32_t addr) } } =20 -static int ehci_get_fetch_addr(EHCIState *s, int async) +static uint64_t ehci_get_fetch_addr(EHCIState *s, int async) { return async ? s->a_fetch_addr : s->p_fetch_addr; } @@ -373,7 +373,7 @@ static inline bool ehci_periodic_enabled(EHCIState *s) } =20 /* Get an array of dwords from main memory */ -static inline int get_dwords(EHCIState *ehci, uint32_t addr, +static inline int get_dwords(EHCIState *ehci, uint64_t addr, uint32_t *buf, int num) { int i; @@ -395,7 +395,7 @@ static inline int get_dwords(EHCIState *ehci, uint32_t = addr, } =20 /* Put an array of dwords in to main memory */ -static inline int put_dwords(EHCIState *ehci, uint32_t addr, +static inline int put_dwords(EHCIState *ehci, uint64_t addr, uint32_t *buf, int num) { int i; @@ -549,7 +549,7 @@ static void ehci_free_packet(EHCIPacket *p) =20 /* queue management */ =20 -static EHCIQueue *ehci_alloc_queue(EHCIState *ehci, uint32_t addr, int asy= nc) +static EHCIQueue *ehci_alloc_queue(EHCIState *ehci, uint64_t addr, int asy= nc) { EHCIQueueHead *head =3D async ? &ehci->aqueues : &ehci->pqueues; EHCIQueue *q; @@ -622,7 +622,7 @@ static void ehci_free_queue(EHCIQueue *q, const char *w= arn) g_free(q); } =20 -static EHCIQueue *ehci_find_queue_by_qh(EHCIState *ehci, uint32_t addr, +static EHCIQueue *ehci_find_queue_by_qh(EHCIState *ehci, uint64_t addr, int async) { EHCIQueueHead *head =3D async ? &ehci->aqueues : &ehci->pqueues; @@ -1135,7 +1135,7 @@ static void ehci_flush_qh(EHCIQueue *q) { uint32_t *qh =3D (uint32_t *) &q->qh; uint32_t dwords =3D sizeof(EHCIqh) >> 2; - uint32_t addr =3D NLPTR_GET(q->qhaddr); + uint64_t addr =3D NLPTR_GET(q->qhaddr); =20 put_dwords(q->ehci, addr + 3 * sizeof(uint32_t), qh + 3, dwords - 3); } @@ -1406,12 +1406,13 @@ static int ehci_execute(EHCIPacket *p, const char *= action) /* 4.7.2 */ static int ehci_process_itd(EHCIState *ehci, EHCIitd *itd, - uint32_t addr) + uint64_t addr) { USBDevice *dev; USBEndpoint *ep; uint32_t i, len, pid, dir, devaddr, endp; - uint32_t pg, off, ptr1, ptr2, max, mult; + uint32_t pg, off, max, mult; + uint64_t ptr1, ptr2; =20 ehci->periodic_sched_active =3D PERIODIC_ACTIVE; =20 @@ -1528,7 +1529,7 @@ static int ehci_state_waitlisthead(EHCIState *ehci, = int async) EHCIqh qh; int i =3D 0; int again =3D 0; - uint32_t entry =3D ehci->asynclistaddr; + uint64_t entry =3D ehci->asynclistaddr; =20 /* set reclamation flag at start event (4.8.6) */ if (async) { @@ -1578,7 +1579,7 @@ out: static int ehci_state_fetchentry(EHCIState *ehci, int async) { int again =3D 0; - uint32_t entry =3D ehci_get_fetch_addr(ehci, async); + uint64_t entry =3D ehci_get_fetch_addr(ehci, async); =20 if (NLPTR_TBIT(entry)) { ehci_set_state(ehci, async, EST_ACTIVE); @@ -1610,8 +1611,10 @@ static int ehci_state_fetchentry(EHCIState *ehci, in= t async) =20 default: /* TODO: handle FSTN type */ - qemu_log_mask(LOG_GUEST_ERROR, "FETCHENTRY: entry at %X is of type= %u " - "which is not supported yet\n", entry, NLPTR_TYPE_GET(entr= y)); + qemu_log_mask(LOG_GUEST_ERROR, + "FETCHENTRY: entry at %" PRIx64 "is of type %" PRIu64 + "which is not supported yet\n", + entry, NLPTR_TYPE_GET(entry)); return -1; } =20 @@ -1621,7 +1624,7 @@ out: =20 static EHCIQueue *ehci_state_fetchqh(EHCIState *ehci, int async) { - uint32_t entry; + uint64_t entry; EHCIQueue *q; EHCIqh qh; =20 @@ -1710,7 +1713,7 @@ out: =20 static int ehci_state_fetchitd(EHCIState *ehci, int async) { - uint32_t entry; + uint64_t entry; EHCIitd itd; =20 assert(!async); @@ -1736,7 +1739,7 @@ static int ehci_state_fetchitd(EHCIState *ehci, int a= sync) =20 static int ehci_state_fetchsitd(EHCIState *ehci, int async) { - uint32_t entry; + uint64_t entry; EHCIsitd sitd; =20 assert(!async); @@ -1794,7 +1797,7 @@ static int ehci_state_fetchqtd(EHCIQueue *q) EHCIqtd qtd; EHCIPacket *p; int again =3D 1; - uint32_t addr; + uint64_t addr; =20 addr =3D NLPTR_GET(q->qtdaddr); if (get_dwords(q->ehci, addr + 8, &qtd.token, 1) < 0) { @@ -1877,7 +1880,7 @@ static int ehci_fill_queue(EHCIPacket *p) USBEndpoint *ep =3D p->packet.ep; EHCIQueue *q =3D p->queue; EHCIqtd qtd =3D p->qtd; - uint32_t qtdaddr; + uint64_t qtdaddr; =20 for (;;) { if (NLPTR_TBIT(qtd.next) !=3D 0) { @@ -2000,7 +2003,8 @@ static int ehci_state_executing(EHCIQueue *q) static int ehci_state_writeback(EHCIQueue *q) { EHCIPacket *p =3D QTAILQ_FIRST(&q->packets); - uint32_t *qtd, addr; + uint32_t *qtd; + uint64_t addr; int again =3D 0; =20 /* Write back the QTD from the QH area */ @@ -2441,6 +2445,11 @@ static int usb_ehci_post_load(void *opaque, int vers= ion_id) } } =20 + if (version_id < 3) { + s->a_fetch_addr =3D s->a_fetch_addr_pre_v3; + s->p_fetch_addr =3D s->p_fetch_addr_pre_v3; + } + return 0; } =20 @@ -2472,7 +2481,7 @@ static void usb_ehci_vm_state_change(void *opaque, bo= ol running, RunState state) =20 const VMStateDescription vmstate_ehci =3D { .name =3D "ehci-core", - .version_id =3D 2, + .version_id =3D 3, .minimum_version_id =3D 1, .pre_save =3D usb_ehci_pre_save, .post_load =3D usb_ehci_post_load, @@ -2501,8 +2510,10 @@ const VMStateDescription vmstate_ehci =3D { /* schedule state */ VMSTATE_UINT32(astate, EHCIState), VMSTATE_UINT32(pstate, EHCIState), - VMSTATE_UINT32(a_fetch_addr, EHCIState), - VMSTATE_UINT32(p_fetch_addr, EHCIState), + VMSTATE_UINT32_V(a_fetch_addr_pre_v3, EHCIState, 2), + VMSTATE_UINT32_V(p_fetch_addr_pre_v3, EHCIState, 2), + VMSTATE_UINT64_V(a_fetch_addr, EHCIState, 3), + VMSTATE_UINT64_V(p_fetch_addr, EHCIState, 3), VMSTATE_END_OF_LIST() } }; diff --git a/hw/usb/trace-events b/hw/usb/trace-events index 0d4318dcf1..8c90688bb3 100644 --- a/hw/usb/trace-events +++ b/hw/usb/trace-events @@ -86,15 +86,15 @@ usb_ehci_portsc_write(uint32_t addr, uint32_t port, uin= t32_t val) "wr mmio 0x%04 usb_ehci_portsc_change(uint32_t addr, uint32_t port, uint32_t new, uint32_= t old) "ch mmio 0x%04x [port %d] =3D 0x%x (old: 0x%x)" usb_ehci_usbsts(const char *sts, int state) "usbsts %s %d" usb_ehci_state(const char *schedule, const char *state) "%s schedule %s" -usb_ehci_qh_ptrs(void *q, uint32_t addr, uint32_t nxt, uint32_t c_qtd, uin= t32_t n_qtd, uint32_t a_qtd) "q %p - QH @ 0x%08x: next 0x%08x qtds 0x%08x,0= x%08x,0x%08x" -usb_ehci_qh_fields(uint32_t addr, int rl, int mplen, int eps, int ep, int = devaddr) "QH @ 0x%08x - rl %d, mplen %d, eps %d, ep %d, dev %d" -usb_ehci_qh_bits(uint32_t addr, int c, int h, int dtc, int i) "QH @ 0x%08x= - c %d, h %d, dtc %d, i %d" +usb_ehci_qh_ptrs(void *q, uint64_t addr, uint32_t nxt, uint32_t c_qtd, uin= t32_t n_qtd, uint32_t a_qtd) "q %p - QH @ 0x%" PRIx64 ": next 0x%08x qtds 0= x%08x,0x%08x,0x%08x" +usb_ehci_qh_fields(uint64_t addr, int rl, int mplen, int eps, int ep, int = devaddr) "QH @ 0x%" PRIx64 " - rl %d, mplen %d, eps %d, ep %d, dev %d" +usb_ehci_qh_bits(uint64_t addr, int c, int h, int dtc, int i) "QH @ 0x%" P= RIx64 " - c %d, h %d, dtc %d, i %d" usb_ehci_qh_tbytes(uint32_t tbytes) "updating tbytes to %d" -usb_ehci_qtd_ptrs(void *q, uint32_t addr, uint32_t nxt, uint32_t altnext) = "q %p - QTD @ 0x%08x: next 0x%08x altnext 0x%08x" -usb_ehci_qtd_fields(uint32_t addr, int tbytes, int cpage, int cerr, int pi= d) "QTD @ 0x%08x - tbytes %d, cpage %d, cerr %d, pid %d" -usb_ehci_qtd_bits(uint32_t addr, int ioc, int active, int halt, int babble= , int xacterr) "QTD @ 0x%08x - ioc %d, active %d, halt %d, babble %d, xacte= rr %d" -usb_ehci_itd(uint32_t addr, uint32_t nxt, uint32_t mplen, uint32_t mult, u= int32_t ep, uint32_t devaddr) "ITD @ 0x%08x: next 0x%08x - mplen %d, mult %= d, ep %d, dev %d" -usb_ehci_sitd(uint32_t addr, uint32_t nxt, uint32_t active) "ITD @ 0x%08x:= next 0x%08x - active %d" +usb_ehci_qtd_ptrs(void *q, uint64_t addr, uint32_t nxt, uint32_t altnext) = "q %p - QTD @ 0x%" PRIx64 ": next 0x%08x altnext 0x%08x" +usb_ehci_qtd_fields(uint64_t addr, int tbytes, int cpage, int cerr, int pi= d) "QTD @ 0x%" PRIx64 " - tbytes %d, cpage %d, cerr %d, pid %d" +usb_ehci_qtd_bits(uint64_t addr, int ioc, int active, int halt, int babble= , int xacterr) "QTD @ 0x%" PRIx64 " - ioc %d, active %d, halt %d, babble %d= , xacterr %d" +usb_ehci_itd(uint64_t addr, uint32_t nxt, uint32_t mplen, uint32_t mult, u= int32_t ep, uint32_t devaddr) "ITD @ 0x%" PRIx64 ": next 0x%08x - mplen %d,= mult %d, ep %d, dev %d" +usb_ehci_sitd(uint64_t addr, uint32_t nxt, uint32_t active) "SITD @ 0x%" P= RIx64 ": next 0x%08x - active %d" usb_ehci_port_attach(uint32_t port, const char *owner, const char *device)= "attach port #%d, owner %s, device %s" usb_ehci_port_detach(uint32_t port, const char *owner) "detach port #%d, o= wner %s" usb_ehci_port_reset(uint32_t port, int enable) "reset port #%d - %d" @@ -104,15 +104,15 @@ usb_ehci_port_resume(uint32_t port) "port #%d" usb_ehci_port_disable(uint32_t port) "port #%d" usb_ehci_queue_action(void *q, const char *action) "q %p: %s" usb_ehci_packet_action(void *q, void *p, const char *action) "q %p p %p: %= s" -usb_ehci_packet_submit(uint32_t qhaddr, uint32_t next, uint32_t qtdaddr, i= nt pid, size_t len, int endp, int status, int actual_length) "qh=3D0x%x, ne= xt=3D0x%x, qtd=3D0x%x, pid=3D0x%x, len=3D%zd, endp=3D0x%x, status=3D%d, act= ual_length=3D%d" +usb_ehci_packet_submit(uint64_t qhaddr, uint32_t next, uint64_t qtdaddr, i= nt pid, size_t len, int endp, int status, int actual_length) "qh=3D0x%" PRI= x64 ", next=3D0x%x, qtd=3D0x%" PRIx64 ", pid=3D0x%x, len=3D%zd, endp=3D0x%x= , status=3D%d, actual_length=3D%d" usb_ehci_irq(uint32_t level, uint32_t frindex, uint32_t sts, uint32_t mask= ) "level %d, frindex 0x%04x, sts 0x%x, mask 0x%x" usb_ehci_guest_bug(const char *reason) "%s" usb_ehci_doorbell_ring(void) "" usb_ehci_doorbell_ack(void) "" usb_ehci_dma_error(void) "" -usb_ehci_execute_complete(uint32_t qhaddr, uint32_t next, uint32_t qtdaddr= , int status, int actual_length) "qhaddr=3D0x%x, next=3D0x%x, qtdaddr=3D0x%= x, status=3D%d, actual_length=3D%d" -usb_ehci_fetchqh_reclaim_done(uint32_t qhaddr) "QH 0x%08x H-bit set, recla= mation status reset - done processing" -usb_ehci_fetchqh_dbg(uint32_t qhaddr, uint32_t h, uint32_t halt, uint32_t = active, uint32_t next) "QH 0x%08x (h 0x%x halt 0x%x active 0x%x) next 0x%08= x" +usb_ehci_execute_complete(uint64_t qhaddr, uint32_t next, uint64_t qtdaddr= , int status, int actual_length) "qhaddr=3D0x%" PRIx64 ", next=3D0x%x, qtda= ddr=3D0x%" PRIx64 ", status=3D%d, actual_length=3D%d" +usb_ehci_fetchqh_reclaim_done(uint64_t qhaddr) "QH 0x%" PRIx64 " H-bit set= , reclamation status reset - done processing" +usb_ehci_fetchqh_dbg(uint64_t qhaddr, uint32_t h, uint32_t halt, uint32_t = active, uint32_t next) "QH 0x%" PRIx64 " (h 0x%x halt 0x%x active 0x%x) nex= t 0x%08x" usb_ehci_periodic_state_advance(uint32_t frame, uint32_t list, uint32_t en= try) "frame=3D%d, list=3D0x%x, entry=3D0x%x" usb_ehci_skipped_uframes(uint64_t skipped_uframes) "skipped %" PRIu64 " uf= rames" usb_ehci_log(const char *msg) "%s" --=20 2.43.0 From nobody Thu Apr 30 00:39:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1776153719; cv=pass; d=zohomail.com; s=zohoarc; b=NCkC+Ovr+zjSdxTFPsTu+BWBJt1lr4yf2JVjxYOuULZK/aMLKNHGx7ZAkUyRJZAkvKvCaMTPEAAKjWdZiVPi/10t6N5pkz7FQw5nS8s6ggtsmTqEQw0MeLkY4W9jXsvkiq/OHvdL+toXC7P2aCckwgg7PZEG6BPWJ2Fj7Eioafs= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776153719; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=AUPW8ChXKsCgsbAjQSVjeZnlRz6pA1jlUQphP5cVbYw=; b=L+k5ossjcbT39ea9zLNHBUXqd0FPCuAwd5wgoOv571u15TyJZPR48dcNeGwbHc+3GV5buL3DBMoLOGkt6zENkUMM4zbSz831gK8OOBBoeqlXzoLdf8j4Opg3zzNlgelErP7h75AAltXN+6YzEK4r0P2XCZSHD/cLshApTvi4S9E= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776153719284563.6096404844576; Tue, 14 Apr 2026 01:01:59 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wCYhd-0003eN-Sy; Tue, 14 Apr 2026 04:00:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYhb-0003bn-GH; Tue, 14 Apr 2026 04:00:55 -0400 Received: from mail-koreacentralazlp170130006.outbound.protection.outlook.com ([2a01:111:f403:c40f::6] helo=SEYPR02CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYhZ-0005mG-Se; Tue, 14 Apr 2026 04:00:55 -0400 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19) by TYZPR06MB6745.apcprd06.prod.outlook.com (2603:1096:400:45a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Tue, 14 Apr 2026 08:00:35 +0000 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9769.046; Tue, 14 Apr 2026 08:00:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LNHvsCJWgjXaVWd9qLf4GIjyWF8QkN5Wi5hQLz8LtALiCh/0GN0yby7wk0py8PAfbdWjJ10rZltdy1WcpisDbVmCEsyMiag86YFLwPCF3GVKacE+6cA+WUm/X9NsmCWjKiyZ2/yZAb5YZ4eydUgyEosGH0hlsIkhVR+xStplUqwXioY9zooq11XcehWCDXEy2YNa3NCdgrTLa5kFqPDG2CtN9f0vYF9MJDozrVFf+Dggfn7PYoSzrAK6aa25Dd6K7LueOQk4gMzhLwb8/CfNVQT8bRcpv2Lyaftz30nXfKnxeA29IerZluGrI3vckUg/BqR41/FT2AbH/j2Vg2YfuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AUPW8ChXKsCgsbAjQSVjeZnlRz6pA1jlUQphP5cVbYw=; b=saQQ8JSs/scMuMxNpR10sT/Ccg5PNsVRBujFhdzY8UmDW6qo4qKXfe1RtyMvzQGWIk4GrjSV0mfI90JIlR3kChbznY9iykyUKOlyk/OS3FC7AHTRU88oczASadOkSXUkmOwc6jIhTmpvLBJ33yfSQ0Xfr8Dl06shk5nsWinU9kgBquiG1lLsoEgVH3r417pIekykQf9+pxVWGH6FUlBF91K9uzNUWg8Bs7kyZ2FKCLrJy4WBmhDztv3tzfOvGwo6WDZu62KUQhuat+4sf52N1pBaYAQInwhNmPIu7j9cvrFwG3gzGlH6JKGS1hwSOb/+Zg+q3frqAn2OlPngZeHCTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AUPW8ChXKsCgsbAjQSVjeZnlRz6pA1jlUQphP5cVbYw=; b=czReLdSolwtb0cz5baCT+Jg2PYnA5vXgaw9bKrwejBV80dp7rJcDQKreMEBqG83R7LOy/5xOgkNtREqxEcqkPgAdPxKCrYU67ZrPLUHz076QoYM3lvPtSIi+oLbJWEV3DBCiuCvGbfgX2Il4M/EdlpUEXbfr0V32+mrYYfOGyF41i8FjpYGe4qkUsCwyiXv2xXWkguqY/LVlTRM6S9DrdaQvNiTr2T+tqlJdowU8jWdYKi2FHk8075Lzyh//cEnvNAH/a4p0Pdd/1jcxG0EjetXq/Vm7fUoaJvUzgA6AOhQEd2NxVRZMkc6Vj/uwk77NMvvjLuBHFqG3NlHkhgXgfg== From: Jamin Lin To: =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , "flwu@google.com" , "nabihestefan@google.com" , =?iso-8859-1?Q?C=E9dric_Le_Goater?= Subject: [PATCH v2 07/17] hw/usb/hcd-ehci: Add property to advertise 64-bit addressing capability Thread-Topic: [PATCH v2 07/17] hw/usb/hcd-ehci: Add property to advertise 64-bit addressing capability Thread-Index: AQHcy+TFdtAGW3rvZUye0YiGqef7VQ== Date: Tue, 14 Apr 2026 08:00:34 +0000 Message-ID: <20260414080025.3005916-8-jamin_lin@aspeedtech.com> References: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYPPR06MB8206:EE_|TYZPR06MB6745:EE_ x-ms-office365-filtering-correlation-id: dfc2d845-3e11-49ad-3186-08de99fbe855 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|7416014|376014|366016|1800799024|38070700021|22082099003|56012099003|18002099003; x-microsoft-antispam-message-info: IHeHjfU0Suyel8heFHkOUvuMDWdd8sGb5JcJCnq0Okf1QigQG5kOQfrKDFGastWWZG+w3TsoeoqaQiwmEwKwYA9uiJTZXFZOmk2poqcSaG3oQZVpWf9LxDI5eRjMTNNPd7dXeuFaCKy2FUd/c3DI5WTYOliT3Uu9JEWybcab63FxwklHTug8+xHVbMNlvOIKSd8FQ1tNX4kOOglw3Q5CAps8/uF6lXyYXvAdZWBJeenPrc8lrFBSc7h8fi6GWimHgveOOfnjx3VWck5Re1E4Osmf9LX+2BdvMX97/ufMnnSSoYunNNrMzPRYGr7+pO9uxdARClbj2JkUEL29HcQx/QhrsqhBK9DtTlrYIbtfG06DvM19ZH9GFQdAP39RcAKdlo4QxM4oNWBaeS111g2h9JshyJgdpMvtct2uCKh7xuPYrfUN1M4gYC8iQYYv1GOZnUDpOo9ITLz/yKVDJ1NXQ5CyND1sFu1O4zFVWIs7T4iTmohjQSXBUseHTpZHjvio+qyNhCP1WVP2Ut+lCvQjOi7uhu7uSZxMbXIuKt9ZBFLp9u6uGJCJD9SJnz0CRN15SvrfVGpA4TxRwUNy9DC7ZO2H9fasu6Is4dX7b3SJezhWF3a3SeOZdACeun+WINspo0XyfuaJUjMRQZKzGd88TwpKuu3DMQ+U+xg8h5sNuXiifOGnQn2709WejgTNhkEzoo2DW3TPqsctqN/27d1+SWqPjwjtss3qlRmQp7ZJbJW1TxtumRxOMEAYBNu/NayqUzX6I0VYsSToe4DBlBlCa+svsSPxLErV8w2e3b68qLc= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(7416014)(376014)(366016)(1800799024)(38070700021)(22082099003)(56012099003)(18002099003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?LjE+nfgPxbhdlFdHQ9dt1sGyZGsablbz05KN1iDlXxeiFPDeb3FefDPYFB?= =?iso-8859-1?Q?oFpuuW+jZkxMk+ifL4AaSKmd7+V4R6jiXERXV+EhU5yLLDG0IBETYAkA85?= =?iso-8859-1?Q?m52bFZ/vjvDQjtnOSy9V6gjVflVkhINM5Ptf/N1oCqCbgy9rR2gymMi47a?= =?iso-8859-1?Q?Dlxfq7QTUS7EPkp+ySttKIZNGQsICg9/N8wnwlPWzFaswx57mD9Ies89WV?= =?iso-8859-1?Q?7fAB+rSAowgGCZ2IAlNFv4WmRf0s2M2wG4Ez+J0gS5vhy95sGNQHkoY5V6?= =?iso-8859-1?Q?4TbWcv2IjSr9fXLmCo8qGxn3k1s93o4THQ9+1dShlLKNfBDZD6dI5CiaZa?= =?iso-8859-1?Q?ptoTAhfQYtstVPaIwtof23rDtUkuRLOLUOhXZD/eIvlsN5OKFXzBzjlMpg?= =?iso-8859-1?Q?SCFyrlv9Jwm+OG1gkHtVgwuMmffc2NKpZkBCJhn8IHxA8DQjaZnAcSgS5a?= =?iso-8859-1?Q?FgQ7pwoBLy1xasRKWnjbAetRV1yAHw5u/zlvuHKHtbXrtYg9Zu2h6/j87O?= =?iso-8859-1?Q?VJU7RaUDQ+3Ya2r9GAoRrO2JxdA5d9i5Dpnzy82Z6lPlBojzTwsKThBRkp?= =?iso-8859-1?Q?7UG9D1I1H9e4Un4dVjURqGuXkG0764fjMUIpqgmft1E6v3PTX9aW0ERoD7?= =?iso-8859-1?Q?X3FACvHDzfPbWUaPtSoZzQ9PfUMd+RwJ3jICeBFAqO/CpVYdiG2RY6UsKM?= =?iso-8859-1?Q?Qfi+P6q/+X9XpBARNZBScI625YU1FjAevscWxkHDJEAmj2A1ti7I16Az33?= =?iso-8859-1?Q?VyRG5VxeJqT4ob+7oN5rMPmbyDxm9ql1wrcsYvkDZmoRuUsDSemxr0NbuD?= =?iso-8859-1?Q?YwDzR2MXu6tAnrXPk8VLZvhYGLeZykcbuzTGVLpJcNK3pbvDglzauSc2bx?= =?iso-8859-1?Q?Ed7+i1yl+HuZoPzYizGXYtNwXv0Qm8iLVTyATnuTiSnn09B2zuKZWcdLsz?= =?iso-8859-1?Q?KyePGplQfylREMnZZzMwTbQiiqJSm0N1MVv3WEJNIkrIPfIOguasuG/mRJ?= =?iso-8859-1?Q?Oi8XVTNuAszG1p1ebL1h5sYN65F4SsOBNCA3CaAUqwQ4dLmiYRUEaBXy6g?= =?iso-8859-1?Q?i7AtVhP5y7tnbuDOHq2BwdnHbM5BOI6IFyvb0Osg4u/Cw9pb7VS0oc//MM?= =?iso-8859-1?Q?VjLhWCCKlbwgjZ44PC+7/kZwJu8tiWwfzRRbVom0zOhe8icwoOGHQvycot?= =?iso-8859-1?Q?BiqcDcns8O/o6tzj31NpVJzs5ruPcF2SsHOKWCpuqnTs6MXeF0W5HhoK63?= =?iso-8859-1?Q?jVMrTgFfSh2M/Ix7LMbHvv5nPz2Y6JdDFph//NFyTFUGokqodFGHsohPZx?= =?iso-8859-1?Q?jOjP85WvBLXgQ46xCGNdAJXYX3+VugNt3PP02V8X48/YuHRK4oFs6Hl41M?= =?iso-8859-1?Q?3f7Z0lJUUzGKbFXtfFUo7TH7XZqC6EC4RD+ApBgXA309ieLbc++2ons1eM?= =?iso-8859-1?Q?b2bc0KoN2Y4hy/jBQugKKz+3+uzBhIm5nqz2RODEZGRPAXztkrlyibpWjE?= =?iso-8859-1?Q?IhrY9cJyd3fygg95bbozwAjzbgp/WKQe+62LsjcxupVOBtn+NBtZ70vVtU?= =?iso-8859-1?Q?f5rVAhM6uwuOv60Cn5VH0p9Mgd/+ck+WgmIWz4cPZzADynN0myNszy/79l?= =?iso-8859-1?Q?OowaLfCuw0QoNw9kMzwK6XHDTy+xW5QrigPL1h2++5EXEdpn2cIPmimW6l?= =?iso-8859-1?Q?GCzCYTp8kDgjtIETKHtop/PkdioDchMa63/gzzP+bKknsjN2mmxJkpcToc?= =?iso-8859-1?Q?+1qS0GI3KYSGLYZJu85ZWYKFhK0Vczp3omVUVraGqzc2K7wTXgpyfdzo8X?= =?iso-8859-1?Q?EIgZgTPbRQ=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: qUTbLYLnQ/1z3ePl7bVYUnQMKhLB0t8ieWjbvN7ISdMFgGepbdsYpIxAwRj9NYyuURe6L9xRxEWfIMYuxxQgbIHmONemG1AZ2utkt8neidihYjdCybVTay57SUCRVUJh8uXKxmatKU0rmuvBcoKBNYDRMlYEkKHyWypgV+OHbiuOxVwL+u2h58Im0WCJ/XhZTqAxtLJMVrTSpGTokfGXjOHMyuxbRrTr0zeJhhEFnZowybCKM7PerUfbRC+IGAMTnSH9L8BddLV2911bMIry3Uw8LOFIPr7wDxzO7fIzkGoZ44cFLZzkoEl1fruTtBg0tzbbTKxe+pzTQEUOrcTcDQ== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYPPR06MB8206.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dfc2d845-3e11-49ad-3186-08de99fbe855 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2026 08:00:34.6455 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jbpvdjauO8aXz6t5qcOAhl4tkBJM1AjSVqdZxObaeHPBA+QrMXmCTy3MbTOt7RY9awn1VDRxaJA9NfJVIp4UQlLCbtZA/ftiVryN0MLBito= X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB6745 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c40f::6; envelope-from=jamin_lin@aspeedtech.com; helo=SEYPR02CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1776153723473154100 Content-Type: text/plain; charset="utf-8" Introduce a new boolean property, "caps-64bit-addr", to control HCCPARAMS[0] (64-bit Addressing Capability). When enabled, the EHCI controller advertises support for 64-bit address memory pointers as defined in the EHCI specification (Table 2-7, HCCPARAMS). This allows software to use the 64-bit data structure formats described in Appendix B. When disabled (default), the controller reports 32-bit addressing capability and uses the standard 32-bit data structures. Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater --- hw/usb/hcd-ehci.h | 1 + hw/usb/hcd-ehci-pci.c | 2 ++ hw/usb/hcd-ehci-sysbus.c | 2 ++ hw/usb/hcd-ehci.c | 5 ++++- 4 files changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h index 24eea9d23b..fe4c508c32 100644 --- a/hw/usb/hcd-ehci.h +++ b/hw/usb/hcd-ehci.h @@ -256,6 +256,7 @@ struct EHCIState { =20 /* properties */ uint32_t maxframes; + bool caps_64bit_addr; =20 /* * EHCI spec version 1.0 Section 2.3 diff --git a/hw/usb/hcd-ehci-pci.c b/hw/usb/hcd-ehci-pci.c index 9febcc1031..2ea8549db9 100644 --- a/hw/usb/hcd-ehci-pci.c +++ b/hw/usb/hcd-ehci-pci.c @@ -137,6 +137,8 @@ static void usb_ehci_pci_write_config(PCIDevice *dev, u= int32_t addr, =20 static const Property ehci_pci_properties[] =3D { DEFINE_PROP_UINT32("maxframes", EHCIPCIState, ehci.maxframes, 128), + DEFINE_PROP_BOOL("caps-64bit-addr", EHCIPCIState, ehci.caps_64bit_addr, + false), }; =20 static const VMStateDescription vmstate_ehci_pci =3D { diff --git a/hw/usb/hcd-ehci-sysbus.c b/hw/usb/hcd-ehci-sysbus.c index b31032bbf3..61215e9f3d 100644 --- a/hw/usb/hcd-ehci-sysbus.c +++ b/hw/usb/hcd-ehci-sysbus.c @@ -34,6 +34,8 @@ static const Property ehci_sysbus_properties[] =3D { DEFINE_PROP_UINT32("maxframes", EHCISysBusState, ehci.maxframes, 128), DEFINE_PROP_BOOL("companion-enable", EHCISysBusState, ehci.companion_e= nable, false), + DEFINE_PROP_BOOL("caps-64bit-addr", EHCISysBusState, ehci.caps_64bit_a= ddr, + false), }; =20 static void usb_ehci_sysbus_realize(DeviceState *dev, Error **errp) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 315e8813f5..e3bff8e518 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -2532,6 +2532,9 @@ void usb_ehci_realize(EHCIState *s, DeviceState *dev,= Error **errp) s->maxframes); return; } + if (s->caps_64bit_addr) { + s->caps[0x08] |=3D BIT(0); + } =20 memory_region_add_subregion(&s->mem, s->capsbase, &s->mem_caps); memory_region_add_subregion(&s->mem, s->opregbase, &s->mem_opreg); @@ -2591,7 +2594,7 @@ void usb_ehci_init(EHCIState *s, DeviceState *dev) s->caps[0x05] =3D 0x00; /* No companion ports at present */ s->caps[0x06] =3D 0x00; s->caps[0x07] =3D 0x00; - s->caps[0x08] =3D 0x80; /* We can cache whole frame, no 64-bit = */ + s->caps[0x08] =3D 0x80; /* We can cache whole frame */ s->caps[0x0a] =3D 0x00; s->caps[0x0b] =3D 0x00; =20 --=20 2.43.0 From nobody Thu Apr 30 00:39:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1776153817; cv=pass; d=zohomail.com; s=zohoarc; b=QXjVwxec5eLliqTHc2BLORlnoT8RyeQ74zf/Itb9FC05NmfbeVQmqR7mHPLDCQwuAhpqJOPIIRbgTo7nFvMRpsu2k979GhpOCZWrNW+///2pa6F2SwEoYmsj0qKmwNi0NJ2USLIzMXJM3NpqrpsrGvlTY03T95MfiKizqxtFdu8= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776153817; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=aU8IkWc7WfKzrDM3ZBQ+aMW/imqYQd9QOl9MxOe/UGs=; b=TGTnmi5R82FSRXTLmSgWgBWq/0Dulf9Sq5D3ya+3wei0dCBaTS/cbsKY5VbUvuRnbQabnqBGm24UrGO16NCdkmMZAK3OgzI1sw4W/j8Yn1kEIjvIvLcMsiL81sqeSXfnQi9xoBm25VPA97mMGpKkzJyEkw/9n7SrypU4in9poKc= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776153817513283.11361793337846; Tue, 14 Apr 2026 01:03:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wCYhf-0003f6-LS; Tue, 14 Apr 2026 04:00:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYhd-0003dz-H4; Tue, 14 Apr 2026 04:00:57 -0400 Received: from mail-koreacentralazlp170130006.outbound.protection.outlook.com ([2a01:111:f403:c40f::6] helo=SEYPR02CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYhc-0005oL-2R; Tue, 14 Apr 2026 04:00:57 -0400 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19) by TYZPR06MB6745.apcprd06.prod.outlook.com (2603:1096:400:45a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Tue, 14 Apr 2026 08:00:36 +0000 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9769.046; Tue, 14 Apr 2026 08:00:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ndb7YumKcqR+09RcXRTu+3SVumBkOWfLj/0kFJoFAoBkKKTfjjMAKUGWwhYS3GBrdWh/zHQwsmly0G2UZILf9VwZ1aYJsb+TitK7F6+TRy6WgD541gI2YK8yPy2zAudvZGEmOu8hfv2zOc6gLwNNC2ToHTb2YCPBG7p5OYvuRaC7EBKR7uxFGVzKlx2BagumZ0+S5mjrJVQuznVM+UFl0tAog8kbfheqZsud2SrL/GuZvBxvSYtYBGrOO5SEglkfeUaR2jGQbhAQBcm7UCmDaA8LOA8C6vUPmkfKvGOeyNTgZr4uBI3iKEzlnt9u5LTRg7F0zsNBeC8p+1PP2lYswA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aU8IkWc7WfKzrDM3ZBQ+aMW/imqYQd9QOl9MxOe/UGs=; b=KOj0EVbqeQbLZP1f8Tn9DXSu9RxBSKtYuQWkmOWA1Gnd5TJeporIWCJ3R48WR+7n/c9kI7my+7ZQ+M5KRUesgw6JeS5IrfINVLWEOQz84fZRbmW0KxAE1Mzxn+8ZBOdAaIUfjDWXDVmRsH/gFVChf9kti9iy9u1MOJCOMKBbPjw4rwjtMDPsCTAD5UXLAgFHmH3rna08nQkvpO9Xm87QrCl2Xy6uFvYcfYKl6cplqJFq2cK4kH9ZrlU5MvCps3ZlywkSMSgdh99ZDOTmdBBmVUEa2S8yv7QQaYfxeubabezPPpw3epIT3pxOs2wCIa/jnmZUUMnxzn2F8FDPApLclA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aU8IkWc7WfKzrDM3ZBQ+aMW/imqYQd9QOl9MxOe/UGs=; b=YavMIYNfyKZrL36x6M9ox0XXDpsjQrkac7uDufN7a4vMKWrgbMSnwxdxBHcMosaWJrlaJr1qVB8MszqManm72ES9IfNmf9kCqrPJD3yJE2nHaMbPPSmvHwhFnfgMMFyEJp6AeH69nx8Rz4odequTn3lO+GiqWUP/5Mh+T+sCciG4GjxKuRQmMqBvIm2+PwOMOciLWxjsUdz+MY3fqjrnVvmukNSx3fYi936PyMiJ2nIAIth2IGga/gEJ2oZdG4mq3FVl5cR0PsGoX4iz3cUd2Qe7F38BZOvfZ+lNnVl0cF+0d3xCGF7YLidkAS0P5DQSVFPNEV6yOXmWJUeqhGNK6A== From: Jamin Lin To: =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , "flwu@google.com" , "nabihestefan@google.com" Subject: [PATCH v2 08/17] hw/usb/hcd-ehci: Reject CTRLDSSEGMENT writes without 64-bit capability Thread-Topic: [PATCH v2 08/17] hw/usb/hcd-ehci: Reject CTRLDSSEGMENT writes without 64-bit capability Thread-Index: AQHcy+TG7IgZ0tbh9EGKhlnAj2UbFQ== Date: Tue, 14 Apr 2026 08:00:35 +0000 Message-ID: <20260414080025.3005916-9-jamin_lin@aspeedtech.com> References: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYPPR06MB8206:EE_|TYZPR06MB6745:EE_ x-ms-office365-filtering-correlation-id: 380b9096-beaa-47ff-ae7c-08de99fbe936 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|38070700021|22082099003|56012099003|18002099003; x-microsoft-antispam-message-info: uKe/DhumztJHphZCStZJkcp6zB3rEt5k1waDo9T9jV/SLqXcgvfRWrpcchFHIeQ0oZ2WGfN5Q4zmkCjxSatHztVt2EJ9ooO9ON63JpTtIigTQu0AwSYJaQdFsA2tUKBbGQtP6kNgZea0zI9fNBzwwWLRc6p83xmShguusVVcTqf2W4oTZFQE0LUNIplHiBGc9npKQZ2L0OK0EleNrFEIJl82rJ6V8zkc5qG5JylbQdPtRJZJPhxghwgpFAofOTEuHu9j8xwOAzJU6yVqR07seKo+OmCBBmjoIX0wdBq4qCcCifybehvkSsj6OQuKSmYZp332NxX4/enD3/Ps3eGuzfMVxhFhxkAANMFVTRHwPz7zg4jxfiAF0wGuYxDlBtkhJencAoBKR/m0fC+DlChA3f4Nh8Oxj4Jx11gqDF+fF09WLctRR9cm4zF6mkNikldNmP/gOjkHCIIC6k0rFi/8nkyOZI6SvXsWB8Fjp4TNgzWxx4lFMKByA69LI3usZiz7RVffh9NgNYWm4dVEyC2BeUr0AFKr5wa05fcDrhTwuCuzmaXgZCFsimIN9qqMbVN6dYamSPcE0onMC027vOfBYrhUVMpnko87y2Fu25bm4jyACVWIRgf2YCVLOlMvixq1DRjRd/yenSlRZpLEHWdYZEz64ytJeUqxBlWUMsaDCJQGn0hDobJ8zmsC1QE2rGTHYULtSG3CGMhEY+iKB/ekyZrO64SPhehOtocFxyNTlLCTTLEy4jWrmxsdXX0uhFpi5GbAnNA69UZKsoskc4V8dyl1pJVR0SqIPwrXgx8rtd0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700021)(22082099003)(56012099003)(18002099003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?N4vbQ9fdCID3ir72TyItXjjEMMC3zgI96cGEcZ2BAwuugPM9/v9uqV+00C?= =?iso-8859-1?Q?tp7yy5sO6ZWmp1oyaNHzejUezEDa4LZvix0AwUSMNunqXeqnT7ME0PT9zd?= =?iso-8859-1?Q?c1dwEYWO7WfglBJ/FXP/AzE1IzScAqlBse0tAuID7O/+FLJzFp0HkdRPcH?= =?iso-8859-1?Q?NJFki4groTNKVeEJcl2ebQpDtx2Gru9xRZa3yISxuqFRVUJPIf7tK3s6Ph?= =?iso-8859-1?Q?Iq6mMaFAXUQT9Msd9tpKGsD9Gpmvw2Kxm8ifJds2BWNwibXhGYhPKNq8gl?= =?iso-8859-1?Q?QMwotOmQ9KEE20cAldQmxWH+QMGuKZcxaVrqr10sGjPnbJUgnIQ2CHfYvi?= =?iso-8859-1?Q?biavjX3WRHeL4ZDiouqsrRFMqrjlwdJQ415EXjwgS+tEWJfUkszUr3bKrF?= =?iso-8859-1?Q?PtHxafkSLS+zU6zsiIHnT+XAYSDk+6oRbFMHWXLkPoPeOIcuy0HX3KaUz3?= =?iso-8859-1?Q?W0mz3kFsvGNl48K+UKUIwDJuWe7LKfUq1mwhMjPaUXltqUUEldNe8bqvQG?= =?iso-8859-1?Q?fH75uKjYPkyc87/ol9O7+wRTzu0aaVaLVLvw42vhcHaWJqAZe6+SOnDzF2?= =?iso-8859-1?Q?FiyhhTBuil14VTJdEZn3s5UvgvvWJYoGH3KAjfZMFkX3A4L6MKkMyWKPCh?= =?iso-8859-1?Q?seFmbC28efWyJzDLgsDjfFL+wz0SdZJ9/8cUoB6RT8ZSluJyJiZfYfKvTX?= =?iso-8859-1?Q?GCST2tTCG9jarvCxeypFf4qGoxxMp0VQfPTdBb3fqpTuKtPm2K8JXy8DCk?= =?iso-8859-1?Q?gIE4fAGum/p8xepNZ7K3hl+rCEIuuWOcpoEQzQUlCmfA93bSsbrkCoBd9Q?= =?iso-8859-1?Q?G29A4cNOSovPhpT7+UGbmD9cN0akchsSqES8xDdFfFDIW8X2JXJ3dyTB+y?= =?iso-8859-1?Q?2m5GPvfvLQrIhFBhRUuXsIdxUu5IGAYN7F93vPnUA08pnSrNPyyK8SR6UO?= =?iso-8859-1?Q?9MrdSUweT8Y9kFiewGOVm0OE3SPxr3lQivLTxaf/byppEvtN2bZjwfB/EL?= =?iso-8859-1?Q?KrJ3LXk4zA1Oy97oDNEX7ZkwOCgLxBdo+e1hFi36+NgllUyiOccTMa1Ysl?= =?iso-8859-1?Q?M33nf7/j7+yVp3IITYlVnpn0x1LzWFnqGCHXCMp7/fV88OQukaQipIpeui?= =?iso-8859-1?Q?VQIm/KSp7wHVaZAWtJlvMj/FvXEHpbdj4D3wtEDSM8lSOJQjYa2FyssKUa?= =?iso-8859-1?Q?yyFUEO6mVASB21X0V1KTxjY3DU0ydpAK6U6N5sgQxxDCqw6/VGeTtgRABL?= =?iso-8859-1?Q?l1kBL8TQGekFM/XO62LDxEcuVt5uwzRIU5akLV7fm7fDXChYcUGc4lS91o?= =?iso-8859-1?Q?5Nwaxy9PE3nlGejPEBp2qFq7f4cI4VACHZvCIfgfzwOl5oswUAc4vwAwgO?= =?iso-8859-1?Q?8E7Zd8vL7Aowu4pYF84EK4LEm+F4FpGtB+54Wyvs3uyj6b1QUfi80VaZQ5?= =?iso-8859-1?Q?Q2sPDSwYlehiAbearmUpPF8odRwT5jZRsA673+MG1jU9G/CRjtNkCWUz16?= =?iso-8859-1?Q?SuKltktjJSQe2XXrgTjSfQhlW2fFywPRnj9yMWOwSSETNBScjgwwEI4I1H?= =?iso-8859-1?Q?80S/mdAwhT6YLDiUO22Pa1wSUsU+sRFuwBrdDwvkv1tUXqaA2z0TY5xOb9?= =?iso-8859-1?Q?Wvks8DNdvEGULAxMrU5dVT+toiMHAFLOlhrCB4UOVLthQCmCItcVu7X0nP?= =?iso-8859-1?Q?eKvqHpunomhxPyWv3f1avfiUvCmUCMiCARgtnEWsBmKTbWQy+GSWldLFvi?= =?iso-8859-1?Q?ttKIPJIt3iNdVu9w+NY/Qn43NYM2rnbb4es9NwJ43jTTjOZyqnYUb7oat5?= =?iso-8859-1?Q?mMdYvxGaPw=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: r3zpIWIYoy41LzXldVmpY+/7Ruli4obMmlzOz/UiYhsyWR6eFs94psd78cZTVOoFBJkisrau3Zpf9LKK/XYTXkWGp//ya3Nmlri6MVcuXEf4x152fDHSRvdV6ZhKiu2240viiPF0cY1CcTOFpkAhwNUyQCYWSTTcm8vZyuug2U2lU0I3QRqV9oZzvVyPh+Ovf3aKhY4LqwBhxLolZePjEcMC+uif0gcbQRbQsYwluO5TfDw/6oYMKvOX2wTmhUCNQWk3zYU0/0ifg3c/UWG+4Y1wJJcf0IBOo89t1MtMjPmLN3zm01LBCtCr9wvzj4fvWhwryyJ21CH635SLYKosYg== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYPPR06MB8206.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 380b9096-beaa-47ff-ae7c-08de99fbe936 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2026 08:00:35.7570 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: b6oxE8oLHeqlIzdWBs0xvOEFpXX5xyd3+uR7Xw8DcYDNo7J14HBWJsUKQaXPWmoDUt7ApddfTTOg0AvTpBkKrAt7VyhwtRYSRzBIVx6enmo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB6745 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c40f::6; envelope-from=jamin_lin@aspeedtech.com; helo=SEYPR02CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1776153818552158500 Content-Type: text/plain; charset="utf-8" The EHCI CTRLDSSEGMENT register provides the upper 32 bits [63:32] used to form 64-bit addresses for EHCI control data structures. Per EHCI 1.0 spec section 2.3.5, when the HCCPARAMS 64-bit Addressing Capability bit is zero, CTRLDSSEGMENT is not used: software cannot write it and reads must return zero. Add a capability check in the operational register write handler and reject guest writes to CTRLDSSEGMENT when 64-bit addressing is not enabled. Signed-off-by: Jamin Lin --- hw/usb/hcd-ehci.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index e3bff8e518..54a1a6f7f3 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -1108,7 +1108,14 @@ static void ehci_opreg_write(void *ptr, hwaddr addr, " is enabled and HC is enabled\n"); } break; - + case CTRLDSSEGMENT: + if (!s->caps_64bit_addr) { + qemu_log_mask(LOG_GUEST_ERROR, + "ehci: write to CTRLDSSEGMENT while " + " 64-bit addressing capability is disabled\= n"); + return; + } + break; case ASYNCLISTADDR: if (ehci_async_enabled(s)) { qemu_log_mask(LOG_GUEST_ERROR, --=20 2.43.0 From nobody Thu Apr 30 00:39:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1776153834; cv=pass; d=zohomail.com; s=zohoarc; b=a3Q9QOGmfEuSJp7jAgLelw+cSAIgM2m3Lh5On1WVNZP+RAYtFq2HfMPulbZHRkmwiv8N4f5O2cpu3XpyhuOJ8BEsMrwt5Hu88/36gk5XFkQW8jV2vXeByKiul+dtQKeMlpy0KNePiNPXlEdwAfjqQSO0RQGptqKSTwYPCz9n5eg= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776153834; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=MvnFkrtpXH4axWxrpZt231+nV+QZRS1GNqSEMuOKNjM=; b=kLCkHrPdf+v1daGjtThVRj3lvDY4s3ZtdjDZ+T7/ZUTSSqDRDnrJrOmckv5Yd/LObDmQof0vLw+xxkdXplTA2L48x+o7nP/VoqQO6/sB86lAtNF0UYgN79kz0raxvs1P+LsFIdEVVfftnqPlQJKIzFrxuuNju9tD6yHfPS3FA6o= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776153833845610.3002217034906; Tue, 14 Apr 2026 01:03:53 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wCYhY-0003ZC-GV; Tue, 14 Apr 2026 04:00:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYhW-0003Xh-2d; Tue, 14 Apr 2026 04:00:50 -0400 Received: from mail-japaneastazlp170120005.outbound.protection.outlook.com ([2a01:111:f403:c405::5] helo=TYPPR03CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYhP-0005tv-O3; Tue, 14 Apr 2026 04:00:47 -0400 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19) by SI4PR06MB8423.apcprd06.prod.outlook.com (2603:1096:4:299::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Tue, 14 Apr 2026 08:00:38 +0000 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9769.046; Tue, 14 Apr 2026 08:00:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pw0gcrKW5gokvjyAwBSvmI/5nyP/9xqovaihLHmFVT+UsAAmOrF89QtZG4DwInupnAT2F0g9Rjq/rI6WU6BXb6PxFqeNGtxk1gqZr3tJKwL/p+ZrHrnduBFsNKvBuw5Y4rUQvWzvvf+VendbqJ2JgOzKs5D4rwLe7F1E2xYSv1kK7WV/HniVFg5+d/qwRggmGKT+h3X7y19IOah14TKjWGZbFAKiVnQ0VQw9oakNMaSesSWE0PtuEEF4A7UtkElL0p4yJIzy1fc94BqSLZVlkN6Rp0NL4bu0EyiEiYl/bNfreSjBExhgPHiCQkRzwgnblnKXu0wxyceIwWMlnBRJbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MvnFkrtpXH4axWxrpZt231+nV+QZRS1GNqSEMuOKNjM=; b=Rrm+EYT5RYfgCSRFm+VAt3mmUajjszS4rH5aHjujlhdPTBUEkBc5x2VAKflL2w6D+i6ke8OEIThm4IiFpxZI37gXqyzwCIGFD6Kk/UKKmGEe069acusRPlJDpY6JmYdxuzSjXEw29NbPuP/IxSXbROwNAoz6nya4wTb6A3jnCnOBWLU6Ymc76/55PaLByWf5g1us2XMJ+pUEXlRuHXIu3Ul91QWUVWH7Zf21O1ispOzVNpy7HkhD4PGJfYgwNbNhddqCVMSlqtd0jnKPYTanbBgUMUn7UNZYH38lAqlCaP4sLW697QNMwjBOk0VH4UVBRx+UgVL9pbnipwDJKetVEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MvnFkrtpXH4axWxrpZt231+nV+QZRS1GNqSEMuOKNjM=; b=BVLO10ELOHRyu64DZtR2QYB50dB86jNKUOzwysmhNFk23wac9gy1eoXOxrV+s82jXq1ADx3MEDUAUcVqFZ7zy7X7BUnpkponlDO4lgL5kswyNbNGHitXVCm9zxNT0iZqXpr4w9k5sPNmi0whxaJ+OUj4/o6jGJ52Yi2BYT8k10aw5j7WYJ6n9xRso7xzNJLTPzbKMP/IFrgP0l2KVsFYhxWKVmVS3XCwIjQgdT83JpR002jThJVquyCvrgN8Mx2nxUlCL9eRFdyrfXxO2cP/bCMHA4fq88hZ9HEQxJkIUyZTfhZmMbfhLa/gwORQWoOvKEGRdoVXO1kFpi+/Vwehcw== From: Jamin Lin To: =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , "flwu@google.com" , "nabihestefan@google.com" Subject: [PATCH v2 09/17] hw/usb/hcd-ehci: Implement 64-bit QH descriptor addressing Thread-Topic: [PATCH v2 09/17] hw/usb/hcd-ehci: Implement 64-bit QH descriptor addressing Thread-Index: AQHcy+TH2pgmCK05ZUmQPzt4XoYVlA== Date: Tue, 14 Apr 2026 08:00:36 +0000 Message-ID: <20260414080025.3005916-10-jamin_lin@aspeedtech.com> References: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYPPR06MB8206:EE_|SI4PR06MB8423:EE_ x-ms-office365-filtering-correlation-id: c3eb7b70-382e-42d4-4f48-08de99fbea02 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|376014|38070700021|56012099003|18002099003|22082099003; x-microsoft-antispam-message-info: po4pDmxr6SpeSe9Qe3MdGrmFMxQgya9gNVq/wwRgTzvyQ9CoydNDx6wsmB6EBqg8CDD1f6WknJg4y6yxW4vd03zhVyOylY/cPvsYRiXcyLoP/RfJjqsTIhkoNihEeudtES8m+ssSLDYGKnKgaMPmavbU+tAHvwKgwV9bDLT/nRKk9c59mTMJbPNco+Rmwdq0VLKkNQPqofF6RXjQabZXGRjcRKIVFVCgYraPuSMGj9LoiQRuYa1qeB4ghQZnMNDdq/Sa/3XoSu0xShqcf5jQkI917P84cN4ZkTd5dV5jAuAiDOd22hydw2xIAOeU1MMjvnb2SHxthBXDilz/WvgjqPFJvjuNubqkAbqbySvULov/9j3If7FF4swvR0ZQ/twef48LAj/ITRy8dX+51EwYBMvXYHWs/fzAceOpvyudm4LcGjeG4SnKn94lS9tB3gDVoyuIbdmZlnSog1Ffd/+4M4/Kb6IdLyPydPRpMr1XeuF12aE6QxM7FvE/7kgflTbu6pI4KG5KR45Z3BrnRHLM/4eLib16Glq3BeJ/hFkBt0jn2MWdhM4LwNq92M+3a1undfU+47q+wDXG+ZCRki7XPtV7FqfFTRbjEdWyKNZ574AA4/14ETelg0BWCDF5spTpPu+QxbTBWfovNlbB2SfWNcdaznNZhU8A3L9FopkTNXq0RBUQFfVUuRrymm2EtdA1j6co8dy8eFEDR2auEx7TQDuToaiLFIXqLZ6rYV62QT7M1+IupuXMqom1A6K6iNGxIvDDhRuuQtSAJ2TmTwFoZOYLgFqnRUnXWg/XJ38nkxk= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(38070700021)(56012099003)(18002099003)(22082099003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?xZ5yYmn/sO5yKn5mBX+QIFbyUBwmg+1sschNPSXO7bo2mpAfyy7B2Jsuxt?= =?iso-8859-1?Q?l8/DXjw+9B1AkpDm/z50adLoM2oqq+aL5qr28Hjd+f1e/XNjtCVzjivZtQ?= =?iso-8859-1?Q?nW0aAK2HrivGY9lXv54X2u4WipvHdZ9Ot4yQu2HbA7BiGerygaFkpdV1HZ?= =?iso-8859-1?Q?FTW0mv/9RGAJPt4B7zB3a08rAscfDZJCn6U1KhcqetpTS6ItMoF1P81k0f?= =?iso-8859-1?Q?hysdmjQcyOxuHKKANhJWFfqkPFd/rtttRZEhfBFJX/FaX+VrM4qwnJlvkH?= =?iso-8859-1?Q?v6n8kwTpTXIYUTPrsuHeAXWd+T69GIJXBqqKveFo/yAZp+kgYvft9B1+W3?= =?iso-8859-1?Q?RvfiuX/aOV3bsjjAXAc5GffrHJ5MFc6pton+SEGjn03LfAWdE+PYAWLk+T?= =?iso-8859-1?Q?/IQr/wdbktLaMLsP6MTIU695B6MOQ0MEMW+bakYj2xyt4bc/oljMpm1bBA?= =?iso-8859-1?Q?V3TZH63XidAXkX0AJiqpEOfaE5+Z5cBz+R43lcS8Zh2lBYtS9jbCOkjS0J?= =?iso-8859-1?Q?y9ybWyZs5wvgnZ0Z16ILgkozQQebgXadsYrBj7dWCRB7PIvpQFM81jaci9?= =?iso-8859-1?Q?BvxXL3xDkotoUUHFYAvAyLuoTrqRnMCHh5CSQriC13Fpl5K1Uyk6G8HE0l?= =?iso-8859-1?Q?Iy+/d474PFQv6qcRCGspFOmfB+l7H4vHK1D7QKU36KaEQr7K5k6EMK7Ky/?= =?iso-8859-1?Q?thjRoQn/tju13Y6L7ijzIY8FVFlc/KXnt5X61GAgHbgFeegdrZI7NMpr5O?= =?iso-8859-1?Q?5a6TbxGswr2cbxCP0ckWJ6Lru8aGT77B4tsPtWVhuwv7DWjEO2G/IA3Z6Q?= =?iso-8859-1?Q?RHsMVMMMj347CeDtIGigVrCkBw7HZW5pQPTkcL1aOchnkIh62UABBCOLla?= =?iso-8859-1?Q?sBZW8kvRbmaTAIvWeIaLQTtXGbkBl12UjQZAKxzt+OefHxf2FeiUcBYMwV?= =?iso-8859-1?Q?ed+nJjfHWkiZcFCoHXxlgvVwxFQsw/WvZvOMUePs9iV7Sk3k9CR++LsN0/?= =?iso-8859-1?Q?Vd3wbu7zC7h0e+srpP2YzH5sEpV5KCMmGz9vA82p3jXq58RwYaWzkQ0MFD?= =?iso-8859-1?Q?G3J6rr3f16Ykw3MJOWsuA9JEMeEt3liit1/n1sjGFrIukxUglnBI1cVhLl?= =?iso-8859-1?Q?SwPIkQbnrAL1Fp0DiQ6yOTTU9J33fLq/pf6op7b6zUv/B77tH2ZhNOy95G?= =?iso-8859-1?Q?AK3wilNjClUvtoN3S+M4Asvezt7Q4xk0HHPSI1M+FJQDLvVdZQSgZwEKA2?= =?iso-8859-1?Q?PC2s7IhmtS2lJ2R8tCPRDZd3EX6/5JMvc1ZL/dXns6P5fBBkYurLabLYm5?= =?iso-8859-1?Q?f12sEBWOUoxQxvUQObB+wwmMU1EehR1ttKUPeKmCsWLp1HkTirO13TP/3T?= =?iso-8859-1?Q?yFAUQzh6kbotgZwAY2EyNJ1G84pAebaeTlbSjIaJhtLW1Ww+Iyy46HxJvV?= =?iso-8859-1?Q?yA+11y4evU1oT3AYQ9rtBFPxb1BQk8qaxq2vYwY9ktUSu9vFQrKHOO/3mD?= =?iso-8859-1?Q?X8oj1UkQ3U/IyBrfckLHXTFuRQ3FIPlROdHJ3To13npznFvvvh6Q7JgWFL?= =?iso-8859-1?Q?Bv1L51HWt9MMz4xdoDUZiQ8iJEYuF9OLjTVQ89YgUvSm0+bjs8i1RpYFbN?= =?iso-8859-1?Q?mmc2LD++ZPl4UVgLyiTHT37Yrn5xDItHrposhc77Ha/fKPmdDhhYMye4cI?= =?iso-8859-1?Q?K54lc7/4zM9j8cVTic3XA2GSFJLCCR6CDR4msFyCodHZXzoRZp9XxiADA6?= =?iso-8859-1?Q?G2RFTJ5+/DP58c/d9yuGPrqDhd6c9YBD2/JENSYzGfrdaK5HTlWAUBrWiY?= =?iso-8859-1?Q?8yJBgNrX0g=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: MkqQDiB9XjrTDDVtuX/cdleu2XlDnzErKgUcppinqXzCxrXLyQ09B5sERNhrzqMxF371tNb9fCb3iDk3SxhSHQkBlItPjS/EaAL0P4iD5blBLm5Ymrh9Bd/XCJRmkjUgELVgD7Zs0vezHXMpDfgZcoaOmdUmvCizEFC8sIHIZXkxdyGp5G83IvZnCyTc2iY7RuAlMQAx6BepFJlLTJIFp4123MIK+GvQp3BL+6Y4W7igpIuQGjo9WzmGwh9tzaYCXjijEK6tolY7UKhPGAwsY2eaLnLOcMXozX27s3wH3aYCeqjfUupCVq6a/k6oghKDXy007KZ30YocTbVfgZ6uNA== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYPPR06MB8206.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c3eb7b70-382e-42d4-4f48-08de99fbea02 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2026 08:00:36.9808 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kulnf8EQqPTMwZxi2AzUR1QTekdC4e2squmtokYV446YQC/KDdTTnEnr737mOUs9koolettQn2h5OWNU8pyiVEYJX75d+8XJztphiPVzV/Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI4PR06MB8423 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c405::5; envelope-from=jamin_lin@aspeedtech.com; helo=TYPPR03CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1776153836692158500 Content-Type: text/plain; charset="utf-8" EHCI supports 64-bit control data structure addressing when the 64-bit Addressing Capability bit in HCCPARAMS is set. In that mode, the CTRLDSSEGMENT register supplies the upper 32 bits which are concatenated with 32-bit link pointer fields to form full 64-bit descriptor addresses (EHCI 1.0, section 2.3.5 and Appendix B). The current implementation assumes 32-bit QH descriptor addresses and directly uses link pointer values without applying the CTRLDSSEGMENT upper dword. Introduce a helper, ehci_get_desc_addr(), to construct full 64-bit descriptor addresses when 64-bit capability is enabled. Update QH traversal paths (async list walk, horizontal QH link, and periodic schedule entry handling) to use the translated 64-bit addresses. Introduce ehci_get_buf_addr() to construct full 64-bit buffer addresses from bufptr[] and bufptr_hi[] fields. Use this helper when calculating transfer buffer addresses so that data buffers above 4GB are correctly handled. Also add bufptr_hi[5] to EHCIqh to support 64-bit buffer pointer fields as defined in Appendix B. When 64-bit capability is disabled, descriptor addresses remain 32-bit and existing behaviour is unchanged. Signed-off-by: Jamin Lin --- hw/usb/hcd-ehci.h | 4 ++++ hw/usb/hcd-ehci.c | 48 ++++++++++++++++++++++++++++++++++----------- hw/usb/trace-events | 2 +- 3 files changed, 42 insertions(+), 12 deletions(-) diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h index fe4c508c32..773f376834 100644 --- a/hw/usb/hcd-ehci.h +++ b/hw/usb/hcd-ehci.h @@ -141,6 +141,9 @@ typedef struct EHCIqtd { #define QTD_BUFPTR_SH 12 } EHCIqtd; =20 +/* QH overlay: altnext_qtd, token, bufptr[5], bufptr_hi[5] */ +#define EHCI_QH_OVERLAY_COUNT 12 + /* * EHCI spec version 1.0 Section 3.6 */ @@ -194,6 +197,7 @@ typedef struct EHCIqh { #define BUFPTR_FRAMETAG_MASK 0x0000001f #define BUFPTR_SBYTES_MASK 0x00000fe0 #define BUFPTR_SBYTES_SH 5 + uint32_t bufptr_hi[5]; } EHCIqh; =20 enum async_state { diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 54a1a6f7f3..d1d68b0342 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -147,6 +147,24 @@ static const char *addr2str(hwaddr addr) return nr2str(ehci_mmio_names, ARRAY_SIZE(ehci_mmio_names), addr); } =20 +static uint64_t ehci_get_buf_addr(EHCIState *s, uint32_t hi, uint32_t low, + uint32_t mask) +{ + uint64_t addr; + + addr =3D (uint64_t)(low & mask); + if (s->caps_64bit_addr) { + addr |=3D (uint64_t)hi << 32; + } + + return addr; +} + +static uint64_t ehci_get_desc_addr(EHCIState *s, uint32_t low) +{ + return ehci_get_buf_addr(s, s->ctrldssegment, low, UINT32_MAX); +} + static void ehci_trace_usbsts(uint32_t mask, int state) { /* interrupts */ @@ -440,7 +458,7 @@ static bool ehci_verify_qh(EHCIQueue *q, EHCIqh *qh) (qh->current_qtd !=3D q->qh.current_qtd) || (q->async && qh->next_qtd !=3D q->qh.next_qtd) || (memcmp(&qh->altnext_qtd, &q->qh.altnext_qtd, - 7 * sizeof(uint32_t)) !=3D 0) || + EHCI_QH_OVERLAY_COUNT * sizeof(uint32_t)) !=3D 0) || (q->dev !=3D NULL && q->dev->addr !=3D devaddr)) { return false; } else { @@ -1536,7 +1554,9 @@ static int ehci_state_waitlisthead(EHCIState *ehci, = int async) EHCIqh qh; int i =3D 0; int again =3D 0; - uint64_t entry =3D ehci->asynclistaddr; + uint64_t entry =3D 0; + + entry =3D ehci_get_desc_addr(ehci, ehci->asynclistaddr); =20 /* set reclamation flag at start event (4.8.6) */ if (async) { @@ -1564,8 +1584,8 @@ static int ehci_state_waitlisthead(EHCIState *ehci, = int async) goto out; } =20 - entry =3D qh.next; - if (entry =3D=3D ehci->asynclistaddr) { + entry =3D ehci_get_desc_addr(ehci, qh.next); + if (entry =3D=3D ehci_get_desc_addr(ehci, ehci->asynclistaddr)) { break; } } @@ -1691,7 +1711,7 @@ static EHCIQueue *ehci_state_fetchqh(EHCIState *ehci,= int async) } =20 if (trace_event_get_state_backends(TRACE_USB_EHCI_FETCHQH_DBG)) { - if (q->qhaddr !=3D q->qh.next) { + if (q->qhaddr !=3D ehci_get_desc_addr(ehci, q->qh.next)) { trace_usb_ehci_fetchqh_dbg(q->qhaddr, q->qh.epchar & QH_EPCHAR_H, q->qh.token & QTD_TOKEN_HALT, @@ -1868,10 +1888,12 @@ static int ehci_state_fetchqtd(EHCIQueue *q) =20 static int ehci_state_horizqh(EHCIQueue *q) { + uint64_t addr; int again =3D 0; =20 - if (ehci_get_fetch_addr(q->ehci, q->async) !=3D q->qh.next) { - ehci_set_fetch_addr(q->ehci, q->async, q->qh.next); + addr =3D ehci_get_desc_addr(q->ehci, q->qh.next); + if (ehci_get_fetch_addr(q->ehci, q->async) !=3D addr) { + ehci_set_fetch_addr(q->ehci, q->async, addr); ehci_set_state(q->ehci, q->async, EST_FETCHENTRY); again =3D 1; } else { @@ -2200,6 +2222,8 @@ static void ehci_advance_periodic_state(EHCIState *eh= ci) uint32_t entry; uint32_t list; const int async =3D 0; + uint64_t entry64; + uint64_t list64; =20 /* 4.6 */ =20 @@ -2224,12 +2248,14 @@ static void ehci_advance_periodic_state(EHCIState *= ehci) break; } list |=3D ((ehci->frindex & 0x1ff8) >> 1); - - if (get_dwords(ehci, list, &entry, 1) < 0) { + list64 =3D ehci_get_desc_addr(ehci, list); + if (get_dwords(ehci, list64, &entry, 1) < 0) { break; } - trace_usb_ehci_periodic_state_advance(ehci->frindex / 8, list, ent= ry); - ehci_set_fetch_addr(ehci, async, entry); + entry64 =3D ehci_get_desc_addr(ehci, entry); + trace_usb_ehci_periodic_state_advance(ehci->frindex / 8, + list64, entry64); + ehci_set_fetch_addr(ehci, async, entry64); ehci_set_state(ehci, async, EST_FETCHENTRY); ehci_advance_state(ehci, async); ehci_queues_rip_unused(ehci, async); diff --git a/hw/usb/trace-events b/hw/usb/trace-events index 8c90688bb3..67249d69c2 100644 --- a/hw/usb/trace-events +++ b/hw/usb/trace-events @@ -113,7 +113,7 @@ usb_ehci_dma_error(void) "" usb_ehci_execute_complete(uint64_t qhaddr, uint32_t next, uint64_t qtdaddr= , int status, int actual_length) "qhaddr=3D0x%" PRIx64 ", next=3D0x%x, qtda= ddr=3D0x%" PRIx64 ", status=3D%d, actual_length=3D%d" usb_ehci_fetchqh_reclaim_done(uint64_t qhaddr) "QH 0x%" PRIx64 " H-bit set= , reclamation status reset - done processing" usb_ehci_fetchqh_dbg(uint64_t qhaddr, uint32_t h, uint32_t halt, uint32_t = active, uint32_t next) "QH 0x%" PRIx64 " (h 0x%x halt 0x%x active 0x%x) nex= t 0x%08x" -usb_ehci_periodic_state_advance(uint32_t frame, uint32_t list, uint32_t en= try) "frame=3D%d, list=3D0x%x, entry=3D0x%x" +usb_ehci_periodic_state_advance(uint32_t frame, uint64_t list, uint64_t en= try) "frame=3D%d, list=3D0x%" PRIx64 ", entry=3D0x%" PRIx64 usb_ehci_skipped_uframes(uint64_t skipped_uframes) "skipped %" PRIu64 " uf= rames" usb_ehci_log(const char *msg) "%s" =20 --=20 2.43.0 From nobody Thu Apr 30 00:39:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1776153852; cv=pass; d=zohomail.com; s=zohoarc; b=l97QyAMmXal1LW14C1ZmZKWKxxs7Uh8X+HqiX6lUC54D6EMY3/eMQayXGQSzOKARNAzrOmMlfWEKb56FXauJuBPrNO2wLSLJfaRiBCHuujyLO8/vO7MJkcpZAsARWpihPWkSt7Z6NEeQcwBv//8Drmxcr2pt5VEz0/Ax5PQC9nY= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776153852; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=SttPpTtS2xkODYGwFInJuvplfMl6KLJGD8oXhnldHOI=; b=NYXVIGspFkoNq6SSFoqazAY24Yh0kYl9G9xyWWSpQ+tnYIO6CZzyTQP/OHFzqHOwsMPzevO3MrLtagnWBekAV4XNeLWXTEWBaf1YyV/kf/TI7H41dkKr1Jg3AOqcngBnQSIILZufKuvXd6lcLPw2kfb3X/nbJyhUiO2N+RHgaK8= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177615385293846.55329960009999; Tue, 14 Apr 2026 01:04:12 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wCYhe-0003eY-Ba; Tue, 14 Apr 2026 04:00:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYhY-0003ZD-Fa; Tue, 14 Apr 2026 04:00:52 -0400 Received: from mail-japaneastazlp170120005.outbound.protection.outlook.com ([2a01:111:f403:c405::5] helo=TYPPR03CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYhW-00060M-F4; Tue, 14 Apr 2026 04:00:52 -0400 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19) by SI4PR06MB8423.apcprd06.prod.outlook.com (2603:1096:4:299::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Tue, 14 Apr 2026 08:00:38 +0000 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9769.046; Tue, 14 Apr 2026 08:00:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ERjXc6EzoKNK4vNA1lECWSPdZBSfmp9Z10nG0W0Kg/BPk2KAEv1f5z4ZM7WPmgXXMZdhr4JuuZ/GCDL56uLIFvyH5R49aq5RYVNhopHMPcneN09Zc1dLFd++otFcuOVmHHqmAulO3xvFS+Ks1oJWnkutyHL46KKarqrgMltFhiczEegii75Zhhly+19PQbvuAmn4+23iTmY1GeW4fumrCtqob9qMYTn8kWISez5hdwE3WLbSQXMwwblE0SOwwKkwxlh5Ov1PYz3DDq+XgKXMKyQWm/qYmvqn/tUomWTfIzBAOh58nLwiV+8FNPLzDUil34O6Y7D+AwEYag+UuyCMOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SttPpTtS2xkODYGwFInJuvplfMl6KLJGD8oXhnldHOI=; b=FUhfwhDtYOmaDVqwB1Sqx30ML6rcyfcxWB5WDg34HD3QwGCw1/AeRlKiedSu1m3oQULPgB/0fHU1guj3zxh5a+FnbBqGJFC72akakCbHprKQNiKWePGozdJ7mUUqJZ+KMw+cENCgSvBeZJYioNZMCtYcuTPeRC4UvlqNFgJTbl7IQuvjJ486HDH9AEtS/YiKw2ct1gPQZ74c1KIt5XsrXtN8IW+stYO2BqGRQg7a0eWaxsfViJqUXd1iQvZdMd0vWCXBiUcsdJn+znebI8KsVPenX8Tu4LGW2VlFMdWnDB4C0jstKTo83nqB/wBa1dSzzCXUpatHrKNAFq2bDLQHiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SttPpTtS2xkODYGwFInJuvplfMl6KLJGD8oXhnldHOI=; b=jYZpsxi0f9lc0E2scSyOKkx78zBo/UbFKTLDwTGsM0AjDQ4B2NGyBeDlG5r9AYfSF9EHUR62KVgutBSmzT2VR7eE+hIEIITWSb10AzOsuJfIlB1DcgkqkeM6YYIDau1S2re37IFezTp0CbcUgIizD4SUbs8ECtmeVO7bfVEfQCV+EK7xfCKdRuUdjDuyfNxGwWUi1wjLjG8wEMfQaY3U1dGUdGvGUdD5/zqk9/+VygM3xTmWPpCtgYdAZv88zW5FNhxwUd/QvHw8p8dY1BpdV/OnQTs01IPcikfvHXmiIIZAnqVATFTEFUoPaD/NtexN0wX5a/6wnwovXbeNudQPvg== From: Jamin Lin To: =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , "flwu@google.com" , "nabihestefan@google.com" Subject: [PATCH v2 10/17] hw/usb/hcd-ehci: Implement 64-bit qTD descriptor addressing Thread-Topic: [PATCH v2 10/17] hw/usb/hcd-ehci: Implement 64-bit qTD descriptor addressing Thread-Index: AQHcy+THb5qoE5nHt0KpM8UKVJWg5A== Date: Tue, 14 Apr 2026 08:00:38 +0000 Message-ID: <20260414080025.3005916-11-jamin_lin@aspeedtech.com> References: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYPPR06MB8206:EE_|SI4PR06MB8423:EE_ x-ms-office365-filtering-correlation-id: a54e93b4-2270-45ce-0cb8-08de99fbeabe x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|376014|38070700021|56012099003|18002099003|22082099003; x-microsoft-antispam-message-info: khaOERuK5IUJ1GHYZ5eGt6rOcYXIqDBLENSN5sCEjoKcYvmelbCCaG8CAv7mWS9PlwpkhQJ9xilNT+BSlt3vtS14qEYThcWrjVYy1TrBLPHXNLkdRyrp052BJG2omWXS9/78aodf5fgVNxaspnc+a/85asH1YXP0tU8VGZG617K3XGhMAzPn9ld0DhAPO3cx1lgfJvjxmEC2dJtcJqnL32I3TitguJjb+YBeEM/Fu8SJd2lxLAThscOW6/E0Jy/GjRwS0G0xMrPcspC89Onk74/xhuFzmLM6kYf97T4EGxnLzbXm27/Goob4hHixaK48kOYmMk/UZp75GCFpq8rq0VbcXbKS8PZAc9Tw4TBVwwow0TQc8lx/8TMXM+rT9UXWH7GAtPdzexPMue1ovtjCNFrhHGZcoBSVdcqOc+rwi/q1yXBdaFzJyl/ml4U0u+CJAkYCrzbDf1m/kWcWqMjhaSSzmaVVntw8MdoG2Re0rugsGZq6Mtjkw2ikv8qDzSOzMSHRAg8mVO172vHETc9vzjYYf2poK1RjN7zPa8EgSdDTyvX66WZbIjDqYjzkCQEXxm8WMSTkJD1y3xNyP5l9F4p1nX/YOvK9RJmQGKvjh+le0BogNTKbLY7T/xbwm/Nt3a5jDZ7H/+cntcu/jrbOz8OBas+IANxTUtuKGj+7p7Gh4b+W1PFxwzsHlqkWqw6lLMMGLYWxBpjYcXlW372FTCcuEKo0AnktbHjOGcqbJEheVFv7vv4nRzF3huRv80FvXpX2FqUnGo53JcR887biDgDC1wUtB82hmZKN8VAlMzM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(38070700021)(56012099003)(18002099003)(22082099003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?zMbOsGZltDQvWIKr16NY5W9ecCWcGFmAmnNMEO9gzEpokKGDqkMqc3FhGb?= =?iso-8859-1?Q?tm957euxHkTqxbxFVuy+8CGA2wf8l+kwhMA8HvQ5IfOiN9P3Cm5L/Hayh8?= =?iso-8859-1?Q?p2wZOcN2c9pWWSy6DsDZoeVPKD0aPWkBmLpMKgk9XyMyAThdSOS30/xG4d?= =?iso-8859-1?Q?uVBnCJzgvb+Fpg0x2vuBFm2QaHhy1KYpMVMFlRRBDRJ9R/ILlrggnMHNso?= =?iso-8859-1?Q?y1mdu/SA8lBGWYDrSbD3WdYDZD1KwvOygCPqbgdy9ouYqooRN1t0ah8pPn?= =?iso-8859-1?Q?IXixi3q0YX2iFBQaKWPt3Yl3/plwMVwvpM4HiXToEcPPnsDXMvBPg2suBf?= =?iso-8859-1?Q?WNIdHLk8Dy/cmsFsBR93oZ8wiDNQfCUNcrOTnm6hTZ4aAHSh6J2G9N5Ujw?= =?iso-8859-1?Q?7GoTYWIWpKUtHjAyQkLfPTTmnLq6+c3wwbx7QCKI6vm2ECb7j1mGXHb/lu?= =?iso-8859-1?Q?Ph11VLcYsIN4z47DFH4HU5LLpyq5oXAUOxfiZ7ys5R3B4gJ/k11Q8xc8TH?= =?iso-8859-1?Q?2k4BF9RxKMSV1vCodckj7Jp2EDa0CG+Oi+nSfxi2XB3hRdjPUO5PCAqPBF?= =?iso-8859-1?Q?3NEaZ2reOFnL8bYsqghoH5IwWjf0zNu99h2BjuQvsZ6izDyod4LgL6qa8H?= =?iso-8859-1?Q?yZWllIcHs7Hw6Omw4Yj7jTV/kzp49DzIsdF4cKt1T7LslSALMnEbGhK/+H?= =?iso-8859-1?Q?TCcsJuR69pvIEq+K1sHaZL2veMTKfjI7T1eqxqY/dkLqO54IA6xHe4VKk9?= =?iso-8859-1?Q?Q4374zNyu1SIP8pSw3regCnFKUcAXEOVeyYC49RXhl3JbpgUq+/cP6ytQl?= =?iso-8859-1?Q?hzcQoBelwLWQk0uZA2jzvtrN002hQwUuSCMhy3jfJXVJ2vtwuL3UfB+5M0?= =?iso-8859-1?Q?jD+GY9S3LiO6EUBOpppEzB7tawNmsltSYPI7iViTS3GaYi5S9ojk2F5B/Z?= =?iso-8859-1?Q?jqzTzyjtYQEN0ApBwnhtF8WZalLeKoHjcnzH5xDCVqC25X77ynGIuEyc8a?= =?iso-8859-1?Q?HQQw/znsvnndodH5gTGImG2oesZLQttsBjl+svxGfXIBRNbwpq0GNVROa3?= =?iso-8859-1?Q?tEApUED6Av8E+dP4hkwHMyAMWRBet5mtCAt/wGaxl0U6JuEo+7nQyB2fK3?= =?iso-8859-1?Q?HoLNrWK/hR9CA6KO6jOFJcNhWQYJvEnrbebZcz/jNEvfueYjyYd2+eHL5/?= =?iso-8859-1?Q?9Xz+ZaFLZO1QJvjrJPlshMi7gcmh61ccNUMTsoHiBalotSOoBw/njkNPjh?= =?iso-8859-1?Q?IhgWKTzfd9dkaC70gk+tbYjNRkvulUdVrcNqRSV5UlGCBGw7INs/AumP2b?= =?iso-8859-1?Q?pXWSraLXtgQ1/98xrpYXkqtSFgQnmNi4ODNmQlScbmdRgNu9w8NIWMwD2k?= =?iso-8859-1?Q?+ICpD2FZfYZT3eEhN4rqMCL6o05OiE6Jg7HNTv+JWIEnT9fISbP36+aU6K?= =?iso-8859-1?Q?+9MD5IzvDOHh8V253vEEbaG8TO2e0jXz2uEKemuKEZR9Vv7EeRImWxNPQV?= =?iso-8859-1?Q?0wW/ZeSQo7hfpKga9DGEr5DESm6ApWJmB0DX+n+j3SR+l9kpqjaPF1X1Ab?= =?iso-8859-1?Q?s5Uixs/ugcMWFK4tnOI+RxeMS3Zoo6/HX2NfBjGIPgMipyYZoXn+D7aUsM?= =?iso-8859-1?Q?KjUkBycXKfZ5z74DP1+tqGQLIvH9fOZOFCAGdhEdGB6mY7gdM+rKoz+rgb?= =?iso-8859-1?Q?2fOifWqVallYFbyX3AnRuB1oN0Q4Z1uERQBUBijcKS/BHjeWrGJvzN/ihT?= =?iso-8859-1?Q?kki5NHLR8ZK6vhTzg4/cKuFzL0ZrmzQvoKeAmA03rQhT0VL9fKXHb5w65p?= =?iso-8859-1?Q?6jvqI2oQYg=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: Rx0awyTsD2N6pii0+jPq5cCo7ZUEmEmezlNcKIOZGGFwzrTQn9wnoGRf47ex6gExmQU5TaAoL3IpqaZcIPnJlLWIjdZ+M8si86Z6bSzumQA+yPbxTQFLwrQFe1TGsh9nu/z+CpcG4pq5Wu3UixwEWEsOJJnBvoalTfIdZ99a6ta8j/EA9BMwBDodFiy/e3fb/CxFiMfHDrW9j4DZR5uXtd2q4pjhlxdIZKAKpaLMHG3bQ1JdhhIVuxLxbhp49NLyPiWLttd6P5daUepTCJ7WUEuyWUgfksZyJAkyxNwW+pJtsdYTkMmVeq4tMRpF5SXZkooQ4qLBzh+3oEbCMBzdAw== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYPPR06MB8206.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a54e93b4-2270-45ce-0cb8-08de99fbeabe X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2026 08:00:38.1020 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xMKJneo8VjixtYtzFP6lQTrQ1lPzE4SN9rPMWK5ZyqR7xDxCJpsvI+SjSYz8CVC9Q0WXTi9DmQUDMbG8UgQVw3Iffj7iEfStsS2m+av9cMA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI4PR06MB8423 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c405::5; envelope-from=jamin_lin@aspeedtech.com; helo=TYPPR03CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1776153854666154100 Content-Type: text/plain; charset="utf-8" EHCI supports 64-bit addressing when the 64-bit Addressing Capability bit in HCCPARAMS is set. In that mode, the CTRLDSSEGMENT register provides the upper 32 bits that are concatenated with 32-bit link pointer values to form 64-bit control data structure addresses (EHCI 1.0, section 2.3.5 and Appendix B). qTD link pointers (current_qtd/next_qtd/altnext_qtd and qTD.next) are stored as 32-bit values in the data structures and must be expanded to full 64-bit descriptor addresses when 64-bit mode is enabled. Update the qTD traversal paths to use ehci_get_desc_addr() when following link pointers. Appendix B also defines high dword fields for qTD buffer pointers. Add bufptr_hi[5] to EHCIqtd and extend qTD fetch and QH overlay handling to load and propagate the high buffer pointer fields. When 64-bit capability is disabled, descriptor and buffer addresses remain 32-bit and existing behaviour is unchanged. Signed-off-by: Jamin Lin --- hw/usb/hcd-ehci.h | 1 + hw/usb/hcd-ehci.c | 19 ++++++++++++------- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h index 773f376834..712de9d50e 100644 --- a/hw/usb/hcd-ehci.h +++ b/hw/usb/hcd-ehci.h @@ -139,6 +139,7 @@ typedef struct EHCIqtd { uint32_t bufptr[5]; /* Standard buffer pointer */ #define QTD_BUFPTR_MASK 0xfffff000 #define QTD_BUFPTR_SH 12 + uint32_t bufptr_hi[5]; } EHCIqtd; =20 /* QH overlay: altnext_qtd, token, bufptr[5], bufptr_hi[5] */ diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index d1d68b0342..5d070e204f 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -473,7 +473,8 @@ static bool ehci_verify_qtd(EHCIPacket *p, EHCIqtd *qtd) (p->qtd.next !=3D qtd->next)) || (!NLPTR_TBIT(p->qtd.altnext) && (p->qtd.altnext !=3D qtd->altnext)= ) || p->qtd.token !=3D qtd->token || - p->qtd.bufptr[0] !=3D qtd->bufptr[0]) { + p->qtd.bufptr[0] !=3D qtd->bufptr[0] || + p->qtd.bufptr_hi[0] !=3D qtd->bufptr_hi[0]) { return false; } else { return true; @@ -1199,6 +1200,7 @@ static int ehci_qh_do_overlay(EHCIQueue *q) =20 for (i =3D 0; i < 5; i++) { q->qh.bufptr[i] =3D p->qtd.bufptr[i]; + q->qh.bufptr_hi[i] =3D p->qtd.bufptr_hi[i]; } =20 if (!(q->qh.epchar & QH_EPCHAR_DTC)) { @@ -1232,7 +1234,8 @@ static int ehci_init_transfer(EHCIPacket *p) return -1; } =20 - page =3D p->qtd.bufptr[cpage] & QTD_BUFPTR_MASK; + page =3D ehci_get_buf_addr(p->queue->ehci, p->qtd.bufptr_hi[cpage], + p->qtd.bufptr[cpage], QTD_BUFPTR_MASK); page +=3D offset; plen =3D bytes; if (plen > 4096 - offset) { @@ -1726,7 +1729,7 @@ static EHCIQueue *ehci_state_fetchqh(EHCIState *ehci,= int async) } else if ((q->qh.token & QTD_TOKEN_ACTIVE) && (NLPTR_TBIT(q->qh.current_qtd) =3D=3D 0) && (q->qh.current_qtd !=3D 0)) { - q->qtdaddr =3D q->qh.current_qtd; + q->qtdaddr =3D ehci_get_desc_addr(ehci, q->qh.current_qtd); ehci_set_state(ehci, async, EST_FETCHQTD); =20 } else { @@ -1798,14 +1801,14 @@ static int ehci_state_advqueue(EHCIQueue *q) */ if (((q->qh.token & QTD_TOKEN_TBYTES_MASK) !=3D 0) && (NLPTR_TBIT(q->qh.altnext_qtd) =3D=3D 0)) { - q->qtdaddr =3D q->qh.altnext_qtd; + q->qtdaddr =3D ehci_get_desc_addr(q->ehci, q->qh.altnext_qtd); ehci_set_state(q->ehci, q->async, EST_FETCHQTD); =20 /* * next qTD is valid */ } else if (NLPTR_TBIT(q->qh.next_qtd) =3D=3D 0) { - q->qtdaddr =3D q->qh.next_qtd; + q->qtdaddr =3D ehci_get_desc_addr(q->ehci, q->qh.next_qtd); ehci_set_state(q->ehci, q->async, EST_FETCHQTD); =20 /* @@ -1834,7 +1837,9 @@ static int ehci_state_fetchqtd(EHCIQueue *q) if (get_dwords(q->ehci, addr + 0, &qtd.next, 1) < 0 || get_dwords(q->ehci, addr + 4, &qtd.altnext, 1) < 0 || get_dwords(q->ehci, addr + 12, qtd.bufptr, - ARRAY_SIZE(qtd.bufptr)) < 0) { + ARRAY_SIZE(qtd.bufptr)) < 0 || + get_dwords(q->ehci, addr + 32, qtd.bufptr_hi, + ARRAY_SIZE(qtd.bufptr_hi)) < 0) { return 0; } ehci_trace_qtd(q, NLPTR_GET(q->qtdaddr), &qtd); @@ -1915,7 +1920,7 @@ static int ehci_fill_queue(EHCIPacket *p) if (NLPTR_TBIT(qtd.next) !=3D 0) { break; } - qtdaddr =3D qtd.next; + qtdaddr =3D ehci_get_desc_addr(q->ehci, qtd.next); /* * Detect circular td lists, Windows creates these, counting on the * active bit going low after execution to make the queue stop. --=20 2.43.0 From nobody Thu Apr 30 00:39:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1776153813; cv=pass; d=zohomail.com; s=zohoarc; b=X+iq7Hnn7igLIgrbT3Xgqmmr6OQ3f7FQn6INAgh8JbM6wARJEj6mMst+LopT4hmHKXlf0IWGjEEhJ8gICr9fviogzMSHVa4/R+VWgtthZC4/DFJNWZK4Amp5SoAscPYSE+rQXx4awSkU8RtquxuPvv0byCqIF5ZXgSZFQP7mwfM= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776153813; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=vuWKDDsk6LX2zEwkIhjM2Aljgzp3WQcUCNwUlAYTDws=; b=PoOzKLZWwLSXmqPnruUKWyfZnS3QRcaWiHCIdb60PbvygaMoUbCvtThPy4nj7F6WO9G5Zzlx1wQm9ZgKl17p6aPbMhR67DHSRfl6hz2mR5nyfT9bis2J3Iih4wbX3rwF70QR0eTG5lI9LOWIPfm8qM6QCIxfLKR/0LPO+K0TXJw= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776153813685473.0453982156379; Tue, 14 Apr 2026 01:03:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wCYhb-0003cS-SR; Tue, 14 Apr 2026 04:00:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYhZ-0003a8-1E; Tue, 14 Apr 2026 04:00:53 -0400 Received: from mail-japaneastazlp170120005.outbound.protection.outlook.com ([2a01:111:f403:c405::5] helo=TYPPR03CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYhX-0005tv-26; Tue, 14 Apr 2026 04:00:52 -0400 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19) by SI4PR06MB8423.apcprd06.prod.outlook.com (2603:1096:4:299::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Tue, 14 Apr 2026 08:00:39 +0000 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9769.046; Tue, 14 Apr 2026 08:00:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xbF2RLU3bZ3qT6yvB2fAddgNnbeUyq0kxSfKjY0Okx27dYDL5ZTQFdqpBBJYBZ0aFeRrFCEHsNX/4tkcmaBW9ZpoEa+i5ouGgwSD6m7yHAhaweG/KNmorSck1FKon6B2e+0zm7C7cfacJ/5yZDPUGb0BS8cR0Ez5bmQpmnd3/qQvxk7wzNRe+T74YfKbakLcW+9FntX/JuDOmKEsj970D0/i+VQxA9J73WGDK9+/kyWBkrjVJia/cLt/EXchg3Q1Ito8n4JxXDF5wviBrDoWV7oK8tHBdaj4mOPesPnCWdG3CGIUKCCC8diuHov/r3//JmS4S1U9VmYLlM94dR97AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vuWKDDsk6LX2zEwkIhjM2Aljgzp3WQcUCNwUlAYTDws=; b=NciMAIUM0P5wOE7ZkPzEStH70ZUSgHG548tvXJCFemSK3kCk4m4LLerKJlWD4lDeYsn7oPWFGXKccf0/yuB/0v2quG+oyhR4O0axRHEW4AQwX/KGeUrw43EGXM5R1YRTtZ6OsyWI9higoUjgYi7Q+ox9++o9OiDJqdM5yk5lOTIO3Yz+NwA1YfAzcKWdMNSN7ai40QdtozJICcbl9E/D0NNo/+FDiBHHhv4sdgRmRjD24edtIq6y/GLfiu9JdUszo6l2rhIEajYsgaG5OcbCLSq0CcFS2LRl9t0HErRixBWtqccDnjFErcgpLxCo8J5e35soIBx3Alu7ZVJftBAXiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vuWKDDsk6LX2zEwkIhjM2Aljgzp3WQcUCNwUlAYTDws=; b=ktvScOWaKO0tgL0nwjp7p367v+VRg9T1xgvn8ohA2F6oyFciO+GMZq3ASoGw5T+05Cqp6r1SrYeY8PDZecmTL3lbA/DCpRvT1cdDVe23Tx27ofNkXt6wSzSF8BMqxzaw004bRIRlb/+ChPUfbIAeLeHl+cdMH2aFoX7KOFKKJhO0vSpavVi6s7ZRvzgfVOWZtHPmI1Q1dPyov6FqbxfM4mbz2VisjxCEm62vtxrn1G6Mj5PKcXDsRYsbSYXP6QfEjZwSq0ACQkefhJJv5yFHEDG3enOBRR4uztCbmE+AorvRr0wXyTXtoBH6raf3X7OlFQT5zv+IAe/Wsa/MMx1icA== From: Jamin Lin To: =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , "flwu@google.com" , "nabihestefan@google.com" Subject: [PATCH v2 11/17] hw/usb/hcd-ehci: Implement 64-bit iTD descriptor addressing Thread-Topic: [PATCH v2 11/17] hw/usb/hcd-ehci: Implement 64-bit iTD descriptor addressing Thread-Index: AQHcy+TIqGBEg6o9N0ylzvr2+zYkwg== Date: Tue, 14 Apr 2026 08:00:39 +0000 Message-ID: <20260414080025.3005916-12-jamin_lin@aspeedtech.com> References: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYPPR06MB8206:EE_|SI4PR06MB8423:EE_ x-ms-office365-filtering-correlation-id: b58410ad-8e2e-4287-1483-08de99fbeb11 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|376014|38070700021|56012099003|18002099003|22082099003; x-microsoft-antispam-message-info: xjVkEeHbOkqw7UlVEJA/9Kektn0s8S4Kw1QAuzOXxMbMNa28KrNxAmlSA5D6biMlO8FqrVKKPO93vprfWFeeKDqvQcQ00qekMDjpM77D7klHIZgpBa2KQR5vOg50HooWPdI5g0iUN5KNNKQOa1BBX+Z5nhPqqzXN+GQIs2VdO2jlU1r/QKqrdw3OOwZii965IZunLzFHBmO/wOuG4ysA+2FbJSh6syvcsOYsxgs5oQT6DHBCB7iPDO0zrXlzmXoWfJ+Q/5EgT+2pAq2bR8940aAKMSjDUZ4KGUZAaNSuxLU8GbdfOyN5M4VP8e0zyATqclrZtESCkbCSt0GNIDmlZadNquI8QU8fRoON1sHUP/LR/gqLIh27do8GaVRXKGXksjS+ciUedivsoMuqX7NLWVx+n5VrErumhp846kdZEyGSGY5hoR9v+qN3YLlxdiXlr7Ei6cpnl3t2/yWu5RpDci+IyEPuAS0v1/LeNL04sg297G0bssMnC7tGKJq304AkbOEDiLavtoIQ1NWQfKqa2mHCBAhfXKtP/vcHXRt7+P6mTqk2lZDrKBs+mTulkNeT06aVjjy3vgK8cPOu8bsD/fX7pcD/0ZnyrrSqSvyz/o4a2l96BNEJJmYxoDdzzt4O7QQjS1UG1Xdd7Yd+pIuYIm3VUPTzCDyEQ2Wn5fuQKz6WtGrgak5ffZBiMrv5eh2AYL9l3ya2bvqYhws71JiDTB9yXd9xuOswdwRK3tcCUIUZuuPExvWq21ZBrhCXbfX5fk4iDmiWCt2qpWqSKO5eGEL+d2tx+dKPKuraOS8jfsQ= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(38070700021)(56012099003)(18002099003)(22082099003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?FmZhJXfe3jrBs6nTPiLdhBrRmPtqJfPYh+wwUI5imiQ/5OVOBRPIxuhrRZ?= =?iso-8859-1?Q?UiJJwje7QdmieNjpighT4wy8ftR3FBVa7vK2BQOcylv3sghgceeIGaPkNH?= =?iso-8859-1?Q?2e0Z5P9mliSKVNTMDrFjq5t649IB7jA0SKNfpFp1jQAT7v2u9kTIZyjQG7?= =?iso-8859-1?Q?1weZES6cM194ClX22NFklnUvC+jJtc6m/NnMTRoQUTmOohRsbHAxVAtDds?= =?iso-8859-1?Q?gTKeWZL2ZS9wCgfROQzCwOLDy7yIhs0GPuoFG2iMDV5HPC0Ee9wMhAJTzC?= =?iso-8859-1?Q?r/h935aj11N2a8QSZqpU6+pt0NtObLCQWm0Y7gSJHWO690BcyALNDicPYZ?= =?iso-8859-1?Q?xiegwLldTaeNfIaoPlazAEzmWrtD1NOmviD1HeQV4Di65J9wVP/U5flmKS?= =?iso-8859-1?Q?FUP4suMkAsubeRK6v7sbpKR3VjLNH5YOD7mOXfIBgvz2+yY8CtMqDPi537?= =?iso-8859-1?Q?lVhQKvcC0rjFDzycZhcRT1kCFrxfuHDTFrkPu5I04xdIQGIsT1ReS32FSC?= =?iso-8859-1?Q?HGDTo8nUCmKlO4EiQV7j2rliE25TL0RcyGXi4WEEMiuGrW0yOREKx4HHA8?= =?iso-8859-1?Q?QjxRGr68xS8PvfsBLJy5aMx2RLzUDaEQe7MaZfnSX3LAePHrWxFpJoG256?= =?iso-8859-1?Q?D33TWhRqDeekP2ZF72lbXU3lc1sZlTKkHbkU00RDED7DW77N2vV+X25aap?= =?iso-8859-1?Q?H3x9A8JxeYucd8APPc8y2VZWzJgCZrQaqL1whlDZ7vL9reknyKvEUPfmGS?= =?iso-8859-1?Q?AUo2Wx1JiHaehtNoHIOS1/dso/IQRmbJqfU6CER+JbINewuNJcLW1DAydX?= =?iso-8859-1?Q?EBBt/PQKo+oDwC6+03HVSHF3pLlVl+VlwzZiVvjc5ImTJoXMI268z/xXCw?= =?iso-8859-1?Q?2mLuI32P3GielwWiwbVzLQGFoA3BTPs9RWov5vp/CCpBfPaIJp7nAHiRyb?= =?iso-8859-1?Q?IF5UV3jwAdBuDkJ09AH1i2+0u2ZIuE5sNsKnmcDGyNKp0+P6fXSdXc3GNo?= =?iso-8859-1?Q?7YartmqRU7+yLRaknCFiTkiRp6Yj5ublmQcu9VF5ocvuvsO8bs65E9CyuR?= =?iso-8859-1?Q?bUCqjGHFTztngLMuGynS1T648jyrQPEhgsjRwP53K2iSTcyLnz9y9TLni3?= =?iso-8859-1?Q?xnCmJxFvfyacShEzTKNSo7541BGB6eyV0ewuaO3J6n5Bd0n69RRv4aAj2i?= =?iso-8859-1?Q?pvJdjjCltys1TDB6RU4CVNKk2wQkJQzln9AzgWdtraGJweldJ+T95zEgV3?= =?iso-8859-1?Q?ZUOcha4ciwJw3Op39bofBAdEzwzcgyGFnTObZYMiVn9bbskk9rdnbI4tAD?= =?iso-8859-1?Q?kRfdLClPzXPbzkITwySOXJiqekmBXOPQ4Z9drN0p/o21H3yASmwqrdmb0c?= =?iso-8859-1?Q?+PGSXuUA0zydF6tb7GFw1EiFzaJeuIn2G+WQ0LRQeNH+7Dx2Aipyxwg7yT?= =?iso-8859-1?Q?Zgzf4CanLspf8VQHoL7LURdL0Gac2FB1hxP5pUEdK6paSalAt7m/cVFEZU?= =?iso-8859-1?Q?33Bzai9N5+cX8yTTDkJUs3m4kM+QMGLIZd9Czuco4CqyetqoU1fsOn+nwZ?= =?iso-8859-1?Q?KAl7Ock+RlGG4i8BA6pghfOQmAd/Iu4Q+mfnsCyChbX8O4TaZGatmtzu9o?= =?iso-8859-1?Q?wFv7Qt+JeQIsqSfhOhWHlc2Q6dI3hq/COL3KbNzR+70/Cv/+Dh6wd4HHNF?= =?iso-8859-1?Q?/t0eqboWNmtbciGQnf6dZk3rx3VEHrztcfXoFOjaSUKTk1ry/7z8VEo8Vq?= =?iso-8859-1?Q?bhlVNzW7MjL+cSShgScuhchg6Pk5VL6ai6vkFbulA9+r2DBFQQQesFFz2v?= =?iso-8859-1?Q?1iO+zlyP9A=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: nG97YbWyHEXIKPZE2cmm3bQQ8/WzVZlqWvufYIahAafRD4b1FU1Cl8VTDURd8eYc8Jsui1UmEJGcEB5QoDWCph/HrIfE39fbshEqsTxAUrg/S7SWm+bNQ7gnfggffixmJm1UT/GQt+lY4z85dt/2N5iwa2Qel4LOv17RF5zs8zSr6yP46RE3+uZFl7Dgcevy9W0+VUu0EnhnxvoIr+fxI5ReNuVQShAloU1G2lcycm3+F5ayRcS73o4N/HChumYv+r01hX420OM0d7NXUhWRgqJejNiBgLlY7RxoG7Ix5Pg7R+WdHe5Df5s8AacBKo4aS5CeDMBGE48q7VQJLXZmow== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYPPR06MB8206.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b58410ad-8e2e-4287-1483-08de99fbeb11 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2026 08:00:39.2124 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DLRAwxUlgi1mHmvhaeeO2gh1tsp8au1lapBZjHZu8t0sldd8iorz3GHklqNraJhQgWcaTxwON8oTbeYLALrVc/a8X5faCy3mQTkEhenNacI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI4PR06MB8423 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c405::5; envelope-from=jamin_lin@aspeedtech.com; helo=TYPPR03CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1776153814566158500 Content-Type: text/plain; charset="utf-8" EHCI supports 64-bit control data structure addressing when the 64-bit Addressing Capability bit in HCCPARAMS is set. In that mode, the CTRLDSSEGMENT register provides the upper 32 bits that are concatenated with 32-bit link pointer values to form full 64-bit descriptor addresses (EHCI 1.0, section 2.3.5 and Appendix B). iTD link pointers are stored as 32-bit values and must be expanded to full 64-bit descriptor addresses when 64-bit mode is enabled. Update the iTD traversal path to use ehci_get_desc_addr() when following link pointers. Appendix B also defines high dword fields for iTD buffer pointers. Add bufptr_hi[7] to EHCIitd and use ehci_get_buf_addr() to construct full 64-bit buffer addresses from bufptr[] and bufptr_hi[] fields when processing isochronous transfers. This allows buffers above 4GB to be handled correctly. When 64-bit capability is disabled, descriptor and buffer addresses remain 32-bit and existing behaviour is unchanged. Signed-off-by: Jamin Lin --- hw/usb/hcd-ehci.h | 1 + hw/usb/hcd-ehci.c | 9 ++++++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h index 712de9d50e..af8c080c60 100644 --- a/hw/usb/hcd-ehci.h +++ b/hw/usb/hcd-ehci.h @@ -63,6 +63,7 @@ typedef struct EHCIitd { #define ITD_BUFPTR_MAXPKT_SH 0 #define ITD_BUFPTR_MULT_MASK 0x00000003 #define ITD_BUFPTR_MULT_SH 0 + uint32_t bufptr_hi[7]; } EHCIitd; =20 /* diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 5d070e204f..5d61b1dd64 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -1463,7 +1463,8 @@ static int ehci_process_itd(EHCIState *ehci, return -1; } =20 - ptr1 =3D (itd->bufptr[pg] & ITD_BUFPTR_MASK); + ptr1 =3D ehci_get_buf_addr(ehci, itd->bufptr_hi[pg], + itd->bufptr[pg], ITD_BUFPTR_MASK); qemu_sglist_init(&ehci->isgl, ehci->device, 2, ehci->as); if (off + len > 4096) { /* transfer crosses page border */ @@ -1471,7 +1472,9 @@ static int ehci_process_itd(EHCIState *ehci, qemu_sglist_destroy(&ehci->isgl); return -1; /* avoid page pg + 1 */ } - ptr2 =3D (itd->bufptr[pg + 1] & ITD_BUFPTR_MASK); + ptr2 =3D ehci_get_buf_addr(ehci, itd->bufptr_hi[pg + 1], + itd->bufptr[pg + 1], + ITD_BUFPTR_MASK); uint32_t len2 =3D off + len - 4096; uint32_t len1 =3D len - len2; qemu_sglist_add(&ehci->isgl, ptr1 + off, len1); @@ -1761,7 +1764,7 @@ static int ehci_state_fetchitd(EHCIState *ehci, int a= sync) =20 put_dwords(ehci, NLPTR_GET(entry), (uint32_t *) &itd, sizeof(EHCIitd) >> 2); - ehci_set_fetch_addr(ehci, async, itd.next); + ehci_set_fetch_addr(ehci, async, ehci_get_desc_addr(ehci, itd.next)); ehci_set_state(ehci, async, EST_FETCHENTRY); =20 return 1; --=20 2.43.0 From nobody Thu Apr 30 00:39:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1776153850; cv=pass; d=zohomail.com; s=zohoarc; b=C5bWwA96fYplUYmYV+nrS48wvLpljY8aTOb34NHcEmi7Yp8/4kf0jQGnacP9kiDeFTmnylpUoQ15vrUu/omXKvQ34JdQyNjlMOhvMvf+NCvs1qoBrTH41XtkHdb246j0LU9mLw8zzhUWweTwGmWgaXDLeeEgSDb9G0fpG5Qm9iE= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776153850; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=UZ5sfLjP2piHvgiFCrLkCqBrAP00iRQDxrNXwZJtM9U=; b=maJTMMEuiX+DZ1nPeup2L6R1b0W/U51IaMJihDKyp6Tj3S38ir1OEbiyU+3xW3imiLnIClmNiVJ/chuw/RvnrbNCAGBAJKpWRS8rhehfRGEDuFKQYEjFTj28s9OrVTfcATtlwFc+uYBBqGC65Iw45ydqhdFYgNoANo9o6aCIXl8= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776153850624925.4383453151672; Tue, 14 Apr 2026 01:04:10 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wCYhf-0003ez-4C; Tue, 14 Apr 2026 04:00:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYha-0003bR-Vp; Tue, 14 Apr 2026 04:00:55 -0400 Received: from mail-japaneastazlp170120005.outbound.protection.outlook.com ([2a01:111:f403:c405::5] helo=TYPPR03CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYhZ-00060M-F2; Tue, 14 Apr 2026 04:00:54 -0400 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19) by SI4PR06MB8423.apcprd06.prod.outlook.com (2603:1096:4:299::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Tue, 14 Apr 2026 08:00:40 +0000 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9769.046; Tue, 14 Apr 2026 08:00:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jlWTj01EEVIgyBsSJcEgC4JYupCoXR93hdV/kHg/OOmE0UYiDsYLmGdLnKPpm3I453F+F7v1rlQTqIF5TTxh37EDGBBy4pMDaU4vBWiodVhEK5txLg+2b1xY1T3aB0yzw+I1wNpBLbMoEZXdBulh4MmVyug3VR/6RCmZKnvVjKNPLP+xLUNUU14m7srWnMRyw2YM7STEyBhkYk3E6yx1VzGea7GSwIIGz3m6qUKrd+4O2i6nR6yc4j8IbjQ99lb9LnvjF6klHNDX9yr1QHeMynfPzV9IXyOPrB7ZdQvNwctERnkpm4ST8yifvD+oZIvHA/3HUx1Bf3zG6HBMiWQIUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UZ5sfLjP2piHvgiFCrLkCqBrAP00iRQDxrNXwZJtM9U=; b=YM4xd/KhEhKm3GntzsxK6AXCBC+BEhXdEr9QAE+UnHd8cq2+Fe89n4uDdrawhPNbzfWhnpDVTs0oMTe0suowQ3rsLgQH97LyHGlTXmylQy+bAhhfIfWGYB10S6+GIOj+BgbNHguHJKiLYq+NUQ9P1Q76QNMull27Q47XqLCIWNmTcgqfzBzbOblXZzqnxlyg3TvYqEOC9sXUo++qnL/rUv6wIeWph40eisczccFVvJYcRWbMGjYS8iov+bd2iX7hP1IkyPmCtgbYBF767dTEQC8Bk4jnIyd1QtEwTkTnNR1x+X3u91oIn7rT5w+1ZLwzFbSSpp7NWcR79NnUePR/KQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UZ5sfLjP2piHvgiFCrLkCqBrAP00iRQDxrNXwZJtM9U=; b=W3VOfTPEa7KoCPdbSwdE+2qaIM75ulsYkCWz4jw70l0iHTB+Aocb3CHvtKHCd9mmon8tXFL2EmK6f+IGGNCwdYfnsGH2O/pgb303o12j/QRmN9VFcs7Z20kEcmyG8INVs5hoR5mwp0eJBLv9i3s2eiNlsU72qRdVc/Jip+fkAkHD7oltWtAEGxckwAHYfy/6gCN7I04DtXt3CLgNEwj1eeQQ25+YlsR2YUZlRXprpT6NB0YD1CHPd7V7Rc4MEwN/pONs7KScieT1yBV4owzatD0qOZVhv7s2tOmZe1+RzyosEFY0UNWptt/lsj8gSoLWAqtJpgQwIlmylVbAvRBX4Q== From: Jamin Lin To: =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , "flwu@google.com" , "nabihestefan@google.com" Subject: [PATCH v2 12/17] hw/usb/hcd-ehci: Implement 64-bit siTD descriptor addressing Thread-Topic: [PATCH v2 12/17] hw/usb/hcd-ehci: Implement 64-bit siTD descriptor addressing Thread-Index: AQHcy+TJsvA3WkppfUCywuNmErKtaA== Date: Tue, 14 Apr 2026 08:00:40 +0000 Message-ID: <20260414080025.3005916-13-jamin_lin@aspeedtech.com> References: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYPPR06MB8206:EE_|SI4PR06MB8423:EE_ x-ms-office365-filtering-correlation-id: e5db6c5c-84c9-4bfb-057c-08de99fbebc8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|376014|38070700021|56012099003|18002099003|22082099003; x-microsoft-antispam-message-info: D0kQkdLVLg9vU3+AFkw4EKKQorJ+JOMVMoGcfMNmloEf5Z8zJ7BbUGv3ulRFdfEnNmGsMYECbF4i6JY+0FQeL+YennMrpNPqdJ7Wh5VEHx7QYS6aGfwFsZB01d+DrjJ24nHqFgbMGrDB9/XswNHNoAYMI1jGZtNmizz2Zc+JYEb9F0Y/yfe4S0VgoL1hkNVYWTJ0HrCjOQH73eamaEqa3Kr7mqvszn3Lf6Do3vpVkYaQAOHrT8qj6yaLWn3idb0/eHRPk3PZlzKJMCMEGZ3+otkd6WT4hiVKr91GkEMLWfaU9sJZogn1SojOB3vPxsPfVLJBPWE3UroakYvr/0TuF5hmiQqbvnpomt/flM7RBArRDQv0x/wTx/nQwlgPs5x6yEbEEaOycxORDnO6PsIhRux3u48mGjC779RuvvyBKA8/mfHn7inNfrdSwG4Czn9p0tTiA8nX2T6C3HhIUidlx2v1s3MdwIlVLiseiU56sMSCGsB5VY7pdO9iHzyFRpjV9x4A7mviGduSKH7wR+gYb8gGy/ysYGj29/6FomfgnWIltwIP4ERg2FAe8ylA5COgEbHagUd7zJpMJQu23t35S1Lu+kjDf5I0/hybgFLcMC8WVasKCq0T/DeCpN0SAeosfciLRvbqa11c24SnVRVVTp9ZU4BTX7ZfNPu2GAqSwe+xE19l/aWfcHc8IwTfEES3z+jLjCmmgu7l+Xo9d11WtiEeTzg4dj+YXHD7GDw5ZafUQBUww2E/mEP9zjIbI2d0JLbzex0voTz6M+F+Lv+VdjaudkL2fbrljKMjo5AT4RA= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(38070700021)(56012099003)(18002099003)(22082099003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?/1eKU/ralP1U67o35w6fiIQAISBXqqmVF8CU1MxnhUnOGVcb7kN/GimMQv?= =?iso-8859-1?Q?BAPkALEIzKNcdwPLDD7O3g5Gqh66LvvOzpKhjhvmmzUj77UfUys/8QvFnz?= =?iso-8859-1?Q?ajGYpvWpwsseNU53u/WjOd9Xkkm5FccKFzzsFBc3rcBzDFGJH8AIWRKbbt?= =?iso-8859-1?Q?xP0QBajzODjn+th0hxLXXZoN0IcZ2wVPY2U/VRKaa9sUuxWpIPZUbzqZET?= =?iso-8859-1?Q?xhA7WsEyf2e7Eqwe9VIwczoGGSHfCjslDTHsKdnD6ZMjsme5ETmDOJRyJu?= =?iso-8859-1?Q?1I34DEGyXyDsvpUh6Vz4zKvCYpo+LdT6girQioqxhb/pplR7OL2iufGhCJ?= =?iso-8859-1?Q?0gNCNchL6AT1/o2+LTOffLzCRyhShlMLL248Q7c0B0fXsEWjKiTFb0FK/K?= =?iso-8859-1?Q?qlo7Udvsi98gdfRTbu6hPvbEEGOVtF/yqqRldoPZ7PpQDQZgh0qDnSD7su?= =?iso-8859-1?Q?7cW/NEIFQlFyRvMmQ/e+28FoZuaF5wzyAunT/PG7EYLba8SrdCYQ5UV6Y3?= =?iso-8859-1?Q?OXT4toVRAOrTAnh84f5lviYFrmUPJ1rwzE1S47+nnI74GOeakMwDgR9PyG?= =?iso-8859-1?Q?lEDnT2/U4B98I8Qdhzl7jEDA5EuhlPrXN1vK+8d9GP8JuXahCmHwqCdT5o?= =?iso-8859-1?Q?lR7tvmzKu4zqv2yltOWmRepBH6qznSbZpILOoAHOKReOpaQ4lQqmCVl4iy?= =?iso-8859-1?Q?Itj4rtGQu23VypN1Pg0HBK0mLv/furfyQqRSEf3lK6Rzd+q/IhAHWu6231?= =?iso-8859-1?Q?kkx5SBsmLIIDfM4PGkyi6sGASuTJU9/PIWYtBfFZnzzd+Y3ft7UwXFx5SW?= =?iso-8859-1?Q?rV/fjY7m52C6RpzbZIo2ZZ8ylzIp7yV63SbDDr94stppmRza1in2figHem?= =?iso-8859-1?Q?NodGeKfzluNLnsXfrVPXlcZSxDJRoQSPrOKsOqOh5Qbp6YOZiQMM2AyFOh?= =?iso-8859-1?Q?MKtThkQE8JeewyW6pOws4g/Nibzjtso3iD0EHRLt1VXsHxwJ+ls1dRI2Dg?= =?iso-8859-1?Q?bcS6avhNB2JQm2ZBmXaCyacYvvlozrPme8yP10hwtRDoP/dscumfh/tdHi?= =?iso-8859-1?Q?QVCsbS7OGwEJnmlWwneYh90TG+3E93vUItO73YeeFGKLsjhmDCHF4JSCam?= =?iso-8859-1?Q?aQ2cW2mwcXQ+GOMYL1mu2cDnsdBe/r6sp8XqI2zCWRWCE/BC1iHIPZYUHF?= =?iso-8859-1?Q?iH38gJQPcYaNq8ZVEoN/jD5vf2P5BZUCHvWSUCFgmJA2TCkaIqJJkutC5y?= =?iso-8859-1?Q?T5lnXiXaVxBWVbAk5AWA3HMDSmdNJ4G8f1IWaOjQH9SvM2Kgs0v5wqIir1?= =?iso-8859-1?Q?Oxv3y3RDaiPBEQ0tJbCBmRkZwZNVARLhGXsH1XEx/xyxDo3QN1X9jD3YYf?= =?iso-8859-1?Q?uGdxGSjVE3TnTTonLpfOeo6qP2vi1pTK/3bpxU6n2eZkH2UzFQU96whdzf?= =?iso-8859-1?Q?t9ABjjOw/ONb5TdkFsg53HlCRsMJUEIDAVVzrWjnCKwbJDXgUj2tmiHIEN?= =?iso-8859-1?Q?oWCZzFZbKhQCHbkysfgDk/uxz9Agcz/mJvDL8rmPBzg7VSR2Zh7YOyJ6ju?= =?iso-8859-1?Q?QlUvEd5miUKXq4OCjrWuJHsxyXhEqucqOM2yO3HwQstDDz6yh0Yz9Gr0sQ?= =?iso-8859-1?Q?Q/4JbFnfTBjEKm6F2uiPwBz9QFOVm7zlIg2pPJFOLgAdOPzh8wI6ozAycG?= =?iso-8859-1?Q?5vmYFWkvlPfHKNLBZLm2JYGWxe6sDBanpzkueGYQsv028oeF7vbYpOJKKf?= =?iso-8859-1?Q?5KxSi8OGNn6BJthaMp/8IkaZeNqeDweTnWwEym/DAz+si7ADRY8q5Ve7VG?= =?iso-8859-1?Q?ucqz41p4Lw=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: AjNyjvSgoAmG12jzZfngi4teh5bkoaVdRWjNfexnw404ShrOCTm+tt89J71I4V1hN9PvG5GSUyRjadEdEX2EIzRntmPHRFN120wCcztjx82Y0RLtgfbaDiwpzqf5vr/CVtJzgb66Lz+DJC02JQBbjuKJ96ynjg+DeJGFNU967lQa0Oo3UGryGivUQrJnkT9op/NxMIo/lMARI9s2D/t9RRmNAHVfx3Nduxr5t+JvzZX7SK/jC+jNy44YEEDMrKVH3c1TzybyM317XV2MVQagwgb6nqQ6H2Uw63W/36XTAmj+BSC9sot3czot1APLzPoQY0Yt+Ss4r8ttkGuhDQNdog== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYPPR06MB8206.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e5db6c5c-84c9-4bfb-057c-08de99fbebc8 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2026 08:00:40.4635 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gb3kjt7FTwxCVg7dsAc54wIdGQn/bgHnQwHGGIMxrhtfGdUD9YC+I4C5MAplBSx26BZ+JqULZxmUsKpPbsZGqEw7iMRlS+jK4/td0+GV0lc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI4PR06MB8423 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c405::5; envelope-from=jamin_lin@aspeedtech.com; helo=TYPPR03CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1776153852588154100 Content-Type: text/plain; charset="utf-8" EHCI supports 64-bit control data structure addressing when the 64-bit Addressing Capability bit in HCCPARAMS is set. In that mode, the CTRLDSSEGMENT register provides the upper 32 bits that are concatenated with 32-bit link pointer values to form full 64-bit descriptor addresses (EHCI 1.0, section 2.3.5 and Appendix B). siTD link pointers are stored as 32-bit values and must be expanded to full 64-bit descriptor addresses when 64-bit mode is enabled. Update the siTD traversal path to use ehci_get_desc_addr() when following link pointers. Appendix B also defines high dword fields for siTD buffer pointers. Add bufptr_hi[] fields to EHCIsitd and use ehci_get_buf_addr() to construct full 64-bit buffer addresses from bufptr[] and bufptr_hi[] when processing split isochronous transfers. This allows buffers above 4GB to be handled correctly. When 64-bit capability is disabled, descriptor and buffer addresses remain 32-bit and existing behaviour is unchanged. Signed-off-by: Jamin Lin --- hw/usb/hcd-ehci.h | 1 + hw/usb/hcd-ehci.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h index af8c080c60..6406f536e8 100644 --- a/hw/usb/hcd-ehci.h +++ b/hw/usb/hcd-ehci.h @@ -109,6 +109,7 @@ typedef struct EHCIsitd { #define SITD_BUFPTR_TCNT_MASK 0x00000007 =20 uint32_t backptr; /* Standard next link pointer */ + uint32_t bufptr_hi[2]; } EHCIsitd; =20 /* diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 5d61b1dd64..24133af9db 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -1791,7 +1791,7 @@ static int ehci_state_fetchsitd(EHCIState *ehci, int = async) warn_report("Skipping active siTD"); } =20 - ehci_set_fetch_addr(ehci, async, sitd.next); + ehci_set_fetch_addr(ehci, async, ehci_get_desc_addr(ehci, sitd.next)); ehci_set_state(ehci, async, EST_FETCHENTRY); return 1; } --=20 2.43.0 From nobody Thu Apr 30 00:39:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1776153813; cv=pass; d=zohomail.com; s=zohoarc; b=MSrvwfhXcieW4vtEqBChQeL7yAQjsFHAZ9UKKFNPRNBdYT8u6f7Vf79q7QmvkY+AafL/tETrHEM+qdISs+izLPqeFgCChXrRRyVVbN3BP9Qe0H0l7vO/wZnNAuMAU/c9VJVaXukgF2SSV9FUXNECiBkOEFnAfTCgwzCjsdp4qJ8= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776153813; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=S0k5yIYwJDLo1KAYtNzWFMwPPZnZg44krZ1IPrhD7sc=; b=iZIKgACC1UMZDjpnaWZJC/31xUAmmr0WBiDCdp+79RhSMzovYHMtG3v0DqwemlxcEvNMgbNYjT4sRKn16YxO3lc58kSwwEUwiKrcZJK0tsKjFz7PCglHwkJBsFSfOgf5SrylyNS+6YSpEsjoNz3jcNa2mNMIsERSlTic9sbC2qk= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776153813495320.53074715759783; Tue, 14 Apr 2026 01:03:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wCYhf-0003fj-Vo; Tue, 14 Apr 2026 04:01:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYhc-0003dD-DY; Tue, 14 Apr 2026 04:00:56 -0400 Received: from mail-japaneastazlp170120005.outbound.protection.outlook.com ([2a01:111:f403:c405::5] helo=TYPPR03CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYhZ-0005tv-Vr; Tue, 14 Apr 2026 04:00:56 -0400 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19) by SI4PR06MB8423.apcprd06.prod.outlook.com (2603:1096:4:299::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Tue, 14 Apr 2026 08:00:41 +0000 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9769.046; Tue, 14 Apr 2026 08:00:41 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=I3lKianQA792ONx/EmgMUItFss+bbq2H+TlbwemqLmOs3AHrcApyE7SEmigOBp6vFX0x7UEQgQMb0WO81mKfdtu9Lbmd2DKDYZkGxJMV/Cy/3wng1TSBf+maZlw7k0OCFWI7jqxfaHWwmsZAE8Z/hzGFDU/opfQP7Pt3vkBVJYq6p26belR1HwWr8TjLl6cpQzaDdpcyOq5AG0///YB/yS9V3/+mQ91/yhkaCceNImRiOyFyZ3Kb9hkHmLImhz8xIQYhlfZR9lYyDvHnMUnqC8UYD7vzVjWR6McOmRhX3qnDbE1J/EoMOcsA/ZuPlurOxL1uQAR+3GNtzpqJteHXLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S0k5yIYwJDLo1KAYtNzWFMwPPZnZg44krZ1IPrhD7sc=; b=QcCiIEIhfGX77JGoGa7CaifSEhzWFi+4LCEuE9jWZBtiCil2BpIGQU/HvmeM2RmOOMy+8NTw0gXF+GSPeLk96jvTI0iIpJjRE/O2Ka/8KSNExGt7QNC0VUB4f5CjHXlXqZzFUHX9/adJeo5Ca25JeIxTrTqKlZpT6oADVfUQ2tkYISPFGiZ0jfpfRfYm12YYlsTHpyn43cmpMCzhDAhk4O5mJBDBoxekRONy5pHWh6wYWQxXophPV4m37WfhsFKQHR3p+OctxUa0bVJC8gawjmjrPeYVvWfcdw1HQGTFsCyLBllKQ6eXVgsu68l9iuEZvI3tgSyERqjx7nccimqM1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S0k5yIYwJDLo1KAYtNzWFMwPPZnZg44krZ1IPrhD7sc=; b=Njp9veo0IZQR7Kg3W3pwgXT2UdIXc1PImrPY6PfLxZ3Clp3Smj+5XsgMdqLzzEhfNYAlU6GEag6LC3pkuWwJVHFPjaS61UW5XeYm6kpD/sJA40q04TjFn86wLdkabwHWlCNO7rOLcyrBEx5IhWhObhQO31YCNMTHHT3MYlPE23ZdMSgJMcLhrpcPtQzXMY1BwQClfpw6VY1o7rtq0+AzSRSl5rlSOlfUYInpD3W9hRJ3T8qQNqvmesEtKzjS6lXvRtfgVbpxV1H+Pf/9I0MRPRU0oiAVIVw5PdBttUped5p+yfbODAu6dKYx7Xv24ltugBHujJzrhqrR5yBOrXhNKw== From: Jamin Lin To: =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , "flwu@google.com" , "nabihestefan@google.com" Subject: [PATCH v2 13/17] hw/usb/hcd-ehci: Add descriptor address offset property Thread-Topic: [PATCH v2 13/17] hw/usb/hcd-ehci: Add descriptor address offset property Thread-Index: AQHcy+TJtjUIeRfiJESO6xYxyFKb6Q== Date: Tue, 14 Apr 2026 08:00:41 +0000 Message-ID: <20260414080025.3005916-14-jamin_lin@aspeedtech.com> References: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYPPR06MB8206:EE_|SI4PR06MB8423:EE_ x-ms-office365-filtering-correlation-id: 0ab9300f-6ec1-4401-e207-08de99fbec74 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|376014|38070700021|56012099003|18002099003|22082099003; x-microsoft-antispam-message-info: +T9sSVtAxbToV3fnRvolDbKJE3XOj8Q+TKW4Lpxeks3GLeHNAIFL2SKNiTc9mAQID1bRs9jO/gTSBqdx8Q2gAU/Ch4iiu4awKqq4Ph0BFfDjjZM/fA1RIna3X538dLU3YbDuLwgmft5gGqkkYZapxGDTQ91t3a/P4y2xExaof9CmqhOZRwHo944f4b+CIlGGgOPTdx+3/9J5G7o00OAuD5NWtfHgXtqkxsIiItAeGbmCjznWYEkUEVjqrxHZyP30Ss5XpgAqEvms8oYcJddh/t/4pUjRFtAucm9SoSQQWx1PJOsk+n3i2RTZo+7vHtyGYoBTl6L9ub0QbK1Pd8tl71+Xi1mrg3WGjUThYvRb9e4zNKAd6w6NmH+roExLY1F9Wa3Ma3YrUUN8/auK0SHh00HsM1q2VpWMwxKNf+1XKJbfSy9xpXy+KiJj+2k3Md2mXmstBgSXphzHejVUKvwP4GGbz2/CHLMbFTT2sDTQ/veCF5mGYUEyyrSZ6Swa+FFHzHO/TmwPOIzfjlG4i7PgsQARTCjdlvjvH+IFOsYh07BVUJH1yb5xXuMZ2/Jgm9iDIFt1GEjkbBKKADZiowBpIyfQc39UmxYcaaSRT9vkScuDG6AYEy68hVb7+FNoL8Vzqbe39gPwzWsacQ4C1M490JhQKCWaXEXOgYI1S5wjMUOrmTt0JiN4+gQXIgHsYpcOGi9t0hofeeOfRjYoWnldI3SZV+LQ0+4QLMqfpL1WgwN/2INEfjvAKpgrc1aOrgZ+qbVDU46GInT3/q5Png2Kp2iMhHMDquGobhs9emFPxHY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(38070700021)(56012099003)(18002099003)(22082099003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?oVDc1rMQuR9ndLAycj/irdwAyksAB9CUB9cN7EGDwQOcDUjoPRr4Jfwk+z?= =?iso-8859-1?Q?p4mYOEfLKat375G24IhDaAUn1xFlMWcSIynBsafQLHOKm0UjMm626fHHH3?= =?iso-8859-1?Q?In3+LJhiX/SNNVh2rYgbcZQtPcvJfXbApU3NGixJn+wQj7nBxudMZpuQOB?= =?iso-8859-1?Q?PM1om0jdpKhUgDBY0oPW3Qb0iDqRSakHXrMXysc4UhsCirhjQYHHq1D3y5?= =?iso-8859-1?Q?4EZ7GRksb86yhUBjIq4vaqSrelh2ieLnNhwOlZRBqZdlQwgbwfouSHFNzt?= =?iso-8859-1?Q?2ZKP6mJu2D+Kavmw2IJq8sBK6lBaYBoWpgGw7P0/K3iWpQvQhNaFX0zwxf?= =?iso-8859-1?Q?wJgUUUks64zAl6SzzyjKS9O05nPgt4FhnFrnCZKxAxuDaLCBLC+fZBPtEQ?= =?iso-8859-1?Q?DgDEeNJZzLtcf4HGSNvzTW46fSsmbqu4CyiSdzdKN+gqJ9gPrrETEEe16D?= =?iso-8859-1?Q?fUrf00obBr4Vc+XpzZiPVpMFjtuHOiHTGlEufsbmD6mru+/oEOvSwpcw8V?= =?iso-8859-1?Q?BaytNh9BKZ1UYJudkLw9l5MxdeT9g2EcYcfEI+vfg2ioYs5amkCwwReCk7?= =?iso-8859-1?Q?JDRIeV33dSjQ2JYbFB07DZEg0pghqnQyu2Bti4yX4JCX0MLzMRvIfiE1Uj?= =?iso-8859-1?Q?6y7bt2buK/JldvQYidoftrA66FRC2o8d+O98UXtT1H3FBFWecr7KauFlbj?= =?iso-8859-1?Q?hI8MOOQM67+eiyY0bzUxXyYozD69Xulv/fvzvUThAFllEStm2YqQjIekr1?= =?iso-8859-1?Q?iypJI0bIUKiDxZGF1jmjrVnTY1TTiUx+mSQdO1tf4l1c09nHgPTjCjencb?= =?iso-8859-1?Q?R5BxXxB3n40H5LsYs7/nQ9O6jmGdrl6qODNYA0gKU5r3cQNAVZbCsqsZes?= =?iso-8859-1?Q?2QtJr+EPYaNE20H997dOtUKqQo+2kjlXUmRCAGO5WKQtJiel8nDFYI90vZ?= =?iso-8859-1?Q?qmh5CTEqCFb7LXIzodUZnYgclfjWinQJ7i5+8MAnSgo/tqx01AL5tMZfKB?= =?iso-8859-1?Q?W9qFmIsE3OH2hbEHcjqj8cCEKWJo9PKY71VpA8U7mZd7P0hG2h475YYcoh?= =?iso-8859-1?Q?fe6uWGbEqXyRtvbnTyoeO0H/k1fMO6I2GmPhX9SUShU+wswkhdW9Nx22Uq?= =?iso-8859-1?Q?Sd4pls1Uy70A1vEDj5ZRX5OrfkkB57x9vLvgdFamGdqkGYGzFHOpnbAXis?= =?iso-8859-1?Q?jBiMnrn7yEtY9b0CRKolkqHC31TeOkONxzPqSUruBMZkITqQfR3mKGnydX?= =?iso-8859-1?Q?hj600pRY0RUa7JTUbhoJzIcvE0IhLfuxUJEPi8GtTPJ/lvlKgIWdC9xtQV?= =?iso-8859-1?Q?eLS5O0htEwhqNB2q+YOIbNgiyxFCyVq3JvYGI7j6d+tSyAwopbiTVuQ64t?= =?iso-8859-1?Q?M4mLOopB8x6/BTqU+dF2JJK2aabV+pFVFK66muafCafKwsTP8tcL91CHxI?= =?iso-8859-1?Q?SSHEbnY9OE3HBfxnW+HIL1G1Ho8Sis4t0QZhfJsZzuk1RFpPg10iEh9ktm?= =?iso-8859-1?Q?bOwOLJqNC4VeiZ21njLOiOf2jzpS0Z1IEcSnDq/gE3GRQu+gi/vRUlGeBY?= =?iso-8859-1?Q?gjqPx3BoeT5+tonxyjB5CWrw1h9g6SbnfGOifiFcW1vc8gYD5M0svwsTcG?= =?iso-8859-1?Q?ng8Byeh0+190XA+PRcjxhiKQVYE1KuQk373ywjsv/lSNs4ngyVA1iVf2qF?= =?iso-8859-1?Q?fhghxlF7ICNo904gpx0r41kpcAdnP0WiWmIA2QpS4B40Ud8AMmbn1JXQLH?= =?iso-8859-1?Q?rDYivZA1/8RJ+Js+t8fsm1zTXT/BZGAVeps64nuhGJ8k4vn+sGnzfOeIuh?= =?iso-8859-1?Q?HMT1pasz1Q=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: T4USLp/VZVc0qcfwvzbmMcIXvqrTquyTEIWCx9lSJ+hsS06si5gn6IS8OJOlVdOWmX/LW/8woVdeiyBgiwgFQeRRkpBtjuBnB/MzDBNK/VSlTIW8QfkI/xc/c9EqaGJaZYJiasuc6Fvq9VLd7JOwCOKRLA6AL9vOa4WhRNYDVcYv+rvQD1m7zCqreMO1NUwdalVMTaTARQkdnM3S+HlolCVgegeHnTHilV/O6g2VvL4YqTnLIHK7xxFLYbmgwMaNh6CYf8mwXEe64hU8kVMJ1BxR6ODx/zVYKjpN5b34Je8IQQ64vdl4KKoS4Pq737IZSPnM/+Tt2otn6qFprLBBoA== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYPPR06MB8206.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0ab9300f-6ec1-4401-e207-08de99fbec74 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2026 08:00:41.5893 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 49fKZQqsB9Yaq/nOkuyEOy61LXqH7LGt4UdlAlOApv6i7Ry4ZywHiMG4w5oY149sLC9if73TMzVCJ1rV2hPV+5jI2UJmnEZWtdmYbybriV0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI4PR06MB8423 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c405::5; envelope-from=jamin_lin@aspeedtech.com; helo=TYPPR03CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1776153816041154100 Content-Type: text/plain; charset="utf-8" When 64-bit addressing is supported, the Linux EHCI driver programs the segment register to zero. See ehci_run function: https://github.com/torvalds/linux/blob/master/drivers/usb/host/ehci-hcd.c The driver comment also notes that descriptor structures allocated from the DMA pool use segment zero semantics. Descriptor memory is allocated using the DMA API. The platform driver configures a 64-bit DMA mask so memory can be allocated above 4GB. See ehci_platform_probe function: https://github.com/torvalds/linux/blob/master/drivers/usb/host/ehci-platfor= m.c On AST2700 platforms, system DRAM is mapped above 4GB at 0x400000000. As a result, descriptor addresses constructed directly from the guest EHCI registers do not match the actual system address used by the controller when fetching queue heads (QH) and queue element transfer descriptors (qTD). Introduce a descriptor-addr-offset property so platforms can provide an address offset applied when constructing descriptor addresses. This allows systems where DRAM resides above 4GB to correctly access EHCI descriptors while keeping the default behavior unchanged for existing machines. Signed-off-by: Jamin Lin --- hw/usb/hcd-ehci.h | 1 + hw/usb/hcd-ehci-pci.c | 2 ++ hw/usb/hcd-ehci-sysbus.c | 2 ++ hw/usb/hcd-ehci.c | 7 ++++++- 4 files changed, 11 insertions(+), 1 deletion(-) diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h index 6406f536e8..05d8db4a5d 100644 --- a/hw/usb/hcd-ehci.h +++ b/hw/usb/hcd-ehci.h @@ -264,6 +264,7 @@ struct EHCIState { /* properties */ uint32_t maxframes; bool caps_64bit_addr; + uint64_t descriptor_addr_offset; =20 /* * EHCI spec version 1.0 Section 2.3 diff --git a/hw/usb/hcd-ehci-pci.c b/hw/usb/hcd-ehci-pci.c index 2ea8549db9..115d05ede0 100644 --- a/hw/usb/hcd-ehci-pci.c +++ b/hw/usb/hcd-ehci-pci.c @@ -139,6 +139,8 @@ static const Property ehci_pci_properties[] =3D { DEFINE_PROP_UINT32("maxframes", EHCIPCIState, ehci.maxframes, 128), DEFINE_PROP_BOOL("caps-64bit-addr", EHCIPCIState, ehci.caps_64bit_addr, false), + DEFINE_PROP_UINT64("descriptor-addr-offset", EHCIPCIState, + ehci.descriptor_addr_offset, 0), }; =20 static const VMStateDescription vmstate_ehci_pci =3D { diff --git a/hw/usb/hcd-ehci-sysbus.c b/hw/usb/hcd-ehci-sysbus.c index 61215e9f3d..df138fb339 100644 --- a/hw/usb/hcd-ehci-sysbus.c +++ b/hw/usb/hcd-ehci-sysbus.c @@ -36,6 +36,8 @@ static const Property ehci_sysbus_properties[] =3D { false), DEFINE_PROP_BOOL("caps-64bit-addr", EHCISysBusState, ehci.caps_64bit_a= ddr, false), + DEFINE_PROP_UINT64("descriptor-addr-offset", EHCISysBusState, + ehci.descriptor_addr_offset, 0), }; =20 static void usb_ehci_sysbus_realize(DeviceState *dev, Error **errp) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 24133af9db..0af9e47fc1 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -162,7 +162,12 @@ static uint64_t ehci_get_buf_addr(EHCIState *s, uint32= _t hi, uint32_t low, =20 static uint64_t ehci_get_desc_addr(EHCIState *s, uint32_t low) { - return ehci_get_buf_addr(s, s->ctrldssegment, low, UINT32_MAX); + uint64_t addr; + + addr =3D ehci_get_buf_addr(s, s->ctrldssegment, low, UINT32_MAX); + addr +=3D s->descriptor_addr_offset; + + return addr; } =20 static void ehci_trace_usbsts(uint32_t mask, int state) --=20 2.43.0 From nobody Thu Apr 30 00:39:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1776153726; cv=pass; d=zohomail.com; s=zohoarc; b=XygPRFax70fWGrrc3eGrj9vLSU9sQmxgeUM2th5hgs8365fWt1CYr2N1Ry2lqxNg+trkBPibeofpZGJnsG3kODUat+1CFotVVy3qgI5hlfk/Bm4UyMETk7w6S6qF2znIJhooVALMeSMOQFh4Kj3/5zzVipojXVwlP+4Ds47EzCE= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776153726; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=VyCwDqxis3DBBPb6bjfJ2G4AY6nV23Q9QeGiVUfq1tM=; b=g0AeRXodipwVVkFokb+Jd64hkJtJCj2TPrOov9slPJIzZ1uxLL5jx6lpsOQilIR7lHtXLZ2nRvt/hSIFNar7sX7KxGSRpdV9BRoLOiz7hhlLwyA+60t6YS7yMRLw9lroev5xv919bXhKPscCtlKdQrIk7hWVJVbuyNQIIcaMpl0= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776153726790877.9742809192103; Tue, 14 Apr 2026 01:02:06 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wCYhm-0003o9-Jr; Tue, 14 Apr 2026 04:01:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYhd-0003dy-Gz; Tue, 14 Apr 2026 04:00:57 -0400 Received: from mail-japaneastazlp170120005.outbound.protection.outlook.com ([2a01:111:f403:c405::5] helo=TYPPR03CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYhc-00060M-3V; Tue, 14 Apr 2026 04:00:57 -0400 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19) by SI4PR06MB8423.apcprd06.prod.outlook.com (2603:1096:4:299::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Tue, 14 Apr 2026 08:00:43 +0000 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9769.046; Tue, 14 Apr 2026 08:00:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Pzg0jgLY5U9xVZo4sMeBpRS56Ko9ph/cr/GmC6YM4qj/iaq/tg5VL2t9x74db5j13SD2QIwgtdsyvQCIvDHGM1nKBnxXxusmKIKPlzRmcGSF+0jf6/ZWd0ohoHzRTt8Z5GRsflAG8PzY6cxG8WDYMBhPHsFc7af8xu+5chvFY3bx53+Pe4Lh2TigEDvPronMGAb2+AImIjjTk4BPsVpp6bAUXVj3AWwNJ9xsVGFQT2B8zR4IJX8fETHTjMXKSo3a6asoG9V403raoXytTMNaZ3hMOGB+o/dufbIu/jLuYUg/95rw0Ohde4QzuRPAjyRGDSv+nlk9V2D8MeIwqUA5ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VyCwDqxis3DBBPb6bjfJ2G4AY6nV23Q9QeGiVUfq1tM=; b=Xs/0etOoY9Bg4XVSwKiSrupYxoMeCnDL76FEaFXj40rf7p//R/YzELWq2itsfMPxYDd6o/Oe+V06s7H/PwIc8sFZmYIm+E/6ksLM7XUPKtTR8KksR/2lkJVwWXB+QJaSrI3Qk1nkb2/tsL5aiD1P6qFkXk9m4vpn3SxhlAf1Kvfk+q8xpYVKXALZW9myQTdsGTsgRWap3wBam+7fDyPuSeqHpelaWh4uiL/vdsWiFQ6MYIhNAoZzYQHsKdogHunHufZaZ1SbGyZg/PLlK8kYsEBWqiEVfd94rMUC3BpPIhlIL+iq03Da9e6APhP/l8qsWTcfuiTP6Iimybq+YRxisQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VyCwDqxis3DBBPb6bjfJ2G4AY6nV23Q9QeGiVUfq1tM=; b=ld+Zwp0sq6iwpZ829I9jWUtxqaW/GfR+mcaH+OFO9p30JHtdsAAHrgTvq15siaWyx3GgMAThlCsXNEGk64djFlarvGZah9NIi/sWn/WPwKVoF8MHucJh9MYw60fNZQ1j7gaJ5MuPPf/McdududyRbW0vZpXDsoq93c23eVr9kVHZfCO+JzM4JJAfsWb6DFlrCK9eDOFuTh2yVCAfJGuYyjOGqR6Qb6AjJtuRzz1bxeJg2uQJPDkbOyNsOy10/hV4JqmMKeHtNxvKyiP33JFG7lzwb4YYcQtfqdQqv55rhMRfc42HZKI0B/p7Xqud/6fow3ogMeHS0mzfx0LM3EjZRQ== From: Jamin Lin To: =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , "flwu@google.com" , "nabihestefan@google.com" , =?iso-8859-1?Q?C=E9dric_Le_Goater?= Subject: [PATCH v2 14/17] hw/arm/aspeed_ast27x0: Enable 64-bit EHCI DMA addressing Thread-Topic: [PATCH v2 14/17] hw/arm/aspeed_ast27x0: Enable 64-bit EHCI DMA addressing Thread-Index: AQHcy+TKYA34hZRnakynJR36+qnNyw== Date: Tue, 14 Apr 2026 08:00:42 +0000 Message-ID: <20260414080025.3005916-15-jamin_lin@aspeedtech.com> References: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYPPR06MB8206:EE_|SI4PR06MB8423:EE_ x-ms-office365-filtering-correlation-id: 2d58fe24-6a06-4405-6ad9-08de99fbed35 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|7416014|376014|38070700021|56012099003|18002099003|22082099003; x-microsoft-antispam-message-info: F221E+tc5lsm/81+5b1GQIKk05Ro9nr8Sbsgb/LQl+4LjACYheUOxa/nmsZKfffU/B958VVHr85lBxANazcvp3N+M+T463m97ErDltguGKttkZ/ynZKMQL69U9mOPMIcZTDtztVKMR3Qp1EtvTW3apE/UH+GgFxfJ9DICMb6SmAETnIsZ0lp9AA+/+H7m47HmNrzIeiYXHJ1wqnOZ9KZCW60hK/yzApH8VilXlmtlJgH5hJHYiF3WUclVi6JF8nyzGPO1cyKarBm/n6kQ6lz1wL2pvGqygW997xL6AQkTLGfaLYq+YF0AzVbgHLjFpF3/XcauQ0Xn4OaujNhNOUrkAQ1D7VRUVcnXyfdcbArpSvDxKjFYs9KIU4QmkMdzBbMb7w7t3tSLzlmYrmQcfm9IIVWKwFn4e48UTV2qxIOhcghR+FuwOQ9p/J3eJ8nhkDkT2+QmtOqC/76JFR8UhHCarfHA3stw4bkoo0bV488egVaHbN6Q+RGOfasMekbTgN5WxThnXdUqFARgEttaPaEnVSAFYfrB2nCl0FD0V7F5Ij0zfSmHnkP9+L4yT5hDDjtAHFL+ulCiyoaa8zAJTvcqXg9+K/PKuDm0KXiYqoK8Te7U6f5LoYO9JHnLpJJOoIkjpeyC9tvODHDlvSfWn1DzKxrAtlr/FMo04NcyoL6YFkhAtysLhuhFTnAWzyeiBll3+oOVLH6jwqt3/Q/69ik/Mpa2d7sPo6macnwMFuS3XxSZvQE/6eKISWANAyChZA4oPrW3hT6ZAGV/pHAKQ9OM5nHHZptLMp2b21I0HFsfT0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(7416014)(376014)(38070700021)(56012099003)(18002099003)(22082099003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?CMPzA8VcSchlf9zaUVEbDmLeXBRF0PHhm99j2ZVaSrw7e90w9k+FVyBIy7?= =?iso-8859-1?Q?ti2tMw1wFk04ZKBsoa8BLccqq0bjZCTidWdpJbGy83rMzy+uy82FTJa899?= =?iso-8859-1?Q?NbKlDwiHlWmdOVCFOdDYgD/64H9b0hmJD61qiw6V5tzlVKD3ugyXJoMUVX?= =?iso-8859-1?Q?Z7chryK9RH1A+BHQF51/1zPPRDkNPSoE3FaepLeo3Om8mIgsOlDTP+sF/d?= =?iso-8859-1?Q?9FQx0LOz7Pr383CQb+DEeO3HrwnAfQ2aEEi7uq7ech/wnoSltF2OAmfj+i?= =?iso-8859-1?Q?5CxpUIiUmBAwPCVgmQ+dKUUDrh5998MBs2Lmx3SPpkJ3LCXqIEICnQSKj7?= =?iso-8859-1?Q?BeWptijbaoX1/u8thCG0Y9gUKozQNKPR/HZ9XhcUAcCvpjW8e7BbfxMSSi?= =?iso-8859-1?Q?FFgjIRxOTaPV2fsTupapK7T4NdlUK53/cZ0Etvy1HuBMuQQlZsMrnfo/pA?= =?iso-8859-1?Q?t4T6nzef0JtjBXu0Lqk1GCnwZzW4RXDmhkWkhTmS4kMaueWs218JwmsRmk?= =?iso-8859-1?Q?/4TueCh2Ys2Mgn5VXba89+jfXefEmq4dnw+HZrz7KP7IHYmLYCQ/hoDvnK?= =?iso-8859-1?Q?Jel4auVnVvZ9lCgw9cpHz+uh0+F82XO9VYUZEBa8Pko5kDjXKcU4D8+Qi6?= =?iso-8859-1?Q?bKjmLKESP8/GDMCNjvz2vme3z2XsZXsXi7aNHJrcZylulzmdid4BdBu8OM?= =?iso-8859-1?Q?Qw+1Jn0syU+n8U7zOZgJ3cbLwuZqrt3croQzXVTCZqU1YEP+jvG8wRnbEB?= =?iso-8859-1?Q?If0dXSutIMhZWKMgDCQhaFJbv/vztQ5Gf5kqTgDbcg7pGSA6MUxVDXOqwy?= =?iso-8859-1?Q?+HAaqelyJYs+GEAaxnOsG0z5JnjniP+WHOnP18XMLWpLqnKpS4XLrIwFZx?= =?iso-8859-1?Q?XBf6IM27cepToTSlhMzoL0KBvwZX3xtt3nBp1SrVrw2zjrvEqZzon5UA3C?= =?iso-8859-1?Q?NcNuN3U1qyxnYYRP9VEowMtDnNaYqQFWpmO3QkLOALmU0OQEPxnuvMX1fQ?= =?iso-8859-1?Q?Kea4zUFvAV142mhSk53hC6fSCUcqMJT84MWYDy4gKjvqlmh/VgVUTv7aLd?= =?iso-8859-1?Q?1My1VtST+gB14Tv+9FM/Lzq3cQmja/3KHVPNNLefj/y6bvQYN3+BnxsNxM?= =?iso-8859-1?Q?1NUhstCqXzEM9+OKpOYyLm0AkNiU6tS8cRtCgRbIkDwzLDQRmisQud+ogg?= =?iso-8859-1?Q?WjRGlSOJBQlwFmHPbsm/eYWKyBi1DxhcN5eiIsxVnVj5p79qyms5nxrjG7?= =?iso-8859-1?Q?18Jn8EDjkPvDz1r1O8BNuc7X0zDdkmoix1wf34GGQaJaGYU05x1YnG4vVR?= =?iso-8859-1?Q?Dtskj0xql7H/S+X14qaLceQTLzx7sWplqKNHQGsWscWCScqiaa3btncnA3?= =?iso-8859-1?Q?LbN65v/I9WS0Asz2u5SFrYTOTHwXIydNKBsF8OLP0ADUIxdmGeif9YbB8P?= =?iso-8859-1?Q?sv+xez/r2dDQB90ThZhNpa5vFOtb6jEByRiVKF02X9tX/8f87OyjL992E7?= =?iso-8859-1?Q?/eQQjNkLMXcqYpCuACB0Hx5ytd9WxQp53lwX+goi7/DHdY6UgOc31Blf6K?= =?iso-8859-1?Q?yQ7JYoMKxmD8a44SuCbyyviCf/xn97rBFsxJNQZuAQP/2G6Y5mpoowbJw7?= =?iso-8859-1?Q?TFyDskuCXWRK8YF/RtbwkxoZCezCNfcDY+GU1hYmcKPdgxmV46SleW50wv?= =?iso-8859-1?Q?YEe+DoFpPefe2waPxdFkT7sC72R3NUmdq9XknvO2Dk+oEW3NctqNLzSPky?= =?iso-8859-1?Q?pk9HxdM+K7ZZTnaoFZI36nKjAo8ori6S+mIFsHyLLwUwQQ65jkZFRCdj4B?= =?iso-8859-1?Q?jCjrdQaghQ=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: TI9gWeNczUPZTlZiHyRIMlncG+hB9nh4PlNQ08Yc/23WS1bx2NSNZpBkcQ1r4h+Easm9kB72PyzI+fdK7YAbGO61cNhThVZ2KK04e+UWbb2BlSL0HVA7WBlFbhSjBqFa6tw8sfHXMKn6zSgxohuZ048ZR+6FTfQx05ElXBPaYmy/tth2dA/nl9LALXvDrh7++1wTVGbO0HQXgigKS3/cWHc7ql6tgJnx2wKPiqdMZK688tPANN55roNb3MRPc4zBTiTACkvoz2+ZPF6rOd6bo/zjsASfhAMyCsvRxJrMzV/I2alpMSq3Ejqii8+M0GpGwjqdJ6MJxV8NCVXeRrG5bA== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYPPR06MB8206.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2d58fe24-6a06-4405-6ad9-08de99fbed35 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2026 08:00:42.7560 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RNFjEsOZFwAGwyKlQNN+0WCv/A137ZtyRyGXPxOB1UPNsBAaTZFOHIlx+mwId6Gs14o6UJYNjTJdW674hHVwz6HiQOls5XbyhK9ClXwD9tE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI4PR06MB8423 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c405::5; envelope-from=jamin_lin@aspeedtech.com; helo=TYPPR03CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1776153729017154100 Content-Type: text/plain; charset="utf-8" AST2700 supports a 64-bit DRAM address space. Therefore, DMA transactions must be capable of accessing 64-bit addresses. Enable the "caps-64bit-addr" property for the EHCI controllers on AST2700 so that USB DMA operations can correctly handle 64-bit memory addresses. Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater --- hw/arm/aspeed_ast27x0.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c index 87dcb82e1b..4a1f7cad73 100644 --- a/hw/arm/aspeed_ast27x0.c +++ b/hw/arm/aspeed_ast27x0.c @@ -856,6 +856,8 @@ static void aspeed_soc_ast2700_realize(DeviceState *dev= , Error **errp) =20 /* EHCI */ for (i =3D 0; i < sc->ehcis_num; i++) { + object_property_set_bool(OBJECT(&s->ehci[i]), "caps-64bit-addr", t= rue, + &error_abort); if (!sysbus_realize(SYS_BUS_DEVICE(&s->ehci[i]), errp)) { return; } --=20 2.43.0 From nobody Thu Apr 30 00:39:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1776153781; cv=pass; d=zohomail.com; s=zohoarc; b=SJeRhRsH4qRxvwP4vwz6mopx/DJZDgt+iJZIOzfeuDGWz3aNcf2LdOsoZKFZ+t6Zkkju145r1/oZoIfoyLAoLE7Hicye9Ztwxa8BMFPr4bTXrpU2+hMwN9EX4HilYcBw9xsJiKxs6/RBjCYOTJj+DxCc03f0w5gG1gybC18CtSE= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776153781; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ygTh7ToBfZdOi8sGPc/aXWfB1/AxJP2jnWfeTJmsqNs=; b=Lb+oSNOJoMAHBOXtTK6DqmKT/dbXHpGqDZlb2PXxJuDoYwsPuZ8/qs+0DRjgbQEXHMX1N+FrFaq5hGhCIgsvWeubnA9llVGP2r2YhM0GMno2Ud62qTXEjdB/s0UjE2cGfNYVndGpK4LsV4UtAKTh4ofQTkw5xYH/0j8k67N7Uug= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776153781234269.3821473791064; Tue, 14 Apr 2026 01:03:01 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wCYhl-0003jw-Qz; Tue, 14 Apr 2026 04:01:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYhe-0003en-VW; Tue, 14 Apr 2026 04:00:59 -0400 Received: from mail-japaneastazlp170120005.outbound.protection.outlook.com ([2a01:111:f403:c405::5] helo=TYPPR03CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYhd-0005tv-AD; Tue, 14 Apr 2026 04:00:58 -0400 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19) by SI4PR06MB8423.apcprd06.prod.outlook.com (2603:1096:4:299::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Tue, 14 Apr 2026 08:00:44 +0000 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9769.046; Tue, 14 Apr 2026 08:00:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=P3fs+3S6WawsiagR6tfsnNHGdPKua6XBhYn9C/uAqI/sPr4wSdk3wezD+1sKbvohFF4i87RziadyxW5tZyJJsuAFYCFml7IKZNovwwFTEEwNoLUjNzZKhJjDBYYtBz7+cNyQLkqLnYr1VA+fA0upcWaml9AvrjJki3MYbFnY1kA+nxEr9T230UsJ+81dlvjsaY66Y8pZcd0HWA7C7yLqMLUzxLD5sg12ibtkj/6BhjpftOHLJwa4zcSsOREzO32NJim0ScRaqfhzg3oqTG+w0AUv+uWSFkvMuUPrMolyKsdWigcQc4w1t7JczrSzxbU6L8lt7HLHEB2YC4SsJHdPnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ygTh7ToBfZdOi8sGPc/aXWfB1/AxJP2jnWfeTJmsqNs=; b=s0Tm7fTcpatLMQi4S7PTlnEf3p76UfC9k80WChzMaw/2UrsnmBwkDbbryuX79WwV0KEOsI8rvqHNH8ZKhYvxI84iofHyqZCxMmrD94gd0TU/KSN999Ib+iWbTYtgQBoVpeciCQSwViWNMYlRPFiXHXvI98uSPKrBH6P4QXcQSxc3iCf69bgKgTy6+fCOEo3XJ6hrpIR5zzbBqa00qFjAZzdCtSxV8lTcOEzY+xamwUgAGbA4/0dGKF2UuOHvgRcjN7bNbZG6BtaFvehH0thfTxtf3OwBvnAhyetzOYp1SsvifzguuysbWMfUZY/4RC9EJB2+8IxblRcJ61lUn3x/oQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ygTh7ToBfZdOi8sGPc/aXWfB1/AxJP2jnWfeTJmsqNs=; b=UwVOiFs0UaMynPf3A22p2hvT1/MsCurhLnghiASuczBVb+ywPRZm9q6CXBot+fu2EWve2B1UZWhOOxykMx9n3O3+OPHjvBaroxER1z0/ewb3WyBsrP/mOt0oAMiIkiYCIeU9b/0A7NiJrq7tYxNAvIiO2OIKrv2VK0PcHGMLMCYUJVklWqnSjnwc5c+U2spRgvqPRRn4yUjzM090ZQ846P0kPEMCZ/R4nVsybr20pawgL1nBY1TogCAlCyjkDPGWQmuwzX9T83U/oPHY6JBUcZUg9EOac80kKpge92xU8sTEJ6IaZoL47TpPx/DbMW7ELaxZIyVI1KwzKkGK5LYDgA== From: Jamin Lin To: =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , "flwu@google.com" , "nabihestefan@google.com" Subject: [PATCH v2 15/17] hw/arm/aspeed_ast27x0: Set EHCI descriptor address offset Thread-Topic: [PATCH v2 15/17] hw/arm/aspeed_ast27x0: Set EHCI descriptor address offset Thread-Index: AQHcy+TLbfX2KXG/5EK1P/Ap3IRTjw== Date: Tue, 14 Apr 2026 08:00:43 +0000 Message-ID: <20260414080025.3005916-16-jamin_lin@aspeedtech.com> References: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYPPR06MB8206:EE_|SI4PR06MB8423:EE_ x-ms-office365-filtering-correlation-id: 2ac972ab-3ef6-44a7-87c4-08de99fbedcf x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|376014|38070700021|56012099003|18002099003|22082099003; x-microsoft-antispam-message-info: yFTK2yng30KmUqP7VqBFWmWfMAXCmBcHQE1zZwLNyJHp/dfYKV9ne4F8UFPgyZyUzJciFz+8kFzmR65Kvx/Cqxg+aKo38IC5cR5uO9eFAC5wHSXpmyYhLbxHCRApurJgLTqAKcuR6ghNljVpNgqqjJw/qpziVm7AMsZlnXktrH1XUETWGVjhgylmW6w6CRhy51r8nasnEmbDSPPiIqMkt7mNoEOEvaE7MiTrDq+YYovgJfe06vTao1pG41W15YVv/xUNj7r9crawaTPiV4ubwbZWiBNYkgvrTG5nnHy5PUoMo+byK0pfV0DzVJqF8zN60704prz/82StNZN9yk7OMuseFuPmlDN7XTH00hCv0iEJi0MyKTPG+B77sJSkLZFVYqUWtyNBfZJ/Xv/9FPHImMTiWTcCsAP4PLQ2M1WxlKDYIFMdMPJU+I3ABRPaAC255svrxIwkY1VjaFQrOa1yYbSuPB5CUTQm7sM1ceVDAryI1l9i1N5NURw0k4Mmsh1jxiAguMeHyS2I5Qhc/TCMK6mIKhyL4dLTHbDaHtA8LBLHLUjv5QHWI/9kXnrgrDOG691Td4W4QkcVgDHjsM991O8UnO5duc1RiEWlua1oZbbrZscZTRaHssO1QV8ltpPea3m3hvv3gdxKsp7DCA0FLiUNlS+udM9NPruRLEx0zUlKSfUQhGzCwFYzymzCOpFyU5F1bqW+SuE5rw3WYHqVYyfRd3JinIJ8rPycEwem2bYZvL8mi1rrbOoDNxjsI+2WD2zv7FXPmbxfkhXRsR+E5wTE/f/3228ZUCNT/7+erF0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(38070700021)(56012099003)(18002099003)(22082099003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?on8WQ8GKkoMwq63cqHdz91DipndZyImx0O9u1WqOT3z/VYCcyhHJ7sap8N?= =?iso-8859-1?Q?JkCn+zo2LfMOhNGxpkGrsUJu/Jx4vSQuw2Vw9daugDMzoKgprm6U7HzkR2?= =?iso-8859-1?Q?iYXUCG1UHTqN060N69P9XYAS375a28TZBhkZhByJvICx8CGEtez/e3nzRi?= =?iso-8859-1?Q?+YPsSqsQsUa7/CjDfQob0TvHdSUWF5ZIngsNNZ/ZFfJy8tV9YSN0QFo43+?= =?iso-8859-1?Q?VXBmmm1CEdN4R8oVqH7R3iuJD3nbH2NSh15woMfiubYdY7TuL4XKOU4VUM?= =?iso-8859-1?Q?QqW82OCWypMJjUaA5rm5aSicriRYN1/wuZVjuRhquwgJ8pUsC5bz15v5HZ?= =?iso-8859-1?Q?+dQhDJ7mpCq5pkAu4N4E205wp9lNRMu0yMo+/Bci7KR323nJ5X8fANFvfe?= =?iso-8859-1?Q?pgnkG0rjR00yzpO8yk12lt+lej+OdcIxwrV39oaX7hKT999JIBz+SBckYl?= =?iso-8859-1?Q?oAvKLn+IToysGwZkIuFFdLCfnQ0tPjLk50elcpMnpAEoaRoDuufFHdl8fR?= =?iso-8859-1?Q?mT2oaOOWJ6sf6e5U2n6lyoBkAJTaUgSi5lSynPcH27Ep0Gri3H/KGiAfpk?= =?iso-8859-1?Q?Zpif8MkLdgPz2fcriFbHMEn/HWw+TfwSHCR950R6o/sLltDxz+n7Wb1Ggr?= =?iso-8859-1?Q?bjM0FhW1n3r7xnIoD5wHtJv6xY99G38vHhp8j7oitJSNuZfqGdswKb+Ijy?= =?iso-8859-1?Q?X2XK5J+RfBr1KWxQvcniHkSornGhiBAyICLMjLODXW4azgvgnS6wXUfP4x?= =?iso-8859-1?Q?17q9X3uxk6j5xvc6UvBzMDmZz//70ozr/uhMmoliS6XyE1QKKv27OZEYal?= =?iso-8859-1?Q?veZjt30K4a5S4ayVPVhVbf8OUloHDR/Ix5Feg2kze1Y1vhkTm25DTF06cM?= =?iso-8859-1?Q?bIixqdrxg03zmY2c290nxqzeE6ry8QPMzPxYXfFGzePjesXymqcnwSG5O2?= =?iso-8859-1?Q?ssebe2BlyQDJPeYmxD5rz+W3CAYwsnLKJY+LiFtT95sa6wyD9KNUudb0Yz?= =?iso-8859-1?Q?Housb4UsUeHnAnoU1kuOef0VPKmfVyrmS7/ii2EX3QJvLfM3tfV41SuTN/?= =?iso-8859-1?Q?Oe9+9rVL/X1t2ncUYdQDJYpJQx/4YITGFxoSYVlOfD6wSJ3SCb6e6YvgeC?= =?iso-8859-1?Q?5vdzWTRlUnHSFapqZuSLHJBFE9EoyuMNFt9R0hYFytd6UNUUgaKA6HUzeo?= =?iso-8859-1?Q?SIJwez5smS7JoCvjbL3qYX1SkqIT47Tgsgkmy/hW/66Ep9/iVQKXQ9ARhk?= =?iso-8859-1?Q?7l5cuKirsltusky138m/eDD2J4SDvx70n0DUwkBOzcnphD33uhHzBvSlkA?= =?iso-8859-1?Q?8UArlsgh/puW3qshNZ5T3PQPuuL2xNrhGqveqVlmf+fpnY2uAN91NUp+vi?= =?iso-8859-1?Q?ryZyCa4HNVC3j7iuzPIPhqKge9g2wx+MSHPPzEqhfQgcm3SYj+ZjMBQ74S?= =?iso-8859-1?Q?9AsZHUMlXNrvsBKLwp/hbvBIHGAa0moh5g70a3E7ro3pH1qOcUCfaZooIw?= =?iso-8859-1?Q?jHdCmc+5wPYAyIgfzxtR9bM+jkYP7glPUlvEo/4vC3YxO1nYd49LDB/9ka?= =?iso-8859-1?Q?M86ERWWni68dmPpe7CKNSoNibqeEVa7P40IpVOt4RxEfwE6M+af0sOYfLH?= =?iso-8859-1?Q?3ph21xmT3wLqQ6LeiIV1lwZHzJlbZn+HwEToFP6hKkdM3YaelXXvhVV0lR?= =?iso-8859-1?Q?ug6rpxfIjXE4rUtkDDZtehAj9M/5cZm+MYQIWvlgmanZ1+eJ/rdshG2ZB0?= =?iso-8859-1?Q?FRS6at8tybhUNmR0YplFbC9W6EWlwMwe/Aok2T2ErUP3l+i7arcwUdkX2h?= =?iso-8859-1?Q?RogejuMaqA=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: eFJoh/C1BFiD4HfzucXFGwjmf0JU3lXPLSg9QCFcMiK9zjZukbevW80i51m0/FqOrPzkFMerpA2TYkhFKX6ZDBR/VbTtD/8nYwHLUfcl22GJ7NT7vz1yUVzFfdQBOaOB+dn/T04nDDiHSHx0dLKhId2kpzhsv4bQw58FNQ1YEr6mA+Jp5Y0RevTyz2sbCff9/+4sZtwvkoZxqBzAGJDpofomkuJZ0vo1D2IcNsh4KBZhRyZ3EjOpe/tFdLiZcl5+1Lx7DMGaR1sPKb0mBQMjyIvDbvg9jI6n6ayVneunP4WxVueV5I24X9EPguaP0oNkCHlPY3WBP671sEXBGJCgpQ== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYPPR06MB8206.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2ac972ab-3ef6-44a7-87c4-08de99fbedcf X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2026 08:00:43.8768 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: W8iqRgEKSBPwCescAogzjh2PkqhhcCBGBD/xmDZOkOml/RYndvhiniqPU02urVo+UUIlmLy28F5cKjHq/ISIIW9UWMJYpBNBKCsVW43wJvM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI4PR06MB8423 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c405::5; envelope-from=jamin_lin@aspeedtech.com; helo=TYPPR03CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1776153782442158500 Content-Type: text/plain; charset="utf-8" On AST2700 platforms, system DRAM is mapped above 4GB with the base address at 0x400000000. The Linux EHCI driver programs the segment register to zero when 64-bit addressing is supported. As a result, descriptor addresses derived from the EHCI registers do not include the DRAM base address. Descriptor memory is allocated through the DMA API with a 64-bit DMA mask, which allows descriptors to be placed in DRAM above 4GB. When running on AST2700, this means EHCI queue heads (QH) and queue element transfer descriptors (qTD) reside at addresses starting from 0x400000000. Set the descriptor-addr-offset property to the DRAM base so the emulated EHCI controller can construct the correct descriptor addresses when accessing system memory. Signed-off-by: Jamin Lin --- hw/arm/aspeed_ast27x0.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c index 4a1f7cad73..3cdbf78ac1 100644 --- a/hw/arm/aspeed_ast27x0.c +++ b/hw/arm/aspeed_ast27x0.c @@ -858,6 +858,9 @@ static void aspeed_soc_ast2700_realize(DeviceState *dev= , Error **errp) for (i =3D 0; i < sc->ehcis_num; i++) { object_property_set_bool(OBJECT(&s->ehci[i]), "caps-64bit-addr", t= rue, &error_abort); + object_property_set_int(OBJECT(&s->ehci[i]), "descriptor-addr-offs= et", + sc->memmap[ASPEED_DEV_SDRAM], + &error_abort); if (!sysbus_realize(SYS_BUS_DEVICE(&s->ehci[i]), errp)) { return; } --=20 2.43.0 From nobody Thu Apr 30 00:39:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1776153815; cv=pass; d=zohomail.com; s=zohoarc; b=VMi5n2BmmXZMuVhkskdSET27rer3HpCJ+oN8U0LXcAMGFvDOSV6/b3rysUPIe5UvOjJpVP6K7fhyWvSwWLBD9dr6ZekJDMrfqg8nV5Z+1227bpBmileAaIOTKz9dqLkEN9kOp+EBcKl0XbmIDDCPwEQf+WrUB8j+df754ALWLJU= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776153815; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/+BXLo1w2+fDyW521IkHc+Zp7jJkmj+YQyW9uVoszJo=; b=N2qSg7XglCUdTUWpa5p2hRg0RZRWfJU+ISOiulINc8EO1D7YL8S2r4ewj70bKNKFKz5C2z3CnPQAFi4AhQnwA1AMbPgKk4KlyrsK77m+ULxNdeOqj1Rz8q7IXlIuJvCDhP9woihWXTb/J7fD49QQKqUaJ6JzoG//FiTT9kdvsh0= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776153815350794.7141293763085; Tue, 14 Apr 2026 01:03:35 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wCYhj-0003iY-LV; Tue, 14 Apr 2026 04:01:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYhg-0003g3-92; Tue, 14 Apr 2026 04:01:00 -0400 Received: from mail-japaneastazlp170120005.outbound.protection.outlook.com ([2a01:111:f403:c405::5] helo=TYPPR03CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYhe-00060M-HO; Tue, 14 Apr 2026 04:00:59 -0400 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19) by SI4PR06MB8423.apcprd06.prod.outlook.com (2603:1096:4:299::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Tue, 14 Apr 2026 08:00:45 +0000 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9769.046; Tue, 14 Apr 2026 08:00:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Xe1jUv9/kOWMJ/CTMIFLsnWVBVVeWAa/nezrrpTpaED0ygUrhUU24mdnjpL5bf4iWBQWqglgkiBvlmGrtpP7pnIWJN+WjhXJ5INNebZmv/24x8yoVlUjlythNDw/3z0C4Xik0l5GeOjYtbRL1tMbFBecMxoohyfdP+JuPX/oDFwTmvXDIAPRf9a9BdsE0RGUL6E+0pi3fTKZN3BVWPczTVjZxj4V+FuwSJAmc5YG4F6sVNJvU53CgC5NtAG+B7YdBM4DWVMerHS4qfwBHGbc0bzceuTfMq7DXfRB8EVl17H5hfr58x7hS207RdAznU6qpFQ8OP2yz5kJwzp+C3Ff1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/+BXLo1w2+fDyW521IkHc+Zp7jJkmj+YQyW9uVoszJo=; b=WRAXxi19XquZYa5FEGLcziqOTQbLdGZfpiq3RkAYDRuysd2Wmw2ALxPo3Ykb5AJYalixPre0o3/SnPd6O0QgHyCQmQrjgMr2zhJba4HmYGv1C5GdwoRvnGPLKuZ6a98phu2mtuPKQslj8gGlZHV295vCYF6YXBINPaE/RA2VF0UjeEjq7M2w3whRHqKWwhFOtkz+1RKo3vrScFfAiCmmuenyy1GdPnHaQiK19l7akYKTfAyqdkcGgKlW+1qA7zQuRE4hbZOfYY9/1/9GqAgqPQOXGXvnW8HM67seiVn0zOeP0qYSzMCUvc5+RvlhAtQVptT88o7IbdECEvD/bsw0Wg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/+BXLo1w2+fDyW521IkHc+Zp7jJkmj+YQyW9uVoszJo=; b=B592FG0hwf2a4iWjAvFBwCA3gnC4bXqQ49iPBmIXCnFZTvwdlLt/HrvKAJZr/0ibeZ7H75eZZ3jg7hONYIGwjkloofiQsgg8qrpkLuYDcw85MFvIwX2snqrrvT2mGtaacYgcwyk/bOQ4+64SYxbmu8jBcbtdBiWiT16T7bI4RmLjbh3Z6uh8y1vunBYVutzU+er/h3HtlOiNTHuxtNLYdgizF4BnHE9wB0Az6M3mki3Zz1IHNfpb12sv4RJYJQ9nu/ArBDhi0HM7MTSTRa7HsOgMy/qvqIlFlLZvFRFpcTsooigazgH15FAVyNkReN7VdncDYJDc42CC1fVleh921A== From: Jamin Lin To: =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , "flwu@google.com" , "nabihestefan@google.com" Subject: [PATCH v2 16/17] tests/functional/arm/test_aspeed_ast2600_sdk: Add USB EHCI test for AST2600 SDK Thread-Topic: [PATCH v2 16/17] tests/functional/arm/test_aspeed_ast2600_sdk: Add USB EHCI test for AST2600 SDK Thread-Index: AQHcy+TM4Eexl7bBWEOSo3UyOpE3uw== Date: Tue, 14 Apr 2026 08:00:45 +0000 Message-ID: <20260414080025.3005916-17-jamin_lin@aspeedtech.com> References: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYPPR06MB8206:EE_|SI4PR06MB8423:EE_ x-ms-office365-filtering-correlation-id: 5cb22094-b2f8-4271-56b6-08de99fbee86 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|376014|38070700021|56012099003|18002099003|22082099003; x-microsoft-antispam-message-info: oM6ARDgh32FBDRICyaY2I7JQ5wATXF/yKJWFiPkhFze/C6GEUw6CmNJ06DQfu2TBB3MUuJxEnYFYR3AdZ1/8rZ17lSVzVXmwlD26P6w/5v8+nSbhr7jT2syKfAl2JjLiMOTMBKrS7axD5MnXmHsF+5DSEzpYzFpKQrUQEcdI/MCp9Ap7gpHObjDzgY/7BM80FRb9MulwK+4FSbquiSLNAchl63fJVD7nF8APtNYTmSw2P5XbmvIevqaPL/XmdxS5Sfu1pTb22noLL9g+xnOIV8UsVLcffuHo1OMvv0ouQUqfbp1de33N5SJhYhqVCAzpwx8btD2UlXxphLREBEl414DfwdGowGwHOGAuxMAqQoXIKV+xhbOGPl7MEOAV/c0/opfhhJpsWOKf4TpCnglIrnTro5vjsnaNHXdWr21OrkxDjG4OfhVhjNs0PvMoFgeqTaQ9/oZ/sL0iR5czfC+35gAy5QJX6vubh3oRJsR5N9B1NbZKdNk2eiGtwLUdf8SJpIrNzjheNtXQjAYjmgiRBjSv0qEkSOO3HUybbV27xMhZ2ZReMjH3TqsQipn8bau4w1iWzN5e7mEKKWAEjGYHECYcv0HIJX/6Fu005LOdSUANZJW2ffOR3tGPX49Gwm4Vv8NJRGNKteDhaHEONaoLF3p7r1W/hDXPeCuIlFVAhJ6FlPJ5ktbkUttC3vwGjVubx5gaJ8QS8maT+mwk8BlDe3ZrmoNr6uGtp2CTaC9K/ug/HgczxrctAvfytrtGxHyKUdFtioVND+EmXCy2oxMCEObd2NEfVGowAIyBluL3i70= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(38070700021)(56012099003)(18002099003)(22082099003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?SmVsZaBORM16coLY3FkynIC0SUY/jJzut5ZSJzYdJn75HO6zPeSV0ZqoMe?= =?iso-8859-1?Q?75go7KEOTrX8wAQPaOcS7VovSMJPzjuY9nM3QM8+76OGDfTvmNqrCKPrTd?= =?iso-8859-1?Q?MngfF10UhmNaGeDRpJM59ej47SAT0bSho8TvY1/ohY4kfkTldAYvgLDaPg?= =?iso-8859-1?Q?TXofUpLYqxHKmdcS2CvU+2bQgTm7Mmcv3g8xyMpbCgwUKWVsNCzupZSZ0d?= =?iso-8859-1?Q?MaSzfpRi0o3XNn2RJJ5ifYOaVz6aOeFGh1rrtXTFTITMMTD24rrukgDtd1?= =?iso-8859-1?Q?kipoVt3FIf/glzS97/blyMkrzYqRRfic7xVeE5pXjAm6uEkVe/HKjo8G/L?= =?iso-8859-1?Q?LDapKG0akWkIWnRKrkaAH33htq5q6knbZ/qHkacGGf2hB+Y3vGX8hNjCXb?= =?iso-8859-1?Q?UdFv/7doJzavzGkQ34IWz5kJ+6ibYyc+5/Gl9bgg9N8fI/bqQRP3VZu5Ad?= =?iso-8859-1?Q?DzReTEcIR2JLHZ4NAVmdIm03WvCeJLyDUZPkYOX4of2Mh8+5ZpYcHw+Ffb?= =?iso-8859-1?Q?A/DIDovNFMbghqTulgQGjxJ1B/cfySSamxloX6B4TyWxovrcKXWqURslN3?= =?iso-8859-1?Q?muwnL7jdeSAA3O4mWYB1ndrI7Tea6F3yyssqMh7vT8QjjBkc+FmLWWhqNq?= =?iso-8859-1?Q?ynLz8GmrB4w5nFMEu82fMtAI8OONk/AHBTCje/lVISSGaiBmgh7JfuF1fa?= =?iso-8859-1?Q?YzPIYRjwHGCGGYjSguvaygaXGdtyNOg2bdukt4m8DyVxTrgTW2Wnt98JHZ?= =?iso-8859-1?Q?a1iRQKWOKsrkdreIVJ+he4P6bVCYvbL+kx5XKOvs5cw+uR+gqo+9wqWMFH?= =?iso-8859-1?Q?7Ollu7WnwbE/Jw7+4jdjsdMr6fZgvbQVAebUR7kDwNr8wxE1ziyA0FzDIh?= =?iso-8859-1?Q?29CvBHloGPepWE8HfXkER8MMN+QOgErW10MzqMYXoIlG964VDX2o5aQA4o?= =?iso-8859-1?Q?Ga9GnGUidMPLCIgDgVqZ5s7v0JI4SvsPJdGr+OkwpsF2VkEnvFrvrEcLQR?= =?iso-8859-1?Q?bivPzrdndf25B50LMV6pdPgYTvP+h1Dw/rb54RiahtzkoPia3OnMnGIPoW?= =?iso-8859-1?Q?Cn8DETCiKQH0fz81BSZdQ2dnEI00KwowhYQ+5Gh512wUNpO3SsHEDCfH+I?= =?iso-8859-1?Q?MA5qXZEoM8KwtLsz0jwoaCDlGMu3jNKWvwJxw5DuGTn+l2EvhqnEv94YuD?= =?iso-8859-1?Q?rqAnNiyE1IRVoO9SBPbrXpyhkpqaDt1tSzeE9xq4cnUbkw5eO39cWdXMXX?= =?iso-8859-1?Q?whNq9aXCF2WrIKjr0CsU97z8hwHoCRFB010mjJJQt5arytHYJbUCLkTdVV?= =?iso-8859-1?Q?9kEGMz4vOyUDp5fMJn6R10xekJgWfjItF42EbprH81IZyyC1aaPvlWoF7t?= =?iso-8859-1?Q?m9T7IvxyjCoLflS/ak0bs+zhOG4FukZvT7mfBcUDLWYXuMaGl749LQN3cm?= =?iso-8859-1?Q?EHByW4QKmNJsvuda7uVsRz3GB1rBpwv32JDelxoInaYABSnc9jnhxmM3OU?= =?iso-8859-1?Q?XOgvtGi41229Anp3cUoAegJcRpMPAI/RaVg/HjCrlMDSDRTlype4TAgR7W?= =?iso-8859-1?Q?l0he0JMrFFAMKtZHU/CR3Z0ieX5fXqljilkJp03JiBlCpdCr4+hU4kX/KT?= =?iso-8859-1?Q?bue7dbfN6Jl/wDwkA9/LGIS7BwITvDI/xWX16Qv7g4lnLCBddbI/hc7xQj?= =?iso-8859-1?Q?o7oJ40GdBQuSLOVJEEjsD+ayuWvHCywNbfWeFCPV7+hceCCVuYQna3h+H2?= =?iso-8859-1?Q?5DI4iFKLYONC4ns7j0i30IVCs9uZVHIDy/G9Oa/rGsCc/oUl7c1ULoepGd?= =?iso-8859-1?Q?bU0VsC6BYQ=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: SByREud/eFFwxD2L3NYh09vjhVtbheSAAMiz6FivfO6dGCgRsNBYupdhi/DSJo5rI4hS4AMSkltKw8rbOEeT9m/EigfOwYAhSIUjTGi61SgiM9CBpKSOwdwBg01KjRXdJqTd66QnqmY/KZLAF0AHOakxQLZEfyz/ra2Fr/qSzq6yyicxuSKgo2H0Fv0GfCwsdTxlrhVhrLaVUv0zPb/xVbx4jaIYJtO8TPotc+H1q/MXPwm6POudl3xZpXwx/yVc0EWQ/nCc/OmWhW6W2CQXxsMBBgBl/rt3G826k3sU89PIX0J+rtlOgeVJqMFoWRRoTNWMcSJXvh0kR4pER+0h9Q== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYPPR06MB8206.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5cb22094-b2f8-4271-56b6-08de99fbee86 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2026 08:00:45.0261 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kB63DbSeXr+R/q37jjOsTuOZygUTz+0dyleKPBcIAU7/ioLkwo0H90QgqjBFL+l/JBagD94rbmvZu/cinSZm0nxcjrovMKygutDoYG3F3jU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI4PR06MB8423 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c405::5; envelope-from=jamin_lin@aspeedtech.com; helo=TYPPR03CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1776153816558158500 Content-Type: text/plain; charset="utf-8" Add a functional test to verify USB EHCI support on the AST2600 SDK machine by attaching a USB keyboard device and checking its enumeration via lsusb. This introduces a helper routine that runs lsusb in the guest and validates that the emulated "QEMU USB Keyboard" is detected. Signed-off-by: Jamin Lin --- tests/functional/arm/test_aspeed_ast2600_sdk.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tests/functional/arm/test_aspeed_ast2600_sdk.py b/tests/functi= onal/arm/test_aspeed_ast2600_sdk.py index d787e90d10..01548dd135 100755 --- a/tests/functional/arm/test_aspeed_ast2600_sdk.py +++ b/tests/functional/arm/test_aspeed_ast2600_sdk.py @@ -40,6 +40,11 @@ def do_ast2600_i3c_test(self): 'i3ctransfer -d /dev/bus/i3c/5-1234567890ab -r 8 | grep 0x | x= args', '0x12 0x34 0x56 0x78 0x90 0xab 0xcd 0xef') =20 + def do_ast2600_usb_ehci_test(self): + exec_command_and_wait_for_pattern(self, + 'lsusb', + 'QEMU QEMU USB Keyboard') + def test_arm_ast2600_evb_sdk(self): self.set_machine('ast2600-evb') self.require_netdev('user') @@ -54,6 +59,7 @@ def test_arm_ast2600_evb_sdk(self): self.vm.add_args('-netdev', 'user,id=3Dnet1') self.vm.add_args('-device', 'mock-i3c-target,bus=3Ddw.i3c.5,pid=3D0xab9078563412') + self.vm.add_args('-device', 'usb-kbd,bus=3Dusb-bus.1') self.do_test_arm_aspeed_sdk_start( self.scratch_file("ast2600-default-image", "image-bmc")) =20 @@ -81,6 +87,7 @@ def test_arm_ast2600_evb_sdk(self): '/sbin/hwclock -f /dev/rtc1', year) self.do_ast2600_pcie_test() self.do_ast2600_i3c_test() + self.do_ast2600_usb_ehci_test() =20 =20 if __name__ =3D=3D '__main__': --=20 2.43.0 From nobody Thu Apr 30 00:39:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1776153733; cv=pass; d=zohomail.com; s=zohoarc; b=XBMC6GUBWWGgprGHQtQG2KGmA+EcXxgWEHuh+veJpMnSegMBBQTxs8CvbpGOZQe/lrdMMhUSp1bZsAMY9k94XwyDLKMQZ4PSMTaNq6Wi3Ro3NlZtmM3g7VnVP9q8NTePlr3MzDPATYK9SFnQlLzU+AXdN4/1Bmo3P1N3t/3ymhg= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776153733; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=OeVKA1gQtxE507eUBEjViUYlF2RK9kx3HlJM9tWvWpY=; b=UKsUSfQcb1sV24+oXZP9wlG2OQsAEHybXoETeuTCxm8w2NdczlKRDm5lUfD8rf/5l5cBUavZihy9ORKGw5rXwIaon/5xX6w0URFLpqU/OuHAK2LQYtV4oESiYRU+wmoinve4aErbXRpPdWvv8mCZ5QwNPuFkAGaaGHhw5bCRL2M= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776153733914853.8189300747756; Tue, 14 Apr 2026 01:02:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wCYhk-0003ji-Pv; Tue, 14 Apr 2026 04:01:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYhh-0003hL-Pm; Tue, 14 Apr 2026 04:01:02 -0400 Received: from mail-japaneastazlp170120005.outbound.protection.outlook.com ([2a01:111:f403:c405::5] helo=TYPPR03CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYhg-0005tv-3v; Tue, 14 Apr 2026 04:01:01 -0400 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19) by SI4PR06MB8423.apcprd06.prod.outlook.com (2603:1096:4:299::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Tue, 14 Apr 2026 08:00:46 +0000 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9769.046; Tue, 14 Apr 2026 08:00:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yGeMyeAS3w13CWK/trv+cVvO7duOfpk0A+mDkzmWbwIA+Od/IQFHBFBDopj40ThH6vlWAvc+VvPlLfEodqiYd7h8K+GPtAzy1vVFN2rUjH8SSYxO08Cr4fLLC5XUHxiOu3RDDKHj2vDTN3xDczT2oQtWdnHZT6RIyxwdj0SdnkWFLH4tvGehiEwnhINsIt+mssZh2vAnMtXVt65gU0P81XL9iAZ4rWspmD9egUrqNoe2xs3ZD4OhcDs4xI10pNPF2sFM0cisjR3flhid986sBP+ScT+vHfuaFg9xwSdf0nyUzX677x0a/X4GMnUKY24yGpNbAB+JQcb91A1UwHgAIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OeVKA1gQtxE507eUBEjViUYlF2RK9kx3HlJM9tWvWpY=; b=cxgLubJXV++pfu5WLWcvezgSI28ezg/fDwsezwyI+vI4vdezX6cR9PZJ9Vt61D8BBsn4BGcAD4h7WZk6xk9IY790/2o+slXH1ghpLS6rGX5lZqDpo7mw2U+uO7ww4PfM8KAspN6fQ9S7LiwvZBu0MzFjGy2W3YuSWR1IkB4P4/2d/3+wWxvu8tj5H9yc8Xj71cnMcAK7KleLrJtYIrY+GmR1ptfZjv7TaFswgH61jfd2BYLdM/QV03rF+3O4T7l4JRNioIEYG5tdHlw8QTjlNSeurzxcW6+OZq0HIalqDRbKsnW6SOJfGflvfJe8/j1uK2WRE9yBYKuqALJdW+b34Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OeVKA1gQtxE507eUBEjViUYlF2RK9kx3HlJM9tWvWpY=; b=ahXQmJlGBxNMPd5dvwSd1n9nv77f40DG1a7tWmCzofnjJDF7qNWEa76LW3SQ7pjnOrnzrvYT0JX3CdnOGxAaVczwe8yaqdlj+gw5OjrAudFGc6UAUmaOZu8yDng6meiPD1siTMvs8+kshzNzT82bnTPLvwcKnFjoYufvOH6vErWKlpkZi49L2kP5OgzN/n1RwdV00EqUKj5cJu6gmCtm5mknuAI6yL1ilT4KWz65++cJoVFS0GTS9MPw2xaaT3yDVJgIlnqycAjAdLr9tMLbddNTS4df72Zou7Q5c0F9iorAOVVmgSGGkx7QZ7MLCqJfGK8zn+HWVyWmwm/odO0KbQ== From: Jamin Lin To: =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , "flwu@google.com" , "nabihestefan@google.com" Subject: [PATCH v2 17/17] tests/functional/aarch64/test_aspeed_ast2700: Add USB EHCI test for AST2700 A1/A2 Thread-Topic: [PATCH v2 17/17] tests/functional/aarch64/test_aspeed_ast2700: Add USB EHCI test for AST2700 A1/A2 Thread-Index: AQHcy+TM6C9nRA56W0e5kCkXK3qE1Q== Date: Tue, 14 Apr 2026 08:00:46 +0000 Message-ID: <20260414080025.3005916-18-jamin_lin@aspeedtech.com> References: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260414080025.3005916-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYPPR06MB8206:EE_|SI4PR06MB8423:EE_ x-ms-office365-filtering-correlation-id: bcdf09b0-a1cc-4405-b934-08de99fbef1f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|376014|38070700021|56012099003|18002099003|22082099003; x-microsoft-antispam-message-info: sYnQ3C9V5ssZ36E1B94oXO23BGsmaK1TW8j+8d5N7pjb1GNS81ssQ58kCM31AMYjl1tIsJYHCdjhUmEujgthCFZfJsfB6wgIvStjMDCFvM3IAxxjQ7EtWfkwG9+guVsn88GdNHKU25OHRVeP2WXE2ZGOAfJw7wTSEANb/mkFKOWnneURU5FGMw9CZB0GOdtWqc9DykdJeI9Ft6qqewsqEHxDM9s+vgSqbCGjKFt9+S/w537s3Quh1QXcTgFhO4XNjQSEwnYrVV8kjzSgMI2+Ztn7GsRmUxsazhaJfG8/Ge/0Ia1aEcB36phYN6eAFj6BRXtkdq3BSvsFr5yK0oI8D2T/Fh2JiQ/WDV+YK+qchENL1tXreb6yRe9oeNWz9HpePxIqyW3lJmXwx0pbzs5g9h6LT5dD/hWnUagkD0TdINpqzgSb7LpapV35PyeHK70nrI5l/FhLF5rpTXwfept4g4Vb3ue5P2ZHoFtgZZNmYfBcT1SrBBlagR05AfC7Uf1Wl3PHhlMhi9D85Ytf0UsYaMbfPBvZUh7xmyOBBFR/mlrrgub9AZJsAxy57+FFb/swtZulOb3Km5VoOtfl8cj4CvCRo1R83p/a4yUpbafRpNwfB6W1kGOrie1o1CYMKcr1120dJagITac/VMhkRJOkEZxVknDAdDNWVBjGd4ROO2YslvMD7URIUMiNGrQXq7l8iZ1cO/VQbM93ukJ+yM5hEFWDsJhXxHs2uX9VAdNBD4hnnG4duR5tFZ3PpZH4sYnd0bXv3kKRV0hlWMjyQeogcdVDRfK7F5+z3EGAZhzyDXE= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(38070700021)(56012099003)(18002099003)(22082099003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?jMO2THY5TzTauTaN1PHlkSqGOyAATNqfSIyI1RluoQq5qM/bfcUwveOo7F?= =?iso-8859-1?Q?JdcROb8i2LTp9gw4CyklMYf/9ujqITqJyBf2A7GxltOPzXWfjMzgPRx8Oh?= =?iso-8859-1?Q?kPF9SPiGx0mwaaBa7eQgXbgqjml/XP2ocsWsF58lxlJwc0F6wg+NW+rls8?= =?iso-8859-1?Q?nOAjuUcJSR9tzmT1mG3q7pT9L4JsOKt1hp4ytSER+RBEdnRwBNitOR2rXl?= =?iso-8859-1?Q?l68+y+PHnZEXyBCCpKnToBJGZQNjC9VNyiNxvD4epJrFJHFe+dux/BrIIa?= =?iso-8859-1?Q?W5m3sP1BvocrYDPMgGOGnK2fJXbkXlCegRvASVaN6Hw690/F0PP87p+XZf?= =?iso-8859-1?Q?Yg+TPdZ0KsU21EJhQycZj0XjpWo/Q3PQWXci+JT+Jdm6DdJKikkOPACRZv?= =?iso-8859-1?Q?CSLQXvtE4zyHB5Wln+045L4KFy1WHmMzVbZG6oUEx0LycYQ4fIPM7LfDoU?= =?iso-8859-1?Q?pF09bvW8z14ZRsmWBJyz0j4fpOXSUiBJg9fBoHSjh5lCc4CQ2+i+sM2ZPs?= =?iso-8859-1?Q?FAQeWMHRgzpBNoDQqEdgDJlA8IVU9J0ck/sy3BW7tIZd1jV820pSAUN39u?= =?iso-8859-1?Q?/zm9dx8Rp3/ih24h1ELUf0j6JN/4CoWioP8fYMTI5X0WgBE9mtan1T2u6A?= =?iso-8859-1?Q?wHFdAQ64fXnnF056ZzzZr/y+jMZOWMGzb7ewELBhLcErwqMiaDuPV7m7XX?= =?iso-8859-1?Q?W5otsZc4JLsMKZ+Cui9x6lROnJTQDl9wDetCwPAJpDTMyfnFkefdmzfh0f?= =?iso-8859-1?Q?HMWOFzohgvRbH4OHGuHxDXp38IpWmizFELq8oXv2+0UFOFcKKpCOr08yFi?= =?iso-8859-1?Q?4gr/NjQRTCZvpfTtxHRQWg4BanYCstVFPlMwG3kG8rwB51/vvTRTncGCn3?= =?iso-8859-1?Q?98tltewejwWgc5fJqVd4LRFDKYkryFT7nCBb7NG6fECC1gwkrncN5zY1ZI?= =?iso-8859-1?Q?XjLO9QPQebMGZk2kOAZH7r4ZQr8qghJmmfMwtTHr9lms6OgH5kMl/LATnd?= =?iso-8859-1?Q?0N/TcOC0YzKlb6YCM51wSDTiASx18zCXo+p8CKWDlyiWPbIjSykLjYRSBo?= =?iso-8859-1?Q?DXzrCScAtE5EaIqV8hw9/U52ojHuaNpbTlLWrzUcOC4ON9dedUs/+2LUox?= =?iso-8859-1?Q?qHFIP9a4hZd2vfqlBLY4jU+BTDICKxmLjYdHxcI5vFJttxlzaDhPgDqhZF?= =?iso-8859-1?Q?oaV+2o8DxiIRKnGm23y5TUAWB54jt385qdIwi5o0RS33gVMQjYt62/xQ6b?= =?iso-8859-1?Q?sOmasc9hiFG1xD/QUcj+Y6jSYFiE2uW8oDk3C3ABYZyL6bB4lPM/zwH7j8?= =?iso-8859-1?Q?kOPJNMznMVNxLYhOli6aWmgaU6jLOE0zq5UATNYlMfZdCgTFIuLfA5YdIB?= =?iso-8859-1?Q?SB6oTGGeP9XRvI41h40FEDPL9fr2OTr9YH4icKqqw6vs9JxaDEw5j7CN0l?= =?iso-8859-1?Q?NQ63TB1tndH1Qm419E4q6uCPuQ38tkt5yOBeSvPTORz6yN22g21K1QeWO+?= =?iso-8859-1?Q?JVP3tCy3CwBurefDHmcnVcTZCbGJiIIGGjDavpYS7Nvz5xKoOPtq0CVb5p?= =?iso-8859-1?Q?Si/RyBTHUTZrLW8LNHorQ1AYSRPCPOxf4ATGWfnD6jm3WF9Q5vJQX7kgHa?= =?iso-8859-1?Q?wREuLUHVtLlFlqgy3UrvHuGi9UtZo5HjbToS7xiDfZNel61XqtWsWsdud1?= =?iso-8859-1?Q?xqcM5AkSpJb27VDTNTsE4ZCaYOHZJCv9dhN5NW6T+405MvtcRsa6wYA2ZQ?= =?iso-8859-1?Q?ArtLG/wDaeA5pxOcRbYTVVbPvSe8VafbGQSJtdbUwlD3kM0aN+pMNgUfNe?= =?iso-8859-1?Q?2Q4Kh/oDig=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: oR+A7bJKndutIxSUwpqYxMqTt/MiT0QHoB7GR2mcxcE4wzOT1DcwjZq4kl6ulpGzz8c41Z4VHFiRHuTows4j/NEugI8vxtuAUU0E+E6E0bwncM5eZtrJZGKviHq6X2eInODmTZqa9paHneuiM+SgL5bHd5Ev7wMKUDPIRmjgb1Ngo9lE5Sk0gKt/8lQjWyajq2Zx2uVzqG1kM2WKWvGNy13nrx6mhVCRdqwfvYtJsDACHh1snpnGPoMmgsZWie//IsOUHqMejS8BgajgYZ4Ja5AxAQRmnrtzHsxFjvVHXhcPzeNVhhuK4pYDTeNIMg4nmuyxD/7VnWQmjqX48300Pw== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYPPR06MB8206.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bcdf09b0-a1cc-4405-b934-08de99fbef1f X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2026 08:00:46.0819 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dzR30WLDgHZYm2LBI0nTNiqNd1LGHWhi6JPZkS5nJFin0egMJ+aygEGDOr+rFkJxsPBdPNg1urFpga86b2faHKqH8qJkUQiHe+cSaMm+j6A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI4PR06MB8423 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c405::5; envelope-from=jamin_lin@aspeedtech.com; helo=TYPPR03CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1776153736992154100 Content-Type: text/plain; charset="utf-8" Add a functional test to verify USB EHCI support on the AST2700 A2/A1 by attaching a USB keyboard device and checking its enumeration via lsusb. This introduces a helper routine that runs lsusb in the guest and validates that the emulated "QEMU USB Keyboard" is detected. Signed-off-by: Jamin Lin --- tests/functional/aarch64/test_aspeed_ast2700a1.py | 7 +++++++ tests/functional/aarch64/test_aspeed_ast2700a2.py | 7 +++++++ 2 files changed, 14 insertions(+) diff --git a/tests/functional/aarch64/test_aspeed_ast2700a1.py b/tests/func= tional/aarch64/test_aspeed_ast2700a1.py index b0c08854da..42b8b200cf 100755 --- a/tests/functional/aarch64/test_aspeed_ast2700a1.py +++ b/tests/functional/aarch64/test_aspeed_ast2700a1.py @@ -118,6 +118,11 @@ def do_ast2700_pcie_test(self): 'ip addr show dev eth2', 'inet 10.0.2.15/24') =20 + def do_ast2700_usb_ehci_test(self): + exec_command_and_wait_for_pattern(self, + 'lsusb', + 'QEMU QEMU USB Keyboard') + def start_ast2700_test(self, name, bus_id): num_cpu =3D 4 load_images_list =3D [ @@ -161,10 +166,12 @@ def test_aarch64_ast2700a1_evb_sdk_v11_01(self): self.archive_extract(self.ASSET_SDK_V1101_AST2700A1) self.vm.add_args('-device', 'e1000e,netdev=3Dnet1,bus=3Dpcie.2') self.vm.add_args('-netdev', 'user,id=3Dnet1') + self.vm.add_args('-device', 'usb-kbd,bus=3Dusb-bus.3') self.start_ast2700_test('ast2700-a1-image', 1) self.verify_openbmc_boot_and_login('ast2700-a1') self.do_ast2700_i2c_test(1) self.do_ast2700_pcie_test() + self.do_ast2700_usb_ehci_test() =20 def test_aarch64_ast2700a1_evb_sdk_vbootrom_v11_01(self): self.set_machine('ast2700a1-evb') diff --git a/tests/functional/aarch64/test_aspeed_ast2700a2.py b/tests/func= tional/aarch64/test_aspeed_ast2700a2.py index ed414999f4..40e0ad81ed 100755 --- a/tests/functional/aarch64/test_aspeed_ast2700a2.py +++ b/tests/functional/aarch64/test_aspeed_ast2700a2.py @@ -121,6 +121,11 @@ def do_ast2700_pcie_test(self): 'ip addr show dev eth2', 'inet 10.0.2.15/24') =20 + def do_ast2700_usb_ehci_test(self): + exec_command_and_wait_for_pattern(self, + 'lsusb', + 'QEMU QEMU USB Keyboard') + def start_ast2700_test(self, name, bus_id): num_cpu =3D 4 load_images_list =3D [ @@ -164,10 +169,12 @@ def test_aarch64_ast2700a2_evb_sdk_v11_01(self): self.archive_extract(self.ASSET_SDK_V1101_AST2700A2) self.vm.add_args('-device', 'e1000e,netdev=3Dnet1,bus=3Dpcie.2') self.vm.add_args('-netdev', 'user,id=3Dnet1') + self.vm.add_args('-device', 'usb-kbd,bus=3Dusb-bus.3') self.start_ast2700_test('ast2700-default-image', 1) self.verify_openbmc_boot_and_login('ast2700-default') self.do_ast2700_i2c_test(1) self.do_ast2700_pcie_test() + self.do_ast2700_usb_ehci_test() =20 def test_aarch64_ast2700a2_evb_sdk_vbootrom_v11_01(self): self.set_machine('ast2700a2-evb') --=20 2.43.0