From nobody Thu Apr 30 00:42:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1776084695; cv=none; d=zohomail.com; s=zohoarc; b=BPtl4VlxUujGAngeCRMdhdO1wydcgFVLjK7AgGrx/78jqPwZXMOgLahzo4oh1cTKMJ9kKN2W3quT3w7c3mEtnSXKmqenNCnwelUDP8GZTJKJVJFsu9G92B9SkqK+CeZKkDIL56AYrsepvH6OtOWfai1+GeqdyYQvhIBRzXSeVos= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776084695; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0rRDfMXaokWX4+ddlLtzyxWBCIzeGuZdGDY33wKrtzI=; b=B38EwDb81KCBrmZR+5h14rHyXaIH4CtrBTLp/mXuLLtNS9FBzZuju/ODiGxBgdRevTaUKyytlCSzAdAvQAVYjL6TusJWzPCwmkohoJ5fYLaRshoBA7krJxIWPREp/M0CJ0UB5Ghw6rMiv3EHtsG5iXMBIzdGR6l4NLVwWSITOwc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776084695169734.2480936395273; Mon, 13 Apr 2026 05:51:35 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wCGkk-0001Ss-IP; Mon, 13 Apr 2026 08:50:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCGki-0001Sd-A2 for qemu-devel@nongnu.org; Mon, 13 Apr 2026 08:50:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCGkg-0001FM-FE for qemu-devel@nongnu.org; Mon, 13 Apr 2026 08:50:56 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-304-WHhmkbQoMJmN3KLXy2rivg-1; Mon, 13 Apr 2026 08:50:47 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 23B331800365; Mon, 13 Apr 2026 12:50:46 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7C13C30001A1; Mon, 13 Apr 2026 12:50:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776084650; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0rRDfMXaokWX4+ddlLtzyxWBCIzeGuZdGDY33wKrtzI=; b=Yl1TzQDODpDVxC4hKtsnG43mwwOWpGfFm06YP8MJ6MhWE3jJABqcHSuMrwmkcDZ861PT6/ BLFiDN2LpiMO+t7RoKxGJpO2Kh42A1oa7enhFAe8xK7mIRFw8t90NTGTtvBC4Hv3Waq83i wCW+arR9LNFjns8urUhTynAeKQlL0dI= X-MC-Unique: WHhmkbQoMJmN3KLXy2rivg-1 X-Mimecast-MFC-AGG-ID: WHhmkbQoMJmN3KLXy2rivg_1776084646 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , Zhao Liu Subject: [PATCH] target/i386: fix strList leak in x86_cpu_get_unavailable_features Date: Mon, 13 Apr 2026 16:50:40 +0400 Message-ID: <20260413125040.3842686-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1776084697553154100 From: Marc-Andr=C3=A9 Lureau The result list built by x86_cpu_list_feature_names() was never freed after being visited, causing a memory leak detected by ASan. (the getter visitor is VISITOR_OUTPUT kind and doesn't own data) Fixes: 506174bf8219 ("i386: "unavailable-features" QOM property") Signed-off-by: Marc-Andr=C3=A9 Lureau --- target/i386/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index c6fd1dc00eb..9d126600c05 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -7842,6 +7842,7 @@ static void x86_cpu_get_unavailable_features(Object *= obj, Visitor *v, =20 x86_cpu_list_feature_names(xc->filtered_features, &result); visit_type_strList(v, "unavailable-features", &result, errp); + qapi_free_strList(result); } =20 /* Print all cpuid feature names in featureset --=20 2.53.0