From nobody Sat May 30 20:56:55 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1776003593; cv=none; d=zohomail.com; s=zohoarc; b=b7i97l1sMdqryt3kIuSb4UzSxsv8VbrcJpJJd5qgCI/lSxgMgvYkqaJlny5jquuWqmPO5VUaX/nX4rnzpuSy0GpqSCdcBlz/BBwl6k0PpruxLv1I2M/I4hdjGS4s8/tTBhjH+dO+GJiJsCB/+/I2KKY/thER9dCLrNzjqFmGGz8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776003593; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ArzLsLDSjc83muoLDyS1M+CRJjI1FneSSOb42Mz0oPY=; b=kYg6weU9DmVfi6wt3ET3pzdWKY7eObSLxjXh72ODxMmfpPBJR31gBK1Ejnx2O+H0BX1l9cgJjwRE1il9CwY/CimX/VHgtm+V7L1Ivx9/ohv3F3k0cGeYC7Krx2gyZAxcfA98Pqgh22atERioLLkxKJp1xEMUdv4hMDHL96aW5Gg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1776003593871145.5422933603095; Sun, 12 Apr 2026 07:19:53 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wBveW-0005Bm-Ll; Sun, 12 Apr 2026 10:19:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wBv34-0007b6-Bf for qemu-devel@nongnu.org; Sun, 12 Apr 2026 09:40:26 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wBv31-00051W-Qt for qemu-devel@nongnu.org; Sun, 12 Apr 2026 09:40:26 -0400 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-43cfd1f9fd1so2260551f8f.3 for ; Sun, 12 Apr 2026 06:40:23 -0700 (PDT) Received: from vle-arch (88-184-113-142.subs.proxad.net. [88.184.113.142]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d6ffd3880sm8713324f8f.7.2026.04.12.06.40.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Apr 2026 06:40:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776001222; x=1776606022; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ArzLsLDSjc83muoLDyS1M+CRJjI1FneSSOb42Mz0oPY=; b=N3jWnB5ux8pKIB21C7VnD/zN5WtnGisG2xBPXHgX0/ShW15fArJBlzoko+wwASQLQe +Zox5tpmJzsfLaNIg7yZOgmOgSbqdWkf6y5VWf/I5RY4f3oIWsRhS+FOt3YNIdxLHm0H mzGaRcwbCiZVSf95tdMGjzVgL24sWcxRRoeUYR0/1JyBZGgOd/4rcxNAowyPeFxUZ3HH VqYQxV3bFDE7MIAmNDJinhhe9qx5Q37jB8lLy/j7l7AztCFASCXESImK6B2+tc9dCTOP mwe6aJptGYqmL25KAAB05LPOq1PWbYszbTGjt+hsSChOrdnTu+208+pms5LZoCvi+7RQ Wejw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776001222; x=1776606022; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ArzLsLDSjc83muoLDyS1M+CRJjI1FneSSOb42Mz0oPY=; b=FnwdGQkDEXuMZcQeQ/4+X0yG4UUgJGq1OEkcasUCRXuAL5zrqzWmK7KJS2JQHH98bK KPlcss635pD3sLHTWAdhdpyTR048524ch3x7sNPpjQAF+QkrBvjWDIcaR3DBEnXEqD2X 5zGvep0DWo24WlUheOgOOfCxe9XJT6qjvsXQ64arzKUamKKYEhI2OIA+wl13Iq2qLxbL 8etWEJ7+F2zZ0O6fBpmLs+Ro5ron3bw160qmZMi67yC1bU5+BCQj9RmOwugtqczoFZ0s w5Vof8wCkj/QU4/JeG4cxXEffdMW08Y5QqsFwSQGGt4ZIGEKX37H3+zU+ttQ4WETCptI xrkg== X-Forwarded-Encrypted: i=1; AFNElJ8IvTCOfB3QVODlYTSMiEAIxOHGqu+v+p/ZVV70eGvR3T0N0xGshZ/L9CfiDPQgIeJJI598jiVgxU89@nongnu.org X-Gm-Message-State: AOJu0YxDfYg5ky/RI8bERRbQy5c95qgzINIrhN41Wjn4i635XGGn7u7f I6C+YxkBPJncaRpKe3RUWS57bvSBCfEt2T++lqBqTx+QNQE7Ffy0ms6j X-Gm-Gg: AeBDievbfikGItyqUX/K98LFxVCZRjLRQMGUAJDDthgtB2UpusL4pOxb2c43pCleS5M GhQqo5aqfVNyktbCe/v/OqZ2jww7HrdP6HoSKtcdqDf5GM53KAxl8AHUjenW/7eKGQIxZi1/Um4 7W0dO2/VhD062sXFrNGnZgDKdpQd36e8YM1asMAHrsSWw1v0HJ/FMTciipHaaGAOiMoFy3ZGJ3u RQvU/9yTHflTsQOcygMscEyxSwnb2qknLPXuX5NiqXjShF2g012nfjuO6xfFeuGs2C9Mu1KHs1u zRvFOROGvT5EXehl5A+CCnJ/BzuJQUfSfXywWAeHXykk+X5G3iJ4XYRn3IEuNb1LPlmTjxXwcTT cPADhvUd7AjsaiEfurkWzpg1ForK0Te2UWluPcR6cbLeqTIWIorLRg2hut4v4nyqkzjH8/orL06 sRAIk4YRVHlbbNsil22mmFb0dtCHVcnpeHHJskYhSnw3Cdg3bOyOpTvE2k/8Jhi6IGwMUnihatv KMYrrVr21PLjVpAze6n0bOmVn1H+daBGxQLOAs= X-Received: by 2002:a05:6000:2403:b0:43d:4b00:9ee7 with SMTP id ffacd0b85a97d-43d642d1b1cmr14406156f8f.33.1776001221475; Sun, 12 Apr 2026 06:40:21 -0700 (PDT) From: Vivien LEGER To: qemu-ppc@nongnu.org Cc: shentey@gmail.com, qemu-devel@nongnu.org, Vivien LEGER Subject: [PATCH] hw/net/fsl_etsec: implement RCTRL[CFA] FCS stripping on receive Date: Sun, 12 Apr 2026 15:40:16 +0200 Message-ID: <20260412134016.1640882-1-vivien.leger@gmail.com> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=vivien.leger@gmail.com; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sun, 12 Apr 2026 10:19:06 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1776003595339158500 Content-Type: text/plain; charset="utf-8" The eTSEC hardware strips the 4-byte FCS from received frames by default (RCTRL[CFA]=3D0). When CFA=3D1, FCS is copied to the application buffer and bd->length includes it. Previously QEMU always included FCS in bd->length regardless of CFA, causing guests using the default RCTRL to receive 4 extra bytes per frame, breaking protocols that validate frame length (e.g. ARP). Fix by subtracting 4 from bd->length when RCTRL[CFA]=3D0 (default). Signed-off-by: Vivien LEGER --- hw/net/fsl_etsec/registers.h | 1 + hw/net/fsl_etsec/rings.c | 10 ++++++++++ 2 files changed, 11 insertions(+) diff --git a/hw/net/fsl_etsec/registers.h b/hw/net/fsl_etsec/registers.h index f085537ecd..1766e39a1a 100644 --- a/hw/net/fsl_etsec/registers.h +++ b/hw/net/fsl_etsec/registers.h @@ -103,6 +103,7 @@ extern const eTSEC_Register_Definition eTSEC_registers_= def[]; #define RCTRL_PRSDEP_MASK (0x3) #define RCTRL_PRSDEP_OFFSET (6) #define RCTRL_RSF (1 << 2) +#define RCTRL_CFA (1 << 11) /* Copy FCS to application */ =20 /* Index of each register */ =20 diff --git a/hw/net/fsl_etsec/rings.c b/hw/net/fsl_etsec/rings.c index 22660c32b8..38e27ad6d8 100644 --- a/hw/net/fsl_etsec/rings.c +++ b/hw/net/fsl_etsec/rings.c @@ -442,6 +442,16 @@ static void fill_rx_bd(eTSEC *etsec, cpu_physical_memory_write(bufptr, padd, rem); } } + + /* Strip FCS unless RCTRL[CFA] requests copy to application. + * Per FSL eTSEC architecture (RCTRL field descriptions): + * CFA=3D0 (reset default): FCS is checked and discarded by hardware, + * bd->length should not include the 4-byte FCS. + * CFA=3D1: FCS is copied to the application buffer, bd->length includ= es FCS. + */ + if (!(etsec->regs[RCTRL].value & RCTRL_CFA) && bd->length >=3D 4) { + bd->length -=3D 4; + } } =20 static void rx_init_frame(eTSEC *etsec, const uint8_t *buf, size_t size) --=20 2.53.0