From nobody Sat Apr 11 13:59:05 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1775848819; cv=none; d=zohomail.com; s=zohoarc; b=hg/zMw+nm+szE2o8UUtJSSY5twKevqf3MGsafS1f7L04hY5G2d1nTqh5WQujlHm749SD+wX9+5+znd2x3kLztCpPI8lC7OFrWYLHbXwdBuWCMUvllbhwD5e5jP6ZQ6gzPHiu56/sDDVNN6kuUlmSA4fzIphjV8FFm7L/E1/brdk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1775848819; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=04H11uqkKPsmfZAF9wEtytacoQ7tjN07AWbO6BWGtZQ=; b=nKISKSmG8f4MXceaj3bMy6qaBGuUqpz9CBTl1vSYhwQKYeUNbZpRtqRqL3Vc3fqM8NfJT7zKgZsbgicG5xo4LBIj6VfF8aXO4iF/P6iGf+xgMZVXdoik6QTWdki8kx09Os1bCGLAQcGzIkLBf4dHDp5T6+uCniqLzY4ZHARgRF4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1775848819475264.84044328120444; Fri, 10 Apr 2026 12:20:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wBHOH-0002Vl-EU; Fri, 10 Apr 2026 15:19:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wBHOD-0002V7-Ct for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:19:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wBHOB-0000W2-JK for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:19:36 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-99-fVKq_1h7MVaasg-dBvEBhA-1; Fri, 10 Apr 2026 15:19:32 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E2D231955DB2 for ; Fri, 10 Apr 2026 19:19:29 +0000 (UTC) Received: from localhost (unknown [10.44.22.4]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D924719560AB; Fri, 10 Apr 2026 19:19:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775848774; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=04H11uqkKPsmfZAF9wEtytacoQ7tjN07AWbO6BWGtZQ=; b=izwaU7qv00AimSjYmRPOfdTAsfGB0jP6Z1TngTpDC5Cfn50QWmGRDFuVWf0oK7t8L2THHC pUo9RnZ+YdseNFrq4QEZeRIVLdQjXXM80LR+VwTjX2QzLLqUMB6JrYsST/7h3ZXa+SCIwD Y1eVTSxOXVagzHyQh0N4VFv1MkWH1M0= X-MC-Unique: fVKq_1h7MVaasg-dBvEBhA-1 X-Mimecast-MFC-AGG-ID: fVKq_1h7MVaasg-dBvEBhA_1775848770 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Fri, 10 Apr 2026 23:18:28 +0400 Subject: [PATCH v2 06/67] ui/vnc-jobs: narrow taking the queue lock MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260410-qemu-vnc-v2-6-231416f76dc3@redhat.com> References: <20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com> In-Reply-To: <20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com> To: qemu-devel@nongnu.org Cc: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1736; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=KoLQMmYbBIOnREXI2mU7J3ttjR2QtUJlnlZbP6oVDa0=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp2U0T/v09UM7pdXc1+Xyeo0y3ldzufWSAD/bAE pStwf3Y7mKJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCadlNEwAKCRDa6OEJdZac 5dsLD/4wlxZeF7b44RGF/ez3ZuSqSOgGM2VqPPFQNSlD/aDhaMu0+dlT0HBmCQ0wmQJ+yPStzjT on3fXdNe7u+P6yO0IFbfdX2HW9KBHlnjYFrrtBSzsmtzbg8xXyaAFKPNV2qFLJG/9reT64YdFfR K82pm0r1IkFZFVshVi9DDdjjICFBVJ8sSIllEjYzv2bBJ7VyW9N7IJ6pIq4fB1nxfXy8lydmvdJ Tf629AcZzJmvW3VtRnpj7zHEHebN9hcMx87+nfBnZxuhtKDzSZZ2VeoxE0Sm1f0tG/7+2VoqUZJ UE4IAO9H54SOMewWzPhJZKKaLS/fJukW3VWJg3lgtgDDTI4kkqmXehp/LFVuGRhG5J/aPEIb/T1 pr7Lm88rk0xy9bfEmU50apkY4HTd378IdM3AeDjttzZtEK3aWOMMpgDvwj0qkwZutx/GD0Jzm4G 7Z1DdyZd3eyC3NPYhXACLnNBMW7hmM1CrDAqElHdB8JtuCfz6ALP1dKTRzgp9I5scXAZIWqVlds xH6eUrYjsT4vCmKzB1uMTUXXuxQvq+sKuey3iXwhgPzJteaAAP5GGhOfMNYZ+91FmGcPD9h1AeL NnvUgKUujBUquMdLl7fl6uZywNzW0sMibl06TgfQIVwsGMRodfsKOgr3C41YIhjRHpwOyyz/SiM bguyrTUtLWpNRyg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 7 X-Spam_score: 0.7 X-Spam_bar: / X-Spam_report: (0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1775848820875158500 It's not needed unless manipulating the queue. Signed-off-by: Marc-Andr=C3=A9 Lureau --- ui/vnc-jobs.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c index 28a4738f1ec..9c17d684c9e 100644 --- a/ui/vnc-jobs.c +++ b/ui/vnc-jobs.c @@ -83,26 +83,26 @@ VncJob *vnc_job_new(VncState *vs) =20 assert(vs->magic =3D=3D VNC_MAGIC); job->vs =3D vs; - vnc_lock_queue(queue); QLIST_INIT(&job->rectangles); - vnc_unlock_queue(queue); return job; } =20 +/* + * Do not call this after pushing the job. + */ int vnc_job_add_rect(VncJob *job, int x, int y, int w, int h) { VncRectEntry *entry =3D g_new0(VncRectEntry, 1); =20 trace_vnc_job_add_rect(job->vs, job, x, y, w, h); + assert(!QTAILQ_IN_USE(job, next)); =20 entry->rect.x =3D x; entry->rect.y =3D y; entry->rect.w =3D w; entry->rect.h =3D h; =20 - vnc_lock_queue(queue); QLIST_INSERT_HEAD(&job->rectangles, entry, next); - vnc_unlock_queue(queue); return 1; } =20 @@ -120,16 +120,21 @@ static void vnc_job_free(VncJob *job) g_free(job); } =20 +/* + * Push a job onto the queue. Ownership of the job is transferred. + */ void vnc_job_push(VncJob *job) { - vnc_lock_queue(queue); + assert(!QTAILQ_IN_USE(job, next)); + if (QLIST_EMPTY(&job->rectangles)) { vnc_job_free(job); } else { + vnc_lock_queue(queue); QTAILQ_INSERT_TAIL(&queue->jobs, job, next); qemu_cond_broadcast(&queue->cond); + vnc_unlock_queue(queue); } - vnc_unlock_queue(queue); } =20 static bool vnc_has_job_locked(VncState *vs) --=20 2.53.0