From nobody Sat Apr 11 13:59:04 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1775848881; cv=none; d=zohomail.com; s=zohoarc; b=Yt+1Nv4XNc4K/CtmPYrhc6lqWf2S3ivFUfTNz/c+xO0/+CiIH2uGB2WliJuh9DFL/X7PnDHqBERM4uNOwPhDqkSFgKB/Gu46XS5xBe/bC0tia1zJhlZ1tCf6E1zLI6KXUhbe3bzFglY0+cmMVlr3CMh9XljtLHqceEF2CKEg66A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1775848881; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=35NB0NPv2qOWBVLdjvh0a4RCEHDwikxV3x+wq6dGcfw=; b=Py9hl1Aupm082TDruZ2NroLvyOTveYEQrsHgElxc2x4dpmxP6VCs9UebkTgx/GtFsey4jKY+aBRR8OWJtT4TYDEZeckrxtpU5C6lllpQ+RmEBYJetjuON5mF9OirBnhvJBXEpSZifLCrQ0OcxYu2gVBVG0Sbs5fFVxhVIBynJ44= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1775848881491187.0138024708317; Fri, 10 Apr 2026 12:21:21 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wBHPk-00062S-Qe; Fri, 10 Apr 2026 15:21:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wBHPU-0005N9-Ss for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:21:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wBHPQ-0001Q5-SB for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:20:55 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-681-nEzCD_YROImaoDvcWAUpFw-1; Fri, 10 Apr 2026 15:20:50 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 79AB8180044D; Fri, 10 Apr 2026 19:20:49 +0000 (UTC) Received: from localhost (unknown [10.44.22.4]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 46748180057F; Fri, 10 Apr 2026 19:20:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775848851; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=35NB0NPv2qOWBVLdjvh0a4RCEHDwikxV3x+wq6dGcfw=; b=NjWfm8TvlfVVLRDLeTO+ttXLaOixwvHJJmVP2XKFXF6MmcwICK1cvPjtxqNUdF2yn/7WNp u+5XuVKd6O9pfd2TPOOMLVT8oDs5Cp+hGlljzQbrAi120q3B+K0Ka66WUeHmH8Blg3kXvb vsDDr5xOc3usiC5uf+Oh5uiYylRLjNU= X-MC-Unique: nEzCD_YROImaoDvcWAUpFw-1 X-Mimecast-MFC-AGG-ID: nEzCD_YROImaoDvcWAUpFw_1775848849 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Fri, 10 Apr 2026 23:18:41 +0400 Subject: [PATCH v2 19/67] ui/console-vc: console_refresh() -> vt100_refresh() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260410-qemu-vnc-v2-19-231416f76dc3@redhat.com> References: <20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com> In-Reply-To: <20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com> To: qemu-devel@nongnu.org Cc: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1727; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=Alv36LrSEk9pffbsC7R8BXcgJH+s8HLIVfm8/6cC23I=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp2U0UTC5YnAx3mhJRtjWlIqasqVJDGZhAcwAaI +MFO5Xw9CCJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCadlNFAAKCRDa6OEJdZac 5aFEEACLRFsKMZr8qCaCwzt+QoEcPge1PEDuVs9OqT+ZcBrOsXsJfHQ/69gbwYBF7aI2x3MkQLf s4PWaUpME6JhZuDP5SDGAe+5saE/E11UR0YTk3cwzi7Nl6orGiRwlMfnwPpJc7IRuCmpO6v5YHj z8YGHYoWFwbqY/DgW62pVwXfxOoPl8qn7LAjLal/v+r0ir81BKLDAaZKBJecY9A6bE4d5goSCZF 5xmlXxXd6stNxu3xxpuGzf5dY+3lZQnIR3z87GFY7+aOMHKpoNRw3LyZ+jEXbv7WS1oZNsfGinC UZDFkLQbgOL/pQ7As7sSLM4SWFZZ9OeNzCuov74IwSrWvRcrtlU4a0x7eswfJf7J1eb5VryrE4/ lFgFqmlpB1JGw+m4BjxwOkGXU3uLIn1RVRxHRwMT9KZ6IAqKuGYh0Qzw1VM11lv+JuOS+TyZRPY u+ctXTFpSygNVevk8rLw2MHKdy/Vcz7myDcViwRRPUM9zbCMxprmQt5B8QrZlHo+SB9nR3jRNTs OcYM3xwcII7O7LJJTXlkNHWqRGvYz2fIhB2zIblYK8ErVkULURIohF+dwm9nIvKa+52fX9rg70K 20Bg9SsWRWMmuGf8b2j4JJvBNauw7ekAt/OUGrpv2U1oMQKT0Sh42AEgE7IaXz1F1ulsVq5LCx/ 0jyXfbQXrvaaouQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1775848883243158500 This decouples glyph rendering from the console object, continuing the QemuVT100 abstraction introduced in the previous commits. Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- ui/console-vc.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/ui/console-vc.c b/ui/console-vc.c index f8682d2d1dc..d46dcb6a678 100644 --- a/ui/console-vc.c +++ b/ui/console-vc.c @@ -232,9 +232,8 @@ static void vt100_image_update(QemuVT100 *vt, int x, in= t y, int width, int heigh vt->image_update(vt, x, y, width, height); } =20 -static void console_refresh(QemuTextConsole *s) +static void vt100_refresh(QemuVT100 *vt) { - QemuVT100 *vt =3D &s->vt; TextCell *c; int x, y, y1; int w =3D pixman_image_get_width(vt->image); @@ -260,8 +259,8 @@ static void console_refresh(QemuTextConsole *s) y1 =3D 0; } } - vt100_show_cursor(&s->vt, 1); - vt100_image_update(&s->vt, 0, 0, w, h); + vt100_show_cursor(vt, 1); + vt100_image_update(vt, 0, 0, w, h); } =20 static void console_scroll(QemuTextConsole *s, int ydelta) @@ -291,7 +290,7 @@ static void console_scroll(QemuTextConsole *s, int ydel= ta) vt->y_displayed =3D vt->total_height - 1; } } - console_refresh(s); + vt100_refresh(&s->vt); } =20 static void kbd_send_chars(QemuTextConsole *s) @@ -1127,7 +1126,7 @@ static void text_console_invalidate(void *opaque) if (!QEMU_IS_FIXED_TEXT_CONSOLE(s)) { text_console_resize(QEMU_TEXT_CONSOLE(s)); } - console_refresh(s); + vt100_refresh(&s->vt); } =20 static void --=20 2.53.0