From nobody Sat Apr 11 18:37:59 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1775667432; cv=none; d=zohomail.com; s=zohoarc; b=LQRxvi5UwSl6zfIYGswRFL3BW5MRejPsZz7Q4fRQQtsdNrYjSTckzjTNdNXlhms9MkG4BA8TPj0GlNWtvg17VQICX9YuNhw7EhSeTo47nYTrV/wMPqsYO3kN7H5lv4xIRMcv6WhWgdF3/cYwHB/od+WuDk3xt5vPKJ6eXUs0XlM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1775667432; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=vMp79kTswNcI5IIMHrzT1aaIDuja5B+32QTFFePbYkM=; b=ZHdM+6nBWtWsPm7fPmH5g3i+Sc0tYgeR2Az3UDC5N1cf6jLsP2yzgyti4ISZACEdVC8LfdIDxAxM1bBeeCRSqP5ZMdyRtlzl9BmX6k7S/GyIv15BFATxO1qTNMAAKgRXK2x6tlz/Vyiz0b3iu1NiDbmg1Y/eSmAWV39yGC2Yjug= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1775667432506578.9392121235039; Wed, 8 Apr 2026 09:57:12 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 7C280417FB; Wed, 8 Apr 2026 12:57:11 -0400 (EDT) Received: from [172.19.199.3] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id E3B56418B1; Wed, 8 Apr 2026 12:56:17 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id E30C3417E1; Wed, 8 Apr 2026 12:56:09 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 153E23F8B0 for ; Wed, 8 Apr 2026 12:56:07 -0400 (EDT) Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-93-bxDCY3f0PDO8uYLHr651ug-1; Wed, 08 Apr 2026 12:56:05 -0400 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8dacf883e77so30938685a.2 for ; Wed, 08 Apr 2026 09:56:05 -0700 (PDT) Received: from x1.com ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50d712c2617sm130491901cf.31.2026.04.08.09.56.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Apr 2026 09:56:03 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775667366; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vMp79kTswNcI5IIMHrzT1aaIDuja5B+32QTFFePbYkM=; b=hI1N/a1C3xPY+DPS1ku97dAzD+Jo2I0vJvoOuJ5DxvdZVFM9nURPrDC3GWHfjkDZZQKP6R 6h82X+jbeTF7HSZ6blT0B6Zih+3Ec62uqr7j6cJUPhvgUfIYj8a21e+1AulOa/USpVenxP pd9PSAxOQUEkhOgdqWT75FaAZPe9Cto= X-MC-Unique: bxDCY3f0PDO8uYLHr651ug-1 X-Mimecast-MFC-AGG-ID: bxDCY3f0PDO8uYLHr651ug_1775667365 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775667365; x=1776272165; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=vMp79kTswNcI5IIMHrzT1aaIDuja5B+32QTFFePbYkM=; b=TqHEHLPw+S1vGeoNy6WS1MMTVnaU4hu+BY91ttfgdHozbDxA11hBKlFWEKy7zHathH 4z65Jcc9ChUZUQxjwvmWcqfatvGDlXvqynLPusjtozsYrr+7q2Kn/cTDe3M0AagvOM/J oqOjjh7aD6QTUN1kRED1aiu+uVM8+vUN5Y21WORnaxrAHXpdM5K3r9MYK8yfuuMHdwSA 8T83GZyHMOMqF11AkzRJdt63t2q8gn0xy38GRc6eg8sO/3Dckkjdo63OauVqpnH0Nd5G SIkceOGzPPQ3gzlcNeSWJrQew+UErMe7Gs5KEdAojKY0wfHQLaRwcIT2vs0upyXPbDIv xhAg== X-Forwarded-Encrypted: i=1; AJvYcCXJYlPTlhrLqgZJl3IOw9IC+52ILOhVTvmp/EXdtXJuY8uJblgYRI9sCPpTdFV7pEZmdalvjQ==@lists.libvirt.org X-Gm-Message-State: AOJu0Yz417zbqOTF/8jQD9PMVN8EsUCv1V1QNcO7aEv6XWX0CheG6nrV 1HPHEiHTynPilhz4McFNBQpe7q/0WKmRKA/cuKox7j0LdVVPCfjMUaUPUFn6PmmjHva8kd5k480 3RG2WY7CSoZMU4vyHzMA3S0iH/5UrzDwrgU3+gMUVLQvOHo5P/4YlirKWrzc= X-Gm-Gg: AeBDiesI/G/zccoT6+fQUOdn52BHJLcQTdInAR6vtgvC0+dj6sv7CsB1p4ejHkQxmAC 2qHYNcmGQo40YXtgAUexxpaYKdvfPcxuhiZY2/DVlPAbgVul6ym07CtTnJDYws3hLQl+oLtSMUO Kmpxj6qN2vLTAGHE3rH3KrXgW7cLBvRbCH8fRN26AcTY5x3PtOgIjB5QJnSPkxblkQVye2qhQWI JEFkuInjWg4B8Yi53LEBWYLG6TTxMRcEHsgbXwbYvhuCBOvsbXQG/4SYwyOb9uiwAIUXt0aKgDd c4pMwAphwpHpEjGiw5KrRXbtBqPxO1qKjjrqkaTRtdaYgNOiN2oAc5tL3mmAO+q02puamT4nfJU v/jFcRVoALVJep5Ot6Rc4s5jwsxfo49Hd71IFiHKF1mzp X-Received: by 2002:ac8:5cd0:0:b0:50d:85c1:3616 with SMTP id d75a77b69052e-50dc2261277mr1108001cf.43.1775667364866; Wed, 08 Apr 2026 09:56:04 -0700 (PDT) X-Received: by 2002:ac8:5cd0:0:b0:50d:85c1:3616 with SMTP id d75a77b69052e-50dc2261277mr1107391cf.43.1775667364247; Wed, 08 Apr 2026 09:56:04 -0700 (PDT) To: qemu-devel@nongnu.org Subject: [PATCH 02/14] migration/qapi: Rename MigrationStats to MigrationRAMStats Date: Wed, 8 Apr 2026 12:55:46 -0400 Message-ID: <20260408165559.157108-3-peterx@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260408165559.157108-1-peterx@redhat.com> References: <20260408165559.157108-1-peterx@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 3i7jwa7vvZRCcz5V0ShDMtFQ6saihxjfVCEDyga0Zj4_1775667365 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: O2SFZMRZD5IKJMU74RZTPYUTVJIXJGLD X-Message-ID-Hash: O2SFZMRZD5IKJMU74RZTPYUTVJIXJGLD X-MailFrom: peterx@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: "Maciej S . Szmigiero" , Zhiyi Guo , Juraj Marcin , Peter Xu , Prasad Pandit , Avihai Horon , Kirti Wankhede , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Fabiano Rosas , Joao Martins , Markus Armbruster , Alex Williamson , devel@lists.libvirt.org X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Xu via Devel Reply-To: Peter Xu X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1775667435760154100 This stats is only about RAM, make it accurate. This paves way for statistics for all devices. Thanks to Markus, who pointed out that docs/devel/qapi-code-gen.rst has a section "Compatibility considerations" stated: Since type names are not visible in the Client JSON Protocol, types may be freely renamed. Even certain refactorings are invisible, such as splitting members from one type into a common base type. Hence this change is not ABI violation according to the document. While at it, touch up the lines to make it read better, correct the restriction on migration status being 'active' or 'completed': over time we grew too many new status that will also report "ram" section. Cc: Daniel P. Berrang=C3=A9 Cc: devel@lists.libvirt.org Reviewed-by: Markus Armbruster Signed-off-by: Peter Xu Reviewed-by: Juraj Marcin Reviewed-by: Michal Privoznik --- docs/about/removed-features.rst | 2 +- qapi/migration.json | 10 +++++----- migration/migration-stats.h | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.= rst index 557a24679a..ccd49b5615 100644 --- a/docs/about/removed-features.rst +++ b/docs/about/removed-features.rst @@ -699,7 +699,7 @@ was superseded by ``sections``. ``query-migrate`` return value member ``skipped`` (removed in 9.1) '''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' =20 -Member ``skipped`` of the ``MigrationStats`` struct hasn't been used +Member ``skipped`` of the ``MigrationRAMStats`` struct hasn't been used for more than 10 years. Removed with no replacement. =20 ``migrate`` command option ``inc`` (removed in 9.1) diff --git a/qapi/migration.json b/qapi/migration.json index 7134d4ce47..e3ad3f0604 100644 --- a/qapi/migration.json +++ b/qapi/migration.json @@ -12,7 +12,7 @@ { 'include': 'sockets.json' } =20 ## -# @MigrationStats: +# @MigrationRAMStats: # # Detailed migration status. # @@ -64,7 +64,7 @@ # # Since: 0.14 ## -{ 'struct': 'MigrationStats', +{ 'struct': 'MigrationRAMStats', 'data': {'transferred': 'int', 'remaining': 'int', 'total': 'int' , 'duplicate': 'int', 'normal': 'int', @@ -209,8 +209,8 @@ # If this field is not returned, no migration process has been # initiated # -# @ram: `MigrationStats` containing detailed migration status, only -# returned if status is 'active' or 'completed'(since 1.2) +# @ram: Detailed migration RAM statistics, only returned if migration +# is in progress or completed (since 1.2) # # @xbzrle-cache: `XBZRLECacheStats` containing detailed XBZRLE # migration statistics, only returned if XBZRLE feature is on and @@ -309,7 +309,7 @@ # Since: 0.14 ## { 'struct': 'MigrationInfo', - 'data': {'*status': 'MigrationStatus', '*ram': 'MigrationStats', + 'data': {'*status': 'MigrationStatus', '*ram': 'MigrationRAMStats', '*vfio': 'VfioStats', '*xbzrle-cache': 'XBZRLECacheStats', '*total-time': 'int', diff --git a/migration/migration-stats.h b/migration/migration-stats.h index c0f50144c9..1153520f7a 100644 --- a/migration/migration-stats.h +++ b/migration/migration-stats.h @@ -27,7 +27,7 @@ =20 /* * These are the ram migration statistic counters. It is loosely - * based on MigrationStats. + * based on MigrationRAMStats. */ typedef struct { /* --=20 2.53.0