From nobody Sat Apr 11 18:38:39 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1775676179; cv=none; d=zohomail.com; s=zohoarc; b=Jb8IuMf+WzWsda4GU/B9ttJDRRVfeGLAfKVjjqbC4TMfHm9DjvnyQfnIrmnWBaFXIX74GjigTXRiIGtlynoMYOHVRAYjWaNCSPPqPAX2GPi6mk2UJkOWva8evHJQSt1aXVeoPRjziZTt6uDRL9D4bx4RcC6VYgK653S1oEqgtDw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1775676179; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ezy+HD52UjJTkuVdmNzj0BC3WnJxDi0i97P4xBBU1cc=; b=RvZ0fSCTxSfXsHo837BU05BIf61HyaAfuerq4ogvQhthpzGFFi5nwk0WGdBJwAIaZenzUYe9vNXrqGhdD45oS+1yRURbCiJcPMPqTIRX6ystUyMI2aT4XPpqvZefZDDq+r1KcEdcKl9RZXsudPe3SS0gXm9ILyTFUm+92YBkcdA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1775676179826203.69276504964114; Wed, 8 Apr 2026 12:22:59 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wAYSj-0003lJ-Ro; Wed, 08 Apr 2026 15:21:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wAY3n-00064g-5s for qemu-devel@nongnu.org; Wed, 08 Apr 2026 14:55:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wANQQ-0001L4-Ne for qemu-devel@nongnu.org; Wed, 08 Apr 2026 03:34:13 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-219-yya9sPyDOU-g_yDcKveqMA-1; Wed, 08 Apr 2026 03:34:07 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DEAEE18005B9; Wed, 8 Apr 2026 07:34:05 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.44.49.216]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 65D261800673; Wed, 8 Apr 2026 07:34:05 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 1B2BD1800381; Wed, 08 Apr 2026 09:34:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775633648; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=ezy+HD52UjJTkuVdmNzj0BC3WnJxDi0i97P4xBBU1cc=; b=cQUHQCCCBzszEIsAfxKxszYsMAmjltZ8pkVI4wklxirXmCOtWPt+lio6vQIfllXCCZEuVH Y7i0SJiiRuORoBcibI3sEPOnE51S6nJC+hX3lGhiHyTcQm5jyuQUjuGvI/Z0cMsCD9Ra81 zqPoWxH9+tIrtJruBWCO1VHFb2C/GA0= X-MC-Unique: yya9sPyDOU-g_yDcKveqMA-1 X-Mimecast-MFC-AGG-ID: yya9sPyDOU-g_yDcKveqMA_1775633646 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , Yuma Kurogome Subject: [PATCH for 11.0] hw/uefi: fix heap overflow (CVE-2026-5744) Date: Wed, 8 Apr 2026 09:34:02 +0200 Message-ID: <20260408073403.3410541-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1775676180955158500 Content-Type: text/plain; charset="utf-8" When copying the request response into the pio transfer buffer the code skips the 'struct mm_header' but does not consider that when calculating transfer size, so it will copy 24 (=3D=3D sizeof(struct mm_header)) extra bytes, which can overflow uv->pio_xfer_buffer. Fix that by copying the complete buffer, including the header, which also makes the pio code path consistent with the (unaffected) dma code path. Fixes: CVE-2026-5744 Fixes: 90ca4e03c27d ("hw/uefi: add var-service-core.c") Reported-by: Yuma Kurogome Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrang=C3=A9 --- hw/uefi/var-service-core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/uefi/var-service-core.c b/hw/uefi/var-service-core.c index ce0628fa5248..68d7594c0dd6 100644 --- a/hw/uefi/var-service-core.c +++ b/hw/uefi/var-service-core.c @@ -137,9 +137,8 @@ static uint32_t uefi_vars_cmd_mm(uefi_vars_state *uv, b= ool dma_mode) uv->buffer, sizeof(*mhdr) + mhdr->length, MEMTXATTRS_UNSPECIFIED); } else { - memcpy(uv->pio_xfer_buffer + sizeof(*mhdr), - uv->buffer + sizeof(*mhdr), - sizeof(*mhdr) + mhdr->length); + memcpy(uv->pio_xfer_buffer, + uv->buffer, sizeof(*mhdr) + mhdr->length); } =20 return retval; --=20 2.53.0