From nobody Sat Apr 11 19:55:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1775676007; cv=none; d=zohomail.com; s=zohoarc; b=RrFcR/EAwiRvk7TofX9qFzgRO/1FzxY04Xww2DkQOPFs31e8wyA9JSEa6Q5uZTuYV+2Mku09u848FqZLKsDy47pK4f1RmBTVzUjQBQbmzPc2k6eIkbVNdcPqQUBqQeG85orgddw360MuM4aPqri6N/kbhdI0Jd92+J3fVfM7IoY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1775676007; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=fr3r1l7govQ0n2tgYo7tIfg3KvIKEMQ0pqpyUPHfVc8=; b=S41gLj1XcWF8TBH2QuiredB3xVMzKDMY4C8NjtbPqvLPXQkP4Cc8aDTSmMyif7w1bX2Rorm83Ctbevu+NvQRvqhlOPaeagEjvL/8+hSri7te8WPxdDUz/0+H41us25w+58/kR8fJLgrq4amw5HWk/dIqhfcUBN85w47Uls/gfa8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1775676007251784.0588736412682; Wed, 8 Apr 2026 12:20:07 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wAYKH-00038r-OO; Wed, 08 Apr 2026 15:12:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wAYIy-0007Je-5v for qemu-devel@nongnu.org; Wed, 08 Apr 2026 15:11:12 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wAKOm-0005Z5-A4 for qemu-devel@nongnu.org; Wed, 08 Apr 2026 00:20:18 -0400 Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 637J81dc3362677 for ; Wed, 8 Apr 2026 04:20:15 GMT Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dd7tkhexe-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 08 Apr 2026 04:20:14 +0000 (GMT) Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-2ba9a744f7dso8188875eec.0 for ; Tue, 07 Apr 2026 21:20:14 -0700 (PDT) Received: from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12c14a371b1sm6480362c88.13.2026.04.07.21.20.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 21:20:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fr3r1l7govQ0n2tgYo7tIfg3KvIKEMQ0pqpyUPHfVc8=; b=pD8uVQnGfLzRoYKj n06zRY9N/4780ZX1HU4Xnfslh97achh1026fk6inUT9dILEtexOgAhZjEys5xfEm BjHhI9ikFlBaG4RQ2Q65BbTQXi+DnBWQfjDWIH40vTvtAme4HLIkwNCEHuJG10J/ XtWw+/GLevwuEiehiO76iJvahH5QhKnszKrYv1nGYmfDL6ssrf9ORO/HpE0GkPFD 2F8VgUO9P3UgV8F6UFuv6u/NTT551/8RRvSCFkFuHWPYMYAmGTnOBfH/R3mtPGzZ QgUjDaV0heP9qxySBJ/zotb6IApJ8MjY6fScpp+KM4NxJPMOgM/QTpkD3fWRMes2 DXy96A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775622014; x=1776226814; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fr3r1l7govQ0n2tgYo7tIfg3KvIKEMQ0pqpyUPHfVc8=; b=Dy0sQR3QjDDbBXEJVNR5cEFG5MyM1RvMxbA0S0h29UtH33DdOW8KGeRrhMKybtsHPL ZenPkmG7sb9myHKRR/G558lEpwHQjBi68qdND8yVvbiDQnfK822mHgl/uohn5xcmnumg qs70n3Y0rp/LTj6dYpvd+yzTqiLKS6UKwoLIa4mbmNaUSTmBdTkubM3Ly7y2XvB3pwnY iehJ6CN0Ptcu0u+YYB3+yJ45rcPPzwgTjdXkE0pDu6L9N3cGWuXbkCzoble7KThOJKES 8Z2v0VRL9ODxPcykKc0csnOB+ZI4mq64yzQ6MJAnrO/uVJsLBhGDF5Lu4iKTQleXMoho 2RRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775622014; x=1776226814; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fr3r1l7govQ0n2tgYo7tIfg3KvIKEMQ0pqpyUPHfVc8=; b=HDADqoKi3THq2gNM3WuqNnFDXZNRpiKMDMFthZ524TPBUzi2XK8IYfw+1bp+8AEBa9 cu2GaIE22rL5hq0rfBYp+1EpbaC1xoH8ehuoVkLnr3nA+Jb+j/E9CNCq51M80jlT/kLo KywW+2V2JVSAmOh4Cs1eB0aL3wK2ZceMii3MPlgsK/m4UoqSU4jOxEx+jsOr5eDJNE8D /zoekYIYlKEtzVjl/vglimlOxmiEI23T1GIfBXPjonfZuzTKaj7c5vjPpjnYk4sUMP/7 JNgjfTH1D49/JNfzIv9MxOTimmIAzziq55bwC93cqJP6LzbkgKjmw/PAWEy2q4GnOW18 n/tA== X-Gm-Message-State: AOJu0Yx79e6zzV92UrY6hExPQe681U7z8Xo7ugmvxf+MsEeB5WQ4GYJb ZbA68ughPMHgUbnE4Lz3/cuJfvGDpcQLAn5/4ySE48AIEXTQbQvjSuGscqk6rg5lG9G7a41sEe4 LAiNThbeP3ZC9U/Gbbtkvb66RWVs1IaZkT2lcfYFvrQsZLW28YSqGQPviJ3A/ZZhaow== X-Gm-Gg: AeBDieuFLEvfa4DVDrTEP/4G3A1C3w4cIzpPaVaUdiOvdIEHFywCISkxbNkcSSgRw7h Sdjq1R5rAFoBb92MRbbV4xjAtAyF57Niwdd7SOBSOpxBZMy+QRM3i5xtaB26zDjU4mj3PTllmAZ g81RX3iH+NApnwz9Ld3B14wrD8HNwtWNPRmE/LmQO4awb4HRWA9q8YkbGZLvwIoMTvjIBeO1UQf 3+PbuaX4gyluzInv5LCzmAQgHhibYVkueeHVmuCchyOw+rwWBb1krIw4ANAQsGMlAdZhLJeMd2k wI9Kw4YMdT1uUj7Juhb/m3/kFXeZGEoLpvhypw6+o31wxbE68uM1nsKiFii2YhPZzRMwjbLnVfq ZIqKCp/xxv5W+79xvhunEJC+dXEv8Q5oggLKU5gOXP6h45MAz/RWRMlWh3t24YMFmrrcAYg== X-Received: by 2002:a05:7022:325:b0:12b:ebb9:1c0b with SMTP id a92af1059eb24-12bfb77ecedmr9784860c88.31.1775622014057; Tue, 07 Apr 2026 21:20:14 -0700 (PDT) X-Received: by 2002:a05:7022:325:b0:12b:ebb9:1c0b with SMTP id a92af1059eb24-12bfb77ecedmr9784840c88.31.1775622013502; Tue, 07 Apr 2026 21:20:13 -0700 (PDT) From: Brian Cain To: qemu-devel@nongnu.org Cc: brian.cain@oss.qualcomm.com, philmd@linaro.org, ltaylorsimpson@gmail.com, matheus.bernardino@oss.qualcomm.com, marco.liebel@oss.qualcomm.com, quic_mburton@quicinc.com, sid.manning@oss.qualcomm.com, ale@rev.ng, anjo@rev.ng, Brian Cain Subject: [PATCH v4 05/28] target/hexagon: Implement wait helper Date: Tue, 7 Apr 2026 21:19:30 -0700 Message-Id: <20260408041953.1899532-6-brian.cain@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260408041953.1899532-1-brian.cain@oss.qualcomm.com> References: <20260408041953.1899532-1-brian.cain@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=drPrzVg4 c=1 sm=1 tr=0 ts=69d5d77e cx=c_pps a=Uww141gWH0fZj/3QKPojxA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=COk6AnOGAAAA:8 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=UWtQ3YZIe0Xef7kIUYIA:9 a=QEXdDO2ut3YA:10 a=PxkB5W3o20Ba91AHUih5:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: mC-DEzHI51w1bzGme9gVkDUetycQ2t2G X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA4MDAzNiBTYWx0ZWRfX8LLNzwR6iNuV lkdHxfjs3cUmW1C8ZI+Hsvpxu8sZaaVMQKTP8HqzcEaI8U245K1SisEOYuXK7sZnOSrVRBA2VxL NjDHwtUbt/meERielFcKo6bLGSPFV772SJy67eZwwS5UyAcPmmUINym9IINmh6FPVTL2NcYifoZ YHu2iogVXQiDZR8yLnqSY3dH2j9DlfRqpVxFWYMfMn473bA3w3CozWUQVlF7CdhgY8zxSki6H6u 1aDLAA496+BfANozH4Ep9vE0eWFOTP7Mztf648TER1fk32NDoX1uRgE/if9V5Z8i7tpLESp4ACg cEmfRZWVhgEXStdbIWSr/HWDblM0y3q/iwAzCYTFIRvXCysxlF/UQyVKe4DVeseslYNG7fYlGei NMu2uDrd7Lszz3It66DenzCr/qna9fDG0CTwlLaGZFcTOUjBbEaxQpCwSuS5CYG7fdb+1UlIzrN Ti8iSlnmEY5kMG3FNUg== X-Proofpoint-GUID: mC-DEzHI51w1bzGme9gVkDUetycQ2t2G X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-08_02,2026-04-07_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 malwarescore=0 bulkscore=0 impostorscore=0 phishscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604080036 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=brian.cain@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1775676008002158500 From: Brian Cain Reviewed-by: Taylor Simpson Signed-off-by: Brian Cain --- target/hexagon/op_helper.c | 60 ++++++++++++++++++++++++++++++++++++-- 1 file changed, 58 insertions(+), 2 deletions(-) diff --git a/target/hexagon/op_helper.c b/target/hexagon/op_helper.c index 235c70f7370..d40061de06e 100644 --- a/target/hexagon/op_helper.c +++ b/target/hexagon/op_helper.c @@ -1486,9 +1486,65 @@ void HELPER(stop)(CPUHexagonState *env) hexagon_stop_thread(env); } =20 -void HELPER(wait)(CPUHexagonState *env, target_ulong PC) +static void set_wait_mode(CPUHexagonState *env) { - g_assert_not_reached(); + HexagonCPU *cpu; + uint32_t modectl; + uint32_t thread_wait_mask; + + g_assert(bql_locked()); + + cpu =3D env_archcpu(env); + if (!cpu->globalregs) { + return; + } + modectl =3D + hexagon_globalreg_read(cpu->globalregs, HEX_SREG_MODECTL, + env->threadId); + thread_wait_mask =3D GET_FIELD(MODECTL_W, modectl); + thread_wait_mask |=3D 0x1 << env->threadId; + SET_SYSTEM_FIELD(env, HEX_SREG_MODECTL, MODECTL_W, thread_wait_mask); +} + +static void hexagon_wait_thread(CPUHexagonState *env, uint32_t PC) +{ + CPUState *cs; + + g_assert(bql_locked()); + + if (qemu_loglevel_mask(LOG_GUEST_ERROR) && + (env->k0_lock_state !=3D HEX_LOCK_UNLOCKED || + env->tlb_lock_state !=3D HEX_LOCK_UNLOCKED)) { + qemu_log("WARNING: executing wait() with acquired lock" + "may lead to deadlock\n"); + } + g_assert(get_exe_mode(env) !=3D HEX_EXE_MODE_WAIT); + + cs =3D env_cpu(env); + /* + * The addtion of cpu_has_work is borrowed from arm's wfi helper + * and is critical for our stability + */ + if ((cs->exception_index !=3D HEX_EVENT_NONE) || + (cpu_has_work(cs))) { + qemu_log_mask(CPU_LOG_INT, + "%s: thread %" PRIu32 " skipping WAIT mode, have some work\n", + __func__, env->threadId); + return; + } + set_wait_mode(env); + env->wait_next_pc =3D PC + 4; + + cpu_interrupt(cs, CPU_INTERRUPT_HALT); +} + +void HELPER(wait)(CPUHexagonState *env, uint32_t PC) +{ + BQL_LOCK_GUARD(); + + if (!fIN_DEBUG_MODE(env->threadId)) { + hexagon_wait_thread(env, PC); + } } =20 void HELPER(resume)(CPUHexagonState *env, uint32_t mask) --=20 2.34.1