From nobody Sat Apr 11 19:55:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1775676585; cv=none; d=zohomail.com; s=zohoarc; b=DK8j3mpSLYGFcY+df4cqtEgViK0U+3M8DQ2WoDM5AguWoHgwIQsL9BWWji3kt63xi0L03OiEUQqRadWPQZ/Wd/yjqqyvvBltscmXJVAxwJAmm7ZETMNW9rGPcjIkbOqsRxfGhsyrS2vx5Gvwolp+yqDuVBG1l5iANEAIJrW+Q9Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1775676585; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=JqirgD+TEHIoit8jv61QYAnhXe1FLYRvtuwMXQLWLDk=; b=ibirLALkekOHVCgXijyvUyiw84y6I6AkkQvxcTTbQV1ccQdZTxoj5iyS0Kbh3VK9VVR0oAOixQrYsctH9HKJf8jBCLXnI6TvKKvq49i+Fk12L0dUQO/pGHuH0m9g1RnjvP+92wAb05U4hoFjjTcj+y0Hn4yqfgFTzuB4ALWAfKs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1775676585212878.5437363411638; Wed, 8 Apr 2026 12:29:45 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wAYWW-0007It-45; Wed, 08 Apr 2026 15:25:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wAY6y-0007Q7-Ur for qemu-devel@nongnu.org; Wed, 08 Apr 2026 14:58:48 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wAKPG-0005cQ-RJ for qemu-devel@nongnu.org; Wed, 08 Apr 2026 00:20:54 -0400 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 637M3Luv1619750 for ; Wed, 8 Apr 2026 04:20:36 GMT Received: from mail-dl1-f69.google.com (mail-dl1-f69.google.com [74.125.82.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ddacrgxjm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 08 Apr 2026 04:20:34 +0000 (GMT) Received: by mail-dl1-f69.google.com with SMTP id a92af1059eb24-12734af2ca4so504755c88.0 for ; Tue, 07 Apr 2026 21:20:34 -0700 (PDT) Received: from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12c14a371b1sm6480362c88.13.2026.04.07.21.20.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 21:20:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= JqirgD+TEHIoit8jv61QYAnhXe1FLYRvtuwMXQLWLDk=; b=a9iW065r4oupQxAM kOjYKtMgLZELLNshgjHIGKOeecDaVOJmtZc54FJ8HRWfTRDjtJTMVRWU1nrzzDv1 cLyPkEeO76OMzTBOMNk+sTYQLYvWti7YcvOe+tt7oRlzDaZXOaXs1WNRCE9Y+Mt2 G+C3fzTOpxw3GQ/z6p0ni6VVc97OZejmyOUxgtpqfKP4t7cWpSBB8/f4oIMosM8S b9QS6Gs5vzCN8DYdU/L0mYQS60rQawxRRkOH6VB2MDTBhUUzDqpJ6Ry07wAYNRIC Vbrs54+ouEeN8VZcyWGaOZJDBEnGOYyqoeXqxeDZnkVh432Pbbcd+CWeT7WlpuFI 9H4Mrw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775622034; x=1776226834; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JqirgD+TEHIoit8jv61QYAnhXe1FLYRvtuwMXQLWLDk=; b=eGmhiKWCLTcYohks8bjykFa9AXKLSsucCAHV9VfHE7Fij2KO83bBUtYnm2txTtRs0+ gyieQv/yjZWDiLvlGe28JAe8PgTeNXlGsamXcv1Y4t66ueCigEWXxtO+MOlBafCeKumX apSmBYYaIdZtxfQ7Sb8VkqsLrBohGy47HdwrrEmL/g9DNZQ7nLNFnlegB4pcaouN82J3 fbKfpeEXX0YXlXQw70OayTWHupQA3MVHSyEARgJqw0XVKGaYrdnOd7IHlDq+2N9rsver P9ZAGgtNcBmVcoXXLbsdIOXWpaZSBR0r5Rxx4jQrgXOyxHoZJsAnv+VmyofDbEUes4sI qvwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775622034; x=1776226834; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=JqirgD+TEHIoit8jv61QYAnhXe1FLYRvtuwMXQLWLDk=; b=UwhiDxjQynkaDH0KKr1nIYIMAtKOtxYgySfnx9Oaue1a+edouikwGXZh1n9VGvLYHt koxWrOHRytKKa7AWmTYroh2h9vq4ZIzlufYozcevZZNtpqkA3DpOT3sNp186ROEyXKE/ 6dIG0Z+OnvFk+d8+zetXttjv/ohQ61keXGJMsESiywcVxi23zOXng/7zVC2Vpk3AN5ru xQff76N76smi7zUP3ujv5wme5cqmsMKJEWOls/eVOpvmpYBh5D+PmPJmDX4eyHyfTLqx o05LYEpQTOCqgOs7Zfdd6B9enqoEni/hvsETwUAgxAa19zGdGkCpzpEmiJuiby9X75NR U4ZQ== X-Gm-Message-State: AOJu0YyelsggCmZT/N1xE4kgK+rhJ5MVCTuFS5+7mwU5/GfufnBm7+yh pM5hTB0HWy8wJf8SYhvfVDVO/igocZuNM86efdyplVtAf9jLBoNpteX2+qetoXJiNOqNpbS5bCO y6XAQSusMza5c3nb3ta3QtgUkeq7AtTwIdXB0JCQRAdLxoRUXhIEAl+RF2Ado1mcDQA== X-Gm-Gg: AeBDieufPeou9ijcCKH2M1WB0Le5oBRJErYbOPWgmYDuvHhysRGINas5b7UI0Tu9dDm 3Pvyti8WZukN4rNPTQNlNeLl2Xg1Vg/2HREFxqN87NpIxlfZwlqFD31yF6N1o+5vEYx0iJm3sq7 HtOPTEtxyAI3QAL2hJKmrVoKYXLBhBLn5LbHCKUeGarqESJXggO1DrYK7WPIWMS3RJwSWKrOMqE GuppCQjM2IjbM+dJcJOz8+ehEB02DNmrpxetlZQg8G+T1YpRS3LNz+//0tvVomxgToc65/v1QYo 3mJR3je5/tXTjeSVOA+OT5M89cy3YwoF3cRzf0WIklF4PUjVvZAYlyg/V9On4Y0AspHTWR+wnkZ NVCgJFVtACPZJ1Gd0Tg+ZtK9La57hGUjhL+S0fHbm0O3CnPrU0GBY6eJXdjHVrfk2TcQ0+Q== X-Received: by 2002:a05:7022:628b:b0:11f:1e5b:2dd6 with SMTP id a92af1059eb24-12bf08803c9mr10028687c88.17.1775622033740; Tue, 07 Apr 2026 21:20:33 -0700 (PDT) X-Received: by 2002:a05:7022:628b:b0:11f:1e5b:2dd6 with SMTP id a92af1059eb24-12bf08803c9mr10028672c88.17.1775622033151; Tue, 07 Apr 2026 21:20:33 -0700 (PDT) From: Brian Cain To: qemu-devel@nongnu.org Cc: brian.cain@oss.qualcomm.com, philmd@linaro.org, ltaylorsimpson@gmail.com, matheus.bernardino@oss.qualcomm.com, marco.liebel@oss.qualcomm.com, quic_mburton@quicinc.com, sid.manning@oss.qualcomm.com, ale@rev.ng, anjo@rev.ng, Brian Cain Subject: [PATCH v4 24/28] target/hexagon: Add k0 {un,}lock Date: Tue, 7 Apr 2026 21:19:49 -0700 Message-Id: <20260408041953.1899532-25-brian.cain@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260408041953.1899532-1-brian.cain@oss.qualcomm.com> References: <20260408041953.1899532-1-brian.cain@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: LWjpB9bFz6rygdDciHRf8MgLwsZjEd_l X-Proofpoint-GUID: LWjpB9bFz6rygdDciHRf8MgLwsZjEd_l X-Authority-Analysis: v=2.4 cv=WZs8rUhX c=1 sm=1 tr=0 ts=69d5d792 cx=c_pps a=kVLUcbK0zfr7ocalXnG1qA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=COk6AnOGAAAA:8 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=5qM_0fsqfvQKBOMFAjMA:9 a=QEXdDO2ut3YA:10 a=vr4QvYf-bLy2KjpDp97w:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA4MDAzNiBTYWx0ZWRfX80+txtDBbVDU AsUbAXNvgsJwauTpOZkQXm6LiGOhKToRV/gh0weIRFTyTZ+hd1e6+HVRLTtAOit/758dU3ueQrs IGgextJj1kKya+U4uU1nqHAGqDG1njdMO1CQemMcFT3O7I2JIGkRsWP3DcDqzsuyTJ2I3nRSwk2 cwCJa7LDH/mnp0XWuO8xtqJtD3N2OMrderMVEYM6nKRmZ/w7NTd/uH207YmkvoEf6u1vSEgZCtG AfgOpbsWbVonhxsUUF9dFTd3GMheHkNFj3CUwg6tFrgNqHkwRycs6ZX0BTXKoS/DGAQmKHz4imb Lrt+k6jnU3VFLWury6JblRJu7wDnUuLA5mwUcUH5BcMSW66Hx7r5maZ/2aXCruPcvoNzZSrGVf/ GDL4GfoHgwe2o6KZyReV3Up39VS9Uv8ociwycXUQS9AwvgAP3MIQQ5aT1rVh0UOJr4iRw9qRUrq /MRyJhGZbNyyhGl2AAQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-08_02,2026-04-07_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 adultscore=0 phishscore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604080036 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=brian.cain@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1775676587045154100 From: Brian Cain Reviewed-by: Taylor Simpson Signed-off-by: Brian Cain --- target/hexagon/sys_macros.h | 3 + target/hexagon/op_helper.c | 119 ++++++++++++++++++++++++++++++++++++ 2 files changed, 122 insertions(+) diff --git a/target/hexagon/sys_macros.h b/target/hexagon/sys_macros.h index cbc857fa2f5..37aae71adce 100644 --- a/target/hexagon/sys_macros.h +++ b/target/hexagon/sys_macros.h @@ -146,6 +146,9 @@ #define fSET_TLB_LOCK() hex_tlb_lock(env); #define fCLEAR_TLB_LOCK() hex_tlb_unlock(env); =20 +#define fSET_K0_LOCK() hex_k0_lock(env); +#define fCLEAR_K0_LOCK() hex_k0_unlock(env); + #define fTLB_IDXMASK(INDEX) \ ((INDEX) & (fPOW2_ROUNDUP( \ fCAST4u(hexagon_tlb_get_num_entries(env_archcpu(env)->tlb))) - 1)) diff --git a/target/hexagon/op_helper.c b/target/hexagon/op_helper.c index 26d32ab9d47..aeea4715372 100644 --- a/target/hexagon/op_helper.c +++ b/target/hexagon/op_helper.c @@ -36,6 +36,9 @@ #include "cpu_helper.h" #include "translate.h" #ifndef CONFIG_USER_ONLY +#include "hw/hexagon/hexagon_globalreg.h" +#include "hex_mmu.h" +#include "hw/hexagon/hexagon_tlb.h" #include "hex_interrupts.h" #include "hexswi.h" #endif @@ -1232,6 +1235,122 @@ void HELPER(modify_ssr)(CPUHexagonState *env, uint3= 2_t new, uint32_t old) BQL_LOCK_GUARD(); hexagon_modify_ssr(env, new, old); } + +static void hex_k0_lock(CPUHexagonState *env) +{ + HexagonCPU *cpu =3D env_archcpu(env); + CPUState *cs =3D env_cpu(env); + target_ulong syscfg; + + BQL_LOCK_GUARD(); + g_assert((env->k0_lock_count =3D=3D 0) || (env->k0_lock_count =3D=3D 1= )); + + syscfg =3D cpu->globalregs ? + hexagon_globalreg_read(cpu->globalregs, HEX_SREG_SYSCFG, + env->threadId) : 0; + if (GET_SYSCFG_FIELD(SYSCFG_K0LOCK, syscfg)) { + if (env->k0_lock_state =3D=3D HEX_LOCK_QUEUED) { + env->next_PC +=3D 4; + env->k0_lock_count++; + env->k0_lock_state =3D HEX_LOCK_OWNER; + SET_SYSCFG_FIELD(env, SYSCFG_K0LOCK, 1); + return; + } + if (env->k0_lock_state =3D=3D HEX_LOCK_OWNER) { + qemu_log_mask(LOG_GUEST_ERROR, + "Double k0lock at PC: 0x%" PRIx32 + ", thread may hang\n", + env->next_PC); + env->next_PC +=3D 4; + cpu_interrupt(cs, CPU_INTERRUPT_HALT); + cpu_loop_exit(cs); + return; + } + env->k0_lock_state =3D HEX_LOCK_WAITING; + cpu_interrupt(cs, CPU_INTERRUPT_HALT); + cpu_loop_exit(cs); + } else { + env->next_PC +=3D 4; + env->k0_lock_count++; + env->k0_lock_state =3D HEX_LOCK_OWNER; + SET_SYSCFG_FIELD(env, SYSCFG_K0LOCK, 1); + } +} + +static void hex_k0_unlock(CPUHexagonState *env) +{ + HexagonCPU *cpu =3D env_archcpu(env); + unsigned int this_threadId =3D env->threadId; + CPUHexagonState *unlock_thread =3D NULL; + CPUState *cs; + target_ulong syscfg; + + BQL_LOCK_GUARD(); + g_assert((env->k0_lock_count =3D=3D 0) || (env->k0_lock_count =3D=3D 1= )); + + /* Nothing to do if the k0 isn't locked by this thread */ + syscfg =3D cpu->globalregs ? + hexagon_globalreg_read(cpu->globalregs, HEX_SREG_SYSCFG, + env->threadId) : 0; + if ((GET_SYSCFG_FIELD(SYSCFG_K0LOCK, syscfg) =3D=3D 0) || + (env->k0_lock_state !=3D HEX_LOCK_OWNER)) { + qemu_log_mask(LOG_GUEST_ERROR, + "thread %" PRIu32 " attempted to unlock k0 without" + " having the lock, k0_lock state =3D %d," + " syscfg:k0 =3D %" PRIu32 "\n", + env->threadId, env->k0_lock_state, + (uint32_t)GET_SYSCFG_FIELD(SYSCFG_K0LOCK, syscfg)); + g_assert(env->k0_lock_state !=3D HEX_LOCK_WAITING); + return; + } + + env->k0_lock_count--; + env->k0_lock_state =3D HEX_LOCK_UNLOCKED; + SET_SYSCFG_FIELD(env, SYSCFG_K0LOCK, 0); + + /* Look for a thread to unlock */ + CPU_FOREACH(cs) { + CPUHexagonState *thread =3D cpu_env(cs); + + /* + * The hardware implements round-robin fairness, so we look for th= reads + * starting at env->threadId + 1 and incrementing modulo the numbe= r of + * threads. + * + * To implement this, we check if thread is a earlier in the modulo + * sequence than unlock_thread. + * if unlock thread is higher than this thread + * thread must be between this thread and unlock_thread + * else + * thread higher than this thread is ahead of unlock_thread + * thread must be lower then unlock thread + */ + if (thread->k0_lock_state =3D=3D HEX_LOCK_WAITING) { + if (!unlock_thread) { + unlock_thread =3D thread; + } else if (unlock_thread->threadId > this_threadId) { + if (this_threadId < thread->threadId && + thread->threadId < unlock_thread->threadId) { + unlock_thread =3D thread; + } + } else { + if (thread->threadId > this_threadId) { + unlock_thread =3D thread; + } + if (thread->threadId < unlock_thread->threadId) { + unlock_thread =3D thread; + } + } + } + } + if (unlock_thread) { + cs =3D env_cpu(unlock_thread); + unlock_thread->k0_lock_state =3D HEX_LOCK_QUEUED; + SET_SYSCFG_FIELD(unlock_thread, SYSCFG_K0LOCK, 1); + cpu_interrupt(cs, CPU_INTERRUPT_K0_UNLOCK); + } + +} #endif =20 =20 --=20 2.34.1